Timeline

Feb 3, 2012:

10:43 PM Changeset in webkit [106729] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Canvas-into-canvas drawing should respect backing store scale ratio
​https://bugs.webkit.org/show_bug.cgi?id=77784
<rdar://problem/10549729>

Reviewed by Dan Bernstein.

Respect the backing store scale ratio when drawing a canvas into another
canvas via ctx.drawImage(canvas, x, y). Previous behavior caused canvas
drawing to differ based on the size of the backing store, which is ideally
an implementation detail to authors.

Also, rename the source canvas arguments to CanvasRenderingContext2D::drawImage
to be more clear.

No new tests.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

8:45 PM Changeset in webkit [106728] by abarth@webkit.org

• 2 edits
  1 add
  1 delete in trunk/LayoutTests

Add a Chromium-specific baseline for this test. These results appear to be passing.

• platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt: Removed.
• platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Added.
• platform/chromium/test_expectations.txt:

7:59 PM Changeset in webkit [106727] by abarth@webkit.org

• 5 edits in trunk/Tools

List of all failures in garden-o-matic should actually list all the failures
​https://bugs.webkit.org/show_bug.cgi?id=77796

Reviewed by Eric Seidel.

This patch wires a bit more data into the new "All Failures" tab. I've
also iterated on how we enable this experimental feature. The tab is
still just a dumb list, but we'll make it smarter.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:

7:50 PM Changeset in webkit [106726] by rniwa@webkit.org

• 2 edits in trunk/Tools

Windows build fix after r106692.

• Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_reference_files):

6:01 PM Changeset in webkit [106725] by Beth Dakin

• 4 edits
  3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=77782
WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
once on some pages with frames
-and corresponding-
<rdar://problem/10798474>

Reviewed by Sam Weinig.

Source/WebCore:

startCountingRelevantRepaintedObjects() should only be called for the main
frame. Otherwise, the counter will be re-set inappropriately, and
didNewFirstVisuallyNonEmptyLayout may even end up firing more than once.

• page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

Tools:

One new test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):

• TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.

5:59 PM Changeset in webkit [106724] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

Reduce the memory allocations of WebCore's cssPropertyName()
​https://bugs.webkit.org/show_bug.cgi?id=74782

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-03
Reviewed by Geoffrey Garen.

Add a fast path to avoid the use of the StringBuilder.

The string builder is needed for two cases:
-CSS prefix (the character after the prefix must be uppercase)
-JavaScript CamelCase name for CSS properties

We can skip all memory allocations if the property is not in those
two cases. We start by testing the string for uppercase characters,
and just return the an identical string.

This patch create a "fast case" 2.7 times faster than previously.
The "slow case" is 2-3% slower due to the additional check at the beginning.

• bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore):
(WebCore::containsASCIIUpperChar):
(WebCore::cssPropertyName):
(WebCore::isCSSPropertyName):

5:56 PM Changeset in webkit [106723] by andersca@apple.com

• 9 edits in trunk/Source

WebKit2 should dispatch wheel events to the new ScrollingTree class
​https://bugs.webkit.org/show_bug.cgi?id=77795

Reviewed by Andreas Kling.

Source/WebCore:

• WebCore.exp.in:

Add new symbols needed by WebKit2.

• WebCore.xcodeproj/project.pbxproj:

Make ScrollingTree.h private so it can be included by WebKit2.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollingTree):

• page/scrolling/ScrollingCoordinator.h:

Add a scrolling tree getter.

Source/WebKit2:

Replace all uses of ScrollingCoordinator with ScrollingTree instead.
Also, don't try to handle gesture events on the scrolling thread anymore;
we don't need to to that right now.

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

• WebProcess/WebPage/EventDispatcher.h:

(WebCore):
(EventDispatcher):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):

5:45 PM Changeset in webkit [106722] by dslomov@google.com

• 2 edits in trunk/Source/WebCore

[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
​https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

• bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

5:41 PM Changeset in webkit [106721] by dpranke@chromium.org

• 12 edits in trunk/Tools

webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
​https://bugs.webkit.org/show_bug.cgi?id=77781

Reviewed by Eric Seidel.

This change fixes a couple of issues discovered while debugging
test-webkitpy; both calling exit() instead of sys.exit() --
which is discouraged in program code instead of the interpreter
-- and a particular usage of outputcapture were stdin to get whacked
and preventing debugging.

This change introduces a couple of common _exit() methods that
will standardize how webkit-patch exit's, in case we need to do
something different in the future.

• Scripts/webkitpy/common/system/deprecated_logging.py:

(error):

• Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.assert_outputs):

• Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.exit_after_handled_error):

• Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand.execute):

• Scripts/webkitpy/tool/commands/queues.py:

(StyleQueue.handle_script_error):

• Scripts/webkitpy/tool/commands/upload.py:

(MarkBugFixed.execute):

• Scripts/webkitpy/tool/multicommandtool.py:

(Command._exit):

• Scripts/webkitpy/tool/steps/abstractstep.py:

(AbstractStep._exit):

• Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

• Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

• Scripts/webkitpy/tool/steps/confirmdiff.py:

(ConfirmDiff.run):

5:33 PM Changeset in webkit [106720] by andersca@apple.com

• 6 edits in trunk/Source/WebCore

The scrolling tree should be able to handle wheel events
​https://bugs.webkit.org/show_bug.cgi?id=77794

Reviewed by Andreas Kling.

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::tryToHandleWheelEvent):
New function. Currently this always returns that it was able to handle the wheel event,
but this will change in the future.

(WebCore::ScrollingTree::handleWheelEvent):
Ask the root node to handle the wheel event.

• page/scrolling/ScrollingTreeNode.h:

Add a handleWheelEvent pure virtual member function.

• page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
Call scrollBy for now. Eventually this should use a scroll elasticity controller to handle
things like rubber-banding.

(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Add getters and setters for the scroll position.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Update the scroll position given the offset.

5:32 PM Changeset in webkit [106719] by Lucas Forschler

• 1 edit in trunk/Tools/Scripts/update-webkit-dependency

buildbot fix for curl.

5:30 PM Changeset in webkit [106718] by vangelis@chromium.org

• 1 edit
  2 copies in branches/chromium/1025

Merge 106672 - REGRESSION (r105401-105403): Blue flash on css border transition
​https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

• platform/animation/AnimationUtilities.h:

(WebCore::blend):

LayoutTests:

• animations/animation-border-overflow-expected.txt: Added.
• animations/animation-border-overflow.html: Added.

TBR=​alexis.menard@openbossa.org
Review URL: ​https://chromiumcodereview.appspot.com/9328025

5:29 PM Changeset in webkit [106717] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

[WK2 Mac] No need to allow access to input methods or keyboard layouts
​https://bugs.webkit.org/show_bug.cgi?id=77775
<rdar://problem/9276253>
<rdar://problem/9276268>

Reviewed by Dan Bernstein.

• WebProcess/com.apple.WebProcess.sb: These rules were likely only necessary in early days

of WebKit2. If there are cases when this happens, that's likely wrong, and we need to know
about that.

5:26 PM Changeset in webkit [106716] by Lucas Forschler

• 1 edit in trunk/Tools/Scripts/update-webkit-dependency

Another http -> https fix for curl

5:22 PM Changeset in webkit [106715] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Crash in Node::dispatchSubtreeModifiedEvent
​https://bugs.webkit.org/show_bug.cgi?id=77449

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by appendChild not retaining this pointer.
This is normally okay because there's another owner within JSC/V8 binding code that
holds onto the node but this isn't the case when nodes are created as a part
of setting document.title. Fixed the crash by retaining the pointer as needed.

Test: fast/dom/remove-body-during-title-creation.html

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::appendChild):

LayoutTests:

Add a regression test for the crash.

• fast/dom/remove-body-during-title-creation-expected.txt: Added.
• fast/dom/remove-body-during-title-creation.html: Added.

5:19 PM Changeset in webkit [106714] by rniwa@webkit.org

• 2 edits in trunk/Tools

Perf bot build fix.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_json):

5:18 PM Changeset in webkit [106713] by abarth@webkit.org

• 6 edits in trunk/Tools

Add a blank "Expected Failures" tab to garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=77793

Reviewed by Eric Seidel.

This tab will help us explore and manage our expected failures. The
tab is hidden by default via a new "experimental features" flag.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#unexpected):
(#onebar.partytime #unexpected):

5:09 PM Changeset in webkit [106712] by Lucas Forschler

• 2 edits in trunk/Tools/Scripts

Fix other instances of ​http://developer links which should be ​https://developer

5:05 PM Changeset in webkit [106711] by andersca@apple.com

• 6 edits in trunk/Source/WebCore

Apply changed properties from the updated scrolling tree state
​https://bugs.webkit.org/show_bug.cgi?id=77792

Reviewed by Andreas Kling.

• page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::update):
Update the tree node properties from the scrolling tree state.

• page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::scrollingTree):
(WebCore::ScrollingTreeNode::viewportRect):
(WebCore::ScrollingTreeNode::contentsSize):
Add getters.

• page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::changedProperties):
New function for accessing the changed properties of the scrolling tree state.

• page/scrolling/mac/ScrollingTreeNodeMac.h:
• page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Update the scroll layer from the scrolling tree if necessary.

4:57 PM Changeset in webkit [106710] by Lucas Forschler

• 1 edit in trunk/Tools/Scripts/update-webkit-support-libs

Fix URL string

4:31 PM Changeset in webkit [106709] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

[WK2] Use properly quoted string literals
​https://bugs.webkit.org/show_bug.cgi?id=77583

Reviewed by Darin Adler.

Also added some FIXMEs.

• WebProcess/com.apple.WebProcess.sb:

4:29 PM Changeset in webkit [106708] by Lucas Forschler

• 2 edits in trunk/Tools

update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
​https://bugs.webkit.org/show_bug.cgi?id=77785

Fix the build bots.

Pass the -k and --sslv3 keys to make curl work with https on ​https://developer.apple.com

• Scripts/update-webkit-support-libs:

(downloadExpectedVersionNumber):

4:24 PM Changeset in webkit [106707] by andersca@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Prefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
​https://bugs.webkit.org/show_bug.cgi?id=77788

Reviewed by Andreas Kling.

The current typedef name, 'ThisIsHereToForceASemicolonAfterThisMacro', shows up when trying to
code-complete 'this' in Xcode. Prefix the typedef with two underscores to stop this from happening.

• wtf/FastAllocBase.h:

4:22 PM Changeset in webkit [106706] by beidson@apple.com

• 10 edits in trunk/Source

2012-02-03 Brady Eidson <​beidson@apple.com>

<rdar://problem/10742441> and ​https://bugs.webkit.org/show_bug.cgi?id=77766
Need a WK2 API to filter which subframes go into WebArchives as they are created.

Reviewed by Darin Adler.

Source/WebCore:

This adds a filter callback object that allows clients to get called back for each
subframe that might be added to a WebArchive.

API only, No new layout tests.

• WebCore.exp.in:
• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

• loader/archive/cf/LegacyWebArchive.h:

(FrameFilter):
(WebCore:: FrameFilter::~ FrameFilter):
(LegacyWebArchive):

Source/WebKit2:

Add a new WKBundleFrame API that takes a filter callback object to allow or reject
subframes from a WebArchive:

• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyWebArchive):
(WKBundleFrameCopyWebArchiveFilteringSubframes):

• WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Implement the above API by calling through to WebCore:

• WebProcess/WebPage/WebFrame.cpp:

(WebFrameFilter):
(WebKit::WebFrameFilter::WebFrameFilter):
(WebKit::WebFrameFilter::shouldIncludeSubframe):
(WebKit::WebFrame::webArchiveData):

• WebProcess/WebPage/WebFrame.h:

(WebFrame):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getWebArchiveOfFrame):

4:16 PM Changeset in webkit [106705] by jsbell@chromium.org

• 4 edits
  2 adds in trunk

IndexedDB: Key generators not rolled back if insertion fails or is aborted
​https://bugs.webkit.org/show_bug.cgi?id=77060

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/key-generator.html

• storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put): Add abort task to reset cache.
(WebCore::IDBObjectStoreBackendImpl::revertAutoIncrementKeyCache):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal): Reset cache on error.

• storage/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

LayoutTests:

• storage/indexeddb/key-generator-expected.txt: Added.
• storage/indexeddb/key-generator.html: Added.

4:10 PM Changeset in webkit [106704] by tony@chromium.org

• 3 edits
  2 adds in trunk

positive and negative flex values are not being cleared on style changes
​https://bugs.webkit.org/show_bug.cgi?id=77771

Reviewed by Ojan Vafai.

Source/WebCore:

If the width or height was a flex() value, but is no longer a flex
value, we weren't clearing the positive and negative flex values in
RenderStyle.

Test: css3/flexbox/flex-no-flex.html

• css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

LayoutTests:

• css3/flexbox/flex-no-flex-expected.txt: Added.
• css3/flexbox/flex-no-flex.html: Added.

4:01 PM Changeset in webkit [106703] by Lucas Forschler

• 3 edits in trunk/Tools

Add a Mac Lion Performance bot.
​https://bugs.webkit.org/show_bug.cgi?id=77765

Reviewed by Adam Roben.

This will update the master configuration in the following ways:

Add a new performance slave (apple-xseve-11)
Add a new Factory to download a build and run perf tests.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadAndPerfTestFactory):
(DownloadAndPerfTestFactory.init):

3:53 PM Changeset in webkit [106702] by dpranke@chromium.org

• 1 edit
  1 delete in trunk/Tools

Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
​https://bugs.webkit.org/show_bug.cgi?id=77752

Reviewed by James Robinson.

Delete unneeded file accidentally checked in in r106481.

• TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.

3:47 PM Changeset in webkit [106701] by ap@apple.com

• 3 edits in trunk/Source/WebKit2

[Mac WK2] Use a minimally invasive way to fake plug-in process name
​https://bugs.webkit.org/show_bug.cgi?id=77682

Reviewed by Darin Adler.

• PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::netscapePluginModule):

Only change the name as it's seen from within the process.

• Shared/Plugins/PluginQuirks.h: Fixed a typo.

3:18 PM Changeset in webkit [106700] by jamesr@google.com

• 20 edits in trunk/Source

[chromium] Defer makeContextCurrent in compositor until first frame
​https://bugs.webkit.org/show_bug.cgi?id=77269

Reviewed by Kenneth Russell.

Source/WebCore:

There are situations where we need to instantiate a compositor, but can't call makeContextCurrent() until some
initialization work completes on another thread that we cannot block for. This defers the first
makeContextCurrent() call until we need to produce the first frame at which point we know the call can succeed,
assuming that the scheduler does the right thing.

This is accomplished by splitting up proxy initialization into two pieces:
*) initializeContext() which attempts to instantiate a GraphicsContext3D. This can fail if we can't make a
context at all, in which case we abort completely and return NULL from CCLayerTreeHost::create().

*) initializeLayerRenderer() which uses the previously-created context to instantiate our compositor objects and

grab our renderer capabilities. This can fail if the context is not usable for compositing, which we report
to the client as a lost context event.

Internally this introduces a new state to the CCLayerTreeHostImpl where it has a context but does not yet have a
LayerRendererChromium, which has fairly minimal impact. One other change is that we don't instantiate the
TextureManagers until we have the renderer capabilities, but this isn't necessary until we want to start
painting so it doesn't have any impact outside of some overly intrustive unit tests.

• platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):

• platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

• platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

• platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

• platform/graphics/chromium/TiledLayerChromium.cpp:
• platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::setSampledTexelFormat):
(TiledLayerChromium):

• platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):
():

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::isContextLost):

• platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

• platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):

• platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeContext):
(WebCore):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

• platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

• tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):

• tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

3:13 PM Changeset in webkit [106699] by jamesr@google.com

• 2 edits in trunk/Source/WebCore

Unreviewed compile fix for chromium - add commas after entries in list in WebCore.gypi

• WebCore.gypi:

3:03 PM Changeset in webkit [106698] by kling@webkit.org

• 6 edits in trunk/Source/WebCore

Unreviewed build fix attempt after r106695.

CSSMutableStyleDeclaration was renamed to StylePropertySet.

• bindings/scripts/CodeGeneratorCPP.pm:

(AddIncludesForType):

• bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

• bindings/v8/V8DOMWindowShell.cpp:
• bindings/v8/V8DOMWrapper.cpp:
• bindings/v8/V8Proxy.cpp:

2:52 PM Changeset in webkit [106697] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[BlackBerry] Let userIdleTime() return maximum number instead of 0 as
most of other ports do.
​https://bugs.webkit.org/show_bug.cgi?id=77769

Patch by Yong Li <​yoli@rim.com> on 2012-02-03
Reviewed by Rob Buis.

userIdleTime() should return a big number so it won't block page cache
from releasing cached pages. See PageCache::releaseAutoreleasedPagesNowOrReschedule().

No new tests as no visible functional changes.

• platform/blackberry/SystemTimeBlackBerry.cpp:

(WebCore::userIdleTime):

2:46 PM Changeset in webkit [106696] by andersca@apple.com

• 6 edits
  4 copies in trunk/Source/WebCore

Commit scrolling tree state changes to the scrolling tree
​https://bugs.webkit.org/show_bug.cgi?id=77780

Reviewed by Darin Adler.

• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::commitTreeState):
Send the new scrolling tree state over to the ScrollingTree on the scrolling thread.

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Create a root node.

(WebCore::ScrollingTree::commitNewTreeState):
Update the root node.

• page/scrolling/ScrollingTreeNode.cpp: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
• page/scrolling/ScrollingTreeNode.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.

Stub out an abstract ScrollingTreeNode class.

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
Update the scroll layer on the tree state.

• page/scrolling/mac/ScrollingTreeNodeMac.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
• page/scrolling/mac/ScrollingTreeNodeMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.

Stub out the concrete ScrollingTreeNodeMac subclass.

2:41 PM Changeset in webkit [106695] by Antti Koivisto

• 49 edits
  2 moves in trunk/Source

Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
​https://bugs.webkit.org/show_bug.cgi?id=77779

Reviewed by Darin Adler.

Source/WebCore:

Match the new class name.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCSSStyleDeclarationCustom.cpp:
• bindings/js/JSDOMBinding.h:
• bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue):

• bindings/scripts/CodeGeneratorObjC.pm:

(AddIncludesForType):

• css/CSSAllInOne.cpp:
• css/CSSComputedStyleDeclaration.cpp:
• css/CSSFontFaceRule.cpp:
• css/CSSFontFaceRule.h:
• css/CSSFontSelector.cpp:
• css/CSSMutableStyleDeclaration.cpp: Removed.
• css/CSSMutableStyleDeclaration.h: Removed.
• css/CSSPageRule.cpp:
• css/CSSParser.cpp:
• css/CSSStyleRule.cpp:
• css/CSSStyleRule.h:
• css/StylePropertySet.cpp: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.cpp.
• css/StylePropertySet.h: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.h.
• css/WebKitCSSKeyframeRule.cpp:
• css/WebKitCSSKeyframeRule.h:
• css/WebKitCSSKeyframesRule.cpp:
• css/WebKitCSSMatrix.cpp:
• dom/CSSMappedAttributeDeclaration.h:
• dom/ElementAttributeData.h:
• dom/StyledElement.cpp:
• dom/StyledElement.h:
• editing/ApplyStyleCommand.cpp:
• editing/DeleteButtonController.cpp:
• editing/EditingStyle.cpp:
• editing/Editor.cpp:
• editing/EditorCommand.cpp:
• editing/RemoveCSSPropertyCommand.cpp:
• editing/ReplaceSelectionCommand.cpp:
• editing/markup.cpp:
• html/canvas/CanvasRenderingContext2D.cpp:
• html/shadow/MeterShadowElement.cpp:
• inspector/InspectorCSSAgent.cpp:
• inspector/InspectorDOMAgent.cpp:
• page/DragController.cpp:
• page/Frame.cpp:
• rendering/RenderLayer.cpp:
• rendering/RenderTreeAsText.cpp:
• svg/SVGFontFaceElement.h:

(WebCore):

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

Source/WebKit/qt:

• Api/qwebelement.cpp:

2:23 PM Changeset in webkit [106694] by mihnea@adobe.com

• 9 edits
  4 adds in trunk

Crash in RenderFlowThread::setRegionBoxesRegionStyle
​https://bugs.webkit.org/show_bug.cgi?id=77474

Reviewed by David Hyatt.

Source/WebCore:

Flexbox and deprecated flexible box should also compute their region range
when they are part of a named flow. Until now, only RenderBlock elements
were doing that. Flexbox and deprecated flexible box, while implementing
their own layoutBlock method, were not doing that.

Tests: fast/regions/flexbox-in-region-crash.html

fast/regions/select-in-region-crash.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):

• rendering/RenderBlock.h:

(RenderBlock):

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

• rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):

• rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

• fast/regions/flexbox-in-region-crash-expected.txt: Added.
• fast/regions/flexbox-in-region-crash.html: Added.
• fast/regions/select-in-region-crash-expected.txt: Added.
• fast/regions/select-in-region-crash.html: Added.

2:07 PM Changeset in webkit [106693] by leviw@chromium.org

• 1 edit in branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

Fixing a use of enclosingIntRect in Accessibility code. Should be pixelSnapped instead.

1:48 PM Changeset in webkit [106692] by rniwa@webkit.org

• 7 edits in trunk/Tools

Ref Tests should support plain SVG files
​https://bugs.webkit.org/show_bug.cgi?id=77685

Reviewed by Tony Chang.

Don't assume reference files always use .html as the extension.
Instead, use the list of supported extension to look for -expected.* and -mismatch.*

Also fix various bugs in MockFileSystem and TestPort.

• Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.isdir):

• Scripts/webkitpy/layout_tests/port/base.py:

(Port.reference_files):

• Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_is_test_file):
(PortTest.test_reference_files):

• Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init):

1:28 PM Changeset in webkit [106691] by piman@chromium.org

• 5 edits in branches/chromium/1025/Source

Merge 106663 - [Chromium] Use the current clip when marking paints as opaque
​https://bugs.webkit.org/show_bug.cgi?id=77582

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Source/WebCore:

New unit test in PlatformContextSkiaTest.cpp

• platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::markRectAsOpaque):

• platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::canvas):

Source/WebKit/chromium:

• tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9328008

1:25 PM Changeset in webkit [106690] by andersca@apple.com

• 6 edits in trunk/Source/WebCore

Update the tree state after layout and add a way to commit it
​https://bugs.webkit.org/show_bug.cgi?id=77767

Reviewed by Andreas Kling.

• page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
Call ScrollingCoordinator::frameViewLayoutUpdated if we have a scrolling coordinator.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Initialize m_scrollingTreeStateCommitterTimer.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Update the viewport rect and contents size of the frame view.

(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
Schedule a tree state commit unless we've already scheduled one or there are no changed properties.

(WebCore::ScrollingCoordinator::scrollingTreeStateCommitterTimerFired):
Call commitTreeState().

(WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
Commit the tree state unless there are no changed properties.

(WebCore::ScrollingCoordinator::commitTreeState):
Commit the tree state. We currently don't do anything with the committed state yet.

• page/scrolling/ScrollingCoordinator.h:

Add new member functions and the timer member variable.

• page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::commit):
Copy the current tree state and restore the changed properties on the original.

• page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::hasChangedProperties):
Return whether there are any changed properties in the tree state.

1:25 PM Changeset in webkit [106689] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

complete rebaseline of box-shadow-clipped-slices
​https://bugs.webkit.org/show_bug.cgi?id=77565

Patch by Elliot Poger <​epoger@google.com> on 2012-02-03
Reviewed by Darin Adler.

• platform/chromium/test_expectations.txt:

1:13 PM Changeset in webkit [106688] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] configure: Print out the -Wno-c++0x-compat test result
​https://bugs.webkit.org/show_bug.cgi?id=77757

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-03
Reviewed by Martin Robinson.

The check whether -Wno-c++0x-compat flag is needed didn't print out
the test result (and newline), which caused the following test to be
displayed on the same line.

checking if we have to disable C++0x compat warnings for GCC >= 4.6.0... checking pthread.h usability... yes

• configure.ac:

1:10 PM Changeset in webkit [106687] by rniwa@webkit.org

• 15 edits in trunk

perf-o-matic should store chromium svn revision
​https://bugs.webkit.org/show_bug.cgi?id=77725

Reviewed by Dirk Pranke.

.:

Store both WebKit and Chromium revisions when both are reported.

• Websites/webkit-perf.appspot.com/models.py:

(Build):

• Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):
(ReportHandler._create_build_if_possible):
(ReportHandler._create_build_if_possible.execute):

• Websites/webkit-perf.appspot.com/static/manual-submit.html:

Tools:

Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
is implemented in terms of newly added svn_revision.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.svn_revision):

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.head_svn_revision):
(SCM):
(SCM.svn_revision):

• Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.svn_revision):

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.svn_revision):

• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init):

• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata):

• Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths):

• Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.repository_paths):

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_json):

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):

12:59 PM Changeset in webkit [106686] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

Fix alignment warnings in ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=55368

Patch by Rob Buis <​rbuis@rim.com> on 2012-02-03
Reviewed by Filip Pizlo.

Use reinterpret_cast_ptr and static_cast to get rid of alignment issues in ARMv7 code.

• heap/HandleTypes.h:

(JSC::HandleTypes::getFromSlot):

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):

• heap/MarkedBlock.h:

(JSC::MarkedBlock::forEachCell):

• runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::unvalidatedGet):

12:57 PM Changeset in webkit [106685] by kling@webkit.org

• 2 edits in trunk/Source/WebCore

HTMLElement: Clean up tabindex attribute parsing.
<​http://webkit.org/b/77763>

Reviewed by Antti Koivisto.

Remove an unnecessary getAttribute() call when parsing tabindexAttr.

• html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

12:46 PM Changeset in webkit [106684] by dgrogan@chromium.org

• 3 edits in trunk/LayoutTests

Make js-test-pre.js more worker friendly
​https://bugs.webkit.org/show_bug.cgi?id=77487

Replace uses of 'window' with 'self'.

Reviewed by Ojan Vafai.

• fast/js/resources/js-test-pre.js:
• storage/indexeddb/resources/basics.js:

12:22 PM Changeset in webkit [106683] by andersca@apple.com

• 3 edits
  1 copy in trunk/Source/WebCore

ScrollingTreeState should keep track of the scroll layer
​https://bugs.webkit.org/show_bug.cgi?id=77762

Reviewed by Andreas Kling.

• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):

• page/scrolling/mac/ScrollingTreeStateMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTreeState.h.

(WebCore):
(WebCore::ScrollingTreeState::platformScrollLayer):
(WebCore::ScrollingTreeState::setScrollLayer):

12:08 PM Changeset in webkit [106682] by jochen@chromium.org

• 1 edit in branches/chromium/1025/Source/WebCore/page/DOMTimer.cpp

Merge 106636 - Crash when trying to add a timer to a detached document.
​https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In ​http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

• page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):

TBR=​jochen@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9317088

11:46 AM Changeset in webkit [106681] by Antti Koivisto

• 63 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=77740
Split CSSMutableStyleDeclaration into separate internal and CSSOM types

Reviewed by Andreas Kling and Darin Adler.

Source/WebCore:

Split the CSSMutableStyleDeclaration into an internal type (StylePropertySet) and a CSSOM implementation type (PropertySetCSSStyleDeclaration).

To keep things somewhat manageable, this patch does NOT

• rename or add any files (so files names won't match types)
• rename fields, methods or variables to match new type names (like CSSStyleRule::declaration() -> CSSStyleRule::propertySet())
• try to realize any memory or performance gains (StylePropertySet loses the vptr but gains PropertySetCSSStyleDeclaration*)

• WebCore.exp.in:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copy):
(WebCore::CSSComputedStyleDeclaration::makeMutable):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

• css/CSSComputedStyleDeclaration.h:

(WebCore):
(CSSComputedStyleDeclaration):

• css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):
(WebCore::CSSFontFaceRule::setDeclaration):
(CSSFontFaceRule):

• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

• css/CSSMutableStyleDeclaration.cpp:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::create):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::deref):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setNeedsStyleRecalc):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::copyBlockProperties):
(WebCore::StylePropertySet::removeBlockProperties):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::parentRule):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

• css/CSSMutableStyleDeclaration.h:

(WebCore):
(StylePropertySet):
(WebCore::StylePropertySet::create):
(WebCore::StylePropertySet::createInline):

• css/CSSPageRule.h:

(WebCore):

• css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

• css/CSSParser.h:

(WebCore):
(CSSParser):

• css/CSSStyleDeclaration.h:

(WebCore):
(CSSStyleDeclaration):

• css/CSSStyleRule.h:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
(WebCore::CSSStyleRule::declaration):
(CSSStyleRule):

• css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::matchPageRulesForList):

• css/CSSStyleSelector.h:

(CSSStyleSelector):
(MatchedStyleDeclaration):

• css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

• css/WebKitCSSKeyframeRule.h:

(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):

• css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

• dom/Attr.h:

(WebCore::Attr::style):

• dom/Attribute.h:

(WebCore::Attribute::decl):

• dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::declaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
(CSSMappedAttributeDeclaration):

• dom/Document.cpp:

(WebCore::Document::createCSSStyleDeclaration):

• dom/ElementAttributeData.h:

(ElementAttributeData):

• dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):

• dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):

• dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::copyNonAttributeProperties):
(WebCore::StyledElement::addSubresourceAttributeURLs):

• dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

• editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

• editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore):
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(HTMLAttributeEquivalent):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::EditingStyle):
(WebCore::getRGBAFontColor):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::EditingStyle::forceInline):
(WebCore::reconcileTextDecorationProperties):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::getTextAlignment):
(WebCore::getPropertiesNotIn):
(WebCore::getIdentifierValue):
(WebCore::isTransparentColorValue):
(WebCore::hasTransparentBackgroundColor):

• editing/EditingStyle.h:

(WebCore):
(WebCore::EditingStyle::create):
(EditingStyle):
(WebCore::EditingStyle::style):
(StyleChange):

• editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::applyEditingStyleToElement):

• editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

• editing/FrameSelection.h:

(WebCore):

• editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

• editing/ReplaceSelectionCommand.h:

(WebCore):

• editing/markup.cpp:

(WebCore):
(StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):

• html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

• html/HTMLTableCellElement.h:

(HTMLTableCellElement):

• html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

• html/HTMLTableColElement.h:

(HTMLTableColElement):

• html/HTMLTableElement.cpp:

(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::leakGroupBorderStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

• html/HTMLTableElement.h:

(HTMLTableElement):

• html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

• html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

• html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

• html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

• page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

• page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

• page/PageSerializer.h:

(WebCore):
(PageSerializer):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

• rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

• svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

Source/WebKit/mac:

• WebView/WebFrame.mm:

(-[WebFrame _typingStyle]):

Source/WebKit/qt:

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

11:32 AM Changeset in webkit [106680] by jochen@chromium.org

• 6 edits
  3 adds in trunk

Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
​https://bugs.webkit.org/show_bug.cgi?id=76704

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/isolatedWorld/sandboxed-iframe.html

• bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

• bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

• bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::callListenerFunction):

• bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::toV8Context):

LayoutTests:

• http/tests/security/isolatedWorld/resources/fail.html:
• http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
• http/tests/security/isolatedWorld/sandboxed-iframe.html:

11:30 AM Changeset in webkit [106679] by andersca@apple.com

• 4 edits
  2 adds in trunk/Source/WebCore

Add ScrollingTreeState class
​https://bugs.webkit.org/show_bug.cgi?id=77756

Reviewed by Andreas Kling.

Add a new ScrollingTreeState whose intent is to be a data container for the current
scrolling tree state. the ScrollingCoordinator class will update it and periodically
send over the new state to the ScrollingTree object on the scrolling thread.

• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

• page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

• page/scrolling/ScrollingTreeState.cpp: Added.

(WebCore):
(WebCore::ScrollingTreeState::create):
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::~ScrollingTreeState):
(WebCore::ScrollingTreeState::setViewportRect):
(WebCore::ScrollingTreeState::setContentsSize):

• page/scrolling/ScrollingTreeState.h: Added.

(WebCore):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::viewportRect):
(WebCore::ScrollingTreeState::contentsSize):

11:29 AM Changeset in webkit [106678] by Beth Dakin

• 18 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=77691
Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use
of device scale

Reviewed by Andy Estes.

Source/WebCore:

Make screenAvailableRect() and screenRect() take a Widget again instead of a
FrameView since taking a FrameView is a layering violation.

• WebCore.exp.in:
• platform/PlatformScreen.h:

(WebCore):

• platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenAvailableRect):
(WebCore::screenRect):

• platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

• platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

• platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

• platform/qt/PlatformScreenQt.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

• platform/win/PlatformScreenWin.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

• platform/wx/ScreenWx.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

It's wrong for the deviceScaleFactor to be taken into consideration here at
all.

• platform/mac/PlatformScreenMac.mm:

(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):

Source/WebKit/chromium:

These two functions now take a Widget again rather than a FrameView.

• src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRect):
(WebCore::PlatformSupport::screenAvailableRect):

Source/WebKit/mac:

toUserSpace() and toDeviceSpace() don't need to take device scale. Also
restore a comment that I needlessly removed.

• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setWindowRect):
(WebChromeClient::windowRect):

Source/WebKit2:

toUserSpace() and toDeviceSpace() don't need to take device scale.

• UIProcess/API/mac/WKView.mm:

(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

11:27 AM Changeset in webkit [106677] by mhahnenberg@apple.com

• 1 edit
  2 adds in trunk/Source/JavaScriptCore

Build fix

Unreviewed build fix

Forgot to add a couple files.

• heap/MarkedAllocator.cpp: Added.

(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

• heap/MarkedAllocator.h: Added.

(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):

11:21 AM Changeset in webkit [106676] by mhahnenberg@apple.com

• 13 edits in trunk/Source/JavaScriptCore

Refactor MarkedBlock::SizeClass into a separate class
​https://bugs.webkit.org/show_bug.cgi?id=77600

Reviewed by Geoffrey Garen.

We pulled SizeClass out into its own class, named MarkedAllocator, and gave it
the responsibility of allocating objects from the collection of MarkedBlocks
that it manages. Also limited the amount of coupling to internal data fields
from other places, although it's mostly unavoidable in the JIT code.

Eventually MarkedAllocator will implement various policies to do with object
management, e.g. whether or not to run destructors on objects that it manages.
MarkedSpace will manage a collection of MarkedAllocators with varying policies,
as it does now but to a larger extent.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):

• heap/Heap.cpp:

(JSC::Heap::collect):
(JSC::Heap::resetAllocators):

• heap/Heap.h:

(JSC::Heap::allocatorForObject):
(Heap):

• heap/MarkedAllocator.cpp: Added.

(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

• heap/MarkedAllocator.h: Added.

(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):

• heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::didAddBlock):
(JSC::MarkedSpace::didConsumeFreeList):

• jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

10:39 AM Changeset in webkit [106675] by scherkus@chromium.org

• 2 edits in branches/chromium/1025/Source/WebCore

Merge 106610 - Avoid crashing renderer when GPU process dies by not caching textures between video frames.
​https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9309085

10:25 AM Changeset in webkit [106674] by mitz@apple.com

• 2 edits in trunk

Added Radar links

10:23 AM Changeset in webkit [106673] by mitz@apple.com

• 3 edits
  2 adds in trunk

Floating image leaves hole in previous column when wrapped to next column
​https://bugs.webkit.org/show_bug.cgi?id=77694

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/dynamic/float-moved-downwards-for-pagination-expected.html

fast/dynamic/float-moved-downwards-for-pagination.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats): When determining which lines to dirty,
also check for changes to the top edge of the float, which can happen when
float gets pushed down by a pagination strut.

LayoutTests:

• fast/dynamic/float-moved-downwards-for-pagination-expected.html: Added.
• fast/dynamic/float-moved-downwards-for-pagination.html: Added.

10:21 AM Changeset in webkit [106672] by alexis.menard@openbossa.org

• 3 edits
  2 adds in trunk

REGRESSION (r105401-105403): Blue flash on css border transition
​https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

• platform/animation/AnimationUtilities.h:

(WebCore::blend):

LayoutTests:

• animations/animation-border-overflow-expected.txt: Added.
• animations/animation-border-overflow.html: Added.

10:02 AM Changeset in webkit [106671] by jesus@webkit.org

• 2 edits in trunk/LayoutTests

[Qt][WK2] Incorrect line number dumping
​https://bugs.webkit.org/show_bug.cgi?id=60074

Reviewed by Csaba Osztrogonác.

Test http/tests/security/contentSecurityPolicy/eval-blocked.html
is now passing, unskipping it.

• platform/qt-wk2/Skipped:

9:38 AM Changeset in webkit [106670] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Chromium] ImageBufferSkia: remove unnecessary overload of flush in
AcceleratedDeviceContext
​https://bugs.webkit.org/show_bug.cgi?id=77741

Patch by Justin Novosad <​junov@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Removing dead code.

• platform/graphics/skia/ImageBufferSkia.cpp:

(AcceleratedDeviceContext):

9:31 AM Changeset in webkit [106669] by jknotten@chromium.org

• 3 edits in trunk/Source/WebKit/chromium

[skia] Fix unit test PlatformContextSkiaTest.trackOpaqueOvalTest
​https://bugs.webkit.org/show_bug.cgi?id=77738

We need to clear the bitmap before the test runs, otherwise the
contents of the bitmap will be uninitialised. This causes an
unpredicatable result as the canvas draw operations blend the
destination bitmap with the source colour.

Similarly, valgrind discovered that
PlatformContextSkiaTest.trackOpaqueTest and
PlatformContextSkiaTest.trackOpaqueLineTest suffers from the same
problem.

Also, re-enable WebFrameTest.FindInPage which was falsely
blamed for making this test fail.

Reviewed by Stephen White.

• tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

• tests/WebFrameTest.cpp:

(WebKit::TEST_F):

9:02 AM Changeset in webkit [106668] by kbalazs@webkit.org

• 2 edits in trunk/Source/WebCore

Speculative unreviewed build fix for Qt-Windows
after ​http://trac.webkit.org/changeset/106659.

• platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::platformCreateAccelerated):

8:56 AM Changeset in webkit [106667] by commit-queue@webkit.org

• 35 edits
  4 deletes in trunk

Unreviewed, rolling out r106654.
​http://trac.webkit.org/changeset/106654
​https://bugs.webkit.org/show_bug.cgi?id=77742

triggers asserts on mac, win, gtk, qt debug bots (Requested by
philn-tp on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-03

Source/WebCore:

• Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

• bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

• dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

• dom/ActiveDOMObject.h:

(ActiveDOMObject):

• dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

• dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

• fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

• fileapi/FileReader.cpp:

(WebCore):

• fileapi/FileReader.h:

(WebCore::FileReader::create):

• fileapi/FileWriter.cpp:

(WebCore):

• fileapi/FileWriter.h:

(WebCore::FileWriter::create):

• history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

• html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

• html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

• mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

• notifications/Notification.cpp:

(WebCore::Notification::create):

• notifications/NotificationCenter.cpp:
• notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

• page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

• page/EventSource.cpp:

(WebCore::EventSource::create):

• page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

• storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

• storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

• storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

• webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

• websockets/WebSocket.cpp:
• websockets/WebSocket.h:

(WebCore::WebSocket::create):

• workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

• workers/Worker.cpp:

(WebCore::Worker::create):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

• fast/events/resources/suspend-subframe-1.html: Removed.
• fast/events/resources/suspend-subframe-2.html: Removed.
• fast/events/suspend-timers-expected.txt: Removed.
• fast/events/suspend-timers.html: Removed.
• platform/chromium/test_expectations.txt:

8:53 AM Changeset in webkit [106666] by haraken@chromium.org

• 27 edits in trunk/Source/WebCore

Add the "V8" prefix to V8 specific IDL attributes
​https://bugs.webkit.org/show_bug.cgi?id=77713

Reviewed by Adam Barth.

This patch adds the "V8" prefix to a V8 specific IDL attribute:
[EnabledAtRuntime] => [V8EnabledAtRuntime]

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GetRuntimeEnableFunctionName):

• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/V8/V8TestObj.cpp: Updated the run-bindings-tests results.

(WebCore::ConfigureV8TestObjTemplate):

• Modules/gamepad/NavigatorGamepad.idl:
• dom/Clipboard.idl:
• dom/Document.idl:
• dom/Element.idl:
• dom/MouseEvent.idl:
• dom/ShadowRoot.idl:
• html/HTMLInputElement.idl:
• html/HTMLMediaElement.idl:
• html/HTMLTrackElement.idl:
• html/TextTrack.idl:
• html/TextTrackCue.idl:
• html/TextTrackCueList.idl:
• html/shadow/HTMLContentElement.idl:
• html/track/TextTrackList.idl:
• html/track/TrackEvent.idl:
• page/DOMWindow.idl:
• page/History.idl:
• page/Navigator.idl:
• storage/DOMWindowSQLDatabase.idl:
• webaudio/DOMWindowWebAudio.idl:
• websockets/DOMWindowWebSocket.idl:
• workers/WorkerContext.idl:
• xml/XMLHttpRequest.idl:

8:50 AM Changeset in webkit [106665] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Web Inspector: Retained size for classes is too conservative in heap profiler
​https://bugs.webkit.org/show_bug.cgi?id=77726

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-03
Reviewed by Yury Semikhatsky.

Makes retained size of all objects of particular class show correct value
in Summary view of heap profiler.

• inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

• inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

8:43 AM Changeset in webkit [106664] by apavlov@chromium.org

• 5 edits
  2 adds in trunk

Web Inspector: Introduce "Copy XPath" popup menu item for DOM elements
​https://bugs.webkit.org/show_bug.cgi?id=77619

Reviewed by Vsevolod Vlasov.

Source/WebCore:

XPath is optimized whenever an element has the "id" attribute.

Test: inspector/elements/node-xpath.xhtml

• English.lproj/localizedStrings.js:
• inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.XPathStep):
(WebInspector.DOMNode.XPathStep.prototype.toString):
(WebInspector.DOMNode.prototype.copyXPath):
(WebInspector.DOMNode.prototype.isXMLNode):
(WebInspector.DOMNode.prototype.xPath):
(WebInspector.DOMNode.prototype._xPathValue):
(WebInspector.DOMNode.prototype._xPathIndex):

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):

LayoutTests:

• inspector/elements/node-xpath-expected.txt: Added.
• inspector/elements/node-xpath.xhtml: Added.

8:28 AM Changeset in webkit [106663] by commit-queue@webkit.org

• 5 edits in trunk/Source

[Chromium] Use the current clip when marking paints as opaque
​https://bugs.webkit.org/show_bug.cgi?id=77582

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Source/WebCore:

New unit test in PlatformContextSkiaTest.cpp

• platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::markRectAsOpaque):

• platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::canvas):

Source/WebKit/chromium:

• tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

8:20 AM Changeset in webkit [106662] by yurys@chromium.org

• 10 edits in trunk

inspector/debugger/pause-in-inline-script.html asserts in chromium debug
​https://bugs.webkit.org/show_bug.cgi?id=77663

Source/WebCore:

Make ASSERT in MainResourceLoader not fail if debugger hits breakpoint
in the main resource inline script.

Reviewed by Pavel Feldman.

Test: inspector/debugger/pause-in-inline-script.html

• bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::isPaused):
(ScriptDebugServer):

• bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

• inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):
(WebCore::InspectorDebuggerAgent::isPaused):

• inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
(WebCore):

• inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore):

• loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

Reviewed by Pavel Feldman.

• platform/chromium/test_expectations.txt: assert was fixed, remove custom expectation for inspector/debugger/pause-in-inline-script.html

7:56 AM Changeset in webkit [106661] by apavlov@chromium.org

• 1 edit
  2 copies in branches/chromium/1025

Merge 106560 - Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
​https://bugs.webkit.org/show_bug.cgi?id=77643

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-during-dom-traversal.html

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):

LayoutTests:

• inspector/styles/updates-during-dom-traversal-expected.txt: Added.
• inspector/styles/updates-during-dom-traversal.html: Added.

TBR=​apavlov@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9310084

7:07 AM Changeset in webkit [106660] by haraken@chromium.org

• 19 edits in trunk/Source/WebCore

Fix typo
​https://bugs.webkit.org/show_bug.cgi?id=77708

Reviewed by Adam Roben.

This patch fixes typos: [ObjCLegacyUnamedParameters] => [ObjCLegacyUnnamedParameters]

No tests. No change in behavior.

• css/CSSMediaRule.idl:
• css/CSSPrimitiveValue.idl:
• css/CSSStyleDeclaration.idl:
• css/CSSStyleSheet.idl:
• dom/CharacterData.idl:
• dom/DOMImplementation.idl:
• dom/Document.idl:
• dom/Element.idl:
• dom/Event.idl:
• dom/EventTarget.idl:
• dom/MouseEvent.idl:
• dom/MutationEvent.idl:
• dom/NamedNodeMap.idl:
• dom/Node.idl:
• dom/Range.idl:
• dom/UIEvent.idl:
• html/HTMLSelectElement.idl:
• xml/XPathExpression.idl:

6:59 AM Changeset in webkit [106659] by noam.rosenthal@nokia.com

• 19 edits
  2 adds
  2 deletes in trunk/Source

[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
​https://bugs.webkit.org/show_bug.cgi?id=77148

Reviewed by Martin Robinson.

Source/WebCore:

Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.

To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.

Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: ​https://bugs.webkit.org/show_bug.cgi?id=77689

Covered extensively by existing tests, no behavioral changes.

• Target.pri:
• platform/graphics/GraphicsContext.cpp:
• platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

• platform/graphics/cairo/TextureMapperCairo.cpp:
• platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):

• platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):

• platform/graphics/qt/TextureMapperQt.cpp: Removed.
• platform/graphics/qt/TextureMapperQt.h: Removed.
• platform/graphics/texmap/TextureMapper.cpp:

(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):

• platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):

• platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

• platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.

• Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

• WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.

• UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

6:47 AM Changeset in webkit [106658] by jocelyn.turcotte@nokia.com

• 25 edits
  1 copy
  1 move
  1 add
  1 delete in trunk

[Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
​https://bugs.webkit.org/show_bug.cgi?id=77632

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Replace the runtime property setting the desktop behavior on each instance
by a static boolean controlling the behavior used by future created WebViews.

• UIProcess/API/qt/qquickwebpage.cpp:

Let only setContentsSize control the size of the drawing area instead of deferring
it until geometryChanged is called.
(QQuickWebPagePrivate::QQuickWebPagePrivate):

• UIProcess/API/qt/qquickwebpage_p.h:
• UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

• UIProcess/API/qt/qquickwebview.cpp:

(createPrivateObject):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::loadDidCommit):
(QQuickWebViewFlickablePrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewFlickablePrivate::computeViewportConstraints):
(QQuickWebViewFlickablePrivate::PostTransitionState::apply):
(QQuickWebViewExperimental::setFlickableViewportEnabled):
The switch is now a static function that has to be called before a WebView
is created. The switch can have it's default defined by the deploying platform.
(QQuickWebViewExperimental::flickableViewportEnabled):
(QQuickWebView::QQuickWebView):
On creation of QQuickWebView, the static boolean is read to know if we want
a QQuickWebViewTouchPrivate or a QQuickWebViewDesktopPrivate.
(QQuickWebView::geometryChanged):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(PostTransitionState):
(QQuickWebViewFlickablePrivate::PostTransitionState::PostTransitionState):

• UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

• UIProcess/API/qt/tests/publicapi/publicapi.pro:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Added.
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Removed.
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml: Renamed

from Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml.
Moved to DesktopBehavior instead of using a DesktopWebView to workaround the touch event limitation.

• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
• UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
• UIProcess/API/qt/tests/qmltests/WebView.pro: Copied

from Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro.

• UIProcess/API/qt/tests/qmltests/qmltests.pro:

Split qmltests in two executables, tst_qmltests_DesktopBehavior and tst_qmltests_WebView.
The former runs without setFlickableViewportEnabled and the later does.

• UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

• UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
• UIProcess/API/qt/tests/tests.pri:
• UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):

Tools:

• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

• MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::sendTouchEvent):
(MiniBrowserApplication::handleUserOptions):

• MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions):
(WindowOptions::WindowOptions):

• WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

• WebKitTestRunner/qt/main.cpp:

(main):

• qmake/mkspecs/features/default_post.prf:

6:47 AM Changeset in webkit [106657] by yurys@chromium.org

• 12 edits
  2 adds in trunk

Web Inspector: console evaluation doesn't work on breakpoint in pages with CSP
​https://bugs.webkit.org/show_bug.cgi?id=77203

Inspector console evaluation now works when debugger is paused in a page with
content-security-policy prohibiting evals.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/eval-on-pause-blocked.html

• bindings/js/JSInjectedScriptHostCustom.cpp:
• bindings/js/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):

• bindings/js/ScriptState.h:

(WebCore):

• bindings/v8/ScriptObject.h:

(WebCore::ScriptObject::ScriptObject):

• bindings/v8/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):

• bindings/v8/ScriptState.h:

(WebCore):

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
• inspector/InjectedScript.cpp:

(WebCore::InjectedScript::makeCall):

• inspector/InjectedScriptHost.idl:
• inspector/InjectedScriptSource.js:

(.):

LayoutTests:

• inspector/debugger/eval-on-pause-blocked-expected.txt: Added.
• inspector/debugger/eval-on-pause-blocked.html: Added.

6:44 AM Changeset in webkit [106656] by jocelyn.turcotte@nokia.com

• 8 edits in trunk/Source/WebKit2

[Qt] Rename content* to contents* in QQuickWebPage.
​https://bugs.webkit.org/show_bug.cgi?id=77629

Reviewed by Kenneth Rohde Christiansen.

• UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::setContentsSize):
(QQuickWebPage::contentsSize):
(QQuickWebPage::setContentsScale):
(QQuickWebPage::contentsScale):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

• UIProcess/API/qt/qquickwebpage_p.h:
• UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):

• UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

• UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

• UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::scaleContent):

6:05 AM Changeset in webkit [106655] by rwlbuis@webkit.org

• 4 edits in trunk/Source/WebCore

2012-02-03 Rob Buis <​rbuis@rim.com>

Upstream targetType usage on ResourceRequest for BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=77649

Reviewed by Antonio Gomes.

Upstream bits that make use of targetType enum.

• loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::reportContentSecurityPolicyViolation):
• platform/network/blackberry/ResourceRequest.h: (ResourceRequest): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::setTargetType):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):

5:42 AM Changeset in webkit [106654] by commit-queue@webkit.org

• 35 edits
  4 adds in trunk

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
​https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

• Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

• bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

• dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

• dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

• dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

• dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

• fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

• fileapi/FileReader.cpp:

(WebCore::FileReader::create):

• fileapi/FileReader.h:
• fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

• fileapi/FileWriter.h:
• history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

• html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

• html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

• mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

• notifications/Notification.cpp:

(WebCore::Notification::create):

• notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

• notifications/NotificationCenter.h:
• page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

• page/EventSource.cpp:

(WebCore::EventSource::create):

• page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

• storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

• storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

• storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

• webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

• websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

• websockets/WebSocket.h:
• workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

• workers/Worker.cpp:

(WebCore::Worker::create):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
​https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.

• fast/events/resources/suspend-subframe-1.html: Added.
• fast/events/resources/suspend-subframe-2.html: Added.
• fast/events/suspend-timers-expected.txt: Added.
• fast/events/suspend-timers.html: Added.
• platform/chromium/test_expectations.txt:

5:36 AM Changeset in webkit [106653] by yurys@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

2012-02-03 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium deps.

• DEPS:

5:23 AM Changeset in webkit [106652] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

New test introduced in r106642 failes on Qt Linux Release
​https://bugs.webkit.org/show_bug.cgi?id=77729

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-02-03
Reviewed by Csaba Osztrogonác.

• platform/qt/Skipped:

5:05 AM Changeset in webkit [106651] by commit-queue@webkit.org

• 4 edits in trunk/Source

[Qt] Fix build when cross-compiling
​https://bugs.webkit.org/show_bug.cgi?id=77634

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

Source/WebKit2:

• WebKit2.pri: Link in -lrt on linux mkspecs, regardless of whether gcc

is in use or not. More specifically this fixes the case where the makespace
is not linux-g++* but for a cross-compiling one like linux-arm-gnueabi-g++.

Source/WTF:

• WTF.pri: Don't use icu-config for determining the library search

path and libraries needed for ICU. Either we use icu-config for includes
_and_ libraries or we don't. Right now we assume that icu is a system library
and expect the headers in the default include search pathes (/usr/include for example).
However we use icu-config to figure out where the libraries are, which breaks when
cross-compiling, because icu-config isn't cross-compile friendly (I wish icu was using
pkg-config). I think for the time being we should require ICU as a _system_ library,
which implies the header and library availability in default search paths. This also
makes the build succeed when cross-compiling with --sysroot.

4:51 AM Changeset in webkit [106650] by commit-queue@webkit.org

• 6 edits
  1 delete in trunk

[Qt] Replace GNU linker script for exports with export macros in WTF/JSC
​https://bugs.webkit.org/show_bug.cgi?id=77723

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

.:

• Source/api.pri: Remove use of GNU linker script on Linux.
• Source/qtwebkit-export.map: Removed.

Source/JavaScriptCore:

• wtf/Platform.h: Enable use of export macros.

Tools:

• Tools.pro: Compile WTR again on all platforms with WK2.

4:49 AM Changeset in webkit [106649] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Do not ASSERT on TouchStationary TouchPoint state.
​https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-03
Reviewed by Kenneth Rohde Christiansen.

• page/EventHandler.cpp:

(WebCore::eventNameForTouchPointState): Explicitly show that TouchStationary is asserted.
(WebCore::EventHandler::handleTouchEvent):

Remove TouchStationary from ASSERT. The value of HitTestRequest is restored to the
value it should have if hittested, but is not used.

4:14 AM Changeset in webkit [106648] by haraken@chromium.org

• 25 edits in trunk/Source/WebCore

Add the "ObjC" prefix to ObjC specific IDL attributes
​https://bugs.webkit.org/show_bug.cgi?id=77708

Reviewed by Adam Barth.

This patch adds the "ObjC" prefix to ObjC specific IDL attributes, as follows:

[Polymorphic] => [ObjCPolymorphic]
[OldStyleObjC] => [ObjCLegacyUnamedParameters]
[UsesView] => [ObjCUseDefaultView] (Note: Renamed for clarification)

No tests. No changes in behavior.

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

• css/CSSMediaRule.idl:
• css/CSSPrimitiveValue.idl:
• css/CSSRule.idl:
• css/CSSStyleDeclaration.idl:
• css/CSSStyleSheet.idl:
• css/CSSValue.idl:
• css/StyleSheet.idl:
• dom/CharacterData.idl:
• dom/DOMImplementation.idl:
• dom/Document.idl:
• dom/Element.idl:
• dom/Event.idl:
• dom/EventTarget.idl:
• dom/MouseEvent.idl:
• dom/MutationEvent.idl:
• dom/NamedNodeMap.idl:
• dom/Node.idl:
• dom/Range.idl:
• dom/UIEvent.idl:
• html/HTMLCollection.idl:
• html/HTMLSelectElement.idl:
• svg/SVGPathSeg.idl:
• xml/XPathExpression.idl:

4:02 AM Changeset in webkit [106647] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Ensure that inspector disabled build works
​https://bugs.webkit.org/show_bug.cgi?id=77604

Patch by Sriram Neelakandan <​sriram.neelakandan@gmail.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

• qmake/mkspecs/features/features.prf:

3:39 AM Changeset in webkit [106646] by morrita@google.com

• 2 edits in trunk/Source/WebCore

TypingCommand should be prepared against detached document.
​https://bugs.webkit.org/show_bug.cgi?id=77216

Reviewed by Ryosuke Niwa.

Added null checks for document()->frame().

No new tests. Just tighten guards for possible codepaths.

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

3:05 AM Changeset in webkit [106645] by haraken@chromium.org

• 26 edits in trunk/Source/WebCore

Rename [DontEnum] IDL to [NotEnumerable] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77710

Reviewed by Adam Barth.

[DontEnum] is a negation of Enumerable in the ECMAScript spec
(8.6.1 of ​http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf).
This patch renames [DontEnum] to [NotEnumerable].

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateImplementation):

• css/WebKitCSSMatrix.idl:
• dom/DOMCoreException.idl:
• dom/Document.idl:
• dom/Element.idl:
• dom/EventException.idl:
• dom/RangeException.idl:
• fileapi/FileException.idl:
• fileapi/OperationNotAllowedException.idl:
• html/DOMTokenList.idl:
• html/HTMLAnchorElement.idl:
• html/HTMLBodyElement.idl:
• html/HTMLFrameSetElement.idl:
• html/HTMLInputElement.idl:
• page/DOMSelection.idl:
• page/DOMWindow.idl:
• page/Location.idl:
• storage/IDBDatabaseException.idl:
• storage/Storage.idl:
• svg/SVGElementInstance.idl:
• svg/SVGException.idl:
• workers/WorkerLocation.idl:
• xml/XMLHttpRequestException.idl:
• xml/XPathException.idl:

3:02 AM Changeset in webkit [106644] by haraken@chromium.org

• 21 edits in trunk/Source/WebCore

Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77711

Reviewed by Adam Barth.

[InitializedByConstructor] can be used only when [ConstructorTemplate=Event]
is specified on the interface. This patch renames [InitializedByConstructor] to
[InitializedByEventConstructor] for clarification.

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):

• bindings/scripts/test/TestEventConstructor.idl:
• bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results.

(WebCore):

• dom/BeforeLoadEvent.idl:
• dom/CustomEvent.idl:
• dom/ErrorEvent.idl:
• dom/Event.idl:
• dom/HashChangeEvent.idl:
• dom/MessageEvent.idl:
• dom/OverflowEvent.idl:
• dom/PageTransitionEvent.idl:
• dom/PopStateEvent.idl:
• dom/ProgressEvent.idl:
• dom/WebKitAnimationEvent.idl:
• dom/WebKitTransitionEvent.idl:
• html/canvas/WebGLContextEvent.idl:
• html/track/TrackEvent.idl:
• storage/StorageEvent.idl:
• websockets/CloseEvent.idl:

2:31 AM Changeset in webkit [106643] by haraken@chromium.org

• 6 edits in trunk/Source/WebCore

Add the "CPP" prefix to CPP specific IDL attributes
​https://bugs.webkit.org/show_bug.cgi?id=77707

Reviewed by Adam Barth.

This patch adds the "CPP" prefix to a CPP specific IDL attribute.
Specifically, this patch renames [PureInterface] to [CPPPureInterface]

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

• css/MediaQueryListListener.idl:
• dom/EventListener.idl:
• dom/EventTarget.idl:
• dom/NodeFilter.idl:

2:10 AM Changeset in webkit [106642] by apavlov@chromium.org

• 10 edits
  2 adds in trunk

Implement touch event emulation in the WebCore layer
​https://bugs.webkit.org/show_bug.cgi?id=77105

Reviewed by Ryosuke Niwa.

Source/WebCore:

This change essentially maps mouse events into single-touch events in the following way:

• mousedown -> touchstart
• mouseup -> touchend
• mousemove -> touchmove (between mousedown and mouseup).

Test: fast/events/touch/emulate-touch-events.html

• page/EventHandler.cpp:

(SyntheticTouchPoint): A synthetic touch point built from PlatformMouseEvent.
(WebCore::SyntheticTouchPoint::SyntheticTouchPoint):
(SyntheticSingleTouchEvent): A synthetic touch point event built from PlatformMouseEvent.
(WebCore::SyntheticSingleTouchEvent::SyntheticSingleTouchEvent):
(WebCore::EventHandler::handleMouseReleaseEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::handleMousePressEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::mouseMoved): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): Dispatch a synthetic touch event if necessary.

• page/EventHandler.h: Added new method.
• page/Settings.cpp:

(WebCore::Settings::Settings): Added m_touchEventEmulationEnabled initializer.

• page/Settings.h: Added m_touchEventEmulationEnabled, getter, and setter.

(WebCore::Settings::setTouchEventEmulationEnabled): Added.
(WebCore::Settings::isTouchEventEmulationEnabled): Added.

• platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint): Unconditionally compile the parameterless ctor.

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setTouchEventEmulationEnabled): Added for testing.

• testing/InternalSettings.h: Added setTouchEventEmulationEnabled() for testing.
• testing/InternalSettings.idl: Added setTouchEventEmulationEnabled() for testing.

LayoutTests:

• fast/events/touch/emulate-touch-events-expected.txt: Added.
• fast/events/touch/emulate-touch-events.html: Added.

2:04 AM Changeset in webkit [106641] by abarth@webkit.org

• 2 edits in trunk/LayoutTests

Group all the security failures together.

• platform/chromium/test_expectations.txt:

2:01 AM Changeset in webkit [106640] by haraken@chromium.org

• 3 edits in trunk/Source/WebCore

Remove [NoCPPCustom] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77704

Reviewed by Adam Barth.

This patch removes [NoCPPCustom], by replacing [Custom, NoCPPCustom]
in HTMLDocument.idl with [JSCCustom, V8Custom].

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType):

• html/HTMLDocument.idl:

1:54 AM Changeset in webkit [106639] by haraken@chromium.org

• 5 edits in trunk/Source/WebCore

Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
​https://bugs.webkit.org/show_bug.cgi?id=77706

Reviewed by Adam Barth.

This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].

No tests. No changes in behavior.

• bindings/scripts/CodeGeneratorGObject.pm:

(Generate):

• bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):

• page/DOMWindow.idl:
• workers/WorkerContext.idl:

1:28 AM Changeset in webkit [106638] by pfeldman@chromium.org

• 5 edits
  2 adds in trunk

Web Inspector: preserve elements panel selection upon node drag'n'drop
​https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

• inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

• inspector/elements/move-node-expected.txt: Added.
• inspector/elements/move-node.html: Added.

12:30 AM Changeset in webkit [106637] by commit-queue@webkit.org

• 13 edits in trunk

Source/WebCore: Reimplement DETAILS and SUMMARY using selector query.
​https://bugs.webkit.org/show_bug.cgi?id=75930

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

DETAILS is reimplemented using content element and its fallback feature.
We don't need to recreate DOM even if SUMMARY is removed from or added into DETAILS.

No new tests, should be covered by existing tests.

• html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::fallbackSummary):

Takes fallback element of content summary.

(DetailsSummaryElement):
(WebCore::DetailsSummaryElement::create):

Creates a fallback element also.

(WebCore):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::toggleOpen):

• html/HTMLDetailsElement.h:

(HTMLDetailsElement):

• html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::isMainSummary):

LayoutTests: Reimplement DETAILS and SUMMARY using selector query.
​https://bugs.webkit.org/show_bug.cgi?id=75930

Since the implementation of DETAILS shadow tree, the path of caret position is also changed.

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

• platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
• platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
• platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:

12:19 AM Changeset in webkit [106636] by jochen@chromium.org

• 2 edits in trunk/Source/WebCore

Crash when trying to add a timer to a detached document.
​https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In ​http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

• page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):

12:16 AM Changeset in webkit [106635] by commit-queue@webkit.org

• 8 edits in trunk

Stop calling Element::ensureShadowRoot in Internals.
​https://bugs.webkit.org/show_bug.cgi?id=77612

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
is built-in or user generated, so let's remove Element::ensureShadowRoot().

As a first step, this patch removes ensureShadowRoot() in Internals.

No new tests, because no changes in behavior.

• WebCore.exp.in:
• testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):

Source/WebKit2:

Exports symbols.

• win/WebKit2.def:
• win/WebKit2CFLite.def:

Feb 2, 2012:

11:44 PM Changeset in webkit [106634] by mrowe@apple.com

• 2 edits in trunk

<​http://webkit.org/b/77717> Makefile should provide control over output verbosity

Allow the filtering of the output of our Makefile to be configured via a user default
and overriden via a command-line argument to make.

The Makefile takes the verbosity from BuildTranscriptVerbosity default in the
org.webkit.BuildConfiguration domain. The supported values are "default", "quiet"
and "noisy". "default" maintains the existing behavior of only filtering out
the setenv lines from Xcode's shell script build phases. "quiet" filters all output
through filter-build-webkit. "noisy" provides unfiltered output. The verbosity can
be overriden for a single invocation of make by specifying the VERBOSITY variable
on the make command line.

To always get full output:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity noisy

To always get filtered ouptut:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity quiet

To get full output for a single build:
make VERBOSITY=noisy

Reviewed by Dan Bernstein.

• Makefile.shared:

11:37 PM Changeset in webkit [106633] by commit-queue@webkit.org

• 8 edits in trunk

Web Inspector: Always show percents together with counters in heap inspector.
​https://bugs.webkit.org/show_bug.cgi?id=77434

Source/WebCore:

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.

• inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):

• inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype.get _isShowingAsPercent):
(WebInspector.DetailedHeapshotView.prototype._percentClicked):

• inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid span.percent-column):

LayoutTests:

Added parseInt conversion as counters are now strings not ints.

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.

• inspector/profiler/detailed-heapshots-comparison-show-all.html:
• inspector/profiler/detailed-heapshots-comparison-show-next.html:
• inspector/profiler/detailed-heapshots-summary-show-all.html:

11:30 PM Changeset in webkit [106632] by commit-queue@webkit.org

• 17 edits
  8 adds in trunk

Use content-language from http-equiv to set document locale and font
​https://bugs.webkit.org/show_bug.cgi?id=76701

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-02-02
Reviewed by Darin Adler.

Source/WebCore:

So far, only content-language set through http-equiv is used; the HTTP Content-Language
header is not yet supported.

Tests: fast/text/content-language-case-insensitivity.html

fast/text/content-language-mapped-to-webkit-locale.html
fast/text/international/content-language-font-selection-expected.html
fast/text/international/content-language-font-selection.html
fast/text/international/content-language-with-subtags-expected.html
fast/text/international/content-language-with-subtags.html

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument): Use content language when selecting initial font.

• dom/Document.cpp:

(WebCore::Document::setContentLanguage): Recalculate style so language is taken into account.
(WebCore):

• dom/Document.h:

(Document):

LayoutTests:

Add tests that content-language from http-equiv sets document locale and is used in font selection.

• fast/text/content-language-case-insensitivity-expected.txt: Added.
• fast/text/content-language-case-insensitivity.html: Added.
• fast/text/content-language-mapped-to-webkit-locale-expected.txt: Added.
• fast/text/content-language-mapped-to-webkit-locale.html: Added.
• fast/text/international/content-language-font-selection-expected.html: Added.
• fast/text/international/content-language-font-selection.html: Added.
• fast/text/international/content-language-with-subtags-expected.html: Added.
• fast/text/international/content-language-with-subtags.html: Added.
• fast/text/lang-mapped-to-webkit-locale-expected.txt:
• fast/text/lang-mapped-to-webkit-locale.xhtml: Fix some style issues.
• fast/text/xml-lang-ignored-in-html-expected.txt:
• fast/text/xml-lang-ignored-in-html.html: Fix some style issues.
• platform/efl/Skipped: Skip tests using overridePreference("WebKit*FontMap"...) on non-Chromium ports.
• platform/gtk-wk2/Skipped: Ditto.
• platform/gtk/Skipped: Ditto.
• platform/mac/Skipped: Ditto.
• platform/qt/Skipped: Ditto.
• platform/win/Skipped: Ditto.
• platform/wincairo/Skipped: Ditto.
• platform/wk2/Skipped: Ditto.

11:12 PM Changeset in webkit [106631] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r106554.

• platform/qt/Skipped: Skip one more failing test.

10:59 PM Changeset in webkit [106630] by Csaba Osztrogonác

• 19 edits
  2 adds
  2 deletes in trunk/Source

Unreviewed, rolling out r106620.
​http://trac.webkit.org/changeset/106620
​https://bugs.webkit.org/show_bug.cgi?id=77716

It broke non ENABLE(3D_RENDERING) builds (Requested by
Ossy_morning on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

• platform/graphics/cairo/TextureMapperCairo.cpp:

(WebCore::TextureMapper::create):
(WebCore):

• platform/graphics/opengl/TextureMapperGL.cpp:

(Entry):
(DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::findOrCreate):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::deref):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::~DirectlyCompositedImageRepository):
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::isOpaque):
(WebCore::BitmapTextureGL::pack):
(WebCore::BitmapTextureGL::unpack):
(WebCore::BitmapTextureGL::isPacked):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::updateRawContents):
(WebCore::BitmapTextureGL::setContentsToImage):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):

• platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::allowSurfaceForRoot):
(BGRA32PremultimpliedBuffer):
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
(WebCore):

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

• platform/graphics/qt/GraphicsContextQt.cpp:
• platform/graphics/qt/TextureMapperQt.cpp: Added.

(WebCore):
(WebCore::BitmapTextureQt::destroy):
(WebCore::BitmapTextureQt::reset):
(WebCore::BitmapTextureQt::beginPaint):
(WebCore::BitmapTextureQt::endPaint):
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BitmapTextureQt::save):
(WebCore::BitmapTextureQt::setContentsToImage):
(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapperQt::beginClip):
(WebCore::TextureMapperQt::endClip):
(WebCore::TextureMapperQt::viewportSize):
(WebCore::TextureMapperQt::TextureMapperQt):
(WebCore::TextureMapperQt::setGraphicsContext):
(WebCore::TextureMapperQt::graphicsContext):
(WebCore::TextureMapperQt::bindSurface):
(WebCore::TextureMapperQt::drawTexture):
(WebCore::TextureMapper::create):
(WebCore::TextureMapperQt::createTexture):
(WebCore::BitmapTextureQt::BitmapTextureQt):
(WebCore::TextureMapperQt::beginPainting):
(WebCore::TextureMapperQt::endPainting):
(BGRA32PremultimpliedBufferQt):
(WebCore::BGRA32PremultimpliedBufferQt::beginPaint):
(WebCore::BGRA32PremultimpliedBufferQt::endPaint):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
(WebCore::uidForImage):

• platform/graphics/qt/TextureMapperQt.h: Added.

(WebCore):
(BitmapTextureQt):
(WebCore::BitmapTextureQt::~BitmapTextureQt):
(WebCore::BitmapTextureQt::size):
(WebCore::BitmapTextureQt::isValid):
(WebCore::BitmapTextureQt::sourceRect):
(WebCore::BitmapTextureQt::isPacked):
(WebCore::BitmapTextureQt::painter):
(TextureMapperQt):
(WebCore::TextureMapperQt::allowSurfaceForRoot):
(WebCore::TextureMapperQt::initialize):
(WebCore::TextureMapperQt::create):
(WebCore::TextureMapperQt::currentPainter):

• platform/graphics/texmap/TextureMapper.cpp:
• platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::allowOfflineTextureUpload):
(BitmapTexture):
(WebCore::BitmapTexture::pack):
(WebCore::BitmapTexture::unpack):
(WebCore::BitmapTexture::isPacked):
(WebCore::BitmapTexture::updateRawContents):
(WebCore::BitmapTexture::beginPaintMedia):
(WebCore::BitmapTexture::save):
(WebCore::BitmapTexture::lock):
(WebCore::BitmapTexture::unlock):
(WebCore::BitmapTexture::isLocked):
(TextureMapper):
(WebCore::TextureMapper::viewportSize):
(WebCore::TextureMapper::setViewportSize):
(WebCore::TextureMapper::allowPartialUpdates):
(WebCore::TextureMapper::isOpenGLBacked):
(WebCore::TextureMapper::setTransform):
(WebCore::TextureMapper::transform):

• platform/graphics/texmap/TextureMapperImageBuffer.cpp: Removed.
• platform/graphics/texmap/TextureMapperImageBuffer.h: Removed.
• platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

• platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

• Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

• WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

• UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

10:44 PM Changeset in webkit [106629] by mikelawther@chromium.org

• 1 edit
  4 adds in trunk/LayoutTests

gradient tests for CSS3 calc
​https://bugs.webkit.org/show_bug.cgi?id=75822

Reviewed by Hajime Morita.

Tests for future implementation of CSS3 calc() (see ​http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

• css3/calc/css3-radial-gradients-expected-mismatch.html: Added.
• css3/calc/css3-radial-gradients.html: Added.
• css3/calc/gradient-color-stops-expected-mismatch.html: Added.
• css3/calc/gradient-color-stops.html: Added.

9:44 PM Changeset in webkit [106628] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

ColorInputType needs to use ensureInlineStyleDecl
​https://bugs.webkit.org/show_bug.cgi?id=77699

Reviewed by Kent Tamura.

Because WebCore internally should use the more specific CSSMutableStyleDeclaration
​http://trac.webkit.org/changeset/105739

• html/ColorInputType.cpp:

(WebCore::ColorInputType::updateColorSwatch):

9:42 PM Changeset in webkit [106627] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/efl

[EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
​https://bugs.webkit.org/show_bug.cgi?id=77586

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2012-02-02
Reviewed by Andreas Kling.

As both zoom and content size change are identified by model flag,
ewk_tiled_backing_store can not detect the conflict between them.
In order to prevent conflict between zoom and contents size change,
contentsSize flag is newly added.

• ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_contents_resize):

9:29 PM Changeset in webkit [106626] by rolandsteiner@chromium.org

• 4 edits in trunk/Source/WebCore

Simplify SelectorChecker::checkSelector and checkOneSelector
​https://bugs.webkit.org/show_bug.cgi?id=77697

Make use of Element::previous/nextElementSibling.
Made those methods inline.
Simplify code in checkSelector and checkOneSelector, esp. for first/nth/nth-last/last/only-child implementations.

Reviewed by Andreas Kling.

No new tests. (refactoring)

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::checkOneSelector):

• dom/Element.cpp:
• dom/Element.h:

(WebCore::Element::previousElementSibling):
(WebCore):
(WebCore::Element::nextElementSibling):

9:26 PM Changeset in webkit [106625] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

ColorChooserClient is missing a virtual destructor
​https://bugs.webkit.org/show_bug.cgi?id=77698

Reviewed by Kent Tamura.

• platform/ColorChooserClient.h:

(WebCore::ColorChooserClient::~ColorChooserClient): Added.

9:14 PM Changeset in webkit [106624] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

Remove OVERRIDE from ColorInputType::valueAsColor
​https://bugs.webkit.org/show_bug.cgi?id=77701

Reviewed by Kent Tamura.

• html/ColorInputType.h:

(WebCore::ColorInputType::valueAsColor):

8:51 PM Changeset in webkit [106623] by commit-queue@webkit.org

• 5 edits
  3 adds in trunk

Support 'disabled' attribute on SVGStyleElement
​https://bugs.webkit.org/show_bug.cgi?id=52130

Source/WebCore:

Adding disabled property to SVGStyleElement, which
mirrors the functionality added to HTMLStyleElement
for DOM1. The disabled property reflects and sets
the disabled state of its style sheet.

Based off of patch for bug 25287

Patch by Bear Travis <​betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.

Test: svg/dom/SVGStyleElement/disable-svg-style-element.html

• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::disabled):
(WebCore):
(WebCore::SVGStyleElement::setDisabled):

• svg/SVGStyleElement.h:

(SVGStyleElement):

• svg/SVGStyleElement.idl:

LayoutTests:

Test the disabled property of an svg style element.
Based off of the patch for bug 25287.

Patch by Bear Travis <​betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.

• svg/dom/SVGStyleElement/disable-svg-style-element-expected.txt: Added.
• svg/dom/SVGStyleElement/disable-svg-style-element.html: Added.
• svg/dom/SVGStyleElement/script-tests/disable-svg-style-element.js: Added.

(createStyle):

8:37 PM Changeset in webkit [106622] by hayato@chromium.org

• 2 edits in trunk/Source/WebCore

Make ShadowRoot interface inherit DocumentFragment interface in IDL.
​https://bugs.webkit.org/show_bug.cgi?id=77511

Reviewed by Kentaro Hara.

This patch contains only the change of IDL to isolate issues.
Other changes, such as tests for querySelector of ShadowRoot, will be added in follow-up patches.

No tests. No change in behavior.

• dom/ShadowRoot.idl:

8:08 PM Changeset in webkit [106621] by commit-queue@webkit.org

• 3 edits
  17 adds in trunk

Check parameters to biquad filters
​https://bugs.webkit.org/show_bug.cgi?id=71413

Source/WebCore:

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.

Tests added for each filter type and for the limiting cases for
each filter type.

• platform/audio/Biquad.cpp:

(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setLowShelfParams):
(WebCore::Biquad::setHighShelfParams):
(WebCore::Biquad::setPeakingParams):
(WebCore::Biquad::setAllpassParams):
(WebCore::Biquad::setNotchParams):
(WebCore::Biquad::setBandpassParams):
Check for invalid parameters and clip them to something sensible.
Also check for the limiting cases and try to use the limiting form
of the z-transform for the biquad. Some issues cannot be
consistently handled because the z-transform is not continuous as
the parameters approach the limit.

LayoutTests:

Patch by Raymond Toy <​rtoy@chromium.org> on 2012-02-02
Reviewed by Kenneth Russell.

• webaudio/biquad-allpass-expected.txt: Added
• webaudio/biquad-allpass.html: Added
• webaudio/biquad-bandpass-expected.txt: Added
• webaudio/biquad-bandpass.html: Added
• webaudio/biquad-highpass-expected.txt: Added
• webaudio/biquad-highpass.html: Added
• webaudio/biquad-highshelf-expected.txt: Added
• webaudio/biquad-highshelf.html: Added
• webaudio/biquad-lowpass-expected.txt: Added
• webaudio/biquad-lowpass.html: Added
• webaudio/biquad-lowshelf-expected.txt: Added
• webaudio/biquad-lowshelf.html: Added
• webaudio/biquad-notch-expected.txt: Added
• webaudio/biquad-notch.html: Added
• webaudio/biquad-peaking-expected.txt: Added
• webaudio/biquad-peaking.html: Added
• webaudio/resources/biquad-testing.js: Added

8:00 PM Changeset in webkit [106620] by noam.rosenthal@nokia.com

• 19 edits
  2 adds
  2 deletes in trunk/Source

[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
​https://bugs.webkit.org/show_bug.cgi?id=77148

Reviewed by Martin Robinson.

Source/WebCore:

Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.

To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.

Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: ​https://bugs.webkit.org/show_bug.cgi?id=77689

Covered extensively by existing tests, no behavioral changes.

• Target.pri:
• platform/graphics/GraphicsContext.cpp:
• platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

• platform/graphics/cairo/TextureMapperCairo.cpp:
• platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):

• platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):

• platform/graphics/qt/TextureMapperQt.cpp: Removed.
• platform/graphics/qt/TextureMapperQt.h: Removed.
• platform/graphics/texmap/TextureMapper.cpp:

(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):

• platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):

• platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

• platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.

• Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

• WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.

• UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

7:33 PM Changeset in webkit [106619] by commit-queue@webkit.org

• 3 edits
  1 add in trunk/LayoutTests

Refactoring: Share test drivers of shadow content tests.
​https://bugs.webkit.org/show_bug.cgi?id=77584

Extracts shared test code from content-element-move.html and content-element-select-dynamic.html.
This test framework will be used a few more times.

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.

• fast/dom/resources/shadow-test-driver.js: Added.

(log):
(cleanUp):
(removeContainerLines):
(check):
(createSpanWithText):
(createContentWithSelect):
(appendShadow):
(appendShadowDeep):
(doTestIfLeft.callIfDone):
(doneTest):
(doTest):

• fast/dom/shadow/content-element-move.html:
• fast/dom/shadow/content-element-select-dynamic.html:

7:23 PM Changeset in webkit [106618] by abarth@webkit.org

• 13 edits in trunk/Source/WebCore

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
​https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Eric Seidel.

As requested by Darin Adler, this patch renames these functions be
clear that we're asking whether the access should be allowed rather
than explicitly allowing the access.

• bindings/generic/BindingSecurity.h:

(BindingSecurity):
(WebCore::::shouldAllowAccessToNode):
(WebCore::::allowSettingFrameSrcToJavascriptUrl):

• bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToNode):
(WebCore::shouldAllowAccessToFrame):

• bindings/js/JSDOMBinding.h:

(WebCore):

• bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::allowSettingJavascriptURL):

• bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::getOwnPropertyDescriptor):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

7:18 PM Changeset in webkit [106617] by jochen@chromium.org

• 2 edits in trunk/Tools

[chromium] add support for --makeargs to the ninja-based build
​https://bugs.webkit.org/show_bug.cgi?id=77688

Reviewed by Adam Barth.

• Scripts/webkitdirs.pm:

(buildChromiumNinja):

7:03 PM Changeset in webkit [106616] by eric@webkit.org

• 3 edits in trunk/Tools

Run tests in serial on SnowLeopard to avoid CFURLCache crashes
​https://bugs.webkit.org/show_bug.cgi?id=75145

Reviewed by Dirk Pranke.

• Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes):

• Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_operating_system):
(test_default_child_processes):

6:53 PM Changeset in webkit [106615] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Make gtk+ symbols available to WidgetBackingStoreCairo.cpp
​https://bugs.webkit.org/show_bug.cgi?id=77679

WidgetBackingStoreCairo.cpp uses GTK+ symbols, so we need it in
webcoregtk_sources instead of webcore_sources.

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

• GNUmakefile.list.am: Move WidgetBackingStoreCairo.cpp to webcoregtk.

6:52 PM Changeset in webkit [106614] by morrita@google.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, removing an unnecessarily JS_PRIVATE_EXPORT annotation.

• interpreter/Interpreter.h:

(Interpreter):

6:47 PM Changeset in webkit [106613] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

StyleRecalc should occur when shadow root exists and light children are changed.
​https://bugs.webkit.org/show_bug.cgi?id=76262

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.

Source/WebCore:

When light children is changed, the element included in HTMLContentElement may also be changed.
So we have to recalculate inclusion of content element again.

Test: fast/dom/shadow/shadow-contents-fallback-dynamic.html

• dom/Element.cpp:

(WebCore::Element::childrenChanged):

LayoutTests:

Tests for dynamic content fallback.
Also, unnecessary RenderText objects in previous test expectations were removed.

• fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt: Added.
• fast/dom/shadow/shadow-contents-fallback-dynamic.html: Added.
• platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
• platform/gtk/fast/html/details-remove-child-2-expected.txt:
• platform/mac/fast/html/details-remove-child-2-expected.txt:
• platform/qt/fast/html/details-remove-child-2-expected.txt:

6:40 PM Changeset in webkit [106612] by commit-queue@webkit.org

• 4 edits
  3 adds in trunk/LayoutTests

noteGrainOn needs more tests
​https://bugs.webkit.org/show_bug.cgi?id=77225

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.

• webaudio/note-grain-on-play.html: Added.
• webaudio/note-grain-on-play-expected.txt: Added.
• webaudio/note-grain-on-timing.html: Refactored to use new

functions in note-grain-on-testing.js.

• webaudio/note-grain-on-timing-expected.txt: Updated.
• webaudio/resources/audio-testing.js:

(grainLengthInSampleFrames): Utility to compute length of a grain
in samples.

• webaudio/resources/note-grain-on-testing.js: Added.

(createSignalBuffer):
(findStartAndEndSamples):
(playGrain):
(playAllGrains):
(verifyStarAndtEndTimes): Common functions for note-grain-on-play and
note-grain-on-timing tests to use.

6:28 PM Changeset in webkit [106611] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

Typo in sample-accurate-scheduling layout test?
​https://bugs.webkit.org/show_bug.cgi?id=75996

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.

• webaudio/sample-accurate-scheduling-expected.txt: Updated
• webaudio/sample-accurate-scheduling.html: Fix typo, add test for

expected number of events.

6:13 PM Changeset in webkit [106610] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Avoid crashing renderer when GPU process dies by not caching textures between video frames.
​https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

• platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

6:04 PM Changeset in webkit [106609] by andersca@apple.com

• 4 edits
  2 adds in trunk/Source/WebCore

Add ScrollingTree class
​https://bugs.webkit.org/show_bug.cgi?id=77695

Reviewed by Andreas Kling.

• WebCore.xcodeproj/project.pbxproj:

Add new files.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Create a scrolling tree.

(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
Assert that the scrolling tree is null.

(WebCore::ScrollingCoordinator::pageDestroyed):
Null out the scrolling tree member variable and tell it to invalidate itself.

• page/scrolling/ScrollingTree.cpp: Added.

(WebCore::ScrollingTree::invalidate):
Null out the scrolling coordinator, breaking the reference cycle between the scrolling
coordinator and the scrolling tree.

• page/scrolling/ScrollingTree.h: Added.

5:49 PM Changeset in webkit [106608] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

[GTK] Don't use uint
​https://bugs.webkit.org/show_bug.cgi?id=77678

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

With the MingGW cross compiler toolchain in Fedora, uint wasn't
defined, so use unsigned int instead.

• WebCoreSupport/ChromeClientGtk.h:

(ChromeClient): Use unsigned int instead of uint

5:35 PM Changeset in webkit [106607] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Refactor plugin drawing to be more data driven
​https://bugs.webkit.org/show_bug.cgi?id=76715

Patch by Tim Dresser <​tdresser@chromium.org> on 2012-02-02
Reviewed by James Robinson.

CCPluginLayerImpl no longer handles drawing itself, but produces a list of CCPluginDrawQuads.
These quads are then drawn by LayerRendererChromium.

CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
This allows for CCLayerImpl objects to allocate textures before appendQuads is called.

This is a refactor, so no new tests were added.
Flash was tested manually on Linux and Mac.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::PluginProgramBinding::set):
(PluginProgramBinding):
(WebCore):
(WebCore::TexStretchPluginProgramBinding::set):
(TexStretchPluginProgramBinding):
(WebCore::TexTransformPluginProgramBinding::set):
(TexTransformPluginProgramBinding):
(WebCore::LayerRendererChromium::drawPluginQuad):

• platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::willDraw):

• platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

• platform/graphics/chromium/cc/CCPluginDrawQuad.cpp:

(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):

• platform/graphics/chromium/cc/CCPluginDrawQuad.h:

(CCPluginDrawQuad):
(WebCore::CCPluginDrawQuad::uvRect):
(WebCore::CCPluginDrawQuad::textureId):
(WebCore::CCPluginDrawQuad::flipped):
(WebCore::CCPluginDrawQuad::ioSurfaceWidth):
(WebCore::CCPluginDrawQuad::ioSurfaceHeight):
(WebCore::CCPluginDrawQuad::ioSurfaceTextureId):

• platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::willDraw):
(WebCore::CCPluginLayerImpl::appendQuads):

• platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(CCPluginLayerImpl):

5:01 PM Changeset in webkit [106606] by morrita@google.com

• 5 edits
  3 deletes in trunk/Source/JavaScriptCore

[Mac] eliminate JavaScriptCore.exp
​https://bugs.webkit.org/show_bug.cgi?id=72854

Reviewed by Darin Adler.

• Removed exp files and corresponding makefile entries.
• Changed the build configuration no to use exp file.

• Configurations/JavaScriptCore.xcconfig:
• DerivedSources.make:
• JavaScriptCore.JSVALUE32_64only.exp: Removed.
• JavaScriptCore.JSVALUE64only.exp: Removed.
• JavaScriptCore.exp: Removed.
• JavaScriptCore.xcodeproj/project.pbxproj:
• wtf/Platform.h:

4:47 PM Changeset in webkit [106605] by haraken@chromium.org

• 12 edits in trunk/Source/WebCore

V8 idl code generator doesn't handle SerializedScriptValue attributes properly.
​https://bugs.webkit.org/show_bug.cgi?id=77295

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-01-29
Reviewed by Kentaro Hara.

Only the case of one (and only one) SerializedScriptValue attribute was
handled, and it was deserialized eagerly in the constructor instead of
generating getters/setters. This patch gets rid of that behavior and
generates the getters and setters instead (similar to what the JSC
generator does).
Also handle the case of SSV attributes with [CachedAttribute]
declaration, caching the deserialized value in a hidden attribute on the
object.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):
(JSValueToNative):
(NativeToJSValue):

• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::setValue):
(WebDOMTestSerializedScriptValueInterface::readonlyValue):
(WebDOMTestSerializedScriptValueInterface::cachedValue):
(WebDOMTestSerializedScriptValueInterface::setCachedValue):
(WebDOMTestSerializedScriptValueInterface::cachedReadonlyValue):

• bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):

• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

():
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::JSTestSerializedScriptValueInterface::put):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterface):
(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):

• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface setValue:]):
(-[DOMTestSerializedScriptValueInterface readonlyValue]):
(-[DOMTestSerializedScriptValueInterface cachedValue]):
(-[DOMTestSerializedScriptValueInterface setCachedValue:]):
(-[DOMTestSerializedScriptValueInterface cachedReadonlyValue]):

• bindings/scripts/test/TestSerializedScriptValueInterface.idl:
• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedReadonlyValueAttrGetter):
():
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

4:47 PM Changeset in webkit [106604] by abarth@webkit.org

• 2 edits in branches/chromium/1025/Source/WebCore/dom

Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium)
​https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
​http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

• dom/EventFactory.in:
• dom/make_event_factory.pl:

(defaultItemFactory):
(generateImplementation):

TBR=​abarth@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9325015

4:26 PM Changeset in webkit [106603] by abarth@webkit.org

• 3 edits in trunk/Source/WebCore

BMW Car Configuration Page doesn't work (Only manifests in Chromium)
​https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
​http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

• dom/EventFactory.in:
• dom/make_event_factory.pl:

(defaultItemFactory):
(generateImplementation):

4:24 PM Changeset in webkit [106602] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Fix up test expectations for two tests that now pass.
​https://bugs.webkit.org/show_bug.cgi?id=77256

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Eric Seidel.

• platform/chromium/test_expectations.txt:

webaudio/audiobuffersource-playbackrate.html and
webaudio/gain.html pass on windows now after the fix for bug

76659. Delete these.

4:06 PM Changeset in webkit [106601] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

[Chromium] Use SkCanvas::flush in skia port
​https://bugs.webkit.org/show_bug.cgi?id=77463

Patch by Justin Novosad <​junov@chromium.org> on 2012-02-02
Reviewed by Stephen White.

Code cleanup in skia port. Using SkCanvas::flush to remove
unnecessary dependency on GrContext. Removed unnecessary inclusions
and forward declarations of GrContext in several source files.

• platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

• platform/graphics/chromium/LayerRendererChromium.cpp:
• platform/graphics/chromium/LayerRendererChromium.h:
• platform/graphics/chromium/cc/CCLayerTreeHost.h:
• platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
• platform/graphics/chromium/cc/CCProxy.h:
• platform/graphics/skia/PlatformContextSkia.cpp:

3:42 PM Changeset in webkit [106600] by benjamin@webkit.org

• 3 edits
  2 adds in trunk

Running a Web Worker on about:blank crashes the interpreter
​https://bugs.webkit.org/show_bug.cgi?id=77593

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-02
Reviewed by Michael Saboff.

Source/JavaScriptCore:

The method Interpreter::execute() was crashing on empty programs because
the assumption is made the source is not null.

This patch shortcut the execution when the String is null to avoid invalid
memory access.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

LayoutTests:

The Worker thread should not crash if running on an empty page.
The timer is necessary to give a chance for the thread to start.

• fast/workers/empty-worker-nocrash-expected.txt: Added.
• fast/workers/empty-worker-nocrash.html: Added.

3:41 PM Changeset in webkit [106599] by Lucas Forschler

• 4 edits in trunk/Source

Versioning.

3:36 PM Changeset in webkit [106598] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[GTK] Use win32 native threading
​https://bugs.webkit.org/show_bug.cgi?id=77676

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

r97269 switched from glib threading to pthreads, breaking win32 GTK+.
This is a follow up, removing some leftovers in ThreadSpecific.h and
switching win32 to use the native threading in ThreadingWin.cpp.

• GNUmakefile.list.am: Compile in win32 native threading support
• wtf/ThreadSpecific.h: Remove GTK+-specific definitions

(ThreadSpecific):
(WTF::::destroy):

3:34 PM Changeset in webkit [106597] by Lucas Forschler

• 1 copy in tags/Safari-535.19

New Tag.

3:18 PM Changeset in webkit [106596] by fpizlo@apple.com

• 3 edits
  3 adds in trunk

retrieveCallerFromVMCode should call trueCallerFrame
​https://bugs.webkit.org/show_bug.cgi?id=77684

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveCallerFromVMCode):

LayoutTests:

Rubber stamped by Oliver Hunt.

• fast/js/dfg-inline-function-dot-caller-expected.txt: Added.
• fast/js/dfg-inline-function-dot-caller.html: Added.
• fast/js/script-tests/dfg-inline-function-dot-caller.js: Added.

(resultArray):
(object.nonInlineable.nonInlineable.if):
(object.nonInlineable):
(object.inlineable):
(makeInlinableCall):
(g):

3:03 PM Changeset in webkit [106595] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[GTK] Implement current executable path finding for win32
​https://bugs.webkit.org/show_bug.cgi?id=77677

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.

• wtf/gobject/GlibUtilities.cpp:

(getCurrentExecutablePath):

2:55 PM Changeset in webkit [106594] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Throwing away bytecode and then reparsing during DFG optimization is just
plain wrong and makes things crash
​https://bugs.webkit.org/show_bug.cgi?id=77680
<rdar://problem/10798490>

Reviewed by Oliver Hunt.

This is the minimal surgical fix: it removes the code that triggered bytecode
throw-away. Once we're confident that this is a good idea, we can kill all of
the code that implements the feature.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::addValueProfile):

• jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

2:50 PM Changeset in webkit [106593] by aestes@apple.com

• 8 edits in trunk

Turn on CSS Filters on Windows
​https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Patch by Chris Marrin <​cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

• WebCore.vcproj/copyForwardingHeaders.cmd:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Patch by Chris Marrin <​cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

• win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Patch by Chris Marrin <​cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

• platform/win/Skipped:

2:16 PM Changeset in webkit [106592] by jonlee@apple.com

• 18 edits in trunk/Source

Clear shown notifications when context is no longer active
​https://bugs.webkit.org/show_bug.cgi?id=77363
<rdar://problem/10568907>

Reviewed by Darin Adler.

Source/WebCore:

• notifications/NotificationPresenter.h: Add new virtual function to clear notifications

associated with a given execution context. By default the notifications are left alone, as
before. Individual implementations can override to allow notifications to clear them.

• notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame): When disconnecting the page from the frame, we
call clearNotifications().

• page/Frame.cpp:

(WebCore::Frame::pageDestroyed): When the page is destroyed, tell the DOM window to reset notifications.

Source/WebKit/win:

• WebCoreSupport/WebDesktopNotificationsDelegate.h:

(WebDesktopNotificationsDelegate): Add previously missing virtual functions.

• WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::notificationControllerDestroyed):
(WebDesktopNotificationsDelegate::cancelRequestsForPermission):

Source/WebKit2:

• WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::clearNotifications): Forward the call to
WebNotificationManager.

• WebProcess/WebCoreSupport/WebNotificationClient.h:

(WebNotificationClient):

• WebProcess/Notifications/WebNotificationManager.h: Add an additional map that maps

all notifications associated with a given ScriptExecutionContext instance.

• WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Create a map entry for the notification's
context if it doesn't exist already, and note that notification's ID. Also, correct
the return value of show() if notifications are not enabled, to return false.
(WebKit::WebNotificationManager::didCloseNotifications): When the notification is closed,
we remove that notification from the map.
(WebKit::WebNotificationManager::clearNotifications): Use the map entry for the given
context, and pass that along to the proxy so that all of the notifications with those IDs
can be cleared. In the meantime, we remove that context's map entry.

• UIProcess/Notifications/WebNotificationManagerProxy.messages.in: New ClearNotifications()

message.

• UIProcess/Notifications/WebNotificationManagerProxy.h:
• UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::clearNotifications): Forward the call to the provider.
Then remove this proxy's entries for the given notification IDs.

• UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::clearNotifications): Convert the vector of IDs to a mutable
array.

• UIProcess/Notifications/WebNotificationProvider.h:

(WebNotificationProvider):

• UIProcess/API/C/WKNotificationProvider.h: Add WK API to tell the platform to clear the notifications.

Remove the #if guard since they already exist in WebNotificationManager functions:

• WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::show):
(WebKit::WebNotificationClient::cancel):
(WebKit::WebNotificationClient::notificationObjectDestroyed):

1:55 PM Changeset in webkit [106591] by dpranke@chromium.org

• 5 edits in trunk/Tools

nrwt shouldn't blow up when there are errors in test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=73603

Reviewed by Ojan Vafai.

This change removes the distinction between 'errors' and 'warnings'
in the test expectations parser. Now, any problem is a
'warning', and if we are linting the file, warnings become fatal (errors).

This will allow a normal run-webkit-tests run to proceed even if
there are bad lines.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(ParseError.init):
(ParseError.str):
(ParseError.repr):
(TestExpectationSerializer.to_string):
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._parse_expectations):
(TestExpectationParser._check_modifiers_against_expectations):
(TestExpectationParser._tokenize):
(TestExpectationLine.init):
(TestExpectationLine.is_invalid):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._already_seen_better_match):
(TestExpectations.init):
(TestExpectations._report_warnings):
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(assert_bad_expectations):
(test_parse_warning):
(test_overridesduplicate):
(ExpectationSyntaxTests.test_missing_expectation):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_colons):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_slow_and_timeout):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RebaseliningTest.assertRemove):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationSerializerTests.test_unparsed_to_string):

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):

• Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations):

1:49 PM Changeset in webkit [106590] by fpizlo@apple.com

• 30 edits in trunk/Source/JavaScriptCore

Release build debugging should be easier
​https://bugs.webkit.org/show_bug.cgi?id=77669

Reviewed by Gavin Barraclough.

• assembler/ARMAssembler.h:

(ARMAssembler):
(JSC::ARMAssembler::debugOffset):

• assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::debugOffset):
(ARMInstructionFormatter):
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):

• assembler/AbstractMacroAssembler.h:

(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::debugOffset):

• assembler/AssemblerBuffer.h:

(AssemblerBuffer):
(JSC::AssemblerBuffer::debugOffset):

• assembler/LinkBuffer.h:

(LinkBuffer):
(JSC::LinkBuffer::debugSize):

• assembler/MIPSAssembler.h:

(MIPSAssembler):
(JSC::MIPSAssembler::debugOffset):

• assembler/X86Assembler.h:

(X86Assembler):
(JSC::X86Assembler::debugOffset):
(X86InstructionFormatter):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):

• bytecode/CodeBlock.cpp:

(JSC):

• bytecode/CodeBlock.h:

(CodeBlock):

• bytecode/CodeOrigin.h:

(CodeOrigin):
(JSC):
(JSC::CodeOrigin::inlineStack):

• bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

• bytecode/DataFormat.h:

(JSC::dataFormatToString):

• bytecode/PredictedType.cpp:

(JSC):
(JSC::predictionToString):

• bytecode/PredictedType.h:

(JSC):

• bytecode/ValueRecovery.h:

(ValueRecovery):
(JSC::ValueRecovery::dump):

• bytecompiler/BytecodeGenerator.cpp:

(JSC):
(JSC::BytecodeGenerator::setDumpsGeneratedCode):
(JSC::BytecodeGenerator::dumpsGeneratedCode):
(JSC::BytecodeGenerator::generate):

• dfg/DFGAbstractValue.h:

(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::dump):
(AbstractValue):
(JSC::DFG::AbstractValue::dump):

• dfg/DFGAssemblyHelpers.h:

(DFG):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):

• dfg/DFGFPRInfo.h:

(FPRInfo):
(JSC::DFG::FPRInfo::debugName):

• dfg/DFGGPRInfo.h:

(GPRInfo):
(JSC::DFG::GPRInfo::debugName):

• dfg/DFGGraph.cpp:

(DFG):

• dfg/DFGGraph.h:

(Graph):

• dfg/DFGNode.h:

(DFG):
(JSC::DFG::arithNodeFlagsAsString):
(Node):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::dumpChildren):

• dfg/DFGOSRExit.cpp:

(DFG):
(JSC::DFG::OSRExit::dump):

• dfg/DFGOSRExit.h:

(OSRExit):

• runtime/JSValue.cpp:

(JSC):
(JSC::JSValue::description):

• runtime/JSValue.h:

(JSValue):

• wtf/BitVector.cpp:

(WTF):
(WTF::BitVector::dump):

• wtf/BitVector.h:

(BitVector):

1:19 PM Changeset in webkit [106589] by oliver@apple.com

• 5 edits in trunk

Getters and setters cause line numbers in errors/console.log to be offset for the whole file
​https://bugs.webkit.org/show_bug.cgi?id=77675

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Our default literal parsing logic doesn't handle the extra work required for
getters and setters. When it encounters one, it rolls back the lexer and
then switches to a more complete parsing function. Unfortunately it was only
winding back the character position, and was ignoring the line number and
other lexer data. This led to every getter and setter causing the line number
to be incorrectly incremented leading to increasingly incorrect numbers for
the rest of the file.

• parser/Parser.cpp:

(JSC::::parseObjectLiteral):

LayoutTests:

Add getter and setter line number tests.

• fast/js/exception-linenums-expected.txt:
• fast/js/script-tests/exception-linenums.js:

(firstPropIsGetter.get getter):
(secondPropIsGetter.prop.1.get getter):
(firstPropIsSetter.set setter):
(secondPropIsSetter.prop.1.set setter):

1:18 PM Changeset in webkit [106588] by andersca@apple.com

• 6 edits in trunk/Source/WebCore

The overhang area layer should have a linen background
​https://bugs.webkit.org/show_bug.cgi?id=77670
<rdar://problem/10797727>

Reviewed by Andreas Kling.

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
Add an #ifdef so that scroll position clamping can be disabled. This will be
removed once rubber-banding works properly.

• platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
Add new empty function.

• platform/mac/ScrollbarThemeMac.h:

(ScrollbarThemeMac):

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::linenBackgroundColor):
Helper function for getting the CGColorRef that represents the linen background color.

(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
Set the linen background color as the overhang areas layer background color.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Call ScrollbarTheme::setUpOverhangAreasLayerContents.

1:15 PM Changeset in webkit [106587] by Nate Chapin

• 2 edits
  1 delete in trunk/LayoutTests

2012-02-02 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.
Remove custom chromium-mac expectation for fast/canvas/fillPath-shadow.html,
since it's failing the same way as chromium win/linux.

• platform/chromium-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
• platform/chromium/test_expectations.txt:

1:12 PM BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org

(diff)

1:10 PM Changeset in webkit [106586] by commit-queue@webkit.org

• 7 edits in trunk

Unreviewed, rolling out r106566.
​http://trac.webkit.org/changeset/106566
​https://bugs.webkit.org/show_bug.cgi?id=77673

Broke the Windows build (Requested by jessieberlin on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

• WebCore.vcproj/copyForwardingHeaders.cmd:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:

WebKitLibraries:

• win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

• platform/win/Skipped:

1:04 PM Changeset in webkit [106585] by scherkus@chromium.org

• 2 edits in trunk/LayoutTests

2012-02-02 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed, updating Chromium test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=73681

• platform/chromium/test_expectations.txt:

1:03 PM Changeset in webkit [106584] by rniwa@webkit.org

• 4 edits
  1 delete in trunk

Unreviewed, rolling out r106543.
​http://trac.webkit.org/changeset/106543
​https://bugs.webkit.org/show_bug.cgi?id=77671

Made tests less stable (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-02

PerformanceTests:

• resources/init.html: Removed.

Tools:

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):
(run_test):

1:00 PM Changeset in webkit [106583] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-02-02 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.
Mark some touch event tests as crashing, since they're
asserting as of r106554.

• platform/chromium/test_expectations.txt:

12:56 PM Changeset in webkit [106582] by Lucas Forschler

• 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r106508.

12:53 PM Changeset in webkit [106581] by tommyw@google.com

• 12 edits
  8 copies
  1 add in trunk/Source

[chromium] MediaStream API: Adding the embedding code for MediaStreamCenter
​https://bugs.webkit.org/show_bug.cgi?id=73130

Reviewed by Darin Fisher.

Source/WebCore:

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

• mediastream/UserMediaClient.h:

(UserMediaClient):

• mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::didCompleteQuery):

• mediastream/UserMediaRequest.h:

(UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):

• platform/mediastream/MediaStreamCenter.cpp:

(WebCore):
(WebCore::MediaStreamCenter::queryMediaStreamSources):

• platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamSourcesQueryClient):
(MediaStreamCenter):

Source/WebKit/chromium:

• WebKit.gyp:
• bridge/MediaStreamCenter.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebCore):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):
(WebCore::MediaStreamCenter::didConstructMediaStream):

• bridge/MediaStreamCenterInternal.cpp: Added.

(WebCore):
(WebCore::MediaStreamCenterInternal::MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::~MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::queryMediaStreamSources):
(WebCore::MediaStreamCenterInternal::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterInternal::didStopLocalMediaStream):
(WebCore::MediaStreamCenterInternal::didConstructMediaStream):
(WebCore::MediaStreamCenterInternal::stopLocalMediaStream):

• bridge/MediaStreamCenterInternal.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebCore):
(MediaStreamCenterInternal):

• public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::createMediaStreamCenter):

• public/platform/WebMediaStreamCenter.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::~WebMediaStreamCenter):

• public/platform/WebMediaStreamCenterClient.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebMediaStreamCenterClient):
(WebKit::WebMediaStreamCenterClient::~WebMediaStreamCenterClient):

• public/platform/WebMediaStreamComponent.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebCore):
(WebKit):
(WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::~WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::isNull):

• public/platform/WebMediaStreamDescriptor.h:

(WebKit):
(WebMediaStreamDescriptor):

• public/platform/WebMediaStreamSourcesRequest.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebCore):
(WebKit):
(WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::~WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::isNull):

• src/UserMediaClientImpl.h:

(UserMediaClientImpl):

• src/WebMediaStreamComponent.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebKit::WebMediaStreamComponent::reset):
(WebKit::WebMediaStreamComponent::operator PassRefPtr<MediaStreamComponent>):
(WebKit::WebMediaStreamComponent::operator MediaStreamComponent*):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::source):

• src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):

• src/WebMediaStreamSourcesRequest.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::reset):
(WebKit::WebMediaStreamSourcesRequest::audio):
(WebKit::WebMediaStreamSourcesRequest::video):
(WebKit::WebMediaStreamSourcesRequest::didCompleteQuery):

12:46 PM Changeset in webkit [106580] by commit-queue@webkit.org

• 4 edits
  7 adds in trunk

Constant values to set "distanceModel" are undefined
​https://bugs.webkit.org/show_bug.cgi?id=74273

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Tests: webaudio/distance-exponential.html

webaudio/distance-inverse.html
webaudio/distance-linear.html

• webaudio/AudioPannerNode.h: Define enum for the new constants

for the distance models.

• webaudio/AudioPannerNode.idl: Define matching constants for the

distance models.

LayoutTests:

• webaudio/distance-exponential-expected.txt: Added.
• webaudio/distance-exponential.html: Added.
• webaudio/distance-inverse-expected.txt: Added.
• webaudio/distance-inverse.html: Added.
• webaudio/distance-linear-expected.txt: Added.
• webaudio/distance-linear.html: Added.
• webaudio/resources/distance-model-testing.js: Added.

(createImpulseBuffer):
(linearDistance):
(exponentialDistance):
(inverseDistance):
(createGraph):
(startSources):
(equalPowerGain):
(checkDistanceResult.return.renderedBuffer):
(checkDistanceResult):

12:29 PM Changeset in webkit [106579] by commit-queue@webkit.org

• 8 edits in trunk

Illegal panner model values should throw an exception
​https://bugs.webkit.org/show_bug.cgi?id=77235

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Modified existing panner-set-model test to catch exceptions.
Debug build should not crash anymore.

• webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::setPanningModel): Throw exception for
invalid model values.

• webaudio/AudioPannerNode.h:

(AudioPannerNode): Update declaration

• webaudio/AudioPannerNode.idl: Setting panner model can throw

exception.

LayoutTests:

• webaudio/panner-set-model-expected.txt: Updated.
• webaudio/panner-set-model.html: Catch the errors that are thrown

for invalid panning model values.

• platform/chromium/test_expectations.txt: Remove test that no

longer crashes.

12:02 PM Changeset in webkit [106578] by Nate Chapin

• 2 edits in trunk/LayoutTests

2012-02-02 Nate Chapin <Nate Chapin>

Unreviewed, chromium expectations update.

• platform/chromium/test_expectations.txt:

12:02 PM Changeset in webkit [106577] by Beth Dakin

• 2 edits
  4 adds in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=77664
Add API tests for didNewFirstVisuallyNonEmptyLayout

Reviewed by Darin Adler.

Two new tests.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):

• TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):

11:49 AM Changeset in webkit [106576] by rniwa@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

Chromium rebaseline after r106543.

• platform/chromium/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

11:24 AM Changeset in webkit [106575] by haraken@chromium.org

• 23 edits in trunk/Source/WebCore

Rename [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString]
​https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

This patch renames [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString], according to the spec
(​http://dev.w3.org/2006/webapi/WebIDL/#TreatNullAs,
​http://dev.w3.org/2006/webapi/WebIDL/#TreatUndefinedAs).

No tests. No changes in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

• bindings/scripts/CodeGeneratorV8.pm:

(GetNativeTypeFromSignature):

• dom/DOMImplementation.idl:
• dom/Document.idl:
• fileapi/Blob.idl:
• fileapi/DirectoryEntry.idl:
• fileapi/DirectoryEntrySync.idl:
• fileapi/Entry.idl:
• fileapi/EntrySync.idl:
• fileapi/WebKitBlobBuilder.idl:
• html/HTMLButtonElement.idl:
• html/HTMLCanvasElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLObjectElement.idl:
• html/HTMLOutputElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTextAreaElement.idl:
• page/Console.idl:
• page/DOMWindow.idl:

• bindings/scripts/test/TestObj.idl: No changes in run-bindings-tests results.

11:12 AM Changeset in webkit [106574] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix type punning warning in HashTable.h debug builds
​https://bugs.webkit.org/show_bug.cgi?id=77422

Patch by Andy Wingo <​wingo@igalia.com> on 2012-02-02
Reviewed by Gavin Barraclough.

• wtf/HashTable.h (WTF::HashTable::checkKey): Fix type punning

warning appearing in debug builds with gcc-4.6.2 on GNU/Linux.

11:06 AM Changeset in webkit [106573] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-02

• DEPS:

11:03 AM Changeset in webkit [106572] by andersca@apple.com

• 4 edits in trunk/Source

NPAPI will not send mouse up events when mouse is outside plugin area
​https://bugs.webkit.org/show_bug.cgi?id=77657
<rdar://problem/10160674>

Reviewed by Andreas Kling.

Source/WebCore:

Export EventHandler::setCapturingMouseEventsNode.

• WebCore.exp.in:

Source/WebKit2:

Use EventHandler::setCapturingMouseEventsNode to ensure we get all the mouse events when the mouse is down.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):

10:59 AM Changeset in webkit [106571] by Csaba Osztrogonác

• 3 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.
​https://bugs.webkit.org/show_bug.cgi?id=67485

• platform/qt-wk2/Skipped:
  • fast/dom/Window/window-properties.html: unskip, it needed only update
  • fast/text/complex-preferred-logical-widths.html: unskip, it passes now
  • http/tests/loading/empty-urls.html: unskip, it doesn't exist now
  • http/tests/loading/progress-finished-callback.html: move to the correct place
• platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.

10:37 AM Changeset in webkit [106570] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

• platform/qt/Skipped: Unskip a now passing test.

10:08 AM Changeset in webkit [106569] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Paint the Qt Mac bot green.

• platform/qt-mac/Skipped:

10:08 AM Changeset in webkit [106568] by Antti Koivisto

• 15 edits in trunk/Source/WebCore

Move remaining implementation from CSSStyleDeclaration to subclasses
​https://bugs.webkit.org/show_bug.cgi?id=77621

Reviewed by Andreas Kling.

This leaves CSSStyleDeclaration a near-pure CSSOM interface.

• bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::putDelegate):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::parentRule):
(WebCore):

• css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

• css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::contextStyleSheet):
(WebCore):
(WebCore::CSSMutableStyleDeclaration::parentRule):

• css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentRuleInternal):
(WebCore::CSSMutableStyleDeclaration::clearParentRule):
(CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentElement):
(WebCore::CSSMutableStyleDeclaration::clearParentElement):
(WebCore::CSSMutableStyleDeclaration::parentStyleSheet):

• css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):

• css/CSSStyleDeclaration.cpp:

(WebCore):

• css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()

• css/CSSStyleRule.h:

(WebCore::CSSStyleRule::setDeclaration):

• css/CSSStyleSelector.cpp:

(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):

• css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

• page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSRule):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

• page/PageSerializer.h:

Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()

(WebCore):
(PageSerializer):

10:03 AM Changeset in webkit [106567] by Csaba Osztrogonác

• 4 edits in trunk/LayoutTests

[Qt] One more unreviewed gardening after r106487
​https://bugs.webkit.org/show_bug.cgi?id=77628

• platform/qt-5.0/Skipped:
• platform/qt-wk2/Skipped:
• platform/qt/Skipped: Skip new crashing tests after r106554.

9:58 AM Changeset in webkit [106566] by cmarrin@apple.com

• 7 edits in trunk

Turn on CSS Filters on Windows
​https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Reviewed by Adele Peterson.

• WebCore.vcproj/copyForwardingHeaders.cmd:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Reviewed by Adele Peterson.

• win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Reviewed by Adele Peterson.

• platform/win/Skipped:

9:44 AM Changeset in webkit [106565] by andersca@apple.com

• 5 edits
  3 adds in trunk/Source/WebCore

Move ScrollingThread to its own file
​https://bugs.webkit.org/show_bug.cgi?id=77652

Reviewed by Sam Weinig.

This just shuffles some classes around and makes ScrollingCoordinator call into ScrollingThread.
Hopefully we'll be able to make ScrollingThread use the new WebCore::RunLoop class eventually.

• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::handleWheelEvent):

• page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

• page/scrolling/ScrollingThread.cpp: Added.

(WebCore):
(WebCore::ScrollingThread::ScrollingThread):
(WebCore::ScrollingThread::isCurrentThread):
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::threadCallback):
(WebCore::ScrollingThread::threadBody):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

• page/scrolling/ScrollingThread.h: Added.

(WebCore):
(ScrollingThread):

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPositionOnScrollingThread):

• page/scrolling/mac/ScrollingThreadMac.mm: Added.

(WebCore):
(WebCore::ScrollingThread::initializeRunLoop):
(WebCore::ScrollingThread::wakeUpRunLoop):
(WebCore::ScrollingThread::threadRunLoopSourceCallback):

9:39 AM Changeset in webkit [106564] by tonyg@chromium.org

• 1 edit
  14 adds in trunk/LayoutTests

Unreviewed chromium baselines for new tests in r106551.

• platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
• platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
• platform/chromium-mac-leopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
• platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
• platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
• platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
• platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
• platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
• platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png: Added.
• platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Added.

9:20 AM Changeset in webkit [106563] by commit-queue@webkit.org

• 5 edits
  9 deletes in trunk

Unreviewed, rolling out r106551.
​http://trac.webkit.org/changeset/106551
​https://bugs.webkit.org/show_bug.cgi?id=77648

Breaking mac and gtk tests due to font differences. (Requested
by _pdr_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

• platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

• svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

• svg/SVGFontData.h:

(SVGFontData):

LayoutTests:

• svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
• svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
• svg/custom/glyph-selection-arabic-forms.svg: Removed.
• svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
• svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
• svg/custom/glyph-selection-bidi-mirror.svg: Removed.
• svg/custom/glyph-selection-non-bmp-expected.png: Removed.
• svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
• svg/custom/glyph-selection-non-bmp.svg: Removed.

9:15 AM Changeset in webkit [106562] by kubo@profusion.mobi

• 2 edits in trunk/Source/WebKit/efl

[EFL] Remove check for ENABLE_GTK_PLUGINS_SUPPORT
​https://bugs.webkit.org/show_bug.cgi?id=77647

Reviewed by Martin Robinson.

There is no clear reason why this check was in place (it came with the
upstreaming of the port), but ENABLE_GTK_PLUGINS_SUPPORT is not set
anywhere, and the build system does not even check for the presence of
GTK+ when building.

• ewk/ewk_main.cpp:

(_ewk_init_body):

8:59 AM Changeset in webkit [106561] by msaboff@apple.com

• 2 edits in trunk/Tools

Add myself as a reviewer.

8:51 AM WebKit Team edited by msaboff@apple.com

(diff)

8:40 AM Changeset in webkit [106560] by apavlov@chromium.org

• 3 edits
  2 adds in trunk

Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
​https://bugs.webkit.org/show_bug.cgi?id=77643

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-during-dom-traversal.html

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):

LayoutTests:

• inspector/styles/updates-during-dom-traversal-expected.txt: Added.
• inspector/styles/updates-during-dom-traversal.html: Added.

8:28 AM Changeset in webkit [106559] by commit-queue@webkit.org

• 13 edits in trunk/Source

[GTK] WebKitWebView won't work in a GtkOffscreenWindow
​https://bugs.webkit.org/show_bug.cgi?id=76911

Patch by Claudio Saavedra <Claudio Saavedra> and Martin Robinson <​mrobinson@igalia.com> on 2012-02-02
Reviewed by Philippe Normand.

Source/WebCore:

• platform/gtk/GtkUtilities.cpp:

(WebCore::widgetIsOnscreenToplevelWindow): Added this helper.

• platform/gtk/GtkUtilities.h:

(WebCore): Added helper declaration.

Source/WebKit/gtk:

• WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::windowRect): Use the new widgetIsOnscreenToplevelWindow helper.
(WebKit::ChromeClient::setWindowRect): Ditto.
(WebKit::ChromeClient::unfocus): Ditto.
(WebKit::ChromeClient::runOpenPanel): Ditto.

• tests/testwebview.c: Added a test to ensure that loading a page in an offscreen window does not crash.
• webkit/webkitglobals.cpp:

(currentToplevelCallback):

• webkit/webkitwebframe.cpp:

(webkit_web_frame_print_full):
(webkit_web_frame_print):

• webkit/webkitwebview.cpp:

(webkit_web_view_focus_in_event):
(webkit_web_view_script_dialog):

Source/WebKit2:

• UIProcess/API/gtk/WebKitUIClient.cpp:

(getWindowFrame): Use the new helper.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateJavaScriptDialog): Ditto

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): Ditto.
(webkitWebViewBaseSizeAllocate): Ditto.
(webkitWebViewBaseFocusInEvent): Ditto.

7:53 AM Changeset in webkit [106558] by tonyg@chromium.org

• 2 edits in trunk/LayoutTests

fast/speech/bubble-position.html fails on mac
​https://bugs.webkit.org/show_bug.cgi?id=77641

Unreviewed expectations update.

• platform/chromium/test_expectations.txt: Test introduced by 106438, never passed on mac.

7:48 AM Changeset in webkit [106557] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.

• platform/qt-mac/Skipped:

7:27 AM Changeset in webkit [106556] by tonyg@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed rebaseline of imperceptible shadow change.

• platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:

7:13 AM Changeset in webkit [106555] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r106551.

• platform/qt/Skipped: Skip new tests because of missing testfonts.

7:09 AM Changeset in webkit [106554] by commit-queue@webkit.org

• 7 edits in trunk/Source

Source/WebCore: Update active and hover state on touch release.
​https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.

• rendering/HitTestRequest.h:

(WebCore::HitTestRequest::move):
(WebCore::HitTestRequest::release):
(WebCore::HitTestRequest::touchEvent):
(WebCore::HitTestRequest::mouseEvent):
(WebCore::HitTestRequest::touchMove):
(WebCore::HitTestRequest::touchRelease):

Rename the enum values in HitTestRequest to be mouse/touch
agnostic, and add value for recognizing touch events.

• rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::nodeAtPoint): Update for HitTestRequest rename.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest): ditto
(WebCore::RenderLayer::updateHoverActiveState): Reset hoverstate on touch release.

• page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDrag): Update for HitTestRequest rename.
(WebCore::EventHandler::handleMouseMoveEvent): ditto
(WebCore::EventHandler::handleMouseReleaseEvent): ditto
(WebCore::EventHandler::hoverTimerFired): ditto
(WebCore::EventHandler::dragSourceEndedAt): ditto
(WebCore::EventHandler::handleTouchEvent): Hittest touch release to reset

active and hover states and add touch enum to all touch hittests.

Source/WebKit/chromium: Update enum name for HitTestRequest::RequestType
​https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

6:47 AM Changeset in webkit [106553] by Csaba Osztrogonác

• 2 edits
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening after r106487
​https://bugs.webkit.org/show_bug.cgi?id=77628

Patch by János Badics <​dicska@gmail.com> on 2012-02-02

• platform/qt-wk2/Skipped: Skip the test made fast/events/resize-subframe.html timeout.
• platform/qt/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

6:42 AM BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org

Add information about qt5 packages for n9. (diff)

6:28 AM Changeset in webkit [106552] by pfeldman@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: enable editing of selected rows on single click in elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=77627

Reviewed by Vsevolod Vlasov.

• inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.onattach):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype._mouseDown):

• inspector/front-end/treeoutline.js:

(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.select):

6:27 AM Changeset in webkit [106551] by commit-queue@webkit.org

• 5 edits
  9 adds in trunk

Fix mirroring with SVG fonts
​https://bugs.webkit.org/show_bug.cgi?id=77067

Patch by Philip Rogers <​pdr@google.com> on 2012-02-02
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg

svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg

• platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

• svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):

• svg/SVGFontData.h:

(SVGFontData):

LayoutTests:

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

• svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
• svg/custom/glyph-selection-arabic-forms.svg: Added.
• svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
• svg/custom/glyph-selection-bidi-mirror.svg: Added.
• svg/custom/glyph-selection-non-bmp-expected.txt: Added.
• svg/custom/glyph-selection-non-bmp.svg: Added.

6:25 AM Changeset in webkit [106550] by pfeldman@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: add experiment for single click styles editing.
​https://bugs.webkit.org/show_bug.cgi?id=77624

Reviewed by Vsevolod Vlasov.

• inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype._mouseDown):
(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):

6:13 AM Changeset in webkit [106549] by kkristof@inf.u-szeged.hu

• 2 edits in trunk/Tools

Add myself as a commiter

5:58 AM Changeset in webkit [106548] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, marking a new test as flaky on GTK.

• platform/gtk/test_expectations.txt:

fast/forms/radio/radio-group.html fails on and off.

5:53 AM Changeset in webkit [106547] by kenneth@webkit.org

• 2 edits in trunk/Source/WebCore

Make the tap highlighting work for all test cases
​https://bugs.webkit.org/show_bug.cgi?id=77626

Reviewed by Simon Hausmann.

Clean up of the current code to make it more generic. Now uses
addFocusRingRects for finding the areas to highlight.

Tested by current manual tests.

• page/GestureTapHighlighter.cpp:

(WebCore::GestureTapHighlighter::pathForNodeHighlight):

5:42 AM Changeset in webkit [106546] by Philippe Normand

• 2 edits
  1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline and skipping 3 new test failures.

• platform/gtk/Skipped:
• platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

5:18 AM Changeset in webkit [106545] by mario@webkit.org

• 4 edits in trunk/Source

[Gtk] atk_text_get_text_at_offset() sometimes fails to provide the correct line
​https://bugs.webkit.org/show_bug.cgi?id=72382

Reviewed by Martin Robinson.

Source/WebCore:

Do not add unnecesary blanks at the end of a line of text.

• accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer): Do not just append a '\n' at the end of a line
if the linebreak for that line was already considered.

Source/WebKit/gtk:

New unit test to ensure the right line is retrieved for the first
position of each line in a multiline preformatted portion of text.

• tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithPreformattedText): New unit test.
(main): Add the new unit test.

2:25 AM Changeset in webkit [106544] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Regions should ignore the saved currentRenderFlowThread during repainting
because if there are imbricated flow threads, it might end using the wrong one.

[CSSRegions] Assert failure in RenderView::computeRectForRepaint
​https://bugs.webkit.org/show_bug.cgi?id=77430

Patch by Raul Hudea <​rhudea@adobe.com> on 2012-02-02
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/imbricated-flow-threads-crash.html

• rendering/RenderFlowThread.cpp:

(CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):
(WebCore):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

• fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
• fast/regions/imbricated-flow-threads-crash.html: Added.

2:24 AM Changeset in webkit [106543] by rniwa@webkit.org

• 4 edits
  1 add in trunk

[PerformanceTests] tests have dependencies
​https://bugs.webkit.org/show_bug.cgi?id=77506

Reviewed by Hajime Morita.

PerformanceTests:

• resources/init.html: Added.

Tools:

Load an initialization page before each test after starting a DRT so that
warming up DRT won't affect the performance test results.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):
(test_initial_page_loaded):
(test_initial_page_loaded.run_test):

1:31 AM Changeset in webkit [106542] by kinuko@chromium.org

• 16 edits in trunk/Source

Cleanup: Move chrome-specific filesystem type handling code (for FileSystem API) under chromium directory (re-landing r105395)
​https://bugs.webkit.org/show_bug.cgi?id=76551

Source/WebCore:

Reviewed by David Levin.

Moved the implementation of crackFileSystemURL() and toURL() from
WebCore/fileapi/DOMFileSystemBase into WebCore/platform/AsyncFileSystem
so that each platform can extend/implement their behavior if necessary.

No new tests as it has no functional changes.

• fileapi/DOMFileSystemBase.cpp: Moved crackFileSystemURL() to AsyncFileSystem.
• fileapi/DOMFileSystemBase.h:

(DOMFileSystemBase):

• fileapi/EntryBase.cpp: Moved toURL() to AsyncFileSystem.

(WebCore::EntryBase::toURL):

• page/DOMWindow.cpp: Made corresponding callsite changes.

(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):

• page/DOMWindow.h:
• platform/AsyncFileSystem.cpp:

(WebCore::AsyncFileSystem::isValidType): Added.

• platform/AsyncFileSystem.h:

(AsyncFileSystem):

• workers/WorkerContext.cpp: Made corresponding callsite changes.

(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
(WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):

• workers/WorkerContext.h:

Source/WebKit/chromium:

• src/AssertMatchingEnums.cpp: Removed the matching assertion for AsyncFileSystem::External (as now we directly use WebFileSystem::TypeExternal).
• src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL): Added.
(WebCore::AsyncFileSystem::isValidType): Added.
(WebCore::AsyncFileSystemChromium::toURL): Added.

• src/AsyncFileSystemChromium.h:

(AsyncFileSystemChromium):

• src/WorkerAsyncFileSystemChromium.cpp: Made this subclass of AsyncFileSystemChromium (rather than that of AsyncFileSystem)

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):

• src/WorkerAsyncFileSystemChromium.h:

(WorkerAsyncFileSystemChromium):

1:12 AM Changeset in webkit [106541] by yurys@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: pause on uncaugh exceptions state is not properly restored
​https://bugs.webkit.org/show_bug.cgi?id=77558

'Pause on exceptions' state is now stored in InspectorState object so that it is
properly restored on inspected process change.

Reviewed by Vsevolod Vlasov.

• inspector/InspectorDebuggerAgent.cpp:

(DebuggerAgentState):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::restore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
(WebCore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):

• inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

12:27 AM Changeset in webkit [106540] by rniwa@webkit.org

• 3 edits in trunk/Tools

Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.init):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):

12:23 AM Changeset in webkit [106539] by haraken@chromium.org

• 3 edits
  2 adds in trunk

The third argument of addEventListener/removeEventListener of PeerConnection should be optional
​https://bugs.webkit.org/show_bug.cgi?id=77606

Reviewed by Adam Barth.

Source/WebCore:

This patch corrects a typo in PeerConnection.idl, i.e. [optional] => [Optional].

Test: fast/mediastream/peerconnection-eventlistener-optional-argument.html

• mediastream/PeerConnection.idl:

LayoutTests:

The added test confirms if the third argument of addEventListener() and
removeEventListener() is optional.

• fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Added.
• fast/mediastream/peerconnection-eventlistener-optional-argument.html: Added.

12:09 AM Changeset in webkit [106538] by commit-queue@webkit.org

• 3 edits
  1 add in trunk

hidden attribute on <input type=file /> suppresses the file selection dialog
​https://bugs.webkit.org/show_bug.cgi?id=58208

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2012-02-02
Reviewed by Ryosuke Niwa.

.:

• ManualTests/input-file-hidden-open-dialog-on-click.html: Added.

Adding manual test as the file dialog opens only in User gesture.

Source/WebCore:

We want to allow opening file dialog on hidden element when click() is called
on the element. The behaviour is similar to Firefox and IE.

Added manual test as the file dialog opens only on user gesture.

• html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
Removed renderer check as input can be hidden.

12:04 AM Changeset in webkit [106537] by Philippe Normand

• 13 edits in trunk

[GStreamer] FFTFrame implementation
​https://bugs.webkit.org/show_bug.cgi?id=73545

Reviewed by Chris Rogers.

.:

• configure.ac: Enable the WebAudio option again and remove

libfftw checks.

Source/WebCore:

FFTFrame implementation based on GStreamer's FFT processing
library.

No new tests, existing WebAudio tests cover this.

• GNUmakefile.am:
• GNUmakefile.list.am:
• platform/audio/FFTFrame.h:
• platform/audio/FFTFrameStub.cpp:
• platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.

(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):

Source/WebKit/gtk:

• GNUmakefile.am: Remove libfftw compilation flags.

Source/WebKit2:

• GNUmakefile.am: Remove libfftw compilation flags.

LayoutTests:

• webaudio/resources/convolution-testing.js:

(checkTail1): Adapt convolution threshold for GStreamerFFTFrame
implementation, as advised by Chris Rogers.

12:00 AM Changeset in webkit [106536] by haraken@chromium.org

• 9 edits in trunk/Source/WebCore

Rename [CheckFrameSecurity] and [SVGCheckSecurity] to [CheckAccessToNode]
​https://bugs.webkit.org/show_bug.cgi?id=77601

Reviewed by Adam Barth.

[CheckFrameSecurity] and [SVGCheckSecurity] have the same meaning; i.e. generate code
to check allowAccessToNode() for a given attribute or method. This patch renames them
to [CheckAccessToNode].

No tests. No changes in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

• html/HTMLEmbedElement.idl:
• html/HTMLFrameElement.idl:
• html/HTMLIFrameElement.idl:
• html/HTMLObjectElement.idl:

• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/V8/V8TestObj.cpp: Updated the test results.

(WebCore):