⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 5, 2012:

11:54 PM Changeset in webkit [106779] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION detached dom nodes aren't highlighted
​https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

11:52 PM Changeset in webkit [106778] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
​https://bugs.webkit.org/show_bug.cgi?id=77850

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):

11:39 PM Changeset in webkit [106777] by yurys@chromium.org
  • 27 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
​https://bugs.webkit.org/show_bug.cgi?id=77444

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.

All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes.get_fixed_data):
(Generator.go):

  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorFileSystemAgent.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::sendMessageToWorker):

  • inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

11:06 PM Changeset in webkit [106776] by haraken@chromium.org
  • 52 edits in trunk/Source/WebCore

Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
​https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm: Added FIXME.

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GetNativeTypeFromSignature):

  • bindings/scripts/test/TestObj.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/ShadowRoot.idl:
  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGScriptElement.idl:
10:44 PM Changeset in webkit [106775] by fpizlo@apple.com
  • 15 edits
    2 adds in trunk/Source/JavaScriptCore

DFG's child references from one node to another should have room for type information
​https://bugs.webkit.org/show_bug.cgi?id=77797

Reviewed by Oliver Hunt.

The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).

The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.

This is performance-neutral on all benchmarks we track.

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):

  • dfg/DFGNodeReferenceBlob.h: Added.

(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):

  • dfg/DFGNodeUse.h: Added.

(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

9:55 PM Changeset in webkit [106774] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
8:47 PM Changeset in webkit [106773] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename [JSCCustom*] IDL to [JSCustom*] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSStyleDeclaration.idl:
  • html/HTMLDocument.idl:
  • html/canvas/DataView.idl:
  • page/DOMWindow.idl:
  • page/MemoryInfo.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
8:01 PM Changeset in webkit [106772] by commit-queue@webkit.org
  • 14 edits
    1 add in trunk

[EFL] Enable WebGL with glx backend
​https://bugs.webkit.org/show_bug.cgi?id=77308

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-05
Reviewed by Martin Robinson.

.:

Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.

  • Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.

Source/WebCore:

Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.

No new tests required. We can verify this feature with the existing test cases.

  • CMakeLists.txt: Revised common files required for WebGL.
  • PlatformEfl.cmake: Added EFL specific files.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):

  • platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.

(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Source/WebKit/efl:

Activated WebGL feature.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

7:53 PM Changeset in webkit [106771] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in FormSubmission::create.
​https://bugs.webkit.org/show_bug.cgi?id=77813

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/form-submission-create-crash.xhtml

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

LayoutTests:

  • fast/forms/form-submission-create-crash-expected.txt: Added.
  • fast/forms/form-submission-create-crash.xhtml: Added.
6:25 PM Changeset in webkit [106770] by kling@webkit.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Remove unused file MappedAttributeEntry.h.
<​http://webkit.org/b/77841>

Reviewed by Anders Carlsson.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/MappedAttributeEntry.h: Removed.
  • dom/StyledElement.h:
6:21 PM Changeset in webkit [106769] by kling@webkit.org
  • 253 edits in trunk/Source/WebCore

StyledElement: Rename parseMappedAttribute() to parseAttribute().
<​http://webkit.org/b/77830>

Reviewed by Anders Carlsson.

Rename across the board and decorate subclasses with OVERRIDE.

6:06 PM Changeset in webkit [106768] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed syntax fix.

  • English.lproj/localizedStrings.js:
5:33 PM Changeset in webkit [106767] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Swedish buildfix.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

4:43 PM Changeset in webkit [106766] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

The scrolling tree should be aware of any wheel event handlers on the page
​https://bugs.webkit.org/show_bug.cgi?id=77840

Reviewed by Andreas Kling.

If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.

(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.

2:27 PM Changeset in webkit [106765] by abarth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline xss-inactive-closure.html. This test "fails" because of a
subtle difference in how V8 and JSC do security checks. Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow. I'm
working on fixing these differences in bugs like
​https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.

In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.

  • platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [106764] by abarth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline xss-DENIED-defineProperty. These V8-specific results appear
to also be passing, just with slightly fewer console messages.

  • platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:02 PM Changeset in webkit [106763] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Further cleanup of failing and flaky security LayoutTests. This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [106762] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test is no longer flaky. It appears to pass all the time.

  • platform/chromium/test_expectations.txt:
10:51 AM Changeset in webkit [106761] by mitz@apple.com
  • 7 edits in trunk

<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
​https://bugs.webkit.org/show_bug.cgi?id=77823

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

6:02 AM Changeset in webkit [106760] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove g_thread_init() calls
​https://bugs.webkit.org/show_bug.cgi?id=77828

Reviewed by Andreas Kling.

g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

1:36 AM Changeset in webkit [106759] by gyuyoung.kim@samsung.com
  • 4 edits in trunk

[CMAKE] Support javascriptcore test for EFL port.
​https://bugs.webkit.org/show_bug.cgi?id=77425

Reviewed by Daniel Bates.

Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.

.:

  • Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.

Source/JavaScriptCore:

  • shell/CMakeLists.txt:
1:27 AM Changeset in webkit [106758] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

[CMAKE] Do not build Tools when building jsc only.
​https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

  • CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.
1:26 AM Changeset in webkit [106757] by kling@webkit.org
  • 14 edits in trunk/Source/WebCore

Remove mapped vs non-mapped attribute distinction.
<​http://webkit.org/b/77827>

Reviewed by Antti Koivisto.

Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.

The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):

  • dom/Document.cpp:

(WebCore::Document::createAttributeNS):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):

  • dom/StyledElement.h:

(StyledElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/parser/MarkupTokenBase.h:

(WebCore::::initializeAttributes):

12:29 AM Changeset in webkit [106756] by kling@webkit.org
  • 18 edits
    2 deletes in trunk/Source/WebCore

Kill CSSMappedAttributeDeclaration.
<​http://webkit.org/b/77820>

Reviewed by Antti Koivisto.

Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.

This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CSSMappedAttributeDeclaration.cpp: Removed.
  • dom/CSSMappedAttributeDeclaration.h: Removed.
  • dom/DOMAllInOne.cpp:

Remove CSSMappedAttributeDeclaration.{cpp,h}

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
directly instead. We lose the benefit of caching new CSSValues in the
document's CSSValuePool but this optimization can be added back later.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

12:27 AM Changeset in webkit [106755] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: beautify retaining tree items view.
​https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/heapProfiler.css:

(.cycled-ancessor-node):

  • inspector/front-end/profilesPanel.css:

Feb 4, 2012:

10:13 PM Changeset in webkit [106754] by shawnsingh@chromium.org
  • 5 edits in trunk/Source

[chromium] Add support to force full damage in CCDamageTracker
​https://bugs.webkit.org/show_bug.cgi?id=76805

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCDamageTrackerTest.cpp.

This feature is needed for events that should cause the entire
surface to be damaged, even if layers themselves had only partial
damage or no damage at all. For example, tab-switching is one such
event.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::CCDamageTracker):
(WebCore::CCDamageTracker::updateDamageRectForNextFrame):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(WebCore::CCDamageTracker::forceFullDamageNextUpdate):
(CCDamageTracker):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

6:53 PM Changeset in webkit [106753] by mitz@apple.com
  • 9 edits in trunk

<rdar://problem/10660698> Clients cannot prevent caching of individual responses
​https://bugs.webkit.org/show_bug.cgi?id=77822

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/APIClientTraits.cpp: Added definition of interfaceSizesByVersion for

WKBundlePageResourceLoadClient.

  • Shared/APIClientTraits.h: Added APIClientTraits specialization for WKBundlePageResourceLoadClient.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added WKBundlePageShouldCacheResponseCallback

typedef, added shouldCacheResponse member to WKBundlePageResourceLoadClient, and bumped
kWKBundlePageResourceLoadClientCurrentVersion to 1.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse): Added. Calls through
to the client if it implements shouldCacheResponse. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse() and return nil if the former
returns false.
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse().

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

5:03 PM Changeset in webkit [106752] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Remove dead code from ScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=77821

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):

4:55 PM Changeset in webkit [106751] by weinig@apple.com
  • 7 edits
    2 adds in trunk

Add ability to send WKURLRequests in WebKit2 API user messages
​https://bugs.webkit.org/show_bug.cgi?id=77819

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WebKit2UserMessageRoundTripTest API test.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encode/decode for WebURLRequest.

Tools:

Add testing for round-tripping WKTypes from the UIProcess,
to the WebProcess, and back.

  • This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef. More can easily be added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.

(TestWebKitAPI):
(WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.

(TestWebKitAPI):
(UserMessageTest):
(TestWebKitAPI::UserMessageTest::UserMessageTest):
(TestWebKitAPI::UserMessageTest::didReceiveMessage):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
4:43 PM Changeset in webkit [106750] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

The scrolling tree should inform the main scrolling coordinator when the scroll position changes
​https://bugs.webkit.org/show_bug.cgi?id=77818

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
Set the main frame scroll position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Call ScrollingCoordinator::updateMainFrameScrollPosition on the main thread.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call ScrollingTree::updateMainFrameScrollPosition.

4:18 PM Changeset in webkit [106749] by mitz@apple.com
  • 7 edits in trunk

<rdar://problem/10772406> WKPreferences instances cannot be copied
​https://bugs.webkit.org/show_bug.cgi?id=77816

Reviewed by Sam Weinig.

Source/WebKit2:

Test added in TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences): Added this constructor that copies the
WebPreferencesStore of the given WebPreferences.

  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::create): Added this create function that takes a WebPreferences
instance and creates a new instance with a copy of the given instance’s store.

Tools:

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

3:49 PM Changeset in webkit [106748] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rubber stamped by Sam Weinig.

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::quantifyAtom):

  • Fix comment.
2:56 PM Changeset in webkit [106747] by commit-queue@webkit.org
  • 2 edits in trunk

Fix bug in svg-link-hover-use.svg
​https://bugs.webkit.org/show_bug.cgi?id=77768

Patch by Philip Rogers <​pdr@google.com> on 2012-02-04
Reviewed by Eric Seidel.

  • ManualTests/svg-link-hover-use.svg:
2:56 PM Changeset in webkit [106746] by kling@webkit.org
  • 19 edits in trunk/Source/WebCore

Element: Remove unnecessary attributeChanged() argument.
<​http://webkit.org/b/77814>

Reviewed by Ryosuke Niwa.

Remove the 'preserveDecls' argument to Element::attributeChanged() as that is no
longer needed after the removal of per-attribute style declarations.
Decorated subclass overrides with OVERRIDE since we're touching the lines.

Also removed an old inaccurate comment in NamedNodeMap::setAttributes() - calling
attributeChanged() is absolutely necessary to initialize element-specific state.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:

(StyledElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::attributeChanged):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::attributeChanged):

  • svg/SVGAnimationElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

  • svg/SVGElement.h:

(SVGElement):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::attributeChanged):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

2:44 PM Changeset in webkit [106745] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] CurrentTime: Reorder headers for win32
​https://bugs.webkit.org/show_bug.cgi?id=77808

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

In GTK+ win32 port, monotonicallyIncreasingTime() implementation is
based on g_get_monotonic_time(). Reorder headers to make sure glib.h
gets included even when the platform is win32.

CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
CurrentTime.cpp:321:53: error: 'g_get_monotonic_time' was not declared in this scope
CurrentTime.cpp:322:1: warning: control reaches end of non-void function [-Wreturn-type]

  • wtf/CurrentTime.cpp:
2:40 PM Changeset in webkit [106744] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when reparenting children of flexible boxes
​https://bugs.webkit.org/show_bug.cgi?id=77458

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

This fixes some regressions I introduced in r106150. RenderBlock::
removeChild needs to be careful about not collapsing anonymous
blocks underneath flexible boxes, and also about node ordering
when there is an after block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild):

LayoutTests:

This test case reparents a block node from under a flexible box so
that only anonymous blocks and floating generated blocks remain.
A recent patch caused these anonymous blocks to be collapsed, which
is incorrect.

  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash-expected.txt: Added
  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html: Added
2:26 PM Changeset in webkit [106743] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Debug build fix after r106715.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::create):

2:24 PM Changeset in webkit [106742] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Use the wide character version of win32 API by default
​https://bugs.webkit.org/show_bug.cgi?id=77809

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

Certain win32-specific files (like PluginDatabaseWin.cpp) make the
assumption that the wide character version of win32 API is the default.
Define _UNICODE and UNICODE to do this, similar to what other win32
ports are doing.

  • GNUmakefile.am:
1:31 PM Changeset in webkit [106741] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed test fix after r106740.
<​http://webkit.org/b/77204>

Disable matched declaration caching for elements with attribute style until we can
figure out how it's supposed to work.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

4:24 AM Changeset in webkit [106740] by kling@webkit.org
  • 74 edits in trunk

Kill per-Attribute style declarations.
<​http://webkit.org/b/77204>

Reviewed by Antti Koivisto.

Source/WebCore:

TL;DR summary: Remove the per-Attribute style declarations and replace them by a single
style declaration on StyledElement that acts as a secondary inline style.

The previous design was conceived in the Age of the Old Web(tm) where the majority of
element styling was accomplished via attributes. Nowadays, CSS is a much better tool for
this and we should optimize around that instead.

StyledElements now have an attributeStyle() which contains all the styling from attributes.
parseMappedAttribute() is responsible for adding/removing properties to the attributeStyle
as the corresponding attributes come in/out of the element.

Each Attribute instance shrinks by one pointer, each element that has attributes grows by
one pointer. The styles from individual attributes are no longer shared, so content that
uses a lot of repeating styling attributes will see a slight memory regression from this.
Future improvements to this could enable sharing the attributeStyle between elements that
have the same exact attributes to mitigate some of the damage.

There should be no web-facing behavior change from this, but it does break two things:

  • The Inspector feature for displaying per-attribute styles. To keep things manageable, this patch simply files all the attribute styles together under an anonymous attribute in the Inspector.
  • The Obj-C DOM binding for Attr::style() has to be kept for compatibility reasons, though it's already deprecated. It will now always return nil, since there's no way to retrieve a live style declaration that's specific to a certain Attr.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

  • dom/Attr.h:

(WebCore):
(Attr):
(WebCore::Attr::style):

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore):
(WebCore::Attribute::create):
(WebCore::Attribute::createMapped):
(Attribute):
(WebCore::Attribute::Attribute):

  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):

  • dom/CSSMappedAttributeDeclaration.h:

(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):
(WebCore):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::parseMappedAttribute):

  • html/HTMLBRElement.h:

(HTMLBRElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):

  • html/HTMLBodyElement.h:

(HTMLBodyElement):

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::parseMappedAttribute):

  • html/HTMLDivElement.h:

(HTMLDivElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttribute):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::removeHTMLAlignment):
(WebCore):
(WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
(WebCore::HTMLElement::setContentEditable):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):

  • html/HTMLEmbedElement.h:

(HTMLEmbedElement):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::parseMappedAttribute):

  • html/HTMLFontElement.h:

(HTMLFontElement):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

  • html/HTMLFrameSetElement.h:

(HTMLFrameSetElement):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::parseMappedAttribute):

  • html/HTMLHRElement.h:

(HTMLHRElement):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • html/HTMLIFrameElement.h:

(HTMLIFrameElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::parseMappedAttribute):

  • html/HTMLLIElement.h:

(HTMLLIElement):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::parseMappedAttribute):

  • html/HTMLMarqueeElement.h:

(HTMLMarqueeElement):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::parseMappedAttribute):

  • html/HTMLOListElement.h:

(HTMLOListElement):

  • html/HTMLOutputElement.cpp:
  • html/HTMLOutputElement.h:

(HTMLOutputElement):

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::parseMappedAttribute):

  • html/HTMLParagraphElement.h:

(HTMLParagraphElement):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::parseMappedAttribute):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::parseMappedAttribute):

  • html/HTMLPreElement.h:

(HTMLPreElement):

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::parseMappedAttribute):

  • html/HTMLTableCaptionElement.h:

(HTMLTableCaptionElement):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::parseMappedAttribute):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTablePartElement.cpp:

(WebCore):
(WebCore::HTMLTablePartElement::parseMappedAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::parseMappedAttribute):

  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::parseMappedAttribute):

  • html/HTMLUListElement.h:

(HTMLUListElement):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseMappedAttribute):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::parseMappedAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseMappedAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::parseMappedAttribute):
(WebCore::SVGStyledElement::getPresentationAttribute):

  • svg/SVGStyledElement.h:

(SVGStyledElement):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::parseMappedAttribute):

LayoutTests:

Rebaselined 3 inspector tests since attribute styles are no longer shown per-attribute.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
2:22 AM Changeset in webkit [106739] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
​https://bugs.webkit.org/show_bug.cgi?id=77802

Reviewed by Eric Seidel.

This patch refactors our directory grouping code into base.js where it
can be shared between failures.js and notifications.js. It then adds
an Examine action to each group of failures that triggers the "results"
view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2:20 AM Changeset in webkit [106738] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: get rid of cycles in retaining tree
​https://bugs.webkit.org/show_bug.cgi?id=77801

Drive by fix: 'retained by' prefix was removed.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/profilesPanel.css:

(.cycled-ancessor-node):

2:12 AM Changeset in webkit [106737] by haraken@chromium.org
  • 152 edits in trunk/Source/WebCore

Add the "JS" prefix to JSC specific IDL attributes
​https://bugs.webkit.org/show_bug.cgi?id=77693

Reviewed by Darin Adler.

Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.

This patch renames the following JSC specific IDLs:

CustomFinalize => JSCustomFinalize
CustomIsReachable => JSCustomIsReachable
CustomMarkFunction => JSCustomMarkFunction
CustomToJS => JSCustomToJS
CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
GenerateIsReachable => JSGenerateIsReachable
GenerateToJS => JSGenerateToJS
NoStaticTables => JSNoStaticTables
WindowEventListener => JSWindowEventListener
InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation):

  • bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/Attr.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringMap.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/NodeList.idl:
  • dom/TreeWalker.idl:
  • dom/WebKitNamedFlow.idl:
  • fileapi/Blob.idl:
  • fileapi/DOMFileSystem.idl:
  • fileapi/DOMFileSystemSync.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/DirectoryReaderSync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/EntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • fileapi/FileWriter.idl:
  • fileapi/Metadata.idl:
  • fileapi/OperationNotAllowedException.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFrameSetElement.idl:
  • html/ImageData.idl:
  • html/MediaController.idl:
  • html/TextTrack.idl:
  • html/TextTrackCue.idl:
  • html/VoidCallback.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/CanvasRenderingContext.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/TextTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • mediastream/LocalMediaStream.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/Geolocation.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Screen.idl:
  • page/WorkerNavigator.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Database.idl:
  • storage/DatabaseSync.idl:
  • storage/IDBAny.idl:
  • storage/IDBKey.idl:
  • storage/SQLError.idl:
  • storage/SQLException.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionSync.idl:
  • storage/Storage.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGPathSeg.idl:
  • webaudio/AudioBufferCallback.idl:
  • webaudio/AudioBufferSourceNode.idl:
  • webaudio/AudioContext.idl:
  • webaudio/AudioDestinationNode.idl:
  • webaudio/AudioGain.idl:
  • webaudio/AudioGainNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioProcessingEvent.idl:
  • webaudio/BiquadFilterNode.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DelayNode.idl:
  • webaudio/DynamicsCompressorNode.idl:
  • webaudio/HighPass2FilterNode.idl:
  • webaudio/JavaScriptAudioNode.idl:
  • webaudio/LowPass2FilterNode.idl:
  • webaudio/MediaElementAudioSourceNode.idl:
  • webaudio/OfflineAudioCompletionEvent.idl:
  • webaudio/RealtimeAnalyserNode.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/CloseEvent.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XPathResult.idl:
2:09 AM Changeset in webkit [106736] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

http/tests/security/xss-eval fails due to difference in JSC and V8 eval
​https://bugs.webkit.org/show_bug.cgi?id=77806

Reviewed by Eric Seidel.

Both the JSC and V8 behaviors are reasonable in this case. This patch
modifies the test to show that either behavior isn't a security
vulnerability.

  • http/tests/security/xss-eval.html:
  • platform/chromium/http/tests/security/xss-eval-expected.txt:
  • platform/chromium/test_expectations.txt:
1:50 AM Changeset in webkit [106735] by ojan@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style is throwing an exception
​https://bugs.webkit.org/show_bug.cgi?id=77744

Reviewed by David Levin.

If the test_list is None, then we don't need to check for unsupported
feature tests to skip.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._has_test_in_directories):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_skipped_tests_for_unsupported_features_empty_test_list):

1:42 AM Changeset in webkit [106734] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Convert RenderTheme over to new layout abstraction
​https://bugs.webkit.org/show_bug.cgi?id=77783

Reviewed by Eric Seidel.

Change the RenderTheme classes to use the new layout abstraction as a
part of the ongoing conversion work.

No new tests.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::baselinePosition):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):

  • rendering/RenderTheme.h:

(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

1:40 AM Changeset in webkit [106733] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

IndexedDB: mark quota layout test WONTFIX
​https://bugs.webkit.org/show_bug.cgi?id=77459

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
1:26 AM Changeset in webkit [106732] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix multi-second hangs in compositor invalidating large layers
​https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

1:24 AM Changeset in webkit [106731] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes
​https://bugs.webkit.org/show_bug.cgi?id=77751

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-02-04
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/ClientExtension.cpp: Added.
  • blackberry/WebCoreSupport/ClientExtension.h: Added.
  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h: Added.
1:19 AM Changeset in webkit [106730] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: Patch by Swapna P <​spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
​https://bugs.webkit.org/show_bug.cgi?id=61558

Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect

Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests: Patch by Swapna P <​spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
​https://bugs.webkit.org/show_bug.cgi?id=61558

Did change inorder to print correct log as per the description provided in test case.

  • fast/events/autoscroll-with-non-scrollable-parent.html:
Note: See TracTimeline for information about the timeline view.