Context Navigation

← Previous Period
Next Period →

Timeline

Feb 6, 2012:

11:25 PM Changeset in webkit [106909] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

11:22 PM Changeset in webkit [106908] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/efl

[EFL] Define to prevent a single backing-store application from calling the tiled view function.
https://bugs.webkit.org/show_bug.cgi?id=77842

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

The define prevents an application using single backing store from calling tiled cache function.
The tiled APIs opened to outer should check the view type before being called.

ewk/ewk_private.h:
ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_frame_view_creation_notify):

ewk/ewk_view_tiled.cpp:

(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

11:09 PM Changeset in webkit [106907] by commit-queue@webkit.org

7 edits in trunk

Remove Element::ensureShadowRoot export.
https://bugs.webkit.org/show_bug.cgi?id=77932

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

Source/autotools/symbols.filter:

Source/WebCore:

Removes Element::ensureShadowRoot export.

No new tests, no change in behavior.

WebCore.exp.in:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

10:33 PM Changeset in webkit [106906] by abarth@webkit.org

5 edits in trunk/LayoutTests

http/tests/security/xssAuditor/cookie-injection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77908

Reviewed by Eric Seidel.

Before this patch, the output of this test depended on the state of the
global cookie store. When running tests in parallel, the cookie store
is shared by multiple tests, and so its state varies from run to run.

This patch changes this test to look only for the specific cookie used
by this test, which should make the test more reliable when run in
parallel with other tests.

http/tests/security/xssAuditor/cookie-injection-expected.txt:
http/tests/security/xssAuditor/resources/echo-intertag.pl:
platform/chromium/test_expectations.txt:

9:45 PM Changeset in webkit [106905] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Unreviewed. Web Inspector: rename Artificial to Synthetic according to v8 patch r10614.

inspector/front-end/DetailedHeapshotGridNodes.js:
inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isSynthetic):
(WebInspector.HeapSnapshot.prototype._init):

9:44 PM Changeset in webkit [106904] by commit-queue@webkit.org

17 edits in trunk/Source/WebKit/efl

[EFL] Adopt C++ style using camelCase and full variable names.
https://bugs.webkit.org/show_bug.cgi?id=76378

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

Modify the code to use camelCase and spell out variable names instead of using abbreviations.
Modify the comments which do not match with actual parameters and correct misspelled words.
Adopt EFL Coding style in header files.
The logic of the code is not changed.

ewk/ewk_cookies.h:
ewk/ewk_frame.cpp:

(ewk_frame_selection_get):
(ewk_frame_feed_focus_in):
(EWKPrivate::coreFrame):

ewk/ewk_frame.h:
ewk/ewk_history.cpp:

(ewk_history_item_new):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):

ewk/ewk_network.h:
ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_move):
(_ewk_tiled_backing_store_smart_resize):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

ewk/ewk_tiled_backing_store.h:

(_Ewk_Tile):

ewk/ewk_tiled_matrix.cpp:

(_Ewk_Tile_Matrix):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_free):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):

ewk/ewk_tiled_matrix.h:
ewk/ewk_tiled_model.cpp:

(tile_account):
(ewk_tile_updates_process):
(ewk_tile_unused_cache_tile_put):
(ewk_tile_unused_cache_dbg):

ewk/ewk_tiled_model.h:
ewk/ewk_util.h:
ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_pre_render_region):
(ewk_view_pre_render_region):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_get):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_get):
(ewk_view_zoom_range_set):

ewk/ewk_view.h:
ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_smart_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

9:09 PM Changeset in webkit [106903] by leo.yang@torchmobile.com.cn

3 edits in trunk/Source/WebKit

[BlackBerry] Use WebPagePrivate instead of WebPage in GeolocationControllerClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77927

Reviewed by Antonio Gomes.

WebKit/blackberry/Api/WebPage which has a d pointer is designed for public API.
GeolocationControllerClientBlackBerry in WebKit/blackberry/WebCoreSupport should
use the d pointer directly because the client is internal implementation.

No functionalities changed, no new tests.

blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::GeolocationControllerClientBlackBerry):
(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h:

(WebKit):
(GeolocationControllerClientBlackBerry):

8:47 PM Changeset in webkit [106902] by hayato@chromium.org

5 edits in trunk

Implement querySelector on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=77714

Reviewed by Dimitri Glazkov.

Source/WebCore:

dom/SelectorQuery.cpp:

(WebCore::nodeIsRootNodeOfTreeScope):
(WebCore):
(WebCore::SelectorDataList::execute):

LayoutTests:

fast/dom/shadow/shadow-root-js-api-expected.txt:
fast/dom/shadow/shadow-root-js-api.html:

8:41 PM Changeset in webkit [106901] by Martin Robinson

24 edits
3 adds
2 deletes in trunk

[GTK] Add TextureMapperGL implementation
https://bugs.webkit.org/show_bug.cgi?id=75308

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

GNUmakefile.am: TextureMapperGL implies USE(TEXTURE_MAPPER)
configure.ac: Only allow enabling the GL version of TextureMapper on X11.

Source/WebCore:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

No new tests. This will be covered by accelerated compositing and
3D CSS transform tests eventually.

GNUmakefile.list.am: Added some files necessary to build TextureMapperGL.
platform/graphics/cairo/TextureMapperGLCairo.cpp: Added implementations.
platform/graphics/cairo/TextureMapperGLCairo.h: Updated member list.
platform/graphics/gtk/WindowGLContext.h: Added.
platform/graphics/gtk/WindowGLContextGLX.cpp: Added.
platform/graphics/opengl/TextureMapperGL.cpp: Use the GL shims on GTK.

Source/WebKit/gtk:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

GNUmakefile.am: Add AcceleratedCompositingContextGL to the list.
WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Added some members for AcceleratedCompositingContextGL.

WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added empty implementations

for GraphicsLayerClient. This is only used for the GL variant.

WebCoreSupport/AcceleratedCompositingContextGL.cpp: Added.
WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::performAllPendingScrolls): Update the root layer while scrolling.
(WebKit::ChromeClient::paint): Update the root layer after painting.

webkit/webkitwebsettings.cpp: Added an enable-accelerated-compositing setting.
webkit/webkitwebsettingsprivate.h: Ditto.
webkit/webkitwebview.cpp:

(webkit_web_view_draw): Call into TextureMapper now.
(webkit_web_view_realize): Use gdk_window_ensure_native here.
(webkit_web_view_update_settings): Support the new enable-accelerated-compositing setting.
(webkit_web_view_settings_notify): Ditto.

Source/WebKit2:

Reviewed by Alejandro G. Castro.

Fix the WebKit2 + AC build for GTK+.

GNUmakefile.am: Add some missing source files.
UIProcess/DrawingAreaProxy.cpp:

(WebKit): Add USE(TILED_BACKING_STORE) to the guard.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Ditto.

WebProcess/WebPage/DrawingArea.h:

(DrawingArea): Ditto.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit): Ditto.

WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl): Ditto.

8:26 PM Changeset in webkit [106900] by eae@chromium.org

22 edits in trunk/Source/WebCore

Change baselinePosition and lineHeight to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=77905

Reviewed by Eric Seidel.

Change the virtual baselinePosition and lineHeight methods to return
LayoutUnits as they are both computed from the height and top/bottom
margins (or width and left/right margins for vertical text), all of
which are LayoutUnits.

No new tests.

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::baselinePosition):

platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::baselinePosition):

platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::baselinePosition):

platform/qt/RenderThemeQt.h:

(RenderThemeQt):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):

rendering/RenderListMarker.h:

(RenderListMarker):

rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

rendering/RenderSlider.h:

(RenderSlider):

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::baselinePosition):

rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::baselinePosition):

rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):

rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::baselinePosition):

rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

8:16 PM Changeset in webkit [106899] by wangxianzhu@chromium.org

7 edits in trunk/Source/WebCore

Avoid Page::updateViewportArguments() if the causing frame is not the main frame
https://bugs.webkit.org/show_bug.cgi?id=77387

Reviewed by Kenneth Rohde Christiansen.

dom/Document.cpp:

(WebCore::Document::processViewport):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):

dom/Document.h:

(Document):

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedIntoDocument):

page/Frame.cpp:

(WebCore::Frame::setDocument):

page/Page.cpp:

(WebCore::Page::viewportArguments):
(WebCore):

page/Page.h:

(Page):

8:05 PM Changeset in webkit [106898] by dgrogan@chromium.org

49 edits
2 deletes in trunk/LayoutTests

js-test-pre.js: relay calls to testPassed, testFailed, debug, etc from
worker to document.
https://bugs.webkit.org/show_bug.cgi?id=76762

Reviewed by Ojan Vafai.

fast/filesystem/resources/async-operations.js:
fast/filesystem/resources/directory-entry-to-uri.js:
fast/filesystem/resources/file-entry-to-uri-sync.js:
fast/filesystem/resources/file-entry-to-uri.js:
fast/filesystem/resources/file-from-file-entry-sync.js:
fast/filesystem/resources/file-from-file-entry.js:
fast/filesystem/resources/file-writer-abort-continue.js:
fast/filesystem/resources/file-writer-abort-depth.js:
fast/filesystem/resources/file-writer-abort.js:
fast/filesystem/resources/file-writer-events.js:
fast/filesystem/resources/file-writer-gc-blob.js:
fast/filesystem/resources/file-writer-sync-truncate-extend.js:
fast/filesystem/resources/file-writer-sync-write-overlapped.js:
fast/filesystem/resources/file-writer-truncate-extend.js:
fast/filesystem/resources/file-writer-write-overlapped.js:
fast/filesystem/resources/fs-worker-common.js:
fast/filesystem/resources/fs-worker-test-util.js: Removed.
fast/filesystem/resources/simple-persistent-sync.js:
fast/filesystem/resources/simple-persistent.js:
fast/filesystem/resources/simple-readonly.js:
fast/filesystem/resources/simple-required-arguments-getdirectory.js:
fast/filesystem/resources/simple-required-arguments-getfile.js:
fast/filesystem/resources/simple-required-arguments-getmetadata.js:
fast/filesystem/resources/simple-required-arguments-remove.js:
fast/filesystem/resources/simple-temporary-sync.js:
fast/filesystem/resources/simple-temporary.js:
fast/filesystem/resources/sync-operations.js:
fast/filesystem/workers/async-operations.html:
fast/filesystem/workers/file-entry-to-uri-sync.html:
fast/filesystem/workers/file-from-file-entry-sync.html:
fast/filesystem/workers/file-from-file-entry.html:
fast/filesystem/workers/file-writer-events.html:
fast/filesystem/workers/file-writer-gc-blob.html:
fast/filesystem/workers/file-writer-sync-truncate-extend.html:
fast/filesystem/workers/file-writer-sync-write-overlapped.html:
fast/filesystem/workers/file-writer-truncate-extend.html:
fast/filesystem/workers/file-writer-write-overlapped.html:
fast/filesystem/workers/simple-persistent-sync.html:
fast/filesystem/workers/simple-persistent.html:
fast/filesystem/workers/simple-temporary-sync.html:
fast/filesystem/workers/simple-temporary.html:
fast/filesystem/workers/sync-operations.html:
fast/js/resources/js-test-pre.js:

(testPassed):
(testFailed):
(finishJSTest):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):

storage/indexeddb/basics-workers.html:
storage/indexeddb/resources/basics.js:

8:01 PM Changeset in webkit [106897] by jchaffraix@webkit.org

2 edits
1 add in trunk/LayoutTests

Unreviewed gardening.

platform/chromium-mac-snowleopard/fast/canvas/check-stale-putImageData-expected.png: Added.

Yet another font difference.

platform/chromium/test_expectations.txt: Added LEOPARD to the list of flaky platforms.

7:52 PM Changeset in webkit [106896] by abarth@webkit.org

5 edits in trunk/LayoutTests

http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=65567

Reviewed by Eric Seidel.

My theory is that the extra log message is caused by the preload
scanner requesting the script, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
http/tests/security/mixedContent/insecure-script-in-iframe.html:
http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
platform/chromium/test_expectations.txt:

7:20 PM Changeset in webkit [106895] by Martin Robinson

6 edits in trunk

Fix some miscellaneous 'make dist' error for WebKitGTK+.

Source/WebCore:

GNUmakefile.list.am: Add some missing Shadow DOM files to the

source list.

Source/WebKit2:

GNUmakefile.am: Do not distribute generated files.

Tools:

MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated

files should not be distributed.

7:11 PM Changeset in webkit [106894] by abarth@webkit.org

5 edits in trunk/LayoutTests

http/tests/security/mixedContent/insecure-image-in-main-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77904

Reviewed by Darin Adler.

My theory is that the extra log message is caused by the preload
scanner requesting the image, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
http/tests/security/mixedContent/insecure-image-in-main-frame.html:
http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
platform/chromium/test_expectations.txt:

6:55 PM Changeset in webkit [106893] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by Anders Carlsson.

platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore):

platform/graphics/Region.h:

(Region):
(Shape):
(WebCore::operator==):
(WebCore):

6:43 PM Changeset in webkit [106892] by haraken@chromium.org

54 edits in trunk/Source/WebCore

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestTypedArray.idl:

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

css/WebKitCSSFilterValue.idl:
css/WebKitCSSTransformValue.idl:
dom/DOMCoreException.idl:
dom/Document.idl:
dom/EventException.idl:
dom/RangeException.idl:
fileapi/FileException.idl:
fileapi/OperationNotAllowedException.idl:
html/HTMLFormElement.idl:
html/canvas/Float32Array.idl:
html/canvas/Float64Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/OESStandardDerivatives.idl:
html/canvas/OESVertexArrayObject.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
html/canvas/Uint8ClampedArray.idl:
html/canvas/WebGLCompressedTextures.idl:
html/canvas/WebGLDebugRendererInfo.idl:
html/canvas/WebGLRenderingContext.idl:
inspector/JavaScriptCallFrame.idl:
loader/appcache/DOMApplicationCache.idl:
page/Console.idl:
page/DOMWindow.idl:
page/Location.idl:
storage/IDBCursor.idl:
storage/IDBDatabaseException.idl:
storage/IDBObjectStore.idl:
storage/SQLException.idl:
svg/SVGComponentTransferFunctionElement.idl:
svg/SVGException.idl:
svg/SVGFEBlendElement.idl:
svg/SVGFEColorMatrixElement.idl:
svg/SVGFECompositeElement.idl:
svg/SVGFEConvolveMatrixElement.idl:
svg/SVGFEDisplacementMapElement.idl:
svg/SVGFEMorphologyElement.idl:
svg/SVGFETurbulenceElement.idl:
svg/SVGGradientElement.idl:
xml/XMLHttpRequestException.idl:
xml/XPathException.idl:

6:24 PM Changeset in webkit [106891] by jamesr@google.com

14 edits in trunk/Source

[chromium] canvas demo is slow due to unnecessary resource cleanups
https://bugs.webkit.org/show_bug.cgi?id=77135

Reviewed by Kenneth Russell.

Source/WebCore:

This defers dropping a ManagedTexture until it is evicted by the manager, the layer is destroyed, the
TextureManager is destroyed, or the layer is added to a CCLayerTreeHost that has a different texture manager. In
particular, removing a layer from a CCLayerTreeHost and then adding it back to the same host does not drop any
ManagedTextures unless the manager has to evict it for other reasons. This provides a big speedup on sites that
rebuild the compositing tree frequently.

New unit test added for ManagedTexture / TextureManager interaction.

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::setLayerTreeHost):
(WebCore::Canvas2DLayerChromium::setTextureManager):

platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):

platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::setTextureManager):
(WebCore):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::clear):

platform/graphics/chromium/ManagedTexture.h:

(ManagedTexture):

platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

tests/TextureManagerTest.cpp:
tests/TiledLayerChromiumTest.cpp:

6:21 PM Changeset in webkit [106890] by rniwa@webkit.org

4 edits in trunk

Perf-o-matic should show min/max/stdev on graphs
https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

Websites/webkit-perf.appspot.com/app.yaml:
Websites/webkit-perf.appspot.com/js/config.js:
Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

6:04 PM Changeset in webkit [106889] by haraken@chromium.org

54 edits in trunk/Source/WebCore

Unreviewed, rolling out r106883.
http://trac.webkit.org/changeset/106883
https://bugs.webkit.org/show_bug.cgi?id=77852

build failure around Chromium V8 bindings

bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestTypedArray.idl:
bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

css/WebKitCSSFilterValue.idl:
css/WebKitCSSTransformValue.idl:
dom/DOMCoreException.idl:
dom/Document.idl:
dom/EventException.idl:
dom/RangeException.idl:
fileapi/FileException.idl:
fileapi/OperationNotAllowedException.idl:
html/HTMLFormElement.idl:
html/canvas/Float32Array.idl:
html/canvas/Float64Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/OESStandardDerivatives.idl:
html/canvas/OESVertexArrayObject.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
html/canvas/Uint8ClampedArray.idl:
html/canvas/WebGLCompressedTextures.idl:
html/canvas/WebGLDebugRendererInfo.idl:
html/canvas/WebGLRenderingContext.idl:
inspector/JavaScriptCallFrame.idl:
loader/appcache/DOMApplicationCache.idl:
page/Console.idl:
page/DOMWindow.idl:
page/Location.idl:
storage/IDBCursor.idl:
storage/IDBDatabaseException.idl:
storage/IDBObjectStore.idl:
storage/SQLException.idl:
svg/SVGComponentTransferFunctionElement.idl:
svg/SVGException.idl:
svg/SVGFEBlendElement.idl:
svg/SVGFEColorMatrixElement.idl:
svg/SVGFECompositeElement.idl:
svg/SVGFEConvolveMatrixElement.idl:
svg/SVGFEDisplacementMapElement.idl:
svg/SVGFEMorphologyElement.idl:
svg/SVGFETurbulenceElement.idl:
svg/SVGGradientElement.idl:
xml/XMLHttpRequestException.idl:
xml/XPathException.idl:

5:58 PM Changeset in webkit [106888] by commit-queue@webkit.org

3 edits in trunk

WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

5:42 PM Changeset in webkit [106887] by jchaffraix@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed gardening.

DEPS: Rolling the DEPS to get the apple_webkit update

and fix the Chromium build.

5:39 PM Changeset in webkit [106886] by dgrogan@chromium.org

4 edits
2 copies
4 adds in trunk/LayoutTests

Port some indexeddb layout tests to workers.
https://bugs.webkit.org/show_bug.cgi?id=77805

Reviewed by Tony Chang.

storage/indexeddb/index-basics-workers-expected.txt: Added.
storage/indexeddb/index-basics-workers.html: Added.
storage/indexeddb/index-basics.html:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt: Added.
storage/indexeddb/objectstore-basics-workers.html: Added.
storage/indexeddb/objectstore-basics.html:
storage/indexeddb/resources/index-basics.js: Copied from LayoutTests/storage/indexeddb/index-basics.html.

(test):
(setVersion):
(deleteExisting):
(addData):
(addData2):
(addData3):
(getData):
(getObjectData):
(getObjectData2):
(getObjectData3):
(getDataFail):
(getObjectDataFail):
(getObjectData4):
(openKeyCursor):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last.try.get testFailed):
(last):

storage/indexeddb/resources/objectstore-basics.js: Copied from LayoutTests/storage/indexeddb/objectstore-basics.html.

(test):
(openSuccess):
(setVersionSuccess):
(createIndex):
(testSetVersionAbort):
(createAnotherIndex):
(checkMetadata):
(addData):
(addDateSuccess):
(addSuccess):
(addAgainFailure):
(getSuccess):
(getSuccessDateKey):
(removeSuccess):
(removeSuccessButFalse):
(testPreConditions.request.onsuccess):
(testPreConditions):

5:37 PM Changeset in webkit [106885] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

5:36 PM Changeset in webkit [106884] by leviw@chromium.org

23 edits in trunk/Source/WebCore

Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader
https://bugs.webkit.org/show_bug.cgi?id=77891

Reviewed by Darin Adler.

Updating the usage of LayoutUnits in the dom, editing, page, accessibility, inspector, and loader
directories to properly use LayoutUnits vs ints.

No new tests. No new behavior.

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::elementAccessibilityHitTest):

accessibility/AccessibilitySlider.h:

(AccessibilitySlider):

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

dom/Clipboard.h:

(WebCore::Clipboard::dragLocation):
(Clipboard):

dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::renderedRectsForMarkers):

dom/DocumentMarkerController.h:
dom/Element.cpp:

(WebCore::Element::screenRect):

dom/Element.h:

(Element):

editing/Editor.cpp:

(WebCore::Editor::rangeForPoint):
(WebCore::Editor::firstRectForRange):

editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect):

editing/RenderedPosition.h:

(WebCore::RenderedPosition::absoluteRect):
(RenderedPosition):

editing/VisiblePosition.h:

(VisiblePosition):

inspector/DOMNodeHighlighter.cpp:
loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):

loader/SubframeLoader.h:

(SubframeLoader):

page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

page/Frame.cpp:

(WebCore::Frame::nodeImage):

page/win/FrameCGWin.cpp:

(WebCore::Frame::nodeImage):

5:33 PM Changeset in webkit [106883] by haraken@chromium.org

54 edits in trunk/Source/WebCore

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

No tests. No change in behavior.

bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestTypedArray.idl:

bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestTypedArray.idl:
css/WebKitCSSFilterValue.idl:
css/WebKitCSSTransformValue.idl:
dom/DOMCoreException.idl:
dom/Document.idl:
dom/EventException.idl:
dom/RangeException.idl:
fileapi/FileException.idl:
fileapi/OperationNotAllowedException.idl:
html/HTMLFormElement.idl:
html/canvas/Float32Array.idl:
html/canvas/Float64Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/OESStandardDerivatives.idl:
html/canvas/OESVertexArrayObject.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
html/canvas/Uint8ClampedArray.idl:
html/canvas/WebGLCompressedTextures.idl:
html/canvas/WebGLDebugRendererInfo.idl:
html/canvas/WebGLRenderingContext.idl:
inspector/JavaScriptCallFrame.idl:
loader/appcache/DOMApplicationCache.idl:
page/Console.idl:
page/DOMWindow.idl:
page/Location.idl:
storage/IDBCursor.idl:
storage/IDBDatabaseException.idl:
storage/IDBObjectStore.idl:
storage/SQLException.idl:
svg/SVGComponentTransferFunctionElement.idl:
svg/SVGException.idl:
svg/SVGFEBlendElement.idl:
svg/SVGFEColorMatrixElement.idl:
svg/SVGFECompositeElement.idl:
svg/SVGFEConvolveMatrixElement.idl:
svg/SVGFEDisplacementMapElement.idl:
svg/SVGFEMorphologyElement.idl:
svg/SVGFETurbulenceElement.idl:
svg/SVGGradientElement.idl:
xml/XMLHttpRequestException.idl:

5:30 PM Changeset in webkit [106882] by commit-queue@webkit.org

3 edits
6 adds in trunk

RenderSVGShape::strokeContains will fail for some strokes
https://bugs.webkit.org/show_bug.cgi?id=76931

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Adding support for rounded zero-length endcaps for SVG path hit
testing.

Tests: svg/hittest/zero-length-butt-cap-path.xhtml

svg/hittest/zero-length-round-cap-path.xhtml
svg/hittest/zero-length-square-cap-path.xhtml

rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

New tests for hit testing against an SVG path of zero length with
endcaps.

svg/hittest/zero-length-butt-cap-path-expected.txt: Added.
svg/hittest/zero-length-butt-cap-path.xhtml: Added.
svg/hittest/zero-length-round-cap-path-expected.txt: Added.
svg/hittest/zero-length-round-cap-path.xhtml: Added.
svg/hittest/zero-length-square-cap-path-expected.txt: Added.
svg/hittest/zero-length-square-cap-path.xhtml: Added.

5:20 PM WebKit Team edited by igor.oliveira@openbossa.org

(diff)

5:14 PM WebKitGTK/1.6.x edited by Martin Robinson

(diff)

5:09 PM Changeset in webkit [106881] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Add webGLErrorsToConsoleEnabled Settings flag
https://bugs.webkit.org/show_bug.cgi?id=77696

Patch by Gregg Tavares <gman@google.com> on 2012-02-06
Reviewed by Kenneth Russell.

No new tests as there is no change in behavior.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(Settings):
(WebCore::Settings::webGLErrorsToConsoleEnabled):

5:07 PM Changeset in webkit [106880] by eae@chromium.org

9 edits in trunk/Source

Convert PopupMenuClient::clientPadding over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77798

Reviewed by Eric Seidel.

Change PopupMenuClient and all classes inheriting from it to use the new
layout types for padding.

Source/WebCore:

No new tests.

platform/PopupMenuClient.h:

(PopupMenuClient):

rendering/RenderMenuList.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):

src/AutofillPopupMenuClient.h:

(AutofillPopupMenuClient):

tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::clientPaddingLeft):
(WebKit::TestPopupMenuClient::clientPaddingRight):

5:07 PM Changeset in webkit [106879] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

ValueToNumber and ValueToDouble nodes don't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=77855
<rdar://problem/10811325>

Reviewed by Gavin Barraclough.

Removed ValueToNumber and ValueToDouble, because the only thing they were doing
was wasting registers.

This looks like a 1% win on V8 (with a 5% win on crypto) and a 2-3% win on Kraken,
mostly due to a >10% win on gaussian-blur. No win anywhere else.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getToInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::hasArithNodeFlags):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(Propagator):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:55 PM Changeset in webkit [106878] by commit-queue@webkit.org

3 edits
3 adds in trunk

Fix color animations by value
https://bugs.webkit.org/show_bug.cgi?id=77812

Patch by Philip Rogers <pdr@google.com> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/animations/animate-color-fill-from-by.html

svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues):

LayoutTests:

svg/animations/animate-color-fill-from-by-expected.txt: Added.
svg/animations/animate-color-fill-from-by.html: Added.
svg/animations/script-tests/animate-color-fill-from-by.js: Added.

(checkFillColor):
(sample1):
(sample2):
(sample3):
(executeTest):

4:53 PM Changeset in webkit [106877] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk

Do not try to chdir to the directory where the executable is in
only if the path is absolute. This makes tests runnable from
anywhere.

Reviewed by Martin Robinson.

tests/test_utils.c:

(testutils_relative_chdir):

4:52 PM Changeset in webkit [106876] by jer.noble@apple.com

4 edits
2 adds in trunk

REGRESSION (r104303): Clicking inline video controls gives the video a focus ring
https://bugs.webkit.org/show_bug.cgi?id=77288

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-mouse-focus.html

Do not allow media elements to be focused by mouse click by overriding isMouseFocusable
and returning false.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isMouseFocusable):

html/HTMLMediaElement.h:

LayoutTests:

media/video-mouse-focus-expected.txt: Added.
media/video-mouse-focus.html: Added.

4:43 PM Changeset in webkit [106875] by andersca@apple.com

10 edits in trunk/Source

Source/WebCore: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

Add a new member function, FocusController::setContainingWindowIsVisible, and move the code
that calls ScrollableArea::contentAreaDidShow/ScrollableArea::contentAreaDidHide there, since
we only want to flash scrollers when the window becomes visible.

WebCore.exp.in:
page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContainingWindowIsVisible):
(WebCore):

page/FocusController.h:

(FocusController):
(WebCore::FocusController::containingWindowIsVisible):

platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
Call ScrollAnimatorMac::contentAreaWillPaint here, since that will trigger AppKit to flash the scrollers.

Source/WebKit/mac: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
Call FocusController::setContainingWindowIsVisible.

Source/WebKit2: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911

Reviewed by Kenneth Russell.

UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowVisibility]):
Use -[NSWindow isVisible] here, since we also want to consider the window hidden if the application itself is hidden.

(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
Call -[WKView updateWindowVisibility].

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setWindowIsVisible):
Call FocusController::setContainingWindowIsVisible.

4:41 PM Changeset in webkit [106874] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

4:38 PM Changeset in webkit [106873] by commit-queue@webkit.org

4 edits
2 adds in trunk

WebGL conformance test misc/functions-returning-strings.html fails
https://bugs.webkit.org/show_bug.cgi?id=77149

Source/WebCore:

Make sure that WebGL methods returning strings don't return null when
they run successfully.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/functions-returning-strings.html

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::ensureNotNull):

html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

LayoutTests:

Imported the WebGL conformance test related to this.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

fast/canvas/webgl/functions-returning-strings-expected.txt: Added.
fast/canvas/webgl/functions-returning-strings.html: Added.

4:34 PM Changeset in webkit [106872] by enrica@apple.com

5 edits in trunk/Source/WebCore

Refactor Mac platform implementation of the Pasteboard class.
https://bugs.webkit.org/show_bug.cgi?id=77567

The goal of this change is to remove the majority of the methods in
the class interface that are Mac specific.
writeSelectionForTypes has been left to support OS X services.
Some of the methods have been turned into static functions.
The method asURL was being used only by the DragData class and its
implementation has been moved there.
This is a first step in the direction of removing NSPasteboard access from
the WebProcess for WebKit2 (https://bugs.webkit.org/show_bug.cgi?id=77259)
leaving the WebKit1 behavior unchanged.

Reviewed by Alexey Proskuryakov.

No new tests. No changes in behavior.

platform/Pasteboard.h: Removed most of the Mac specific methods.
platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writeURL):

platform/mac/DragDataMac.mm:

(WebCore::DragData::asURL): Moved code from PasteboardMac.mm. Removed FIXME
because we only want to handle the case of single file, otherwise the user
doesn't know which of the files has been chosen.

platform/mac/PasteboardMac.mm:

(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment): Now a static function.
(WebCore::Pasteboard::writeImage):
(WebCore::documentFragmentWithImageResource): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment):

4:30 PM Changeset in webkit [106871] by crogers@google.com

2 edits in branches/chromium/1025

Merge 106864 - zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

TBR=crogers@google.com
Review URL: https://chromiumcodereview.appspot.com/9350003

4:25 PM Changeset in webkit [106870] by jamesr@google.com

5 edits in trunk/Source

[chromium] Drop tiles completely outside of layer bounds when resizing to a smaller size
https://bugs.webkit.org/show_bug.cgi?id=77910

Reviewed by Kenneth Russell.

Source/WebCore:

When resizing a tiled layer to a smaller size, drop all tiles that lie completely outside the new layer bounds.
This avoids attempting to access out-of-bounds tiles when iterating over all tiles in the tiler, which triggers
ASSERT()s, as well as saves some memory.

New unit test added to TiledLayerChromiumTest.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::invalidateRect):

platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

Source/WebKit/chromium:

Adds test for resizing a layer to cover fewer tiles. Test hits ASSERT()s without any code changes.

tests/TiledLayerChromiumTest.cpp:

(::TEST):

4:14 PM Changeset in webkit [106869] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Reverting RenderFrameSet's canResizeRow/Column to operate on IntPoints.

4:09 PM Changeset in webkit [106868] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderFrameSet.cpp

Call intValue on grid lengths instead of explicitly operating on floats when we only use integer precision for FrameSets.

4:08 PM Changeset in webkit [106867] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Revert r106859. It was completely bogus.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

4:00 PM Changeset in webkit [106866] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderFrameSet.cpp

Fix pixel snapping logic for FrameSets. This is for code correctness, but would never actually lead to incorrect renderings.

3:44 PM Changeset in webkit [106865] by morrita@google.com

18 edits
54 adds
5 deletes in trunk

[PerformanceTests] Each Dromaeo test needs its landing html.
https://bugs.webkit.org/show_bug.cgi?id=77504

Reviewed by Ryosuke Niwa.

PerformanceTests:

Added landing pages for each test which are listed in MANIFEST.json
Removed some tests which depends on the library whose license is incompatible to WebKit.
Added local copy of corresponding library. And replace the references to the remote sources to the local copies.
Removed old library files under Dromaeo/resources/dromaeo/web/lib/.
Skipped Sunsupier and v8 test. Such JS centric test should have its own test instead of running as a part of Dromaeo.

Dromaeo/cssquery-dojo.html: Added.
Dromaeo/cssquery-jquery.html: Added.
Dromaeo/cssquery-prototype.html: Added.
Dromaeo/dom-attr.html: Added.
Dromaeo/dom-modify.html: Added.
Dromaeo/dom-traverse.html: Added.
Dromaeo/dromaeo-3d-cube.html: Added.
Dromaeo/dromaeo-core-eval.html: Added.
Dromaeo/dromaeo-object-array.html: Added.
Dromaeo/dromaeo-object-regexp.html: Added.
Dromaeo/dromaeo-object-string.html: Added.
Dromaeo/dromaeo-string-base64.html: Added.
Dromaeo/jslib-attr-jquery.html: Added.
Dromaeo/jslib-attr-prototype.html: Added.
Dromaeo/jslib-event-jquery.html: Added.
Dromaeo/jslib-event-prototype.html: Added.
Dromaeo/jslib-modify-jquery.html: Added.
Dromaeo/jslib-modify-prototype.html: Added.
Dromaeo/jslib-style-jquery.html: Added.
Dromaeo/jslib-style-prototype.html: Added.
Dromaeo/jslib-traverse-jquery.html: Added.
Dromaeo/jslib-traverse-prototype.html: Added.
Dromaeo/resources/dromaeo/web/lib/dojo.js: Removed.
Dromaeo/resources/dromaeo/web/lib/dojo-1.6.1.js: Added.
Dromaeo/resources/dromaeo/web/lib/jquery.js: Removed.
Dromaeo/resources/dromaeo/web/lib/jquery-1.6.4.js: Added.
Dromaeo/resources/dromaeo/web/lib/mootools.js: Removed.
Dromaeo/resources/dromaeo/web/lib/prototype.js: Removed.
Dromaeo/resources/dromaeo/web/lib/prototype-1.7.js: Added.
Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html:
Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html:
Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Removed.
Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html:
Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html:
Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html:
Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html:
Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html:
Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:
Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html:
Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html:
Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html:
Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html:
Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html:
Dromaeo/sunspider-3d-morph.html: Added.
Dromaeo/sunspider-3d-raytrace.html: Added.
Dromaeo/sunspider-access-binary-trees.html: Added.
Dromaeo/sunspider-access-fannkuch.html: Added.
Dromaeo/sunspider-access-nbody.html: Added.
Dromaeo/sunspider-access-nsieve.html: Added.
Dromaeo/sunspider-bitops-3bit-bits-in-byte.html: Added.
Dromaeo/sunspider-bitops-bits-in-byte.html: Added.
Dromaeo/sunspider-bitops-bitwise-and.html: Added.
Dromaeo/sunspider-bitops-nsieve-bits.html: Added.
Dromaeo/sunspider-controlflow-recursive.html: Added.
Dromaeo/sunspider-crypto-aes.html: Added.
Dromaeo/sunspider-crypto-md5.html: Added.
Dromaeo/sunspider-crypto-sha1.html: Added.
Dromaeo/sunspider-date-format-tofte.html: Added.
Dromaeo/sunspider-date-format-xparb.html: Added.
Dromaeo/sunspider-math-cordic.html: Added.
Dromaeo/sunspider-math-partial-sums.html: Added.
Dromaeo/sunspider-math-spectral-norm.html: Added.
Dromaeo/sunspider-regexp-dna.html: Added.
Dromaeo/sunspider-string-fasta.html: Added.
Dromaeo/sunspider-string-tagcloud.html: Added.
Dromaeo/sunspider-string-unpack-code.html: Added.
Dromaeo/sunspider-string-validate-input.html: Added.
Dromaeo/v8-crypto.html: Added.
Dromaeo/v8-deltablue.html: Added.
Dromaeo/v8-earley-boyer.html: Added.
Dromaeo/v8-raytrace.html: Added.
Dromaeo/v8-richards.html: Added.
Skipped:

Tools:

Added an ignorable pattern which happens in some Dromaeo tests.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):

3:23 PM Changeset in webkit [106864] by crogers@google.com

4 edits in trunk

zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

Reviewed by Kenneth Russell.

Source/WebCore:

platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

LayoutTests:

platform/chromium/test_expectations.txt:

3:14 PM Changeset in webkit [106863] by kling@webkit.org

7 edits in trunk/Source/WebCore

REGRESSION(r106756): 10% performance hit on DOM/Template.
<http://webkit.org/b/77831>

Reviewed by Ryosuke Niwa.

Let the StylePropertySet used for element attribute style have the element as its parent.
This is accomplished by adding an m_parentIsElement bit to StylePropertySet and sharing
some of the internal logic with inline styles.

In the end, this means that CSSParser will now pick up the document's CSSValuePool when
parsing properties for attribute styles, which fixes the perf regression from r106756.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::contextStyleSheet):

Find contextStyleSheet via the parentElement() when there is one.

(WebCore::StylePropertySet::setNeedsStyleRecalc):

Always set FullStyleChange for attribute style mutations. We can probably use the
same lighter invalidation as inline styles, but that's a topic for another patch.

css/StylePropertySet.h:

(WebCore::StylePropertySet::createInline):
(WebCore::StylePropertySet::createAttributeStyle):
(WebCore::StylePropertySet::parentRuleInternal):
(WebCore::StylePropertySet::clearParentRule):
(StylePropertySet):
(WebCore::StylePropertySet::parentElement):
(WebCore::StylePropertySet::clearParentElement):

Added m_parentIsElement bit and update assertions as appropriate to not just
cover the inline style case. Added a createAttributeStyle() helper to create
a StylePropertySet for use as Element::attributeStyle().

dom/StyledElement.h:
dom/ElementAttributeData.h:
dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureAttributeStyle):

Use StylePropertySet::createAttributeStyle().

dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

Remove setNeedsStyleRecalc() calls since that is now handled automatically by
StylePropertySet's mutation methods.

3:10 PM Changeset in webkit [106862] by haraken@chromium.org

4 edits
1 add in trunk/Source/WebCore

In AppleWebKit, stop rebuilding IDLs that need not to be rebuilt
https://bugs.webkit.org/show_bug.cgi?id=77510

Reviewed by Adam Barth.

Currently, if any IDL file is updated, all IDL files are rebuilt.
This patch stops rebuilding IDL files which are not modified nor
whose supplemental dependencies are not changed.

The new build flow is as follows:

supplemental.dep : $(ALL_IDLS)

perl resolve-supplemental.pl ...

%.idl-needs-rebuild : %.idl supplemental.dep

perl update-idl-needs-rebuild.pl ...

JS%.cpp : %.idl-needs-rebuild

perl generate-bindings.pl ...

resolve-supplemental.pl generates the following supplemental.dep.
The number in () is the last access timestamp of the file.

A.idl(1200)
B.idl(1000) B-supplemental1.idl(800) B-supplemental2.idl(1200)
C.idl(1000)

update-idl-needs-rebuild.pl for X.idl touches X.idl-needs-rebuild,
if X.idl-needs-rebuild is older than X.idl or the IDL files which are
supplementing X.idl. For example, if the timestamps of A.idl-needs-rebuild,
B.idl-needs-rebuild and C.idl-needs-rebuild are all 1000, then A.idl-needs-rebuild
and B.idl-needs-rebuild will be touched.

Even if no IDL files are modified, update-idl-needs-rebuild.pl can run for all IDL files,
but generate-bindings.pl won't run. If any IDL file is updated, resolve-supplemental.pl
will run once, update-idl-needs-rebuild.pl will run for all IDL files, and
generate-bindings.pl will run for the IDL files which are modified or whose
dependencies are changed.

No tests. I manually confirmed the followings:

Touch Element.idl, then only Element.idl is rebuilt
Touch DOMWindow.idl, then only DOMWindow.idl is rebuilt
Touch DOMWindowWebAudio.idl, then only DOMWindow.idl and DOMWindowWebAudio.idl are rebuilt

DerivedSources.make: Modified the build flow as described above.
bindings/scripts/generate-bindings.pl: Modified to read an IDL file path from .idl-needs-rebuild.
bindings/scripts/update-idl-needs-rebuild.pl: Added. Touches X.idl-needs-rebuild if

the X.idl-needs-rebuild is older than X.idl or the IDL files which are supplementing X.idl.
(touch):

3:10 PM Changeset in webkit [106861] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Test is not flaky on XP.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-06

platform/chromium/test_expectations.txt:

3:08 PM Changeset in webkit [106860] by mdelaney@apple.com

1 edit in trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp

Windows build fix

3:02 PM Changeset in webkit [106859] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Chromium build fix after r106836.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

3:00 PM Changeset in webkit [106858] by commit-queue@webkit.org

2 edits
2 adds in trunk

AudioBus need to support stereo->mono down mix in copyFrom sumFrom etc.
https://bugs.webkit.org/show_bug.cgi?id=77609

Patch by Wei James <james.wei@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: webaudio/stereo2mono-down-mixing.html

platform/audio/AudioBus.cpp:

(WebCore):
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):

2:55 PM Changeset in webkit [106857] by jsbell@chromium.org

2 edits in trunk/LayoutTests

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

No sign of this test timing out in recent history, and significant
performance work has been done since it was filed. Unmarking as SLOW/PASS.

Reviewed by Tony Chang.

platform/chromium/test_expectations.txt:

2:54 PM Changeset in webkit [106856] by ericu@chromium.org

2 edits in trunk/Source/WebKit/chromium

[filesystem/Chromium] crackFileSystemURL needs to use innerURL
https://bugs.webkit.org/show_bug.cgi?id=77881

Reviewed by Adam Barth.

src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL):
Add the new code path, taken only if innerURL is present.

2:39 PM Changeset in webkit [106855] by jchaffraix@webkit.org

1 edit
2 adds
1 delete in trunk/LayoutTests

Unreviewed gardening.

More font differences that need a rebaseline.

platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Removed.
platform/chromium-linux/fast/canvas/check-stale-putImageData-expected.png: Added.
platform/chromium-win/fast/canvas/check-stale-putImageData-expected.png: Added.

2:35 PM Changeset in webkit [106854] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[Chromium] rebaseline test on win/mac after enabling paint opaque tracking for draw culling
https://bugs.webkit.org/show_bug.cgi?id=77497

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by James Robinson.

platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
platform/chromium/test_expectations.txt:

2:32 PM Changeset in webkit [106853] by abarth@webkit.org

4 edits in trunk/LayoutTests

http/tests/security/mixedContent/insecure-plugin-in-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77901

Reviewed by Eric Seidel.

This test fails occationally because of the order of the frame load
callbacks. Now that we log mixed content errors to the console, we
don't need to dump the frame load callbacks in this test.

http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
http/tests/security/mixedContent/insecure-plugin-in-iframe.html:

2:30 PM Changeset in webkit [106852] by cdn@chromium.org

3 edits
2 adds in trunk

Source/WebCore: Add RefPtrs for parent and sibling counter nodes
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

Test: fast/css/counters/reparent-table-children-with-counters-crash.html

rendering/RenderCounter.cpp:

(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::updateCounters):

LayoutTests: Test for crash when counter nodes are reparented outside of tables
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

fast/css/counters/reparent-table-children-with-counters-crash-expected.txt: Added.
fast/css/counters/reparent-table-children-with-counters-crash.html: Added.

2:26 PM Changeset in webkit [106851] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk

Unreviewed fix for the new API test that is failing -
WEBKIT_INSPECTOR_PATH needs to be set, since we do not install our
builds.

tests/testwebinspector.c:

(main):

2:17 PM Changeset in webkit [106850] by mdelaney@apple.com

2 edits in trunk/Source/WebCore/platform/mac

Fix for burning SL tree

2:17 PM Changeset in webkit [106849] by abarth@webkit.org

2 edits in trunk/LayoutTests

According to the flakiness dashboard, these tests do appear to be
successfully de-flaked.

platform/chromium/test_expectations.txt:

2:16 PM LayoutUnit created by eae@chromium.org

Added initial draft of wiki page explaining LayoutUnits.

2:06 PM Changeset in webkit [106848] by jochen@chromium.org

4 edits in branches/chromium/1025/Source/WebCore

Merge 106846 - Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code
Review URL: https://chromiumcodereview.appspot.com/9340005

1:59 PM Changeset in webkit [106847] by commit-queue@webkit.org

4 edits in trunk

[GTK] Add missing pango include dir to fix build
https://bugs.webkit.org/show_bug.cgi?id=77832

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Source/WebCore:

GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCore_la_CPPFLAGS.

Tools:

GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.

1:55 PM Changeset in webkit [106846] by jochen@chromium.org

5 edits in trunk/Source/WebCore

Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code

1:43 PM Changeset in webkit [106845] by senorblanco@chromium.org

3 edits in branches/chromium/963/Source/WebCore

Merge 104501 - [chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

platform/graphics/ImageBuffer.h:
platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9340004

1:39 PM Changeset in webkit [106844] by jchaffraix@webkit.org

1 edit
1 add in trunk/LayoutTests

Unreviewed rebaseline after r106836.

The rebaseline is caused by a font difference.

platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Added.

1:34 PM Changeset in webkit [106843] by mdelaney@apple.com

4 edits in trunk/WebKitLibraries

Correcting the version of WKSI committed in r106836

1:25 PM Changeset in webkit [106842] by jsbell@chromium.org

2 edits in trunk/LayoutTests

Unreviewed chromium test expectation change

Unmarking storage/indexeddb/data-corruption.html as TIMEOUT. Was apparently
bulk-marked as TIMEOUT on Snow Leopard as part of WK54322 although it is
not mentioned in that issue. The test hasn't failed in recent history and
there has been substantial rework on the IndexedDB feature since the
expectation was set.

platform/chromium/test_expectations.txt:

1:19 PM Changeset in webkit [106841] by shawnsingh@chromium.org

4 edits in branches/chromium/1025

Merge 106459 - Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9342003

1:17 PM Changeset in webkit [106840] by jamesr@google.com

7 edits in trunk/Source

Source/WebCore: Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Reviewed by Kenneth Russell.
Initial patch by Alok Priyadarshi.

TextureManager now holds references to the textures it manages.
This allows TextureManager to inform managed textures when it gets deleted
so that the texture that outlive the TextureManager can handle the situation gracefully.

Unit test in TextureManagerTest.cpp

platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore):
(WebCore::ManagedTexture::managerWillDie):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::reset):

platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::manager):
(ManagedTexture):
(WebCore::ManagedTexture::isReserved):

platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::~TextureManager):
(WebCore):
(WebCore::TextureManager::setPreferredMemoryLimitBytes):
(WebCore::TextureManager::registerTexture):
(WebCore::TextureManager::unregisterTexture):

platform/graphics/chromium/TextureManager.h:

(WebCore):
(TextureManager):

Source/WebKit/chromium: [chromium] Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Adds unit test for destroying a TextureManager while ManagedTextures are still alive referring to it.

Reviewed by Kenneth Russell.

tests/TextureManagerTest.cpp:

1:05 PM Changeset in webkit [106839] by andersca@apple.com

6 edits in trunk

Wheel event handler count not updated when adding handlers to the window
https://bugs.webkit.org/show_bug.cgi?id=77895

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/wheelevent-handler-count.html

page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
Update the wheel event count.

testing/Internals.cpp:

(WebCore::Internals::wheelEventHandlerCount):

testing/Internals.h:
testing/Internals.idl:

Add wheelEventHandlerCount to window.internals.

LayoutTests:

fast/events/wheelevent-handler-count-expected.txt: Added.
fast/events/wheelevent-handler-count.html: Added.

1:01 PM Changeset in webkit [106838] by commit-queue@webkit.org

7 edits in trunk

Source/WebKit2: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Fix some style issues in the GTK+ WebKit2 API section of the source code.

UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:
UIProcess/API/gtk/tests/TestMain.h:

Tools: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Verify that WebKit2 GTK+ test files are not skipped during style checks.
Skip soup_server_new when checking for NULL versus 0 usage.

Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherSkipTest.test_should_skip_with_warning):

Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null):

1:00 PM CommitterTips edited by bweinstein@apple.com

(diff)

1:00 PM CommitterTips edited by bweinstein@apple.com

(diff)

12:57 PM CommitterTips edited by bweinstein@apple.com

(diff)

12:56 PM Changeset in webkit [106837] by Lucas Forschler

2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r106729.

12:54 PM Changeset in webkit [106836] by mdelaney@apple.com

28 edits
3 adds in trunk

toDataURL() uses stale data after putImageData()
https://bugs.webkit.org/show_bug.cgi?id=65767

Source/WebCore:

This patch fixes the issue we've encountered of getting back
stale copies of the CGContext of accelerated ImageBuffers who have seen
putImageData calls but have not been drawn into via the CG API.
This issue is fixed by modifying the way we implement putImageData
in ImageBufferCG to draw the bits wrapped in a CGImage while the CGContext
is in a state where the data will effectively be copied (as is needed for
implementing putImageData) instead of directly modifying the bits of the IOSurface.

Reviewed by Chris Marrin.

Test: fast/canvas/check-stale-putImageData, pixel test to check that the canvas is in fact painted.

platform/graphics/cg/ImageBufferCG.cpp: Implement new way of putting image data.
platform/graphics/ImageBuffer.h: Merged two previously separate put data calls

into a single and more sensibly named 'putByteArray', since that's what it does!

WebCore.exp.in: Added new WKSI call for use in ImageBufferCG.cpp
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Using new method name.

html/canvas/CanvasRenderingContext2D.cpp:
platform/graphics/ImageBuffer.cpp:
platform/graphics/ShadowBlur.cpp:
platform/graphics/filters/FEColorMatrix.cpp:
platform/graphics/filters/FEDropShadow.cpp:
platform/graphics/filters/FilterEffect.cpp:

Updated other ports' ImageBuffers to use new method.

platform/graphics/cairo/ImageBufferCairo.cpp:
platform/graphics/qt/ImageBufferQt.cpp:
platform/graphics/skia/ImageBufferSkia.cpp:
platform/graphics/wince/ImageBufferWinCE.cpp:
platform/graphics/wx/ImageBufferWx.cpp:

Source/WebKit/chromium:

Reviewed by Chris Marrin.

src/WebViewImpl.cpp: Updated method name.

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Source/WebKit/mac:

Reviewed by Chris Marrin.

WebCoreSupport/WebSystemInterface.mm:

Source/WebKit2:

Reviewed by Chris Marrin.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

Added WKCGContextResetClip for use in reseting clip for new putByteArray method.

Reviewed by Chris Marrin.

WebKitSystemInterface.h: Added WKCGContextResetClip.
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceLion.a:

12:54 PM Changeset in webkit [106835] by Lucas Forschler

5 edits
3 copies in branches/safari-534.54-branch

Merged r104356.

12:48 PM Changeset in webkit [106834] by Lucas Forschler

3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r106594.

12:42 PM Changeset in webkit [106833] by caio.oliveira@openbossa.org

30 edits in trunk/Source

Provide more attribute methods in Element
https://bugs.webkit.org/show_bug.cgi?id=77800

Reviewed by Ryosuke Niwa.

Source/WebCore:

Reduce the clients of NamedNodeMap. This will make easier to change the
implementation of our attribute storage. The clients now use Element methods
that expose Attribute* accessors.

Instead of checking the existence of NamedNodeMap, clients can call
hasAttributes() or hasAttributesWithoutUpdate() (that skips updating invalid
style or animation svg attributes).

If there are attributes, they can be accessed by index via attributeCount() /
attributeItem(), as well as by QualifiedName. Those accessors assume there are an
attribute storage.

css/SelectorChecker.cpp:

(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):

css/SelectorChecker.h:

(WebCore::SelectorChecker::checkExactAttribute):

dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

dom/Document.cpp:

(WebCore::Document::importNode): use setAttributesFromElement() instead of manually copying.

dom/Element.h:

(Element):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::removeAttribute):

dom/Node.cpp:

(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):

editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isEmptyFontTag):

editing/EditingStyle.cpp:

(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::highestVisuallyEquivalentDivBelowRoot):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement):

editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCountWithoutUpdate):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Store Attribute*
to avoid looking up the right element again by name.

inspector/DOMEditor.cpp:

(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::createDigest):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):

Source/WebKit/chromium:

src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): access attributes via Element interface.

Source/WebKit/qt:

Api/qwebelement.cpp:

(QWebElement::attributeNames): access attributes via Element interface.

12:29 PM Changeset in webkit [106832] by eric@webkit.org

3 edits in trunk/Tools

webkit-patch apply-from-bug should be able to apply non-reviewed patches
https://bugs.webkit.org/show_bug.cgi?id=77883

Reviewed by Adam Barth.

This is very helpful if you use bugzilla as a replacement for git-stash.
Makes it simpler to re-apply the patch w/o having to look up the patch id.

Scripts/webkitpy/tool/commands/download.py:

(ProcessBugsMixin._fetch_list_of_patches_to_process):

Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest.test_apply_from_bug):

12:12 PM Changeset in webkit [106831] by kov@webkit.org

6 edits
1 add in trunk

[GTK] Insta-crash when closing browser with inspector window opened
https://bugs.webkit.org/show_bug.cgi?id=50744

Reviewed by Martin Robinson.

Source/WebKit/gtk:

GNUmakefile.am:
WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::releaseFrontendPage): also let go of the
frontend client when releasing the frontend page;
(WebKit::InspectorFrontendClient::~InspectorFrontendClient(): Call releaseFrontendPage()
like other ports do instead of just disconnectFrontendClient().
(WebKit::InspectorFrontendClient::destroyInspectorWindow): Use GRefPtr for the
inspector ref.
(WebKit::InspectorFrontendClient::bringToFront): Adjust for GRefPtr usage.
(WebKit::InspectorFrontendClient::attachWindow): Ditto.
(WebKit::InspectorFrontendClient::detachWindow): Ditto.
(WebKit::InspectorFrontendClient::inspectedURLChanged): Ditto.

WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient): Use GRefPtr for inspector member.

tests/testwebinspector.c: Added. Test that killing a WebView with the inspector

open does not crash, and that closing and reinspecting works.
(quitLoop):
(consoleMessageCallback):
(inspectElementCallback):
(closeInspector):
(showInspector):
(test_webkit_web_inspector_close_and_inspect):
(test_webkit_web_inspector_destroy_inspected_web_view):
(main):

LayoutTests:

platform/gtk/Skipped: unskip inspector/debugger/open-close-open.html,

which now passes.

12:00 PM Changeset in webkit [106830] by jsbell@chromium.org

5 edits in trunk

IndexedDB: Raise exception during add/put call if autoIncrement key insertion will fail
https://bugs.webkit.org/show_bug.cgi?id=77374

Source/WebCore:

If a put request will use a key generator, try inserting a dummy key during the sync
put() call to check if the key insertion will succeed so an exception can be raised
early, rather than deferring to the asynchronous task.

Reviewed by Tony Chang.

Test: storage/indexeddb/keypath-edges.html

storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

Reviewed by Tony Chang.

storage/indexeddb/keypath-edges-expected.txt:
storage/indexeddb/keypath-edges.html:

11:56 AM Changeset in webkit [106829] by jchaffraix@webkit.org

2 edits in trunk/LayoutTests

[Chromium] Test fast/forms/listbox-clear-restore.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77889

Unreviewed gardening.

platform/chromium/test_expectations.txt:

11:54 AM Changeset in webkit [106828] by kov@webkit.org

4 edits in trunk/Source

Add a null check for the gdkwindow, that will happen if the window
is not mapped.

Reviewed by Martin Robinson.

platform/gtk/GtkUtilities.cpp:

(WebCore::convertWidgetPointToScreenPoint):

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursor):

11:50 AM Changeset in webkit [106827] by commit-queue@webkit.org

13 edits in trunk

Source/WebCore: IndexedDB createObjectStore should throw if options arg is invalid
Added logic to OptionsObject to determine if an invalid object was created.
Javascript bindings now detect invalid OptionsObject's and throw TypeError when found.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Test: storage/indexeddb/createObjectStore-bad-options.html

bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::isObject):

bindings/v8/OptionsObject.h:

LayoutTests: IndexedDB createObjectStore should throw if options arg is invalid (not an object).
Added unit tests to test invalid arguments.
storage/indexddb/transaction-basics was modified only to correct calls that would
now throw.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/create-object-store-options.html:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics.html:
storage/indexeddb/resources/shared.js:

(evalAndExpectExceptionClass):

storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-basics.html:
storage/indexeddb/tutorial.html:

11:50 AM Changeset in webkit [106826] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/platform/Widget.h

Fixing incorrect usage of AppUnits as parameters to Widgets.

11:37 AM Changeset in webkit [106825] by jesus@webkit.org

2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Unreviewed gardening.

Skipped 3 tests because they were still failing after http://trac.webkit.org/changeset/106812 .
Skipped tests were:
fast/history/form-submit-in-frame-via-onclick.html
fast/history/form-submit-in-frame.html
http/tests/loading/state-object-security-exception.html

platform/qt-wk2/Skipped:

11:37 AM Changeset in webkit [106824] by rniwa@webkit.org

2 edits in trunk/Source/WebKit2

gcc build fix after r106749.

UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):

11:28 AM Changeset in webkit [106823] by jchaffraix@webkit.org

36 edits
4 deletes in trunk

Unreviewed, rolling out r106797 and r106806.
http://trac.webkit.org/changeset/106797
http://trac.webkit.org/changeset/106806
https://bugs.webkit.org/show_bug.cgi?id=77888

The change is still causing some crashes in webaudio/ on the
Chromium bots (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-06

Source/WebCore:

Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

dom/ActiveDOMObject.h:

(ActiveDOMObject):

dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

fileapi/FileReader.cpp:

(WebCore):

fileapi/FileReader.h:

(WebCore::FileReader::create):

fileapi/FileWriter.cpp:

(WebCore):

fileapi/FileWriter.h:

(WebCore::FileWriter::create):

history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):

html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

notifications/Notification.cpp:

(WebCore::Notification::create):

notifications/NotificationCenter.cpp:
notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

page/EventSource.cpp:

(WebCore::EventSource::create):

page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

websockets/WebSocket.cpp:
websockets/WebSocket.h:

(WebCore::WebSocket::create):

workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

workers/Worker.cpp:

(WebCore::Worker::create):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

fast/events/resources/suspend-subframe-1.html: Removed.
fast/events/resources/suspend-subframe-2.html: Removed.
fast/events/suspend-timers-expected.txt: Removed.
fast/events/suspend-timers.html: Removed.
platform/chromium/test_expectations.txt:

11:24 AM Changeset in webkit [106822] by Lucas Forschler

9 edits in branches/safari-534.54-branch/Source

Merged r106678.

11:13 AM Changeset in webkit [106821] by dslomov@google.com

1 edit in branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp

Merge 106722 - [Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

TBR=dslomov@google.com
Review URL: https://chromiumcodereview.appspot.com/9334005

11:01 AM Changeset in webkit [106820] by rniwa@webkit.org

1 edit
2 copies in branches/chromium/1025

Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
https://bugs.webkit.org/show_bug.cgi?id=77077

Reviewed by Enrica Casucci.

The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.

Tests: editing/deleting/delete-start-block.html

editing/selection/move-into-empty-root-inline-box.html

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
editing/selection/move-into-empty-root-inline-box.html: Added.

http://crbug.com/99408/
Review URL: https://chromiumcodereview.appspot.com/9331006

10:35 AM Changeset in webkit [106819] by caio.oliveira@openbossa.org

6 edits in trunk/Source/WebCore

Move style related functions from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77879

Reviewed by Ryosuke Niwa.

This commit also removes the NamedNodeMap::mappedAttributeCount(),
which is a leftover from removal of mapped attributes.

dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
(WebCore::ElementAttributeData::ensureAttributeStyle):

dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::inlineStyleDecl):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeStyle):

dom/NamedNodeMap.cpp:
dom/NamedNodeMap.h:
dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
(WebCore::StyledElement::destroyInlineStyleDecl):

10:23 AM Changeset in webkit [106818] by inferno@chromium.org

3 edits
3 adds in trunk

Crash in SubframeLoader::loadSubframe.
https://bugs.webkit.org/show_bug.cgi?id=77345

Reviewed by Nate Chapin.

Source/WebCore:

Mutation event when loading subframe can blow away the
main frame. Add a RefPtr to protect against that.

Test: fast/frames/subframe-load-crash-main.html

loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

LayoutTests:

fast/frames/resources/subframe-load-crash.svg: Added.
fast/frames/subframe-load-crash-main-expected.txt: Added.
fast/frames/subframe-load-crash-main.html: Added.

10:20 AM Changeset in webkit [106817] by senorblanco@chromium.org

2 edits in branches/chromium/1025

Merge 106477 - [SKIA/CHROMIUM] Perform getImageData format conversions using Skia
https://bugs.webkit.org/show_bug.cgi?id=77553

Patch by Brian Salomon <bsalomon@google.com> on 2012-02-01
Reviewed by Stephen White.

Source/WebCore:

Many existing canvas tests exercise this functionality.

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

LayoutTests:

platform/chromium/test_expectations.txt:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9331005

9:59 AM Changeset in webkit [106816] by commit-queue@webkit.org

5 edits in trunk/Source

[GTK] WebKitWebView does a lot of work during size_allocate when not mapped
https://bugs.webkit.org/show_bug.cgi?id=77743

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Instead of resizing the guts of a WebView when it's not mapped, wait
until it's mapped and do one resize. This prevents unmapped WebViews
from adding to a container's resize cost.

Source/WebKit/gtk:

webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): Abstracted out this helper.
(webkit_web_view_size_allocate): Wait until map to resize umapped widgets.
(webkitWebViewMap): Added this vmethod implementation.
(webkit_web_view_class_init): Added vmethod.

webkit/webkitwebviewprivate.h: Added new needsResizeOnMap member.

Source/WebKit2:

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Added a new member needsResizeOnMap.
(resizeWebKitWebViewBaseFromAllocation): Abstracted out this helper.
(webkitWebViewBaseSizeAllocate): Wait until map to resize unmapped WebViews.
(webkitWebViewBaseMap): Added this vmethod implementation.
(webkit_web_view_base_class_init): Added vmethod.

9:49 AM Changeset in webkit [106815] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Initial implementation of GraphicsContext3DOpenGLES.cpp
https://bugs.webkit.org/show_bug.cgi?id=76248

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-06
Reviewed by Martin Robinson.

Implemented APIs in GraphicsContext3DOpenGLES.cpp according to the GLES spec. roughly.
But no way to run these codes right now, because they need an extra port
specific implementation to work. I plan to add these extra codes for the GTK port
in the next patch. And also this patch doesn't support anti-aliasing yet. Another bug
will deal with it.
Moved some APIs in GraphicsContext3DOpenGLES.cpp to GraphicsContext3DCommon.cpp.
It looks it could be shared between gl and gles.
Two helper functions are added to avoid code duplication in GraphicsContext3D.
Added a missing period at the end of comment lines.

No new tests required.
We'll be able to verify this patch by using the existing webgl test cases.

platform/graphics/GraphicsContext3D.h: Add build flag to access stencilBuffer & depthBuffer for gles.

(WebCore):

platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Helper function extracted from GC3D::reshape to resize regular & multisampled FBOs.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Helper function to resolve multisampling.

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateAttributes): Add condition to disable antialiasing & packedDepthStencilExtension for GLES.
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Following APIs looked shareable so that moved into GC3DOpenGLCommon.cpp.
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::readPixels):

Added a missing period at the end of comment line.
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::texSubImage2D):

platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Same with the above.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Same with the above.

Brief explanation about what the differences are between gl and gles.
(WebCore::GraphicsContext3D::renderbufferStorage): Removed codes for converting GLES parameter to GL parameter.
(WebCore::GraphicsContext3D::getIntegerv): Removed codes that emulate GLES.
(WebCore::GraphicsContext3D::texImage2D): Removed codes for converting GLES parameter to GL parameter.

9:33 AM Changeset in webkit [106814] by Philippe Normand

3 edits in trunk/Tools

[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
https://bugs.webkit.org/show_bug.cgi?id=77866

Reviewed by Martin Robinson.

Scripts/webkitpy/style/checker.py: Ignore readability/naming

errors in some gstreamer source code files defining new GStreamer elements.

Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

9:31 AM Changeset in webkit [106813] by senorblanco@chromium.org

1 edit in branches/chromium/1025/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp

Merge 106732 - [chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9333004

9:05 AM Changeset in webkit [106812] by jesus@webkit.org

2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Rubber stamped by Csaba Osztrogonác.

Unskipping tests that were kept as skipped even after
https://bugs.webkit.org/show_bug.cgi?id=42333 was fixed.

platform/wk2/Skipped:

8:57 AM Changeset in webkit [106811] by apavlov@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: [Meta] Allow emulation of touch events
https://bugs.webkit.org/show_bug.cgi?id=77096

Reviewed by Pavel Feldman.

This is the inspector part of the change, core part implementation tracked in bug 77105.

English.lproj/localizedStrings.js:
inspector/Inspector.json:
inspector/InspectorDOMAgent.cpp:

(DOMAgentState):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::restore):
(WebCore):
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInDocuments):
(WebCore::InspectorDOMAgent::setTouchEmulationEnabled):

inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):

inspector/front-end/Settings.js:

(WebInspector.Settings):

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

8:39 AM Changeset in webkit [106810] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[Blackberry] Non-supported about: operations never stops loading
https://bugs.webkit.org/show_bug.cgi?id=76366

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-06
Reviewed by Rob Buis.

If user typed a non-supported "about:" scheme such as "about:nonsupport",
the loadAboutURL() function in NetworkManger should recognize and handle it as
an error of invalid url.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::loadAboutURL):
(WebCore::NetworkJob::handleAbout):

platform/network/blackberry/NetworkJob.h:

(NetworkJob):

platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

8:26 AM Changeset in webkit [106809] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Remove unused disabledComputedProperties from methods in StylesSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=77876

Reviewed by Pavel Feldman.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

8:20 AM Changeset in webkit [106808] by loislo@chromium.org

5 edits in trunk

Web Inspector: Redesign summary view / retaining tree contents
https://bugs.webkit.org/show_bug.cgi?id=77870

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-06
Reviewed by Pavel Feldman.

Make object IDs less contrast.
Put array indices in [].
Do not write type if it's just "Object".

Source/WebCore:

inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .console-formatted-id):
(.detailed-heapshot-view td.object-column span.grayed):

LayoutTests:

inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

8:10 AM Changeset in webkit [106807] by noam.rosenthal@nokia.com

2 edits in trunk/Source/WebCore

[Texmap][Qt] Avoid an image copy when uploading textures in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=77748

Reviewed by Kenneth Rohde Christiansen.

Use QPixmap::buffer() API to get access to the QPixmap's pixels without implicit copies.

Instrumentation shows that the deep image copies created from TextureMapperGL are
eliminated.

platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

8:05 AM Changeset in webkit [106806] by tonyg@chromium.org

2 edits in trunk/Source/WebCore

LayoutTest failures on r106797
https://bugs.webkit.org/show_bug.cgi?id=77868

Call suspendIfNeeded from subclass of IDBRequest, IDBVersionChangeRequest.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Simon Hausmann.

storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

6:54 AM Changeset in webkit [106805] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Make sure html_dir exists before calling gtkdoc-rebase
https://bugs.webkit.org/show_bug.cgi?id=77869

Reviewed by Philippe Normand.

gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Check html_dir exists.

6:18 AM Changeset in webkit [106804] by noam.rosenthal@nokia.com

3 edits in trunk/Source/WebCore

[Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore)
https://bugs.webkit.org/show_bug.cgi?id=77689

Reviewed by Kenneth Rohde Christiansen.

Use StillImageQt::createForRendering when using DontCopyBackingStore.
Enable DontCopyBackingStore in TextureMapperNode.
This removes deep copies resulting from the use of ImageBuffer.

Instrumentation shows that deep image copies resulted from ImageBuffer are eliminated.

platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage):

platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):

6:07 AM Changeset in webkit [106803] by commit-queue@webkit.org

7 edits in trunk/Source

WebGestureEvent can not encode delta and area.
https://bugs.webkit.org/show_bug.cgi?id=77728

Source/WebCore:

Add area field to PlatformGestureEvent.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::area):

Source/WebKit2:

Support delta and area fields in WebGestureEvent, and send area with Qt tap gesture.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

Shared/WebEvent.h:

(WebKit::WebGestureEvent::area):
(WebKit::WebGestureEvent::delta):

Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):

Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):

UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleSingleTapEvent):

5:55 AM Changeset in webkit [106802] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry]Use extension for a mimetype as the suggested extension
if the url file doesn't have an extension.
https://bugs.webkit.org/show_bug.cgi?id=76779

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-06
Reviewed by Antonio Gomes.

No new tests.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

5:24 AM Changeset in webkit [106801] by hans@chromium.org

4 edits in trunk/LayoutTests

Speech input: fix fast/speech/bubble-position.html
https://bugs.webkit.org/show_bug.cgi?id=77732

Reviewed by Tony Gentilcore.

There is no need for the test to check the pixel-exact position of the
rect, since that seems to vary a little between platforms.
The point of the test is to check that the rect is within the iframe,
so let's do that.

fast/speech/bubble-position-expected.txt:
fast/speech/bubble-position.html:

5:11 AM Changeset in webkit [106800] by jocelyn.turcotte@nokia.com

14 edits
9 deletes in trunk/Source/WebKit2

[Qt][WK2] Remove TiledDrawingArea and dependencies.
https://bugs.webkit.org/show_bug.cgi?id=71681

Reviewed by Kenneth Rohde Christiansen.

Tiled drawing surface functionality got converted to LayerTree.
TiledDrawingArea and its dependencies are not used by any port anymore.

CMakeLists.txt:
GNUmakefile.am:
Shared/DrawingAreaInfo.h:
Target.pri:
UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

UIProcess/API/qt/qquickwebpage_p.h:
UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.messages.in:
UIProcess/TiledDrawingAreaProxy.cpp: Removed.
UIProcess/TiledDrawingAreaProxy.h: Removed.
UIProcess/qt/QtSGTileNode.cpp: Removed.
UIProcess/qt/QtSGTileNode.h: Removed.
UIProcess/qt/QtSGUpdateQueue.cpp: Removed.
UIProcess/qt/QtSGUpdateQueue.h: Removed.
UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Removed.
WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledDrawingArea.cpp: Removed.
WebProcess/WebPage/TiledDrawingArea.h: Removed.
WebProcess/WebPage/WebPage.h:

(WebPage):

5:09 AM Changeset in webkit [106799] by jocelyn.turcotte@nokia.com

14 edits in trunk

[Qt] Don't version QtWebKit.experimental.
https://bugs.webkit.org/show_bug.cgi?id=77739

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

We won't support previous versions of the experimental API.

declarative/experimental/plugin.cpp:

Source/WebKit2:

UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

Tools:

MiniBrowser/qt/qml/BrowserWindow.qml:

4:56 AM Changeset in webkit [106798] by haraken@chromium.org

52 edits in trunk/Source/WebCore

Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77848

Reviewed by Adam Barth.

For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:

[HasIndexGetter] => [IndexedGetter] (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter] (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)

No tests. No change in behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
bindings/scripts/test/TestTypedArray.idl: Ditto.

Modules/gamepad/GamepadList.idl:
css/CSSRuleList.idl:
css/CSSStyleDeclaration.idl:
css/CSSValueList.idl:
css/MediaList.idl:
css/StyleSheetList.idl:
css/WebKitCSSFilterValue.idl:
css/WebKitCSSKeyframesRule.idl:
css/WebKitCSSTransformValue.idl:
dom/ClientRectList.idl:
dom/DOMStringList.idl:
dom/DOMStringMap.idl:
dom/DataTransferItemList.idl:
dom/NamedNodeMap.idl:
dom/NodeList.idl:
dom/TouchList.idl:
fileapi/EntryArray.idl:
fileapi/EntryArraySync.idl:
fileapi/FileList.idl:
html/DOMSettableTokenList.idl:
html/DOMTokenList.idl:
html/HTMLAllCollection.idl:
html/HTMLCollection.idl:
html/HTMLFormElement.idl:
html/HTMLOptionsCollection.idl:
html/HTMLPropertiesCollection.idl:
html/HTMLSelectElement.idl:
html/TextTrackCueList.idl:
html/canvas/CanvasPixelArray.idl:
html/canvas/Float32Array.idl:
html/canvas/Float64Array.idl:
html/canvas/Int16Array.idl:
html/canvas/Int32Array.idl:
html/canvas/Int8Array.idl:
html/canvas/Uint16Array.idl:
html/canvas/Uint32Array.idl:
html/canvas/Uint8Array.idl:
html/canvas/Uint8ClampedArray.idl:
html/track/TextTrackList.idl:
mediastream/MediaStreamList.idl:
mediastream/MediaStreamTrackList.idl:
page/SpeechInputResultList.idl:
page/WebKitAnimationList.idl:
plugins/DOMMimeTypeArray.idl:
plugins/DOMPlugin.idl:
plugins/DOMPluginArray.idl:
storage/Storage.idl:

4:36 AM Changeset in webkit [106797] by commit-queue@webkit.org

35 edits
4 adds in trunk

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

dom/ScriptExecutionContext.cpp:

dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

fileapi/FileReader.cpp:

(WebCore::FileReader::create):

fileapi/FileReader.h:
fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

fileapi/FileWriter.h:
history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

notifications/Notification.cpp:

(WebCore::Notification::create):

notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

notifications/NotificationCenter.h:
page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

page/EventSource.cpp:

(WebCore::EventSource::create):

page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

websockets/WebSocket.h:
workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

workers/Worker.cpp:

(WebCore::Worker::create):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

fast/events/resources/suspend-subframe-1.html: Added.
fast/events/resources/suspend-subframe-2.html: Added.
fast/events/suspend-timers-expected.txt: Added.
fast/events/suspend-timers.html: Added.
platform/chromium/test_expectations.txt:

4:33 AM Changeset in webkit [106796] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Unreviewed WinCE build fix after r106197.

tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator): getenv() isn't supported by WinCE. Don't call it.

3:18 AM Changeset in webkit [106795] by Philippe Normand

2 edits
1 add in trunk/Source/WebCore

Adding FFTFrameGStreamer.cpp that I forgot to commit
in r106537. That new file was reviewed in https://bugs.webkit.org/show_bug.cgi?id=73545.

platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.

2:39 AM Changeset in webkit [106794] by hayato@chromium.org

13 edits
5 adds in trunk

Add <shadow> element, which is guarded by SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76435

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/shadow-element.html

Source/WebCore:

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
html/HTMLElementsAllInOne.cpp:
html/HTMLTagNames.in:
html/shadow/HTMLShadowElement.cpp: Added.

(WebCore):
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::create):
(WebCore::HTMLShadowElement::~HTMLShadowElement):

html/shadow/HTMLShadowElement.h: Added.

(WebCore):
(HTMLShadowElement):

html/shadow/HTMLShadowElement.idl: Added.

LayoutTests:

fast/dom/shadow/shadow-element-expected.txt: Added.
fast/dom/shadow/shadow-element.html: Added.

2:26 AM Changeset in webkit [106793] by Carlos Garcia Campos

4 edits in trunk

[GTK] Update NEWS and configure.ac for 1.7.5 release
https://bugs.webkit.org/show_bug.cgi?id=77859

Reviewed by Philippe Normand.

configure.ac: Bumped version number.

Source/WebKit/gtk:

NEWS: Added release notes for 1.7.5.

2:18 AM Changeset in webkit [106792] by commit-queue@webkit.org

11 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

All input types should respect indeterminate property(getter and setter). This is true with other browsers.
Indeterminate appearance for radio input type is supported by IOS platform. Webkit need not support indeterminate appearance
for radio input type on other platforms.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-06
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/indeterminate-input-types.html

html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

html/CheckboxInputType.h:

(CheckboxInputType):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate): Removed the check isCheckable().
(WebCore::HTMLInputElement::isIndeterminate): Checks indeterminate appearance is supported.
(WebCore):

html/HTMLInputElement.h:

(HTMLInputElement):

html/InputType.cpp:

(WebCore::InputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

html/InputType.h:

(InputType):

html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick): Indeterminate related code is moved to IOS specific.
(WebCore::RadioInputType::didDispatchClick): Ditto.
(WebCore::RadioInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

html/RadioInputType.h:

(RadioInputType):

LayoutTests:

fast/forms/indeterminate-input-types-expected.txt: Added.
fast/forms/indeterminate-input-types.html: Added.
fast/forms/indeterminate-radio.html:

2:02 AM Changeset in webkit [106791] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Remove unused variable in PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77847

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

No changes in behavior, so no new tests.

plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):

1:58 AM Changeset in webkit [106790] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[BlackBerry] Remove unused variable in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=77851

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

1:40 AM Changeset in webkit [106789] by Nikolas Zimmermann

2 edits in trunk/LayoutTests

2012-02-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Switch to unix file endings and at a trailing newline - hopefully the bots will accept my follow up patch then.

svg/filters/invalidate-on-child-layout.svg:

1:29 AM Changeset in webkit [106788] by Carlos Garcia Campos

9 edits in trunk

[GTK] Fix several gtkdoc-fixxref warnings
https://bugs.webkit.org/show_bug.cgi?id=77613

Reviewed by Martin Robinson.

Source/WebKit/gtk:

docs/webkitgtk-docs.sgml: Remove webkitspellcheckerenchant

section.

docs/webkitgtk-sections.txt: Remove webkitspellcheckerenchant

symbols and move WebKitWebNavigationReason from the private
section to the global section.

webkit/webkitwebnavigationaction.h: Document

WebKitWebNavigationReason enum.

Source/WebKit2:

UIProcess/API/gtk/WebKitWindowProperties.cpp: Fix a typo, a

colon was missing in WebKitWebView::ready-to-show.

Tools:

gtk/generate-gtkdoc:

(get_webkit1_options): Add webkitspellcheckerenchant.* to the list
of ignored files, since it's private.

gtk/gtkdoc.py:

(GTKDoc._ignored_files_basenames): Helper function that returns a
string with the list of ignored files basenames separated by a
spaces, as expected by several gtkdoc commands.
(GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
--ignore-headers option.
(GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
--ignore-files option.

1:27 AM Changeset in webkit [106787] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: Fix CallArgument type in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=77839

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-06
Reviewed by Yury Semikhatsky.

Protocol description is fixed: field type is changed. No changes to
program code are necessary.

inspector/Inspector-0.1.json:
inspector/Inspector-1.0.json:
inspector/Inspector.json:

1:23 AM Changeset in webkit [106786] by Carlos Garcia Campos

5 edits in trunk/Tools

[GTK] Fix xrefs after installing API documentation
https://bugs.webkit.org/show_bug.cgi?id=77551

Reviewed by Martin Robinson.

GNUmakefile.am: Call generate-gtkdoc --rebase after installing

api docs.

gtk/common.py:

(prefix_of_pkg_config_file): Get the prefix variable of the given
pkg-config file.
(gtk_version_of_pkg_config_file): Get the gtk version required by
the given pkg-config file.

gtk/generate-gtkdoc: Add --rebase command line option to rebase

installed documentation.
(get_gtkdoc_module_paths): Get paths where API doc is installed
for the dependencies of the given pkg-config file.
(get_common_xref_deps): Get API doc directories of dependencies
common to WebKit1 and WebKit2.
(get_webkit2_options): Add cross_reference_deps option.
(get_webkit1_options): Ditto
(rebase_installed_docs): Helper function to create a generator for
the given pkg-config file and options and call rebase_installed_docs.

gtk/gtkdoc.py:

(GTKDoc.init): Initialize cross_reference_deps.
(GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
dependencies.
(GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
links of installed documentation.
(PkgConfigGTKDoc.init): Get the prefix from the pkg-config
file.

1:22 AM Changeset in webkit [106785] by abarth@webkit.org

4 edits in trunk/LayoutTests

Layout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67538

Reviewed by Kentaro Hara.

Try to fix the flakiness in this test by kicking off the <img> load
before the load event has fired for the inner frame. That way, the
load event for the main frame will be delayed until the image finishes
loading (and its error handler has fired), removing the need for the
setTimeout.

http/tests/security/xssAuditor/dom-write-innerHTML.html:
http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:
platform/chromium/test_expectations.txt:

1:07 AM Changeset in webkit [106784] by sergio@webkit.org

4 edits in trunk/Tools

Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
https://bugs.webkit.org/show_bug.cgi?id=77672

Reviewed by Dirk Pranke.

Test repetitions must be taken into account when working out
the statistics shown by run-webkit-tests.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):
(Manager._print_result_summary):

Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_repeat_each_iterations_num_tests):

12:56 AM Changeset in webkit [106783] by barraclough@apple.com

24 edits in trunk/Source

Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
https://bugs.webkit.org/show_bug.cgi?id=77451

Reviewed by Sam Weinig.

These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.

Source/JavaScriptCore:

JavaScriptCore.exp:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::defineOwnProperty):

debugger/DebuggerActivation.h:

(DebuggerActivation):

runtime/ClassInfo.h:

(MethodTable):
(JSC):

runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

runtime/JSCell.cpp:

(JSC):

runtime/JSCell.h:

(JSCell):

runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):
(JSC):

runtime/JSGlobalObject.h:

(JSGlobalObject):

runtime/JSObject.cpp:

(JSC):

runtime/JSObject.h:

(JSObject):

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

Source/WebCore:

bindings/js/JSDOMWindowCustom.cpp:

(WebCore):
(WebCore::JSDOMWindow::defineOwnProperty):

bindings/js/JSDOMWindowShell.cpp:

(WebCore):

bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::defineOwnProperty):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

page/DOMWindow.idl:
page/Location.idl:

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):

12:51 AM Changeset in webkit [106782] by Carlos Garcia Campos

5 edits in trunk/Source

Source/JavaScriptCore: Unreviewed. Fix make distcheck.

GNUmakefile.list.am: Add missing files.

Source/WebCore: Unreviewed. Fix make distrcheck.

GNUmakefile.am: Fix typo in inspector json file.
GNUmakefile.list.am: Remove non existent file.

12:38 AM Changeset in webkit [106781] by pfeldman@chromium.org

3 edits
2 copies in branches/chromium/1025

Merge 106638 - Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

inspector/elements/move-node-expected.txt: Added.
inspector/elements/move-node.html: Added.

TBR=pfeldman@chromium.org
BUG=112578
Review URL: https://chromiumcodereview.appspot.com/9328038

12:04 AM Changeset in webkit [106780] by yurys@chromium.org

2 edits in trunk/Source/WebCore

2012-02-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt minimal compilation fix after r106777.

inspector/InspectorDatabaseAgent.h: added missing #if ENABLED guards.

Feb 5, 2012:

11:54 PM Changeset in webkit [106779] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

11:52 PM Changeset in webkit [106778] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850

Reviewed by Yury Semikhatsky.

inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):

11:39 PM Changeset in webkit [106777] by yurys@chromium.org

27 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.

All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.

inspector/CodeGeneratorInspector.py:

(DomainNameFixes.get_fixed_data):
(Generator.go):

inspector/InspectorAgent.h:
inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

inspector/InspectorConsoleAgent.h:
inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

inspector/InspectorDOMDebuggerAgent.h:
inspector/InspectorDOMStorageAgent.h:
inspector/InspectorDatabaseAgent.h:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):

inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

inspector/InspectorFileSystemAgent.h:
inspector/InspectorIndexedDBAgent.h:
inspector/InspectorMemoryAgent.h:
inspector/InspectorPageAgent.h:
inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):

inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):

inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

inspector/InspectorRuntimeAgent.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::sendMessageToWorker):

inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

11:06 PM Changeset in webkit [106776] by haraken@chromium.org

52 edits in trunk/Source/WebCore

Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)

No tests. No change in behavior.

bindings/scripts/CodeGeneratorJS.pm: Added FIXME.

(JSValueToNative):

bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GetNativeTypeFromSignature):

bindings/scripts/test/TestObj.idl:
css/CSSCharsetRule.idl:
css/CSSPageRule.idl:
css/CSSRule.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleRule.idl:
css/CSSValue.idl:
css/MediaList.idl:
css/WebKitCSSKeyframesRule.idl:
dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/Document.idl:
dom/Element.idl:
dom/NamedNodeMap.idl:
dom/Node.idl:
dom/ProcessingInstruction.idl:
dom/ShadowRoot.idl:
fileapi/Blob.idl:
fileapi/DirectoryEntry.idl:
fileapi/DirectoryEntrySync.idl:
fileapi/Entry.idl:
fileapi/EntrySync.idl:
fileapi/WebKitBlobBuilder.idl:
html/HTMLAnchorElement.idl:
html/HTMLButtonElement.idl:
html/HTMLCanvasElement.idl:
html/HTMLDocument.idl:
html/HTMLElement.idl:
html/HTMLFieldSetElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLInputElement.idl:
html/HTMLKeygenElement.idl:
html/HTMLMediaElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOutputElement.idl:
html/HTMLScriptElement.idl:
html/HTMLSelectElement.idl:
html/HTMLTextAreaElement.idl:
html/HTMLTitleElement.idl:
html/canvas/CanvasRenderingContext2D.idl:
page/Console.idl:
page/DOMWindow.idl:
storage/StorageEvent.idl:
svg/SVGAngle.idl:
svg/SVGElement.idl:
svg/SVGLength.idl:
svg/SVGScriptElement.idl:

10:44 PM Changeset in webkit [106775] by fpizlo@apple.com

15 edits
2 adds in trunk/Source/JavaScriptCore

DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797

Reviewed by Oliver Hunt.

The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).

The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.

This is performance-neutral on all benchmarks we track.

JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):
(AbstractState):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

dfg/DFGCommon.h:
dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):

dfg/DFGNodeReferenceBlob.h: Added.

(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):

dfg/DFGNodeUse.h: Added.

(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

9:55 PM Changeset in webkit [106774] by abarth@webkit.org

6 edits in trunk/LayoutTests

xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
platform/chromium/test_expectations.txt:

8:47 PM Changeset in webkit [106773] by haraken@chromium.org

12 edits in trunk/Source/WebCore

Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

css/CSSStyleDeclaration.idl:
html/HTMLDocument.idl:
html/canvas/DataView.idl:
page/DOMWindow.idl:
page/MemoryInfo.idl:
webaudio/ConvolverNode.idl:
webaudio/DOMWindowWebAudio.idl:
webaudio/WaveShaperNode.idl:
websockets/DOMWindowWebSocket.idl:
workers/WorkerContext.idl:

8:01 PM Changeset in webkit [106772] by commit-queue@webkit.org

14 edits
1 add in trunk

[EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-05
Reviewed by Martin Robinson.

Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.

Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.

Source/WebCore:

Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.

No new tests required. We can verify this feature with the existing test cases.

CMakeLists.txt: Revised common files required for WebGL.
PlatformEfl.cmake: Added EFL specific files.
html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/GraphicsContext3D.h:

(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):

platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.

(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Source/WebKit/efl:

Activated WebGL feature.

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

7:53 PM Changeset in webkit [106771] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in FormSubmission::create.
https://bugs.webkit.org/show_bug.cgi?id=77813

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/form-submission-create-crash.xhtml

loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

LayoutTests:

fast/forms/form-submission-create-crash-expected.txt: Added.
fast/forms/form-submission-create-crash.xhtml: Added.

6:25 PM Changeset in webkit [106770] by kling@webkit.org

6 edits
1 delete in trunk/Source/WebCore

Remove unused file MappedAttributeEntry.h.
<http://webkit.org/b/77841>

Reviewed by Anders Carlsson.

GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/MappedAttributeEntry.h: Removed.
dom/StyledElement.h:

6:21 PM Changeset in webkit [106769] by kling@webkit.org

253 edits in trunk/Source/WebCore

StyledElement: Rename parseMappedAttribute() to parseAttribute().
<http://webkit.org/b/77830>

Reviewed by Anders Carlsson.

Rename across the board and decorate subclasses with OVERRIDE.

6:06 PM Changeset in webkit [106768] by kov@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed syntax fix.

English.lproj/localizedStrings.js:

5:33 PM Changeset in webkit [106767] by kling@webkit.org

2 edits in trunk/Source/WebCore

Swedish buildfix.

dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

4:43 PM Changeset in webkit [106766] by andersca@apple.com

8 edits in trunk/Source/WebCore

The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840

Reviewed by Andreas Kling.

If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.

dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.

(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.

page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.

2:27 PM Changeset in webkit [106765] by abarth@webkit.org

2 edits
1 add in trunk/LayoutTests

Rebaseline xss-inactive-closure.html. This test "fails" because of a
subtle difference in how V8 and JSC do security checks. Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow. I'm
working on fixing these differences in bugs like
https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.

In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.

platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
platform/chromium/test_expectations.txt:

2:16 PM Changeset in webkit [106764] by abarth@webkit.org

2 edits
1 add in trunk/LayoutTests

Rebaseline xss-DENIED-defineProperty. These V8-specific results appear
to also be passing, just with slightly fewer console messages.

platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
platform/chromium/test_expectations.txt:

2:02 PM Changeset in webkit [106763] by abarth@webkit.org

2 edits in trunk/LayoutTests

Further cleanup of failing and flaky security LayoutTests. This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.

platform/chromium/test_expectations.txt:

1:54 PM Changeset in webkit [106762] by abarth@webkit.org

2 edits in trunk/LayoutTests

This test is no longer flaky. It appears to pass all the time.

platform/chromium/test_expectations.txt:

10:51 AM Changeset in webkit [106761] by mitz@apple.com

7 edits in trunk

<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
https://bugs.webkit.org/show_bug.cgi?id=77823

Reviewed by Anders Carlsson.

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.

WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.

Tools:

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

6:02 AM Changeset in webkit [106760] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit/efl

[EFL] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=77828

Reviewed by Andreas Kling.

g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.

ewk/ewk_main.cpp:

(_ewk_init_body):

1:36 AM Changeset in webkit [106759] by gyuyoung.kim@samsung.com

4 edits in trunk

[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425

Reviewed by Daniel Bates.

Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.

Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.

Source/JavaScriptCore:

shell/CMakeLists.txt:

1:27 AM Changeset in webkit [106758] by gyuyoung.kim@samsung.com

2 edits in trunk

[CMAKE] Do not build Tools when building jsc only.
https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.

1:26 AM Changeset in webkit [106757] by kling@webkit.org

14 edits in trunk/Source/WebCore

Remove mapped vs non-mapped attribute distinction.
<http://webkit.org/b/77827>

Reviewed by Antti Koivisto.

Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.

The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)

dom/Attribute.cpp:

(WebCore::Attribute::clone):

dom/Attribute.h:

(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):

dom/Document.cpp:

(WebCore::Document::createAttributeNS):

dom/Element.cpp:

(WebCore::Element::attributeChanged):

dom/Element.h:

(Element):

dom/Node.cpp:

(WebCore::Node::dumpStatistics):

dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):

dom/StyledElement.h:

(StyledElement):

html/parser/HTMLConstructionSite.cpp:

(WebCore):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

xml/parser/MarkupTokenBase.h:

(WebCore::::initializeAttributes):

12:29 AM Changeset in webkit [106756] by kling@webkit.org

18 edits
2 deletes in trunk/Source/WebCore

Kill CSSMappedAttributeDeclaration.
<http://webkit.org/b/77820>

Reviewed by Antti Koivisto.

Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.

This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.order:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/CSSMappedAttributeDeclaration.cpp: Removed.
dom/CSSMappedAttributeDeclaration.h: Removed.
dom/DOMAllInOne.cpp:

Remove CSSMappedAttributeDeclaration.{cpp,h}

css/CSSParser.h:
css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
directly instead. We lose the benefit of caching new CSSValues in the
document's CSSValuePool but this optimization can be added back later.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

dom/ElementAttributeData.h:

(ElementAttributeData):

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):

dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

dom/StyledElement.h:

(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

12:27 AM Changeset in webkit [106755] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

inspector/front-end/heapProfiler.css:

(.cycled-ancessor-node):

inspector/front-end/profilesPanel.css:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed