Timeline



Feb 8, 2012:

11:58 PM Changeset in webkit [107188] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/gtk/fast/forms/select-overflow-scroll-expected.txt:
  • platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt:
  • platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:
11:52 PM Changeset in webkit [107187] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix a typo for r107125
​https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-02-08
Reviewed by James Robinson.

  • tests/WebCompositorInputHandlerImplTest.cpp:
11:20 PM Changeset in webkit [107186] by haraken@chromium.org
  • 40 edits in trunk/Source/WebCore

Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
​https://bugs.webkit.org/show_bug.cgi?id=78108

Reviewed by Adam Barth.

[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationIndexer):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl: No change in run-bindings-tests results.
  • css/CSSCharsetRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/StyleSheet.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Clipboard.idl:
  • dom/DOMStringList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/MutationRecord.idl:
  • dom/Node.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLMediaElement.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • page/DOMWindow.idl:
  • storage/IDBObjectStore.idl:
  • storage/IDBRequest.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • websockets/WebSocket.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XPathNSResolver.idl:
  • xml/XSLTProcessor.idl:
11:14 PM Changeset in webkit [107185] by kling@webkit.org
  • 11 edits in trunk/Source/WebCore

Simplify ownership of StyledElement::additionalAttributeStyles().
<​http://webkit.org/b/78204>

Reviewed by Anders Carlsson.

Change additionalAttributeStyle() to return a raw pointer rather than a PassRefPtr.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

11:14 PM Changeset in webkit [107184] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
​https://bugs.webkit.org/show_bug.cgi?id=78174

Patch by Hajime Morrita <​morrita@chromium.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Pulled back removed files.

  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.
11:02 PM Changeset in webkit [107183] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
​https://bugs.webkit.org/show_bug.cgi?id=78049

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-02-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.h: Added.
  • blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h: Added.
10:58 PM Changeset in webkit [107182] by haraken@chromium.org
  • 141 edits in trunk/Source/WebCore

Rename [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue]
​https://bugs.webkit.org/show_bug.cgi?id=78200

Reviewed by Adam Barth.

[Optional=CallWithDefalutValue] and [Optional=CallWithNullValue] are confusing.

  • [Optional=CallWithDefalutValue] indicates that a missing value should be treated

as if the JavaScript undefined is passed.

  • [Optional=CallWithNullValue] indicates that a missing value should be treated as

the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).

  • Actually, the difference between [Optional=CallWithDefalutValue] and

[Optional=CallWithNullValue] appears only when the type of the missing value is DOMString.
In case of [Optional=CallWithDefalutValue], the missing value is converted to the string
"undefined". On the other hand, in case of [Optional=CallWithNullValue], the missing
value is converted to the WebKit null string.

With these observations, this patch renames them as follows:

  • Rename [Optional=CallWithDefalutValue] to [Optional=TreatAsUndefined].
  • Remove [Optional=CallWithNullValue]. Instead, we use

[Optional=TreatAsUndefined, TreatUndefinedAs=NullString].

Test: bindings/scripts/test/TestInterface.idl

  • bindings/js/JSDOMBinding.h: Renamed MissingIsUndefined to MissingIsUndefinedValue,

renamed MissingIsEmpty to MissingIsNullValue.

  • bindings/v8/V8Binding.h: Ditto.
  • bindings/v8/custom/V8BindingMacros.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Modified to support the IDL attribute renaming.

(GenerateParametersCheck):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateParametersCheck):
(RequiresCustomSignature):

  • Modules/gamepad/GamepadList.idl: Renamed IDL attributes as described above.
  • Modules/intents/Intent.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeList.idl:
  • dom/OverflowEvent.idl:
  • dom/Range.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/DOMFormData.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/IDBDatabase.idl:
  • storage/StorageEvent.idl:
  • svg/ElementTimeControl.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStylable.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • webaudio/AudioNode.idl:
  • workers/SharedWorker.idl:
  • workers/WorkerContext.idl:
  • xml/DOMParser.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • bindings/scripts/test/TestInterface.idl: Added test cases for [Optional],

[Optional=TreatAsUndefined] and [Optional=TreatAsUndefined, TreatUndefinedAs=NullString]

  • bindings/scripts/test/TestNamedConstructor.idl: Renamed IDL attributes as described above.
  • bindings/scripts/test/TestObj.idl: Ditto.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalIsTreatAsUndefinedString):
(WebDOMTestObj::methodWithOptionalIsNullStringString):

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.

(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_is_treat_as_undefined_string):
(webkit_dom_test_obj_method_with_optional_is_null_string_string):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Ditto.

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Ditto.

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.

(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.

(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsTreatAsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.

(WebCore):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.

(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalIsTreatAsUndefinedString:]):
(-[DOMTestObj methodWithOptionalIsNullStringString:]):

  • bindings/scripts/test/V8/V8Float64Array.cpp: Ditto.

(WebCore::Float64ArrayInternal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Ditto.

(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.

(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp: Ditto.

(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.

(WebCore::TestMediaQueryListListenerInternal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalIsTreatAsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalIsNullStringStringCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Ditto.

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

10:43 PM Changeset in webkit [107181] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
​https://bugs.webkit.org/show_bug.cgi?id=78096

Reviewed by Adam Barth.

This patch renames [HasNumericIndexGetter] to [NumericIndexedGetter],
for naming consistency with [IndexedGetter] and [CustomIndexedGetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):

  • bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
  • html/canvas/CanvasPixelArray.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
10:12 PM Changeset in webkit [107180] by commit-queue@webkit.org
  • 4 edits
    1 copy
    1 add in trunk/Source/WebKit2

[WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.
​https://bugs.webkit.org/show_bug.cgi?id=76171

Patch by Keunsoon Lee <​keunsoon.lee@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.

FileDownloaderEfl is a practical class to operate file download.
It communicates with Download class to start download
and to notify downloading states to user(e.g. client application).
Besides FileDownloaderEfl derives from ResourceHandleClient
and receives chunked data from ResourceHandle directly
or redirects data flow which is started from MainResourceLoader
by mean of exchanging ResourceHandle's existing client for FileDownloaderEfl.

This patch has only dummy functions to make easy to review.
Working patch will be uploaded on another bug thread.

  • PlatformEfl.cmake: added new file to compile.
  • WebProcess/Downloads/Download.h: added FileDownloaderEfl's instance as a form of OwnPtr<FileDownloaderEfl>.

(WebKit):
(Download):

  • WebProcess/Downloads/efl/DownloadEfl.cpp:

(WebKit::Download::start): calling to FileDownloaderEfl::start() to start download for passing ResourceRequest.

  • WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Added. a practical class to operate file download.

(WebKit):
(WebKit::FileDownloaderEfl::create): create function, which returns PassOwnPtr<FileDownloaderEfl>.
(WebKit::FileDownloaderEfl::FileDownloaderEfl): constructor, which receives Download* as a parameter.
(WebKit::FileDownloaderEfl::~FileDownloaderEfl): deconstructor.
(WebKit::FileDownloaderEfl::start): a function to start downloading for passed ResourceRequest.
It does nothing for now, but shows how Download class can call FileDownloaderEfl's function.
(WebKit::FileDownloaderEfl::didReceiveResponse): virtual function for ResourceHandleClient.
It will receive response header information from ResourceHandle.
(WebKit::FileDownloaderEfl::didReceiveData): virtual function for ResourceHandleClient.
It will receive chunk data from ResourceHandle.
(WebKit::FileDownloaderEfl::didFinishLoading): virtual function for ResourceHandleClient.
It will be notified loading is finished from ResourceHandle.
(WebKit::FileDownloaderEfl::didFail): virtual function for ResourceHandleClient.
It will be notified loading is fail with ResourceError from ResourceHandle.
(WebKit::FileDownloaderEfl::shouldUseCredentialStorage): virtual function for ResourceHandleClient.
It returns whether to use credential storage or not.
(WebKit::FileDownloaderEfl::didReceiveAuthenticationChallenge): virtual function for ResourceHandleClient.
It will receive AuthenticationChallenge.
(WebKit::FileDownloaderEfl::didCancelAuthenticationChallenge): virtual function for ResourceHandleClient.
It will be notified AuthenticationChallenge is canceled.
(WebKit::FileDownloaderEfl::receivedCancellation): virtual function for ResourceHandleClient.

  • WebProcess/Downloads/efl/FileDownloaderEfl.h: Added.

(WebCore):
(WebKit):
(FileDownloaderEfl):

9:57 PM Changeset in webkit [107179] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

refactor RenderFlexibleBox to return preferred sizes of all children
​https://bugs.webkit.org/show_bug.cgi?id=78169

Reviewed by Ojan Vafai.

This is in preparation for multi-line flexbox. We need the preferred
size of each child so we can compute where the multi-line breaks happen.

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Renamed from preferredMainAxisContentExtentForFlexItem because
other methods are ForChild rather than ForFlexItem.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

9:46 PM Changeset in webkit [107178] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
​https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

Initialize exception code before calling appendChild.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

9:26 PM Changeset in webkit [107177] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[Chromium] Avoid unnecessary full tile updates without breaking atomicity of commits.
​https://bugs.webkit.org/show_bug.cgi?id=76740

Patch by David Reveman <​reveman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

Allow the final batch of texture uploads to be performed without
allocating new textures and re-painting complete tiles.

This patch is tested by the following unit test:

  • CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
  • TiledLayerChromiumTest.partialUpdates
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::requestPartialTextureUpdate):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::maxPartialTextureUpdates):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore):
(WebCore::CCTextureUpdater::appendPartial):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommitWithPartialUpdate and
TiledLayerChromiumTest.partialUpdates tests that verifies
atomicity of commits with partial updates.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(CCLayerTreeHostTestAtomicCommit):
(CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::afterTest):
(WTF):
(WTF::TEST_F):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::Texture::Texture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(Texture):
(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::updateCount):
(WTF::FakeLayerTextureUpdater::clearUpdateCount):
(WTF::FakeLayerTextureUpdater::updateRect):
(WTF::FakeLayerTextureUpdater::createTexture):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):

9:23 PM Changeset in webkit [107176] by morrita@google.com
  • 23 edits
    2 adds in trunk

Replacement text should be available from the marker.
​https://bugs.webkit.org/show_bug.cgi?id=77934

.:

Reviewed by Kent Tamura.

  • Source/autotools/symbols.filter: Added an exporting symbol.

Source/WebCore:

Reviewed by Kent Tamura.

On spellchecking, TextCheckingResult can contain a replacement text
which is usable both for an automatic replacement and for showing a suggestion.

But when marking a misspelled word ragarding to returned
TextCheckingResult, Editor uses only the misspelled range data and
discards the replacement value. Then it asks the same value again
when showing suggestion/autocorrection.

It would be great if the marker holds the replacement text
and Editor can use it on suggesting a correction, without any re-request.
This is especially true in the case when it needs IPC messaging for spellchecking:
We can save one round-trip by this technique.

Here is actual change:

  • Passed the replacement text to addMarker() for for misspelling markers. Note that this is done only for the unified checker path because legacy TextCheckerClient API doesn't provide such a replacement.
  • Added an Internals API to retrieve a description text on a marker.

Test: editing/spelling/spelling-marker-description.html

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

  • testing/Internals.cpp:

(WebCore::Internals::markerAt):
(WebCore):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::markerDescriptionForNode):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

didFinishCheckingText() accidentally dropped the description text
given from the backend. Fixed to copy it on the API-to-Core
convertion. The test won't work without this fix.

Reviewed by Kent Tamura.

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::toCoreResults):

Source/WebKit/win:

Reviewed by Kent Tamura.

  • WebKit.vcproj/WebKit_Cairo.def:
  • WebKit.vcproj/WebKit_Cairo_debug.def:

Source/WebKit2:

Reviewed by Kent Tamura.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Made the mock requestCheckingOfText() implementation to return
a replacement text for each misspelled word if available.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::finishLastTextCheck):

LayoutTests:

Reviewed by Kent Tamura.

  • editing/spelling/spelling-marker-description-expected.txt: Added.
  • editing/spelling/spelling-marker-description.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:06 PM Changeset in webkit [107175] by eric@webkit.org
  • 14 edits
    2 deletes in trunk

Remove more cruft now that HTMLIsIndexElement is gone
​https://bugs.webkit.org/show_bug.cgi?id=77887

Reviewed by Darin Adler.

Just removing dead code, thus no tests.
There is likely more to remove after this.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

  • html/InputType.h:

(InputTypeNames):

  • html/IsIndexInputType.cpp: Removed.
  • html/IsIndexInputType.h: Removed.
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isContentEditable):

8:49 PM Changeset in webkit [107174] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[V8][Chromium] Race between worker accessing WebDatabase and frame closing down.
​https://bugs.webkit.org/show_bug.cgi?id=78150
Handle case when the frame is shut down under us gracefully.

Patch by Dmitry Lomov <​dslomov@chromium.org> on 2012-02-08
Reviewed by David Levin.

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::canEstablishDatabase): Handle WebWorkerBase::view returning 0.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker): Handle WebWorkerBase::view returning 0.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::view):

8:41 PM Changeset in webkit [107173] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Increased style sharing for elements with presentation attributes.
<​http://webkit.org/b/78199>

Reviewed by Antti Koivisto.

When determining whether two elements can share style, we can do a lot better.
Instead of comparing the attribute maps for exact equality, do a property-by-property
comparison of the attributeStyle() and the additionalAttributeStyle() (if any.)

This increases our style sharing hit rate and shaves 100ms off of each cycle on
Chromium's "Moz" page cycler test on my machine.

The function that compares attribute styles has O(n2) runtime in the worst case,
where n is the number of properties in the styles. However, given the low number of
properties found in attribute styles, this should be fine, and it doesn't seem to
heat up in profiles.

  • css/CSSStyleSelector.cpp:

(WebCore::attributeStylesEqual):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

8:34 PM Changeset in webkit [107172] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the caculation of preDelayFrames in DynamicsCompressorKernel
​https://bugs.webkit.org/show_bug.cgi?id=78057

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-02-08
Reviewed by Chris Rogers.

No new tests required.

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::setPreDelayTime):

8:04 PM Changeset in webkit [107171] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
​https://bugs.webkit.org/show_bug.cgi?id=78146

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Our DumpRenderTree should support --no-timeout and --timeout options in order
to be able to use run-perf-tests and have a Performance Bot.
This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
and the necessary code to handle such command line arguments to our DumpRenderTree.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::setTimeout):
(WebCore):
(WebCore::DumpRenderTree::setShouldTimeout):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::setTimeout):
(LayoutTestController::setShouldTimeout):
(LayoutTestController):

  • DumpRenderTree/qt/main.cpp:

(isOption):
(printUsage):
(main):

7:34 PM Changeset in webkit [107170] by adamk@chromium.org
  • 13 edits in trunk/Source

DOM mutations should not be delivered on worker threads
​https://bugs.webkit.org/show_bug.cgi?id=77898

Reviewed by Dmitry Titov.

Source/WebCore:

In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.

This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).

Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.

See also ​http://crbug.com/112586, where the problem was initially
reported.

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallback::call):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):

  • bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

  • bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

  • bindings/v8/V8RecursionScope.h:

(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):

Source/WebKit/chromium:

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

7:20 PM Changeset in webkit [107169] by leo.yang@torchmobile.com.cn
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
​https://bugs.webkit.org/show_bug.cgi?id=78082

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/InspectorClientBlackBerry.h: Added.
7:02 PM Changeset in webkit [107168] by andersca@apple.com
  • 13 edits in trunk/Source

Don't use the wheel event handler count to track if a page has horizontal scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=78192

Reviewed by Andreas Kling.

Source/WebCore:

Stop calling Document::didAddWheelEventHandler and Document::didRemoveWheelEventHandler when
adding and removing scrollbars.

  • page/FrameView.cpp:
  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:

Source/WebKit2:

Prior to this change, we were incrementing and decrementing the wheel event handler count
whenever a scrollable area gained or lost a horizontal scrollbar, so we could use the count
to determine if Safari can handle horizontal wheel events directly or whether they have to be sent
to the web process first.

What this meant was that whenever a page had horizontal scrollbars we'd have to send all scroll wheel events
to the main thread instead of the scrolling thread, regardless of whether there were any wheel event handlers.

After this change, we traverse the tree of scrollable areas after every layout and check if any of them
have a horizontal scrollbar. (We still also check if there are wheel event handlers).

If traversing the tree after every layout is deemed to slow we can go back to caching the number of horizontal scrollbars
in a page, but the number of subframes in a page is usually very small and the number of other scrollable areas is even smaller.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::willHandleHorizontalScrollEvents):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setCanShortCircuitHorizontalWheelEvents):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::numWheelEventHandlersChanged):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::numWheelEventHandlersChanged):
(WebKit):
(WebKit::hasEnabledHorizontalScrollbar):
(WebKit::pageContainsAnyHorizontalScrollbars):
(WebKit::WebPage::recomputeShortCircuitHorizontalWheelEventsState):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

6:55 PM Changeset in webkit [107167] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/WebCore.gypi

Remove skia FixedPoint/Rect/Size files from build

6:45 PM Changeset in webkit [107166] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS
​https://bugs.webkit.org/show_bug.cgi?id=78152

Patch by Scott Graham <​scottmg@chromium.org> on 2012-02-08
Reviewed by Adam Barth.

  • DEPS:
6:38 PM Changeset in webkit [107165] by kov@webkit.org
  • 2 edits in trunk/Tools

Rubber-stamped by Martin Robinson.

  • gtk/common.py:

(get_build_path): Move test for current directory being a valid
directory up so it takes precedence over WebKitBuild/Release and
WebKitBuild/Debug when they exist as well.

6:28 PM Changeset in webkit [107164] by kov@webkit.org
  • 4 edits in trunk/Tools

[GTK] doc rebasing does not respect DESTDIR
​https://bugs.webkit.org/show_bug.cgi?id=78177

Reviewed by Martin Robinson.

  • GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when

calling it for rebasing.

  • gtk/generate-gtkdoc:

(get_common_options): Handle the new --virtual-root option.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.

6:20 PM Changeset in webkit [107163] by eae@chromium.org
  • 17 edits
    11 deletes in branches/subpixellayout/Source

Remove platform specific implicit conversions from/to FloatRect/Point/Size and make conversions explicit in platform code.

6:07 PM Changeset in webkit [107162] by igor.o@sisa.samsung.com
  • 10 edits
    6 adds in trunk

Source/WebCore: Implement reverse animation direction

Implement reverse animation direction
​https://bugs.webkit.org/show_bug.cgi?id=60525

Implement reverse and alternate-reverse direction.

Reviewed by Dean Jackson.

Tests: animations/animation-direction-alternate-reverse.html

animations/animation-direction-reverse.html
animations/fill-mode-reverse.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationDirection):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapAnimationDirection):

  • css/CSSValueKeywords.in:
  • page/WebKitAnimation.cpp:

(WebCore::WebKitAnimation::direction):

  • page/WebKitAnimation.h:
  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):

  • platform/animation/Animation.h:

(Animation):

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore):
(WebCore::shouldReverseAnimationValue):
(WebCore::normalizedAnimationValue):

LayoutTests: Implement reverse animation direction
​https://bugs.webkit.org/show_bug.cgi?id=60525

Add test for the new animation-direction values.

Reviewed by Dean Jackson.

  • animations/animation-direction-alternate-reverse-expected.txt: Added.
  • animations/animation-direction-alternate-reverse.html: Added.
  • animations/animation-direction-reverse-expected.txt: Added.
  • animations/animation-direction-reverse.html: Added.
  • animations/fill-mode-reverse-expected.txt: Added.
  • animations/fill-mode-reverse.html: Added.
5:56 PM Changeset in webkit [107161] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Avoid creating a temporary GraphicsContext3D if someone requests the WebView's GraphicsContext3D before initialization is complete
​https://bugs.webkit.org/show_bug.cgi?id=78154

Patch by James Robinson <​jamesr@chromium.org> on 2012-02-08
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::context):

5:50 PM Changeset in webkit [107160] by hyatt@apple.com
  • 8 edits
    3 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=78157

Make multi-column layout work with line grids that are outside of the multi-column
block.

Reviewed by Dan Bernstein.

Added new tests in fast/line-grid.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):
(WebCore):
(WebCore::LayoutState::computeLineGridPaginationOrigin):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::lineGrid):
(WebCore::LayoutState::lineGridOffset):
(WebCore::LayoutState::lineGridPaginationOrigin):
(WebCore::LayoutState::needsBlockDirectionLocationSetBeforeLayout):
(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=78157

Make multi-column layout work with line grids that are outside of the multi-column
block.

Reviewed by Dan Bernstein.

  • fast/line-grid/line-grid-into-columns.html: Added.
  • platform/mac/fast/line-grid/line-grid-into-columns-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-into-columns-expected.txt: Added.
5:41 PM Changeset in webkit [107159] by commit-queue@webkit.org
  • 5 edits
    3 copies
    9 adds in trunk/LayoutTests

Improve http-equiv content-language parsing
​https://bugs.webkit.org/show_bug.cgi?id=77724

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-02-08
Reviewed by Alexey Proskuryakov.

Add more tests for mapping http-equiv content-language to -webkit-locale. The desired behavior of some
of these is not yet decided, so some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

  • fast/text/content-language-case-insensitivity-expected.txt:
  • fast/text/content-language-case-insensitivity.html: Style fixes.
  • fast/text/content-language-empty-expected.txt: Added.
  • fast/text/content-language-empty.html: Added.
  • fast/text/content-language-late-expected.txt: Added.
  • fast/text/content-language-late.html: Added.
  • fast/text/content-language-mapped-to-webkit-locale-expected.txt:
  • fast/text/content-language-mapped-to-webkit-locale.html: Style fixes.
  • fast/text/content-language-multiple-expected.txt: Added.
  • fast/text/content-language-multiple.html: Added.
  • fast/text/content-language-no-content-expected.txt: Added.
  • fast/text/content-language-no-content.html: Added.
  • fast/text/content-language-only-whitespace-expected.txt: Added.
  • fast/text/content-language-only-whitespace.html: Added.
  • fast/text/content-language-with-whitespace-expected.txt: Added.
  • fast/text/content-language-with-whitespace.html: Added.
5:41 PM Changeset in webkit [107158] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Remove EditCommandBlackBerry.cpp from build system
​https://bugs.webkit.org/show_bug.cgi?id=78078

Reviewed by Rob Buis.

WebKit/blackberry/WebCoreSupport/EditCommandBlackBerry.cpp which hasn't
been upstreamed has been removed from the BlackBerry porting internally.
So we should remove it from the build system.

  • blackberry/CMakeListsBlackBerry.txt:
5:30 PM Changeset in webkit [107157] by mdelaney@apple.com
  • 3 edits in trunk/Source/WebCore

GeneratorGeneratedImage::drawPattern does not factor in its destination context's scale when generating its image tiles

​https://bugs.webkit.org/show_bug.cgi?id=67729
<rdar://problem/10087050>

Reviewed by Beth Dakin.

No new tests, current pixel tests will cover this. Though some pixel results might improve to become less pixel-y.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw): Updated context to destContext for consistency.
(WebCore::GeneratorGeneratedImage::drawPattern): Taught drawPattern about the destination
scale factor to avoid having low-res generated images such as gradients in certain cases.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer): Have the image buffer match the
context acceleration setting as well.

4:50 PM Changeset in webkit [107156] by abarth@webkit.org
  • 2 edits in trunk/Tools

Remove Python 2.5 support from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Eric Seidel.

This is the last vestige of our Python 2.5 support.

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(AbstractQueueTest.test_log_from_script_error_for_upload):

4:46 PM Changeset in webkit [107155] by abarth@webkit.org
  • 2 edits in trunk/Tools

version_check.py should inform users that we don't support Python 2.5 anymore
​https://bugs.webkit.org/show_bug.cgi?id=78179

Reviewed by Eric Seidel.

We don't support Python 2.5 anymore.

  • Scripts/webkitpy/common/version_check.py:
4:37 PM Changeset in webkit [107154] by abarth@webkit.org
  • 1 delete in trunk/Tools/Scripts/webkitpy/python24

Remove empty directory.

4:32 PM Changeset in webkit [107153] by abarth@webkit.org
  • 2 edits in trunk/Tools

test_configuration.py shouldn't re-implement itertools
​https://bugs.webkit.org/show_bug.cgi?id=78178

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):

4:30 PM Changeset in webkit [107152] by jchaffraix@webkit.org
  • 3 edits
    3 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/mac-future/svg/carto.net: Added.
  • platform/mac-future/svg/carto.net/scrollbar-expected.png: Added.
  • platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Added.

Updated the baseline here, thanks to the text on the button...

  • platform/chromium/test_expectations.txt:

Marked one test as failing as some output don't make much sense.

4:27 PM Changeset in webkit [107151] by abarth@webkit.org
  • 7 edits in trunk/Tools

webkitpy should reply upon the multiprocessing package existing
​https://bugs.webkit.org/show_bug.cgi?id=78176

Reviewed by Eric Seidel.

Now that we don't support Python 2.5, this import can't fail.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_Process):
(_Process.init):
(_Process.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(FunctionTests.test_getprocesses):
(MultiProcessBrokerTests.setUp):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.default_worker_model):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.check_build):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_default_worker_model):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4:25 PM Changeset in webkit [107150] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed typo fix that makes docs build again for the gtk2-based
library.

  • gtk/generate-gtkdoc:
4:24 PM Changeset in webkit [107149] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Simplify and correct mutation delivery timing for JSC
​https://bugs.webkit.org/show_bug.cgi?id=78172

Reviewed by Adam Barth.

Instead of keeping a static recursion counter in JSMainThreadExecState,
simply wait for a state change from non-null ExecState to null ExecState.
Because s_mainThreadState is initially null, this equivalent to
waiting for s_recursionLevel to rewind to zero.

This also properly handles the usage of JSMainThreadNullState (and
does not do mutation delivery), since that class is only used by
non-JS bindings. Now fast/mutation/end-of-task-delivery.html properly
fails, whereas it was passing before due to usage of the ObjC DOM API
from DumpRenderTree.

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore):

  • bindings/js/JSMainThreadExecState.h: Added a comment explaining the purpose of JSMainThreadNullState.

(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):
(WebCore):

4:21 PM Changeset in webkit [107148] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
it to [ObjCImplementedAsUnsignedLong]
​https://bugs.webkit.org/show_bug.cgi?id=78100

Reviewed by Eric Seidel.

Now [ConvertToString] is used by ObjC's HTMLElement.size only.
This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec

says HTMLInputElement.size should be unsigned long.
(​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)

4:10 PM Changeset in webkit [107147] by abarth@webkit.org
  • 2 edits in trunk/Tools

Don't re-implement ZipFile.extractall
​https://bugs.webkit.org/show_bug.cgi?id=78173

Reviewed by Eric Seidel.

We can use ZipFile.extractall now that we don't support Python 2.5.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_targz):
(AutoInstaller._unzip):

4:04 PM Changeset in webkit [107146] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
​https://bugs.webkit.org/show_bug.cgi?id=78088

Reviewed by Antonio Gomes.

WebCore::getDOMObjectWrapper was changed to WebCore::wrap in r84194.
Adapt to this change in JSEntryCustom.cpp and JSEntrySyncCustom.cpp.

Build fix, no new tests.

  • bindings/js/JSEntryCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSEntrySyncCustom.cpp:

(WebCore::toJS):

3:59 PM Changeset in webkit [107145] by abarth@webkit.org
  • 5 edits
    2 deletes in trunk/Tools

Remove the ospath compat shim from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=78170

Reviewed by Eric Seidel.

We no longer need this compat shim now that we don't support Python 2.5.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.relpath):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.relpath):

  • Scripts/webkitpy/common/system/ospath.py: Removed.
  • Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
3:57 PM Changeset in webkit [107144] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix attempt after r107053.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests):

3:48 PM Changeset in webkit [107143] by commit-queue@webkit.org
  • 12 edits
    6 adds in trunk

[Chromium] Fix opaque tracking for box shadows and non-composited child elements
​https://bugs.webkit.org/show_bug.cgi?id=78073

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-08
Reviewed by Stephen White.

Source/WebCore:

Tests: compositing/culling/scrolled-within-boxshadow.html

compositing/culling/translated-boxshadow.html

Unit tests: PlatformContextSkiaTest.cpp

When painting a box shadow, a filter is applied to the skia canvas, that can make
pixels painted with an opaque color end up non-opaque. So consider image/mask/color
filters when deciding if a paint is opaque.

Also when painting the background of an element with a box shadow, the background is
painted with a transform on the skia canvas based on the size of the box shadow. This
transform needs to be considered when tracking an opaque paint.

However, when a layer's contentRect position is non-zero, we translate the GraphicsContext
to put the contentRect at 0,0 in the skia canvas. For tracking opaque regions in the resulting
layer, we need to unto this translation. Scaling can also occur which we must undo. So we pass
the transform in to PlatformContextSkia to go from the SkCanvas back to the layer's content
coordinate space. Opaque paints can then be tracked in the layer's content space rather than
in the skia canvas space.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(WebCore):
(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(WebCore):
(OpaqueRegionSkia):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::setOpaqueRegionTransform):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

LayoutTests:

  • compositing/culling/scrolled-within-boxshadow-expected.png: Added.
  • compositing/culling/scrolled-within-boxshadow-expected.txt: Added.
  • compositing/culling/scrolled-within-boxshadow.html: Added.
  • compositing/culling/translated-boxshadow-expected.png: Added.
  • compositing/culling/translated-boxshadow-expected.txt: Added.
  • compositing/culling/translated-boxshadow.html: Added.
3:46 PM Changeset in webkit [107142] by eae@chromium.org
  • 1050 edits
    233 copies
    1 add
    50 deletes in branches/subpixellayout

Merging trunk changes up until 107124 into subpixel branch.

3:35 PM Changeset in webkit [107141] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

Remove simplejson because it's no longer used by webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=78164

Reviewed by Eric Seidel.

All the importers of this code were removed in a previous patch.

  • Scripts/webkitpy/thirdparty/simplejson: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/init.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
3:34 PM Changeset in webkit [107140] by jchaffraix@webkit.org
  • 2 edits
    9 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.

Updated this baseline. It looks like an opacity difference of 1 that we could't really explain.

  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
  • platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Removed.

Rebaselined those tests on snowleopard as we started taking up the new snow-leopard baselines from r107122.

  • platform/chromium/test_expectations.txt:

Mark compositing/iframes/scrolling-iframe.html as flaky as seen on a snow-leopard or windows (debug) bot near you.

3:26 PM Changeset in webkit [107139] by abarth@webkit.org
  • 12 edits in trunk/Tools

webkitpy still imports simplejson
​https://bugs.webkit.org/show_bug.cgi?id=78161

Reviewed by Eric Seidel.

We no longer support Python 2.5, so we can rely upon Python's built-in
JSON package.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/style/checkers/jsonchecker.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
3:20 PM Changeset in webkit [107138] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fails to build docs with non-standard build directories
​https://bugs.webkit.org/show_bug.cgi?id=78118

  • gtk/common.py:

(get_build_path): add comment to document changes done in r107098,
as requested by the reviewer and forgotten by me.

3:14 PM Changeset in webkit [107137] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
​https://bugs.webkit.org/show_bug.cgi?id=78089

Reviewed by Adam Barth.

This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
should have custom header or not will depend on JavaScript bindings.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • dom/Node.idl:
  • html/canvas/CanvasPixelArray.idl:
3:08 PM Changeset in webkit [107136] by abarth@webkit.org
  • 26 edits in trunk/Tools

Stop importing with_statement from the mysterious future
​https://bugs.webkit.org/show_bug.cgi?id=78156

Reviewed by Eric Seidel.

The future is now! (Well, at least 2008, when Python 2.6 was released,
is no longer the future.)

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/net/file_uploader.py:
  • Scripts/webkitpy/common/newstringio_unittest.py:
  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/path.py:
  • Scripts/webkitpy/common/thread/threadedmessagequeue.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:

(of):

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
  • Scripts/webkitpy/tool/commands/analyzechangelog.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2:44 PM Changeset in webkit [107135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Dispatch updateViewportArguments(), when Document is finished
restoring from page cache.

​https://bugs.webkit.org/show_bug.cgi?id=77943

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Move updateViewportArguments() call from setPageInCache() to
documentDidResumeFromPageCache() to ensure, that the Document is
fully resumed from the page cache and attached to the mainframe,
when the viewport arguments are updated.

No tests. No change in behaviour.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):
(WebCore::Document::documentDidResumeFromPageCache):

2:38 PM Changeset in webkit [107134] by jchaffraix@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.

Add those 2 new baselines.

2:17 PM Changeset in webkit [107133] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderView.cpp

Prevent painting rects that snap to zero width or height.

1:49 PM BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
(diff)
1:47 PM Changeset in webkit [107132] by jamesr@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Add a layout test for losing the compositor context with a video playing
​https://bugs.webkit.org/show_bug.cgi?id=78060

Reviewed by Eric Carlson.

Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
frame to be displayed).

Prior to r106610 this test times out in debug and crashes in ASAN.

  • platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
  • platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
  • platform/chromium/compositing/lost-compositor-context-with-video.html: Added.
1:46 PM Changeset in webkit [107131] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Whoops, fix the build.

1:41 PM Changeset in webkit [107130] by shawnsingh@chromium.org
  • 6 edits in trunk/Source

[chromium] Remove incorrect early exit in CCDamageTracker
​https://bugs.webkit.org/show_bug.cgi?id=76924

Reviewed by James Robinson.

Source/WebCore:

New unit test added to CCDamageTrackerTest.cpp

This patch does three things: (1) adds unit test that demonstrates
that early exiting in CCDamageTracker is wrong, (2) removes the
early exit and cleans up the surrounding code, and (3) re-names
several functions in CCDamageTracker so that state updating is
implied by the name, and not just a bad side-effect of the functions.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):

1:37 PM Changeset in webkit [107129] by rwlbuis@webkit.org
  • 1 edit
    6 adds in trunk/Tools

[BlackBerry] Upstream DumpRenderTreeBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream more parts of our DRT implementation.

  • DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/EventSender.cpp: Added.
  • DumpRenderTree/blackberry/EventSender.h: Added.
  • DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
1:35 PM Changeset in webkit [107128] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix issue encountered while debugging stacktraces
​https://bugs.webkit.org/show_bug.cgi?id=78147

Reviewed by Gavin Barraclough.

Debugging is easier if we always ensure that we have a non-null
inferred name.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

1:32 PM Changeset in webkit [107127] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Check that we can make the SharedGraphicsContext3D current before returning
​https://bugs.webkit.org/show_bug.cgi?id=78142

Reviewed by Stephen White.

If we can't make the context current, we can't use it.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

1:30 PM BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
(diff)
1:22 PM Changeset in webkit [107126] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
​https://bugs.webkit.org/show_bug.cgi?id=78145

Reviewed by Gavin Barraclough.

Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.

  • interpreter/CallFrame.h:

(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

1:12 PM Changeset in webkit [107125] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit/chromium

Add support for pinch gesture processing in the MT compositor.
​https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-02-08
Reviewed by James Robinson.

  • public/WebInputEvent.h:
  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

  • tests/WebCompositorInputHandlerImplTest.cpp:
1:02 PM Changeset in webkit [107124] by dpranke@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style failing with "Path does not exist."
​https://bugs.webkit.org/show_bug.cgi?id=77873

Reviewed by Ojan Vafai.

This change fixes the way the style checker determines which
Port class to use for a given test_expectations.txt path; the
previous version used a heuristic that didn't really work in the
first place.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):
(TestExpectationsChecker.init):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.test_determine_port_from_expectations_path):

12:53 PM Changeset in webkit [107123] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Crash in Node::normalize.
​https://bugs.webkit.org/show_bug.cgi?id=78135

Reviewed by Ryosuke Niwa.

No new tests. Original testcase does not reduce to manageable
extent.

  • dom/Node.cpp:

(WebCore::Node::normalize):

12:42 PM Changeset in webkit [107122] by eae@chromium.org
  • 60 edits in trunk/LayoutTests

Update pixel table test expectations for mac to match new DRT scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=76938

Rubber stamped by Eric Seidel.

  • platform/mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11944-expected.png:
  • platform/mac/tables/mozilla/bugs/bug120364-expected.png:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.png:
  • platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug22019-expected.png:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.png:
  • platform/mac/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug29314-expected.png:
  • platform/mac/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.png:
  • platform/mac/tables/mozilla/bugs/bug43039-expected.png:
  • platform/mac/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug44505-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56405-expected.png:
  • platform/mac/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/mac/tables/mozilla/bugs/bug92143-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96343-expected.png:
  • platform/mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:
12:39 PM Changeset in webkit [107121] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Make WebGL context current early to check validity
​https://bugs.webkit.org/show_bug.cgi?id=78141

Patch by Antoine Labour <​piman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Covered by existing tests

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

12:35 PM Changeset in webkit [107120] by commit-queue@webkit.org
  • 15 edits in trunk

[chromium] Disable root layer clears on release builds.
​https://bugs.webkit.org/show_bug.cgi?id=77478

Patch by Jonathan Backer <​backer@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

LayoutTests:

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
12:24 PM Changeset in webkit [107119] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Add a content shadow layer to the render layer compositor
​https://bugs.webkit.org/show_bug.cgi?id=78133
<rdar://problem/10797742>

Reviewed by Beth Dakin.

Have the render layer compositor optionally create a content shadow layer,
and add a ScrollbarTheme::setUpContentShadowLayer member function that subclasses
can use to set content shadow properties.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
Set the layer properties once, and set the shadow path on every call, since we know that this
function will be called every time the size of the content shadow layer changes.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Reposition the content shadow layer, and call ScrollbarTheme::setUpContentShadowLayer if the size changes.

(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
Add new helper function.

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Create a content shadow layer if needed.

12:20 PM Changeset in webkit [107118] by aestes@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize
​https://bugs.webkit.org/show_bug.cgi?id=77167

Reviewed by Eric Seidel.

Source/WebCore:

Test: plugins/layout-in-beforeload-listener-affects-plugin-loading.html

r102983 made FrameView::updateWidgets() check if the DOM node actually
needs a widget update before calling updateWidget(). Due to historical
reasons, however, updateWidget() can be legitimately called twice: once
at attach time for non-Netscape plug-ins and once at layout time for
Netscape plug-ins.

If the widget represents a Netscape plug-in, but updateWidget() is
called for the CreateOnlyNonNetscapePlugins case after the DOM node was
marked as needing an update, updateWidget() will clear the update flag
and prevent a second call to updateWidget() at layout time for the
CreateAnyWidgetType case.

As much as I loathe adding to the code duplication between
HTMLEmbedElement::updateWidget() and HTMLObjectElement::updateWidget(),
the simplest solution seems to be marking the DOM node as needing
update in the case where we are calling updateWidget() for the
CreateOnlyNonNetscapePlugins case and we know we will be loading a
Netscape plug-in.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Call
setNeedsWidgetUpdate(true) if pluginCreationOption is
CreateOnlyNonNetscapePlugins but we will load a Netscape plug-in.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Ditto.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent): Remove an
invalid assertion that prevents the layout test from running in a Debug
configuration.

LayoutTests:

  • plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt: Added.
  • plugins/layout-in-beforeload-listener-affects-plugin-loading.html: Added.
12:17 PM Changeset in webkit [107117] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Make dependency on Accelerate.framework explicit.
​https://bugs.webkit.org/show_bug.cgi?id=78131

It's used by platform/audio/mac/FFTFrameMac.cpp. The explicit
dependency is needed to build a libwebkit.dylib.

Patch by Nico Weber <​nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.

  • WebKit.gyp:
12:17 PM Changeset in webkit [107116] by kbr@google.com
  • 2 edits in branches/chromium/1025

Merge 106888 - WebGL must allocate smaller drawing buffer when the allocation fails.
​https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <​yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9359020

12:16 PM Changeset in webkit [107115] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Don't add selection from password fields to context menu.
​https://bugs.webkit.org/show_bug.cgi?id=77733

Patch by Bernhard Bauer <​bauerb@google.com> on 2012-02-08
Reviewed by Adam Barth.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

12:11 PM Changeset in webkit [107114] by caryclark@google.com
  • 19 edits
    28 adds
    8 deletes in trunk/LayoutTests

Unreviewed rebaselines for vertical text tests.
See ​https://bugs.webkit.org/show_bug.cgi?id=78120

  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:

[...]

  • platform/chromium-mac-snowleopard/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:59 AM Changeset in webkit [107113] by commit-queue@webkit.org
  • 11 edits in trunk/Tools

nrwt: make --skip-pixel-test-if-no-baseline option
​https://bugs.webkit.org/show_bug.cgi?id=70484

Patch by Fehér Zsolt <​feherzs@inf.u-szeged.hu> on 2012-02-08
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):
(SingleTestRunner._should_fetch_expected_checksum):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.handle_test_list):

  • Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.cmd_line):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_skip_pixel_test_if_no_baseline_option):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):

  • WebKitTestRunner/TestInvocation.h:

(WTR::TestInvocation::setSkipPixelTestOption):
(TestInvocation):

11:58 AM Changeset in webkit [107112] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Floated flexboxes render as regular RenderBlocks
​https://bugs.webkit.org/show_bug.cgi?id=77909

Reviewed by Eric Seidel.

Source/WebCore:

Add grid/flexbox cases to adjusting the display of floated/positioned
elements. Also, move this logic into a switch statement. This makes
the code more readable and gives compile warnings when new display types
are added that aren't handled here.

Test: css3/flexbox/floated-flexbox.html

  • css/CSSStyleSelector.cpp:

(WebCore::adjustDisplay):
(WebCore):
(WebCore::CSSStyleSelector::adjustRenderStyle):

LayoutTests:

  • css3/flexbox/floated-flexbox-expected.txt: Added.
  • css3/flexbox/floated-flexbox.html: Added.
11:44 AM Changeset in webkit [107111] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
​https://bugs.webkit.org/show_bug.cgi?id=78130

Patch by Nico Weber <​nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.

  • WebKit.gyp:
11:29 AM Changeset in webkit [107110] by jamesr@google.com
  • 2 edits
    1 delete in trunk/Source/Platform

r107042 caused compile breakages on chromium try bots
​https://bugs.webkit.org/show_bug.cgi?id=78125

Reviewed by Adam Barth.

Replace the copy script with a copies GYP action since the MSVS generator tracks dependencies on a per-file
basis.

  • Platform.gyp/Platform.gyp:
  • Platform.gyp/copy_webcore_headers.py: Removed.
11:26 AM Changeset in webkit [107109] by jchaffraix@webkit.org
  • 6 edits
    4 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt: Added.

More rebaseline of those (I pulled the trigger too early).

  • platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png:
  • platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png:
  • platform/chromium/rubberbanding/custom-scrollbars-se-expected.png:
  • platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png:

Update the expected files. I don't know how we ended up with a blue color when the html specifies
an orange.

  • platform/chromium/test_expectations.txt:

Mark a test as timing out as it has been raising an exception on the bots fairly regularly.

11:19 AM Changeset in webkit [107108] by krit@webkit.org
  • 9 edits
    3 adds in trunk

viewBox on nested SVG causes wrong content size for relative values
​https://bugs.webkit.org/show_bug.cgi?id=69459

Reviewed by Nikolas.

Source/WebCore:

In the past we just checked the change of the viewport size of the root SVG element. If the size changed, all childs
with relative length values needed a relayout. We did not consider that we might have other viewports in the document.
Childs with relative lengths had a strange zooming, if just the viewport size of an inner SVG element changed.

With this patch we check if the size of the nearest viewport changes. Is this the case, childs with relative lengths
need a relayout.

Test: inner-svg-change-viewBox.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGContainer.h:

(RenderSVGContainer):
(WebCore::RenderSVGContainer::determineIfLayoutSizeChanged): Check if we need layout and have relative length values.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout): Remove resetting 'viewport size changed' flag for code operability. No influence on the layout.

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): Add a flag that indicates that the viewport size changes.
(WebCore::RenderSVGViewportContainer::determineIfLayoutSizeChanged): The flag gets set during the layout phase of the SVG element if the size changes.
(WebCore):

  • rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::isLayoutSizeChanged): Added getter to get flag status.
(RenderSVGViewportContainer):
(WebCore::toRenderSVGViewportContainer): Added casting function for constant RenderObjects.
(WebCore):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::layoutSizeOfNearestViewportChanged): Search the nearest viewport and check if the size changed.
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren): Don't check the roots viewport for size changes, but the nearest viewport.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged): Added viewBoxAttr to the list of attributes that cause relayout.

LayoutTests:

Test relayout of content of inner SVG on change of relative length values.

  • svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewBox.svg: Added.
11:13 AM Changeset in webkit [107107] by commit-queue@webkit.org
  • 21 edits
    1 copy
    1 move
    1 add
    2 deletes in trunk

Implement new WEBGL compressed texture extensions
​https://bugs.webkit.org/show_bug.cgi?id=77066

Source/WebCore:

This removes the old experimental compressed
texture extension and implements the first new
one.

A test is in the WebGL conformance tests in
extensions/webgl-compressed-texture-s3tc.html
and will be copied here in a future patch.

Patch by Gregg Tavares <​gman@google.com> on 2012-02-08
Reviewed by Kenneth Russell.

No new tests. Test coming in future patch.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextureS3TC.cpp: Added.

(WebCore):
(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::~WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::getName):
(WebCore::WebGLCompressedTextureS3TC::create):
(WebCore::WebGLCompressedTextureS3TC::supported):

  • html/canvas/WebGLCompressedTextureS3TC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTextureS3TC):

  • html/canvas/WebGLCompressedTextureS3TC.idl: Renamed from Source/WebCore/html/canvas/WebGLCompressedTextures.idl.
  • html/canvas/WebGLCompressedTextures.cpp: Removed.
  • html/canvas/WebGLCompressedTextures.h: Removed.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLGetInfo.cpp:

(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore):
(WebCore::WebGLGetInfo::getWebGLUnsignedIntArray):

  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::addCompressedTextureFormat):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFormat):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

Patch by Gregg Tavares <Gregg Tavares> on 2012-02-08
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/constants.html:
  • fast/canvas/webgl/gl-get-calls-expected.txt:
  • fast/canvas/webgl/gl-get-calls.html:
10:49 AM Changeset in webkit [107106] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.
​https://bugs.webkit.org/show_bug.cgi?id=78113

Retaining path list was replaced with Retaining tree some time ago.
But it was not so useful when we want to track the retaining path from an object to a DOM Window node.

Drive by fix: sort doesn't work in retaining tree panel.
Drive by fix: save/load child nodes doesn't work for the retaining tree panel.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotRetainerEdge.prototype.set retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndEdge):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid td.distanceToWindow-column):

10:35 AM Changeset in webkit [107105] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk

[BlackBerry] Upstream DumpRenderTreeBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=78042

Patch by Rob Buis <​rbuis@rim.com> on 2012-02-08
Reviewed by Antonio Gomes.

Source/WebKit:

Add abstract interface for our DumpRenderTree solution.

  • blackberry/Api/DumpRenderTreeClient.h: Added.

Tools:

Add implementation for our DumpRenderTree solution.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
10:29 AM Changeset in webkit [107104] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
​https://bugs.webkit.org/show_bug.cgi?id=78128

  • platform/qt/Skipped: Skip it until fix.
10:27 AM Changeset in webkit [107103] by jchaffraix@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed morning gardening.

  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Added.

Rebaselined this file (font difference).

  • platform/chromium/test_expectations.txt: Marked one test as SLOW on Window.
10:00 AM Changeset in webkit [107102] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=78126

Reviewed by Dan Bernstein.

This broke in r106977 when I tried to change an early return into an ASSERT,
so let's bring back the early return.

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

9:56 AM Changeset in webkit [107101] by Csaba Osztrogonác
  • 9 edits in trunk/Source

Unreviewed, rolling out r106920, r106924, r106933, r106939,
and r107090.
​http://trac.webkit.org/changeset/106920
​http://trac.webkit.org/changeset/106924
​http://trac.webkit.org/changeset/106933
​http://trac.webkit.org/changeset/106939
​http://trac.webkit.org/changeset/107090
​https://bugs.webkit.org/show_bug.cgi?id=78124

Something is completely wrong this change (Requested by
Ossy_gardener on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-08

Source/WebCore:

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

Source/WebKit2:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

9:35 AM Changeset in webkit [107100] by Antti Koivisto
  • 4 edits
    1 add in trunk

REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
​https://bugs.webkit.org/show_bug.cgi?id=78080

Source/WebKit/mac:

Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

  • WebView/WebFrame.mm:

(-[WebFrame _typingStyle]):

Tools:

Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

Add API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

9:34 AM Changeset in webkit [107099] by hyatt@apple.com
  • 3 edits
    3 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=78122

Add support for the "contains" value for line-grid-snap. This value centers the line box in between the
text-top and text-bottom of the minimum number of grid lines that enclose the line box. This is useful for
centering headers in a line grid.

Reviewed by Adam Roben.

Added a new test in fast/line-grid.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=78122

Add a new test that shows the "contains" value in action.

Reviewed by Adam Roben.

  • fast/line-grid/line-grid-contains-value.html: Added.
  • platform/mac/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
9:31 AM Changeset in webkit [107098] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fails to build docs with non-standard build directories
​https://bugs.webkit.org/show_bug.cgi?id=78118

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-02-08
Reviewed by Martin Robinson.

  • gtk/common.py:

(get_build_path): also try the current directory as a valid build
dir, which makes non-standard build directories such as build-2.0
and build-3.0 work

9:15 AM Changeset in webkit [107097] by caryclark@google.com
  • 2 edits in trunk/Source/WebCore

[Skia Mac] Make misspelling underline dots unclipped
​https://bugs.webkit.org/show_bug.cgi?id=78117
​http://code.google.com/p/chromium/issues/detail?id=113154

Reviewed by Stephen White.

No new tests. Existing layout tests cover this.

As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking):

9:05 AM Changeset in webkit [107096] by mitz@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Moved a Mac-specific test to platform/mac.

  • fast/text/synthetic-bold-transformed-expected.html: Removed.
  • fast/text/synthetic-bold-transformed.html: Removed.
  • platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
  • platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.
9:01 AM Changeset in webkit [107095] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit

Initial upstreaming of input handling for BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=77992

Patch by Nima Ghanavatian <​nghanavatian@rim.com> on 2012-02-08
Reviewed by Rob Buis.

  • blackberry/WebKitSupport/InputHandler.cpp: Added.
  • blackberry/WebKitSupport/InputHandler.h: Added.
8:57 AM Changeset in webkit [107094] by commit-queue@webkit.org
  • 26 edits in trunk

Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
​https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: ​http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: ​http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

  • platform/chromium/test_expectations.txt:
8:42 AM Changeset in webkit [107093] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
​https://bugs.webkit.org/show_bug.cgi?id=78116

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._unbind):

LayoutTests:

  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/insert-node.html:
8:31 AM Changeset in webkit [107092] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Fix a crash when WebKitWebView is created without a WebContext
​https://bugs.webkit.org/show_bug.cgi?id=78104

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
property is initialized to the default web context when a web
context is not passed to g_object_new().

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewDefaultContext): Check that a web view created with
g_object_new has the default context.

8:17 AM Changeset in webkit [107091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
​https://bugs.webkit.org/show_bug.cgi?id=77967

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-08
Reviewed by Yury Semikhatsky.

Condition for RefPtr-based types added. This is more-or-less a hack
and it's should be redone together with the switch to type-safe API.

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

8:02 AM Changeset in webkit [107090] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
CacheModelPrimaryWebBrowser.

LayoutTests:

  • platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.
7:51 AM Changeset in webkit [107089] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
​https://bugs.webkit.org/show_bug.cgi?id=77972

When object popover is shown the object under cursor is resolved and its
wrapper is put into 'popover' object wrapper group. The group is discarded
when the popover closes.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/js/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

7:51 AM Changeset in webkit [107088] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=78099

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewDecidePolicy): Check whether it's a link clicked with the
middle mouse button and load the request in a new window.
(browserWindowConstructed): Connect to
WebKitWebView::decide-policy signal.

7:48 AM Changeset in webkit [107087] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix WebKitWebView::decide-policy API documentation
​https://bugs.webkit.org/show_bug.cgi?id=78101

Reviewed by Martin Robinson.

  • It refers to WebKitPolicyClient instead of WebKitWebView
  • Trailing ':' is missing
  • References @decision as WebKitNavigationPolicyDecision instead

of WebKitPolicyDecision

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

7:38 AM Changeset in webkit [107086] by mario@webkit.org
  • 4 edits in trunk/Source

[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
​https://bugs.webkit.org/show_bug.cgi?id=73431

Reviewed by Chris Fleizach.

Source/WebCore:

Don't replace item's markers with the objectReplacementCharacter
character, as they will be treated in an special way later on.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer): Don't append the objectReplacementCharacter
character for list item's markers.

Source/WebKit/gtk:

Updated unit test to check text wrapping accross different lines
inside list items with bullet markers.

  • tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.

7:11 AM Changeset in webkit [107085] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Remote web inspector reentrancy fixes
​https://bugs.webkit.org/show_bug.cgi?id=77022

Patch by Leo Franchi <​lfranchi@kde.org> on 2012-02-08
Reviewed by Joseph Pecoraro.

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

6:57 AM Changeset in webkit [107084] by podivilov@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.

  • platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
6:49 AM Changeset in webkit [107083] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: do not clear entire tree map upon last element deletion.
​https://bugs.webkit.org/show_bug.cgi?id=78112

Reviewed by Yury Semikhatsky.

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._forgetChildrenRecursive):

6:39 AM Changeset in webkit [107082] by commit-queue@webkit.org
  • 23 edits
    1 copy
    2 adds in trunk

Migrate createObjectURL & revokeObjectURL to static (Class) methods.
​https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Move createObjectURL & revokeObjectURL from DOMURL implementation to
static methods as per specs - ​http://www.w3.org/TR/FileAPI/#creating-revoking

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:

fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.

  • html/DOMURL.h:

(DOMURL):
(WebCore::DOMURL::create):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Added.

(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):

  • page/DOMWindow.cpp: Removed object initialization for DOMURL.

(WebCore):

  • page/DOMWindow.h: ditto.

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
  • platform/gtk/fast/js/global-constructors-expected.txt: ditto.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
  • platform/qt/fast/js/global-constructors-expected.txt: ditto.
6:06 AM Changeset in webkit [107081] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-08 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.

  • platform/chromium/test_expectations.txt:
6:02 AM Changeset in webkit [107080] by podivilov@chromium.org
  • 1 edit
    21 adds in trunk/LayoutTests

Unreviewed, update chromium svg expectations after r107067.

  • platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added.
5:48 AM WebKitGTK/1.6.x edited by kov@webkit.org
(diff)
5:47 AM WebKitGTK/1.6.x edited by kov@webkit.org
(diff)
5:22 AM Changeset in webkit [107079] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Add changes for Spectrum colorpicker
​https://bugs.webkit.org/show_bug.cgi?id=75454

Patch by Brian Grinstead <​briangrinstead@gmail.com> on 2012-02-01
Reviewed by Pavel Feldman.

  • inspector/front-end/Color.js:

(WebInspector.Color.fromRGB):

  • inspector/front-end/utilities.js:

(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
():

5:00 AM Changeset in webkit [107078] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-08 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
​https://bugs.webkit.org/show_bug.cgi?id=78084

  • platform/chromium/test_expectations.txt:
4:59 AM Changeset in webkit [107077] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and skipping 2 new failing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
4:58 AM Changeset in webkit [107076] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressionsSidebarPane
​https://bugs.webkit.org/show_bug.cgi?id=78102

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

4:48 AM Changeset in webkit [107075] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

[Qt] New http/tests/security/ introduced r107046 fail
​https://bugs.webkit.org/show_bug.cgi?id=78093

Unskip these tests and rebaselines for Qt and GTK.

Patch by Ádám Kallai <​Kallai.Adam@stud.u-szeged.hu> on 2012-02-08
Reviewed by Csaba Osztrogonác.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
4:38 AM Changeset in webkit [107074] by Csaba Osztrogonác
  • 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.

  • platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/qt/svg/custom/getTransformToElement-expected.png:
  • platform/qt/svg/custom/getTransformToElement-expected.txt:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
  • platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/qt/svg/custom/text-ctm-expected.png:
  • platform/qt/svg/custom/text-ctm-expected.txt:
  • platform/qt/svg/custom/text-hit-test-expected.png:
  • platform/qt/svg/custom/text-hit-test-expected.txt:
4:37 AM Changeset in webkit [107073] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2012-02-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline Gtk/SVG results.

  • platform/gtk/svg/carto.net/scrollbar-expected.txt:
  • platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:
4:34 AM Changeset in webkit [107072] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
​https://bugs.webkit.org/show_bug.cgi?id=69993

Patch by Antaryami Pandia <​antaryami.pandia@motorola.com> on 2012-02-08
Reviewed by Simon Fraser.

Source/WebCore:

The issue was that for overflow:scroll, currently webkit always places the horizontal
and vertical scrollbar. But Since the listbox renderer handles its scrolling,
we should not set scrollbar for list-box.

Tests: fast/css/getComputedStyle/computed-style-select-overflow.html

fast/forms/select-overflow-scroll-inherited.html
fast/forms/select-overflow-scroll.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
  • fast/forms/select-overflow-scroll-inherited.html: Added.
  • fast/forms/select-overflow-scroll.html: Added.
  • platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
4:31 AM Changeset in webkit [107071] by Nikolas Zimmermann
  • 7 edits in trunk/LayoutTests

qt fixes

4:24 AM Changeset in webkit [107070] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Build broken if qt missing openssl
​https://bugs.webkit.org/show_bug.cgi?id=77894

Reviewed by Chang Shu.

Build fix. No new test content.

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::onSslErrors):

4:18 AM Changeset in webkit [107069] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaselined the test that has been failing since r107046.

  • http/tests/security/cross-frame-access-put-expected.txt:
4:13 AM Changeset in webkit [107068] by yael.aharon@nokia.com
  • 11 edits in trunk/Source/WebKit2

[WK2] Text notifications should have an iconURL
​https://bugs.webkit.org/show_bug.cgi?id=77968

Reviewed by Simon Hausmann.

Per ​http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.

  • UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyiconURL):

  • UIProcess/API/C/WKNotification.h:
  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

4:12 AM Changeset in webkit [107067] by Nikolas Zimmermann
  • 9 edits
    14 copies
    10 moves
    19 adds in trunk

feImage doesn't invalidate when its target SVG element is animated
​https://bugs.webkit.org/show_bug.cgi?id=73860

Reviewed by Dirk Schulze.

Source/WebCore:

Consider following testcase:
<defs>

<rect id="rect" fill="red" width="50" height="50"/>
<filter id="filter">

<feImage xlink:href="#rect"/>

</filter>

</defs>
<rect width="50" height="50" filter="url(#filter)"/>

If the <rect id="rect"> gets changed dynamically (attribute/property/style change) the <feImage>
doesn't notice this, as there's no link between the <rect> and the <feImage>, as the <rect> is not
a child of the <feImage/>. To get invalidations working for these situations, we have to track
the referencingElement & referencedElement in SVGDocumentExtensions.

Fixes parts the SVG-Wow twirl testcase and David Daileys SVG waves example.

Tests: svg/filters/feImage-animated-transform-on-target-rect.svg

svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-mutliple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-target-property-change.svg
svg/filters/feImage-target-style-change.svg

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromFilterCacheAndInvalidateDependencies): Renamed from removeFromFilterCache, as it has another purpose now.
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): s/removeFromFilterCache/removeFromFilterCacheAndInvalidateDependencies/.

  • rendering/svg/RenderSVGResource.h: Removed removeFromFilterCache, it got inlined.
  • svg/SVGDocumentExtensions.cpp: Add a new HashMap<SVGElement*, OwnPtr<HashSet<SVGElement*> > > used for dependency tracking.

(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget): Returns all elements the passed in element depends on.
(WebCore::SVGDocumentExtensions::addElementReferencingTarget): Register element 'a' referencing target 'b'.
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): Called by element 'a' on destruction or any target change.
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Called by element 'b' on destruction.

  • svg/SVGDocumentExtensions.h: Expose new methods.
  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement): Call remove removeAllElementReferencesForTarget on destruction.

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

LayoutTests:

Add lots of new testcases covering <feImage> invalidation, when the referenced target changes.
Thanks to the repaint harness, it uncovered a bug with feImage-late-indirect-update.svg - there no gray
overlay rects are visible, as the whole screen gets repainted, which is a bug!

  • platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/mac/svg/filters/feImage-change-target-id-expected.png: Added.
  • platform/mac/svg/filters/feImage-change-target-id-expected.txt: Added.
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.txt: Added.
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
  • platform/mac/svg/filters/feImage-remove-target-expected.png: Added.
  • platform/mac/svg/filters/feImage-remove-target-expected.txt: Added.
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-add-to-document-expected.png.
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-add-to-document-expected.txt.
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
  • platform/mac/svg/filters/feImage-target-changes-id-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.png.
  • platform/mac/svg/filters/feImage-target-changes-id-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-id-change-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.png.
  • platform/mac/svg/filters/feImage-target-id-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.txt.
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-property-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.png.
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.txt.
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.png.
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.txt.
  • platform/mac/svg/filters/feImage-target-style-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-style-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
  • svg/filters/feImage-animated-transform-on-target-rect.svg: Added.
  • svg/filters/feImage-change-target-id.svg: Added.
  • svg/filters/feImage-late-indirect-update.svg: Added.
  • svg/filters/feImage-multiple-targets-id-change.svg: Added.
  • svg/filters/feImage-remove-target.svg: Added.
  • svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg: Added.
  • svg/filters/feImage-target-attribute-change-with-use-indirection.svg: Added.
  • svg/filters/feImage-target-attribute-change.svg: Added.
  • svg/filters/feImage-target-inline-style-change.svg: Added.
  • svg/filters/feImage-target-property-change.svg: Added.
  • svg/filters/feImage-target-style-change.svg: Added.
4:02 AM Changeset in webkit [107066] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.

  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
3:53 AM Changeset in webkit [107065] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Using string method instead of char* operation in the platformLanguage().
​https://bugs.webkit.org/show_bug.cgi?id=78077

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.

No new tests. Just fix a bug of platformLanguage function.

  • platform/efl/LanguageEfl.cpp:

(WebCore::platformLanguage):
Change char* operation to string operation.

3:40 AM Changeset in webkit [107064] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Revert a part of the change in r106687 as a build fix.

Since Chromium port doesn't checkout the entire WebKit trunk,
we can't run "svn info" on webkit_base.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths):

3:15 AM Changeset in webkit [107063] by haraken@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
The test needs rebaselining.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:13 AM Changeset in webkit [107062] by apavlov@chromium.org
  • 3 edits
    3 adds in trunk

Web Inspector: Touch event emulation fails for iframes
​https://bugs.webkit.org/show_bug.cgi?id=77987

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/events/touch/emulated-touch-iframe.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/touch/emulated-touch-iframe-expected.txt: Added.
  • fast/events/touch/emulated-touch-iframe.html: Added.
  • fast/events/touch/resources/emulated-touch-iframe2.html: Added.
3:03 AM Changeset in webkit [107061] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
<​http://webkit.org/b/78068>

Rubber-stamped by Ryosuke Niwa.

Turns out that setProperty() with a CSSProperty has quite different behavior from
the other setProperty() methods. We should probably clean that up (separately.)
For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
use setProperty(CSSProperty).

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

2:55 AM Changeset in webkit [107060] by morrita@google.com
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r107050.
​http://trac.webkit.org/changeset/107050
​https://bugs.webkit.org/show_bug.cgi?id=78094

May crash editing tests (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-08

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

2:42 AM Changeset in webkit [107059] by Csaba Osztrogonác
  • 5 edits in trunk

[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
​https://bugs.webkit.org/show_bug.cgi?id=77995

Patch by Nikolas Zimmermann <​nzimmermann@rim.com> on 2012-02-08
Reviewed by Csaba Osztrogonác.

Source/WebCore:

From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
from frameDetached(). There's no point in redrawing there, so we should just stop it.

Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.

  • svg/graphics/SVGImage.h:

LayoutTests:

  • platform/qt/Skipped: Unskip previously skipped tests.
2:39 AM Changeset in webkit [107058] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk

Add state attribute to history's dom interface.
​https://bugs.webkit.org/show_bug.cgi?id=76035

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-object-types.html

fast/loader/stateobjects/state-attribute-only-one-deserialization.html

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::state):
(WebCore):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):
(WebCore):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • page/History.cpp:

(WebCore::History::History):
(WebCore::History::state):
(WebCore):
(WebCore::History::stateInternal):
(WebCore::History::stateChanged):

  • page/History.h:

(History):

  • page/History.idl:

LayoutTests:

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-object-types.html: Added.
  • fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.
2:21 AM Changeset in webkit [107057] by Nikolas Zimmermann
  • 64 edits in trunk

SVGLoad event fires too early
​https://bugs.webkit.org/show_bug.cgi?id=78084

Reviewed by Hajime Morita.

Source/WebCore:

SVGLoad event fires too early, making it impossible to use the vanilla repaint.js harness (runRepaintTest).

We're using a hack called runSVGRepaintTest() at the moment in trunk, which runs runRepaintTest() from a 0ms timer,
which is not reliable. The main difference between HTML onload and SVG onload is that HTMLs event is a "window event",
thus dispatched through DOMWindow (eg. <body onload="alert(event.target)" will yield Document,
<svg onload="alert(evt.target)"> will say SVGSVGElement).

Consider:
<svg onload="alert('1')>
<g onload="alert('2)">
<rect onload="alert('3')"/>
</svg>

As soon as the <rect> finishes parsing (SVGElement::finishedParsingChildren), it's SVGLoad event is fired.
So first you'll see '3', then '2', then '1'.

Using:
<svg onload="alert('1')>
<g onload="alert('2)">
<image xlink:href="someExternal.jpg" onload="alert('3')"/>
</svg>

will yield the same SVGLoad order. When using <image externalREsourcesRequired="true", first the '1' will fire,
then '3', then '2', all as expected and specified in SVG.

​http://www.w3.org/TR/SVG/interact.html#LoadEvent says:
"The event is triggered at the point at which the user agent has fully parsed the element and its descendants and is
ready to act appropriately upon that element, such as being ready to render the element to the target device. Referenced
external resources that are required must be loaded, parsed and ready to render before the event is triggered. Optional
external resources are not required to be ready for the event to be triggered."

What we don't implement correctly is the second part of the first sentence: "and is ready to act appropriately upon that
element, such as being ready to render the element to the target device". We currently fire the SVGLoad event, right after
</svg> is seen, if no externalResourceRequired="true" attributes are set anywhere. This is not wrong, but not correct for
WebKit, as we're not yet "ready to render".

HTML fires its window onload event from Document::implicitClose(), where it calls Document::dispatchWindowLoadEvent.
At this point we're ready to render. So I'm now aligning the timing of the outermost <svg> elements SVGLoad event, to be
equal to HTML. This lets use use the repaint.js harness w/o any special SVG tricks.

Covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::implicitClose): Dispatch SVGLoad event for outermost <svg> elements from here, as HTML does for its window onload event.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Sends a SVGLoad event to all outermost <svg> elements in a document, if possible.
There can be multiple ones, if using <svg><foreignObject><svg>... - the <svg> in the <fO> also acts as outermost <svg> element.

  • svg/SVGDocumentExtensions.h: Add new dispatchSVGLoadEventToOutermostSVGElements() helper.
  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement): Moved from SVGSVGElement into SVGElement, and renamed from isOutermostSVG().
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't dispatch load events to outermost <svg> elements, if Document::implicitClose() wasn't called yet.
(WebCore::SVGElement::finishParsingChildren): Stop using the default SVGLoad dispatching logic for outermost <svg> elements.

  • svg/SVGElement.h: Add isOutermostSVGSVGElement().
  • svg/SVGSVGElement.cpp: Rename isOutermostSVG to isOutermostSVGSVGElement.

(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::createRenderer):

  • svg/SVGSVGElement.h: Move isOutermostSVG() to SVGElement.
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title): Rename isOutermostSVG to isOutermostSVGSVGElement.

LayoutTests:

Remove runSVGRepaintTest() from repaint.js again, and convert all *.svg tests to use runRepaintTest() directly.
This is now possible as the outermost <svg> elements load event timing as aligned with HTML.

  • fast/repaint/resources/repaint.js: Remove runSVGRepaintTest(), it's no longer needed.

(runRepaintTest): s/document.rootElement/document.documentElement/ to make it work for all HTML/XHTML and SVG documents (XHTML was broken).

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/mac/svg/custom/getTransformToElement-expected.png:
  • platform/mac/svg/custom/getTransformToElement-expected.txt:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.png:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/mac/svg/custom/text-ctm-expected.png:
  • platform/mac/svg/custom/text-ctm-expected.txt:
  • platform/mac/svg/custom/text-hit-test-expected.png:
  • platform/mac/svg/custom/text-hit-test-expected.txt:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • svg/carto.net/tabgroup.svg:
  • svg/carto.net/window.svg:
  • svg/css/shadow-changes.svg:
  • svg/custom/loadevents-externalresourcesrequired.svg:
  • svg/dom/SVGPathSegList-segment-modification.svg:
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
  • svg/dom/SVGRectElement/rect-modify-rx.svg:
  • svg/filters/animate-fill.svg:
  • svg/filters/feImage-reference-invalidation.svg:
  • svg/filters/feImage-target-add-to-document.svg:
  • svg/filters/feImage-target-changes-id.svg:
  • svg/filters/feImage-target-id-change.svg:
  • svg/filters/feImage-target-reappend-to-document.svg:
  • svg/filters/feImage-target-remove-from-document.svg:
  • svg/filters/filter-refresh.svg:
  • svg/filters/filter-width-update.svg:
  • svg/filters/invalidate-on-child-layout.svg:
  • svg/hixie/perf/001.xml:
  • svg/hixie/perf/002.xml:
  • svg/hixie/perf/003.xml:
  • svg/hixie/perf/004.xml:
  • svg/hixie/perf/005.xml:
  • svg/hixie/perf/006.xml:
  • svg/hixie/perf/007.xml:
  • svg/repaint/container-repaint.svg:
  • svg/repaint/filter-child-repaint.svg:
  • svg/repaint/image-href-change.svg:
  • svg/repaint/image-with-clip-path.svg:
  • svg/text/text-text-05-t.svg:
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/page/absolute-sized-document-scrollbars.svg:
  • svg/zoom/page/relative-sized-document-scrollbars.svg:
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
  • svg/zoom/resources/testPageZoom.js:

(repaintTest):

  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/text/absolute-sized-document-scrollbars.svg:
  • svg/zoom/text/relative-sized-document-scrollbars.svg:
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/text/zoom-foreignObject.svg:
2:11 AM Changeset in webkit [107056] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
​https://bugs.webkit.org/show_bug.cgi?id=78090

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):

2:00 AM Changeset in webkit [107055] by apavlov@chromium.org
  • 7 edits
    2 adds in trunk

Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
​https://bugs.webkit.org/show_bug.cgi?id=77865

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/lazy-computed-style.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):

  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/css-live-edit.html:
  • inspector/styles/lazy-computed-style-expected.txt: Added.
  • inspector/styles/lazy-computed-style.html: Added.
  • inspector/styles/styles-computed-trace.html:
1:52 AM Changeset in webkit [107054] by tommyw@google.com
  • 6 edits in trunk/Source/WebCore

MediaStream API: Adding the onstatechange callback to PeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=77954

When readyState changes a callback should be triggered.

Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • dom/EventNames.h:

(WebCore):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::changeReadyState):

  • mediastream/PeerConnection.h:

(PeerConnection):
(WebCore::PeerConnection::didChangeState):

  • mediastream/PeerConnection.idl:
  • platform/mediastream/PeerConnectionHandlerClient.h:

(PeerConnectionHandlerClient):

1:51 AM Changeset in webkit [107053] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests doesn't recognize paths that start with PerformanceTests
​https://bugs.webkit.org/show_bug.cgi?id=78012

Reviewed by Adam Barth.

Use resolve paths using filesystem.relpath before passing it to find_files.find.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._collect_tests):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests):
(test_collect_tests.add_file):

1:17 AM Changeset in webkit [107052] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening after r106982.
Skip a new test because of missing AuthenticationChallenges support.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
12:57 AM Changeset in webkit [107051] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77963

Reviewed by Adam Barth.

This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

  • bindings/scripts/test/TestInterface.idl:
  • css/CSSStyleDeclaration.idl:
  • dom/DOMStringMap.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/Storage.idl:
12:57 AM Changeset in webkit [107050] by commit-queue@webkit.org
  • 7 edits in trunk

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
​https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <​shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

12:47 AM Changeset in webkit [107049] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2012-02-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Add missing results for a new SVG test.

  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.
12:37 AM Changeset in webkit [107048] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-08 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.

  • platform/chromium/test_expectations.txt:
12:29 AM Changeset in webkit [107047] by dmazzoni@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.

12:13 AM Changeset in webkit [107046] by haraken@chromium.org
  • 4 edits
    3 adds in trunk

Replace [CheckNodeSecurity] with [CheckAccessToNode]
​https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

  • page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

  • http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
  • http/tests/security/cross-frame-access-frameelement.html: Added.
  • http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
12:05 AM Changeset in webkit [107045] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
​https://bugs.webkit.org/show_bug.cgi?id=78081

Reviewed by Adam Barth.

[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • dom/Node.idl:
  • html/HTMLElement.idl:
12:05 AM Changeset in webkit [107044] by Philippe Normand
  • 5 edits in trunk/Source/WebKit2

[GTK][WK2] enable-webaudio WebSetting
​https://bugs.webkit.org/show_bug.cgi?id=77959

Reviewed by Martin Robinson.

Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

Feb 7, 2012:

11:21 PM Changeset in webkit [107043] by Martin Robinson
  • 6 edits
    3 adds in trunk/Source/WebKit2

[GTK] [WK2] Add WebKitResponsePolicyDecision
​https://bugs.webkit.org/show_bug.cgi?id=76789

Reviewed by Philippe Normand.

Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.

  • GNUmakefile.am: Added new source files to the list.
  • UIProcess/API/gtk/WebKitPolicyClient.cpp:

(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.

  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
  • UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
  • UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:

(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.

10:56 PM Changeset in webkit [107042] by commit-queue@webkit.org
  • 11 edits
    6 copies
    1 move
    1 add in trunk/Source

[chromium] Move geometry headers in Platform API to Platform directory
​https://bugs.webkit.org/show_bug.cgi?id=78067

Patch by James Robinson <​jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

Source/Platform:

This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.

Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.

  • Platform.gyp/Platform.gyp:
  • Platform.gyp/copy_webcore_headers.py: Added.

(CopyHeaders):
(Main):

  • chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.

(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.

(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):

  • chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.

(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.

(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.

(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.

(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):

Source/WebKit/chromium:

Add forwarding headers for several API types moved into Platform.

  • public/platform/WebFloatPoint.h:
  • public/platform/WebFloatQuad.h:
  • public/platform/WebFloatRect.h:
  • public/platform/WebPoint.h:
  • public/platform/WebRect.h:
  • public/platform/WebSize.h:
10:40 PM Changeset in webkit [107041] by haraken@chromium.org
  • 51 edits in trunk/Source/WebCore

Add "JS" prefix to JSC-specific IDLs
​https://bugs.webkit.org/show_bug.cgi?id=77846

Reviewed by Darin Adler.

In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:

[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/TestTypedArray.idl:
  • dom/Attr.idl:
  • dom/DataTransferItemList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/DOMFormData.idl:
  • html/DOMURL.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLVideoElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • mediastream/LocalMediaStream.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/StorageInfo.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstance.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
10:33 PM Changeset in webkit [107040] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebTextCheckingResult should have new default constructor
​https://bugs.webkit.org/show_bug.cgi?id=78066

Reviewed by Ryosuke Niwa.

Added a new default constructor. ex-default constructor will be removed
in an upcoming change.

  • public/WebTextCheckingResult.h:

(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):

9:47 PM Changeset in webkit [107039] by haraken@chromium.org
  • 6 edits
    11 moves
    2 adds
    2 deletes in trunk/Source/WebCore

Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
​https://bugs.webkit.org/show_bug.cgi?id=78076

Reviewed by Adam Barth.

This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].

Test: bindings/scripts/test/TestCustomNamedGetter.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

  • html/HTMLDocument.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameSetElement.idl:
  • bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.

(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.

(WebCore):
(WebDOMTestCustomNamedGetter):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.

(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.

(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.

(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.

(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.

(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.

(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.

(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

9:37 PM Changeset in webkit [107038] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Revert TableSection cell and border calculations to integers
​https://bugs.webkit.org/show_bug.cgi?id=77918

Reviewed by Eric Seidel.

Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.

No new tests.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

9:34 PM Changeset in webkit [107037] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Plumb through webGLErrorsToConsoleEnable in WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=78061

Patch by Gregg Tavares <​gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

9:06 PM Changeset in webkit [107036] by commit-queue@webkit.org
  • 22 edits
    10 deletes in trunk

Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
​https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • wtf/Platform.h:

Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
​https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • WebCore.gypi:
  • platform/PlatformGestureRecognizer.h: Removed.
  • platform/chromium/FramelessScrollView.h:

(WebCore):
(FramelessScrollView):

  • platform/chromium/GestureRecognizerChromium.cpp: Removed.
  • platform/chromium/GestureRecognizerChromium.h: Removed.
  • platform/chromium/PopupContainer.cpp:

(WebCore):

  • platform/chromium/PopupContainer.h:
  • platform/chromium/PopupListBox.cpp:

(WebCore):

  • platform/chromium/PopupListBox.h:

(PopupListBox):

Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
​https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • blackberry/WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
​https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • WebKit.gypi:
  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

  • tests/InnerGestureRecognizerTest.cpp: Removed.

LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
​https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/events/touch/touch-gesture-click-expected.txt: Removed.
  • fast/events/touch/touch-gesture-click.html: Removed.
  • fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
  • fast/events/touch/touch-gesture-scroll.html: Removed.
  • platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
  • platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
8:23 PM Changeset in webkit [107035] by arv@chromium.org
  • 9 edits
    1 delete in trunk

[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
​https://bugs.webkit.org/show_bug.cgi?id=78052

Reviewed by Nate Chapin.

Source/WebCore:

Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.

Covered by existing tests

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

LayoutTests:

  • platform/chromium/test_expectations.txt:
8:14 PM Changeset in webkit [107034] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
​https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
8:05 PM Changeset in webkit [107033] by leo.yang@torchmobile.com.cn
  • 1 edit
    2 adds in trunk/Source/WebKit

[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
​https://bugs.webkit.org/show_bug.cgi?id=77843

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.
7:56 PM Changeset in webkit [107032] by eae@chromium.org
  • 14 edits in trunk/Source/WebCore

Add pixelSnappedX/Y/Width/Height methods
​https://bugs.webkit.org/show_bug.cgi?id=78040

Reviewed by Eric Seidel.

Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.

When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.

In summary, the values are computed as follows:

x: round(x)
y: round(y)
maxX: round(x + width)
maxY: round(y + height)
width: round(x + width) - round(x)
height: round(y + height) - round(y)

We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.

No new tests, no functionality changes.

  • page/PrintContext.cpp:

(WebCore::PrintContext::pageNumberForElement):

  • rendering/RenderBlock.cpp:

(WebCore::::collectIfNeeded):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollHeight):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

7:53 PM Changeset in webkit [107031] by jchaffraix@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed gardening.

Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.

  • platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.
7:40 PM Changeset in webkit [107030] by mikelawther@chromium.org
  • 7 edits in trunk

CSS3 calc() - simple parse time evaluation
​https://bugs.webkit.org/show_bug.cgi?id=77960

Source/WebCore:

Adds simple number/percent expression evaluation. rgb() and hsl() functions now
allow simple calc() expressions.

Reviewed by Ojan Vafai.

  • css/CSSCalculationValue.cpp:

(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parsedDouble):

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/calc/color-hsl-expected.txt:
  • css3/calc/color-rgb-expected.txt:
7:26 PM Changeset in webkit [107029] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<​http://webkit.org/b/78068>

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSProperty):

7:20 PM Changeset in webkit [107028] by timothy@apple.com
  • 4 edits in trunk/Source/WebKit2

Avoid making a window for the Web Inspector when it is docked.

This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.

​https://webkit.org/b/78064

Reviewed by Brian Weinstein.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.

7:10 PM Changeset in webkit [107027] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Remove TextureMapperQt from the gyp projects
​https://bugs.webkit.org/show_bug.cgi?id=78055

Reviewed by Noam Rosenthal.

TextureMapperQt.{cpp,h} were removed in r106659, remove references to
these files from the gyp projects.

  • WebCore.gypi:
7:00 PM Changeset in webkit [107026] by tony@chromium.org
  • 12 edits
    1 delete in trunk/Source

merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
​https://bugs.webkit.org/show_bug.cgi?id=78036

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebCore:

In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.

No new tests, build refactoring.

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
  • DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
  • DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
  • WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
  • css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
  • css/DashboardSupportCSSPropertyNames.in: Removed.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
6:51 PM Changeset in webkit [107025] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

Enable IPP for FFTFrame
​https://bugs.webkit.org/show_bug.cgi?id=75522

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2012-02-07
Reviewed by Tony Chang.

Add the FFTFrame implementation using Intel IPP's DFT algorithm.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/audio/FFTFrame.h:

(FFTFrame):

  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/ipp/FFTFrameIPP.cpp: Added.

(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):

6:47 PM Changeset in webkit [107024] by enne@google.com
  • 3 edits in trunk/Source/WebCore

Properly detect top level frames when propogating compositing
​https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

6:21 PM Changeset in webkit [107023] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Resolve crash in FrameLoader::checkTimerFired.
​https://bugs.webkit.org/show_bug.cgi?id=77907

Patch by Chris Palmer <​palmer@google.com> on 2012-02-07
Reviewed by Eric Seidel.

Source/WebCore:

Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkTimerFired):

LayoutTests:

  • http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
  • http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
  • http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
  • http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.
6:06 PM Changeset in webkit [107022] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=78039

Patch by Justin Novosad <​junov@chromium.org> on 2012-02-07
Reviewed by Stephen White.

Adding the --enable-deferred-2d-canvas switch to DumpRenderTree

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setDeferred2dCanvasEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

6:05 PM Changeset in webkit [107021] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
​https://bugs.webkit.org/show_bug.cgi?id=78029

Patch by Yong Li <​yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.

When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.

No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

5:51 PM Changeset in webkit [107020] by gyuyoung.kim@samsung.com
  • 13 edits in trunk

[CMAKE] Use *bin* and *lib* directories for executable and libraries.
​https://bugs.webkit.org/show_bug.cgi?id=77928

Reviewed by Daniel Bates.

CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.

.:

  • CMakeLists.txt: Set library output path.
  • Source/cmake/WebKitFS.cmake: Remove *Programs* creation.

Source/JavaScriptCore:

  • shell/CMakeLists.txt: Change *Programs* with *bin*.

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:

(jscProductDir):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_driver):
(EflPort._path_to_image_diff):

5:49 PM Changeset in webkit [107019] by commit-queue@webkit.org
  • 20 edits in trunk

Remove extraneous MathML code before bug 52444 fix
​https://bugs.webkit.org/show_bug.cgi?id=78034

Source/WebCore:

Patch by David Barton <Dave Barton> on 2012-02-07
Reviewed by Eric Seidel.

Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.

No new tests.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):

  • changed to a static member function since 'this' is unused; removed redundant non-const version

(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):

  • changed to a static member function since 'this' is unused; removed redundant non-const version

(WebCore):

  • rendering/mathml/RenderMathMLFraction.cpp:
  • rendering/mathml/RenderMathMLMath.cpp:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLOperator.h:

(WebCore):

  • rendering/mathml/RenderMathMLRoot.cpp:
  • rendering/mathml/RenderMathMLRow.cpp:
  • rendering/mathml/RenderMathMLRow.h:
  • rendering/mathml/RenderMathMLSquareRoot.cpp:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLSubSup.cpp:
  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:
  • rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

Patch by David Barton <Dave Barton> on 2012-02-07
Reviewed by Eric Seidel.

The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.

  • mathml/presentation/row.xhtml:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
5:37 PM Changeset in webkit [107018] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
​https://bugs.webkit.org/show_bug.cgi?id=78030

Unreviewed.

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-07

  • platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
5:28 PM Changeset in webkit [107017] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.

If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.

5:16 PM Changeset in webkit [107016] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk

Get rid of Source/autotools/webkit.m4
​https://bugs.webkit.org/show_bug.cgi?id=77833

Patch by Priit Laes <​plaes@plaes.org> on 2012-02-07
Reviewed by Martin Robinson.

Move checks from webkit.m4 to configure.ac and modernize macros:

. Check for visibility flags after CXX has been defined
. Use PKG_PROG_PKG_CONFIG for pkg-config lookup
. Drop unused LIBFFTW_REQUIRED_VERSION
. Update ICU libs for mingw (bug 77837).
. Require Pango 1.21.0 (as per unicode backend)
. Bump minimum glib version due to g_thread_init changes

  • Source/autotools/webkit.m4: Removed.
  • configure.ac:
5:15 PM Changeset in webkit [107015] by Lucas Forschler
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

5:03 PM Changeset in webkit [107014] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
​https://bugs.webkit.org/show_bug.cgi?id=78020

Patch by David Reveman <​reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

Revert r101854.

This patch is tested by the following unit test:

  • TextureManagerTest.requestTextureExceedingPreferredLimit
  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::reserve):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

Source/WebKit/chromium:

Update TextureManagerTest.requestTextureExceedingPreferredLimit test.

  • tests/TextureManagerTest.cpp:

(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):

5:00 PM Changeset in webkit [107013] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Use the non-fast-scrollable region to detect when we can't do fast scrolling
​https://bugs.webkit.org/show_bug.cgi?id=78056
<rdar://problem/10247932>

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.

  • platform/graphics/Region.cpp:
  • platform/graphics/Region.h:

Add a simple contains(const IntPoint&) member function.

4:59 PM Changeset in webkit [107012] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/10475450> Synthetic bold is illegible under some scaling transforms
​https://bugs.webkit.org/show_bug.cgi?id=78044

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/text/synthetic-bold-transformed-expected.html

fast/text/synthetic-bold-transformed.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.

LayoutTests:

  • fast/text/synthetic-bold-transformed-expected.html: Added.
  • fast/text/synthetic-bold-transformed.html: Added.
4:58 PM Changeset in webkit [107011] by Lucas Forschler
  • 1 copy in tags/Safari-534.54.14

New tag.

4:55 PM Changeset in webkit [107010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add missing initialization of editable variable.
​https://bugs.webkit.org/show_bug.cgi?id=77948

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2012-02-07
Reviewed by Eric Seidel.

The value of editable in Ewk_Frame_Smart_Data struct is not set.

  • ewk/ewk_frame.cpp:

(ewk_frame_editable_set):

4:52 PM Changeset in webkit [107009] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Update LayoutUnit usage in ColumnInfo and RenderFrameSet
​https://bugs.webkit.org/show_bug.cgi?id=77914

Reviewed by Eric Seidel.

Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.

No new tests. No changed behavior.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):

4:40 PM Changeset in webkit [107008] by adamk@chromium.org
  • 17 edits in trunk

Add JSC support for delivering mutations when the outermost script context exits
​https://bugs.webkit.org/show_bug.cgi?id=70289

Reviewed by Eric Seidel.

Source/WebCore:

The meat of this change is in JSMainThreadExecState, where a counter
is incremented every time WebCore calls into JSC and decremented every
time it returns. When the counter reaches zero, any pending mutations
are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope).

The rest of the changes are of two sorts: compilation/logic fixes for
JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional
usages of JSMainThreadExecState so as to trigger the above
increment/decrements at the appropriate times.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add support
for tryGetProperty with a HashMap<AtomicString>.

  • bindings/js/JSDictionary.h:
  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::JSMainThreadExecState::didLeaveScriptContext):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::JSMainThreadExecState):
Increment a static recursion level counter.
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
Decrement a static recursion level counter and, if we are
at zero (the outermost script invocation), deliver any
outstanding mutation records.

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):
Fix JSDictionary logic, add support for attributeFilter.

Tools:

  • DumpRenderTree/mac/EventSendingController.mm: Add support for

eventSender.scheduleAsynchronousKeyDown.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):

  • Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.

LayoutTests:

With the various fixes in this change, 8/10 tests in fast/mutation
pass under WebKit/Mac. Of the failing tests, only one is due to
a deficiency in the Mac port's code (end-of-task-delivery.html);
the other is due to lack of support for a feature (FILE_SYSTEM)
exercised by the test (non-event-delivery.html).

  • fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available.
  • fast/mutation/observe-attributes.html: Fixed calls to removeEventListener.
  • fast/mutation/observe-characterdata.html: ditto.
4:26 PM Changeset in webkit [107007] by Lucas Forschler
  • 4 edits
    7 copies in branches/safari-534.54-branch

Merged r106982.

4:17 PM Changeset in webkit [107006] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollableAreaBoundingBox):

4:14 PM Changeset in webkit [107005] by leviw@chromium.org
  • 3 edits
    3 adds in trunk

[SVG] Use element disappears after scripted change
​https://bugs.webkit.org/show_bug.cgi?id=74392

Reviewed by Eric Seidel.

Source/WebCore:

Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.

Test: svg/custom/use-disappears-after-style-update.svg

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::didRecalcStyle):

LayoutTests:

  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • svg/custom/use-disappears-after-style-update.svg: Added.
4:00 PM Changeset in webkit [107004] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
​https://bugs.webkit.org/show_bug.cgi?id=77973

Reviewed by Adam Barth.

This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

3:58 PM Changeset in webkit [107003] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merge patch for 78045.

3:53 PM Changeset in webkit [107002] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

media/audio-data-url.html test broken on Lion
​https://bugs.webkit.org/show_bug.cgi?id=69779

Reviewed by Eric Carlson.

Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovie):

3:47 PM Changeset in webkit [107001] by andersca@apple.com
  • 13 edits in trunk/Source/WebCore

Scrolling tree should keep track of region we can't do fast scrolling for
​https://bugs.webkit.org/show_bug.cgi?id=78050

Reviewed by Dan Bernstein.

We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.

  • platform/ScrollableArea.h:

Add scrollableAreaBoundingBox member function.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.

3:46 PM Changeset in webkit [107000] by leviw@chromium.org
  • 5 edits
    6 adds in trunk

unicode-bidi:plaintext is supposed to be effective on display:inline elements too
​https://bugs.webkit.org/show_bug.cgi?id=73310

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.

Tests: fast/text/international/inline-plaintext-is-isolated-expected.html

fast/text/international/inline-plaintext-is-isolated.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
fast/text/international/inline-plaintext-with-generated-content-expected.html
fast/text/international/inline-plaintext-with-generated-content.html

  • platform/text/UnicodeBidi.h:

(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.

  • rendering/InlineIterator.h:

(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.

LayoutTests:

Ref tests for unicode-bidi: plaintext on inlines.

  • fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
  • fast/text/international/inline-plaintext-is-isolated.html: Added.
  • fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
  • fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
  • fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
  • fast/text/international/inline-plaintext-with-generated-content.html: Added.
3:43 PM Changeset in webkit [106999] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash on ​http://www.rickshawbags.com/
​https://bugs.webkit.org/show_bug.cgi?id=78045

Reviewed by Darin Adler.

Problem URL is: ​http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()

This is a bug introduced by ​https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.

  • runtime/JSType.h:
    • sort JSType enum such that StaticScopeObjectType comes before VariableObjectType, and thus is excluded from isVariableObject() checks.
3:38 PM Changeset in webkit [106998] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=77957

Reviewed by Adam Barth.

This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):

3:29 PM Changeset in webkit [106997] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Crash when using per-tile painting on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=75715

Patch by David Reveman <​reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.

Tested with manual tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

3:12 PM Changeset in webkit [106996] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.

  • platform/mac/PlatformClockCM.mm:
3:07 PM Changeset in webkit [106995] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r106982.

  • platform/chromium/test_expectations.txt:

We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.

3:03 PM Changeset in webkit [106994] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unit test for bug #77996
​https://bugs.webkit.org/show_bug.cgi?id=78019

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):

2:52 PM Changeset in webkit [106993] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/WebKit

[BlackBerry] Upstream DumpRenderTreeSupport
​https://bugs.webkit.org/show_bug.cgi?id=77991

Patch by Rob Buis <​rbuis@rim.com> on 2012-02-07
Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

  • blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.

(toGeolocationClientMock):
(DumpRenderTreeSupport::DumpRenderTreeSupport):
(DumpRenderTreeSupport::~DumpRenderTreeSupport):
(DumpRenderTreeSupport::javaScriptObjectsCount):
(DumpRenderTreeSupport::garbageCollectorCollect):
(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
(DumpRenderTreeSupport::linksIncludedInFocusChain):
(DumpRenderTreeSupport::dumpConfigurationForViewport):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

  • blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.

(WebKit):
(WebCore):
(WTF):
(DumpRenderTreeSupport):

2:20 PM Changeset in webkit [106992] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
​https://bugs.webkit.org/show_bug.cgi?id=77923

Reviewed by Kenneth Russell.

Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
error checking in case the TextureManager cannot successfully reserve memory for the texture.

Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
continues and that we don't create a new set of textures for each plane on each frame.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::reserveTextures):

2:18 PM Changeset in webkit [106991] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

IndexedDB createIndex should fail if options arg is invalid
​https://bugs.webkit.org/show_bug.cgi?id=58467

Patch by Eugene Girard <​girard@chromium.org> on 2012-02-07
Reviewed by Tony Chang.

This ticket was fixed as part of ​https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/resources/index-basics.js:

(deleteExisting):

2:08 PM Changeset in webkit [106990] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark those 2 tests as crashing in Debug as they seem
to be hitting an ASSERT.

2:02 PM Changeset in webkit [106989] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, paint the bots green.

  • platform/qt/Skipped: Skip failing/crashing tests, because we like regressions in trunk.
1:52 PM Changeset in webkit [106988] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=77912
Removing old CG shadow code.

A CG-specific shadow offset hack was added in ​http://trac.webkit.org/changeset/34317
for this particular setShadow method. However, this shadow offset adjustment for CG
has since moved down into platform specific code. Thus, this offset adjustment here
is now redundant.

The CG-only shadow setting code block in this setShadow method is now redundant.
Since it sets the shadow values to the CGContext directly - and not to the State object -
it will be overwritten later by any subsequent calls to setting shadow values such as
blur, offset, or shadow color.

Reviewed by Simon Fraser.

No new tests. Current canvas tests cover this path.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadow):

1:52 PM Changeset in webkit [106987] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Process Scroll-gesture events from the compositor.
​https://bugs.webkit.org/show_bug.cgi?id=77477

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-02-07
Reviewed by James Robinson.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

1:50 PM Changeset in webkit [106986] by jamesr@google.com
  • 6 edits in trunk/Source/WebCore

[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
​https://bugs.webkit.org/show_bug.cgi?id=78013

Reviewed by Kenneth Russell.

If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
some early outs.

Tested manually by forcing the first makeContextCurrent() call fail.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

1:48 PM Changeset in webkit [106985] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Keep a reference in didReceiveInvalidMessage.
​https://bugs.webkit.org/show_bug.cgi?id=78024

Reviewed by Anders Carlsson.

  • UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
1:46 PM Changeset in webkit [106984] by crogers@google.com
  • 2 edits in trunk/Tools

Add Chris Rogers to reviewers section
​https://bugs.webkit.org/show_bug.cgi?id=78016

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers.py:
1:37 PM Changeset in webkit [106983] by Nikolas Zimmermann
  • 2 edits in trunk/Tools

layoutTestController.display() is flaky for SVG tests
​https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Dan Bernstein.

Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):
(runTest):

1:37 PM Changeset in webkit [106982] by beidson@apple.com
  • 4 edits
    7 adds in trunk

<rdar://problem/9567286> and ​https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html

Associate the credential with the URL of the challenge itself, not the original request:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

LayoutTests:

  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.
1:24 PM Changeset in webkit [106981] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Revert r106958.

  • platform/chromium/test_expectations.txt:

It was a mistake as the test is really flaky not slow,
so now it is taking way longer to fail (see ​http://webkit.org/b/77997).

1:22 PM Changeset in webkit [106980] by tony@chromium.org
  • 6 edits in trunk/Source/WebCore

move warning about css values and render style constants closer to where it applies
​https://bugs.webkit.org/show_bug.cgi?id=78017

Reviewed by Darin Adler.

Move the warning about keeping RenderStyleConstnats.h enums and
CSSValueKeywords.in values in the same order closer to the properties
that the warning applies to. The warning was easy to miss and was
confusing since it doesn't apply to most values.

Also refactor 2 conversion functions to
enumerate the possible values so the order doesn't matter.

No new tests, just refactoring and comment cleanup.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().

  • css/CSSValueKeywords.in:
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:
1:06 PM Changeset in webkit [106979] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore

Various build fixes for branch

12:48 PM Changeset in webkit [106978] by jer.noble@apple.com
  • 5 edits
    1 copy
    1 add in trunk/Source

Use CMClock as a timing source for PlatformClock where available.
​https://bugs.webkit.org/show_bug.cgi?id=77885

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • wtf/Platform.h: Added WTF_USE_COREMEDIA.

Source/WebCore:

No new tests; performance improvement covered by existing test cases.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Clock.cpp:

(Clock::create): Use PlatformClockCM if available.

  • platform/mac/PlatformClockCM.h: Added.

(WebCore::PlatformClockCM::playRate):
(WebCore::PlatformClockCM::isRunning):

  • platform/mac/PlatformClockCM.mm: Added.

(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
(PlatformClockCM::setCurrentTime):
(PlatformClockCM::currentTime):
(PlatformClockCM::setPlayRate):
(PlatformClockCM::start):
(PlatformClockCM::stop):

12:45 PM Changeset in webkit [106977] by andersca@apple.com
  • 21 edits in trunk/Source

ScrollableAreaSet should be moved from Page to FrameView
​https://bugs.webkit.org/show_bug.cgi?id=62762

Reviewed by Beth Dakin.

Source/WebCore:

It makes more sense for the set of scrollable areas to be per frame view instead of per page;
scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.

  • WebCore.exp.in:

Replace the Page member functions with FrameView member functions instead.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
Check if the frame view contains the given layer.

(WebCore::EventHandler::updateMouseEventTargetNode):
Ditto.

  • page/FocusController.cpp:

(WebCore::contentAreaDidShowOrHide):
Add helper function.

(WebCore::FocusController::setContainingWindowIsVisible):
Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
inside all subframe views.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.

(WebCore::FrameView::~FrameView):
Don't remove the scrollable area here.

(WebCore::FrameView::zoomAnimatorTransformChanged):
m_page is gone so use m_frame->page() instead.

(WebCore::FrameView::setAnimatorsAreActive):
Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
this will be done implicitly.

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
to do this for all scrollable areas on the page, but we only need to do it for this frame view.

(WebCore::FrameView::scrollAnimatorEnabled):
Get the page from m_frame since m_page is gone.

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea):
Move these member functions here from Page.

(WebCore::FrameView::addChild):
If we are adding a frame view, add it to the scrollable area set.

(WebCore::FrameView::removeChild):
If we are removing a frame view, remove it from the scrollable area set.

  • page/FrameView.h:

Move the member function declarations and the scrollable area set member variable here from Page.

  • page/Page.cpp:

(WebCore::Page::~Page):
Don't call disconnectPage on the scrollable areas anymore.

  • platform/ScrollView.h:

(ScrollView):
Make addChild and removeChild virtual.

  • platform/ScrollableArea.h:

Remove disconnectFromPage.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::styleChanged):
The frame view now keeps track of the scrollable areas.

  • rendering/RenderLayer.h:

Remove the page member variable and disconnectFromPage.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
The frame view now keeps track of the scrollable areas.

  • rendering/RenderListBox.h:

Remove the page member variable and disconnectFromPage.

Source/WebKit/chromium:

Update for changes to WebCore now that the scrollable area set is kept per frame view.

  • src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):

  • src/ScrollbarGroup.h:

(WebCore):
(ScrollbarGroup):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollbarGroup):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::initialize):
Call FrameView::addScrollableArea instead.

(WebKit::BuiltInPDFView::destroy):
Call FrameView::removeScrollableArea instead.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Remove disconnectFromPage since it no longer exists on ScrollableArea.

12:40 PM Changeset in webkit [106976] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
​https://bugs.webkit.org/show_bug.cgi?id=77993

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-02-07
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h: Added.
  • blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h: Added.
12:28 PM Changeset in webkit [106975] by jchaffraix@webkit.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
  • platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Rebaseline some old entries in test_expectations.

12:16 PM Changeset in webkit [106974] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

createImpulseBuffer uses incorrect length
​https://bugs.webkit.org/show_bug.cgi?id=77665

Patch by Raymond Toy <Raymond Toy> on 2012-02-07
Reviewed by Kenneth Russell.

  • webaudio/resources/audio-testing.js:

(createImpulseBuffer): Fix bug so the buffer has the correct
length.

12:04 PM Changeset in webkit [106973] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

Remove redundant checks in CanvasRenderingContext2D.cpp
​https://bugs.webkit.org/show_bug.cgi?id=78000

Reviewed by Dan Bernstein.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawImage):

12:01 PM Changeset in webkit [106972] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

Crash in ContainerNode functions due to mutation events.
​https://bugs.webkit.org/show_bug.cgi?id=77999

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add RefPtr to protect premature deletion of this due to mutation events.

Tests: fast/dom/remove-body-during-body-replacement.html

fast/dom/remove-body-during-body-replacement2.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):

LayoutTests:

  • fast/dom/remove-body-during-body-replacement-expected.txt: Added.
  • fast/dom/remove-body-during-body-replacement.html: Added.
  • fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
  • fast/dom/remove-body-during-body-replacement2.html: Added.
11:59 AM Changeset in webkit [106971] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
​https://bugs.webkit.org/show_bug.cgi?id=65862

Unreviewed test expectations change. Removed this expectation in r106857
but it's still timing out so restoring it for now.

  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [106970] by eae@chromium.org
  • 6999 edits
    925 copies
    33 adds
    113 deletes in branches/subpixellayout

Merging trunk changes up until 106956 into subpixel branch.

11:46 AM Changeset in webkit [106969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Memory bug during occlusion tracking if Vector::append() needs to reallocate the buffer
​https://bugs.webkit.org/show_bug.cgi?id=77996

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

We're holding onto the last element in the Vector and then calling
append(). If append() reallocates the Vector's buffer, the pointer
is no longer valid.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::enterTargetRenderSurface):

11:37 AM Changeset in webkit [106968] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash due to column style not updated on post block
in splitInlines.
​https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

Test: fast/multicol/span/split-inline-wrong-post-block-crash.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitFlow):

LayoutTests: Crash due to column style not updated on post block
in splitInlines.
​https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

  • fast/multicol/span/split-inline-wrong-post-block-crash-expected.txt: Added.
  • fast/multicol/span/split-inline-wrong-post-block-crash.html: Added.
11:34 AM Changeset in webkit [106967] by jchaffraix@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen

on the bots.

11:30 AM Changeset in webkit [106966] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
​https://bugs.webkit.org/show_bug.cgi?id=77896

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-07
Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
11:26 AM Changeset in webkit [106965] by hans@chromium.org
  • 4 edits in trunk

Chromium: remove WebSpeechInputResult::set
​https://bugs.webkit.org/show_bug.cgi?id=77977

Reviewed by Darin Fisher.

It was renamed to assign() in r106475.

Source/WebKit/chromium:

  • public/WebSpeechInputResult.h:

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(makeRectResult):

11:18 AM Changeset in webkit [106964] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
​https://bugs.webkit.org/show_bug.cgi?id=77922

Address review comments by Alexey Proskuryakov and Mark Rowe.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):

11:18 AM Changeset in webkit [106963] by mikelawther@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

composited mask test for CSS3 calc
​https://bugs.webkit.org/show_bug.cgi?id=76006

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see ​http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/resources/alpha-gradient.png: Added.
  • css3/calc/simple-composited-mask-expected-mismatch.html: Added.
  • css3/calc/simple-composited-mask.html: Added.
11:03 AM Changeset in webkit [106962] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac
​https://bugs.webkit.org/show_bug.cgi?id=75132

Unreviewed, chromium expectations update.
Fixed with ​http://crrev.com/120714.

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-07

  • platform/chromium/test_expectations.txt:
10:57 AM Changeset in webkit [106961] by Carlos Garcia Campos
  • 11 edits
    2 adds in trunk/Source/WebKit2

[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=76998

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add WebKitEditingCommands.h.
  • UIProcess/API/gtk/WebKitEditingCommands.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(didValidateCommand): Callback called by the C API when an editor
command has been validated.
(webkit_web_view_can_execute_editing_command): Asynchronously
validate the given editing command.
(webkit_web_view_can_execute_editing_command_finish): Finish async
operation started by webkit_web_view_can_execute_editing_command().
(webkit_web_view_execute_editing_command): Execute the given
command.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
loop on load failure, now finished is always called.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest

instead of LoadTrackingTest.

  • UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.

(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(loadChanged):
(WebViewTest::waitUntilLoadFinished): Run a main loop until load
finished.

  • UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
  • UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.
10:55 AM WebKitGTK/1.6.x edited by Martin Robinson
(diff)
10:54 AM Changeset in webkit [106960] by rniwa@webkit.org
  • 2 edits in trunk

Dashboard on perf-o-matic should be sorted
​https://bugs.webkit.org/show_bug.cgi?id=77924

Reviewed by Tony Chang.

Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.

  • Websites/webkit-perf.appspot.com/js/config.js:

(fetchDashboardManifest):

10:49 AM Changeset in webkit [106959] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.
[Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD
​https://bugs.webkit.org/show_bug.cgi?id=77412

Fixed with ​http://crrev.com/120714.

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-07

  • platform/chromium/test_expectations.txt:
9:45 AM Changeset in webkit [106958] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark an SVG test as SLOW.

9:38 AM Changeset in webkit [106957] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
​https://bugs.webkit.org/show_bug.cgi?id=77919

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-07
Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-02-07
Reviewed by Yury Semikhatsky.

Array validator method runtimeCast is added, internal backing method
is moved from .cpp to .h (it's template anyway), boolean validator is
supported.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params):
(TypeBuilder):

9:34 AM Changeset in webkit [106956] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
​https://bugs.webkit.org/show_bug.cgi?id=77922

Reviewed by Chris Marrin.

Follow Chrome's lead to allow WebGL antialiasing
on ATI cards as long as we're on 10.7.2 and above.

No new tests. Covered by existing tests.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):

9:21 AM Changeset in webkit [106955] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test media/controls-drag-timebar.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=77531

No more flakiness.

Patch by Ami Fischman <​fischman@chromium.org> on 2012-02-07
Reviewed by Eric Carlson.

  • platform/chromium/test_expectations.txt:
9:19 AM Changeset in webkit [106954] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests, because we like regressions in trunk.
9:00 AM Changeset in webkit [106953] by pfeldman@chromium.org
  • 20 edits
    12 adds in trunk

Web Inspector: add generic support for undo-ing DOM edits.
​https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html

inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(InspectorDOMAgent::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::perform):
(WebCore::InspectorDOMAgent::DOMAction::undo):
(WebCore):
(InspectorDOMAgent::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::perform):
(WebCore::InspectorDOMAgent::RemoveChildAction::undo):
(InspectorDOMAgent::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::perform):
(WebCore::InspectorDOMAgent::InsertBeforeAction::undo):
(InspectorDOMAgent::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::perform):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::undo):
(InspectorDOMAgent::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::perform):
(WebCore::InspectorDOMAgent::SetAttributeAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::perform):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::newNode):
(InspectorDOMAgent::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::perform):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::undo):
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore::InspectorDOMAgent::markUndoableState):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):

  • inspector/InspectorHistory.cpp: Added.

(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):

  • inspector/InspectorHistory.h: Added.

(WebCore):
(InspectorHistory):
(Action):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt: Added.
  • inspector/elements/undo-dom-edits-2.html: Added.
  • inspector/elements/undo-dom-edits-expected.txt: Added.
  • inspector/elements/undo-dom-edits.html: Added.
  • inspector/styles/undo-add-property-expected.txt: Added.
  • inspector/styles/undo-add-property.html: Added.
  • inspector/styles/undo-change-property-expected.txt: Added.
  • inspector/styles/undo-change-property.html: Added.
  • inspector/styles/undo-property-toggle-expected.txt: Added.
  • inspector/styles/undo-property-toggle.html: Added.
8:55 AM Changeset in webkit [106952] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, more svg rebaselines following change in r106918.

  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
8:43 AM Changeset in webkit [106951] by tonyg@chromium.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r106935.
​http://trac.webkit.org/changeset/106935
​https://bugs.webkit.org/show_bug.cgi?id=77994

"Crashes runMultiThread webkit_unit_test" (Requested by tonyg-
cr on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

8:28 AM Changeset in webkit [106950] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
​https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Skip one more test because of this bug.
8:18 AM Changeset in webkit [106949] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Encode radius, force and rotationAngle in WebPlatformTouchPoint.
​https://bugs.webkit.org/show_bug.cgi?id=77986

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::radius):
(WebKit::WebPlatformTouchPoint::rotationAngle):
(WebKit::WebPlatformTouchPoint::force):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

8:16 AM Changeset in webkit [106948] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening after r106898. Update platform specific expected results

Patch by Ádám Kallai <​Kallai.Adam@stud.u-szeged.hu> on 2012-02-07

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
8:13 AM Changeset in webkit [106947] by commit-queue@webkit.org
  • 20 edits
    12 deletes in trunk

Unreviewed, rolling out r106932.
​http://trac.webkit.org/changeset/106932
​https://bugs.webkit.org/show_bug.cgi?id=77988

Breaks Mac bots (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorHistory.cpp: Removed.
  • inspector/InspectorHistory.h: Removed.
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheetForInlineStyle::text):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):

  • inspector/elements/undo-dom-edits-2-expected.txt: Removed.
  • inspector/elements/undo-dom-edits-2.html: Removed.
  • inspector/elements/undo-dom-edits-expected.txt: Removed.
  • inspector/elements/undo-dom-edits.html: Removed.
  • inspector/styles/undo-add-property-expected.txt: Removed.
  • inspector/styles/undo-add-property.html: Removed.
  • inspector/styles/undo-change-property-expected.txt: Removed.
  • inspector/styles/undo-change-property.html: Removed.
  • inspector/styles/undo-property-toggle-expected.txt: Removed.
  • inspector/styles/undo-property-toggle.html: Removed.
8:09 AM Changeset in webkit [106946] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Qt] Give emulated touch-point a radius
​https://bugs.webkit.org/show_bug.cgi?id=77985

Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/qml/MockTouchPoint.qml:
8:00 AM Changeset in webkit [106945] by commit-queue@webkit.org
  • 2 edits in trunk

Update .gitignore for Qt Creator/KDevelop.
​https://bugs.webkit.org/show_bug.cgi?id=77984

Patch by Frederik Gladhorn <​frederik.gladhorn@nokia.com> on 2012-02-07
Reviewed by Simon Hausmann.

  • .gitignore: Ignore temp files created by Qt Creator and KDevelop.
7:55 AM Changeset in webkit [106944] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Broken "HTML5 <scoped style>" detection
​https://bugs.webkit.org/show_bug.cgi?id=77979

Patch by Priit Laes <​plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Fix wrong variable for HTML5 <style scoped> detection
7:54 AM Changeset in webkit [106943] by tonyg@chromium.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Unreviewed, a couple more chromium rebaselines after r106918.

  • platform/chromium-mac-leopard/svg/hixie/perf/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
7:51 AM Changeset in webkit [106942] by tonyg@chromium.org
  • 4 edits
    3 moves
    11 adds
    10 deletes in trunk/LayoutTests

Unreviewed, more chromium rebaselines as a result of change in r106918.

  • platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/chromium-mac-leopard/svg/filters/filter-width-update-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/perf/005-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/perf/007-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-width-update-expected.png: Removed.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
7:46 AM Changeset in webkit [106941] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Build failure with --enable-web-audio
​https://bugs.webkit.org/show_bug.cgi?id=77978

Patch by Priit Laes <​plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.list.am: Include AudioSourceProviderClient.h
7:46 AM Changeset in webkit [106940] by tonyg@chromium.org
  • 25 edits
    2 copies
    6 moves
    15 adds
    5 deletes in trunk/LayoutTests

Unreviewed chromium rebaseline to account for change in r106918.

  • platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/chromium-linux/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/carto.net/window-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt:
  • platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png.
  • platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/chromium-win/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
7:33 AM Changeset in webkit [106939] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WK2] Fix the debug build after r106920

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Remove unnecessary assert.

7:29 AM Changeset in webkit [106938] by Csaba Osztrogonác
  • 34 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Update platform specific expected files after r106918.

  • platform/qt/Skipped: Unskip non-existing tests.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.txt:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.txt:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.txt:
  • platform/qt/svg/hixie/perf/005-expected.png:
  • platform/qt/svg/hixie/perf/005-expected.txt:
  • platform/qt/svg/hixie/perf/006-expected.png:
  • platform/qt/svg/hixie/perf/006-expected.txt:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
7:27 AM Changeset in webkit [106937] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix objects duplication when switching filter in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=77974

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-02-07
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):

7:22 AM Changeset in webkit [106936] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include gdk-pixbuf in the jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=77980

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
7:16 AM Changeset in webkit [106935] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[chromium] Add setNeedsRedraw to WebWidget
​https://bugs.webkit.org/show_bug.cgi?id=77555

Patch by Jonathan Backer <​backer@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

6:58 AM BuildingGtk edited by kov@webkit.org
Add libtiff4-dev as a dependency (diff)
6:52 AM Changeset in webkit [106934] by tonyg@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.
6:32 AM Changeset in webkit [106933] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

No new tests. (build fix)

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath):

6:00 AM Changeset in webkit [106932] by pfeldman@chromium.org
  • 20 edits
    12 adds in trunk

Web Inspector: add generic support for undo-ing DOM edits.
​https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html

inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore):
(WebCore::InspectorDOMAgent::markUndoableState):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):

  • inspector/InspectorHistory.cpp: Added.

(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):

  • inspector/InspectorHistory.h: Added.

(WebCore):
(InspectorHistory):
(Action):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt: Added.
  • inspector/elements/undo-dom-edits-2.html: Added.
  • inspector/elements/undo-dom-edits-expected.txt: Added.
  • inspector/elements/undo-dom-edits.html: Added.
  • inspector/styles/undo-add-property-expected.txt: Added.
  • inspector/styles/undo-add-property.html: Added.
  • inspector/styles/undo-change-property-expected.txt: Added.
  • inspector/styles/undo-change-property.html: Added.
  • inspector/styles/undo-property-toggle-expected.txt: Added.
  • inspector/styles/undo-property-toggle.html: Added.
5:41 AM Changeset in webkit [106931] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
​https://bugs.webkit.org/show_bug.cgi?id=77926

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2012-02-07
Reviewed by Rob Buis.

  1. rename clientIsOk to isClientAvailable.
  2. m_isRunning is only for an ASSERT in NetWorkManager, So move out from

release build but keep available in debug build.

No changes in behavior, so no new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyDataSent):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):
(WebCore::NetworkJob::isClientAvailable):

5:09 AM Changeset in webkit [106930] by abecsi@webkit.org
  • 9 edits in trunk/Source/WebKit2

[Qt][WK2] Add the componentComplete method to WebView
​https://bugs.webkit.org/show_bug.cgi?id=77111

Reviewed by Simon Hausmann.

Move the initialization of the interaction engine to componentComplete
in preparation of switching to a Flickable based content positioning
for the touch based WebView.
Suspend the page and delay the dispatch of load success on startup until
the component finished initialization. With this patch instantiating the
WebView in C++ is only possible by creating a QDeclarativeComponent as
the initialization depends on the componentComplete method being called.
Also return valid default values in the viewport info functions if the
interaction engine is not yet initialized because the viewport info
component could finish initialization earlier than the WebView, which
results in QML warnings during MiniBrowser startup.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::dispatchLoadSucceeded):

4:55 AM Changeset in webkit [106929] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

  • DEPS:
4:52 AM Changeset in webkit [106928] by yurys@chromium.org
  • 4 edits in trunk

Web Inspector: don't mark object is queriable if it is only reachable by internal reference
​https://bugs.webkit.org/show_bug.cgi?id=77877

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot.html:
4:44 AM Changeset in webkit [106927] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] New svg/hittest tests introduced in r106882 fail
​https://bugs.webkit.org/show_bug.cgi?id=77964

Patch by Ádám Kallai <​Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip failing tests until fix.
4:43 AM Changeset in webkit [106926] by loislo@chromium.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r106909.
​http://trac.webkit.org/changeset/106909
​https://bugs.webkit.org/show_bug.cgi?id=77965

~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

4:29 AM Changeset in webkit [106925] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
<​http://webkit.org/b/77952>

Reviewed by Andreas Kling.
Patch by Ryosuke Niwa.

The performance regression was caused by using ensureAttributeData() which forces the
regeneration of invalidated attributes ("style" and SVG animatable attributes.)
Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
of ElementAttributeData, not the validity of its contents. Use that when grabbing
at an element's inline and attribute styles.

  • dom/Element.h:

(Element):
(WebCore::Element::ensureAttributeDataWithoutUpdate):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::ensureAttributeStyle):

4:23 AM Changeset in webkit [106924] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

No new tests. (build fix).

  • platform/qt/FileSystemQt.cpp:
4:12 AM Changeset in webkit [106923] by Philippe Normand
  • 16 edits in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r106918.

  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/gtk/svg/carto.net/tabgroup-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
3:50 AM Changeset in webkit [106922] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Unreviewed, rolling out r106915.
​http://trac.webkit.org/changeset/106915
​https://bugs.webkit.org/show_bug.cgi?id=77961

because 106912 was rolled out (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
3:45 AM Changeset in webkit [106921] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add ModuleEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=63608

Patch by YoungTaeck Song <​youngtaeck.song@samsung.com> on 2012-02-07
Reviewed by Andreas Kling.

Add first version of ModuleEfl.cpp including load(), unload() and platformFunctionPointer().

  • Platform/Module.h:
  • Platform/efl/ModuleEfl.cpp: Added.

(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):

3:42 AM Changeset in webkit [106920] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests. (Not applicable)

Added OS-specific implementation for retrieving the free disk space.

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath):
(WebCore):

Source/WebKit2:

First part of the implementation. The next steps are the implementation
of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::physicalMemorySizeInBytes):
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

3:19 AM Changeset in webkit [106919] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Prevent early test termination with newer Qt 5
​https://bugs.webkit.org/show_bug.cgi?id=77945

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

QTBUG-24120 tracks a regression in Qt that would make layout tests
terminate early. This patch works around it in a Qt 4 + 5 safe manner
by disabling the quitOnLastWindowClosed feature, which we don't want/need
for DRT anyway.

  • DumpRenderTree/qt/main.cpp:

(main): Don't quit on last window closed.

3:19 AM Changeset in webkit [106918] by Nikolas Zimmermann
  • 181 edits
    1 copy
    2 adds in trunk/LayoutTests

Rewrite SVG tests to make extensive use of display() in repaint tests
​https://bugs.webkit.org/show_bug.cgi?id=77736

Reviewed by Andreas Kling.

Convert all tests in svg/ (except svg/custom & svg/dynamic-updates) that exercise repainting to use the
fast/repaint/resources/repaint.js harness, which forces a layout, and calls layoutTestController.display()
before executing the actual repaint test, so that repaint rectangles are properly tracked and shown (white
areas that are redrawn, on top of the gray background, painted over the web view after the initial painting).

Previously SVG tests used to work like this: (using an HTML example, but it doesn't matter)
<html><body><svg><rect/><script>function change() { rect.setAttribute(...); layoutTestController.notifyDone(); } setTimeout(change, 0); </script></svg></body></html>

We expected that the initial painting was done, before change() as called. This is unreliable for various reasons:

  • the timeout is not guaranteed to fire after the document loaded, it may happen inbetween on eg. a slow connection.
  • nor is it guaranteed that the document has painted initially before we enter change(). This leads to the current regressions -- if we break repainting, we can't see it in the current layout tests, as the initial painting always happens after change() executed in trunk, at least on a fast machine.

In order to make repaint testing reliable we have to use following scheme:
<html><body onload="runRepaintTest()"><svg><rect/><script>function repaintTest() { rect.setAttribute(...); }</script></svg></body></html>

runRepaintTest() is provided by the repaint.js harness and does:
if (window.layoutTestController) {

document.body.offsetTop;
layoutTestController.display();
repaintTest();

} else {

setTimeout(repaintTest, 100);

}

Using this harness outside of DRT allows to test SVG repainting tests in the browser as well, as the repainting changes
aren't immediately fired (0ms timer) but instead delayed by 100ms, so a visual "flash" is visible, if something changes.
For DRT it does two things. First it forces Document::updateLayout() to be called, and then forces the web view to paint
immediately, and then it starts tracking any repaint rects, that are fired _after_ the initial painting, which are then
highlighted in the pixel test dump later on. Using display() is the only way to get reliable painting results across
DRT/WebKitTestRunner, and to get rid of the flakiness.

All *.xml/*.html/*.htm/*.xhtml tests which excersise repainting can be moved to use runRepaintTest() from repaint.js.
<body> needs to be changed to <body onload="runRepaintTest()">, and the timeouts & waitUntilDone/notifyDone calls can
be removed from the tests, leading to much nicer testcases, removing lots of boilerplate.

Pure *.svg tests unfortunately can't use <svg onload="runRepaintTest()"> at the moment, due timing differences between
the HTML load and the SVGLoad event, that's out of scope for this bug report. To remove any hacks from the testcases
themselves, I centralized following work-around in a new function in repaint.js, and let all *.svg tests use it.

function runSVGRepaintTest() {

if (window.layoutTestController) {

layoutTestController.waitUntilDone();
setTimeout(runRepaintTest, 0);

} else

runRepaintTest();

}

runRepaintTest() has to be called from a timer at the moment, as the SVGLoad event fires earlier as HTML load event.
Before that is fixed, we have to use <svg onload="runSVGRepaintTest()"> instead of <svg onload="runRepaintTest()">
and append: layoutTestController.notifyDone() to the repaintTest() functions in the testcases. That should explain
the testcase differences between pure-SVG and non-pure-SVG tests, and why I treated them differently. This approach
is unfortunately as flakey as the old, so to make pure *.svg tests test repainting reliable, the bug needs to be fixed.

Note that svg/custom, and svg/dynamic-updates will be fixed in another chunk, as they also require large amounts
of rebaselines.

  • fast/repaint/resources/repaint.js:

(runRepaintTest):
(runSVGRepaintTest):

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.png:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.txt:
  • platform/mac/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.txt:
  • platform/mac/svg/hixie/perf/004-expected.png:
  • platform/mac/svg/hixie/perf/004-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.png:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.png:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/repaint/image-href-change-expected.png:
  • platform/mac/svg/repaint/image-with-clip-path-expected.png:
  • platform/mac/svg/text/append-text-node-to-tspan-expected.png:
  • platform/mac/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/mac/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/mac/svg/text/remove-tspan-from-text-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • svg/as-background-image/animated-svg-as-background.html:
  • svg/as-background-image/resources/animated-rect-relative-size.svg:
  • svg/as-background-image/svg-as-background-5.html:
  • svg/as-background-image/svg-background-partial-redraw.html:
  • svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
  • svg/as-image/animated-svg-as-image-same-image.html:
  • svg/as-image/animated-svg-as-image.html:
  • svg/as-image/resources/animated-rect-fixed-size-2.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-same-image.svg.
  • svg/as-image/resources/animated-rect-fixed-size.svg:
  • svg/as-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-same-image.svg:
  • svg/as-image/svg-image-change-content-size.xhtml:
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
  • svg/as-object/embedded-svg-size-changes.html:
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
  • svg/as-object/nested-embedded-svg-size-changes.html:
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
  • svg/carto.net/tabgroup.svg:
  • svg/carto.net/window.svg:
  • svg/css/shadow-changes.svg:
  • svg/dom/SVGPathSegList-segment-modification.svg:
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
  • svg/dom/SVGRectElement/rect-modify-rx.svg:
  • svg/filters/animate-fill-expected.png:
  • svg/filters/animate-fill.svg:
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-invalidation.svg:
  • svg/filters/feImage-target-add-to-document-expected.png:
  • svg/filters/feImage-target-add-to-document.svg:
  • svg/filters/feImage-target-changes-id-expected.png:
  • svg/filters/feImage-target-changes-id.svg:
  • svg/filters/feImage-target-id-change-expected.png:
  • svg/filters/feImage-target-id-change.svg:
  • svg/filters/feImage-target-reappend-to-document-expected.png:
  • svg/filters/feImage-target-reappend-to-document.svg:
  • svg/filters/feImage-target-remove-from-document-expected.png:
  • svg/filters/feImage-target-remove-from-document.svg:
  • svg/filters/filter-refresh.svg:
  • svg/filters/filter-width-update.svg:
  • svg/filters/invalidate-on-child-layout.svg:
  • svg/hixie/perf/001.xml:
  • svg/hixie/perf/002.xml:
  • svg/hixie/perf/003.xml:
  • svg/hixie/perf/004.xml:
  • svg/hixie/perf/005.xml:
  • svg/hixie/perf/006.xml:
  • svg/hixie/perf/007.xml:
  • svg/hixie/perf/resources/smallcats.gif: Added.
  • svg/repaint/container-repaint-expected.png:
  • svg/repaint/container-repaint.svg:
  • svg/repaint/filter-child-repaint.svg:
  • svg/repaint/image-href-change.svg:
  • svg/repaint/image-with-clip-path.svg:
  • svg/text/append-text-node-to-tspan.html:
  • svg/text/modify-text-node-in-tspan.html:
  • svg/text/remove-text-node-from-tspan.html:
  • svg/text/remove-tspan-from-text.html:
  • svg/text/text-text-05-t.svg:
  • svg/transforms/animated-path-inside-transformed-html.xhtml:
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/page/absolute-sized-document-scrollbars.svg:
  • svg/zoom/page/relative-sized-document-scrollbars.svg:
  • svg/zoom/page/zoom-background-image-tiled.html:
  • svg/zoom/page/zoom-background-images.html:
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/page/zoom-getBoundingClientRect.xhtml:
  • svg/zoom/page/zoom-hixie-mixed-008.xml:
  • svg/zoom/page/zoom-hixie-mixed-009.xml:
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml:
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm:
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html:
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html:
  • svg/zoom/page/zoom-svg-as-image.html:
  • svg/zoom/page/zoom-svg-as-object.html:
  • svg/zoom/page/zoom-svg-as-relative-image.html:
  • svg/zoom/page/zoom-svg-float-border-padding.xml:
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html:
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html:
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled:
  • svg/zoom/page/zoom-zoom-coords.xhtml:
  • svg/zoom/resources/testPageZoom.js:

(repaintTest):

  • svg/zoom/resources/testTextZoom.js:

(repaintTest):

  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/text/absolute-sized-document-scrollbars.svg:
  • svg/zoom/text/relative-sized-document-scrollbars.svg:
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/text/zoom-foreignObject.svg:
  • svg/zoom/text/zoom-hixie-mixed-008.xml:
  • svg/zoom/text/zoom-hixie-mixed-009.xml:
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml:
  • svg/zoom/text/zoom-svg-float-border-padding.xml:
3:10 AM Changeset in webkit [106917] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

[Inspector] Add the Nokia N9 user agent
​https://bugs.webkit.org/show_bug.cgi?id=77949

Reviewed by Simon Hausmann.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

2:29 AM Changeset in webkit [106916] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent& event) references a NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=77953

Reviewed by Andreas Kling.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

2:22 AM Changeset in webkit [106915] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

GTK & QT Rebaseline after r106912.
​https://bugs.webkit.org/show_bug.cgi?id=77942

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-07
Reviewed by David Levin.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
1:51 AM Applications using WebKit edited by renhuan@360.cn
(diff)
1:44 AM Changeset in webkit [106914] by haraken@chromium.org
  • 13 edits
    3 deletes in trunk

Unreviewed, rolling out r106912.
​http://trac.webkit.org/changeset/106912
​https://bugs.webkit.org/show_bug.cgi?id=77947

"AppleWebKit build is broken" (Requested by haraken on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:

(WebCore::DOMURL::create):
(DOMURL):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Removed.
  • page/DOMWindow.cpp:

(WebCore):
(WebCore::DOMWindow::webkitURL):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):
(WebCore::WorkerContext::webkitURL):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
1:28 AM Applications using WebKit edited by wesley
(diff)
12:54 AM Changeset in webkit [106913] by haraken@chromium.org
  • 4 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r106862.
​http://trac.webkit.org/changeset/106862
​https://bugs.webkit.org/show_bug.cgi?id=77510

Mac build fails if we manually remove generated code

  • DerivedSources.make:
  • bindings/scripts/generate-bindings.pl:

(generateEmptyHeaderAndCpp):

  • bindings/scripts/resolve-supplemental.pl:
  • bindings/scripts/update-idl-needs-rebuild.pl: Removed.
12:40 AM Applications using WebKit edited by renhuan@360.cn
(diff)
12:18 AM Changeset in webkit [106912] by commit-queue@webkit.org
  • 13 edits
    1 copy
    2 adds in trunk

Migrate createObjectURL & revokeObjectURL to static (Class) methods.
​https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-07
Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:

fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.

  • html/DOMURL.h:

(DOMURL):
(WebCore::DOMURL::create):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Added.

(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):

  • page/DOMWindow.cpp: Removed object initialization for DOMURL.

(WebCore):

  • page/DOMWindow.h: ditto.

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
12:16 AM Changeset in webkit [106911] by vsevik@chromium.org
  • 4 edits in trunk

http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux
​https://bugs.webkit.org/show_bug.cgi?id=77661

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:09 AM Changeset in webkit [106910] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix build on Mac with '--shadow-dom'.
​https://bugs.webkit.org/show_bug.cgi?id=77940

Reviewed by Hajime Morita.

  • WebCore.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.