Timeline
Feb 11, 2012:
- 11:59 PM Changeset in webkit [107503] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT calls fprintf() instead of dataLog in terminateSpeculativeExecution()
https://bugs.webkit.org/show_bug.cgi?id=78431
Reviewed by Gavin Barraclough.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- 10:32 PM Changeset in webkit [107502] by
-
- 5 edits14 adds in trunk
Add back WTFURL to WebKit
https://bugs.webkit.org/show_bug.cgi?id=77291
Reviewed by Adam Barth.
Source/JavaScriptCore:
WTFURL was removed from WebKit in r86787.
This patch adds the code back to WTF with the following changes:
-Guard the feature with USE(WTFURL).
-Change the typename CHAR to CharacterType to follow recent WebKit conventions.
-Fix some coding style to make check-webkit-style happy.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Platform.h:
- wtf/url/api/ParsedURL.cpp: Added.
(WTF):
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::scheme):
(WTF::ParsedURL::username):
(WTF::ParsedURL::password):
(WTF::ParsedURL::host):
(WTF::ParsedURL::port):
(WTF::ParsedURL::path):
(WTF::ParsedURL::query):
(WTF::ParsedURL::fragment):
(WTF::ParsedURL::segment):
- wtf/url/api/ParsedURL.h: Added.
(WTF):
(ParsedURL):
(WTF::ParsedURL::spec):
- wtf/url/api/URLString.h: Added.
(WTF):
(URLString):
(WTF::URLString::URLString):
(WTF::URLString::string):
- wtf/url/src/RawURLBuffer.h: Added.
(WTF):
(RawURLBuffer):
(WTF::RawURLBuffer::RawURLBuffer):
(WTF::RawURLBuffer::~RawURLBuffer):
(WTF::RawURLBuffer::resize):
- wtf/url/src/URLBuffer.h: Added.
(WTF):
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
- wtf/url/src/URLCharacterTypes.cpp: Added.
(WTF):
():
- wtf/url/src/URLCharacterTypes.h: Added.
(WTF):
(URLCharacterTypes):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isHexChar):
():
(WTF::URLCharacterTypes::isCharOfType):
- wtf/url/src/URLComponent.h: Added.
(WTF):
(URLComponent):
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::fromRange):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonEmpty):
(WTF::URLComponent::isEmptyOrInvalid):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):
- wtf/url/src/URLEscape.cpp: Added.
(WTF):
():
- wtf/url/src/URLEscape.h: Added.
(WTF):
(WTF::appendURLEscapedCharacter):
- wtf/url/src/URLParser.h: Added.
(WTF):
(URLParser):
():
(WTF::URLParser::isPossibleAuthorityTerminator):
(WTF::URLParser::parseAuthority):
(WTF::URLParser::extractScheme):
(WTF::URLParser::parseAfterScheme):
(WTF::URLParser::parseStandardURL):
(WTF::URLParser::parsePath):
(WTF::URLParser::parsePathURL):
(WTF::URLParser::parseMailtoURL):
(WTF::URLParser::parsePort):
(WTF::URLParser::extractFileName):
(WTF::URLParser::extractQueryKeyValue):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::consecutiveSlashes):
(WTF::URLParser::isPortDigit):
(WTF::URLParser::nextAuthorityTerminator):
(WTF::URLParser::parseUserInfo):
(WTF::URLParser::parseServerInfo):
- wtf/url/src/URLQueryCanonicalizer.h: Added.
(WTF):
(URLQueryCanonicalizer):
(WTF::URLQueryCanonicalizer::canonicalize):
(WTF::URLQueryCanonicalizer::isAllASCII):
(WTF::URLQueryCanonicalizer::isRaw8Bit):
(WTF::URLQueryCanonicalizer::appendRaw8BitQueryString):
(WTF::URLQueryCanonicalizer::convertToQueryEncoding):
- wtf/url/src/URLSegments.cpp: Added.
(WTF):
(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):
- wtf/url/src/URLSegments.h: Added.
(WTF):
(URLSegments):
():
(WTF::URLSegments::URLSegments):
Tools:
Add a flag to build-webkit to easily build WebKit with WTFURL.
- Scripts/build-webkit:
- 7:54 PM Changeset in webkit [107501] by
-
- 3 edits in trunk/Source/JavaScriptCore
Old JIT put_by_id profiling counts every put_by_id_transition as taking slow path
https://bugs.webkit.org/show_bug.cgi?id=78430
<rdar://problem/10849469> <rdar://problem/10849684>
Reviewed by Gavin Barraclough.
The old JIT's put_by_id transition caching involves repatching the slow call to
a generated stub. That means that the call is counted as "slow case". So, this
patch inserts code to decrement the slow case count if the stub succeeds.
Looks like a ~1% speed-up on V8.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- 7:38 PM Changeset in webkit [107500] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for Qt.
- wtf/DataLog.h:
- 7:21 PM Changeset in webkit [107499] by
-
- 50 edits3 adds in trunk/Source
It should be possible to send all JSC debug logging to a file
https://bugs.webkit.org/show_bug.cgi?id=78418
Reviewed by Sam Weinig.
Introduced wtf/DataLog, which defines WTF::dataFile, WTF::dataLog,
and WTF::dataLogV. Changed all debugging- and profiling-related printfs
to use WTF::dataLog() or one of its friends. By default, debug logging
goes to stderr, unless you change the setting in wtf/DataLog.cpp.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::vprintfStdoutInstr):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/Opcode.cpp:
(JSC::OpcodeStats::~OpcodeStats):
- bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCommon.h:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::dump):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::dump):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- heap/Heap.cpp:
(JSC::Heap::destroy):
- heap/MarkedBlock.h:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::dumpRegExpTrace):
- runtime/RegExp.cpp:
(JSC::RegExp::matchCompareWithInterpreter):
- runtime/SamplingCounter.cpp:
(JSC::AbstractSamplingCounter::dump):
- runtime/SamplingCounter.h:
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::report):
- tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
- wtf/CMakeLists.txt:
- wtf/DataLog.cpp: Added.
(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLog):
- wtf/DataLog.h: Added.
(WTF):
- wtf/HashTable.cpp:
(WTF::HashTableStats::~HashTableStats):
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
- wtf/text/WTFString.cpp:
(String::show):
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::dumpDisjunction):
Source/WebCore:
No new tests because behavior is unchanged.
- ForwardingHeaders/wtf/DataLog.h: Added.
Source/WTF:
- WTF.pro:
- 6:47 PM Changeset in webkit [107498] by
-
- 29 edits in trunk
Move special proto property to Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=78409
Reviewed by Oliver Hunt.
Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- No need to prohibit functions named proto.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- Add proto accessor to Object.prototype.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):
- Definition of the proto accessor functions.
- runtime/JSGlobalObjectFunctions.h:
- Declaration of the proto accessor functions.
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.
(JSC::JSObject::putDirectAccessor):
- Track on the structure whether an object contains accessors other than one for proto.
(JSC::JSObject::defineOwnProperty):
- No need to prohibit definition of own properties named proto.
- runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
- Remove the special handling for proto.
(JSC::JSValue::get):
- Remove the special handling for proto.
- runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
- Remove the special handling for proto.
- runtime/JSValue.h:
(JSValue):
- Made synthesizePrototype public (this may be needed by the proto getter).
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
- Perform the security check & call prototype() directly.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
- runtime/Structure.h:
(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):
- expose allowsAccessFrom check to JSC.
- bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
- expose allowsAccessFrom check to JSC.
LayoutTests:
- fast/js/Object-getOwnPropertyNames-expected.txt:
- fast/js/cyclic-prototypes-expected.txt:
- fast/js/parser-syntax-check-expected.txt:
- fast/js/preventExtensions-expected.txt:
- fast/js/prototypes-expected.txt:
- Update results
- fast/js/script-tests/Object-getOwnPropertyNames.js:
- proto is now a property of Object Prototype.
- fast/js/script-tests/cyclic-prototypes.js:
- setting an object's prototype to null removes proto setter, future usage won't set prototype.
- fast/js/script-tests/parser-syntax-check.js:
- Allow functions named proto
- fast/js/script-tests/preventExtensions.js:
- Setting proto should not throw.
- fast/js/script-tests/prototypes.js:
- Objects may contained own properties named proto, add new test cases.
- 6:33 PM Changeset in webkit [107497] by
-
- 6 edits1 delete in trunk/Source/WebCore
Get rid of WebCore::URLString
https://bugs.webkit.org/show_bug.cgi?id=78429
Reviewed by Adam Barth.
URLString is unused, remove the class.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.cpp:
- platform/KURL.h:
(KURL):
- platform/URLString.h: Removed.
- 6:26 PM Changeset in webkit [107496] by
-
- 3 edits3 adds in trunk
DFG CFA assumes that a WeakJSConstant's structure is known
https://bugs.webkit.org/show_bug.cgi?id=78428
<rdar://problem/10849492> <rdar://problem/10849621>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
LayoutTests:
Rubber stamped by Gavin Barraclough.
- fast/js/dfg-put-by-id-prototype-check-expected.txt: Added.
- fast/js/dfg-put-by-id-prototype-check.html: Added.
- fast/js/script-tests/dfg-put-by-id-prototype-check.js: Added.
(foo):
(Foo):
- 5:27 PM Changeset in webkit [107495] by
-
- 2 edits in trunk/Source/JavaScriptCore
Qt debug build fix
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): Platforms that don't use clang will allocate
JSFinalObjects in the destuctor subspace, so we should remove this assert so it
doesn't cause crashes.
- 5:24 PM Changeset in webkit [107494] by
-
- 2 edits in trunk/Source/JavaScriptCore
Old 32_64 JIT should assert that its use of map() is consistent with the DFG
OSR exit's expectations
https://bugs.webkit.org/show_bug.cgi?id=78419
<rdar://problem/10817121>
Reviewed by Oliver Hunt.
- jit/JITInlineMethods.h:
(JSC::JIT::map):
- 5:18 PM Changeset in webkit [107493] by
-
- 2 edits in trunk/Source/JavaScriptCore
Reduce the reentrancy limit of the interpreter for the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=78400
Reviewed by Gavin Barraclough.
- interpreter/Interpreter.h: Lowered the maximum reentrancy limit for large thread stacks.
(JSC):
- 4:08 PM Changeset in webkit [107492] by
-
- 3 edits3 adds in trunk
[DFG] Misuse of WeakJSConstants in silentFillGPR code.
https://bugs.webkit.org/show_bug.cgi?id=78423
<rdar://problem/10849353> <rdar://problem/10804043>
Source/JavaScriptCore:
Reviewed by Sam Weinig.
The code was using Node::isConstant(), when it was supposed to use Node::hasConstant().
This patch is a surgical fix; the bigger problem is: why do we have isConstant() and
hasConstant() when hasConstant() is correct and isConstant() is almost always wrong?
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillGPR):
LayoutTests:
Rubber stamped by Sam Weinig.
- fast/js/dfg-weak-js-constant-silent-fill.html: Added.
- fast/js/dfg-weak-js-constant-silent-fill-expected.txt: Added.
- fast/js/script-tests/dfg-weak-js-constant-silent-fill.js: Added.
- 3:58 PM Changeset in webkit [107491] by
-
- 11 edits in trunk/Source/WebCore
Fix the windows build.
Since Windows uses an all-in-one file to compile, the isRespectedPresentationAttribute()
functions all need unique names.
- html/HTMLBodyElement.cpp:
- html/HTMLHRElement.cpp:
- html/HTMLIFrameElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLMarqueeElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLTableCellElement.cpp:
- html/HTMLTablePartElement.cpp:
- mathml/MathMLElement.cpp:
- 3:36 PM Changeset in webkit [107490] by
-
- 5 edits in trunk/Source/WebCore
Overlay scrollbars don't appear when scrolling on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78427
Reviewed by Sam Weinig.
Add a ScrollAnimator::notifyContentAreaScrolled and call it from ScrollAnimator::notifyContentAreaScrolled.
It is then overridden in ScrollAnimatorMac to tickle AppKit so that overlay scrollbars will be shown.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):
(ScrollAnimator):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore):
- 3:10 PM Changeset in webkit [107489] by
-
- 3 edits in trunk/Source/JavaScriptCore
Prepare JavaScriptCore to build with libc++
<rdar://problem/10426673>
https://bugs.webkit.org/show_bug.cgi?id=78424
Reviewed by Anders Carlsson.
- wtf/NullPtr.cpp:
- wtf/NullPtr.h:
libc++ provides std::nullptr emulation, so we don't have to.
- 3:02 PM Changeset in webkit [107488] by
-
- 4 edits in trunk/Source/WebCore
Implement more ScrollElasticityControllerClient member functions
https://bugs.webkit.org/show_bug.cgi?id=78425
<rdar://problem/10710727>
Reviewed by Sam Weinig.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::horizontalScrollElasticity):
(WebCore::ScrollingTreeNode::verticalScrollElasticity):
(WebCore::ScrollingTreeNode::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeNode::hasEnabledVerticalScrollbar):
Add new getters.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Implement ScrollElasticityControllerClient member functions.
- 1:44 PM Changeset in webkit [107487] by
-
- 2 edits in trunk/Source/WebCore
Add size assert for Length
https://bugs.webkit.org/show_bug.cgi?id=78420
Rubber-stamped by Andreas Kling.
Length type is memory critical and must not grow.
- platform/Length.cpp:
(SameSizeAsLength):
(WebCore):
- 1:37 PM Changeset in webkit [107486] by
-
- 3 edits in trunk/Source/WebCore
Pass wheel events to a scroll elasticity controller on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78421
Reviewed by Sam Weinig.
Add a ScrollElasticityController to ScrollingTreeNodeMac and pass wheel events to it.
Fix ScrollingTreeNodeMac::scrollBy to clamp by the minimum and maximum scroll positions.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::ScrollingTreeNodeMac):
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollBy):
- 1:07 PM Changeset in webkit [107485] by
-
- 13 edits3 adds in trunk/Source/JavaScriptCore
DFG should have polymorphic put_by_id caching
https://bugs.webkit.org/show_bug.cgi?id=78062
<rdar://problem/10326439> <rdar://problem/10824839>
Reviewed by Oliver Hunt.
Implemented polymorphic put_by_id caching in the DFG, and added much of the
machinery that would be needed to implement it in the old JIT as well.
I decided against using the old PolymorphicAccessStructureList mechanism as
this didn't quite fit with put_by_id. In particular, I wanted the ability to
have one list that captured all relevant cases (including proto put_by_id
if we ever decided to do it). And I wanted the code to have better
encapsulation. And I didn't want to get confused by the fact that the
original (non-list) put_by_id cache may itself consist of a stub routine.
This code is still sub-optimal (for example adding a replace to a list whose
previous elements are all transitions should just repatch the original code,
but here it will generate a stub) but it already generates a >20% speed-up
on V8-splay, leading to a 2% win overall in splay. Neutral elsewhere.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/PolymorphicPutByIdList.cpp: Added.
(JSC):
(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::from):
(JSC::PolymorphicPutByIdList::~PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::isFull):
(JSC::PolymorphicPutByIdList::isAlmostFull):
(JSC::PolymorphicPutByIdList::addAccess):
(JSC::PolymorphicPutByIdList::visitWeak):
- bytecode/PolymorphicPutByIdList.h: Added.
(JSC):
(PutByIdAccess):
(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::isSet):
(JSC::PutByIdAccess::operator!):
(JSC::PutByIdAccess::type):
(JSC::PutByIdAccess::isTransition):
(JSC::PutByIdAccess::isReplace):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::structure):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):
(JSC::PolymorphicPutByIdList::isEmpty):
(JSC::PolymorphicPutByIdList::size):
(JSC::PolymorphicPutByIdList::at):
(JSC::PolymorphicPutByIdList::operator[]):
(JSC::PolymorphicPutByIdList::kind):
- bytecode/PutKind.h: Added.
(JSC):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
(JSC):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdList):
(StructureStubInfo):
(JSC::StructureStubInfo::reset):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
(DFG):
- dfg/DFGRepatch.cpp:
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(DFG):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgRepatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgBuildPutByIdList):
(JSC::DFG::dfgResetPutByID):
- dfg/DFGRepatch.h:
(DFG):
- runtime/WriteBarrier.h:
(WriteBarrierBase):
(JSC::WriteBarrierBase::copyFrom):
- 11:29 AM Changeset in webkit [107484] by
-
- 67 edits in trunk/Source/WebCore
Attribute styles should be created lazily.
<http://webkit.org/b/78381>
Reviewed by Antti Koivisto.
TL;DR summary: Lazily construct the StyledElement::attributeStyle() instead of
moving properties in/out of it in parseAttribute(). This allows us to enable
the matched declaration cache for elements with presentation attributes.
The matched declaration cache has been disabled for elements with presentation
attributes because attributeStyle() was mutable, and (simply put) the cache maps
a set of StylePropertySet pointers to a resulting RenderStyle. This requires
that the StylePropertySets are immutable.
To make them immutable, we now construct the attribute style lazily by adding
a flag (to Node) that gets set in parseAttribute() when a presentation attribute
respected by the element changes. A subsequent call to attributeStyle() checks
the flag and rebuilds the style by looping over the attributes and calling the
new virtual StyledElement::collectStyleForAttribute() on each one. Any dangling
references to the previous attribute style will be garbage collected by the
cache in CSSStyleSelector::sweepMatchedDeclarationCache().
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
Enable matched declaration cache for elements with attribute style.
- dom/Node.h:
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
Add a Node flag to signify that a presentation attribute has changed and
the attribute style needs to be rebuilt.
- dom/ElementAttributeData.h:
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::setAttributeStyle):
Added a setter for the attribute style, called by updateAttributeStyle().
- dom/StyledElement.cpp:
(WebCore::StyledElement::addHTMLLengthToStyle):
(WebCore::StyledElement::addHTMLColorToStyle):
Moved and renamed two of the old addCSS* helpers from StyledElement.
(WebCore::StyledElement::updateAttributeStyle):
Called by attributeStyle() in case the "attribute style dirty" flag is
set. Rebuilds the attribute style from scratch by looping over the
attribute map and calling collectStyleForAttribute() on each attribute.
- dom/StyledElement.h:
(WebCore::StyledElement::collectStyleForAttribute):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::setNeedsAttributeStyleUpdate):
Helper, sets the attribute style dirty flag and marks the element for
full style recalc. This is what parseAttribute() calls in subclasses
when they encounter a presentation attribute.
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
(WebCore::HTMLBRElement::parseAttribute):
- html/HTMLBRElement.h:
- html/HTMLBodyElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):
- html/HTMLBodyElement.h:
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForAttribute):
(WebCore::HTMLDivElement::parseAttribute):
- html/HTMLDivElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):
- html/HTMLEmbedElement.h:
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
(WebCore::HTMLFontElement::parseAttribute):
- html/HTMLFontElement.h:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::collectStyleForAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):
(WebCore::HTMLHRElement::parseAttribute):
- html/HTMLHRElement.h:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):
- html/HTMLInputElement.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForAttribute):
(WebCore::HTMLLIElement::parseAttribute):
- html/HTMLLIElement.h:
- html/HTMLMarqueeElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):
- html/HTMLMarqueeElement.h:
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForAttribute):
(WebCore::HTMLOListElement::parseAttribute):
- html/HTMLOListElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::collectStyleForAttribute):
(WebCore::HTMLObjectElement::parseAttribute):
- html/HTMLObjectElement.h:
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForAttribute):
(WebCore::HTMLParagraphElement::parseAttribute):
- html/HTMLParagraphElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):
(WebCore::HTMLPlugInElement::parseAttribute):
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::collectStyleForAttribute):
(WebCore::HTMLPreElement::parseAttribute):
- html/HTMLPreElement.h:
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::collectStyleForAttribute):
(WebCore::HTMLTableColElement::parseAttribute):
- html/HTMLTableColElement.h:
- html/HTMLTableElement.cpp:
(WebCore::getBordersFromFrameAttributeValue):
(WebCore::HTMLTableElement::collectStyleForAttribute):
(WebCore::HTMLTableElement::parseAttribute):
- html/HTMLTableElement.h:
- html/HTMLTablePartElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
(WebCore::HTMLTablePartElement::parseAttribute):
- html/HTMLTablePartElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):
- html/HTMLTextAreaElement.h:
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForAttribute):
(WebCore::HTMLUListElement::parseAttribute):
- html/HTMLUListElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectStyleForAttribute):
(WebCore::HTMLVideoElement::parseAttribute):
- html/HTMLVideoElement.h:
- mathml/MathMLElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):
(WebCore::MathMLElement::parseAttribute):
- mathml/MathMLElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForAttribute):
(WebCore::SVGImageElement::parseAttribute):
- svg/SVGImageElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::parseAttribute):
- svg/SVGStyledElement.h:
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
- svg/SVGTextContentElement.h:
Split handling of presentation attributes between parseAttribute() and
collectStyleForAttribute() as appropriate. Some minor refactorings here and
there (mostly in HTMLTableElement) to avoid excessive code duplication.
Also sprinkled FIXMEs about inefficiencies we should clean up.
- 10:51 AM Changeset in webkit [107483] by
-
- 6 edits2 adds in trunk
HTML 5: Support click() method on HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=27880
Patch by Arko Saha <arko@motorola.com> on 2012-02-11
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: fast/dom/click-method-on-html-element.html
- bindings/objc/PublicDOMInterfaces.h: Added click() method in DOMHTMLElement
with availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1.
- html/HTMLButtonElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
- html/HTMLElement.idl: Added click() IDL method.
- html/HTMLInputElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
LayoutTests:
- fast/dom/click-method-on-html-element-expected.txt: Added.
- fast/dom/click-method-on-html-element.html: Added.
- 10:36 AM Changeset in webkit [107482] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] html5test.com says that gstreamer ports do not support WebM for audio
https://bugs.webkit.org/show_bug.cgi?id=78244
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-11
Reviewed by Eric Seidel.
Specifically advertise support for audio/webm when we support the vorbis
audio codec. This is necessary because gstreamer doesn't advertise it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Add an override for audio/webm.
- 10:18 AM Changeset in webkit [107481] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
- 9:46 AM Changeset in webkit [107480] by
-
- 12 edits2 adds in trunk/Source/WebCore
[chromium] Enable CSS filters on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=77266
Reviewed by James Robinson.
Will be covered by existing tests in css3/filters (when enabled).
- WebCore.gypi:
Add CCRenderSurfaceFilters.* to the Chromium build.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setFilters):
- platform/graphics/chromium/GraphicsLayerChromium.h:
Override setFilters() virtual from GraphicsLayer.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Implement setFilters() to cache the filters here...
(WebCore::LayerChromium::pushPropertiesTo):
... and push them to the CCLayerImpl at commit time.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::filters):
Implement accessor.
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setFilters):
Implement stub version of setFilters(), to satisfy the templates.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setFilters):
Implement setter to receive filters at commit time.
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::filters):
Implement member var and accessor for filters.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
Add another clause here to force creation of a RenderSurface when
filters are present, and to forward them from the layer to the
RenderSurface.
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
Check for filters at draw time, apply them, and forward the result
through the drawing traversal.
(WebCore::CCRenderSurface::drawSurface):
If filter bitmap is present, bind it instead of the normal
RenderSurface texture.
(WebCore::CCRenderSurface::applyFilters):
Apply filters to the render surface texture, and return the result.
This function is a no-op for the threaded compositor, due to use
of the SharedGraphicsContext3D.
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setFilters):
(WebCore::CCRenderSurface::filters):
(CCRenderSurface):
Filters getters and setters.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Added.
(WebCore::CCRenderSurfaceFilters::apply):
External interface for this (static) class. All internal
implementation and helper functions are in the unnamed namespace.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Added.
- 8:17 AM Changeset in webkit [107479] by
-
- 3 edits2 adds in trunk
Node.isEqualNode() compares attributes twice.
<http://webkit.org/b/78414>
Reviewed by Anders Carlsson.
Source/WebCore:
A single pass across the attribute maps should be enough for anyone.
Added a test verifying correct behavior of Node.isEqualNode() when comparing
two elements, one of which has had attributes that were all removed,
resulting in an empty but non-null NamedNodeMap hanging off of the element.
Note that this change is not fixing a regression, I'm just adding the test
since I came close to introducing a bug here.
Test: fast/dom/isEqualNode-after-removeAttribute.html
- dom/Node.cpp:
(WebCore::Node::isEqualNode):
LayoutTests:
- fast/dom/isEqualNode-after-removeAttribute-expected.txt: Added.
- fast/dom/isEqualNode-after-removeAttribute.html: Added.
- 6:54 AM Changeset in webkit [107478] by
-
- 6 edits in trunk/Source/WebCore
HTMLTablePartElement: Add helper method to find parent table.
<http://webkit.org/b/78413>
Reviewed by Anders Carlsson.
Add HTMLTablePartElement::findParentTable() and use that in subclasses instead
of duplicating the code.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
(WebCore):
- html/HTMLTablePartElement.h:
(WebCore):
(HTMLTablePartElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
- 6:50 AM Changeset in webkit [107477] by
-
- 22 edits in trunk/Source/WebCore
Use Element's hasName/hasID flags to avoid unnecessary work when looking up name/id attributes.
<http://webkit.org/b/77845>
Reviewed by Anders Carlsson.
Have Element::getIdAttribute() check the hasID() flag before looking up the attribute.
Add an Element::getNameAttribute() to do the same thing with hasName().
Update call sites to make use of these helpers whenever possible.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
- dom/Element.h:
(Element):
(WebCore::Element::getIdAttribute):
(WebCore):
(WebCore::Element::getNameAttribute):
- dom/NameNodeList.cpp:
(WebCore::NameNodeList::nodeMatches):
- dom/StaticHashSetNodeList.cpp:
(WebCore::StaticHashSetNodeList::itemWithName):
- dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::itemWithName):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::name):
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formControlName):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::name):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::name):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::formControlName):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- page/Frame.cpp:
(WebCore::Frame::matchLabelsAgainstElement):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
- 12:56 AM Changeset in webkit [107476] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt/Skipped: Skip tests because ENABLE(MUTATION_OBSERVERS) is disabled.
- 12:33 AM Changeset in webkit [107475] by
-
- 14 edits3 deletes in trunk/Source
Unreviewed, rolling out r107435.
http://trac.webkit.org/changeset/107435
https://bugs.webkit.org/show_bug.cgi?id=78410
It broke the Qt build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-11
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard):
- platform/Pasteboard.h:
(WebCore):
(Pasteboard):
- platform/PasteboardStrategy.h: Removed.
- platform/PlatformPasteboard.h: Removed.
- platform/PlatformStrategies.h:
(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):
- platform/mac/PasteboardMac.mm:
(WebCore):
(WebCore::selectionPasteboardTypes):
(WebCore::writableTypesForURL):
(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeSelection):
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
(WebCore::Pasteboard::documentFragment):
- platform/mac/PlatformPasteboardMac.mm: Removed.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::addVisitedLink):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Feb 10, 2012:
- 11:52 PM Changeset in webkit [107474] by
-
- 3 edits in trunk/Source/WebCore
Move CSSOM wrapper pointer out of StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=78406
Reviewed by Andreas Kling.
Most StylePropertySet instances never have CSSOM wrappers so having a pointer to one in
each and and every object makes no sense.
Move the PropertySetCSSStyleDeclaration instances to a global HashMap. This shrinks
StylePropertySet by a pointer.
Added COMPILE_ASSERT for StylePropertySet size.
- css/StylePropertySet.cpp:
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
- 8:28 PM Changeset in webkit [107473] by
-
- 9 edits in trunk/Source/WebCore
MathML internals - use createXXX() function naming, ASSERT()s
https://bugs.webkit.org/show_bug.cgi?id=78384
Patch by David Barton <Dave Barton> on 2012-02-10
Reviewed by Eric Seidel.
Standard RefPtr function naming uses "createXXX" instead of "makeXXX".
I also added a couple of ASSERT()s.
No new tests.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createBlockStyle):
- rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createOperatorStyle):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::RenderMathMLSubSup):
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):
(WebCore::RenderMathMLUnderOver::addChild):
- 8:00 PM Changeset in webkit [107472] by
-
- 2 edits in trunk/Source/WebCore
Non-threaded scrolling build fix.
- page/FrameView.cpp:
(WebCore::FrameView::requestScrollPositionUpdate):
- 7:58 PM Changeset in webkit [107471] by
-
- 2 edits in trunk/Source/WebKit
BlackBerry Port - Input focus is suppressed during XHR loads
https://bugs.webkit.org/show_bug.cgi?id=78368
Allow JS to trigger the VKB and input focus when XHR scripting
is active.
This switching the loaded state to checking the webpages loaded state
which is only updated after initial load. When additional loading
events happen for XHR, it remains false and focus events function.
Also add detailed FocusLog's to shouldAcceptInputFocus.
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-10
Reviewed by Rob Buis.
- blackberry/WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
- 7:10 PM Changeset in webkit [107470] by
-
- 6 edits in trunk
Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE
https://bugs.webkit.org/show_bug.cgi?id=71293
Patch by Edward O'Connor <Theresa O'Connor> on 2012-02-10
Reviewed by Chris Marrin.
Source/WebCore:
Tests: animations/animation-css-rule-types.html
- css/CSSRule.h: Change WEBKIT_KEYFRAMES_RULE to 7 and
WEBKIT_KEYFRAME_RULE to 8.
- css/CSSRule.idl: Ditto.
LayoutTests:
- animations/animation-css-rule-types-expected.txt:
- animations/script-tests/animation-css-rule-types.js: Update
expected WEBKIT_KEYFRAMES_RULE and WEBKIT_KEYFRAME_RULE values.
- 6:53 PM Changeset in webkit [107469] by
-
- 17 edits8 deletes in trunk/LayoutTests
[chromium] Unreviewed gardening.
svg/text/non-bmp-positioning-lists.svg is missing glyphs. The other
tests are additional fallout from r107417.
- platform/chromium-mac-leopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
- platform/chromium-mac-leopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
- platform/chromium-mac-leopard/svg/carto.net/window-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/chromium-mac-leopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-stop-linked-gradient-expected.png:
- platform/chromium-mac-leopard/svg/custom/mask-invalidation-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/chromium-mac-leopard/svg/custom/text-repaint-including-stroke-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-clipped-hit-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-detach-expected.png:
- platform/chromium-mac-leopard/svg/filters/filter-refresh-expected.txt:
- platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
- platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/filters/animate-fill-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/filters/filter-refresh-expected.txt:
- platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium/test_expectations.txt:
- 6:35 PM Changeset in webkit [107468] by
-
- 2 edits in trunk/Source/WebCore
AtomicMarkupTokenBase::initializeAttributes should not create a StringImpl if it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=78394
Reviewed by Adam Barth.
On the very next line is passes value to Attribute::create which takes
an AtomicString, so this code was just allocating a StringImpl (every time)
only to (much of the time) just release that StringImpl on the next line
when it got the AtomicString instead.
I discovered this while looking at DOM/Events.html, but it's unclear
if this fix actually makes that benchmark faster.
- xml/parser/MarkupTokenBase.h:
(WebCore::::initializeAttributes):
- 6:33 PM Changeset in webkit [107467] by
-
- 12 edits in trunk/Source/WebCore
Always update the scroll position through the scrolling coordinator
https://bugs.webkit.org/show_bug.cgi?id=78403
Reviewed by Sam Weinig.
To get correct behavior, we always want to update the scrolling layer position
on the scrolling thread. Do this by allowing the scrolling coordinator to intercept
scroll position update requests and send them to the scrolling tree.
- page/FrameView.cpp:
(WebCore::FrameView::requestScrollPositionUpdate):
Let the scrolling coordinator have a go at updating the scroll position for this frame view.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
If it's a frame view we're coordinating scrolling for, tell the scrolling tree to update
the scroll position.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::setMainFrameScrollPosition):
Call through to the scrolling tree node.
- page/scrolling/ScrollingTreeNode.h:
Add a new pure virtual setScrollPosition member function.
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Move most of the code from scrollBy here.
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
Rename this member function from setScrollPosition to avoid conflicts.
(WebCore::ScrollingTreeNodeMac::scrollBy):
Just call setScsrollPosition.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Call requestScrollPositionUpdate, which allows subclasses of scrollable area to intercept
the scroll operation and call it asynchronously.
- 6:08 PM LayoutUnit edited by
- Removed duplicate borders entry. (diff)
- 6:03 PM Changeset in webkit [107466] by
-
- 4 edits in trunk/Source/WebCore
ScrollableArea should have a function for noting that the scroll position changed
https://bugs.webkit.org/show_bug.cgi?id=78402
Reviewed by Sam Weinig.
The scrolling coordinator needs a specialized function to call whenever the main frame
scrolling position has changed, so add ScrollableArea::notifyScrollPositionChanged and
call it from the scrolling coordinator.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
New function.
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Call ScrollableArea::notifyScrollPositionChanged.
- 5:41 PM Changeset in webkit [107465] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
Fixing the build by removing a duplicate definition of pixelSnappedIntRect in LayoutTypes.h and
removing conflict markers from the changelog.
- rendering/LayoutTypes.h:
(pixelSnappedIntRect):
- ChangeLog:
- 5:37 PM Changeset in webkit [107464] by
-
- 3 edits in trunk/LayoutTests
CSS3 calc: convert font-size-fractional test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78347
Reviewed by Ojan Vafai.
- css3/calc/font-size-fractional-expected.txt:
- css3/calc/font-size-fractional.html:
- 5:20 PM Changeset in webkit [107463] by
-
- 2 edits in trunk/Source/WebKit/chromium
Disable IndexedDB permissions check from shared workers
https://bugs.webkit.org/show_bug.cgi?id=78316
We want to temporarily bypass this check because it causes a crash
when called from a shared worker. We'll have to fix it before
including idb on shared workers in a release but don't want to stop
developers from testing out idb on shared workers.
No new tests because it affects shared workers only, which aren't
testable by DRT.
Reviewed by Tony Chang.
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):
- 5:03 PM Changeset in webkit [107462] by
-
- 1 edit1 delete in trunk/LayoutTests
[chromium] Unreviewed, remove a linux gpu result that is not needed after r107448.
- platform/chromium-gpu-linux/media/video-empty-source-expected.png: Removed.
- 4:58 PM Changeset in webkit [107461] by
-
- 23 edits in trunk/Source/WebCore
Add pixelSnappedIntRect method
https://bugs.webkit.org/show_bug.cgi?id=78054
Reviewed by Eric Seidel.
This patch introduces a pixelSnappedIntRect method that will snap a sub-pixel LayoutRect to
pixel boundaries. These pixel snapped forms are what is used to communicate with the graphics
engine (to paint at whole pixel boundaries) and the embedding app (so they don't need to
understand we're using sub-pixel units).
No new tests. No change in behavior.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
- dom/Range.cpp:
(WebCore::Range::boundingBox):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
- page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::windowClipRectForLayer):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::selectionGaps):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::calculateRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::paintScrollbar):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::addPDFURLRect):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::paint):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):
- 4:55 PM Changeset in webkit [107460] by
-
- 15 edits in trunk/Source
Source/WebCore: Web Inspector: Add the ability to jump to the source for a given frame
https://bugs.webkit.org/show_bug.cgi?id=78396
Reviewed by Tim Hatcher.
- WebCore.exp.in: Add a new exported function.
- inspector/InspectorController.cpp: Add and expose the InspectorPageAgent.
(WebCore::InspectorController::InspectorController): Set m_pageAgent.
- inspector/InspectorController.h: Add m_pageAgent.
(WebCore::InspectorController::pageAgent): Return m_pageAgent.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::showMainResourceForFrame): Get the inspector's frame ID
of the frame that was passed in, and add a call to evaluate on load.
- inspector/InspectorFrontendClientLocal.h:
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.showMainResourceForFrame): Add a FIXME to show the source code for the main
resource of the given frame.
Source/WebKit2: Web Inspector: Add the ability to jump to the source for a given frame
https://bugs.webkit.org/show_bug.cgi?id=78396
Add WebKit2 API for the ability to show the source of a frame in the web inspector. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showMainResourceForFrame.
Reviewed by Tim Hatcher.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorShowMainResourceForFrame): Call WebInspectorProxy::showMainResourceForFrame.
- UIProcess/API/C/WKInspector.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::showMainResourceForFrame): Send a message to the web process, passing
the frame ID of the frame we want to show the main resource of.
- UIProcess/WebInspectorProxy.h:
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::showMainResourceForFrame): Get the WebFrame for the frame we want to show the
main resource of from its ID. If we found a frame, call InspectorFrontendClientLocal::showMainResourceForFrame.
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in: Add a new message.
- 4:42 PM Changeset in webkit [107459] by
-
- 11 edits in trunk/Source
Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it
Patch by Vineet Chaudhary <Vineet> on 2012-02-10
Reviewed by Timothy Hatcher.
- API/WebKitAvailability.h: Added AVAILABLE_AFTER_WEBKIT_VERSION_5_1 and AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1 for the new versions.
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72756
DOMHTMLElement’s accessKey property is declared as available in WebKit version that didn’t have it.
Patch by Vineet Chaudhary <Vineet> on 2012-02-10
Reviewed by Timothy Hatcher.
No new tests.
- bindings/objc/PublicDOMInterfaces.h: Moving accessKey property to DOMHTMLElement with an appropriate availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1. Also Moving accessKey property to HTMLAnchorElement, HTMLAreaElement, HTMLButtonElement, HTMLInputElement, HTMLLabelElement, HTMLLegendElement and HTMLTextAreaElement idls with an availability macro AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1.
- html/HTMLAnchorElement.idl: Adding accessKey entries back to idls under LANGUAGE_OBJECTIVE_C.
- html/HTMLAreaElement.idl: Ditto.
- html/HTMLButtonElement.idl: Ditto.
- html/HTMLInputElement.idl: Ditto.
- html/HTMLLabelElement.idl: Ditto.
- html/HTMLLegendElement.idl: Ditto.
- html/HTMLTextAreaElement.idl: Ditto.
- 4:36 PM Changeset in webkit [107458] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
- 4:35 PM Changeset in webkit [107457] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/rendering
Switching positionOverflowControls to operate on integers, as these overflow controls are always widgets on integer boundaries.
- 4:32 PM Changeset in webkit [107456] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixing windows build
Unreviewed build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:13 PM Changeset in webkit [107455] by
-
- 2 edits in trunk/LayoutTests
These SVG tests all appear to pass (many due to my updating their
baselines last night).
- platform/chromium/test_expectations.txt:
- 4:06 PM Changeset in webkit [107454] by
-
- 26 edits in trunk
Enable MUTATION_OBSERVERS by default on all platforms
https://bugs.webkit.org/show_bug.cgi?id=78196
Reviewed by Ojan Vafai.
.:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- UseV8.cmake: Add some previously-missing files.
- WebCore.vcproj/WebCore.vcproj: ditto.
- bindings/js/JSBindingsAllInOne.cpp: ditto.
- dom/DOMAllInOne.cpp: ditto.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
- platform/efl/Skipped: Stop skipping the tests except for those known to fail.
- platform/gtk/Skipped: ditto.
- platform/mac/Skipped: ditto.
- platform/qt/Skipped: ditto.
- platform/win/Skipped: ditto.
- platform/wincairo/Skipped: ditto.
- 4:00 PM Changeset in webkit [107453] by
-
- 3 edits1 add in trunk/Source/WebCore
Add FractionalLayoutUnit type for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=77485
Reviewed by Eric Seidel.
Add fixed point implementation (FractionalLayoutUnit).
FractionalLayoutUnit represents values as multiples of 1/60th pixel. This allows us
to represent sub-pixel values using integer math and avoids floating point precision
problems.
No new tests.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h: Added.
- 3:53 PM Changeset in webkit [107452] by
-
- 3 edits in trunk/LayoutTests
Add keyframes to LayoutTests/media/content/test.ogv to hasten test completion & avoid timeouts.
https://bugs.webkit.org/show_bug.cgi?id=78058
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-10
Reviewed by Eric Carlson.
File was created with ffmpeg2theora v0.24, command-line:
ffmpeg2theora --no-upscaling --no-skeleton -e 6.02 -K 21 test.mp4 -o test.ogv
The important bit was the addition of "-K 21" to force keyframe creation.
The other flags are important to minimize breakage of tests that hardcode
expectations like "the first 100k will contain the metadata" etc.
Before this, seeking to 5.6s would use the (only) keyframe at 2.4s and
have to decode all the way forward from there, which would be sometimes
timeout (presumably on overloaded bots).
- media/content/test.ogv:
- platform/chromium/test_expectations.txt:
- 3:53 PM Changeset in webkit [107451] by
-
- 2 edits in trunk/Tools
Move garden-o-matic's All Failures out of experimental
https://bugs.webkit.org/show_bug.cgi?id=78395
Reviewed by Dimitri Glazkov.
Several folks have tried this feature and found it useful.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- 3:49 PM Changeset in webkit [107450] by
-
- 7 edits1 move in trunk
Don't lowercase ping URLs.
Previously, ping URLs would be lowercased when splitting them apart.
URLs are not, however, case-insensitive.
https://bugs.webkit.org/show_bug.cgi?id=78371
Reviewed by Tony Chang.
Source/WebCore:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::sendPings): Don't lowercase URL.
LayoutTests:
- http/tests/navigation/image-load-in-unload-handler.html: update to new URL
- http/tests/navigation/ping-cookie.html:
- http/tests/navigation/ping-cross-origin.html:
- http/tests/navigation/ping-same-origin.html:
- http/tests/navigation/resources/save-Ping.php: Renamed from LayoutTests/http/tests/navigation/resources/save-ping.php.
- 3:41 PM WikiStart edited by
- Added link to LayoutUnit wiki page (diff)
- 3:39 PM LayoutUnit edited by
- (diff)
- 3:38 PM Changeset in webkit [107449] by
-
- 3 edits in trunk/Source/WebKit
BlackBerry Port - JS focus on blur can cause recursion
https://bugs.webkit.org/show_bug.cgi?id=78368
Prevent JS recursion of blur/focus by allowing focus
if we are already trying to prevent focus.
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-10
Reviewed by Rob Buis.
- blackberry/WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):
- blackberry/WebKitSupport/InputHandler.h:
(InputHandler):
- 3:30 PM Changeset in webkit [107448] by
-
- 7 edits9 adds in trunk/LayoutTests
media/video-empty-source.html needs a rebaseline for chromium
https://bugs.webkit.org/show_bug.cgi?id=78233
Unreviewed rebaselining.
Patch by Ami Fischman <fischman@chromium.org> on 2012-02-10
- platform/chromium-linux-x86/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-linux/media/video-empty-source-expected.png:
- platform/chromium-linux/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-mac-leopard/media/video-empty-source-expected.png:
- platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
- platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Added.
- platform/chromium-win-vista/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-win-xp/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
- platform/chromium-win/media/video-empty-source-expected.png:
- platform/chromium-win/media/video-empty-source-expected.txt:
- platform/chromium/test_expectations.txt:
- 3:01 PM Changeset in webkit [107447] by
-
- 2 edits in trunk/Source/JavaScriptCore
ENABLE(ASSEMBLER_WX_EXCLUSIVE): LinkBuffer can leave pages not marked as executable.
https://bugs.webkit.org/show_bug.cgi?id=76724
Patch by Yong Li <yoli@rim.com> on 2012-02-10
Reviewed by Rob Buis.
This issue only exists when both ENABLE(ASSEMBLER_WX_EXCLUSIVE) and ENABLE(BRANCH_COMPACTION) are on.
The size used to call makeExecutable can be smaller than the one that was used for makeWritable.
So it can leave pages behind that are not set back to default flags. When an assembly on one of those
pages is executed or JIT returns to those pages in the case it was already executing from there, the
software will crash.
- assembler/LinkBuffer.h: Add m_initialSize and use it in performFinalization().
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(LinkBuffer):
- 3:01 PM Changeset in webkit [107446] by
-
- 4 edits2 adds in trunk
flex-pack:center and flex-item-align:center should do true centering
https://bugs.webkit.org/show_bug.cgi?id=77385
Reviewed by Tony Chang.
Source/WebCore:
Also, removed passing totalPositiveFlexibility around. We don't
need to know about positive/negative flex once we run the flexing algorithm.
We used to need to know this in order to flex margins, but margins can
no longer be flexed.
Test: css3/flexbox/true-centering.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
LayoutTests:
- css3/flexbox/true-centering-expected.txt: Added.
- css3/flexbox/true-centering.html: Added.
- 2:44 PM Changeset in webkit [107445] by
-
- 22 edits in trunk/Source
Split MarkedSpace into destructor and destructor-free subspaces
https://bugs.webkit.org/show_bug.cgi?id=77761
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject): Switched over to use destructor-free space.
- heap/Heap.h:
(JSC::Heap::allocatorForObjectWithoutDestructor): Added to give clients (e.g. the JIT) the ability to
pick which subspace they want to allocate out of.
(JSC::Heap::allocatorForObjectWithDestructor): Ditto.
(Heap):
(JSC::Heap::allocateWithDestructor): Added private function for CellAllocator to use.
(JSC):
(JSC::Heap::allocateWithoutDestructor): Ditto.
- heap/MarkedAllocator.cpp: Added the cellsNeedDestruction flag to allocators so that they can allocate
their MarkedBlocks correctly.
(JSC::MarkedAllocator::allocateBlock):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::cellsNeedDestruction):
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC):
(JSC::MarkedAllocator::init): Replaced custom set functions, which were only used upon initialization, with
an init function that does all of that stuff in fewer lines.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::recycle):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::callDestructor): Templatized, along with specializedSweep and sweepHelper, to make
checking the m_cellsNeedDestructor flag faster and cleaner looking.
(JSC):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
- heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::cellsNeedDestruction):
(JSC):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):
- heap/MarkedSpace.h:
(MarkedSpace):
(Subspace):
(JSC::MarkedSpace::allocatorFor): Needed function to differentiate between the two broad subspaces of
allocators.
(JSC):
(JSC::MarkedSpace::destructorAllocatorFor): Ditto.
(JSC::MarkedSpace::allocateWithoutDestructor): Ditto.
(JSC::MarkedSpace::allocateWithDestructor): Ditto.
(JSC::MarkedSpace::forEachBlock):
- jit/JIT.h:
- jit/JITInlineMethods.h: Modified to use the proper allocator for JSFinalObjects and others.
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
- runtime/JSArray.cpp:
(JSC):
- runtime/JSArray.h:
(JSArray):
(JSC::JSArray::create):
(JSC):
(JSC::JSArray::tryCreateUninitialized):
- runtime/JSCell.h:
(JSCell):
(JSC):
(NeedsDestructor): Template struct that calculates at compile time whether the class in question requires
destruction or not using the compiler type trait has_trivial_destructor. allocateCell then checks this
constant to decide whether to allocate in the destructor or destructor-free parts of the heap.
(JSC::allocateCell):
- runtime/JSFunction.cpp:
(JSC):
- runtime/JSFunction.h:
(JSFunction):
- runtime/JSObject.cpp:
(JSC):
- runtime/JSObject.h:
(JSNonFinalObject):
(JSC):
(JSFinalObject):
(JSC::JSFinalObject::create):
Source/WebCore:
No new tests.
- bindings/js/JSDOMWindowShell.cpp: Removed old operator new, which was just used in the create
function so that we can use allocateCell instead.
(WebCore):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::create):
(JSDOMWindowShell):
- bindings/scripts/CodeGeneratorJS.pm: Added destructor back to root JS DOM nodes (e.g. JSNode, etc)
because their destroy functions need to be called, so we don't want the NeedsDestructor struct to
think they don't need destruction due to having empty/trivial destructors.
Removed ASSERT_HAS_TRIVIAL_DESTRUCTOR from all JS DOM wrapper auto-generated objects because their
ancestors now have non-trivial destructors.
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):
- 2:42 PM Changeset in webkit [107444] by
-
- 1 edit2 adds in trunk/LayoutTests
[chromium] Unreviewed, adding Leopard pixel baselines for
fast/forms/select-overflow-scroll* tests. This was missed in r107084.
- platform/chromium-mac-leopard/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- 2:25 PM Changeset in webkit [107443] by
-
- 3 edits in trunk/Source/WebCore
Remove a bunch of unused ScrollableArea member functions
https://bugs.webkit.org/show_bug.cgi?id=78388
Reviewed by Beth Dakin.
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
- 2:20 PM Changeset in webkit [107442] by
-
- 4 edits in trunk/Source/WebCore
Fix a few typos in IDL exception names.
https://bugs.webkit.org/show_bug.cgi?id=78356
Reviewed by Adam Barth.
- dom/Node.idl:
- notifications/NotificationCenter.idl:
- page/Navigator.idl:
- 2:19 PM Changeset in webkit [107441] by
-
- 9 edits1 copy2 deletes in trunk/LayoutTests
[chromium] Unreviewed, fix up some baselines that were landed in r107417.
Some bad results were checked in.
- platform/chromium-linux-x86/svg/filters/filter-refresh-expected.txt:
- platform/chromium-linux/svg/filters/filter-refresh-expected.txt:
- platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/animate-fill-expected.txt: Renamed from LayoutTests/platform/chromium/svg/filters/animate-fill-expected.txt.
- platform/chromium-win-vista/svg/filters/filter-refresh-expected.txt:
- platform/chromium-win-xp/svg/filters/filter-refresh-expected.txt:
- platform/chromium-win-xp/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Removed.
- platform/chromium-win/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
- platform/chromium-win/svg/filters/filter-refresh-expected.txt:
- platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
- 2:17 PM Changeset in webkit [107440] by
-
- 3 edits in trunk/Source/WebCore
DefaultLocalizationStrategy::htmlSelectMultipleItems() should use size_t instead of int
https://bugs.webkit.org/show_bug.cgi?id=78374
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.
The value comes from size_t and is converted to int for no good reason. We should use
size_t.
- platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
- platform/DefaultLocalizationStrategy.h:
(DefaultLocalizationStrategy):
- 2:17 PM Changeset in webkit [107439] by
-
- 2 edits in trunk/LayoutTests
Remove platform/win/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=78382
Reviewed by Adam Barth.
This files is unused, since the Apple win port does not use new-run-webkit-tests, and causes unnecessary
confusion.
- platform/win/test_expectations.txt:
- 2:01 PM Changeset in webkit [107438] by
-
- 4 edits in trunk/Source/WebCore
More ScrollableArea cleanup
https://bugs.webkit.org/show_bug.cgi?id=78383
Reviewed by Beth Dakin.
Get rid of setScrollOriginX and setScrollOriginY. Make ScrollableArea::setScrollOrigin private.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOrigin):
- platform/ScrollableArea.h:
(ScrollableArea):
- 1:52 PM Changeset in webkit [107437] by
-
- 3 edits in branches/subpixellayout/Source
Remove unnecessary type conversions.
- 1:43 PM Changeset in webkit [107436] by
-
- 3 edits in trunk/Source/WebCore
Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
https://bugs.webkit.org/show_bug.cgi?id=78353
Reviewed by Adam Barth.
[JSCustomPrototypePutDelegate] is used to write custom code for named
getters on a prototype interface. "PutDelegate" is just a method name
in implementation and not so descriptive. This patch renames it to
[JSCustomNamedGetterOnPrototype]. This is also for naming consistency
with [CustomNamedGetter].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- page/Location.idl:
- 1:40 PM Changeset in webkit [107435] by
-
- 14 edits3 adds in trunk/Source
Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
https://bugs.webkit.org/show_bug.cgi?id=78282
This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
interface but this one more step in the direction of removing access to NSPasteboard from
the WebProcess.
As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. No change in behavior, just code refactoring.
- WebCore.exp.in: Added exported class PlatformPasteboard.
- WebCore.xcodeproj/project.pbxproj: Added new files to the build.
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard): New method signature that doesn't use OBJ-C types.
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h: Added PasteboardStrategy abstract class.
- platform/PlatformPasteboard.h: Added. This class implements access to NSPasteboard.
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pasteboardStrategy): Added.
- platform/mac/DragDataMac.mm:
(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):
- platform/mac/PasteboardMac.mm:
(WebCore::selectionPasteboardTypes): Changed to use Vector<String> instead of NSArray.
(WebCore::writableTypesForURL): Ditto.
(WebCore::createWritableTypesForImage): Ditto.
(WebCore::writableTypesForImage): Ditto.
(WebCore::Pasteboard::Pasteboard): Removed access to NSPasteboard.
(WebCore::Pasteboard::clear): Modified to use platformStrategies()->pasteboardStrategy().
(WebCore::Pasteboard::writeSelectionForTypes): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::writeURLForTypes): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writeClipboard): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.
- platform/mac/PlatformPasteboardMac.mm: Added.
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
- WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
(WebPlatformStrategies::createPasteboardStrategy):
(WebPlatformStrategies::getTypes):
(WebPlatformStrategies::bufferForType):
(WebPlatformStrategies::getPathnamesForType):
(WebPlatformStrategies::stringForType):
(WebPlatformStrategies::copy):
(WebPlatformStrategies::setTypes):
(WebPlatformStrategies::setBufferForType):
(WebPlatformStrategies::setPathnamesForType):
(WebPlatformStrategies::setStringForType):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added implementation of PasteboardStrategy
interface.
(WebKit::WebPlatformStrategies::createPasteboardStrategy):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
- 1:33 PM Changeset in webkit [107434] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
[chromium] Unreviewed, update SnowLeopard results for
compositing/geometry/fixed-position-composited.html. Minor differences
in fonts between Leopard and SL.
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/chromium/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
- platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Removed.
- 1:16 PM Changeset in webkit [107433] by
-
- 4 edits in branches/chromium/1025
Merge 106730 - Source/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.
Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558
Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect
Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
LayoutTests: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.
Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558
Did change inorder to print correct log as per the description provided in test case.
- fast/events/autoscroll-with-non-scrollable-parent.html:
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9385018
- 1:03 PM Changeset in webkit [107432] by
-
- 8 edits in trunk/Source/WebCore
Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
https://bugs.webkit.org/show_bug.cgi?id=78352
Reviewed by Adam Barth.
[JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
[JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/History.idl:
- page/Location.idl:
- workers/WorkerContext.idl:
- 1:00 PM Changeset in webkit [107431] by
-
- 3 edits in trunk/Source/WebCore
Minor ScrollAnimatorMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=78375
Reviewed by Beth Dakin.
Get rid of adjustScrollXPositionIfNecessary and adjustScrollYPositionIfNecessary.
Also, reduce nesting in willAdd/didAdd functions by using early returns.
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
- 1:00 PM Changeset in webkit [107430] by
-
- 4 edits in branches/chromium/1025/Source/WebKit/chromium
Merge 106401 (part of http://crbug.com/111266) -
[chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453
Needed for http://crbug.com/111266
Reviewed by Darin Fisher.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::didChangeWindowResizerRect):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didChangeWindowResizerRect):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9384018
- 12:49 PM Changeset in webkit [107429] by
-
- 4 edits in trunk/Source/WebCore
Minor ScrollableArea cleanup
https://bugs.webkit.org/show_bug.cgi?id=78372
Reviewed by Beth Dakin.
Get rid of scrollToXOffsetWithoutAnimation and scrollToYOffsetWithoutAnimation.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
- platform/ScrollableArea.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeLogicalHeight):
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::setScrollTop):
- 12:17 PM Changeset in webkit [107428] by
-
- 4 edits in trunk/Source
[Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT
https://bugs.webkit.org/show_bug.cgi?id=78320
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-10
Reviewed by Joseph Pecoraro.
<rdar://problem/10839750>
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- 12:15 PM Changeset in webkit [107427] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, mark compositing/rubberbanding tests as failing.
There's too much flipping in the tests for me to narrow it down to a revision.
- platform/chromium/test_expectations.txt:
- 12:11 PM Changeset in webkit [107426] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream graphics helper classes in WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=78278
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebKitSupport/RenderQueue.cpp: Added.
- blackberry/WebKitSupport/RenderQueue.h: Added.
- 12:07 PM Changeset in webkit [107425] by
-
- 3 edits in trunk/LayoutTests
CSS3 calc: update font-size test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78325
Reviewed by Ojan Vafai.
- css3/calc/font-size-expected.txt:
- css3/calc/font-size.html:
- 12:06 PM Changeset in webkit [107424] by
-
- 2 edits in trunk/Source/WebCore
Update the non-fast-scrollable region for subframe layout as well
https://bugs.webkit.org/show_bug.cgi?id=78366
<rdar://problem/10844064>
Reviewed by Beth Dakin.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Move the non-fast-scrollable region computation out into a new function.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Always recompute the non-fast-scrollable region whenever a frame view's layout is updated,
not just the main frame.
- 11:54 AM Changeset in webkit [107423] by
-
- 1 edit4 adds in trunk/LayoutTests
[chromium] Unreviewed: The Leopard results were missed in r107140.
The getComputedStyle change is due to r107289.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug23151-expected.png: Added.
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
- 11:41 AM Changeset in webkit [107422] by
-
- 14 edits12 adds in trunk
Implement hardware animation of CSS filters
https://bugs.webkit.org/show_bug.cgi?id=78155
Source/WebCore:
Added logic to PlatformCAAnimation to return enough information
to GraphicsLayerCA to be able to construct a keyPath animation
for each filter property. Some filters need to animate multiple
properties per filter, so PlatformCAAnimation also returns the number
of properties per filter and then an animation is constructed for
each one. Also added all the support logic to handle hardware filter
animation in the higher level logic, just like we do for transforms and
opacity.
Also stubbed out new PlatformCAAnimation functions for Windows. We don't yet
support hardware filters on Windows.
Reviewed by Dean Jackson.
Tests: css3/filters/filter-animation-from-none-hw.html
css3/filters/filter-animation-from-none-multi-hw.html
css3/filters/filter-animation-from-none-multi.html
css3/filters/filter-animation-hw.html
css3/filters/filter-animation-multi-hw.html
css3/filters/filter-animation-multi.html
- page/animation/AnimationBase.cpp:
(WebCore):
(PropertyWrapperAcceleratedFilter):
(WebCore::PropertyWrapperAcceleratedFilter::PropertyWrapperAcceleratedFilter):
(WebCore::PropertyWrapperAcceleratedFilter::animationIsAccelerated):
(WebCore::PropertyWrapperAcceleratedFilter::blend):
(WebCore::AnimationBase::ensurePropertyMap):
- platform/graphics/GraphicsLayer.cpp:
(WebCore):
(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
- platform/graphics/GraphicsLayer.h:
(WebCore):
(FilterAnimationValue):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(WebCore::FilterAnimationValue::clone):
(WebCore::FilterAnimationValue::value):
(GraphicsLayer):
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::propertyIdToString):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::cloneLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- platform/graphics/ca/PlatformCAAnimation.h:
(PlatformCAAnimation):
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::numAnimatedFilterProperties):
(PlatformCAAnimation::animatedFilterPropertyName):
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::numAnimatedFilterProperties):
(PlatformCAAnimation::animatedFilterPropertyName):
- platform/graphics/filters/FilterOperation.h:
(FilterOperation):
(WebCore::FilterOperation::isDefault):
(DefaultFilterOperation):
(WebCore::DefaultFilterOperation::create):
(WebCore::DefaultFilterOperation::operator==):
(WebCore::DefaultFilterOperation::isDefault):
(WebCore::DefaultFilterOperation::DefaultFilterOperation):
(WebCore):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::hasFilter):
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):
LayoutTests:
New tests for hardware animated filters, cribbed from software animation tests.
Also added a -multi test, which uses 3 keyframes for each filter. Hardware animations
use the same logic for 2 keyframe animations and transitions, so this exercises the
other logic path.
Reviewed by Dean Jackson.
- css3/filters/filter-animation-from-none-hw-expected.txt: Added.
- css3/filters/filter-animation-from-none-hw.html: Added.
- css3/filters/filter-animation-from-none-multi-expected.txt: Added.
- css3/filters/filter-animation-from-none-multi-hw-expected.txt: Added.
- css3/filters/filter-animation-from-none-multi-hw.html: Added.
- css3/filters/filter-animation-from-none-multi.html: Added.
- css3/filters/filter-animation-hw-expected.txt: Added.
- css3/filters/filter-animation-hw.html: Added.
- css3/filters/filter-animation-multi-expected.txt: Added.
- css3/filters/filter-animation-multi-hw-expected.txt: Added.
- css3/filters/filter-animation-multi-hw.html: Added.
- css3/filters/filter-animation-multi.html: Added.
- 11:36 AM Changeset in webkit [107421] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove implicit copy constructor usage in HashMaps with OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=78071
Reviewed by Darin Adler.
Change the return type of emptyValue() in PairHashTraits to be the
actual type returned rather than the trait type to avoid an implicit
generation of the OwnPtr copy constructor. This happens for hash
traits involving OwnPtr where the empty value is not zero and each
hash bucket needs to be initialized with emptyValue().
Also, update StructureTransitionTable to use default hash traits
rather than rolling its own, in order to update it to handle
EmptyValueType.
Test: patch from bug 74154 compiles on Clang with this patch
- runtime/StructureTransitionTable.h:
(StructureTransitionTable):
- wtf/HashTraits.h:
(GenericHashTraits):
(PairHashTraits):
(WTF::PairHashTraits::emptyValue):
- 11:33 AM Changeset in webkit [107420] by
-
- 3 edits in trunk/LayoutTests
CSS3 calc: convert font test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78321
Reviewed by Ojan Vafai.
- css3/calc/font-expected.txt:
- css3/calc/font.html:
- 11:31 AM Changeset in webkit [107419] by
-
- 5 edits in trunk/LayoutTests
[chromium] Unreviewed: Add baselines on Mac for 2 tests that got
missed in the jpeg change (r107389). I verified that the only diffs
were in the jpeg and very minor.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug86708-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug101674-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug86708-expected.png:
- 11:20 AM Changeset in webkit [107418] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed: Give fast/js/dfg-int8array.html more time to run in debug.
The flakiness dashboard show it timing out regularly on Mac and occasionally on Windows.
- platform/chromium/test_expectations.txt:
- 11:16 AM Changeset in webkit [107417] by
-
- 93 edits62 adds55 deletes in trunk/LayoutTests
Massive SVG rebaselining on Chromium after bug 77736 and al.
Output trimmed.
- 11:02 AM Changeset in webkit [107416] by
-
- 7 edits in branches/subpixellayout/Source/WebCore
Switching RenderLayer's tracked repaint and outline rects, and LayoutRepainter's tracked boundary rects to LayoutRects. This keeps us from losing precision and conducting unnecessary repaints.
- 10:50 AM Changeset in webkit [107415] by
-
- 2 edits in trunk/Tools
NRWT should categorize options in --help
https://bugs.webkit.org/show_bug.cgi?id=76221
Reviewed by Eric Seidel.
Use optparse's OptionGroup mechanism to logically group NRWT's options,
providing a better experience when scanning all the options.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 10:45 AM Changeset in webkit [107414] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 106488
BUG=112259
Review URL: https://chromiumcodereview.appspot.com/9379014
- 10:41 AM Changeset in webkit [107413] by
-
- 1 edit2 copies in branches/chromium/963
Merge 106488
BUG=112259
Review URL: https://chromiumcodereview.appspot.com/9385008
- 10:39 AM Changeset in webkit [107412] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: properly resolve output types of commands
https://bugs.webkit.org/show_bug.cgi?id=78025
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-10
Reviewed by Vsevolod Vlasov.
Code for generating ad-hoc types is added. It was reused from event
generator part.
- inspector/CodeGeneratorInspector.py:
(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext.add_type):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceForwardListener.add_type_data):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceResolveContext):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator):
- 10:35 AM Changeset in webkit [107411] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107369
BUG=112055
Review URL: https://chromiumcodereview.appspot.com/9381012
- 10:28 AM Changeset in webkit [107410] by
-
- 9 edits in trunk/Source/WebCore
Rename [CustomPropertyNames] to [CustomEnumerateProperty]
https://bugs.webkit.org/show_bug.cgi?id=78351
Reviewed by Adam Barth.
This patch renames [CustomPropertyNames] to [CustomEnumerateProperty],
for clarification and for naming consistency with [CustomDeleteProperty].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):
- css/CSSStyleDeclaration.idl:
- dom/DOMStringMap.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- storage/Storage.idl:
- 10:27 AM Changeset in webkit [107409] by
-
- 3 edits in branches/chromium/1025/Source/WebKit/chromium/src
Merge 107174
BUG=108695
Review URL: https://chromiumcodereview.appspot.com/9380014
- 10:22 AM Changeset in webkit [107408] by
-
- 3 edits in branches/chromium/963/Source/WebKit/chromium/src
Merge 107174
BUG=108695
Review URL: https://chromiumcodereview.appspot.com/9383008
- 10:22 AM Changeset in webkit [107407] by
-
- 21 edits in trunk/Source
Use underlying property set to refcount PropertySetCSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=78257
Reviewed by Andreas Kling.
Clean up the PropertySetCSSStyleDeclaration refcounting. PropertySetCSSStyleDeclaration now
forwards the ref/deref to the underlying StylePropertySet.
Also made CSSComputedStyleDeclaration construction use the standard create() pattern.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::ref):
(WebCore):
(WebCore::CSSComputedStyleDeclaration::deref):
- css/CSSComputedStyleDeclaration.h:
(WebCore::CSSComputedStyleDeclaration::create):
(CSSComputedStyleDeclaration):
(WebCore):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
- css/StylePropertySet.h:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::backgroundColorInEffect):
- editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
- svg/SVGAnimateElement.cpp:
(WebCore::getPropertyValue):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::baseValueFor):
- 9:27 AM Changeset in webkit [107406] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
The test is not finishing on windows so now we are waiting 30 seconds
before killing it. Replacing the SLOW keyword with TIMEOUT as it did
not help.
- 9:19 AM Changeset in webkit [107405] by
-
- 2 edits in trunk/LayoutTests
win test_expectations and Skipped have duplicates
https://bugs.webkit.org/show_bug.cgi?id=78260
Reviewed by Anders Carlsson.
- platform/win/test_expectations.txt: Remove duplicated entries
from this file. They were wrongly added to Skipped too and looking
at the comment in r103876, it's better to keep the Skipped entries.
- 8:32 AM Changeset in webkit [107404] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Fix compiler warning in Visual Studio 2010 about TR1
https://bugs.webkit.org/show_bug.cgi?id=63642
Patch by Aron Rosenberg <arosenberg@logitech.com> on 2012-02-10
Reviewed by Simon Hausmann.
- JavaScriptCore.pri:
- 7:41 AM Changeset in webkit [107403] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-10
- DEPS:
- 7:41 AM Changeset in webkit [107402] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console
https://bugs.webkit.org/show_bug.cgi?id=78236
Reviewed by Vsevolod Vlasov.
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype._completeCommonPrefix):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
- 7:41 AM Changeset in webkit [107401] by
-
- 1 edit4 adds in trunk/Source/WebKit
[BlackBerry] Upstream graphics helper classes in WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=78278
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebKitSupport/SurfacePool.cpp: Added.
- blackberry/WebKitSupport/SurfacePool.h: Added.
- blackberry/WebKitSupport/TileIndex.h: Added.
- blackberry/WebKitSupport/TileIndexHash.h: Added.
- 7:31 AM Changeset in webkit [107400] by
-
- 3 edits3 adds in trunk
Yarr assert with regexp where alternative in *-quantified group matches empty
https://bugs.webkit.org/show_bug.cgi?id=67752
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Added backtracking for the prior alternative if it matched
but didn't consume any input characters.
- yarr/YarrJIT.cpp:
(YarrOp): New jump.
(JSC::Yarr::YarrGenerator::generate): Emit conditional jump
when an alternative matches and no input was consumed. Moved the
zero length match check for a set of alternatives to the alternative
code from the parentheses cases to the alternative end cases.
Converted the existing zero length checks in the parentheses cases
to runtime assertion checks.
(JSC::Yarr::YarrGenerator::backtrack): Link new jump to backtrack
to prior term.
LayoutTests:
Added new tests for alternatives that match without consuming
any input characters.
- fast/js/regexp-zero-length-alternatives-expected.txt: Added.
- fast/js/regexp-zero-length-alternatives.html: Added.
- fast/js/script-tests/regexp-zero-length-alternatives.js: Added.
- 5:15 AM Changeset in webkit [107399] by
-
- 17 edits2 copies2 adds in trunk
Web Inspector: implement undo for setOuterHTML via undo-ing nested primitive commands.
https://bugs.webkit.org/show_bug.cgi?id=78346
Reviewed by Yury Semikhatsky.
Source/WebCore:
Tests: inspector/elements/undo-set-outer-html-2.html
inspector/elements/undo-set-outer-html.html
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::ReplaceChildNodeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::undo):
(WebCore):
(DOMEditor::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::SetNodeValueAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::undo):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):
(WebCore::DOMEditor::replaceChild):
(WebCore::DOMEditor::setNodeValue):
(WebCore::populateErrorString):
- inspector/DOMEditor.h:
(DOMEditor):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
(WebCore):
(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::insertBeforeAndMarkAsUsed):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):
- inspector/DOMPatchSupport.h:
(WebCore):
(DOMPatchSupport):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::toErrorString):
(WebCore):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::undo):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::undo):
- inspector/InspectorHistory.h:
(WebCore):
(Action):
(InspectorHistory):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::toggleProperty):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
- inspector/InspectorStyleSheet.h:
(InspectorStyle):
(InspectorStyleSheet):
LayoutTests:
- inspector/elements/set-outer-html-2-expected.txt:
- inspector/elements/set-outer-html-test.js:
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest.patchOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):
(initialize_SetOuterHTMLTest.InspectorTest.innerSetOuterHTML):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.dumpIdentity):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML.callback):
(initialize_SetOuterHTMLTest.InspectorTest._dumpOuterHTML):
(initialize_SetOuterHTMLTest):
- inspector/elements/undo-dom-edits-expected.txt:
- inspector/elements/undo-set-outer-html-2-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
- inspector/elements/undo-set-outer-html-2.html: Added.
- inspector/elements/undo-set-outer-html-expected.txt: Copied from LayoutTests/inspector/elements/set-outer-html-2-expected.txt.
- inspector/elements/undo-set-outer-html.html: Added.
- 5:04 AM Changeset in webkit [107398] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Refactor on Qt5 Layout tests' structure
https://bugs.webkit.org/show_bug.cgi?id=77450
- platform/qt-4.8/Skipped: Add after r107397, because it was missing accidentally.
- 4:48 AM Changeset in webkit [107397] by
-
- 6 edits2 moves in trunk
[Qt][WK2] Refactor on Qt5 Layout tests' structure
https://bugs.webkit.org/show_bug.cgi?id=77450
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-10
Reviewed by Csaba Osztrogonác.
Tools:
Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
to qt-5.0-wk2 and qt-5.0-wk1.
- Scripts/old-run-webkit-tests:
(buildPlatformResultHierarchy):
(readSkippedFiles):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._wk2_port_name):
(QtPort._skipped_file_search_paths):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._wk2_port_name):
LayoutTests:
The folders qt-wk2 and qt-wk1 have been renamed to qt-5.0-wk2 and qt-5.0-wk1, respectively,
and the skipped list from qt-wk1 has been copied into qt-4.8/Skipped.
- platform/qt-4.8/Skipped: Copy entries from platform/qt-wk1.
- platform/qt-5.0-wk1/: Renamed from platform/qt-wk1.
- platform/qt-5.0-wk2/: Renamed from platform/qt-wk1.
- platform/qt-wk1/: Removed.
- platform/qt-wk2/: Removed.
- 4:38 AM Changeset in webkit [107396] by
-
- 18 edits in trunk/Source/WebCore
Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
https://bugs.webkit.org/show_bug.cgi?id=78327
Reviewed by Adam Barth.
This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorJS.pm: Modified to replace
[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateCallWith):
- bindings/scripts/CodeGeneratorGObject.pm: Ditto.
(SkipFunction):
(GenerateFunction):
- bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]
from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):
- bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.
(WebCore::V8Console::assertCallback):
- page/Console.cpp: Ditto.
(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):
- page/Console.h: Ditto.
(Console):
- bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- 3:51 AM Changeset in webkit [107395] by
-
- 2 edits in trunk/Source/WebCore
[GTK] KURL::fileSystemPath() doesn't work if uri contains #
https://bugs.webkit.org/show_bug.cgi?id=78339
Reviewed by Philippe Normand.
- platform/gtk/KURLGtk.cpp:
(WebCore::KURL::fileSystemPath): Use GFile API instead of
g_filename_from_uri() to convert the uri to a local
path. g_file_get_path() removes the anchor from the uri and
returns a valid path instead of NULL.
- 3:46 AM Changeset in webkit [107394] by
-
- 3 edits in trunk/Source/WebCore
CodeGeneratorJS doesn't always generate visitChildren() implementation when required
https://bugs.webkit.org/show_bug.cgi?id=78336
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-10
Reviewed by Kentaro Hara.
In an IDL for an interface that declares no functions, but has
attributes with [CachedAttribute], the implementation of visitChildren()
is not generated by the JSC code generator.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::visitChildren):
(WebCore):
- 3:25 AM Changeset in webkit [107393] by
-
- 5 edits in trunk
Perf-o-matic build fix after r107386.
- Websites/webkit-perf.appspot.com/app.yaml:
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
- Websites/webkit-perf.appspot.com/merge_tests_handler.py:
(MergeTestsHandler.get):
- Websites/webkit-perf.appspot.com/report_logs_handler.py:
(ReportLogsHandler.get):
(ReportLogsHandler.post):
- 3:23 AM Changeset in webkit [107392] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 3:04 AM Changeset in webkit [107391] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline and skipping another svg test
presenting floating-point issues.
- platform/gtk/Skipped:
- platform/gtk/editing/execCommand/insertImage-expected.txt:
- platform/gtk/security/block-test-expected.txt:
- 2:48 AM Changeset in webkit [107390] by
-
- 6 edits in trunk/Source/JavaScriptCore
[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-10
Reviewed by Zoltan Herczeg.
These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread",
and a local static function [initializeGCThreads] is moved from
MainThreadMac.mm to the common MainThread.cpp to make them available
for other platforms.
Measurement results:
V8 speed-up: 1.025x as fast [From: 663.4ms To: 647.0ms ]
V8 Splay speed-up: 1.185x as fast [From: 138.4ms To: 116.8ms ]
Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.
- JavaScriptCore.order:
- wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):
- wtf/MainThread.h:
(WTF):
- wtf/Platform.h:
- wtf/mac/MainThreadMac.mm:
(WTF):
- 2:46 AM Changeset in webkit [107389] by
-
- 4 edits in trunk
[chromium] Increase JPEG decoding performance some more
https://bugs.webkit.org/show_bug.cgi?id=78323
Reviewed by Adam Barth.
Source/WebCore:
Increase JPEG image decoding speed by another 9% (avg) according to libjpeg-turbo tjbench.
No new tests. Covered by many existing tests, all requiring subsequent rebaselines.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(dctMethod): Fast decode on the jpeg-turbo using ports (Chrome Android, Chrome, Chromium).
(WebCore::JPEGImageReader::decode): Select DCT method via a helper routine.
LayoutTests:
- platform/chromium/test_expectations.txt: tests containing jpeg images that will require
rebaselines, mostly together in a group, but some other expectations unattended to at the
current time, spread changes throughout the file. The following lists changed tests for
chrome mac and win:
compositing/geometry/horizontal-scroll-composited.html
compositing/geometry/vertical-scroll-composited.html
compositing/overflow/overflow-scaled-descendant-overlapping.html
fast/backgrounds/size/backgroundSize17.html
fast/backgrounds/size/backgroundSize18.html
fast/backgrounds/size/backgroundSize19.html
fast/backgrounds/size/backgroundSize20.html
fast/backgrounds/size/backgroundSize21.html
fast/backgrounds/size/backgroundSize22.html
fast/block/float/014.html
fast/images/color-jpeg-with-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/image-css3-content-data.html
fast/images/ycbcr-with-cmyk-color-profile.html
fast/repaint/backgroundSizeRepaint.html
fast/repaint/block-layout-inline-children-replaced.html
fast/repaint/clipped-relative.html
fast/repaint/selected-replaced.html
fast/replaced/absolute-image-sizing.html
fast/replaced/image-onload.html
fast/replaced/image-sizing.html
fast/replaced/image-tag.html
fast/replaced/width100percent-image.html
fast/writing-mode/background-horizontal-bt.html
fast/writing-mode/background-vertical-lr.html
fast/writing-mode/background-vertical-rl.html
platform/chromium/compositing/img-layer-grow.html
svg/W3C-SVG-1.1/animate-elem-30-t.svg
svg/W3C-SVG-1.1/animate-elem-36-t.svg
svg/W3C-SVG-1.1/animate-elem-39-t.svg
svg/W3C-SVG-1.1/animate-elem-40-t.svg
svg/W3C-SVG-1.1/coords-viewattr-02-b.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg
svg/W3C-SVG-1.1/struct-image-01-t.svg
svg/W3C-SVG-1.1/struct-image-02-b.svg
svg/W3C-SVG-1.1/struct-image-04-t.svg
svg/carto.net/scrollbar.svg
svg/carto.net/selectionlist.svg
svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg
svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html
svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html
tables/mozilla/bugs/bug101674.html
tables/mozilla/bugs/bug10565.html
tables/mozilla/bugs/bug11026.html
tables/mozilla/bugs/bug1188.html
tables/mozilla/bugs/bug120107.html
tables/mozilla/bugs/bug1271.html
tables/mozilla/bugs/bug12908-1.html
tables/mozilla/bugs/bug12908-2.html
tables/mozilla/bugs/bug1296.html
tables/mozilla/bugs/bug13169.html
tables/mozilla/bugs/bug1430.html
tables/mozilla/bugs/bug15544.html
tables/mozilla/bugs/bug17138.html
tables/mozilla/bugs/bug196870.html
tables/mozilla/bugs/bug29314.html
tables/mozilla/bugs/bug2981-2.html
tables/mozilla/bugs/bug4093.html
tables/mozilla/bugs/bug4284.html
tables/mozilla/bugs/bug4427.html
tables/mozilla/bugs/bug50695-2.html
tables/mozilla/bugs/bug56563.html
tables/mozilla/bugs/bug5797.html
tables/mozilla/bugs/bug625.html
tables/mozilla/bugs/bug6404.html
tables/mozilla/bugs/bug82946-2.html
tables/mozilla/bugs/bug86708.html
tables/mozilla/core/bloomberg.html
tables/mozilla/core/col_widths_auto_autoFix.html
tables/mozilla/core/misc.html
tables/mozilla/core/row_span.html
tables/mozilla/marvin/tbody_valign_baseline.html
tables/mozilla/marvin/tbody_valign_bottom.html
tables/mozilla/marvin/tbody_valign_middle.html
tables/mozilla/marvin/tbody_valign_top.html
tables/mozilla/marvin/td_valign_baseline.html
tables/mozilla/marvin/td_valign_bottom.html
tables/mozilla/marvin/td_valign_middle.html
tables/mozilla/marvin/td_valign_top.html
tables/mozilla/marvin/tfoot_valign_baseline.html
tables/mozilla/marvin/tfoot_valign_bottom.html
tables/mozilla/marvin/tfoot_valign_middle.html
tables/mozilla/marvin/tfoot_valign_top.html
tables/mozilla/marvin/th_valign_baseline.html
tables/mozilla/marvin/th_valign_bottom.html
tables/mozilla/marvin/th_valign_middle.html
tables/mozilla/marvin/th_valign_top.html
tables/mozilla/marvin/thead_valign_baseline.html
tables/mozilla/marvin/thead_valign_bottom.html
tables/mozilla/marvin/thead_valign_middle.html
tables/mozilla/marvin/thead_valign_top.html
tables/mozilla/marvin/tr_valign_baseline.html
tables/mozilla/marvin/tr_valign_bottom.html
tables/mozilla/marvin/tr_valign_middle.html
tables/mozilla/marvin/tr_valign_top.html
tables/mozilla/other/cell_widths.html
tables/mozilla_expected_failures/bugs/bug6933.html
tables/mozilla_expected_failures/bugs/bug85016.html
tables/mozilla_expected_failures/other/test4.html
- 2:10 AM Changeset in webkit [107388] by
-
- 3 edits3 deletes in trunk/LayoutTests
Unreviewed, rebaseline svg/carto.net/selectionlist.svg.
- platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Removed.
- platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Removed.
- platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
- 2:02 AM Changeset in webkit [107387] by
-
- 4 edits1 copy1 delete in trunk/LayoutTests
Unreviewed, rebaseline svg/carto.net/scrollbar-expected.png on chromium mac.
- platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
- platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt: Copied from LayoutTests/platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt.
- platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
- 1:56 AM Changeset in webkit [107386] by
-
- 6 edits1 copy1 move2 adds in trunk
Perf-o-matic should process reports in background
https://bugs.webkit.org/show_bug.cgi?id=78309
Reviewed by Hajime Morita.
Split the logic to create Build, Test, and TestResult objects from ReportHandler into ReportProcessHandler.
ReportHandler now merely creates ReportLog and schedules a task to process it.
Also added ReportLogHandler to manage stale ReportLogs.
- Websites/webkit-perf.appspot.com/app.yaml:
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_manifest_update):
(schedule_dashboard_update):
(schedule_runs_update):
(CachedRunsHandler.get):
(schedule_report_process):
- Websites/webkit-perf.appspot.com/main.py:
- Websites/webkit-perf.appspot.com/merge_tests.html: Renamed from Websites/webkit-perf.appspot.com/merge_tests.yaml.
- Websites/webkit-perf.appspot.com/models.py:
(ReportLog):
(ReportLog._parsed_payload):
(ReportLog.get_value):
(ReportLog.results):
(ReportLog.builder):
(ReportLog.branch):
(ReportLog.platform):
(ReportLog.build_number):
(ReportLog.webkit_revision):
(ReportLog.chromium_revision):
(ReportLog._model_by_key_name_in_payload):
(ReportLog._integer_in_payload):
(ReportLog.timestamp):
- Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
(ReportHandler._output):
(ReportHandler._results_are_valid):
(ReportHandler._results_are_valid._is_float_convertible):
(ReportHandler):
- Websites/webkit-perf.appspot.com/report_logs.html: Added.
- Websites/webkit-perf.appspot.com/report_logs_handler.py: Added.
(ReportLogsHandler):
(ReportLogsHandler.get):
(ReportLogsHandler.post):
(ReportLogsHandler._error):
- Websites/webkit-perf.appspot.com/report_process_handler.py: Copied from Websites/webkit-perf.appspot.com/report_handler.py.
(ReportProcessHandler):
(ReportProcessHandler.post):
(ReportProcessHandler._create_build_if_possible):
(ReportProcessHandler._create_build_if_possible.execute):
(ReportProcessHandler._add_test_if_needed):
- 1:41 AM Changeset in webkit [107385] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test fix following r107373.
https://bugs.webkit.org/show_bug.cgi?id=78254
This also resolves https://bugs.webkit.org/show_bug.cgi?id=77416.
- inspector/timeline/timeline-receive-response-event.html:
- platform/chromium/test_expectations.txt:
- 1:34 AM Changeset in webkit [107384] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: FileSelector should not depend on DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=78337
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.FileSelector.prototype.reset):
(WebInspector.ScriptsPanel.ComboBoxFileSelector):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.reset):
- 1:29 AM Changeset in webkit [107383] by
-
- 2 edits in trunk/LayoutTests
Unreviewed attempt to fix the test failure.
- editing/spelling/spelling-marker-description.html:
- 1:28 AM Changeset in webkit [107382] by
-
- 2 edits in trunk/Source/WebCore
Remove [ConvertingNullStringTo] from CloseEvent.idl
https://bugs.webkit.org/show_bug.cgi?id=78328
Reviewed by Adam Barth.
In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
Test: fast/events/constructors/close-event-constructor.html
- websockets/CloseEvent.idl:
- 1:13 AM Changeset in webkit [107381] by
-
- 2 edits in trunk/LayoutTests
2012-02-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix error in test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 1:06 AM Changeset in webkit [107380] by
-
- 5 edits in trunk
[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78330
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchChildren):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:04 AM Changeset in webkit [107379] by
-
- 2 edits2 deletes in trunk/LayoutTests
- platform/chromium-mac/storage/domstorage/quota-expected.txt: Removed.
- platform/chromium-win/storage/domstorage/quota-expected.txt: Removed.
- These baselines are wrong. Removing them shows that we pass this test now.
- platform/chromium/test_expectations.txt:
- According to the flakiness dashboard, these tests always pass now.
- 12:56 AM Changeset in webkit [107378] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip new asserting tests to paint the debug bot green.
- platform/qt/Skipped:
- 12:52 AM Changeset in webkit [107377] by
-
- 52 edits54 adds36 deletes in trunk/LayoutTests
Update a large number of baselines for svg/custom. These baselines all
appear to be correct (or at least no less correct than the previous
baselines). There are a number of svg/custom tests that appear to be
actually failing, which I haven't rebaselined.
This patch does not update the test_expectations.txt file. Once this
patch has cycled through the bots, I'll clean up the expectations file
as appropriate.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-linux/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/chromium-linux/svg/custom/absolute-root-position-masking-expected.png: Added.
- platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
- platform/chromium-linux/svg/custom/getTransformToElement-expected.png:
- platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
- platform/chromium-linux/svg/custom/js-update-style-expected.txt: Removed.
- platform/chromium-linux/svg/custom/marker-changes-expected.png: Added.
- platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/chromium-linux/svg/custom/text-ctm-expected.png:
- platform/chromium-linux/svg/custom/text-hit-test-expected.png:
- platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- platform/chromium-linux/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.png:
- platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-mac-leopard/svg/custom/getTransformToElement-expected.png:
- platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
- platform/chromium-mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/absolute-root-position-masking-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/getTransformToElement-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/gradient-stroke-width-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/path-bad-data-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-text-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/repaint-on-image-bounds-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-forward-refs-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
- platform/chromium-mac/svg/custom/gradient-stroke-width-expected.png: Removed.
- platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png: Removed.
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Removed.
- platform/chromium-mac/svg/custom/pointer-events-text-expected.png: Removed.
- platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Removed.
- platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png: Removed.
- platform/chromium-mac/svg/custom/use-font-face-crash-expected.png: Removed.
- platform/chromium-mac/svg/custom/use-forward-refs-expected.png: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
- platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
- platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/chromium-win/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/chromium-win/svg/custom/absolute-root-position-masking-expected.png: Added.
- platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
- platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/custom/getTransformToElement-expected.png:
- platform/chromium-win/svg/custom/getTransformToElement-expected.txt:
- platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
- platform/chromium-win/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
- platform/chromium-win/svg/custom/marker-changes-expected.png: Added.
- platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
- platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
- platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.txt:
- platform/chromium-win/svg/custom/pointer-events-image-expected.txt:
- platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
- platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/chromium-win/svg/custom/text-ctm-expected.png:
- platform/chromium-win/svg/custom/text-ctm-expected.txt:
- platform/chromium-win/svg/custom/text-hit-test-expected.png:
- platform/chromium-win/svg/custom/text-hit-test-expected.txt:
- platform/chromium-win/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.png: Added.
- platform/chromium-win/svg/custom/use-font-face-crash-expected.txt: Added.
- platform/chromium-win/svg/custom/use-forward-refs-expected.png:
- platform/chromium/svg/custom/js-update-style-expected.txt: Removed.
- platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-stroke-width-expected.txt: Removed.
- platform/gtk/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
- platform/gtk/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
- platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/gtk/svg/custom/use-forward-refs-expected.txt: Removed.
- platform/gtk/svg/custom/use-invalid-style-expected.txt: Removed.
- platform/gtk/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- platform/mac/svg/custom/absolute-root-position-masking-expected.png: Removed.
- platform/mac/svg/custom/absolute-root-position-masking-expected.txt: Removed.
- platform/mac/svg/custom/gradient-stroke-width-expected.txt: Removed.
- platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
- platform/mac/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/mac/svg/custom/use-forward-refs-expected.txt: Removed.
- platform/mac/svg/custom/use-invalid-style-expected.txt: Removed.
- platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- platform/qt/svg/custom/absolute-root-position-masking-expected.png: Removed.
- platform/qt/svg/custom/absolute-root-position-masking-expected.txt: Removed.
- platform/qt/svg/custom/gradient-stroke-width-expected.txt: Removed.
- platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Removed.
- platform/qt/svg/custom/repaint-on-image-bounds-change-expected.txt: Removed.
- platform/qt/svg/custom/use-forward-refs-expected.txt: Removed.
- platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
- svg/custom/absolute-root-position-masking-expected.png: Added.
- svg/custom/absolute-root-position-masking-expected.txt: Added.
- svg/custom/gradient-stroke-width-expected.txt: Added.
- svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
- svg/custom/repaint-on-image-bounds-change-expected.txt: Added.
- svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
- svg/custom/use-forward-refs-expected.txt: Added.
- svg/custom/use-invalid-style-expected.txt: Added.
- svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Added.
- 12:32 AM Changeset in webkit [107376] by
-
- 2 edits in trunk/LayoutTests
2012-02-10 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, gardening, mark editing/spelling/spelling-marker-description.html as failing.
- platform/chromium/test_expectations.txt:
- 12:21 AM Changeset in webkit [107375] by
-
- 31 edits8 adds5 deletes in trunk/LayoutTests
Update baselines for svg/batik. These baselines either look quite
similar to the previous baselines or look like improvements (e.g., text
masking seems to work now).
- platform/chromium-linux/svg/batik/masking/maskRegions-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.png:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
- platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
- platform/chromium-linux/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt: Added.
- platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
- platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
- platform/chromium-mac-leopard/svg/batik/text/xmlSpace-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Added.
- platform/chromium-mac/svg/batik/filters: Removed.
- platform/chromium-mac/svg/batik/filters/feTile-expected.png: Removed.
- platform/chromium-mac/svg/batik/text/textStyles-expected.png: Removed.
- platform/chromium-mac/svg/batik/text/verticalText-expected.png: Removed.
- platform/chromium-mac/svg/batik/text/xmlSpace-expected.png: Removed.
- platform/chromium-win-xp/svg/batik/masking: Removed.
- platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
- platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
- platform/chromium-win/svg/batik/text/textAnchor-expected.png:
- platform/chromium-win/svg/batik/text/textEffect-expected.png:
- platform/chromium-win/svg/batik/text/textEffect-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png:
- platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/batik/text/textLayout-expected.png:
- platform/chromium-win/svg/batik/text/textPCDATA-expected.png:
- platform/chromium-win/svg/batik/text/textProperties-expected.png:
- platform/chromium-win/svg/batik/text/textProperties2-expected.png:
- platform/chromium-win/svg/batik/text/textStyles-expected.png:
- platform/chromium-win/svg/batik/text/verticalText-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:05 AM Changeset in webkit [107374] by
-
- 3 edits in trunk/Tools
[GTK] EWS command-line option to run the tests
https://bugs.webkit.org/show_bug.cgi?id=78211
Reviewed by Adam Barth.
New --run-tests option (defaults to False) for the EWS commands.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.review_patch):
(ChromiumLinuxEWS):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_builder_ews):
- 12:05 AM Changeset in webkit [107373] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
https://bugs.webkit.org/show_bug.cgi?id=78254
Reviewed by Yury Semikhatsky.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._loadFromFile):
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._reset):
