Timeline
Feb 12, 2012:
- 11:59 PM Changeset in webkit [107538] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping 2 tests failing because of bug 78434.
- platform/gtk/Skipped:
- 11:30 PM Changeset in webkit [107537] by
-
- 5 edits2 deletes in trunk/Source/WebCore
Navigator.webkitGetUserMedia doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=78464
Reviewed by Eric Seidel.
The code generator has gotten smarter since this function was added.
- GNUmakefile.list.am:
- UseV8.cmake:
- WebCore.gypi:
- bindings/js/JSNavigatorCustom.cpp: Removed.
- bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
- page/Navigator.idl:
- 11:03 PM Changeset in webkit [107536] by
-
- 14 edits2 adds in trunk/Source/WebCore
Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=78457
Reviewed by Hajime Morita.
This patch moves GAMEPAD-specific logic out of Navigator by introducing
the concept of a NavigatorSupplement, analogous to the recently
introduced PageSupplement.
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
(WebCore):
(WebCore::NavigatorGamepad::webkitGamepads):
(WebCore::NavigatorGamepad::gamepads):
- Modules/gamepad/NavigatorGamepad.h:
(NavigatorGamepad):
- WebCore.gypi:
- dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::supplementName):
- page/Navigator.cpp:
(WebCore::Navigator::provideSupplement):
(WebCore):
(WebCore::Navigator::requireSupplement):
- page/Navigator.h:
(Navigator):
- page/Page.h:
(Page):
- page/PageSupplement.h:
- This patch cleans up some nits in PageSupplement.
(WebCore):
(PageSupplement):
- 11:00 PM Changeset in webkit [107535] by
-
- 2 edits in trunk
Another perf-o-matic build fix.
- Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler._create_build_if_possible):
- 10:47 PM Changeset in webkit [107534] by
-
- 4 edits1 move3 adds1 delete in trunk/LayoutTests
Unreviewed test expectations update after r107516.
- platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/font-face-multiple-faces-expected.png:
- platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/font-face-multiple-faces-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/css/font-face-multiple-faces-expected.png.
- platform/chromium-mac/fast/css/font-face-default-font-expected.png: Removed.
- platform/chromium-win/fast/css/font-face-default-font-expected.png:
- platform/chromium-win/fast/css/font-face-default-font-expected.txt:
- 10:41 PM Changeset in webkit [107533] by
-
- 1 edit18 deletes in trunk/LayoutTests
Remove fast/css/font-face-descriptor-multiple-values.html
https://bugs.webkit.org/show_bug.cgi?id=78456
The test is no longer needed because WebKit now follow the current
draft(*1) and doesn't accept multiple font-weight descriptors.
(*1) http://dev.w3.org/csswg/css3-fonts/#descdef-font-weight
Reviewed by Hajime Morita.
- fast/css/font-face-descriptor-multiple-values.html: Removed.
- fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Removed.
- platform/chromium-linux/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/chromium-mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
- platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/chromium-win/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
- platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
- platform/efl/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/efl/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
- platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/gtk/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
- platform/mac-leopard/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
- platform/qt/fast/css/font-face-descriptor-multiple-values-expected.png: Removed.
- platform/qt/fast/css/font-face-descriptor-multiple-values-expected.txt: Removed.
- 10:26 PM WebKitIDL edited by
- (diff)
- 10:25 PM WebKitIDL edited by
- (diff)
- 10:21 PM WebKitIDL edited by
- (diff)
- 10:20 PM WebKitIDL edited by
- (diff)
- 10:20 PM Changeset in webkit [107532] by
-
- 2 edits in trunk
Perf-o-matic build fix.
- Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
- 9:45 PM Changeset in webkit [107531] by
-
- 5 edits in trunk
REGRESSION: Perf-o-matic adds duplicated test results
https://bugs.webkit.org/show_bug.cgi?id=78373
Reviewed by Hajime Morita.
Add TestResult inside a transaction. We use high replication databsae but this should prevent
the duplication in the most of the time.
Also fixed random bugs in Controller and ReportHandler.
- Websites/webkit-perf.appspot.com/controller.py:
(get_persistent_cache):
- Websites/webkit-perf.appspot.com/report_handler.py:
(ReportHandler.post):
- Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post):
(ReportProcessHandler._add_test_if_needed):
(ReportProcessHandler):
(ReportProcessHandler._add_test_result_if_needed):
(ReportProcessHandler._add_test_result_if_needed._float_or_none):
(ReportProcessHandler._add_test_result_if_needed.execute):
- 9:35 PM Changeset in webkit [107530] by
-
- 17 edits in trunk/Source/WebCore
Add a [V8CustomToJSObject] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=78450
Reviewed by Adam Barth.
This is the first step to remove hard-coding in HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch adds [V8CustomToJSObject]
to interfaces which have custom toV8() but do not have custom toJS().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm: Replaced hard-coding with [V8CustomToJSObject].
(HasCustomToV8Implementation):
- css/CSSStyleSheet.idl: Added [V8CustomToJSObject].
- dom/DOMStringMap.idl:
- dom/Element.idl:
- dom/NamedNodeMap.idl:
- html/DOMTokenList.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/canvas/CanvasPixelArray.idl:
- inspector/ScriptProfile.idl:
- inspector/ScriptProfileNode.idl:
- page/DOMWindow.idl:
- page/Location.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- workers/WorkerContext.idl:
- 9:26 PM Changeset in webkit [107529] by
-
- 3 edits161 adds in trunk
[EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
https://bugs.webkit.org/show_bug.cgi?id=78091
Patch by Kangil Han <kangil.han@samsung.com> on 2012-02-12
Reviewed by Hajime Morita.
Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
This patch will activate around 1,900 test cases from skipped list in EFL port.
Tools:
- DumpRenderTree/efl/EventSender.cpp:
(textZoom):
(pageZoom):
(textZoomInCallback):
(textZoomOutCallback):
(zoomPageInCallback):
(zoomPageOutCallback):
LayoutTests:
- platform/efl/fast/css/ignore-text-zoom-expected.txt: Added.
- platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
- platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
- platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
- platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
- platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
- platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
- platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
- platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
- platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt: Added.
- platform/efl/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
- platform/efl/svg/as-background-image/background-image-tiled-expected.txt: Added.
- platform/efl/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-as-background-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-background-partial-redraw-expected.txt: Added.
- platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt: Added.
- platform/efl/svg/as-border-image/svg-as-border-image-2-expected.txt: Added.
- platform/efl/svg/as-border-image/svg-as-border-image-expected.txt: Added.
- platform/efl/svg/as-image/animated-svg-as-image-expected.txt: Added.
- platform/efl/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
- platform/efl/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
- platform/efl/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/efl/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
- platform/efl/svg/as-image/same-image-two-instances-expected.txt: Added.
- platform/efl/svg/as-image/svg-as-image-expected.txt: Added.
- platform/efl/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
- platform/efl/svg/as-image/svg-image-change-content-size-expected.txt: Added.
- platform/efl/svg/batik/filters/feTile-expected.txt: Added.
- platform/efl/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/efl/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/efl/svg/batik/paints/gradientLimit-expected.txt: Added.
- platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
- platform/efl/svg/batik/paints/patternRegionA-expected.txt: Added.
- platform/efl/svg/batik/paints/patternRegions-expected.txt: Added.
- platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
- platform/efl/svg/batik/text/longTextOnPath-expected.txt: Added.
- platform/efl/svg/batik/text/smallFonts-expected.txt: Added.
- platform/efl/svg/batik/text/textAnchor-expected.txt: Added.
- platform/efl/svg/batik/text/textAnchor2-expected.txt: Added.
- platform/efl/svg/batik/text/textAnchor3-expected.txt: Added.
- platform/efl/svg/batik/text/textDecoration-expected.txt: Added.
- platform/efl/svg/batik/text/textDecoration2-expected.txt: Added.
- platform/efl/svg/batik/text/textEffect-expected.txt: Added.
- platform/efl/svg/batik/text/textEffect2-expected.txt: Added.
- platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
- platform/efl/svg/batik/text/textFeatures-expected.txt: Added.
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
- platform/efl/svg/batik/text/textLayout-expected.txt: Added.
- platform/efl/svg/batik/text/textLayout2-expected.txt: Added.
- platform/efl/svg/batik/text/textLength-expected.txt: Added.
- platform/efl/svg/batik/text/textOnPath-expected.txt: Added.
- platform/efl/svg/batik/text/textOnPath2-expected.txt: Added.
- platform/efl/svg/batik/text/textOnPath3-expected.txt: Added.
- platform/efl/svg/batik/text/textOnPathSpaces-expected.txt: Added.
- platform/efl/svg/batik/text/textPCDATA-expected.txt: Added.
- platform/efl/svg/batik/text/textPosition-expected.txt: Added.
- platform/efl/svg/batik/text/textPosition2-expected.txt: Added.
- platform/efl/svg/batik/text/textProperties-expected.txt: Added.
- platform/efl/svg/batik/text/textProperties2-expected.txt: Added.
- platform/efl/svg/batik/text/textStyles-expected.txt: Added.
- platform/efl/svg/batik/text/verticalText-expected.txt: Added.
- platform/efl/svg/batik/text/verticalTextOnPath-expected.txt: Added.
- platform/efl/svg/batik/text/xmlSpace-expected.txt: Added.
- platform/efl/svg/carto.net/button-expected.txt: Added.
- platform/efl/svg/carto.net/colourpicker-expected.txt: Added.
- platform/efl/svg/carto.net/combobox-expected.txt: Added.
- platform/efl/svg/carto.net/scrollbar-expected.txt: Added.
- platform/efl/svg/carto.net/selectionlist-expected.txt: Added.
- platform/efl/svg/carto.net/slider-expected.txt: Added.
- platform/efl/svg/carto.net/tabgroup-expected.txt: Added.
- platform/efl/svg/carto.net/textbox-expected.txt: Added.
- platform/efl/svg/carto.net/window-expected.txt: Added.
- platform/efl/svg/clip-path/clip-in-clip-expected.txt: Added.
- platform/efl/svg/clip-path/clip-in-mask-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-text-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
- platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
- platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
- platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
- platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
- platform/efl/svg/css/arrow-with-shadow-expected.txt: Added.
- platform/efl/svg/css/clippath-with-shadow-expected.txt: Added.
- 9:20 PM Applications using WebKit edited by
- (diff)
- 9:18 PM Applications using WebKit edited by
- (diff)
- 9:00 PM Changeset in webkit [107528] by
-
- 3 edits2 adds in trunk
CSS3 currentColor on outline-color gets treated as inherit
https://bugs.webkit.org/show_bug.cgi?id=73180
Patch by David Barr <davidbarr@chromium.org> on 2012-02-12
Reviewed by Antti Koivisto.
Source/WebCore:
The CSS2 and CSS3 UI modules state that outline-color
is not inherited. Make it so.
http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
http://www.w3.org/TR/css3-ui/#outline-color
Test: fast/css/outline-currentcolor.html
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
LayoutTests:
Adapted fast/css/background-currentcolor.html dumpRenderTree test
for outline-color.
- fast/css/outline-currentcolor-expected.txt: Added.
- fast/css/outline-currentcolor.html: Added.
- 9:00 PM Changeset in webkit [107527] by
-
- 5 edits in trunk
KeywordLookupGenerator.py script fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=77886
Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-02-12
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- parser/Keywords.table: Converted to LF-only.
Tools:
- Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
- Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
(GlobalVariablesTest.test_path_rules_specifier):
- 8:58 PM Changeset in webkit [107526] by
-
- 8 edits in trunk/Source/WebCore
CSSPageRule should inherit from CSSRule instead of CSSStyleRule
https://bugs.webkit.org/show_bug.cgi?id=78452
Reviewed by Anders Carlsson.
This matches CSSOM and eliminates the only subclass of CSSStyleRule, enabling further refactoring.
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):
- css/CSSPageRule.h:
(CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selector):
(WebCore::CSSPageRule::properties):
(WebCore::CSSPageRule::adoptSelectorVector):
(WebCore::CSSPageRule::setDeclaration):
- css/CSSRule.cpp:
(WebCore::CSSRule::cssText):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::generateSelectorText):
- css/CSSStyleSelector.cpp:
(WebCore::RuleSet::pageRules):
(RuleSet):
(WebCore::RuleSet::addPageRule):
(WebCore::comparePageRules):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- 8:15 PM Changeset in webkit [107525] by
-
- 14 edits2 adds in trunk/Source
Introduce ShadowRootList.
https://bugs.webkit.org/show_bug.cgi?id=78069
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.
Source/JavaScriptCore:
DoublyLinkedList should have tail() method to take the last element.
- wtf/DoublyLinkedList.h:
(DoublyLinkedList):
(WTF::::tail):
(WTF):
Source/WebCore:
This is a step to implement multiple shadow subtrees.
This patch introduces a shadow root list. ShadowRootList is a doubly linked list,
and each shadow root now has a younger shadow root and older shadow root,
which are a previous element and a next element respectively.
Since a visual tree traversal, which will be introduced in coming patches, will need a older shadow root,
we make a shadow root list a doubly linked list.
However, ShadowRootList does not have more than one shadow root now.
This will be changed in a series of coming patches.
Element::shadowRoot(), setShadowRoot(), ensureShadowRoot(), and removeShadowRoot() are
emulated using ShadowRootList for a while. These API will be replaced to ShadowRootList API later.
No new tests, no change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Element.cpp:
(WebCore::Element::hasShadowRoot):
Retruns true if an element has a shadowRoot.
(WebCore::Element::shadowRootList):
Gets shadow root list if any.
(WebCore::Element::shadowRoot):
Gets the first shadow root from the shadow root list.
(WebCore::Element::setShadowRoot):
Sets the first shadow root to the shadow root list.
(WebCore::Element::removeShadowRoot):
Removes all the shadow roots in the shadow root list.
- dom/Element.h:
(WebCore):
(Element):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
Has shadow root lists instead of shadow root.
(WebCore::ElementRareData::~ElementRareData):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
- dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
- dom/ShadowRootList.cpp: Added.
(WebCore):
(WebCore::ShadowRootList::ShadowRootList):
(WebCore::ShadowRootList::~ShadowRootList):
(WebCore::ShadowRootList::pushShadowRoot):
Adds a shadow root into the list. Currently we limit the list can have only one shadow root.
(WebCore::ShadowRootList::popShadowRoot):
Removes and returns the youngest shadow root if any.
- dom/ShadowRootList.h: Added.
(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):
- 7:53 PM Changeset in webkit [107524] by
-
- 9 edits2 adds in trunk
INPUT shouldn't create ShadowRoot dynamically.
https://bugs.webkit.org/show_bug.cgi?id=77930
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-12
Reviewed by Dimitri Glazkov.
Source/WebCore:
When input type is changed, ShadowRoot was being re-created. This makes it difficult to
support multiple shadow subtrees. This patch makes input re-use the existing shadow root
instead of re-creating a shaow root. A shadow root should be created when an element is created.
Since media control elements are implemented using input elements, these elements should also
create a shadow root in their construction phase.
Test: fast/dom/shadow/input-shadow-nochange.html
Tests related to media controls should be covered by existing tests.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
- html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
- html/shadow/MediaControlElements.cpp: Creates a shadow tree in the construction phase.
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):
LayoutTests:
Ensures cheaging input type does not cause shadow root recreation.
- fast/dom/shadow/input-shadow-nochange.html: Added.
- fast/dom/shadow/input-shadow-nochange-expected.txt: Added.
- 7:35 PM Changeset in webkit [107523] by
-
- 4 edits2 adds in trunk
SVGTRefElement shouldn't create a shadow root dynamically.
https://bugs.webkit.org/show_bug.cgi?id=77938
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-12
Reviewed by Hajime Morita.
Source/WebCore:
SVGTRefElement creates a shadow root dynamically. This will cause a problem to support
multiple shadow subtrees. So it should be created in a constructor phase.
Test: svg/custom/tref-shadowdom.html
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::create):
(WebCore::SVGTRefElement::createShadowSubtree):
(WebCore):
(WebCore::SVGTRefElement::updateReferencedText):
- svg/SVGTRefElement.h:
(SVGTRefElement):
LayoutTests:
Checks a shadow root exists of tref element in cases xlink:href is set and is not set.
- svg/custom/tref-shadowdom-expected.txt: Added.
- svg/custom/tref-shadowdom.html: Added.
- 7:15 PM Changeset in webkit [107522] by
-
- 2 edits in trunk/Tools
Add toText and isTextNode helpers in Text class.
https://bugs.webkit.org/show_bug.cgi?id=78140
Unit test case for the new style checker introduced.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest):
(CppStyleTest.test_static_cast_readability): Added a unit test case.
- 6:15 PM Changeset in webkit [107521] by
-
- 2 edits in trunk/Tools
Enable features supported by EFL port in build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=78348
Reviewed by Ryosuke Niwa.
Sync build-webkit with OptionEfl.cmake, as some features enabled in
OptionEfl.cmake are not enabled in build-webkit.
- Scripts/build-webkit:
- 6:12 PM Changeset in webkit [107520] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore):
(WebCore::JSTestActiveDOMObject::destroy):
(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(JSTestActiveDOMObject):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(JSTestCustomNamedGetter):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore):
(WebCore::JSTestEventConstructor::destroy):
(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(JSTestEventConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore):
(WebCore::JSTestEventTarget::destroy):
(WebCore::JSTestEventTarget::~JSTestEventTarget):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(JSTestEventTarget):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore):
(WebCore::JSTestInterface::destroy):
(WebCore::JSTestInterface::~JSTestInterface):
- bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore):
(WebCore::JSTestMediaQueryListListener::destroy):
(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(JSTestMediaQueryListListener):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore):
(WebCore::JSTestNamedConstructor::destroy):
(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(JSTestNamedConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::JSTestObj::destroy):
(WebCore::JSTestObj::~JSTestObj):
- bindings/scripts/test/JS/JSTestObj.h:
(JSTestObj):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::JSTestSerializedScriptValueInterface::destroy):
(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterface):
- 5:59 PM Changeset in webkit [107519] by
-
- 3 edits3 adds in trunk
Regression (r104528): Crash when moving nodes across documents.
https://bugs.webkit.org/show_bug.cgi?id=78432
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/dom/node-move-to-new-document-crash-main.html
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
LayoutTests:
- fast/dom/node-move-to-new-document-crash-main-expected.txt: Added.
- fast/dom/node-move-to-new-document-crash-main.html: Added.
- fast/dom/resources/node-move-to-new-document-crash.svg: Added.
- 5:18 PM Changeset in webkit [107518] by
-
- 26 edits2 copies in trunk/Source
Page should have less intrusive way to associate API implementation objects.
https://bugs.webkit.org/show_bug.cgi?id=78085
Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-12
Reviewed by Adam Barth.
Source/WebCore:
Introducing PageSupplement interface to attach behind-the-flag-ish
objects to Page instances.
This change aims to improve modularity of Modules/ entries. With
PageSupplement mechinary, we can eliminate ifdef conditionals from
Page.h/Page.cpp and are able to add Modules/ entries without
touching non-Module WebCore files. WebKit API classes like WebPage
can "provide" these objects dynamically during the Page setup phase.
In this change, DeviceMotionController and
DeviceOrientationController is updated to adopt PageSupplement
inteface for an illustrative purpose because they are going to
move into Modules/ shortly. Other Page associated API backing
objects also should be transformed to PageSupplement family.
Reviewed by Adam Barth.
No new tests. No behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DeviceMotionClient.h:
(WebCore):
- dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::supplementName):
(WebCore):
(WebCore::DeviceMotionController::isActiveAt):
(WebCore::provideDeviceMotionTo):
- dom/DeviceMotionController.h:
(DeviceMotionController):
(WebCore::DeviceMotionController::from):
- dom/DeviceOrientationClient.h:
(WebCore):
- dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::supplementName):
(WebCore):
(WebCore::DeviceOrientationController::isActiveAt):
(WebCore::provideDeviceOrientationTo):
- dom/DeviceOrientationController.h:
(DeviceOrientationController):
(WebCore::DeviceOrientationController::from):
- dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
- history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
- page/PageSupplement.cpp:
(WebCore::PageSupplement::~PageSupplement):
(WebCore::PageSupplement::provideTo):
(WebCore::PageSupplement::from):
- page/PageSupplement.h:
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::provideSupplement):
(WebCore):
(WebCore::Page::requireSupplement):
(WebCore::Page::notifyDestroyedToSupplements):
(WebCore::Page::PageClients::PageClients):
- page/Page.h:
(WebCore):
(PageClients):
(Page):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
- 5:01 PM Changeset in webkit [107517] by
-
- 2 edits1 delete in trunk/Source/WebCore
[chromium/mac] Change the type of webkit_system_interface from static_library to none
https://bugs.webkit.org/show_bug.cgi?id=78441
This target exists only run an action and to add a dependency to the
action's output to targets depending on webkit_system_interface.
This is what target type 'none' is for. With this, no dummy source
file is needed, and no empty libwebkit_system_interface.a is created.
This also fixes this (harmless) libtool warning:
libtool: warning for library: libwebkit_system_interface.a the table
of contents is empty (no object file members in the library define
global symbols)
Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-12
Reviewed by Adam Barth.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/mac/Empty.cpp: Removed.
- 4:43 PM Changeset in webkit [107516] by
-
- 6 edits2 adds2 deletes in trunk
If @font-face does not provide an explicit italic/bold variant, regular is used.
https://bugs.webkit.org/show_bug.cgi?id=34147
Reviewed by Dan Bernstein.
Source/WebCore:
Update @font-face handling code so that it matches @font-face behavior to the current draft of CSS3 Font spec. The original patch was written by yusukes@chromium.org.
- Drops support for "bolder", "lighter", and "all" value. These are no longer allowed.
- Only allows one value for font-style and font-weight.
Tests: fast/css/font-face-synthetic-bold-italic.html
fast/css/font-face-weight-matching.html
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Removed "all", "lighter", "bolder" handling code.
(WebCore::compareFontFaces):Updated the weight matching algortihm.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Replaced parseFontStyle() call with checking primitive values.
(WebCore::CSSParser::parseFontWeight): Changed to allow only primitive values.
(WebCore::CSSParser::createFontFaceRule): Removed checks for font-weight and font-style.
(WebCore::CSSParser::deleteFontFaceOnlyValues): Ditto.
- css/CSSParser.h: Removed parseFontStyle().
LayoutTests:
Added two tests to make sure font matching algorithm matches the current draft of CSS Fonts Module Level 3, and removed a test which uses obsoleted 'all' value for font-weight and font-style.
- fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Removed.
- fast/css/font-face-descriptor-multiple-values-parsing.html: Removed.
- fast/css/font-face-synthetic-bold-italic.html: Added.
- fast/css/font-face-weight-matching.html: Added.
- platform/chromium/test_expectations.txt: Needs rebaselines.
- 4:35 PM Writing Layout Tests for DumpRenderTree edited by
- Add missing parenthesis (diff)
- 3:53 PM Changeset in webkit [107515] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Avoid unnecessary memset in per-tile layer updater.
https://bugs.webkit.org/show_bug.cgi?id=78426
Patch by David Reveman <reveman@chromium.org> on 2012-02-12
Reviewed by Stephen White.
Use our own SkBitmap and call SkBitmap::allocPixels() instead of
letting SkDevice construct a SkBitmap. This avoids an unnecessary
memset otherwise done by SkDevice.
No new tests.
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):
- 3:51 PM Changeset in webkit [107514] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Move source files in WTF_HEADERS to WTF_SOURCES.
https://bugs.webkit.org/show_bug.cgi?id=78436
Reviewed by Daniel Bates.
- wtf/CMakeLists.txt: Move .cpp files from WTF_HEADERS to WTF_SOURCES,
and correctly sort the files which start with 'M'.
- 3:35 PM Changeset in webkit [107513] by
-
- 2 edits in trunk/Source/JavaScriptCore
Move the NumberOfCores.h/cpp files into the WTF group of JavaScriptCore.xcodeproj.
Rubber-stamped by Anders Carlsson.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:50 PM Changeset in webkit [107512] by
-
- 4 edits in trunk/Source/JavaScriptCore
[CMake] Remove unused or empty variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=78437
Reviewed by Daniel Bates.
- CMakeLists.txt: Remove unused JavaScriptCore_HEADERS definition.
- shell/CMakeLists.txt: Remove unused JSC_HEADERS definition.
- wtf/CMakeLists.txt: Remove empty WTF_LIBRARIES definition, it will
be defined later by Platform*.cmake via LIST(APPEND WTF_LIBRARIES).
- 10:39 AM Changeset in webkit [107511] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening. Update expected files.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- 6:14 AM Changeset in webkit [107510] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ build after r107454.
- configure.ac: Disable Mutation observers build on GTK+ until it
can actually build.
- 3:27 AM Changeset in webkit [107509] by
-
- 37 edits in trunk
Add toText and isTextNode helpers in Text class.
https://bugs.webkit.org/show_bug.cgi?id=78140
Source/WebCore:
Added a new helper function toText() in dom/Text.h which does the type casting operation to Text object.
Modified the code to make use of this helper function.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.
No new tests.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::accessibleNameForNode):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
- dom/Element.cpp:
(WebCore::Element::recalcStyle):
- dom/Node.cpp:
(WebCore::Node::normalize):
- dom/Position.cpp:
(WebCore::Position::containerText):
(WebCore::Position::leadingWhitespacePosition):
- dom/Range.cpp:
(WebCore::Range::insertNode):
(WebCore::Range::getBorderAndTextQuads):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptContent):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcShadowTreeStyle):
- dom/Text.h: Added new helper function toText.
(WebCore::toText): new helper function which does the type casting operation to Text object.
(WebCore):
- editing/ApplyBlockElementCommand.cpp:
(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::joinChildTextNodes):
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::positionOutsideTabSpan):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):
- editing/Editor.cpp:
(WebCore::Editor::setComposition):
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):
- editing/htmlediting.cpp:
(WebCore::lineBreakExistsAtPosition):
- editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- html/HTMLElement.cpp:
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
(WebCore::mergeWithNextTextNode):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasFallbackContent):
(WebCore::HTMLObjectElement::updateDocNamedItem):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::defaultValue):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::text):
(WebCore::HTMLTitleElement::setText):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeValue):
- rendering/RenderText.cpp:
(WebCore::RenderText::originalText):
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::originalText):
(WebCore::RenderTextFragment::previousCharacter):
Tools:
Added a style checker to use toText rather than static_cast<Text*>.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-12
Reviewed by Adam Barth.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_language): Style checker for static_cast<Text*>.
- 3:16 AM Changeset in webkit [107508] by
-
- 3 edits in trunk/Source/WebCore
Remove [CPPCustom] from CodeGeneratorCPP.pm
https://bugs.webkit.org/show_bug.cgi?id=78342
Reviewed by Adam Barth.
This patch removes [CPPCustom].
[CPPCustom] has been used in DOMWindow.location only to indicate that
DOMWindow.location should be ignored in CPP. However, there are many
other attributes and methods that CPP does not support (e.g. [CallWith=...],
[CustomSetter], etc), and they are not yet marked with [CPPCustom].
CPP just generates "meaningless" code for those unsupported attributes
and methods. Ideally we can mark all unsupported attributes and methods
with [CPPCustom], but it would not be so practical. Otherwise, removing
[CPPCustom] would make sense. The side effect of removing [CPPCustom]
is just that CPP will generate "meaningless" code for DOMWindow.location.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorCPP.pm:
(ShouldSkipType):
- page/DOMWindow.idl:
- 2:53 AM Changeset in webkit [107507] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, rebaseline after r107483 and r107498.
- fast/dom/wrapper-classes-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 2:41 AM Changeset in webkit [107506] by
-
- 3 edits in trunk/Source/WebCore
Rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype]
https://bugs.webkit.org/show_bug.cgi?id=78354
Reviewed by Adam Barth.
This patch renames [JSCustomPrototypeDefineOwnProperty] to
[JSCustomDefineOwnPropertyOnPrototype], for naming consistency with
[JSCustomDefineOwnProperty] and [JSCustomNamedGetterOnPrototype].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- page/Location.idl:
- 2:23 AM Changeset in webkit [107505] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip mutation tests on GTK again after r107504.
- platform/gtk/Skipped:
- 2:13 AM Changeset in webkit [107504] by
-
- 2 edits in trunk/Tools
Unreviewed, disable Mutation observers build on GTK until it can
actually build.
- Scripts/build-webkit:
Feb 11, 2012:
- 11:59 PM Changeset in webkit [107503] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT calls fprintf() instead of dataLog in terminateSpeculativeExecution()
https://bugs.webkit.org/show_bug.cgi?id=78431
Reviewed by Gavin Barraclough.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
- 10:32 PM Changeset in webkit [107502] by
-
- 5 edits14 adds in trunk
Add back WTFURL to WebKit
https://bugs.webkit.org/show_bug.cgi?id=77291
Reviewed by Adam Barth.
Source/JavaScriptCore:
WTFURL was removed from WebKit in r86787.
This patch adds the code back to WTF with the following changes:
-Guard the feature with USE(WTFURL).
-Change the typename CHAR to CharacterType to follow recent WebKit conventions.
-Fix some coding style to make check-webkit-style happy.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Platform.h:
- wtf/url/api/ParsedURL.cpp: Added.
(WTF):
(WTF::ParsedURL::ParsedURL):
(WTF::ParsedURL::scheme):
(WTF::ParsedURL::username):
(WTF::ParsedURL::password):
(WTF::ParsedURL::host):
(WTF::ParsedURL::port):
(WTF::ParsedURL::path):
(WTF::ParsedURL::query):
(WTF::ParsedURL::fragment):
(WTF::ParsedURL::segment):
- wtf/url/api/ParsedURL.h: Added.
(WTF):
(ParsedURL):
(WTF::ParsedURL::spec):
- wtf/url/api/URLString.h: Added.
(WTF):
(URLString):
(WTF::URLString::URLString):
(WTF::URLString::string):
- wtf/url/src/RawURLBuffer.h: Added.
(WTF):
(RawURLBuffer):
(WTF::RawURLBuffer::RawURLBuffer):
(WTF::RawURLBuffer::~RawURLBuffer):
(WTF::RawURLBuffer::resize):
- wtf/url/src/URLBuffer.h: Added.
(WTF):
(URLBuffer):
(WTF::URLBuffer::URLBuffer):
(WTF::URLBuffer::~URLBuffer):
(WTF::URLBuffer::at):
(WTF::URLBuffer::set):
(WTF::URLBuffer::capacity):
(WTF::URLBuffer::length):
(WTF::URLBuffer::data):
(WTF::URLBuffer::setLength):
(WTF::URLBuffer::append):
(WTF::URLBuffer::grow):
- wtf/url/src/URLCharacterTypes.cpp: Added.
(WTF):
():
- wtf/url/src/URLCharacterTypes.h: Added.
(WTF):
(URLCharacterTypes):
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isHexChar):
():
(WTF::URLCharacterTypes::isCharOfType):
- wtf/url/src/URLComponent.h: Added.
(WTF):
(URLComponent):
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::fromRange):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonEmpty):
(WTF::URLComponent::isEmptyOrInvalid):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):
- wtf/url/src/URLEscape.cpp: Added.
(WTF):
():
- wtf/url/src/URLEscape.h: Added.
(WTF):
(WTF::appendURLEscapedCharacter):
- wtf/url/src/URLParser.h: Added.
(WTF):
(URLParser):
():
(WTF::URLParser::isPossibleAuthorityTerminator):
(WTF::URLParser::parseAuthority):
(WTF::URLParser::extractScheme):
(WTF::URLParser::parseAfterScheme):
(WTF::URLParser::parseStandardURL):
(WTF::URLParser::parsePath):
(WTF::URLParser::parsePathURL):
(WTF::URLParser::parseMailtoURL):
(WTF::URLParser::parsePort):
(WTF::URLParser::extractFileName):
(WTF::URLParser::extractQueryKeyValue):
(WTF::URLParser::isURLSlash):
(WTF::URLParser::shouldTrimFromURL):
(WTF::URLParser::trimURL):
(WTF::URLParser::consecutiveSlashes):
(WTF::URLParser::isPortDigit):
(WTF::URLParser::nextAuthorityTerminator):
(WTF::URLParser::parseUserInfo):
(WTF::URLParser::parseServerInfo):
- wtf/url/src/URLQueryCanonicalizer.h: Added.
(WTF):
(URLQueryCanonicalizer):
(WTF::URLQueryCanonicalizer::canonicalize):
(WTF::URLQueryCanonicalizer::isAllASCII):
(WTF::URLQueryCanonicalizer::isRaw8Bit):
(WTF::URLQueryCanonicalizer::appendRaw8BitQueryString):
(WTF::URLQueryCanonicalizer::convertToQueryEncoding):
- wtf/url/src/URLSegments.cpp: Added.
(WTF):
(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):
- wtf/url/src/URLSegments.h: Added.
(WTF):
(URLSegments):
():
(WTF::URLSegments::URLSegments):
Tools:
Add a flag to build-webkit to easily build WebKit with WTFURL.
- Scripts/build-webkit:
- 7:54 PM Changeset in webkit [107501] by
-
- 3 edits in trunk/Source/JavaScriptCore
Old JIT put_by_id profiling counts every put_by_id_transition as taking slow path
https://bugs.webkit.org/show_bug.cgi?id=78430
<rdar://problem/10849469> <rdar://problem/10849684>
Reviewed by Gavin Barraclough.
The old JIT's put_by_id transition caching involves repatching the slow call to
a generated stub. That means that the call is counted as "slow case". So, this
patch inserts code to decrement the slow case count if the stub succeeds.
Looks like a ~1% speed-up on V8.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- 7:38 PM Changeset in webkit [107500] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for Qt.
- wtf/DataLog.h:
- 7:21 PM Changeset in webkit [107499] by
-
- 50 edits3 adds in trunk/Source
It should be possible to send all JSC debug logging to a file
https://bugs.webkit.org/show_bug.cgi?id=78418
Reviewed by Sam Weinig.
Introduced wtf/DataLog, which defines WTF::dataFile, WTF::dataLog,
and WTF::dataLogV. Changed all debugging- and profiling-related printfs
to use WTF::dataLog() or one of its friends. By default, debug logging
goes to stderr, unless you change the setting in wtf/DataLog.cpp.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::vprintfStdoutInstr):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):
- bytecode/Opcode.cpp:
(JSC::OpcodeStats::~OpcodeStats):
- bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCommon.h:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::Propagator::performBlockCFA):
(JSC::DFG::Propagator::performForwardCFA):
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::dump):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::dump):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- heap/Heap.cpp:
(JSC::Heap::destroy):
- heap/MarkedBlock.h:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::dumpRegExpTrace):
- runtime/RegExp.cpp:
(JSC::RegExp::matchCompareWithInterpreter):
- runtime/SamplingCounter.cpp:
(JSC::AbstractSamplingCounter::dump):
- runtime/SamplingCounter.h:
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):
- runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::report):
- tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
- wtf/CMakeLists.txt:
- wtf/DataLog.cpp: Added.
(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLog):
- wtf/DataLog.h: Added.
(WTF):
- wtf/HashTable.cpp:
(WTF::HashTableStats::~HashTableStats):
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
- wtf/text/WTFString.cpp:
(String::show):
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::dumpDisjunction):
Source/WebCore:
No new tests because behavior is unchanged.
- ForwardingHeaders/wtf/DataLog.h: Added.
Source/WTF:
- WTF.pro:
- 6:47 PM Changeset in webkit [107498] by
-
- 29 edits in trunk
Move special proto property to Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=78409
Reviewed by Oliver Hunt.
Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- No need to prohibit functions named proto.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- Add proto accessor to Object.prototype.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):
- Definition of the proto accessor functions.
- runtime/JSGlobalObjectFunctions.h:
- Declaration of the proto accessor functions.
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.
(JSC::JSObject::putDirectAccessor):
- Track on the structure whether an object contains accessors other than one for proto.
(JSC::JSObject::defineOwnProperty):
- No need to prohibit definition of own properties named proto.
- runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):
- Remove the special handling for proto.
(JSC::JSValue::get):
- Remove the special handling for proto.
- runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
- Remove the special handling for proto.
- runtime/JSValue.h:
(JSValue):
- Made synthesizePrototype public (this may be needed by the proto getter).
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
- Perform the security check & call prototype() directly.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
- runtime/Structure.h:
(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):
- Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):
- expose allowsAccessFrom check to JSC.
- bindings/js/JSDOMWindowBase.h:
(JSDOMWindowBase):
- expose allowsAccessFrom check to JSC.
LayoutTests:
- fast/js/Object-getOwnPropertyNames-expected.txt:
- fast/js/cyclic-prototypes-expected.txt:
- fast/js/parser-syntax-check-expected.txt:
- fast/js/preventExtensions-expected.txt:
- fast/js/prototypes-expected.txt:
- Update results
- fast/js/script-tests/Object-getOwnPropertyNames.js:
- proto is now a property of Object Prototype.
- fast/js/script-tests/cyclic-prototypes.js:
- setting an object's prototype to null removes proto setter, future usage won't set prototype.
- fast/js/script-tests/parser-syntax-check.js:
- Allow functions named proto
- fast/js/script-tests/preventExtensions.js:
- Setting proto should not throw.
- fast/js/script-tests/prototypes.js:
- Objects may contained own properties named proto, add new test cases.
- 6:33 PM Changeset in webkit [107497] by
-
- 6 edits1 delete in trunk/Source/WebCore
Get rid of WebCore::URLString
https://bugs.webkit.org/show_bug.cgi?id=78429
Reviewed by Adam Barth.
URLString is unused, remove the class.
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.cpp:
- platform/KURL.h:
(KURL):
- platform/URLString.h: Removed.
- 6:26 PM Changeset in webkit [107496] by
-
- 3 edits3 adds in trunk
DFG CFA assumes that a WeakJSConstant's structure is known
https://bugs.webkit.org/show_bug.cgi?id=78428
<rdar://problem/10849492> <rdar://problem/10849621>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
LayoutTests:
Rubber stamped by Gavin Barraclough.
- fast/js/dfg-put-by-id-prototype-check-expected.txt: Added.
- fast/js/dfg-put-by-id-prototype-check.html: Added.
- fast/js/script-tests/dfg-put-by-id-prototype-check.js: Added.
(foo):
(Foo):
- 5:27 PM Changeset in webkit [107495] by
-
- 2 edits in trunk/Source/JavaScriptCore
Qt debug build fix
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): Platforms that don't use clang will allocate
JSFinalObjects in the destuctor subspace, so we should remove this assert so it
doesn't cause crashes.
- 5:24 PM Changeset in webkit [107494] by
-
- 2 edits in trunk/Source/JavaScriptCore
Old 32_64 JIT should assert that its use of map() is consistent with the DFG
OSR exit's expectations
https://bugs.webkit.org/show_bug.cgi?id=78419
<rdar://problem/10817121>
Reviewed by Oliver Hunt.
- jit/JITInlineMethods.h:
(JSC::JIT::map):
- 5:18 PM Changeset in webkit [107493] by
-
- 2 edits in trunk/Source/JavaScriptCore
Reduce the reentrancy limit of the interpreter for the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=78400
Reviewed by Gavin Barraclough.
- interpreter/Interpreter.h: Lowered the maximum reentrancy limit for large thread stacks.
(JSC):
- 4:08 PM Changeset in webkit [107492] by
-
- 3 edits3 adds in trunk
[DFG] Misuse of WeakJSConstants in silentFillGPR code.
https://bugs.webkit.org/show_bug.cgi?id=78423
<rdar://problem/10849353> <rdar://problem/10804043>
Source/JavaScriptCore:
Reviewed by Sam Weinig.
The code was using Node::isConstant(), when it was supposed to use Node::hasConstant().
This patch is a surgical fix; the bigger problem is: why do we have isConstant() and
hasConstant() when hasConstant() is correct and isConstant() is almost always wrong?
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillGPR):
LayoutTests:
Rubber stamped by Sam Weinig.
- fast/js/dfg-weak-js-constant-silent-fill.html: Added.
- fast/js/dfg-weak-js-constant-silent-fill-expected.txt: Added.
- fast/js/script-tests/dfg-weak-js-constant-silent-fill.js: Added.
- 3:58 PM Changeset in webkit [107491] by
-
- 11 edits in trunk/Source/WebCore
Fix the windows build.
Since Windows uses an all-in-one file to compile, the isRespectedPresentationAttribute()
functions all need unique names.
- html/HTMLBodyElement.cpp:
- html/HTMLHRElement.cpp:
- html/HTMLIFrameElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLMarqueeElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLTableCellElement.cpp:
- html/HTMLTablePartElement.cpp:
- mathml/MathMLElement.cpp:
- 3:36 PM Changeset in webkit [107490] by
-
- 5 edits in trunk/Source/WebCore
Overlay scrollbars don't appear when scrolling on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78427
Reviewed by Sam Weinig.
Add a ScrollAnimator::notifyContentAreaScrolled and call it from ScrollAnimator::notifyContentAreaScrolled.
It is then overridden in ScrollAnimatorMac to tickle AppKit so that overlay scrollbars will be shown.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):
(ScrollAnimator):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore):
- 3:10 PM Changeset in webkit [107489] by
-
- 3 edits in trunk/Source/JavaScriptCore
Prepare JavaScriptCore to build with libc++
<rdar://problem/10426673>
https://bugs.webkit.org/show_bug.cgi?id=78424
Reviewed by Anders Carlsson.
- wtf/NullPtr.cpp:
- wtf/NullPtr.h:
libc++ provides std::nullptr emulation, so we don't have to.
- 3:02 PM Changeset in webkit [107488] by
-
- 4 edits in trunk/Source/WebCore
Implement more ScrollElasticityControllerClient member functions
https://bugs.webkit.org/show_bug.cgi?id=78425
<rdar://problem/10710727>
Reviewed by Sam Weinig.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::horizontalScrollElasticity):
(WebCore::ScrollingTreeNode::verticalScrollElasticity):
(WebCore::ScrollingTreeNode::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeNode::hasEnabledVerticalScrollbar):
Add new getters.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::scrollByWithoutContentEdgeConstraints):
Implement ScrollElasticityControllerClient member functions.
- 1:44 PM Changeset in webkit [107487] by
-
- 2 edits in trunk/Source/WebCore
Add size assert for Length
https://bugs.webkit.org/show_bug.cgi?id=78420
Rubber-stamped by Andreas Kling.
Length type is memory critical and must not grow.
- platform/Length.cpp:
(SameSizeAsLength):
(WebCore):
- 1:37 PM Changeset in webkit [107486] by
-
- 3 edits in trunk/Source/WebCore
Pass wheel events to a scroll elasticity controller on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78421
Reviewed by Sam Weinig.
Add a ScrollElasticityController to ScrollingTreeNodeMac and pass wheel events to it.
Fix ScrollingTreeNodeMac::scrollBy to clamp by the minimum and maximum scroll positions.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::ScrollingTreeNodeMac):
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollBy):
- 1:07 PM Changeset in webkit [107485] by
-
- 13 edits3 adds in trunk/Source/JavaScriptCore
DFG should have polymorphic put_by_id caching
https://bugs.webkit.org/show_bug.cgi?id=78062
<rdar://problem/10326439> <rdar://problem/10824839>
Reviewed by Oliver Hunt.
Implemented polymorphic put_by_id caching in the DFG, and added much of the
machinery that would be needed to implement it in the old JIT as well.
I decided against using the old PolymorphicAccessStructureList mechanism as
this didn't quite fit with put_by_id. In particular, I wanted the ability to
have one list that captured all relevant cases (including proto put_by_id
if we ever decided to do it). And I wanted the code to have better
encapsulation. And I didn't want to get confused by the fact that the
original (non-list) put_by_id cache may itself consist of a stub routine.
This code is still sub-optimal (for example adding a replace to a list whose
previous elements are all transitions should just repatch the original code,
but here it will generate a stub) but it already generates a >20% speed-up
on V8-splay, leading to a 2% win overall in splay. Neutral elsewhere.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/PolymorphicPutByIdList.cpp: Added.
(JSC):
(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::from):
(JSC::PolymorphicPutByIdList::~PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::isFull):
(JSC::PolymorphicPutByIdList::isAlmostFull):
(JSC::PolymorphicPutByIdList::addAccess):
(JSC::PolymorphicPutByIdList::visitWeak):
- bytecode/PolymorphicPutByIdList.h: Added.
(JSC):
(PutByIdAccess):
(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::isSet):
(JSC::PutByIdAccess::operator!):
(JSC::PutByIdAccess::type):
(JSC::PutByIdAccess::isTransition):
(JSC::PutByIdAccess::isReplace):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::structure):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(PolymorphicPutByIdList):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):
(JSC::PolymorphicPutByIdList::isEmpty):
(JSC::PolymorphicPutByIdList::size):
(JSC::PolymorphicPutByIdList::at):
(JSC::PolymorphicPutByIdList::operator[]):
(JSC::PolymorphicPutByIdList::kind):
- bytecode/PutKind.h: Added.
(JSC):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
(JSC):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdList):
(StructureStubInfo):
(JSC::StructureStubInfo::reset):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
(DFG):
- dfg/DFGRepatch.cpp:
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(DFG):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::dfgRepatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgBuildPutByIdList):
(JSC::DFG::dfgResetPutByID):
- dfg/DFGRepatch.h:
(DFG):
- runtime/WriteBarrier.h:
(WriteBarrierBase):
(JSC::WriteBarrierBase::copyFrom):
- 11:29 AM Changeset in webkit [107484] by
-
- 67 edits in trunk/Source/WebCore
Attribute styles should be created lazily.
<http://webkit.org/b/78381>
Reviewed by Antti Koivisto.
TL;DR summary: Lazily construct the StyledElement::attributeStyle() instead of
moving properties in/out of it in parseAttribute(). This allows us to enable
the matched declaration cache for elements with presentation attributes.
The matched declaration cache has been disabled for elements with presentation
attributes because attributeStyle() was mutable, and (simply put) the cache maps
a set of StylePropertySet pointers to a resulting RenderStyle. This requires
that the StylePropertySets are immutable.
To make them immutable, we now construct the attribute style lazily by adding
a flag (to Node) that gets set in parseAttribute() when a presentation attribute
respected by the element changes. A subsequent call to attributeStyle() checks
the flag and rebuilds the style by looping over the attributes and calling the
new virtual StyledElement::collectStyleForAttribute() on each one. Any dangling
references to the previous attribute style will be garbage collected by the
cache in CSSStyleSelector::sweepMatchedDeclarationCache().
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):
Enable matched declaration cache for elements with attribute style.
- dom/Node.h:
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
Add a Node flag to signify that a presentation attribute has changed and
the attribute style needs to be rebuilt.
- dom/ElementAttributeData.h:
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::setAttributeStyle):
Added a setter for the attribute style, called by updateAttributeStyle().
- dom/StyledElement.cpp:
(WebCore::StyledElement::addHTMLLengthToStyle):
(WebCore::StyledElement::addHTMLColorToStyle):
Moved and renamed two of the old addCSS* helpers from StyledElement.
(WebCore::StyledElement::updateAttributeStyle):
Called by attributeStyle() in case the "attribute style dirty" flag is
set. Rebuilds the attribute style from scratch by looping over the
attribute map and calling collectStyleForAttribute() on each attribute.
- dom/StyledElement.h:
(WebCore::StyledElement::collectStyleForAttribute):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::setNeedsAttributeStyleUpdate):
Helper, sets the attribute style dirty flag and marks the element for
full style recalc. This is what parseAttribute() calls in subclasses
when they encounter a presentation attribute.
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
(WebCore::HTMLBRElement::parseAttribute):
- html/HTMLBRElement.h:
- html/HTMLBodyElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):
- html/HTMLBodyElement.h:
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForAttribute):
(WebCore::HTMLDivElement::parseAttribute):
- html/HTMLDivElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):
- html/HTMLEmbedElement.h:
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
(WebCore::HTMLFontElement::parseAttribute):
- html/HTMLFontElement.h:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::collectStyleForAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLHRElement::collectStyleForAttribute):
(WebCore::HTMLHRElement::parseAttribute):
- html/HTMLHRElement.h:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):
- html/HTMLInputElement.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForAttribute):
(WebCore::HTMLLIElement::parseAttribute):
- html/HTMLLIElement.h:
- html/HTMLMarqueeElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
(WebCore::HTMLMarqueeElement::parseAttribute):
- html/HTMLMarqueeElement.h:
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForAttribute):
(WebCore::HTMLOListElement::parseAttribute):
- html/HTMLOListElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::collectStyleForAttribute):
(WebCore::HTMLObjectElement::parseAttribute):
- html/HTMLObjectElement.h:
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForAttribute):
(WebCore::HTMLParagraphElement::parseAttribute):
- html/HTMLParagraphElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLPlugInElement::collectStyleForAttribute):
(WebCore::HTMLPlugInElement::parseAttribute):
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::collectStyleForAttribute):
(WebCore::HTMLPreElement::parseAttribute):
- html/HTMLPreElement.h:
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
(WebCore::HTMLTableCaptionElement::parseAttribute):
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::collectStyleForAttribute):
(WebCore::HTMLTableColElement::parseAttribute):
- html/HTMLTableColElement.h:
- html/HTMLTableElement.cpp:
(WebCore::getBordersFromFrameAttributeValue):
(WebCore::HTMLTableElement::collectStyleForAttribute):
(WebCore::HTMLTableElement::parseAttribute):
- html/HTMLTableElement.h:
- html/HTMLTablePartElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
(WebCore::HTMLTablePartElement::parseAttribute):
- html/HTMLTablePartElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):
- html/HTMLTextAreaElement.h:
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForAttribute):
(WebCore::HTMLUListElement::parseAttribute):
- html/HTMLUListElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectStyleForAttribute):
(WebCore::HTMLVideoElement::parseAttribute):
- html/HTMLVideoElement.h:
- mathml/MathMLElement.cpp:
(WebCore::isRespectedPresentationAttribute):
(WebCore::MathMLElement::collectStyleForAttribute):
(WebCore::MathMLElement::parseAttribute):
- mathml/MathMLElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForAttribute):
(WebCore::SVGImageElement::parseAttribute):
- svg/SVGImageElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::parseAttribute):
- svg/SVGStyledElement.h:
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
- svg/SVGTextContentElement.h:
Split handling of presentation attributes between parseAttribute() and
collectStyleForAttribute() as appropriate. Some minor refactorings here and
there (mostly in HTMLTableElement) to avoid excessive code duplication.
Also sprinkled FIXMEs about inefficiencies we should clean up.
- 10:51 AM Changeset in webkit [107483] by
-
- 6 edits2 adds in trunk
HTML 5: Support click() method on HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=27880
Patch by Arko Saha <arko@motorola.com> on 2012-02-11
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: fast/dom/click-method-on-html-element.html
- bindings/objc/PublicDOMInterfaces.h: Added click() method in DOMHTMLElement
with availability macro AVAILABLE_AFTER_WEBKIT_VERSION_5_1.
- html/HTMLButtonElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
- html/HTMLElement.idl: Added click() IDL method.
- html/HTMLInputElement.idl: Moved click() method under LANGUAGE_OBJECTIVE_C.
LayoutTests:
- fast/dom/click-method-on-html-element-expected.txt: Added.
- fast/dom/click-method-on-html-element.html: Added.
- 10:36 AM Changeset in webkit [107482] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] html5test.com says that gstreamer ports do not support WebM for audio
https://bugs.webkit.org/show_bug.cgi?id=78244
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-11
Reviewed by Eric Seidel.
Specifically advertise support for audio/webm when we support the vorbis
audio codec. This is necessary because gstreamer doesn't advertise it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Add an override for audio/webm.
- 10:18 AM Changeset in webkit [107481] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
- 9:46 AM Changeset in webkit [107480] by
-
- 12 edits2 adds in trunk/Source/WebCore
[chromium] Enable CSS filters on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=77266
Reviewed by James Robinson.
Will be covered by existing tests in css3/filters (when enabled).
- WebCore.gypi:
Add CCRenderSurfaceFilters.* to the Chromium build.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setFilters):
- platform/graphics/chromium/GraphicsLayerChromium.h:
Override setFilters() virtual from GraphicsLayer.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setFilters):
Implement setFilters() to cache the filters here...
(WebCore::LayerChromium::pushPropertiesTo):
... and push them to the CCLayerImpl at commit time.
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::filters):
Implement accessor.
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setFilters):
Implement stub version of setFilters(), to satisfy the templates.
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setFilters):
Implement setter to receive filters at commit time.
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::filters):
Implement member var and accessor for filters.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
Add another clause here to force creation of a RenderSurface when
filters are present, and to forward them from the layer to the
RenderSurface.
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
(WebCore::CCRenderSurface::drawLayer):
Check for filters at draw time, apply them, and forward the result
through the drawing traversal.
(WebCore::CCRenderSurface::drawSurface):
If filter bitmap is present, bind it instead of the normal
RenderSurface texture.
(WebCore::CCRenderSurface::applyFilters):
Apply filters to the render surface texture, and return the result.
This function is a no-op for the threaded compositor, due to use
of the SharedGraphicsContext3D.
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setFilters):
(WebCore::CCRenderSurface::filters):
(CCRenderSurface):
Filters getters and setters.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Added.
(WebCore::CCRenderSurfaceFilters::apply):
External interface for this (static) class. All internal
implementation and helper functions are in the unnamed namespace.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Added.
- 8:17 AM Changeset in webkit [107479] by
-
- 3 edits2 adds in trunk
Node.isEqualNode() compares attributes twice.
<http://webkit.org/b/78414>
Reviewed by Anders Carlsson.
Source/WebCore:
A single pass across the attribute maps should be enough for anyone.
Added a test verifying correct behavior of Node.isEqualNode() when comparing
two elements, one of which has had attributes that were all removed,
resulting in an empty but non-null NamedNodeMap hanging off of the element.
Note that this change is not fixing a regression, I'm just adding the test
since I came close to introducing a bug here.
Test: fast/dom/isEqualNode-after-removeAttribute.html
- dom/Node.cpp:
(WebCore::Node::isEqualNode):
LayoutTests:
- fast/dom/isEqualNode-after-removeAttribute-expected.txt: Added.
- fast/dom/isEqualNode-after-removeAttribute.html: Added.
- 6:54 AM Changeset in webkit [107478] by
-
- 6 edits in trunk/Source/WebCore
HTMLTablePartElement: Add helper method to find parent table.
<http://webkit.org/b/78413>
Reviewed by Anders Carlsson.
Add HTMLTablePartElement::findParentTable() and use that in subclasses instead
of duplicating the code.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
(WebCore):
- html/HTMLTablePartElement.h:
(WebCore):
(HTMLTablePartElement):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
- 6:50 AM Changeset in webkit [107477] by
-
- 22 edits in trunk/Source/WebCore
Use Element's hasName/hasID flags to avoid unnecessary work when looking up name/id attributes.
<http://webkit.org/b/77845>
Reviewed by Anders Carlsson.
Have Element::getIdAttribute() check the hasID() flag before looking up the attribute.
Add an Element::getNameAttribute() to do the same thing with hasName().
Update call sites to make use of these helpers whenever possible.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescription):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
- dom/Element.h:
(Element):
(WebCore::Element::getIdAttribute):
(WebCore):
(WebCore::Element::getNameAttribute):
- dom/NameNodeList.cpp:
(WebCore::NameNodeList::nodeMatches):
- dom/StaticHashSetNodeList.cpp:
(WebCore::StaticHashSetNodeList::itemWithName):
- dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::itemWithName):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::name):
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formControlName):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::name):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::name):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::formControlName):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- page/Frame.cpp:
(WebCore::Frame::matchLabelsAgainstElement):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
- 12:56 AM Changeset in webkit [107476] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt/Skipped: Skip tests because ENABLE(MUTATION_OBSERVERS) is disabled.
- 12:33 AM Changeset in webkit [107475] by
-
- 14 edits3 deletes in trunk/Source
Unreviewed, rolling out r107435.
http://trac.webkit.org/changeset/107435
https://bugs.webkit.org/show_bug.cgi?id=78410
It broke the Qt build (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-11
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard):
- platform/Pasteboard.h:
(WebCore):
(Pasteboard):
- platform/PasteboardStrategy.h: Removed.
- platform/PlatformPasteboard.h: Removed.
- platform/PlatformStrategies.h:
(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::canSmartReplace):
(WebCore::insertablePasteboardTypes):
(WebCore::DragData::asURL):
- platform/mac/PasteboardMac.mm:
(WebCore):
(WebCore::selectionPasteboardTypes):
(WebCore::writableTypesForURL):
(WebCore::createWritableTypesForImage):
(WebCore::writableTypesForImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeSelection):
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
(WebCore::Pasteboard::documentFragment):
- platform/mac/PlatformPasteboardMac.mm: Removed.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::addVisitedLink):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
