Timeline
Feb 15, 2012:
- 11:50 PM Changeset in webkit [107900] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix for !ENABLE(CSS_FILTERS) after r106593.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- 11:39 PM Changeset in webkit [107899] by
-
- 32 edits in trunk/Source/WebCore
Move the context invalidation code out from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=78589
Reviewed by Ryosuke Niwa.
StylePropertySet should be independent of its context so that they can in the future
be shared between documents. The context invalidation code should move to the CSSOM wrapper.
Parent rule and parent element pointers move to the CSSOM wrapper classes.
The wrapper is responsible of invalidating the element or document style on mutation.
In case of internal mutation of style attribute, StyledElement takes care of the
invalidation.
The StylePropertySet will still have a pointer to the context stylesheet so the patch
doesn't actually reduce memory usage. That pointer will be factored out later.
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
- css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::style):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::~CSSPageRule):
- css/CSSPageRule.h:
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::setDeclaration):
- css/CSSParser.cpp:
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::~CSSStyleRule):
- css/CSSStyleRule.h:
(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
- css/StylePropertySet.cpp:
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(WebCore):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureRuleCSSStyleDeclaration):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):
- css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::useStrictParsing):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::setContextStyleSheet):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
- css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::style):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::insertedIntoDocument):
(WebCore):
(WebCore::StyledElement::removedFromDocument):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::updateAttributeStyle):
- dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::destroyInlineStyleDecl):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):
- editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::updateColorSwatch):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
- html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::show):
(WebCore::MediaControlElement::hide):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
(WebCore::MediaControlInputElement::show):
(WebCore::MediaControlInputElement::hide):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterValueElement::setWidthPercentage):
- html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressValueElement::setWidthPercentage):
- html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
- 11:39 PM Changeset in webkit [107898] by
-
- 21 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r107814.
- platform/qt/css3/filters/effect-blur-hw-expected.png:
- platform/qt/css3/filters/effect-blur-hw-expected.txt:
- platform/qt/css3/filters/effect-combined-expected.png:
- platform/qt/css3/filters/effect-combined-expected.txt:
- platform/qt/css3/filters/effect-combined-hw-expected.png:
- platform/qt/css3/filters/effect-combined-hw-expected.txt:
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt:
- platform/qt/css3/filters/effect-grayscale-hw-expected.png:
- platform/qt/css3/filters/effect-grayscale-hw-expected.txt:
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.png:
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt:
- platform/qt/css3/filters/effect-invert-hw-expected.png:
- platform/qt/css3/filters/effect-invert-hw-expected.txt:
- platform/qt/css3/filters/effect-opacity-hw-expected.png:
- platform/qt/css3/filters/effect-opacity-hw-expected.txt:
- platform/qt/css3/filters/effect-saturate-hw-expected.png:
- platform/qt/css3/filters/effect-saturate-hw-expected.txt:
- platform/qt/css3/filters/effect-sepia-hw-expected.png:
- platform/qt/css3/filters/effect-sepia-hw-expected.txt:
- 11:38 PM Changeset in webkit [107897] by
-
- 2 edits in trunk
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416
Reviewed by Eric Seidel.
Source/WebCore:
This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.
Test: fast/events/drag-dataTransfer-live-attributes.html
- bindings/js/JSClipboardCustom.cpp:
(WebCore):
- bindings/v8/custom/V8ClipboardCustom.cpp:
- dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
- dom/Clipboard.h:
(WebCore):
(Clipboard):
- dom/Clipboard.idl:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().
- editing/pasteboard/clipboard-customData.html:
- editing/pasteboard/onpaste-text-html-types.html:
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
- fast/events/drag-customData.html:
- fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
- fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
- http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
- http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):
- 11:37 PM Changeset in webkit [107896] by
-
- 3 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r107606.
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::createPasteboardStrategy):
- WebCoreSupport/PlatformStrategiesWinCE.h:
(PlatformStrategiesWinCE):
- 11:28 PM Changeset in webkit [107895] by
-
- 2 edits in trunk
Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903
Source/WebCore:
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.
Test: svg/repaint/inner-svg-change-viewBox-contract.svg
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
LayoutTests:
Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
- platform/chromium/test_expectations.txt:
- svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
- svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
- svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
- 11:26 PM Changeset in webkit [107894] by
-
- 32 edits1 copy1 add in trunk
dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416
Reviewed by Eric Seidel.
Source/WebCore:
This change breaks backwards compatibility; however, since Firefox only supported
event.dataTransfer.types.contains, sites already needed to check whether to use contains or
indexOf. Therefore, the net compatibility effect of this change should be minimal.
Test: fast/events/drag-dataTransfer-live-attributes.html
- bindings/js/JSClipboardCustom.cpp:
(WebCore):
- bindings/v8/custom/V8ClipboardCustom.cpp:
- dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
- dom/Clipboard.h:
(WebCore):
(Clipboard):
- dom/Clipboard.idl:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
Add a test to document the fact that many dataTransfer attributes aren't live and return a
different object each time they're accessed. Also update tests to use contains() instead of
indexOf().
- editing/pasteboard/clipboard-customData.html:
- editing/pasteboard/onpaste-text-html-types.html:
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
- fast/events/drag-customData.html:
- fast/events/drag-dataTransfer-live-attributes-expected.txt: Added.
- fast/events/drag-dataTransfer-live-attributes.html: Copied from LayoutTests/fast/events/drag-customData.html.
- http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
- http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):
- 11:16 PM Changeset in webkit [107893] by
-
- 6 edits3 adds in trunk
Repaint issues on changing 'viewBox' of inner SVG
https://bugs.webkit.org/show_bug.cgi?id=77903
Source/WebCore:
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
Do not update the child viewbox/viewport transform to its parent
coordinate system until after layout has stored the old bounds for
repainting purposes.
Test: svg/repaint/inner-svg-change-viewBox-contract.svg
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
(WebCore):
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
(WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::setNeedsTransformUpdate):
(RenderSVGViewportContainer):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
LayoutTests:
Adding test for 77903. When setting the viewbox on an inner svg
element causes the content to become smaller, make sure that the
area behind the content is redrawn.
Patch by Bear Travis <betravis@adobe.com> on 2012-02-15
Reviewed by Nikolas Zimmermann.
- platform/chromium/test_expectations.txt:
- svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
- svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
- svg/repaint/inner-svg-change-viewBox-contract.svg: Added.
- 11:14 PM Changeset in webkit [107892] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r107811.
- platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
- platform/qt/plugins/application-plugin-plugins-disabled-expected.txt:
- platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
- platform/qt/plugins/netscape-dom-access-expected.txt:
- 11:12 PM Changeset in webkit [107891] by
-
- 3 edits in trunk/Source/WebCore
Fix unused parameter warnings.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
- 11:05 PM Changeset in webkit [107890] by
-
- 2 edits in trunk/Source/WebKit
[BlackBerry] Remove ResourceHolderImpl.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=78779
Reviewed by George Staikos.
blackberry/Api/ResourceHolderImpl.cpp which hasn't been upstreamed
has been removed internally. So remove it from the build system.
- blackberry/CMakeListsBlackBerry.txt:
- 11:04 PM Changeset in webkit [107889] by
-
- 3 edits in trunk/Source/WebCore
Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78526
Reviewed by Eric Seidel.
Revert paintColumnBorder and paintRowBorder to IntRect and pixel snap in
paint before calling them. This way the rounding logic is contained in a
single place (in paint).
No new tests, no new functionality.
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::paint):
(WebCore::RenderFrameSet::getCursor):
- rendering/RenderFrameSet.h:
(RenderFrameSet):
- 10:47 PM Changeset in webkit [107888] by
-
- 9 edits4 adds2 deletes in trunk/LayoutTests
[chromium] Unreviewed rebaseline after r107864.
- platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac-leopard/svg/text/text-text-08-b-expected.png:
- platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
- platform/chromium-mac-snowleopard/svg/text/text-text-08-b-expected.png:
- platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac/compositing/plugins/composited-plugin-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Removed.
- 10:40 PM Changeset in webkit [107887] by
-
- 16 edits5 adds in trunk/Source/WebCore
Add FractionalLayoutPoint/Size/Rect for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=76571
Reviewed by Eric Seidel.
Add fixed point versions of the Point, Size and Rect classes using
the new FractionalLayoutPoint type and.
FractionalLayoutPoint, FractionalLayoutSize and FractionalLayoutRect are
Point, Size and Rect implementations respectively using this new type.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h:
Fixed a couple of typos and signed/unsigned bugs.
- platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::FloatPoint):
Add explicit FloatPoint(FractionalLayoutPoint) constructor.
(WebCore::FloatPoint::move):
Add move(FractionalLayoutSize) implementation.
(WebCore::FloatPoint::moveBy):
Add moveBy(FractionalLayoutPoint) implementation.
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::FloatRect):
Add explicit FloatRectFractionalLayoutRect) constructor.
- platform/graphics/FloatRect.h:
(WebCore):
(FloatRect):
- platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::FloatSize):
Add explicit FloatSize(FractionalLayoutSize) constructor.
- platform/graphics/FloatSize.h:
- platform/graphics/FractionalLayoutPoint.h: Added.
- platform/graphics/FractionalLayoutRect.cpp: Added.
- platform/graphics/FractionalLayoutRect.h: Added.
- platform/graphics/FractionalLayoutSize.cpp: Added.
- platform/graphics/FractionalLayoutSize.h: Added.
- platform/graphics/IntRect.cpp:
(WebCore::IntRect::IntRect):
Add explicit IntRect(FractionalLayoutRect) constructor.
- platform/graphics/IntRect.h:
- 10:34 PM WebKitIDL edited by
- (diff)
- 10:14 PM Changeset in webkit [107886] by
-
- 9 edits2 adds in trunk
[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655
Reviewed by Enrica Casucci.
Source/WebCore:
This patch fixes the code to make a plain text for pasted file names.
The code should return a string of concatenated file names.
Test: editing/pasteboard/drag-files-to-editable-element.html
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
LayoutTests:
The added test drops multiple files onto an editable element,
and checks if the filenames are inserted into the editable element.
- editing/pasteboard/drag-files-to-editable-element-expected.txt: Added.
- editing/pasteboard/drag-files-to-editable-element.html: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 10:10 PM Changeset in webkit [107885] by
-
- 2 edits in trunk/Source/WebCore
Another attempt at fixing the Snow Leopard build.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):
- 9:57 PM Changeset in webkit [107884] by
-
- 1 edit1 move3 adds1 delete in trunk/LayoutTests
[chromium] Unreviewed rebaseline after r107864.
- platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Added.
- platform/chromium-mac/fast/canvas/text-globalAlpha-expected.txt: Removed.
- platform/chromium-win/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-win/svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/text/text-fill-opacity-expected.txt.
- 9:42 PM Changeset in webkit [107883] by
-
- 6 edits2 adds in trunk
Add support for the translate attribute in html elements.
https://bugs.webkit.org/show_bug.cgi?id=78751
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-15
Reviewed by Adam Barth.
The translate attribute is used to specify whether an element's
attribute values and the values of its Text node children are to be
translated when the page is localized, or whether to leave them
unchanged.
Details at http://www.whatwg.org/specs/web-apps/current-work/multipage/elements.html#attr-translate
Source/WebCore:
Test: fast/dom/HTMLElement/translate.html
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::translateAttributeMode):
(WebCore):
(WebCore::HTMLElement::translate):
(WebCore::HTMLElement::setTranslate):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLElement.idl:
LayoutTests:
- fast/dom/HTMLElement/translate-expected.txt: Added.
- fast/dom/HTMLElement/translate.html: Added.
- 9:39 PM WebKitIDL edited by
- (diff)
- 9:29 PM Changeset in webkit [107882] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. compositing/culling/scrolled-within-boxshadow.html IMAGE failure.
- platform/chromium/test_expectations.txt:
- 9:09 PM Changeset in webkit [107881] by
-
- 16 edits3 adds in trunk
Source/WebCore: Add -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664
Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.
Add a CSS property indicating that an element with overflow scrolling
should follow the platform's behavior for touch scrollable user
interface objects. For instance, this property could enable momentum
scrolling for the element if that is the platform convention.
The property has two possible values: auto (default) and touch. The
former does not alter overflow scrolling behavior, while the latter
activates touch scrolling.
As a side effect, enabling touch scrolling also causes an element to
gain a stacking context. This is to allow the implementation to promote
the scrolling contents into a render layer, which can be translated more
efficiently.
This property was introduced with iOS 5 WebKit. Another implementation
is in Chrome for Android.
Test: platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
Source/WebKit/chromium: Enable -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664
Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.
- features.gypi:
LayoutTests: Add stacking context test for -webkit-overflow-scrolling CSS property
https://bugs.webkit.org/show_bug.cgi?id=78664
Patch by Sami Kyostila <skyostil@google.com> on 2012-02-15
Reviewed by Eric Seidel.
Make sure a stacking context is created for elements with touch overflow scrolling.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: Added new property.
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: Ditto.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Added.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Added.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Added.
- 8:49 PM Changeset in webkit [107880] by
-
- 21 edits in trunk/Source/WebCore
Add zeroLayoutUnit constant.
https://bugs.webkit.org/show_bug.cgi?id=78747
Reviewed by Eric Seidel.
Converting call sites where LayoutUnits and raw zeros are in ternary operations
and templatized function calls (like std::max and min) to use a new zeroLayoutUnit
constant instead of the raw zero.
No new tests. No change in behavior.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
- rendering/LayoutTypes.h:
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::adjustForUnsplittableChild):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
- rendering/RenderBox.h:
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFileUploadControl.cpp:
(WebCore::nodeWidth):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset):
(WebCore::RenderListBox::verticalScrollbarWidth):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
- 8:18 PM Changeset in webkit [107879] by
-
- 10 edits2 adds in trunk
Crash after trying to use FileReader in a document with null origin string
https://bugs.webkit.org/show_bug.cgi?id=78649
Reviewed by Enrica Casucci.
Source/WebCore:
Test: fast/files/null-origin-string.html
- fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::~FileReaderLoader):
HashMaps don't like empty keys, and they don't like removing keys that have never been added.
LayoutTests:
- fast/files/null-origin-string-expected.txt: Added.
- fast/files/null-origin-string.html: Added.
Dragging files is only implemented on a few platforms. Brought some order to skipped files
for these tests:
- platform/mac/Skipped: Bug 45576 has been fixed long ago; unskip the test.
- platform/efl/Skipped:
- platform/qt/Skipped:
Skipped the new tests.
- platform/gtk-wk2/Skipped:
- platform/mac-wk2/Skipped:
- platform/win-wk2/Skipped:
- platform/wk2/Skipped:
Skipped the new tests, and moved other tests using eventSender.beginDragWithFiles to a
central location. No WK2 port implements these yet, so we needn't maintain the lists
separately.
- 7:57 PM Changeset in webkit [107878] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the Snow Leopard build.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
- 7:57 PM Changeset in webkit [107877] by
-
- 2 edits in trunk/Tools
Build fix after r107863.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
- 7:53 PM Changeset in webkit [107876] by
-
- 11 edits3 moves5 adds11 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #14 of N.
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug17138-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug17138-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120107-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12908-2-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug17138-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug196870-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug120107-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug12908-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug17138-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug196870-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- tables/mozilla/bugs/bug120107-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug120107-expected.txt.
- tables/mozilla/bugs/bug12908-2-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt.
- tables/mozilla/bugs/bug196870-expected.txt: Renamed from LayoutTests/platform/gtk/tables/mozilla/bugs/bug196870-expected.txt.
- 7:52 PM Changeset in webkit [107875] by
-
- 3 edits in trunk/Tools
[chromium] add linux dbg back to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=78752
Reviewed by Adam Barth.
This reflects the current linux debug bot name (there's only one bot).
I'm also remove the mac clang builder since it doesn't exist (mac
always uses clang now).
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- Scripts/webkitpy/layout_tests/port/builders.py:
- 7:32 PM Changeset in webkit [107874] by
-
- 7 edits in trunk/Source/WebCore
REGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing
https://bugs.webkit.org/show_bug.cgi?id=78759
Reviewed by Simon Fraser.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::boxShadowCanBeAppliedToBackground): Added. Returns false if
paintFillLayer() would push a clip before painting the layer, thus preventing it from casting
its own shadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Pass this as an additional parameter to
boxShadowShouldBeAppliedToBackground().
- rendering/InlineFlowBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass the InlineFlowBox along to
boxShadowShouldBeAppliedToBackground().
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added an InlineFlowBox
parameter. If non-0, check boxShadowCanBeAppliedToBackground(). Also check for shadow spread,
and for the case of border radius with a background image, in which paintFillLayerExtended uses
clipping. Finally, fixed a bug in the for() loop for finding the last background layer which
was noticed by Tony Chang.
- rendering/RenderBoxModelObject.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground):
- rendering/RenderTableCell.h:
- 7:27 PM Changeset in webkit [107873] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream WebPageGroupLoadDeferrer.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78770
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
- blackberry/Api/WebPageGroupLoadDeferrer.cpp: Added.
- blackberry/Api/WebPageGroupLoadDeferrer.h: Added.
- 7:18 PM Changeset in webkit [107872] by
-
- 3 edits in trunk/Tools
Add style check for ctype functions that are generally frowned upon in WebKit
https://bugs.webkit.org/show_bug.cgi?id=78748
Patch by Sam Weinig <sam@webkit.org> on 2012-02-15
Reviewed by Anders Carlsson.
Not every platform has DisallowCType.h to check for uses of the ctype.h
functions, so add a style check for them as well.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_ctype_functions):
(check_style):
(CppChecker):
Add check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_ctype_fucntion):
Add checker.
- 7:16 PM Changeset in webkit [107871] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry specific Web Inspector resources
https://bugs.webkit.org/show_bug.cgi?id=78727
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-15
Reviewed by Rob Buis.
- blackberry/WebCoreSupport/inspectorBB.html: Added.
- blackberry/WebCoreSupport/inspectorBB.js: Added.
():
(InspectorFrontendHost.copyText):
- 6:58 PM Changeset in webkit [107870] by
-
- 1 edit2 adds in trunk/Source/WebKit
Initial upstreaming of EditorClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78730
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-15
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
- blackberry/WebCoreSupport/EditorClientBlackBerry.cpp: Added.
(WebCore):
(WebCore::EditorClientBlackBerry::EditorClientBlackBerry):
(WebCore::EditorClientBlackBerry::pageDestroyed):
(WebCore::EditorClientBlackBerry::shouldDeleteRange):
(WebCore::EditorClientBlackBerry::shouldShowDeleteInterface):
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientBlackBerry::enableSpellChecking):
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleContinuousSpellChecking):
(WebCore::EditorClientBlackBerry::isGrammarCheckingEnabled):
(WebCore::EditorClientBlackBerry::toggleGrammarChecking):
(WebCore::EditorClientBlackBerry::spellCheckerDocumentTag):
(WebCore::EditorClientBlackBerry::shouldBeginEditing):
(WebCore::EditorClientBlackBerry::shouldEndEditing):
(WebCore::EditorClientBlackBerry::shouldInsertNode):
(WebCore::EditorClientBlackBerry::shouldInsertText):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::shouldApplyStyle):
(WebCore::EditorClientBlackBerry::shouldMoveRangeAfterDelete):
(WebCore::EditorClientBlackBerry::didBeginEditing):
(WebCore::EditorClientBlackBerry::respondToChangedContents):
(WebCore::EditorClientBlackBerry::respondToChangedSelection):
(WebCore::EditorClientBlackBerry::didEndEditing):
(WebCore::EditorClientBlackBerry::respondToSelectionAppearanceChange):
(WebCore::EditorClientBlackBerry::didWriteSelectionToPasteboard):
(WebCore::EditorClientBlackBerry::didSetSelectionTypesForPasteboard):
(WebCore::EditorClientBlackBerry::registerCommandForUndo):
(WebCore::EditorClientBlackBerry::registerCommandForRedo):
(WebCore::EditorClientBlackBerry::clearUndoRedoOperations):
(WebCore::EditorClientBlackBerry::canUndo):
(WebCore::EditorClientBlackBerry::canRedo):
(WebCore::EditorClientBlackBerry::canCopyCut):
(WebCore::EditorClientBlackBerry::canPaste):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):
(KeyDownEntry):
(KeyPressEntry):
(WebCore::EditorClientBlackBerry::interpretKeyEvent):
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):
(WebCore::EditorClientBlackBerry::handleInputMethodKeydown):
(WebCore::EditorClientBlackBerry::textFieldDidBeginEditing):
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):
(WebCore::EditorClientBlackBerry::doTextFieldCommandFromEvent):
(WebCore::EditorClientBlackBerry::textWillBeDeletedInTextField):
(WebCore::EditorClientBlackBerry::textDidChangeInTextArea):
(WebCore::EditorClientBlackBerry::ignoreWordInSpellDocument):
(WebCore::EditorClientBlackBerry::learnWord):
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
(WebCore::EditorClientBlackBerry::checkGrammarOfString):
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
(WebCore::EditorClientBlackBerry::textChecker):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithGrammarString):
(WebCore::EditorClientBlackBerry::updateSpellingUIWithMisspelledWord):
(WebCore::EditorClientBlackBerry::showSpellingUI):
(WebCore::EditorClientBlackBerry::spellingUIIsShowing):
(WebCore::EditorClientBlackBerry::getGuessesForWord):
(WebCore::EditorClientBlackBerry::willSetInputMethodState):
(WebCore::EditorClientBlackBerry::setInputMethodState):
- blackberry/WebCoreSupport/EditorClientBlackBerry.h: Added.
(WebKit):
(WebCore):
(EditorClientBlackBerry):
- 6:47 PM Changeset in webkit [107869] by
-
- 3 edits2 adds in trunk
Expose Window constructor
https://bugs.webkit.org/show_bug.cgi?id=78722
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/Window/window-constructor-presence.html
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/window-constructor-presence-expected.txt: Added.
- fast/dom/Window/window-constructor-presence.html: Added.
- 6:43 PM Changeset in webkit [107868] by
-
- 3 edits in trunk
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546
Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2012-02-15
Reviewed by Simon Hausmann.
Resize the web view programatically because the declarative property binding
does not work. Seems like our qml environment is not initialized fully but it
needs more investigation.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):
- 6:41 PM Changeset in webkit [107867] by
-
- 6 edits in trunk/Tools
webkitpy: add a worker_args concept to start_worker()
https://bugs.webkit.org/show_bug.cgi?id=78572
Reviewed by Tony Chang.
This change replaces the three NRWT-specific arguments passed
through the broker to the worker with a generic WorkerArguments
wrapper class and a separate set_inline_arguments() call that can
be used to pass additional data to the worker when it is running
in the same process as the manager (this is needed for testing).
With the addition of set_inline_arguments() we also no longer
need to pass an optional argument to the worker.run() call.
Note that this method is *only* implemented on inline workers,
so calling this on a regular (child process) worker will result
in a runtime error.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.init):
(AbstractWorker.run):
(_ManagerConnection.start_worker):
(_InlineManager.start_worker):
(_InlineManager.set_inline_arguments):
(_InlineManager.run_message_loop):
(_MultiProcessManager.start_worker): Reworked signature.
(_WorkerConnection.init):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.set_inline_arguments): New method.
(_InlineWorkerConnection):
(_InlineWorkerConnection.run):
(_Process.run):
(_MultiProcessWorkerConnection.init):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.init):
(_TestWorker.set_inline_arguments):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(InlineBrokerTests): New class for more testing.
(InlineBrokerTests.setUp):
(InlineBrokerTests.test_inline_arguments): New test.
(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(WorkerArguments):
(WorkerArguments.init):
(Worker.init):
(Worker.set_inline_arguments):
(Worker):
(Worker.run):
- Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
(WorkerTest.test_default_platform_in_worker):
- 6:25 PM Changeset in webkit [107866] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h
Readd std constructs for FractionalLayoutUnit on branch, for now
- 6:24 PM Changeset in webkit [107865] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/dom/ElementRareData.h
Fixing usages of INT_MAX with LayoutUnit max values.
- 6:23 PM WebKitIDL edited by
- (diff)
- 6:15 PM Changeset in webkit [107864] by
-
- 4 edits3 adds in trunk
fill-opacity does not render properly only on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=78624
Reviewed by Stephen White.
Source/WebCore:
Test: svg/text/text-fill-opacity.svg
- platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
LayoutTests:
- platform/chromium-linux/svg/text/text-fill-opacity-expected.png: Added.
- platform/chromium-linux/svg/text/text-fill-opacity-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- svg/text/text-fill-opacity.svg: Added.
- 6:02 PM Changeset in webkit [107863] by
-
- 5 edits1 add in trunk/Source
[BlackBerry] Upstream WebPageClient.h
https://bugs.webkit.org/show_bug.cgi?id=78660
Reviewed by Antonio Gomes.
Source/WebCore:
Header inclusion fix, no new test.
- plugins/blackberry/PluginViewPrivateBlackBerry.h:
Add #include <BlackBerryPlatformIntRectRegion.h>
and #include <BlackBerryPlatformGraphics.h> because they
are being removed from WebKit/blackberry/Api/WebPageClient.h.
Source/WebKit:
Initial upstreaming, no new tests.
- blackberry/Api/BackingStore.cpp: Add #include <BlackBerryPlatformWindow.h> because this inclusion
is being removed from WebPageClient.h.
- blackberry/Api/WebPageClient.h: Added.
- blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Add #include <BlackBerryPlatformWindow.h>
because this inclusion is being removed from WebPageClient.h.
- 5:50 PM Changeset in webkit [107862] by
-
- 4 edits3 adds in trunk
REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>
Reviewed by Simon Fraser.
Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).
Test: svg/text/tspan-dynamic-positioning.svg
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):
Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- svg/text/tspan-dynamic-positioning.svg: Added.
- 5:35 PM Changeset in webkit [107861] by
-
- 9 edits in trunk/Source
MediaStream API: Removing SecurityContext from the embedder API
https://bugs.webkit.org/show_bug.cgi?id=73816
Reviewed by Darin Fisher.
Source/WebCore:
Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.
- mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::PeerConnection):
- platform/mediastream/PeerConnectionHandler.h:
(WebCore):
(PeerConnectionHandler):
- platform/mediastream/gstreamer/PeerConnectionHandler.cpp:
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
Source/WebKit/chromium:
- bridge/PeerConnectionHandler.cpp:
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
- bridge/PeerConnectionHandlerInternal.cpp:
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
- bridge/PeerConnectionHandlerInternal.h:
(WebCore):
(PeerConnectionHandlerInternal):
- public/platform/WebPeerConnectionHandler.h:
(WebPeerConnectionHandler):
(WebKit::WebPeerConnectionHandler::initialize):
- 5:29 PM Changeset in webkit [107860] by
-
- 10 edits in trunk/Source/JavaScriptCore
Ensure that the DFG JIT always plants a CodeOrigin when making calls
https://bugs.webkit.org/show_bug.cgi?id=78763
Reviewed by Gavin Barraclough.
Make all calls plant a CodeOrigin prior to the actual
call. Also clobbers the Interpreter with logic to ensure
that the interpreter always plants a bytecode offset.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(CallBeginToken):
(JSC::DFG::JITCompiler::beginJSCall):
(JSC::DFG::JITCompiler::beginCall):
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
- interpreter/CallFrame.h:
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(ExecState):
(JSC::ExecState::setBytecodeOffsetForNonDFGCode):
(JSC::ExecState::codeOriginIndexForDFG):
- 5:19 PM Changeset in webkit [107859] by
-
- 5 edits in trunk
Source/WebCore: Fix test regressons from r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564
Move setting CachedRawResource::m_identifer from
data() to setResponse(). WorkerScriptLoader depends
on the identifier being set correctly during setResponse()
in order to correctly mark itself as a ScriptResource in
the inspector.
Reviewed by Adam Barth.
Fixes several worker script loading tests.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data):
(WebCore::CachedRawResource::setResponse):
LayoutTests: Remove Skipped tests that were broken by r107672.
https://bugs.webkit.org/show_bug.cgi?id=76564
Reviewed by Adam Barth.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 5:06 PM Changeset in webkit [107858] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r107704.
http://trac.webkit.org/changeset/107704
https://bugs.webkit.org/show_bug.cgi?id=78486
Caused layout test crashes in debug builds.
Specific crashing tests:
fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html
inspector/console/console-long-eval-crash.html
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):
- 4:47 PM Changeset in webkit [107857] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed. regionOverflow tests are flaky in debug.
- platform/chromium/test_expectations.txt:
- 4:45 PM Changeset in webkit [107856] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: "Copy image" fails...copies image URL instead.
https://bugs.webkit.org/show_bug.cgi?id=78723
<rdar://problem/10869104>
During the refactoring of the Pasteboard class some code was lost.
When placing an NSImage in the NSPasteboard as NSTIFFPboardType, we need
to use the its TIFF representation.
Reviewed by Andy Estes.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage):
- 4:39 PM Changeset in webkit [107855] by
-
- 1 edit1 move in trunk/Source/WebKit
[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644
Reviewed by Antonio Gomes.
No functionalities changed, no new tests.
- blackberry/Api/ActiveNodeContext.h: Renamed from Source/WebKit/blackberry/Api/BlackBerryContext.h.
- 4:27 PM Changeset in webkit [107854] by
-
- 16 edits2 copies in trunk/Source
[soup] Add support for multiple SoupSessions.
https://bugs.webkit.org/show_bug.cgi?id=77341
Source/WebCore:
Reviewed by Gustavo Noronha Silva.
Make the libsoup network backend support multiple SoupSessions. This is
accomplished by using the NetworkingContext classes, which now have a
`soupSession()' method when the libsoup backend is being used.
libsoup's ResourceHandle implementation now retrieves the SoupSession
via the NetworkingContext it receives instead of relying on
defaultSession(). defaultSession() is still used when a null
NetworkingContext is passed to ResourceHandle::start (for example, via
webkit_download_start).
The CookieJar implementation retrieves the SoupSession from the
NetworkingContext as much as possible as well -- the functions used by
WebKit2 could not be converted, though, as they seem to assume there is
only one shared cookie jar.
No new tests, covered by the existing ones.
- platform/network/NetworkingContext.h:
(NetworkingContext): Add soupSession() method if USE(SOUP) is set.
- platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal):
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForDocument):
(WebCore):
(WebCore::defaultCookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::soupSession): Add method to retrieve
a SoupSession from a NetworkingContext and fallback to defaultSession()
if there's no valid NetworkingContext.
(WebCore):
(WebCore::ensureSessionIsInitialized): Only change or use the default
cookie jar if the SoupSession being changed is the default one.
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::cancel):
(WebCore::startNonHTTPRequest):
Source/WebKit/efl:
Add the necessary infrastructure to support multiple SoupSessions. Each
WebView now has a "session" property, which defaults to
ResourceHandle::defaultSession() and can be changed to another
SoupSession by the user.
Some API in ewk_network and ewk_view which required SoupSession to be a
valid type in the headers has now been moved inside #if USE(SOUP)
ifdefs so we can actually the required Soup header and avoid build
problems with duplicate typedefs.
- CMakeListsEfl.txt:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::createNetworkingContext):
- WebCoreSupport/FrameNetworkingContextEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h.
(WebCore):
(WebCore::FrameNetworkingContextEfl::create):
(WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
(WebCore::FrameNetworkingContextEfl::soupSession):
- WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
- ewk/ewk_cookies.h: Mention this API is only valid with the
default SoupSession.
- ewk/ewk_network.cpp:
(ewk_network_default_soup_session_get): Define only if USE(SOUP) is set.
- ewk/ewk_network.h: Ditto, and mention this API is only valid with the
default SoupSession.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
- ewk/ewk_view.h:
():
Source/WebKit/gtk:
Reviewed by Gustavo Noronha Silva.
Adapt to the changes to FrameNetworkingContext in WebCore.
- GNUmakefile.am:
- WebCoreSupport/FrameNetworkingContextGtk.cpp: Copied from Source/WebKit/gtk/WebCoreSupport/FrameNetworkingContextGtk.h.
(WebKit):
(WebKit::FrameNetworkingContextGtk::soupSession): Always return ResourceHandle::defaultSession().
- WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk):
- 4:08 PM Changeset in webkit [107853] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/ScrollView.h
Removing unused methods conversion methods from ScrollView.
- 4:01 PM Changeset in webkit [107852] by
-
- 4 edits in trunk/Source/WebCore
The TileCache object should be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78757
<rdar://problem/10866161>
Reviewed by Sam Weinig.
Since the WebTileCacheLayer can be deleted on the scrolling thread, we need to make sure that the underlying
TileCache object is actually destroyed on the main thread.
- platform/graphics/ca/mac/TileCache.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::~TileCache):
Assert that this object is being destroyed on the main thread.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer dealloc]):
If dealloc is being called from a non-main thread, make sure to delete the tile cache object on the main thread.
- 3:58 PM Changeset in webkit [107851] by
-
- 14 edits in trunk/LayoutTests
[chromium] Unreviewed, rebasing tests after r107836.
- platform/chromium-linux-x86/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-linux/fast/transforms/shadows-expected.png:
- platform/chromium-mac-leopard/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-mac-leopard/fast/transforms/shadows-expected.png:
- platform/chromium-mac-snowleopard/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png:
- platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win-xp/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
- platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium/test_expectations.txt:
- 3:54 PM Changeset in webkit [107850] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Roll DEPS to r122122
https://bugs.webkit.org/show_bug.cgi?id=78754
Unreviewed DEPS roll.
- DEPS:
- 3:47 PM Changeset in webkit [107849] by
-
- 2 edits in trunk/Source/WebCore
Scrolling Coordinator must be deleted on the main thread
https://bugs.webkit.org/show_bug.cgi?id=78756
<rdar://problem/10866167>
Reviewed by Sam Weinig.
ScrollingTree::invalidate will finish breaking the cycle between the scrolling coordinator and the
scrolling tree by dereffing the scrolling coordinator. We need to make sure that this happens on the main
thread because the scrolling coordinator expects to be destroyed from there.
- page/scrolling/ScrollingTree.cpp:
(WebCore::derefScrollingCoordinator):
(WebCore):
(WebCore::ScrollingTree::invalidate):
- 3:45 PM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 3:37 PM Changeset in webkit [107848] by
-
- 5 edits in trunk/Source/WebCore
Scrolling coordinator should handle pages being restored from the page cache
https://bugs.webkit.org/show_bug.cgi?id=78753
<rdar://problem/10866171>
Reviewed by Sam Weinig.
Replace ScrollingCoordinator::frameViewScrollLayerDidChange with a new member function,
ScrollingCoordinator::frameViewRootLayerDidChange which is called whenever the root layer
of the frame view changes (which happens on back/forward navigation as well).
In this function, reset the scrolling tree state from the frame view.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::scrollLayerForFrameView):
Add a helper function.
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Reset the entire scrolling tree state.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Call the newly added helper function.
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
Remove frameViewScrollLayerDidChange.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
Remove call to ScrollingCoordinator::frameViewScrollLayerDidChange.
(WebCore::RenderLayerCompositor::attachRootLayer):
Call ScrollingCoordinator::frameViewRootLayerDidChange.
- 3:36 PM Changeset in webkit [107847] by
-
- 4 edits in branches/safari-534.54-branch/Source/WebKit2
Merge 10574154.
- 3:14 PM Changeset in webkit [107846] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add setter/getter to expose drag data as a list of items
https://bugs.webkit.org/show_bug.cgi?id=77125
This change supports the unification of the data store backing ChromiumDataObject and
DataTransferItemListChromium. ChromiumDataObject will represent dragging and clipboard data
as a list of data nodes to make it more straightforward to implement the HTML spec for
DataTransferItemList. Thus, we extend the abstraction to the webkit glue layer to
simplify the serialization/deserialization between platform-specific data and WebDragData.
The other setter/getter methods are deprecated and will be removed once the dependencies in
Chromium code are gone.
Reviewed by Darin Fisher.
- public/platform/WebDragData.h:
(WebKit):
(WebDragData):
- src/WebDragData.cpp:
(WebKit::WebDragData::items):
(WebKit):
(WebKit::WebDragData::setItems):
(WebKit::WebDragData::addItem):
- 3:10 PM Changeset in webkit [107845] by
-
- 3 edits in trunk/Source/WebKit2
Add TiledCoreAnimationDrawingArea::forceRepaint
https://bugs.webkit.org/show_bug.cgi?id=78749
<rdar://problem/10866221>
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Force a repaint and synchronize the layer tree to the UI process.
- 3:08 PM Changeset in webkit [107844] by
-
- 21 edits in trunk/Source
Refactor ClipboardMac class to use PlatformStrategies.
https://bugs.webkit.org/show_bug.cgi?id=78554
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. No change in behavior.
- WebCore.exp.in: Added new exported methods of the PlatformPasteboard class
- editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard): Use name based pasteboard references.
- page/DragClient.h:
(WebCore::DragClient::declareAndWriteDragImage): Ditto.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard): Ditto.
- platform/PasteboardStrategy.h: Added new methods to get a unique pasteboard name
and the pasteboard change count.
- platform/PlatformPasteboard.h: Ditto.
- platform/mac/ClipboardMac.h:
(WebCore::ClipboardMac::create): Using name based pasteboard.
(WebCore::ClipboardMac::pasteboardName): Replacing the old pasteboard() method.
- platform/mac/ClipboardMac.mm: All the methods below have been modified to avoid
using Objective-C types and direct access to NSPasteboard object.
(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::hasData):
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::absoluteURLsFromPasteboardFilenames):
(WebCore::absoluteURLsFromPasteboard):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writePlainText):
(WebCore::ClipboardMac::writeURL):
(WebCore::ClipboardMac::declareAndWriteDragImage):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard): Using name based pasteboard reference.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::getPathnamesForType): Fixed to support NSArray and NString content.
(WebCore::PlatformPasteboard::changeCount): Added.
(WebCore::PlatformPasteboard::uniqueName): Added.
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
- WebCoreSupport/WebDragClient.mm: Ditto.
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
- WebCoreSupport/WebPlatformStrategies.h: Added new methods.
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::changeCount):
(WebPlatformStrategies::uniqueName):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebDragClient.h: Changed method signature to reference
the pasteboard by name.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added new methods.
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Changed method signature to reference
the pasteboard by name.
- 2:48 PM Changeset in webkit [107843] by
-
- 4 edits in trunk/Source/WebCore
TileCache needs to support setting the contents scale
https://bugs.webkit.org/show_bug.cgi?id=78741
<rdar://problem/10710773>
Reviewed by Sam Weinig.
- platform/graphics/ca/mac/TileCache.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setContentsScale):
Update the contents scale of all the tiles and then revalidate the tile cache since tiles
might have come and gone as a result of setting the contents scale.
(WebCore::TileCache::createTileLayer):
Set the contents scale of the tile layer.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setContentsScale.
- 2:36 PM Changeset in webkit [107842] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Chromium build and remove a snarky comment in the process.
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::handleWheelEvent):
- 2:33 PM Changeset in webkit [107841] by
-
- 4 edits in branches/subpixellayout/Source
Add LayoutUnit version of StylePropertySet::setProperty and change DeleteButtonController to use it.
- 2:14 PM Changeset in webkit [107840] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: mark a test as no longer MISSING.
- platform/chromium/test_expectations.txt:
- 2:09 PM Changeset in webkit [107839] by
-
- 6 edits in trunk/LayoutTests
Unreviewed gardening: Fix more results after r107833.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:06 PM Changeset in webkit [107838] by
-
- 7 edits in trunk/Source/WebCore
Wheel events should be re-dispatched to the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=78731
<rdar://problem/10866144>
Reviewed by Sam Weinig.
When threaded scrolling is enabled, all the state is assumed to be kept in the scrolling tree,
on the scrolling thread. This means that even if we do end up processing an event on the main thread
(because of wheel event handlers for example), we still have to dispatch the wheel event back to the
scrolling thread.
- page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
Move wheelEvent from ScrollView and ask the scrolling coordinator to handle the wheel event.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEvent):
Dispatch the event to the scrolling thread, unless it will start a gesture. In that case we'll return false
so that information will be passed back to the UI process.
(ScrollingCoordinator):
- platform/ScrollView.cpp:
- platform/ScrollView.h:
Move wheelEvent to FrameView.
- 1:59 PM Changeset in webkit [107837] by
-
- 2 edits in trunk/Source/WebCore
RootObject::finalize can cause a crash in object->invalidate()
https://bugs.webkit.org/show_bug.cgi?id=78645
Reviewed by Geoffrey Garen.
No new tests.
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::finalize): Added a stack-allocated RefPtr to protect the RootObject
during the call to invalidate().
- 1:57 PM Changeset in webkit [107836] by
-
- 10 edits in trunk/Source/WebCore
<rdar://problem/10870238> Box shadow drawing takes an unnecessarily slow code path in some single-shadow, opaque-background cases
https://bugs.webkit.org/show_bug.cgi?id=78728
In some cases, when there is only one normal box shadow, and the box has an opaque background,
it is possible to draw the box shadow by having the background cast it directly. This appears
to be faster than the generic code path that uses a separate drawing pass to cast the shadow,
clipping out the border box and the shadow-casting box.
Reviewed by Dave Hyatt.
No new tests, because behavior is unchanged.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Ditto.
- rendering/RenderBox.h: Made determineBackgroundBleedAvoidance() protected.
- rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground): Added this helper function, which applies the first
normal shadow from the given RenderStyle to the given GraphicsContext.
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Added calls to
applyBoxShadowForBackground() before drawing the background color when needed.
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Added. Returns true
in some of the cases where the box shadow can be cast by the background directly.
- rendering/RenderBoxModelObject.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Changed to not paint normal box shadows if
they are going to be cast by the background.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground): Added this override that
always returns false, because table cells sometimes apply a clip before drawing the background.
- rendering/RenderTableCell.h:
- 1:02 PM Changeset in webkit [107835] by
-
- 1 edit1 add in trunk/LayoutTests
[chromium] Unreviewed, adding the chromium-mac result for this test (test added in r107822).
- platform/chromium-mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
- 12:30 PM Changeset in webkit [107834] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test asserting that the second argument to MutationCallback is the observer
https://bugs.webkit.org/show_bug.cgi?id=78653
Reviewed by Ryosuke Niwa.
This is specified in the spec text, so I wanted to make sure it was
properly exercised in a layout test.
- fast/mutation/callback-second-argument-expected.txt: Added.
- fast/mutation/callback-second-argument.html: Added.
- 12:26 PM Changeset in webkit [107833] by
-
- 7 edits in trunk
getComputedStyle of flex-item-align:auto should resolve to it's parent's flex-align value
https://bugs.webkit.org/show_bug.cgi?id=76326
Reviewed by Tony Chang.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
- css3/flexbox/css-properties-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 12:21 PM Changeset in webkit [107832] by
-
- 30 edits in trunk/Source
Notify ChromeClient when touch-event handlers are installed/removed.
https://bugs.webkit.org/show_bug.cgi?id=77440
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-15
Reviewed by Darin Fisher and Ryosuke Niwa.
Source/WebCore:
Keep a count of the number of touch-event handlers and notify the
embedder when the count changes. Depending on the count, the embedder
can decide whether or not to dispatch touch events to webkit.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler):
(WebCore):
(WebCore::Document::didRemoveTouchEventHandler):
- dom/Document.h:
(WebCore::Document::touchEventHandlerCount):
(Document):
- dom/Node.cpp:
(WebCore::isTouchEventType):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::numTouchEventHandlersChanged):
- page/ChromeClient.h:
(ChromeClient):
- page/Frame.cpp:
(WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
(WebCore::Frame::notifyChromeClientTouchEventHandlerCountChanged):
(WebCore):
- page/Frame.h:
(Frame):
Source/WebKit/chromium:
- public/WebViewClient.h:
(WebKit::WebViewClient::numberOfTouchEventHandlersChanged):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numTouchEventHandlersChanged):
(WebKit):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfTouchEventHandlersChanged):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::numTouchEventHandlersChanged):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::numTouchEventHandlersChanged):
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::numTouchEventHandlersChanged):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numTouchEventHandlersChanged):
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.h:
(WebKit::ChromeClientWinCE::numTouchEventHandlersChanged):
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::numTouchEventHandlersChanged):
Source/WebKit2:
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::numTouchEventHandlersChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 12:03 PM Changeset in webkit [107831] by
-
- 5 edits2 adds in trunk
Unset the active flag when TextTrackCues go away
https://bugs.webkit.org/show_bug.cgi?id=72552
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: media/track/track-active-cues.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired): Configure new text tracks before preparing to load
so we know about all tracks when resource selection begins.
(WebCore::HTMLMediaElement::prepareForLoad): Call updateActiveTextTrackCues after setting
to m_readyState is HAVE_NOTHING so all cues get deactivated. Don't build list of
available text tracks because resource selection won't actually start until after the load timer fires.
(WebCore::HTMLMediaElement::loadInternal): Build list of non-disabled tracks.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Clear the active flag on all cues
when m_readyState is HAVE_NOTHING or m_player is 0.
(WebCore::HTMLMediaElement::setReadyState): Don't update m_readyState when tracks which haven't
loaded yet will prevent events from firing. Call updateActiveTextTrackCues to ensure that the
first cue(s) are shown as soon as possible.
(WebCore::HTMLMediaElement::userCancelledLoad): Call updateActiveTextTrackCues when when m_readyState
is HAVE_NOTHING so all cues get deactivated.
LayoutTests:
- media/track/track-active-cues-expected.txt: Added.
- media/track/track-active-cues.html: Added.
- track-cue-mutable-text.html: Update to not run test until track and video have
both loaded.
- media/video-test.js:
(waitForEventsAndCall): New, call the specified function after the list of events
has been seen.
- 11:55 AM EFLWebKit edited by
- Fix info on network backends. Cite unstable dependencies requirement. (diff)
- 11:52 AM Changeset in webkit [107830] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening.
Added baseline for new test multiple-filters-invalidation.html.
- platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png: Added.
- 11:44 AM Changeset in webkit [107829] by
-
- 2 edits in trunk/LayoutTests
Stop skipping fast/filesystem/file-writer-gc-blob.html, as FileWriter is well-supported in DRT.
Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 11:43 AM Changeset in webkit [107828] by
-
- 13 edits4 adds5 deletes in trunk/LayoutTests
[chromium] Unreviewed, land chromium pixel results after r107797.
- platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- 11:37 AM Changeset in webkit [107827] by
-
- 5 edits in trunk/LayoutTests
fast/regions/element-region-overflow-state.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=78654
Reviewed by Ojan Vafai.
Sometimes layout happens before test() is called (e.g., if one of the
script or other resources take a long time to load). In that case, we
get different results. Not waiting for the load event should always
be before layout.
- fast/regions/element-region-overflow-state-expected.txt:
- fast/regions/element-region-overflow-state.html:
- fast/regions/element-region-overflow-state-vertical-rl-expected.txt
- fast/regions/element-region-overflow-state-vertical-rl.html
- 11:16 AM Changeset in webkit [107826] by
-
- 2 edits in trunk/LayoutTests
Re-specify flakiness of http/tests/filesystem/workers as PASS TIMEOUT, since they never crash.
Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 11:16 AM Changeset in webkit [107825] by
-
- 2 edits in branches/chromium/963/Source/WebCore/rendering
Merge 107024 - Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033
Reviewed by James Robinson.
There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/9405017
- 10:57 AM Changeset in webkit [107824] by
-
- 3 edits in trunk/Source/WebCore
WebCore build exceeds address space on 32-bit Windows builders (again).
https://bugs.webkit.org/show_bug.cgi?id=78724
Reviewed by Jon Honeycutt.
Add the rest of the inspector .cpp files to the InspectorAllInOne.cpp file in Production and
Release builds.
- WebCore.vcproj/WebCore.vcproj:
In the process, let VS have its way with this file.
- inspector/InspectorAllInOne.cpp:
- 10:53 AM Changeset in webkit [107823] by
-
- 12 edits in trunk/Source
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661
Reviewed by Adam Roben.
Source/WebCore:
ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(ScrollView):
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
(ScrollableArea):
Source/WebKit/chromium:
Update for WebCore changes.
- src/WebPluginContainerImpl.cpp:
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
- 10:44 AM Changeset in webkit [107822] by
-
- 4 edits3 adds in trunk
Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626
Reviewed by Darin Adler.
Test: css3/filters/multiple-filters-invalidation.html
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.
LayoutTests: New test to exercise invalidation of multiple CSS filters.
https://bugs.webkit.org/show_bug.cgi?id=78626
Reviewed by Darin Adler.
- css3/filters/multiple-filters-invalidation-expected.txt: Added.
- css3/filters/multiple-filters-invalidation.html: Added.
- platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.
- 8:09 AM Changeset in webkit [107821] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Minus" (Delete) button disappears for hovered watch expression in Watches pane
https://bugs.webkit.org/show_bug.cgi?id=78714
Reviewed by Pavel Feldman.
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._mouseOut):
- 8:01 AM Changeset in webkit [107820] by
-
- 5 edits in trunk/Source
[CMake] Move RunLoop to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=78504
Reviewed by Adam Roben.
Source/WebCore:
r105475 moved RunLoop.cpp from WebKit2 to WebCore, but missed the CMake based ports.
- CMakeLists.txt:
- PlatformWinCE.cmake:
Source/WebKit2:
- CMakeLists.txt: Remove RunLoop.cpp from list of souces.
- 7:56 AM Changeset in webkit [107819] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed Qt 4.x build fix.
- WebCoreSupport/PageClientQt.cpp: Fix the QT_VERSION_CHECK pre-processor foo.
- 7:54 AM Changeset in webkit [107818] by
-
- 3 edits in trunk/Source/WebCore
Remove clipToImageBuffer from SourceAlpha and feComposite
https://bugs.webkit.org/show_bug.cgi?id=78355
Reviewed by Nikolas Zimmermann.
The implementation of clipToImageBuffer is inefficient on
non-mac platforms, so we would benefit if remove it.
Existing tests cover this feature.
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
- platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::platformApplySoftware):
- 7:42 AM Changeset in webkit [107817] by
-
- 7 edits in trunk/Source
[Qt] Replace use of QGLWidget/QGLContext with QOpenGLContext and QSurface for Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78694
Reviewed by Noam Rosenthal.
Source/WebCore:
Typedef PlatformGraphicsContext3D and PlatformGraphicsSurface3D to QOpenGLContext
and QSurface for Qt 5. Use these APIs to change the current context and get the
procedure addresses. Removed QGraphicsObject inheritance remainder while we're at it,
because that code path is obsolete.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/cairo/OpenGLShims.cpp:
(WebCore::getProcAddress):
- platform/graphics/cairo/OpenGLShims.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
Source/WebKit/qt:
- WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget): Return the QOpenGLContext and QSurface
from the QGLWidget when compiling with Qt 5, as that's what WebCore expects.
- 7:38 AM Changeset in webkit [107816] by
-
- 4 edits1 copy in trunk/Tools
[Qt] Add UI for HTTP authentication in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=76347
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-15
Reviewed by Kenneth Rohde Christiansen.
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- MiniBrowser/qt/qml/DialogLineInput.qml:
- 7:33 AM Changeset in webkit [107815] by
-
- 7 edits in trunk/Source
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
https://bugs.webkit.org/show_bug.cgi?id=78692
Reviewed by Noam Rosenthal.
Source/WebCore:
Replace the "glWidget" term in the GraphicsContext with "surface" and delegate
the context and surface creation to the page client.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
(WebCore::GraphicsContext3DPrivate::makeCurrentIfNeeded):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
- platform/qt/QWebPageClient.h:
(QWebPageClient):
Source/WebKit/qt:
Implement GLWidget and GLContext creation from the page client interface.
- WebCoreSupport/PageClientQt.cpp:
(createPlatformGraphicsContext3DFromWidget):
(WebCore):
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):
- WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
- 7:29 AM Changeset in webkit [107814] by
-
- 12 edits20 adds in trunk
[Texmap] Support filters in TextureMapperImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=76026
Source/WebCore:
Implement GraphicsLayer::setFilters for TextureMapper, and pass the filters all the way
to BitmapTextureImageBuffer. This does not introduce a new filters implementation, but
rather uses the non-AC implementation. A complete implementation will be needed in
TextureMapperGL, which can use some of the glue in this code.
Reviewed by Kenneth Rohde Christiansen.
Unskipped 10 tests in css3/filters.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setFilters):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapper.h:
(BitmapTexture):
(WebCore::BitmapTexture::applyFilters):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore):
(WebCore::BitmapTextureImageBuffer::applyFilters):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore):
(WebCore::applyFilters):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
- platform/graphics/texmap/TextureMapperLayer.h:
(State):
LayoutTests:
Unskipping hardware filter tests. They're still skipped in WebKit2.
Reviewed by Kenneth Rohde Christiansen.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- platform/qt/css3/filters/crash-hw-sw-switch-expected.png:
- platform/qt/css3/filters/effect-blur-hw-expected.png: Added.
- platform/qt/css3/filters/effect-blur-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-combined-expected.png: Added.
- platform/qt/css3/filters/effect-combined-expected.txt: Added.
- platform/qt/css3/filters/effect-combined-hw-expected.png: Added.
- platform/qt/css3/filters/effect-combined-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.png: Added.
- platform/qt/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-grayscale-hw-expected.png: Added.
- platform/qt/css3/filters/effect-grayscale-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.png: Added.
- platform/qt/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-invert-hw-expected.png: Added.
- platform/qt/css3/filters/effect-invert-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-opacity-hw-expected.png: Added.
- platform/qt/css3/filters/effect-opacity-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-saturate-hw-expected.png: Added.
- platform/qt/css3/filters/effect-saturate-hw-expected.txt: Added.
- platform/qt/css3/filters/effect-sepia-hw-expected.png: Added.
- platform/qt/css3/filters/effect-sepia-hw-expected.txt: Added.
- 7:26 AM Changeset in webkit [107813] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Clean up fallback rendering of GraphicsContext3D to Canvas
https://bugs.webkit.org/show_bug.cgi?id=78690
Reviewed by Noam Rosenthal.
Use the common paintRenderingResultsToCanvas code to retrieve the
pixels from the FBO and use a Qt port specific paintToCanvas
implementation to wrap the pixels into a QImage and render it
into the graphics context, just like it's done for the other ports.
This removes the QGraphicsObject based paint, which is an now
obsolete method of rendering.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::paintToCanvas):
- 7:13 AM Changeset in webkit [107812] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add missing libsoup to (pkgconfig) dependency requirements
https://bugs.webkit.org/show_bug.cgi?id=78702
Unreviewed build fix.
Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-15
- ewebkit.pc.in: Now that bug 77874 had its patch landed, we
always require libsoup as a dependency for the EFL port. The
'Require' session of this file has to contemplate that, otherwise
code linking with ewebkit will fail to lookup to libsoup's header
files.
- 6:14 AM Changeset in webkit [107811] by
-
- 28 edits in trunk/Source
[Qt] Eliminate first set of QtWidgets dependencies from WebCore
https://bugs.webkit.org/show_bug.cgi?id=78611
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
- bindings/js/ScriptControllerQt.cpp: Remove unused include.
- page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::tabsToAllFormControls): Replace import
of private Qt(Widgets) variable with the default of Qt 5, where
it is also not configurable.
- platform/ContextMenu.h: Remove unused include.
- platform/ContextMenuItem.h: Ditto.
- platform/Widget.h: Use QObject as type for PlatformWidget
instead of QWidget.
- platform/graphics/Icon.h:
(Icon): Prefer QImage over QIcon for storage.
- platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
(WebCore): Make it compile with QWindow for Qt 5 and QWidget for Qt 4.
- platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(FullScreenVideoWindow::showFullScreen):
(PlatformVideoWindow::PlatformVideoWindow):
- platform/graphics/qt/IconQt.cpp: Revert the implementation of this class
back to notImplemented(). It was trying to load the actual file as QIcon
instead of trying to find a symbolic icon for the given file. We should
probably use the QMimeType API in Qt 5 once it becomes available.
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):
- platform/graphics/qt/ImageQt.cpp:
(graphics): Remove use of QStyle for retrieving icons. Code moved to
WebCoreSupport instead.
- platform/qt/ContextMenuQt.cpp: Removed unused include.
- platform/qt/PlatformScreenQt.cpp: Add #ifdefs to use QScreen API
with Qt 5.
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/qt/QWebPageClient.h: Add hook for showing/hiding widget.
(WebCore):
(QWebPageClient):
- platform/qt/SoundQt.cpp:
(WebCore::systemBeep): Beep is not implemented in Qt 5 and its use is
questionable. Move back to notImplemented() until proper QPA API becomes
available in Qt 5 (if ever...).
- platform/qt/WidgetQt.cpp: Delegate QWidget specific show/hide calls
to the PageClient, out of WebCore.
(WebCore::Widget::Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
- plugins/PluginView.h: Remove unused include.
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject): When dumping properties of
QWidget, use the QObject property API to retrieve the values instead of
QWidget specific API. Removed the mask from the dump as it's not available
as property and our layout tests don't seem to use it.
Source/WebKit/qt:
- Api/qwebpage.cpp: Add missing includes.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
- WebCoreSupport/FrameLoaderClientQt.cpp: Make it compile by casting
the QObject based PlatformWidget back to QWidget before doing QWidget
specific function calls.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt): Moved QStyle specific web-graphic initialization
here from WebCore.
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setWidgetVisible): Implement show/hiding of widgets
through delegation to QWidget.
(WebCore):
(WebCore::PageClientQGraphicsWidget::setWidgetVisible): Provide empty widget
show/hide implementation, as it doesn't seem to make sense for graphicsviews.
- WebCoreSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
- UIProcess/qt/QtWebPageEventHandler.cpp: Add missing QCursor include
to fix compilation.
- 6:11 AM Changeset in webkit [107810] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Fix minor design issues in the Spectrum color picker
https://bugs.webkit.org/show_bug.cgi?id=78693
Drive-by: frontend compilability fixes.
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/compile-front-end.sh:
- inspector/front-end/ElementsPanel.js:
- inspector/front-end/Popover.js:
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get isVisible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/elementsPanel.css:
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
- inspector/front-end/inspector.css:
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):
- 6:09 AM Changeset in webkit [107809] by
-
- 2 edits in trunk
[CMake] Remove unused PkgConfig module import from FindCFLite.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78600
Reviewed by Adam Roben.
- Source/cmake/FindCFLite.cmake:
- 6:05 AM Changeset in webkit [107808] by
-
- 3 edits in trunk/Source/WebCore
2012-02-15 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix after r107806
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFunctionWithEvalEnabled):
- inspector/InjectedScript.h: (InjectedScript):
- 5:59 AM Changeset in webkit [107807] by
-
- 12 edits2 adds2 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #13 of N.
- platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10565-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug11026-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.png: Removed.
- platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium/test_expectations.txt:
- 5:55 AM Changeset in webkit [107806] by
-
- 4 edits2 adds in trunk
Web Inspector: crash when inspecting an element on a page with eval disabled by CSP
https://bugs.webkit.org/show_bug.cgi?id=78705
Source/WebCore:
Inspector functions in injected script may use eval so we need to make sure
it is allowed for inspector code on pages where it is prohibited by CSP.
Reviewed by Pavel Feldman.
Test: inspector/elements/resolve-node-blocked.html
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
(WebCore):
(WebCore::InjectedScript::makeCall):
- inspector/InjectedScript.h:
(InjectedScript):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/elements/resolve-node-blocked-expected.txt: Added.
- inspector/elements/resolve-node-blocked.html: Added.
- 5:39 AM Changeset in webkit [107805] by
-
- 7 edits8 adds60 deletes in trunk/LayoutTests
Clean up radio button tests
https://bugs.webkit.org/show_bug.cgi?id=78679
Reviewed by Kentaro Hara.
- Split checkbox-radio-onchange.html into checkbox-onchange.html and radio/radio-onchange.html.
- Convert the following rendering tests to text tests. radio-attr-order.html radio-nested-labels.html radio_checked.html radio_checked_dynamic.html
This change is a preparation of moving radio button tests to fast/forms/radio/.
- fast/forms/checkbox-onchange-expected.txt: Added.
- fast/forms/checkbox-onchange.html: Added.
- fast/forms/checkbox-radio-onchange.html: Removed.
- fast/forms/radio-attr-order-expected.txt: Added.
- fast/forms/radio-attr-order.html:
- fast/forms/radio-nested-labels-expected.txt: Added.
- fast/forms/radio-nested-labels.html:
- fast/forms/radio/radio-onchange-expected.txt: Added.
- fast/forms/radio/radio-onchange.html: Added.
- fast/forms/radio_checked-expected.txt: Added.
- fast/forms/radio_checked.html:
- fast/forms/radio_checked_dynamic-expected.txt: Added.
- fast/forms/radio_checked_dynamic.html:
- platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio-attr-order-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio_checked-expected.png: Removed.
- platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio-attr-order-expected.png: Removed.
- platform/chromium-win/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/chromium-win/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio_checked-expected.png: Removed.
- platform/chromium-win/fast/forms/radio_checked-expected.txt: Removed.
- platform/chromium-win/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/chromium-win/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/efl/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/efl/fast/forms/radio-attr-order-expected.png: Removed.
- platform/efl/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/efl/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/efl/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/efl/fast/forms/radio_checked-expected.png: Removed.
- platform/efl/fast/forms/radio_checked-expected.txt: Removed.
- platform/efl/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/efl/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/gtk/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/gtk/fast/forms/radio-attr-order-expected.png: Removed.
- platform/gtk/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/gtk/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/gtk/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/gtk/fast/forms/radio_checked-expected.png: Removed.
- platform/gtk/fast/forms/radio_checked-expected.txt: Removed.
- platform/gtk/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/gtk/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/mac-leopard/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio-attr-order-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio_checked-expected.png: Removed.
- platform/mac-leopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked-expected.txt: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/mac-snowleopard/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/mac/fast/forms/checkbox-radio-onchange-expected.png: Removed.
- platform/mac/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/mac/fast/forms/radio-attr-order-expected.png: Removed.
- platform/mac/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/mac/fast/forms/radio-nested-labels-expected.png: Removed.
- platform/mac/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/mac/fast/forms/radio_checked-expected.png: Removed.
- platform/mac/fast/forms/radio_checked-expected.txt: Removed.
- platform/mac/fast/forms/radio_checked_dynamic-expected.png: Removed.
- platform/mac/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- platform/qt-mac/Skipped:
- platform/qt/fast/forms/checkbox-radio-onchange-expected.txt: Removed.
- platform/qt/fast/forms/radio-attr-order-expected.txt: Removed.
- platform/qt/fast/forms/radio-nested-labels-expected.txt: Removed.
- platform/qt/fast/forms/radio_checked-expected.txt: Removed.
- platform/qt/fast/forms/radio_checked_dynamic-expected.txt: Removed.
- 5:18 AM Changeset in webkit [107804] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar
https://bugs.webkit.org/show_bug.cgi?id=71262
Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-13
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/Settings.js:
- inspector/front-end/Spectrum.js: Added.
(WebInspector.Spectrum.hueDrag):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.alphaDrag):
(WebInspector.Spectrum):
(WebInspector.Spectrum.hsvaToRGBA):
(WebInspector.Spectrum.rgbaToHSVA):
(WebInspector.Spectrum.draggable.prevent):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):
(WebInspector.Spectrum.draggable.stop):
(WebInspector.Spectrum.draggable):
(WebInspector.Spectrum.prototype.set color):
(WebInspector.Spectrum.prototype.get color):
(WebInspector.Spectrum.prototype.get outputColorFormat):
(WebInspector.Spectrum.prototype.get colorHueOnly):
(WebInspector.Spectrum.prototype.set displayText):
(WebInspector.Spectrum.prototype._onchange):
(WebInspector.Spectrum.prototype._updateHelperLocations):
(WebInspector.Spectrum.prototype._updateUI):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.reposition):
(WebInspector.Spectrum.prototype.hide):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
(.swatch):
(.swatch-inner):
(.spectrum-container):
(.spectrum-top):
(.spectrum-color):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container):
(.spectrum-range-container *):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.swatch, .spectrum-dragger, .spectrum-slider):
(.spectrum-sat):
(.spectrum-val):
(.spectrum-dragger):
(.spectrum-slider):
- inspector/front-end/inspector.html:
- 5:06 AM Changeset in webkit [107803] by
-
- 5 edits in trunk/Source
Source/WebCore: [Qt] Be smarter with tile usages during tiling
https://bugs.webkit.org/show_bug.cgi?id=78243
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.
The keep rect used to know what existing tiles to keep around, is now a
padding (in tile dimensions) around the usual cover rect. With usual,
I mean to point out that we take our panning optimization into account.
We also do a good effort at keeping the amount of tiles steady, by not
simply intersecting our areas with the contentRect, but moving it
first into legal bounds and then expanding in opposite direction to
cover a similar amount of pixels.
In the future the cover area should be calculated given available
system memory.
- platform/graphics/TiledBackingStore.cpp:
(WebCore):
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
Source/WebKit/qt: [Qt] Be smarted with tile usages during tiling
https://bugs.webkit.org/show_bug.cgi?id=78243
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2012-02-15
Reviewed by Simon Hausmann.
Remove internal API used by Symbian.
- Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):
- 4:54 AM Changeset in webkit [107802] by
-
- 89 edits32 adds in trunk/LayoutTests
2012-02-15 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update SnowLeopard SVG pixel test baseline - chunk 1.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
- platform/mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
- platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png:
- platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
- platform/mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
- platform/mac-snowleopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
- platform/mac-snowleopard/svg/as-object/embedded-svg-size-changes-expected.png:
- platform/mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
- platform/mac-snowleopard/svg/batik/filters/feTile-expected.png:
- platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
- platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
- platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png:
- platform/mac-snowleopard/svg/batik/text/textEffect-expected.png:
- platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png:
- platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
- platform/mac-snowleopard/svg/carto.net/window-expected.png:
- platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
- platform/mac-snowleopard/svg/css/shadow-changes-expected.png:
- platform/mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
- platform/mac-snowleopard/svg/custom/convolution-crash-expected.png: Added.
- platform/mac-snowleopard/svg/custom/createImageElement-expected.png: Added.
- platform/mac-snowleopard/svg/custom/createImageElement2-expected.png:
- platform/mac-snowleopard/svg/custom/empty-merge-expected.png: Added.
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
- platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png: Added.
- platform/mac-snowleopard/svg/custom/focus-ring-expected.png:
- platform/mac-snowleopard/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/mac-snowleopard/svg/custom/getTransformToElement-expected.png:
- platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
- platform/mac-snowleopard/svg/custom/group-opacity-expected.png:
- platform/mac-snowleopard/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/mac-snowleopard/svg/custom/hit-test-with-br-expected.png:
- platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png:
- platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png:
- platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
- platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png:
- platform/mac-snowleopard/svg/custom/mask-invalidation-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png:
- platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
- platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png:
- platform/mac-snowleopard/svg/custom/recursive-filter-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-content-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
- platform/mac-snowleopard/svg/custom/relative-sized-inner-svg-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-use-on-symbol-expected.png:
- platform/mac-snowleopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
- platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac-snowleopard/svg/custom/text-filter-expected.png: Added.
- platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png:
- platform/mac-snowleopard/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-clipped-hit-expected.png:
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
- platform/mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.png:
- platform/mac-snowleopard/svg/custom/use-elementInstance-methods-expected.png:
- platform/mac-snowleopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
- platform/mac-snowleopard/svg/custom/use-event-handler-on-use-element-expected.png:
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
- platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
- platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png: Added.
- platform/mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
- platform/mac-snowleopard/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
- 4:19 AM Changeset in webkit [107801] by
-
- 16 edits2 adds in trunk
Web Inspector: [InspectorIndexedDB] Pass data entries from object stores and indexes to front-end.
https://bugs.webkit.org/show_bug.cgi?id=78503
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/indexeddb/database-data.html
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):
- bindings/js/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore):
(WebCore::InjectedScript::canAccessInspectedWindow):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::assertFrame):
(WebCore::assertDocument):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/InspectorIndexedDBAgent.h:
(WebCore):
(WebCore::InspectorIndexedDBAgent::create):
(InspectorIndexedDBAgent):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
(WebInspector.IndexedDBModel.keyFromIDBKey):
(WebInspector.IndexedDBModel.keyRangeFromIDBKeyRange):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.Entry):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype._requestData.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype._requestData):
(WebInspector.IndexedDBRequestManager.prototype.requestObjectStoreData):
(WebInspector.IndexedDBRequestManager.prototype._objectStoreDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestIndexData):
(WebInspector.IndexedDBRequestManager.prototype._indexDataLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DataRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):
(WebInspector.IndexedDBDispatcher.prototype.objectStoreDataLoaded):
(WebInspector.IndexedDBDispatcher.prototype.indexDataLoaded):
LayoutTests:
- http/tests/inspector/indexeddb/database-data-expected.txt: Added.
- http/tests/inspector/indexeddb/database-data.html: Added.
- http/tests/inspector/indexeddb/database-names-expected.txt:
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest.evaluateWithCallback):
(initialize_IndexedDBTest.InspectorTest.addIDBValue):
(initialize_IndexedDBTest):
(doWithReadWriteTransaction.step2.innerCommitCallback):
(doWithReadWriteTransaction.step2):
(doWithReadWriteTransaction):
(addIDBValue.doWithReadWriteTransaction.withTransactionCallback):
(addIDBValue):
- 3:47 AM Changeset in webkit [107800] by
-
- 2 edits in trunk/Tools
[Qt] Fix WebGL in QtTestBrowser
Reviewed by Tor Arne Vestbø.
- QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
the options for enabling GL we also pass them on properly.
- 3:37 AM Changeset in webkit [107799] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(r107518): DeviceOrientationController doesn't remove registered DOMWindows
https://bugs.webkit.org/show_bug.cgi?id=78683
Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-15
Reviewed by Kentaro Hara.
A copy-n-paste disaster. This change fixed it by calling correct methods.
No new tests. Needs browser side mocking for testing this.
A Chromium automated test covers this.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
- page/Page.cpp:
(WebCore::Page::provideSupplement):
(WebCore::Page::requireSupplement):
- page/Page.h: Fix typo.
(Page):
- 3:28 AM Changeset in webkit [107798] by
-
- 2 edits in trunk/LayoutTests
2012-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, change the encoding of a test HTML.
- fast/forms/radio-nested-labels.html: Convert from UTF-16 to UTF-8.
- 2:49 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:48 AM Changeset in webkit [107797] by
-
- 1095 edits1 delete in trunk/LayoutTests
Switch svg/dynamic-updates tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78219
Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.
This is the last step, all svg tests have been converted.
The only relevant change to look at is svg/dynamic-updates/resources/SVGTestCase.js, the rest is mechanic, done by a script.
Ran following magic in svg/dynamic-updates: (inject repaint.js in all *.html files in that folder, and register onload handler)
find . -type f -name "*.html" | xargs perl -pi -e "s/js-test-pre\.js\"><\/script\>/js-test-pre\.js\"><\/script\>\n\<script src=\"..\/..\/fast\/repaint\/resources\/repaint\.js\"\>\<\/script\>/"
find . -type f -name "*.html" | xargs perl -pi -e "s/<body>/<body onload=\"runRepaintTest()\">/"
And in svg/dynamic-updates/script-tests: (remove manual startTest function calls, and rename executeTest to repaintTest).
find . -type f -name "*.js" | xargs perl -pi -e "s/startTest\(.*\);\n"
find . -type f -name "*.js" | xargs perl -pi -e "s/function\ executeTest/function\ repaintTest/"
Only a few tests needed other adjustments.
- platform/chromium/test_expectations.txt:
- svg/animations/resources/SVGAnimationTestCase.js:
(runSMILTest):
...
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
...
- svg/dynamic-updates/SVG-dynamic-css-transform.html:
- svg/dynamic-updates/SVGAElement-dom-href-attr.html:
...
- svg/dynamic-updates/resources/SVGTestCase.js: Changed to utilize the repaint.js harness.
(createSVGTestCase):
(clickAt):
- svg/dynamic-updates/resources/linkTarget.svg:
- svg/dynamic-updates/script-tests/SVGAElement-dom-href-attr.js:
(repaintTest):
- svg/dynamic-updates/script-tests/SVGAElement-dom-target-attr.js:
(repaintTest):
...
- svg/dynamic-updates/script-tests/TEMPLATE.html: Removed.
- 2:30 AM Changeset in webkit [107796] by
-
- 2 edits in trunk/Source/WebCore
2012-02-15 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed, quick build fix for 107792
- inspector/DOMEditor.cpp: (WebCore::DOMEditor::RemoveAttributeAction::redo):
- 1:52 AM Changeset in webkit [107795] by
-
- 2 edits in trunk/LayoutTests
2012-02-15 Kent Tamura <tkent@chromium.org>
Unreviewed, correct svn:mime-type of a test.
- fast/forms/radio-nested-labels.html: Modified property svn:mime-type from application/octet-stream to text/html.
- 1:24 AM Changeset in webkit [107794] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Don't use increased FontCache size on Android
https://bugs.webkit.org/show_bug.cgi?id=78656
Reviewed by Adam Barth.
The chromium port uses a larger font cache size because it increases
performance on the intl1 and intl2 page cyclers. However, on Android
devices where resources are more constrained, it isn't desireable to
allow the FontCache to grow so big.
No new tests because no testable difference in functionality.
- platform/graphics/FontCache.cpp:
(WebCore):
- 1:17 AM Changeset in webkit [107793] by
-
- 20 edits2 adds in trunk
<style scoped>: Allow <style scoped> as a direct child of a ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=77853
.:
numberOfScopedHTMLStyleChildren got moved from Element into Node.
Reviewed by Dimitri Glazkov.
- Source/autotools/symbols.filter:
Source/WebCore:
Moved registration code from Element to Node. updated Internals and build files accordingly.
Moved registration data members from ElementRareData to NodeRareData.
Forward willRemove() from host element into shadow DOM tree.
Reviewed by Dimitri Glazkov.
Test: fast/css/style-scoped/registering-shadowroot.html
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::willRemove):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore):
(WebCore::Node::hasScopedHTMLStyleChild):
(WebCore::Node::numberOfScopedHTMLStyleChildren):
(WebCore::Node::registerScopedHTMLStyleChild):
(WebCore::Node::unregisterScopedHTMLStyleChild):
- dom/Node.h:
(Node):
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):
(WebCore::NodeRareData::registerScopedHTMLStyleChild):
(WebCore::NodeRareData::unregisterScopedHTMLStyleChild):
(WebCore::NodeRareData::hasScopedHTMLStyleChild):
(WebCore::NodeRareData::numberOfScopedHTMLStyleChildren):
- dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::willRemove):
(WebCore):
- dom/ShadowRootList.h:
(ShadowRootList):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
- testing/Internals.cpp:
(WebCore::Internals::numberOfScopedHTMLStyleChildren):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
numberOfScopedHTMLStyleChildren got moved from Element into Node.
Reviewed by Dimitri Glazkov.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
Test registration of <style scoped> as a direct child of a ShadowRoot.
Reviewed by Dimitri Glazkov.
- fast/css/style-scoped/registering-shadowroot-expected.txt: Added.
- fast/css/style-scoped/registering-shadowroot.html: Added.
- 1:12 AM Changeset in webkit [107792] by
-
- 25 edits in trunk
Web Inspector: implement redo for DOM actions.
https://bugs.webkit.org/show_bug.cgi?id=78601
Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-14
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/DOMEditor.cpp:
(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::redo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::InsertBeforeAction::redo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::redo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::redo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetOuterHTMLAction::redo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::redo):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::perform):
(WebCore::DOMEditor::ReplaceChildNodeAction::redo):
(DOMEditor::ReplaceChildNodeAction):
(WebCore::DOMEditor::SetNodeValueAction::perform):
(WebCore::DOMEditor::SetNodeValueAction::redo):
(DOMEditor::SetNodeValueAction):
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::redo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::redo):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::redo):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::perform):
(WebCore::InspectorCSSAgent::SetRuleSelectorAction::redo):
(InspectorCSSAgent::SetRuleSelectorAction):
(WebCore::InspectorCSSAgent::AddRuleAction::perform):
(WebCore::InspectorCSSAgent::AddRuleAction::redo):
(InspectorCSSAgent::AddRuleAction):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::redo):
(WebCore):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore):
- inspector/InspectorHistory.h:
(Action):
(InspectorHistory):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._undoRedoRequested):
(WebInspector.CSSStyleModel.prototype._undoRedoCompleted):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.get undo):
(WebInspector.DOMAgent.prototype.redo):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.generateUndoTest):
- inspector/elements/undo-dom-edits-2-expected.txt:
- inspector/elements/undo-dom-edits-expected.txt:
- inspector/styles/undo-add-new-rule-expected.txt:
- inspector/styles/undo-add-new-rule.html:
- inspector/styles/undo-add-property-expected.txt:
- inspector/styles/undo-add-property.html:
- inspector/styles/undo-change-property-expected.txt:
- inspector/styles/undo-change-property.html:
- inspector/styles/undo-property-toggle-expected.txt:
- inspector/styles/undo-property-toggle.html:
- inspector/styles/undo-set-selector-text-expected.txt:
- inspector/styles/undo-set-selector-text.html:
- 12:59 AM Changeset in webkit [107791] by
-
- 105 edits in trunk/LayoutTests
2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Rubber-stamped by Simon Hausmann.
Further cleanup of the svg/animation tests. Always use "0.001" as sampling time
for "just-after-anim-begin" instead of 0.1/0.01 variations. Use "3.999" as
"just-before-anim-end" time instead of 3.9/3.99 variations.
Use a default tolerance of 0.1, instead of the strict 0.01, to avoid having
to expect values like "199.98". Use "200" instead. That doesn't reduce the
value of any of the tests, but its likely to be more stable.
Changed some real-quick running animamtions to have a higher duration.
This minimizes the sampling time error when sampling the animation right after
it started (svg/animation/*nested-transforms*). This doesn't affect the runtime
of the tests at all, as we manually drive the timeline anyways.
Always use shouldBe() instead of shouldBeCloseEnough() if the sampling time
is an integer, like 2.0 for animations that eg. animate x from 0 to 200.
Sampling exactly at 2.0, yields 100, so there's no need to check for equal
with tolerance.
- platform/chromium/test_expectations.txt:
- svg/animations/animate-calcMode-spline-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-to-expected.txt:
- svg/animations/animate-calcMode-spline-to-expected.txt:
- svg/animations/animate-calcMode-spline-values-expected.txt:
- svg/animations/animate-path-animation-Cc-Ss-expected.txt:
- svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
- svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
- svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
- svg/animations/animate-path-nested-transforms-expected.txt:
- svg/animations/animate-path-to-animation-expected.txt:
- svg/animations/animate-text-nested-transforms-expected.txt:
- svg/animations/resources/SVGAnimationTestCase.js: (shouldBeCloseEnough):
- svg/animations/script-tests/animVal-basics.js: (sample3):
- svg/animations/script-tests/animate-calcMode-spline-by.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-from-by.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-from-to.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-to.js: (sample2): (sample3):
- svg/animations/script-tests/animate-calcMode-spline-values.js: (sample2): (sample3):
- svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js: (executeTest):
- svg/animations/script-tests/animate-dynamic-update-attributeName.js: (executeTest):
- svg/animations/script-tests/animate-end-attribute.js: (sample3):
- svg/animations/script-tests/animate-mpath-insert.js: (endSample): (executeTest):
- svg/animations/script-tests/animate-path-animation-Cc-Ss.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-Qq-Tt.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: (sample2): (sample3): (sample4):
- svg/animations/script-tests/animate-path-nested-transforms.js: (endSample): (executeTest):
- svg/animations/script-tests/animate-path-to-animation.js: (sample2): (sample3):
- svg/animations/script-tests/animate-text-nested-transforms.js: (endSample): (executeTest):
- svg/animations/script-tests/animateTransform-pattern-transform.js: (sample3):
- svg/animations/script-tests/svgangle-animation-deg-to-grad.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-deg-to-rad.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-deg.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-grad-to-rad.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-deg.js: (sample2): (sample3):
- svg/animations/script-tests/svgangle-animation-rad-to-grad.js: (sample2): (sample3):
- svg/animations/script-tests/svginteger-animation-1.js: (sample3):
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-number-to-number.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-cm.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-ems.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-exs.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-in.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-number.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-pc.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-pt.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-px-to-px.js: (sample2): (sample3):
- svg/animations/script-tests/svglength-animation-values.js: (sample2): (sample3): (sample4): (sample5):
- svg/animations/script-tests/svglengthlist-animation-1.js: (sample3):
- svg/animations/script-tests/svglengthlist-animation-2.js: (sample2): (sample3):
- svg/animations/script-tests/svglengthlist-animation-3.js: (sample2): (sample3):
- svg/animations/script-tests/svglengthlist-animation-4.js: (sample3):
- svg/animations/script-tests/svglengthlist-animation-5.js: (sample3):
- svg/animations/script-tests/svgnumber-animation-1.js: (sample3):
- svg/animations/script-tests/svgnumber-animation-2.js: (sample3):
- svg/animations/script-tests/svgnumberlist-animation-1.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberlist-animation-2.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js: (sample2): (sample3):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js: (sample2): (sample3):
- svg/animations/script-tests/svgpath-animation-1.js: (sample2): (sample3):
- svg/animations/script-tests/svgpointlist-animation-1.js: (sample3):
- svg/animations/script-tests/svgpointlist-animation-2.js: (sample3):
- svg/animations/script-tests/svgrect-animation-1.js: (sample3):
- svg/animations/script-tests/svgrect-animation-2.js: (sample3):
- svg/animations/script-tests/svgtransform-animation-1.js: (sample1): (sample2): (sample3):
- svg/animations/script-tests/svgtransform-animation-discrete.js: (sample1): (sample2): (sample3):
- svg/animations/svgangle-animation-deg-to-grad-expected.txt:
- svg/animations/svgangle-animation-deg-to-rad-expected.txt:
- svg/animations/svgangle-animation-grad-to-deg-expected.txt:
- svg/animations/svgangle-animation-grad-to-rad-expected.txt:
- svg/animations/svgangle-animation-rad-to-deg-expected.txt:
- svg/animations/svgangle-animation-rad-to-grad-expected.txt:
- svg/animations/svglength-animation-LengthModeHeight-expected.txt:
- svg/animations/svglength-animation-LengthModeOther-expected.txt:
- svg/animations/svglength-animation-LengthModeWidth-expected.txt:
- svg/animations/svglength-animation-number-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-cm-expected.txt:
- svg/animations/svglength-animation-px-to-ems-expected.txt:
- svg/animations/svglength-animation-px-to-exs-expected.txt:
- svg/animations/svglength-animation-px-to-in-expected.txt:
- svg/animations/svglength-animation-px-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-pc-expected.txt:
- svg/animations/svglength-animation-px-to-percentage-expected.txt:
- svg/animations/svglength-animation-px-to-pt-expected.txt:
- svg/animations/svglength-animation-px-to-px-expected.txt:
- svg/animations/svglength-animation-values-expected.txt:
- svg/animations/svglengthlist-animation-2-expected.txt:
- svg/animations/svgnumberlist-animation-1-expected.txt:
- svg/animations/svgnumberlist-animation-2-expected.txt:
- svg/animations/svgpath-animation-1-expected.txt:
- svg/animations/svgpointlist-animation-1-expected.txt:
- svg/animations/svgpointlist-animation-2-expected.txt:
- svg/animations/svgrect-animation-1-expected.txt:
- svg/animations/svgrect-animation-2-expected.txt:
- svg/animations/svgtransform-animation-1-expected.txt:
- 12:53 AM Changeset in webkit [107790] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107785 and r107762. Also
skipping a new SVG failure.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-zoom-expected.txt:
- 12:45 AM Changeset in webkit [107789] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Unreviewed morning gardening.
- 12:43 AM Changeset in webkit [107788] by
-
- 5 edits4 adds in trunk
WebSocket: MessageEvent fired during send() on workers
https://bugs.webkit.org/show_bug.cgi?id=76521
Reviewed by David Levin.
Source/WebCore:
WebSocket's message event should not be invoked while a synchronous operation
(send() and bufferedAmount) is in progress.
Test: http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Added #if ENABLE(WORKERS) because ThreadableWebSocketChannelClientWrapper is not used
if Web Workers is not available.
Changed access label because private members were declared as protected with no good reason.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
Receive ScriptExecutionContext so we can post a task that should be executed later.
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
LayoutTests:
- http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op-expected.txt: Added.
- http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html: Added.
- http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op.js:
Added. The server sends messages immediately after the connection is established, but
these messages should not be delivered until the script exits the current cycle of
the event loop. The script calls a few synchronous operations to make sure we don't
fire MessageEvents while we are waiting for these operations to finish.
- http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op_wsh.py: Added.
- 12:26 AM Changeset in webkit [107787] by
-
- 17 edits2 moves in trunk/Source
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660
Source/WebCore:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
No new tests.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setParent):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::removeFromParent):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::syncCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::layer):
- platform/graphics/texmap/TextureMapperLayer.cpp: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp.
(WebCore):
(WebCore::toTextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::clearBackingStoresRecursive):
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paint):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::compareGraphicsLayersZValue):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::syncCompositingState):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::syncAnimationsRecursively):
- platform/graphics/texmap/TextureMapperLayer.h: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.h.
(WebCore):
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setTextureMapper):
(WebCore::TextureMapperLayer::setShouldUpdateBackingStoreFromLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(WebCore::TextureMapperLayer::backingStore):
(WebCore::TextureMapperLayer::texture):
(WebCore::TextureMapperLayer::layerRect):
(State):
(WebCore::TextureMapperLayer::State::State):
Source/WebKit/gtk:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
Source/WebKit/qt:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
- Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
- Api/qwebframe.h:
(WebCore):
- Api/qwebframe_p.h:
(WebCore):
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):
- WebCoreSupport/PageClientQt.cpp:
(WebCore::TextureMapperLayerClientQt::TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
(WebCore::TextureMapperLayerClientQt::~TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
(WebCore::TextureMapperLayerClientQt::rootLayer):
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
(TextureMapperLayerClientQt):
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- 12:21 AM Changeset in webkit [107786] by
-
- 3 edits in trunk/Source/WebCore
ShadowRoot: Remove a public static factory function which doesn't have any callers.
https://bugs.webkit.org/show_bug.cgi?id=78668
Reviewed by Kent Tamura.
No tests. No change in behavior.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(ShadowRoot):
- 12:04 AM Changeset in webkit [107785] by
-
- 9 edits2 moves2 adds6 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #11 of N.
- platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
- platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Removed.
- platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
- platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/image-rescale-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png.
- platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Removed.
- platform/chromium-mac/svg/custom/image-rescale-expected.png: Removed.
- platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
- platform/chromium-win/svg/custom/image-rescale-expected.png:
- platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/svg/custom/image-rescale-expected.txt: Removed.
- platform/qt/svg/custom/image-rescale-expected.txt: Removed.
- svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/image-rescale-expected.txt.
Feb 14, 2012:
- 11:03 PM Changeset in webkit [107784] by
-
- 5 edits in trunk
Cleanup pending transaction queue in Database.
https://bugs.webkit.org/show_bug.cgi?id=75048
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-14
Reviewed by David Levin.
Source/WebCore:
Each SQLTransaction has 3 SQLCallbackWrappers, and each of them
holds a ref to WorkerContext. As a result, if the worker thread is
stopped before all SQLTransactions are finished, the ASSERT of
m_workerContext->hasOneRef() in WorkerThread::workerThread() would fail.
No new tests.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts
- storage/Database.cpp:
(WebCore::Database::close): Cleanup pending transaction queue in close().
- storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(SafeReleaseTask): Make SafeReleaseTask a cleanup task, which is
necessary because at the time of SafeReleaseTask is performed,
WorkerRunLoop has been terminated and only runs cleanup tasks.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
LayoutTests:
As crash is fixed, trun BUGWK75048 into BUGWK75111, so that we can
close 75048 and fix the timeout in 75111 for both DEBUG and RELEASE.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts
- platform/chromium/test_expectations.txt:
- 10:58 PM Changeset in webkit [107783] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=78662
CSSStyleSelector should not rely on parent rule pointer in StylePropertySet
Reviewed by Andreas Kling.
Pass the rule pointer down to the style applying so we don't need to rely on
StylePropertySet having one.
To make this easier the patch also refactors the matched properties vector to
be part of MatchResult object instead of a member of CSSStyleSelector.
Rename Declaration -> Properties.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::matchUserRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyProperties):
(WebCore::CSSStyleSelector::applyMatchedProperties):
(WebCore::CSSStyleSelector::computeMatchedPropertiesHash):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addToMatchedPropertiesCache):
(WebCore::CSSStyleSelector::invalidateMatchedPropertiesCache):
(WebCore::isCacheableInMatchedPropertiesCache):
(WebCore::CSSStyleSelector::matchPageRules):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::MatchedProperties::MatchedProperties):
(MatchedProperties):
(MatchResult):
(MatchedPropertiesCacheItem):
- 10:56 PM Changeset in webkit [107782] by
-
- 3 edits1 add in trunk/Source/WebKit/chromium
Provide SocketStreamHandleInternal::toWebSocketStreamHandle(SocketStreamHandle*).
https://bugs.webkit.org/show_bug.cgi?id=78581
Reviewed by Kent Tamura.
Now, there is no way to convert SocketStreamHandle to
WebSocketStreamHandle. In subsequent changes, I'll use this function
in FrameLoaderClientImpl.
- src/SocketStreamHandle.cpp: Remove SocketStreamHandleInternal class declaration.
- src/SocketStreamHandleInternal.h: Move SocketStreamHandleInternal class declaration from SocketStreamHandle.cpp to expose, and add conversion function to WebSocketStreamHandle from SocketStreamHandle.
(WebKit):
(WebCore):
(SocketStreamHandleInternal):
(WebCore::SocketStreamHandleInternal::create):
(WebCore::SocketStreamHandleInternal::toWebSocketStreamHandle):
- WebKit.gyp: Add SocketStreamHandleInternal.h entry.
- 10:56 PM Changeset in webkit [107781] by
-
- 62 edits64 deletes in trunk/LayoutTests
Stop using script-tests in LayoutTests/fast/forms
https://bugs.webkit.org/show_bug.cgi?id=78667
Reviewed by Kentaro Hara.
- fast/forms/ValidityState-patternMismatch-unsupported.html:
- fast/forms/ValidityState-rangeOverflow.html:
- fast/forms/ValidityState-rangeUnderflow.html:
- fast/forms/ValidityState-stepMismatch.html:
- fast/forms/ValidityState-tooLong-input.html:
- fast/forms/ValidityState-tooLong-textarea.html:
- fast/forms/ValidityState-typeMismatch-date-expected.txt: Removed.
- fast/forms/ValidityState-typeMismatch-url.html:
- fast/forms/ValidityState-valueMissing-radio.html:
- fast/forms/checkValidity-cancel.html:
- fast/forms/checkValidity-handler-updates-dom.html:
- fast/forms/form-attribute-elements-order.html:
- fast/forms/form-attribute-elements-order2.html:
- fast/forms/form-attribute-elements.html:
- fast/forms/form-attribute.html:
- fast/forms/form-collection-elements-order.html:
- fast/forms/form-collection-elements.html:
- fast/forms/formnovalidate-attribute.html:
- fast/forms/incremental-dom-property.html:
- fast/forms/input-maxlength-ime-completed.html:
- fast/forms/input-maxlength-ime-preedit.html:
- fast/forms/input-maxlength-unsupported.html:
- fast/forms/input-minmax.html:
- fast/forms/input-pattern.html:
- fast/forms/input-step.html:
- fast/forms/input-stepup-stepdown.html:
- fast/forms/input-type-change3.html:
- fast/forms/input-valueasnumber-unsupported.html:
- fast/forms/labels-add-htmlFor-label.html:
- fast/forms/labels-add-parent-label.html:
- fast/forms/labels-change-htmlFor-attribute.html:
- fast/forms/labels-item-index.html:
- fast/forms/labels-remove-htmlFor-attribute.html:
- fast/forms/labels-remove-htmlFor-label.html:
- fast/forms/labels-remove-parent-label.html:
- fast/forms/labels-set-htmlFor-attribute.html:
- fast/forms/listbox-deselect-scroll.html:
- fast/forms/listbox-selection-2.html:
- fast/forms/listbox-selection.html:
- fast/forms/menulist-disabled-selected-option.html:
- fast/forms/menulist-submit-without-selection.html:
- fast/forms/novalidate-attribute.html:
- fast/forms/output-reset-assertion-failed.html:
- fast/forms/placeholder-dom-property.html:
- fast/forms/script-tests/TEMPLATE.html: Removed.
- fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Removed.
- fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed.
- fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed.
- fast/forms/script-tests/ValidityState-stepMismatch.js: Removed.
- fast/forms/script-tests/ValidityState-tooLong-input.js: Removed.
- fast/forms/script-tests/ValidityState-tooLong-textarea.js: Removed.
- fast/forms/script-tests/ValidityState-typeMismatch-date.js: Removed.
- fast/forms/script-tests/ValidityState-typeMismatch-url.js: Removed.
- fast/forms/script-tests/ValidityState-valueMissing-radio.js: Removed.
- fast/forms/script-tests/checkValidity-cancel.js: Removed.
- fast/forms/script-tests/checkValidity-handler-updates-dom.js: Removed.
- fast/forms/script-tests/form-attribute-elements-order.js: Removed.
- fast/forms/script-tests/form-attribute-elements-order2.js: Removed.
- fast/forms/script-tests/form-attribute-elements.js: Removed.
- fast/forms/script-tests/form-attribute.js: Removed.
- fast/forms/script-tests/form-collection-elements-order.js: Removed.
- fast/forms/script-tests/form-collection-elements.js: Removed.
- fast/forms/script-tests/formnovalidate-attribute.js: Removed.
- fast/forms/script-tests/incremental-dom-property.js: Removed.
- fast/forms/script-tests/input-maxlength-ime-completed.js: Removed.
- fast/forms/script-tests/input-maxlength-ime-preedit.js: Removed.
- fast/forms/script-tests/input-maxlength-unsupported.js: Removed.
- fast/forms/script-tests/input-minmax.js: Removed.
- fast/forms/script-tests/input-pattern.js: Removed.
- fast/forms/script-tests/input-step.js: Removed.
- fast/forms/script-tests/input-stepup-stepdown.js: Removed.
- fast/forms/script-tests/input-type-change3.js: Removed.
- fast/forms/script-tests/input-valueasnumber-unsupported.js: Removed.
- fast/forms/script-tests/labels-add-htmlFor-label.js: Removed.
- fast/forms/script-tests/labels-add-parent-label.js: Removed.
- fast/forms/script-tests/labels-change-htmlFor-attribute.js: Removed.
- fast/forms/script-tests/labels-item-index.js: Removed.
- fast/forms/script-tests/labels-remove-htmlFor-attribute.js: Removed.
- fast/forms/script-tests/labels-remove-htmlFor-label.js: Removed.
- fast/forms/script-tests/labels-remove-parent-label.js: Removed.
- fast/forms/script-tests/labels-set-htmlFor-attribute.js: Removed.
- fast/forms/script-tests/listbox-deselect-scroll.js: Removed.
- fast/forms/script-tests/listbox-selection-2.js: Removed.
- fast/forms/script-tests/listbox-selection.js: Removed.
- fast/forms/script-tests/menulist-disabled-selected-option.js: Removed.
- fast/forms/script-tests/menulist-submit-without-selection.js: Removed.
- fast/forms/script-tests/novalidate-attribute.js: Removed.
- fast/forms/script-tests/output-reset-assertion-failed.js: Removed.
- fast/forms/script-tests/placeholder-dom-property.js: Removed.
- fast/forms/script-tests/search-cancel-button-events.js: Removed.
- fast/forms/script-tests/select-set-length-optgroup.js: Removed.
- fast/forms/script-tests/select-set-length-with-mutation-remove.js: Removed.
- fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Removed.
- fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Removed.
- fast/forms/script-tests/select-set-length-with-mutation.js: Removed.
- fast/forms/script-tests/select-set-length.js: Removed.
- fast/forms/script-tests/setCustomValidity-existence.js: Removed.
- fast/forms/script-tests/shadow-tree-exposure.js: Removed.
- fast/forms/script-tests/submit-form-attributes.js: Removed.
- fast/forms/script-tests/text-control-intrinsic-widths.js: Removed.
- fast/forms/script-tests/textarea-maxlength.js: Removed.
- fast/forms/script-tests/textarea-metrics.js: Removed.
- fast/forms/script-tests/textarea-placeholder-dom-property.js: Removed.
- fast/forms/script-tests/textarea-rows-cols.js: Removed.
- fast/forms/script-tests/textarea-textlength.js: Removed.
- fast/forms/script-tests/validationMessage.js: Removed.
- fast/forms/script-tests/willvalidate.js: Removed.
- fast/forms/search-cancel-button-events.html:
- fast/forms/select-set-length-optgroup.html:
- fast/forms/select-set-length-with-mutation-remove.html:
- fast/forms/select-set-length-with-mutation-reorder.html:
- fast/forms/select-set-length-with-mutation-reparent.html:
- fast/forms/select-set-length-with-mutation.html:
- fast/forms/select-set-length.html:
- fast/forms/setCustomValidity-existence.html:
- fast/forms/shadow-tree-exposure.html:
- fast/forms/submit-form-attributes.html:
- fast/forms/text-control-intrinsic-widths.html:
- fast/forms/textarea-maxlength.html:
- fast/forms/textarea-metrics.html:
- fast/forms/textarea-placeholder-dom-property.html:
- fast/forms/textarea-rows-cols.html:
- fast/forms/textarea-textlength.html:
- fast/forms/validationMessage.html:
- fast/forms/willvalidate.html:
- 10:39 PM Changeset in webkit [107780] by
-
- 5 edits in trunk/Source/WebCore
WebSocketChannel minor refactoring for code manageability
https://bugs.webkit.org/show_bug.cgi?id=78576
Reviewed by Kent Tamura.
Change the first argument type of WebSocketChannel
from ScriptExecutionContext to Document.
WebSocketChannel always assume this ScriptExecutionContext must
inherit Document. Then, it results in many static cast.
It isn't readable and dangerous against future code changes.
- websockets/ThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.
(WebCore::ThreadableWebSocketChannel::create):
- websockets/WebSocketChannel.cpp: Replace all ScriptExecutionContext* m_context descriptions to Document* m_document.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
- websockets/WebSocketChannel.h: Change the first argument for construction to Document and hold it as Document m_document.
(WebCore):
(WebCore::WebSocketChannel::create):
(WebSocketChannel):
- websockets/WorkerThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
- 10:00 PM Changeset in webkit [107779] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r107774.
http://trac.webkit.org/changeset/107774
https://bugs.webkit.org/show_bug.cgi?id=78661
Broke Chromium build
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/ScrollAnimator.cpp:
(WebCore):
(WebCore::ScrollAnimator::handleGestureEvent):
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(ScrollView):
- platform/ScrollableArea.cpp:
(WebCore):
(WebCore::ScrollableArea::handleGestureEvent):
- platform/ScrollableArea.h:
(ScrollableArea):
- 9:19 PM Changeset in webkit [107778] by
-
- 7 edits3 deletes in trunk/Source
Unreviewed, rolling out r107766.
http://trac.webkit.org/changeset/107766
https://bugs.webkit.org/show_bug.cgi?id=78665
Breaks Chromium Win build (Requested by bashi1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14
Source/WebCore:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- websockets/WebSocketDeflater.cpp: Removed.
- websockets/WebSocketDeflater.h: Removed.
Source/WebKit/chromium:
- WebKit.gypi:
- tests/WebSocketDeflaterTest.cpp: Removed.
- 9:10 PM Changeset in webkit [107777] by
-
- 9 edits2 adds2 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #10 of N.
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
- platform/chromium/test_expectations.txt:
- 8:13 PM Changeset in webkit [107776] by
-
- 2 edits in trunk/Tools
Add #include of unistd.h on the mac for getcwd.
Reviewed by Anders Carlsson.
This is necessary when building with libc++.
- WebKitTestRunner/TestInvocation.cpp:
- 8:10 PM Changeset in webkit [107775] by
-
- 3 edits in trunk/Tools
In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
https://bugs.webkit.org/show_bug.cgi?id=78663
Reviewed by Anders Carlsson.
- DumpRenderTree/DumpRenderTreePrefix.h:
- DumpRenderTree/cg/ImageDiffCG.cpp:
- 7:56 PM Changeset in webkit [107774] by
-
- 8 edits in trunk/Source/WebCore
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661
Reviewed by Sam Weinig.
ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/ScrollAnimator.cpp:
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h:
(ScrollView):
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
(ScrollableArea):
- 7:42 PM Changeset in webkit [107773] by
-
- 2758 edits1243 copies52 adds402 deletes in branches/subpixellayout
Merging trunk changes up until 107734 into subpixel branch.
- 7:22 PM Changeset in webkit [107772] by
-
- 9 edits2 adds in trunk
[JSC] Cache the number of non-custom constructor arguments
https://bugs.webkit.org/show_bug.cgi?id=78195
Reviewed by Darin Adler.
Source/WebCore:
If [ConstructorParameters=] is specified, JSC caches the number of constructor
arguments for performance. However, at present, [ConstructorParameters=] is specified
on a small part of constructors (It appears that people have forgotten to
add [ConstructorParameters=]). Thus, for non-custom constructors, this patch modifies
CodeGeneratorJS.pm so that it caches the number of constructor arguments automatically
without [ConstructorParameters=] (CodeGeneratorJS.pm can know the number of arguments
by the [Constructor=...] signature).
Test: fast/js/constructor-length.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
LayoutTests:
The added tests check the length property of constructors.
The test fails for "flag-disabled" constructors.
- fast/js/constructor-length.html: Added.
- platform/mac/fast/js/constructor-length-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 7:04 PM Changeset in webkit [107771] by
-
- 2 edits in trunk/Source/WebCore
<http://webkit.org/b/78658> platformUserPreferredLanguages is leaking all of the language codes
Reviewed by Darin Adler.
- platform/mac/Language.mm:
(WebCore::httpStyleLanguageCode): Switch to using RetainPtr's for temporaries to make the ownership
more explicit. Switch to returning a WTF::String so that the caller doesn't have to worry about
ownership at all. Change the name to reflect the lack of transfer of ownership.
(WebCore::platformUserPreferredLanguages):
- 6:20 PM Changeset in webkit [107770] by
-
- 2 edits in trunk/Source/WebCore
[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655
Reviewed by Hajime Morita.
Although the bots have been working fine, PasteboardMac.mm build fails
in our local Mac environments due to an uninitialized variable:
/Users/haraken/WebKit/Source/WebCore/platform/mac/PasteboardMac.mm:322: warning: 'string' may be used uninitialized in this function
This patch initializes the 'string' to nil to fix the build failure.
No tests. No change in behavior.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
- 6:11 PM Changeset in webkit [107769] by
-
- 16 edits in trunk/Source
[WebSocket] Add extension attribute support
https://bugs.webkit.org/show_bug.cgi?id=78557
Source/WebCore:
Implement WebSocket "extensions" attribute that holds a list of
extension the server accepted. No change in behavior at this time
because we don't send any extension on handshake.
Reviewed by Kent Tamura.
No new tests. http/tests/websocket/tests/hybi/extensions.html checks the value of this attribute.
- websockets/ThreadableWebSocketChannel.h: Add extensions().
(ThreadableWebSocketChannel):
- websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions): Added.
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Added.
- websockets/ThreadableWebSocketChannelClientWrapper.h:
(ThreadableWebSocketChannelClientWrapper):
- websockets/WebSocket.cpp: Added m_extensions member variable.
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::extensions): Returns m_extensions.
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::extensions): Added.
(WebCore):
- websockets/WebSocketChannel.h:
(WebSocketChannel):
- websockets/WebSocketExtensionDispatcher.cpp:
(WebCore::WebSocketExtensionDispatcher::fail): Added.
(WebCore::WebSocketExtensionDispatcher::processHeaderValue): Stores accepted extensions.
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
(WebCore):
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
- websockets/WebSocketExtensionDispatcher.h:
(WebSocketExtensionDispatcher):
- websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::acceptedExtensions): Added.
(WebCore):
- websockets/WebSocketHandshake.h:
- websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::extensions): Added.
(WebCore):
(WebCore::workerContextDidConnect): Calls ThreadableWebSocketChannelClientWrapper::setExtensions().
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect): Passes extensions as an argument.
- websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Source/WebKit/chromium:
Add WebSocketExtensionDispatcher::acceptedExtensions() checks.
Reviewed by Kent Tamura.
- tests/WebSocketExtensionDispatcherTest.cpp:
(WebCore::TEST_F):
- 6:05 PM Changeset in webkit [107768] by
-
- 33 edits in trunk/Source/WebCore
Rename [JSGenerateToJS] to [JSGenerateToJSObject]
https://bugs.webkit.org/show_bug.cgi?id=78490
Reviewed by Adam Barth.
This patch renames [JSGenerateToJS] to [JSGenerateToJSObject],
for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- dom/WebKitNamedFlow.idl:
- fileapi/DirectoryEntry.idl:
- fileapi/DirectoryEntrySync.idl:
- fileapi/File.idl:
- fileapi/FileEntry.idl:
- fileapi/FileEntrySync.idl:
- html/DOMFormData.idl:
- html/DOMSettableTokenList.idl:
- html/DOMURL.idl:
- html/MediaController.idl:
- mediastream/LocalMediaStream.idl:
- webaudio/AudioBufferCallback.idl:
- webaudio/AudioBufferSourceNode.idl:
- webaudio/AudioDestinationNode.idl:
- webaudio/AudioGain.idl:
- webaudio/AudioGainNode.idl:
- webaudio/AudioPannerNode.idl:
- webaudio/AudioProcessingEvent.idl:
- webaudio/BiquadFilterNode.idl:
- webaudio/ConvolverNode.idl:
- webaudio/DelayNode.idl:
- webaudio/DynamicsCompressorNode.idl:
- webaudio/HighPass2FilterNode.idl:
- webaudio/JavaScriptAudioNode.idl:
- webaudio/LowPass2FilterNode.idl:
- webaudio/MediaElementAudioSourceNode.idl:
- webaudio/OfflineAudioCompletionEvent.idl:
- webaudio/RealtimeAnalyserNode.idl:
- webaudio/WaveShaperNode.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- 6:04 PM Changeset in webkit [107767] by
-
- 13 edits1 move in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #9 of N.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium/test_expectations.txt:
- 6:02 PM Changeset in webkit [107766] by
-
- 7 edits3 adds in trunk/Source
Source/WebCore: [WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449
Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.
Reviewed by Kent Tamura.
No new tests except for chromium port. Behavior is unchanged.
- GNUmakefile.list.am: Added.WebSocketDeflater.(cpp|h).
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- websockets/WebSocketDeflater.cpp: Added.
(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):
- websockets/WebSocketDeflater.h: Added.
(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):
Source/WebKit/chromium: [WebSocket] Add deflater/inflater classes.
https://bugs.webkit.org/show_bug.cgi?id=78449
Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.
Reviewed by Kent Tamura.
- WebKit.gypi:
- tests/WebSocketDeflaterTest.cpp: Added.
(WebCore):
(WebCore::TEST):
- 5:50 PM Changeset in webkit [107765] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Fixing up more border painting logic that should be integers instead of layout types.
- 5:47 PM Changeset in webkit [107764] by
-
- 1 edit3 adds in trunk/Source/WebKit
[BlackBerry] Upstreaming WebSettings code
https://bugs.webkit.org/show_bug.cgi?id=78633
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
- blackberry/Api/WebSettings.cpp: Added.
- blackberry/Api/WebSettings.h: Added.
- blackberry/Api/WebSettings_p.h: Added.
- 5:34 PM Changeset in webkit [107763] by
-
- 4 edits in trunk/Source
[chromium] Compare filters on impl thread when setting them, and test setting in unit tests
https://bugs.webkit.org/show_bug.cgi?id=78643
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Source/WebCore:
Add setFilters() coverage to CCLayerImplTest.cpp
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setFilters):
Source/WebKit/chromium:
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- 5:34 PM Changeset in webkit [107762] by
-
- 16 edits in trunk/LayoutTests
Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634
Unreviewed layouttest rebaselining.
- platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
- platform/chromium-gpu-linux/media/video-zoom-expected.png:
- platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
- platform/chromium-gpu-mac/media/video-zoom-expected.png:
- platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
- platform/chromium-gpu-win/media/video-zoom-expected.png:
- platform/chromium-linux/media/video-controls-rendering-expected.png:
- platform/chromium-linux/media/video-zoom-expected.png:
- platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
- platform/chromium-mac-leopard/media/video-zoom-expected.png:
- platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
- platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-zoom-expected.png:
- platform/chromium/test_expectations.txt:
- 5:23 PM Changeset in webkit [107761] by
-
- 3 edits2 adds in trunk
Crash in deleteInsignificantText
https://bugs.webkit.org/show_bug.cgi?id=78567
Reviewed by Eric Seidel.
Source/WebCore:
Fix the crash. Also update layout at the beginning of each call to deleteInsignificantText
since the previous call may have mutated the DOM.
Test: editing/inserting/delete-insignificant-text-crash.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
LayoutTests:
Add a regression test.
- editing/inserting/delete-insignificant-text-crash.html: Added.
- editing/inserting/delete-insignificant-text-crash.txt: Added.
- 5:20 PM Changeset in webkit [107760] by
-
- 6 edits in trunk/Source/WebCore
Prepare RenderLayerBacking and RenderLayerCompositor for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78630
Reviewed by Simon Fraser.
In our transition to subpixel layout in the render tree, we continue to pass RenderLayerBacking
and RenderLayerCompositor integer (pixel) sizes and positions. This patch moves nearly all
methods and members on these two classes back to integers, and applies pixel snapping logic to
LayoutUnits pulled in.
No new tests. No change in behavior.
- rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedLayoutOverflowRect): Convenience function for getting pixel
snapped overflow bounds.
- rendering/RenderLayerBacking.cpp:
(WebCore):
(WebCore::RenderLayerBacking::updateCompositedBounds): Switch to integers and pixel snapping the
clipping bounds.
(WebCore::clipBox): Returns a pixel snapped rect.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Using pixelSnappedLayerCoords. Removing
pixelSnappedIntRect calls to clipBox since this is now an IntRect.
(WebCore::RenderLayerBacking::computeTransformOrigin): Switching to operate on a pixel snapped rect.
(WebCore::RenderLayerBacking::computePerspectiveOrigin): Ditto.
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Returns a size based on m_compositingBounds,
which is now an IntSize.
(WebCore::RenderLayerBacking::contentsBox): Switching to use pixel snapped values from the render tree.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): This now takes in and outputs integers.
(WebCore::RenderLayerBacking::paintIntoLayer): Uses a pixel snapped rect for the dirty rect.
(WebCore::paintScrollbar): Scrollbars are Widgets & painted natively, so they should use integers.
(WebCore::RenderLayerBacking::paintContents): We now properly take in an integer clip rect, as it's
used for the scrollbars.
(WebCore::RenderLayerBacking::startAnimation): Using pixel snapped values for animations and transitions.
(WebCore::RenderLayerBacking::startTransition): Ditto.
(WebCore::RenderLayerBacking::compositedBounds): Composited bounds are now properly stored as integers.
(WebCore::RenderLayerBacking::setCompositedBounds): Ditto.
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Composited bounds are pixel snapped, but
we use LayoutUnits up until we snap and return.
(WebCore::RenderLayerCompositor::addToOverlapMap): Overlap mapping uses our integer positions. Switching
it back to operating on them.
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive): Ditto.
(WebCore::RenderLayerCompositor::overlapsCompositedLayers): Ditto.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Using integers.
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation): FrameViews are on integer bounds. We now
properly use these as integers.
(WebCore::RenderLayerCompositor::frameViewDidScroll): Ditto.
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Switching to use integers and
pixelSnappedLayerCoords.
(WebCore::RenderLayerCompositor::repaintCompositedLayersAbsoluteRect): Ditto.
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Using integer positions, which are what
the apis used already returned.
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Using pixel snapped values.
(WebCore::RenderLayerCompositor::requiresCompositingForFrame): Ditto.
(WebCore::paintScrollbar): Scrollbars should always use integers.
(WebCore::RenderLayerCompositor::paintContents): Switching to use an integer clip rect.
(WebCore::RenderLayerCompositor::ensureRootLayer): Using values from new pixelSnappedLayoutOverflowRect
method on RenderBox to ensure we're using values that are pixel snapped to the proper location.
(WebCore::RenderLayerCompositor::destroyRootLayer): Properly calling scrollbar invalidation methods
with integers.
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 5:16 PM Changeset in webkit [107759] by
-
- 5 edits3 adds3 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #8 of N.
- platform/chromium-mac-snowleopard/fast/writing-mode/background-horizontal-bt-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-lr-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-rl-expected.png: Added.
- platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png: Removed.
- platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png: Removed.
- platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
- platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
- platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
- platform/chromium/test_expectations.txt:
- 5:08 PM Changeset in webkit [107758] by
-
- 8 edits in trunk/Source
Swipe gestures don't work if main frame has a horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=78650
<rdar://problem/10864993>
Reviewed by Sam Weinig.
Source/WebCore:
Change ScrollingTree::tryToHandleWheelEvent so we can indicate that an event was
processed by the scrolling tree but that we should indicate back to WebKit that it wasn't handled.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::tryToHandleWheelEvent):
If the wheel event will start a swipe gesture, return DidNotHandleEvent.
(WebCore::ScrollingTree::updateBackForwardState):
This can now be called from any thread, so use a mutex.
(WebCore::ScrollingTree::setMainFramePinState):
New function that will set the current main frame pin state.
(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Put locks around these.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Helper function that returns whether the given wheel event will start a swipe gesture
because the main frame is pinned to the left/right and we can go back/forward.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Call updateMainFramePinState if the frame geometry changes.
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Call updateMainFramePinState.
(WebCore::ScrollingTreeNodeMac::updateMainFramePinState):
Compute the main frame pin state and set it on the scrolling tree.
Source/WebKit2:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
ScrollingTree::tryToHandleWheelEvent now returns a tri-state enum so handle the extra case.
(WebKit::EventDispatcher::sendDidReceiveEvent):
Rename this now that it takes a parameter indicating whether the event was handled or not.
- 5:05 PM Changeset in webkit [107757] by
-
- 13 edits in trunk/Source
Source/WebCore: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641
Reviewed by Timothy Hatcher.
- WebCore.exp.in: Add a new function to be exported.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::showResources): Call showResources on load.
- inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.showResources): Show the resources panel.
Source/WebKit2: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641
Add WebKit2 API for the ability to show the resources panel. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showResources.
Reviewed by Timothy Hatcher.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorShowResources): Call WebInspectorProxy::showResources.
- UIProcess/API/C/WKInspector.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::showResources): Send a message to the web process.
- UIProcess/WebInspectorProxy.h:
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::showResources): Call InspectorFrontendClientLocal::showResources.
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in: Add a ShowResources message.
- 5:00 PM Changeset in webkit [107756] by
-
- 2 edits in trunk/Tools
Implement an adb-based driver for the ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78627
Reviewed by Eric Seidel.
This driver mostly just wires up the ChromiumDriver through adb. In
some cases, it translates protocol elements, such as URIs, so that the
rest of webkitpy is insulated from the "remoteness" of the target device.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._driver_class):
(ChromiumAndroidPort._update_version):
(ChromiumAndroidPort._get_stderr):
(ChromiumAndroidPort):
(ChromiumAndroidPort._get_last_stacktrace):
(ChromiumAndroidPort._teardown_performance):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._test_shell_command):
(ChromiumAndroidDriver._write_command_and_read_line):
(ChromiumAndroidDriver._output_image):
(ChromiumAndroidDriver._has_crash_hint):
- 4:57 PM Changeset in webkit [107755] by
-
- 3 edits in trunk/Tools
webkitpy: the real_name() method in the Port class is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=78651
Reviewed by Eric Seidel.
The change in bug 78565 / r107718 made it no longer necessary
(we can use options.platform instead).
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.name):
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.init):
- 4:36 PM Changeset in webkit [107754] by
-
- 5 edits in trunk/Tools
webkitpy: clean up options, port handling in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78568
Reviewed by Tony Chang.
manager_worker_broker no longer needs options or port objects
directly, so we make them only be passed in start_worker().
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(_ManagerConnection.init):
(_ManagerConnection.start_worker):
(_InlineManager.init):
(_InlineManager.start_worker):
(_InlineManager.run_message_loop):
(_MultiProcessManager.init):
(_MultiProcessManager):
(_MultiProcessManager.start_worker):
(_InlineWorkerConnection.init):
(_InlineWorkerConnection.run):
(_Process.init):
(_MultiProcessWorkerConnection.init):
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(make_broker):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(MultiProcessBrokerTests.setUp):
(InterfaceTest.test_managerconnection_is_abstract):
- Scripts/webkitpy/layout_tests/controllers/message_broker.py:
(Broker.init):
- 4:35 PM Changeset in webkit [107753] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r107568-r107627): Crash when copying in WebCore::SharedBuffer::hasPlatformData().
https://bugs.webkit.org/show_bug.cgi?id=78577
Reviewed by Dan Bernstein.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setBufferForType): Missing null check when
setting data to the NSPasteboard.
- 4:26 PM Changeset in webkit [107752] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix Interpreter.
- 4:11 PM Changeset in webkit [107751] by
-
- 1 edit1 add in trunk/Tools
nrwt: add a unit test for regression introduced in bug 78565
https://bugs.webkit.org/show_bug.cgi?id=78646
Reviewed by Tony Chang.
- Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
(FakeConnection):
(FakeConnection.run_message_loop):
(FakeConnection.post_message):
(WorkerTest):
(WorkerTest.test_default_platform_in_worker):
- 4:11 PM Changeset in webkit [107750] by
-
- 1 edit5 adds in trunk/Source/WebKit
[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/Api/BlackBerryContext.h: Added.
- blackberry/Api/BlackBerryGlobal.cpp: Added.
- blackberry/Api/BlackBerryGlobal.h: Added.
- blackberry/Api/Version.cpp: Added.
- blackberry/Api/Version.h: Added.
- 3:54 PM Changeset in webkit [107749] by
-
- 3 edits2 adds in trunk
Crash in WebCore::SVGElement::removedFromDocument
https://bugs.webkit.org/show_bug.cgi?id=77270
Reviewed by Adam Barth.
Source/WebCore:
Add a protector before calling NodeRemovalDispatcher::dispatch since
NodeRemovalDispatcher::dispatch may remove the last RefPtr to this node.
Test: fast/dom/Range/surround-contents-font-face-crash.svg
- dom/ContainerNodeAlgorithms.h:
(WebCore::Private::addChildNodesToDeletionQueue):
LayoutTests:
Add a regression test for the crash.
- fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added.
- fast/dom/Range/surround-contents-font-face-crash.svg: Added.
- 3:40 PM Changeset in webkit [107748] by
-
- 8 edits in trunk/Source
Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=78629
Reviewed by David Kilzer.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 3:26 PM Changeset in webkit [107747] by
-
- 6 edits1 delete in trunk
[CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78566
Reviewed by Daniel Bates.
.:
- Source/cmake/FindEFL.cmake: Move the code to find edje_cc here from
WebKitEfl.cmake.
- Source/cmake/WebKitEfl.cmake: Removed.
Source/WebKit/efl:
- CMakeListsEfl.txt: Do not include WebKitEfl.cmake.
Source/WebKit2:
- PlatformEfl.cmake: Do not include WebKitEfl.cmake.
- 3:20 PM Changeset in webkit [107746] by
-
- 2 edits in trunk/Tools
NRWT is broken for the default port
https://bugs.webkit.org/show_bug.cgi?id=78640
Reviewed by Tony Chang.
The change in r107718 (bug 78565) broke NRWT if you didn't
specify any sort of --platform flag or equivalent. I didn't
catch this because it's a full integration test (which we don't
have an automated test for) and I missed this command line
variant when testing interactively.
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.run):
- 3:16 PM Changeset in webkit [107745] by
-
- 2 edits in trunk/Source/WebCore
Avoid full style recalc when presentation attributes change.
<http://webkit.org/b/78636>
Patch by Andreas Kling <awesomekling@apple.com> on 2012-02-14
Reviewed by Antti Koivisto.
Use setNeedsStyleRecalc(InlineStyleChange) when a presentation attribute changes
to reduce the amount of work done in recalcStyle().
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
- 3:11 PM Changeset in webkit [107744] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix for non-DFG platforms.
- assembler/MacroAssembler.h:
(MacroAssembler):
- 2:58 PM Changeset in webkit [107743] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstreaming DOMSupport files
https://bugs.webkit.org/show_bug.cgi?id=78607
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
- blackberry/WebKitSupport/DOMSupport.cpp: Added.
- blackberry/WebKitSupport/DOMSupport.h: Added.
- 2:56 PM Changeset in webkit [107742] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix build and configuration goof.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::invert):
- dfg/DFGCommon.h:
- 2:50 PM Changeset in webkit [107741] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG should be able to emit code on control flow edges
https://bugs.webkit.org/show_bug.cgi?id=78515
Reviewed by Gavin Barraclough.
This gets us a few steps closer to being able to perform global register allocation,
by allowing us to have landing pads on control flow edges. This will let us reshuffle
registers if it happens to be necessary due to different reg alloc decisions in
differen blocks.
This also introduces the notion of a landing pad for OSR entry, which will allow us
to emit code that places data into registers when we're entering into the DFG from
the old JIT.
Finally, this patch introduces a verification mode that checks that the landing pads
are actually emitted and do actually work as advertised. When verification is disabled,
this has no effect on behavior.
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::invert):
(JSC::MacroAssembler::isInvertible):
- dfg/DFGCommon.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(DFG):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::haveEdgeCodeToEmit):
(JSC::DFG::SpeculativeJIT::emitEdgeCode):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- 2:47 PM Changeset in webkit [107740] by
-
- 4 edits in trunk/LayoutTests
Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634
Unreviewed test maintenance.
- media/video-controls-rendering.html:
- media/video-zoom.html:
- platform/chromium/test_expectations.txt:
- 2:35 PM Changeset in webkit [107739] by
-
- 7 edits in trunk
Last character display for passwords in Android.
https://bugs.webkit.org/show_bug.cgi?id=78532
Patch by Ramya Chandrasekaran <cramya@google.com> on 2012-02-14
Reviewed by Adam Barth.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::Settings):
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setPasswordEchoEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPasswordEchoDurationInSeconds):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Tools:
- DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
- 2:31 PM Changeset in webkit [107738] by
-
- 7 edits in trunk
IndexedDB: Invalid dates should not be valid keys
https://bugs.webkit.org/show_bug.cgi?id=78622
Reviewed by Tony Chang.
Source/WebCore:
Tests: storage/indexeddb/invalid-keys.html
storage/indexeddb/factory-cmp.html
- bindings/v8/IDBBindingUtilities.cpp: Special case for NaN Dates.
(WebCore::createIDBKeyFromValue):
LayoutTests:
- storage/indexeddb/factory-cmp-expected.txt:
- storage/indexeddb/factory-cmp.html:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/invalid-keys.html:
- 2:30 PM Changeset in webkit [107737] by
-
- 3 edits in trunk/Source/WebKit
[BlackBerry] Remove OpenVG references
https://bugs.webkit.org/show_bug.cgi?id=78623
Patch by Jeff Rogers <jrogers@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Removed references to USE(OPENVG) and the related code.
- blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::createSurface):
- blackberry/Api/BackingStore_p.h:
- 2:18 PM Changeset in webkit [107736] by
-
- 4 edits2 adds in trunk/Source/WebKit
Initial upstreaming for find-in-page for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78615
Create a new class InPageSearchManager for find-in-page and
remove the functions in SelectionHandler
Patch by Andy Chen <andchen@rim.com> on 2012-02-14
Reviewed by Rob Buis.
- blackberry/CMakeListsBlackBerry.txt:
- blackberry/WebKitSupport/InPageSearchManager.cpp: Added.
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
- blackberry/WebKitSupport/InPageSearchManager.h: Added.
- blackberry/WebKitSupport/SelectionHandler.cpp:
- blackberry/WebKitSupport/SelectionHandler.h:
- 2:12 PM Changeset in webkit [107735] by
-
- 5 edits1 delete in branches/subpixellayout/Source
Cleaning up unused code/unnecessary conversions on branch.
- 2:09 PM Changeset in webkit [107734] by
-
- 1 edit2 adds in trunk/Source/WebKit
[BlackBerry] Upstream BlackBerry WebCoreSupport FrameLoaderClientBlackBerry class
https://bugs.webkit.org/show_bug.cgi?id=78275
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstream, no new tests.
- blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp: Added.
- blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h: Added.
- 2:02 PM Changeset in webkit [107733] by
-
- 3 edits2 adds in trunk
Crash from line break iterators in counter content
https://bugs.webkit.org/show_bug.cgi?id=72977
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-14
Reviewed by David Hyatt.
Source/WebCore:
Calculating the width of counter text can sometimes cause the
underlying text buffer to change. This patch causes the iterator
to reset appropriately when this happens.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
LayoutTests:
Test that causes asterisk counters to change during layout
and potentially confuse iterators.
- fast/css/counters/asterisk-counter-update-after-layout-crash-expected.txt: Added
- fast/css/counters/asterisk-counter-update-after-layout-crash.html: Added
- 1:26 PM Changeset in webkit [107732] by
-
- 4 edits3 adds in trunk
Assertion failure under JSC::DFG::AbstractState::execute loading economist.com
https://bugs.webkit.org/show_bug.cgi?id=78153
<rdar://problem/10861712> <rdar://problem/10861947>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
LayoutTests:
- fast/js/dfg-add-not-number-expected.txt: Added.
- fast/js/dfg-add-not-number.html: Added.
- fast/js/script-tests/dfg-add-not-number.js: Added.
(foo):
- 1:25 PM LayoutUnit edited by
- (diff)
- 1:17 PM Changeset in webkit [107731] by
-
- 4 edits in trunk/Source/WebCore
Update usage of LayoutUnits in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=78511
Reviewed by Simon Fraser.
Updating RenderLayer to properly use LayoutUnits. See descriptions below for the rationale behind all
the changes. Also adding a roundedIntSize method that takes a LayoutSize.
No new tests. No change in behavior.
- rendering/LayoutTypes.h:
(WebCore::roundedIntSize): Inline method that currently does nothing, but will round a LayoutSize
to an IntSize.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Switching repaint and outline boxes to LayoutRects, as
it's important to keep the precision of these rects until handing off to the embedder (in FrameView).
(WebCore::RenderLayer::computeRepaintRects): Repaint rects should be preserved in subpixel units until
being passed to the embedding layer. This prevents needless repaints.
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Convenience function to return pixel snapped rects
(WebCore):
(WebCore::RenderLayer::convertToLayerCoords): Fixing a style flaw.
(WebCore::RenderLayer::scrollRectToVisible): Pixel snapping the rect when handing off to the embedder.
(WebCore::RenderLayer::maximumScrollPosition): Scroll offsets are rounded.
(WebCore::RenderLayer::scrollCornerRect): Scrollbars are drawn natively and should be positioned on pixel
boundaries.
(WebCore::RenderLayer::scrollCornerAndResizerRect): Resize corner doesn't influence the size/position of
render objects. It is only painted and hit tested. Therefor it should use integers.
(WebCore::RenderLayer::offsetFromResizeCorner): Ditto.
(WebCore::RenderLayer::positionOverflowControls): Overflow controls are drawn natively and should be
positioned on integer boundaries.
(WebCore::RenderLayer::paintOverflowControls): Ditto.
(WebCore::RenderLayer::paintScrollCorner): Ditto.
(WebCore::RenderLayer::drawPlatformResizerImage): Ditto.
(WebCore::RenderLayer::paintResizer): Ditto.
(WebCore::RenderLayer::hitTestOverflowControls): Hit testing & overflow controls both use integers.
(WebCore::RenderLayer::clipToRect): Clipping to actual painted (pixel snapped) layer bounds in the
graphics context.
(WebCore::RenderLayer::paintLayerContents): Calling paintOverflowControls at pixel bounds.
(WebCore::RenderLayer::hitTest): Intersecting the hit test area with pixel snapped boundaries.
(WebCore::RenderLayer::setBackingNeedsRepaintInRect): Sending pixelSnapped rects to the backing
store, which only cares about pixels, and hence integers.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::scrolledContentOffset): RenderLayer's scroll offsets are used in platform
code, so we need to return them as integers. Rounding the scroll overflow before adding it to the
scroll offset, which was already stored in integers.
(RenderLayer):
- 1:16 PM Changeset in webkit [107730] by
-
- 4 edits2 adds in trunk/Source/WebKit
Separate mimetype and file extension mapping API from WebKit/blackberry/Api/WebKitTextCodec and complete it.
https://bugs.webkit.org/show_bug.cgi?id=78605
Patch by Lianghui Chen <liachen@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Now the MIME type and file extension mapping API are in WebKitMIMETypeConverter.
- blackberry/Api/WebKitMIMETypeConverter.cpp: Added.
(WebKit):
(BlackBerry::WebKit::getExtensionForMimeType):
(BlackBerry::WebKit::getMimeTypeForExtension):
- blackberry/Api/WebKitMIMETypeConverter.h: Added.
(WebKit):
- blackberry/Api/WebKitTextCodec.cpp:
- blackberry/Api/WebKitTextCodec.h:
- blackberry/CMakeListsBlackBerry.txt:
- 1:02 PM Changeset in webkit [107729] by
-
- 3 edits2 adds in trunk
Crash in NavigationScheduler::schedule.
https://bugs.webkit.org/show_bug.cgi?id=78297
Reviewed by Adam Barth.
Source/WebCore:
Protect frame pointer and navigation scheduler when we stop the
load (when redirect is scheduled during a load). Also, dont fire
the navigation scheduler timer when we know that frameloader is
going away.
Test: http/tests/navigation/navigation-redirect-schedule-crash.html
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::schedule):
LayoutTests:
- http/tests/navigation/navigation-redirect-schedule-crash-expected.txt: Added.
- http/tests/navigation/navigation-redirect-schedule-crash.html: Added.
- 1:00 PM Changeset in webkit [107728] by
-
- 3 edits2 adds in trunk
font shorthand with inherit keyword incorrectly parsed and rendered
https://bugs.webkit.org/show_bug.cgi?id=20181
Reviewed by Tony Chang.
Source/WebCore:
As stated in http://www.w3.org/TR/CSS21/changes.html#q142
if the inherit (and also by extension initial) is encountered in the
middle of the shorthand then the property becomes invalid.
Test: fast/css/font-shorthand-mix-inherit.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
LayoutTests:
- fast/css/font-shorthand-mix-inherit-expected.txt: Added.
- fast/css/font-shorthand-mix-inherit.html: Added.
- 12:47 PM Changeset in webkit [107727] by
-
- 6 edits in branches/subpixellayout/Source/WebCore/rendering
Moving RenderLayerBacking and RenderLayerCompositor to integers, and ensuring pixel snapping occurs in all the right places.
- 12:45 PM Changeset in webkit [107726] by
-
- 3 edits2 adds in trunk
Crash due to incorrect firing of mutation event during class attribute parsing.
https://bugs.webkit.org/show_bug.cgi?id=78537
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/class-attr-change-double-mutation-fire.html
- dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
LayoutTests:
- fast/dom/class-attr-change-double-mutation-fire-expected.txt: Added.
- fast/dom/class-attr-change-double-mutation-fire.html: Added.
- 12:29 PM Changeset in webkit [107725] by
-
- 2 edits in trunk/Tools
Finish implementing start_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78582
Reviewed by Eric Seidel.
This patch contains the remaining odds and ends for the start_helper function.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._synchronize_datetime):
(ChromiumAndroidPort):
(ChromiumAndroidPort._check_version):
(ChromiumAndroidPort._run_adb_command):
(ChromiumAndroidPort._copy_device_file):
- 12:22 PM Changeset in webkit [107724] by
-
- 5 edits in trunk
CSS3 calc: add isZero implementations to catch divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78603
Reviewed by Ojan Vafai.
Source/WebCore:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::isZero):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcBinaryOperation::isZero):
(CSSCalcBinaryOperation):
- css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
LayoutTests:
- css3/calc/calc-errors-expected.txt:
- 12:15 PM Changeset in webkit [107723] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, marking a perf test as slow in debug and two
gpu tests as failing in debug (different scrollbar rendering).
- platform/chromium/test_expectations.txt:
- 12:13 PM Changeset in webkit [107722] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.
https://bugs.webkit.org/show_bug.cgi?id=76937
Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Add perTilePainting to WebLayerTreeView::Settings.
- public/platform/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
- 12:11 PM Changeset in webkit [107721] by
-
- 3 edits in trunk/LayoutTests
[chromium] Layout Test media/media-document-audio-repaint.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76580
Reviewed by James Robinson.
Make sure to call layoutTestController.display() at a stable point
(namely when the media element is paused) so that any subsequent GPU
disabling doesn't cause a complete redraw (and the test to be
flaky).
- media/media-document-audio-repaint.html:
- platform/chromium/test_expectations.txt:
- 11:42 AM Changeset in webkit [107720] by
-
- 1 edit6 deletes in trunk/LayoutTests
Remove inspector/protocol/page-agent.html since it is inherently flaky.
Filed https://webkit.org/b/78621 about devising a non-flaky test.
Unreviewed.
- inspector/protocol/page-agent-expected.txt: Removed.
- inspector/protocol/page-agent.html: Removed.
- inspector/protocol/resources/dummy-iframe.html: Removed.
- inspector/protocol/resources/empty.png: Removed.
- inspector/protocol/resources/font1.ttf: Removed.
- inspector/protocol/resources/font2.ttf: Removed.
- 11:39 AM Changeset in webkit [107719] by
-
- 3 edits in trunk/Source/WebKit
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608
Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not applying padding to
a direction that would cause the selection to shrink when performing
the handle direction detection.
Patch by Ed Baker <edbaker@rim.com> on 2012-02-14
Reviewed by Rob Buis.
- blackberry/WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
- blackberry/WebKitSupport/SelectionHandler.h:
- 11:25 AM Changeset in webkit [107718] by
-
- 4 edits in trunk/Tools
webkitpy: create ports in Workers, not in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78565
Reviewed by Tony Chang.
We will now create the Port object (if necessary) in the Worker
directly, so that the manager_worker_broker module doesn't need
all of this layout_test-specific logic. Part of the fixes for
bug 78171.
These changes are all well-tested by the existing tests in
run_webkit_tests_integrationtest.py.
- Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_Process.run):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.init):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(main): Fix a minor bug where running the 'mock-test' port didn't work right.
- 11:18 AM Changeset in webkit [107717] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, mark some form tests as flaky.
- platform/chromium/test_expectations.txt:
- 11:13 AM Changeset in webkit [107716] by
-
- 1 edit6 adds in trunk/Source/WebKit
[BlackBerry] Upstream backing store related classes
https://bugs.webkit.org/show_bug.cgi?id=78517
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- blackberry/WebKitSupport/BackingStoreClient.cpp: Added.
- blackberry/WebKitSupport/BackingStoreClient.h: Added.
- blackberry/WebKitSupport/BackingStoreCompositingSurface.cpp: Added.
- blackberry/WebKitSupport/BackingStoreCompositingSurface.h: Added.
- blackberry/WebKitSupport/BackingStoreTile.cpp: Added.
- blackberry/WebKitSupport/BackingStoreTile.h: Added.
- 10:44 AM Changeset in webkit [107715] by
-
- 5 edits in trunk
Source/WebCore: Don't include CachedResources that haven't downloaded when populating the Web Inspector on load.
https://webkit.org/b/78447
rdar://problem/10843542
Reviewed by Brian Weinstein.
Test: inspector/protocol/page-agent.html
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourcesForFrame): Skip CachedFonts and CachedImages that
return true for stillNeedsLoad.
- loader/cache/CachedFont.h:
(WebCore::CachedFont::stillNeedsLoad): Added.
LayoutTests: Updated test results to exclude CachedResources that haven't downloaded.
https://webkit.org/b/78447
rdar://problem/10843542
Reviewed by Brian Weinstein.
- inspector/protocol/page-agent-expected.txt: Updated. There is now only one font list
in the resources, when there was incorrectly two being listed. Only the font being used
is the one that downloaded and is listed now.
- 10:44 AM Changeset in webkit [107714] by
-
- 5 edits7 adds in trunk
Source/WebCore: Web Inspector: include failed and canceled in FrameResourceTree.
Reviewed by Pavel Feldman.
Test: inspector/protocol/page-agent.html
- WebCore.xcodeproj/project.pbxproj: Added Inspector.json, Inspector-0.1.json and Inspector-1.0.json
for quick access and easy editing.
- inspector/Inspector.json: Added failed and canceled as optional properties to the object for resources in FrameResourceTree.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrameTree): Set those properties.
LayoutTests: Test for Web Inspector: include failed and canceled in FrameResourceTree.
Reviewed by Pavel Feldman.
- inspector/protocol/page-agent-expected.txt: Added.
- inspector/protocol/page-agent.html: Added.
- inspector/protocol/resources/dummy-iframe.html: Added.
- inspector/protocol/resources/empty.png: Added.
- inspector/protocol/resources/font1.ttf: Added.
- inspector/protocol/resources/font2.ttf: Added.
- 9:39 AM Changeset in webkit [107713] by
-
- 3 edits in trunk/LayoutTests
[GTK] fast/forms/implicit-submission.html fails
https://bugs.webkit.org/show_bug.cgi?id=76632
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-14
Reviewed by Martin Robinson.
[Gtk] Rebaseline implicit-submission test expectations after r105253.
- platform/gtk/Skipped:
- platform/gtk/fast/forms/implicit-submission-expected.txt:
- 9:36 AM WinCE edited by
- (diff)
- 9:29 AM WinCE edited by
- Fixed build exmple after r101052 (diff)
- 8:12 AM Changeset in webkit [107712] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107688 and skipping some new
test failures.
- platform/gtk/Skipped:
- platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt:
- 7:42 AM Changeset in webkit [107711] by
-
- 26 edits in branches/chromium/1025
Merge 107094 - Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007
This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
LayoutTests:
- platform/chromium/test_expectations.txt:
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9358057
- 6:28 AM Changeset in webkit [107710] by
-
- 2 edits in trunk/Source/WebCore
Typo fix after r107707.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::updateBackingStore):
- 6:24 AM Changeset in webkit [107709] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel
https://bugs.webkit.org/show_bug.cgi?id=78599
Reviewed by Pavel Feldman.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowResizeDragging):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMaximum):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelinePanel.WindowSelector):
- 5:34 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 5:33 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 4:55 AM Changeset in webkit [107708] by
-
- 16 edits1 copy3 adds in trunk
Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349
Reviewed by Pavel Feldman.
Source/WebCore:
Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.
Tests: inspector/debugger/scripts-combobox-file-selector-history.html
inspector/debugger/scripts-file-selector.html
- English.lproj/localizedStrings.js:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
(.TestSuite.prototype._scriptsAreParsed):
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
(initialize_DebuggerTest.):
- inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
- inspector/debugger/scripts-combobox-file-selector-history.html: Added.
- inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
- inspector/debugger/scripts-file-selector.html: Added.
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/source-frame-count.html:
- 4:53 AM Changeset in webkit [107707] by
-
- 17 edits4 adds in trunk/Source
[Qt][Texmap] Refactor backing-store code in TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=78305
Source/WebCore:
Instead of dealing with tiling inside of TextureMapperNode, we now deal with that in a new
TextureMapperBackingStore class. Since the class is abstract, WebKit2 can overload it to
support remotely-managed tiles.
The backing-store for directly composited images is handled separately, in a new class
TextureMapperCompositedImage. The TextureMapper implementation decides the dimension of
the tiles, for example 2000 in the case of OpenGL.
Also, directly composited content is now handled correctly, by painting it after the regular
content and not as part of the same texture.
To make this work, the functions in TextureMapperPlatformLayers had to become non-const,
thus the changes to that file and GraphicsContext3DQt.
Reviewed by Kenneth Rohde Christiansen.
No new functionality, no new tests.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/opengl/TextureMapperGL.h:
(WebCore::TextureMapperGL::maxTextureDimension):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::getContentsLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::platformLayer):
(WebCore::GraphicsLayerTextureMapper::needsDisplay):
(WebCore::GraphicsLayerTextureMapper::needsDisplayRect):
- platform/graphics/texmap/TextureMapper.cpp:
- platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::maxTextureDimension):
(TextureMapper):
- platform/graphics/texmap/TextureMapperBackingStore.cpp: Added.
- platform/graphics/texmap/TextureMapperBackingStore.h: Added.
- platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::backingStore):
(WebCore::TextureMapperNode::updateBackingStore):
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::intermediateSurfaceRect):
(WebCore::TextureMapperNode::paintRecursive):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):
- platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(WebCore::TextureMapperNode::TextureMapperNode):
(TextureMapperNode):
(WebCore::TextureMapperNode::setBackingStore):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::layerRect):
(WebCore::TextureMapperNode::createBackingStore):
(State):
(WebCore::TextureMapperNode::State::State):
- platform/graphics/texmap/TextureMapperPlatformLayer.h:
(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::swapBuffers):
Source/WebKit2:
Move the backing-store code to LayerTreeBackingStore, implementing the virtual functions
in TextureMapperBackingStore.
We save the double-buffered tile in the backing-store, and then convert them to regular
tiles in updateContents, based on the order of painting.
Use TextureMapperCompositedImage for images instead of saving our own composited image
registry.
Reviewed by Kenneth Rohde Christiansen.
- Target.pri:
- UIProcess/LayerTreeHostProxy.h:
(WebKit):
(LayerTreeHostProxy):
- UIProcess/qt/LayerBackingStore.cpp: Added.
- UIProcess/qt/LayerBackingStore.h: Added.
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::createTile):
(WebKit::LayerTreeHostProxy::removeTile):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::assignImageToLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
- WebProcess.pro:
- 4:48 AM Changeset in webkit [107706] by
-
- 37 edits in trunk
Use youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot().
https://bugs.webkit.org/show_bug.cgi?id=78455
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-14
Reviewed by Hajime Morita.
.:
Exports necessary symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
Element::shadowRoot() was used for these 3 purposes.
- checks a shadow root exists.
- gets author shadow root.
- gets user agent shadow root.
We have to distinguish them when implementing multiple shadow subtrees.
Calling for (1), (2), and (3) are convered to hasShadowRoot(),
ShadowRootList()->youngestShadowRoot(), and ShadowRootList()->oldestShadowRoot() respectively.
No new tests, no change in behavior.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
- dom/Element.cpp:
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
(WebCore::Element::focus):
- dom/Element.h:
(Element):
- dom/EventDispatcher.cpp:
(WebCore::isShadowHost):
- dom/Node.cpp:
(WebCore::shadowRoot):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::insertedIntoDocument):
(WebCore):
(WebCore::ShadowRootList::removedFromDocument):
(WebCore::ShadowRootList::insertedIntoTree):
(WebCore::ShadowRootList::removedFromTree):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):
- dom/ShadowRootList.h:
(ShadowRootList):
- dom/TreeScopeAdopter.cpp:
(WebCore::shadowRootFor):
- html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::deleteBubbleTree):
- html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):
- page/FocusController.cpp:
(WebCore::shadowRoot):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
Exports necesarry symbols.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
- 4:45 AM Changeset in webkit [107705] by
-
- 8 edits in trunk
Elements panel needs to be able to preview images
https://bugs.webkit.org/show_bug.cgi?id=21570
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.willHide):
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode.dimensions):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode):
(WebInspector.ElementsPanel.prototype._showPopover.dimensionsCallback):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover.buildPopoverContents):
(WebInspector.ElementsPanel.prototype._showPopover):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._onmousemove):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.get g):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):
- inspector/front-end/elementsPanel.css:
(.image-preview-container):
(.image-preview-container img):
LayoutTests:
- inspector/elements/elements-img-tooltip-expected.txt:
- inspector/elements/elements-img-tooltip.html:
- 4:36 AM Changeset in webkit [107704] by
-
- 4 edits in trunk/Tools
[chromium] check that we're not running multiple modal dialogs at the same time
https://bugs.webkit.org/show_bug.cgi?id=78486
Reviewed by Kent Tamura.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):
- 4:05 AM WebKitIDL edited by
- (diff)
- 4:01 AM Changeset in webkit [107703] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: List expansion arrows is pointing down even
when the list of eventListeners are hidden in the Elements tab
https://bugs.webkit.org/show_bug.cgi?id=78360
Reviewed by Timothy Hatcher.
- inspector/front-end/elementsPanel.css:
(.section .event-bar .header):
(.section .event-bars .event-bar .header .title):
(.section .event-bar .header .subtitle):
(.section .event-bar .header::before):
(.section .event-bar.expanded .header::before):
- 3:42 AM Changeset in webkit [107702] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Typo fix, skip a new failing test.
- platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Updated after r107688.
- 3:37 AM Changeset in webkit [107701] by
-
- 5 edits3 adds1 delete in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #7 of N.
- platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
- platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added.
- platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Removed.
- platform/chromium-win/fast/replaced/width100percent-image-expected.png:
- platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 3:32 AM Changeset in webkit [107700] by
-
- 23 edits in trunk
Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514
Reviewed by Dimitri Glazkov.
NodeType.SHADOW_ROOT_NODE type is finally gone.
Source/WebCore:
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- bindings/objc/DOM.mm:
(kitClass):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
- dom/Node.h:
- dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
- dom/ShadowRoot.cpp:
- dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
- editing/FrameSelection.cpp:
(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
- html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):
Source/WebKit/chromium:
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):
LayoutTests:
- fast/dom/shadow/nodetype-expected.txt:
- fast/dom/shadow/nodetype.html:
- resources/dump-as-markup.js:
(Markup._get):
- 3:01 AM Changeset in webkit [107699] by
-
- 2 edits in trunk/Source/WebCore
StylePropertySet: Try to find a CSSValuePool for identifier values.
<http://webkit.org/b/78590>
Reviewed by Antti Koivisto.
For StylePropertySets with a parent element (inline and attribute style),
grab at the parentElement()->document() to locate a CSSValuePool.
This code will change soon in the CSSOM refactoring and moreso once we
figure out how to have a global CSSValuePool, but I'm hoping it will buy
us some perf back in the meantime.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
- 2:54 AM Changeset in webkit [107698] by
-
- 10 edits in trunk/LayoutTests
svg/hixie/perf has different repaint region in debug vs release
https://bugs.webkit.org/show_bug.cgi?id=78516
Reviewed by Hajime Morita.
Based on patch by Tony Chang <tony@chromium.org>.
The problem is the progress text in the lower right. It says,
"Test in progress... X of 10". Depending on how fast the test runs,
this text is never painted and the repaint region changes. Disable
painting of the intermediate text and only include the final text.
Extended Tonys original patch to cover all svg/hixie/perf tests that
suffered from this issue - also avoid using setTimeout between the
individual steps, as we're only interessted in the final repaint
region, not the intermediate ones.
- platform/mac/svg/hixie/perf/001-expected.png:
- platform/mac/svg/hixie/perf/002-expected.png:
- platform/mac/svg/hixie/perf/003-expected.png:
- svg/hixie/perf/001.xml:
- svg/hixie/perf/002.xml:
- svg/hixie/perf/003.xml:
- svg/hixie/perf/004.xml:
- svg/hixie/perf/005.xml:
- svg/hixie/perf/006.xml:
- 2:41 AM Changeset in webkit [107697] by
-
- 2 edits in trunk/Tools
Enable the GPU codepath in the chromium-android port
https://bugs.webkit.org/show_bug.cgi?id=78580
Reviewed by James Robinson.
Suprise! There is no ChromiumGpuAndroidPort! Instead, Chromium
Android always uses the GPU codepath, so we set the GPU flags on the
main chromium-android port instead.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
- 2:38 AM Changeset in webkit [107696] by
-
- 2 edits in trunk/Tools
NRWT should expose --adb-args flag for Android
https://bugs.webkit.org/show_bug.cgi?id=78579
Reviewed by Eric Seidel.
This flag is already wired up to the ChromiumAndroidPort.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 2:35 AM Changeset in webkit [107695] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView.
https://bugs.webkit.org/show_bug.cgi?id=76927
Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Remove unnecessary initialization and include maxPartialTextureUpdates
in FIXME comment.
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
- 2:29 AM WebKitIDL edited by
- (diff)
- 2:21 AM Changeset in webkit [107694] by
-
- 1 edit1 add in trunk/LayoutTests
2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add mixing Lion pixel test result for a svg/carto.net test.
- platform/mac/svg/carto.net/scrollbar-expected.png: Added.
- 2:19 AM Changeset in webkit [107693] by
-
- 5 edits in trunk/Source/WebCore
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Reviewed by Hajime Morita.
Fix last-minute typo in clearTimesWithDynamicOrigins, leading to assertions browsing the W3C SVG animation tests.
Covered by existing tests in svg/animations.
- svg/SVGAnimationElement.cpp: Remove unused endedActiveInterval.
- svg/SVGAnimationElement.h: Ditto.
- svg/animation/SVGSMILElement.cpp:
(WebCore::clearTimesWithDynamicOrigins): Fix order of walking the times list.
(WebCore::SVGSMILElement::reset): Move calls to clearTimesWithDynamicOrigins into endedActiveInterval.
(WebCore::SVGSMILElement::endedActiveInterval):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement): Devirtualize endedActiveInterval.
- 2:04 AM Changeset in webkit [107692] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- 1:55 AM Changeset in webkit [107691] by
-
- 23 edits in trunk
Unreviewed, rolling out r107661.
http://trac.webkit.org/changeset/107661
https://bugs.webkit.org/show_bug.cgi?id=78591
crash on lion/qt bots (Requested by hayato on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14
Source/WebCore:
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- bindings/objc/DOM.mm:
(kitClass):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
- dom/Node.h:
- dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeType):
(WebCore):
- dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::textWillBeReplaced):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
- html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):
Source/WebKit/chromium:
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):
LayoutTests:
- fast/dom/shadow/nodetype-expected.txt:
- fast/dom/shadow/nodetype.html:
- resources/dump-as-markup.js:
(Markup._get):
- 1:52 AM Changeset in webkit [107690] by
-
- 6 edits in trunk/Source/WebCore
Fix typo. HTMLContentSeleciton -> HTMLContentSelection.
https://bugs.webkit.org/show_bug.cgi?id=78571
Reviewed by Hajime Morita.
No tests. No change in behavior.
- dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointFor):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
- html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelection::append):
(WebCore::HTMLContentSelection::unlink):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
- html/shadow/HTMLContentSelector.h:
(HTMLContentSelection):
(WebCore::HTMLContentSelection::next):
(WebCore::HTMLContentSelection::previous):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
- 1:50 AM Changeset in webkit [107689] by
-
- 73 edits in trunk
[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
https://bugs.webkit.org/show_bug.cgi?id=78541
<rdar://problem/10036695>
Reviewed by Kent Tamura.
Source/WebKit/mac:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the
preference.
Source/WebKit/win:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of
the preference
Source/WebKit2:
- Shared/WebPreferencesStore.h: (WebKit): Changed default value of the preference.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
After each test, reset to using new protocol.
LayoutTests:
- http/tests/websocket/tests/hixie76/alert-in-event-handler.html:
- http/tests/websocket/tests/hixie76/bad-handshake-crash.html:
- http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html:
- http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html:
- http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html:
- http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html:
- http/tests/websocket/tests/hixie76/client-close.html:
- http/tests/websocket/tests/hixie76/close-before-open.html:
- http/tests/websocket/tests/hixie76/close-event.html:
- http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html:
- http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
- http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html:
- http/tests/websocket/tests/hixie76/close-on-unload.html:
- http/tests/websocket/tests/hixie76/close-unref-websocket.html:
- http/tests/websocket/tests/hixie76/cross-origin.html:
- http/tests/websocket/tests/hixie76/error-detect.html:
- http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html:
- http/tests/websocket/tests/hixie76/frame-length-overflow.html:
- http/tests/websocket/tests/hixie76/frame-length-skip.html:
- http/tests/websocket/tests/hixie76/frame-lengths.html:
- http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html:
- http/tests/websocket/tests/hixie76/handshake-error.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html:
- http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html:
- http/tests/websocket/tests/hixie76/long-invalid-header.html:
- http/tests/websocket/tests/hixie76/multiple-connections.html:
- http/tests/websocket/tests/hixie76/null-character.html:
- http/tests/websocket/tests/hixie76/reload-crash.html:
- http/tests/websocket/tests/hixie76/send-after-close-on-unload.html:
- http/tests/websocket/tests/hixie76/send-empty.html:
- http/tests/websocket/tests/hixie76/send-object.html:
- http/tests/websocket/tests/hixie76/send-throw.html:
- http/tests/websocket/tests/hixie76/send.html:
- http/tests/websocket/tests/hixie76/server-close.html:
- http/tests/websocket/tests/hixie76/simple-stress.html:
- http/tests/websocket/tests/hixie76/simple.html:
- http/tests/websocket/tests/hixie76/split-binary-frame-header.html:
- http/tests/websocket/tests/hixie76/sub-protocol-with-space.html:
- http/tests/websocket/tests/hixie76/sub-protocol.html:
- http/tests/websocket/tests/hixie76/undefined-attributes.html:
- http/tests/websocket/tests/hixie76/unicode.html:
- http/tests/websocket/tests/hixie76/url-attribute.html:
- http/tests/websocket/tests/hixie76/url-no-trailing-slash.html:
- http/tests/websocket/tests/hixie76/url-parsing.html:
- http/tests/websocket/tests/hixie76/url-with-credential.html:
- http/tests/websocket/tests/hixie76/url-with-empty-query.html:
- http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html:
- http/tests/websocket/tests/hixie76/url-with-query.html:
- http/tests/websocket/tests/hixie76/websocket-event-target.html:
- http/tests/websocket/tests/hixie76/websocket-pending-activity.html:
- http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html:
- http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html:
- http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html:
- http/tests/websocket/tests/hixie76/workers/close-in-worker.html:
- http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html:
- http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html:
- http/tests/websocket/tests/hixie76/workers/worker-simple.html:
Added overridePreference calls, so that the tests don't depend on platform or DRT default.
- 1:46 AM Changeset in webkit [107688] by
-
- 20 edits3 moves in trunk
CSS3 calc: embed calc expressions in CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=78446
Source/WebCore:
Reviewed by Ojan Vafai.
Adds calc expressions to CSSPrimitiveValue. This enables simple (ie no mixing of
percents with numbers/lengths) expressions to be evaluated on most properties.
Tests: css3/calc/block-mask-overlay-image-outset-expected.html
css3/calc/css3-radial-gradients-expected.html
css3/calc/gradient-color-stops-expected.html
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
- css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(CSSCalcValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::init):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::customCssText):
- css/CSSPrimitiveValue.h:
(WebCore):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isCalculated):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageNumber):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageLength):
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::getValue):
(WebCore::CSSPrimitiveValue::cssCalcValue):
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
LayoutTests:
Reviewed by Ojan Vafai.
- css3/calc/block-mask-overlay-image-outset-expected.html: Renamed from LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html.
- css3/calc/border-expected.txt:
- css3/calc/calc-errors-expected.txt:
- css3/calc/css3-radial-gradients-expected.html: Renamed from LayoutTests/css3/calc/css3-radial-gradients-expected-mismatch.html.
- css3/calc/font-expected.txt:
- css3/calc/font-monospace-expected.txt:
- css3/calc/font-size-expected.txt:
- css3/calc/font-size-fractional-expected.txt:
- css3/calc/getComputedStyle-margin-percentage-expected.txt:
- css3/calc/gradient-color-stops-expected.html: Renamed from LayoutTests/css3/calc/gradient-color-stops-expected-mismatch.html.
- css3/calc/line-height-expected.txt:
- css3/calc/margin-expected.txt:
- css3/calc/padding-expected.txt:
- css3/calc/simple-calcs-expected.txt:
- css3/calc/table-border-spacing-expected.txt:
- 1:24 AM Changeset in webkit [107687] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: follow up to r107683: protect inspector sidebar from updating
while inserting new rule.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
- 1:22 AM Changeset in webkit [107686] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r107662.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 1:13 AM Changeset in webkit [107685] by
-
- 3 edits in trunk/Source/WebCore
Extend Chromium V8 tracing to cover more cases
https://bugs.webkit.org/show_bug.cgi?id=78507
Patch by Rick Byers <rbyers@.com> on 2012-02-14
Reviewed by Eric Seidel.
No tests modified because this affects only chrome tracing which we
currently don't try to validate with automated tests.
- bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::instrumentedCallFunction):
(WebCore::V8Proxy::newInstance):
- 1:03 AM WebKitIDL edited by
- (diff)
- 12:55 AM Changeset in webkit [107684] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Pepper plugins don't receive mouse movement information in
non-mouse-lock mode.
https://bugs.webkit.org/show_bug.cgi?id=78014
This change makes WebMouseEventBuilder pass along mouse movement
information properly.
There isn't test for this change because:
- the movement information added is only used by pepper, and there isn't any test for pepper at the WebKit side. (WebKit doesn't know about pepper.)
- this change is trivial. It just copies two newly-added data fields from MouseEvent to WebMouseEventBuilder during conversion.
Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-02-14
Reviewed by Tony Chang.
- src/WebInputEventConversion.cpp:
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
- 12:50 AM Changeset in webkit [107683] by
-
- 18 edits in trunk
Web Inspector: fire stylesheet changed event upon CSS modifications.
https://bugs.webkit.org/show_bug.cgi?id=78500
Patch by Pavel Feldman <pfeldman@google.com> on 2012-02-14
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::mergeId):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::merge):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):
(WebCore):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyleSheet::Listener::~Listener):
(Listener):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSStyleModel.prototype._undoRequested):
(WebInspector.CSSStyleModel.prototype._undoCompleted):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
(WebInspector.CSSDispatcher.prototype.mediaQueryResultChanged):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):
(WebInspector.DOMAgent.prototype.get undo):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.generateUndoTest):
- inspector/elements/set-outer-html-test.js:
(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):
- inspector/styles/styles-history.html:
- inspector/styles/undo-add-new-rule.html:
- inspector/styles/undo-add-property.html:
- inspector/styles/undo-change-property.html:
- inspector/styles/undo-property-toggle.html:
- inspector/styles/undo-set-selector-text.html:
- 12:41 AM Changeset in webkit [107682] by
-
- 260 edits1 delete in trunk
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Reviewed by Dirk Schulze.
Source/WebCore:
Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked:
- beginElement()/endElement() modify the begin/end times of a SVGSMILElement. When beginElement() is called a new begin time is added to the list - and the same happens for endElement() with the end list. Unfortunately the begin/end times never get removed again, leading to incorrect instance time resolving when begin/endElement is called repeatedly, combined with moving the timeline through setCurrentTime.
SMIL3 specifically demands that all 'dynamic' times in the begin/endTimes list, such that got inserted
via beginElement/endElement - get removed if the begin/endTimes list is updated. Why?
When calling beginElement, then endElement, then beginElement again, the begin/endTimes lists should be
identical, w/o leftovers from any previous begin/endElement call.
To keep track of that introduce SMILTimeWithOrigin, which holds a SMILTime and an Origin enum,
which determines whether this SMILTime was created by the parser or dynamically created via
beginElement/endElement.
- SMILTimeContainer::setElapsed() (called by SVGSVGElement::setCurrentTime) forgot to update the animation state, when it was not paused.
- document.getElementsByTagName('animateMotion')[0], always returned 'object SVGElement', instead of SVGAnimateMotion element making it impossible to query the animation start time, as the interfaces from SVGAnimationElement were not available. Fix that by removing the last hacks from svgtags.in, now that all IDLs are available.
Now that we use SVGSVGElement::setCurrentTime to drive the animation testing, we can remove
the DRT specific sampleSVGAnimationAtTime functionality, and its code springled all over WebCore.
Covered by all existing tests in svg/animations.
- WebCore.exp.in: Remove sampleAnimationAtTime() symbols.
- WebCore.order: Ditto.
- svg/SVGAnimationElement.cpp: Add a flag to begin/endElement, SMILTimeWithOrigin::ScriptOrigin, to indicate that these are dynamic SMILTimes, added by a script.
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/SVGDocumentExtensions.cpp: Remove sampleAnimationAtTime.
- svg/SVGDocumentExtensions.h: Ditto.
- svg/animation/SMILTime.h: Add SMILTimeWithOrigin helper.
(SMILTimeWithOrigin): Needs a SMILTime and an Origin enum entry.
(WebCore::SMILTimeWithOrigin::SMILTimeWithOrigin):
(WebCore::SMILTimeWithOrigin::time): Returns the SMILTime.
(WebCore::SMILTimeWithOrigin::originIsScript): Determines if this SMILTime got added by a script.
(WebCore::operator<): Used by std::sort.
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed): Always call updateAnimations, even if the animation is not paused. Use the right elpased time value, to seek precisely to the desired position.
(WebCore::SMILTimeContainer::timerFired): Cleanup code, no need for a local variable 'elapsed'.
(WebCore::SMILTimeContainer::updateAnimations): Remove DRT specific sampling code, which is no longer needed.
- svg/animation/SMILTimeContainer.h: Remove sampleAnimationAtTime.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::SVGSMILElement): Only call resolveFirstInterval, not reset, from the constructor - it wastes unnecessary time, as everything is already initialized.
(WebCore::clearTimesWithDynamicOrigins): Helper function to clear all SMILTimes from the begin/endTimes list, that are dynamic.
(WebCore::SVGSMILElement::reset): Clear begin/endTimes lists, on any reset() call (when driving the animation timeline through setElapsed).
(WebCore::SVGSMILElement::insertedIntoDocument): m_beginTimes now stores SMILTimeWithOrigins, adapt the code.
(WebCore::sortTimeList): Ditto.
(WebCore::SVGSMILElement::parseBeginOrEnd): Ditto.
(WebCore::SVGSMILElement::addBeginTime): Ditto.
(WebCore::SVGSMILElement::addEndTime): Ditto.
(WebCore::extractTimeFromVector): Ditto.
(WebCore::SVGSMILElement::findInstanceTime): Ditto.
- svg/animation/SVGSMILElement.h:
- svg/svgtags.in: Enable animateMotion/hkern/mpath JS interfaces, which were not enabled, despite their IDLs existed.
Source/WebKit/chromium:
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
Source/WebKit/efl:
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- WebKit.order:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Source/WebKit/qt:
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
- WebFrame.h:
Tools:
Remove no longer needed SVG specific animation sampling functionality from DRT.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked.
This also unifies & cleans up the tests, to use the same formatting and the same shouldBeCloseEnough helpers.
- svg/animations/animVal-basics-expected.txt:
- svg/animations/animVal-basics.html:
- svg/animations/animate-calcMode-spline-by-expected.txt:
- svg/animations/animate-calcMode-spline-by.html:
- svg/animations/animate-calcMode-spline-from-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-by.html:
- svg/animations/animate-calcMode-spline-from-to-expected.txt:
- svg/animations/animate-calcMode-spline-from-to.html:
- svg/animations/animate-calcMode-spline-to-expected.txt:
- svg/animations/animate-calcMode-spline-to.html:
- svg/animations/animate-calcMode-spline-values-expected.txt:
- svg/animations/animate-calcMode-spline-values.html:
- svg/animations/animate-color-calcMode-discrete.html:
- svg/animations/animate-color-fill-currentColor.html:
- svg/animations/animate-color-fill-from-by.html:
- svg/animations/animate-color-rgba-calcMode-discrete.html:
- svg/animations/animate-color-transparent.html:
- svg/animations/animate-currentColor.html:
- svg/animations/animate-dynamic-update-attributeName.html:
- svg/animations/animate-end-attribute-expected.txt:
- svg/animations/animate-end-attribute.html:
- svg/animations/animate-endElement-beginElement.html:
- svg/animations/animate-from-to-keyTimes.html:
- svg/animations/animate-gradient-transform.html:
- svg/animations/animate-inherit-css-property.html:
- svg/animations/animate-insert-begin.html:
- svg/animations/animate-insert-no-begin.html:
- svg/animations/animate-keySplines.html:
- svg/animations/animate-mpath-insert.html:
- svg/animations/animate-number-calcMode-discrete-expected.txt:
- svg/animations/animate-number-calcMode-discrete-keyTimes.html:
- svg/animations/animate-number-calcMode-discrete.html:
- svg/animations/animate-path-animation-Cc-Ss-expected.txt:
- svg/animations/animate-path-animation-Cc-Ss.html:
- svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
- svg/animations/animate-path-animation-Ll-Vv-Hh.html:
- svg/animations/animate-path-animation-Qq-Tt.html:
- svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
- svg/animations/animate-path-animation-cC-sS-inverse.html:
- svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
- svg/animations/animate-path-animation-lL-vV-hH-inverse.html:
- svg/animations/animate-path-animation-qQ-tT-inverse.html:
- svg/animations/animate-path-nested-transforms-expected.txt:
- svg/animations/animate-path-nested-transforms.html:
- svg/animations/animate-path-to-animation-expected.txt:
- svg/animations/animate-path-to-animation.html:
- svg/animations/animate-text-nested-transforms-expected.txt:
- svg/animations/animate-text-nested-transforms.html:
- svg/animations/animateTransform-pattern-transform.html:
- svg/animations/resources/SVGAnimationTestCase.js:
(isCloseEnough):
(shouldBeCloseEnough):
(moveAnimationTimelineAndSample):
(sampleAnimation):
(runSMILTest):
(runAnimationTest):
- svg/animations/script-tests/TEMPLATE.html: Removed.
- svg/animations/script-tests/animVal-basics.js:
(sample3):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-by.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-from-by.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-from-to.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-to.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-values.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-color-calcMode-discrete.js:
(executeTest):
- svg/animations/script-tests/animate-color-fill-currentColor.js:
(executeTest):
- svg/animations/script-tests/animate-color-fill-from-by.js:
(executeTest):
- svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:
(executeTest):
- svg/animations/script-tests/animate-color-transparent.js:
(executeTest):
- svg/animations/script-tests/animate-currentColor.js:
(executeTest):
- svg/animations/script-tests/animate-dynamic-update-attributeName.js:
(executeTest):
- svg/animations/script-tests/animate-end-attribute.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-endElement-beginElement.js:
(executeTest):
(end):
(begin):
- svg/animations/script-tests/animate-from-to-keyTimes.js:
(executeTest):
- svg/animations/script-tests/animate-gradient-transform.js:
(executeTest):
- svg/animations/script-tests/animate-inherit-css-property.js:
(executeTest):
- svg/animations/script-tests/animate-insert-begin.js:
(executeTest):
- svg/animations/script-tests/animate-insert-no-begin.js:
(executeTest):
- svg/animations/script-tests/animate-keySplines.js:
(executeTest):
- svg/animations/script-tests/animate-mpath-insert.js:
(executeTest):
- svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:
(executeTest):
- svg/animations/script-tests/animate-number-calcMode-discrete.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/animate-path-animation-Cc-Ss.js:
(sample4):
(executeTest):
- svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:
(sample4):
(executeTest):
- svg/animations/script-tests/animate-path-animation-Qq-Tt.js:
(executeTest):
- svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:
(sample4):
(executeTest):
- svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:
(sample4):
(executeTest):
- svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:
(executeTest):
- svg/animations/script-tests/animate-path-nested-transforms.js:
(g.setAttribute.rect.createSVGElement.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.g.appendChild.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.g.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):
- svg/animations/script-tests/animate-path-to-animation.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-text-nested-transforms.js:
(rootSVGElement.setAttribute.text.createSVGElement.text.setAttribute.text.textContent.string_appeared_here.text.setAttribute.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.text.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):
- svg/animations/script-tests/animateTransform-pattern-transform.js:
(executeTest):
- svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgboolean-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svginteger-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-1.js:
(executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-2.js:
(executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-3.js:
(executeTest):
- svg/animations/script-tests/svglength-animation-number-to-number.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-cm.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-ems.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-exs.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-in.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-number.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pc.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pt.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-px.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglength-animation-unitType.js:
(executeTest):
- svg/animations/script-tests/svglength-animation-values.js:
(sample5):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-2.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-3.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-4.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-5.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumber-animation-1.js:
(executeTest):
- svg/animations/script-tests/svgnumber-animation-2.js:
(executeTest):
- svg/animations/script-tests/svgnumber-animation-3.js:
(executeTest):
- svg/animations/script-tests/svgnumberlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumberlist-animation-2.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgpath-animation-1.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svgpointlist-animation-1.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svgpointlist-animation-2.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svgrect-animation-1.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svgrect-animation-2.js:
(sample3):
(executeTest):
- svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:
(executeTest):
- svg/animations/script-tests/svgtransform-animation-1.js:
(executeTest):
- svg/animations/script-tests/svgtransform-animation-discrete.js:
(executeTest):
- svg/animations/smil-element-not-removed-crash.html:
- svg/animations/svgPreserveAspectRatio-animation-1.html:
- svg/animations/svgangle-animation-deg-to-grad-expected.txt:
- svg/animations/svgangle-animation-deg-to-grad.html:
- svg/animations/svgangle-animation-deg-to-rad-expected.txt:
- svg/animations/svgangle-animation-deg-to-rad.html:
- svg/animations/svgangle-animation-grad-to-deg-expected.txt:
- svg/animations/svgangle-animation-grad-to-deg.html:
- svg/animations/svgangle-animation-grad-to-rad-expected.txt:
- svg/animations/svgangle-animation-grad-to-rad.html:
- svg/animations/svgangle-animation-rad-to-deg-expected.txt:
- svg/animations/svgangle-animation-rad-to-deg.html:
- svg/animations/svgangle-animation-rad-to-grad-expected.txt:
- svg/animations/svgangle-animation-rad-to-grad.html:
- svg/animations/svgboolean-animation-1.html:
- svg/animations/svginteger-animation-1.html:
- svg/animations/svglength-animation-LengthModeHeight-expected.txt:
- svg/animations/svglength-animation-LengthModeHeight.html:
- svg/animations/svglength-animation-LengthModeOther-expected.txt:
- svg/animations/svglength-animation-LengthModeOther.html:
- svg/animations/svglength-animation-LengthModeWidth-expected.txt:
- svg/animations/svglength-animation-LengthModeWidth.html:
- svg/animations/svglength-animation-invalid-value-1.html:
- svg/animations/svglength-animation-invalid-value-2.html:
- svg/animations/svglength-animation-invalid-value-3.html:
- svg/animations/svglength-animation-number-to-number-expected.txt:
- svg/animations/svglength-animation-number-to-number.html:
- svg/animations/svglength-animation-px-to-cm-expected.txt:
- svg/animations/svglength-animation-px-to-cm.html:
- svg/animations/svglength-animation-px-to-ems-expected.txt:
- svg/animations/svglength-animation-px-to-ems.html:
- svg/animations/svglength-animation-px-to-exs-expected.txt:
- svg/animations/svglength-animation-px-to-exs.html:
- svg/animations/svglength-animation-px-to-in-expected.txt:
- svg/animations/svglength-animation-px-to-in.html:
- svg/animations/svglength-animation-px-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-number.html:
- svg/animations/svglength-animation-px-to-pc-expected.txt:
- svg/animations/svglength-animation-px-to-pc.html:
- svg/animations/svglength-animation-px-to-percentage-expected.txt:
- svg/animations/svglength-animation-px-to-percentage.html:
- svg/animations/svglength-animation-px-to-pt-expected.txt:
- svg/animations/svglength-animation-px-to-pt.html:
- svg/animations/svglength-animation-px-to-px-expected.txt:
- svg/animations/svglength-animation-px-to-px.html:
- svg/animations/svglength-animation-unitType.html:
- svg/animations/svglength-animation-values-expected.txt:
- svg/animations/svglength-animation-values.html:
- svg/animations/svglengthlist-animation-1.html:
- svg/animations/svglengthlist-animation-2-expected.txt:
- svg/animations/svglengthlist-animation-2.html:
- svg/animations/svglengthlist-animation-3.html:
- svg/animations/svglengthlist-animation-4.html:
- svg/animations/svglengthlist-animation-5.html:
- svg/animations/svgnumber-animation-1.html:
- svg/animations/svgnumber-animation-2.html:
- svg/animations/svgnumber-animation-3.html:
- svg/animations/svgnumberlist-animation-1-expected.txt:
- svg/animations/svgnumberlist-animation-1.html:
- svg/animations/svgnumberlist-animation-2-expected.txt:
- svg/animations/svgnumberlist-animation-2.html:
- svg/animations/svgnumberoptionalnumber-animation-1.html:
- svg/animations/svgnumberoptionalnumber-animation-2.html:
- svg/animations/svgnumberoptionalnumber-animation-3.html:
- svg/animations/svgnumberoptionalnumber-animation-4.html:
- svg/animations/svgpath-animation-1-expected.txt:
- svg/animations/svgpath-animation-1.html:
- svg/animations/svgpointlist-animation-1-expected.txt:
- svg/animations/svgpointlist-animation-1.html:
- svg/animations/svgpointlist-animation-2-expected.txt:
- svg/animations/svgpointlist-animation-2.html:
- svg/animations/svgrect-animation-1-expected.txt:
- svg/animations/svgrect-animation-1.html:
- svg/animations/svgrect-animation-2-expected.txt:
- svg/animations/svgrect-animation-2.html:
- svg/animations/svgstring-animation-fallback-to-discrete-expected.txt:
- svg/animations/svgstring-animation-fallback-to-discrete.html:
- svg/animations/svgtransform-animation-1.html:
- svg/animations/svgtransform-animation-discrete-expected.txt:
- svg/animations/svgtransform-animation-discrete.html:
- 12:24 AM Changeset in webkit [107681] by
-
- 3 edits2 adds in trunk
Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/copy-stack-trace.html
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
LayoutTests:
- inspector/debugger/copy-stack-trace-expected.txt: Added.
- inspector/debugger/copy-stack-trace.html: Added.
- 12:17 AM Changeset in webkit [107680] by
-
- 12 edits1 move4 adds6 deletes in trunk/LayoutTests
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #6 of N (visually re-inspecting as I go along, lest skia bite me).
- fast/replaced/image-tag-expected.txt: Renamed from LayoutTests/platform/gtk/fast/replaced/image-tag-expected.txt.
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/replaced/image-onload-expected.png:
- platform/chromium-linux/fast/replaced/image-sizing-expected.png:
- platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
- platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png: Removed.
- platform/chromium-mac/fast/replaced/image-onload-expected.png: Removed.
- platform/chromium-mac/fast/replaced/image-sizing-expected.png: Removed.
- platform/chromium-mac/fast/replaced/image-tag-expected.png: Removed.
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/replaced/image-onload-expected.png:
- platform/chromium-win/fast/replaced/image-sizing-expected.png:
- platform/chromium-win/fast/replaced/image-tag-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/replaced/image-tag-expected.txt: Removed.
- platform/qt/fast/replaced/image-tag-expected.txt: Removed.
- 12:16 AM Changeset in webkit [107679] by
-
- 2 edits in trunk/Source/WebCore
Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
https://bugs.webkit.org/show_bug.cgi?id=78540
Reviewed by Adam Barth.
- platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::encodePixels):
- 12:05 AM Changeset in webkit [107678] by
-
- 2 edits in trunk/Source/JavaScriptCore
Upstream Android's additions to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=78536
Reviewed by Adam Barth.
- wtf/Platform.h:
- 12:01 AM Applications using WebKit edited by
- (diff)
