Context Navigation

← Previous Period
Next Period →

Timeline

Feb 18, 2012:

10:25 PM Changeset in webkit [108184] by commit-queue@webkit.org

6 edits
1 add in trunk/Source

Track the NPN protocol version negotiated with the server
https://bugs.webkit.org/show_bug.cgi?id=77349

Source/WebCore:

Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher..

[chromium] Added ExtraData to WebURLResponse.

No intended functionality change.

platform/network/chromium/ResourceResponse.h:

(ExtraData):
(WebCore::ResourceResponse::ExtraData::~ExtraData):
(ResourceResponse):
(WebCore::ResourceResponse::extraData):
(WebCore::ResourceResponse::setExtraData):

Source/WebKit/chromium:

Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher.

[chromium] Added ExtraData to WebURLResponse.

WebKit.gypi:
public/platform/WebURLResponse.h:

(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebURLResponse):

src/WebURLResponse.cpp:

(WebKit::WebURLResponse::extraData):
(WebKit):
(WebKit::WebURLResponse::setExtraData):

tests/WebURLResponseTest.cpp: Added.

(WebKit):
(TestExtraData):
(WebKit::TestExtraData::TestExtraData):
(WebKit::TestExtraData::~TestExtraData):
(WebKit::TEST):

8:57 PM Changeset in webkit [108183] by inferno@chromium.org

3 edits
2 deletes in trunk

Unreviewed, rolling out r107965.
http://trac.webkit.org/changeset/107965
https://bugs.webkit.org/show_bug.cgi?id=78273

Source/WebCore:

crashes

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

LayoutTests:

Crashes on ClusterFuzz.

fast/multicol/span/clone-flexbox-expected.txt: Removed.
fast/multicol/span/clone-flexbox.html: Removed.

8:07 PM Changeset in webkit [108182] by dpranke@chromium.org

2 edits in trunk/Tools

Fix one more dangling reference to worker_connection.name, delete unused code.

Unreviewed, build fix.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.update):
(_WorkerState.init):

7:53 PM Changeset in webkit [108181] by mitz@apple.com

3 edits in trunk/Source/WebKit2

<rdar://problem/10891801> BackingStore::scroll() unnecessarily copies pixels around
https://bugs.webkit.org/show_bug.cgi?id=78976

Reviewed by Anders Carlsson.

Rather than move pixels in the backing store in response to scrolling, we can maintain a
mapping, for the most recently scrolled rect, from backing store coordinates to view
client coordinates.

UIProcess/BackingStore.h:
UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::performWithScrolledRectTransform): Added. Given a block to be
performed on a rect, divides the rect into parts such that for each part the mapping from
backing store coordinates to client coordinates is a (uniform) translation, and performs
the block on that part, passing it the translation that applies to the part.
(WebKit::BackingStore::resetScrolledRect): Added. Copies everything in the scrolled rect
back to where it should be under the identity map, and resets the scrolled rect and offset.
(WebKit::BackingStore::paint): Changed to call through performWithScrolledRectTransform().
(WebKit::BackingStore::incorporateUpdate): Ditto.
(WebKit::BackingStore::scroll): Now instead of copying pixels, just updates the scrolled
rect and offset.

5:53 PM Changeset in webkit [108180] by weinig@apple.com

6 edits in trunk/Source/JavaScriptCore

Fix style issues in DFG Phase classes
https://bugs.webkit.org/show_bug.cgi?id=78983

Reviewed by Ryosuke Niwa.

dfg/DFGArithNodeFlagsInferencePhase.cpp:
dfg/DFGCFAPhase.cpp:
dfg/DFGCSEPhase.cpp:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGVirtualRegisterAllocationPhase.cpp:

Add a space before the colon in class declarations.

5:08 PM Changeset in webkit [108179] by weinig@apple.com

2 edits in trunk/Source/WebCore

Make WebCore compile with libc++ (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=78974

Reviewed by Anders Carlsson.

config.h:

Disable the DisallowCType check when using libc++.

4:57 PM Changeset in webkit [108178] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix the build.

page/DOMWindow.idl:

4:50 PM Changeset in webkit [108177] by dpranke@chromium.org

4 edits in trunk/Tools

Add a change that should've been in r108005.

Unreviewed, build fix.

In the refactoring/cleanup in r108005 I should've changed the
implementation of WorkerConnection to make it match BrokerClient
(and everything else) so that objects had a name() method
instead of a name property.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_WorkerConnection.init):
(_WorkerConnection.name):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestsMixin.name):
(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_unknown_message):

4:33 PM Changeset in webkit [108176] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Attempt to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:51 PM Changeset in webkit [108175] by dpranke@chromium.org

6 edits
2 deletes in trunk/Tools

webkitpy: remove webkitpy.common.array_stream
https://bugs.webkit.org/show_bug.cgi?id=78952

Reviewed by Eric Seidel.

Turns out array_stream didn't really do anything that StringIO
didn't do (at least as of Python 2.6). This change removes it
and updates all of the callers. Where possible, I changed the
test assertions in order to capture the intent more clearly,
e.g., instead of calling self.assertTrue('foo' in stream.get()),
we have self.assertContainsLine(stream, 'foo'), and instead of
self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
the latter isn't that much more readable, but StringIO doesn't
export an empty() method.

Scripts/webkitpy/common/array_stream.py: Removed.
Scripts/webkitpy/common/array_stream_unittest.py: Removed.
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(run_and_capture):
(StreamTestingMixin):
(StreamTestingMixin.assertContains):
(StreamTestingMixin.assertContainsLine):
(StreamTestingMixin.assertEmpty):
(StreamTestingMixin.assertNotEmpty):
(LintTest):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):
(MainTest):
(MainTest.test_child_process_1):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_help_printing):
(MainTest.test_hung_thread):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_worker_modelinline_with_child_processes):
(MainTest.test_additional_platform_directory):
(RebaselineTest):
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.update):

Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(TestMeteredStream.test_regular):

Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.assertEmpty):
(Testprinter):
(Testprinter.assertNotEmpty):
(Testprinter.assertWritten):
(Testprinter.reset):
(Testprinter.get_printer):
(Testprinter.test_help_printer):
(Testprinter.do_switch_tests.do_helper):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_test_result):
(Testprinter.test_print_progress):
(Testprinter.test_write_nothing):
(Testprinter.test_write_misc):
(Testprinter.test_write_everything):
(Testprinter.test_write_verbose):
(Testprinter.test_print_unexpected_results):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.assertWritten):
(create_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_upload_json):

3:42 PM Changeset in webkit [108174] by weinig@apple.com

2 edits in trunk/Source/WebCore

Make WebCore compile with libc++ (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=78974

Reviewed by Anders Carlsson.

Add a workaround for <rdar://problem/10858112>, which cause the standard heap functions
not to work when using an iterator with proxy objects for reference and pointer types.

WebCorePrefix.h:

(move):
Add an overload of std::move that the heap functions can call successfully.

2:30 PM Changeset in webkit [108173] by kling@webkit.org

3 edits in trunk/LayoutTests

Unreviewed chromium rebaselines after r108157.

platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:

2:10 PM Changeset in webkit [108172] by kevino@webkit.org

4 edits in trunk

[wx] Fix wx port compilation.

2:07 PM Changeset in webkit [108171] by kevino@webkit.org

3 edits in trunk/Source/WebCore

[wx] Build fixes for C++ bindings after recent changes.

2:04 PM Changeset in webkit [108170] by kevino@webkit.org

2 edits in trunk/Source/WebCore

[wx] Build fix, add new platform method wx impl.

1:48 PM Changeset in webkit [108169] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix part of the windows build failure.

WebCore.vcproj/WebCore.vcproj:

Don't build JSWebKitCSSRegionRule.cpp, since it is already being built
as part of DerivedSources.cpp.

1:30 PM Changeset in webkit [108168] by weinig@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix the libc++ build.

Reviewed by Anders Carlsson.

heap/Weak.h:

Libc++'s nullptr emulation does not allow default construction
of the nullptr_t type. Work around this with the arguably clearer
just returning nullptr.

1:28 PM Changeset in webkit [108167] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix the ENABLE(THREADED_SCROLLING) build.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):

12:07 PM Changeset in webkit [108166] by fpizlo@apple.com

6 edits
12 adds
2 deletes in trunk/Source/JavaScriptCore

DFGPropagator.cpp has too many things
https://bugs.webkit.org/show_bug.cgi?id=78956

Reviewed by Oliver Hunt.

Added the notion of a DFG::Phase. Removed DFG::Propagator, and took its
various things and put them into separate files. These new phases follow
the naming convention "DFG<name>Phase" where <name> is a noun. They are
called via functions of the form "perform<name>".

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
dfg/DFGArithNodeFlagsInferencePhase.cpp: Added.

(DFG):
(JSC::DFG::performArithNodeFlagsInference):

dfg/DFGArithNodeFlagsInferencePhase.h: Added.

(DFG):

dfg/DFGCFAPhase.cpp: Added.

(DFG):
(JSC::DFG::performCFA):

dfg/DFGCFAPhase.h: Added.

(DFG):

dfg/DFGCSEPhase.cpp: Added.

(DFG):
(JSC::DFG::performCSE):

dfg/DFGCSEPhase.h: Added.

(DFG):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGPhase.cpp: Added.

(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):

dfg/DFGPhase.h: Added.

(DFG):
(Phase):
(JSC::DFG::Phase::Phase):
(JSC::DFG::Phase::~Phase):
(JSC::DFG::Phase::globalData):
(JSC::DFG::Phase::codeBlock):
(JSC::DFG::Phase::profiledBlock):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
(JSC::DFG::runPhase):

dfg/DFGPredictionPropagationPhase.cpp: Added.

(DFG):
(JSC::DFG::performPredictionPropagation):

dfg/DFGPredictionPropagationPhase.h: Added.

(DFG):

dfg/DFGPropagator.cpp: Removed.
dfg/DFGPropagator.h: Removed.
dfg/DFGVirtualRegisterAllocationPhase.cpp: Added.

(DFG):
(JSC::DFG::performVirtualRegisterAllocation):

dfg/DFGVirtualRegisterAllocationPhase.h: Added.

(DFG):

11:58 AM Changeset in webkit [108165] by kling@webkit.org

7 edits in trunk/Source/WebCore

HTML: Remove unnecessary attributeChange() overrides.
<http://webkit.org/b/78890>

Reviewed by Anders Carlsson.

Move logic from attributeChanged() overrides into parseAttribute().
This is a step towards making attributeChanged() non-virtual.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLMediaElement.h:

(HTMLMediaElement):

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute):

html/HTMLScriptElement.h:

(HTMLScriptElement):

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute):

html/HTMLTrackElement.h:

(HTMLTrackElement):

11:53 AM Changeset in webkit [108164] by kling@webkit.org

4 edits in trunk/Source/WebCore

Remove Element::createAttribute().
<http://webkit.org/b/78965>

Reviewed by Anders Carlsson.

Switch call sites to use Attribute::create() directly, as there is no magic
in calling Element::createAttribute() anymore (it used to be virtual and handled
differently by StyledElement.)

dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

dom/Element.h:
svg/properties/SVGAnimatedPropertySynchronizer.h:

11:48 AM Changeset in webkit [108163] by kling@webkit.org

2 edits in trunk/Source/WebCore

HTMLBodyElement: Avoid synchronous style recalc when setting link/vlink/alink.
<http://webkit.org/b/78959>

Reviewed by Anders Carlsson.

Mark the body element for deferred style recalc instead of doing it synchronously
when the attributes change.

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseAttribute):

10:33 AM Changeset in webkit [108162] by Martin Robinson

2 edits in trunk/Source/WebCore

Fix the TextureMapper build for non-Qt ports. Qt debug builds
must use RTTI, but GTK+, at least, does not.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Make the RTTI check
Qt only.

10:17 AM Changeset in webkit [108161] by kevino@webkit.org

2 edits in trunk/Tools

[wx] Unreviewed build fix. Don't error out or hang if we have
downloaded dependencies but server update check fails.

5:04 AM Changeset in webkit [108160] by Csaba Osztrogonác

6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r107971.

platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
platform/qt/test_expectations.txt:

4:59 AM Changeset in webkit [108159] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, skip new failing tests.

platform/qt/Skipped:

4:51 AM Changeset in webkit [108158] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

Unreviewed gardening r108133.

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

3:42 AM Changeset in webkit [108157] by kling@webkit.org

5 edits in trunk

FontFamilyValue: Utilize inheritance from CSSPrimitiveValue better.
<http://webkit.org/b/78806>

Reviewed by Antti Koivisto.

Source/WebCore:

Now that FontFamilyValue's string doesn't change after creation, we can just
pass the massaged family name up to the CSSPrimitiveValue constructor and get
cached cssText() for free. This also shrinks FontFamilyValue by sizeof(String)
though that's less of an issue now that we cache them in CSSValuePool.

css/FontFamilyValue.cpp:

(WebCore::stripFontFamilyJunk):
(WebCore::FontFamilyValue::FontFamilyValue):

css/FontFamilyValue.h:

(WebCore::FontFamilyValue::familyName):
(FontFamilyValue):

LayoutTests:

Rebaseline as CSSPrimitiveValue.getStringValue() is no longer broken for
font-family values.

fast/dom/setPrimitiveValue-exceptions-expected.txt:

12:25 AM Changeset in webkit [108156] by Lucas Forschler

5 edits in branches/safari-534.54-branch/Source

Versioning

12:19 AM Changeset in webkit [108155] by Lucas Forschler

1 copy in tags/Safari-534.54.16

New tag.

Feb 17, 2012:

11:56 PM Changeset in webkit [108154] by fpizlo@apple.com

16 edits in trunk/Source/JavaScriptCore

DFG::Graph should have references to JSGlobalData, the CodeBlock being compiled, and
the CodeBlock that was used for profiling
https://bugs.webkit.org/show_bug.cgi?id=78954

Reviewed by Gavin Barraclough.

bytecode/CodeBlock.h:

(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::execute):

dfg/DFGAbstractState.h:
dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::parse):

dfg/DFGByteCodeParser.h:

(DFG):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

dfg/DFGGraph.h:

(JSC::DFG::Graph::Graph):
(Graph):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::globalCFA):
(JSC::DFG::propagate):

dfg/DFGPropagator.h:

(DFG):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):

11:28 PM Changeset in webkit [108153] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

There is a warning in memset in glibc that gets triggered through a
warndecl when the fill-value of memset is a non-zero constant and the
size is zero. This warning is enabled when building with
-D_FORTIFY_SOURCE=2. This patch fixes the warning.

https://bugs.webkit.org/show_bug.cgi?id=78513

Patch by Ahmad Sharif <asharif.tools@gmail.com> on 2012-02-17
Reviewed by Alexey Proskuryakov

wtf/Vector.h:

7:22 PM Changeset in webkit [108152] by adamk@chromium.org

4 edits
4 adds in trunk

Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
https://bugs.webkit.org/show_bug.cgi?id=76087

Reviewed by Ryosuke Niwa.

Source/WebCore:

Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.

Tests: fast/dom/getElementById-consistency.html

fast/dom/getElementById-consistency2.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.

LayoutTests:

fast/dom/getElementById-consistency-expected.txt: Added.
fast/dom/getElementById-consistency.html: Added.
fast/dom/getElementById-consistency2-expected.txt: Added.
fast/dom/getElementById-consistency2.html: Added.

6:51 PM Changeset in webkit [108151] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit/gtk

[GTK] change the way of registering DeviceOrientation clients.
https://bugs.webkit.org/show_bug.cgi?id=78680

Reviewed by Gustavo Noronha Silva.

Bug 78085 removed deviceOrientationClient and deviceMotionClient from PageClients. Instead,
DeviceOrientationClient and DeviceMotionClient should be registered by PageSupplement class.
Chromium, mac and qt ports are already changed by Bug 78085.

webkit/webkitwebview.cpp:

(webkit_web_view_init):

6:46 PM Changeset in webkit [108150] by jsbell@chromium.org

22 edits
2 adds in trunk

IndexedDB: Support overloaded methods that take IDBKey or IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=78399

Source/WebCore:

Implements IDBObjectStore.delete(IDBKeyRange) to exercise the functionality.

Reviewed by Tony Chang.

Test: storage/indexeddb/delete-range.html

bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallString): Use .get() to disambiguate when passing RefPtr.

bindings/scripts/test/V8/V8TestObj.cpp: Update test expectations.
storage/IDBLevelDBBackingStore.cpp:

(WebCore):

storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteFunction):
(WebCore):

storage/IDBObjectStore.h:

(IDBObjectStore):

storage/IDBObjectStore.idl:
storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

storage/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

storage/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

Implements the WebKit API for IDBObjectStore.delete(IDBKeyRange),
to exercise the overload capability.

Reviewed by Tony Chang.

src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::deleteFunction):
(WebKit):

src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::deleteFunction):
(WebKit):

src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

LayoutTests:

Tests IDBObjectStore.delete(IDBKeyRange). The spec has been updated such
that delete() always yields a result of undefined rather than a boolean,
so other test expectations are updated.

Reviewed by Tony Chang.

storage/indexeddb/delete-range-expected.txt: Added.
storage/indexeddb/delete-range.html: Added.
storage/indexeddb/mozilla/delete-result-expected.txt:
storage/indexeddb/mozilla/delete-result.html:
storage/indexeddb/objectStore-required-arguments-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/resources/objectstore-basics.js:

(createIndex):
(removeSuccess):
(removeSuccessButNotThere):

6:20 PM Changeset in webkit [108149] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Replace [V8OnInstance] with [V8Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=78894

Reviewed by Adam Barth.

[V8OnInstance] means that the method should be defined
(not on a prototype chain but) on a DOM object. It is the
same meaning as [V8Unforgeable]. This patch replaces [V8OnInstance]
with [V8Unforgeable].

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

page/Location.idl:

6:07 PM Changeset in webkit [108148] by leviw@chromium.org

20 edits in branches/subpixellayout/Source/WebCore

Adding pixel snapped methods to FractionalLayoutRect. Adding a roundToInt abstraction, using it everywhere except FractionalLayout* classes, and correcting a ton of incorrect rounding methods. Cleaning up RenderInline::paintOutlineForLine. Fixing a crash in adjustRectForColumns.

6:03 PM Changeset in webkit [108147] by jamesr@google.com

6 edits
1 add
1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening, update baselines for svg/dynamic-updates/.. and some more getComputedStyle
results

platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Removed.
platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:

5:19 PM Changeset in webkit [108146] by jamesr@google.com

2 edits
1 move in trunk/Source/WebCore

[chromium] Unreviewed build fix. MSVS gyp generator can't handle multiple .cpps with the same name in the same
target from different paths.

WebCore.gypi:
page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Renamed from Source/WebCore/page/scrolling/chromium/ScrollingCoordinator.cpp.

(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

5:02 PM Changeset in webkit [108145] by jamesr@google.com

2 edits in trunk/Source/WebCore

Unreviewed mac compile fix pt 2

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

5:01 PM Changeset in webkit [108144] by dpranke@chromium.org

4 edits in trunk/Tools

The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
https://bugs.webkit.org/show_bug.cgi?id=69444

Reviewed by Tony Chang.

Currently if a test's image checksum doesn't match the checksum
in the baseline, but the images themselves match according to
ImageDiff, new-run-webkit-tests ignores the problem. This is
probably bad, but it's not yet clear what the right thing to do
is. This patch will log a warning to stderr, at least (but the
test will still pass).

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):

Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_list):

Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

4:56 PM Changeset in webkit [108143] by dpranke@chromium.org

4 edits in trunk/Tools

NRWT does not report failure for a skipped test
https://bugs.webkit.org/show_bug.cgi?id=78750

Reviewed by Eric Seidel.

If a test is listed in a Skipped file and you run it anyway
with --force, and the test fails, currently NRWT will print
"test ran as expected"; this is confusing, because you probably
expect the test to fail and yet this might lead you to think the
test passed. This patch changes the expected behavior to "PASS",
so tests that fail will be reported.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(result_was_expected):
(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_add_skipped_tests):

Scripts/webkitpy/layout_tests/port/test.py:

(unit_test_list): Add some tests that are expected to be in a Skipped file.
(TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.

4:50 PM Changeset in webkit [108142] by jamesr@google.com

3 edits in trunk/Source/WebCore

Unreviewed mac compile fix (unused parameter warning)

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

4:33 PM Changeset in webkit [108141] by dpranke@chromium.org

3 edits in trunk/Tools

webkitpy: fix test code after bug 78181
https://bugs.webkit.org/show_bug.cgi?id=78870

Reviewed by Adam Barth.

I forgot to update the test code as per Tony's suggestion in
bug 78181 (r108005). This change does that, and in doing so
it revealed a subtle bug in _InlineWorkerConnection.run() that
I am fixing as part of this (_alive would not be cleared if an
exception was thrown).

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_InlineWorkerConnection.run):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestWorker.handle_stop):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.handle_exception):
(_TestsMixin.test_unknown_message):

4:23 PM Changeset in webkit [108140] by jamesr@google.com

23 edits
1 copy
1 add in trunk/Source/WebCore

Move ScrollingCoordinator out of ENABLE(THREADED_SCROLLING) ifdef and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=78401

Reviewed by Adam Barth.

Separates THREADED_SCROLLING from ScrollingCoordinator and enables ScrollingCoordinator-related code on
chromium. ScrollingCoordinator receives scrolling information to be used with an external scrolling source.
ENABLE(THREADED_SCROLLING) enables a codepath that uses a thread in WebCore to handle scrolling related input
events and interact with composited layers.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

page/FrameView.cpp:

(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::performPostLayoutTasks):

page/Page.cpp:

(WebCore::Page::~Page):
(WebCore):

page/Page.h:

(Page):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(Settings):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore):

page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::createThreadIfNeeded):

page/scrolling/ScrollingTreeState.cpp:
page/scrolling/ScrollingTreeState.h:
page/scrolling/chromium/ScrollingCoordinator.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore):

rendering/RenderLayerCompositor.h:

(WebCore):
(RenderLayerCompositor):

4:14 PM Changeset in webkit [108139] by jamesr@google.com

5 edits in trunk/LayoutTests

[chromium] Unreviewed - removing expectations for tests that consistently pass, update some baselines for
getComputedStyle due to new -webkit-line-align property.

platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium/test_expectations.txt:

4:02 PM Changeset in webkit [108138] by eae@chromium.org

8 edits
1 add in trunk/Source/WebCore

Add FractionalLayoutPoint for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78913

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Point class and a couple of
conversion methods to the Int and Float versions of same.

No new tests.

GNUmakefile.list.am:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/FloatPoint.cpp:

(WebCore::FloatPoint::FloatPoint):
(WebCore):
(WebCore::FloatPoint::moveBy):

platform/graphics/FloatPoint.h:

(WebCore):
(FloatPoint):

platform/graphics/FractionalLayoutPoint.h: Added.

(WebCore):
(FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::zero):
(WebCore::FractionalLayoutPoint::x):
(WebCore::FractionalLayoutPoint::y):
(WebCore::FractionalLayoutPoint::setX):
(WebCore::FractionalLayoutPoint::setY):
(WebCore::FractionalLayoutPoint::move):
(WebCore::FractionalLayoutPoint::moveBy):
(WebCore::FractionalLayoutPoint::scale):
(WebCore::FractionalLayoutPoint::expandedTo):
(WebCore::FractionalLayoutPoint::shrunkTo):
(WebCore::FractionalLayoutPoint::clampNegativeToZero):
(WebCore::FractionalLayoutPoint::transposedPoint):
(WebCore::operator+=):
(WebCore::operator-=):
(WebCore::operator+):
(WebCore::operator-):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::toPoint):
(WebCore::toSize):
(WebCore::flooredIntPoint):
(WebCore::roundedIntPoint):
(WebCore::ceiledIntPoint):

platform/graphics/FractionalLayoutSize.cpp:

(WebCore::pixelSnappedIntSize):

platform/graphics/FractionalLayoutSize.h:

(WebCore):

3:57 PM Changeset in webkit [108137] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

Move textDirectionForSelection from Editor to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=78868

Reviewed by Enrica Casucci.

Move textDirectionForSelection from Editor to EditingStyle to centralize the editing code's
dependency on CSSStyleDeclaration.

editing/EditingStyle.cpp:

(WebCore::EditingStyle::textDirectionForSelection):
(WebCore):

editing/EditingStyle.h:

(EditingStyle):

editing/Editor.cpp:

(WebCore):

editing/Editor.h:

(Editor):

editing/EditorCommand.cpp:

(WebCore::stateTextWritingDirection):

editing/ReplaceSelectionCommand.cpp:
editing/markup.cpp:

3:33 PM Changeset in webkit [108136] by commit-queue@webkit.org

9 edits in trunk/Source/WebCore

MathML internals - embellished operators, getBase() accessor functions
https://bugs.webkit.org/show_bug.cgi?id=78617

Patch by David Barton <Dave Barton> on 2012-02-17
Reviewed by Eric Seidel.

Define functions that return an unembellished "base", by omitting
subscripts/superscripts, underscripts/overscripts, or denominators. This is needed in
subsequent patches both for correct operator stretching and simple code factoring.

No new tests.

rendering/mathml/RenderMathMLBlock.h:

(WebCore):
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::unembellishedOperator):

rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::unembellishedOperator):
(WebCore):

rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::unembellishedOperator):

rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::base):
(WebCore):
(WebCore::RenderMathMLSubSup::unembellishedOperator):
(WebCore::RenderMathMLSubSup::stretchToHeight):

renamed a variable for clarity, especially in later patches

(WebCore::RenderMathMLSubSup::layout):

renamed a variable for clarity, especially in later patches

rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::base):
(WebCore):
(WebCore::RenderMathMLUnderOver::unembellishedOperator):
(WebCore::RenderMathMLUnderOver::stretchToHeight):

rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

3:28 PM Changeset in webkit [108135] by noam.rosenthal@nokia.com

11 edits in trunk/Source

[Qt][WK2] Allow opaque tiles
https://bugs.webkit.org/show_bug.cgi?id=78809

Source/WebCore:

Replace the isOpaque boolean in BitmapTexture to a SupportsAlpha flag.
Use reset/didReset instead of a virtual function that has to call the superclass.

Make sure that all calls to BitmapTexture::reset() pass the correct SupportsAlpha flag,
based on the source image.
Since we now disable blending for opaque textures, we also have to make sure that we treat
the depth buffer correctly and bring it back to its previous state.

Reviewed by Kenneth Rohde Christiansen.

No behavior changes.

platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(WebCore::TextureMapperGLData::initStencil):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::beginClip):

platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::flags):
(WebCore::BitmapTexture::didReset):
(WebCore::BitmapTexture::reset):
(BitmapTexture):

platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):

platform/graphics/texmap/TextureMapperBackingStore.h:

(TextureMapperTiledBackingStore):

platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::didReset):
(WebCore):

platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

Source/WebKit2:

Apply the SupportsAlpha flag only when the buffers actually have alpha.

Reviewed by Kenneth Rohde Christiansen.

Shared/ShareableBitmap.h:

(ShareableBitmap):

Shared/qt/ShareableBitmapQt.cpp:
UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):

3:16 PM Changeset in webkit [108134] by commit-queue@webkit.org

7 edits
2 adds in trunk

Crash in SVGAnimateElement due to changed target
https://bugs.webkit.org/show_bug.cgi?id=75096

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGAnimateElement object creates various internal objects
depending on the type of property being animated, which depends on the
target. These objects were not being recreated when the target
changed, and crashes ensued. Now the SVGSMILElement provides a virtual
method that is called when the target changes, and SVGAnimateElement
updates its objects as necessary. We also deactivate the animation
when the target changes, forcing recomputation of other derived
objects.

This change also removes various unnecessary calls to semi-expensive
methods.

Not only does this change fix the new test, it also fixes potential
crashes in other tests that apparently never manifested before (but
manifest when this new test is included in DRT).

Test: svg/animations/svglength-animation-retarget-crash.html

svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::calculateDistance):
(WebCore):
(WebCore::SVGAnimateElement::targetElementDidChange):

svg/SVGAnimateElement.h:

(SVGAnimateElement):

svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::type):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::targetElement):
(WebCore::SVGSMILElement::resetTargetElement):
(WebCore):

svg/animation/SVGSMILElement.h:

(SVGSMILElement):
(WebCore::SVGSMILElement::targetElementDidChange):

LayoutTests:

This test verifies that the target element information is correctly
updated when the target changes. Note that the clone is required, as
it causes the results of one animation to be pushed to a different
animation.

svg/animations/svglength-animation-retarget-crash-expected.txt: Added.
svg/animations/svglength-animation-retarget-crash.html: Added.

3:13 PM Changeset in webkit [108133] by hyatt@apple.com

15 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=78934

Add the -webkit-line-align property to support the alignment of lines in the inline direction
to the line grid.

Reviewed by Dan Bernstein.

Source/WebCore:

Added fast/line-grid/line-align-parsing.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator LineAlign):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

css/CSSValueKeywords.in:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:
rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests:

fast/line-grid/line-align-parsing-expected.txt: Added.
fast/line-grid/line-align-parsing.html: Added.
fast/line-grid/script-tests/line-align-parsing.js: Added.

3:08 PM Changeset in webkit [108132] by Lucas Forschler

4 edits in trunk/Source

Versioning.

3:07 PM Changeset in webkit [108131] by eae@chromium.org

10 edits
2 adds in trunk/Source/WebCore

Add FractionalLayoutSize for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78852

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Size class and a couple of
conversion methods to the Int and Float versions of same.

No new tests.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/FloatPoint.cpp:

(WebCore::FloatPoint::move):
Add FractionalLayoutSize version of move.

platform/graphics/FloatPoint.h:
platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::FloatSize):
Add FloatSize(FractionalLayoutSize) constructor.

platform/graphics/FloatSize.h:
platform/graphics/FractionalLayoutSize.cpp: Added.
platform/graphics/FractionalLayoutSize.h: Added.

2:57 PM Changeset in webkit [108130] by jamesr@google.com

1 edit
1 move
2 adds in trunk/LayoutTests

[chromium] Unreviewed. Land the last (hopefully) new baselines for fast/css/non-empty-span.html

platform/chromium-mac-leopard/fast/css/non-empty-span-expected.png: Added.
platform/chromium-win/fast/css/non-empty-span-expected.png: Added.
platform/chromium-win/fast/css/non-empty-span-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/non-empty-span-expected.txt.

2:50 PM Changeset in webkit [108129] by eae@chromium.org

34 edits in branches/subpixellayout/Source

Avoid unnecessary rounding/snapping and replace LayoutUnit(0) with constant.

2:44 PM Changeset in webkit [108128] by enrica@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r107606): Copy Link writes malformed WebURLsWithTitlesPboardType
data to the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=78933
<rdar://problem/10874553>

For this format, the data needs to be placed in the pasteboard as array of arrays
of strings. Currently is it stored as array of strings, which causes the code
that uses this format to break.

Reviewed by Ryosuke Niwa.

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setPathnamesForType):

2:36 PM Changeset in webkit [108127] by inferno@chromium.org

6 edits
12 adds in trunk

Incorrect placement of a new child when beforeChild and its
previous sibling are in the same table.
https://bugs.webkit.org/show_bug.cgi?id=78269

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/table-cell-split.html

fast/table/table-row-split.html
fast/table/table-section-split-with-after-content.html
fast/table/table-section-split.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitAnonymousBlocksAroundChild): add
call to splitTablePartsAroundChild to take care of splitting the
table first if the child is part of table.
(WebCore::markTableForSectionAndCellRecalculation): add helper to
mark table for complete relayout by invalidating sections and cells.
(WebCore):
(WebCore::moveAllTableChildrenTo): moves children to another table.
(WebCore::RenderBlock::splitTablePartsAroundChild): split table child
and its next siblings into a new table. This allows adding a new
non-table child between the tables.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): calls
splitTablePartsAroundChild to see if we need to split the table
for adding this new child.

rendering/RenderBlock.h:

(RenderBlock):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createAnonymousTable): add helper for
creating anonymous table.
(WebCore):
(WebCore::RenderObject::addChild): use the new helper for creating
anonymous table.

rendering/RenderObject.h:

(WebCore):
(RenderObject):
(WebCore::RenderObject::isTablePart): add helper to tell if the object
is a table part.

LayoutTests:

Test passes if the div child splits the table parts and is not
part of table itself.

fast/table/table-cell-split-expected.txt: Added.
fast/table/table-cell-split.html: Added.
fast/table/table-row-split-expected.txt: Added.
fast/table/table-row-split.html: Added.
fast/table/table-section-split-expected.txt: Added.
fast/table/table-section-split-with-after-content-expected.txt: Added.
fast/table/table-section-split-with-after-content.html: Added.
fast/table/table-section-split.html: Added.

2:34 PM Changeset in webkit [108126] by kling@webkit.org

3 edits in trunk/Source/WebCore

Element: Inline style selector and AX invalidation in attributeChanged().
<http://webkit.org/b/78888>

Reviewed by Antti Koivisto.

Inline the updateAfterAttributeChanged() and recalcStyleIfNeededAfterAttributeChanged()
methods into Element::attributeChanged(). They were separated when we needed them in
StyledElement::attributeChanged(), but that's no longer the case.

dom/Element.cpp:

(WebCore::Element::attributeChanged):

dom/Element.h:

2:31 PM Changeset in webkit [108125] by Adam Roben

4 edits in trunk

Clang/Mac build fix after r108119

Source/WebKit2:

WebProcess/WebProcess.cpp:

(WebKit::randomCrashThread): Annotate this function with NO_RETURN_DUE_TO_CRASH.

Tools:

Mac build fix after r108119

DumpRenderTree/mac/DumpRenderTree.mm:

(runThread):
(runPthread):
(testThreadIdentifierMap):
Updated to match current WTF threading APIs.

2:25 PM Changeset in webkit [108124] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Chromium] Texture eviction doesn't show up in traces.
https://bugs.webkit.org/show_bug.cgi?id=78851

Patch by David Reveman <reveman@chromium.org> on 2012-02-17
Reviewed by James Robinson.

Add TextureManager::evictTexture() function with TRACE statement so
that texture eviction shows up in traces.

No new tests.

platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::evictTexture):
(WebCore):
(WebCore::TextureManager::reduceMemoryToLimit):

platform/graphics/chromium/TextureManager.h:

(TextureManager):

2:22 PM Changeset in webkit [108123] by abarth@webkit.org

1 delete in trunk/Source/WebCore/manual-tests

Remove empty directory.

2:21 PM Changeset in webkit [108122] by Lucas Forschler

1 copy in tags/Safari-535.21

New Tag.

2:09 PM Changeset in webkit [108121] by jamesr@google.com

1 edit
2 adds in trunk/LayoutTests

[chromium] Unreviewed - add some more fast/css/non-empty-span expectations.

platform/chromium-mac-snowleopard/fast/css/non-empty-span-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/non-empty-span-expected.txt: Added.

2:00 PM Changeset in webkit [108120] by jamesr@google.com

2 edits
2 moves in trunk/LayoutTests

[chromium] Unreviewed baseline and expectation updates.

platform/chromium-linux/fast/css/non-empty-span-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.png.
platform/chromium-linux/fast/css/non-empty-span-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt.
platform/chromium/test_expectations.txt:

1:54 PM Changeset in webkit [108119] by commit-queue@webkit.org

49 edits in trunk/Source

Remove unused parameters from WTF threading API
https://bugs.webkit.org/show_bug.cgi?id=78389

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-17
Reviewed by Adam Roben.

waitForThreadCompletion() had an out param 'void result' to get the
'void *' returned by ThreadFunction. However, the implementation in
ThreadingWin.cpp ignored the out param, not filling it in. This had
led to a situation where none of the client code made use of the param
and just ignored it.

To clean this up, the patch changes the signature of ThreadFunction to
return void instead of void* and drops the the unused 'void result'
parameter from waitForThreadCompletion. Also, all client code is
updated for the API change.

As mentioned in https://bugs.webkit.org/show_bug.cgi?id=78389 , even
though the change only affects internal API, Safari is using it
directly and we'll need to keep the old versions around for ABI
compatibility. For this, the patch adds compatibility wrappers with
the old ABI.

Source/JavaScriptCore:

JavaScriptCore.order:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
bytecode/SamplingTool.cpp:

(JSC::SamplingThread::threadStartFunc):
(JSC::SamplingThread::stop):

bytecode/SamplingTool.h:

(SamplingThread):

heap/Heap.cpp:

(JSC::Heap::~Heap):
(JSC::Heap::blockFreeingThreadStartFunc):

heap/Heap.h:
heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::~MarkStackThreadSharedData):

heap/MarkStack.h:

(MarkStackThreadSharedData):

wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::workerThread):

wtf/ParallelJobsGeneric.h:

(ThreadPrivate):

wtf/ThreadFunctionInvocation.h: Update the signature of

ThreadFunction.
(WTF):

wtf/Threading.cpp:

(WTF::threadEntryPoint): Update for ThreadFunction signature change.
(WTF):
(WTF::ThreadFunctionWithReturnValueInvocation::ThreadFunctionWithReturnValueInvocation):
ABI compatibility function for Safari.
(ThreadFunctionWithReturnValueInvocation): Ditto.
(WTF::compatEntryPoint): Ditto.
(WTF::createThread): Ditto.
(WTF::waitForThreadCompletion): Ditto.

wtf/Threading.h: Update the signature of ThreadFunction and

waitForThreadCompletion.
(WTF):

wtf/ThreadingPthreads.cpp: Implement the new API.

(WTF::wtfThreadEntryPoint):
(WTF):
(WTF::createThreadInternal):
(WTF::waitForThreadCompletion):

wtf/ThreadingWin.cpp: Implement the new API.

(WTF::wtfThreadEntryPoint):
(WTF::waitForThreadCompletion):

Source/WebCore:

bindings/js/GCController.cpp:

(WebCore::collect):
(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):

fileapi/FileThread.cpp:

(WebCore::FileThread::fileThreadStart):
(WebCore::FileThread::runLoop):

fileapi/FileThread.h:

(FileThread):

loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::close):
(WebCore::IconDatabase::iconDatabaseSyncThreadStart):
(WebCore::IconDatabase::iconDatabaseSyncThread):
(WebCore::IconDatabase::syncThreadMainLoop):

loader/icon/IconDatabase.h:

(IconDatabase):

page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::threadCallback):

page/scrolling/ScrollingThread.h:

(ScrollingThread):

platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::databaseLoaderEntry):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):

platform/audio/ReverbConvolver.cpp:

(WebCore::backgroundThreadEntry):
(WebCore::ReverbConvolver::~ReverbConvolver):

platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::runLoaderThread):

storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThreadStart):
(WebCore::DatabaseThread::databaseThread):

storage/DatabaseThread.h:

(DatabaseThread):

storage/LocalStorageThread.cpp:

(WebCore::LocalStorageThread::threadEntryPointCallback):
(WebCore::LocalStorageThread::threadEntryPoint):
(WebCore::LocalStorageThread::terminate):

storage/LocalStorageThread.h:

(LocalStorageThread):

webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::~AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::threadEntry):

webaudio/AsyncAudioDecoder.h:

(AsyncAudioDecoder):

webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::uninitialize):
(WebCore::OfflineAudioDestinationNode::renderEntry):

webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThreadStart):
(WebCore::WorkerThread::workerThread):

workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/win:

WebKit.vcproj/WebKit_Cairo.def: Add the new functions.
WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.

Source/WebKit2:

Platform/WorkQueue.h:

(WorkQueue):

Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::startWorkQueueThread):

UIProcess/Launcher/mac/ThreadLauncherMac.mm:

(WebKit::webThreadBody):

UIProcess/Launcher/qt/ThreadLauncherQt.cpp:

(WebKit::webThreadBody):

UIProcess/Launcher/win/ThreadLauncherWin.cpp:

(WebKit::webThreadBody):

WebProcess/WebProcess.cpp:

(WebKit::randomCrashThread):

win/WebKit2.def:
win/WebKit2CFLite.def:

1:53 PM Changeset in webkit [108118] by dpranke@chromium.org

2 edits in trunk/Tools

revert r107147 - breaks webkit-patch on Mac SL
https://bugs.webkit.org/show_bug.cgi?id=78866

Reviewed by Adam Barth.

It appears that zipfile.ExtractAll is broken on Python 2.6.1,
which is the version that ships on Mac SL. Reverting this
change until we no longer have to worry about that version.

Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller):
(AutoInstaller._extract_all): Added a comment about SL.
(AutoInstaller._unzip):

1:48 PM Changeset in webkit [108117] by robert@webkit.org

2 edits in trunk/Source/WebCore

AppleMac Build fix for r108111

Remove variable that is now unused.

Unreviewed, build fix.

rendering/RenderBlockLineLayout.cpp:

(WebCore::alwaysRequiresLineBox): Remove lineInfo
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

1:40 PM Changeset in webkit [108116] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] GL_CHROMIUM_gpu_memory_manager extension
https://bugs.webkit.org/show_bug.cgi?id=77155

Patch by Michal Mocny <mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):

Source/WebKit/chromium:

public/platform/WebGraphicsContext3D.h:

(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):

src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):

src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

src/GraphicsContext3DPrivate.h:

(WebCore):

tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):

1:40 PM WebDevelopers edited by michael-gawlik@web.de

(diff)

1:36 PM Changeset in webkit [108115] by wjmaclean@chromium.org

2 edits in trunk/LayoutTests

[chromium] Re-enable compositing/culling/scrolled-within-boxshadow.html
https://bugs.webkit.org/show_bug.cgi?id=78859

Reviewed by James Robinson.

platform/chromium/test_expectations.txt:

1:28 PM Changeset in webkit [108114] by commit-queue@webkit.org

5 edits
6 adds in trunk/LayoutTests

[chromium] Rebaseline tests for composited filters
https://bugs.webkit.org/show_bug.cgi?id=78903

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-17
Reviewed by Stephen White.

compositing/culling/filter-occlusion-alpha-large.html:
compositing/culling/filter-occlusion-alpha.html:
compositing/culling/filter-occlusion-blur-large.html:
compositing/culling/filter-occlusion-blur.html:
platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Added.
platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png: Added.
platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png: Added.

1:23 PM Changeset in webkit [108113] by jamesr@google.com

4 edits in trunk/LayoutTests

[chromium] Update baselines for border-radius-wide-border-01 due to skia change. Unreviewed.

platform/chromium-linux/fast/borders/border-radius-wide-border-01-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-radius-wide-border-01-expected.png:
platform/chromium-win/fast/borders/border-radius-wide-border-01-expected.png:

1:17 PM Changeset in webkit [108112] by oliver@apple.com

15 edits
3 adds in trunk

Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Implement support for stack traces on exception objects. This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.

interpreter/Interpreter.cpp:

(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

interpreter/Interpreter.h:

(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):

jsc.cpp:

(GlobalObject::finishCreation):
(functionJSCStack):

parser/Nodes.h:

(JSC::FunctionBodyNode::setInferredName):

parser/Parser.h:

(JSC::::parse):

runtime/CommonIdentifiers.h:
runtime/Error.cpp:

(JSC::addErrorInfo):

runtime/Error.h:

(JSC):

LayoutTests:

Add testcases for producing a stack trace on exception objects.

fast/js/exception-properties-expected.txt:
fast/js/script-tests/exception-properties.js:
fast/js/script-tests/stack-trace.js: Added.

(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):

fast/js/stack-trace-expected.txt: Added.
fast/js/stack-trace.html: Added.

1:10 PM Changeset in webkit [108111] by robert@webkit.org

4 edits
5 adds in trunk

REGRESSION: empty span creates renders with non-zero height
https://bugs.webkit.org/show_bug.cgi?id=76465

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/css/empty-span.html

fast/css/non-empty-span.html

Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.

This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size

will need a linebox if the rest of the line is not empty.

(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark

the line non-empty - otherwise hold off.

LayoutTests:

fast/css/empty-span-expected.html: Added.
fast/css/empty-span.html: Added.
fast/css/non-empty-span.html: Added.
platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.

12:57 PM Changeset in webkit [108110] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

RealtimeAnalyserNode does not consistently respect .minDecibels
https://bugs.webkit.org/show_bug.cgi?id=78729

Make use of m_minDecibel consistent. Clean up some style issues
with names of local variables and style issues with float
constants.

Patch by Raymond Toy <Raymond Toy> on 2012-02-17
Reviewed by Chris Rogers.

No new tests because the changes are cosmetic for style issues.

webaudio/RealtimeAnalyser.cpp:

(WebCore):
(WebCore::RealtimeAnalyser::doFFTAnalysis):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):

12:51 PM Changeset in webkit [108109] by inferno@chromium.org

3 edits
3 adds in trunk

:before content incorrectly placed in continuation
when we don't have a first child.
https://bugs.webkit.org/show_bug.cgi?id=78380

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css-generated-content/before-content-continuation-chain.html

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

fast/css-generated-content/before-content-continuation-chain-expected.png: Added.
fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.
fast/css-generated-content/before-content-continuation-chain.html: Added.

12:44 PM Changeset in webkit [108108] by mihnea@adobe.com

34 edits
3 adds in trunk

CSS regions enabled by default
https://bugs.webkit.org/show_bug.cgi?id=78525

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/css-regions-disabled.html

Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
CSSRegions are still enabled by default.
In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.

WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::createRegionRule):

css/CSSParser.h:
dom/Document.cpp:

(WebCore::Document::cssRegionsEnabled):
(WebCore):
(WebCore::Document::webkitGetFlowByName):

dom/Document.h:

(Document):

dom/Element.cpp:

(WebCore::Element::webkitRegionOverflow):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setCSSRegionsEnabled):
(WebCore::Settings::cssRegionsEnabled):
(Settings):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setExperimentalCSSRegionsEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

Source/WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cssRegionsEnabled]):
(-[WebPreferences setCSSRegionsEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Shared/WebPreferencesStore.h:

(WebKit):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSRegionsEnabled):
(WKPreferencesGetCSSRegionsEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

fast/regions/css-regions-disabled-expected.txt: Added.
fast/regions/css-regions-disabled.html: Added.
fast/regions/script-tests/css-regions-disabled.js: Added.

(testWebKitFlowInto):
(testWebKitFlowFrom):
(testWebKitRegionOverflow):
(testComputedStyleWebKitFlowInto):
(testComputedStyleWebKitFlowFrom):
(testComputedStyleWebKitRegionOverflow):

12:09 PM Changeset in webkit [108107] by mhahnenberg@apple.com

16 edits
4 adds
4 deletes in trunk/Source/JavaScriptCore

Rename Bump* to Copy*
https://bugs.webkit.org/show_bug.cgi?id=78573

Reviewed by Geoffrey Garen.

Renamed anything with "Bump" in the name to have "Copied" instead.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
heap/BumpBlock.h: Removed.
heap/BumpSpace.cpp: Removed.
heap/BumpSpace.h: Removed.
heap/BumpSpaceInlineMethods.h: Removed.
heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::genericAddPointer):

heap/ConservativeRoots.h:

(ConservativeRoots):

heap/CopiedBlock.h: Added.

(JSC):
(CopiedBlock):
(JSC::CopiedBlock::CopiedBlock):

heap/CopiedSpace.cpp: Added.

(JSC):
(JSC::CopiedSpace::tryAllocateSlowCase):

heap/CopiedSpace.h: Added.

(JSC):
(CopiedSpace):
(JSC::CopiedSpace::isInCopyPhase):
(JSC::CopiedSpace::totalMemoryAllocated):
(JSC::CopiedSpace::totalMemoryUtilized):

heap/CopiedSpaceInlineMethods.h: Added.

(JSC):
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::pin):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::recycleBlock):
(JSC::CopiedSpace::getFreshBlock):
(JSC::CopiedSpace::borrowBlock):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::fitsInCurrentBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::allocateFromBlock):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::isOversize):
(JSC::CopiedSpace::isPinned):
(JSC::CopiedSpace::oversizeBlockFor):
(JSC::CopiedSpace::blockFor):

heap/Heap.cpp:
heap/Heap.h:

(JSC):
(Heap):

heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):

heap/MarkStack.h:

(MarkStackThreadSharedData):

heap/SlotVisitor.h:

(SlotVisitor):

runtime/JSArray.cpp:
runtime/JSObject.cpp:

12:07 PM Changeset in webkit [108106] by mjs@apple.com

2 edits in trunk/Tools

Some API tests erroneously use = instead of == (causing build failures)
https://bugs.webkit.org/show_bug.cgi?id=78915

Reviewed by Sam Weinig.

TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
(TestWebKitAPI::decidePolicyForNewWindowAction): ditto

12:05 PM Changeset in webkit [108105] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Case typo in fast/js/script-tests/date-constructor.js
https://bugs.webkit.org/show_bug.cgi?id=78898

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-02-17
Reviewed by Adam Barth.

fast/js/script-tests/date-constructor.js: toSTring to toString

12:00 PM Changeset in webkit [108104] by Martin Robinson

4 edits in trunk/Source/WebKit/gtk

[GTK] [AC] Events can starve accelerated compositing updates
https://bugs.webkit.org/show_bug.cgi?id=78826

Reviewed by Gustavo Noronha Silva.

Instead of using a WebCore timer, which can be starved by GdkEvents,
use a raw GLib timer with GDK_PRIORITY_EVENTS to drive AC updates.
This prevents dragging from blocking rendering.

WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Store a GLib source tag instead of a WebCore timer.

WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
Remove the timer upon destruction.
(WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer.
(WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer.
(WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto.

WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::~AcceleratedCompositingContext):
Remove the timer upon destruction.
(WebKit::syncLayersTimeoutCallback): Added this callback for the GLib timer.
(WebKit::AcceleratedCompositingContext::markForSync): Use a GLib timer.
(WebKit::AcceleratedCompositingContext::syncLayersTimeout): Ditto.

11:58 AM Changeset in webkit [108103] by mihnea@adobe.com

9 edits
2 adds in trunk

[CSSRegions]Implement NamedFlow::overflow
https://bugs.webkit.org/show_bug.cgi?id=78880

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/webkit-named-flow-overflow.html

dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):
(WebCore::WebKitNamedFlow::overflow):
(WebCore):

dom/WebKitNamedFlow.h:

(WebCore):
(WebCore::WebKitNamedFlow::create):
(WebKitNamedFlow):

dom/WebKitNamedFlow.idl:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::ensureNamedFlow):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

rendering/RenderFlowThread.h:

LayoutTests:

fast/regions/resources/helper.js:

(testContentToRegionsMapping):

fast/regions/resources/region-style.css:
fast/regions/webkit-named-flow-overflow-expected.txt: Added.
fast/regions/webkit-named-flow-overflow.html: Added.

11:56 AM Changeset in webkit [108102] by commit-queue@webkit.org

19 edits in trunk

flex-wrap:nowrap should be flex-wrap:none
https://bugs.webkit.org/show_bug.cgi?id=78772

As per the spec http://dev.w3.org/csswg/css3-flexbox/#flex-wrap0, flex-wrap:nowrap should be changed to flex-wrap:none.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-17
Reviewed by Ojan Vafai.

Source/WebCore:

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):

css/CSSValueKeywords.in:
rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h:

LayoutTests:

css3/flexbox/css-properties-expected.txt:
css3/flexbox/script-tests/css-properties.js:
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

11:54 AM Changeset in webkit [108101] by enrica@apple.com

14 edits in trunk/Source

Refactor DragData class to use PlatformStrategies in the Mac implementation.
https://bugs.webkit.org/show_bug.cgi?id=78768

Reviewed by Darin Adler.

Source/WebCore:

No new tests. No behavior change.

WebCore.exp.in: Added new exported method of the PlatformPasteboard class.
platform/DragData.h:

(WebCore::DragData::pasteboardName): Added pasteboardName and removed pasteboard.

platform/PasteboardStrategy.h: Added color() method.
platform/PlatformPasteboard.h: Ditto.
platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create): Changed to use pasteboardName() method.

platform/mac/DragDataMac.mm: All the methods below have been changed to use pasteboardName

and the pasteboardStrategy() methods.
(WebCore::DragData::DragData):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::color): Added implementation of the color() method.

Source/WebKit/mac:

WebCoreSupport/WebPlatformStrategies.h: Added color() method.
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::color):

Source/WebKit2:

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added color() method.

(WebKit::WebPlatformStrategies::color):

WebProcess/WebCoreSupport/WebPlatformStrategies.h:

11:45 AM Changeset in webkit [108100] by Nate Chapin

3 edits in trunk/Source/WebCore

2012-02-17 Nate Chapin <Nate Chapin>

[Chromium mac] Cursors and background images disappear.
https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

rendering/style/StyleCachedImage.cpp:
rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

11:08 AM Changeset in webkit [108099] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] pack Gamepad shared memory structure
https://bugs.webkit.org/show_bug.cgi?id=78022

Patch by Scott Graham <scottmg@chromium.org> on 2012-02-17
Reviewed by Darin Fisher.

Add #pragma pack around definition of shared memory structures to
avoid differences across compilers and platforms. Add COMPILE_ASSERT
to verify expected size.

public/platform/WebGamepad.h:

(WebKit):

public/platform/WebGamepads.h:

(WebKit):

11:02 AM Changeset in webkit [108098] by jchaffraix@webkit.org

5 edits
2 adds in trunk

Table cell's anonymous wrappers are left in the tree, impacting our layout
https://bugs.webkit.org/show_bug.cgi?id=7180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-switch-cell-position-bad-layout-expected.html

fast/table/table-switch-cell-position-bad-layout.html

This patch implements cell's anonymous wrapper removal at detach time.

Trimming the render tree when we remove objects from it would be more complex
to generalize as several objects override the behavior to do their own clean-ups.
This would also open more potential for programming errors.

This change is limited to table cells' as a simple step towards fixing bug 52123
and more generally eliminate some anonymous wrappers from the tree at detach time.

dom/Node.cpp:

(WebCore::Node::detach):
Patched detach to call destroyAndCleanupAnonymousWrappers. The Document does not need
to clean up any anonymous wrappers on detach.

rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Added this method to wrap destroy() call and trim the render tree. To avoid slowing down
detach in some cases, added a fast path.

rendering/RenderObject.h: Added destroyAndCleanupAnonymousWrappers.

LayoutTests:

fast/table/table-switch-cell-position-bad-layout-expected.html: Added.
fast/table/table-switch-cell-position-bad-layout.html: Added.

11:00 AM Changeset in webkit [108097] by rwlbuis@webkit.org

3 edits
2 adds in trunk

ASSERT (and crash) with dynamically moved <font-face>
https://bugs.webkit.org/show_bug.cgi?id=64839

Reviewed by Antti Koivisto.

Source/WebCore:

Reset the style declaration when rmeoving the font-face element from the document.

Test: svg/custom/font-face-move.svg

svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::removedFromDocument):

LayoutTests:

svg/custom/font-face-move-expected.txt: Added.
svg/custom/font-face-move.svg: Added.

10:55 AM Changeset in webkit [108096] by Lucas Forschler

2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r107966.

10:51 AM Changeset in webkit [108095] by Martin Robinson

6 edits in trunk/Source

Fix some warnings encountered during the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=78911

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. These are just fixes for warnings.

page/GestureTapHighlighter.cpp: Avoid using potentially signed operations on

a size_t type. Use size_t for iterating over members of a vector.

platform/graphics/texmap/TextureMapperBackingStore.cpp: Use size_t where necessary.

(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded): Ditto.

platform/graphics/texmap/TextureMapperLayer.cpp: Ditto.

(WebCore::TextureMapperLayer::computeTransformsRecursive): Ditto.
(WebCore::TextureMapperLayer::paintSelfAndChildren): Ditto.
(WebCore::TextureMapperLayer::intermediateSurfaceRect): Ditto.

Source/WebKit2:

UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Initialize a new member of the loader client struct.

10:47 AM Changeset in webkit [108094] by rniwa@webkit.org

5 edits
1 add in trunk

perf-o-matic needs model unit tests
https://bugs.webkit.org/show_bug.cgi?id=78885

Reviewed by Adam Barth.

Added unit tests for models.py.

Also renamed modelFromNumericId to model_from_numeric_id and moved set_persitent_cache and get_persistent_cache
from controller to PersistentCache.set_cache and PersistentCahce.set_cache respectively.

Websites/webkit-perf.appspot.com/controller.py:

(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):

Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler._create_builder):
(CreateHandler._create_builder.execute):

Websites/webkit-perf.appspot.com/models.py:

(create_in_transaction_with_numeric_id_holder):
(model_from_numeric_id):
(Builder):
(Builder.create):
(Builder.update_password):
(Builder._hashed_password):
(TestResult.key_name):
(ReportLog.get_value):
(ReportLog._integer_in_payload):
(ReportLog):
(ReportLog.timestamp):
(PersistentCache):
(PersistentCache.set_cache):
(PersistentCache.set_cache.execute):
(PersistentCache.get_cache):

Websites/webkit-perf.appspot.com/models_unittest.py: Added.

(HelperTests):
(HelperTests.setUp):
(HelperTests.tearDown):
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_model_from_numeric_id):
(HelperTests.test_model_from_numeric_id.execute):
(BuilderTests):
(BuilderTests.setUp):
(BuilderTests.tearDown):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(ReportLog):
(ReportLog.setUp):
(ReportLog.tearDown):
(ReportLog._create_log_with_payload):
(ReportLog.test_parsed_payload):
(ReportLog.test_get_value):
(ReportLog.test_results):
(ReportLog.test_builder):
(ReportLog.test_build_number):
(ReportLog.test_webkit_revision):
(ReportLog.chromium_revision):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.tearDown):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):

Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.post):

10:27 AM Changeset in webkit [108093] by commit-queue@webkit.org

13 edits in trunk/Source

[chromium] Refactor video drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76720

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

CCVideoLayerImpl no longer handles drawing itself, but produces a list of CCVideoDrawQuads.
These quads are then drawn by LayerRendererChromium.

CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
CCLayerImpl::didDraw() is called directly after all drawing has been completed.
CCLayerImpl::draw has been removed.

willDraw and didDraw are used to handle interaction with the VideoFrameProvider
in CCVideoLayerImpl. willDraw gets a frame from the VideoFrameProvider, and
didDraw returns it.

A unit test has been added: CCLayerTreeHostImplTest.didDrawCalledOnAllLayers.
This test ensures that CCLayerImpl::didDraw() is called on all layers,
including layers on different render surfaces.

As this was a refactor, no other tests were added.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore):
(WebCore::LayerRendererChromium::drawSingleTextureVideoQuad):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture):
(WebCore::LayerRendererChromium::copyFrameToTextures):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/cc/CCLayerImpl.cpp:
platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::didDraw):
(CCLayerImpl):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::textures):
(WebCore::CCVideoDrawQuad::frame):
(WebCore::CCVideoDrawQuad::format):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):

platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::providerMutex):
(WebCore::CCVideoLayerImpl::provider):
(Texture):

Source/WebKit/chromium:

CCLayerTreeHostImplTest.didDrawCalledOnAllLayers ensures that
CCLayerImpl::didDraw() is called on all layers, including layers
on different render surfaces.

tests/CCLayerTreeHostImplTest.cpp:

(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::create):
(WebKit::DidDrawCheckLayer::didDraw):
(WebKit::DidDrawCheckLayer::didDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit):
(WebKit::TEST_F):

10:19 AM Changeset in webkit [108092] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] Allow printing scaled pages in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78823

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable scale option in print
dialog.

WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
manual scale to 1.
(WebKit::WebPrintOperationGtk::rotatePageIfNeeded): Renamed and
moved the needs rotate check here as an early return.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Scale the
page according to the manual scale factor.
(WebKit::WebPrintOperationGtk::renderPage): Move rotatePage to
prepareContextToDraw.

WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

10:17 AM Changeset in webkit [108091] by adamk@chromium.org

11 edits in branches/chromium/1025/Source

Merge 107170 - DOM mutations should not be delivered on worker threads
https://bugs.webkit.org/show_bug.cgi?id=77898

Reviewed by Dmitry Titov.

Source/WebCore:

In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.

This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).

Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.

See also http://crbug.com/112586, where the problem was initially
reported.

bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallback::call):

bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):

bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

bindings/v8/V8RecursionScope.h:

(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):

Source/WebKit/chromium:

src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

TBR=adamk@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9355009

10:09 AM Changeset in webkit [108090] by peter@chromium.org

2 edits in trunk/Tools

[Chromium] Include TestShellLinux.cpp in the build for Android
https://bugs.webkit.org/show_bug.cgi?id=78865

Reviewed by Eric Seidel.

Android will be re-using the TestShellLinux.cpp file. I already
added this r104033, but it seems to have gotten lost in the
recent refactorings.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

10:08 AM Changeset in webkit [108089] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] Allow printing multiple copies in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78805

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable multiple copies and
collate options in print dialog.

WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Initialize number of
collated and uncolated copies done and total.
(WebKit::PrintPagesData::collatedCopiesLeft): Helper function that
returns the number of collated copies left to do.
(WebKit::PrintPagesData::uncollatedCopiesLeft): Helper function
that returns the number of uncollated copies left to do.
(WebKit::PrintPagesData::copiesLeft): Helper function
that returns the number of collated or uncollated copies left to
do.
(WebKit::PrintPagesData::incrementPageSequence): Do not finish the
print if there are uncollated copies left, and do not increment
sheet number if there are collated copies left.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualCopies to 1 and m_manualCollateCopies to false.

WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

10:05 AM Changeset in webkit [108088] by jchaffraix@webkit.org

6 edits
2 adds
1 delete in trunk/LayoutTests

Unreviewed Chromium rebaseline after r107971.

platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-1-expected.png:
platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Added.
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.txt: Added.
platform/chromium-win-vista/tables/mozilla/bugs: Removed.
platform/chromium/test_expectations.txt:

10:00 AM Changeset in webkit [108087] by jamesr@google.com

6 edits
1 copy
2 moves
2 adds
4 deletes in trunk/LayoutTests

[chromium] Unreviewed, update chromium pixel baselines for r108079

fast/borders/border-mixed-alpha-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-mixed-alpha-expected.txt.
fast/borders/only-one-border-with-width-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/only-one-border-with-width-expected.txt.
platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png:
platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png:
platform/chromium-mac-snowleopard/fast/borders/only-one-border-with-width-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/color-leakage-expected.png: Added.
platform/chromium-win/fast/borders/border-mixed-alpha-expected.png:
platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
platform/chromium-win/fast/borders/only-one-border-with-width-expected.png: Copied from LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png.
platform/chromium-win/fast/css/color-leakage-expected.png:
platform/mac/fast/borders/border-mixed-alpha-expected.txt: Removed.
platform/mac/fast/borders/only-one-border-with-width-expected.txt: Removed.
platform/qt/fast/borders/border-mixed-alpha-expected.txt: Removed.
platform/qt/fast/borders/only-one-border-with-width-expected.txt: Removed.

9:43 AM Changeset in webkit [108086] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] Allow printing pages in reverse order in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78799

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable printing in reverse
order option in print dialog.

WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and lastPagePosition depending on whether printing is in reverse
order or not.
(WebKit::PrintPagesData::incrementPageSequence): Use a negative
increment step when printing in reverse order. Fix page
incrementing when printing only odd/even pages broken in previous
commit due to merge conflicts.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
reverse printing to false.

WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

9:25 AM Changeset in webkit [108085] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] Allow printing only odd/even pages in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78793

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable print odd/even pages
option in print dialog.

WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Add lastPagePosition and
initialize it depending on the page set.
(WebKit::PrintPagesData::incrementPageSequence): Use 2 step
increment when printing only odd/even pages.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualPageSet to GTK_PAGE_SET_ALL.

9:10 AM WebKit Team edited by Dimitri Glazkov

(diff)

9:06 AM Changeset in webkit [108084] by commit-queue@webkit.org

8 edits
2 adds in trunk

Crash at WebCore::SVGUseElement::expandSymbolElementsInShadowTree
https://bugs.webkit.org/show_bug.cgi?id=77639

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Fix a SVG crash in Release builds, although it still crashes in Debug builds.
The crash occurred when an SVG use element attempted to reference a style element while the file
contained an error causing the error banner to display. The fix is to prevent SVGUseElement
from recalculating style during tree building and return immediately when style is recalculated and
the tree is building.

Test: svg/custom/use-referencing-style-crash.svg

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::willRecalcStyle): Return false if the tree is being built.
(WebCore::SVGUseElement::didRecalcStyle): Check and return if the tree
is being built and we are not yet ready for style update.

LayoutTests:

Fix a SVG crash in Release builds, although it still crashes in Debug builds.
This test is to verify no crash in Release builds, while expectations/Skipped
are added for Debug builds. Bug 77764 tracks the Debug fix.

platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
svg/custom/use-referencing-style-crash-expected.txt: Added.
svg/custom/use-referencing-style-crash.svg: Added.

8:55 AM Changeset in webkit [108083] by loislo@chromium.org

6 edits in trunk/Source/WebCore

Unreviewed, rolling out r108077.
http://trac.webkit.org/changeset/108077
https://bugs.webkit.org/show_bug.cgi?id=78390

it broke compilation.

inspector/CodeGeneratorInspector.py:
inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

inspector/InjectedScript.h:

(InjectedScript):

inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):

inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

8:50 AM Changeset in webkit [108082] by commit-queue@webkit.org

4 edits
2 adds in trunk

chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV@NULL (e85cb8e140071fa7790cad215b0109dc)
https://bugs.webkit.org/show_bug.cgi?id=74858

Patch by Florin Malita <fmalita@google.com> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/custom/tref-remove-target-crash-expected.svg

svg/custom/tref-remove-target-crash.svg

Add a DOMNodeRemovedFromDocumentEvent listener to detect when the target element is removed. Upon removal,
cleanup all listeners and re-activate the pending resource to attach if the referenced ID is added
at a later time programmatically. Also move the DOMSubtreeModifiedEvent listener from the parent to
the target element to simplify the implementation and reduce the scope.

svg/SVGTRefElement.cpp:

(WebCore::TargetListener::create):
(WebCore::TargetListener::cast):
(WebCore::TargetListener::clear):
(WebCore::TargetListener::TargetListener):
(WebCore::TargetListener::operator==):
(WebCore::TargetListener::handleEvent):
(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

svg/SVGTRefElement.h:

LayoutTests:

svg/custom/tref-remove-target-crash-expected.svg: Added.
svg/custom/tref-remove-target-crash.svg: Added.

8:48 AM Changeset in webkit [108081] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix the build after r108077.

inspector/CodeGeneratorInspector.py:

(RawTypes.Any.generate_validate_method):

8:42 AM Changeset in webkit [108080] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

[GTK] Allow printing multiple pages per sheet in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78715

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialogUnix): Enable multiple pages per
sheet options in print dialog.

WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and numberOfSheets. Move pagePosition to WebPrintOperationGtk.
(WebKit::PrintPagesData::incrementPageSequence): Increment current
sheet and page position.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk):
(WebKit::WebPrintOperationGtk::currentPageIsFirstPageOfSheet):
Helper function to check whether current pages is the first one of
the current sheet.
(WebKit::WebPrintOperationGtk::currentPageIsLastPageOfSheet):
Helper function to check whether current pages is the last one of
the current sheet.
(WebKit::WebPrintOperationGtk::getRowsAndColumnsOfPagesPerSheet):
Returns the number of rows and columns of pages per sheet.
(WebKit::WebPrintOperationGtk::getPositionOfPageInSheet): Returns
the row and column number of the current page in the current sheet.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Translate,
scale and rotate accordingly to render every page in the right
place of the sheet.
(WebKit::WebPrintOperationGtk::renderPage): Call
prepareContextToDraw() before drawing the page.

WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

(WebKit::WebPrintOperationGtk::setNumberOfPagesToPrint):
(WebKit::WebPrintOperationGtk::pagePosition):
(WebKit::WebPrintOperationGtk::setPagePosition):
(WebKit::WebPrintOperationGtk::numberUp):
(WebKit::WebPrintOperationGtk::numberUpLayout):

8:40 AM Changeset in webkit [108079] by Simon Fraser

2 edits in trunk/Source/WebCore

Avoid using a transparency layer for rgba() border drawing when possible
https://bugs.webkit.org/show_bug.cgi?id=63176

Reviewed by Dan Bernstein.

The non-radiused border drawing code would use a transparency layer
when drawing any one or more borders with alpha colors. However,
we only need to use a transparency layer when there is a corner
join between the borders being rendered with any one color,
so add a utility function includesAdjacentEdges() that can tell us
that, and use it to avoid making extraneous transparency layers.

Optimization only, no new tests.

rendering/RenderBoxModelObject.cpp:

(WebCore::includesAdjacentEdges):
(WebCore):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

8:39 AM Changeset in webkit [108078] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2012-02-17 Pavel Feldman <pfeldman@google.com>

Not reviewed: Qt minimal build fix.

inspector/InjectedScript.h: (WebCore):

8:25 AM Changeset in webkit [108077] by vsevik@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-17
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

inspector/CodeGeneratorInspector.py:
inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

inspector/InjectedScript.h:

(InjectedScript):

inspector/InspectorDebuggerAgent.cpp:

inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

8:17 AM Changeset in webkit [108076] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: hide color picker on selected node update.
https://bugs.webkit.org/show_bug.cgi?id=78896

Reviewed by Vsevolod Vlasov.

inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.prototype.get visible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

8:13 AM Changeset in webkit [108075] by pfeldman@chromium.org

3 edits
4 adds in trunk

Web Inspector: check undo-redo boundaries based on current action index, not history size.
https://bugs.webkit.org/show_bug.cgi?id=78895

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests: inspector/elements/perform-undo-undo.html

inspector/styles/perform-undo-perform-of-mergable-action.html

inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::perform):

LayoutTests:

inspector/elements/perform-undo-undo-expected.txt: Added.
inspector/elements/perform-undo-undo.html: Added.
inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Added.
inspector/styles/perform-undo-perform-of-mergable-action.html: Added.

8:06 AM Changeset in webkit [108074] by loislo@chromium.org

8 edits in trunk/Source

Unreviewed, rolling out r108071.
http://trac.webkit.org/changeset/108071
https://bugs.webkit.org/show_bug.cgi?id=77155

chromium-mac compilation failed

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

public/platform/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

src/Extensions3DChromium.cpp:
src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

src/GraphicsContext3DPrivate.h:

(WebCore):

tests/FakeWebGraphicsContext3D.h:

7:53 AM Changeset in webkit [108073] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, skipping 2 new test failures on GTK.

platform/gtk/Skipped:
platform/gtk/test_expectations.txt:

7:48 AM Changeset in webkit [108072] by loislo@chromium.org

2 edits in trunk/LayoutTests

Web Inspecter: Unreviewed. Adjust expectation for script-formatter-console.html

platform/chromium/test_expectations.txt:

7:41 AM Changeset in webkit [108071] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] GL_CHROMIUM_gpu_memory_manager extension
https://bugs.webkit.org/show_bug.cgi?id=77155

Patch by Michal Mocny <mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):

Source/WebKit/chromium:

public/platform/WebGraphicsContext3D.h:

src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):

src/GraphicsContext3DChromium.cpp:

src/GraphicsContext3DPrivate.h:

(WebCore):

tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):

6:42 AM Changeset in webkit [108070] by kubo@profusion.mobi

2 edits in trunk/Source/WebKit/efl

[EFL] Unreviewed, adapt to the changes introduced in r107973.

SVN r107973 moved some libsoup feature initialization code to
WebCore, but only changed the GTK+ bits in WebKit.

ewk/ewk_main.cpp:

(_ewk_init_body): Do not initialize the content sniffer and the
decoder here, the initialization is now done in WebCore.

6:32 AM Changeset in webkit [108069] by Carlos Garcia Campos

7 edits in trunk/Source/WebKit2

[GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78893

Reviewed by Gustavo Noronha Silva.

And it's not emitted anynmore when the print dialog has been
cancelled. Since it's not possible to know whether the print
dialog was cancelled or not, the enum WebKitPrintOperationResponse
has been added, with Print and Cancel values, and it's used as
return value of webkit_print_operation_run_dialog().

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkit_print_operation_class_init): Rename done as finished.
(webkitPrintOperationRunDialogUnix): Return a
WebKitPrintOperationResponse instead of bool.
(webkitPrintOperationRunDialogWin32): Ditto.
(drawPagesForPrintingCompleted): Emit finished instead of done.
(webkitPrintOperationRunDialogForFrame): Do not emit finished if
the dialog was cancelled and return a WebKitPrintOperationResponse.
(webkit_print_operation_run_dialog): Return
WebKitPrintOperationResponse.

UIProcess/API/gtk/WebKitPrintOperation.h: Add

WebKitPrintOperationResponse enum.

UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Check whether the dialog has been
cancelled or not and connect to finish when the print operation is
in progress to release the print operation object when printing
finishes.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add

WebKitPrintOperationResponse symbol.

UIProcess/API/gtk/tests/TestPrinting.cpp:

(testPrintOperationPrintFinished): Use finished instead of done.
(testPrintOperationPrint): Ditto.

6:25 AM Changeset in webkit [108068] by Carlos Garcia Campos

6 edits in trunk/Source/WebKit2

[GTK] Add webkit_print_operation_print() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76536

Reviewed by Gustavo Noronha Silva.

UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationPrintPagesForFrame): Helper function to call
WebPageProxy::drawPagesForPrinting using the given
GtkPrintSettings and GtkPageSetup.
(webkitPrintOperationRunDialogForFrame): Use
webkitPrintOperationPrintPagesForFrame().
(webkit_print_operation_print): Print directly using current
GtkPrintSettings and GtkPageSetup without showing the print
dialog.

UIProcess/API/gtk/WebKitPrintOperation.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/tests/GNUmakefile.am:
UIProcess/API/gtk/tests/TestPrinting.cpp:

(testPrintOperationPrintLoadChanged):
(testPrintOperationPrintDone):
(testPrintOperationPrintPrinter):
(testPrintOperationPrint):
(beforeAll):
(afterAll):

6:19 AM Changeset in webkit [108067] by kubo@profusion.mobi

3 edits in trunk/Source/WebCore

[CMake, EFL] Unreviewed, fix the build when building with
SHARED_CORE=ON after r107820.

RunLoopEfl.cpp has not been upstreamed yet, and building only
RunLoop.cpp created an .so with some missing, unimplemented
symbols. The BlackBerry port seems to be in the same situation.

The best solution for now is to build RunLoop.cpp only on the
WinCE port.

CMakeLists.txt: Remove RunLoop.cpp from the list of files to build.
PlatformWinCE.cmake: Add RunLoop.cpp to the list of files to build.

5:40 AM Changeset in webkit [108066] by kubo@profusion.mobi

2 edits in trunk/Source/WebKit/efl

Unreviewed, fix the build with ENABLE(DEVICE_ORIENTATION) after
r107518. The EFL EWS bot doesn't enable that flag, so the breakage
was not spotted earlier.

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

5:14 AM Changeset in webkit [108065] by pfeldman@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: a bit of color picker polish
https://bugs.webkit.org/show_bug.cgi?id=78892

Fixed computed style swatch
Removed color: caption
Rendered value as source code, user-selectable
Removed scroller gap

Reviewed by Yury Semikhatsky.

English.lproj/localizedStrings.js:
inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):

inspector/front-end/Spectrum.js:
inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

inspector/front-end/elementsPanel.css:

(.spectrum-container):
(.spectrum-display-value):
(.spectrum-range-container):

inspector/front-end/popover.css:

(.popover .content.fixed-height):

5:14 AM Changeset in webkit [108064] by loislo@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Chromium DEPS roll

DEPS: from 122122 to 122498

4:45 AM Changeset in webkit [108063] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

Unreviewed, disable video build on EFL until it can be
supported by EFL build bot.

Scripts/build-webkit:

4:31 AM Changeset in webkit [108062] by pfeldman@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: color picker does not allow changing the color.
https://bugs.webkit.org/show_bug.cgi?id=78886

Reviewed by Vsevolod Vlasov.

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._showPopover.showPopover):

inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):

inspector/front-end/Settings.js:
inspector/front-end/Spectrum.js:
inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

4:28 AM Changeset in webkit [108061] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: new image preview has poorly positioned popover arrow.
https://bugs.webkit.org/show_bug.cgi?id=78884

Reviewed by Vsevolod Vlasov.

inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):

inspector/front-end/utilities.js:

(Element.prototype.boxInWindow):

4:23 AM Changeset in webkit [108060] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #34 of N. Restore/move following tests back in BUGCR9950
group with a WIN exception for an IMAGE failure.

WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE

platform/chromium/test_expectations.txt:

3:41 AM Changeset in webkit [108059] by pfeldman@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: enable "Single click CSS editing" experiment by default.
https://bugs.webkit.org/show_bug.cgi?id=78881

Reviewed by Vsevolod Vlasov.

inspector/front-end/elementsPanel.css:

(.styles-section .properties .enabled-button):

3:40 AM Changeset in webkit [108058] by pfeldman@chromium.org

8 edits in trunk

Web Inspector: split innerUpdate into rebuildUpdate and refreshUpdate, make computed styles load lazily.
https://bugs.webkit.org/show_bug.cgi?id=78827

Reviewed by Vsevolod Vlasov.

Source/WebCore:

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._validateNode):
(WebInspector.StylesSidebarPane.prototype._styleSheetOrMediaQueryResultChanged):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylesSidebarPane.prototype._innerRefreshUpdate):
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.waitForStyles):

inspector/styles/undo-add-property.html:
inspector/styles/undo-change-property.html:
inspector/styles/updates-during-dom-traversal.html:
inspector/styles/updates-throttled.html:

3:11 AM Changeset in webkit [108057] by noel.gordon@gmail.com

8 edits
2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #32 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
platform/chromium-win/tables/mozilla/core/row_span-expected.png:
platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
platform/chromium/test_expectations.txt:

3:09 AM Changeset in webkit [108056] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] Implement zoom in/out in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75253

Reviewed by Gustavo Noronha Silva.

MiniBrowser/gtk/BrowserWindow.c:

(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowUpdateZoomActions):
(webViewZoomLevelChanged):
(zoomInCallback):
(zoomOutCallback):
(browser_window_init):
(browserWindowConstructed):

3:09 AM Changeset in webkit [108055] by noam.rosenthal@nokia.com

7 edits in trunk/Source

[Qt][WK2] Allow partial updates
https://bugs.webkit.org/show_bug.cgi?id=78824

Source/WebCore:

BitmapTextureGL should not zero-fill the textures when resetting.
This was needed in the previous buffer management system, where texture were not completely
filled by the backing store.

Reviewed by Simon Hausmann.

No new behavior.

platform/graphics/opengl/TextureMapperGL.cpp:

(BitmapTextureGL):
(WebCore::texSubImage2DResourceSafe):
(WebCore):
(WebCore::BitmapTextureGL::reset):

Source/WebKit2:

Instead of using UpdateInfo to fill the entire tile's texture, we use it as a patch that
contains only the dirty rectangle of the current paint. This requires a lot less memory
for small updates, for example when typing a text in an input field.
This shows a significant reduction in overhead when testing on Mac with Instruments.

Reviewed by Simon Hausmann.

UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit):
(WebKit::LayerBackingStore::updateTile):

UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):

UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::updateTileForLayer):

WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

3:07 AM Changeset in webkit [108054] by Nikolas Zimmermann

2 edits in trunk/Tools

layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Adam Roben.

Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
Size the web view before running the test, not when dumping.
All platforms handle this correctly now.

DumpRenderTree/win/DumpRenderTree.cpp:

(dump):
(sizeWebViewForCurrentTest):
(runTest):

2:37 AM Changeset in webkit [108053] by Carlos Garcia Campos

2 edits in trunk

Unreviewed. Fix GTK+ build after r108003.

Source/autotools/symbols.filter: Add missing symbol.

2:28 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu

set environment variables for sysroot before building (diff)

2:25 AM WebKitIDL edited by haraken@chromium.org

(diff)

2:22 AM WebKitIDL edited by haraken@chromium.org

(diff)

2:15 AM WebKitIDL edited by haraken@chromium.org

(diff)

1:47 AM Changeset in webkit [108052] by noel.gordon@gmail.com

8 edits
2 adds
2 deletes in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #33 of N. See also bug 78219.

platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
platform/chromium/test_expectations.txt:

1:25 AM WebKitGTK/WebKit2Roadmap created by Carlos Garcia Campos

1:22 AM Changeset in webkit [108051] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[Forms] Integrate InputType::dispatchChangeEventInResponseToSetValue into InputType::setValue
https://bugs.webkit.org/show_bug.cgi?id=78873

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-17
Reviewed by Kent Tamura.

This patch moves event dispatch logic to InputType and TextFieldInputType from HTMLInputElement
and merge dispatchChangeEventInResponseToSetValue to setValue.

No new tests. No change in behavior.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Move dispatch logic to InputType and TextFieldInput.

html/InputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
html/InputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.

(WebCore::InputType::setValue): Move code from dispatchChangeEventInResponseToSetValue.

html/TextFieldInputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
html/TextFieldInputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.

(WebCore::TextFieldInputType::setValue): Move code from dispatchChangeEventInResponseToSetValue. Stop dispatching event in InputType::setValue.

html/HTMLTextFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent to public from protected for accessing from InputType class.

1:22 AM WebKitIDL edited by haraken@chromium.org

(diff)

1:09 AM Changeset in webkit [108050] by yurys@chromium.org

2 edits in trunk/Source/WebCore

2012-02-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mac build fix after r108047.

WebCore.xcodeproj/project.pbxproj:

1:01 AM Changeset in webkit [108049] by kling@webkit.org

3 edits in trunk/Source/WebCore

Removing the last presentation attribute should result in a null attributeStyle().
<http://webkit.org/b/78812>

Reviewed by Antti Koivisto.

If the collectStyleForAttribute() pass in updateAttributeStyle() doesn't encounter any
respected presentation attributes, set a null attributeStyle() instead of an empty one.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

12:44 AM Changeset in webkit [108048] by noel.gordon@gmail.com

4 edits
2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #31 of N. Any reasons for the MAC exception have been lost
in time, like tears in rain. Remove the MAC exception, update all pixel results.

platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
platform/chromium/test_expectations.txt:

12:33 AM Changeset in webkit [108047] by yurys@chromium.org

19 edits
2 adds in trunk/Source/WebCore

Web Inspector: use static counters for estimation of allocated Documents, Nodes and JS EventListeners
https://bugs.webkit.org/show_bug.cgi?id=78825

Introduced static counters of allocated Documents, Nodes and JS EventListeners.
Their values are displayed on the Timeline panel.

Reviewed by Pavel Feldman.

CMakeLists.txt:
English.lproj/localizedStrings.js:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):

dom/Document.h:

(WebCore::Node::Node):

dom/Node.cpp:

(WebCore::Node::~Node):

inspector/InspectorAllInOne.cpp:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorCounters.cpp: Added.

(WebCore):
(WebCore::InspectorCounters::counterValue):

inspector/InspectorCounters.h: Added.

(WebCore):
(InspectorCounters):
(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getDocumentCount):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):

12:08 AM Changeset in webkit [108046] by Philippe Normand

4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r108034.

platform/gtk/fast/dom/Window/window-properties-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:

12:06 AM Changeset in webkit [108045] by noel.gordon@gmail.com

8 edits
2 adds in trunk/LayoutTests

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #30 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-linux/tables/mozilla/core/misc-expected.png:
platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-win/tables/mozilla/core/misc-expected.png:
platform/chromium/test_expectations.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed