Timeline

Feb 20, 2012:

11:54 PM Changeset in webkit [108317] by abarth@webkit.org

• 2 edits in trunk/Tools

mastercfg_unittest.py fails without simplejson
​https://bugs.webkit.org/show_bug.cgi?id=79070

Reviewed by Csaba Osztrogonác.

Now that we require Python 2.6 (and higher) we can import json rather
than simplejson. We still need to use the simplejson name because
that's what the master.cfg script expects.

• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):

11:51 PM Changeset in webkit [108316] by Martin Robinson

• 3 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging r108279

11:49 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

11:48 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

11:47 PM Changeset in webkit [108315] by Martin Robinson

• 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r108313

11:46 PM Changeset in webkit [108314] by Martin Robinson

• 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r108312

11:45 PM Changeset in webkit [108313] by Martin Robinson

• 2 edits in trunk/Source/WebKit/gtk

Fix GTK+ unit tests after r108281.

Reviewed by Alejandro G. Castro.

• tests/testwebplugindatabase.c:

(test_webkit_web_plugin_database_get_plugins): Update the description used
in the test.

11:44 PM Changeset in webkit [108312] by Martin Robinson

• 2 edits in trunk/Source/WebKit/gtk

Fix GTK+ unit tests after r108278.

Reviewed by Alejandro G. Castro.

Now that WebCore is no longer stealing focus, we need to
adjust where we grab focus to ensure that it actually succeeds.

• tests/testcopyandpaste.c:

(map_event_cb): No longer grab focus here.
(runPasteTestCallback): Grabbing focus here seems to be late enough in the process.

11:41 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

11:32 PM Changeset in webkit [108311] by abarth@webkit.org

• 4 edits in trunk

Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
​https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

• html5lib/resourcesl/webkit-02.dat:

11:07 PM Changeset in webkit [108310] by abarth@webkit.org

• 7 edits
  11 moves in trunk/Source/WebCore

Unite TextTrack-related files with their friends in WebCore/html/track
​https://bugs.webkit.org/show_bug.cgi?id=78941

Reviewed by Eric Seidel.

The code that supports <track> seems to be split between the
WebCore/html directory and the WebCore/html/track directory. This
patch unites this code in the WebCore/html/track directory.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:
• html/LoadableTextTrack.cpp: Removed.
• html/LoadableTextTrack.h: Removed.
• html/TextTrack.cpp: Removed.
• html/TextTrack.h: Removed.
• html/TextTrack.idl: Removed.
• html/TextTrackCue.cpp: Removed.
• html/TextTrackCue.h: Removed.
• html/TextTrackCue.idl: Removed.
• html/TextTrackCueList.cpp: Removed.
• html/TextTrackCueList.h: Removed.
• html/TextTrackCueList.idl: Removed.
• html/track/LoadableTextTrack.cpp: Copied from Source/WebCore/html/LoadableTextTrack.cpp.
• html/track/LoadableTextTrack.h: Copied from Source/WebCore/html/LoadableTextTrack.h.
• html/track/TextTrack.cpp: Copied from Source/WebCore/html/TextTrack.cpp.
• html/track/TextTrack.h: Copied from Source/WebCore/html/TextTrack.h.
• html/track/TextTrack.idl: Copied from Source/WebCore/html/TextTrack.idl.
• html/track/TextTrackCue.cpp: Copied from Source/WebCore/html/TextTrackCue.cpp.
• html/track/TextTrackCue.h: Copied from Source/WebCore/html/TextTrackCue.h.
• html/track/TextTrackCue.idl: Copied from Source/WebCore/html/TextTrackCue.idl.
• html/track/TextTrackCueList.cpp: Copied from Source/WebCore/html/TextTrackCueList.cpp.
• html/track/TextTrackCueList.h: Copied from Source/WebCore/html/TextTrackCueList.h.
• html/track/TextTrackCueList.idl: Copied from Source/WebCore/html/TextTrackCueList.idl.

10:49 PM Changeset in webkit [108309] by fpizlo@apple.com

• 79 edits
  39 adds in trunk

JSC should be a triple-tier VM
​https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

• CMakeLists.txt:
• GNUmakefile.am:
• GNUmakefile.list.am:
• JavaScriptCore.pri:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
• JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• assembler/LinkBuffer.h:
• assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

• bytecode/BytecodeConventions.h: Added.
• bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

• bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

• bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

• bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

• bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

• bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

• bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

• bytecode/Opcode.cpp:

(JSC):

• bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

• bytecode/PutByIdStatus.h:

(PutByIdStatus):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOperations.cpp:
• heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

• heap/MarkStack.cpp:

(JSC::visitChildren):

• heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

• heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

• interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

• interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

• interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

• interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

• jit/ExecutableAllocator.h:

(JSC):

• jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

• jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

• jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

• jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

• jit/JITExceptions.cpp:

(JSC::jitThrow):

• jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

• jit/JITStubs.h:

(JSC):

• jit/JSInterfaceJIT.h:
• llint: Added.
• llint/LLIntCommon.h: Added.
• llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

• llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

• llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

• llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

• llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

• llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

• llint/LLIntOfflineAsmConfig.h: Added.
• llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

• llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

• llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

• llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

• llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

• llint/LowLevelInterpreter.asm: Added.
• llint/LowLevelInterpreter.cpp: Added.
• llint/LowLevelInterpreter.h: Added.
• offlineasm: Added.
• offlineasm/armv7.rb: Added.
• offlineasm/asm.rb: Added.
• offlineasm/ast.rb: Added.
• offlineasm/backends.rb: Added.
• offlineasm/generate_offset_extractor.rb: Added.
• offlineasm/instructions.rb: Added.
• offlineasm/offset_extractor_constants.rb: Added.
• offlineasm/offsets.rb: Added.
• offlineasm/opt.rb: Added.
• offlineasm/parser.rb: Added.
• offlineasm/registers.rb: Added.
• offlineasm/self_hash.rb: Added.
• offlineasm/settings.rb: Added.
• offlineasm/transform.rb: Added.
• offlineasm/x86.rb: Added.
• runtime/CodeSpecializationKind.h: Added.

(JSC):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

• runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

• runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

• runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

• runtime/JSArray.h:

(JSC):
(JSArray):

• runtime/JSCell.h:

(JSC):
(JSCell):

• runtime/JSFunction.h:

(JSC):
(JSFunction):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

• runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

• runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

• runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

• runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

• runtime/JSString.h:

(JSC):
(JSString):

• runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

• runtime/JSValue.cpp:

(JSC::JSValue::description):

• runtime/JSValue.h:

(LLInt):
(JSValue):

• runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

• runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

• runtime/Options.h:

(Options):

• runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

• runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

• runtime/Structure.h:

(JSC):
(Structure):

• runtime/StructureChain.h:

(JSC):
(StructureChain):

• wtf/InlineASM.h:
• wtf/Platform.h:
• wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

• wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

• CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

• CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

• DumpRenderTree/efl/CMakeLists.txt:

10:38 PM Changeset in webkit [108308] by benjamin@webkit.org

• 18 edits
  1 copy
  3 deletes in trunk/Source

Get rid of the LocalizationStrategy
​https://bugs.webkit.org/show_bug.cgi?id=78324

Reviewed by Sam Weinig.

Source/WebCore:

Remove LocalizationStrategy and unify the localization behind
LocalizedStrings.h and LocalizedStrings.cpp.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.exp.in:
• WebCore.gypi:
• WebCore.order:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• platform/DefaultLocalizationStrategy.cpp: Removed.
• platform/DefaultLocalizationStrategy.h: Removed.
• platform/LocalizationStrategy.h: Removed.
• platform/LocalizedStrings.cpp:
• platform/LocalizedStrings.h:

(WebCore):

• platform/PlatformStrategies.cpp:
• platform/PlatformStrategies.h:

(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):

• platform/qt/LocalizedStringsQt.cpp: Copied from Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp.

Source/WebKit/qt:

Move the localization code from PlatformStrategiesQt.cpp
to LocalizedStringsQt.cpp.

Get rid of LocalizationStrategy from PlatformStrategiesQt

• WebCoreSupport/PlatformStrategiesQt.cpp:
• WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit/wince:

Remove a useless #include of LocalizationStrategy.h.

• WebCoreSupport/PlatformStrategiesWinCE.h:

10:34 PM Changeset in webkit [108307] by fpizlo@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out ​http://trac.webkit.org/changeset/108291
It completely broke the 32-bit JIT.

• heap/CopiedAllocator.h:
• heap/CopiedSpace.h:

(CopiedSpace):

• heap/Heap.h:

(JSC::Heap::allocatorForObjectWithDestructor):

• jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:

(JIT):

• jit/JITInlineMethods.h:

(JSC):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):

• runtime/JSArray.cpp:

(JSC::storageSize):
(JSC):

• runtime/JSArray.h:

(ArrayStorage):
(JSArray):

10:30 PM Changeset in webkit [108306] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r108259.

• platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.

10:23 PM Changeset in webkit [108305] by haraken@chromium.org

• 2 edits in trunk/Source/WebCore

Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
​https://bugs.webkit.org/show_bug.cgi?id=79064

Reviewed by Hajime Morita.

[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
But as far as I read the spec
(​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
is not yet initialized. In particular, there is no statement that says "null should
be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
Removing [TreatReturnedNullStringAsNull] does not change the current behavior.

Test: media/media-controller.html (No change in the test results.)

• html/HTMLMediaElement.idl:

10:17 PM Changeset in webkit [108304] by barraclough@apple.com

• 7 edits in trunk

Put should throw if prototype chain contains a readonly property.
​https://bugs.webkit.org/show_bug.cgi?id=79069

Reviewed by Oliver Hunt.

Currently we only check the base of the put, not the prototype chain.
Fold this check in with the test for accessors.

Source/JavaScriptCore:

• runtime/JSObject.cpp:

(JSC::JSObject::put):

• Updated to test all objects in the propotype chain for readonly properties.

(JSC::JSObject::putDirectAccessor):
(JSC::putDescriptor):

• Record the presence of readonly properties on the structure.

• runtime/Structure.cpp:

(JSC::Structure::Structure):

• hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.

• runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):

• hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.

(JSC::Structure::setContainsReadOnlyProperties):

• Added.

LayoutTests:

• fast/js/Object-defineProperty-expected.txt:
• fast/js/script-tests/Object-defineProperty.js:

(get shouldBeTrue):

• Added test case.

10:15 PM Changeset in webkit [108303] by hayato@chromium.org

• 11 edits in trunk/Source/WebCore

Use InsertinonPoint instead of HTMLContentElement.
​https://bugs.webkit.org/show_bug.cgi?id=78778

Reviewed by Hajime Morita.

Replace HTMLContentElement with InsertionPoint in NodeRenderingContext and HTMLContentSelection.
This is one of followup patches for r108207.

No new tests, no change in behavior.

• dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

• dom/NodeRenderingContext.h:

(WebCore):
(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):

• dom/ShadowRoot.h:

(WebCore):

• html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

• html/shadow/HTMLContentElement.h:

(HTMLContentElement):

• html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::select):

• html/shadow/HTMLContentSelector.h:

(WebCore):
(HTMLContentSelection):
(WebCore::HTMLContentSelection::insertionPoint):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):

• html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::selections):
(WebCore::InsertionPoint::hasSelection):
(InsertionPoint):

10:00 PM Changeset in webkit [108302] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

MathML internals - code clean-up for RenderMathMLSubSup
​https://bugs.webkit.org/show_bug.cgi?id=79063

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

In the next patch, I will shrink and revise the <msubsup> formatting code. To make this
easier to follow, I am first doing some simple code clean-up.

No new tests.

• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

• rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

• rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):

• There is no need to iterate over baseWrapper's children since it should have only one child, the base of the <msubsup>.

9:52 PM Changeset in webkit [108301] by haraken@chromium.org

• 2 edits in trunk/Source/WebCore

Replace [V8Custom=DOMWindowNOP] with [V8Custom]
​https://bugs.webkit.org/show_bug.cgi?id=79062

Reviewed by Adam Barth.

[V8Custom=DOMWindowNOP] is not implemented by CodeGeneratorV8.pm.
This patch replaces it with [V8Custom].

No new tests. No change in behavior.

• page/DOMWindow.idl:

9:28 PM Changeset in webkit [108300] by haraken@chromium.org

• 2 edits in trunk/Source/WebCore

[JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
​https://bugs.webkit.org/show_bug.cgi?id=79061

Reviewed by Adam Barth.

CSSStyleDeclaration.idl uses [JSGenerateIsReachable=ImplRoot],
but "ImplRoot" is not implemented in CodeGeneratorJS.pm.
This patch replaces [JSGenerateIsReachable=ImplRoot] with [JSGenerateIsReachable].

No tests. No change in behavior.

• css/CSSStyleDeclaration.idl:

9:25 PM Changeset in webkit [108299] by commit-queue@webkit.org

• 3 edits
  9 adds in trunk/LayoutTests

There is no complete test cases of optional arguments for MediaStream API and PeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=78578

Reviewed by Adam Barth.

• fast/mediastream/peerconnection-AttributesMethod-expected.txt: Added.
• fast/mediastream/peerconnection-AttributesMethod.html: Added.
• fast/mediastream/peerconnection-addstream-expected.txt:
• fast/mediastream/peerconnection-argument-types-expected.txt: Added.
• fast/mediastream/peerconnection-argument-types.html: Added.
• fast/mediastream/peerconnection-removestream-expected.txt: Added.
• fast/mediastream/peerconnection-removestream.html: Added.
• fast/mediastream/script-tests/AttributesMethod.js: Added.
• fast/mediastream/script-tests/argument-types.js: Added.
• fast/mediastream/script-tests/peerconnection-addstream.js:
• fast/mediastream/script-tests/peerconnection-removestream.js: Added.

Patch by Yanbin Zhang <​yanbin.zhang@intel.com> on 2012-02-20

9:21 PM Changeset in webkit [108298] by haraken@chromium.org

• 2 edits in trunk/Source/WebCore

[EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
​https://bugs.webkit.org/show_bug.cgi?id=79058

Reviewed by Adam Barth.

[EnabledAtRuntime] does not exist any longer. It should be [V8EnabledAtRuntime].

No tests.

• html/shadow/HTMLShadowElement.idl:

8:52 PM Changeset in webkit [108297] by haraken@chromium.org

• 11 edits in trunk/Source/WebCore

Replace [Callback=FunctionOnly] with [Callback]
​https://bugs.webkit.org/show_bug.cgi?id=79060

Reviewed by Adam Barth.

[Callback=FunctionOnly] is not implemented by any code generator.
This patch replaces it with [Callback].

No tests. No change in behavior.

• Modules/intents/IntentResultCallback.idl:
• Modules/intents/NavigatorIntents.idl:
• dom/RequestAnimationFrameCallback.idl:
• mediastream/NavigatorMediaStream.idl:
• mediastream/NavigatorUserMediaErrorCallback.idl:
• mediastream/NavigatorUserMediaSuccessCallback.idl:
• mediastream/PeerConnection.idl:
• mediastream/SignalingCallback.idl:
• page/PositionCallback.idl:
• page/PositionErrorCallback.idl:

8:17 PM Changeset in webkit [108296] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Need to override active/inactive text search highlight color for RenderThemeBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=78920

Override two functions for text search highlight colors so that we can
provide platform specified colors.

Patch by Andy Chen <​andchen@rim.com> on 2012-02-17
Reviewed by Antonio Gomes.

No function change so no new tests.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeBlackBerry::platformInactiveTextSearchHighlightColor):

• platform/blackberry/RenderThemeBlackBerry.h:

8:12 PM Changeset in webkit [108295] by yutak@chromium.org

• 4 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

• platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
• platform/chromium/fast/js/string-capitalization-expected.txt:
• platform/chromium/test_expectations.txt:

8:06 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

8:05 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

8:05 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

7:59 PM Changeset in webkit [108294] by Martin Robinson

• 2 edits in releases/WebKitGTK/webkit-1.8

Merging r108288

7:48 PM Changeset in webkit [108293] by jknotten@chromium.org

• 2 edits in trunk/Source/WebCore

Default canvas backing store to be 1:1 with specified dimensions.
​https://bugs.webkit.org/show_bug.cgi?id=78971

Reviewed by Adam Barth.

Although the canvas specification states that the backing image may
be larger than the user-specified dimensions, there are a number of
philip canvas tests that fail when the backing image data is not
1:1 with the specified canvas dimensions. These failures are
tracked in ​https://bugs.webkit.org/show_bug.cgi?id=73645

This change defaults the canvas backing store to be 1:1 with the
user-specified dimensions, while also providing an
ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
behaviour, so that the above bug may be more easily fixed.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):

7:24 PM Changeset in webkit [108292] by bashi@chromium.org

• 2 edits in trunk/Tools

Update pywebsocket to 0.7.2
​https://bugs.webkit.org/show_bug.cgi?id=79066

This version includes vendor-prefixed deflate-frame extension support.

Reviewed by Kent Tamura.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

7:20 PM Changeset in webkit [108291] by mhahnenberg@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Implement fast path for op_new_array in the baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

• heap/CopiedAllocator.h:

(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.

• heap/CopiedSpace.h:

(CopiedSpace): Friended the JIT to allow access to
(JSC::CopiedSpace::allocator):

• heap/Heap.h:

(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.

• jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.

• jit/JIT.h:

(JIT):

• jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): Just bails out to a stub call if we fail in any way on
the fast path.

• runtime/JSArray.cpp:

(JSC):

• runtime/JSArray.h: Added lots of offset functions for all the fields that we need to

initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

7:19 PM Changeset in webkit [108290] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk/Source/WebCore

Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=78785

Main Contributors:
Daniel Bates <​dbates@rim.com>
Bryan Gislason <​bgislason@rim.com>
Akash Vaswani <​akvaswani@rim.com>
Dave Battista <​dbattista@rim.com>
Robin Cao <​robin.cao@torchmobile.com.cn>
Genevieve Mak <​gmak@rim.com>
Mike Fenton <​mifenton@rim.com>

Patch by Mary Wu <​mary.wu@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

• platform/blackberry/RenderThemeBlackBerry.cpp: Added.
• platform/blackberry/RenderThemeBlackBerry.h: Added.

7:10 PM Changeset in webkit [108289] by commit-queue@webkit.org

• 4 edits
  1 move
  3 deletes in trunk/Source/WebCore

[GTK] [EFL] Collapse duplicate WebGL support code
​https://bugs.webkit.org/show_bug.cgi?id=78970

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

No new tests. This just cleans up duplicated code.

Centralize duplicated WebGL code for EFL and GTK+ in the Cairo
directory. This is in preparation for the changes necessary to
connect WebGL to the TextureMapper AC.

• GNUmakefile.list.am: Update source list.
• PlatformEfl.cmake: Update source list.
• platform/graphics/cairo/DrawingBufferCairo.cpp: Renamed from Source/WebCore/platform/graphics/gtk/DrawingBufferGtk.cpp.
• platform/graphics/cairo/GraphicsContext3DCairo.cpp: Integrated the code From GraphicsContext3DGtk.cpp.
• platform/graphics/efl/DrawingBufferEfl.cpp: Removed.
• platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed.
• platform/graphics/gtk/GraphicsContext3DGtk.cpp: Removed.

7:05 PM Changeset in webkit [108288] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] Turn on requestAnimationFrame for release builds
​https://bugs.webkit.org/show_bug.cgi?id=79038

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

• configure.ac: Turn on requestAnimationFrame by default.

6:53 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

6:51 PM Changeset in webkit [108287] by Martin Robinson

• 2 edits in releases/WebKitGTK/webkit-1.8

Merging r108277

6:48 PM Changeset in webkit [108286] by Martin Robinson

• 5 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108278

6:45 PM Changeset in webkit [108285] by Martin Robinson

• 12 edits in releases/WebKitGTK/webkit-1.8

Merging r108281

6:39 PM Changeset in webkit [108284] by Martin Robinson

• 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging rr108248

6:37 PM Changeset in webkit [108283] by Martin Robinson

• 4 edits
  4 deletes in releases/WebKitGTK/webkit-1.8

Merging r108237

6:35 PM Changeset in webkit [108282] by barraclough@apple.com

• 6 edits in trunk

DefineOwnProperty fails with numeric properties & Object.prototype
​https://bugs.webkit.org/show_bug.cgi?id=79059

Reviewed by Oliver Hunt.

ObjectPrototype caches whether it contains any numeric properties (m_hasNoPropertiesWithUInt32Names),
calls to defineOwnProperty need to update this cache.

Source/JavaScriptCore:

• runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

• runtime/ObjectPrototype.h:

(ObjectPrototype):

LayoutTests:

• fast/js/Object-defineProperty-expected.txt:
• fast/js/script-tests/Object-defineProperty.js:

(shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldThrow.Object.defineProperty):

6:27 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

6:19 PM Changeset in webkit [108281] by commit-queue@webkit.org

• 12 edits in trunk

[UNIX] Plugin information fields are not interpreted as UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=78635

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

This is tested by a change to TestNetscapePlugin and expectations updates.

• plugins/efl/PluginPackageEfl.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

• plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

• plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

Source/WebKit2:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

• Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin): Use String::fromUTF8.

Tools:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

• DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.

LayoutTests:

Update expectations to match the fact that TestNetscapePlugin is now
returning a Unicode character in the description field.

• platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
• platform/gtk/plugins/plugin-javascript-access-expected.txt:
• platform/qt/plugins/plugin-javascript-access-expected.txt:

6:16 PM Changeset in webkit [108280] by commit-queue@webkit.org

• 3 edits
  3 moves
  3 adds in trunk/Tools

[GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
​https://bugs.webkit.org/show_bug.cgi?id=78935

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Move the TestNetscapePlugin headers to a more appropriate directory and update
the build files to match.

• DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
• DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
• DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
• DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
• GNUmakefile.am: Ditto.

6:12 PM Changeset in webkit [108279] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Does not build on GNU Hurd
​https://bugs.webkit.org/show_bug.cgi?id=79045

Patch by Pino Toscano <​pino@debian.org> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

• wtf/Platform.h: define WTF_OS_HURD.
• wtf/ThreadIdentifierDataPthreads.cpp: adds a band-aid fix

for the lack of PTHREAD_KEYS_MAX definition, with a value which
should not cause issues.

6:04 PM Changeset in webkit [108278] by commit-queue@webkit.org

• 5 edits in trunk/Source

[GTK] Web content oftens steals focus from other widgets
​https://bugs.webkit.org/show_bug.cgi?id=77791

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

• platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setFocus): No longer do anything special to try
to grab "real" widget focus. This matches the behavior on Qt.

• plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::setFocus): Moved the focus handling to here.
This ensures that behavior for plugins does not change.

Source/WebKit/gtk:

• tests/testwebview.c: Added a WebKit1 test to verify this behavior.

6:02 PM Changeset in webkit [108277] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] Geolocation support should be on by default
​https://bugs.webkit.org/show_bug.cgi?id=79037

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

• configure.ac: Turn on geolocation support in release builds.

5:33 PM Changeset in webkit [108276] by yael.aharon@nokia.com

• 2 edits in trunk/Source/WebCore

Regression (108135) isOpaque() returns uninitialized variable.
​https://bugs.webkit.org/show_bug.cgi?id=79049

Reviewed by Noam Rosenthal.

isOpaque() should use the new m_flags instead of the old m_isOpaque.
No new tests. No new functionality.

• platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

5:27 PM Changeset in webkit [108275] by haraken@chromium.org

• 5 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

• bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
• bindings/scripts/test/CPP/WebDOMTestInterface.h:
• bindings/scripts/test/CPP/WebDOMTestObj.cpp:
• bindings/scripts/test/CPP/WebDOMTestObj.h:

5:20 PM Changeset in webkit [108274] by noam.rosenthal@nokia.com

• 3 edits in trunk/Source/WebCore

[Qt][WK2] Clipping is broken
​https://bugs.webkit.org/show_bug.cgi?id=78677

It's not necessary to add a full-viewport rect to the scissor clip stack.
It creates a situation where if there's a clip in the page, we return to
the viewport clip instead of applying the WebView's clip we got from the
scenegraph.

Also, it's unnecessary to clip before we paint the layer's content, we should
only clip afterwards, before painting the children.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

• platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::size):
(WebCore::scissorClip):
(WebCore):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::endScissorClip):

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):

5:15 PM Changeset in webkit [108273] by noam.rosenthal@nokia.com

• 2 edits in trunk/Source/WebCore

[Texmap] Layers and tiles appear to have missing pixels in their right/bottom borders
​https://bugs.webkit.org/show_bug.cgi?id=78961

The relativeSize member should point to one pixel before the edge, since it's used
by glVertexAttribPointer, which takes edge points and not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new funcionality.

• platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::didReset):

5:05 PM Changeset in webkit [108272] by commit-queue@webkit.org

• 17 edits
  11 adds in trunk

.: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Add Implementation for the Vibration API to the WebKit-EFL port.
​http://dev.w3.org/2009/dap/vibration/

• Source/cmake/OptionsEfl.cmake: Add ENABLE_VIBRATION feature.
• Source/cmakeconfig.h.cmake:

Source/WebCore: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

​http://dev.w3.org/2009/dap/vibration/
This patch implements navigator.webkitvibrate() API.
This API operates differently depending upon a given parameter:

1. It cancels vibration when given 0 or [].
2. It gives a vibration duration in milliseconds when given as a single integer value.
3. It gives a vibration pattern when given as an integer array. For instance, [1000 300 1000] generates a vibration of 1000ms followed by 300ms of idle time, and then creates another vibration of 1000ms.

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Test: fast/dom/navigator-vibration.html

• CMakeLists.txt:
• Modules/vibration/NavigatorVibration.cpp: Added.

(WebCore):
(WebCore::NavigatorVibration::NavigatorVibration):
(WebCore::NavigatorVibration::~NavigatorVibration):
(WebCore::NavigatorVibration::webkitVibrate):
Add webkitVibrate method to get an array or single integer parameter for vibrating.
They check vibration is activated in the platform, and then call vibrate() in the Vibration class.

• Modules/vibration/NavigatorVibration.h: Added.

(WebCore):
(NavigatorVibration):

• Modules/vibration/NavigatorVibration.idl: Added.
• Modules/vibration/Vibration.cpp: Added.

This class implements the entire vibration logic.
(WebCore):
(WebCore::Vibration::Vibration):
(WebCore::Vibration::~Vibration):
(WebCore::Vibration::create):
(WebCore::Vibration::vibrate):
(WebCore::Vibration::cancelVibration):
(WebCore::Vibration::suspendVibration):
(WebCore::Vibration::resumeVibration):
(WebCore::Vibration::timerStartFired):
(WebCore::Vibration::timerStopFired):
(WebCore::Vibration::supplementName):
(WebCore::Vibration::isActive):
(WebCore::provideVibrationTo):

• Modules/vibration/Vibration.h: Added.

(WebCore):
(Vibration):
(WebCore::Vibration::from):

• Modules/vibration/VibrationClient.h: Added.

vibrate() and cancelVibrate() need to be implemented in the VibrationClient.
(WebCore):
(VibrationClient):
(WebCore::VibrationClient::~VibrationClient):

Source/WebKit/efl: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Implementation for the Vibration API feature to the EFL-port layer.
​http://dev.w3.org/2009/dap/vibration/
There are two methods for vibration API.

• vibrate : Vibrate device for receiving as a parameter.
• cancelVibrate : Cancel current vibration.

• CMakeListsEfl.txt:
• WebCoreSupport/VibrationClientEfl.cpp: Added.

(WebCore):
(WebCore::VibrationClientEfl::VibrationClientEfl):
(WebCore::VibrationClientEfl::vibrate):
(WebCore::VibrationClientEfl::cancelVibration):
(WebCore::VibrationClientEfl::vibrationDestroyed):

• WebCoreSupport/VibrationClientEfl.h: Added.

(WebCore):
(VibrationClientEfl):
(WebCore::VibrationClientEfl::~VibrationClientEfl):

• ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Add a new API for the Vibration API(W3C).
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

• Scripts/build-webkit: Enable ENABLE_VIBRATION feature.

LayoutTests: Add a new test case for the Vibration API.
​https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

• fast/dom/navigator-vibration-expected.txt: Added.
• fast/dom/navigator-vibration.html: Added.
• platform/chromium/test_expectations.txt:
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:

4:57 PM Changeset in webkit [108271] by yutak@chromium.org

• 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r108263.
​http://trac.webkit.org/changeset/108263
​https://bugs.webkit.org/show_bug.cgi?id=77856

Broke Chromium Windows build.

• platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):

• platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::isStereo):
(DynamicsCompressor):

• platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

• platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

• webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

4:25 PM Changeset in webkit [108270] by rniwa@webkit.org

• 6 edits in trunk

Move more logic from handler classes to model classes and add unit tests
​https://bugs.webkit.org/show_bug.cgi?id=78989

Reviewed by Hajime Morita.

Extracted various functions from CreateHandler, ReportHanlder, and RunsHanlder to model classes
in order to unit-test them, added DataStoreTestsBase to reduce the code duplication in tests,
and added a whole bunch of unit tests in models_unittest.py.

• Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler._create_branch):
(CreateHandler._create_platform):

• Websites/webkit-perf.appspot.com/models.py:

(_create_if_possible):
(_create_if_possible.execute):
(Branch):
(Branch.create_if_possible):
(Platform):
(Platform.create_if_possible):
(Build):
(Build.get_or_insert_from_log):
(Test):
(Test.update_or_insert):
(Test.update_or_insert.execute):
(TestResult):
(TestResult.get_or_insert_from_parsed_json):
(TestResult.get_or_insert_from_parsed_json._float_or_none):
(TestResult.generate_runs):

• Websites/webkit-perf.appspot.com/models_unittest.py:

(DataStoreTestsBase):
(DataStoreTestsBase.assertThereIsNoInstanceOf):
(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase.assertEqualUnorderedList):
(HelperTests):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder):
(BranchTests):
(BranchTests.test_create_if_possible):
(PlatformTests):
(PlatformTests.test_create_if_possible):
(BuilderTests):
(_create_some_builder):
(BuildTests):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestResultTests):
(TestResultTests._create_build):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests._create_results):
(TestResultTests.test_generate_runs):
(ReportLogTests):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.test_set):

• Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

• Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):
(RunsHandler.post):

4:18 PM Changeset in webkit [108269] by barraclough@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:49 PM Changeset in webkit [108268] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Undoing accidental changes

• heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

3:42 PM Changeset in webkit [108267] by mhahnenberg@apple.com

• 11 edits
  1 add in trunk/Source/JavaScriptCore

Factor out allocation in CopySpace into a separate CopyAllocator
​https://bugs.webkit.org/show_bug.cgi?id=78610

Reviewed by Oliver Hunt.

Added a new CopyAllocator class, which allows us to do allocations without
having to load the current offset and store the current offset in the current
block. This change will allow us to easily do inline assembly in the JIT for
array allocations.

• GNUmakefile.list.am:
• JavaScriptCore.gypi:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopiedAllocator.h: Added.

(JSC):
(CopiedAllocator):
(JSC::CopiedAllocator::currentBlock):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::allocate):
(JSC::CopiedAllocator::fitsInCurrentBlock):
(JSC::CopiedAllocator::wasLastAllocation):
(JSC::CopiedAllocator::startedCopying):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::currentUtilization):
(JSC::CopiedAllocator::resetLastAllocation):

• heap/CopiedBlock.h:

(CopiedBlock):

• heap/CopiedSpace.cpp: Moved some stuff from CopiedSpaceInlineMethods to here because we

weren't really getting any benefits from having such big functions in a header file.
(JSC::CopiedSpace::CopiedSpace):
(JSC):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::getFreshBlock):

• heap/CopiedSpace.h:

(CopiedSpace):

• heap/CopiedSpaceInlineMethods.h:

(JSC):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::allocateFromBlock):

• heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

• heap/HeapBlock.h:

(HeapBlock):

3:39 PM WebKitGTK/1.8.x edited by kov@webkit.org

chrome version update merged (diff)

3:38 PM Changeset in webkit [108266] by kov@webkit.org

• 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging ​http://trac.webkit.org/changeset/108264

3:37 PM Changeset in webkit [108265] by Patrick Gansterer

• 2 edits in trunk/Source/JavaScriptCore

Fix Visual Studio 2010 build.

• bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

3:22 PM Changeset in webkit [108264] by kov@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

[GTK] Needs to claim being a more up-to-date Chrome
​https://bugs.webkit.org/show_bug.cgi?id=79044

Reviewed by Martin Robinson.

• webkit/webkitwebsettings.cpp:

(chromeUserAgent): update the version of Chrome we claim to be
to avoid warnings from sites such as Wordpress saying that our
browser is outdated.

3:16 PM WebKitGTK/1.8.x edited by kov@webkit.org

Adding to proposed merges [GTK] Needs to claim being a more up-to-date … (diff)

2:10 PM Changeset in webkit [108263] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Have the DynamicsCompressorNode support multi-channel data
​https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-02-20
Reviewed by Chris Rogers.

• platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

• platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

• platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

• platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

• webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

2:02 PM Changeset in webkit [108262] by commit-queue@webkit.org

• 11 edits in trunk

RenderMathMLRow::baselinePosition() only if linePositionMode == PositionOnContainingLine
​https://bugs.webkit.org/show_bug.cgi?id=79039

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

Source/WebCore:

RenderMathMLRow::baselinePosition() is actually unnecessary, but I am deleting it in two
steps. First we add a guard to restrict it to the intended PositionOnContainingLine
case, leaving PositionOfInteriorLineBoxes to a superclass, RenderBlock. This removes
some randomness, and tightens up the results of four existing test files.

Test: mathml/presentation/row.xhtml, fenced.xhtml, mo.xhtml, and mo-stretch.html

• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

LayoutTests:

• platform/mac/mathml/presentation/fenced-expected.png:
• platform/mac/mathml/presentation/fenced-expected.txt:
• platform/mac/mathml/presentation/mo-expected.png:
• platform/mac/mathml/presentation/mo-expected.txt:
• platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
• platform/mac/mathml/presentation/mo-stretch-expected.txt:
• platform/mac/mathml/presentation/row-expected.png:
• platform/mac/mathml/presentation/row-expected.txt:

1:55 PM Changeset in webkit [108261] by jonlee@apple.com

• 11 edits in trunk/Source/WebCore

HTML input file control "No File Selected" needs more room in some languages
​https://bugs.webkit.org/show_bug.cgi?id=32366
<rdar://problem/4481028>

Reviewed by David Hyatt.

The patch exposes a function to return the "no file(s) selected" label text.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListDefaultLabel): Added to expose the text for the label in
file upload controls when nothing has been selected.
(WebCore::RenderTheme::fileListNameForWidth): Refactor to use fileListDefaultLabel().

• rendering/RenderTheme.h: Change fileListNameForWidth() to be a const function.

• rendering/RenderThemeMac.h: Update fileListNameForWidth() to be a const function for

platform implementations.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Refactor to use fileListDefaultLabel().

Update fileListNameForWidth() to be a const function for platform implementations.

• platform/gtk/RenderThemeGtk.h:
• platform/gtk/RenderThemeGtk.cpp:
• platform/qt/RenderThemeQt.h:
• platform/qt/RenderThemeQt.cpp:

• rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Change the calculation
of the max preferred logical width. Calculate the length of the "no file(s) selected" text,
and include the button and after-button margin. Take the max of that and the original
default width, which was a string of 34 (defaultWidthNumChars) "0"'s, in the case that the
label text is too short.

1:52 PM Changeset in webkit [108260] by barraclough@apple.com

• 2 edits in trunk/Source/WebCore

Rubber stamped by Sam Weinig.

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):

• Errk, remove dead code from end of function.

1:14 PM Changeset in webkit [108259] by barraclough@apple.com

• 33 edits in trunk

Move special proto property to Object.prototype
​https://bugs.webkit.org/show_bug.cgi?id=78409

Reviewed by Oliver Hunt.

Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.

Source/JavaScriptCore:

• parser/Parser.cpp:

(JSC::::parseFunctionInfo):

• No need to prohibit functions named proto.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

• Add proto accessor to Object.prototype.

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

• Definition of the proto accessor functions.

• runtime/JSGlobalObjectFunctions.h:
  • Declaration of the proto accessor functions.
• runtime/JSObject.cpp:

(JSC::JSObject::put):

• Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.

(JSC::JSObject::putDirectAccessor):

• Track on the structure whether an object contains accessors other than one for proto.

(JSC::JSObject::defineOwnProperty):

• No need to prohibit definition of own properties named proto.

• runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):

• Remove the special handling for proto.

(JSC::JSValue::get):

• Remove the special handling for proto.

• runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

• Remove the special handling for proto.

• runtime/JSValue.h:

(JSValue):

• Made synthesizePrototype public (this may be needed by the proto getter).

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

• Perform the security check & call prototype() directly.

• runtime/Structure.cpp:

(JSC::Structure::Structure):

• Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.

• runtime/Structure.h:

(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):

• Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.

Source/WebCore:

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):

• expose allowsAccessFrom check to JSC.

• bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

• expose allowsAccessFrom check to JSC.

LayoutTests:

• fast/js/Object-getOwnPropertyNames-expected.txt:
• fast/js/cyclic-prototypes-expected.txt:
• fast/js/parser-syntax-check-expected.txt:
• fast/js/preventExtensions-expected.txt:
• fast/js/prototypes-expected.txt:
  • Update results
• fast/js/script-tests/Object-getOwnPropertyNames.js:
  • proto is now a property of Object Prototype.
• fast/js/script-tests/cyclic-prototypes.js:
  • setting an object's prototype to null removes proto setter, future usage won't set prototype.
• fast/js/script-tests/parser-syntax-check.js:
  • Allow functions named proto
• fast/js/script-tests/preventExtensions.js:
  • Setting proto should not throw.
• fast/js/script-tests/prototypes.js:
  • Objects may contained own properties named proto, add new test cases.

1:11 PM Changeset in webkit [108258] by Patrick Gansterer

• 2 edits in trunk

[CMake] Fix PLATFORM() define for Windows.

Define WTF_PLATFORM_WIN instead of WTF_PLATFORM_WINDOWS.

• Source/cmake/OptionsWindows.cmake:

12:43 PM Changeset in webkit [108257] by benjamin@webkit.org

• 5 edits
  2 adds in trunk

Make JSCSSStyleDeclaration work directly with CSS Property ID
​https://bugs.webkit.org/show_bug.cgi?id=79014

Reviewed by Geoffrey Garen.

Source/WebCore:

Previously, accessing the CSS property was done by converting from
the JavaScript name to the CSS name, then converting that name to a lowercase
character array, and finally getting the CSS property ID.

This patch cut the indirection and make the code go directly from the
JavaScript name conversion to the CSS property ID.

This improves the performance mainly due to the following:
-avoid dynamic memory allocation
-cut the conversion early when possible
-do not parse the string twice
The previous fast-path optimization was removed because it is no longer
necessary with this change.

The improvement are the following:
-previous fast-path: no change
-previous slow-path: ~3 times faster

Test: fast/dom/CSSStyleDeclaration/access-longest-css-property.html
This just test the edge case of CSSPropertyName.

• bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::writeWebKitPrefix):
(WebCore::writeEpubPrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::nameGetter):
(WebCore::JSCSSStyleDeclaration::putDelegate):

• css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore):
(WebCore::cssPropertyNameIOSAliasing):

• css/CSSParser.h:

(WebCore):

LayoutTests:

• fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt: Added.
• fast/dom/CSSStyleDeclaration/access-longest-css-property.html: Added.

11:26 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

11:15 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

11:03 AM Changeset in webkit [108256] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Updated Localizable.strings after r107440.

Rubber-stamped by Joseph Pecoraro.

• English.lproj/Localizable.strings:

11:00 AM Changeset in webkit [108255] by Csaba Osztrogonác

• 8 edits in trunk/LayoutTests

Unreviewed gardening after r108226.
Skip tests because ENABLE(SHADOW_DOM) is disabled on these platforms.

• platform/efl/Skipped:
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:
• platform/wk2/Skipped:

11:00 AM Changeset in webkit [108254] by Martin Robinson

• 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108250

10:59 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

10:58 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

10:49 AM Changeset in webkit [108253] by Nate Chapin

• 2 edits in branches/chromium/963/Source/WebCore/rendering/style

Merge 108100 - 2012-02-17 Nate Chapin <Nate Chapin>

[Chromium mac] Cursors and background images disappear.
​https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

• rendering/style/StyleCachedImage.cpp:
• rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=Nate Chapin
Review URL: ​https://chromiumcodereview.appspot.com/9424038

10:49 AM Changeset in webkit [108252] by msaboff@apple.com

• 5 edits in trunk

Update toLower and toUpper tests for Unicode 6.1 changes
​https://bugs.webkit.org/show_bug.cgi?id=78923

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

• tests/mozilla/ecma/String/15.5.4.11-2.js: Updated the test

to handle a third set of results for updated Unicode 6.1
changes.
(getTestCases):
(TestCaseMultiExpected):
(writeTestCaseResultMultiExpected):
(getTestCaseResultMultiExpected):
(test):
(GetUnicodeValues):
(DecimalToHexString):

LayoutTests:

• fast/js/script-tests/string-capitalization.js: Updated the test

to handle a new set of characters that have different results depending
on what version of Unicode the platform supports. The tests work
for Unicode 5.0 through 6.1.
(createExpected):

• fast/js/string-capitalization-expected.txt:

10:46 AM Changeset in webkit [108251] by Nate Chapin

• 2 edits in branches/chromium/1025/Source/WebCore/rendering/style

Merge 108100 - 2012-02-17 Nate Chapin <Nate Chapin>

[Chromium mac] Cursors and background images disappear.
​https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

• rendering/style/StyleCachedImage.cpp:
• rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=Nate Chapin
Review URL: ​https://chromiumcodereview.appspot.com/9424037

10:46 AM Changeset in webkit [108250] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] Adding SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature to soup session makes WebProcess to hang
​https://bugs.webkit.org/show_bug.cgi?id=79036

Reviewed by Martin Robinson.

This looks like a bug in gobject. Initializing the WebProcess
before creating the soup session seems to fix the problem. It's
actually a workaround, but initializing the WebProcess as sson as
possible it's a good idea in any case.

• WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

10:43 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson

(diff)

10:35 AM Changeset in webkit [108249] by commit-queue@webkit.org

• 10 edits
  3 adds in trunk

MathML internals - remove nonOperatorHeight(), hasBase()
​https://bugs.webkit.org/show_bug.cgi?id=78977

Source/WebCore:

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

Stretchy operators, including embellished ones, should stretch to the largest height of
the non-stretchy items in the same explicit or implicit <mrow>.
RenderMathMLRow::layout() used to use hasBase(), isRenderMathMLOperator(), and
nonOperatorHeight() to approximate this height. We now use unembellishedOperator() to
improve this approximation, while also simplifying the code. More plainly, the code used
to skip all operators when estimating this height, instead of just the stretchy ones. We
continue to do that for now, but we more accurately skip all embellished operators
(using our currently implemented approximate definition of this), and use the simple and
true height of the remaining items. In case all items in the row are stretchy,
style()->fontSize() is better than using whatever heights these items currently happen
to be stretched to.

Test: mathml/presentation/mo-stretch.html, and many existing tests

• rendering/mathml/RenderMathMLBlock.cpp:

(WebCore):

• rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::unembellishedOperator):

• rendering/mathml/RenderMathMLRow.cpp:

(WebCore):
(WebCore::RenderMathMLRow::layout):

• rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

• rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore):

• rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore):

• rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

LayoutTests:

Patch by David Barton <Dave Barton> on 2012-02-20
Reviewed by Eric Seidel.

More tests with multiple embellished stretchy and non-stretchy operators will be added
later, when code is added to more precisely handle such cases.

• mathml/presentation/mo-stretch.html: Added.
• platform/mac/mathml/presentation/mo-stretch-expected.png: Added.
• platform/mac/mathml/presentation/mo-stretch-expected.txt: Added.

9:57 AM WebKitGTK/WebKit2Roadmap edited by Martin Robinson

(diff)

9:34 AM WebKitGTK/1.8.x edited by kov@webkit.org

(diff)

9:24 AM Changeset in webkit [108248] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Stop the committer timer when the page is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=78907

Reviewed by Adam Roben.

We don't want the committer timer to fire after the scrolling tree has been invalidated,
so stop the committer timer to prevent it from firing and trying to access the scrolling tree.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):

9:11 AM Changeset in webkit [108247] by Patrick Gansterer

• 3 edits in trunk/Source/WebCore

[WIN] Allow compiling FileSystem without CoreFoundation.
​https://bugs.webkit.org/show_bug.cgi?id=79032

Reviewed by Adam Roben.

Add #if USE(CF) around code using the CoreFoundation functions.

• platform/FileSystem.h:
• platform/win/FileSystemWin.cpp:

8:57 AM Changeset in webkit [108246] by Csaba Osztrogonác

• 3 edits in trunk/Tools

[Qt] run-qtwebkit-tests doesn't consider timeouts as failures
​https://bugs.webkit.org/show_bug.cgi?id=71816

RunQtAPITests will notify if a timeout occurs during testing.
Added unittest to the master.cfg

Patch by János Badics <​dicska@gmail.com> on 2012-02-20
Reviewed by Csaba Osztrogonác.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests.evaluateCommand):

• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunQtAPITestsTest):
(RunQtAPITestsTest.assertResults):
(RunQtAPITestsTest.test_timeout):
(test_success):
(test_failure):
(test_timeout_and_failure):

8:50 AM Changeset in webkit [108245] by commit-queue@webkit.org

• 1 edit
  7 adds in trunk/Source/WebCore

[BlackBerry] Upstream the first few files in platform/graphics/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=79023

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

• platform/graphics/blackberry/FloatPointBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatPoint::FloatPoint):
(WebCore::FloatPoint::operator BlackBerry::Platform::FloatPoint):

• platform/graphics/blackberry/FloatRectBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::operator BlackBerry::Platform::FloatRect):

• platform/graphics/blackberry/FloatSizeBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatSize::FloatSize):
(WebCore::FloatSize::operator BlackBerry::Platform::FloatSize):

• platform/graphics/blackberry/IntPointBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntPoint::IntPoint):
(WebCore::IntPoint::operator BlackBerry::Platform::IntPoint):

• platform/graphics/blackberry/IntRectBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntRect::IntRect):
(WebCore::IntRect::operator BlackBerry::Platform::IntRect):

• platform/graphics/blackberry/IntSizeBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntSize::IntSize):
(WebCore::IntSize::operator BlackBerry::Platform::IntSize):

8:43 AM Changeset in webkit [108244] by tonikitoo@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

2012-02-19 Antonio Gomes <​agomes@rim.com>

All default video/audio control elements should be rect-hit testable (Part II)
PR #139518 / MKS_3005538

Reviewed by George Staikos.

Add HTMLInputElement::isMediaControlElement as a criteria
to consider a element as clickable.

Note that is should be only used while in the "ClickableByDefault"
phase of FatFingers.

• WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::FatFingers::isElementClickable):

8:40 AM Changeset in webkit [108243] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

[WIN] Share openTemporaryFile with WinCE
​https://bugs.webkit.org/show_bug.cgi?id=58750

Reviewed by Adam Roben.

Use pathByAppendingComponent instead of PathCombine to share the
code with WinCE. Also use the wide version of Windows functions.

• platform/win/FileSystemWin.cpp:

(WebCore::openTemporaryFile):

7:23 AM Changeset in webkit [108242] by peter@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

• DEPS:

7:19 AM WebKitIDL edited by haraken@chromium.org

(diff)

7:11 AM WebKitGTK/1.8.x edited by kov@webkit.org

(diff)

7:02 AM Changeset in webkit [108241] by commit-queue@webkit.org

• 16 edits
  6 adds in trunk

Source/WebCore: Added code to support dispatching of missed cues in case of normal playback
and event sorting in case of simultaneous event triggering.

<track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
​https://bugs.webkit.org/show_bug.cgi?id=72171

Patch by Victor Carbune <​victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.

Tests: media/track/track-cues-missed.html

media/track/track-cues-sorted-before-dispatch.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Added initialization code
for newly added state variables.
(WebCore::trackIndexCompare): Static boolean compare function between
the index of two tracks.
(WebCore):
(WebCore::eventTimeCueCompare): Static boolean compare function between
events associated with text track cues.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Added code to
sort the events associated with text track cues before dispatching.
Each step from the specification is commented within the code.
(WebCore::HTMLMediaElement::finishSeek): Added a boolean variable that
is needed within the text track update function, to know whether a seek
event has occured before or not.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Moved the update
call for text tracks at the beginning of the function instead of the end.
'ended' events for video should be dispatched after track specific events.

• html/HTMLMediaElement.h: Added variables to keep

state information required by the text track update algorithm (last time
the algorithm was run, and whether a seeking event has occured)
(HTMLMediaElement):

• html/LoadableTextTrack.cpp: Refactored fireCueChangeEvent method

(WebCore::LoadableTextTrack::fireCueChangeEvent): The method dispatches a
synchronous cue change event for the track element.

• html/LoadableTextTrack.h:

(LoadableTextTrack):

• html/TextTrack.cpp: Modified the fireCueChange method, cached track index.

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::trackIndex): Cached the track index.
(WebCore):
(WebCore::TextTrack::invalidateTrackIndex): Invalidates the track. Used
when a new track is added in a TextTrackList instance.

• html/TextTrack.h:

(TextTrack):
(WebCore::TextTrack::fireCueChangeEvent): The fireCueChangeEvent has been changed,
as events need to be fired asyncronously.

• html/TextTrackCue.cpp: Added internal variables to keep the current index

position in the track cue order. This is invalidated when an element is
inserted before.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueIndex): Getter for the cueIndex.
(WebCore):
(WebCore::TextTrackCue::invalidateCueIndex): Invalidates the currently stored
cue index.
(WebCore::TextTrackCue::dispatchEvent): Event dispatching is done asynchronously
now. This should be the only method used for event dispatching.
(WebCore::TextTrackCue::setIsActive): The setIsActive method no longer dispatches
events, but rather just changes the m_isActive variable.

• html/TextTrackCue.h:

(TextTrackCue):

• html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::getCueIndex): Retrieves the cue index, in the track cue
order, of a given cue.
(WebCore):
(WebCore::TextTrackCueList::add): Modified the add method such that all the next cue
indexes are invalidated.
(WebCore::TextTrackCueList::invalidateCueIndexes): Invalidates all cue indexes starting
with a specific position.

• html/TextTrackCueList.h:

(TextTrackCueList):

• html/track/TextTrackList.cpp:

(TextTrackList::getTrackIndex): Retrieves the track index position.
(TextTrackList::append): Added method for invalidating the text track index in case of
changing the list contents.

• html/track/TextTrackList.h:

(TextTrackList):

LayoutTests: <track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
​https://bugs.webkit.org/show_bug.cgi?id=72171

Patch by Victor Carbune <​victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.

• media/track/captions-webvtt/missed-cues.vtt: Added.
• media/track/captions-webvtt/sorted-dispatch.vtt: Added.
• media/track/track-cues-cuechange-expected.txt: This test had to be changed because

the synchronous dispatch of the events against the HTMLTrackElement doesn't mean that
the text track actually has any active cues at the dispatch moment.

• media/track/track-cues-cuechange.html: Changed tests structure to guide the entering and

exit events according to the asynchronous dispatch done by TextTrack.

• media/track/track-cues-missed-expected.txt: Added.
• media/track/track-cues-missed.html: Added.
• media/track/track-cues-sorted-before-dispatch-expected.txt: Added.
• media/track/track-cues-sorted-before-dispatch.html: Added.

6:54 AM Changeset in webkit [108240] by bashi@chromium.org

• 8 edits
  1 add in trunk/Source/WebCore

[WebSocket] Move WebSocketChannel::FrameData into a separate header file
​https://bugs.webkit.org/show_bug.cgi?id=78682

Extract WebSocketChannel::FrameData as WebSocketFrame. This brings
flexibility to add classes which want to do something for
incoming/outgoing frames (e.g. compression/decompression).

Reviewed by Kent Tamura.

No new tests. No behavior change.

• GNUmakefile.list.am: AddedWebSocketFrame.h
• Target.pri: Ditto.
• WebCore.gypi: Ditto.
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• websockets/WebSocketChannel.cpp: Modified to use WebSocketFrame instead of FrameData

(WebCore):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::appendMaskedFramePayload): Added.
(WebCore::makeFrameData): Added.
(WebCore::WebSocketChannel::sendFrame):

• websockets/WebSocketChannel.h: Removed FrameData.

(WebSocketChannel):
(QueuedFrame):

• websockets/WebSocketFrame.h: Added.

(WebCore):
(WebSocketFrame):
(WebCore::WebSocketFrame::isNonControlOpCode):
(WebCore::WebSocketFrame::isControlOpCode):
(WebCore::WebSocketFrame::isReservedOpCode):
(WebCore::WebSocketFrame::WebSocketFrame):

6:53 AM Changeset in webkit [108239] by Adam Roben

• 2 edits in trunk/Source/WebCore

32-bit build fix

• platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::setRawValue): Explicitly cast long long to int, since they
are different widths in 32-bit.

6:51 AM Changeset in webkit [108238] by Adam Roben

• 2 edits in trunk/Source/WebCore

Clang build fix

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::willModifyDOMAttr): Removed unused parameter.

6:13 AM WebKitIDL edited by haraken@chromium.org

(diff)

6:03 AM Changeset in webkit [108237] by vsevik@chromium.org

• 4 edits
  4 deletes in trunk

Unreviewed manual rollout of r107970 which breaks table column widths
updates from javascript (e.g. inspector's network panel).

Source/WebCore:

• rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

• rendering/RenderTableCol.h:

(RenderTableCol):

LayoutTests:

• css2.1/20110323/fixed-table-layout-013-expected.html: Removed.
• css2.1/20110323/fixed-table-layout-013.htm: Removed.
• css2.1/20110323/fixed-table-layout-015-expected.html: Removed.
• css2.1/20110323/fixed-table-layout-015.htm: Removed.

6:02 AM WebKitIDL edited by haraken@chromium.org

(diff)

5:42 AM Changeset in webkit [108236] by apavlov@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Inconsistent alignment of non-parsed properties (having an exclamation mark)
​https://bugs.webkit.org/show_bug.cgi?id=79028

Reviewed by Yury Semikhatsky.

• inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):

5:11 AM Changeset in webkit [108235] by apavlov@chromium.org

• 9 edits in trunk

Web Inspector: DOMAttrModified should not be fired if the attribute value remains the same
​https://bugs.webkit.org/show_bug.cgi?id=79025

Reviewed by Pavel Feldman.

Source/WebCore:

• dom/Element.cpp:

(WebCore::Element::willModifyAttribute):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::willModifyDOMAttr):
(WebCore):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):

• inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):

• inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):

LayoutTests:

• inspector/elements/set-attribute-expected.txt:
• inspector/elements/set-attribute.html:

5:10 AM WebKitIDL edited by haraken@chromium.org

(diff)

5:00 AM Changeset in webkit [108234] by wingo@igalia.com

• 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog from last commit.

• ChangeLog: Quick fix to date and email address.

4:49 AM Changeset in webkit [108233] by wingo@igalia.com

• 3 edits in trunk/Source/JavaScriptCore

2012-02-120 Andy Wingo <​wingo@pobox.com>

Remove unused features from CodeFeatures
​https://bugs.webkit.org/show_bug.cgi?id=78804

Reviewed by Gavin Barraclough.

• parser/Nodes.h:
• parser/ASTBuilder.h:

(JSC::ClosureFeature):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::usesClosures):
Remove "ClosureFeature". Since we track captured variables more
precisely, this bit doesn't do us any good.

(JSC::AssignFeature):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
(JSC::ASTBuilder::usesAssignment):
Similarly, remove AssignFeature. It is unused.

4:49 AM EFLWebKit edited by dominik.rottsches@intel.com

libsoup version. (diff)

4:26 AM WebKit Team edited by wingo@igalia.com

fix markup (diff)

4:26 AM WebKit Team edited by wingo@igalia.com

add myself as a committer (diff)

4:25 AM Changeset in webkit [108232] by commit-queue@webkit.org

• 22 edits in trunk/Source/WebKit2

[Qt][WK2] Implement proxy authentication handling.
​https://bugs.webkit.org/show_bug.cgi?id=78792

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-02-20
Reviewed by Simon Hausmann.

This patch implements the proxy authentication handling
for the Qt port in a similar matter to the http authentication
implementation.

Since there is a need to pass the proxy port, which is of type uint16_t,
from the WebProcess to the UIProcess, an encoder and a decoder for
this type was added because it did not exist.

The message that was added to the WebPageProxy is called synchronously
as this is needed by the implementation of the network access manager
and has also been implemented this way already for the http
authentication.

• Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::decodeUInt16):
(CoreIPC):

• Platform/CoreIPC/ArgumentDecoder.h:

(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decode):
(CoreIPC):

• Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::encodeUInt16):
(CoreIPC):

• Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC):

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):

• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

• UIProcess/PageClient.h:

(PageClient):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::proxyAuthenticationRequiredRequest):
(WebKit):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/qt/QtDialogRunner.cpp:

(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::hostname):
(ProxyAuthenticationDialogContextObject::port):
(ProxyAuthenticationDialogContextObject::prefilledUsername):
(ProxyAuthenticationDialogContextObject::accept):
(ProxyAuthenticationDialogContextObject::reject):
(QtDialogRunner::initForProxyAuthentication):

• UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

• UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleProxyAuthenticationRequiredRequest):

• UIProcess/qt/QtPageClient.h:

(QtPageClient):

• WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeUInt16):
(WebKit):

• WebProcess/WebPage/DecoderAdapter.h:

(DecoderAdapter):

• WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeUInt16):
(WebKit):

• WebProcess/WebPage/EncoderAdapter.h:

(EncoderAdapter):

• WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):
(WebKit):

• WebProcess/qt/QtNetworkAccessManager.h:

(QtNetworkAccessManager):

4:16 AM Changeset in webkit [108231] by wingo@igalia.com

• 2 edits in trunk/Tools

Add wingo as a committer.

Unreviewed.

• Scripts/webkitpy/common/config/committers.py: Add myself to the

committers list.

4:14 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

4:13 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

3:44 AM Changeset in webkit [108230] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Correct a typo error in ScrollingCoordinator.h
​https://bugs.webkit.org/show_bug.cgi?id=79012

Patch by Kwonjin Jeong <​gram@company100.net> on 2012-02-20
Reviewed by Andreas Kling.

• page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

2:50 AM Changeset in webkit [108229] by apavlov@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] box-shadow and -webkit-box-shadow properties are not considered color-aware
​https://bugs.webkit.org/show_bug.cgi?id=78988

Reviewed by Yury Semikhatsky.

• inspector/front-end/CSSKeywordCompletions.js:

2:47 AM Changeset in webkit [108228] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

[Forms] Spin buttons of number input type should fire both input and change event
​https://bugs.webkit.org/show_bug.cgi?id=75067

Patch by Yosifumi Inoue <​yosin@chromium.org> on 2012-02-20
Reviewed by Kent Tamura.

Source/WebCore:

This patch makes spin button in number input field clicks to fire input and change events as described in WHATWG HTML5 specification.
To implement this behavior, this patch introduces new value DispatchInputAndChangeEvent in TextFieldEventBehavior.

Test: fast/forms/number/spin-button-events.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUpFromRenderer): Pass DispatchInputAndChangeEvent instead of DispatchChangeEvent to applyStep, setValue, and setValueAsNumber.

• html/HTMLTextFormControlElement.h: Add new enum value DispatchInputAndChangeEvent to TextFieldEventBehavior.
• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue): Handle DispatchInputAndChangeEvent and use RefPtr for element to keep reference.

LayoutTests:

• fast/forms/number/spin-button-events-expected.txt: Added.
• fast/forms/number/spin-button-events.html: Added.

2:15 AM Changeset in webkit [108227] by Patrick Gansterer

• 2 edits in trunk/Source/WebKit2

[CMake] Update and sort list of source files.

• CMakeLists.txt:

1:33 AM Changeset in webkit [108226] by shinyak@chromium.org

• 5 edits
  2 adds in trunk

Attached/Detached state must be testable
​https://bugs.webkit.org/show_bug.cgi?id=79010

Reviewed by Hajime Morita.

Source/WebCore:

Added a method to check an element attached or not.

Test: fast/dom/shadow/shadow-root-attached.html

• testing/Internals.cpp:

(WebCore::Internals::attached):
(WebCore):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

LayoutTests:

• fast/dom/shadow/shadow-root-attached-expected.txt: Added.
• fast/dom/shadow/shadow-root-attached.html: Added.

1:30 AM Changeset in webkit [108225] by jochen@chromium.org

• 4 edits in trunk/Tools

[chromium] check that we're not running multiple modal dialogs at the same time
​https://bugs.webkit.org/show_bug.cgi?id=78486

Reviewed by Kent Tamura.

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

• DumpRenderTree/chromium/TestShell.h:

(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):

• DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModal):

1:25 AM WebKitIDL edited by haraken@chromium.org

(diff)

1:16 AM Changeset in webkit [108224] by Martin Robinson

• 8 edits in releases/WebKitGTK/webkit-1.8

Merging r108222

1:15 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

1:14 AM Changeset in webkit [108223] by Martin Robinson

• 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108216

1:13 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

1:12 AM Changeset in webkit [108222] by Martin Robinson

• 8 edits in trunk

Fix WebKit2GTK+ for 'make distcheck'.

Instead of conditionally including WebKit2 GNUmakefiles, always
include them and conditionally activate the final targets.

.:

• GNUmakefile.am:

Source/WebKit2:

• GNUmakefile.am:
• UIProcess/API/gtk/tests/GNUmakefile.am:

Tools:

• MiniBrowser/gtk/GNUmakefile.am:
• WebKitTestRunner/GNUmakefile.am:

12:59 AM Changeset in webkit [108221] by bashi@chromium.org

• 9 edits
  3 adds in trunk/Source

[WebSocket] Add deflater/inflater classes
​https://bugs.webkit.org/show_bug.cgi?id=78449

Source/WebCore:

Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.

This patch is second try. The previous patch broke Chromium Win
build. I added dependency of zlib to WebCore.gyp. I think it's
OK because Chromium already depends on zlib.

Reviewed by Kent Tamura.

No new tests except for chromium port. Behavior is unchanged.

• GNUmakefile.list.am: Added WebSocketDeflater.(cpp|h).
• WebCore.gyp/WebCore.gyp: Added zlib dependency.
• WebCore.gypi: Added WebSocketDeflater.(cpp|h).
• WebCore.vcproj/WebCore.vcproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• websockets/WebSocketDeflater.cpp: Added.

(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):

• websockets/WebSocketDeflater.h: Added.

(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):

Source/WebKit/chromium:

Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.

Reviewed by Kent Tamura.

• WebKit.gypi: Added zlib dependency.
• WebKitUnitTests.gyp: Ditto.
• tests/WebSocketDeflaterTest.cpp: Added.

(WebCore):
(WebCore::TEST):

12:48 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

12:48 AM WebKitIDL edited by haraken@chromium.org

(diff)

12:45 AM Changeset in webkit [108220] by Martin Robinson

• 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r108191

12:40 AM Changeset in webkit [108219] by Martin Robinson

• 8 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108206

12:40 AM Changeset in webkit [108218] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: consume undo/redo shortcuts.
​https://bugs.webkit.org/show_bug.cgi?id=79016

Reviewed by Vsevolod Vlasov.

• inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

12:39 AM Changeset in webkit [108217] by gyuyoung.kim@samsung.com

• 2 edits in trunk/Tools

Enable video option for EFL port in build-webkit.
​https://bugs.webkit.org/show_bug.cgi?id=79006

Reviewed by Daniel Bates.

• Scripts/build-webkit:

12:38 AM Changeset in webkit [108216] by Martin Robinson

• 3 edits in trunk/Source/WebKit2

[GTK][WK2] WebKit2 does not build if gtk-unix-printing-3.0 is not available
​https://bugs.webkit.org/show_bug.cgi?id=79011

Fix the build when gtk-unix-printing-3.0 is not present.

• UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):
(webkitPrintOperationRunDialogForFrame):

• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::create):

12:37 AM Changeset in webkit [108215] by Philippe Normand

• 2 edits in trunk/Source/WebCore

MediaPlayer: MediaPlayerPrivate registration cleanup
​https://bugs.webkit.org/show_bug.cgi?id=78897

Reviewed by Martin Robinson.

• platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Simplified GStreamer Private
player registration by using the PlatformMediaEngineClassName
macro like other players do.

12:34 AM Changeset in webkit [108214] by Philippe Normand

• 1 edit
  1 add in trunk/LayoutTests

Unreviewed, GTK baselines for a new fast/css-generated-content
test.

• platform/gtk/fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.

12:28 AM Changeset in webkit [108213] by Philippe Normand

• 5 edits in trunk/LayoutTests

Unreviewed, GTK fast/repaint rebaseline.

• platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
• platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
• platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
• platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:

12:07 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

Feb 19, 2012:

11:51 PM Changeset in webkit [108212] by yurys@chromium.org

• 5 edits in trunk/Source

[Chromium] Web Inspector: terminated workers are not removed from dedicated worker list
​https://bugs.webkit.org/show_bug.cgi?id=78899

Source/WebCore:

Notify inspector about starting context from WorkerContextProxy not from Worker.

Reviewed by Pavel Feldman.

• workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Pass original WorkerContextProxy object to the inspector instrumentation instead
of Chromium-specific one for consistency with WorkerMessagingProxy implementation
in WebCore.

Reviewed by Pavel Feldman.

• src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

11:47 PM WebKitIDL edited by haraken@chromium.org

(diff)

11:41 PM Changeset in webkit [108211] by gyuyoung.kim@samsung.com

• 8 edits in trunk

[CMAKE] Check gstreamer minimum required version.
​https://bugs.webkit.org/show_bug.cgi?id=79005

Reviewed by Daniel Bates.

To enable video, Gstreamer version requires to be above 0.10.30.
This patch checks whether Gstreamer version is greater than 0.10.30.

• Source/cmake/FindGStreamer-App.cmake:
• Source/cmake/FindGStreamer-Base.cmake:
• Source/cmake/FindGStreamer-Interfaces.cmake:
• Source/cmake/FindGStreamer-Pbutils.cmake:
• Source/cmake/FindGStreamer-Plugins-Base.cmake:
• Source/cmake/FindGStreamer-Video.cmake:
• Source/cmake/FindGStreamer.cmake:

11:03 PM Changeset in webkit [108210] by yutak@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update a few test expectations.

• platform/chromium/test_expectations.txt:

10:41 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:31 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:30 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:29 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:26 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

10:22 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:17 PM Changeset in webkit [108209] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

Use shadowRootList for ColorInputType
​https://bugs.webkit.org/show_bug.cgi?id=79007

Reviewed by Kent Tamura.

• html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree): Changed shadowRoot to shadowRootList.
(WebCore::ColorInputType::shadowColorSwatch): Changed shadowRoot to shadowRootList.

10:14 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:06 PM Changeset in webkit [108208] by noel.gordon@gmail.com

• 5 edits
  1 add
  1 delete in trunk/LayoutTests

[chromium] Unreviewed. Update remaining expectations for SVGImageElement-svgdom-requiredFeatures.html.

• platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
• platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
• platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
• platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Removed.
• platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
• platform/chromium/test_expectations.txt:

10:01 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:00 PM WebKitIDL edited by haraken@chromium.org

(diff)

10:00 PM Changeset in webkit [108207] by shinyak@chromium.org

• 9 edits
  2 adds in trunk/Source/WebCore

Introduce InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
​https://bugs.webkit.org/show_bug.cgi?id=78771

Reviewed by Hajime Morita.

This patch introduces InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.

This is a step for rendering <shadow> correctly, because <shadow> has almost the same function of <content>.
After this patch, we will change NodeRenderingContext and related classes to accept InsertionPoint instead of
HTMLContentElement only.

No new tests, no change in behavior.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):

• html/shadow/HTMLContentElement.h:
• html/shadow/InsertionPoint.cpp: Added.

(WebCore):
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::~InsertionPoint):

• html/shadow/InsertionPoint.h: Added.

(WebCore):
(InsertionPoint):

9:59 PM WebKitIDL edited by haraken@chromium.org

(diff)

9:24 PM Changeset in webkit [108206] by commit-queue@webkit.org

• 8 edits in trunk/Source

[GTK] Can't find webinspector and error page redirection on Windows
​https://bugs.webkit.org/show_bug.cgi?id=51616

Source/WebCore:

Create and use an abstraction for finding shared resources on Windows.

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.

• platform/FileSystem.h:

(WebCore):

• platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

• platform/graphics/gtk/ImageGtk.cpp:

(WebCore::getPathToImageResource):

• platform/gtk/FileSystemGtk.cpp:

(WebCore::sharedResourcesPath):
(WebCore):

Source/WebKit/gtk:

Use an abstraction for finding shared resources on Windows.

Patch by Paweł Forysiuk <​tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.

• WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

• WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorFilesPath):

8:22 PM Changeset in webkit [108205] by yutak@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Update Leopard expectation for
SVGImageElement-svgdom-requiredFeatures.html.

• platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:

5:11 PM Changeset in webkit [108204] by jamesr@google.com

• 2 edits in trunk/LayoutTests

[chromium] Unreviewed - mark failing test as failing.

• platform/chromium/test_expectations.txt:

4:04 PM Changeset in webkit [108203] by jamesr@google.com

• 2 edits
  11 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Add leopard baselines for fast/css/relative-positioned-block-* tests, fix up test_expectations.txt

• platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
• platform/chromium/test_expectations.txt:

3:51 PM Changeset in webkit [108202] by jamesr@google.com

• 9 edits
  1 copy in trunk/Source/WebCore

Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
​https://bugs.webkit.org/show_bug.cgi?id=78951

Reviewed by Adam Barth.

This move stubs for ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp instead of #ifdefing inside
ScrollingCoordinator.cpp. The mac port uses ScrollingCoordinator when #if ENABLE(THREADED_SCROLLING) is not set
and implementations in ScrollingCoordinator.cpp / ScrollingCoordinatorMac.mm otherwise. The chromium port
always uses implementations in ScrollingCoordinatorChromium.cpp. All other ports use
ScrollingCoordinatorNone.cpp.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbx:
• page/scrolling/ScrollingCoordinator.cpp:
• page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::create):
(WebCore):

3:47 PM Changeset in webkit [108201] by haraken@chromium.org

• 8 edits in trunk/Source/WebCore

Rename [CheckDomainSecurity] to [CheckSecurity]
​https://bugs.webkit.org/show_bug.cgi?id=78874

Reviewed by Adam Barth.

"Domain security" isn't a term that's used elsewhere.
This patch renames IDL attributes as follows:

• [CheckDomainSecurity] => [CheckSecurity]
• [DoNotCheckDomainSecurity] => [DoNotCheckSecurity]
• [DoNotCheckDomainSecurityOnGetter] => [DoNotCheckSecurityOnGetter]
• [DoNotCheckDomainSecurityOnSetter] => [DoNotCheckSecurityOnSetter]

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(IsVisibleAcrossOrigins):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):

• bindings/scripts/test/TestDomainSecurity.idl:
• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

• page/DOMWindow.idl:
• page/History.idl:
• page/Location.idl:

3:32 PM Changeset in webkit [108200] by jamesr@google.com

• 8 edits
  2 adds
  2 deletes in trunk

Unreviewed, rolling out r108195.
​http://trac.webkit.org/changeset/108195
​https://bugs.webkit.org/show_bug.cgi?id=77700

Lots of failing ASSERT()s on v8 bots, requested by kling on
#webkit

Source/WebCore:

• bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

LayoutTests:

• fast/css/css-value-wrapper-sameness-expected.txt: Removed.
• fast/css/css-value-wrapper-sameness.html: Removed.
• fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Added.
• fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Added.
• fast/dom/domListEnumeration-expected.txt:
• fast/dom/gc-9-expected.txt:
• fast/dom/gc-9.html:
• fast/dom/script-tests/domListEnumeration.js:

3:30 PM Changeset in webkit [108199] by haraken@chromium.org

• 10 edits in trunk/Source/WebCore

Rename [CheckAccessToNode] to [CheckSecurityForNode]
​https://bugs.webkit.org/show_bug.cgi?id=78991

Reviewed by Adam Barth.

For naming consistency with [CheckSecurity], this patch renames
[CheckAccessToNode] to [CheckSecurityForNode].

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

• html/HTMLEmbedElement.idl:
• html/HTMLFrameElement.idl:
• html/HTMLIFrameElement.idl:
• html/HTMLObjectElement.idl:
• page/DOMWindow.idl:

3:24 PM Changeset in webkit [108198] by jamesr@google.com

• 2 edits in trunk/Source/WebCore

Sort WebCore XCode project files with sort-Xcode-project-files script. Unreviewed.

• WebCore.xcodeproj/project.pbxproj:

2:50 PM WebKitGTK/1.8.x edited by kov@webkit.org

(diff)

2:43 PM Changeset in webkit [108197] by kov@webkit.org

• 7 edits in releases/WebKitGTK/webkit-1.8

Merging r108190

12:58 PM Changeset in webkit [108196] by robert@webkit.org

• 4 edits in trunk/LayoutTests

Update expectations for test results changed by r108185

The bots only check text results.

Unreviewed.

• platform/gtk/test_expectations.txt:
• platform/mac/test_expectations.txt:
• platform/qt/test_expectations.txt:

12:16 PM Changeset in webkit [108195] by kling@webkit.org

• 8 edits
  2 adds
  2 deletes in trunk

Make CSSValue wrapper getters return unique objects every time.
<​http://webkit.org/b/77700>

Reviewed by Antti Koivisto.

Source/WebCore:

Change the behavior of CSSValue getters to return unique JS wrappers every
time they are called. This means we no longer have to deal with the risk
of leaking custom properties between unrelated documents, and are free to
implement global value sharing across WebCore.

This patch will be followed by one making CSSValuePool globally shared,
it's done in two steps to monitor the impact of this change.

• bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(IsCSSValueType):

LayoutTests:

• fast/css/css-value-wrapper-sameness-expected.txt: Added.
• fast/css/css-value-wrapper-sameness.html: Added.
• fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Removed.
• fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Removed.
• fast/dom/domListEnumeration-expected.txt:
• fast/dom/gc-9-expected.txt:
• fast/dom/gc-9.html:
• fast/dom/script-tests/domListEnumeration.js:

12:06 PM Changeset in webkit [108194] by inferno@chromium.org

• 3 edits
  2 adds in trunk

Crash in RenderBlock::splitAnonymousBlocksAroundChild.
​https://bugs.webkit.org/show_bug.cgi?id=78994

Reviewed by Eric Seidel.

Source/WebCore:

Generalize splitTablePartsAroundChild to handle splitting
in nested tables.
Table->Table Section->Table Row->Table Cell->Table->Table Section->Table Row

Test: fast/table/table-split-inside-table.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitTablePartsAroundChild):

LayoutTests:

• fast/table/table-split-inside-table-expected.txt: Added.
• fast/table/table-split-inside-table.html: Added.

11:36 AM Changeset in webkit [108193] by kov@webkit.org

• 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Remove gsettings schema from EXTRA_DIST.

• GNUmakefile.am:

11:29 AM Changeset in webkit [108192] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] Use modifier keys to execute pre-rendering.
​https://bugs.webkit.org/show_bug.cgi?id=77933

Patch by JungJik Lee <​jungjik.lee@samsung.com> on 2012-02-19
Reviewed by Chang Shu.

Use modifier key to execute pre-rendering instead of using reserved function keys.

• EWebLauncher/main.c:

(on_key_down):

11:16 AM Changeset in webkit [108191] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GTK] Fix build on platforms where UChar is wchar_t
​https://bugs.webkit.org/show_bug.cgi?id=78996

Patch by Kalev Lember <​kalevlember@gmail.com> on 2012-02-19
Reviewed by Martin Robinson.

The ICU backend defines UChar as wchar_t for platforms where wchar_t is
16 bits wide, e.g. win32.

• platform/graphics/pango/FontPango.cpp:

(WebCore::utf16ToUtf8): Use reinterpret_cast instead of static_cast.

• platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::typeAheadFind): Ditto.

11:16 AM Changeset in webkit [108190] by kov@webkit.org

• 7 edits
  1 delete in trunk

[GTK] Remove unused GSettings stuff
​https://bugs.webkit.org/show_bug.cgi?id=78995

Reviewed by Martin Robinson.

.:

• configure.ac: remove gsettings schema file creation.

Source/WebKit/gtk:

• GNUmakefile.am: remove GSettings-related stuff.
• WebCoreSupport/InspectorClientGtk.cpp:

(WebKit): Remove unused code.

• org.webkitgtk.gschema.xml.in: Removed.
• webkit/webkitwebinspector.cpp:

(webkit_web_inspector_execute_script): remove gsettings-related helper.

• webkit/webkitwebinspectorprivate.h: Ditto.

11:03 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

11:01 AM Changeset in webkit [108189] by rniwa@webkit.org

• 3 edits in trunk

Perf-o-matic should show both WebKit and Chromium revisions
​https://bugs.webkit.org/show_bug.cgi?id=78955

Reviewed by Andreas Kling.

Include Chromium revision numbers in runs responses when available.

• Websites/webkit-perf.appspot.com/js/config.js:

(urlForChangeset):
(urlForChangesetList):

• Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.post):

10:32 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

10:16 AM WebKitGTK edited by Martin Robinson

(diff)

10:15 AM WebKitGTK/1.8.x created by Martin Robinson

9:41 AM Changeset in webkit [108188] by Martin Robinson

• 1 copy in releases/WebKitGTK/webkit-1.8

Branching for the WebKitGTK+ 1.8 stable release

8:53 AM Changeset in webkit [108187] by Carlos Garcia Campos

• 4 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

• GNUmakefile.list.am: Add missing files.

Source/WebCore:

• GNUmakefile.list.am: Add missing header.

8:27 AM Changeset in webkit [108186] by robert@webkit.org

• 5 edits
  25 moves
  36 adds
  2 deletes in trunk/LayoutTests

Chromium results for r108185

Unreviewed gardening.

• platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png.
• platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
• platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-big-endian-expected.png.
• platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-little-endian-expected.png.
• platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-with-layers-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png.
• platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
• platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Removed.
• platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Removed.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
• platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt.
• platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
• platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
• platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.png:
• platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:

7:24 AM Changeset in webkit [108185] by robert@webkit.org

• 19 edits
  43 adds in trunk

CSS 2.1 failure: inline-box-002.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=69210

Reviewed by David Hyatt.

Source/WebCore:

Tests: css2.1/20110323/dynamic-top-change-005.htm

css2.1/20110323/dynamic-top-change-005a.htm
css2.1/20110323/dynamic-top-change-005b.htm
css2.1/20110323/inline-box-002.htm
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent.html
fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor.html
fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-parent-keeps-style.html
fast/css/relative-positioned-block-with-inline-parent.html

A block within an inline is affected by relative positioning on the inline box. Give
the anonymous block containing the block a layer and make it relative positioned. Then
calculate the offset of the anonymous block's layer by accumulating the offsets from its
inline continuation and the inline continuation's inline parents.
If the position of an inline changes from or to relative positioned then ensure that any
descendant blocks update their position and layer accordingly.

• rendering/RenderBoxModelObject.cpp:

(): add an enum RelPosAxis
(WebCore::accumulateRelativePositionOffsets):
Total up the offsets of all relatively positioned inlines that are de-facto parents of the relatively
positioned anonymous block's child block.

(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
Use accumulateRelativePositionOffsets when calculating the relative position offset of a relatively positioned anonymous block.

(WebCore::RenderBoxModelObject::relativePositionOffsetY): ditto

• rendering/RenderInline.cpp:

(WebCore::hasRelPositionedInlineAncestor):
Detects if the anonymous block contains a block that is the de-facto descendant of a relatively positioned inline.

(WebCore::updateStyleOfAnonymousBlockContinuations):
Update the style's positioning for each anonymous block containing a block that is descendant from the inline whose style has changed.

(WebCore::RenderInline::styleDidChange):
If an inline changes to or from relative positioning ensure that any descendant blocks change to or from relative positioning
as well, unless they still have a relatively positioned ancestor after the current ancestor loses its relative positioning.

(WebCore::RenderInline::addChildIgnoringContinuation):
If the anonymous block contains a block that is effectively descended from a relatively positioned inline, make it relatively
positioned so the block will respect its inline ancestor's relative positioning.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):
Preserve style position in anonymous block continuations when the parent block propagates a style change.

LayoutTests:

• css2.1/20110323/dynamic-top-change-005-expected.html: Added.
• css2.1/20110323/dynamic-top-change-005.htm: Added.
• css2.1/20110323/dynamic-top-change-005a-expected.html: Added.
• css2.1/20110323/dynamic-top-change-005a.htm: Added.
• css2.1/20110323/dynamic-top-change-005b-expected.html: Added.
• css2.1/20110323/dynamic-top-change-005b.htm: Added.
• css2.1/20110323/inline-box-002-expected.html: Added.
• css2.1/20110323/inline-box-002.htm: Added.
• fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html: Added.
• fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html: Added.
• fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html: Added.
• fast/css/relative-positioned-block-nested-with-inline-parent.html: Added.
• fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html: Added.
• fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html: Added.
• fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html: Added.
• fast/css/relative-positioned-block-with-inline-ancestor.html: Added.
• fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html: Added.
• fast/css/relative-positioned-block-with-inline-parent-dynamic.html: Added.
• fast/css/relative-positioned-block-with-inline-parent-expected.html: Added.
• fast/css/relative-positioned-block-with-inline-parent-keeps-style.html: Added.
• fast/css/relative-positioned-block-with-inline-parent.html: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
• platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
• platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
• platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
• platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt:
• platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
• platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
• platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
• platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
• platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
• platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
• platform/chromium/test_expectations.txt: Suppress existing tests until results rebaselined.
• platform/gtk/test_expectations.txt: ditto
• platform/mac/test_expectations.txt: ditto
• platform/qt/test_expectations.txt: ditto
• platform/win/Skipped: ditto