Context Navigation

← Previous Period
Next Period →

Timeline

Feb 22, 2012:

11:36 PM Changeset in webkit [108617] by mitz@apple.com

2 edits in trunk/LayoutTests

Skipped a test that uses Chromium-only LayoutTestController functionality.

Rubber-stamped by Joseph Pecoraro.

platform/mac/Skipped: Added fast/dom/title-directionality-removeChild.html.

11:36 PM Changeset in webkit [108616] by igor.o@sisa.samsung.com

3 edits in trunk/Source/WebCore

Every call to RenderObject::setAnimatableStyle() iterates through all m_compositeAnimations: potentially O(N^{2)

https://bugs.webkit.org/show_bug.cgi?id=38025}

This patchs implements updateAnimationTimerForRenderer, it just checks the timeToNextService for
the current RenderObject reducing the amount of iterations.

Reviewed by Simon Fraser.

page/animation/AnimationController.cpp:

(WebCore):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationController::updateAnimations):

page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

11:29 PM Changeset in webkit [108615] by commit-queue@webkit.org

13 edits in trunk/Source

NOTIFICATIONS should be implemented as PageSupplement
https://bugs.webkit.org/show_bug.cgi?id=79052

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-22
Reviewed by Adam Barth.

Source/WebCore:

Turned NotificationController to a PageSupplement.

No new tests. No behavior change.

notifications/NotificationController.cpp:

(WebCore::NotificationController::clientFrom):
(WebCore):
(WebCore::NotificationController::supplementName):
(WebCore::provideNotification):

notifications/NotificationController.h:

(NotificationController):
(WebCore::NotificationController::from):

notifications/NotificationPresenter.h:

(WebCore):

page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

11:22 PM Changeset in webkit [108614] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit2

[Qt][WK2] navigationType is missing in new API
https://bugs.webkit.org/show_bug.cgi?id=78867

Patch by Michael Tyutyunik <michael.tyutyunik@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

In QtWebPagePolicyClient::decidePolicyForNavigationAction()
navigationType argument is dropped by mistake. Adding it back
and make it available through NavigationRequest.

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::navigationType):

UIProcess/API/qt/qwebnavigationrequest_p.h:
UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQuickWebViewNavigationType):

UIProcess/qt/QtWebPagePolicyClient.h:

(QtWebPagePolicyClient):

11:04 PM Changeset in webkit [108613] by dslomov@google.com

3 edits
1 delete in trunk

[Chromium][V8] Support Uint8ClampedArray in postMessage
https://bugs.webkit.org/show_bug.cgi?id=79291.

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

bindings/v8/SerializedScriptValue.cpp:

LayoutTests:

platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Removed.

10:50 PM Changeset in webkit [108612] by tkent@chromium.org

1 edit
34 moves in trunk/LayoutTests

Move <input type=radio> tests to fast/forms/radio/
https://bugs.webkit.org/show_bug.cgi?id=78678

Reviewed by Kentaro Hara.

fast/forms/ValidityState-valueMissing-radio-expected.txt: Removed.
fast/forms/ValidityState-valueMissing-radio.html: Removed.
fast/forms/indeterminate-radio-expected.txt: Removed.
fast/forms/indeterminate-radio.html: Removed.
fast/forms/input-radio-checked-tab-expected.txt: Removed.
fast/forms/input-radio-checked-tab.html: Removed.
fast/forms/interactive-validation-required-radio-expected.txt: Removed.
fast/forms/interactive-validation-required-radio.html: Removed.
fast/forms/radio-attr-order-expected.txt: Removed.
fast/forms/radio-attr-order.html: Removed.
fast/forms/radio-button-no-change-event-expected.txt: Removed.
fast/forms/radio-button-no-change-event.html: Removed.
fast/forms/radio-check-click-and-drag-expected.txt: Removed.
fast/forms/radio-check-click-and-drag.html: Removed.
fast/forms/radio-default-value-expected.txt: Removed.
fast/forms/radio-default-value.html: Removed.
fast/forms/radio-group-keyboard-change-event-expected.txt: Removed.
fast/forms/radio-group-keyboard-change-event.html: Removed.
fast/forms/radio-nested-labels-expected.txt: Removed.
fast/forms/radio-nested-labels.html: Removed.
fast/forms/radio-no-theme-padding-expected.txt: Removed.
fast/forms/radio-no-theme-padding.html: Removed.
fast/forms/radio-remove-form-attr-expected.txt: Removed.
fast/forms/radio-remove-form-attr.html: Removed.
fast/forms/radio/ValidityState-valueMissing-radio-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio-expected.txt.
fast/forms/radio/ValidityState-valueMissing-radio.html: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio.html.
fast/forms/radio/indeterminate-radio-expected.txt: Copied from LayoutTests/fast/forms/indeterminate-radio-expected.txt.
fast/forms/radio/indeterminate-radio.html: Copied from LayoutTests/fast/forms/indeterminate-radio.html.
fast/forms/radio/input-radio-checked-tab-expected.txt: Copied from LayoutTests/fast/forms/input-radio-checked-tab-expected.txt.
fast/forms/radio/input-radio-checked-tab.html: Copied from LayoutTests/fast/forms/input-radio-checked-tab.html.
fast/forms/radio/interactive-validation-required-radio-expected.txt: Copied from LayoutTests/fast/forms/interactive-validation-required-radio-expected.txt.
fast/forms/radio/interactive-validation-required-radio.html: Copied from LayoutTests/fast/forms/interactive-validation-required-radio.html.
fast/forms/radio/radio-attr-order-expected.txt: Copied from LayoutTests/fast/forms/radio-attr-order-expected.txt.
fast/forms/radio/radio-attr-order.html: Copied from LayoutTests/fast/forms/radio-attr-order.html.
fast/forms/radio/radio-button-no-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-button-no-change-event-expected.txt.
fast/forms/radio/radio-button-no-change-event.html: Copied from LayoutTests/fast/forms/radio-button-no-change-event.html.
fast/forms/radio/radio-check-click-and-drag-expected.txt: Copied from LayoutTests/fast/forms/radio-check-click-and-drag-expected.txt.
fast/forms/radio/radio-check-click-and-drag.html: Copied from LayoutTests/fast/forms/radio-check-click-and-drag.html.
fast/forms/radio/radio-default-value-expected.txt: Copied from LayoutTests/fast/forms/radio-default-value-expected.txt.
fast/forms/radio/radio-default-value.html: Copied from LayoutTests/fast/forms/radio-default-value.html.
fast/forms/radio/radio-group-keyboard-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event-expected.txt.
fast/forms/radio/radio-group-keyboard-change-event.html: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event.html.
fast/forms/radio/radio-nested-labels-expected.txt: Copied from LayoutTests/fast/forms/radio-nested-labels-expected.txt.
fast/forms/radio/radio-nested-labels.html: Copied from LayoutTests/fast/forms/radio-nested-labels.html.
fast/forms/radio/radio-no-theme-padding-expected.txt: Copied from LayoutTests/fast/forms/radio-no-theme-padding-expected.txt.
fast/forms/radio/radio-no-theme-padding.html: Copied from LayoutTests/fast/forms/radio-no-theme-padding.html.
fast/forms/radio/radio-remove-form-attr-expected.txt: Copied from LayoutTests/fast/forms/radio-remove-form-attr-expected.txt.
fast/forms/radio/radio-remove-form-attr.html: Copied from LayoutTests/fast/forms/radio-remove-form-attr.html.
fast/forms/radio/radio_checked-expected.txt: Copied from LayoutTests/fast/forms/radio_checked-expected.txt.
fast/forms/radio/radio_checked.html: Copied from LayoutTests/fast/forms/radio_checked.html.
fast/forms/radio/radio_checked_dynamic-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_dynamic-expected.txt.
fast/forms/radio/radio_checked_dynamic.html: Copied from LayoutTests/fast/forms/radio_checked_dynamic.html.
fast/forms/radio/radio_checked_name-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_name-expected.txt.
fast/forms/radio/radio_checked_name.html: Copied from LayoutTests/fast/forms/radio_checked_name.html.
fast/forms/radio/remove-radio-button-assert-expected.txt: Copied from LayoutTests/fast/forms/remove-radio-button-assert-expected.txt.
fast/forms/radio/remove-radio-button-assert.html: Copied from LayoutTests/fast/forms/remove-radio-button-assert.html.
fast/forms/radio/state-restore-radio-group-expected.txt: Copied from LayoutTests/fast/forms/state-restore-radio-group-expected.txt.
fast/forms/radio/state-restore-radio-group.html: Copied from LayoutTests/fast/forms/state-restore-radio-group.html.
fast/forms/radio_checked-expected.txt: Removed.
fast/forms/radio_checked.html: Removed.
fast/forms/radio_checked_dynamic-expected.txt: Removed.
fast/forms/radio_checked_dynamic.html: Removed.
fast/forms/radio_checked_name-expected.txt: Removed.
fast/forms/radio_checked_name.html: Removed.
fast/forms/remove-radio-button-assert-expected.txt: Removed.
fast/forms/remove-radio-button-assert.html: Removed.
fast/forms/state-restore-radio-group-expected.txt: Removed.
fast/forms/state-restore-radio-group.html: Removed.

10:40 PM Changeset in webkit [108611] by mitz@apple.com

2 edits in trunk/LayoutTests

Updated expected test results for the addition of -webkit-line-align (r108133) and the
renaming of -webkit-line-grid-snap (r107289).

Rubber-stamped by Andy Estes.

platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

10:26 PM Changeset in webkit [108610] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Enable Geolocation bindings for GObject
https://bugs.webkit.org/show_bug.cgi?id=79293

Reviewed by Adam Barth.

This patch adds "WebCore::" to supplemental method calls.
This will solve the GTK build failure we have observed in the Geolocation API,
and thus this patch enables the Geolocation API.

Modules/geolocation/NavigatorGeolocation.idl:
bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

10:13 PM Changeset in webkit [108609] by bashi@chromium.org

2 edits in trunk/LayoutTests

REGRESSION (r107516): fast/css/font-face-default-font.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79260

Add @font-face with "font-style: italic;" so that affecting the rule
for italic text.

Reviewed by Dan Bernstein.

fast/css/font-face-default-font.html:

9:58 PM Changeset in webkit [108608] by morrita@google.com

3 edits in trunk/Source/WebCore

[Refactoring] Align supplementName() values.
https://bugs.webkit.org/show_bug.cgi?id=79311

Reviewed by Adam Barth.

No new tests. No behavioral change.

dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):

mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::supplementName):

9:46 PM Changeset in webkit [108607] by yutak@chromium.org

51 edits
2 deletes in trunk

Unreviewed, rolling out r108602.
http://trac.webkit.org/changeset/108602
https://bugs.webkit.org/show_bug.cgi?id=78878

Caused a couple of layout test failures on Chromium bots.

Source/WebCore:

dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

dom/Element.h:

(Element):

dom/Node.h:

(WebCore::Node::childShouldCreateRenderer):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

dom/NodeRenderingContext.h:

(NodeRenderingContext):

html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

html/HTMLDetailsElement.h:

(HTMLDetailsElement):

html/HTMLMediaElement.cpp:

(WebCore):

html/HTMLMediaElement.h:

(HTMLMediaElement):

html/HTMLMeterElement.cpp:
html/HTMLMeterElement.h:

(HTMLMeterElement):

html/HTMLProgressElement.cpp:
html/HTMLProgressElement.h:

(HTMLProgressElement):

html/HTMLSelectElement.cpp:
html/HTMLSelectElement.h:

(HTMLSelectElement):

html/HTMLSummaryElement.cpp:
html/HTMLSummaryElement.h:

(HTMLSummaryElement):

html/HTMLTextFormControlElement.cpp:
html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

rendering/RenderButton.cpp:

(WebCore::RenderButton::canHaveChildren):
(WebCore):

rendering/RenderButton.h:

(RenderButton):

rendering/RenderListBox.h:

(WebCore::RenderListBox::canHaveChildren):
(RenderListBox):

rendering/RenderMedia.h:
rendering/RenderMenuList.h:

(WebCore::RenderMenuList::canHaveChildren):

rendering/RenderMeter.h:

(WebCore::RenderMeter::canHaveChildren):

rendering/RenderProgress.h:

(WebCore::RenderProgress::canHaveChildren):

rendering/RenderTextControl.h:

(WebCore::RenderTextControl::canHaveChildren):

rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::canHaveChildren):

svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

svg/SVGAElement.h:

(SVGAElement):

svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

svg/SVGDocument.h:

(SVGDocument):

svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

svg/SVGElement.h:

(SVGElement):

svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

svg/SVGSwitchElement.h:

(SVGSwitchElement):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

svg/SVGTRefElement.h:

(SVGTRefElement):

svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

svg/SVGTSpanElement.h:

(SVGTSpanElement):

svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

svg/SVGTextElement.h:

(SVGTextElement):

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

svg/SVGTextPathElement.h:

LayoutTests:

fast/dom/shadow/shadow-on-image-expected.html: Removed.
fast/dom/shadow/shadow-on-image.html: Removed.
platform/chromium/test_expectations.txt:

9:36 PM Changeset in webkit [108606] by inferno@chromium.org

4 edits
6 adds in trunk

Crash in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=79043

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/runin-div-before-child.html

fast/runin/runin-table-before-child.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle
the case of run-in elements and strengthen code to handle cases where
beforeChild is incorrectly set.

rendering/RenderObject.h: remove anonymousContainer function since

the new logic in RenderBlock does not need it.

LayoutTests:

fast/runin/runin-div-before-child-expected.png: Added.
fast/runin/runin-div-before-child-expected.txt: Added.
fast/runin/runin-div-before-child.html: Added.
fast/runin/runin-table-before-child-expected.png: Added.
fast/runin/runin-table-before-child-expected.txt: Added.
fast/runin/runin-table-before-child.html: Added.

9:14 PM Changeset in webkit [108605] by hayato@chromium.org

10 edits in trunk/Source/WebCore

Make ShadowRootList manage a node distribution.
https://bugs.webkit.org/show_bug.cgi?id=79008

Reviewed by Dimitri Glazkov.

The result of node distributions is currently stored in
ShadowRoot. To support multiple ShadowRoots, such node distribution
information should be managed in one place per shadow host. Now
ShadowRootList takes this responsibility on behalf of owing
multiple ShadowRoots. Clients should ask ShadowRootList for such
information, not for each ShadowRoot.

No tests. No change in behavior.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::attach):

dom/ShadowRoot.h:

(ShadowRoot):

dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::insertionPointFor):
(WebCore):
(WebCore::ShadowRootList::isSelectorActive):
(WebCore::ShadowRootList::ensureSelector):

dom/ShadowRootList.h:

(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):
(WebCore::ShadowRootList::selector):
(WebCore::ShadowRootList::host):

html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::willSelectOver):

html/shadow/HTMLContentSelector.h:

(HTMLContentSelector):

8:51 PM Changeset in webkit [108604] by commit-queue@webkit.org

4 edits
7 adds in trunk

Add multi channels support in AudioBus and AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79017

Patch by Wei James <james.wei@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Tests: webaudio/up-mixing-mono-51.html

webaudio/up-mixing-mono-stereo.html
webaudio/up-mixing-stereo-51.html

platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::processWithGainFromMonoStereo):
(WebCore::AudioBus::processWithGainFrom):

LayoutTests:

webaudio/resources/audio-testing.js:

(writeAudioBuffer):

webaudio/resources/mix-testing.js: Added.

(createToneBuffer):

webaudio/up-mixing-mono-51-expected.wav: Added.
webaudio/up-mixing-mono-51.html: Added.
webaudio/up-mixing-mono-stereo-expected.wav: Added.
webaudio/up-mixing-mono-stereo.html: Added.
webaudio/up-mixing-stereo-51-expected.wav: Added.
webaudio/up-mixing-stereo-51.html: Added.

8:24 PM Changeset in webkit [108603] by haraken@chromium.org

9 edits in trunk/Source/WebCore

[Supplemental] should support constants
https://bugs.webkit.org/show_bug.cgi?id=79303

Reviewed by Adam Barth.

Given that we have

interface [Supplemental=Y] X { constant int A = 123; }

then the code generator should generate

X::A

to refer to the constant. However, the current code generator generates Y::A instead.
This patch fixes it.

Test: bindings/scripts/test/TestSupplemental.idl

bindings/scripts/CodeGenerator.pm: Modified as described above.

(GenerateCompileTimeCheckForEnumsIfNeeded):

bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

page/DOMWindow.h: Moved DOMWindow::FileSystemType to DOMWindowFileSystem::FileSystemType.

(DOMWindow):

fileapi/DOMWindowFileSystem.h: Ditto.

(DOMWindowFileSystem):

fileapi/DOMWindowFileSystem.cpp: Ditto.

(WebCore):

8:01 PM Changeset in webkit [108602] by morrita@google.com

51 edits
2 adds in trunk

Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.

NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.

This change re-aligns the responsibility:

Now canHaveChildren() purely declares the ability of the renderer. If the renderer is capable of having children, it return true regardless of HTML semantics.

On the other hand, childShouldCreateRenderer() cares about the semantics. If the element doesn't allow children to be rendered, this returns false.

Note that these decision on elements are contextual. Each element needs to know which role it is playing in the tree composition algorithm of Shadow DOM. That's why the method parameter is changed from Node* to NodeRenderingContext.

With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:

RenderButton, RenderListBox, RenderMenuList, RenderMeter, RenderProgress, RenderTextControl.

Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.

Tests: fast/dom/shadow/shadow-on-image-expected.html
fast/dom/shadow/shadow-on-image.html

dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

dom/Element.h:

(Element):

dom/Node.h:
dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):

html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

html/HTMLDetailsElement.h:

(HTMLDetailsElement):

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):

html/HTMLMeterElement.h:

(HTMLMeterElement):

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):

html/HTMLMediaElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer):
(WebCore):

html/HTMLProgressElement.h:

(HTMLProgressElement):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):

html/HTMLSelectElement.h:

(HTMLSelectElement):

html/HTMLSummaryElement.cpp:
html/HTMLSummaryElement.h:

(HTMLSummaryElement):

html/HTMLTextFormControlElement.cpp:
html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

rendering/RenderButton.cpp:
rendering/RenderButton.h:

(RenderButton):

rendering/RenderListBox.h:

(RenderListBox):

rendering/RenderMedia.h:

(WebCore::RenderMedia::canHaveChildren):

rendering/RenderMenuList.h:
rendering/RenderMeter.h:
rendering/RenderProgress.h:
rendering/RenderTextControl.h:
rendering/svg/RenderSVGRoot.h:
svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

svg/SVGAElement.h:

(SVGAElement):

svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

svg/SVGDocument.h:

(SVGDocument):

svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

svg/SVGElement.h:

(SVGElement):

svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

svg/SVGSwitchElement.h:

(SVGSwitchElement):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

svg/SVGTRefElement.h:

(SVGTRefElement):

svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

svg/SVGTSpanElement.h:

(SVGTSpanElement):

svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

svg/SVGTextElement.h:

(SVGTextElement):

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

svg/SVGTextPathElement.h:

LayoutTests:

fast/dom/shadow/shadow-on-image-expected.html: Added.
fast/dom/shadow/shadow-on-image.html: Added.

7:57 PM Changeset in webkit [108601] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] NetworkJob can access deleted objects.
https://bugs.webkit.org/show_bug.cgi?id=79246

Patch by Yong Li <yoli@rim.com> on 2012-02-22
Reviewed by Antonio Gomes.

When a NetworkJob is created by unload handler, we still need
to send the request to the server, but we shouldn't save and
keep using the Frame pointer because the frame is being detached.
The NetworkJob will be cancelled by PingLoader as soon as it gets
first response from host.
Also see https://bugs.webkit.org/show_bug.cgi?id=30457.

No new tests because existing test case is good enough like
LayoutTests/http/tests/navigation/image-load-in-unload-handler.html.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):

7:44 PM Changeset in webkit [108600] by bashi@chromium.org

3 edits in trunk/Source/WebCore

[WebSocket] Remove zlib.h from WebSocketDeflater.h
https://bugs.webkit.org/show_bug.cgi?id=79298

Use forward declaration and OwnPtr for z_stream to move zlib.h from
.h file to .cpp file.

Reviewed by Kent Tamura.

No new tests. No behavior change.

websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):

websockets/WebSocketDeflater.h:

(WebSocketDeflater): Use OwnPtr for m_stream.
(WebSocketInflater): Ditto.

7:37 PM Changeset in webkit [108599] by yutak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Two inspector tests are timing out on Mac Debug.

platform/chromium/test_expectations.txt:

7:37 PM Changeset in webkit [108598] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Add unit test for surface occlusion
https://bugs.webkit.org/show_bug.cgi?id=79302

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):
(WebCore):

7:07 PM Changeset in webkit [108597] by jamesr@google.com

12 edits in trunk/Source

Remove GraphicsContext3D::paintsIntoCanvasBuffer and unify WebGL and canvas 2d logic
https://bugs.webkit.org/show_bug.cgi?id=79317

Reviewed by Kenneth Russell.

Source/WebCore:

HTMLCanvasElement::paint needs to know whether to attempt to paint the canvas buffer for its context. In the
case of an accelerated canvas or WebGL context, unless we are printing it is typically the composited layer's
responsibility to present the contents and the element itself is only responsible for backgrounds, borders and
the like. This removes a rather indirect path that WebGL content used to take to accomplish this and unifies
the logic with CanvasRenderingContext2D's, which has the exact same needs.

Covered by existing canvas layout tests.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::paint):

html/HTMLCanvasElement.h:

(HTMLCanvasElement):

html/canvas/CanvasRenderingContext.h:
html/canvas/CanvasRenderingContext2D.cpp:
html/canvas/CanvasRenderingContext2D.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore):

html/canvas/WebGLRenderingContext.h:
platform/graphics/GraphicsContext3D.h:

Source/WebKit/chromium:

Remove paintsIntoCanvasBuffer() implementations.

src/GraphicsContext3DChromium.cpp:

(WebCore):

src/GraphicsContext3DPrivate.h:

7:05 PM Changeset in webkit [108596] by commit-queue@webkit.org

14 edits
4 adds in trunk

PopStateEvent.state should use the same object as history.state
https://bugs.webkit.org/show_bug.cgi?id=77493

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-22
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-history-getter.html

fast/loader/stateobjects/state-attribute-popstate-event.html

bindings/js/JSPopStateEventCustom.cpp:

(WebCore):
(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):

bindings/v8/V8HiddenPropertyName.h:

(WebCore):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore):
(WebCore::cacheState):
(WebCore::V8PopStateEvent::stateAccessorGetter):

dom/Document.cpp:

(WebCore::Document::enqueuePopstateEvent):

dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):

dom/PopStateEvent.h:

(WebCore):
(PopStateEvent):
(WebCore::PopStateEvent::history):

dom/PopStateEvent.idl:
page/History.cpp:

(WebCore::History::stateChanged):
(WebCore):
(WebCore::History::isSameAsCurrentState):

page/History.h:

(History):

LayoutTests:

fast/loader/stateobjects/state-attribute-history-getter-expected.txt: Added.
fast/loader/stateobjects/state-attribute-history-getter.html: Added.
fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt:
fast/loader/stateobjects/state-attribute-only-one-deserialization.html:
fast/loader/stateobjects/state-attribute-popstate-event-expected.txt: Added.
fast/loader/stateobjects/state-attribute-popstate-event.html: Added.

7:01 PM Changeset in webkit [108595] by adamk@chromium.org

2 edits in trunk/Source/WebCore

Remove obsolete FIXMEs from ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=79295

Reviewed by Ryosuke Niwa.

Each of these three identical FIXMEs has since been fixed by adding
"RefPtr<Node> protect(this)" at the top of each method.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):

6:51 PM Changeset in webkit [108594] by dslomov@google.com

6 edits in trunk

[JSC] Implement ArrayBuffer and typed array cloning in JSC
https://bugs.webkit.org/show_bug.cgi?id=79294

Reviewed by Oliver Hunt.

Source/WebCore:

Covered by existing tests.

bindings/js/SerializedScriptValue.cpp:

(WebCore::typedArrayElementSize):
(WebCore):
(WebCore::CloneSerializer::dumpArrayBufferView):
(CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readArrayBufferViewSubtag):
(CloneDeserializer):
(WebCore::CloneDeserializer::readArrayBuffer):
(WebCore::CloneDeserializer::readArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

fast/canvas/webgl/array-message-passing-expected.txt: Updated expectation after cloning implemented.
fast/canvas/webgl/script-tests/array-message-passing.js: Added Uint8ClampedArray
platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Updated expectations. Fixing covered by https://bugs.webkit.org/show_bug.cgi?id=79291

6:24 PM Changeset in webkit [108593] by enne@google.com

2 edits in trunk/Source/WebCore

[chromium] Unreviewed speculative chromium-mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=75874

This broke in r108581.

platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebCore):

6:19 PM Changeset in webkit [108592] by commit-queue@webkit.org

3 edits
3 adds in trunk

exponentialRampToValue doesn't use starting value
https://bugs.webkit.org/show_bug.cgi?id=78035

Patch by Raymond Toy <Raymond Toy> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/audioparam-exponentialRampToValueAtTime.html

webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Set
starting value for exponential ramp.

LayoutTests:

webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Added.
webaudio/audioparam-exponentialRampToValueAtTime.html: Added.
webaudio/resources/audioparam-testing.js: Added.

(createConstantBuffer):
(createExponentialRampArray):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(doAutomation):

6:16 PM Changeset in webkit [108591] by yutak@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r108590.
http://trac.webkit.org/changeset/108590

I mistakenly disabled tests even though the fix was already
in.

tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):

6:09 PM Changeset in webkit [108590] by yutak@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed. Disable two tests from CCOcclusionTrackerTest
which cause assertion failures.

tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(WebCore::TEST):

6:08 PM Changeset in webkit [108589] by eae@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/platform

Removed unused methods from branch.

5:51 PM Changeset in webkit [108588] by enne@google.com

3 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline more svg tests.

This test was also broken after r108559. It times out on all platforms
but windows, so only rebaselining windows.

platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:

5:43 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

5:42 PM Changeset in webkit [108587] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Fix CCOcclusionTracker unit test assertion
https://bugs.webkit.org/show_bug.cgi?id=79275

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):

5:40 PM Changeset in webkit [108586] by kling@webkit.org

4 edits in trunk/Source/WebCore

Make parsing color presentation attributes do less pointless work.
<http://webkit.org/b/79304>

Reviewed by Antti Koivisto.

Let HTMLElement::addHTMLColorToStyle() construct the color CSSValue directly
rather than passing a string that has to go through CSSParser.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

css/StylePropertySet.h:

Added a setProperty(propertyID, CSSValue) overload that expands shorthand
properties if necessary. Also added a little comment about the behavior
differences between setProperty() overloads.

html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

Changed this to return an RGBA32.

(WebCore::HTMLElement::addHTMLColorToStyle):

Figure out the RGB value and construct a (pooled) CSSValue directly.

5:35 PM Changeset in webkit [108585] by enne@google.com

6 edits
1 copy in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline zoom-replaced-intrinsic-ratio

This was broken after r108559 and the result looks reasonable given
the description of the change, so rebaselining.

platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

5:34 PM Changeset in webkit [108584] by dpranke@chromium.org

2 edits in trunk/LayoutTests

fast/files/create-blob-url-crash.html is no longer flaky.
https://bugs.webkit.org/show_bug.cgi?id=60125

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

5:32 PM Changeset in webkit [108583] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Fix to launch the EWebLauncher using the script, run-launcher.
https://bugs.webkit.org/show_bug.cgi?id=79076

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-02-22
Reviewed by Andreas Kling.

Scripts/webkitdirs.pm: Fix the path of libewebkit.so.

(builtDylibPathForName):

5:25 PM Changeset in webkit [108582] by barraclough@apple.com

6 edits in trunk

Implement DefineOwnProperty for the arguments object
https://bugs.webkit.org/show_bug.cgi?id=79309

Reviewed by Sam Weinig.

Source/JavaScriptCore:

runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

Deleting an argument should also delete the copy on the object, if any.

(JSC::Arguments::defineOwnProperty):

Defining a property may override the live mapping.

runtime/Arguments.h:

(Arguments):

LayoutTests:

fast/js/arguments-expected.txt:
fast/js/script-tests/arguments.js:
- Added test cases

5:22 PM Changeset in webkit [108581] by commit-queue@webkit.org

36 edits
1 copy
5 adds in trunk/Source

[chromium] Plumb from GraphicsLayer to the cc thread animation code
https://bugs.webkit.org/show_bug.cgi?id=75874

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

WebCore.gypi:
page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setThreadedAnimationEnabled):
(WebCore::Settings::threadedAnimationEnabled):
(Settings):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::addChild):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::addAnimation):
(WebCore):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::pushPropertiesTo):

platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::layerAnimationController):
(WebCore::LayerChromium::numChildren):

platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::create):
(WebCore):
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::isWaiting):
(WebCore::CCActiveAnimation::isRunningOrHasRun):
(WebCore::CCActiveAnimation::cloneForImplThread):
(WebCore::CCActiveAnimation::synchronizeProperties):

platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::AnimationSignature::AnimationSignature):
(AnimationSignature):
(WebCore::CCActiveAnimation::id):
(WebCore::CCActiveAnimation::group):
(WebCore::CCActiveAnimation::signature):

platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCAnimationCurve):
(CCTransformAnimationCurve):

platform/graphics/chromium/cc/CCAnimationEvents.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationCurve.h.

(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(CCAnimationStartedEvent):

platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Added.

(WebCore):
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::~CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::pauseAnimation):
(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::resumeAnimations):
(WebCore::CCLayerAnimationController::synchronizeAnimations):
(WebCore::CCLayerAnimationController::removeCompletedAnimations):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::pushAnimationProperties):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::remove):

platform/graphics/chromium/cc/CCLayerAnimationController.h: Added.

(WebCore):
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::activeAnimations):

platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::~CCLayerAnimationControllerImpl):
(WebCore):
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::add):
(WebCore::CCLayerAnimationControllerImpl::getActiveAnimation):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImplClient):
(CCLayerAnimationControllerImpl):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::opacity):
(WebCore::CCLayerImpl::transform):
(WebCore::CCLayerImpl::bounds):
(WebCore::CCLayerImpl::layerAnimationController):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::needsAnimateLayers):
(WebCore::CCLayerTreeHostImpl::setNeedsAnimateLayers):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):
(WebCore):
(DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::~DebugScopedSetMainThread):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setAnimationEvents):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

WebKit.gypi:
public/WebSettings.h:
public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setThreadedAnimationEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

tests/CCActiveAnimationTest.cpp:

(WebCore::createActiveAnimation):

tests/CCAnimationTestCommon.cpp: Added.

(WebKitTests):
(WebKitTests::FakeFloatAnimationCurve::FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::~FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::clone):
(WebKitTests::FakeTransformTransition::FakeTransformTransition):
(WebKitTests::FakeTransformTransition::~FakeTransformTransition):
(WebKitTests::FakeTransformTransition::getValue):
(WebKitTests::FakeTransformTransition::clone):
(WebKitTests::FakeFloatTransition::FakeFloatTransition):
(WebKitTests::FakeFloatTransition::~FakeFloatTransition):
(WebKitTests::FakeFloatTransition::getValue):
(WebKitTests::FakeLayerAnimationControllerImplClient::FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::~FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeFloatTransition::clone):
(WebKitTests::addOpacityTransition):

tests/CCAnimationTestCommon.h: Added.

(WebCore):
(WebKitTests):
(FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::duration):
(WebKitTests::FakeFloatAnimationCurve::getValue):
(FakeTransformTransition):
(WebKitTests::FakeTransformTransition::duration):
(FakeFloatTransition):
(WebKitTests::FakeFloatTransition::duration):
(FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::id):
(WebKitTests::FakeLayerAnimationControllerImplClient::opacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::setOpacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::transform):
(WebKitTests::FakeLayerAnimationControllerImplClient::setTransform):
(WebKitTests::FakeLayerAnimationControllerImplClient::bounds):

tests/CCLayerAnimationControllerImplTest.cpp:

(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):

tests/CCLayerAnimationControllerTest.cpp: Added.

(WebKitTests):
(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):

tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):

tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::animateLayers):
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF):
(MockLayerAnimationController):
(WTF::MockLayerAnimationController::create):
(WTF::MockLayerAnimationController::addAnimation):
(WTF::MockLayerTreeHostClient::scheduleComposite):
(WTF::CCLayerTreeHostTest::postAddAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::afterTest):
(WTF::TEST_F):

tests/TreeSynchronizerTest.cpp:

(FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::synchronizedAnimations):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::synchronizeAnimations):
(WebKitTests):
(WebKitTests::TEST):

5:20 PM Changeset in webkit [108580] by eae@chromium.org

3587 edits
804 copies
338 deletes in branches/subpixellayout

Merge trunk changes up until 108547 into subpixel branch.

5:13 PM Changeset in webkit [108579] by andersca@apple.com

2 edits in trunk/Source/WebCore

Subframes with scrollable areas must be added to the non-fast scrollable region
https://bugs.webkit.org/show_bug.cgi?id=79306
<rdar://problem/10915564>

Reviewed by Andreas Kling.

When computing the non-fast scrollable region, add subframes with scrollable regions to the region.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):

5:04 PM Changeset in webkit [108578] by enne@google.com

16 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Update expectations after skia roll.

It is most likely that the Skia roll from 3216 to 3226 slightly
changed image expectations for the following tests. None of these are
perceptually any different, so just rebaselining.

platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-linux/svg/custom/focus-ring-expected.png:
platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-win/svg/custom/focus-ring-expected.png:
platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:

4:56 PM Changeset in webkit [108577] by commit-queue@webkit.org

5 edits in trunk

[Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::gestureTap):

DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Unskip gestureTap test.

platform/qt/Skipped:

4:49 PM WebKitIDL edited by ericu@chromium.org

Copied info from http://trac.webkit.org/wiki/IdlAttributes (diff)

4:47 PM Changeset in webkit [108576] by Nate Chapin

3 edits
2 adds in trunk

Source/WebCore: CachedResourceLoader ignores the Range header
in determineRavlidationPolicy(), resulting in incorrect
cache hits.

Reviewed by Adam Barth.

Test: http/tests/xmlhttprequest/range-test.html
Test written by Aaron Colwell (acolwell@chromium.org).

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests: Test Range header compliance for CachedResources.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Adam Barth.

http/tests/xmlhttprequest/range-test-expected.txt: Added.
http/tests/xmlhttprequest/range-test.html: Added.

4:44 PM Changeset in webkit [108575] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Generalize svg failures from r108494.

platform/chromium/test_expectations.txt:

4:42 PM Changeset in webkit [108574] by Antti Koivisto

8 edits
3 adds in trunk

REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
https://bugs.webkit.org/show_bug.cgi?id=79186

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/font-face-insert-link.html

If a dynamically inserted stylesheet contains @font-face rules, we may fail to update the rendering.

Before r104060 the style selector was destroyed on every style change, and the font selector along with it.
This is no longer the case and we can't rely on comparing font selector pointers when comparing Fonts
for equality. This patch adds version number to the font selector and checks it in Font::operator==.
The version number is incremented when new font-face rules are added to the font selector.

FontFallbackList is an object shared between Fonts so the extra field shouldn't matter much in terms
of memory.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):

css/CSSFontSelector.h:

(CSSFontSelector):

platform/graphics/Font.cpp:

(WebCore::Font::operator==):

platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):

platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::fontSelectorVersion):

platform/graphics/FontSelector.h:

(FontSelector):

LayoutTests:

fast/css/font-face-insert-link-expected.txt: Added.
fast/css/font-face-insert-link.html: Added.
fast/css/resources/ahem.css: Added.

(@font-face):

4:38 PM Changeset in webkit [108573] by Nate Chapin

7 edits in trunk

Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html

should no longer be flaky.

loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.

(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.

loader/cache/CachedRawResource.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether

or not to call didAddClient.

(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.

If called on a timer, move the client between sets.

(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and

return true if it can.

(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.

loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

platform/chromium/test_expectations.txt:

4:26 PM Changeset in webkit [108572] by kubo@profusion.mobi

1 edit
2 deletes in trunk

[CMake] Remove FindGDK.cmake and FindGDK-PixBuf.cmake
https://bugs.webkit.org/show_bug.cgi?id=79292

Reviewed by Daniel Bates.

These files were committed when the EFL port's buildsystem code
was upstreamed, but are currently not being used anywhere, as the EFL
port has not depended on GDK for a long time.

Source/cmake/FindGDK-PixBuf.cmake: Removed.
Source/cmake/FindGDK.cmake: Removed.

4:24 PM Changeset in webkit [108571] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Implement TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange
https://bugs.webkit.org/show_bug.cgi?id=79297
<rdar://problem/10748510>

Reviewed by Beth Dakin.

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
Send a message to the web process.

WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setDeviceScaleFactor):
Add empty stub.

WebProcess/WebPage/DrawingArea.messages.in:

Add SetDeviceScaleFactor message.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Call WebPage::setDeviceScaleFactor.

4:16 PM Changeset in webkit [108570] by beidson@apple.com

14 edits in trunk

<rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs

Reviewed by NOBODY (OOPS!).

Source/WebKit2:

Anytime the WebProcess sends a sync message up to the UI Process a hang can ensue.

In the case of shouldGoToBackForwardListItem it seems many clients want a back/forward
notification but don't actually want to make a policy decision.

Making it an asynchronous notification instead of a synchronous policy call will remove the
possibility of a hang here.

If clients later decide it is important to have a policy here we should implement a form of
shouldGoToBackForwardListItem in the bundle loader client.

Add a notification "willGoToBackForwardListItem" to the WKPageLoaderClient:

UIProcess/API/C/WKPage.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient): Tell the WebProcess whether it should be

sending the shouldGoToBackForwardListItem or willGoToBackForwardListItem form of this message.

(WebKit::WebPageProxy::shouldGoToBackForwardListItem):
(WebKit::WebPageProxy::willGoToBackForwardListItem):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in: Add an asynchronous WillGoToBackForwardListItem message

Store a flag in the WebProcess - Sent from the UIProcess - to tell the FrameLoaderClient which form
of the callback should be used:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::willGoToBackForwardItemCallbackEnabled):
(WebKit::WebPage::setWillGoToBackForwardItemCallbackEnabled):

WebProcess/WebPage/WebPage.messages.in:

UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Only consider calling this for

version 0 clients.

(WebKit::WebLoaderClient::willGoToBackForwardListItem): Later clients get this callback.

UIProcess/WebLoaderClient.h:

(WebLoaderClient):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem): Send either the synchronous "should" message

or the asynchronous "will" message depending on which the WebProcess was last told that the
UIProcess expects. There is an edge case where the wrong one might be sent because the WebProcess
hasn't received the message about a change in the WKPageLoaderClient yet but that's probably okay;
It seems unlikely that a UIProcess client would ever rapidly change between v0 and other versions
of the loader client and the UIProcess of WebKit2 is equipped to handle that case if it comes up.

Tools:

Update our tools to the new form of the PageLoadClient.

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

3:47 PM Changeset in webkit [108569] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.6.2

Tagging the WebKitGTK+ 1.6.2 release

3:46 PM Changeset in webkit [108568] by barraclough@apple.com

8 edits in trunk

Fix Object.freeze for non-final objects.
https://bugs.webkit.org/show_bug.cgi?id=79286

Reviewed by Oliver Hunt.

For vanilla objects we implement this with a single transition, for objects
with special properties we should just follow the spec defined algorithm.

Source/JavaScriptCore:

runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):

this does need to handle inextensible objects.

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):

Implement spec defined algorithm for non-final objects.

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):

freeze should set m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.

runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(JSC::Structure::setContainsReadOnlyProperties):
(Structure):

renamed m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.

LayoutTests:

fast/js/preventExtensions-expected.txt:
fast/js/script-tests/preventExtensions.js:
- added new tests.

3:46 PM Changeset in webkit [108567] by dbates@webkit.org

1 edit in trunk/Source/WebCore/ChangeLog

Update change log entry for r108561 to reflect removal of "if (m_dispatchSoonList.isEmpty())".
https://bugs.webkit.org/show_bug.cgi?id=78840

Mention removal of unnecessary check for empty list m_dispatchSoonList in EventSender::cancelEvent().

Also, fix the date in the change log entry for changeset r108562 since it landed today (02/22/2012).

3:45 PM Changeset in webkit [108566] by jonlee@apple.com

3 edits in trunk/Source/WebKit2

[WK2] Clearing notifications does not clean up internal state
https://bugs.webkit.org/show_bug.cgi?id=78861
<rdar://problem/10881167>

Reviewed by Anders Carlsson.

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::clearNotifications): This function was missing removing the notification
entries from the other maps.
(WebKit::WebNotificationManager::didDestroyNotification): When the notification is destroyed, it should
also be removed from the context map.
(WebKit::WebNotificationManager::didCloseNotifications): Refactor to pull out the code that removes
a provided notification from the context map.
(WebKit::WebNotificationManager::removeNotificationFromContextMap): Find the notification in the map, and
remove it. If the map is empty, get rid of the entry.

WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

3:44 PM Changeset in webkit [108565] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.6.3

Tagging the WebKitGTK+ 1.6.3 release

3:43 PM Changeset in webkit [108564] by Martin Robinson

1 copy in releases/WebKitGTK/webkit-1.7.90

Tagging the WebKitGTK+ 1.7.90 release

3:43 PM Changeset in webkit [108563] by jonlee@apple.com

2 edits in trunk/Source/WebKit2

Code cleanup in WebNotificationManager (79285)
https://bugs.webkit.org/show_bug.cgi?id=79285
<rdar://problem/10914522>

Reviewed by Anders Carlsson.

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Simplify adding a blank vector to the map using .add(),
similar to what is found in WebNotificationClient.mm in WebKit 1.

3:40 PM Changeset in webkit [108562] by rniwa@webkit.org

11 edits in trunk/Source

Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Reviewed by Enrica Casucci.

Source/WebCore:

Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
to StylePropertySet.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::computeAndSetTypingStyle):

editing/Editor.h:

(WebCore):
(Editor):

editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldApplyStyle):

page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

page/EditorClient.h:

(WebCore):
(EditorClient):

Source/WebKit/blackberry:

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldApplyStyle):

WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldApplyStyle):

src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldApplyStyle):

WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

WebView/WebFrame.mm:

(-[WebFrame _setTypingStyle:withUndoAction:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):

WebView/WebView.mm:

(-[WebView applyStyle:]):

Source/WebKit/qt:

WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldApplyStyle):

WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):

WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldApplyStyle):

Source/WebKit/wx:

WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldApplyStyle):

WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

WebProcess/WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

3:28 PM Changeset in webkit [108561] by dbates@webkit.org

8 edits
1 add in trunk/Source/WebCore

Abstract ImageEventSender into a general purpose EventSender
https://bugs.webkit.org/show_bug.cgi?id=78840

Reviewed by Adam Barth.

Abstract the functionality in ImageEventSender so that it can be used again.
This functionality may be useful in fixing WebKit Bug #38995.

No functionality was changed; no new tests.

GNUmakefile.list.am: Added EventSender.h.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/EventSender.h: Added.

(WebCore):
(EventSender):
(WebCore::EventSender::eventType):
(WebCore::EventSender::hasPendingEvents):
(WebCore::EventSender::timerFired):
(WebCore::::EventSender):
(WebCore::::dispatchEventSoon):
(WebCore::::cancelEvent):
(WebCore::::dispatchPendingEvents):

loader/ImageLoader.cpp: Modified to use EventSender.

(WebCore):
(WebCore::ImageLoader::dispatchPendingEvent): Added; called by EventSender when the ImageLoader
should dispatch a pending BeforeLoad or Load event.

loader/ImageLoader.h:

(WebCore):
(ImageLoader):

3:23 PM Changeset in webkit [108560] by dbates@webkit.org

3 edits in trunk/Tools

new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
https://bugs.webkit.org/show_bug.cgi?id=79277

Reviewed by Adam Barth.

Pass command line argument no-saved-state to run-safari to disable Safari
state restoration for the session on OS 10.7.

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.show_results_html_file):

Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_show_results_html_file):

3:17 PM Changeset in webkit [108559] by commit-queue@webkit.org

6 edits
2 adds in trunk

Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-22
Reviewed by Nikolas Zimmermann.

Source/WebCore:

When computing its localToBorderBoxTransform, RenderSVGRoot was using its width and height
as the dimensions of the SVG viewport. However, width and height include CSS borders and
paddings, which are not part of the SVG viewport area. Now, RenderSVGRoot uses its
contentWidth and contentHeight, which correspond to the SVG viewport area.

Tests: svg/custom/svg-root-padding-border-margin-expected.html

svg/custom/svg-root-padding-border-margin.html

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):

LayoutTests:

platform/chromium/test_expectations.txt:
platform/mac/svg/custom/circle-move-invalidation-expected.png:
platform/mac/svg/custom/circle-move-invalidation-expected.txt:

This test contains a circle drawn inside a root SVG element with a 1px border. This bug
was causing WebKit to render the circle 1px too large, reflected in the expectations.
The expectations have been updated.

svg/custom/svg-root-padding-border-margin-expected.html: Added.
svg/custom/svg-root-padding-border-margin.html: Added.

3:15 PM Changeset in webkit [108558] by kubo@profusion.mobi

2 edits
2 deletes in trunk/Source/WebCore

[EFL] Get rid of GeolocationServiceEfl
https://bugs.webkit.org/show_bug.cgi?id=79270

Reviewed by Adam Barth.

These were just a bunch of dummy files with no real functionality, and
removing them helps the preparation of bug 78853, which will make
client-based geolocation the default.

No new tests, this functionality was not used.

PlatformEfl.cmake:
platform/efl/GeolocationServiceEfl.cpp: Removed.
platform/efl/GeolocationServiceEfl.h: Removed.

3:10 PM Changeset in webkit [108557] by jchaffraix@webkit.org

4 edits in trunk/Source/WebCore

Clean-up RenderTableSection::calcRowLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=77705

Reviewed by Eric Seidel.

Refactoring / simplication of the code.

This change removes some variables that were unneeded and were
hiding what the code was really doing. Also some of the code was
split and moved down to RenderTableCell.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

rendering/RenderTableCell.h:

(RenderTableCell):
Added the previous helper function to calculate the cell's
adjusted logical height.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
Removed some variables, simplified the rowspan logic to be clearer
(and added a comment about how we handle rowspans).

3:07 PM Changeset in webkit [108556] by abarth@webkit.org

10 edits
3 adds in trunk/Source/WebCore

Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
https://bugs.webkit.org/show_bug.cgi?id=79259

Reviewed by Eric Seidel.

This patch is part of our ongoing effort to remove ifdefs from code
classes. The FILE_SYSTEM code in DOMWindow doesn't really have any
necessary connection to DOMWindow. DOMWindow is just the context
object that the API hangs off of.

This patch moves the FILE_SYSTEM code into the fileapi folder using
[Supplemental].

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
fileapi/DOMWindowFileSystem.cpp: Added.

(WebCore):
(WebCore::DOMWindowFileSystem::DOMWindowFileSystem):
(WebCore::DOMWindowFileSystem::~DOMWindowFileSystem):
(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):

fileapi/DOMWindowFileSystem.h: Added.

(WebCore):
(DOMWindowFileSystem):

fileapi/DOMWindowFileSystem.idl: Added.
page/DOMWindow.cpp:

(WebCore):

page/DOMWindow.h:

(WebCore):
(DOMWindow):

page/DOMWindow.idl:

2:54 PM Changeset in webkit [108555] by macpherson@chromium.org

4 edits in trunk/Source/WebCore

Re-implement many more HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macros in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79200

Reviewed by Andreas Kling.

No new tests / refactoring only.

css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

rendering/style/RenderStyle.h:

2:52 PM Changeset in webkit [108554] by dcheng@chromium.org

3 edits in trunk/Source/WebKit/chromium

[chromium] Cleanup unused WebDragData methods after r107846
https://bugs.webkit.org/show_bug.cgi?id=78837

Reviewed by Tony Chang.

The deleted methods have been replaced by items() and setItems().

public/platform/WebDragData.h:

(WebDragData):

src/WebDragData.cpp:

(WebKit::WebDragData::addItem): Add ensureMutable() call to verify preconditions for

mutating the item store.

2:26 PM Changeset in webkit [108553] by mhahnenberg@apple.com

7 edits in trunk/Source/JavaScriptCore

Allocations from CopiedBlocks should always be 8-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=79271

Reviewed by Geoffrey Garen.

heap/CopiedAllocator.h:

(JSC::CopiedAllocator::allocate):

heap/CopiedBlock.h: Changed to add padding so that the start of the payload is always

guaranteed to be 8 byte aligned on both 64- and 32-bit platforms.
(CopiedBlock):

heap/CopiedSpace.cpp: Changed all assertions of isPointerAligned to is8ByteAligned.

(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::getFreshBlock):

heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::allocateFromBlock):

runtime/JSArray.h:

(ArrayStorage): Added padding for ArrayStorage to make sure that it is always 8 byte
aligned on both 64- and 32-bit platforms.

wtf/StdLibExtras.h:

(WTF::is8ByteAligned): Added new utility function that functions similarly to the
way isPointerAligned does, but it just always checks for 8 byte alignment.
(WTF):

2:25 PM Changeset in webkit [108552] by eae@chromium.org

10 edits in branches/subpixellayout/Source/WebCore

Fix qt build on branch.

2:21 PM Changeset in webkit [108551] by tsepez@chromium.org

4 edits
8 adds in trunk

XSSAuditor bypass with <svg> tags and html-entities.
https://bugs.webkit.org/show_bug.cgi?id=78836

Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html

http/tests/security/xssAuditor/script-tag-inside-svg-tag.html
http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html
http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html

html/parser/XSSAuditor.cpp:

(WebCore::isNonCanonicalCharacter):
(WebCore::isTerminatingCharacter):
(WebCore):
(WebCore::startsHTMLCommentAt):
(WebCore::startsSingleLineCommentAt):
(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterEndToken):
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::snippetForJavaScript):

html/parser/XSSAuditor.h:

(XSSAuditor):

LayoutTests:

http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt: Added.
http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html: Added.
http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-inside-svg-tag.html: Added.
http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html: Added.
http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html: Added.

2:09 PM Changeset in webkit [108550] by andersca@apple.com

2 edits in trunk/Source/WebCore

Crash when marking cached pages for full style recalc
https://bugs.webkit.org/show_bug.cgi?id=79276
<rdar://problem/10884036>

Reviewed by Beth Dakin.

Guard against a null history item.

history/BackForwardController.cpp:

(WebCore::BackForwardController::markPagesForFullStyleRecalc):

2:03 PM Changeset in webkit [108549] by eae@chromium.org

43 edits in branches/subpixellayout/Source/WebCore

Revert baselinePosition to int on branch.

1:56 PM Changeset in webkit [108548] by commit-queue@webkit.org

7 edits
2 adds in trunk

Crash from empty anonymous block preceding :before content
https://bugs.webkit.org/show_bug.cgi?id=78250

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-22
Reviewed by David Hyatt.

Source/WebCore:

RenderListMarkers getting removed from the tree in updateMarkerLocation()
can leave parent anonymous blocks behind with no children. This was
confusing updateBeforeAfterContent() because it does not expect
an empty block to precede :before content renderers.

Fix is to remove the anonymous block if it will lose all of its children.

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerLocation):

LayoutTests:

Test exercises a crashing condition from extra :before content being
created after a RenderListMarker in an anonymous block has been moved.

Also rebasing some tests that had extraneous anonymous blocks in their
render tree dumps.

fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash-expected.txt: Added
fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html: Added
platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
platform/qt/editing/execCommand/create-list-with-hr-expected.txt:

1:33 PM Changeset in webkit [108547] by inferno@chromium.org

3 edits
2 adds in trunk

Source/WebCore: Crash due to accessing removed parent lineboxes when clearing view selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Eric Seidel.

When our block needed a full layout, we were deleting our own lineboxes
and letting descendant children (at any level in hierarchy and not just
immediate children) clear their own lineboxes as we keep laying them out.
This was problematic because those descendant children lineboxes were
pointing to removed parent lineboxes in the meantime. An example scenario
where this would go wrong is first-letter object removal, which can cause
clearing view selection, leading to accessing parent lineboxes. The patch
modifies clearing the entire linebox tree upfront. It shouldn't introduce
performance issues since it will eventually happen as we are laying out
those children.

Test: fast/css-generated-content/first-letter-textbox-parent-crash.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests: Crash due to accessing removed parent lineboxes when clearing view selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Eric Seidel.

fast/css-generated-content/first-letter-textbox-parent-crash-expected.txt: Added.
fast/css-generated-content/first-letter-textbox-parent-crash.html: Added.

1:24 PM Changeset in webkit [108546] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderMarquee.cpp

Fixing a merge artifact in RenderMarquee.

1:23 PM Changeset in webkit [108545] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Adding a floorToInt method for ease in moving to trunk, and flooring the right offset for line layout, as due to column layout, we can't be guaranteed to pixel snap at render time identically to layout time.

1:17 PM Changeset in webkit [108544] by Martin Robinson

1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.am

Fix bad merge

1:07 PM Changeset in webkit [108543] by inferno@chromium.org

3 edits
7 adds in trunk

Cloning and linebox issues in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78273

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/multicol/span/clone-flexbox.html

fast/multicol/span/clone-summary.html
fast/multicol/span/textbox-not-removed-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): Fix cloning algorithm to take
care of cloning descendant classes of RenderBlock.
(WebCore::RenderBlock::splitBlocks): When we move our inline children
to cloneBlock, we need to clear our entire line box tree. Any descendant
child in the hierarchy could be a part of our line box tree and will
never get cleared since the child has moved to new parent cloneBlock.

LayoutTests:

fast/multicol/span/clone-flexbox-expected.png:
fast/multicol/span/clone-flexbox-expected.txt: Added.
fast/multicol/span/clone-flexbox.html: Added. Test passes if we

see two RenderFlexibox in the rendertree.

fast/multicol/span/clone-summary-expected.png: Added.
fast/multicol/span/clone-summary-expected.txt: Added.
fast/multicol/span/clone-summary.html: Added. Test passes if we

see two RenderSummary in the rendertree.

fast/multicol/span/textbox-not-removed-crash-expected.txt: Added.
fast/multicol/span/textbox-not-removed-crash.html: Added. Test

passes it we do not crash on m_hasBadParent assert in InlineBox.

1:00 PM Changeset in webkit [108542] by commit-queue@webkit.org

5 edits in trunk/Source

CCLayerTreeHostImpl calls didDraw more frequently than willDraw
https://bugs.webkit.org/show_bug.cgi?id=79139

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Ensure that didDraw is called if and only if willDraw was called previously.

CCLayerTreeHostImplTest.didDrawNotCalledOnHiddenLayer has been added to ensure that
hidden layers, for which willDraw is not called, will also not have didDraw called.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::didDraw):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKit::DidDrawCheckLayer::willDraw):
(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::willDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit::TEST_F):
(WebKit):

12:57 PM Changeset in webkit [108541] by leviw@chromium.org

2 edits in trunk/Source/WebCore

ScrollbarThemeComposite::thumbPosition uses the result of a divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78910

Reviewed by Eric Seidel.

Adding a check to avoid doing a floating point divide by zero and assigning NaN to an integer.
This causes problems with our conversion to subpixel layout, which asserts when we overflow.

platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbPosition):

12:51 PM Changeset in webkit [108540] by commit-queue@webkit.org

2 edits in trunk/Tools

Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=77759

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-22
Reviewed by Tony Chang.

Fixes build with gcc 4.7.

r100432 added the include only for ANDROID; this changes the ifdef to
also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
longer implicitly includes unistd.h from standard headers and other
unix platforms are likely to get gcc 4.7 as well in the future.

DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

12:43 PM Changeset in webkit [108539] by enne@google.com

2 edits
7 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline svg expectations after r108493.

Blindly updating expected to actual on Chromium. They only started
failing after the base expectations were updated and don't have any
perceptual differences.

platform/chromium-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
platform/chromium-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
platform/chromium-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
platform/chromium-win/svg/custom/visited-link-color-expected.png: Added.
platform/chromium-win/svg/foreignObject/clip-expected.png: Added.
platform/chromium-win/svg/foreignObject/filter-expected.png: Added.
platform/chromium-win/svg/foreignObject/mask-expected.png: Added.
platform/chromium/test_expectations.txt:

12:41 PM Changeset in webkit [108538] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Have the DynamicsCompressorNode support multi-channel data
https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

12:31 PM Changeset in webkit [108537] by commit-queue@webkit.org

4 edits
3 adds in trunk

Not correctly recalculating layout for elements within nested SVG elements
https://bugs.webkit.org/show_bug.cgi?id=77535

Patch by Bear Travis <betravis@adobe.com> on 2012-02-22
Reviewed by Dirk Schulze.

Source/WebCore:

Relatively positioned text is not correctly updating its position when the
size of its nearest viewport changes. Updating to mark text for layout when
viewPort size changes.

Test: svg/repaint/inner-svg-change-viewPort-relative.svg

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

LayoutTests:

Adding a repaint test for a relatively sized inner svg and inner svg content when
its width/height changes.

platform/chromium/test_expectations.txt:
svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
svg/repaint/inner-svg-change-viewPort-relative.svg: Added.

12:18 PM Changeset in webkit [108536] by commit-queue@webkit.org

8 edits in trunk

[chromium] Fix remaining compositing/rubberbanding test failures
https://bugs.webkit.org/show_bug.cgi?id=78008

These were happening due to the fact that ScrollView wasn't updating
the overhang layer when the contentsSize was updated. This is necessary
because calculateOverhangAreasForPainting() takes the contentsSize into
account when determining whether the overhang areas are visible.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Re-enabled the following tests with updated baselines:

platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
platform/chromium/test_expectations.txt:

platform/ScrollView.cpp:

(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore):

platform/ScrollView.h:

(ScrollView):

LayoutTests:

Re-enabled the following tests with updated baselines:

platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
platform/chromium/test_expectations.txt:

12:15 PM Changeset in webkit [108535] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler has signed vs unsigned comparison.
https://bugs.webkit.org/show_bug.cgi?id=79261

Fix warning by casting the unsigned int to an int.

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-22
Reviewed by Rob Buis.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::rectForCaret):

12:11 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

12:09 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

12:08 PM Changeset in webkit [108534] by Martin Robinson

4 edits in releases/WebKitGTK/webkit-1.8

.: Update the version information in preparation for the 1.7.90 release.

Reviewed by Gustavo Noronha Silva.

configure.ac: Update versions.

Source/WebKit/gtk: Update the NEWS file in preparation for the 1.7.90 release.

Reviewed by Gustavo Noronha Silva.

NEWS: Update NEWS.

12:04 PM Changeset in webkit [108533] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Regression] network worker tests crash on qt.
https://bugs.webkit.org/show_bug.cgi?id=79263

Reviewed by Pavel Feldman.

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

12:02 PM Changeset in webkit [108532] by enne@google.com

4 edits
1 add in trunk/Source/WebCore

Unreviewed, rolling out r108518.
http://trac.webkit.org/changeset/108518
https://bugs.webkit.org/show_bug.cgi?id=75864

Breaks surfaceOcclusionWithOverlappingSiblingSurfaces unit test.

WebCore.gypi:
platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(CCLayerIterator):
(BackToFront):
(FrontToBack):

platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore):
(CCLayerIteratorPositionValue):
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

11:52 AM Changeset in webkit [108531] by Martin Robinson

9 edits in releases/WebKitGTK/webkit-1.8

Merging r108459

11:48 AM Changeset in webkit [108530] by Martin Robinson

7 edits in releases/WebKitGTK/webkit-1.8

Merging r108523

11:43 AM Changeset in webkit [108529] by Martin Robinson

13 edits in releases/WebKitGTK/webkit-1.8

Rolling out a bad merge

11:37 AM Changeset in webkit [108528] by mitz@apple.com

4 edits in trunk

REGRESSION (r62632): page-break-inside: avoid is ignored
https://bugs.webkit.org/show_bug.cgi?id=79262

Reviewed by Adele Peterson.

Source/WebCore:

This was disabled in r62632 because of <http://webkit.org/b/41532>. Changes to the
pagination code since then have invalidated that bug, so enabling the feature again does not
re-introduce the bug.

Updated expected results for printing/page-break-inside-avoid.html.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

LayoutTests:

printing/page-break-inside-avoid-expected.txt:

11:20 AM Changeset in webkit [108527] by Philippe Normand

8 edits in trunk

Unreviewed, rolling out r108522.
http://trac.webkit.org/changeset/108522
https://bugs.webkit.org/show_bug.cgi?id=76181

Broke 4 fullscreen tests on GTK.

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

tests/testwebview.c:
webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

webkit/webkitwebview.h:

(_WebKitWebViewClass):

Tools:

GtkLauncher/main.c:

(createBrowser):
(createWindow):

11:18 AM Changeset in webkit [108526] by Martin Robinson

13 edits in releases/WebKitGTK/webkit-1.8

Merging r108459

11:14 AM Changeset in webkit [108525] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Mark some XHR tests as asserting.
https://bugs.webkit.org/show_bug.cgi?id=79229

platform/chromium/test_expectations.txt:

11:12 AM Changeset in webkit [108524] by Philippe Normand

4 edits in trunk/Source/WebCore

[GStreamer] webkitwebsrc: use HTTP referer provided by MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=79236

Reviewed by Martin Robinson.

Store a pointer to the MediaPlayer object in the private structure
of the WebKitWebSrc element so we can call its public methods,
like ::referrer().

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(_WebKitWebSrcPrivate):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

10:56 AM Changeset in webkit [108523] by Martin Robinson

7 edits in trunk

[GTK] Clean build is broken when using make -j
https://bugs.webkit.org/show_bug.cgi?id=76388

GNUmakefile.am: Add new global source list variables.

Source/WebCore:

No new tests. This is just a build fix.

Use order-only dependencies to ensure that built sources are built before
files that depend on them.

GNUmakefile.am: Establish an order-only dependency on some built sources before starting

to build non-generated sources. Rename some temporary files and variables to be more consistent.

bindings/gobject/GNUmakefile.am: Updated to reflect new variable names.

Source/WebKit2:

GNUmakefile.am: Add some WebKit2 sources to global sources lists

so that we can refer to them in separate GNUmakefiles.

10:56 AM Changeset in webkit [108522] by Philippe Normand

8 edits in trunk

[GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76181

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Added entering-fullscreen and leaving-fullscreen signals, meant to
be used by the user agent to be notified when an element requests
full screen display and when the full screen display is to be
disabled.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::onFullscreenGtkKeyPressEvent):
(WebKit::ChromeClient::cancelFullScreen):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

WebCoreSupport/ChromeClientGtk.h:
tests/testwebview.c:
webkit/webkitwebview.cpp:

(webkit_web_view_real_entering_fullscreen):
(webkit_web_view_real_leaving_fullscreen):
(webkit_web_view_class_init):

webkit/webkitwebview.h:

Tools:

Use the two new entering/leaving fullscreen signals to hide/show
the tool bar, the status bar and ask the user's permission before
entering fullscreen.

GtkLauncher/main.c:

(webViewFullscreenMessageWindowClose):
(webViewWindowStateEvent):
(hide_widget):
(show_widget):
(webViewEnteringFullScreen):
(webViewLeavingFullScreen):
(createBrowser):
(createWindow):

10:45 AM Changeset in webkit [108521] by commit-queue@webkit.org

5 edits
3 adds in trunk/Source

[Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Adds a CCOcclusionTrackerBase template class that is able to track occlusion
of layers while traversing the layer tree from front-to-back, with typedefed
versions for the main and impl threads.

At each step of the front-to-back traversal, the class should be notified of
changes to the current render target, and when done working with a layer, the
layer is added the tracked occlusion.

The class provides tests for checking if a rect in content space
for a layer/surface is occluded by others in front of it.

Unit tests: CCOcclusionTrackerTest.cpp

WebCore.gypi:
platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.

(WebCore):
(WebCore::::enterTargetRenderSurface):
(WebCore::::finishedTargetRenderSurface):
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::::surfaceOccluded):
(WebCore::rectSubtractRegion):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::surfaceUnoccludedContentRect):
(WebCore::::currentOcclusionInScreenSpace):
(WebCore::::currentOcclusionInTargetSurface):

platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.

(WebCore):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
(StackObject):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

tests/CCOcclusionTrackerTest.cpp: Added.

(WebCore):
(WebCore::setLayerPropertiesForTesting):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TEST):

10:42 AM Changeset in webkit [108520] by jsbell@chromium.org

14 edits
1 add in trunk/Source/WebCore

[Chromium] IndexedDB: Integrate with about:tracing
https://bugs.webkit.org/show_bug.cgi?id=78831

Annotate interesting IDB functions so they show up in the
tracing utility included in the Chromium port.

Reviewed by Tony Chang.

WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):

storage/IDBCursor.cpp:

(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::direction):
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):
(WebCore::IDBCursorBackendImpl::prefetchReset):
(WebCore::IDBCursorBackendImpl::close):

storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::dispatchEvent):

storage/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::transaction):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::fetchKeyFromKeyPath):
(WebCore::injectKeyIntoKeyPath):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):

storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

storage/IDBTracing.h: Added.
storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

10:38 AM Changeset in webkit [108519] by evan@chromium.org

2 edits
3 copies in branches/chromium/1025

Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>

Reviewed by Simon Fraser.

Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).

Test: svg/text/tspan-dynamic-positioning.svg

rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):

Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.

platform/chromium/test_expectations.txt:
platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
svg/text/tspan-dynamic-positioning.svg: Added.

TBR=timothy_horton@apple.com
Review URL: https://chromiumcodereview.appspot.com/9429058

10:35 AM Changeset in webkit [108518] by commit-queue@webkit.org

4 edits
1 delete in trunk/Source/WebCore

[chromium] Push CCLayerIteratorPosition struct into CCLayerIterator class.
https://bugs.webkit.org/show_bug.cgi?id=75864

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::targetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):

platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.

10:35 AM Changeset in webkit [108517] by enne@google.com

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Marking svg failures from r108494.
https://bugs.webkit.org/show_bug.cgi?id=41386

platform/chromium/test_expectations.txt:

10:25 AM Changeset in webkit [108516] by commit-queue@webkit.org

2 edits in trunk/Tools

Update Linux ChromiumOS builders in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=79238

Patch by Rob Flack <flackr@chromium.org> on 2012-02-22
Reviewed by Ojan Vafai.

TestResultServer/static-dashboards/builders.js:

10:19 AM Changeset in webkit [108515] by dpranke@chromium.org

2 edits in trunk/Tools

webkitpy: test_function_length_check_definition_huge_lines is slow
https://bugs.webkit.org/show_bug.cgi?id=79185

Reviewed by Adam Barth.

This test takes ~3 seconds to run, apparently because we're
running a test on a 10,000 line function :). Dropping the
function length to 640 still exercises the code path and
provides a 10x speedup.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):
(CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):

10:17 AM WebKitGTK/1.8.x edited by sergio@webkit.org

(diff)

10:16 AM Changeset in webkit [108514] by dpranke@chromium.org

3 edits in trunk/Tools

webkitpy: speed up FileLockTest.test_lock_lifecycle
https://bugs.webkit.org/show_bug.cgi?id=79189

Reviewed by Adam Barth.

The unit test had a second lock trying to acquire a
lock already held, and a hard-coded timeout of one second.
I have changed the timeouts to a tenth of a second (which
is probably still fine) and changed the hard-spin on
the lock to a slow-spin every hundredth of a second.

Scripts/webkitpy/common/system/file_lock.py:

(FileLock.acquire_lock):

Scripts/webkitpy/common/system/file_lock_integrationtest.py:

(FileLockTest.setUp):
(FileLockTest.test_stuck_lock):

10:10 AM Changeset in webkit [108513] by rgabor@webkit.org

2 edits in trunk/Tools

build-webkit should use environment variable at number of CPU
detection on all platform
https://bugs.webkit.org/show_bug.cgi?id=79227

Reviewed by Martin Robinson.

Scripts/webkitdirs.pm:

(determineNumberOfCPUs):

9:44 AM Changeset in webkit [108512] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

[GTK][WK2] Add WebGL WebSetting.
https://bugs.webkit.org/show_bug.cgi?id=79217

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-22
Reviewed by Martin Robinson.

Add a WebSetting to enable/disable Webgl.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_webaudio):
(webkit_settings_get_enable_webgl):
(webkit_settings_set_enable_webgl):

UIProcess/API/gtk/WebKitSettings.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

9:39 AM Changeset in webkit [108511] by pfeldman@chromium.org

8 edits in trunk

Web Inspector: console doesn't show properly arrays from which tail values have been deleted
https://bugs.webkit.org/show_bug.cgi?id=79242

Reviewed by Yury Semikhatsky.

Source/WebCore:

English.lproj/localizedStrings.js:
inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._printArray.appendUndefined):
(WebInspector.ConsoleMessageImpl.prototype._printArray):

LayoutTests:

inspector/console/console-format-expected.txt:
inspector/console/console-format.html:
platform/chromium/inspector/console/console-format-collections-expected.txt:
platform/chromium/inspector/console/console-format-expected.txt:

9:26 AM Changeset in webkit [108510] by pfeldman@chromium.org

1 edit
2 copies in branches/chromium/1025

Merge 107681 - Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/copy-stack-trace.html

inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

LayoutTests:

inspector/debugger/copy-stack-trace-expected.txt: Added.
inspector/debugger/copy-stack-trace.html: Added.

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9430052

9:09 AM Changeset in webkit [108509] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: warning external font mime (font/font/woff).
https://bugs.webkit.org/show_bug.cgi?id=79244

Reviewed by Yury Semikhatsky.

inspector/front-end/Resource.js:

9:05 AM Changeset in webkit [108508] by yurys@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: use dots as markers on the counter graphs
https://bugs.webkit.org/show_bug.cgi?id=79243

Changed counter graphs marker and counter text styles.

Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._onMouseMove):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._recordIndexAt):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._clearMarkers):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._clear):

inspector/front-end/timelinePanel.css:

(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .title):
(.memory-counter-sidebar-info .counter-value):

8:54 AM Changeset in webkit [108507] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: make 'glue asynchronous events' optional.
https://bugs.webkit.org/show_bug.cgi?id=79240

Reviewed by Yury Semikhatsky.

English.lproj/localizedStrings.js:
inspector/front-end/Images/statusbarButtonGlyphs.png:
inspector/front-end/TimelinePanel.js:

inspector/front-end/timelinePanel.css:

(.glue-async-status-bar-item .glyph):
(.timeline-start-at-zero-status-bar-item .glyph):

8:47 AM Changeset in webkit [108506] by vsevik@chromium.org

4 edits
2 adds in trunk

Web Inspector: [REGRESSION] Console xhr logging is broken for async xhrs since r107672.
https://bugs.webkit.org/show_bug.cgi?id=79229

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/console-xhr-logging-async.html

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setInitialScriptContent):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

http/tests/inspector/console-xhr-logging-async-expected.txt: Added.
http/tests/inspector/console-xhr-logging-async.html: Added.

8:29 AM Changeset in webkit [108505] by mihnea@adobe.com

12 edits in trunk

[Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
https://bugs.webkit.org/show_bug.cgi?id=78960

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

Api/qwebsettings.h:

Tools:

DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

fast/repaint/japanese-rl-selection-repaint-in-regions.html:
fast/repaint/line-flow-with-floats-in-regions.html:
fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
fast/repaint/region-painting-invalidation.html:
fast/repaint/region-painting-via-layout.html:
platform/qt/Skipped:

8:08 AM Changeset in webkit [108504] by caseq@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: fix memory counters and start-at-zero modes of timeline panels to co-exist nicely
https://bugs.webkit.org/show_bug.cgi?id=79241

Reviewed by Yury Semikhatsky.

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.addTimlineEvent):

inspector/front-end/TimelineOverviewPane.js:

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._timelinesOverviewModeChanged):

7:42 AM Changeset in webkit [108503] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239

Unreviewed, skipping a test that started to fail after r108387.

platform/chromium/test_expectations.txt:

7:16 AM Changeset in webkit [108502] by caseq@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: [experimental] add a mode to display timeline events aligned by the start time
https://bugs.webkit.org/show_bug.cgi?id=79123

Reviewed by Pavel Feldman.

inspector/front-end/Images/statusbarButtonGlyphs.png:
inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._filterRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype._onWindowChanged):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype.get _startAtZero):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineStartAtZeroCalculator):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineStartAtZeroCalculator.prototype.calculateWindow):
(WebInspector.TimelineStartAtZeroCalculator.prototype.reset):
(WebInspector.TimelineStartAtZeroCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
(WebInspector.TimelinePanel.FormattedRecord.prototype.get aggregatedStats):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelineRecordFilter):
(WebInspector.TimelineRecordFilter.prototype.accept):
(WebInspector.TimelineStartAtZeroRecordFilter):
(WebInspector.TimelineStartAtZeroRecordFilter.prototype.accept):

inspector/front-end/timelinePanel.css:

(.timeline-start-at-zero #timeline-overview-sidebar):
(.timeline-start-at-zero #timeline-overview-grid):
(.timeline-overview-window):
(.timeline-start-at-zero .timeline-overview-window):
(.timeline-start-at-zero .timeline-overview-dividers-background):
(.timeline-overview-window-rulers):
(.timeline-start-at-zero #timeline-overview-memory):
(.popover .timeline-loading):
(.popover .timeline-scripting):
(.popover .timeline-rendering):
(.timeline-start-at-zero-status-bar-item .glyph):
(.timeline-start-at-zero-status-bar-item.toggled-on .glyph):
(.timeline-overview-start-at-zero):
(.timeline-overview-start-at-zero-bars):
(.timeline-overview-start-at-zero-bars .padding):
(.timeline-overview-start-at-zero-bars .timeline-bar-vertical):
(.timeline-bar-vertical div:first-child):
(.timeline-bar-vertical .timeline-loading):
(.timeline-bar-vertical .timeline-scripting):
(.timeline-bar-vertical .timeline-rendering):

7:15 AM Changeset in webkit [108501] by kenneth@webkit.org

5 edits in trunk/Source

[Qt] Disregard previous backing store as soon as possible https://bugs.webkit.org/show_bug.cgi?id=79232

Reviewed by Simon Hausmann and No'am Rosenthal.

Source/WebCore:

Make it possible to drop non-visible tiles and to test
if the current visible rect is fully covered.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::visibleContentsRect):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):

platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit2:

Between creating the new backing store and painting the content,
we do not want to drop the previous one as that might result in
briefly seeing flickering as the old tiles may be dropped before
something replaces them.

But we do need to drop it at some point and we need to make sure
to not spike the memory usage before of this.

What we now do, is to store the previous backing store as before,
but drop all tiles which are not visible and then drop it as soon
as the visible rect (which might change due if followed by a quick
panning) has been fully covered by tiles.

WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::updateContentBuffers):

7:12 AM Changeset in webkit [108500] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skipping one more mediastream failure on GTK.

platform/gtk/Skipped:

7:11 AM Changeset in webkit [108499] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt][WK2] Implement proxy authentication handling.
https://bugs.webkit.org/show_bug.cgi?id=78792

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

This patch corrects two bugs with the previous implementation:

The signal proxyAuthenticationRequired was not connected to a slot.
The slot onProxyAuthenticationRequired had the wrong parameters.

WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):

WebProcess/qt/QtNetworkAccessManager.h: Added include.

(QtNetworkAccessManager):

7:10 AM Changeset in webkit [108498] by Simon Hausmann

5 edits
1 delete in trunk/Source

[Qt] Move QMenu dependant scrollbar context menu handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=79233

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Move the code into WebKit/qt/Api/qwebpage.cpp, the only place where it is called from.

Target.pri: Remove ScrollbarQt.cpp from build.
platform/Scrollbar.h: Remove Qt-only context menu handling but make moveThum

accessible from the outside.

platform/qt/ScrollbarQt.cpp: Removed. Not needed anymore.

Source/WebKit/qt:

Move scrollbar context menu handling here, it's the only place where it is
used.

Api/qwebpage.cpp:

(handleScrollbarContextMenuEvent):
(QWebPage::swallowContextMenuEvent):

7:07 AM Changeset in webkit [108497] by vsevik@chromium.org

6 edits
6 adds in trunk

Web Inspector: retrieving content for some XHR requests crashes inspected page renderer
https://bugs.webkit.org/show_bug.cgi?id=79026

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed loading empty xhr content and xhr content decoding that was
broken in r107672.

Tests: http/tests/inspector/network/network-cyrillic-xhr.html

http/tests/inspector/network/network-empty-xhr.html

inspector/InspectorPageAgent.cpp:

(WebCore):
(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

inspector/InspectorPageAgent.h:

(WebCore):

inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::responseReceived):

inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::decoder):
(WebCore::NetworkResourcesData::ResourceData::setDecoder):

LayoutTests:

http/tests/inspector/network/network-cyrillic-xhr-expected.txt: Added.
http/tests/inspector/network/network-cyrillic-xhr.html: Added.
http/tests/inspector/network/network-empty-xhr-expected.txt: Added.
http/tests/inspector/network/network-empty-xhr.html: Added.
http/tests/inspector/network/resources/cyrillic.html: Added.
http/tests/inspector/network/resources/empty.html: Added.

7:05 AM Changeset in webkit [108496] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions
https://bugs.webkit.org/show_bug.cgi?id=79153

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-22
Reviewed by Yury Semikhatsky.

CParamType class removed completely, some ("virtual") methods are
removed. TypeModel notion is added instead with some minor helper
classes and methods.

inspector/CodeGeneratorInspector.py:

(DomainNameFixes):
(RawTypes.BaseType):
(RawTypes.String):
(RawTypes.String.get_raw_type_model):
(RawTypes.Int):
(RawTypes.Int.get_raw_type_model):
(RawTypes.Number):
(RawTypes.Number.get_raw_type_model):
(RawTypes.Bool):
(RawTypes.Bool.get_raw_type_model):
(RawTypes.Object):
(RawTypes.Object.get_raw_type_model):
(RawTypes.Any):
(RawTypes.Any.get_raw_type_model):
(RawTypes.Array):
(RawTypes.Array.get_raw_type_model):
(replace_right_shift):
(CommandReturnPassModel):
(CommandReturnPassModel.ByReference):
(CommandReturnPassModel.ByReference.init):
(CommandReturnPassModel.ByReference.get_return_var_type):
(CommandReturnPassModel.get_output_argument_prefix):
(CommandReturnPassModel.get_output_to_raw_expression):
(CommandReturnPassModel.get_output_parameter_type):
(CommandReturnPassModel.get_set_return_condition):
(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel.ByPointer.init):
(CommandReturnPassModel.ByPointer.get_return_var_type):
(TypeModel):
(TypeModel.RefPtrBased):
(TypeModel.RefPtrBased.init):
(TypeModel.RefPtrBased.get_optional):
(TypeModel.RefPtrBased.get_command_return_pass_model):
(TypeModel.RefPtrBased.get_input_param_type_text):
(TypeModel.RefPtrBased.get_event_setter_expression_pattern):
(TypeModel.Enum):
(TypeModel.Enum.init):
(TypeModel.Enum.get_optional):
(TypeModel.Enum.get_optional.EnumOptional):
(TypeModel.Enum.get_optional.EnumOptional.get_optional):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.Enum.get_input_param_type_text):
(TypeModel.Enum.get_event_setter_expression_pattern):
(TypeModel.Enum.get_command_return_pass_model):
(TypeModel.ValueType):
(TypeModel.ValueType.init):
(TypeModel.ValueType.get_optional):
(TypeModel.ValueType.get_command_return_pass_model):
(TypeModel.ValueType.get_input_param_type_text):
(TypeModel.ValueType.get_event_setter_expression_pattern):
(TypeModel.ValueType.ValueOptional):
(TypeModel.ValueType.ValueOptional.init):
(TypeModel.ValueType.ValueOptional.get_optional):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_input_param_type_text):
(TypeModel.ValueType.ValueOptional.get_event_setter_expression_pattern):
(TypeModel.init_class):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.get_type_model):
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.get_type_model):
(TypeBindings.create_type_declaration_.get_array_item_c_type_text):
(get_type_model):
(AdHocTypeContextImpl.init):
(PlainObjectBinding):
(PlainObjectBinding.get_type_model):
(AdHocTypeContext):
(ArrayBinding.get_array_item_c_type_text):
(ArrayBinding):
(ArrayBinding.get_type_model):
(RawTypeBinding.get_validator_call_text):
(RawTypeBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.get_type_model):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(Generator.go):
(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):

inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didParseSource):

7:00 AM Changeset in webkit [108495] by vsevik@chromium.org

14 edits
2 adds in trunk

Web Inspector: [InspectorIndexedDB] Show IndexedDB views on selection IndexedDB elements in resources panel.
https://bugs.webkit.org/show_bug.cgi?id=79098

Reviewed by Pavel Feldman.

Source/WebCore:

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

inspector/compile-front-end.sh:
inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._assertFrameId):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):

inspector/front-end/IndexedDBViews.js: Added.
inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement.prototype.onselect):

inspector/front-end/WebKit.qrc:
inspector/front-end/externs.js:
inspector/front-end/indexedDBViews.css: Added.
inspector/front-end/inspector.html:

LayoutTests:

http/tests/inspector/indexeddb/database-data.html:

6:49 AM Changeset in webkit [108494] by Nikolas Zimmermann

6 edits
21 adds in trunk

REGRESSION(58212): html foreignObjects with positions other than static not hidden correctly when parent has display:none
https://bugs.webkit.org/show_bug.cgi?id=41386

Reviewed by Zoltan Herczeg.

Source/WebCore:

r58212 gave SVGGElements a renderer, regardless if "display: none" was set or not, for various reasons (see change set).
The <g> renderer for such cases is a RenderSVGHiddenContainer. We make sure in SVG that such subtrees are never used
for painting & hittesting - they only exist for the purpose of SVG DOM (query getCTM, etc..) and to create renderers
for child resources, like <g display="none"><linearGradient>.

This concept still works fine for: <g display="none"><foreignObject><body>Foobar</body></foreignObject></g>, as
RenderSVGForeignObject::paint is never called thus we never paint the subtree of the <fO>. If the <body> elements
contains "position: relative" a new layer is created for the <body>. When the document paints we have two seperated
layers, and the <body> layer doesn't know that it's actually inside a "SVG hidden subtree", and gets painted, where it
shouldn't. HTML doesn't have this problems, as a display: none object, never creates a renderer.

The fix is to disallow layer creation in hidden SVG subtrees, to mimic what would happen if we'd follow HTML rules
to not create renderers for display: none objects. This avoids any indirections - as no layers are created anymore.

Tests: svg/foreignObject/fO-display-none-with-relative-pos-content.svg

svg/foreignObject/fO-display-none.svg
svg/foreignObject/fO-parent-display-changes.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-display-none.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange): Only create layers, if its allowed -- layerCreationAllowedForSubtree() will always return true for HTML, and only false for layers inside a hidden SVG subtree.

rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Only create layers, if its allowed.

rendering/RenderObject.h: Add inline layerCreationAllowedForSubtree() helper, that craws the tree to find a RenderSVGHiddenContainer ancestor, if not present, return true.

LayoutTests:

Add new tests covering <foreignObject> content inside a <g display="none">.

platform/chromium/test_expectations.txt:
platform/mac/svg/foreignObject/fO-display-none-expected.png: Added.
platform/mac/svg/foreignObject/fO-display-none-expected.txt: Added.
platform/mac/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Added.
platform/mac/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
platform/mac/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
platform/mac/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
platform/mac/svg/foreignObject/fO-parent-display-none-expected.png: Added.
platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Added.
platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Added.
platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Added.
platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
svg/foreignObject/fO-display-none-with-relative-pos-content.svg: Added.
svg/foreignObject/fO-display-none.svg: Added.
svg/foreignObject/fO-parent-display-changes.svg: Added.
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg: Added.
svg/foreignObject/fO-parent-display-none.svg: Added.
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg: Added.
svg/foreignObject/fO-parent-of-parent-display-none.svg: Added.

6:21 AM Changeset in webkit [108493] by Nikolas Zimmermann

35 edits in trunk/LayoutTests

2012-02-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix SVG pixel test results, which now show up as hash failures, since DRT was fixed to report these.

platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/mac/svg/clip-path/clip-in-mask-expected.png:
platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
platform/mac/svg/custom/circular-marker-reference-2-expected.png:
platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png:
platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png:
platform/mac/svg/custom/glyph-selection-non-bmp-expected.png:
platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
platform/mac/svg/custom/marker-opacity-expected.png:
platform/mac/svg/custom/non-circular-marker-reference-expected.png:
platform/mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
platform/mac/svg/hixie/error/017-expected.png:
platform/mac/svg/text/text-align-05-b-expected.png:
platform/mac/svg/text/text-path-01-b-expected.png:
platform/mac/svg/text/text-text-01-b-expected.png:
platform/mac/svg/text/text-text-07-t-expected.png:
platform/mac/svg/text/text-tselect-02-f-expected.png:
svg/as-image/svg-non-integer-scaled-image-expected.png:
svg/custom/visited-link-color-expected.png:
svg/custom/zero-path-square-cap-rendering2-expected.png:
svg/foreignObject/clip-expected.png:
svg/foreignObject/filter-expected.png:
svg/foreignObject/mask-expected.png:

6:18 AM Changeset in webkit [108492] by zherczeg@webkit.org

2 edits in trunk/Source/WebCore

Drop clipToImageBuffer from RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=79225

Reviewed by Nikolas Zimmermann.

-webkit-background-clip: text is a rarely used non-standard
feature uses clipToImageBuffer. It is replaced by
CompositeDestinationIn on a transparent layer. The new
approach has the same speed as the old one.

Existing tests cover this issue.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

5:56 AM Changeset in webkit [108491] by kenneth@webkit.org

7 edits in trunk/Source

Merge setVisibleRectTrajectoryVector and adjustVisibleRect to the more descriptive coverWithTilesIfNeeded https://bugs.webkit.org/show_bug.cgi?id=79230

Reviewed by Simon Hausmann.

Source/WebCore:

Both setVisibleRectTrajectoryVector and the adjustVisibleRect are
used for initiating re-tiling, so make that more obvious and merge
the two.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit/qt:

Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

Use coverWithTilesIfNeeded().

Source/WebKit2:

Replace use by coverWithTilesIfNeeded().

WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):

5:38 AM Changeset in webkit [108490] by Nikolas Zimmermann

3 edits
2 adds in trunk

REGRESSION: unbalanced transparency layers for clipPath
https://bugs.webkit.org/show_bug.cgi?id=78074

Reviewed by Zoltan Herczeg.

Source/WebCore:

If we're rendering to a mask image buffer, all children are rendered with opacity=1, regardless what their RenderStyles specify.
SVGRenderSupport::finishRenderSVGContent() did not take this into account and always called endTransparencyLayer(). Fix that
by checking if we're rendering to a mask image buffer, if so don't call endTransparencyLayer().

Add new reftest covering both the visual & logical correctness (no assertion).

Tests: svg/clip-path/opacity-assertion-expected.svg

svg/clip-path/opacity-assertion.svg

rendering/svg/SVGRenderSupport.cpp:

(WebCore::isRenderingMaskImage): Extraced as sharable helper function.
(WebCore::SVGRenderSupport::prepareToRenderSVGContent): Factor out isRenderingMaskImage() function.
(WebCore::SVGRenderSupport::finishRenderSVGContent): Only call endTransparencyLayer(), if we actually called beginTL() first.

LayoutTests:

svg/clip-path/opacity-assertion-expected.svg: Added.
svg/clip-path/opacity-assertion.svg: Added.

5:36 AM Changeset in webkit [108489] by kenneth@webkit.org

2 edits in trunk/Source/WebCore

Improve comments in tiling code.

Rubberstamped by Simon Hausmann.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

5:27 AM Changeset in webkit [108488] by pfeldman@chromium.org

4 edits in trunk/Source/WebCore

Not reviewed: build fix.

inspector/InspectorController.cpp:
inspector/InspectorController.h:

(InspectorController):

5:25 AM Changeset in webkit [108487] by commit-queue@webkit.org

7 edits in trunk

[chromium] Build WebKit with MEDIA_STREAM disabled.
https://bugs.webkit.org/show_bug.cgi?id=79214

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-22
Reviewed by Kent Tamura.

Source/WebKit/chromium:

src/UserMediaClientImpl.h:

Tools:

DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
DumpRenderTree/chromium/WebUserMediaClientMock.h:
DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createMediaPlayer):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

5:13 AM Changeset in webkit [108486] by pfeldman@chromium.org

20 edits in trunk

Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events.
https://bugs.webkit.org/show_bug.cgi?id=79116

Reviewed by Yury Semikhatsky.

Source/WebCore:

English.lproj/localizedStrings.js:
dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameCallback):

inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didRequestAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):

inspector/front-end/TimelineAgent.js:
inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

inspector/timeline/timeline-animation-frame-expected.txt:
inspector/timeline/timeline-animation-frame.html:
inspector/timeline/timeline-enum-stability-expected.txt:
platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:

5:10 AM Changeset in webkit [108485] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Remove unused class declaration in WebCore/page/scrolling/ScrollingCoordinator.h
https://bugs.webkit.org/show_bug.cgi?id=79175

Patch by Changhun Kang <temoochin@company100.net> on 2012-02-22
Reviewed by Kentaro Hara.

page/scrolling/ScrollingCoordinator.h:

Remove PlatformGestureEvent class declaration.
(WebCore):

5:05 AM Changeset in webkit [108484] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r108456.
http://trac.webkit.org/changeset/108456
https://bugs.webkit.org/show_bug.cgi?id=79223

Broke fast/regex/pcre-test-4.html and cannot find anyone on
IRC (Requested by zherczeg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-22

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):

4:56 AM Changeset in webkit [108483] by abecsi@webkit.org

2 edits in trunk/Source/WebCore

[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Simon Hausmann.

Fixed the include order of the rolled out r108359 not to break
the build with CONFIG+=force_static_libs_as_shared.

platform/graphics/OpenGLShims.h: Add missing include.

4:51 AM Changeset in webkit [108482] by yutak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, regular maintenance of test expectations.

platform/chromium/test_expectations.txt:

4:47 AM WebKit Team edited by wingo@igalia.com

Remove duplicate entry for Enrica Casucci (diff)

4:20 AM Changeset in webkit [108481] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

platform/qt/Skipped:

4:06 AM Changeset in webkit [108480] by shinyak@chromium.org

9 edits in trunk

firstRendererOf() should also return a fallback element renderer in NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=79180

Reviewed by Hajime Morita.

Source/WebCore:

Currently we have handled AttachingFallback in some special mannger, however if firstRendererOf
and lastRendererOf return a fallback element renderer, we don't need to handle it in such a manner.

We have introduced new attaching phase: AttachingFallbacked, and AttachingNotFallbacked.
They are used for fallback elements.

Added new test cases in:

fast/dom/shadow/shadow-contents-fallback.html
fast/dom/shadow/shadow-contents-fallback-dynamic.html

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

dom/NodeRenderingContext.h:
html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore):
(WebCore::toInsertionPoint):

LayoutTests:

Added new test cases, e.g. <content> in <content>, with display:none.

fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt:
fast/dom/shadow/shadow-contents-fallback-dynamic.html:
fast/dom/shadow/shadow-contents-fallback-expected.txt:
fast/dom/shadow/shadow-contents-fallback.html:

3:46 AM Changeset in webkit [108479] by zeno.albisser@nokia.com

2 edits in trunk/Tools

[Qt][WK2][Mac] WebKitTestRunner does not build with clang.
https://bugs.webkit.org/show_bug.cgi?id=79124

WebKitTestRunnerPrefix.h should also be included
when building with clang.

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner/Target.pri:

3:38 AM Changeset in webkit [108478] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

[Qt] Unreviewed gardening after r108464.

Target.pri:

3:21 AM Changeset in webkit [108477] by haraken@chromium.org

1 edit
4 adds in trunk/PerformanceTests

Add performance tests for the Element.id getter and setter
https://bugs.webkit.org/show_bug.cgi?id=79209

Reviewed by Adam Barth.

This patch adds performance tests for the Element.id getter and setter.

The results of 10 runs in my local Chromium/Linux are as follows:

dom_attributes_id_getter.html:
median= 92.0 ms, stdev= 1.65151445649 ms, min= 89.0 ms, max= 96.0 ms
median= 87.5 ms, stdev= 1.84390889146 ms, min= 85.0 ms, max= 92.0 ms
median= 94.0 ms, stdev= 1.46543508898 ms, min= 90.0 ms, max= 95.0 ms
median= 86.0 ms, stdev= 1.66958078571 ms, min= 84.0 ms, max= 91.0 ms
median= 94.0 ms, stdev= 2.25610283454 ms, min= 103.0 ms, max= 98.0 ms
median= 86.0 ms, stdev= 1.49666295471 ms, min= 84.0 ms, max= 91.0 ms
median= 86.0 ms, stdev= 1.5321553446 ms, min= 84.0 ms, max= 90.0 ms
median= 86.0 ms, stdev= 2.20227155455 ms, min= 84.0 ms, max= 94.0 ms
median= 96.0 ms, stdev= 1.74570902501 ms, min= 101.0 ms, max= 99.0 ms
median= 86.0 ms, stdev= 1.63935963108 ms, min= 84.0 ms, max= 90.0 ms
median= 94.0 ms, stdev= 1.49248115566 ms, min= 90.0 ms, max= 95.0 ms
median= 88.0 ms, stdev= 5.20192272146 ms, min= 84.0 ms, max= 98.0 ms
median= 86.0 ms, stdev= 1.41067359797 ms, min= 84.0 ms, max= 89.0 ms
median= 86.0 ms, stdev= 1.48660687473 ms, min= 84.0 ms, max= 89.0 ms
median= 94.0 ms, stdev= 1.58113883008 ms, min= 93.0 ms, max= 97.0 ms
median= 86.0 ms, stdev= 1.95959179423 ms, min= 84.0 ms, max= 93.0 ms
median= 86.0 ms, stdev= 1.8547236991 ms, min= 84.0 ms, max= 92.0 ms
median= 86.0 ms, stdev= 1.39283882772 ms, min= 84.0 ms, max= 89.0 ms
median= 88.0 ms, stdev= 1.48660687473 ms, min= 85.0 ms, max= 90.0 ms
median= 86.5 ms, stdev= 2.3 ms, min= 84.0 ms, max= 93.0 ms

dom_attributes_id_setter.html:
median= 123.0 ms, stdev= 2.06397674406 ms, min= 119.0 ms, max= 128.0 ms
median= 119.0 ms, stdev= 1.92028643697 ms, min= 117.0 ms, max= 123.0 ms
median= 121.0 ms, stdev= 1.8781639971 ms, min= 118.0 ms, max= 123.0 ms
median= 123.0 ms, stdev= 2.21585198062 ms, min= 119.0 ms, max= 130.0 ms
median= 124.5 ms, stdev= 2.36378933071 ms, min= 119.0 ms, max= 129.0 ms
median= 122.0 ms, stdev= 2.4474476501 ms, min= 118.0 ms, max= 128.0 ms
median= 123.0 ms, stdev= 1.76351920885 ms, min= 118.0 ms, max= 125.0 ms
median= 119.0 ms, stdev= 1.79652442232 ms, min= 117.0 ms, max= 125.0 ms
median= 121.0 ms, stdev= 1.49916643506 ms, min= 119.0 ms, max= 123.0 ms
median= 119.5 ms, stdev= 1.85135085816 ms, min= 117.0 ms, max= 125.0 ms
median= 124.0 ms, stdev= 1.43090880213 ms, min= 120.0 ms, max= 124.0 ms
median= 122.0 ms, stdev= 1.45859521458 ms, min= 118.0 ms, max= 123.0 ms
median= 123.0 ms, stdev= 1.50332963784 ms, min= 120.0 ms, max= 124.0 ms
median= 123.0 ms, stdev= 1.3638181697 ms, min= 120.0 ms, max= 125.0 ms
median= 119.0 ms, stdev= 1.43527000944 ms, min= 117.0 ms, max= 121.0 ms
median= 122.5 ms, stdev= 1.71682847134 ms, min= 118.0 ms, max= 124.0 ms
median= 121.0 ms, stdev= 1.44481832768 ms, min= 118.0 ms, max= 123.0 ms
median= 120.0 ms, stdev= 1.40978721799 ms, min= 117.0 ms, max= 122.0 ms
median= 122.0 ms, stdev= 1.68522995464 ms, min= 119.0 ms, max= 125.0 ms
median= 122.0 ms, stdev= 1.55804364509 ms, min= 118.0 ms, max= 123.0 ms

Bindings/dom_attributes_id_getter.html: Added.
Bindings/dom_attributes_id_setter.html: Added.
Bindings/resources/dom_attributes_common.js: Added.

3:20 AM Changeset in webkit [108476] by bashi@chromium.org

15 edits
13 deletes in trunk

Unreviewed, rolling out r108468.
http://trac.webkit.org/changeset/108468
https://bugs.webkit.org/show_bug.cgi?id=79219

Broke Chromium Win release build (Requested by bashi on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-22

Source/JavaScriptCore:

wtf/Platform.h:

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):

websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):

websockets/WebSocketChannel.h:
websockets/WebSocketDeflateFramer.cpp: Removed.
websockets/WebSocketDeflateFramer.h: Removed.

LayoutTests:

http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed.
http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed.
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed.
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed.
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed.
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed.
http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed.
http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed.
http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(web_socket_transfer_data):

3:05 AM Changeset in webkit [108475] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening, unskip 2 tests that should pass now.

platform/gtk/Skipped:

2:45 AM Changeset in webkit [108474] by rolandsteiner@chromium.org

12 edits in trunk

Source/WebCore:

Added runtime-flag.
Query runtime flag when (un)registering a <style scoped> element, and when determineing a style sheet's scope.

Reviewed by Dimitri Glazkov.

No new tests. (no change in functionality)

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::determineScopingElement):

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

html/HTMLStyleElement.idl:

Source/WebKit/chromium:

Added a runtime-flag.
Enable default STYLE_SCOPED compile-time flag for Chromium.

Reviewed by Dimitri Glazkov.

features.gypi: enable STYLE_SCOPED
public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableStyleScoped):
(WebKit):
(WebKit::WebRuntimeFeatures::isStyleScopedEnabled):

Tools:

Enable the runtime-flag for DRT.

Reviewed by Dimitri Glazkov.

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

2:42 AM Changeset in webkit [108473] by apavlov@chromium.org

7 edits in trunk

Web Inspector: Audit rules to recommend unprefixing supported CSS properties
https://bugs.webkit.org/show_bug.cgi?id=78985

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/AuditCategories.js:

(WebInspector.AuditCategories.PagePerformance.prototype.initialize):

inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CSSRuleBase):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype.didVisitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.didVisitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
(WebInspector.AuditRules.VendorPrefixedCSSProperties):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitStyleSheet):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitRule):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitRule):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):

inspector/front-end/ResourceUtils.js:

LayoutTests:

inspector/audits/audits-panel-functional-expected.txt:
inspector/audits/audits-panel-functional.html:

2:20 AM Changeset in webkit [108472] by pfeldman@chromium.org

1 edit in branches/chromium/1025/Source/WebCore/inspector/InspectorInstrumentation.cpp

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

(Fixing merge 2)

Reviewed by Yury Semikhatsky.

inspector/Inspector.json:
inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429046

2:17 AM Changeset in webkit [108471] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] Add frame flattening setting to QWebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=79099

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-22
Reviewed by Simon Hausmann.

Frame flattening is enabled by default for Qt WebKit2.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::setNavigatorQtObjectEnabled):
(QWebPreferences::frameFlatteningEnabled):
(QWebPreferences::setFrameFlatteningEnabled):

UIProcess/API/qt/qwebpreferences_p.h:

2:12 AM Changeset in webkit [108470] by shinyak@chromium.org

2 edits in trunk/Source/WebCore

Node::attach() should be after attaching children in Element::attach().
https://bugs.webkit.org/show_bug.cgi?id=79201

Reviewed by Hajime Morita.

In Element::attach(), Node::attach() is called before attaching children if a shaodw root exists.
This may cause O(N^{2) problem in NodeRenderingContext.}

No new tests. Existing tests should cover this.

dom/Element.cpp:

(WebCore::Element::attach):

2:04 AM Changeset in webkit [108469] by pfeldman@chromium.org

1 edit in branches/chromium/1025/Source/WebCore/inspector/InspectorInstrumentation.cpp

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

inspector/Inspector.json:
inspector/InspectorDOMDebuggerAgent.cpp:

inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

inspector/InspectorInstrumentation.cpp:

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429045

2:03 AM Changeset in webkit [108468] by bashi@chromium.org

15 edits
1 copy
12 adds in trunk

Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522

Source/JavaScriptCore:

Added USE(ZLIB) flag.

Reviewed by Kent Tamura.

wtf/Platform.h:

Source/WebCore:

Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.

Reviewed by Kent Tamura.

Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html

http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html

CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect): Set m_extensions.

websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.

websockets/WebSocketChannel.h:
websockets/WebSocketDeflateFramer.cpp: Added.

(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):

websockets/WebSocketDeflateFramer.h: Added.

(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):

LayoutTests:

Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.

Reviewed by Kent Tamura.

http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(_retrieve_frame):
(web_socket_transfer_data):

2:00 AM Changeset in webkit [108467] by yutak@chromium.org

5 edits
3 deletes in trunk/Source

Unreviewed, rolling out r108453.
http://trac.webkit.org/changeset/108453
https://bugs.webkit.org/show_bug.cgi?id=78549

Broke Chromium's webkit_unit_tests.

Source/WebCore:

WebCore.gypi:
platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

tests/CCOcclusionTrackerTest.cpp: Removed.

1:56 AM Changeset in webkit [108466] by zherczeg@webkit.org

2 edits in trunk/Source/WebCore

[Qt] clipToImageBuffer assertion fix in debug mode on Qt.

Rubber stamped by Csaba Osztrogonác.

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::restorePlatformState):

1:45 AM Changeset in webkit [108465] by abarth@webkit.org

4 edits in trunk/Source/WebCore

[GTK] fast/frames/frame-dead-region.html crash
https://bugs.webkit.org/show_bug.cgi?id=79205

Unreviewed.

Apparently we're not supposed to call willDetachPage from
CachedFrame::destroy. This call got added in
http://trac.webkit.org/changeset/108428, but it seems to cause a crash.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

page/Frame.h:

(WebCore::Frame::detachFromPage):

page/Page.cpp:

(WebCore::Page::~Page):

1:40 AM Changeset in webkit [108464] by abarth@webkit.org

10 edits
16 moves in trunk/Source/WebCore

Move Geolocation code into Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=79204

Reviewed by Hajime Morita.

There are still some dangling references into the Geolocation module,
which I will clean up in a followup patch.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/geolocation/Geolocation.cpp: Copied from Source/WebCore/page/Geolocation.cpp.
Modules/geolocation/Geolocation.h: Copied from Source/WebCore/page/Geolocation.h.
Modules/geolocation/Geolocation.idl: Copied from Source/WebCore/page/Geolocation.idl.
Modules/geolocation/GeolocationController.cpp: Copied from Source/WebCore/page/GeolocationController.cpp.
Modules/geolocation/GeolocationController.h: Copied from Source/WebCore/page/GeolocationController.h.
Modules/geolocation/GeolocationError.h: Copied from Source/WebCore/page/GeolocationError.h.
Modules/geolocation/GeolocationPosition.h: Copied from Source/WebCore/page/GeolocationPosition.h.
Modules/geolocation/Geoposition.h: Copied from Source/WebCore/page/Geoposition.h.
Modules/geolocation/Geoposition.idl: Copied from Source/WebCore/page/Geoposition.idl.
Modules/geolocation/PositionCallback.h: Copied from Source/WebCore/page/PositionCallback.h.
Modules/geolocation/PositionCallback.idl: Copied from Source/WebCore/page/PositionCallback.idl.
Modules/geolocation/PositionError.h: Copied from Source/WebCore/page/PositionError.h.
Modules/geolocation/PositionError.idl: Copied from Source/WebCore/page/PositionError.idl.
Modules/geolocation/PositionErrorCallback.h: Copied from Source/WebCore/page/PositionErrorCallback.h.
Modules/geolocation/PositionErrorCallback.idl: Copied from Source/WebCore/page/PositionErrorCallback.idl.
Modules/geolocation/PositionOptions.h: Copied from Source/WebCore/page/PositionOptions.h.
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
page/Geolocation.cpp: Removed.
page/Geolocation.h: Removed.
page/Geolocation.idl: Removed.
page/GeolocationController.cpp: Removed.
page/GeolocationController.h: Removed.
page/GeolocationError.h: Removed.
page/GeolocationPosition.h: Removed.
page/Geoposition.h: Removed.
page/Geoposition.idl: Removed.
page/PositionCallback.h: Removed.
page/PositionCallback.idl: Removed.
page/PositionError.h: Removed.
page/PositionError.idl: Removed.
page/PositionErrorCallback.h: Removed.
page/PositionErrorCallback.idl: Removed.
page/PositionOptions.h: Removed.

1:28 AM Changeset in webkit [108463] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[gtk] Accessibility: use find funtion in vector instead of for.
https://bugs.webkit.org/show_bug.cgi?id=77878

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-22
Reviewed by Hajime Morita.

Minor cleanup, use the find function from vector.

accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetIndexInParent):

1:14 AM Changeset in webkit [108462] by rniwa@webkit.org

40 edits in trunk/Source

Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Reviewed by Enrica Casucci.

Source/WebCore:

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp:

editing/Editor.h:

(WebCore):
(Editor):

editing/EditorCommand.cpp:

loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldApplyStyle):

page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

page/EditorClient.h:

(WebCore):
(EditorClient):

Source/WebKit/blackberry:

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldApplyStyle):

WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldApplyStyle):

src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldApplyStyle):

WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

WebView/WebFrame.mm:

(-[WebFrame _setTypingStyle:withUndoAction:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):

WebView/WebView.mm:

(-[WebView applyStyle:]):

Source/WebKit/qt:

WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldApplyStyle):

WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):

WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldApplyStyle):

Source/WebKit/wx:

WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldApplyStyle):

WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

WebProcess/WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

1:04 AM Changeset in webkit [108461] by pfeldman@chromium.org

1 edit
1 copy in branches/chromium/1025/Source/WebCore/inspector

Merge 106352 - Web Inspector: boost protocol version to 1.0
https://bugs.webkit.org/show_bug.cgi?id=77408

Reviewed by Yury Semikhatsky.

inspector/Inspector-1.0.json: Copied from Source/WebCore/inspector/Inspector.json.
inspector/Inspector.json:

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9430040

1:03 AM Changeset in webkit [108460] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[GTK] fast/mediastream/peerconnection-argument-types.html fails
https://bugs.webkit.org/show_bug.cgi?id=79096

Patch by Yanbin Zhang <yanbin.zhang@intel.com> on 2012-02-22
Reviewed by Adam Barth.

fast/mediastream/peerconnection-argument-types-expected.txt:
fast/mediastream/script-tests/argument-types.js:

12:55 AM Changeset in webkit [108459] by Carlos Garcia Campos

9 edits in trunk

Unreviewed, rolling out r107351.
http://trac.webkit.org/changeset/107351
https://bugs.webkit.org/show_bug.cgi?id=53600

Several issues introduced in WebKitGTK+ API

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::chromeDestroyed):
(WebKit::ChromeClient::canRunModal):
(WebKit::ChromeClient::runModal):

WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Tools:

DumpRenderTree/gtk/DumpRenderTree.cpp:

(createWebView):

GtkLauncher/main.c:

(createWebViewCb):
(createBrowser):
(createWindow):
(main):

LayoutTests:

platform/gtk/Skipped:

12:54 AM Changeset in webkit [108458] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] Cull quads outside of the scissoring damage rect
https://bugs.webkit.org/show_bug.cgi?id=79181

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Quads outside of the partial swap cause us to execute GL operations
that actually use a fair amount of CPU time (enough to affect power
usage). Here we cull quads by only keeping their intersection
with the damage rect used for partial swap.

Unit test: CCQuadCuller.cpp

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::optimizeQuads):

platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

tests/CCQuadCullerTest.cpp:

(WebCore::TEST):
(WebCore):

12:49 AM Changeset in webkit [108457] by pfeldman@chromium.org

5 edits in branches/chromium/1025/Source/WebCore/inspector

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

inspector/Inspector.json:
inspector/InspectorDOMDebuggerAgent.cpp:

inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

inspector/InspectorInstrumentation.cpp:

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429043

12:43 AM Changeset in webkit [108456] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Short circuit fixed for a 16 bt pattern character and an 8 bit string.
https://bugs.webkit.org/show_bug.cgi?id=75602

Patch by Hojong Han <hojong.han@samsung.com> on 2012-02-22
Reviewed by Gavin Barraclough.

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):

12:37 AM Changeset in webkit [108455] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/Skipped:
platform/gtk/fast/forms/float-before-fieldset-expected.txt:

12:30 AM Changeset in webkit [108454] by jonlee@apple.com

3 edits in trunk/Source/WebKit/mac

Part of r108409 was incorrect, and incorporated an older version of a sub-patch.
This is the actual sub-patch that should have been submitted.

WebCoreSupport/WebNotificationClient.h:
WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):

12:27 AM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com

(diff)

12:26 AM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com

(diff)

12:25 AM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com

(diff)

12:24 AM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com

(diff)

12:20 AM EFLWebKit edited by gyuyoung.kim@samsung.com

Add dependent package (diff)

Feb 21, 2012:

11:59 PM Changeset in webkit [108453] by commit-queue@webkit.org

5 edits
3 adds in trunk/Source

[Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by James Robinson.

Source/WebCore:

Adds a CCOcclusionTrackerBase template class that is able to track occlusion
of layers while traversing the layer tree from front-to-back, with typedefed
versions for the main and impl threads.

At each step of the front-to-back traversal, the class should be notified of
changes to the current render target, and when done working with a layer, the
layer is added the tracked occlusion.

The class provides tests for checking if a rect in content space
for a layer/surface is occluded by others in front of it.

Unit tests: CCOcclusionTrackerTest.cpp

WebCore.gypi:
platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.

platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.

(WebCore):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
(StackObject):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

tests/CCOcclusionTrackerTest.cpp: Added.

11:37 PM Changeset in webkit [108452] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Null ResourceErrors are encoded/decoded as empty ResourceErrors
https://bugs.webkit.org/show_bug.cgi?id=79120

Reviewed by Martin Robinson.

Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::::encode): Encode a boolean to indicate whether it's a
Null error.
(CoreIPC::::decode): Check whether the error is Null and do not
continue decoding in such case.

11:33 PM Changeset in webkit [108451] by kling@webkit.org

6 edits in trunk/Source/WebCore

Cache <font face> family lists in CSSValuePool.
<http://webkit.org/b/79195>

Reviewed by Antti Koivisto.

HTMLFontElements with "face" attributes are very common in legacy web content.
Add a String->CSSValue cache for these in CSSValuePool and use it to avoid
reparsing and recreating duplicate font face values.

This knocks 20ms (~1.5%) worth of samples off of the Moz page cycler on my system.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

css/CSSParser.h:
css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

css/CSSValuePool.h:
html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

11:28 PM Changeset in webkit [108450] by abarth@webkit.org

10 edits
3 adds in trunk/Source/WebCore

Separate the implementation of registerProtocolHandler from Navigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=78945

Reviewed by Eric Seidel.

The implementation of registerProtocolHandler needlessly complicates
the implementation of Navigator.cpp. In principle,
registerProtocolHandler (and possibly registerContentHandler, when we
implement that feature) could be its own module, but that seems like
overkill for one or two files.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
page/Navigator.cpp:

(WebCore):

page/Navigator.h:

(Navigator):

page/Navigator.idl:

11:20 PM Changeset in webkit [108449] by morrita@google.com

6 edits in trunk/Source/WebCore

HasIDFlag and HasClassFlag can be removed.
https://bugs.webkit.org/show_bug.cgi?id=77861

Reviewed by Andreas Kling.

Replaced HasIDFlag and HasClassFlag with a check against
ElementAttributeData. It looks these flags (originally bitfields)
were legacy of ancient era, where we didn't cache @id and @class
values and needed a hash lookup for each check.

No new tests. No behavioral change.

dom/Element.cpp:

(WebCore::Element::idAttributeChanged):

dom/Element.h:

(WebCore::Element::hasID):
(WebCore):
(WebCore::Element::hasClass):
(WebCore::Node::hasID):
(WebCore::Node::hasClass):

dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::hasID):
(WebCore::ElementAttributeData::hasClass):
(ElementAttributeData):

dom/Node.h:

(Node):
(WebCore::nodeStyleChangeShift):

dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

11:15 PM Changeset in webkit [108448] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix for systems with case sensitive disks.

llint/LLIntOfflineAsmConfig.h:

10:29 PM Changeset in webkit [108447] by mdelaney@apple.com

2 edits in trunk/Source/WebCore

2D Canvas setTransform makes unnecessary matrix mults
https://bugs.webkit.org/show_bug.cgi?id=79190

Reviewed by Dan Bernstein.

No new tests - plenty of current tests using setTransform.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setTransform):

9:46 PM Changeset in webkit [108446] by morrita@google.com

9 edits in trunk/Source

INPUT_SPEECH should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79051

Source/WebCore:

Turned SpeechInput to a PageSupplement.

Reviewed by Adam Barth.

No new tests. No behavior change.

html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::speechInput):
(WebCore::InputFieldSpeechButtonElement::attach):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

page/Page.h:

(WebCore):
(PageClients):
(Page):

page/SpeechInput.cpp:

(WebCore::SpeechInput::supplementName):
(WebCore):
(WebCore::provideSpeechInputTo):

page/SpeechInput.h:

(SpeechInput):
(WebCore::SpeechInput::from):

page/SpeechInputClient.h:

(WebCore):

Source/WebKit/chromium:

Reviewed by Adam Barth.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

9:29 PM Changeset in webkit [108445] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Add three small zoom gesture features
https://bugs.webkit.org/show_bug.cgi?id=74216

Patch by Alexandre Elias <aelias@google.com> on 2012-02-21
Reviewed by James Robinson.

Support panning around with two fingers.
When double-tap zooming, issue the commit at final/scroll scale as

early as possible.

When pinch zooming out, issue a commit at minimum scale to avoid

showing checkerboard.

Added test for panning to CCLayerTreeHostImplTest::pinchGesture.
(The other features are heuristics whose exact behavior we don't need
to lock in with a test.)

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computeDoubleTapZoomDeltas):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

9:23 PM Changeset in webkit [108444] by fpizlo@apple.com

79 edits
38 adds in trunk

JSC should be a triple-tier VM
https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
assembler/LinkBuffer.h:
assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

bytecode/BytecodeConventions.h: Added.
bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

bytecode/Opcode.cpp:

(JSC):

bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

bytecode/PutByIdStatus.h:

(PutByIdStatus):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOperations.cpp:
heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

heap/MarkStack.cpp:

(JSC::visitChildren):

heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

jit/ExecutableAllocator.h:

(JSC):

jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

jit/JITExceptions.cpp:

(JSC::jitThrow):

jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

jit/JITStubs.h:

(JSC):

jit/JSInterfaceJIT.h:
llint: Added.
llint/LLIntCommon.h: Added.
llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

llint/LLIntOfflineAsmConfig.h: Added.
llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

llint/LowLevelInterpreter.asm: Added.
llint/LowLevelInterpreter.cpp: Added.
llint/LowLevelInterpreter.h: Added.
offlineasm: Added.
offlineasm/armv7.rb: Added.
offlineasm/asm.rb: Added.
offlineasm/ast.rb: Added.
offlineasm/backends.rb: Added.
offlineasm/generate_offset_extractor.rb: Added.
offlineasm/instructions.rb: Added.
offlineasm/offset_extractor_constants.rb: Added.
offlineasm/offsets.rb: Added.
offlineasm/opt.rb: Added.
offlineasm/parser.rb: Added.
offlineasm/registers.rb: Added.
offlineasm/self_hash.rb: Added.
offlineasm/settings.rb: Added.
offlineasm/transform.rb: Added.
offlineasm/x86.rb: Added.
runtime/CodeSpecializationKind.h: Added.

(JSC):

runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

runtime/JSArray.h:

(JSC):
(JSArray):

runtime/JSCell.h:

(JSC):
(JSCell):

runtime/JSFunction.h:

(JSC):
(JSFunction):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

runtime/JSString.h:

(JSC):
(JSString):

runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

runtime/JSValue.cpp:

(JSC::JSValue::description):

runtime/JSValue.h:

(LLInt):
(JSValue):

runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

runtime/Options.h:

(Options):

runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

runtime/Structure.h:

(JSC):
(Structure):

runtime/StructureChain.h:

(JSC):
(StructureChain):

wtf/InlineASM.h:
wtf/Platform.h:
wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

DumpRenderTree/efl/CMakeLists.txt:

9:13 PM Changeset in webkit [108443] by haraken@chromium.org

2 edits in trunk/Source/WebCore

NavigatorMediaStream.idl defines an interface for NavigatorGamepad
https://bugs.webkit.org/show_bug.cgi?id=79152

Reviewed by Adam Barth.

Fixed a typo: NavigatorGamepad => NavigatorMediaStream

This typo fix just changes the name of generated files:

V8NavigatorGamepad.h => V8NavigatorMediaStream.h
V8NavigatorGamepad.cpp => V8NavigatorMediaStream.cpp

The reason why the typo has not caused any serious build issues is that
the generate files for supplemental interfaces are "empty" and not important.
They just exist to control makefile dependencies.

No tests. No change in behavior.

mediastream/NavigatorMediaStream.idl:

9:12 PM Changeset in webkit [108442] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Fix compositor setting color uniforms incorrectly for solid color quads.
https://bugs.webkit.org/show_bug.cgi?id=76017

Patch by Daniel Sievers <sievers@chromium.org> on 2012-02-21
Reviewed by James Robinson.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawSolidColorQuad):

8:42 PM Changeset in webkit [108441] by commit-queue@webkit.org

4 edits
3 adds in trunk

getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-21
Reviewed by Eric Seidel.

Source/WebCore:

SVGSVGElement::currentViewportSize was returning the size of the SVG viewport plus CSS
borders and paddings, causing the CTM calculation to be off.

Test: svg/dom/SVGLocatable-getCTM-svg-root.html

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):

SVGSVGElement::currentViewportSize now uses the contentBoxRect instead of the frameRect.
The contentBoxRect corresponds to the SVG viewport and does not include borders and
paddings.

LayoutTests:

platform/chromium/test_expectations.txt
platform/mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png
svg/dom/SVGLocatable-getCTM-svg-root-expected.txt: Added.
svg/dom/SVGLocatable-getCTM-svg-root.html: Added.

8:34 PM Changeset in webkit [108440] by commit-queue@webkit.org

1 edit
1 add in trunk/Source/WebCore

[BlackBerry] Upstream Icon class in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79088

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-21
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

platform/graphics/blackberry/IconBlackBerry.cpp: Added.

(WebCore):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):
(WebCore::Icon::createIconForFiles):

8:26 PM Changeset in webkit [108439] by bashi@chromium.org

6 edits in trunk

Rename "reserved1" flag of WebSocketFrame to compress
https://bugs.webkit.org/show_bug.cgi?id=79187

Source/WebCore:

WebSocket deflate-frame extension draft specification defines COMP bit.
http://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-05#page-11

Reviewed by Kent Tamura.

No new tests. http/tests/websocket/tests/hybi/reserved-bits.html is revised to follow the change.

websockets/WebSocketChannel.cpp:

(WebCore):
(WebCore::WebSocketChannel::parseFrame): "reserved1" renamed "compress".
(WebCore::WebSocketChannel::processFrame): Removed reserved1 flag check.
(WebCore::makeFrameData):
(WebCore::WebSocketChannel::sendFrame):

websockets/WebSocketFrame.h: "reserved1" flag renamed "compress".

(WebCore::WebSocketFrame::WebSocketFrame):
(WebSocketFrame):

LayoutTests:

Reviewed by Kent Tamura.

http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Revised to follow the change in meaning rsv1 bit.
http/tests/websocket/tests/hybi/reserved-bits.html: Ditto.

8:02 PM Changeset in webkit [108438] by yael.aharon@nokia.com

5 edits
4 moves in trunk/Source/WebCore

[Texmap] Move all TextureMapper related files to graphics/texmap
https://bugs.webkit.org/show_bug.cgi?id=79141

Reviewed by Martin Robinson.

Move TextureMaooerGL and TextureMapperShaderManager files to graphics/texmap.
No new tests.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
platform/graphics/qt/GraphicsContext3DQt.cpp
platform/graphics/opengl/TextureMapperGL.cpp: Removed.
platform/graphics/opengl/TextureMapperGL.h: Removed.
platform/graphics/opengl/TextureMapperShaderManager.cpp: Removed.
platform/graphics/opengl/TextureMapperShaderManager.h: Removed.
platform/graphics/texmap/TextureMapperGL.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp.
platform/graphics/texmap/TextureMapperGL.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.h.
platform/graphics/texmap/TextureMapperShaderManager.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.cpp.
platform/graphics/texmap/TextureMapperShaderManager.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.h.

7:56 PM Changeset in webkit [108437] by morrita@google.com

11 edits
2 adds in trunk/Source

MEDIA_STREAM should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79050

Reviewed by Adam Barth.

Source/WebCore:

Added UserMediaController which implements PageSupplement. This
controller mediates WebCore-to-client communication and lifecycle
management. Then pushed UserMediaController out as a
PageSupplement module.

No new tests. No behavior change.

WebCore.gypi:
GNUmakefile.list.am:
mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

mediastream/UserMediaClient.h:

(WebCore):

mediastream/UserMediaController.cpp: Added.

(WebCore):
(WebCore::UserMediaController::supplementName):
(WebCore::UserMediaController::UserMediaController):
(WebCore::UserMediaController::~UserMediaController):
(WebCore::UserMediaController::create):
(WebCore::provideUserMediaTo):

mediastream/UserMediaController.h: Added.

(WebCore):
(UserMediaController):
(WebCore::UserMediaController::client):
(WebCore::UserMediaController::from):
(WebCore::UserMediaController::requestUserMedia):
(WebCore::UserMediaController::cancelUserMediaRequest):

mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::didCompleteQuery):
(WebCore::UserMediaRequest::contextDestroyed):

mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::PageClients::PageClients):

page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

7:35 PM Changeset in webkit [108436] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Node::isContentEditable should only update styles, not layout
https://bugs.webkit.org/show_bug.cgi?id=78637

Patch by James Robinson <jamesr@chromium.org> on 2012-02-21
Reviewed by Ryosuke Niwa.

isContentEditable depends on knowing the node's current computed style, so it has to update styles if they are
out of date. It does not depend on knowing any layout-derived properties, however, so updating layout is just a
waste of time.

Behavior is covered by existing layout tests, primarily in editing/

dom/Node.cpp:

(WebCore::Node::isContentEditable):
(WebCore::Node::isContentRichlyEditable):

7:16 PM Changeset in webkit [108435] by jamesr@google.com

2 edits in trunk/Source/WebCore

Partially revert r108418 - move allowEventDispatch() call back to where it used to be.

Rubber-stamped by Ryosuke Niwa.

Tested by fast/text/find-layout-crash.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

7:11 PM Changeset in webkit [108434] by andersca@apple.com

2 edits in trunk/Source/WebCore

Background jitters on pages with background-attachment: fixed
https://bugs.webkit.org/show_bug.cgi?id=79182

Reviewed by Dan Bernstein.

Make sure to update the main frame scroll position before updating the scrolling layer.
This also fixes a (purely theoretical) bug where we wouldn't be updating the main frame
position if the main frame didn't have a scroll layer.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

6:58 PM Changeset in webkit [108433] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Early-out in Region::unite() for adding an empty region.
https://bugs.webkit.org/show_bug.cgi?id=79174

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by Anders Carlsson.

platform/graphics/Region.cpp:

(WebCore::Region::unite):

6:46 PM Changeset in webkit [108432] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Unbreak double-typed arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=79177

Reviewed by Gavin Barraclough.

The existing code had completely broken address arithmetic.

JSCTypedArrayStubs.h:

(JSC):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):

6:45 PM Changeset in webkit [108431] by commit-queue@webkit.org

4 edits in trunk/Source

[chromium] Painting a layer clears opaque rect in untouched tiles
https://bugs.webkit.org/show_bug.cgi?id=79157

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by James Robinson.

Source/WebCore:

When painting a tiled layer, we would throw away the saved opaque rect
for any tiles that were not part of the paint. So now we check
if we are able to save the existing saved opaque rect in a more
proper way:

If any pixels of the saved rect are painted non-opaque, we replace

the saved rect.

If an opaque rect is drawn outside of the saved rect, we replace

the saved rect.

Unit test: TiledLayerChromiumTest.cpp

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):

Source/WebKit/chromium:

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

6:42 PM Changeset in webkit [108430] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Small typo in AudioPannerNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=75890

Change to check elevation as intended instead of azimuth.

Patch by Raymond Toy <Raymond Toy> on 2012-02-21
Reviewed by Chris Rogers.

No new tests for correction of typo.

webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::getAzimuthElevation):

6:35 PM Changeset in webkit [108429] by jonlee@apple.com

3 edits in trunk/Source/WebKit/mac

Build fix. Push ENABLE_NOTIFICATIONS into .mm file.

WebCoreSupport/WebNotificationClient.h:
WebView/WebNotification.h:
WebView/WebNotification.mm:

(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

6:23 PM WikiStart edited by haraken@chromium.org

(diff)

6:22 PM Changeset in webkit [108428] by abarth@webkit.org

40 edits
4 adds in trunk/Source

Frame and Navigator shouldn't need to worry about Geolocation
https://bugs.webkit.org/show_bug.cgi?id=78860

Reviewed by Eric Seidel.

This patch removes some Geolocation-specific code from Frame and
Navigator in favor of our new supplemental module mechanism. We're
still refining the module system, but we seem to be converging on a
simple Observer/Supplement design.

In a future patch, I'll move the remaining Geolocation-related files in
WebCore into Modules/geolocation. This patch appears to be the first
patch that introduces a module used by all the various build systems,
which is why there's a bit more build system overhead than usual.

Modules/geolocation: Added.
Modules/geolocation/NavigatorGeolocation.cpp: Added.

(WebCore):
(WebCore::NavigatorGeolocation::NavigatorGeolocation):
(WebCore::NavigatorGeolocation::~NavigatorGeolocation):
(WebCore::NavigatorGeolocation::pageDestroyed):
(WebCore::NavigatorGeolocation::from):
(WebCore::NavigatorGeolocation::geolocation):

Modules/geolocation/NavigatorGeolocation.h: Added.

(WebCore):
(NavigatorGeolocation):

Modules/geolocation/NavigatorGeolocation.idl: Added.
- I've temporarily disabled this API for GObject because it generates a strange compile error. Once I land this patch, I'll spend some more time fixing the compile error.
page/DOMWindow.cpp:

(WebCore):

page/DOMWindow.h:

(DOMWindow):

page/Frame.cpp:

(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):

page/FrameDestructionObserver.cpp:

(WebCore::FrameDestructionObserver::pageDestroyed):
(WebCore):

page/FrameDestructionObserver.h:

(FrameDestructionObserver):

page/Navigator.cpp:

(WebCore):

page/Navigator.h:

(WebCore):
(Navigator):

page/Navigator.idl:

6:20 PM WebKitIDL edited by haraken@chromium.org

(diff)

6:20 PM WebKitIDL edited by haraken@chromium.org

(diff)

5:51 PM Changeset in webkit [108427] by barraclough@apple.com

7 edits in trunk

Should be able to reconfigure a non-configurable property as read-only
https://bugs.webkit.org/show_bug.cgi?id=79170

Reviewed by Sam Weinig.

See ES5.1 8.12.9 10.a.i - the spec prohibits making a read-only property writable,
but does not inhibit making a writable property read-only.

Source/JavaScriptCore:

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::setInDefineOwnProperty):
(JSGlobalData):
(JSC::JSGlobalData::isInDefineOwnProperty):

Added flag, tracking whether we are in JSObject::defineOwnProperty.

runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):
(DefineOwnPropertyScope):

Always allow properties to be deleted by DefineOwnProperty - assume it knows what it is doing!

(JSC::DefineOwnPropertyScope::DefineOwnPropertyScope):
(JSC::DefineOwnPropertyScope::~DefineOwnPropertyScope):

Added RAII helper.

(JSC::JSObject::defineOwnProperty):

Track on the globalData when we are in this method.

LayoutTests:

fast/js/Object-defineProperty-expected.txt:
fast/js/script-tests/Object-defineProperty.js:
- Update test result (this was enforcing incorrect behaviour).

5:49 PM Changeset in webkit [108426] by shawnsingh@chromium.org

4 edits in trunk/Source/WebCore

[chromium] Refactor CCLayerTreeHostCommon: merge scattered setTargetRenderSurface logic
https://bugs.webkit.org/show_bug.cgi?id=78936

Reviewed by James Robinson.

No change in behavior, the code moved around already covered by existing tests.

In calculateDrawTransformsAndVisibility(), there are two separate
if-else statements where setTargetRenderSurface logic is
performed, and this makes the code less readable and more error
prone. This patch merges the logic, removing the redundant if-else
statements.

This code also merges one other set of if-statements that are
equivalent, if (layer->parent()) and if (layer!=rootLayer).

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::createRenderSurface):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createRenderSurface):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

5:36 PM Changeset in webkit [108425] by sullivan@apple.com

2 edits in trunk/Source/WebKit/mac

Build fix.

WebView/WebUIDelegatePrivate.h:

Added @class declarations for DOMNode and DOMElement.

5:24 PM WebKitIDL edited by haraken@chromium.org

(diff)

5:23 PM Changeset in webkit [108424] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Remove FIXME from resolve-supplemental.pl
https://bugs.webkit.org/show_bug.cgi?id=79160

Reviewed by Adam Barth.

The IDL attribute checker has been enabled in all build systems.
This patch removes FIXME in resolve-supplemental.pl.
Also, this patch improves a comment in IDLAttributes.txt.

No tests. No change in behavior.

bindings/scripts/IDLAttributes.txt:
bindings/scripts/resolve-supplemental.pl:

5:19 PM Changeset in webkit [108423] by eae@chromium.org

8 edits
2 adds in trunk/Source/WebCore

Add FractionalLayoutRect for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78924

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Rect class. Uses FractionalLayoutPoint
and FractionalLayoutSize internally.

Also add conversions to int/float versions of same.

No new tests.

GNUmakefile.list.am:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::FloatRect):
(WebCore):

platform/graphics/FloatRect.h:

(WebCore):
(FloatRect):

platform/graphics/FractionalLayoutRect.cpp: Added.

(WebCore):
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::intersects):
(WebCore::FractionalLayoutRect::contains):
(WebCore::FractionalLayoutRect::intersect):
(WebCore::FractionalLayoutRect::unite):
(WebCore::FractionalLayoutRect::uniteIfNonZero):
(WebCore::FractionalLayoutRect::scale):
(WebCore::unionRect):
(WebCore::enclosingIntRect):
(WebCore::enclosingFractionalLayoutRect):
(WebCore::pixelSnappedIntRect):

platform/graphics/FractionalLayoutRect.h: Added.

(WebCore):
(FractionalLayoutRect):
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::location):
(WebCore::FractionalLayoutRect::size):
(WebCore::FractionalLayoutRect::setLocation):
(WebCore::FractionalLayoutRect::setSize):
(WebCore::FractionalLayoutRect::x):
(WebCore::FractionalLayoutRect::y):
(WebCore::FractionalLayoutRect::maxX):
(WebCore::FractionalLayoutRect::maxY):
(WebCore::FractionalLayoutRect::width):
(WebCore::FractionalLayoutRect::height):
(WebCore::FractionalLayoutRect::setX):
(WebCore::FractionalLayoutRect::setY):
(WebCore::FractionalLayoutRect::setWidth):
(WebCore::FractionalLayoutRect::setHeight):
(WebCore::FractionalLayoutRect::isEmpty):
(WebCore::FractionalLayoutRect::center):
(WebCore::FractionalLayoutRect::move):
(WebCore::FractionalLayoutRect::moveBy):
(WebCore::FractionalLayoutRect::expand):
(WebCore::FractionalLayoutRect::contract):
(WebCore::FractionalLayoutRect::shiftXEdgeTo):
(WebCore::FractionalLayoutRect::shiftMaxXEdgeTo):
(WebCore::FractionalLayoutRect::shiftYEdgeTo):
(WebCore::FractionalLayoutRect::shiftMaxYEdgeTo):
(WebCore::FractionalLayoutRect::minXMinYCorner):
(WebCore::FractionalLayoutRect::maxXMinYCorner):
(WebCore::FractionalLayoutRect::minXMaxYCorner):
(WebCore::FractionalLayoutRect::maxXMaxYCorner):
(WebCore::FractionalLayoutRect::contains):
(WebCore::FractionalLayoutRect::inflateX):
(WebCore::FractionalLayoutRect::inflateY):
(WebCore::FractionalLayoutRect::inflate):
(WebCore::FractionalLayoutRect::transposedRect):
(WebCore::FractionalLayoutRect::infiniteRect):
(WebCore::intersection):
(WebCore::unionRect):
(WebCore::operator==):
(WebCore::operator!=):

platform/graphics/IntRect.cpp:

(WebCore::IntRect::IntRect):
(WebCore):

platform/graphics/IntRect.h:

(WebCore):
(IntRect):

5:11 PM WebKitIDL edited by haraken@chromium.org

(diff)

5:04 PM Changeset in webkit [108422] by jamesr@google.com

7 edits in trunk/Source

Enable ScrollingCoordinator in chromium whenever compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=79165

Reviewed by Adam Barth.

Source/WebCore:

As the title says.

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Remove ASSERT_NOT_REACHED()ed from these functions, they are now expected to be called but do nothing.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Guard a mac-specific piece of code in #if PLATFORM(MAC). This code already has a FIXME.

rendering/RenderLayerCompositor.cpp:

(WebCore::shouldCompositeOverflowControls):

Make coordinatesScroll..() sufficient but not necessary for compositing overflow controls. In chromium, we
want to composite overflow controls even for FrameViews that we aren't coordinating via the
ScrollingCoordinator.

Source/WebKit/chromium:

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

Whenever the ScrollingCoordinator is enabled the scroll layer's position is expected to be updated
externally to RenderLayerCompositor, so set it here.

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingEnabled):

5:01 PM Changeset in webkit [108421] by jonlee@apple.com

5 edits in trunk/Source/WebKit/mac

Build fix for r108409.

WebCoreSupport/WebNotificationClient.h:

(WebCore):

WebCoreSupport/WebNotificationClient.mm:
WebView/WebNotification.h:

(WebSecurityOrigin):

WebView/WebNotification.mm:

(core):
(-[WebNotification initWithCoreNotification:notificationID:]):

4:55 PM WebKitIDL edited by haraken@chromium.org

(diff)

4:49 PM Changeset in webkit [108420] by oliver@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

Make TypedArrays be available in commandline jsc
https://bugs.webkit.org/show_bug.cgi?id=79163

Reviewed by Gavin Barraclough.

Adds a compile time option to have jsc support a basic implementation
of the TypedArrays available in WebCore. This lets us test the typed
array logic in the JIT witout having to build webcore.

JSCTypedArrayStubs.h: Added.

(JSC):

JavaScriptCore.xcodeproj/project.pbxproj:
jsc.cpp:

(GlobalObject::finishCreation):
(GlobalObject):
(GlobalObject::addConstructableFunction):

runtime/JSGlobalData.h:

(JSGlobalData):

4:47 PM Changeset in webkit [108419] by dcheng@chromium.org

5 edits in trunk

[chromium] Fix image drag out on Chromium
https://bugs.webkit.org/show_bug.cgi?id=79158

Reviewed by Tony Chang.

Source/WebKit/chromium:

We constructed the WebDragData::Item for dragging out an image but never added it to the
item list. This is normally covered by the fast/events/drag-image-filename.html layout test,
but the bug wasn't caught in the original patch since the implementations in Chrome and DRT
had diverged.

src/WebDragData.cpp:

(WebKit::WebDragData::items):

Tools:

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::dumpFilenameBeingDragged):
(EventSender::beginDragWithFiles):

DumpRenderTree/chromium/WebViewHost.cpp:

(addDRTFakeFileToDataObject):

4:46 PM Changeset in webkit [108418] by adamk@chromium.org

3 edits
6 adds in trunk

Setting innerText causes DOMSubtreeModified to be dispatched too early
https://bugs.webkit.org/show_bug.cgi?id=79140

Reviewed by Ryosuke Niwa.

Source/WebCore:

Followup to r108152: move children change notifications later in
ContainerNode::removeChildren(), thus making sure Node::inDocument()
is in the correct state when we call into script.

Tests: fast/dom/getElementById-consistency3.html

fast/dom/getElementById-consistency4.html
fast/dom/getElementById-consistency5.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

LayoutTests:

fast/dom/getElementById-consistency3-expected.txt: Added.
fast/dom/getElementById-consistency3.html: Added.
fast/dom/getElementById-consistency4-expected.txt: Added.
fast/dom/getElementById-consistency4.html: Added.
fast/dom/getElementById-consistency5-expected.txt: Added.
fast/dom/getElementById-consistency5.html: Added.

4:42 PM Changeset in webkit [108417] by rniwa@webkit.org

3 edits
2 adds in trunk

Assertion failure in TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=78530

Source/WebCore:

Reviewed by Eric Seidel.

The assertion failure was caused by handleTextNodeFirstLetter's updating m_text without clearing
m_sortedTextBoxesPosition. Re-structured handleTextNode so that we always reset m_sortedTextBoxesPosition
when we have a first-letter.

Test: editing/text-iterator/rtl-first-letter-text-iterator-crash.html

editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::TextIterator::handleTextNodeFirstLetter):

LayoutTests:

Reviewed by Enrica Casucci.

Add a regression test. Also rebaseline a crash test.

editing/text-iterator/rtl-first-letter-text-iterator-crash-expected.txt: Added.
editing/text-iterator/rtl-first-letter-text-iterator-crash.html: Added.
editing/text-iterator/rtl-selection-crash-expected.txt:

4:38 PM Changeset in webkit [108416] by yael.aharon@nokia.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

No new tests.

platform/graphics/opengl/TextureMapperGL.cpp:

4:34 PM Changeset in webkit [108415] by adamk@chromium.org

3 edits
2 adds in trunk

ContainerNode::childrenChanged must be called immediately after removing children
https://bugs.webkit.org/show_bug.cgi?id=79162

Reviewed by Ryosuke Niwa.

Source/WebCore:

In r108152, a call to childrenChanged() was erroneously moved
below the call to child->removedFromDocument(). This breaks, at the
least, the behavior of the <title> element. This patch corrects the
mistake and adds a test.

Test: fast/dom/title-directionality-removeChild.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

LayoutTests:

fast/dom/title-directionality-removeChild-expected.txt: Added.
fast/dom/title-directionality-removeChild.html: Added.

4:32 PM Changeset in webkit [108414] by dpranke@chromium.org

4 edits in trunk/Tools

webkitpy: speed up hot filesystem_mock functions
https://bugs.webkit.org/show_bug.cgi?id=79159

Reviewed by Adam Barth.

Profiling run_webkit_tests_integrationtest.py revealed that
isdir(), normpath(), and join() are called a lot and were very
slow.This patch speeds them up substantially, shaving 20 seconds
off of the execution time.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.isdir):
(MockFileSystem._slow_but_correct_join):
(MockFileSystem.join):
(MockFileSystem.listdir):
(MockFileSystem._slow_but_correct_normpath):
(MockFileSystem.normpath):
(MockFileSystem.write_binary_file):

Scripts/webkitpy/common/system/filesystem_mock_unittest.py:

(MockFileSystemTest.quick_check):
(MockFileSystemTest):
(MockFileSystemTest.test_join):
(MockFileSystemTest.test_normpath):

Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config): Call write_binary_file() instead of updating

filesystem.files directly, so that we create directories as
needed.

4:29 PM Changeset in webkit [108413] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt: make the delay between starting workers configurable per-port
https://bugs.webkit.org/show_bug.cgi?id=79148

Reviewed by Eric Seidel.

Because of bug 79147, we have to sleep a bit in between starting
DRTs; however, doing so across the board slows down the Test
port. Making this configurable shaves 10 seconds off of
run_webkit_tests_integrationtest.py

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

Scripts/webkitpy/layout_tests/port/base.py:

(Port.worker_startup_delay_secs):

Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.worker_startup_delay_secs):

4:19 PM Changeset in webkit [108412] by tsepez@chromium.org

4 edits in trunk

equalIgnoringNullity() only comparing half the bytes for equality
https://bugs.webkit.org/show_bug.cgi?id=79135

Reviewed by Adam Barth.

Source/JavaScriptCore:

wtf/text/StringImpl.h:

(WTF::equalIgnoringNullity):

LayoutTests:

http/tests/security/xssAuditor/script-tag.html:

4:16 PM WebKitIDL edited by haraken@chromium.org

(diff)

4:12 PM Changeset in webkit [108411] by jamesr@google.com

2 edits in trunk/LayoutTests

[chromium] Update chromium expectations for accessibility/aria-invalid.html

platform/chromium/test_expectations.txt:

4:03 PM Changeset in webkit [108410] by macpherson@chromium.org

4 edits in trunk/Source/WebCore

Implement many instances of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79067

Reviewed by Andreas Kling.

No new tests / refactoring only.

css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

rendering/style/RenderStyle.h:

4:00 PM Changeset in webkit [108409] by jonlee@apple.com

20 edits
2 copies
1 add in trunk

Source/WebCore: Bring notifications support to WK1 mac
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

WebCore.exp.in: Expose dispatchErrorEvent on Notification.

Source/WebKit: Bring notifications support to WK1 mac: showing, canceling, removing notifications
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

WebKit.xcodeproj/project.pbxproj: Added new files.

Source/WebKit/mac: Bring notifications support to WK1 mac: permission requests
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

WebCoreSupport/WebNotificationClient.h:
WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the

WebAllowDenyPolicyListener protocol, similar to geolocation.
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):
(-[WebNotificationPolicyListener initWithCallback:]):
(-[WebNotificationPolicyListener allow]): Call the callback.
(-[WebNotificationPolicyListener deny]): Call the callback.

WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a

policy for navigations.

====
Bring notifications support to WK1 mac: showing, canceling, removing notifications

Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned
ID.

WebView/WebNotification.h: Added.

(WebSecurityOrigin):

WebView/WebNotification.mm: Added.

(core):
(-[WebNotification initWithCoreNotification:notificationID:]):
(-[WebNotification init]):
(-[WebNotification dealloc]):
(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

WebView/WebNotificationInternal.h: Added.

(WebCore): Internal category to allow creating instances with WebCore objects.

Extend WebView to include a WebNotificationProvider, which clients implement.

WebView/WebViewData.h: Add a private member for the provider.
WebView/WebViewPrivate.h:
- Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission that client which implement the provider can use to return policy decisions.
- Define WebNotificationProvider.
- Category WebViewNotification extends WebView with methods that set and manager the notification provider, and handle events from the platform notifications.
WebView/WebView.mm:

(-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView.
(-[WebView _notificationControllerDestroyed]):
(-[WebView _notificationProvider]):
(-[WebView _notificationDidShow:]):
(-[WebView _notificationDidClick:]):
(-[WebView _notificationsDidClose:]):

WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification

instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects.

WebCoreSupport/WebNotificationClient.mm:

(generateNotificationID): Created unique IDs for each shown notification.
(WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the
mappings between the objects, and forward it to the provider.
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications): Clear all notifications associated with the
provided context.
(WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps.
(WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell
the provider to clear of the notifications related to this web view.

====
(Prep work for) Bring notifications support to WK1 mac

Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for
notification requests. To avoid having to create a new listener type, instead rename it
to WebAllowDenyPolicyListener.

WebView/WebUIDelegatePrivate.h: Rename the protocol.
WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use

new name.

Add preference to keep track of whether notifications are enabled in general.

WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the

preference.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]): By default have them enabled.
(-[WebPreferences setNotificationsEnabled:]):
(-[WebPreferences notificationsEnabled]):

WebView/WebPreferencesPrivate.h:

Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the
notification policy for a given origin.

WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin stringValue]):

WebCoreSupport/WebSecurityOriginPrivate.h:

Tools: Bring notifications support to WK1 mac
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate timerFired]):

3:33 PM Changeset in webkit [108408] by noam.rosenthal@nokia.com

2 edits in trunk/Source/WebKit2

[Qt][WK2] Draw tiles of previous contents-scale for opaque layers if they don't intersect with previous tiles
https://bugs.webkit.org/show_bug.cgi?id=78962

Only avoid painting old-scale tiles in semi-transparent situtations if the old
tiles intersect with existing tiles.

Reviewed by Kenneth Rohde Christiansen.

UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

3:30 PM Changeset in webkit [108407] by noam.rosenthal@nokia.com

4 edits in trunk/Source

[Qt] Previous web page appears outside content rect
https://bugs.webkit.org/show_bug.cgi?id=78816

Source/WebCore:

Adjust the scissor clipping by -1, as the glScissor() function requires coordinates and
not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::scissorClip):

Source/WebKit2:

Apply a clip on painted tiles if some of the tiles fall outside of the target rect.

Reviewed by Kenneth Rohde Christiansen.

UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

3:28 PM Changeset in webkit [108406] by commit-queue@webkit.org

3 edits
3 adds in trunk

Source/WebCore: Added support for pause-on-exit flag on a TextTrackCue.
https://bugs.webkit.org/show_bug.cgi?id=72173

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-02-21
Reviewed by Eric Carlson.

Test: media/track/track-cues-pause-on-exit.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Implemented
support for pausing the video if the pause-on-exit flag is set on
a cue that is currently exiting.

LayoutTests: Added relevant tests and functionality for supporting pause-on-exit
flag for a TextTrackCue.

https://bugs.webkit.org/show_bug.cgi?id=72173

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-02-21
Reviewed by Eric Carlson.

media/track/captions-webvtt/simple-captions.vtt: Added.
media/track/track-cues-pause-on-exit-expected.txt: Added.
media/track/track-cues-pause-on-exit.html: Added.

2:57 PM Changeset in webkit [108405] by noam.rosenthal@nokia.com

3 edits in trunk/Source/WebKit2

[Qt][WK2] Accelerated animations don't work on Mac
https://bugs.webkit.org/show_bug.cgi?id=78963

Problem came from using a non-RunLoop timer.
Remove the unused viewportUpdateTimer, and use the existing animationTimer instead.
Use a continuous timer that we only stop when animations stop.

Reviewed by Kenneth Rohde Christiansen.

UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(WebKit::LayerTreeHostProxy::syncAnimations):

2:51 PM Changeset in webkit [108404] by haraken@chromium.org

10 edits in trunk/Source/WebCore

Enable the IDL attribute checker in all build systems
https://bugs.webkit.org/show_bug.cgi?id=79090

Reviewed by Adam Barth.

We have enabled the IDL attribute checker in Chromium in r108322.
This patch enables the IDL attribute checker in all other
build systems.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.am:
UseJSC.cmake:
UseV8.cmake:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/scripts/IDLAttributes.txt: Added [ObjCCustomImplementation]

since I forgot to add it in r108322.

2:46 PM Changeset in webkit [108403] by rniwa@webkit.org

2 edits in trunk

Fix more typos.

2:44 PM Changeset in webkit [108402] by yael.aharon@nokia.com

8 edits
2 adds in trunk/Source/WebCore

[Texmap] Better management of shaders in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=78674

Reviewed by Noam Rosenthal.

Split TextureMapperGL.cpp into two files.
Get rid of the enums that we were using to identify shaders and to identify variables.
Switch flip and opaque from using bool to using enums.

No new tests. This is refactoring only.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
platform/graphics/OpenGLShims.h:
platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore):
(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTextureWithMaskAndOpacity):
(WebCore::TextureMapperGL::drawTextureSimple):
(WebCore::TextureMapperGL::beginClip):

platform/graphics/opengl/TextureMapperGL.h:
platform/graphics/opengl/TextureMapperShaderManager.cpp: Added.

(WebCore):
(WebCore::FRAGMENT_SHADER):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramClip::create):
(WebCore::TextureMapperShaderProgramClip::TextureMapperShaderProgramClip):
(WebCore::TextureMapperShaderProgramClip::vertexShaderSource):
(WebCore::TextureMapperShaderProgramClip::fragmentShaderSource):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):

platform/graphics/opengl/TextureMapperShaderManager.h: Added.

(WebCore):
(WebCore::debugGLCommand):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(WebCore::TextureMapperShaderProgram::shaderType):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::matrixVariable):
(WebCore::TextureMapperShaderProgramSimple::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgramSimple::sourceTextureVariable):
(WebCore::TextureMapperShaderProgramSimple::opacityVariable):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::matrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::sourceTextureVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::opacityVariable):
(TextureMapperShaderProgramClip):
(WebCore::TextureMapperShaderProgramClip::matrixVariable):
(TextureMapperShaderManager):
(WebCore::TextureMapperShaderManager::getShaderProgram):

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

2:37 PM Changeset in webkit [108401] by rniwa@webkit.org

1 edit in trunk/ChangeLog

Fix the typo.

2:29 PM Changeset in webkit [108400] by haraken@chromium.org

2 edits in trunk/Tools

Enable the IDL attribute checker in run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=79091

Reviewed by Adam Barth.

We have enabled the IDL attribute checker in Chromium in r108322.
This patch enables the IDL attribute checker in run-bindings-tests.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
run-bindings-tests failures.

Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):

2:26 PM Changeset in webkit [108399] by rniwa@webkit.org

5 edits
2 adds
3 deletes in trunk

perf-o-matic: Extract logic to generate JSON responses as classes to unit test
https://bugs.webkit.org/show_bug.cgi?id=79018

Rubber-stamped by Adam Birth.

Extracted DashboardJSONGenerator, ManifestJSONGenerator, and RunsJSONGenerator
into json_generators.py from DashboardHandler, ManifestHandler, and RunsHandler
and added unit tests for the former three classes.

Merged the latter three classes into controler.py since they have become too trivial
to have their own files.

Websites/webkit-perf.appspot.com/controller.py:

(ManifestUpdateHandler):
(ManifestUpdateHandler.get):
(ManifestUpdateHandler.post):
(DashboardUpdateHandler):
(DashboardUpdateHandler.get):
(DashboardUpdateHandler.post):
(_get_test_branch_platform_ids):
(RunsUpdateHandler):
(RunsUpdateHandler.get):
(CachedRunsHandler.get):

Websites/webkit-perf.appspot.com/dashboard_handler.py: Removed.
Websites/webkit-perf.appspot.com/json_generators.py: Added.

(JSONGeneratorBase):
(JSONGeneratorBase.to_json):
(DashboardJSONGenerator):
(DashboardJSONGenerator.init):
(DashboardJSONGenerator.value):
(ManifestJSONGenerator):
(ManifestJSONGenerator.init):
(ManifestJSONGenerator.value):
(RunsJSONGenerator):
(RunsJSONGenerator.init):
(RunsJSONGenerator._generate_runs):
(RunsJSONGenerator._entry_from_build_and_result):
(RunsJSONGenerator.value):

Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added.

(_create_results):
(JSONGeneratorBaseTest):
(JSONGeneratorBaseTest.test_to_json):
(JSONGeneratorBaseTest.test_to_json.AJSONGenerator):
(JSONGeneratorBaseTest.test_to_json.AJSONGenerator.value):
(DashboardJSONGeneratorTest):
(DashboardJSONGeneratorTest.test_value_no_branch):
(DashboardJSONGeneratorTest.test_value_no_plaforms):
(DashboardJSONGeneratorTest.test_value_single_platform):
(DashboardJSONGeneratorTest.test_value_two_platforms):
(ManifestJSONGeneratorTest):
(ManifestJSONGeneratorTest.test_value_no_branch):
(ManifestJSONGeneratorTest.test_value_no_plaforms):
(ManifestJSONGeneratorTest._assert_single_test):
(ManifestJSONGeneratorTest.test_value_single_platform):
(ManifestJSONGeneratorTest.test_value_two_platforms):
(ManifestJSONGeneratorTest.test_value_two_tests):
(RunsJSONGeneratorTest):
(RunsJSONGeneratorTest._create_results):
(RunsJSONGeneratorTest.test_generate_runs):
(RunsJSONGeneratorTest.test_value_without_results):
(RunsJSONGeneratorTest.test_value_with_results):
(RunsJSONGeneratorTest._assert_entry):
(RunsJSONGeneratorTest.test_run_from_build_and_result):
(RunsJSONGeneratorTest.test_run_from_build_and_result.create_build):

Websites/webkit-perf.appspot.com/main.py:
Websites/webkit-perf.appspot.com/manifest_handler.py: Removed.
Websites/webkit-perf.appspot.com/models.py:

(Test.update_or_insert.execute):
(Test):
(TestResult.get_or_insert_from_parsed_json):

Websites/webkit-perf.appspot.com/models_unittest.py:

(TestModelTests.test_update_or_insert_to_update):
(TestResultTests.test_get_or_insert_stat_value):

Websites/webkit-perf.appspot.com/runs_handler.py: Removed.

2:26 PM Changeset in webkit [108398] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/AutoTableLayout.cpp

Explicitly converting table's logical width, as well as borders, padding, spacing, etc. to integers before doing math with them to avoid truncating the width an extra pixel unnecessarily.

2:21 PM Changeset in webkit [108397] by andersca@apple.com

3 edits in trunk/Source/WebCore

The tile cache should keep track of the tile coverage rect
https://bugs.webkit.org/show_bug.cgi?id=79149
<rdar://problem/10877338>

Reviewed by Andreas Kling.

Keep track of the tile coverage rect and use it to avoid trying to iterate over non-existent tiles on large pages.

platform/graphics/ca/mac/TileCache.h:

(TileCache):

platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):
(WebCore::TileCache::revalidateTiles):

2:05 PM Changeset in webkit [108396] by kling@webkit.org

3 edits in trunk/Source/WebCore

Make WebKitCSSShaderValue inherit directly from CSSValue.
<http://webkit.org/b/79144>

Reviewed by Antti Koivisto.

WebKitCSSShaderValue was inheriting from CSSPrimitiveValue but only used
it for storing the shader URL. Moved that to a String member instead.

WebKitCSSShaderValues didn't even return true for isPrimitiveValue() so
there should be no behavior change whatsoever here.

css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::customCssText):

css/WebKitCSSShaderValue.h:

(WebKitCSSShaderValue):

1:57 PM Changeset in webkit [108395] by jamesr@google.com

2 edits in trunk/Source/WebCore

Unreviewed windows build fix - avoid return statement after return if USE(ACCELERATED_COMPOSITING) is set.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):

1:46 PM Changeset in webkit [108394] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing the order of arguments to pixelSnappedIntRectFromEdges in RenderInline, and properly calculating the available logical width in RenderBlockLineLayout. Both of these were regressions from my previous commit.

1:40 PM Changeset in webkit [108393] by Csaba Osztrogonác

1 edit
1 move
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Typo fix.

platform/qt-5.0-wk2/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt.

1:39 PM Changeset in webkit [108392] by jamesr@google.com

3 edits in trunk/Source/WebCore

ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active
https://bugs.webkit.org/show_bug.cgi?id=79126

Reviewed by Anders Carlsson.

The ScrollingCoordinator should only attempt to coordinate scrolling when compositing is active, since it's all
about manipulating GraphicsLayers. Adds a runtime check.

Also removes some stray #if ENABLE(THREADED_SCROLLING) guards that snuck into FrameView.

page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):

1:35 PM Changeset in webkit [108391] by jamesr@google.com

4 edits in trunk/Source/WebCore

Chromium build fix. Unreviwed but rubber-stamped by Antti.

dom/Document.cpp:
editing/ReplaceSelectionCommand.cpp:
inspector/InspectorStyleSheet.h:

1:29 PM Changeset in webkit [108390] by senorblanco@chromium.org

1 edit
3 copies in branches/chromium/1025

Merge 107822 - Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

Test: css3/filters/multiple-filters-invalidation.html

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.

LayoutTests: New test to exercise invalidation of multiple CSS filters.
https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

css3/filters/multiple-filters-invalidation-expected.txt: Added.
css3/filters/multiple-filters-invalidation.html: Added.
platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429011

1:20 PM Changeset in webkit [108389] by Csaba Osztrogonác

2 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed evening gardening after r108364.

platform/qt/fast/forms/float-before-fieldset-expected.png: Added.
platform/qt/fast/forms/float-before-fieldset-expected.txt: Updated.

1:14 PM Changeset in webkit [108388] by wjmaclean@chromium.org

2 edits in trunk/LayoutTests

[chromium] Enable compositor filter layout tests (except on mac and win debug)
https://bugs.webkit.org/show_bug.cgi?id=79111

Reviewed by Stephen White.

platform/chromium/test_expectations.txt:

1:08 PM Changeset in webkit [108387] by eric.carlson@apple.com

10 edits
1 delete in trunk

Set Referrer header for media downloads
https://bugs.webkit.org/show_bug.cgi?id=78614

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/media/video-referer.html was modified to test this change.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerReferrer): New, return the document's referer.

html/HTMLMediaElement.h:

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::referrer): New, return the client's mediaPlayerReferrer.

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerReferrer):

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation to add

a referer header.

LayoutTests:

http/tests/media/resources/video-referer-check-referer.php: Get the test file and content-type

from parameters on the url. Fail if referrer is anything but video-referer.html. Add support for
byte-range requests so it will work with AVFoundation.

http/tests/media/video-referer.html: Pass video file name and content-type as url parameters

instead of having another cgi set a cookie. Set the php script as the 'src' on a <source> element
instead of on the <video> element so we can also add a 'type' attribute.

12:58 PM Changeset in webkit [108386] by Antti Koivisto

2 edits in trunk/Source/WebCore

Not reviewed.

Remove some obsolete comments, use consistent name for propertyID.

css/StylePropertySet.h:

(StylePropertySet):

12:48 PM Changeset in webkit [108385] by Antti Koivisto

5 edits in trunk/Source/WebCore

Clean up StylePropertySet included headers
https://bugs.webkit.org/show_bug.cgi?id=79134

Reviewed by Andreas Kling.

Remove unneccesary includes.

bindings/js/JSDOMBinding.h:
css/StylePropertySet.cpp:
css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

editing/RemoveCSSPropertyCommand.cpp:

12:43 PM Changeset in webkit [108384] by Chris Fleizach

2 edits in trunk/LayoutTests

AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Unreviewed. Forgot to update paths.

accessibility/aria-invalid.html:

12:10 PM Changeset in webkit [108383] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix bug from r107672.
https://bugs.webkit.org/show_bug.cgi?id=78773

Before set MediaStreamTrack disable/enable operation,
checking the status of MediaStream that contains this MediaStreamTrack.
if MediaStream is finished, then skipping operation of
didSetMediaStreamTrackEnabled().

Patch by Lin Wei <wei.a.lin@intel.com> on 2012-02-21
Reviewed by Adam Barth.

mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

11:59 AM Changeset in webkit [108382] by jchaffraix@webkit.org

11 edits in trunk/Source/WebCore

Move RenderLayer::scrolledContentOffset calls to a common function
https://bugs.webkit.org/show_bug.cgi?id=76971

Reviewed by David Hyatt.

Refactoring without any change in behavior.

This change adds a RenderBox::scrolledContentOffset function to handle all
the calls that goes through the layer(). This indirection will enable us to
add layer() checks without patching a lot of call sites as part of bug 75568.

We also moved down the concept of scroll offset down to RenderBox where it belongs!

rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::scrolledContentOffset):
Moved scrolledContent to the private section of the class to prevent misuse.

rendering/RenderBox.cpp:

(WebCore::RenderBox::scrolledContentOffset):
New function to add an indirection with RenderLayer.

editing/visible_units.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock):

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):

rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):

rendering/RenderBox.h:

(RenderBox):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):

rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::offsetFromContainer):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlInnerBlock::positionForPoint):
Patched all those call sites to use the new function.

11:55 AM Changeset in webkit [108381] by rafaelw@chromium.org

2 edits in trunk/Tools

Add rafaelw as a committer.

Unreviewed.

Scripts/webkitpy/common/config/committers.py:

11:49 AM Changeset in webkit [108380] by tonikitoo@webkit.org

3 edits in trunk/Source/WebKit/blackberry

2012-02-18 Antonio Gomes <agomes@rim.com>

Fat fingers - cache the first rect-based hit test so we do not need to do it again
https://bugs.webkit.org/show_bug.cgi?id=79115

Reviewed by Adam Treat.

Our FatFingers implementation runs currently in two phases:
the first checks for the elements intrinsically clickable;
the second checks for elements made clickable by the page
(for example, a div with a onclick event listener attached to it).
For each phase, we perform a rect hittest, which is not needed since
the result of each is the same.

Patch introduces a caching mechanism so we avoid on rect hittest:
when the first phase runs, it caches each nodeset per document in
a hashmap. This second phase works with the cached results.

No behavioral change, but performance is better since we
avoid one (possibly expensive) rect hittest.

I measured the performance gain on https://www.kvd.se/, and we
save up to 0.04 seconds, by caching and re-using the results.

WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::dumpHitTestResult): (BlackBerry::WebKit::FatFingers::findBestPoint): (BlackBerry::WebKit::FatFingers::findIntersectingRegions): (BlackBerry::WebKit::FatFingers::cachingStrategy): (WebKit): (BlackBerry::WebKit::FatFingers::getNodesFromRect):
WebKitSupport/FatFingers.h:

11:41 AM Changeset in webkit [108379] by dpranke@chromium.org

2 edits in trunk/Tools

webkitpy: update names after deleting message_broker
https://bugs.webkit.org/show_bug.cgi?id=79000

Reviewed by Eric Seidel.

Part 3 of 3 in deleting message_broker.py; this change just
adjusts the names for the newly merged symbols so that they are
private as appropriate.

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_Broker):
(_BrokerConnection):
(_BrokerConnection.init):
(AbstractWorker.init):
(_ManagerConnection):
(_ManagerConnection.init):
(_WorkerConnection):
(_WorkerConnection.init):

11:33 AM Changeset in webkit [108378] by dpranke@chromium.org

2 edits
1 delete in trunk/Tools

webkitpy: merge message_broker.py into manager_worker_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78999

Reviewed by Tony Chang.

This is pretty much a straight cut-and-paste of one file into
another (broken up so that docstrings and imports are in the
right place).

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(BrokerClient):
(BrokerClient.is_done):
(BrokerClient.name):
(Broker):
(Broker.init):
(Broker.add_topic):
(Broker._get_queue_for_topic):
(Broker.post_message):
(Broker.run_message_loop):
(Broker.run_all_pending):
(Broker._run_loop):
(Broker._dispatch_message):
(_Message):
(_Message.loads):
(_Message.init):
(_Message.dumps):
(_Message.repr):
(BrokerConnection):
(BrokerConnection.init):
(BrokerConnection.run_message_loop):
(BrokerConnection.post_message):
(BrokerConnection.raise_exception):

Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.

11:33 AM Changeset in webkit [108377] by eae@chromium.org

5 edits in trunk/Source/WebCore

Remove obsolete float comparison FIXMEs
https://bugs.webkit.org/show_bug.cgi?id=79127

Reviewed by Eric Seidel.

Remove obsolete FIXME comments added back when we were planning to use
floating point units for layout.

No new tests, no code changes.

page/FrameView.cpp:

(WebCore::FrameView::init):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::getClearDelta):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):

rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

11:28 AM Changeset in webkit [108376] by dpranke@chromium.org

3 edits
1 delete in trunk/Tools

webkitpy: prepare to delete message_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78997

Reviewed by Eric Seidel.

This is part 1 of 3 changes to fix bug 78187. This change
prepares the code for merging message_broker.py into
manager_worker_broker.py; the tests in message_broker_unittest
are merged into manager_worker_broker_unittest, the symbols
needed by the tests are exported from manager_worker_broker.py,
and manager_worker_broker itself is updated to refer to the
symbols directly (without the module prefix).

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(AbstractWorker):
(AbstractWorker.init):
(_ManagerConnection):
(_ManagerConnection.init):
(_WorkerConnection):
(_WorkerConnection.init):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(InterfaceTest.test_brokerclient_is_abstract):
(InterfaceTest.test_brokerclient_is_abstract.methods):
(MessageTest):
(MessageTest.testno_body):
(MessageTest.testbody):

Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.

11:25 AM Changeset in webkit [108375] by dgrogan@chromium.org

2 edits in trunk/Source/WebKit/chromium

IndexedDB: webFrame isn't threadsafe, don't use it from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=78659

After crrev.com/121669, indexed db doesn't use the web frame for
anything if called from a web worker.

No new tests - this check was defensive and possibly not ever
triggered.

Reviewed by Tony Chang.

src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

11:17 AM Changeset in webkit [108374] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: it is nearly impossible to select and copy text on the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60814

Reviewed by Pavel Feldman.

inspector/front-end/inspector.js:

(WebInspector.documentClick.followLink):
(WebInspector.documentClick):

11:13 AM Changeset in webkit [108373] by Chris Fleizach

3 edits
2 moves in trunk/LayoutTests

AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Reviewed by David Kilzer.

accessibility/aria-invalid-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-invalid-expected.txt.
accessibility/aria-invalid.html: Copied from LayoutTests/platform/mac/accessibility/aria-invalid.html.
platform/gtk/Skipped:
platform/mac/accessibility/aria-invalid-expected.txt: Removed.
platform/mac/accessibility/aria-invalid.html: Removed.
platform/win/Skipped:

11:10 AM Changeset in webkit [108372] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in RenderTableSection::nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=78922

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-section-node-at-point-crash.html

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
m_needsCellRecalc is set. Otherwise, we will end up accessing
removed table cells.

LayoutTests:

fast/table/table-section-node-at-point-crash-expected.txt: Added.
fast/table/table-section-node-at-point-crash.html: Added.

10:54 AM Changeset in webkit [108371] by jamesr@google.com

2 edits
2 adds in trunk/LayoutTests

[chromium] Unreviewed, update chromium leopard baselines for r108364

platform/chromium-mac-leopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
platform/chromium-mac-leopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
platform/chromium-mac-leopard/fast/forms/float-before-fieldset-expected.png:

10:46 AM WebKitIDL edited by arv@chromium.org

(diff)

10:38 AM Changeset in webkit [108370] by Antti Koivisto

8 edits
1 copy
1 add in trunk/Source/WebCore

Move PropertySetCSSStyleDeclaration to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=79121

Rubber-stamped by Andreas Kling.

This makes StylePropertySet.cpp more readable.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/PropertySetCSSStyleDeclaration.cpp: Copied from Source/WebCore/css/StylePropertySet.cpp.

(WebCore::PropertySetCSSStyleDeclaration::ref):
(WebCore::PropertySetCSSStyleDeclaration::deref):
(WebCore):

css/PropertySetCSSStyleDeclaration.h: Added.

(WebCore):
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):

css/StylePropertySet.cpp:

(WebCore):

10:24 AM Changeset in webkit [108369] by Patrick Gansterer

3 edits in trunk/Source/JavaScriptCore

Unnecessary preprocessor macros in MainThread.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=79083

Removed invalid/wrong PLATFORM(WINDOWS) preprocessor macro.

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-21

wtf/MainThread.cpp:

(WTF):

wtf/MainThread.h:

(WTF):

10:22 AM Changeset in webkit [108368] by jamesr@google.com

4 edits
9 adds
1 delete in trunk/LayoutTests

[chromium] Unreviewed, update chromium baselines for r108364

platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
platform/chromium-mac-snowleopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/float-before-fieldset-expected.png: Added.
platform/chromium-mac/fast/forms/float-before-fieldset-expected.png: Removed.
platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
platform/chromium-win/fast/forms/float-before-fieldset-expected.txt:

10:20 AM Changeset in webkit [108367] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK] WebAudio build is broken
https://bugs.webkit.org/show_bug.cgi?id=79113

Patch by Philippe Normand <pnormand@igalia.com> on 2012-02-21
Reviewed by Martin Robinson.

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioGStreamerChannelPosition): Set a default value for
the position variable.

platform/audio/gtk/AudioBusGtk.cpp: Include CString.h, needed

for sharedResourcesPath().

10:00 AM Changeset in webkit [108366] by kling@webkit.org

16 edits
2 adds
2 deletes in trunk

Kill FontFamilyValue.
<http://webkit.org/b/79103>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove FontFamilyValue and replace all usage by CSSPrimitiveValue.
The class was only used to filter font family names, removing bracketed
suffixes, e.g "[Xft]".

This was added to KHTML in 2002 to support the use of specific X11 font
families inside KMail: <https://bugs.kde.org/show_bug.cgi?id=38808>

Test: fast/css/font-family-trailing-bracket-gunk.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.order:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

css/CSSParser.cpp:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:
css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

css/CSSValuePool.h:

(CSSValuePool):

css/FontFamilyValue.cpp: Removed.
css/FontFamilyValue.h: Removed.

LayoutTests:

fast/css/font-family-trailing-bracket-gunk-expected.txt: Added.
fast/css/font-family-trailing-bracket-gunk.html: Added.

9:35 AM Changeset in webkit [108365] by alexis.menard@openbossa.org

2 edits in trunk/Source/WebCore

Little optimization for CSSParser::parseFillShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79042

Reviewed by Hajime Morita.

Remove one extra loop that we can combine with the following one
which adds the properties to the parser's list of properties. I also
removed a useless check.
Instruments shows on the css-parser-yui benchmark an improvement
of 13ms (from 77ms spent in the function to 64ms).

No new tests : refactoring, existings tests should cover.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFillShorthand):

9:17 AM Changeset in webkit [108364] by hyatt@apple.com

8 edits
6 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Relevant discussion is here: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

This patch makes the following changes to how objects shrink when avoiding floats:
(1) The containing block width used for percentage calculations is now constant. This means that
an overflow:hidden block with a margin-left of 10% will no longer change what 10% means depending
on the available line width. From a code perspective, containingBlockLogicalWidthForContent and
containingBlockLogicalWidthForContentInRegion no longer contain any special-case code for
shrinkToAvoidFloats() objects.

(2) Now the computation of the logical width for the shrinking object itself handles the adjustments.
Two kinds of adjustments are made for both the start and end margins. Conceptually what we do is shrink
the object to the available line width minus our margins, and then expand the width back out to the content edge
or to the float edge as necessary. If the float fully fits in the margin, then we expand back out to the
content edge. Otherwise if the float doesn't fit, then we expand only to the float edge, making sure our
margin overlaps with the float. This expansion is not performed for negative margins, since our result is already
correct in that case.

Reviewed by Dan Bernstein.

Added the new tests from the thread on www-style about this issue (from Alan Gresley and George Talbot)
in fast/block/float.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containsFloat):

rendering/RenderBlock.h:

(WebCore::RenderBlock::containsFloats):
Changed to be const.

(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::endOffsetForContent):
Added endOffsetForXXX methods to mirror their startOffset counterparts. Used by the width adjustment code.

rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
New method that handles shrinking the logical width to the line width (and then re-expanding back out to the
float and/or content edges as needed).

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Patched to no longer do the shrinking of objects to avoid floats.

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Patched to handle calling the new shrinking code to adjust our logical width.

rendering/RenderBox.h:

(RenderBox):
The signature of computeLogicalWithUsing changed to be region-specific and to carry along enough information
to efficiently perform the shrinking.

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Patched to handle calling the new shrinking code to adjust our logical width.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Added new tests from www-style thread: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

Reviewed by Dan Bernstein.

fast/block/float/centered-float-avoidance-complexity.html: Added.
fast/block/float/shrink-to-avoid-float-complexity.html: Added.
platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.

9:01 AM Changeset in webkit [108363] by weinig@apple.com

17 edits in trunk

Attempt to fix the Snow Leopard build.

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty:

gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

8:49 AM Changeset in webkit [108362] by Csaba Osztrogonác

1 edit
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add platform specific expected file after r107689.

platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.

8:44 AM Changeset in webkit [108361] by weinig@apple.com

17 edits in trunk

Use libc++ when building with Clang on Mac
https://bugs.webkit.org/show_bug.cgi?id=78981

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty:

gtest/xcode/Config/General.xcconfig:

In addition to enabling libc++ when building with Clang,
disable gtest's use of tr1::tuple, which doesn't exist in
libc++.

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

8:38 AM Changeset in webkit [108360] by Adam Roben

2 edits in trunk/Source/WebCore

Mac build fix

WebCore.xcodeproj/project.pbxproj: Mark TextTrack.h and TextTrackCue.h private so that

WebKit can include them.

8:26 AM Changeset in webkit [108359] by abecsi@webkit.org

2 edits in trunk/Source/WebCore

[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Noam Rosenthal.

No new tests needed.

platform/graphics/opengl/TextureMapperGL.cpp: Add missing include.

8:26 AM Changeset in webkit [108358] by Adam Roben

79 edits
8 deletes in trunk

Roll out r108309, r108323, and r108326

They broke the 32-bit Lion build.

Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.

Source/JavaScriptCore:

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
assembler/LinkBuffer.h:
assembler/MacroAssemblerCodeRef.h:
bytecode/BytecodeConventions.h: Removed.
bytecode/CallLinkStatus.cpp:
bytecode/CallLinkStatus.h:
bytecode/CodeBlock.cpp:
bytecode/CodeBlock.h:
bytecode/GetByIdStatus.cpp:
bytecode/GetByIdStatus.h:
bytecode/Instruction.h:
bytecode/LLIntCallLinkInfo.h: Removed.
bytecode/MethodCallLinkStatus.cpp:
bytecode/Opcode.cpp:
bytecode/Opcode.h:
bytecode/PutByIdStatus.cpp:
bytecode/PutByIdStatus.h:
bytecompiler/BytecodeGenerator.cpp:
dfg/DFGByteCodeParser.cpp:
dfg/DFGCapabilities.h:
dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOperations.cpp:
heap/Heap.h:
heap/MarkStack.cpp:
heap/MarkedAllocator.h:
heap/MarkedSpace.h:
interpreter/CallFrame.cpp:
interpreter/CallFrame.h:
interpreter/Interpreter.cpp:
interpreter/Interpreter.h:
interpreter/RegisterFile.h:
jit/ExecutableAllocator.h:
jit/HostCallReturnValue.cpp: Removed.
jit/HostCallReturnValue.h: Removed.
jit/JIT.cpp:
jit/JITCode.h:
jit/JITDriver.h:
jit/JITExceptions.cpp:
jit/JITInlineMethods.h:
jit/JITStubs.cpp:
jit/JITStubs.h:
jit/JSInterfaceJIT.h:
llint/LLIntCommon.h: Removed.
llint/LLIntData.cpp: Removed.
llint/LLIntData.h: Removed.
llint/LLIntEntrypoints.cpp: Removed.
llint/LLIntEntrypoints.h: Removed.
llint/LLIntExceptions.cpp: Removed.
llint/LLIntExceptions.h: Removed.
llint/LLIntOfflineAsmConfig.h: Removed.
llint/LLIntOffsetsExtractor.cpp: Removed.
llint/LLIntSlowPaths.cpp: Removed.
llint/LLIntSlowPaths.h: Removed.
llint/LLIntThunks.cpp: Removed.
llint/LLIntThunks.h: Removed.
llint/LowLevelInterpreter.asm: Removed.
llint/LowLevelInterpreter.cpp: Removed.
llint/LowLevelInterpreter.h: Removed.
offlineasm/armv7.rb: Removed.
offlineasm/asm.rb: Removed.
offlineasm/ast.rb: Removed.
offlineasm/backends.rb: Removed.
offlineasm/generate_offset_extractor.rb: Removed.
offlineasm/instructions.rb: Removed.
offlineasm/offset_extractor_constants.rb: Removed.
offlineasm/offsets.rb: Removed.
offlineasm/opt.rb: Removed.
offlineasm/parser.rb: Removed.
offlineasm/registers.rb: Removed.
offlineasm/self_hash.rb: Removed.
offlineasm/settings.rb: Removed.
offlineasm/transform.rb: Removed.
offlineasm/x86.rb: Removed.
runtime/CodeSpecializationKind.h: Removed.
runtime/CommonSlowPaths.h:
runtime/Executable.cpp:
runtime/Executable.h:
runtime/ExecutionHarness.h: Removed.
runtime/JSArray.h:
runtime/JSCell.h:
runtime/JSFunction.h:
runtime/JSGlobalData.cpp:
runtime/JSGlobalData.h:
runtime/JSGlobalObject.h:
runtime/JSObject.h:
runtime/JSPropertyNameIterator.h:
runtime/JSString.h:
runtime/JSTypeInfo.h:
runtime/JSValue.cpp:
runtime/JSValue.h:
runtime/JSVariableObject.h:
runtime/Options.cpp:
runtime/Options.h:
runtime/ScopeChain.h:
runtime/Structure.cpp:
runtime/Structure.h:
runtime/StructureChain.h:
wtf/InlineASM.h:
wtf/Platform.h:
wtf/SentinelLinkedList.h:
wtf/text/StringImpl.h:

Source/WebCore:

CMakeLists.txt:

Source/WebKit:

CMakeLists.txt:

Tools:

DumpRenderTree/efl/CMakeLists.txt:

8:20 AM Changeset in webkit [108357] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

platform/qt/Skipped: Unskip now passing tests.

8:17 AM Changeset in webkit [108356] by apavlov@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] textPrompt.css disablement displays garbled suggest box
https://bugs.webkit.org/show_bug.cgi?id=79107

Reviewed by Pavel Feldman.

inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

inspector/front-end/textPrompt.css:

(.suggest-box):

8:14 AM Changeset in webkit [108355] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: timeline hangs on a page with deep chain of nested events.
https://bugs.webkit.org/show_bug.cgi?id=79106

Use stack of states instead of recursive calls when traversing records tree to
avoid stack overflow.

Reviewed by Pavel Feldman.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._forAllRecords):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._filterRecords):

7:56 AM Changeset in webkit [108354] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [crash] upon style modification after navigation
https://bugs.webkit.org/show_bug.cgi?id=79108

Reviewed by Yury Semikhatsky.

inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore::InspectorHistory::reset):

7:52 AM Changeset in webkit [108353] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Use WTF::cryptographicallyRandomValues in FileSystemWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=79089

Reviewed by Adam Roben.

Avoid loading and unloading of the crypto library during every
call to openTemporaryFile() and make the code easier.

platform/win/FileSystemWin.cpp:

(WebCore::openTemporaryFile):

7:31 AM Changeset in webkit [108352] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-02-21
Reviewed by Csaba Osztrogonác.

Qt buildfix after r108345.

css/CSSParser.cpp:

(WebCore::parseColorValue):

7:14 AM Changeset in webkit [108351] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Antti Koivisto.

Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
reported a false warning: 'value$m_ptr' may be used uninitialized in this function

css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

6:39 AM WebKitGTK/1.8.x edited by kov@webkit.org

merged Does not build on IA64, SPARC and Alpha (diff)

6:37 AM Changeset in webkit [108350] by kling@webkit.org

3 edits in trunk/Source/WebCore

Shrink attribute style property sets after populating them.
<http://webkit.org/b/78972>

Reviewed by Antti Koivisto.

Add a StylePropertySet::shrinkToFit() and call it at the end of updateStyleAttribute()
to minimize the amount of wasted space.

css/StylePropertySet.h:

(WebCore::StylePropertySet::shrinkToFit):

dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

6:33 AM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com

Modify build options to build WebKit EFL (diff)

6:20 AM Changeset in webkit [108349] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing test to paint the bot green.

platform/qt-mac/Skipped:

6:09 AM Changeset in webkit [108348] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging r108347

6:06 AM Changeset in webkit [108347] by kov@webkit.org

2 edits in trunk/Source/JavaScriptCore

Does not build on IA64, SPARC and Alpha
https://bugs.webkit.org/show_bug.cgi?id=79047

Patch by Gustavo Noronha Silva <kov@debian.org> and Bob Tracy <rct@frus.com> on 2012-02-21
Rubber-stamped by Kent Tamura.

wtf/dtoa/utils.h: these architectures also have correct double

operations, so add them to the appropriate side of the check.

5:53 AM Changeset in webkit [108346] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

platform/qt-4.8/Skipped:
platform/qt-5.0-wk2/Skipped:
platform/wk2/Skipped:

5:49 AM Changeset in webkit [108345] by Antti Koivisto

35 edits in trunk/Source/WebCore

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Andreas Kling.

The context should be passed as an argument for CSS parser invoking setters that actually need it.

Remove the context stylesheet pointer.
Add context stylesheet argument to setters.
Drop an unnecessary StylePropertySet constructor, pass strict parsing flag directly.
Adapt to changes by passing in the context stylesheet where needed.
Add StyledElement::applyPresentationAttributeToStyle helpers for building up the attribute style.

css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::addSubresourceStyleURLs):

css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

css/CSSParser.h:

(CSSParser):

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::addSubresourceStyleURLs):

css/StylePropertySet.cpp:

(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(InlineCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::RuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::contextStyleSheet):
(SameSizeAsStylePropertySet):

css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):

dom/StyledElement.cpp:

(WebCore):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::updateAttributeStyle):

dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::applyPresentationAttributeToStyle):
(WebCore):

html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectStyleForAttribute):

html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::collectStyleForAttribute):

html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):

html/HTMLElement.h:

(HTMLElement):

html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::collectStyleForAttribute):

html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectStyleForAttribute):

html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectStyleForAttribute):

html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectStyleForAttribute):

html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::collectStyleForAttribute):

html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::collectStyleForAttribute):

html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):

html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::collectStyleForAttribute):

html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::collectStyleForAttribute):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::collectStyleForAttribute):

svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):

svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::collectStyleForAttribute):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::collectStyleForAttribute):

svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):

5:10 AM Changeset in webkit [108344] by yurys@chromium.org

15 edits in trunk/Source

[V8] Web Inspector: set breakpoint/pause doesn't work when worker is in a tight loop
https://bugs.webkit.org/show_bug.cgi?id=79097

Source/WebCore:

Worker script will be interrupted to dispatch all arriving inspector commands.
This way debugger will be operable even if worker is in a tight loop.

Reviewed by Pavel Feldman.

bindings/js/ScriptDebugServer.h:

(Task):
(WebCore::ScriptDebugServer::Task::~Task):
(ScriptDebugServer):

bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):

bindings/js/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::interruptAndRun):

bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):

bindings/v8/WorkerScriptDebugServer.h:

(v8):
(WebCore):
(WorkerScriptDebugServer):

inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):

inspector/WorkerDebuggerAgent.h:

(WebCore):
(WorkerDebuggerAgent):

workers/WorkerMessagingProxy.cpp:

(WebCore):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):

workers/WorkerRunLoop.h:

(WorkerRunLoop):

Source/WebKit/chromium:

Worker script execution will be interrupted for dispatching inspector commands.

Reviewed by Pavel Feldman.

src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):

5:05 AM Changeset in webkit [108343] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] 3 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332

platform/qt/Skipped: Skip 3 more asserting test.

4:38 AM Changeset in webkit [108342] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] REGRESSION(r108112): sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A1.2_T2.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=79029

platform/qt/Skipped: Skip new crashing test.

4:34 AM Changeset in webkit [108341] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit/qt

[Qt] tst_QWebPage::infiniteLoopJS() timeouts with DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79040

Reviewed by Simon Hausmann.

tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage): Disable tst_QWebPage::infiniteLoopJS() until proper fix.

4:26 AM Changeset in webkit [108340] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: fixing Mac build (take 2).

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setShowPaintRects):

4:16 AM Changeset in webkit [108339] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, skip new failing mediastream test on GTK.

platform/gtk/Skipped:

4:13 AM Changeset in webkit [108338] by pfeldman@chromium.org

7 edits in trunk/Source/WebCore

Not reviewed: fixing Mac build.

inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawOutline):

inspector/DOMNodeHighlighter.h:

(DOMNodeHighlighter):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):

inspector/InspectorPageAgent.h:

4:04 AM Changeset in webkit [108337] by vsevik@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-21
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

inspector/CodeGeneratorInspector.py:
inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

inspector/InjectedScript.h:

(InjectedScript):

inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):

inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

4:00 AM Changeset in webkit [108336] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Not reviewed: fixing poor merge in r108332.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):

inspector/front-end/externs.js:

3:47 AM Changeset in webkit [108335] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Rule source URL tooltip should show line number
https://bugs.webkit.org/show_bug.cgi?id=79087

Reviewed by Pavel Feldman.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

3:46 AM Changeset in webkit [108334] by Philippe Normand

2 edits in trunk/Source/WebKit/gtk

Fix one more GTK+ unit test after r108278.

Reviewed by Alejandro G. Castro.

tests/testkeyevents.c:

(map_event_cb): No longer grab focus here.
(setup_keyevent_test): Grabbing focus here seems to be late enough in the process.

3:34 AM Changeset in webkit [108333] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/qt

[Qt] Print warning when importing experimental WK2 APIs in QML
https://bugs.webkit.org/show_bug.cgi?id=78817

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-02-21
Reviewed by Simon Hausmann.

declarative/experimental/plugin.cpp:

3:32 AM Changeset in webkit [108332] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: clicking empty space should not re-enter edit mode
https://bugs.webkit.org/show_bug.cgi?id=79024

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Vsevolod Vlasov.

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceMouseDown):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):

3:30 AM Changeset in webkit [108331] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: evaluate on hover does not work for large files.
https://bugs.webkit.org/show_bug.cgi?id=79015

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Yury Semikhatsky.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):

inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._handleMouseAction):

inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer):
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

inspector/front-end/SourceJavaScriptTokenizer.re2js:

3:28 AM Changeset in webkit [108330] by pfeldman@chromium.org

15 edits in trunk/Source/WebCore

Web Inspector: add "show paint rectangles" setting.
https://bugs.webkit.org/show_bug.cgi?id=79030

Reviewed by Yury Semikhatsky.

English.lproj/localizedStrings.js:
inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawOutline):
(DOMNodeHighlighter):

inspector/DOMNodeHighlighter.h:

(WebCore):
(DOMNodeHighlighter):

inspector/Inspector.json:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):

inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::buildObjectForFrame):

inspector/InspectorPageAgent.h:

(WebCore):

inspector/front-end/Settings.js:

(WebInspector.Settings):

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):

inspector/front-end/inspector.js:
page/FrameView.cpp:

(WebCore::FrameView::paintContents):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

3:26 AM Changeset in webkit [108329] by abecsi@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Clean-up project file after r108310

Reviewed by Csaba Osztrogonác.

No new tests needed.

Target.pri: Fix path for TextTrack headers.

2:57 AM Changeset in webkit [108328] by abecsi@webkit.org

13 edits in trunk

[Qt][WK2] Get rid of the dependency to QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=76276

Reviewed by Simon Hausmann.

Source/WebKit2:

Target.pri:
UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
UIProcess/API/qt/tests/tests.pri:
UIProcess/API/qt/tests/util.h:

Tools:

MiniBrowser/qt/MiniBrowser.pro:
MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

MiniBrowser/qt/MiniBrowserApplication.h:

(MiniBrowserApplication):

QtTestBrowser/locationedit.h:
WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

2:33 AM Changeset in webkit [108327] by Philippe Normand

4 edits
14 adds in trunk

[GStreamer] media/W3C failures
https://bugs.webkit.org/show_bug.cgi?id=75078

Reviewed by Martin Robinson.

Source/WebCore:

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): Clean out everything
after file:// url path to cope with media/W3C tests loading
file:///path/to/media.ext?some parameters.

LayoutTests:

Unskip now passing tests and add GTK baselines for them.

platform/gtk/Skipped:
platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.

1:49 AM Changeset in webkit [108326] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Fix massive crashes in all tests introduced by previous build fix, and fix non-DFG build.
https://bugs.webkit.org/show_bug.cgi?id=75812

Reviewed by Csaba Osztrogonác.

dfg/DFGOperations.cpp:

(JSC):

jit/HostCallReturnValue.h:

(JSC::initializeHostCallReturnValue):

1:29 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu

(diff)

1:20 AM Changeset in webkit [108325] by mlilek@apple.com

2 edits in trunk/Source/WebCore

Not reviewed, build fix for non-client-based Geolocation builds after r107982.

page/Geolocation.cpp:

1:09 AM Changeset in webkit [108324] by yurys@chromium.org

6 edits in trunk/Source/WebCore

[V8] Web Inspector: simplify worker debugger implementation
https://bugs.webkit.org/show_bug.cgi?id=79085

There is one instance of WorkerScriptDebugServer per worker thread. We don't
need to resolve WorkerContext from V8::Context anymore.

Reviewed by Pavel Feldman.

bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):

bindings/v8/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):

1:09 AM Changeset in webkit [108323] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Attempted build fix for ELF platforms.

dfg/DFGOperations.cpp:

(JSC):
(JSC::getHostCallReturnValueWithExecState):

jit/HostCallReturnValue.cpp:

(JSC):

jit/HostCallReturnValue.h:

(JSC::initializeHostCallReturnValue):

1:00 AM Changeset in webkit [108322] by haraken@chromium.org

6 edits
1 add in trunk/Source/WebCore

Enable the IDL attribute checker in Chromium
https://bugs.webkit.org/show_bug.cgi?id=79082

Reviewed by Adam Barth.

We have fixed 10~ bugs caused by typos of IDL attributes.
This patch adds an IDL attribute checker, which checks if all IDL attributes
used in IDL files are implemented by code generators.

The IDL attribute checker uses IDLAttributes.txt, which lists all IDL attributes implemented in code generators. If we want to add a new IDL attribute, we need to add it to IDLAttributes.txt manually.
The IDL attribute checker checks if all IDL attributes used in IDL files are listed in IDLAttributes.txt.
If the IDL attribute checker fails, the build fails with a verbose error message.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

WebCore.gyp/WebCore.gyp: Modified to enable the IDL attribute checker.

bindings/scripts/resolve-supplemental.pl:

(loadIDLAttributes): This method loads a list of IDL attributes from IDLAttributes.txt.
(checkIDLAttributes): This method implementes the IDL attribute checker as described above.
(checkIfIDLAttributesExists):

bindings/scripts/IDLParser.pm: "1" is not good to represent that

the IDL attribute does not have any value. This patch changed it to "VALUE_IS_MISSING".
(parseExtendedAttributes):
(ParseInterface):

bindings/scripts/CodeGenerator.pm: Ditto.

(ContentAttributeName):

bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GetRuntimeEnableFunctionName):

bindings/scripts/IDLAttributes.txt: Added. This file lists all IDL attributes implemented

in code generators.

12:43 AM Changeset in webkit [108321] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336

Reviewed by Adam Roben.

Use FindFirstFile() in favour over _wstat64() to share the code with WinCE.

platform/win/FileSystemWin.cpp:

(WebCore):
(WebCore::getFindData):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::fileExists):

12:25 AM Changeset in webkit [108320] by yutak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations to reflect recent flakiness.

platform/chromium/test_expectations.txt:

12:19 AM Changeset in webkit [108319] by Martin Robinson

2 edits in trunk/LayoutTests

Rebaseline a test for GTK+.

platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: New baseline.

12:10 AM Changeset in webkit [108318] by Martin Robinson

2 edits in trunk/LayoutTests

Skip some test that are failing after r108278.

platform/gtk/Skipped: Skip a few tests.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed