Timeline
Feb 24, 2012:
- 11:20 PM Changeset in webkit [108887] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Unreviewed. Add missing fast/images/rgb-jpeg-with-adobe-marker-only.html results.
- platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Removed.
- platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 8:09 PM Changeset in webkit [108886] by
-
- 47 edits in trunk/Source
[chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
https://bugs.webkit.org/show_bug.cgi?id=78404
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-02-24
Reviewed by James Robinson.
Source/WebCore:
No new tests. Updated existing test to reflect changes.
- platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/CanvasLayerChromium.h:
(CanvasLayerChromium):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::createCCLayerImpl):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/PluginLayerChromium.h:
(PluginLayerChromium):
- platform/graphics/chromium/SolidColorLayerChromium.cpp:
(WebCore::SolidColorLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/SolidColorLayerChromium.h:
(SolidColorLayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
- platform/graphics/chromium/TreeSynchronizer.h:
(TreeSynchronizer):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::createCCLayerImpl):
- platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
(WebCore::CCCanvasLayerImpl::create):
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::addChild):
(WebCore::sortLayers):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::children):
(CCLayerImpl):
(WebCore):
- platform/graphics/chromium/cc/CCLayerIterator.cpp:
(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
- platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore):
(CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::getRawPtr):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):
(BackToFront):
(FrontToBack):
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::createGraphNodes):
- platform/graphics/chromium/cc/CCLayerSorter.h:
(CCLayerSorter):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(WebCore::CCPluginLayerImpl::create):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::layerList):
(CCRenderSurface):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(WebCore::CCSolidColorLayerImpl::create):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::create):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::createAndSetUpTestTreeWithOneSurface):
(WebKitTests::createAndSetUpTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerSorterTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):
(WebKit::DidDrawCheckLayer::create):
(WebKit::BlendStateCheckLayer::create):
- tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):
- tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
- tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
- tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- tests/TreeSynchronizerTest.cpp:
(WebKitTests::MockCCLayerImpl::create):
(WebKitTests::MockLayerChromium::createCCLayerImpl):
(WebKitTests::expectTreesAreIdentical):
(WebKitTests::TEST):
- 7:27 PM Changeset in webkit [108885] by
-
- 3 edits in trunk/Source/WebCore
Don't pass constant strings to CSSParser for presentation attributes.
<http://webkit.org/b/79530>
Reviewed by Anders Carlsson.
"both" -> CSSValueBoth.
"center" -> CSSValueCenter.
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::collectStyleForAttribute):
- 6:57 PM Changeset in webkit [108884] by
-
- 1 edit5 moves in trunk/LayoutTests
Unreviewed, rename mispelled expectation files.
https://bugs.webkit.org/show_bug.cgi?id=79457
WebKit is no abode for poor spelling.
- fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
- fast/images/rgb-jpeg-with-adobe-marker-only.html: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only.html.
- platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
- platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
- platform/mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
- 6:55 PM Changeset in webkit [108883] by
-
- 10 edits in trunk/Source
[chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=75591
Reviewed by Kenneth Russell.
This converts WebViewImpl from depending on CCLayerTreeHost to WebLayerTreeView in order to provide better
isolation and allow for future refactorings. The changes to WebViewImpl are mostly mechanical. The
WebLayerTreeView and WebLayerTreeViewClient interfaces have both grown and changed slightly:
- Setup path for WebLayerTreeView changed to expose an initialize() function instead of a create() factory
function. The new model is that a WebLayerTreeView when constructed is in a null state. Calling initialize()
attempts to re-initialize the WLTV, which can either fail or succeed. All other functions must be called on a
successfully initialized view.
- WebLayerTreeView expanded to include functionality that CCLayerTreeHost exposes but WebLayerTreeView did not.
Some of this is only valid for the single thread case and will be removed when we invert the scheduling control
logic, these bits are commented.
- WebLayerTreeViewClient expanded with some flow-control related APIs.
Refactor only, no change in behavior.
- public/platform/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::isNull):
- public/platform/WebLayerTreeViewClient.h:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::initialize):
(WebKit::WebLayerTreeView::compositorIdentifier):
(WebKit::WebLayerTreeView::setVisible):
(WebKit::WebLayerTreeView::setNeedsAnimate):
(WebKit::WebLayerTreeView::updateAnimations):
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeView::startPageScaleAnimation):
(WebKit::WebLayerTreeView::finishAllRendering):
(WebKit::WebLayerTreeView::context):
(WebKit::WebLayerTreeView::loseCompositorContext):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::loseCompositorContext):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::addPageOverlay):
(WebKit::WebViewImpl::removePageOverlay):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleCompositingLayerSync):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createContext3D):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::didRebindGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):
- src/WebViewImpl.h:
- tests/WebLayerTest.cpp:
- 6:41 PM Changeset in webkit [108882] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] Add const-ness to TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=79545
Reviewed by Noam Rosenthal.
Add const to new methods.
No new tests.
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
- platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(TextureMapperShaderProgramOpacityAndMask):
- 6:39 PM Changeset in webkit [108881] by
-
- 4 edits3 adds in trunk
XSS Auditor targeting legitimate frames as false positives.
https://bugs.webkit.org/show_bug.cgi?id=79397
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/script-tag-safe4.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::decodedSnippetForToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavascript):
(WebCore::XSSAuditor::isContainedInRequest):
(WebCore::XSSAuditor::isSameOriginResource):
- html/parser/XSSAuditor.h:
LayoutTests:
- http/tests/security/xssAuditor/resources/script-tag-safe4-frame.html: Added.
- http/tests/security/xssAuditor/script-tag-safe4-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-safe4.html: Added.
- 6:19 PM Changeset in webkit [108880] by
-
- 13 edits1 copy1 add in trunk/Source
[chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=77646
Patch by Ian Vollick <vollick@chromium.org> on 2012-02-24
Reviewed by James Robinson.
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(std):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):
(WebCore):
(WebCore::GraphicsLayerChromium::notifyAnimationStarted):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setAnimationEvent):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
(WebCore::LayerChromium::setLayerAnimationDelegate):
- platform/graphics/chromium/cc/CCAnimationEvents.cpp: Added.
(WebCore):
(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::~CCAnimationEvent):
(WebCore::CCAnimationEvent::toAnimationStartedEvent):
(WebCore::CCAnimationEvent::toAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::~CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::type):
(WebCore::CCAnimationFinishedEvent::create):
(WebCore::CCAnimationFinishedEvent::CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::~CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::type):
- platform/graphics/chromium/cc/CCAnimationEvents.h:
(WebCore):
(CCAnimationEvent):
(WebCore::CCAnimationEvent::layerId):
(CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::startTime):
(CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::animationId):
- platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:
(CCLayerAnimationControllerImpl):
- platform/graphics/chromium/cc/CCLayerAnimationDelegate.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationEvents.h.
(WebCore):
(CCLayerAnimationDelegate):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(TestHooks):
(WTF::TestHooks::notifyAnimationStarted):
(WTF::TestHooks::notifyAnimationFinished):
(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationFinished):
- 6:19 PM Changeset in webkit [108879] by
-
- 2 edits in trunk/Tools
Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
Reviewed by James Robinson.
- Scripts/webkitpy/common/config/watchlist:
- 6:01 PM Changeset in webkit [108878] by
-
- 3 edits2 adds in trunk
Regression(r107477): Crash in StaticNodeList::itemWithName.
https://bugs.webkit.org/show_bug.cgi?id=79532
Reviewed by Andreas Kling.
Source/WebCore:
Make sure that node is an element node before checking its id attribute.
Test: fast/mutation/mutation-callback-non-element-crash.html
- dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::itemWithName):
LayoutTests:
- fast/mutation/mutation-callback-non-element-crash-expected.txt: Added.
- fast/mutation/mutation-callback-non-element-crash.html: Added.
- 5:56 PM Changeset in webkit [108877] by
-
- 6 edits2 moves in trunk/Source
[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539
Reviewed by Darin Fisher.
Source/Platform:
- Platform.gypi:
- chromium/public/WebColor.h:
(WebKit):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.
(WebKit):
- public/platform/WebColorName.h:
- src/WebColor.cpp:
- 5:46 PM Changeset in webkit [108876] by
-
- 3 edits in trunk/Source/WebCore
More refactoring in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=79533
Reviewed by Ojan Vafai.
No new tests, just refactoring.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems): Move the flipping of RTL+column positions to its own method.
This might be a tiny bit slower, but it's clearer since it's not related to alignment.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Move the logical height calculation out of the loop. We only need the final height.
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- 5:31 PM Changeset in webkit [108875] by
-
- 3 edits2 adds in trunk
Positioned objects not cleared when moving children
to clone block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78416
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/multicol/span/positioned-child-not-removed-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitBlocks):
LayoutTests:
- fast/multicol/span/positioned-child-not-removed-crash-expected.txt: Added.
- fast/multicol/span/positioned-child-not-removed-crash.html: Added.
- 5:11 PM Changeset in webkit [108874] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Windows build fix. Changed "-1" to newly
created constant JSC::Yarr::offsetNoMatch added in r108858.
- platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match):
- 5:10 PM Changeset in webkit [108873] by
-
- 2 edits in trunk/Websites/webkit.org
team.html (on webkit.org) doesn't recognize codeaurora.org
https://bugs.webkit.org/show_bug.cgi?id=79529
Reviewed by Ryosuke Niwa.
- team.html:
- 4:58 PM Changeset in webkit [108872] by
-
- 25 edits in trunk
Update TextTrackCue API
https://bugs.webkit.org/show_bug.cgi?id=79368
Source/WebCore:
Change TextTrackCue.alignment to .align, TextTrackCue.linePosition and .textPosition to .line
and .position, and TextTrackCue.direction to .vertical. Change direction values "horizontal"
to "","vertical" to "rl", and "vertical-lr" to "lr".
Reviewed by Eric Seidel.
No new tests, updated existing tests for API changes.
- html/track/TextTrackCue.cpp:
(WebCore::horizontalKeyword):
(WebCore::verticalGrowingLeftKeyword):
(WebCore):
(WebCore::verticalGrowingRightKeyword):
(WebCore::verticalKeywordOLD):
(WebCore::verticallrKeywordOLD):
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::vertical):
(WebCore::TextTrackCue::setVertical):
(WebCore::TextTrackCue::setLine):
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::align):
(WebCore::TextTrackCue::setAlign):
(WebCore::TextTrackCue::parseSettings):
- html/track/TextTrackCue.h:
(TextTrackCue):
(WebCore::TextTrackCue::line):
(WebCore::TextTrackCue::position):
- html/track/TextTrackCue.idl:
LayoutTests:
Reviewed by Eric Seidel.
- media/track/track-add-remove-cue-expected.txt:
- media/track/track-add-remove-cue.html:
- media/track/track-cue-mutable-expected.txt:
- media/track/track-cue-mutable.html:
- media/track/track-webvtt-tc013-settings-expected.txt:
- media/track/track-webvtt-tc013-settings.html:
- media/track/track-webvtt-tc014-alignment-expected.txt:
- media/track/track-webvtt-tc014-alignment.html:
- media/track/track-webvtt-tc015-positioning-expected.txt:
- media/track/track-webvtt-tc015-positioning.html:
- media/track/track-webvtt-tc016-align-positioning-expected.txt:
- media/track/track-webvtt-tc016-align-positioning.html:
- media/track/track-webvtt-tc017-line-position-expected.txt:
- media/track/track-webvtt-tc017-line-position.html:
- media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
- media/track/track-webvtt-tc018-align-text-line-position.html:
- media/track/track-webvtt-tc020-cue-size-align-expected.txt:
- media/track/track-webvtt-tc020-cue-size-align.html:
- media/track/track-webvtt-tc021-valign-expected.txt:
- media/track/track-webvtt-tc021-valign.html:
- platform/mac/Skipped:
- 4:54 PM Changeset in webkit [108871] by
-
- 2 edits in trunk/Source/WebCore
Fix uninitialized variables in HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=79546
Reviewed by Dirk Pranke.
These were introduced in r108733.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):
- 4:49 PM Changeset in webkit [108870] by
-
- 4 edits6 adds in trunk
[chromium] JPEG RGB image with Adode Marker fails to turbo swizzle decode
https://bugs.webkit.org/show_bug.cgi?id=79457
Reviewed by Adam Barth.
Source/WebCore:
If a JPEG has no JFIF marker, the Adode Marker must be used to determine the image
color space for decoding via that markers transform value. Transform 0 images with
3 color components (RGB) fail to decode with libjpeg-turbo when a swizzle decoding
is active. Detect this case and decode using JCS_RGB output color space instead.
Test: fast/images/rgb-jpeg-with-abode-marker-only.html
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
LayoutTests:
- fast/images/resources/rgb-jpeg-with-adobe-marker-only.jpg: Added.
- fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
- fast/images/rgb-jpeg-with-abode-marker-only.html: Added.
- platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
- 4:45 PM Changeset in webkit [108869] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, Windows build fix. Changed signature in export to match
change made in r108858.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 4:30 PM Changeset in webkit [108868] by
-
- 3 edits in trunk/Tools
webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
https://bugs.webkit.org/show_bug.cgi?id=79258
Reviewed by Ryosuke Niwa.
Split the fuzzy matching into separate functions so that they
can be sharded and run in parallel.
Also, fix a bug in the svn_blame_regexp that was causing us
to require ChangeLog lines to have at least one space after the
author, making the code require trailing whitespace in the
changelog in some places (this was making my life harder because
I have my text editor set to strip trailing whitespace in python
files, and that was causing test_parse_log_entries_from_changelog() to fail
when the whitespace on line 275 was removed).
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_fuzzy_reviewer_matchnone):
(test_fuzzy_reviewer_match_adam_barth):
(test_fuzzy_reviewer_match_darin_adler_et_al):
(test_fuzzy_reviewer_match_dimitri_glazkov):
(test_fuzzy_reviewer_match_george_staikos):
(test_fuzzy_reviewer_match_mark_rowe):
- 4:26 PM Changeset in webkit [108867] by
-
- 8 edits3 adds in trunk
[V8] IndexedDB: IDBTransaction objects leak in Workers
https://bugs.webkit.org/show_bug.cgi?id=79308
Source/WebCore:
Use a V8RecursionScope whenever Workers call into script, so that
post-script side-effects can be executed.
Reviewed by Tony Chang.
Test: storage/indexeddb/transaction-abort-workers.html
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- bindings/v8/WorkerContextExecutionProxy.cpp: Replace custom recursion tracking.
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::runScript):
- bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):
LayoutTests:
Reviewed by Tony Chang.
- fast/js/resources/js-test-pre.js:
(startWorker): Return Worker object so onerror can be hooked.
- storage/indexeddb/resources/transaction-abort-workers.js: Added.
- storage/indexeddb/transaction-abort-workers-expected.txt: Added.
- storage/indexeddb/transaction-abort-workers.html: Added.
- 4:23 PM Changeset in webkit [108866] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG support for op_new_regexp should be enabled
https://bugs.webkit.org/show_bug.cgi?id=79538
Reviewed by Oliver Hunt.
No performance change.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- dfg/DFGCommon.h:
- 4:22 PM Changeset in webkit [108865] by
-
- 6 edits2 moves in trunk/Source
Unreviewed, rolling out r108860.
http://trac.webkit.org/changeset/108860
https://bugs.webkit.org/show_bug.cgi?id=79544
"Breaks Linux compile" (Requested by enne on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24
Source/Platform:
- Platform.gypi:
- chromium/public/WebColor.h:
(WebKit):
- chromium/public/WebColorName.h: Renamed from Source/WebKit/chromium/public/WebColorName.h.
(WebKit):
Source/WebKit/chromium:
- WebKit.gyp:
- public/platform/WebColorName.h:
- src/WebColor.cpp: Renamed from Source/WebKit/chromium/src/WebColorName.cpp.
(WebKit):
(WebKit::toCSSValueKeyword):
(WebKit::setNamedColors):
- 4:19 PM Changeset in webkit [108864] by
-
- 2 edits in trunk/Tools
webkitpy: committers_unittest fuzzy matching is really slow
https://bugs.webkit.org/show_bug.cgi?id=79179
Reviewed by Ryosuke Niwa.
Break the fuzzy matching tests into individual routines for
each contributor so that the intent is a little clearer, so
that it's easier to test individual names (and identify
duplicate tests), and so that we can eventually run
them in parallel.
Also, mark most of them as 'integration' tests so that they
can be skipped if we want to go fast (we leave a few as
regular tests for functional coverage).
- Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest):
(CommittersTest.test_contributors_by_fuzzy_match):
(CommittersTest.integration_test_contributorsnone):
(CommittersTest.integration_test_contributorsnone_2):
(CommittersTest.integration_test_contributorsnone_3):
(CommittersTest.integration_test_contributors_ada_chan):
(CommittersTest.integration_test_contributors_adele_peterson):
(CommittersTest.integration_test_contributors_alexey_proskuryakov):
(CommittersTest.integration_test_contributors_alice_liu):
(CommittersTest.integration_test_contributors_alp_toker):
(CommittersTest.integration_test_contributors_anders_carlsson):
(CommittersTest.integration_test_contributors_antti_koivisto):
(CommittersTest.integration_test_contributors_beth_dakin):
(CommittersTest.integration_test_contributors_brady_eidson):
(CommittersTest.integration_test_contributors_cameron_zwarich):
(CommittersTest.integration_test_contributors_chris_blumenberg):
(CommittersTest.integration_test_contributors_dan_bernstein):
(CommittersTest.integration_test_contributors_dan_bernstein_2):
(CommittersTest.integration_test_contributors_darin_adler):
(CommittersTest.integration_test_contributors_david_harrison):
(CommittersTest.integration_test_contributors_david_harrison_2):
(CommittersTest.integration_test_contributors_david_hyatt):
(CommittersTest.integration_test_contributors_david_kilzer):
(CommittersTest.integration_test_contributors_don_melton):
(CommittersTest.integration_test_contributors_eric_seidel):
(CommittersTest.integration_test_contributors_geoffrey_garen):
(CommittersTest.integration_test_contributors_greg_bolsinga):
(CommittersTest.integration_test_contributors_holger_freyther):
(CommittersTest.integration_test_contributors_jon_sullivan):
(CommittersTest.integration_test_contributors_jon_honeycutt):
(CommittersTest.integration_test_contributors_joseph_pecoraro):
(CommittersTest.integration_test_contributors_ken_kocienda):
(CommittersTest.integration_test_contributors_kenneth_russell):
(CommittersTest.integration_test_contributors_kevin_decker):
(CommittersTest.integration_test_contributors_kevin_mccullough):
(CommittersTest.integration_test_contributors_lars_knoll):
(CommittersTest.integration_test_contributors_lars_weintraub):
(CommittersTest.integration_test_contributors_maciej_stachowiak):
(CommittersTest.integration_test_contributors_mark_rowe):
(CommittersTest.integration_test_contributors_nikolas_zimmermann):
(CommittersTest.integration_test_contributors_oliver_hunt):
(CommittersTest.integration_test_contributors_rniwa):
(CommittersTest.disabled_integration_test_contributors_simon_fraser):
(CommittersTest.integration_test_contributors_steve_falkenburg):
(CommittersTest.integration_test_contributors_sam_weinig):
(CommittersTest.integration_test_contributors_tim_omernick):
(CommittersTest.integration_test_contributors_timothy_hatcher):
(CommittersTest.integration_test_contributors_tor_arne_vestbo):
(CommittersTest.integration_test_contributors_vicki_murley):
(CommittersTest.integration_test_contributors_zack_rusin):
- 4:17 PM Changeset in webkit [108863] by
-
- 3 edits in branches/chromium/963/Source/WebCore
Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312
Reviewed by Dimitri Glazkov.
When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp
This patch adds the check back.
Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.
We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.
The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.
- dom/EventFactory.in:
- dom/make_event_factory.pl:
(defaultItemFactory):
(generateImplementation):
TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9467023
- 4:12 PM Changeset in webkit [108862] by
-
- 3 edits in trunk/Tools
webkitpy: should autoinstall coverage
https://bugs.webkit.org/show_bug.cgi?id=79535
Reviewed by Eric Seidel.
We should automatically print the coverage report after the run, too.
- Scripts/webkitpy/test/main.py:
(Tester._run_tests):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_coverage):
- 4:03 PM Changeset in webkit [108861] by
-
- 3 edits in trunk/Source/WebCore
Limit WebGL Errors in Console to 10 per context
https://bugs.webkit.org/show_bug.cgi?id=79387
Patch by Gregg Tavares <gman@google.com> on 2012-02-24
Reviewed by Kenneth Russell.
Some apps generated enough errors to overload
the Dev Tools so limit the number of errors.
For a correct app there should never be any
errors so seeing the first few should be enough
to debug.
No new tests as no new functionality
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::printGLErrorToConsole):
(WebCore::WebGLRenderingContext::synthesizeGLError):
- html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
- 3:57 PM Changeset in webkit [108860] by
-
- 6 edits2 moves in trunk/Source
[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539
Reviewed by Darin Fisher.
Source/Platform:
- Platform.gypi:
- chromium/public/WebColor.h:
(WebKit):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.
(WebKit):
- public/platform/WebColorName.h:
- src/WebColor.cpp:
- 3:57 PM Changeset in webkit [108859] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, mark fast/files/workers tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79540
- platform/chromium/test_expectations.txt:
- 3:55 PM Changeset in webkit [108858] by
-
- 11 edits in trunk
ASSERT(position < 0) in JSC::Yarr::Interpreter::InputStream::readChecked
https://bugs.webkit.org/show_bug.cgi?id=73728
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Fixed the mixing of signed and unsigned character indeces in YARR
interpreter.
- runtime/RegExp.cpp:
(JSC::RegExp::match): Added code to check for match longer than 231 and
return no match after resetting the offsets.
- yarr/YarrInterpreter.cpp: Changed to use unsigned for all character index
handling except when matching back references.
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::isAvailableInput):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
- yarr/YarrInterpreter.h:
Source/WebCore:
No new tests, refactored usage of JSC::Yarr interpreter.
Should be covered by existing tests.
Changed WebCore callers of JSC::Yarr:Interpreter::interpret() to match the
new signature with unsigned offsets.
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findMagicComment):
- platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::match):
LayoutTests:
Updated test for change. Test is from defect.
- fast/regex/overflow-expected.txt:
- fast/regex/script-tests/overflow.js:
- 3:49 PM Changeset in webkit [108857] by
-
- 8 edits2 adds in trunk
onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714
Patch by Hans Muller <hmuller@adobe.com> on 2012-02-24
Reviewed by Dirk Schulze.
Source/WebCore:
Use FloatPoints in RenderSVGRoot::nodeAtPoint() when converting the incoming
point to local coordinates.
Test: svg/hittest/svg-small-viewbox.xhtml
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
LayoutTests:
New svg-small-viewbox test checks that elementFromPoint() works correctly with SVG
elements defined within a 1x1 viewbox.
Revised select-textLength-spacing-squeeze-2.svg to avoid a corner-case,
removed unnecessary -1 adjustment of absEndPos.x from SelectionTestCase.js.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
- platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
- svg/hittest/svg-small-viewbox-expected.txt: Added.
- svg/hittest/svg-small-viewbox.xhtml: Added.
- svg/text/resources/SelectionTestCase.js:
(selectRange):
- svg/text/select-textLength-spacing-squeeze-2.svg:
- 3:35 PM Changeset in webkit [108856] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix for builds where the DFG is disabled but the LLInt is
enabled.
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter.asm:
- 3:24 PM Changeset in webkit [108855] by
-
- 17 edits4 adds in trunk
Implement limited parsing of -webkit-grid-column and -webkit-grid-row
https://bugs.webkit.org/show_bug.cgi?id=79151
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-column-row-get-set.html
This change implements a subset of the grammar:
-webkit-grid-{row|column} := <integer> | 'auto'
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added the new files to our build systems.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition): Check that we have the right translated grammar
(this function will be more useful once we implement more of the grammar).
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Added handling for the new properties.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Allow only 'auto' or <integer>.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
grid-colum and grid-row are not inherited.
- css/CSSPropertyNames.in:
Added the 2 new properties.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.cpp: Added.
(WebCore::StyleGridItemData::StyleGridItemData):
- rendering/style/StyleGridItemData.h: Added.
(StyleGridItemData):
(WebCore::StyleGridItemData::create):
(WebCore::StyleGridItemData::copy):
(WebCore::StyleGridItemData::operator==):
(WebCore::StyleGridItemData::operator!=):
Implemented the minimum working class.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
Added StyleGridItemData to the class StyleRareNonInheritedData.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-column-row-get-set.html: Added.
- 3:18 PM Changeset in webkit [108854] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Remove expectations for nonexistent tests.
Make --lint-test-files run clean again for Chromium.
- platform/chromium/test_expectations.txt:
- 3:16 PM WebKitIDL edited by
- Fix documentation for InterfaceName (diff)
- 3:03 PM Changeset in webkit [108853] by
-
- 2 edits in trunk/Tools
Fix copypasta in build-webkit's --vibration option description
https://bugs.webkit.org/show_bug.cgi?id=79528
Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-24
Reviewed by Andreas Kling.
- Scripts/build-webkit:
- 2:57 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 2:56 PM Changeset in webkit [108852] by
-
- 12 edits in trunk
IndexedDB: IDBObjectStore.count() and IDBIndex.count() should accept key argument
https://bugs.webkit.org/show_bug.cgi?id=79422
Reviewed by Tony Chang.
Source/WebCore:
Tests: storage/indexeddb/index-count.html
storage/indexeddb/objectstore-count.html
- storage/IDBIndex.cpp:
(WebCore::IDBIndex::count):
(WebCore):
- storage/IDBIndex.h:
(WebCore::IDBIndex::count):
(IDBIndex):
- storage/IDBIndex.idl:
- storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::count):
(WebCore):
- storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::count):
(IDBObjectStore):
- storage/IDBObjectStore.idl:
LayoutTests:
- storage/indexeddb/index-count-expected.txt:
- storage/indexeddb/index-count.html:
- storage/indexeddb/objectstore-count-expected.txt:
- storage/indexeddb/objectstore-count.html:
- 2:54 PM Changeset in webkit [108851] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r108730): Webkit nightlies fails to start due to WKPreferencesGetSuppressIncrementalRendering renaming
https://bugs.webkit.org/show_bug.cgi?id=79515
Reviewed by Alexey Proskuryakov.
Some versions of Safari contain call sites to two functions in WebKit2
that were removed in r108730. Restore these two functions so that these
versions of Safari can be used with WebKit nightly builds.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSuppressIncrementalRendering):
(WKPreferencesGetSuppressIncrementalRendering):
- UIProcess/API/C/WKPreferences.h:
- 2:46 PM Changeset in webkit [108850] by
-
- 3 edits in trunk/Source/WebKit/mac
<rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
Need a WK1 Mac API to filter which subframes go into WebArchives as they are created
Reviewed by Sam Weinig (with additional comments by Adam Roben)
Add webArchiveByFilteringSubframes: which takes a callback block:
- DOM/WebDOMOperationsPrivate.h:
Add FrameFilter that adapts the block, and use it to implement the new SPI:
- DOM/WebDOMOperations.mm:
(WebFrameFilter):
(WebFrameFilter::WebFrameFilter):
(WebFrameFilter::~WebFrameFilter):
(WebFrameFilter::shouldIncludeSubframe):
(-[DOMNode webArchiveByFilteringSubframes:]):
- 2:39 PM Changeset in webkit [108849] by
-
- 5 edits1 move in trunk/Source/WebCore
Move mediastream into Modules/mediastream
https://bugs.webkit.org/show_bug.cgi?id=79517
Reviewed by Eric Seidel.
This patch moves the mediastream directory into Modules. mediastream
is a self-contained feature and is a good candidate for being a module.
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/mediastream: Copied from Source/WebCore/mediastream.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- mediastream: Removed.
- mediastream/DOMWindowMediaStream.idl: Removed.
- mediastream/LocalMediaStream.cpp: Removed.
- mediastream/LocalMediaStream.h: Removed.
- mediastream/LocalMediaStream.idl: Removed.
- mediastream/MediaStream.cpp: Removed.
- mediastream/MediaStream.h: Removed.
- mediastream/MediaStream.idl: Removed.
- mediastream/MediaStreamEvent.cpp: Removed.
- mediastream/MediaStreamEvent.h: Removed.
- mediastream/MediaStreamEvent.idl: Removed.
- mediastream/MediaStreamList.cpp: Removed.
- mediastream/MediaStreamList.h: Removed.
- mediastream/MediaStreamList.idl: Removed.
- mediastream/MediaStreamRegistry.cpp: Removed.
- mediastream/MediaStreamRegistry.h: Removed.
- mediastream/MediaStreamTrack.cpp: Removed.
- mediastream/MediaStreamTrack.h: Removed.
- mediastream/MediaStreamTrack.idl: Removed.
- mediastream/MediaStreamTrackList.cpp: Removed.
- mediastream/MediaStreamTrackList.h: Removed.
- mediastream/MediaStreamTrackList.idl: Removed.
- mediastream/NavigatorMediaStream.cpp: Removed.
- mediastream/NavigatorMediaStream.h: Removed.
- mediastream/NavigatorMediaStream.idl: Removed.
- mediastream/NavigatorUserMediaError.h: Removed.
- mediastream/NavigatorUserMediaError.idl: Removed.
- mediastream/NavigatorUserMediaErrorCallback.h: Removed.
- mediastream/NavigatorUserMediaErrorCallback.idl: Removed.
- mediastream/NavigatorUserMediaSuccessCallback.h: Removed.
- mediastream/NavigatorUserMediaSuccessCallback.idl: Removed.
- mediastream/PeerConnection.cpp: Removed.
- mediastream/PeerConnection.h: Removed.
- mediastream/PeerConnection.idl: Removed.
- mediastream/SignalingCallback.h: Removed.
- mediastream/SignalingCallback.idl: Removed.
- mediastream/UserMediaClient.h: Removed.
- mediastream/UserMediaController.cpp: Removed.
- mediastream/UserMediaController.h: Removed.
- mediastream/UserMediaRequest.cpp: Removed.
- mediastream/UserMediaRequest.h: Removed.
- 2:38 PM Changeset in webkit [108848] by
-
- 5 edits2 copies in trunk/Source
[chromium] Move WebGraphicsContext3D header into the Platform directory
https://bugs.webkit.org/show_bug.cgi?id=79301
Reviewed by Adam Barth.
Moves WebGraphicsContext3D and WebNonCopyable (which WGC3D depends on).
Source/Platform:
- Platform.gypi:
- chromium/public/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h.
(WebKit):
(WebGraphicsContext3D):
(ActiveInfo):
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):
(WebGraphicsContextLostCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsErrorMessageCallback::~WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::setParentContext):
(WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
(WebKit::WebGraphicsContext3D::setContextLostCallback):
(WebKit::WebGraphicsContext3D::setErrorMessageCallback):
(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):
(WebKit::WebGraphicsContext3D::getTranslatedShaderSourceANGLE):
(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):
(WebKit::WebGraphicsContext3D::texStorage2DEXT):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
- chromium/public/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/platform/WebNonCopyable.h.
(WebKit):
(WebNonCopyable):
(WebKit::WebNonCopyable::WebNonCopyable):
(WebKit::WebNonCopyable::~WebNonCopyable):
Source/WebKit/chromium:
- public/platform/WebGraphicsContext3D.h:
- public/platform/WebNonCopyable.h:
- 2:24 PM Changeset in webkit [108847] by
-
- 3 edits2 adds in trunk
Overhanging floats not removed from new flex box.
https://bugs.webkit.org/show_bug.cgi?id=79522
Reviewed by Ojan Vafai.
Source/WebCore:
Similar to r69476.
Test: fast/flexbox/overhanging-floats-not-removed-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
LayoutTests:
- fast/flexbox/overhanging-floats-not-removed-crash-expected.txt: Added.
- fast/flexbox/overhanging-floats-not-removed-crash.html: Added.
- 2:15 PM Changeset in webkit [108846] by
-
- 1 edit1 move in trunk/PerformanceTests
Rename dom*_*attributes.html to dom*-*attributes.html to follow the WebKit convention.
- Bindings/dom-attributes.html: Copied from PerformanceTests/Bindings/dom_attributes.html.
- Bindings/dom_attributes.html: Removed.
- 2:09 PM Changeset in webkit [108845] by
-
- 2 edits in trunk
Increment perf-o-matic version.
- Websites/webkit-perf.appspot.com/app.yaml:
- 1:40 PM Changeset in webkit [108844] by
-
- 2 edits in trunk/Tools
Adding myself to ScrollingCoordinator watchlist
https://bugs.webkit.org/show_bug.cgi?id=79525
Patch by Antonio Gomes <agomes@rim.com> on 2012-02-24
Reviewed by Rob Buis.
- Scripts/webkitpy/common/config/watchlist:
- 1:38 PM Changeset in webkit [108843] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compute more acurate font heights.
https://bugs.webkit.org/show_bug.cgi?id=79524
Reviewed by Adam Roben.
Adjust font handling as suggested by Lynn Neir to use the proper
xHeight value for the font, rather than the fall-back guess
used in the current code.
css1/text_properties/line_height.html
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit): Properly initialize a
few elements.
(WebCore::SimpleFontData::platformWidthForGlyph): Use the Cairo
cairo_scaled_font_text_extents call, rather than attempting
to compute the value from ::GetGlyphOutline.
- 1:31 PM Changeset in webkit [108842] by
-
- 15 edits in trunk/Source/JavaScriptCore
DFG should be able to handle variables getting captured
https://bugs.webkit.org/show_bug.cgi?id=79469
Reviewed by Oliver Hunt.
Made captured variables work by placing a Flush on the SetLocal and
forcing the emission of the GetLocal even if copy propagation tells us
who has the value.
Changed the CFA and various prediction codes to understand that we can't
really prove anything about captured variables. Well, we could in the
future by just looking at what side effects are happening, but in this
first cut we just assume that we can't reason about captured variables.
Also added a mode where the DFG pretends that all variables and arguments
got captured. Used this mode to harden the code.
This is performance neutral. Capturing all variables is a slow down, but
not too big of one. This seems to predict that when we add activation
support, the amount of speed benefit we'll get from increased coverage
will far outweigh the pessimism that we'll have to endure for captured
variables.
- bytecode/CodeType.h:
(JSC::codeTypeToString):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCapabilities.h:
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
- dfg/DFGCommon.h:
- dfg/DFGGraph.h:
(JSC::DFG::Graph::needsActivation):
(Graph):
(JSC::DFG::Graph::argumentIsCaptured):
(JSC::DFG::Graph::localIsCaptured):
(JSC::DFG::Graph::isCaptured):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldGenerate):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(ValueSource):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 1:10 PM Changeset in webkit [108841] by
-
- 12 edits in trunk
Should not allow malformed \x escapes
https://bugs.webkit.org/show_bug.cgi?id=79462
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- parser/Lexer.cpp:
(JSC::::parseString):
(JSC::::parseStringSlowCase):
- Prohibit malformed '\x' escapes
- tests/mozilla/ecma/Array/15.4.5.1-1.js:
- tests/mozilla/ecma/LexicalConventions/7.7.4.js:
- tests/mozilla/ecma_2/RegExp/hex-001.js:
- tests/mozilla/js1_2/regexp/hexadecimal.js:
- Remove erroneous test cases (correct behaviour is tested by LayoutTests/sputnik).
LayoutTests:
- fast/regex/script-tests/pcre-test-1.js:
- Fix bad escapes in test case.
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A4.3_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.1_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T2-expected.txt:
- Check in passing results.
- 1:08 PM Changeset in webkit [108840] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Purge Skia's GPU texture cache using GL_CHROMIUM_gpu_memory_manager
https://bugs.webkit.org/show_bug.cgi?id=78265
Patch by Michal Mocny <mmocny@google.com> on 2012-02-24
Reviewed by Stephen White.
- src/GraphicsContext3DChromium.cpp:
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):
- 1:06 PM Changeset in webkit [108839] by
-
- 10 edits in trunk/LayoutTests
Fix flaky tests by removing call to dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=79505
Reviewed by Daniel Bates.
It appears to be a race condition (on Chromium at least) between when
script executes and the style sheet resource response occurs. This
prevents some of the text to be output if the response occurs before
the call to set the flag to dump responses. Since the tests themselves
already test the results of loading stylesheets properly, this extra
text is superfluous and can be removed.
This change modifies all tests using link-load-utilities.js to dump
stylesheet resource responses. Other tests are using
dumpResponseResponseMIMEType, but for things other than stylesheets.
- fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
- fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
- fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
- fast/dom/HTMLLinkElement/link-onload-expected.txt:
- fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
- fast/dom/HTMLLinkElement/link-onload2-expected.txt:
- fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
- fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
- fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:
- 12:45 PM Changeset in webkit [108838] by
-
- 2 edits in trunk/Tools
Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/watchlist:
- 12:42 PM Changeset in webkit [108837] by
-
- 2 edits in trunk/Tools
webkitpy: config_unittest is sensitive to other tests that might've already run
https://bugs.webkit.org/show_bug.cgi?id=79382
Reviewed by Adam Barth.
If another test runs prior to config_unittest and pokes the
cached configuration, the first test in config_unittest might
fail; the tearDown() will then allow subsequent tests to pass.
Clearing the configuration prior to each test makes things
slightly slower but safer.
- Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.setUp):
- 12:36 PM Changeset in webkit [108836] by
-
- 2 edits in trunk/Tools
Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>
Reviewed by Dan Bernstein.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.
- 12:07 PM Changeset in webkit [108835] by
-
- 4 edits in trunk/LayoutTests
Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
https://bugs.webkit.org/show_bug.cgi?id=79488
Patch by Elliot Poger <epoger@google.com> on 2012-02-24
Reviewed by Adam Barth.
- fast/canvas/script-tests/canvas-strokePath-shadow.js:
(shouldBeAlmost):
- fast/js/resources/js-test-pre.js:
(shouldBeCloseTo):
- 11:41 AM Changeset in webkit [108834] by
-
- 5 edits in trunk/Source/WebCore
Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>
Reviewed by Dean Jackson.
Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.
No new tests, as the problem only occurs in a nonstandard configuration.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):
- svg/graphics/SVGImage.h:
(WebCore):
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):
- svg/graphics/SVGImageCache.h:
(SVGImageCache):
- 11:40 AM Changeset in webkit [108833] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
https://bugs.webkit.org/show_bug.cgi?id=79296
Reviewed by Kenneth Russell.
The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.
- public/platform/WebGraphicsContext3D.h:
(WebKit):
- tests/CCLayerTreeHostImplTest.cpp:
- tests/FakeWebGraphicsContext3D.h:
- 11:39 AM Changeset in webkit [108832] by
-
- 5 edits10 adds10 deletes in trunk
SVG should be supported in Dashboard compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=78322
<rdar://problem/5861278>
Reviewed by Dean Jackson.
Enable SVG elements inside Dashboard, more or less reverting r21418.
Tests: http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html
svg/custom/embedded-svg-allowed-in-dashboard.xml
svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html
svg/custom/manually-parsed-svg-allowed-in-dashboard.html
svg/custom/svg-allowed-in-dashboard-object.html
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- dom/Document.cpp:
(WebCore::Document::importNode):
- dom/make_names.pl:
(printFactoryCppFile):
Change tests that ensured that SVG didn't work in Dashboard to instead test that it does!
- http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard-expected.txt: Added.
- http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html: Renamed from LayoutTests/http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html.
- http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt: Removed.
- svg/custom/embedded-svg-allowed-in-dashboard-expected.txt: Added.
- svg/custom/embedded-svg-allowed-in-dashboard.xml: Renamed from LayoutTests/svg/custom/embedded-svg-disallowed-in-dashboard.xml.
- svg/custom/embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
- svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard-expected.txt: Added.
- svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html.
- svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
- svg/custom/manually-parsed-svg-allowed-in-dashboard-expected.txt: Added.
- svg/custom/manually-parsed-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-svg-disallowed-in-dashboard.html.
- svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.txt: Removed.
- svg/custom/svg-allowed-in-dashboard-object-expected.txt: Added.
- svg/custom/svg-allowed-in-dashboard-object.html: Renamed from LayoutTests/svg/custom/svg-disallowed-in-dashboard-object.html.
- svg/custom/svg-disallowed-in-dashboard-object-expected.txt: Removed.
- 11:35 AM Changeset in webkit [108831] by
-
- 7 edits2 adds in trunk
Expose a setting to exempt media playback from user gesture requirement after a user gesture is initiated on loading/playing a media
https://bugs.webkit.org/show_bug.cgi?id=79167
Patch by Min Qin <qinmin@google.com> on 2012-02-24
Reviewed by Adam Barth.
Source/WebCore:
Test: media/video-play-require-user-gesture.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
(WebCore):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- testing/Internals.cpp:
(WebCore::Internals::setMediaPlaybackRequiresUserGesture):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- media/video-play-require-user-gesture-expected.txt: Added.
- media/video-play-require-user-gesture.html: Added.
- 11:32 AM Changeset in webkit [108830] by
-
- 12 edits in trunk/Source/WebCore
DOMWindow*.idl should have had the same license block as DOMWindow.idl did originally
https://bugs.webkit.org/show_bug.cgi?id=79507
Reviewed by Alexey Proskuryakov.
In moving pieces of DOMWindow.idl into separate files, we mistakenly
changed some of the license blocks. All these files should have a
license block that matches the file that originally contained the code.
- Modules/intents/DOMWindowIntents.idl:
- fileapi/DOMWindowFileSystem.idl:
- html/DOMWindowHTML.idl:
- html/canvas/DOMWindowWebGL.idl:
- mediastream/DOMWindowMediaStream.idl:
- storage/DOMWindowSQLDatabase.idl:
- svg/DOMWindowSVG.idl:
- webaudio/DOMWindowWebAudio.idl:
- websockets/DOMWindowWebSocket.idl:
- workers/DOMWindowWorker.idl:
- xml/DOMWindowXML.idl:
- 11:28 AM Changeset in webkit [108829] by
-
- 14 edits11 copies in trunk/Source
[chromium] Move Web*Layer* headers into Platform
https://bugs.webkit.org/show_bug.cgi?id=79425
Reviewed by Adam Barth.
Source/Platform:
This moves the Web*Layer* headers and their dependencies from WebKit/chromium/public/platform/ into
Platform/chromium/public.
- Platform.gypi:
- chromium/public/WebCanvas.h: Copied from Source/WebKit/chromium/public/platform/WebCanvas.h.
(WebKit):
- chromium/public/WebColor.h: Copied from Source/WebKit/chromium/public/platform/WebColor.h.
(WebKit):
- chromium/public/WebColorName.h: Copied from Source/WebKit/chromium/public/platform/WebColorName.h.
(WebKit):
- chromium/public/WebContentLayer.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayer.h.
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):
- chromium/public/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayerClient.h.
(WebKit):
(WebContentLayerClient):
(WebKit::WebContentLayerClient::~WebContentLayerClient):
- chromium/public/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/platform/WebExternalTextureLayer.h.
(WebKit):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):
- chromium/public/WebLayer.h: Copied from Source/WebKit/chromium/public/platform/WebLayer.h.
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeView.h.
(WebCore):
(WebKit):
(WebLayerTreeView):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h.
(WebKit):
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):
- chromium/public/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/platform/WebPrivatePtr.h.
(WebKit):
(WebPrivatePtr):
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::~WebPrivatePtr):
(WebKit::WebPrivatePtr::isNull):
(WebKit::WebPrivatePtr::reset):
(WebKit::WebPrivatePtr::operator=):
(WebKit::WebPrivatePtr::get):
(WebKit::WebPrivatePtr::operator->):
(WebKit::WebPrivatePtr::assign):
- chromium/public/WebSolidColorLayer.h: Copied from Source/WebKit/chromium/public/platform/WebSolidColorLayer.h.
(WebKit):
(WebSolidColorLayer):
Source/WebKit/chromium:
Adds forwarding headers for Web*Layer* APIs and their dependencies. The forwarding headers for the Web*Layer*
APIs are temporary since Web*Layer* is not exposed in the client interface. The other headers (such as
WebColor) are exposed in both the client and platform APIs, so the forwarding headers are permanent, although we
might move them back down to public/ at some point.
- public/platform/WebCanvas.h:
- public/platform/WebColor.h:
- public/platform/WebColorName.h:
- public/platform/WebContentLayer.h:
- public/platform/WebContentLayerClient.h:
- public/platform/WebExternalTextureLayer.h:
- public/platform/WebLayer.h:
- public/platform/WebLayerTreeView.h:
- public/platform/WebLayerTreeViewClient.h:
- public/platform/WebPrivatePtr.h:
- public/platform/WebSolidColorLayer.h:
- 11:27 AM Changeset in webkit [108828] by
-
- 4 edits in trunk/Source
Versioning.
- 11:25 AM Changeset in webkit [108827] by
-
- 1 copy in tags/Safari-535.23
New Tag.
- 11:22 AM Changeset in webkit [108826] by
-
- 2 edits in trunk/Source/WebCore
Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>
Reviewed by Mark Rowe.
- WebCore.xcodeproj/project.pbxproj:
(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.
- 11:06 AM Changeset in webkit [108825] by
-
- 2 edits in trunk/Source/WebCore
Crash in TileCache::revalidateTiles
https://bugs.webkit.org/show_bug.cgi?id=79510
<rdar://problem/10928035>
Reviewed by Sam Weinig.
Handle the tile cache layer's PlatformCALayer going away before the
CALayer itself has been deallocated.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::revalidateTiles):
- 11:06 AM Changeset in webkit [108824] by
-
- 2 edits in trunk/Tools
Create a watchlist for ScrollingCoordinator changes
https://bugs.webkit.org/show_bug.cgi?id=79511
Reviewed by Anders Carlsson.
- Scripts/webkitpy/common/config/watchlist:
- 11:00 AM Changeset in webkit [108823] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove spurious mac-specific tests
https://bugs.webkit.org/show_bug.cgi?id=75091
Patch by Philip Rogers <pdr@google.com> on 2012-02-24
Reviewed by Daniel Bates.
- platform/mac/svg/text/text-rescale.html: Removed.
- platform/mac/svg/text/text-viewbox-rescale.html: Removed.
- 10:51 AM Changeset in webkit [108822] by
-
- 2 edits in trunk/Source/WebKit2
requestPermission callback not invoked if the WebProcess doesn't have to ask the UI Process
about the permission level.
https://bugs.webkit.org/show_bug.cgi?id=79494
Reviewed by Jon Honeycutt.
Invoke the callback in the case where the permission level is known and no message is sent
to the UI Process.
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest):
- 10:51 AM Changeset in webkit [108821] by
-
- 4 edits3 adds in trunk
[chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup.
https://bugs.webkit.org/show_bug.cgi?id=77307
Patch by Peter Collingbourne <peter@pcc.me.uk> on 2012-02-24
Reviewed by Tony Chang.
This function is currently used to build markup in order to
print the selection, and will also be used to build markup for
the clipboard. Without this change, the markup will refer to
(for example) nonexistent CSS classes and invalid relative
paths and therefore will not be interpreted correctly.
Chromium bug: http://crbug.com/23329
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectionAsMarkup):
- 10:41 AM Changeset in webkit [108820] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fix change log entry for changeset r108819; add bug URL
https://bugs.webkit.org/show_bug.cgi?id=79504
Changeset r108819 is associated with bug #79504.
- ChangeLog
- 10:37 AM Changeset in webkit [108819] by
-
- 2 edits in trunk/Source/JavaScriptCore
Substitute ENABLE(CLASSIC_INTERPRETER) for ENABLE(INTERPRETER) in Interpreter.cpp
Reviewed by Oliver Hunt.
There are a few places in Interpreter.cpp that need to be updated to use
ENABLE(CLASSIC_INTERPRETER) following the renaming of ENABLE_INTERPRETER to
ENABLE_CLASSIC_INTERPRETER in changeset <http://trac.webkit.org/changeset/108020>
(https://bugs.webkit.org/show_bug.cgi?id=78791).
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):
- 10:26 AM Changeset in webkit [108818] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/GNUmakefile.list.am
Merge GNUMakefile from trunk into branch.
- 10:04 AM Changeset in webkit [108817] by
-
- 2 edits in trunk/Source/WebCore
Don't notify the inspector of Node insertions initiated by the parser
https://bugs.webkit.org/show_bug.cgi?id=79388
Reviewed by Adam Barth.
This is part of a series of changes to make ContainerNode's
implementation simpler and more internally consistent.
I don't know of a way to break on parser-initiated insertions,
and the code already doesn't notify on parser-initiated removes
(in ContainerNode::parserRemoveChild).
No new tests, should already be covered by
inspector/debugger/dom-breakpoints.html.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAddChild):
- 9:56 AM Changeset in webkit [108816] by
-
- 10 edits in trunk/Source/WebKit2
[Qt] Signal and property cleanup in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=78820
Reviewed by Simon Hausmann.
- Remove parameters from property change notify signals: titleChanged, urlChanged, iconChanged, loadProgressChanged
- Rename the parameters of linkHovered to prevent shadoing properties of WebView
- Rename navigationStateChanged to navigationHistoryChanged
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onUrlChanged):
(QQuickWebViewPrivate::setIcon):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::loadProgress):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):
- UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):
- 9:50 AM Changeset in webkit [108815] by
-
- 30 edits3 adds in trunk/Source
[Qt] API: Unify the loading properties and signals.
https://bugs.webkit.org/show_bug.cgi?id=79486
Reviewed by Simon Hausmann.
Source/WebKit/qt:
- declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
Source/WebKit2:
- Remove the canReload signal, instead assume that calling reload in those cases won't have any effect.
- Replace loadStarted, loadSucceeded and loadFailed by a single signal: loadingChanged. The signal carries an argument with a status and error codes giving the intended context.
- Use loadingChanged as the notification signal for the property "loading" instead of navigationStateChanged.
Also update all API tests to use the new loading signals and add some utility functions
to track the loading since the new API aims to be more adapted to declarative logic
and the auto tests are using an imperative logic.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewPrivate::didChangeLoadingState):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/qwebloadrequest.cpp: Added.
(QWebLoadRequestPrivate):
(QWebLoadRequestPrivate::QWebLoadRequestPrivate):
(QWebLoadRequest::QWebLoadRequest):
(QWebLoadRequest::~QWebLoadRequest):
(QWebLoadRequest::url):
(QWebLoadRequest::status):
(QWebLoadRequest::errorString):
(QWebLoadRequest::errorDomain):
(QWebLoadRequest::errorCode):
- UIProcess/API/qt/qwebloadrequest_p.h: Added.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
- UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Added.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::scrollRequest):
- UIProcess/API/qt/tests/util.cpp:
(LoadSpy):
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
(waitForLoadSucceeded):
(waitForLoadFailed):
- UIProcess/API/qt/tests/util.h:
- UIProcess/qt/QtWebError.h:
- UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):
- UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):
- 9:26 AM Changeset in webkit [108814] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the Windows and WinCE build after changeset r108809
<http://trac.webkit.org/changeset/108809> (https://bugs.webkit.org/show_bug.cgi?id=38995)
Substitute styleLoadEventSender() for loadEventSender() in HTMLStyleElement.cpp
and substitute linkLoadEventSender() for loadEventSender() in HTMLLinkElement.cpp.
- html/HTMLLinkElement.cpp:
(WebCore::linkLoadEventSender):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents):
(WebCore::HTMLLinkElement::dispatchPendingEvent):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):
- html/HTMLStyleElement.cpp:
(WebCore::styleLoadEventSender):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents):
(WebCore::HTMLStyleElement::dispatchPendingEvent):
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):
- 9:25 AM Changeset in webkit [108813] by
-
- 2 edits in trunk/Source/JavaScriptCore
Undo the BUILDING_WTF part of r108808
This broke the build, which is obviously worse than the linker warning it was trying to
solve.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 9:21 AM Changeset in webkit [108812] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Fix Chromium Android build by building HarfBuzzShaperBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=79497
Reviewed by Tony Gentilcore.
The Chromium Android build was broken by revision r108733, as the
HarfBuzzShaperBase.cpp file also should have been included for Android.
Fix the build by including it.
- WebCore.gyp/WebCore.gyp:
- 9:02 AM Changeset in webkit [108811] by
-
- 11 edits in trunk/LayoutTests
Unreviewed, GTK SVG rebaseline (from 64-bit Release bot) and
skipping one more fast/dom/shadow test.
- platform/gtk/Skipped:
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/gtk/svg/carto.net/scrollbar-expected.txt:
- platform/gtk/svg/carto.net/window-expected.txt:
- platform/gtk/svg/custom/circle-move-invalidation-expected.txt:
- platform/gtk/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.txt:
- platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/gtk/svg/custom/use-detach-expected.txt:
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 9:02 AM Changeset in webkit [108810] by
-
- 5 edits in trunk/Source/WebCore
[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143
Reviewed by Noam Rosenthal.
Combine the two drawTexture methods into one, and extract the part that
could not be combined into its own method.
No new tests. Refactoring only.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::TextureMapperGL::drawTexture):
- platform/graphics/texmap/TextureMapperGL.h:
(WebCore):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::id):
(WebCore::BitmapTextureGL::relativeSize):
(WebCore::BitmapTextureGL::setTextureMapper):
(WebCore::BitmapTextureGL::BitmapTextureGL):
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):
- platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore):
(WebCore::TextureMapperShaderProgram::prepare):
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
- 8:50 AM Changeset in webkit [108809] by
-
- 11 edits37 adds in trunk
style element and link element for CSS stylesheet should emit load/error event when sheet loads/fails to load
https://bugs.webkit.org/show_bug.cgi?id=38995
Reviewed by Adam Barth and Nate Chapin.
Source/WebCore:
Tests: fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html
fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html
fast/dom/HTMLLinkElement/link-onerror.html
fast/dom/HTMLLinkElement/link-onload-before-page-load.html
fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html
fast/dom/HTMLLinkElement/link-onload.html
fast/dom/HTMLLinkElement/link-onload2.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html
fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html
fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html
fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html
fast/dom/HTMLStyleElement/style-onerror.html
fast/dom/HTMLStyleElement/style-onload-before-page-load.html
fast/dom/HTMLStyleElement/style-onload.html
fast/dom/HTMLStyleElement/style-onload2.html
Implements support for firing Load and Error events at HTML Link and HTML Style elements as per
the HTML5 spec. (draft 05/25/2011) section "The link element" <http://www.w3.org/TR/html5/semantics.html#the-link-element>
and "The style element" <http://www.w3.org/TR/html5/semantics.html#the-style-element>, respectively.
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): Modified to call CSSStyleSheet::notifyLoadedSheet()
after the style sheet associated with the @import rule loaded.
- css/CSSStyleSheet.cpp: Added instance variable m_didLoadErrorOccur to track whether a network error
occurred while loading any @import style sheets.
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore):
(WebCore::CSSStyleSheet::notifyLoadedSheet): Added; update m_didLoadErrorOccur to reflect if a network
error occurred while loading a style sheet associated with an @import rule.
- css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
- dom/Document.cpp:
(WebCore::Document::implicitClose): Call HTML{LinkElement, StyleElement}::dispatchPendingLoadEvents() to
ensure that all pending Load events for link and style elements are dispatched before we fire the Load
event for the window.
- dom/Node.h:
(WebCore::Node::notifyLoadedSheetAndAllCriticalSubresources): Added; as stated in its name, this method is
called once a style sheet and all its critical subresources (@imports) have loaded.
- html/HTMLLinkElement.cpp:
(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLLinkElement::parseAttribute): Register event listeners for Load and Error events regardless of whether we
built with link prefetch support.
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLLinkElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources): Added.
- html/HTMLLinkElement.h:
(WebCore):
(HTMLLinkElement):
- html/HTMLStyleElement.cpp:
(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLStyleElement::parseAttribute): Register event listeners for Load and Error events.
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLStyleElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources): Added.
- html/HTMLStyleElement.h:
(WebCore):
(HTMLStyleElement):
LayoutTests:
Add test cases to ensure we dispatch Load/Error events to HTML Link and HTML Style elements.
- fast/dom/HTMLLinkElement/link-onerror-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html: Added.
- fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html: Added.
- fast/dom/HTMLLinkElement/link-onerror.html: Added.
- fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onload-before-page-load.html: Added.
- fast/dom/HTMLLinkElement/link-onload-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html: Added.
- fast/dom/HTMLLinkElement/link-onload.html: Added.
- fast/dom/HTMLLinkElement/link-onload2-expected.txt: Added.
- fast/dom/HTMLLinkElement/link-onload2.html: Added.
- fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler-expected.txt: Added.
- fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html: Added.
- fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt: Added.
- fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html: Added.
- fast/dom/HTMLLinkElement/resources/link-load-utilities.js: Added.
(shouldComputedColorOfElementBeEqualToRGBString):
(createLinkElementWithStylesheet):
(createStyleElementWithString):
(log):
(testPassed):
(testFailed):
(testPassedAndNotifyDone):
(testFailedAndNotifyDone):
(testFinished):
- fast/dom/HTMLLinkElement/resources/stylesheet-with-existent-and-non-existent-import.css: Added.
(#test):
- fast/dom/HTMLLinkElement/resources/stylesheet-with-import.css: Added.
(#test):
- fast/dom/HTMLLinkElement/resources/stylesheet-with-non-existent-import.css: Added.
(#test):
- fast/dom/HTMLLinkElement/resources/stylesheet.css: Added.
(#test):
- fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler-expected.txt: Added.
- fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html: Added.
- fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler-expected.txt: Added.
- fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html: Added.
- fast/dom/HTMLStyleElement/style-onerror-expected.txt: Added.
- fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt: Added.
- fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html: Added.
- fast/dom/HTMLStyleElement/style-onerror.html: Added.
- fast/dom/HTMLStyleElement/style-onload-before-page-load-expected.txt: Added.
- fast/dom/HTMLStyleElement/style-onload-before-page-load.html: Added.
- fast/dom/HTMLStyleElement/style-onload-expected.txt: Added.
- fast/dom/HTMLStyleElement/style-onload.html: Added.
- fast/dom/HTMLStyleElement/style-onload2-expected.txt: Added.
- fast/dom/HTMLStyleElement/style-onload2.html: Added.
- 8:49 AM Changeset in webkit [108808] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix linker warnings on Windows
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed symbols that are already
exported via JS_EXPORTDATA.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Define BUILDING_WTF. We
aren't actually building WTF, but we are statically linking it, so we need to define this
symbol so that we export WTF's exports.
- 8:48 AM Changeset in webkit [108807] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after r108698
- page/scrolling/mac/ScrollingCoordinatorMac.mm: Added missing #import.
- 8:33 AM Changeset in webkit [108806] by
-
- 9 edits in trunk
[EFL][DRT] Implement setValueForUser and setAutofilled.
https://bugs.webkit.org/show_bug.cgi?id=79237
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-02-24
Reviewed by Andreas Kling.
Source/WebKit:
Adds the main directory of WebKit's source to find headers of JavaScriptCore.
- PlatformEfl.cmake:
Source/WebKit/efl:
Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::setAutofilled):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setValueForUser):
(LayoutTestController::setAutofilled):
LayoutTests:
Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html
- platform/efl/Skipped:
- 8:33 AM Changeset in webkit [108805] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed, rolling out r108798.
http://trac.webkit.org/changeset/108798
https://bugs.webkit.org/show_bug.cgi?id=78047
Broke too many Qt WK2 tests.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::inputMethodEvent):
(QtWebPageEventHandler::touchEvent):
- UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
- 8:33 AM Changeset in webkit [108804] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed speculative buildfix after r108785 for ENABLE(SVG) && !ENABLE(XSLT) case.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
- 8:33 AM Changeset in webkit [108803] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=79393
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.
Cleanup usage of BlackBerry::Platform in InputHandler.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::learnText):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::frameUnloaded):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::setSelection):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setComposingRegion):
(BlackBerry::WebKit::InputHandler::finishComposition):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setTextAttributes):
(BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
(BlackBerry::WebKit::InputHandler::setComposingText):
(BlackBerry::WebKit::InputHandler::commitText):
- 8:00 AM Changeset in webkit [108802] by
-
- 2 edits in trunk/Source/WebKit/chromium
Not reviewed: chromium image for inspector status bar button updated.
Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24
- src/js/Images/segmentSelectedEndChromium.png:
- 7:54 AM Changeset in webkit [108801] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- 7:54 AM Changeset in webkit [108800] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Do not show scripts panel navigator automatically more than once to the same user.
https://bugs.webkit.org/show_bug.cgi?id=79489
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
- 7:51 AM Changeset in webkit [108799] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline and skip a fast/dom/shadow test.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 7:48 AM Changeset in webkit [108798] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047
Reviewed by Kenneth Rohde Christiansen.
Replaced double-dispatch of events with direct forwarding of events from QQuickWebView::*Event to
QtWebPageEventHandler::handle*Event.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::handleInputMethodEvent):
(QtWebPageEventHandler::handleTouchEvent):
- UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
- 7:40 AM Changeset in webkit [108797] by
-
- 4 edits in trunk/Source
Fix GTK WebAudio build for WebKitGTK 1.7.90.
Patch by Priit Laes <plaes@plaes.org> on 2012-02-24
Rubber-stamped by Philippe Normand.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add Complex.h to the list of files so it
gets disted in the tarballs.
Source/WebCore:
- GNUmakefile.list.am: Add AudioBufferCallback.h and
DenormalDisabler.h to the list of files so they get disted in the
tarballs.
- 7:34 AM Changeset in webkit [108796] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
https://bugs.webkit.org/show_bug.cgi?id=79391
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.
Clean up usage of BlackBerry::Platform in SelectionHandler and
explicitly define what namespace to use for ambiguous objects like
IntRect and IntPoint.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::selectObject):
(BlackBerry::WebKit::comparePointsToReferencePoint):
(BlackBerry::WebKit::minXMinYCorner):
(BlackBerry::WebKit::maxXMinYCorner):
(BlackBerry::WebKit::minXMaxYCorner):
(BlackBerry::WebKit::maxXMaxYCorner):
(BlackBerry::WebKit::caretLocationForRect):
(BlackBerry::WebKit::caretComparisonPointForRect):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
(BlackBerry::WebKit::referencePoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
(BlackBerry::WebKit::SelectionHandler::selectionContains):
- 7:32 AM Changeset in webkit [108795] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: show all counters on one graph
https://bugs.webkit.org/show_bug.cgi?id=79484
Now it is possible to hide any counter. All graphs share the same area.
Current values are displayed above that area.
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.getDocumentCount):
(WebInspector.MemoryStatistics.getNodeCount):
(WebInspector.MemoryStatistics.getListenerCount):
(WebInspector.MemoryStatistics):
(WebInspector.SwatchCheckbox):
(WebInspector.SwatchCheckbox.prototype.get checked):
(WebInspector.SwatchCheckbox.prototype.set checked):
(WebInspector.SwatchCheckbox.prototype._toggleCheckbox):
(WebInspector.CounterUI):
(WebInspector.CounterUI.prototype._toggleCounterGraph):
(WebInspector.CounterUI.prototype.setRange):
(WebInspector.CounterUI.prototype.updateCurrentValue):
(WebInspector.CounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUI.prototype.get visible):
(WebInspector.CounterUI.prototype.saveImageUnderMarker):
(WebInspector.CounterUI.prototype.restoreImageUnderMarker):
(WebInspector.CounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawGraph):
(WebInspector.MemoryStatistics.prototype._clear):
- inspector/front-end/timelinePanel.css:
(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .swatch):
(.memory-counter-sidebar-info .title):
(.memory-counter-value):
(#counter-values-bar):
- 7:28 AM Changeset in webkit [108794] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: map Ctrl/Cmd +/- to zoom in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=79475
(In remote front-end mode, default zoom actions are working.)
Reviewed by Yury Semikhatsky.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setZoomFactor):
(WebCore):
- inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):
- inspector/front-end/Settings.js:
(WebInspector.Settings):
- inspector/front-end/inspector.js:
(WebInspector._initializeCapability):
(WebInspector._zoomIn):
(WebInspector._zoomOut):
(WebInspector._resetZoom):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector._doLoadedDoneWithCapabilities.get if):
(WebInspector.documentKeyDown):
- 7:03 AM Changeset in webkit [108793] by
-
- 3 edits in trunk/Source/WebCore
Refactor EventHandler::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=79476
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.
No new tests. No behavior change.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):
- page/EventHandler.h:
- 6:48 AM Changeset in webkit [108792] by
-
- 11 edits in trunk
[Qt] Allow to use WebCore imagedecoders
https://bugs.webkit.org/show_bug.cgi?id=32410
Source/WebCore:
Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system, WebKit will build
with WebCore's imagedecoders.
I added NO_RETURN attribute and PLATFORM(QT) conditionals to 2 functions of PNG and
JPEG decoders to avoid compiler warnings because in Qt-port we treat warning as errors (-Werror).
I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
cases when WebCore doesn't support the image format.
Reviewed by Simon Hausmann.
No behavior change, no need new tests.
- Target.pri:
- WebCore.pri:
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::getAddr):
(ImageFrame):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
NO_RETURN has been added to a function to avoid warning message.
- platform/image-decoders/png/PNGImageDecoder.cpp:
NO_RETURN has been added to a function to avoid warning message.
(WebCore):
- platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore):
(WebCore::ImageFrame::asNewNativeImage):
Tools:
Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/features.prf:
- 6:46 AM Changeset in webkit [108791] by
-
- 2 edits in trunk/Source/WebCore
[Windows, WinCairo] Handle indeterminate checkbox state
https://bugs.webkit.org/show_bug.cgi?id=79288
Patch by Lynn Neir <lynn.neir@skype.net> on 2012-02-24
Reviewed by Adam Roben.
Tested by fast/forms/indeterminate.html
- rendering/RenderThemeWin.cpp: Add code to check for indeterminate state in CheckBox.
- 6:42 AM Changeset in webkit [108790] by
-
- 3 edits in trunk/Tools
[Qt] Add Qt5 way to force 96 DPI for tests
https://bugs.webkit.org/show_bug.cgi?id=79364
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/main.cpp:
(main):
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- 6:41 AM Changeset in webkit [108789] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Use private QSGRenderNode in QQuickWebView for improved Qt Scene Graph integration
https://bugs.webkit.org/show_bug.cgi?id=79022
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-24
Reviewed by Csaba Osztrogonác.
- Target.pri:
- UIProcess/API/qt/qquickwebpage.cpp:
(PageProxyNode::PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode):
- 6:39 AM Changeset in webkit [108788] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Font related problem with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=79402
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.
Apply the descent += 1 workaround needed to produce correct metrics only for Qt 4,
because the behaviour has been corrected in Qt 5.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
- 6:37 AM Changeset in webkit [108787] by
-
- 8 edits1 add in trunk/Source/WebCore
Move XML-related APIs from DOMWindow.idl to DOMWindowXML.idl
https://bugs.webkit.org/show_bug.cgi?id=79434
Reviewed by Adam Barth.
For WebKit modularization, this patch moves XML-related APIs
from DOMWindow.idl to DOMWIndowXML.idl.
No tests. No change in behavior.
- xml/DOMWindowXML.idl: Added.
- page/DOMWindow.idl:
- CMakeLists.txt: Added "DOMWindowXML.idl".
- DerivedSources.make: Ditto.
- DerivedSources.pri: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- 6:36 AM Changeset in webkit [108786] by
-
- 8 edits in trunk/Source/WebKit/qt
[Qt] Build fix. macro "QSKIP" now only takes 1 argument on Qt5
https://bugs.webkit.org/show_bug.cgi?id=79328
Patch by Holger Hans Peter Freyther <holger@moiji-mobile.com> on 2012-02-24
Reviewed by Csaba Osztrogonác.
Introduce an alternative QSKIP that can work with both Qt4
and Qt5 without adding #ifdef to each usage site.
- tests/benchmarks/loading/tst_loading.cpp:
(tst_Loading::load):
- tests/benchmarks/painting/tst_painting.cpp:
(tst_Painting::paint):
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::elementAreaAt):
- tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setHtmlWithBaseURL):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::geolocationRequestJS):
(tst_QWebPage::loadHtml5Video):
(tst_QWebPage::screenshot):
- tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::reusePage):
- 6:31 AM Changeset in webkit [108785] by
-
- 11 edits2 adds in trunk/Source/WebCore
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Reviewed by Nikolas Zimmermann.
Support external references on <use> by introducing CachedSVGDocument.
CachedSVGDocument is a CachedResource specialized for SVGDocuments.
This CachedSVGDocument will be stored for every use element with external reference.
This first patch only contains the new classes to test whether it works on every platform.
So they aren't used anywhere and just a follow-up patch will bind them into the caching system.
No new tests - no change in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceClient.h:
(CachedResourceClient):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
- loader/cache/CachedSVGDocument.cpp: Added.
(WebCore):
(WebCore::CachedSVGDocument::CachedSVGDocument):
(WebCore::CachedSVGDocument::~CachedSVGDocument):
(WebCore::CachedSVGDocument::setEncoding):
(WebCore::CachedSVGDocument::encoding):
(WebCore::CachedSVGDocument::data):
- loader/cache/CachedSVGDocument.h: Added.
(WebCore):
(CachedSVGDocument):
(WebCore::CachedSVGDocument::document):
(WebCore::CachedSVGDocument::schedule):
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
- 6:20 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 6:16 AM Changeset in webkit [108784] by
-
- 2 edits in trunk/Source/WebCore
Little optimization in CSSParser::parseShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79356
Reviewed by Tony Chang.
Remove one loop by initializing array values at declaration time.
Also early return when the number of properties parsed are equals
with longhands count of the shorthand. It happens to be very often
the case (e.g. border). Instruments shows an improvement from 19ms
to 17ms on the time spent in this function for the css-parser-yui
benchmark.
No new tests : refactor, exisiting ones should cover.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShorthand):
- 6:09 AM Changeset in webkit [108783] by
-
- 3 edits in trunk/LayoutTests
Tests for showModalDialog need to ask for permission to open windows
https://bugs.webkit.org/show_bug.cgi?id=79465
Reviewed by Tony Gentilcore.
- fast/animation/request-animation-frame-during-modal.html:
- fast/events/scroll-event-during-modal-dialog.html:
- 6:03 AM Changeset in webkit [108782] by
-
- 1 edit3 deletes in trunk/PerformanceTests
Unreviewed, rolling out r108477.
http://trac.webkit.org/changeset/108477
https://bugs.webkit.org/show_bug.cgi?id=79209
The perf tests committed in r108748 covers the perf tests
committed in r108477. So I'll roll out r108477.
- Bindings/dom_attributes_id_getter.html: Removed.
- Bindings/dom_attributes_id_setter.html: Removed.
- Bindings/resources/dom_attributes_common.js: Removed.
- 5:50 AM Changeset in webkit [108781] by
-
- 3 edits in trunk/Source/WebCore
Move HTML-related APIs from DOMWindow.idl to DOMWindowHTML.idl
https://bugs.webkit.org/show_bug.cgi?id=79436
Reviewed by Adam Barth.
For WebKit modularization, this patch moves HTML-related APIs
from DOMWindow.idl to DOMWindowHTML.idl.
No tests. No change in behavior.
- html/DOMWindowHTML.idl:
- page/DOMWindow.idl:
- 5:41 AM Changeset in webkit [108780] by
-
- 3 edits2 adds in trunk
[v8] when a named item on document goes out of scope, actually remove it
https://bugs.webkit.org/show_bug.cgi?id=79409
Reviewed by Adam Barth.
Source/WebCore:
The original change already included the code, but it led to some
problems, so it was reverted in http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.
Test: fast/dom/HTMLDocument/named-item.html
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemRemoved):
LayoutTests:
- fast/dom/HTMLDocument/named-item-expected.txt: Added.
- fast/dom/HTMLDocument/named-item.html: Added.
- 5:38 AM Changeset in webkit [108779] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Buildfix for "Zero out CopiedBlocks on initialization".
https://bugs.webkit.org/show_bug.cgi?id=79199
Ruber stamped by Csaba Osztrogonác.
Temporary fix since the new member wastes a little space on
64 bit systems. Although it is harmless, it is only needed
for 32 bit systems.
- heap/CopiedBlock.h:
(CopiedBlock):
- 5:33 AM Changeset in webkit [108778] by
-
- 7 edits1 add in trunk/Source/WebCore
Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
https://bugs.webkit.org/show_bug.cgi?id=79442
Reviewed by Adam Barth.
For WebKit modularization, this patch moves Worker-related APIs
from DOMWindow.idl to DOMWindowWorker.idl.
No tests. No change in behavior.
- workers/DOMWindowWorker.idl: Added.
- page/DOMWindow.idl:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- 5:32 AM Changeset in webkit [108777] by
-
- 2 edits in trunk/Tools
[GTK] MiniBrowser should reload the view then the reload button is clicked
https://bugs.webkit.org/show_bug.cgi?id=79472
Reviewed by Philippe Normand.
- MiniBrowser/gtk/BrowserWindow.c:
(reloadCallback): Call webkit_web_view_reload().
(browser_window_init): Connect reload item clicked even to
reloadCallback instead of activateUriEntryCallback.
- 5:30 AM Changeset in webkit [108776] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Encode/decode Null ResourceResponse objects in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=79471
Reviewed by Philippe Normand.
- Shared/gtk/WebCoreArgumentCodersGtk.cpp:
(CoreIPC::::encode): Check whether ResourceResponse is Null before
encoding it.
(CoreIPC::::decode): Check whether response is Null and create a
Null ResourceResponse object in such case.
- 5:03 AM Changeset in webkit [108775] by
-
- 1 edit4 adds in trunk/Source/WebCore
[BlackBerry] Upstream helper classes for skia
https://bugs.webkit.org/show_bug.cgi?id=79216
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-24
Reviewed by Antonio Gomes.
Initial upstreaming, no new tests.
- platform/graphics/blackberry/skia/ImageBufferData.h: Added.
(WebCore):
(ImageBufferData):
- platform/graphics/blackberry/skia/PlatformSupport.cpp: Added.
(WebCore):
(WebCore::setFontRenderStyleDefaults):
(WebCore::PlatformSupport::getRenderStyleForStrike):
(WebCore::PlatformSupport::getFontFamilyForCharacters):
- platform/graphics/blackberry/skia/PlatformSupport.h: Added.
(WebCore):
(PlatformSupport):
(FontFamily):
- 4:39 AM Changeset in webkit [108774] by
-
- 2 edits1 add in trunk/Source/WebCore
[BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79212
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-24
Reviewed by Antonio Gomes.
Initial upstreaming, no new tests.
- PlatformBlackBerry.cmake:
- platform/graphics/blackberry/ImageBlackBerry.cpp: Added.
(WebCore):
(WebCore::Image::loadPlatformResource):
- 4:34 AM Changeset in webkit [108773] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntSize.h
https://bugs.webkit.org/show_bug.cgi?id=79430
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::IntSize and BlackBerry::Platform::IntSize.
The porting can't be built yet, no new tests.
- platform/graphics/IntSize.h:
(Platform):
(IntSize):
- 4:32 AM Changeset in webkit [108772] by
-
- 32 edits in trunk/Source
SpellCheckRequest needs to know the context where the spellcheck happened.
https://bugs.webkit.org/show_bug.cgi?id=79320
Reviewed by Hajime Morita.
Source/WebCore:
WebKit clients should be able to get the context how the spellcheck happended.
For example, WebKit clients may want to change the behavior by a spellcheck request is
invoked in typing or in pasting.
This patch added an enum in SpellCheckRequest so that WebKit clients can understand the context.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellChecker::invokeRequest):
- editing/SpellChecker.h:
(SpellCheckRequest):
(WebCore::SpellCheckRequest::textCheckingRequest):
(WebCore::SpellCheckRequest::processType):
- loader/EmptyClients.h:
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
- platform/text/TextCheckerClient.h:
(WebCore):
(TextCheckerClient):
- platform/text/TextChecking.h:
(TextCheckingRequest):
(WebCore::TextCheckingRequest::TextCheckingRequest):
(WebCore::TextCheckingRequest::setSequence):
(WebCore::TextCheckingRequest::sequence):
(WebCore::TextCheckingRequest::text):
(WebCore::TextCheckingRequest::mask):
(WebCore::TextCheckingRequest::processType):
(WebCore):
Source/WebKit/blackberry:
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
- WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
Source/WebKit/chromium:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::requestCheckingOfString):
- src/EditorClientImpl.h:
(EditorClientImpl):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::requestTextChecking):
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::requestCheckingOfString):
Source/WebKit/gtk:
- WebCoreSupport/TextCheckerClientGtk.h:
(WebKit::TextCheckerClientGtk::requestCheckingOfString):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::requestCheckingOfString):
Source/WebKit/qt:
- WebCoreSupport/TextCheckerClientQt.h:
(WebCore::TextCheckerClientQt::requestCheckingOfString):
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
(WebEditorClient):
Source/WebKit/wince:
- WebCoreSupport/EditorClientWinCE.h:
(WebKit::EditorClientWinCE::requestCheckingOfString):
Source/WebKit/wx:
- WebKitSupport/EditorClientWx.h:
(WebCore::EditorClientWx::requestCheckingOfString):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::requestCheckingOfString):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 4:09 AM Changeset in webkit [108771] by
-
- 15 edits in trunk/Source/WebKit2
[Qt] Tiling: Improve the method names dealing with moving and scaling.
Rubberstamped by Simon Hausmann.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):
(QQuickWebViewFlickablePrivate::_q_resume):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::_q_commitScaleChange):
(QQuickWebViewFlickablePrivate):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRectForScaling):
(WebKit::DrawingAreaProxy::setVisibleContentsRectForPanning):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectForScaling):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectForPanning):
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHost::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHost::setVisibleContentsRectForLayer):
- WebProcess/WebPage/LayerTreeHost.messages.in:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostQt::setVisibleContentsRectForPanning):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 4:02 AM Changeset in webkit [108770] by
-
- 3 edits in trunk/Source/WebCore
Make Node::showTreeForThis (and Node::showTreeForThisAcrossFrame) dump multiple shadow roots.
https://bugs.webkit.org/show_bug.cgi?id=79351
Reviewed by Dimitri Glazkov.
No new tests since these utility functions are only available in debug build.
I manually tested in GDB session.
- dom/Node.cpp:
(WebCore::oldestShadowRootFor):
(WebCore::traverseTreeAndMark):
(WebCore::parentOrHostOrFrameOwner):
(WebCore::showSubTreeAcrossFrame):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
(WebCore::toShadowRoot):
(WebCore):
- 3:58 AM Changeset in webkit [108769] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: follow up to inspector's r108331, using more general condition.
Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
- 3:57 AM Changeset in webkit [108768] by
-
- 7 edits1 add in trunk/Source/WebCore
Move WebGL APIs from DOMWindow.idl to DOMWindowWebGL.idl
https://bugs.webkit.org/show_bug.cgi?id=79432
Reviewed by Adam Barth.
For WebKit modularization, this patch moves WebGL-related APIs
from DOMWindow.idl to DOMWindowWebGL.idl.
No tests. No change in behavior.
- html/canvas/DOMWindowWebGL.idl: Added.
- page/DOMWindow.idl:
- DerivedSources.make: Added DOMWindowWebGL.idl.
- DerivedSources.pri: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- 3:35 AM Changeset in webkit [108767] by
-
- 3 edits in trunk
Web Inspector: [Regression] network worker tests crash on qt.
https://bugs.webkit.org/show_bug.cgi?id=79263
Reviewed by Pavel Feldman.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):
- 3:25 AM Changeset in webkit [108766] by
-
- 3 edits1 add4 deletes in trunk/LayoutTests
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=78906
Patch by Flex Mobile <rhauck@adobe.com> on 2012-02-24
Reviewed by Hajime Morita.
- fast/regions/float-pushed-width-change-expected.html: Added.
- fast/regions/float-pushed-width-change.html:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/regions/float-pushed-width-change-expected.png: Removed.
- platform/efl/fast/regions/float-pushed-width-change-expected.txt: Removed.
- platform/mac/fast/regions/float-pushed-width-change-expected.png: Removed.
- platform/mac/fast/regions/float-pushed-width-change-expected.txt: Removed.
- 3:21 AM Changeset in webkit [108765] by
-
- 6 edits in trunk/Source/WebCore
Miscellaneous CSSParser dodging in presentation attribute parsing.
<http://webkit.org/b/79468>
Reviewed by Antti Koivisto.
- Bypass CSSParser when adding constant values to attribute styles.
- Added fast paths for the valid HTMLTablePartElement align values.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForAttribute):
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForAttribute):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
- 3:01 AM Changeset in webkit [108764] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling
https://bugs.webkit.org/show_bug.cgi?id=79183
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-24
Reviewed by James Robinson.
Addresses performance issues with draw culling by avoiding the work
of mapRect and other function calls when the quad has no opaque area.
And adds a TRACE_EVENT to watch the time spent in draw culling.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
- 2:54 AM Changeset in webkit [108763] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked
https://bugs.webkit.org/show_bug.cgi?id=79318
Need to give the client a chance to decide how to handle the new window request.
Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-24
Reviewed by Rob Buis.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
- 2:40 AM Changeset in webkit [108762] by
-
- 4 edits in trunk/LayoutTests
[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239
Fix error event race at startup and cleanup event code to take
advantage of more succinct video-test.js functionality; such as
waitForEventAndFail, etc.
Since this test uses a <source> element without a 'src' tag, an error
event gets fired during load. If we don't wait until after the <body>
onload fires, we'll pickup this error we don't care about.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-02-24
Reviewed by Eric Carlson.
- http/tests/media/video-referer-expected.txt:
- http/tests/media/video-referer.html:
- platform/chromium/test_expectations.txt:
- 2:33 AM Changeset in webkit [108761] by
-
- 18 edits in trunk/LayoutTests
2012-02-24 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update layout test results after r108699.
- platform/mac/svg/carto.net/tabgroup-expected.png:
- platform/mac/svg/carto.net/tabgroup-expected.txt:
- platform/mac/svg/carto.net/window-expected.png:
- platform/mac/svg/carto.net/window-expected.txt:
- platform/mac/svg/custom/circle-move-invalidation-expected.png:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/mac/svg/custom/text-ctm-expected.png:
- platform/mac/svg/custom/text-ctm-expected.txt:
- platform/mac/svg/custom/use-detach-expected.png:
- platform/mac/svg/custom/use-detach-expected.txt:
- platform/mac/svg/hixie/perf/003-expected.png:
- platform/mac/svg/hixie/perf/003-expected.txt:
- 2:20 AM WebKitGTK/1.8.x edited by
- (diff)
- 2:19 AM Changeset in webkit [108760] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=79466
Reviewed by Philippe Normand.
Explicitly cast the observer before deleting it instead of just
deleting a generic pointer. We must to that in order to get the
destructor of the object properly called.
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
- 2:12 AM Changeset in webkit [108759] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Scripts panel navigator overlay should be shown automatically only one time.
https://bugs.webkit.org/show_bug.cgi?id=79467
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):
- 1:59 AM Changeset in webkit [108758] by
-
- 53 edits2 adds in trunk
Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878
Reviewed by Dimitri Glazkov.
Source/WebCore:
The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.
NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.
This change re-aligns the responsibility:
- Now canHaveChildren() purely declares the ability of the renderer. If the renderer is capable of having children, it return true regardless of HTML semantics.
- On the other hand, childShouldCreateRenderer() cares about the semantics. If the element doesn't allow children to be rendered, this returns false.
- Note that these decision on elements are contextual. Each element needs to know which role it is playing in the tree composition algorithm of Shadow DOM. That's why the method parameter is changed from Node* to NodeRenderingContext.
- Fixed updateFirstLetter() which relied on this confused assumption. This change introduces RenderDeprecatedFlexibleBox::buttonText() to refine the relying assumption.
With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:
- RenderButton, RenderListBox, RenderMenuList, RenderMeter, RenderProgress, RenderTextControl.
Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.
Reviewed by Dimitri Glazkov.
Tests: fast/dom/shadow/shadow-on-image-expected.html
fast/dom/shadow/shadow-on-image.html
- dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
- dom/Element.h:
(Element):
- dom/Node.h:
(WebCore::Node::childShouldCreateRenderer):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
- dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
- html/HTMLDetailsElement.h:
(HTMLDetailsElement):
- html/HTMLMediaElement.cpp:
(WebCore):
(WebCore::HTMLMediaElement::childShouldCreateRenderer):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):
- html/HTMLMeterElement.h:
(HTMLMeterElement):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::childShouldCreateRenderer):
(WebCore):
- html/HTMLProgressElement.h:
(HTMLProgressElement):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):
- html/HTMLSelectElement.h:
(HTMLSelectElement):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::childShouldCreateRenderer):
(WebCore):
- html/HTMLSummaryElement.h:
(HTMLSummaryElement):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
(WebCore):
- html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderButton.cpp:
- rendering/RenderButton.h:
(RenderButton):
- rendering/RenderDeprecatedFlexibleBox.h:
(WebCore::RenderDeprecatedFlexibleBox::buttonText):
- rendering/RenderListBox.h:
(RenderListBox):
- rendering/RenderMedia.h:
(WebCore::RenderMedia::canHaveChildren):
- rendering/RenderMenuList.h:
(RenderMenuList):
(WebCore::RenderMenuList::hasControlClip):
- rendering/RenderMeter.h:
- rendering/RenderProgress.h:
- rendering/RenderTextControl.h:
- rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::canHaveChildren):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::childShouldCreateRenderer):
- svg/SVGAElement.h:
(SVGAElement):
- svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
- svg/SVGAltGlyphElement.h:
(SVGAltGlyphElement):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::childShouldCreateRenderer):
- svg/SVGDocument.h:
(SVGDocument):
- svg/SVGElement.cpp:
(WebCore::SVGElement::childShouldCreateRenderer):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):
- svg/SVGForeignObjectElement.h:
(SVGForeignObjectElement):
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGSwitchElement.h:
(SVGSwitchElement):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::childShouldCreateRenderer):
- svg/SVGTRefElement.h:
(SVGTRefElement):
- svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::childShouldCreateRenderer):
- svg/SVGTSpanElement.h:
(SVGTSpanElement):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::childShouldCreateRenderer):
- svg/SVGTextElement.h:
(SVGTextElement):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::childShouldCreateRenderer):
- svg/SVGTextPathElement.h:
LayoutTests:
- fast/dom/shadow/shadow-on-image-expected.html: Added.
- fast/dom/shadow/shadow-on-image.html: Added.
- 1:56 AM Changeset in webkit [108757] by
-
- 13 edits in trunk/Source/WebCore
Support [Supplemental] on static methods
https://bugs.webkit.org/show_bug.cgi?id=79357
Reviewed by Adam Barth.
[Supplemental] on static methods does not work in CodeGeneratorJS.pm
and CodeGeneratorV8.pm due to mis-ordered if-elsif statements.
This patch fixes it and supports [Supplemental] on static methods.
Test: bindings/scripts/test/TestSupplemental.idl
- bindings/scripts/CodeGeneratorJS.pm: Modified as described above.
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateFunctionCallString):
- bindings/scripts/test/TestSupplemental.idl: Added a test case.
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated run-bindings-tests results.
(WebDOMTestInterface::supplementalMethod4):
- bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_supplemental_method4):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
- bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore):
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestInterfaceConstructorFunctionSupplementalMethod4):
- bindings/scripts/test/JS/JSTestInterface.h: Ditto.
(WebCore):
- bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface supplementalMethod4]):
- bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(TestInterfaceInternal):
(WebCore::TestInterfaceInternal::supplementalMethod4Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):
- 1:53 AM Changeset in webkit [108756] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Remove tests introduced in r108731 but rolled out.
- platform/qt/Skipped: Removed rolled out tests.
- 1:53 AM Changeset in webkit [108755] by
-
- 2 edits in trunk/Source/WebCore
Small refactor in RenderFlexibleBox::layoutAndPlaceChildren
https://bugs.webkit.org/show_bug.cgi?id=79420
Reviewed by Ojan Vafai.
No new tests, just a refactor.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Share some of the logic
in computing the cross axis length.
- 1:50 AM Changeset in webkit [108754] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: cannot drag timeline overview window when clicking inside the window
https://bugs.webkit.org/show_bug.cgi?id=79453
Reviewed by Pavel Feldman.
- inspector/front-end/timelinePanel.css:
(.timeline-overview-window-rulers):
- 1:49 AM Changeset in webkit [108753] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove useless jump instructions for short circuit
https://bugs.webkit.org/show_bug.cgi?id=75602
Patch by Han Hojong <hojong.han@samsung.com> on 2012-02-24
Reviewed by Michael Saboff.
Jump instruction is inserted to make short circuit,
however it does nothing but moving to the next instruction.
Therefore useless jump instructions are removed,
and jump list is moved into the case not for a short circuit,
so that only necessary instructions are added to JIT code
unless it has a 16 bit pattern character and an 8 bit string.
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
- 1:47 AM Changeset in webkit [108752] by
-
- 16 edits13 deletes in trunk
Unreviewed, rolling out r108731.
http://trac.webkit.org/changeset/108731
https://bugs.webkit.org/show_bug.cgi?id=79464
Broke Chromium Win tests (Requested by bashi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24
Source/JavaScriptCore:
- wtf/Platform.h:
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect):
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):
- websockets/WebSocketChannel.h:
- websockets/WebSocketDeflateFramer.cpp: Removed.
- websockets/WebSocketDeflateFramer.h: Removed.
LayoutTests:
- http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
- http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed.
- http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
- http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed.
- http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed.
- http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
- http/tests/websocket/tests/hybi/send-file-blob_wsh.py:
(web_socket_transfer_data):
- 1:41 AM Changeset in webkit [108751] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Show scripts panel navigator overlay on the first scripts panel opening.
https://bugs.webkit.org/show_bug.cgi?id=79248
Reviewed by Pavel Feldman.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
- 1:33 AM Changeset in webkit [108750] by
-
- 7 edits2 adds in trunk
CSS3 calc(): handle non-negative values
https://bugs.webkit.org/show_bug.cgi?id=79188
Reviewed by Daniel Bates.
Source/WebCore:
Some CSS properties (e.g. padding) are required to be non-negative. These
are now restricted to the correct range.
Tests: css3/calc/negative-padding-expected.html
css3/calc/negative-padding.html
- css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::clampToPermittedRange): Added
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcValue::isNegative): Added
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcValue::create):
- css/CSSCalculationValue.h:
(CSSCalcValue):
(WebCore::CSSCalcValue::CSSCalcValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::parseCalculation):
- css/CSSParser.h:
- platform/CalculationValue.h:
LayoutTests:
- css3/calc/negative-padding-expected.html: Added.
- css3/calc/negative-padding.html: Added.
- 1:31 AM Changeset in webkit [108749] by
-
- 4 edits in trunk
Web Inspector: [Regression] xhr tests are crashing after r108506.
https://bugs.webkit.org/show_bug.cgi?id=79265
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 12:55 AM Changeset in webkit [108748] by
-
- 4 edits1 add in trunk
Add performance tests for DOM attribute getters and setters
https://bugs.webkit.org/show_bug.cgi?id=79208
Reviewed by Ryosuke Niwa.
PerformanceTests:
This patch adds performance micro-benchmarks for DOM attribute
getters and setters. We selected DOM attributes from HTMLElement,
Element and Node which will most impact on the DOM performance
in the real Web and which have different call-paths from another
DOM attribute.
The perf test result in my local Chromium/Linux environment is as follows:
median= 14967.0 ms, stdev= 85.2385476178 ms, min= 14861.0 ms, max= 15155.0 ms
If we run the test with DumpRenderTree, we can get the following test results:
Info: [HTMLElement.id] avg=65.76ms, median=65.00ms, stdev=2.14ms, min=63, max=70
Info: [HTMLElement.title] avg=64.05ms, median=63.00ms, stdev=1.50ms, min=63, max=67
Info: [HTMLElement.lang] avg=64.19ms, median=63.00ms, stdev=1.82ms, min=62, max=67
Info: [HTMLElement.dir] avg=64.10ms, median=63.00ms, stdev=1.72ms, min=62, max=68
Info: [HTMLElement.className] avg=63.33ms, median=63.00ms, stdev=0.89ms, min=63, max=67
Info: [HTMLElement.classList] avg=1946.00ms, median=1945.00ms, stdev=38.22ms, min=1921, max=2110
Info: [HTMLElement.tabIndex] avg=83.52ms, median=80.00ms, stdev=6.00ms, min=79, max=94
Info: [HTMLElement.draggable] avg=78.14ms, median=81.00ms, stdev=3.51ms, min=74, max=82
Info: [HTMLElement.webkitdropzone] avg=64.33ms, median=63.00ms, stdev=1.98ms, min=63, max=68
Info: [HTMLElement.hidden] avg=65.57ms, median=64.00ms, stdev=3.27ms, min=63, max=71
Info: [HTMLElement.accessKey] avg=64.43ms, median=63.00ms, stdev=2.11ms, min=62, max=68
Info: [HTMLElement.children] avg=130.76ms, median=128.00ms, stdev=9.75ms, min=109, max=143
Info: [HTMLElement.isContentEditable] avg=74.29ms, median=75.00ms, stdev=2.00ms, min=71, max=77
Info: [HTMLElement.spellcheck] avg=79.52ms, median=80.00ms, stdev=2.52ms, min=76, max=82
Info: [HTMLElement.innerHTML] avg=279.05ms, median=279.00ms, stdev=1.96ms, min=276, max=283
Info: [HTMLElement.innerText] avg=204.14ms, median=203.00ms, stdev=2.95ms, min=200, max=210
Info: [HTMLElement.outerHTML] avg=1544.10ms, median=1546.00ms, stdev=15.56ms, min=1514, max=1568
Info: [HTMLElement.outerText] avg=216.05ms, median=207.00ms, stdev=18.19ms, min=201, max=247
Info: [HTMLElement.contentEditable] avg=334.24ms, median=323.00ms, stdev=36.06ms, min=318, max=446
Info: [HTMLElement.id="foo"] avg=53.19ms, median=53.00ms, stdev=1.76ms, min=52, max=58
Info: [HTMLElement.title="foo"] avg=63.14ms, median=63.00ms, stdev=0.35ms, min=63, max=64
Info: [HTMLElement.lang="foo"] avg=60.86ms, median=61.00ms, stdev=0.56ms, min=60, max=62
Info: [HTMLElement.dir="foo"] avg=53.57ms, median=54.00ms, stdev=0.58ms, min=53, max=55
Info: [HTMLElement.className="foo"] avg=64.52ms, median=64.00ms, stdev=0.91ms, min=63, max=66
Info: [HTMLElement.tabIndex="foo"] avg=367.86ms, median=369.00ms, stdev=8.06ms, min=352, max=380
Info: [HTMLElement.draggable="foo"] avg=79.43ms, median=79.00ms, stdev=0.58ms, min=79, max=81
Info: [HTMLElement.webkitdropzone="foo"] avg=62.14ms, median=62.00ms, stdev=0.35ms, min=62, max=63
Info: [HTMLElement.hidden="foo"] avg=61.67ms, median=62.00ms, stdev=0.71ms, min=61, max=64
Info: [HTMLElement.accessKey="foo"] avg=61.86ms, median=62.00ms, stdev=0.56ms, min=61, max=63
Info: [HTMLElement.spellcheck="foo"] avg=79.57ms, median=80.00ms, stdev=0.58ms, min=78, max=80
Info: [HTMLElement.innerHTML="foo"] avg=1176.67ms, median=1169.00ms, stdev=26.60ms, min=1146, max=1246
Info: [HTMLElement.innerText="foo"] avg=51.62ms, median=52.00ms, stdev=0.72ms, min=50, max=53
Info: [Element.tagName] avg=79.52ms, median=80.00ms, stdev=1.05ms, min=78, max=81
Info: [Element.style] avg=126.19ms, median=126.00ms, stdev=10.40ms, min=104, max=161
Info: [Element.offsetLeft] avg=98.95ms, median=104.00ms, stdev=4.01ms, min=100, max=99
Info: [Element.clientLeft] avg=98.33ms, median=102.00ms, stdev=2.59ms, min=100, max=99
Info: [Element.scrollLeft] avg=103.29ms, median=96.00ms, stdev=15.63ms, min=100, max=97
Info: [Element.dataset] avg=2448.62ms, median=2441.00ms, stdev=20.43ms, min=2426, max=2503
Info: [Element.firstElementChild] avg=58.71ms, median=58.00ms, stdev=2.37ms, min=57, max=65
Info: [Element.lastElementChild] avg=56.33ms, median=55.00ms, stdev=1.83ms, min=54, max=59
Info: [Element.previousElementSibling] avg=52.95ms, median=52.00ms, stdev=1.70ms, min=52, max=57
Info: [Element.nextElementSibling] avg=58.48ms, median=58.00ms, stdev=1.79ms, min=57, max=63
Info: [Element.childElementCount] avg=64.57ms, median=64.00ms, stdev=1.81ms, min=63, max=71
Info: [Element.onload] avg=98.38ms, median=98.00ms, stdev=0.49ms, min=98, max=99
Info: [Element.scrollLeft="foo"] avg=95.24ms, median=95.00ms, stdev=0.92ms, min=94, max=98
Info: [Element.onload="foo"] avg=67.14ms, median=67.00ms, stdev=0.56ms, min=66, max=68
Info: [Node.nodeName] avg=76.29ms, median=76.00ms, stdev=0.63ms, min=75, max=77
Info: [Node.nodeType] avg=53.05ms, median=52.00ms, stdev=2.61ms, min=52, max=61
Info: [Node.parentNode] avg=53.52ms, median=53.00ms, stdev=1.22ms, min=52, max=56
Info: [Node.childNodes] avg=118.33ms, median=123.00ms, stdev=8.85ms, min=107, max=129
Info: [Node.firstChild] avg=53.62ms, median=53.00ms, stdev=1.13ms, min=51, max=55
Info: [Node.lastChild] avg=53.14ms, median=53.00ms, stdev=1.21ms, min=52, max=55
Info: [Node.previousSibling] avg=51.86ms, median=51.00ms, stdev=1.55ms, min=50, max=54
Info: [Node.nextSibling] avg=52.86ms, median=54.00ms, stdev=1.81ms, min=50, max=55
Info: [Node.attributes] avg=2027.71ms, median=2026.00ms, stdev=10.48ms, min=2010, max=2051
Info: [Node.ownerDocument] avg=152.14ms, median=152.00ms, stdev=1.73ms, min=149, max=155
Info: [Node.namespaceURI] avg=60.86ms, median=59.00ms, stdev=3.85ms, min=56, max=66
Info: [Node.localName] avg=60.00ms, median=59.00ms, stdev=2.71ms, min=57, max=66
Info: [Node.baseURI] avg=671.10ms, median=668.00ms, stdev=10.66ms, min=659, max=706
Info: [Node.parentElement] avg=55.05ms, median=56.00ms, stdev=2.15ms, min=52, max=58
Info: [Node.nodeValue] avg=61.24ms, median=60.00ms, stdev=2.56ms, min=59, max=68
Info: [Node.prefix] avg=60.90ms, median=58.00ms, stdev=4.26ms, min=57, max=68
Info: [Node.textContent] avg=149.71ms, median=149.00ms, stdev=1.12ms, min=148, max=152
Info: [Node.nodeValue="foo"] avg=23.62ms, median=23.00ms, stdev=0.72ms, min=23, max=25
Info: [Node.prefix="foo"] avg=49.57ms, median=49.00ms, stdev=0.73ms, min=49, max=51
Info: [Node.textContent="foo"] avg=145.81ms, median=140.00ms, stdev=17.43ms, min=138, max=199
- Bindings/dom_attributes.html: Added.
- resources/runner.js:
(PerfTestRunner.info):
Tools:
We want to allow perf tests to output info messages
that do not affect the test results. To accomplish this,
this patch modifies perftestsrunner.py so that it ignores
a line that starts from "Info:".
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
- 12:42 AM Changeset in webkit [108747] by
-
- 4 edits in trunk
[BlackBerry] Enable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=79408
Source/JavaScriptCore:
Use timer implementation of requestAnimationFrame on BlackBerry.
Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
Reviewed by Rob Buis.
- wtf/Platform.h:
Tools:
Enable requestAnimationFrame for BlackBerry.
Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
Reviewed by Rob Buis.
- Scripts/build-webkit:
- 12:38 AM Changeset in webkit [108746] by
-
- 12 edits5 moves1 add1 delete in trunk/Source/WebCore
Rename LocalStorageThread to StorageThread and LocalStorageTask to StorageTask.
https://bugs.webkit.org/show_bug.cgi?id=79358
Revision 45124 commented FIXME to rename these classes.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-24
Reviewed by Kentaro Hara.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/LocalStorageTask.h: Removed.
- storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):
- storage/StorageSyncManager.h:
(WebCore):
(StorageSyncManager):
- storage/StorageTask.cpp: Renamed from Source/WebCore/storage/LocalStorageTask.cpp.
(WebCore):
(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::~StorageTask):
(WebCore::StorageTask::performTask):
- storage/StorageTask.h: Added.
(WebCore):
(StorageTask):
(WebCore::StorageTask::createImport):
(WebCore::StorageTask::createSync):
(WebCore::StorageTask::createDeleteEmptyDatabase):
(WebCore::StorageTask::createOriginIdentifiersImport):
(WebCore::StorageTask::createSetOriginDetails):
(WebCore::StorageTask::createDeleteOrigin):
(WebCore::StorageTask::createDeleteAllOrigins):
(WebCore::StorageTask::createTerminate):
- storage/StorageThread.cpp: Renamed from Source/WebCore/storage/LocalStorageThread.cpp.
(WebCore):
(WebCore::StorageThread::create):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::threadEntryPointCallback):
(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::scheduleTask):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):
- storage/StorageThread.h: Renamed from Source/WebCore/storage/LocalStorageThread.h.
(WebCore):
(StorageThread):
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
- storage/StorageTracker.h:
(WebCore):
(StorageTracker):
- storage/wince/StorageThreadWinCE.cpp: Renamed from Source/WebCore/storage/wince/LocalStorageThreadWinCE.cpp.
(WebCore):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::timerFired):
(WebCore::StorageThread::scheduleImport):
(WebCore::StorageThread::scheduleSync):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):
- storage/wince/StorageThreadWinCE.h: Renamed from Source/WebCore/storage/wince/LocalStorageThreadWinCE.h.
(WebCore):
(StorageThread):
(WebCore::StorageThread::create):
- 12:34 AM Changeset in webkit [108745] by
-
- 24 edits in trunk/Source/WebCore
Web Inspector: prepare border images on timelines to enable zooming.
https://bugs.webkit.org/show_bug.cgi?id=79360
Reviewed by Yury Semikhatsky.
- inspector/front-end/Images/timelineBarBlue.png:
- inspector/front-end/Images/timelineBarGray.png:
- inspector/front-end/Images/timelineBarGreen.png:
- inspector/front-end/Images/timelineBarOrange.png:
- inspector/front-end/Images/timelineBarPurple.png:
- inspector/front-end/Images/timelineBarRed.png:
- inspector/front-end/Images/timelineBarYellow.png:
- inspector/front-end/Images/timelineHollowPillBlue.png:
- inspector/front-end/Images/timelineHollowPillGray.png:
- inspector/front-end/Images/timelineHollowPillGreen.png:
- inspector/front-end/Images/timelineHollowPillOrange.png:
- inspector/front-end/Images/timelineHollowPillPurple.png:
- inspector/front-end/Images/timelineHollowPillRed.png:
- inspector/front-end/Images/timelineHollowPillYellow.png:
- inspector/front-end/Images/timelinePillBlue.png:
- inspector/front-end/Images/timelinePillGray.png:
- inspector/front-end/Images/timelinePillGreen.png:
- inspector/front-end/Images/timelinePillOrange.png:
- inspector/front-end/Images/timelinePillPurple.png:
- inspector/front-end/Images/timelinePillRed.png:
- inspector/front-end/Images/timelinePillYellow.png:
- inspector/front-end/inspectorCommon.css:
(body):
- inspector/front-end/networkLogView.css:
(.network-graph-bar):
(.resource-cached .network-graph-bar):
(.network-category-documents .network-graph-bar):
(.network-category-documents.resource-cached .network-graph-bar):
(.network-category-stylesheets .network-graph-bar):
(.network-category-stylesheets.resource-cached .network-graph-bar):
(.network-category-images.resource-cached .network-graph-bar):
(.network-category-fonts .network-graph-bar):
(.network-category-fonts.resource-cached .network-graph-bar):
(.network-category-scripts .network-graph-bar):
(.network-category-scripts.resource-cached .network-graph-bar):
(.network-category-xhr .network-graph-bar):
(.network-category-xhr.resource-cached .network-graph-bar):
(.network-category-websockets .network-graph-bar):
(.network-category-websockets.resource-cached .network-graph-bar):
- 12:33 AM Changeset in webkit [108744] by
-
- 7 edits in trunk/Tools
style-queue tries to apply the patch twice
https://bugs.webkit.org/show_bug.cgi?id=79459
Reviewed by Eric Seidel.
Previously, we applied the patch using both apply-patch and
check-style. This patch introduces a check-style-local to mirror the
apply-watchlist-local, which operates on the current working diff.
This patch also cleans up some other bugs I found by running the queue
locally for a while. The queue still prints out a slightly
less-than-ideal message on the bugs when it find an error, but it's ok
for now. We'll need to iterate a bit.
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.validate):
(StyleQueueTask._check_style):
- Scripts/webkitpy/tool/commands/download.py:
(CheckStyleLocal):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._default_expected_stderr):
(EarlyWarningSytemTest._test_testing_ews):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue.handle_script_error):
(StyleQueue.review_patch):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest.assert_queue_outputs):
- 12:28 AM Changeset in webkit [108743] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: exception in front-end on selecting an element in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=79447
Fixed a typo in method name and added a check that selected node has
corresponding heap snapshot object before adding that object to the console
as $0 entry.
Reviewed by Pavel Feldman.
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):
- 12:20 AM Changeset in webkit [108742] by
-
- 7 edits3 adds in trunk
\u200cand\u200dshould be allowed in IdentifierPart, as per ES5
https://bugs.webkit.org/show_bug.cgi?id=78908
Source/JavaScriptCore:
Add additional checks for zero-width non-joiner (0x200C) and
zero-width joiner (0x200D) characters.
Patch by Mathias Bynens <mathias@qiwi.be> on 2012-02-24
Reviewed by Michael Saboff.
- parser/Lexer.cpp:
(JSC::isNonASCIIIdentPart)
- runtime/LiteralParser.cpp:
(JSC::::Lexer::lexIdentifier)
LayoutTests:
Patch by Mathias Bynens <mathias@qiwi.be> on 2012-02-24
Reviewed by Michael Saboff.
- fast/js/var-declarations-zero-width-expected.txt: Added.
- fast/js/var-declarations-zero-width.html: Added.
- fast/js/removing-Cf-characters-expected.txt: Removed the ZWJ test.
- fast/js/script-tests/removing-Cf-characters.js: Removed the ZWJ test.
- fast/js/script-tests/var-declarations-zero-width.js: Added.
- platform/chromium/test_expectations.txt: Disable the new test in Chromium, for now.
- 12:17 AM Changeset in webkit [108741] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectation change.
svg/repaint/image-with-clip-path.svg is flaky for DEBUG builds.
- platform/chromium/test_expectations.txt:
- 12:11 AM Changeset in webkit [108740] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectation change.
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG builds.
- platform/chromium/test_expectations.txt:
- 12:00 AM Changeset in webkit [108739] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip failing tests.
Feb 23, 2012:
- 11:58 PM Changeset in webkit [108738] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectation change.
svg/text/text-rescale.html and svg/text/text-viewbox-rescale.html
are failing on Win, Linux, and Mac since added by wk r108699.
- platform/chromium/test_expectations.txt:
- 11:52 PM Changeset in webkit [108737] by
-
- 8 edits in trunk/Tools
should_proceed_with_work_item is unused and can be removed
https://bugs.webkit.org/show_bug.cgi?id=79416
Reviewed by Eric Seidel.
We used to use this function to check whether the tree is red. Now, we
don't use external measures of whether to proceed with work items.
Instead, we analyze them with the idea in mind that the tree might be
red.
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngineDelegate.next_work_item):
(QueueEngine.run):
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate):
(LoggingDelegate.next_work_item):
(RaisingDelegate.process_work_item):
(QueueEngineTest.test_terminating_error):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.init):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.next_work_item):
(FeederQueue.next_work_item):
(CommitQueue.next_work_item):
(AbstractReviewQueue.next_work_item):
(StyleQueue.init):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(FeederQueueTest.test_feeder_queue):
(CommitQueueTest.test_commit_queue):
(test_commit_queue_failure):
(test_commit_queue_failure_with_failing_tests):
(test_rollout):
(test_rollout_lands):
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):
- Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest.assert_queue_outputs):
- Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot.next_work_item):
- 11:49 PM Changeset in webkit [108736] by
-
- 17 edits16 adds in trunk/LayoutTests
[Qt] Unreviewed morning gardening.
- platform/qt/Skipped:
- platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
- platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
- platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
- platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.png:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/qt/fast/repaint/region-painting-invalidation-expected.png: Added.
- platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Added.
- platform/qt/svg/carto.net/window-expected.png:
- platform/qt/svg/carto.net/window-expected.txt:
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
- platform/qt/svg/custom/text-ctm-expected.png:
- platform/qt/svg/custom/text-ctm-expected.txt:
- platform/qt/svg/hixie/perf/003-expected.png:
- platform/qt/svg/hixie/perf/003-expected.txt:
- platform/qt/svg/text/ems-display-none-expected.png: Added.
- platform/qt/svg/text/ems-display-none-expected.txt: Added.
- platform/qt/svg/text/exs-display-none-expected.png: Added.
- platform/qt/svg/text/exs-display-none-expected.txt: Added.
- platform/qt/svg/text/text-fill-opacity-expected.png: Added.
- platform/qt/svg/text/text-fill-opacity-expected.txt: Added.
- platform/qt/svg/text/text-viewbox-rescale-expected.png: Added.
- platform/qt/svg/text/text-viewbox-rescale-expected.txt: Added.
- platform/qt/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/qt/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- 11:37 PM Changeset in webkit [108735] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: hide color picker upon panel switch.
https://bugs.webkit.org/show_bug.cgi?id=79355
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.willHide):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):
(WebInspector.StylesSidebarPane.prototype.willHide):
- 11:28 PM Changeset in webkit [108734] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: make color review larger in the color picker.
https://bugs.webkit.org/show_bug.cgi?id=79339
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.hide):
- inspector/front-end/Spectrum.js:
- inspector/front-end/elementsPanel.css:
(.spectrum-container):
(.spectrum-color):
(.spectrum-display-value):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.spectrum-slider):
(.spectrum-container .swatch):
- inspector/front-end/inspector.css:
(.swatch):
- 11:00 PM Changeset in webkit [108733] by
-
- 7 edits2 adds in trunk/Source/WebCore
[Chromium] Add HarfBuzzShaperBase class
https://bugs.webkit.org/show_bug.cgi?id=79336
Extract a part of ComplexTextControllerHarfBuzz class as
HarfBuzzShaperBase class. This patch intends to share the code between
old HarfBuzz and HarfBuzz-ng.
Reviewed by Tony Chang.
No new tests. No behavior change. Existing tests in fast/text should pass.
- PlatformBlackBerry.cmake: Added HarfBuzzShaperBase.cpp.
- WebCore.gyp/WebCore.gyp: Added HarfBuzzShaperBase.(cpp|h).
- WebCore.gypi: Ditto.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextController): Removed redundant arguments.
(WebCore::ComplexTextController::nextScriptRun): Use m_normalizedBuffer and m_normalizedBufferLength instead of m_run.
(WebCore::ComplexTextController::setupFontForScriptRun): Ditto.
(WebCore::ComplexTextController::setGlyphPositions): Ditto.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawComplexText): Removed redundant arguments of ComplexTextController constructor.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
(WebCore::Font::selectionRectForComplexText): Ditto.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Added.
(WebCore):
(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):
(WebCore::normalizeSpacesAndMirrorChars):
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
(WebCore::HarfBuzzShaperBase::isWordEnd):
(WebCore::HarfBuzzShaperBase::determineWordBreakSpacing):
(WebCore::HarfBuzzShaperBase::setPadding):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Added.
(WebCore):
(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::~HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):
- 10:34 PM Changeset in webkit [108732] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
- DEPS:
- 10:29 PM Changeset in webkit [108731] by
-
- 16 edits1 copy12 adds in trunk
Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522
Source/JavaScriptCore:
Added USE(ZLIB) flag.
Reviewed by Kent Tamura.
- wtf/Platform.h:
Source/WebCore:
Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.
This is the second patch to land. The previous patch broke Chromium Win
release build. r108600 should fix the build failure. I also added
zlib entry to |export_dependent_settings| of |webcore_prerequisites|
target.
Reviewed by Kent Tamura.
Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html
- CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.gyp/WebCore.gyp: Added zlib dependency.
- WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
- WebCore.xcodeproj/project.pbxproj: Ditto.
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect): Set m_extensions.
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.
- websockets/WebSocketChannel.h:
- websockets/WebSocketDeflateFramer.cpp: Added.
(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):
- websockets/WebSocketDeflateFramer.h: Added.
(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):
LayoutTests:
Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.
(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
- http/tests/websocket/tests/hybi/send-file-blob_wsh.py:
(_retrieve_frame):
(web_socket_transfer_data):
- 10:24 PM Changeset in webkit [108730] by
-
- 18 edits in trunk/Source
Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
https://bugs.webkit.org/show_bug.cgi?id=79433
Reviewed by Dan Bernstein.
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::visualUpdatesAllowed):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setSuppressesIncrementalRendering):
(WebCore::Settings::suppressesIncrementalRendering):
(Settings):
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setSuppressesIncrementalRendering:]):
(-[WebPreferences suppressesIncrementalRendering]):
(-[WebPreferences setSuppressIncrementalRendering:]):
(-[WebPreferences suppressIncrementalRendering]):
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesStore.h:
(WebKit):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSuppressesIncrementalRendering):
(WKPreferencesGetSuppressesIncrementalRendering):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 10:21 PM Changeset in webkit [108729] by
-
- 80 edits in trunk
Rename DOMWindow to Window in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78721
Reviewed by Adam Barth.
Source/WebCore:
Covered by existing tests.
- inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isWindow):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/atob-btoa-expected.txt:
- fast/dom/Window/atob-btoa.html:
- fast/dom/Window/window-lookup-precedence-expected.txt:
- fast/dom/Window/window-lookup-precedence.html:
- fast/dom/Window/window-postmessage-args-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/script-tests/prototype-inheritance-2.js:
(pushPropertyValuesWithUnseenTypes):
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- fast/events/device-orientation-crash-expected.txt:
- fast/events/device-orientation-crash.html:
- fast/events/event-trace-expected.txt:
- fast/events/event-view-toString-expected.txt:
- fast/events/popup-blocked-to-post-blank-expected.txt:
- fast/events/popup-blocked-to-post-blank.html:
- fast/js/eval-cross-window-expected.txt:
- fast/js/eval-keyword-vs-function-expected.txt:
- fast/js/function-bind-expected.txt:
- fast/js/mozilla/strict/10.4.3-expected.txt:
- fast/js/mozilla/strict/15.3.4.5-expected.txt:
- fast/js/mozilla/strict/this-for-function-expression-recursion-expected.txt:
- fast/js/script-tests/function-bind.js:
- fast/js/toString-and-valueOf-override-expected.txt:
- http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
- http/tests/security/cross-frame-access-custom-expected.txt:
- http/tests/security/cross-frame-access-custom.html:
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/document-all-expected.txt:
- inspector/console/console-dir-global-expected.txt:
- inspector/debugger/debugger-expand-scope-expected.txt:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):
- inspector/profiler/heap-snapshot.html:
- java/lc3/JSObject/ToJSObject-001-expected.txt:
- java/lc3/JSObject/ToObject-001-expected.txt:
- java/lc3/JSObject/ToString-001-expected.txt:
- platform/chromium-mac/fast/events/event-view-toString-expected.txt:
- platform/chromium-win/fast/events/event-view-toString-expected.txt:
- platform/chromium-win/fast/js/README:
- platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
- platform/chromium/fast/dom/wrapper-classes-expected.txt:
- platform/chromium/fast/js/mozilla/strict/15.3.4.5-expected.txt:
- platform/chromium/fast/js/toString-and-valueOf-override-expected.txt:
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
- platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
- platform/chromium/inspector/console/console-dir-global-expected.txt:
- platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
- 9:43 PM Changeset in webkit [108728] by
-
- 3 edits in trunk/Source/WebCore
NodeRenderingContext should have ShadowRootList instead of ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=79079
Reviewed by Dimitri Glazkov.
Apparently NodeRenderingContext should have ShadowRootList instead of ShadowRoot.
This patch changes it.
No new tests. Simple refactoring.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
- dom/NodeRenderingContext.h:
(WebCore):
- 9:31 PM Changeset in webkit [108727] by
-
- 15 edits3 adds in trunk/Source
[chromium] Implement keyframed animations for the cc thread.
https://bugs.webkit.org/show_bug.cgi?id=77229
Patch by Ian Vollick <vollick@chromium.org> on 2012-02-23
Reviewed by James Robinson.
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::hasActiveAnimation):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::isFinishedAt):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(WebCore::CCActiveAnimation::curve):
(CCActiveAnimation):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp: Added.
(WebCore::CCKeyframedFloatAnimationCurve::create):
(WebCore):
(WebCore::CCKeyframedFloatAnimationCurve::CCKeyframedFloatAnimationCurve):
(WebCore::CCKeyframedFloatAnimationCurve::~CCKeyframedFloatAnimationCurve):
(WebCore::CCKeyframedFloatAnimationCurve::duration):
(WebCore::CCKeyframedFloatAnimationCurve::clone):
(WebCore::CCKeyframedFloatAnimationCurve::getValue):
(WebCore::CCKeyframedTransformAnimationCurve::create):
(WebCore::CCKeyframedTransformAnimationCurve::CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::~CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::duration):
(WebCore::CCKeyframedTransformAnimationCurve::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h: Added.
(WebCore):
(WebCore::CCFloatKeyframe::CCFloatKeyframe):
(CCFloatKeyframe):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(CCTransformKeyframe):
(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::addAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(WebCore::CCLayerAnimationController::hasActiveAnimation):
(CCLayerAnimationController):
- platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCAnimationTestCommon.cpp:
(WebCore):
(WebCore::addOpacityTransition):
(WebKitTests::addOpacityTransitionToController):
(WebKitTests::addOpacityTransitionToLayer):
- tests/CCAnimationTestCommon.h:
(WebCore):
(WebKitTests):
- tests/CCKeyframedAnimationCurveTest.cpp: Added.
(WebCore):
(WebCore::expectTranslateX):
(WebCore::TEST):
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::expectTranslateX):
(WebKitTests):
(WebKitTests::TEST):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::doBeginTest):
- 9:25 PM Changeset in webkit [108726] by
-
- 2 edits in trunk/Source/WebCore
Use MathExtras round() in timeToSampleFrame
https://bugs.webkit.org/show_bug.cgi?id=79281
Patch by Raymond Toy <Raymond Toy> on 2012-02-23
Reviewed by Chris Rogers.
No new tests. Existing tests cover this change.
- platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::timeToSampleFrame): Use round().
- 9:24 PM Changeset in webkit [108725] by
-
- 6 edits1 move in trunk/LayoutTests
REGRESSION: Assertion failure in Document::setCompatibilityMode() (!m_styleSheets->length()) in fast/dynamic/crash-paint-no-documentElement-renderer.html
https://bugs.webkit.org/show_bug.cgi?id=79333
Reviewed by Sam Weinig.
Disabled the test. The assertion failure is tracked by <http://webkit.org/b/68859>.
- fast/dynamic/crash-paint-no-documentElement-renderer.html: Removed.
- fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled: Copied from LayoutTests/fast/dynamic/crash-paint-no-documentElement-renderer.html.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 8:58 PM Changeset in webkit [108724] by
-
- 5 edits5 adds in trunk
Don't clear IntentRequest callback pointers on stop()
This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.
Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638
Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Adam Barth.
- Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):
- Modules/intents/IntentRequest.h:
(IntentRequest):
- 8:40 PM Changeset in webkit [108723] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection handler has compile failure with logs enabled.
https://bugs.webkit.org/show_bug.cgi?id=79392
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-23
Reviewed by Antonio Gomes.
Build Fix. Update log to avoid usage of toString which was removed.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 8:34 PM Changeset in webkit [108722] by
-
- 2 edits13 adds in trunk
Upstream BlackBerry Cookie Management Classes
https://bugs.webkit.org/show_bug.cgi?id=73654
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-23
Reviewed by Rob Buis.
.:
Manual test to see in milliseconds how quickly 100 writes followed by 100 reads take.
This test is ran twice and the average read and write for each of the 2 runs is shown.
- ManualTests/cookieSpeedTest.html: Added.
Source/WebCore:
Added ManualTests/cookieSpeedTest.html as well as tested functionality
on the BlackBerry port with http://testsuites.opera.com/cookies/
Passes all non Cookie 2 tests since Cookie 2 is not implemented/supported at this time.
Error handling and extended tests do not all pass and will be updated with future bugs/patches.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp: Added.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h: Added.
- platform/blackberry/CookieJarBlackBerry.cpp: Added.
- platform/blackberry/CookieManager.cpp: Added.
- platform/blackberry/CookieManager.h: Added.
- platform/blackberry/CookieMap.cpp: Added.
- platform/blackberry/CookieMap.h: Added.
- platform/blackberry/CookieParser.cpp: Added.
- platform/blackberry/CookieParser.h: Added.
- platform/blackberry/ParsedCookie.cpp: Added.
- platform/blackberry/ParsedCookie.h: Added.
- 8:28 PM Changeset in webkit [108721] by
-
- 5 edits in trunk/Source/WebKit/blackberry
2012-02-19 Antonio Gomes <agomes@rim.com>
Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow)
https://bugs.webkit.org/show_bug.cgi?id=79256
PR #127814 / MKS_2587410
Reviewed by Rob Buis.
Patch adds a cleaner way for call sites of FatFingersResult to
query for the appropriated target node: shadow or non-shadow DOM nodes.
It also renames FatFingersResults::validNode to ::node, assuming
that "invalid" nodes are not applicable in any context.
- Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::clearDocumentData): (BlackBerry::WebKit::WebPagePrivate::contextNode): (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- WebKitSupport/FatFingers.h: (FatFingersResult): (BlackBerry::WebKit::FatFingersResult::node): (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
- WebKitSupport/SelectionHandler.cpp: (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- WebKitSupport/TouchEventHandler.cpp: (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent): (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 8:04 PM Changeset in webkit [108720] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test fix after r108699.
Fix wrong path of repaint.js in platform/mac/svg/text/text-rescale.html
and platform/mac/svg/text/text-viewbox-rescale.html
- platform/mac/svg/text/text-rescale.html:
- platform/mac/svg/text/text-viewbox-rescale.html:
- 7:55 PM Changeset in webkit [108719] by
-
- 8 edits in trunk/Source/WebCore
Switch drawLineForBoxSide to use integers
https://bugs.webkit.org/show_bug.cgi?id=78647
Reviewed by Eric Seidel.
drawLineForBoxSide handles painting lines for boxes which must be done on pixel boundaries.
Its interface doesn't make it possible to pixel snap properly within the function itself --
it draws one side of the box at a time, and the logical right and bottom lines can only be
properly determined using the logical top and left positions -- so it needs to be treated
like a graphics context function, whereby the caller handles the proper pixel snapping before
passing the values in.
No new tests. No change in behavior.
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRectFromEdges): convenience function for returning a pixel snapped
int rect from four LayoutUnits that are its edges (as opposed to position and size).
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Pixel snapping the column rule rect.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintOneBorderSide): Side rects are now IntRects by the time
they get to paintOneBorderSide.
(WebCore::calculateSideRect): Properly use RoundedRect as IntRects instead of LayoutRects.
(WebCore::RenderBoxModelObject::paintBorderSides): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::calculateSideRectIncludingInner): Ditto.
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine): Outline widths are related to borders and stored
as ints. Removing an unnecessary conversion to LayoutUnits. Pixel snapping the edges of the box.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide): Moving back to integers and removing an
unnecessary pixelSnappedIntRect call.
(WebCore::RenderObject::paintOutline): Pixel snapping the column rule rect and using an integer
for outlineOffset.
- rendering/RenderObject.h:
(RenderObject):
- 7:41 PM Changeset in webkit [108718] by
-
- 1 edit3 adds in trunk/Source/WebKit/blackberry
[BlackBerry] Upstream BlackBerry API web page related files
https://bugs.webkit.org/show_bug.cgi?id=74380
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-23
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- Api/WebPage.cpp: Added.
- Api/WebPage.h: Added.
- Api/WebPage_p.h: Added.
- 7:11 PM Changeset in webkit [108717] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove unused ChromeClientBlackBerry::platformCompositingWindow(), platformWindow() and WebPageClient::compositingWindow()
https://bugs.webkit.org/show_bug.cgi?id=78681
Reviewed by Antonio Gomes.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- 7:10 PM Changeset in webkit [108716] by
-
- 3 edits in trunk/Source/JavaScriptCore
Zero out CopiedBlocks on initialization
https://bugs.webkit.org/show_bug.cgi?id=79199
Reviewed by Filip Pizlo.
Made CopyBlocks zero their payloads during construction. This allows
JSArray to avoid having to manually clear its backing store upon allocation
and also alleviates any future pain with regard to the garbage collector trying
to mark what it thinks are values in what is actually uninitialized memory.
- heap/CopiedBlock.h:
(JSC::CopiedBlock::CopiedBlock):
- runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::unshiftCountSlowCase):
- 7:05 PM Changeset in webkit [108715] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntPoint.h
https://bugs.webkit.org/show_bug.cgi?id=79094
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::IntPoint and BlackBerry::Platform::IntPoint.
The porting can't be built yet, no new tests.
- platform/graphics/IntPoint.h:
(Platform):
(IntPoint):
- 7:03 PM Changeset in webkit [108714] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Add profiling trace for deferred canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=79376
Patch by Justin Novosad <junov@chromium.org> on 2012-02-23
Reviewed by Stephen White.
No new tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
Profiling trace for the entire method, as well as for
calls to canvas flush and context flush, both of which may
cause deferred operation to be executed.
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::bitmap):
Inserting a profiling trace in this method because it may cause
deferred draw commands to be executed.
- 6:37 PM Changeset in webkit [108713] by
-
- 8 edits in trunk/Source/WebCore
ShadowRootList should have recalculation flag instead of ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=79071
Reviewed by Hajime Morita.
When light children or shadow children are changed, we currently re-construct a shadow subtree.
However, when supporting multiple shadow subtrees, all shadow subtrees should be re-constructed.
So ShadowRootList should have re-construction flag instead of ShadowRoot.
Also, re-construction methods in ShadowRoot should be moved to ShadowRootList.
No new tests, should be convered by existing tests.
- dom/Element.cpp:
(WebCore::Element::recalcStyle):
(WebCore::Element::childrenChanged):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::hostChildrenChanged):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::list):
- dom/ShadowRoot.h:
(WebCore):
(ShadowRoot):
- dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::ShadowRootList):
(WebCore::ShadowRootList::reattach):
(WebCore):
(WebCore::ShadowRootList::childNeedsStyleRecalc):
(WebCore::ShadowRootList::needsStyleRecalc):
(WebCore::ShadowRootList::recalcShadowTreeStyle):
(WebCore::ShadowRootList::needsReattachHostChildrenAndShadow):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowRootList::reattachHostChildrenAndShadow):
- dom/ShadowRootList.h:
(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::clearNeedsReattachHostChildrenAndShadow):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):
- 6:20 PM Changeset in webkit [108712] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed: add clause in ASSERT missing from r108474.
No new tests. (fix)
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::willRemove):
- 6:16 PM Changeset in webkit [108711] by
-
- 1 edit2 adds in trunk/Source/WebKit/blackberry
[BlackBerry] Upstream GLES2Context.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79196
Reviewed by Rob Buis.
Initial upstream, no new tests.
- WebKitSupport/GLES2Context.cpp: Added.
- WebKitSupport/GLES2Context.h: Added.
- 6:11 PM Changeset in webkit [108710] by
-
- 8 edits1 add in trunk/Source/WebCore
Split out HTML constructors into new DOMWindowHTML suplemental idl
https://bugs.webkit.org/show_bug.cgi?id=79377
Reviewed by Adam Barth.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMWindowHTML.idl: Added.
- page/DOMWindow.idl:
- 6:04 PM Changeset in webkit [108709] by
-
- 8 edits1 add in trunk/Source/WebCore
Move SVG element constructors out of DOMWindow.idl into a new DOMWindowSVG.idl suplemental
https://bugs.webkit.org/show_bug.cgi?id=79379
Reviewed by Adam Barth.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- svg/DOMWindowSVG.idl: Added.
- 5:56 PM Changeset in webkit [108708] by
-
- 11 edits in branches/subpixellayout/Source/WebCore
Fixing the Mac build and adding a pixelSnappedBorderBoxRect. borderBoxRect should probably be deprecated...
- 5:48 PM Changeset in webkit [108707] by
-
- 2 edits in trunk/Tools
Unreviewed, add Stephen Chenney to committers.py as a contributor.
- Scripts/webkitpy/common/config/committers.py:
- 5:38 PM Changeset in webkit [108706] by
-
- 11 edits in trunk/Source/WebKit/chromium
[chromium] Clean up GraphicsContext3D initialization paths
https://bugs.webkit.org/show_bug.cgi?id=79321
Reviewed by Kenneth Russell.
This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
WebLayerTreeViewImpl.
Offscreen initialization path:
1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.
Onscreen initialization path:
1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
or WebLayerTreeViewClient, respectively
2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.
There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
within WebCore.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
- src/WebViewImpl.cpp:
(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::createContext):
(CCLayerTreeHostImplTest):
(WebKit::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
- tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
- tests/CompositorFakeGraphicsContext3D.h:
(WebCore::createCompositorMockGraphicsContext3D):
- tests/FakeGraphicsContext3DTest.cpp:
(TEST):
- 5:37 PM Changeset in webkit [108705] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
Fix QT build on branch.
- 5:33 PM Changeset in webkit [108704] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Apply bug number to svg/carto.net failures.
https://bugs.webkit.org/show_bug.cgi?id=79423
These two tests were in a set of tests that needed to be rebaselined
after a jpeg decoder change. However, there was also a text change
during this period that caused debug vs. release differences for text
spans in the SVG output. Filing a real bug so this can get looked at.
- platform/chromium/test_expectations.txt:
- 5:32 PM Changeset in webkit [108703] by
-
- 5 edits in trunk/Source
[chromium] Plumb video damage to the damage tracker.
https://bugs.webkit.org/show_bug.cgi?id=79373
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-23
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::contentChanged):
(WebCore):
- platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
Source/WebKit/chromium:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::repaint):
- 5:27 PM Changeset in webkit [108702] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
https://bugs.webkit.org/show_bug.cgi?id=79366
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-23
Reviewed by Rob Buis.
Cleanup InputHandler navigation based code.
1) Remove the concept of NavigationMode and replace it
with simple showKeyboard calls.
2) Remove navigation move events and replace with standard
key events.
3) Standardize function/variable names and remove obsolete
functions.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::nodeFocused):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::setDelayKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::processPendingKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
- WebKitSupport/InputHandler.h:
(InputHandler):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 5:25 PM Changeset in webkit [108701] by
-
- 3 edits in trunk/Tools
style-queue logs bogus messages to the QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=79424
Reviewed by Eric Seidel.
Copy/paste error.
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask._check_style):
(StyleQueueTask._apply_watch_list):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 4:54 PM Changeset in webkit [108700] by
-
- 10 edits2 adds in trunk
This test checks select attribute of content element is valid.
https://bugs.webkit.org/show_bug.cgi?id=65595
Reviewed by Dimitri Glazkov.
Source/WebCore:
This change introduces FrameTree::scopedChild() and
FrameTree::scopedChild(), which can be used for scope-aware
frame lookup. Using these, the named accessor and the indexed
acceccor on Document, and Window.length are now TreeScope
aware. They don't count iframes in Shadow DOM.
This change also removes FrameTree::m_childCount since
Frame::childCount() is no longer in the hot
path. m_scopedChildCount is added instead.
Test: fast/dom/shadow/iframe-shadow.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::length):
- page/Frame.cpp:
(WebCore::Frame::inScope):
(WebCore):
- page/Frame.h:
(WebCore):
(Frame):
- page/FrameTree.cpp:
(WebCore::FrameTree::actuallyAppendChild):
(WebCore::FrameTree::removeChild):
(WebCore::FrameTree::scopedChild):
(WebCore):
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::childCount):
- page/FrameTree.h:
(WebCore):
(FrameTree):
(WebCore::FrameTree::FrameTree):
LayoutTests:
- fast/dom/shadow/iframe-shadow-expected.txt: Added.
- fast/dom/shadow/iframe-shadow.html: Added.
- 4:52 PM Changeset in webkit [108699] by
-
- 14 edits16 adds in trunk
Recompute font metrics on scale changes
https://bugs.webkit.org/show_bug.cgi?id=75091
Patch by Philip Rogers <pdr@google.com> on 2012-02-23
Reviewed by Nikolas Zimmermann.
Source/WebCore:
SVG text metrics depend on the transform from renderer to the svg root
which requires that we propagate transform changes down to text.
This change adds a boolean for tracking transform changes to
SVGViewportContainers and SVGTransformableContainers, and updates
RenderSVGText::layout() to recalculate text metrics if the transform
of an ancestor has changed.
Tests: platform/mac/svg/text/text-rescale.html
platform/mac/svg/text/text-viewbox-rescale.html
svg/text/text-rescale.html
svg/text/text-viewbox-rescale.html
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGTransformableContainer):
(WebCore::RenderObject::isSVGViewportContainer):
- rendering/svg/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::didTransformToRootUpdate):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::layout):
- rendering/svg/RenderSVGText.h:
(WebCore::RenderSVGText::setNeedsTextMetricsUpdate):
(RenderSVGText):
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/svg/RenderSVGTransformableContainer.h:
(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::didTransformToRootUpdate):
(RenderSVGTransformableContainer):
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):
- rendering/svg/RenderSVGViewportContainer.h:
(WebCore::RenderSVGViewportContainer::didTransformToRootUpdate):
(RenderSVGViewportContainer):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::transformToRootChanged):
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren):
- rendering/svg/SVGRenderSupport.h:
(SVGRenderSupport):
LayoutTests:
- platform/chromium-linux/svg/text/text-rescale-expected.png: Added.
- platform/chromium-linux/svg/text/text-rescale-expected.txt: Added.
- platform/chromium-linux/svg/text/text-viewbox-rescale-expected.png: Added.
- platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/text/text-rescale-expected.png: Added.
- platform/mac/svg/text/text-rescale-expected.txt: Added.
- platform/mac/svg/text/text-rescale.html: Added.
- platform/mac/svg/text/text-viewbox-rescale-expected.png: Added.
- platform/mac/svg/text/text-viewbox-rescale-expected.txt: Added.
- platform/mac/svg/text/text-viewbox-rescale.html: Added.
- svg/text/text-rescale-expected.png: Added.
- svg/text/text-rescale-expected.txt: Added.
- svg/text/text-rescale.html: Added.
- svg/text/text-viewbox-rescale-expected.png: Added.
- svg/text/text-viewbox-rescale-expected.txt: Added.
- svg/text/text-viewbox-rescale.html: Added.
- 4:29 PM Changeset in webkit [108698] by
-
- 22 edits in trunk/Source
[chromium] Notify compositor of wheel event registration via ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=79133
Reviewed by Dimitri Glazkov.
Source/WebCore:
This notifies the chromium compositor of changes to the number of wheel event handlers via ScrollingCoordinator
instead of through ChromeClient/WebViewImpl. This is the path we'll use for other properties in the future and
is more extensible for handling things other than the root layer.
Property behavior is covered by new unit tests in LayerChromiumTests and CCLayerTreeHostImplTest.
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):
Add a ScrollingCoordinatorPrivate so implementations can tack on additional data without having to #ifdef up
ScrollingCoordinator.h/cpp
- page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(ScrollingCoordinatorPrivate):
ScrollingCoordinatorPrivate in the chromium implementation keeps a reference to the scroll layer.
(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::~ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setHaveWheelEventHandlers):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::haveWheelEventHandlers):
(WebCore::CCLayerImpl::setHaveWheelEventHandlers):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
Rips out old wheel event notification and adds unit tests for new LayerChromium property.
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setViewport):
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
(WebKit):
- tests/LayerChromiumTest.cpp:
- tests/WebCompositorInputHandlerImplTest.cpp:
- 4:26 PM Changeset in webkit [108697] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Re-enable a handful of tests.
These have no relation to each other, but all don't appear to be
failing anymore, so removing expectations for them.
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [108696] by
-
- 6 edits in trunk/Source/WebCore
[Qt][WK2] Clipping is broken
https://bugs.webkit.org/show_bug.cgi?id=78677
Reviewed by Simon Hausmann.
Rework the clipping stack in TextureMapperGL.
Instead of saving a stack of IntRect scissor clips, we save every clipping change in the
stack, and reapply it when we end the clip. Popping the stack is almost free, since we
don't reapply the stencil but simply change the stencil test index.
In addition, we don't use a special shader for clipping, and we don't apply clipping for
masked children, since they're already clipped because they're rendered into an intermediate
buffer.
This fixes exiting tests in LayoutTests/compositing/overflow.
It also fixes asserts in the leaves demo, as well as asserts in nytimes.com and other sites.
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- platform/graphics/texmap/TextureMapperGL.cpp:
(ClipState):
(WebCore::TextureMapperGLData::SharedGLData::ClipState::ClipState):
(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::pushClipState):
(WebCore::TextureMapperGLData::SharedGLData::popClipState):
(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
(WebCore::TextureMapperGLData::SharedGLData::applyCurrentClip):
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::TextureMapperGLData::initStencil):
(WebCore):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::initStencil):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelfAndChildren):
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
- platform/graphics/texmap/TextureMapperShaderManager.h:
- 4:18 PM Changeset in webkit [108695] by
-
- 3 edits in trunk
Add Chromium gpu_tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=79300
Patch by Dave Tu <dtu@chromium.org> on 2012-02-23
Reviewed by Ojan Vafai.
- Tools/TestResultServer/static-dashboards/builders.js:
- Tools/TestResultServer/static-dashboards/dashboard_base.js:
- 4:08 PM Changeset in webkit [108694] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Wrong signal name on emission in WebKitWindowProperties.cpp
https://bugs.webkit.org/show_bug.cgi?id=79352
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-02-23
Reviewed by Philippe Normand.
Emit the signal 'resizable' instead of 'resizable-visible'.
- UIProcess/API/gtk/WebKitWindowProperties.cpp:
(webkitWindowPropertiesSetResizable): Use right signal name.
- 4:05 PM Changeset in webkit [108693] by
-
- 5 edits in trunk/Tools
Use self._filesystem in more places in the SCM classes
https://bugs.webkit.org/show_bug.cgi?id=79415
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system):
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.find_checkout_root):
(Git.to_object_name):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.init):
(SCM.in_working_directory):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.find_uuid):
(SVN.find_checkout_root):
- 4:03 PM Changeset in webkit [108692] by
-
- 10 edits in trunk
Unreviewed, rolling out r108685.
http://trac.webkit.org/changeset/108685
https://bugs.webkit.org/show_bug.cgi?id=79414
Broke Chromium builds (Requested by enne on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
Source/WebCore:
- Target.pri:
- WebCore.pri:
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::getAddr):
(ImageFrame):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore):
- platform/image-decoders/qt/ImageFrameQt.cpp:
Tools:
- qmake/mkspecs/features/features.prf:
- 3:59 PM Changeset in webkit [108691] by
-
- 7 edits1 add in trunk/Tools
style-queue shouldn't spam bugs if it fails to update its working copy
https://bugs.webkit.org/show_bug.cgi?id=79412
Reviewed by Eric Seidel.
This patch moves style-queue over to the new PatchAnalysisTask
infrastructure, which is smarter about retrying patches when update
fails.
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_and_throw_if_fail):
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(UnableToApplyPatch):
(UnableToApplyPatch.init):
(PatchAnalysisTask.init):
- Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
(StyleQueueTaskDelegate):
(StyleQueueTaskDelegate.parent_command):
(StyleQueueTask):
(StyleQueueTask.validate):
(StyleQueueTask._check_style):
(StyleQueueTask._apply_watch_list):
(StyleQueueTask.run):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/queues.py:
(StyleQueue):
(StyleQueue.should_proceed_with_work_item):
(StyleQueue.review_patch):
(StyleQueue.run_command):
(StyleQueue.command_passed):
(StyleQueue.command_failed):
(StyleQueue.expected_failures):
(StyleQueue.refetch_patch):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):
- 3:55 PM Changeset in webkit [108690] by
-
- 3 edits2 adds in trunk
CSS2:text-decoration: <rt> element should not inherit text-decoration property
https://bugs.webkit.org/show_bug.cgi?id=71266
Patch by Koji Ishii <Koji Ishii> on 2012-02-23
Reviewed by Kentaro Hara.
Source/WebCore:
Tests: fast/ruby/text-decoration-in-descendants-ruby-expected.html
fast/ruby/text-decoration-in-descendants-ruby.html
The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
it should be included; it was confirmed at a discussion at www-style.
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
LayoutTests:
The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
it should be included; it was confirmed at a discussion at www-style.
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html
- fast/ruby/text-decoration-in-descendants-ruby-expected.html: Added.
- fast/ruby/text-decoration-in-descendants-ruby.html: Added.
- 3:54 PM Changeset in webkit [108689] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/rendering
Adding a pixelSnappedIntRect method that takes top, left, width, and height. Pixel snapping borders for tables. Fixing inconsistencies in RenderObject.cpp.
- 3:52 PM Changeset in webkit [108688] by
-
- 17 edits in branches/subpixellayout/Source
Clean up chromium and qt platform code on branch.
- 3:50 PM Changeset in webkit [108687] by
-
- 2 edits in trunk/LayoutTests
Make fast/js/script-tests/dfg-inline-function-dot-caller not timeout.
Rubber stamped by Oliver Hunt.
Verified that the test still causes inlining to happen and still passes but
otherwise reduced the loops to take an order of magnitude fewer iterations.
- fast/js/script-tests/dfg-inline-function-dot-caller.js:
(object.nonInlineable.nonInlineable.if):
(object.nonInlineable):
(makeInlinableCall):
- 3:44 PM Changeset in webkit [108686] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Mark two fast/files/ tests as non-flaky.
https://bugs.webkit.org/show_bug.cgi?id=45667
These two look like they're passing consistently, so remove
expectations.
- platform/chromium/test_expectations.txt:
- 3:37 PM Changeset in webkit [108685] by
-
- 10 edits in trunk
[Qt] Allow to use WebCore imagedecoders
https://bugs.webkit.org/show_bug.cgi?id=32410
Source/WebCore:
Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system WebKit will build
with WebCore's imagedecoders.
I added NO_RETURN attribute to 2 functions of PNG and JPEG decoders to avoid compiler warnings
because in Qt-port we treat warning as errors (-Werror).
I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
cases when WebCore doesn't support the image format.
Reviewed by Simon Hausmann.
No behavior change, no need new tests.
- Target.pri:
- WebCore.pri:
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::getAddr):
(ImageFrame):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
NO_RETURN has been added to a function to avoid warning message.
- platform/image-decoders/png/PNGImageDecoder.cpp:
NO_RETURN has been added to a function to avoid warning message.
(WebCore):
- platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore):
(WebCore::ImageFrame::asNewNativeImage):
Tools:
Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/features.prf:
- 3:26 PM Changeset in webkit [108684] by
-
- 2 edits1 add in trunk/Tools
Remove old broken find_checkout_root tests now that find_checkout_root is gone
https://bugs.webkit.org/show_bug.cgi?id=79405
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
(SCMDetectorTest):
(SCMDetectorTest.test_find_checkout_root):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SVNTestRepository.tear_down):
- 3:20 PM Changeset in webkit [108683] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Mark a media-fragments test as slow.
https://bugs.webkit.org/show_bug.cgi?id=77523
This has been periodically timing out on Win, so give it more time.
- platform/chromium/test_expectations.txt:
- 3:20 PM Changeset in webkit [108682] by
-
- 3 edits1 add in trunk/Tools
[Qt][WK2] Implement proxy authentication dialog.
https://bugs.webkit.org/show_bug.cgi?id=79350
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-23
Reviewed by Simon Hausmann.
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/qml/BrowserWindow.qml:
- MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
- 3:18 PM Changeset in webkit [108681] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make Interpreter::getStackTrace be able to generate the line number for the top callframe if none is provided
https://bugs.webkit.org/show_bug.cgi?id=79407
Reviewed by Gavin Barraclough.
Outside of exception handling, we don't know what our source line number is. This
change allows us to pass -1 is as the initial line number, and get the correct line
number in the resultant stack trace. We can't completely elide the initial line
number (yet) due to some idiosyncrasies of the exception handling machinery.
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC):
(JSC::Interpreter::getStackTrace):
- 3:13 PM Changeset in webkit [108680] by
-
- 4 edits1 add in trunk/LayoutTests
[chromium] New baselines for CSS3 filters drop-shadow() tests.
Unreviewed gardening.
- platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png: Added.
- platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium/test_expectations.txt:
- 3:12 PM Changeset in webkit [108679] by
-
- 10 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r108666.
http://trac.webkit.org/changeset/108666
https://bugs.webkit.org/show_bug.cgi?id=79321
Breaks webplugin tests: http://goo.gl/CoHIi
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DPrivate.h:
(WebKit):
(GraphicsContext3DPrivate):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
- src/WebViewImpl.cpp:
(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
- tests/CCLayerTreeHostImplTest.cpp:
(CCLayerTreeHostImplTest):
(WebKit::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
- tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
- tests/CompositorFakeGraphicsContext3D.h:
(WebCore::createCompositorMockGraphicsContext3D):
- tests/FakeGraphicsContext3DTest.cpp:
(TEST):
- 3:03 PM Changeset in webkit [108678] by
-
- 4 edits1 delete in trunk/Source/WebCore
[chromium] Push CCLayerIteratorPosition struct into CCLayerIterator class.
https://bugs.webkit.org/show_bug.cgi?id=75864
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-23
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCLayerIterator.cpp:
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
- platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::targetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):
- platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
- 2:51 PM Changeset in webkit [108677] by
-
- 22 edits4 adds1 delete in trunk/Source/JavaScriptCore
DFG OSR exit value profiling should have graceful handling of local variables and arguments
https://bugs.webkit.org/show_bug.cgi?id=79310
Reviewed by Gavin Barraclough.
Previously, if we OSR exited because a prediction in a local was wrong, we'd
only realize what the true type of the local was if the regular value profiling
kicked in and told us. Unless the local was block-locally copy propagated, in
which case we'd know from an OSR exit profile.
This patch adds OSR exit profiling to all locals and arguments. Now, if we OSR
exit because of a mispredicted local or argument type, we'll know what the type of
the local or argument should be immediately upon exiting.
The way that local variable OSR exit profiling works is that we now have a lazily
added set of OSR-exit-only value profiles for exit sites that are BadType and that
cited a GetLocal as their value source. The value profiles are only added if the
OSR exit is taken, and are keyed by CodeBlock, bytecode index of the GetLocal, and
operand. The look-up is performed by querying the
CompressedLazyOperandValueProfileHolder in the CodeBlock, using a key that contains
the bytecode index and the operand. Because the value profiles are added at random
times, they are not sorted; instead they are just stored in an arbitrarily-ordered
SegmentedVector. Look-ups are made fast by "decompressing": the DFG::ByteCodeParser
creates a LazyOperandValueProfileParser, which turns the
CompressedLazyOperandValueProfileHolder's contents into a HashMap for the duration
of DFG parsing.
Previously, OSR exits had a pointer to the ValueProfile that had the specFailBucket
into which values observed during OSR exit would be placed. Now it uses a lazy
thunk for a ValueProfile. I call this the MethodOfGettingAValueProfile. It may
either contain a ValueProfile inside it (which works for previous uses of OSR exit
profiling) or it may just have knowledge of how to go about creating the
LazyOperandValueProfile in the case that the OSR exit is actually taken. This
ensures that we never have to create NumOperands*NumBytecodeIndices*NumCodeBlocks
value profiling buckets unless we actually did OSR exit on every single operand,
in every single instruction, in each code block (that's probably unlikely).
This appears to be neutral on the major benchmarks, but is a double-digit speed-up
on code deliberately written to have data flow that spans basic blocks and where
the code exhibits post-optimization polymorphism in a local variable.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::lazyOperandValueProfiles):
- bytecode/LazyOperandValueProfile.cpp: Added.
(JSC):
(JSC::CompressedLazyOperandValueProfileHolder::CompressedLazyOperandValueProfileHolder):
(JSC::CompressedLazyOperandValueProfileHolder::~CompressedLazyOperandValueProfileHolder):
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::CompressedLazyOperandValueProfileHolder::add):
(JSC::LazyOperandValueProfileParser::LazyOperandValueProfileParser):
(JSC::LazyOperandValueProfileParser::~LazyOperandValueProfileParser):
(JSC::LazyOperandValueProfileParser::getIfPresent):
(JSC::LazyOperandValueProfileParser::prediction):
- bytecode/LazyOperandValueProfile.h: Added.
(JSC):
(LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::operator!):
(JSC::LazyOperandValueProfileKey::operator==):
(JSC::LazyOperandValueProfileKey::hash):
(JSC::LazyOperandValueProfileKey::bytecodeOffset):
(JSC::LazyOperandValueProfileKey::operand):
(JSC::LazyOperandValueProfileKey::isHashTableDeletedValue):
(JSC::LazyOperandValueProfileKeyHash::hash):
(JSC::LazyOperandValueProfileKeyHash::equal):
(LazyOperandValueProfileKeyHash):
(WTF):
(JSC::LazyOperandValueProfile::LazyOperandValueProfile):
(LazyOperandValueProfile):
(JSC::LazyOperandValueProfile::key):
(CompressedLazyOperandValueProfileHolder):
(LazyOperandValueProfileParser):
- bytecode/MethodOfGettingAValueProfile.cpp: Added.
(JSC):
(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
- bytecode/MethodOfGettingAValueProfile.h: Added.
(JSC):
(MethodOfGettingAValueProfile):
(JSC::MethodOfGettingAValueProfile::MethodOfGettingAValueProfile):
(JSC::MethodOfGettingAValueProfile::operator!):
- bytecode/ValueProfile.cpp: Removed.
- bytecode/ValueProfile.h:
(JSC):
(ValueProfileBase):
(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(JSC::MinimalValueProfile::MinimalValueProfile):
(ValueProfileWithLogNumberOfBuckets):
(JSC::ValueProfileWithLogNumberOfBuckets::ValueProfileWithLogNumberOfBuckets):
(JSC::ValueProfile::ValueProfile):
(JSC::getValueProfileBytecodeOffset):
(JSC::getRareCaseProfileBytecodeOffset):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(DFG):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(Graph):
- dfg/DFGNode.h:
(Node):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::nonUnifiedPrediction):
(VariableAccessData):
- 2:41 PM Changeset in webkit [108676] by
-
- 2 edits in trunk/Source/WebKit2
Flush layer changes after layout when resizing web page
https://bugs.webkit.org/show_bug.cgi?id=79399
<rdar://problem/10920157>
Reviewed by Andreas Kling.
Flush layer changes after layout, otherwise the scrollbars won't be updated
until sometime later which looks bad.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
- 2:10 PM Changeset in webkit [108675] by
-
- 20 edits1 copy in trunk/Source
[Chromium] Add video stream texture support
https://bugs.webkit.org/show_bug.cgi?id=78398
This upstreams the abstraction used on Android for
hardware video decoding with the compositor.
Most of the interfaces are kept generic and the core
of this change is to allow texturing from an external
texture while receiving notifications (on the compositor
thread if we are running it) when there are new frames to
be displayed.
Patch by Daniel Sievers <sievers@chromium.org> on 2012-02-23
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/Extensions3DChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawSingleTextureVideoQuad):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture):
(WebCore):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
(WebCore::LayerRendererChromium::streamTextureLayerProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderVideoTransform::VertexShaderVideoTransform):
(WebCore):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::VertexShaderVideoTransform::getShaderString):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderOESImageExternal::getShaderString):
- platform/graphics/chromium/ShaderChromium.h:
(VertexShaderVideoTransform):
(WebCore::VertexShaderVideoTransform::matrixLocation):
(WebCore::VertexShaderVideoTransform::texTransformLocation):
(WebCore::VertexShaderVideoTransform::texMatrixLocation):
(WebCore):
(FragmentShaderOESImageExternal):
- platform/graphics/chromium/VideoFrameChromium.h:
- platform/graphics/chromium/VideoFrameProvider.h:
(Client):
(VideoFrameProvider):
- platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(WebCore::CCVideoDrawQuad::matrix):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::setMatrix):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didReceiveFrame):
(WebCore::CCVideoLayerImpl::didUpdateMatrix):
(WebCore::CCVideoLayerImpl::setNeedsRedraw):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore):
(CCVideoLayerImpl):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebMediaPlayer.h:
(WebKit):
(WebKit::WebMediaPlayer::setStreamTextureClient):
(WebMediaPlayer):
- public/WebStreamTextureClient.h: Copied from Source/WebKit/chromium/public/WebVideoFrame.h.
(WebKit):
(WebStreamTextureClient):
(WebKit::WebStreamTextureClient::~WebStreamTextureClient):
- public/WebVideoFrame.h:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::didReceiveFrame):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::didUpdateMatrix):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 2:05 PM Changeset in webkit [108674] by
-
- 5 edits in trunk
Source/WebCore: [chromium] Implement drop-shadow() CSS filter on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=79386
Reviewed by James Robinson.
Covered by css3/filters/effect-drop-shadow-hw.html
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
- platform/graphics/filters/FilterOperation.h:
(WebCore::DropShadowFilterOperation::movesPixels):
LayoutTests: [chromium] Mark drop-shadow() tests as failing, pending a rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=79386
Reviewed by James Robinson.
- platform/chromium/test_expectations.txt:
- 1:52 PM Changeset in webkit [108673] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Cleaning up pixelSnappedLogical*OffsetForLine code.
- 1:42 PM Changeset in webkit [108672] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- llint/LLIntOffsetsExtractor.cpp:
- 1:41 PM Changeset in webkit [108671] by
-
- 4 edits in trunk/Source
Versioning.
- 1:38 PM Changeset in webkit [108670] by
-
- 1 copy in tags/Safari-535.22
New Tag.
- 1:23 PM Changeset in webkit [108669] by
-
- 14 edits in trunk/Source/WebCore
Add support for InterfaceName in the bindings
https://bugs.webkit.org/show_bug.cgi?id=79384
Reviewed by Adam Barth.
This makes the interface name part of the idl file instead of being hard coded into the code generators.
- bindings/scripts/CodeGenerator.pm:
(GetVisibleInterfaceName): Extracted from CodeGenerator{JS,V8}.pm and changed to look at the extended attribute.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateConstructorDefinition):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- dom/DOMCoreException.idl: Set the InterfaceName.
- html/DOMFormData.idl: Ditto.
- plugins/DOMMimeType.idl: Ditto.
- plugins/DOMMimeTypeArray.idl: Ditto.
- plugins/DOMPlugin.idl: Ditto.
- plugins/DOMPluginArray.idl: Ditto.
- 1:17 PM Changeset in webkit [108668] by
-
- 4 edits2 adds in trunk
REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305
Reviewed by Tony Chang.
Source/WebCore:
The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.
Test: editing/input/paste-text-ending-with-interchange-newline.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
LayoutTests:
Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.
- editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
- editing/input/paste-text-ending-with-interchange-newline.html: Added.
- resources/dump-as-markup.js:
(Markup._get):
(Markup._getShadowHostIfPossible):
- 1:15 PM Changeset in webkit [108667] by
-
- 9 edits in trunk/Source/WebCore
Make use of StylePropertySet::setProperty(propertyID, CSSValue).
<http://webkit.org/b/79374>
Reviewed by Antti Koivisto.
Use the new setProperty() overload that takes a CSSValue in more places. This allows us
to get rid of 1/3 setProperty() overloads that don't expand shorthands.
- css/StylePropertySet.h:
- css/StylePropertySet.cpp:
Remove the setProperty() overload for specific primitive value types. StyledElement
can take care of this without help from StylePropertySet.
- dom/StyledElement.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):
Switch some functions over to using the setProperty() overload that takes a CSSValue.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForAttribute):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
Use shorthands where possible to shrink the code a bit. Pass border widths as CSS_PX
values directly instead of making a CSSParser round-trip.
- 1:09 PM Changeset in webkit [108666] by
-
- 10 edits in trunk/Source/WebKit/chromium
[chromium] Clean up GraphicsContext3D initialization paths
https://bugs.webkit.org/show_bug.cgi?id=79321
Reviewed by Kenneth Russell.
This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
WebLayerTreeViewImpl.
Offscreen initialization path:
1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.
Onscreen initialization path:
1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
or WebLayerTreeViewClient, respectively
2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.
There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
within WebCore.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
- src/WebViewImpl.cpp:
(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::createContext):
(CCLayerTreeHostImplTest):
(WebKit::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
- tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
- tests/CompositorFakeGraphicsContext3D.h:
(WebCore::createCompositorMockGraphicsContext3D):
- tests/FakeGraphicsContext3DTest.cpp:
(TEST):
- 1:06 PM Changeset in webkit [108665] by
-
- 2 edits2 adds in trunk/Source/WebKit/chromium
Add UserGestureIndicator capability to Chromium API.
https://bugs.webkit.org/show_bug.cgi?id=77690
Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebScopedUserGesture.h: Added.
- src/WebScopedUserGesture.cpp: Added.
- 12:54 PM Changeset in webkit [108664] by
-
- 3 edits in trunk
[wx] Build fixes, update the build system after recent changes.
- 12:52 PM Changeset in webkit [108663] by
-
- 2 edits in trunk/Source/WebCore
[wx] Build fix, use the strings in LocalizedStrings.cpp.
- 12:51 PM Changeset in webkit [108662] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Add missing "Reviewed by" line to change log entry for changeset r108631
(https://bugs.webkit.org/show_bug.cgi?id=79252)
The patch landed in changeset r108631 was reviewed by Martin Robinson.
- ChangeLog:
- 12:48 PM Changeset in webkit [108661] by
-
- 3 edits in trunk/Source/JavaScriptCore
[wx] Build fix, disable LLINT for now and fix ENABLE defines for it.
- 12:47 PM Changeset in webkit [108660] by
-
- 2 edits in trunk/Source/JavaScriptCore
[wx] Build fix for non-Mac wx builds.
- 12:46 PM Changeset in webkit [108659] by
-
- 2 edits in trunk/Source/WebCore
Microsoft IE fishtank demo causes assertion in RenderLayer::convertToLayerCoords
https://bugs.webkit.org/show_bug.cgi?id=61964
Reviewed by James Robinson.
The assertion is caused with the following callstack:
WebCore::RenderLayer::convertToLayerCoords
WebCore::RenderLayerCompositor::layerWillBeRemoved
WebCore::RenderLayer::removeChild
WebCore::RenderLayer::removeOnlyThisLayer
WebCore::RenderLayer::removeOnlyThisLayer removes itself from the parent
before moving its children to its parent. When WebCore::RenderLayer::convertToLayerCoords
is called for one of the children, it tries to walk to root only to stop at the immediate
parent which was disconnected from the tree in WebCore::RenderLayer::removeOnlyThisLayer.
If removal of layer is delayed until the children has been moved, the ASSERT is avoided.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::removeOnlyThisLayer):
- 12:43 PM WikiStart edited by
- (diff)
- 12:27 PM Changeset in webkit [108658] by
-
- 1 edit in trunk/Source/WebCore/html/HTMLCanvasElement.cpp
Missed an if from r108657.
- 12:17 PM Changeset in webkit [108657] by
-
- 2 edits in trunk/Source/WebCore
Fix for canvas breakage caused by r108597 from the following:
https://bugs.webkit.org/show_bug.cgi?id=79317
Reviewed by Oliver Hunt.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
- 12:06 PM Changeset in webkit [108656] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: mad Redo to Cmd+Shift+Z, not Cmd+Y on a Mac.
https://bugs.webkit.org/show_bug.cgi?id=79341
Reviewed by Timothy Hatcher.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):
- 12:02 PM Changeset in webkit [108655] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped: Skip a failing test.
- 11:58 AM Changeset in webkit [108654] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after 108629.
- WebCore.exp.in:
- 11:46 AM Changeset in webkit [108653] by
-
- 3 edits4 adds in trunk
[chromium] XSS Auditor bypass via javascript url and control characters
https://bugs.webkit.org/show_bug.cgi?id=79154
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/javascript-link-control-char2.html
- html/parser/XSSAuditor.cpp:
(WebCore):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
LayoutTests:
- http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt: Added.
- http/tests/security/xssAuditor/javascript-link-control-char2.html: Added.
- platform/chromium/http/tests/security/xssAuditor: Added.
- platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt: Added.
- 11:45 AM Changeset in webkit [108652] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG's logic for emitting a Flush is too convoluted and contains an inaccurate comment
https://bugs.webkit.org/show_bug.cgi?id=79334
Reviewed by Oliver Hunt.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):
- 11:43 AM Changeset in webkit [108651] by
-
- 7 edits in trunk
Object.isSealed / Object.isFrozen don't work for native objects
https://bugs.webkit.org/show_bug.cgi?id=79331
Reviewed by Sam Weinig.
Need to inspect all properties, including static ones.
This exposes a couple of bugs in Array & Arguments:
- getOwnPropertyDescriptor doesn't correctly report the writable attribute of array length.
- Arguments object's defineOwnProperty does not handle callee/caller/length correctly.
Source/JavaScriptCore:
- runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
- Add handling for callee/caller/length.
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyDescriptor):
- report length's writability correctly.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
- Add spec-based implementation for non-final objects.
LayoutTests:
- fast/js/preventExtensions-expected.txt:
- fast/js/script-tests/preventExtensions.js:
- Added tests.
- 11:41 AM Changeset in webkit [108650] by
-
- 4 edits in trunk
pop of array hole should get from the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=79338
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- runtime/JSArray.cpp:
(JSC::JSArray::pop):
- If the fast fast vector case fails, more closely follow the spec.
LayoutTests:
- sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.6_Array_prototype_pop/S15.4.4.6_A4_T1-expected.txt:
- Checking passing test result.
- 11:29 AM Changeset in webkit [108649] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope()
https://bugs.webkit.org/show_bug.cgi?id=79268
Patch by Yong Li <yoli@rim.com> on 2012-02-23
Reviewed by Michael Saboff.
resolveRope() is the only caller of outOfMemory(), and it calls outOfMemory()
after it fails to allocate a buffer for m_value. So outOfMemory() should assert
isRope() rather than !isRope().
- runtime/JSString.cpp:
(JSC::JSString::outOfMemory):
- 11:23 AM Changeset in webkit [108648] by
-
- 12 edits3 moves in trunk
[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
https://bugs.webkit.org/show_bug.cgi?id=79371
Reviewed by Daniel Bates.
.:
Add a new macro to handle the inclusion of the platform specific *.cmake files.
In the future this macro should get expanded to also handle feature specifc
files, like the UseJSC.cmake in WebCore we already have.
- Source/cmake/WebKitMacros.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
- shell/CMakeLists.txt:
- wtf/CMakeLists.txt:
Source/WebCore:
- CMakeLists.txt:
Source/WebKit:
- CMakeLists.txt:
- PlatformBlackBerry.cmake: Renamed from Source/WebKit/blackberry/CMakeListsBlackBerry.txt.
- PlatformEfl.cmake: Renamed from Source/WebKit/efl/CMakeListsEfl.txt.
- PlatformWinCE.cmake: Renamed from Source/WebKit/wince/CMakeListsWinCE.txt.
Source/WebKit2:
- CMakeLists.txt:
- 11:15 AM Changeset in webkit [108647] by
-
- 1 edit1 add in trunk
[CMake] Add FindDirectX
https://bugs.webkit.org/show_bug.cgi?id=79344
Reviewed by Adam Roben.
- Source/cmake/FindDirectX.cmake: Added.
- 11:14 AM Changeset in webkit [108646] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped:
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- 11:12 AM Changeset in webkit [108645] by
-
- 2 edits in trunk/Source/WebCore
Cleanup RenderBlock::moveChildrenTo
https://bugs.webkit.org/show_bug.cgi?id=79319
Reviewed by Eric Seidel.
Refactoring, no change in behavior expected.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveChildrenTo):
Removed inline check that was redundant, switched to |while| to a |for|
to show what's going on more closely and adds a call to moveChildTo to
share more code between the 2 functions.
- 11:06 AM Changeset in webkit [108644] by
-
- 1 edit1 add in trunk
[CMake] Add FindQuickTimeSDK
https://bugs.webkit.org/show_bug.cgi?id=79345
Reviewed by Adam Roben.
- Source/cmake/FindQuickTimeSDK.cmake: Added.
- 11:04 AM WebKitGTK/Releasing edited by
- (diff)
- 11:03 AM WebKitGTK/Releasing edited by
- Add more removed parts (diff)
- 11:00 AM WebKitGTK/Releasing edited by
- We are following GNOME schedule (diff)
- 11:00 AM Changeset in webkit [108643] by
-
- 24 edits in trunk
[Qt] Add support for touch cancellation
https://bugs.webkit.org/show_bug.cgi?id=79348
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Map Qt touch cancel events to the WebCore equivalent.
No new tests, unskipped existing test for Qt 5.
- platform/PlatformTouchPoint.h:
(PlatformTouchPoint):
- platform/qt/PlatformTouchEventQt.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
- platform/qt/PlatformTouchPointQt.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
Source/WebKit/qt:
Forward incoming touch cancellation events to the WebCore
event handler.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::sceneEvent):
- Api/qwebpage.cpp:
(QWebPage::event):
- Api/qwebview.cpp:
(QWebView::event):
Source/WebKit2:
Convert and forward incoming touch cancellation events
to the web process.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::webEventTypeForEvent):
(WebKit::WebEventFactory::createWebTouchEvent):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::event):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleEvent):
Tools:
Added straight-forward touch cancellation event sending to Qt WK1 DRT
and WK2 WTR.
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::touchCancel):
(EventSender::cancelTouchPoint):
- DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
- WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::touchCancel):
(WTR):
(WTR::EventSendingController::cancelTouchPoint):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::touchCancel):
(WTR):
(WTR::EventSenderProxy::cancelTouchPoint):
LayoutTests:
Moved touch cancel event layout tests from general skip list to the
Qt 4 specific one. The Qt 5 version we depend on has QEvent::TouchCancel, which
is all we need in order to implement touch cancellation in DRT/WTR.
- platform/qt-4.8/Skipped:
- platform/qt/Skipped:
- 10:59 AM WebKitGTK/Releasing edited by
- Bring back information about how to update library version (diff)
- 10:58 AM Changeset in webkit [108642] by
-
- 2 edits in trunk/Source/WebKit2
[WinCairo] Build fix after r108428.
- win/WebKit2CFLite.def: Add missing export declaration.
- 10:46 AM Changeset in webkit [108641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the PRI macros used in WTF::String formatters to be compatible with Qt and Visual Studio 2005 and newer.
https://bugs.webkit.org/show_bug.cgi?id=76210
Add compile time check for Visual Studio 2005 or newer.
Patch by Aron Rosenberg <arosenberg@logitech.com> on 2012-02-23
Reviewed by Simon Hausmann.
- os-win32/inttypes.h:
- 10:43 AM Changeset in webkit [108640] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed test fix after r108614: Adjust public API after changes.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- 10:35 AM Changeset in webkit [108639] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler.
https://bugs.webkit.org/show_bug.cgi?id=79335
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-23
Reviewed by Kenneth Rohde Christiansen.
In the upcoming Qt 5 builds the convenient setInputMethodHints method on QQuickItem
will be removed. There's no need for us to use it, we can implement passing the hints
to the input method right away in our re-implementation of inputMethodQuery, which works
with old and newer Qt 5 builds.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::updateTextInputState):
- 10:15 AM Changeset in webkit [108638] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Rebaseline binding test files.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
- 10:10 AM Changeset in webkit [108637] by
-
- 9 edits in branches/subpixellayout/Source
Fix usage of enclosing/pixelSnapped/round in branch
- 10:01 AM Changeset in webkit [108636] by
-
- 3 edits in trunk/Source/WebCore
Crash in ScrollElasticityController::snapRubberBandTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=79372
<rdar://problem/10915193>
Reviewed by Andreas Kling.
Invalidate the rubber-band timer in the ScrollingTreeNodeMac destructor.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::~ScrollingTreeNodeMac):
(WebCore):
- 9:56 AM WebKitGTK/Releasing edited by
- (diff)
- 9:32 AM Changeset in webkit [108635] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r108626.
http://trac.webkit.org/changeset/108626
https://bugs.webkit.org/show_bug.cgi?id=79370
broke qt-wk2 bot, somehow the workaround does not work on the
bot (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):
- 9:31 AM WebKitGTK/Releasing edited by
- (diff)
- 9:30 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:28 AM Changeset in webkit [108634] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add experiment that loads stylesheets as links
https://bugs.webkit.org/show_bug.cgi?id=79340
Reviewed by Timothy Hatcher.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/View.js:
(WebInspector.View.prototype._doLoadCSS):
- 8:54 AM Changeset in webkit [108633] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r108462.
- WebCoreSupport/EditorClientWinCE.h:
(EditorClientWinCE):
- 8:44 AM Changeset in webkit [108632] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r108627 and r108630.
https://bugs.webkit.org/show_bug.cgi?id=79367
ffmpeg is creating issues and was just reverted upstream as well.
- DEPS:
- 8:38 AM Changeset in webkit [108631] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] WebProcess SIGSEVs due to incorrect clipboard handling
https://bugs.webkit.org/show_bug.cgi?id=79252
Do not execute clipboard callbacks after the Frame associated with
it is destroyed.
This change is already covered by the TestWebViewEditor unit tests
(among others), they hang (because WebProcess dies) without this
patch in Debug builds.
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::frameDestroyed):
(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
(WebKit):
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):
- 8:19 AM Changeset in webkit [108630] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed build fix. Remove the ffmpeg binary directory from the
Chromium-Windows DEPS file, following the commit done in the
Chromium repository:
http://src.chromium.org/viewvc/chrome?view=rev&revision=123123
- DEPS:
- 8:08 AM Changeset in webkit [108629] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after r108615
- WebCore.exp.in: Added a missing export.
- 7:57 AM Changeset in webkit [108628] by
-
- 7 edits in trunk
[GTK] DRT doesn't support scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=78481
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-23
Reviewed by Gustavo Noronha Silva.
Source/WebKit/gtk:
Added a new API to deliver all mutations explicitly.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Extracted shareable code from keyDownCallback and then added createKeyPressEvent
to create gdk press key event.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
- DumpRenderTree/gtk/EventSender.cpp:
(scheduleAsynchronousClickCallback):
(createKeyPressEvent):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):
LayoutTests:
Removed following skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html
- platform/gtk/Skipped:
- 7:30 AM Changeset in webkit [108627] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 7:28 AM Changeset in webkit [108626] by
-
- 2 edits in trunk/Tools
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546
Reviewed by Simon Hausmann.
Co-authored with Simon Hausmann.
Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):
- 7:10 AM Changeset in webkit [108625] by
-
- 13 edits in trunk/Source/WebKit2
[Qt] Page doesn't get repainted while panning is in progress https://bugs.webkit.org/show_bug.cgi?id=78602
Reviewed by Simon Hausmann.
The tiling code needed the current visibleContentsRect in order to be
able to create tiles, so we now make sure it gets it. We also needed
to make sure to set the trajectory vector while panning and while the
flicking engine was animating kinetic scrolling.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentRectTrajectoryVector):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::flickableMovingStateChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::panMoveStarted):
(WebKit::QtViewportInteractionEngine::panMoveEnded):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
- WebProcess/WebPage/LayerTreeHost.messages.in:
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 6:58 AM Changeset in webkit [108624] by
-
- 5 edits in trunk
Unreviewed, rolling out r108577.
http://trac.webkit.org/changeset/108577
https://bugs.webkit.org/show_bug.cgi?id=79359
It doesn't work as expected (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23
Tools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::postEvent):
- DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
LayoutTests:
- platform/qt/Skipped:
- 4:26 AM Changeset in webkit [108623] by
-
- 4 edits1 add in trunk/Source/WebCore
Move MediaStream related declarations from DOMWindow to DOMWindowMediaStream
https://bugs.webkit.org/show_bug.cgi?id=79343
Reviewed by Eric Seidel.
These declarations belong in the MEDIA_STREAM module.
- GNUmakefile.list.am:
- WebCore.gypi:
- mediastream/DOMWindowMediaStream.idl: Added.
- page/DOMWindow.idl:
- 1:32 AM Changeset in webkit [108622] by
-
- 2 edits in trunk/Source/WebKit2
[CMAKE][WK2] Cleanup WebKit2/CMakeLists.txt.
https://bugs.webkit.org/show_bug.cgi?id=76122
Reviewed by Eric Seidel.
- CMakeLists.txt: Removed hardcoded WTF_USE_JSC preprocessor definition.
- 12:51 AM Changeset in webkit [108621] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Trivial build fix after r108615.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 12:45 AM Changeset in webkit [108620] by
-
- 8 edits in trunk
[GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76181
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Added entering-fullscreen and leaving-fullscreen signals, meant to
be used by the user agent to be notified when an element requests
full screen display and when the full screen display is to be
disabled.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::onFullscreenGtkKeyPressEvent):
(WebKit::ChromeClient::cancelFullScreen):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):
- WebCoreSupport/ChromeClientGtk.h:
- tests/testwebview.c:
- webkit/webkitwebview.cpp:
(webkit_web_view_real_entering_fullscreen):
(webkit_web_view_real_leaving_fullscreen):
(webkit_web_view_class_init):
- webkit/webkitwebview.h:
Tools:
Use the two new entering/leaving fullscreen signals to hide/show
the tool bar, the status bar and ask the user's permission before
entering fullscreen.
- GtkLauncher/main.c:
(webViewFullscreenMessageWindowClose):
(webViewWindowStateEvent):
(hide_widget):
(show_widget):
(webViewEnteringFullScreen):
(webViewLeavingFullScreen):
(createBrowser):
(createWindow):
- 12:32 AM Changeset in webkit [108619] by
-
- 4 edits3 deletes in trunk/LayoutTests
[Chromium] Unreviewed test expectations update for fast/css/font-face-default-font.html
- platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png:
- platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Removed.
- platform/chromium-win/fast/css/font-face-default-font-expected.png:
- platform/chromium-win/fast/css/font-face-default-font-expected.txt:
- 12:24 AM Changeset in webkit [108618] by
-
- 6 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/Skipped:
- platform/qt/fast/multicol/span/clone-flexbox-expected.png: Added.
- platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Added.
- platform/qt/fast/multicol/span/clone-summary-expected.png: Added.
- platform/qt/fast/multicol/span/clone-summary-expected.txt: Added.
- platform/qt/svg/custom/circle-move-invalidation-expected.png:
- platform/qt/svg/custom/circle-move-invalidation-expected.txt:
- platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
- platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
