⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 27, 2012:

11:52 PM Modules edited by abarth@webkit.org
(diff)
11:46 PM Modules edited by abarth@webkit.org
(diff)
11:43 PM Modules edited by abarth@webkit.org
(diff)
11:43 PM Changeset in webkit [109083] by Philippe Normand
  • 10 edits
    7 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/Skipped: Skip all dom/shadow tests, GTK doesn't

support this feature yet.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/multicol/span/clone-flexbox-expected.txt: Added.
  • platform/gtk/fast/multicol/span/clone-summary-expected.txt: Added.
  • platform/gtk/fast/runin/runin-div-before-child-expected.txt: Added.
  • platform/gtk/fast/runin/runin-table-before-child-expected.txt: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/text-rescale-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
11:37 PM Modules edited by abarth@webkit.org
(diff)
11:32 PM Modules edited by abarth@webkit.org
(diff)
11:31 PM Modules edited by abarth@webkit.org
(diff)
11:28 PM Modules edited by abarth@webkit.org
(diff)
11:26 PM Modules edited by abarth@webkit.org
(diff)
11:19 PM Modules edited by abarth@webkit.org
(diff)
11:02 PM Changeset in webkit [109082] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329

Remove trailing whitespace which makes test failure.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-27
Reviewed by Kent Tamura.

  • fast/forms/number/input-number-events-expected.txt: Remove trailing whitespace at line 11.
10:57 PM Changeset in webkit [109081] by commit-queue@webkit.org
  • 18 edits in trunk

Fix <msubsup> formatting, especially for a tall base, subscript, or superscript
https://bugs.webkit.org/show_bug.cgi?id=79274

Patch by David Barton <Dave Barton> on 2012-02-27
Reviewed by Julien Chaffraix.

Source/WebCore:

Move the <msubsup> formatting code in stretchToHeight() to layout(). Then revise the
combined code to produce more vertically accurate results, and without extra white
space. Finally, don't multiply msub/msup/msubsup operator stretching by 1.2.

Test: Added the bug report's attached test case to mathml/presentation/subsup.xhtml, and
it and 5 other test files in mathml/presentation now produce improved results. The
integral sign in mo-stretch.html is no longer scaled up by an extra 1.2, and baselines
are more accurate so the base is higher in msubsup-sub-changed.png. Several examples are
slightly tighter vertically, because their (somewhat) anonymous blocks wrapping
subscripts and superscripts now have the correct font size.

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • mathml/presentation/subsup.xhtml:
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.png:
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.png:
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.png:
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
10:49 PM Changeset in webkit [109080] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

kCTFontTableOptionExcludeSynthetic is unneeded
https://bugs.webkit.org/show_bug.cgi?id=79744

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-02-27
Reviewed by Dan Bernstein.

The aforementioned option is a no-op, so no new tests.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs): Specify no options.

10:47 PM Changeset in webkit [109079] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
10:34 PM Changeset in webkit [109078] by koz@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add missing parameter to didCreateScriptContext() so it overrides base class again.
https://bugs.webkit.org/show_bug.cgi?id=79742

Reviewed by Kent Tamura.

  • tests/WebFrameTest.cpp:
10:12 PM Changeset in webkit [109077] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel

  • tests/TransparencyWinTest.cpp:

(WebCore::TEST):

10:03 PM Changeset in webkit [109076] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Multi-Channel support in AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79202

Patch by Wei James <james.wei@intel.com> on 2012-02-27
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/audiobuffersource-multi-channels.html

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::setBuffer):

  • webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):

LayoutTests:

  • webaudio/audiobuffersource-channels-expected.txt:
  • webaudio/audiobuffersource-channels.html:
  • webaudio/audiobuffersource-multi-channels-expected.wav: Added.
  • webaudio/audiobuffersource-multi-channels.html: Added.
9:59 PM Changeset in webkit [109075] by mrowe@apple.com
  • 5 edits in tags/Safari-535.23.1/Source/JavaScriptCore

Merge r108888.

9:49 PM Changeset in webkit [109074] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
https://bugs.webkit.org/show_bug.cgi?id=79732

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.

The porting can't be built yet, no new tests.

  • platform/graphics/IntRect.h:

(Platform):
(IntRect):

9:42 PM Changeset in webkit [109073] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Printed font-size should not be dependant on zoom level
https://bugs.webkit.org/show_bug.cgi?id=79717

Reviewed by Adam Barth.

Ignore full page zoom level when printing a document.

Source/WebCore:

Test: printing/zoomed-document.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

  • printing/zoomed-document-expected.txt: Added.
  • printing/zoomed-document.html: Added.
9:29 PM Changeset in webkit [109072] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed gardening, further compile fixes for
TransparencyWinTest.

  • platform/graphics/chromium/TransparencyWin.h:

(WebCore):

9:16 PM Changeset in webkit [109071] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed gardening, fix compile error after r109043

  • platform/graphics/chromium/TransparencyWin.h:

(TransparencyWin):

8:59 PM Changeset in webkit [109070] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
https://bugs.webkit.org/show_bug.cgi?id=79394

Reviewed by Darin Fisher.

  • public/platform/WebFileSystem.h:

(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.

8:50 PM Changeset in webkit [109069] by bashi@chromium.org
  • 6 edits
    7 deletes in trunk

Unreviewed, rolling out r109041.
http://trac.webkit.org/changeset/109041
https://bugs.webkit.org/show_bug.cgi?id=79741

Broke Chromium Win build (Requested by bashi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-27

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • webintents/resources/web-intents-testing.js: Removed.
  • webintents/web-intents-failure-expected.txt: Removed.
  • webintents/web-intents-failure.html: Removed.
  • webintents/web-intents-invoke-expected.txt: Removed.
  • webintents/web-intents-invoke.html: Removed.
  • webintents/web-intents-reload.html:
  • webintents/web-intents-reply-expected.txt: Removed.
  • webintents/web-intents-reply.html: Removed.
8:41 PM Changeset in webkit [109068] by abarth@webkit.org
  • 8 edits
    1 move in trunk/Source/WebCore

EventFactory.in should be named EventNames.in
https://bugs.webkit.org/show_bug.cgi?id=79727

Reviewed by Kentaro Hara.

Originally EventFactory.in was just used to generate EventFactory.cpp,
but now we're able to generate a bunch of other Event-related code from
this "in" file.

In writing some documentation about how to use these mechanisms, the
name EventFactory.in didn't seem like the right name. This patch
renames EventFactory.in to EventNames.in, which more accurately
describes the role of this file (and matches the naming convention of
HTMLTagNames.in).

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:

(main):

  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
  • dom/EventFactory.in: Removed.
8:17 PM Changeset in webkit [109067] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=79622

For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

No new tests. No behavior change.

  • html/HTMLInputElement.idl: Reorder and remove obsolete comments.
7:52 PM Changeset in webkit [109066] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] Remove media tests from ChromiumGpu configurations
https://bugs.webkit.org/show_bug.cgi?id=79720

Patch by James Robinson <jamesr@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
composited playback path via tests in the compositing/ directory.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

7:44 PM Changeset in webkit [109065] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Sort CSSStyleSelector property handler constructors by CSS property name.
https://bugs.webkit.org/show_bug.cgi?id=79713

Reviewed by Andreas Kling.

No new tests / refactoring only.

This patch is simply an automated sort of the property constructors.
Presently they are all over the place and it is difficult to know where to insert new rules.
This patch provides a clear pattern and should reduce future conflicts when adding properties.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

7:31 PM Changeset in webkit [109064] by koz@chromium.org
  • 9 edits in trunk/Source

[chromium] Plumb extensionGroup into didCreateScriptContext().
https://bugs.webkit.org/show_bug.cgi?id=79072

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

7:29 PM Changeset in webkit [109063] by commit-queue@webkit.org
  • 2 edits in trunk

Update flakiness dashboard unit test.
https://bugs.webkit.org/show_bug.cgi?id=79711

Patch by Dave Tu <dtu@chromium.org> on 2012-02-27
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
7:17 PM Modules edited by abarth@webkit.org
(diff)
7:09 PM Modules edited by abarth@webkit.org
(diff)
7:09 PM Changeset in webkit [109062] by commit-queue@webkit.org
  • 6 edits in trunk

Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
incorrect source and destination rect used.
https://bugs.webkit.org/show_bug.cgi?id=79566

Source/WebCore:

Pass dstRect and bufferSrcRect to
CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
and source rect, respectively.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-27
Reviewed by Daniel Bates.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

I amended canvas-composite-canvas to cover this bug, and I also amended
canvas-composite-image because I changed
LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
However, the change of canvas-composite-image is reasonable because
drawImage(HTMLImageElement) will be able to have a similar bug.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-27
Reviewed by Daniel Bates.

  • fast/canvas/canvas-composite-canvas.html:
  • fast/canvas/canvas-composite-image.html:
  • fast/canvas/resources/canvas-composite-image-common.js:

(setupContext):

7:09 PM Modules edited by abarth@webkit.org
(diff)
7:08 PM Modules edited by abarth@webkit.org
(diff)
7:05 PM Modules edited by abarth@webkit.org
(diff)
7:03 PM Modules edited by abarth@webkit.org
(diff)
7:01 PM Changeset in webkit [109061] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[EFL] Initial implementation of GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=62961

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-02-27
Reviewed by Noam Rosenthal.

This patch adds the GraphicsContext3DPrivate class using Evas_GL.
GraphicsContext3DPrivate delegates all GL function calls to Evas_GL_API.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::activeTexture):
(WebCore::GraphicsContext3DPrivate::attachShader):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bindBuffer):
(WebCore::GraphicsContext3DPrivate::bindFramebuffer):
(WebCore::GraphicsContext3DPrivate::bindRenderbuffer):
(WebCore::GraphicsContext3DPrivate::bindTexture):
(WebCore::GraphicsContext3DPrivate::blendColor):
(WebCore::GraphicsContext3DPrivate::blendEquation):
(WebCore::GraphicsContext3DPrivate::blendEquationSeparate):
(WebCore::GraphicsContext3DPrivate::blendFunc):
(WebCore::GraphicsContext3DPrivate::blendFuncSeparate):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::checkFramebufferStatus):
(WebCore::GraphicsContext3DPrivate::clear):
(WebCore::GraphicsContext3DPrivate::clearColor):
(WebCore::GraphicsContext3DPrivate::clearDepth):
(WebCore::GraphicsContext3DPrivate::clearStencil):
(WebCore::GraphicsContext3DPrivate::colorMask):
(WebCore::GraphicsContext3DPrivate::compileShader):
(WebCore::GraphicsContext3DPrivate::copyTexImage2D):
(WebCore::GraphicsContext3DPrivate::copyTexSubImage2D):
(WebCore::GraphicsContext3DPrivate::cullFace):
(WebCore::GraphicsContext3DPrivate::depthFunc):
(WebCore::GraphicsContext3DPrivate::depthMask):
(WebCore::GraphicsContext3DPrivate::depthRange):
(WebCore::GraphicsContext3DPrivate::detachShader):
(WebCore::GraphicsContext3DPrivate::disable):
(WebCore::GraphicsContext3DPrivate::disableVertexAttribArray):
(WebCore::GraphicsContext3DPrivate::drawArrays):
(WebCore::GraphicsContext3DPrivate::drawElements):
(WebCore::GraphicsContext3DPrivate::enable):
(WebCore::GraphicsContext3DPrivate::enableVertexAttribArray):
(WebCore::GraphicsContext3DPrivate::finish):
(WebCore::GraphicsContext3DPrivate::flush):
(WebCore::GraphicsContext3DPrivate::framebufferRenderbuffer):
(WebCore::GraphicsContext3DPrivate::framebufferTexture2D):
(WebCore::GraphicsContext3DPrivate::frontFace):
(WebCore::GraphicsContext3DPrivate::generateMipmap):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttachedShaders):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getBooleanv):
(WebCore::GraphicsContext3DPrivate::getBufferParameteriv):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getFloatv):
(WebCore::GraphicsContext3DPrivate::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramiv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getRenderbufferParameteriv):
(WebCore::GraphicsContext3DPrivate::getShaderiv):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getTexParameterfv):
(WebCore::GraphicsContext3DPrivate::getTexParameteriv):
(WebCore::GraphicsContext3DPrivate::getUniformfv):
(WebCore::GraphicsContext3DPrivate::getUniformiv):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::getVertexAttribfv):
(WebCore::GraphicsContext3DPrivate::getVertexAttribiv):
(WebCore::GraphicsContext3DPrivate::getVertexAttribOffset):
(WebCore::GraphicsContext3DPrivate::hint):
(WebCore::GraphicsContext3DPrivate::isBuffer):
(WebCore::GraphicsContext3DPrivate::isEnabled):
(WebCore::GraphicsContext3DPrivate::isFramebuffer):
(WebCore::GraphicsContext3DPrivate::isProgram):
(WebCore::GraphicsContext3DPrivate::isRenderbuffer):
(WebCore::GraphicsContext3DPrivate::isShader):
(WebCore::GraphicsContext3DPrivate::isTexture):
(WebCore::GraphicsContext3DPrivate::lineWidth):
(WebCore::GraphicsContext3DPrivate::linkProgram):
(WebCore::GraphicsContext3DPrivate::pixelStorei):
(WebCore::GraphicsContext3DPrivate::polygonOffset):
(WebCore::GraphicsContext3DPrivate::readPixels):
(WebCore::GraphicsContext3DPrivate::renderbufferStorage):
(WebCore::GraphicsContext3DPrivate::sampleCoverage):
(WebCore::GraphicsContext3DPrivate::scissor):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::stencilFunc):
(WebCore::GraphicsContext3DPrivate::stencilFuncSeparate):
(WebCore::GraphicsContext3DPrivate::stencilMask):
(WebCore::GraphicsContext3DPrivate::stencilMaskSeparate):
(WebCore::GraphicsContext3DPrivate::stencilOp):
(WebCore::GraphicsContext3DPrivate::stencilOpSeparate):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texParameterf):
(WebCore::GraphicsContext3DPrivate::texParameteri):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1f):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1i):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2f):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2i):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3f):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3i):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4f):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4i):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::useProgram):
(WebCore::GraphicsContext3DPrivate::validateProgram):
(WebCore::GraphicsContext3DPrivate::vertexAttrib1f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib1fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib2f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib2fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib3f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib3fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib4f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib4fv):
(WebCore::GraphicsContext3DPrivate::vertexAttribPointer):
(WebCore::GraphicsContext3DPrivate::viewport):
(WebCore::GraphicsContext3DPrivate::createBuffer):
(WebCore::GraphicsContext3DPrivate::createFramebuffer):
(WebCore::GraphicsContext3DPrivate::createProgram):
(WebCore::GraphicsContext3DPrivate::createRenderbuffer):
(WebCore::GraphicsContext3DPrivate::createShader):
(WebCore::GraphicsContext3DPrivate::createTexture):
(WebCore::GraphicsContext3DPrivate::deleteBuffer):
(WebCore::GraphicsContext3DPrivate::deleteFramebuffer):
(WebCore::GraphicsContext3DPrivate::deleteProgram):
(WebCore::GraphicsContext3DPrivate::deleteRenderbuffer):
(WebCore::GraphicsContext3DPrivate::deleteShader):
(WebCore::GraphicsContext3DPrivate::deleteTexture):
(WebCore::GraphicsContext3DPrivate::synthesizeGLError):
(WebCore::GraphicsContext3DPrivate::getExtensions):

  • platform/graphics/efl/GraphicsContext3DPrivate.h: Added.

(WebCore):
(GraphicsContext3DPrivate):

6:58 PM Modules edited by abarth@webkit.org
(diff)
6:36 PM Changeset in webkit [109060] by shawnsingh@chromium.org
  • 5 edits
    3 adds in trunk

RenderLayer ClipRect not accounting for transforms
https://bugs.webkit.org/show_bug.cgi?id=76486

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/layer-creation/overlap-transformed-and-clipped.html

This patch changes calculateClipRects() so that the clipRect
offset is allowed to be converted across layers with
transforms. This is necessary because the RenderLayerCompositor
needs clipRects in document space, rather than with respect to
some local clipping layer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerPoint):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

  • compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • compositing/layer-creation/overlap-transformed-and-clipped.html: Added.
6:36 PM Modules edited by abarth@webkit.org
(diff)
6:35 PM Changeset in webkit [109059] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=79728

Reviewed by Gavin Barraclough.

When initialising a chained get instruction we may end up in a state where
the instruction stream says we have a scopechain, but it has not yet been set
(eg. if allocating the StructureChain itself is what leads to the GC). We could
re-order the allocation, but it occurs in a couple of places, so it seems less
fragile simply to null check the scopechain slot before we actually visit the slot.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitStructures):

6:34 PM Changeset in webkit [109058] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

[MutationObservers] Clear pending mutation records on disconnect()
https://bugs.webkit.org/show_bug.cgi?id=78639

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/disconnect-cancel-pending.html

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.

LayoutTests:

  • fast/mutation/disconnect-cancel-pending-expected.txt: Added.
  • fast/mutation/disconnect-cancel-pending.html: Added.
6:25 PM Modules edited by abarth@webkit.org
(diff)
6:19 PM Modules edited by abarth@webkit.org
(diff)
6:14 PM Changeset in webkit [109057] by rniwa@webkit.org
  • 8 edits
    1 add
    1 delete in trunk

Extract the logic to merge tests from MergeTestsHandler and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=79602

Reviewed by Hajime Morita.

Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler,
and moved MergeTestsHandler into admin_handlers.py where it belongs.

Added new backend "model-manipulator" to execute tasks to merge tests.

Also revive the inadvertently removed manual submission form on the admin page.

  • Websites/webkit-perf.appspot.com/admin_handlers.py:

(AdminDashboardHandler.get_tests):
(MergeTestsHandler):
(MergeTestsHandler.post):

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/backends.yaml: Added.
  • Websites/webkit-perf.appspot.com/css/admin.css:
  • Websites/webkit-perf.appspot.com/js/admin.js:
  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed.
  • Websites/webkit-perf.appspot.com/models.py:

(Test):
(Test.merge):
(TestResult.replace_to_change_test_name):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase):
(DataStoreTestsBase.assertOnlyInstances):
(DataStoreTestsBase.assertEqualUnorderedModelList):
(DataStoreTestsBase.assertEqualUnorderedList):
(_create_build):
(TestModelTests.test_merge):
(TestResultTests):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):

6:05 PM Changeset in webkit [109056] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: log multiline stderr/crash output properly
https://bugs.webkit.org/show_bug.cgi?id=79722

Reviewed by Adam Barth.

This cleans up some nits in the log output to make things
slightly easier to read (every line gets timestamped, etc.).

Also tweaks the log message for pixel hash mismatches.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._handle_error):
(SingleTestRunner._compare_image):

5:59 PM Changeset in webkit [109055] by beidson@apple.com
  • 4 edits in trunk

<rdar://problem/10924993> and https://bugs.webkit.org/show_bug.cgi?id=79725
<a ping> doesn't work in WebKit2

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Push the WK2 <a ping> setting to WebCore::Settings.

LayoutTests:

  • platform/wk2/Skipped: Unskip some tests that now pass.
5:56 PM Modules edited by abarth@webkit.org
(diff)
5:51 PM Changeset in webkit [109054] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

Always notify subtree of removal in ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=79316

Reviewed by Ryosuke Niwa.

Source/WebCore:

In the inDocument case, Node::removedFromDocument is called.
In the out-of-document case, call ContainerNode::removedFromTree to ensure,
e.g., form-associated elements are properly disconnected.

Test: fast/forms/form-associated-element-removal.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

LayoutTests:

  • fast/forms/form-associated-element-removal-expected.txt: Added.
  • fast/forms/form-associated-element-removal.html: Added.
5:47 PM Changeset in webkit [109053] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Touch the master.cfg to force a reconfig.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndTestLeaksFactory):
(NewBuildAndTestFactory):

5:44 PM Modules edited by abarth@webkit.org
(diff)
5:36 PM Changeset in webkit [109052] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

Repair license blocks for files created during modularization
https://bugs.webkit.org/show_bug.cgi?id=79721

Reviewed by Eric Seidel.

We failed to copy the license blocks correctly when moving code into
these files. This patch restores the correct license blocks.

  • Modules/geolocation/NavigatorGeolocation.cpp:
  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/mediastream/NavigatorMediaStream.cpp:
  • Modules/mediastream/NavigatorMediaStream.h:
  • bindings/js/JSDOMWindowWebAudioCustom.cpp:
  • bindings/js/JSDOMWindowWebSocketCustom.cpp:
  • storage/DOMWindowSQLDatabase.cpp:
  • storage/DOMWindowSQLDatabase.h:
5:34 PM Changeset in webkit [109051] by commit-queue@webkit.org
  • 8 edits in trunk

[BlackBerry] Upstream BlackBerry API web page related files
https://bugs.webkit.org/show_bug.cgi?id=74380

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

Source/WebKit/blackberry:

Clean up WebPage.{h, cpp} and WebPage_p.h.

  • Remove WebPage::mainFrame() as it is bad to expose WebCore::Frame in the public API, adapt to the change by adding a new method WebPagePrivate::core(Const WebPage*) and expose it to DumpRenderTreeSupport.
  • Rename WebPage::spellCheckingEnabled to WebPage::setSpellCheckingEnabled.
  • Remove unused WebPage::focusNodeRect().
  • Remove extra blank lines.
  • Put WebPage methods and their associated WebPagePrivate methods together.

No new tests as this patch doesn't change behavior.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::WebPage):
(WebKit):
(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPagePrivate::core):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):
(BlackBerry::WebKit::WebPage::loadString):
(BlackBerry::WebKit::WebPage::executeJavaScript):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::stopLoading):
(BlackBerry::WebKit::WebPage::prepareToDestroy):
(BlackBerry::WebKit::WebPage::setScrollPosition):
(BlackBerry::WebKit::WebPage::scrollBy):
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStatusChanged):
(BlackBerry::WebKit::WebPage::zoomToFitScale):
(BlackBerry::WebKit::WebPage::initialScale):
(BlackBerry::WebKit::WebPage::maximumScale):
(BlackBerry::WebKit::WebPage::scrollPosition):
(BlackBerry::WebKit::WebPage::viewportSize):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPage::blockZoomAnimationFinished):
(BlackBerry::WebKit::WebPage::onInputLocaleChanged):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
(BlackBerry::WebKit::WebPage::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::forcedTextEncoding):
(BlackBerry::WebKit::WebPage::setForcedTextEncoding):
(BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
(BlackBerry::WebKit::parentLayer):
(BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
(BlackBerry::WebKit::WebPage::destroyWebPageCompositor):

  • Api/WebPage.h:

(WebCore):
(WebKit):

  • Api/WebPage_p.h:

(WebCore):
(WebKit):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::corePage):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):

  • WebKitSupport/DumpRenderTreeSupport.h:

(WebCore):
(DumpRenderTreeSupport):

Tools:

Adapt to the removing of WebPage::mainFrame(), use
DumpRenderTreeSupport::corePage() and its mainFrame() instead.

No new tests as this patch doesn't change behavior.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::runTests):

5:32 PM Changeset in webkit [109050] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Windows and Linux Chromium perf bots
https://bugs.webkit.org/show_bug.cgi?id=79418

Reviewed by Tony Chang.

Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
the dedicated perf bot slave (uses the same hardware).

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:30 PM Changeset in webkit [109049] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._read_prompt):

5:24 PM Changeset in webkit [109048] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark another svg test as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [109047] by rniwa@webkit.org
  • 1 edit
    5 copies in branches/chromium/1025

Merge 108111 - REGRESSION: empty span creates renders with non-zero height
https://bugs.webkit.org/show_bug.cgi?id=76465

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/css/empty-span.html

fast/css/non-empty-span.html

Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.

This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size

will need a linebox if the rest of the line is not empty.

(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark

the line non-empty - otherwise hold off.

LayoutTests:

  • fast/css/empty-span-expected.html: Added.
  • fast/css/empty-span.html: Added.
  • fast/css/non-empty-span.html: Added.
  • platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
  • platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.

TBR=robert@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9478022

5:16 PM Changeset in webkit [109046] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark more svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
5:12 PM Changeset in webkit [109045] by dbates@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add test case for ::selection:window-inactive
https://bugs.webkit.org/show_bug.cgi?id=79623

Reviewed by Beth Dakin.

Add reftest to ensure that we don't regress inactive selection color.

For completeness, support for inactive selection color was added in
<http://trac.webkit.org/changeset/41094> (<rdar://problem/6077775>).

  • fast/selectors/selection-window-inactive-expected.html: Added.
  • fast/selectors/selection-window-inactive.html: Added.
5:10 PM Changeset in webkit [109044] by bashi@chromium.org
  • 4 edits
    2 copies in branches/chromium/1025

Merge 108724 - Don't clear IntentRequest callback pointers on stop()

This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.

Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638

Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Adam Barth.

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

  • Modules/intents/IntentRequest.h:

(IntentRequest):

TBR=gbillock@google.com
Review URL: https://chromiumcodereview.appspot.com/9479030

5:05 PM Changeset in webkit [109043] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=79718

  • tests/TransparencyWinTest.cpp:
5:05 PM Changeset in webkit [109042] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
https://bugs.webkit.org/show_bug.cgi?id=79580

Reviewed by Eric Seidel.

Refactoring only.

  • rendering/RenderTableSection.h:

(CellSpan):
(WebCore::CellSpan::CellSpan):
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
Added this class to hold the span information.

(WebCore::RenderTableSection::fullTableRowSpan):
(WebCore::RenderTableSection::fullTableColumnSpan):
Those functions return the span corresponding to the full table.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
return the full table span.

(WebCore::RenderTableSection::paintObject):
Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
This wasn't done previously and we had to manually patch some size comparison to account for the outline.

4:48 PM Changeset in webkit [109041] by commit-queue@webkit.org
  • 6 edits
    7 adds in trunk

Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527

Patch by Greg Billock <gbillock@google.com> on 2012-02-27
Reviewed by Adam Barth.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::currentIntentRequest):

LayoutTests:

  • webintents/resources/web-intents-testing.js: Added.
  • webintents/web-intents-failure-expected.txt: Added.
  • webintents/web-intents-failure.html: Added.
  • webintents/web-intents-invoke-expected.txt: Added.
  • webintents/web-intents-invoke.html: Added.
  • webintents/web-intents-reply-expected.txt: Added.
  • webintents/web-intents-reply.html: Added.
4:37 PM Changeset in webkit [109040] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Old JIT's style of JSVALUE64 strict equality is subtly wrong
https://bugs.webkit.org/show_bug.cgi?id=79700

Reviewed by Oliver Hunt.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::comparePtr):
(MacroAssemblerX86_64):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):

  • jit/JITOpcodes.cpp:

(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

4:36 PM Changeset in webkit [109039] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Support mutation observers
https://bugs.webkit.org/show_bug.cgi?id=79603

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-27
Reviewed by Eric Seidel.

.:

Added a build-option for the mutation observers feature.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

LayoutTests:

Rebased skipped tests regarding the mutation observers feature.

  • platform/efl/Skipped:
4:31 PM Changeset in webkit [109038] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617

Reviewed by Filip Pizlo.

Add an ArithNegate op to the DFG JIT, to implement op_negate.

This patch also adds support for op_negate to the JSVALUE64 baseline JIT
(JSVALUE32_64 already had this), so that we can profile the slowpath usage.

This is a 2.5%-3% Sunspider progression and a 1% win on Kraken.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::sub_S):

  • Added sub_S from immediate.

(ARMv7Assembler):
(JSC::ARMv7Assembler::vneg):

  • Added double negate.
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::negateDouble):

  • Added double negate.

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::branchNeg32):

  • Added.
  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):

  • moved loadDouble, absDouble to common.
  • assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::absDouble):

  • implementation can be shared.

(JSC::MacroAssemblerX86Common::negateDouble):

  • Added.

(JSC::MacroAssemblerX86Common::loadDouble):

  • allow absDouble to have a common implementation.
  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):

  • moved loadDouble, absDouble to common.
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • support ArithNegate.
  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • support ArithNegate.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • support ArithNegate.

(JSC::DFG::ByteCodeParser::parseBlock):

  • support op_negate.
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • support ArithNegate.
  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • support op_negate.
  • dfg/DFGGraph.h:

(JSC::DFG::Graph::negateShouldSpeculateInteger):

  • support ArithNegate.
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

  • support ArithNegate.
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithNegate):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • support ArithNegate.
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • Add support for op_negate in JSVALUE64.
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):

  • Add support for op_negate in JSVALUE64.
4:17 PM Changeset in webkit [109037] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed, fixed wrong bug URL on the ChangeLog.

4:07 PM Changeset in webkit [109036] by haraken@chromium.org
  • 10 edits
    1 move in trunk/Source/WebCore

Rename resolve-supplemental.pl to preprocess-idls.pl
https://bugs.webkit.org/show_bug.cgi?id=79660

Reviewed by Adam Barth.

Due to r108322, resolve-supplemental.pl not only resolves supplemental
dependencies but also runs IDL attribute checker. For clarification,
this patch renames resolve-supplemental.pl to preprocess-idls.pl.

No tests. Confirm that all builds pass.

  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.vcproj/MigrateScripts:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl.
3:59 PM Changeset in webkit [109035] by haraken@chromium.org
  • 20 edits in trunk

[JSC] Add [ConstructorParameters=] to all custom constructors
https://bugs.webkit.org/show_bug.cgi?id=78221

Reviewed by Adam Barth.

Source/WebCore:

This patch adds [ConstructorParameters=X] to IDL files that have
custom constructors, where X is the maximum number of arguments
of the constructor. [ConstructorParameters=X] is needed for custom
constructors, because custom constructors do not have a signature
in IDL files and thus CodeGeneratorJS.pm cannot know the number of
constructor arguments.

Test: fast/js/constructor-length.html

  • dom/WebKitMutationObserver.idl:
  • html/DOMFormData.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • webaudio/AudioContext.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.

(WebCore::JSFloat64ArrayConstructor::finishCreation):

LayoutTests:

The added tests check the length property of the custom constructors.

  • fast/js/constructor-length.html:
  • platform/mac/fast/js/constructor-length-expected.txt:
3:56 PM Changeset in webkit [109034] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-02-27 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Unreviewed. Build fix for linux-bot (qt) after r109021.

  • runtime/Error.cpp:
3:48 PM Changeset in webkit [109033] by jamesr@google.com
  • 5 edits in branches/chromium/1025/Source

Disable occlusion tracking and draw culling for Chromium m18

https://bugs.webkit.org/show_bug.cgi?id=79429
BUG=115957

3:40 PM Changeset in webkit [109032] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark many svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [109031] by kubo@profusion.mobi
  • 5 edits
    2 adds in trunk/Source/WebCore

[BlackBerry][EFL] Provide dummy RunLoop implementations.
https://bugs.webkit.org/show_bug.cgi?id=79398

Reviewed by Antonio Gomes.

r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
BlackBerry, as both platforms lack an implementation that provides the
missing methods for the RunLoop class.

However, RunLoop.cpp is a generic file which should not be included
directly in PlatformWinCE.cmake (plus it helps in converting the
AppleWin port to CMake).

Fix this by providing a dummy implementation of the missing RunLoop
methods for both EFL and BlackBerry.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • platform/blackberry/RunLoopBlackBerry.cpp: Added.

(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):

  • platform/efl/RunLoopEfl.cpp: Added.

(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):

3:32 PM Changeset in webkit [109030] by sullivan@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix (on Lion at least).

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged):
Removed names of unused parameters.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childrenChanged):
Ditto.

3:29 PM Modules created by abarth@webkit.org
3:22 PM Changeset in webkit [109029] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove [ConstructorParameters] from IDL files that have [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=79643

Reviewed by Adam Barth.

This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.

Test: fast/js/constructor-length.html

  • Modules/mediastream/PeerConnection.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • css/WebKitCSSMatrix.idl:
  • page/EventSource.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
3:09 PM Changeset in webkit [109028] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid doing 2 hash lookups if we override RenderBox's logical width / height
https://bugs.webkit.org/show_bug.cgi?id=79591

Reviewed by Antonio Gomes.

Refactoring only.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearOverrideSize):
Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
just directly call HashMap::remove that will do the lookup instead.

2:59 PM Changeset in webkit [109027] by leviw@chromium.org
  • 19 edits in branches/subpixellayout/Source

Build fix for Mac. Converting linesBoundingBox and borderBoundingBox, and ShadowData to integers. Removing a whitespace change to bring patch size down. Removing an extraneous printf.

2:53 PM Changeset in webkit [109026] by adamk@chromium.org
  • 5 edits in trunk/Source/WebCore

Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
https://bugs.webkit.org/show_bug.cgi?id=79697

Reviewed by Ryosuke Niwa.

insertedIntoTree/removedFromTree are only used by subclasses of
ContainerNode. Moreover, attempting to make use of these notifications
in a non-container Node would currently not work, because
Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods.
Rather than adding useless calls to an always-empty virtual method,
this patch moves these methods to ContainerNode.

Meanwhile, childrenChanged moves to ContainerNode for an obvious reason:
non-container Nodes have no children to change.

No new tests, refactoring only.

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal.
(WebCore::ContainerNode::parserRemoveChild): ditto.
(WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree.
(WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree.
(WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
(WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion.

  • dom/ContainerNode.h:

(ContainerNode): Migrate comments from Node.h, point back at it for more notification methods.

  • dom/Node.h:

(Node): Move methods, update comments to point at ContainerNode.h.

2:19 PM Changeset in webkit [109025] by eae@chromium.org
  • 10 edits in branches/subpixellayout/Source

Fix a IntRect/LayoutRect usage to avoid unnecessary type conversions on branch.

2:19 PM Changeset in webkit [109024] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark two fast/regex tests as failing

  • platform/chromium/test_expectations.txt:
2:15 PM Changeset in webkit [109023] by crogers@google.com
  • 9 edits
    2 adds in trunk

Implement static compression curve parameters for DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=78937

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::setParameterValue):
(WebCore):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::process):

  • platform/audio/DynamicsCompressor.h:
  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::kneeCurve):
(WebCore::DynamicsCompressorKernel::saturate):
(WebCore::DynamicsCompressorKernel::slopeAt):
(WebCore::DynamicsCompressorKernel::kAtSlope):
(WebCore::DynamicsCompressorKernel::updateStaticCurveParameters):
(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::meteringGain):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(WebCore):
(WebCore::DynamicsCompressorNode::create):
(DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::threshold):
(WebCore::DynamicsCompressorNode::knee):
(WebCore::DynamicsCompressorNode::ratio):
(WebCore::DynamicsCompressorNode::reduction):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt: Added.
  • webaudio/dynamicscompressor-basic.html: Added.
2:03 PM Changeset in webkit [109022] by enrica@apple.com
  • 7 edits in trunk/Source

WebKit2: implement platform strategy to access Pasteboard in the UI process.
https://bugs.webkit.org/show_bug.cgi?id=79253
<rdar://problem/9971876>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests. No behavior change.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::bufferForType): There is no need
to create a SharedBuffer object if there is no NSData in the pasteboard
for the given pasteboard type.

Source/WebKit2:

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Added messages to access NSPasteboard

in the UI process.

  • UIProcess/mac/WebContextMac.mm: Added methods corresponding to the

new messages.
(WebKit::WebContext::getPasteboardTypes):
(WebKit::WebContext::getPasteboardPathnamesForType):
(WebKit::WebContext::getPasteboardStringForType):
(WebKit::WebContext::getPasteboardBufferForType):
(WebKit::WebContext::pasteboardCopy):
(WebKit::WebContext::getPasteboardChangeCount):
(WebKit::WebContext::getPasteboardUniqueName):
(WebKit::WebContext::getPasteboardColor):
(WebKit::WebContext::setPasteboardTypes):
(WebKit::WebContext::setPasteboardPathnamesForType):
(WebKit::WebContext::setPasteboardStringForType):
(WebKit::WebContext::setPasteboardBufferForType):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: New implementation of the PasteboardStrategy using message exchange

with the UI process.
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

1:33 PM Changeset in webkit [109021] by oliver@apple.com
  • 4 edits in trunk

REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=79693

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Alas we can't provide the stack trace as an array, as despite everyone wanting
an array, everyone arbitrarily creates the array by calling split on the stack
trace. To create the array we would have provided them in the first place.

This changes the exception's stack property to a \n separated string. To get the
old array just do <exception>.stack.split("\n").

  • runtime/Error.cpp:

(JSC::addErrorInfo):

LayoutTests:

Update test case to handle Error.stack being a string rather than an array.

  • fast/js/script-tests/stack-trace.js:

(printStack):

1:24 PM Changeset in webkit [109020] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed speculative Chromium win build fix.

mdelaney's http://trac.webkit.org/changeset/109016 changed the
interface on ImageBuffer, but didn't update TransparencyWin.

  • platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::OwnedBuffers::canHandleSize):

1:22 PM Changeset in webkit [109019] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection handling should be entirely directional
https://bugs.webkit.org/show_bug.cgi?id=79692

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

Make all VisibleSelections directional.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):

1:10 PM Changeset in webkit [109018] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Cleanup Gesture requirement when exiting video-play-require-user-gesture test
https://bugs.webkit.org/show_bug.cgi?id=79690

Patch by Min Qin <qinmin@google.com> on 2012-02-27
Reviewed by Philippe Normand.

  • media/video-play-require-user-gesture.html:
1:03 PM Changeset in webkit [109017] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Chromium-Android layout test script: the adb shell prompt is not always '# '
https://bugs.webkit.org/show_bug.cgi?id=79506

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._read_prompt):

12:43 PM Changeset in webkit [109016] by mdelaney@apple.com
  • 26 edits in trunk/Source/WebCore

Add ImageBuffer support for having a hi-res backing store. This allows
ImageBuffer clients to specify a scale factor upon creation so that they
don't have to maintain that info themselves as they use/pass around the ImageBuffer.
https://bugs.webkit.org/show_bug.cgi?id=79395

Reviewed by Dan Bernstein.

No new tests. This patch doesn't change behavior.

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create): Scale the backing store by the resolution scale.
(WebCore::ImageBuffer::logicalSize): Differentiate the logical size from the backing store's size.
(WebCore::ImageBuffer::internalSize): The backing store's size.

  • platform/graphics/cg/ImageBufferCG.cpp: Prefer the explicit use of logicalSize and internalSize.

Explicitly state a 1x scale for all ImageBuffer creation sites
since this is what they currently assume.

  • html/HTMLCanvasElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • page/Frame.cpp:
  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/mac/ScrollbarThemeMac.mm:
  • rendering/FilterEffectRenderer.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/svg/SVGImageBufferTools.cpp:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImageCache.cpp:

Update ImageBuffer::size() calls to new versions.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/skia/PlatformContextSkia.cpp:
12:36 PM Changeset in webkit [109015] by mihnea@adobe.com
  • 20 edits in trunk

[CSSRegions]-webkit-flow-into initial value should be none instead of auto
https://bugs.webkit.org/show_bug.cgi?id=79670

Reviewed by Simon Fraser.

Source/WebCore:

No new tests, modified expectations for existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlowThread):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/css-regions-disabled-expected.txt:
  • fast/regions/script-tests/css-regions-disabled.js:
  • fast/regions/script-tests/webkit-flow-parsing.js:
  • fast/regions/webkit-flow-parsing-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:33 PM Changeset in webkit [109014] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

implement display: -webkit-inline-flexbox
https://bugs.webkit.org/show_bug.cgi?id=77772

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/inline-flexbox-expected.html

css3/flexbox/inline-flexbox.html

  • rendering/style/RenderStyle.h:

-Add INLINE_FLEXBOX to the list of replaced display types.
-Restructure the isDisplayInline methods to avoid code duplication.

LayoutTests:

  • css3/flexbox/inline-flexbox-expected.html: Added.
  • css3/flexbox/inline-flexbox.html: Added.
12:03 PM Changeset in webkit [109013] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608

Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not apply padding to a
direction that would cause the selection to shrink when performing the
handle direction detection.

Patch by Ed Baker <edbaker@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::convertPointToFrame):

  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::clamp):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):

  • WebKitSupport/SelectionHandler.h:
11:58 AM Changeset in webkit [109012] by rniwa@webkit.org
  • 4 edits
    2 copies in branches/chromium/963

REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305

Reviewed by Tony Chang.

LayoutTests:

Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.

  • editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
  • editing/input/paste-text-ending-with-interchange-newline.html: Added.
  • resources/dump-as-markup.js:

(Markup._get):
(Markup._getShadowHostIfPossible):

Source/WebCore:

The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.

Test: editing/input/paste-text-ending-with-interchange-newline.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
Merge 108668 - REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.

Test: editing/input/paste-text-ending-with-interchange-newline.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.

  • editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
  • editing/input/paste-text-ending-with-interchange-newline.html: Added.
  • resources/dump-as-markup.js:

(Markup._get):
(Markup._getShadowHostIfPossible):

TBR=rniwa@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9477008

11:48 AM Changeset in webkit [109011] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=78713

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-27
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/positioned-in-relative-position-inline-crash.html

Patch originally by Robin Cao.

This is a regression. r104183 changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous block itself. We should
change markContainingBlocksForLayout() to match the change in containingBlock().

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Test case originally by Robin Cao. This exercises the crashing
condition in bug 78713.

  • fast/css/positioned-in-relative-position-inline-crash-expected.txt: Added.
  • fast/css/positioned-in-relative-position-inline-crash.html: Added.
11:26 AM Changeset in webkit [109010] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp

Properly using pixel snapping to determing RenderLayer size on Layered Inlines.

11:14 AM Changeset in webkit [109009] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: move record formatting into the timeline presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79684

Source/WebCore:

Drive-by: fix for stop recording in reset; cpu time restored.

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.reset):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update.updateBoundaries):
(WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._rootRecord):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.createFormattedRecord):
(WebInspector.TimelinePresentationModel.prototype._createRootRecord):
(WebInspector.TimelinePresentationModel.prototype.rootRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.prototype._resetWindow):
(WebInspector.TimelinePresentationModel.prototype._addCategory):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.get lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get cpuTime):
(WebInspector.TimelinePresentationModel.Record.prototype.isLong):
(WebInspector.TimelinePresentationModel.Record.prototype.get children):
(WebInspector.TimelinePresentationModel.Record.prototype.containsTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generateAggregatedInfo):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyScriptLocation):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):
(WebInspector.TimelinePresentationModel.Record.prototype.get aggregatedStats):
(WebInspector.TimelinePresentationModel.PopupContentHelper):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._createCell):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendElementRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/timelinePanel.css:

(.timeline-graph-bar.cpu):

LayoutTests:

Reviewed by Vsevolod Vlasov.

  • inspector/timeline/timeline-receive-response-event.html:
10:29 AM Changeset in webkit [109008] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

RegExp lastIndex should behave as a regular property
https://bugs.webkit.org/show_bug.cgi?id=79446

Reviewed by Sam Weinig.

lastIndex should be a regular data descriptor, with the attributes configurable:false,
enumerable:false, writable:true. As such, it should be possible to reconfigure writable
as false. If the lastIndex property is reconfigured to be read-only, we should respect
this correctly.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:
    • Removed some unused identifiers, added lastIndex.
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::getOwnPropertyDescriptor):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::deleteProperty):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::getOwnPropertyNames):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::getPropertyNames):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::reject):

  • helper function for defineOwnProperty.

(JSC::RegExpObject::defineOwnProperty):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::put):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::match):

  • Pass setLastIndex an ExecState, so it can throw if read-only.
  • runtime/RegExpObject.h:

(JSC::RegExpObject::setLastIndex):

  • Pass setLastIndex an ExecState, so it can throw if read-only.

(RegExpObjectData):

  • Added lastIndexIsWritable.
  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • Pass setLastIndex an ExecState, so it can throw if read-only.

LayoutTests:

  • fast/regex/lastIndex-expected.txt: Added.
  • fast/regex/lastIndex.html: Added.
  • fast/regex/script-tests/lastIndex.js: Added.
    • Added test cases for correct handling of lastIndex.
10:26 AM Changeset in webkit [109007] by barraclough@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617

Reviewed by Sam Weinig.

Remove op_bitnop - this is redundant, ~x === x-1.
This is a fractional (<1%) progression.

Remove not32(X) from the MacroAssemblers - make this an optimization to add32(-1, X).
Remove CanReuse from the result type - this was unused.
Remove op_bitnot.

  • assembler/MacroAssemblerARM.h:

(MacroAssemblerARM):
(JSC::MacroAssemblerARM::xor32):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::xor32):

  • assembler/MacroAssemblerMIPS.h:

(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::xor32):

  • assembler/MacroAssemblerSH4.h:

(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::xor32):

  • assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::xor32):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/NodesCodegen.cpp:

(JSC):
(JSC::BitwiseNotNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITArithmetic32_64.cpp:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC):

  • jit/JITStubs.cpp:

(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • parser/NodeConstructors.h:

(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::SubNode::SubNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):

  • parser/Nodes.h:

(BitwiseNotNode):
(JSC::BitwiseNotNode::expr):
(JSC):

  • parser/ResultType.h:

(ResultType):
(JSC::ResultType::numberTypeIsInt32):
(JSC::ResultType::stringOrNumberType):
(JSC::ResultType::forAdd):
(JSC::ResultType::forBitOp):

10:15 AM Changeset in webkit [109006] by vsevik@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Scripts navigator overlay should not consume mouse actions.
https://bugs.webkit.org/show_bug.cgi?id=79674

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.registerShortcut):
(WebInspector.Panel.prototype.unregisterShortcut):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):

  • inspector/front-end/SidebarOverlay.js:

(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype._containingElementFocused):
(WebInspector.SidebarOverlay.prototype.position):
(WebInspector.SidebarOverlay.prototype.hide):
(WebInspector.SidebarOverlay.prototype._setWidth):

  • inspector/front-end/dialog.css:

(.go-to-line-dialog button:active):

  • inspector/front-end/scriptsPanel.css:

(#scripts-editor-view .sidebar-overlay):

  • inspector/front-end/splitView.css:

(.split-view-resizer):
(.sidebar-overlay):
(.sidebar-overlay-resizer):

10:04 AM Changeset in webkit [109005] by Philippe Normand
  • 6 edits
    2 adds in trunk/Source/WebCore

[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=77089

Reviewed by Martin Robinson.

Basic port to GStreamer 0.11 APIs. This patch excludes the video
painting changes and the GStreamerGWorld changes which are handled
in two other patches (bugs 77087 and 77088).

  • GNUmakefile.list.am: Add GStreamerVersioning files to the build.
  • Source/WebCore/PlatformEfl.cmake: Ditto.
  • Source/WebCore/Target.pri: Ditto.
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp: Added.

(webkit_gst_object_ref_sink):
(webkit_gst_element_get_pad_caps):

  • platform/graphics/gstreamer/GStreamerVersioning.h: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):

10:00 AM Changeset in webkit [109004] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Source/WebKit2: <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607

Reviewed by Adele Peterson.

Test: TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm

This was caused by not mapping the mouse event coordinates from window coordinates to
document coordinates.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Convert the point to main frame
coordinates when performing the hit test.
(WebKit::WebPage::shouldDelayWindowOrderingEvent): Convert the point to the main or focused
frame coordinates when perfomring the hit test.
(WebKit::WebPage::acceptsFirstMouse): Ditto.

Tools: Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607

Reviewed by Adele Peterson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.

(TestWebKitAPI::AcceptsFirstMouse::url):
(TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
(TestWebKitAPI::AcceptsFirstMouse::runTest):
(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
9:57 AM Changeset in webkit [109003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Stop recomputing SVG path data twice during layout
https://bugs.webkit.org/show_bug.cgi?id=79672

Patch by Philip Rogers <pdr@google.com> on 2012-02-27
Reviewed by Nikolas Zimmermann.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

9:51 AM Changeset in webkit [109002] by timothy@apple.com
  • 12 edits in trunk/Source

Add WKInspector API to know when the Web Inspector is the frontmost window.

https://webkit.org/b/79649

Reviewed by John Sullivan.

Source/WebCore: Updated for WebKit2 string changes.

  • English.lproj/Localizable.strings: Updated.

Source/WebKit2: Also makes the Safari Develop menu items work when the Web Inspector is frontmost.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsFront): Added. Call WebInspectorProxy::isFront.

  • UIProcess/API/C/WKInspector.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::isFront): Added. Call platformIsFront.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/efl/WebInspectorEfl.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter showWebInspector:]): Added. Makes the Develop menu items in Safari work when
the Web Inspector window is front.
(-[WKWebInspectorProxyObjCAdapter showErrorConsole:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter showResources:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter viewSource:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleDebuggingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleProfilingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter validateUserInterfaceItem:]): Added. Update the menu item titles.
(WebKit::WebInspectorProxy::platformIsFront): Added. Return if visible and the window is main.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

9:42 AM Changeset in webkit [109001] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark getPutImageDataPair as slow
https://bugs.webkit.org/show_bug.cgi?id=79679

  • platform/chromium/test_expectations.txt:
9:34 AM Changeset in webkit [109000] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Ctrl+K should not zoom in
https://bugs.webkit.org/show_bug.cgi?id=79676

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

9:22 AM Changeset in webkit [108999] by msaboff@apple.com
  • 5 edits in trunk

Error check regexp min quantifier
https://bugs.webkit.org/show_bug.cgi?id=70648

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Added checking for min or only quantifier being UINT_MAX.
When encountered this becomes a SyntaxError during parsing.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parse):
(Parser):

LayoutTests:

New test added to check for newly generated SyntaxError.

  • fast/regex/overflow-expected.txt:
  • fast/regex/script-tests/overflow.js:

(quantifyMaxInt):

9:01 AM Changeset in webkit [108998] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Patch from Vincent Untz <vuntz@gnome.org> to fix gtk2 build

8:58 AM Changeset in webkit [108997] by pfeldman@chromium.org
  • 14 edits
    2 adds
    1 delete in trunk

Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
https://bugs.webkit.org/show_bug.cgi?id=79675

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/TimelineAgent.js: Removed.
  • inspector/front-end/TimelineModel.js: Added.

(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._loadFromFile.onError):
(WebInspector.TimelineModel.prototype._saveToFile):
(WebInspector.TimelineModel.prototype._reset):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

  • inspector/front-end/TimelinePresentationModel.js: Added.

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/timeline/timeline-enum-stability.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):

8:54 AM Changeset in webkit [108996] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Build fix for building with GTK+ 2.x.

Patch by Vincent Untz <vuntz@gnome.org>> and Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-02-27

  • tests/testwebview.c:
8:49 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
8:36 AM Changeset in webkit [108995] by apavlov@chromium.org
  • 11 edits in trunk

Web Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration, not only at the end
https://bugs.webkit.org/show_bug.cgi?id=79662

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setValue):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._applyUserInput):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • inspector/styles/styles-add-blank-property-expected.txt:
  • inspector/styles/styles-add-blank-property.html:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-history.html:
  • inspector/styles/undo-add-property-expected.txt:
  • inspector/styles/undo-add-property.html:
8:34 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
7:49 AM Changeset in webkit [108994] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for lint error after r108992.

  • platform/chromium/test_expectations.txt:
7:22 AM Changeset in webkit [108993] by pfeldman@chromium.org
  • 15 edits in trunk

Source/WebCore: [Shadow]: Expose one ShadowRoot in the Elements panel (under experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=78202

Reviewed by Yury Semikhatsky.

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didPushShadowRoot):
(WebCore):
(WebCore::InspectorDOMAgent::willPopShadowRoot):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(InspectorDOMAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPushShadowRootImpl):
(WebCore):
(WebCore::InspectorInstrumentation::willPopShadowRootImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):

  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::addInspectedNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.isInShadowTree):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._shadowRootPopped):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.shadowRootPushed):
(WebInspector.DOMDispatcher.prototype.shadowRootPopped):

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/MemoryStatistics.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/inspector.css:

(.webkit-html-tag.shadow, .webkit-html-fragment.shadow):

LayoutTests: [Shadow]: Expose one ShadowRoot in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=78202

Reviewed by Yury Semikhatsky.

  • inspector/console/console-dirxml-expected.txt:
7:13 AM Changeset in webkit [108992] by pfeldman@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Web Inspector: drop protocol-level tests
https://bugs.webkit.org/show_bug.cgi?id=79671

Reviewed by Vsevolod Vlasov.

  • inspector/protocol/console-agent-expected.txt: Removed.
  • inspector/protocol/console-agent.html: Removed.
  • inspector/protocol/runtime-agent-expected.txt: Removed.
  • inspector/protocol/runtime-agent.html: Removed.
7:07 AM Changeset in webkit [108991] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
https://bugs.webkit.org/show_bug.cgi?id=79031

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-27
Reviewed by Zoltan Herczeg.

  • Get the pixel data when the cairo surface is created.
  • evas_object_image_data_get increases the reference count and returns the image buffer pointer.

evas_object_image_data_set decreases the reference count and when the ref count become zero,
the function releases the cached image inside evas engine.
We should make a pair between evas_object_image_data_set/get to return evas resource.

  • ewk/ewk_tiled_backing_store.h:

(_Ewk_Tile):

  • ewk/ewk_tiled_model.cpp:

(tile_account):
(ewk_tile_new):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb):

7:05 AM Changeset in webkit [108990] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [refactoring] remove dependencies from TimelinePanel from most of FormattedRecord
https://bugs.webkit.org/show_bug.cgi?id=79665

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyScriptLocation):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

6:56 AM Changeset in webkit [108989] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: reveal corresponding timeline record when user clicks on memory graph
https://bugs.webkit.org/show_bug.cgi?id=79669

When user clicks on DOM counter graph corresponding timeline record is
revealed in timelime grid and all its ancestors are expanded.

Reviewed by Pavel Feldman.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._onClick):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.HeapGraph.prototype._clear):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.revealRecordAt.recordFinder):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.forAllRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype.containsTime):

6:46 AM QtWebKitBugs edited by Csaba Osztrogonác
Add the meta bug to fix crashes/assertions/timeouts (diff)
6:43 AM Changeset in webkit [108988] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed single line fix for r108983.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide):

6:41 AM QtWebKitBugs edited by Csaba Osztrogonác
Add the meta bug to fix regressions cause layout test failures (diff)
5:47 AM Changeset in webkit [108987] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: repaint counter graphs when timeline splitter moves
https://bugs.webkit.org/show_bug.cgi?id=79644

Immediately refresh timeline panel on splitter move.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._splitterDragging):

5:14 AM Changeset in webkit [108986] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip one more crashing test.

  • platform/qt-5.0-wk2/Skipped:
4:28 AM Changeset in webkit [108985] by Carlos Garcia Campos
  • 7 edits in trunk

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.am: Add missing files.
  • GNUmakefile.list.am: Ditto.

Tools:

  • GNUmakefile.am: Fix typo.
4:04 AM Changeset in webkit [108984] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMake] Build fix after r108709.

  • CMakeLists.txt: Move DOMWindowSVG.idl to the other IDL files.
3:56 AM Changeset in webkit [108983] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected
https://bugs.webkit.org/show_bug.cgi?id=79654

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide):

3:38 AM Changeset in webkit [108982] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove page/PageSupplement.h from WebCore's Target.pri

The file itself was removed in r108958.

Reviewed by Kenneth Rohde Christiansen.

3:30 AM Changeset in webkit [108981] by vestbo@webkit.org
  • 8 edits in trunk

[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder

Reviewed by Kenneth Rohde Christiansen.

3:13 AM Changeset in webkit [108980] by morrita@google.com
  • 7 edits
    2 adds in trunk

Source/WebCore: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=79630

Reviewed by Ryosuke Niwa.

This problem was caused by the inconsistent detach order of DOM tree where
Element::detach() called ContainerNode::detach() before shadow tree is detached.
This resulted the renderer of the element being destroyed even if its children,
each of which came from an element in the shadow tree, are alive.
In principle, child renderers should be destroyed before its parent.

This change aligns the detach order with the attach order. The shadow tree is
now deatched before parent's ContainerNode::detach() is called.

Test: fast/dom/shadow/shadow-ul-li.html

  • dom/Element.cpp:

(WebCore::Element::detach):

LayoutTests: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=72440

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/shadow-ul-li-expected.txt: Added.
  • fast/dom/shadow/shadow-ul-li.html: Added.
  • fast/dom/shadow/shadow-ul-li.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
3:05 AM Changeset in webkit [108979] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/qt-5.0-wk1/Skipped: Skip a new timeouting test.
  • platform/qt-5.0-wk2/Skipped: Skip a new _crashing_ test.
  • platform/wk2/Skipped: Unskip non-existning tests, rename entries as real files renamed before.
2:42 AM Changeset in webkit [108978] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

Following tests are flaky:

  • compositing/reflections/remove-add-reflection.html
  • compositing/reflections/nested-reflection-transition.html
  • platform/chromium/test_expectations.txt:
2:27 AM Changeset in webkit [108977] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, try to skip previous tests to avoid crashes.

  • platform/qt/Skipped:
2:23 AM Changeset in webkit [108976] by keishi@webkit.org
  • 14 edits
    2 copies in trunk/Source/WebCore

Color input type should be clickable through keyboard
https://bugs.webkit.org/show_bug.cgi?id=79629

Reviewed by Kent Tamura.

Introduced BaseClickableWithKeyInputType that represents an input type
that can be clicked by pressing space/return keys.
ColorInputType, FileInputType directly inherit it because it doesn't
want the other methods(like appendFormData) in BaseButtonInputType.

  • CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
  • GNUmakefile.list.am: Added BaseClickableWithKeyInputType.{cpp,h}
  • Target.pri: Added BaseClickableWithKeyInputType.{cpp,h}
  • WebCore.gypi: Added BaseClickableWithKeyInputType.{cpp,h}
  • WebCore.vcproj/WebCore.vcproj: Added BaseClickableWithKeyInputType.{cpp,h}
  • WebCore.xcodeproj/project.pbxproj: Added BaseClickableWithKeyInputType.{cpp,h}
  • html/BaseButtonInputType.cpp:
  • html/BaseButtonInputType.h:

(WebCore::BaseButtonInputType::BaseButtonInputType): Inherits BaseClickableWithKeyInputType now.
(BaseButtonInputType):

  • html/BaseCheckableInputType.cpp: Changed comment.
  • html/BaseClickableWithKeyInputType.cpp:

(WebCore):
(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeypressEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::accessKeyAction): Moved from BaseButtonInputType

  • html/BaseClickableWithKeyInputType.h:

(WebCore):
(BaseClickableWithKeyInputType): Input type that can be clicked by pressing space/return keys.
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):

  • html/ColorInputType.h:

(WebCore::ColorInputType::ColorInputType): Inherits BaseClickableWithKeyInputType now.

  • html/FileInputType.cpp:

(WebCore::FileInputType::FileInputType):

  • html/FileInputType.h:

(FileInputType): Inherits BaseClickableWithKeyInputType now.

  • html/RangeInputType.cpp: Changed comment.

(WebCore):

2:21 AM Changeset in webkit [108975] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add missing include to ColorInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=79632

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp: Include ShadowTree.h
2:19 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Ad windowed plugins task (diff)
2:06 AM Changeset in webkit [108974] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Add a ChromiumGpuAndroid port.
https://bugs.webkit.org/show_bug.cgi?id=79628

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

Android does have a gpu port, so revert r107697.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(ChromiumGpuAndroidPort):
(ChromiumGpuAndroidPort.init):
(ChromiumGpuAndroidPort.baseline_search_path):
(ChromiumGpuAndroidPort.default_child_processes):
(ChromiumGpuAndroidPort.tests):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):

2:01 AM Changeset in webkit [108973] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

Following tests are flaky:

  • compositing/reflections/reflection-ordering.html
  • compositing/reflections/reflection-positioning.html
  • compositing/reflections/nested-reflection-transformed.html
  • compositing/reflections/nested-reflection-transformed2.html
  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [108972] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Use built-in bind in ExtensionAPI.js

Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in
https://bugs.webkit.org/show_bug.cgi?id=79570

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(injectedExtensionAPI):
(injectedExtensionAPI.Panels.prototype.create):
(injectedExtensionAPI.AuditResultImpl):
(injectedExtensionAPI.ExtensionServerClient):

1:27 AM Changeset in webkit [108971] by podivilov@chromium.org
  • 12 edits in trunk

Web Inspector: get rid of RawSourceCode.sourceMapping getter.
https://bugs.webkit.org/show_bug.cgi?id=79461

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.get location):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._restoreExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._updateCallFrame):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/callstack-placards-discarded-expected.txt:
  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/raw-source-code.html:
1:21 AM Changeset in webkit [108970] by mihnea@adobe.com
  • 17 edits
    2 copies
    12 adds in trunk

[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/get-regions-by-content-node-horiz-bt.html

fast/regions/get-regions-by-content-node-horiz-tb.html
fast/regions/get-regions-by-content-node-vert-lr.html
fast/regions/get-regions-by-content-node-vert-rl.html
fast/regions/get-regions-by-content-node.html
fast/regions/get-regions-by-content-node2.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::removeCachedRegionNodeList):
(WebCore):
(WebCore::Node::getRegionsByContentNode):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(WebCore):
(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/RegionNodeList.cpp:

(WebCore):
(WebCore::RegionNodeList::RegionNodeList):
(WebCore::RegionNodeList::~RegionNodeList):
(WebCore::RegionNodeList::nodeMatches):

  • dom/RegionNodeList.h:

(WebCore):
(RegionNodeList):
(WebCore::RegionNodeList::create):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::flowThread):

LayoutTests:

  • fast/regions/get-regions-by-content-node-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
  • fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
  • fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-vert-lr.html: Added.
  • fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-vert-rl.html: Added.
  • fast/regions/get-regions-by-content-node.html: Added.
  • fast/regions/get-regions-by-content-node2-expected.txt: Added.
  • fast/regions/get-regions-by-content-node2.html: Added.
1:16 AM Changeset in webkit [108969] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectaion update.

  • platform/chromium/test_expectations.txt: Changed expectation for http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html.
1:08 AM Changeset in webkit [108968] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=79642

Following tests time out:

  • accessibility/aria-describedby-on-input.html
  • fast/loader/subresource-willSendRequest-null.html
  • http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
  • media/video-playbackrate.html
  • platform/chromium/test_expectations.txt:
1:00 AM Changeset in webkit [108967] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: counter graphs should resize after console showing
https://bugs.webkit.org/show_bug.cgi?id=79640

Invoke Panel.doResize after showing drawer.

Reviewed by Pavel Feldman.

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):

12:51 AM Changeset in webkit [108966] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518

Patch by Dan Beam <dbeam@chromium.org> on 2012-02-27
Reviewed by Pavel Feldman.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

12:42 AM Changeset in webkit [108965] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: crash in fake workers
https://bugs.webkit.org/show_bug.cgi?id=79637

Notify front-end about worker creation/destruction synchronously instead of
posting a task.

Reviewed by Pavel Feldman.

  • inspector/InspectorAgent.cpp:

(WebCore):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):

  • inspector/InspectorAgent.h:

(InspectorAgent):

12:40 AM Changeset in webkit [108964] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip the following crashing svg test.

  • platform/qt/Skipped:
12:38 AM WebKitGTK/WebKit2Roadmap edited by Philippe Normand
(diff)
12:27 AM Changeset in webkit [108963] by leo.yang@torchmobile.com.cn
  • 1 edit
    2 adds in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream accelerated compositing helper class
https://bugs.webkit.org/show_bug.cgi?id=78448

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • WebKitSupport/FrameLayers.cpp: Added.
  • WebKitSupport/FrameLayers.h: Added.

Feb 26, 2012:

11:50 PM Changeset in webkit [108962] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing tests to paint the bots green.

  • platform/qt-5.0/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
11:47 PM Changeset in webkit [108961] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Add InjectedBundleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=75463

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-26
Reviewed by Andreas Kling.

Add first version of InjectedBundleEfl.cpp including load() and placeholder for activateMacFontAscentHack().

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::load):
(WebKit::InjectedBundle::activateMacFontAscentHack):

10:54 PM Changeset in webkit [108960] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed.

Fix some warnings in the build from referencing the non-existent
websockets directory.

  • WebCore.gyp/WebCore.gyp:
10:50 PM Changeset in webkit [108959] by shinyak@chromium.org
  • 40 edits
    2 moves in trunk

Rename ShadowRootList to ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=79342

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This patch renames ShadowRootList ot ShadowTree.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

  • dom/Element.cpp:

(WebCore::Element::willRemove):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::hasShadowRoot):
(WebCore::Element::shadowTree):
(WebCore::Element::setShadowRoot):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::removeShadowRoot):
(WebCore::Element::childrenChanged):

  • dom/Element.h:

(WebCore):
(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):

  • dom/Node.cpp:

(WebCore::oldestShadowRoot):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(WebCore):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::tree):
(WebCore::ShadowRoot::attach):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • dom/ShadowTree.cpp: Renamed from Source/WebCore/dom/ShadowRootList.cpp.

(WebCore):
(WebCore::ShadowTree::ShadowTree):
(WebCore::ShadowTree::~ShadowTree):
(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):
(WebCore::ShadowTree::insertedIntoDocument):
(WebCore::ShadowTree::removedFromDocument):
(WebCore::ShadowTree::insertedIntoTree):
(WebCore::ShadowTree::removedFromTree):
(WebCore::ShadowTree::willRemove):
(WebCore::ShadowTree::attach):
(WebCore::ShadowTree::detach):
(WebCore::ShadowTree::insertionPointFor):
(WebCore::ShadowTree::isSelectorActive):
(WebCore::ShadowTree::reattach):
(WebCore::ShadowTree::childNeedsStyleRecalc):
(WebCore::ShadowTree::needsStyleRecalc):
(WebCore::ShadowTree::recalcShadowTreeStyle):
(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::hostChildrenChanged):
(WebCore::ShadowTree::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::reattachHostChildrenAndShadow):
(WebCore::ShadowTree::ensureSelector):

  • dom/ShadowTree.h: Renamed from Source/WebCore/dom/ShadowRootList.h.

(WebCore):
(ShadowTree):
(WebCore::ShadowTree::hasShadowRoot):
(WebCore::ShadowTree::youngestShadowRoot):
(WebCore::ShadowTree::oldestShadowRoot):
(WebCore::ShadowTree::selector):
(WebCore::ShadowTree::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::host):

  • dom/TreeScopeAdopter.cpp:

(WebCore::shadowRootFor):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::shadowColorSwatch):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::findMainSummary):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::deleteBubbleTree):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):

  • page/FocusController.cpp:

(WebCore::shadowRoot):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
10:33 PM Changeset in webkit [108958] by abarth@webkit.org
  • 30 edits
    1 add
    4 deletes in trunk/Source/WebCore

Extract Supplementable base class from Page and Navigator
https://bugs.webkit.org/show_bug.cgi?id=79624

Reviewed by Hajime Morita.

We'll use this pattern again soon for ScriptExecutionContext.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • Modules/gamepad/NavigatorGamepad.h:
  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::from):

  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::provideUserMediaTo):

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::from):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DeviceMotionController.cpp:

(WebCore::provideDeviceMotionTo):

  • dom/DeviceMotionController.h:

(WebCore::DeviceMotionController::from):

  • dom/DeviceOrientationController.cpp:

(WebCore::provideDeviceOrientationTo):

  • dom/DeviceOrientationController.h:

(WebCore):
(WebCore::DeviceOrientationController::from):

  • notifications/NotificationController.cpp:

(WebCore::provideNotification):

  • notifications/NotificationController.h:

(WebCore):
(WebCore::NotificationController::from):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::page):
(WebCore):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(Navigator):

  • page/NavigatorSupplement.cpp: Removed.
  • page/NavigatorSupplement.h: Removed.
  • page/Page.cpp:

(WebCore):

  • page/Page.h:

(Page):

  • page/PageSupplement.cpp: Removed.
  • page/PageSupplement.h: Removed.
  • page/SpeechInput.cpp:

(WebCore::provideSpeechInputTo):

  • page/SpeechInput.h:

(WebCore::SpeechInput::from):

  • platform/Supplementable.h: Added.

(WebCore):
(Supplement):
(WebCore::Supplement::~Supplement):
(WebCore::Supplement::provideTo):
(WebCore::Supplement::from):
(Supplementable):
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::requireSupplement):

10:31 PM Changeset in webkit [108957] by commit-queue@webkit.org
  • 39 edits in trunk/Source

Move ChromeClient::showContextMenu() to ContextMenuClient
https://bugs.webkit.org/show_bug.cgi?id=79427

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-26
Reviewed by Adam Barth.

Source/JavaScriptCore:

Added ACCESSIBILITY_CONTEXT_MENUS.

  • wtf/Platform.h:

Source/WebCore:

  • Removed ChromeClient::showContextMenu(), Chrome::showContextMenu()
  • Added ContextMenuController::showContextMenuAt(), ContextMenuClient::showContextMenu()
  • Hided showContextMenu() behind ACCESSIBILITY_CONTEXT_MENUS

This change localizes context menu related code and will make it easy to
modularize CONTEXT_MENUS code.

Refactoring. No new tests.

  • WebCore.exp.in:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

  • loader/EmptyClients.h:

(EmptyContextMenuClient):
(WebCore::EmptyContextMenuClient::showContextMenu):

  • page/ContextMenuClient.h:

(ContextMenuClient):

  • page/ContextMenuController.cpp:

(WebCore):
(WebCore::ContextMenuController::showContextMenuAt):

  • page/ContextMenuController.h:

(ContextMenuController):

  • page/Chrome.cpp:
  • page/Chrome.h:

(Chrome):

  • page/ChromeClient.h:

(ChromeClient):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/chromium:

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.h:

(WebContextMenuClient):

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu): Moved from WebChromeClient

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(ChromeClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit):
(WebKit::WebContextMenuClient::showContextMenu): Moved from WebChromeClient

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:

(WebContextMenuClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

10:27 PM Changeset in webkit [108956] by benjamin@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/Source/WebCore

[Mac] Release localized Strings instead of AutoRelease
https://bugs.webkit.org/show_bug.cgi?id=79552

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-26
Reviewed by Sam Weinig.

By using the CoreFoundation API, we can release the memory as soon as
the WTF::String is created.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalizedStringsMac.cpp: Renamed from Source/WebCore/platform/mac/LocalizedStringsMac.mm.

(WebCore):
(WebCore::localizedString):

9:27 PM Changeset in webkit [108955] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329

Update input-number-events.html test for r108228. Spin buttons of number input field
fire both input and change events.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-26
Reviewed by Kent Tamura.

  • fast/forms/number/input-number-events-expected.txt: We get one change event from spin button click.
  • fast/forms/number/input-number-events.html: Change to one for change event.
9:10 PM Changeset in webkit [108954] by abarth@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebCore

ContextDestructionObserver should live in its own file
https://bugs.webkit.org/show_bug.cgi?id=79619

Reviewed by Hajime Morita.

WebKit prefers to have one class per file. (This patch is paying a
build system hacking debt I incurred earlier.)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ActiveDOMObject.cpp:

(WebCore):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
(WebCore::ActiveDOMObject::setPendingActivity):
(WebCore::ActiveDOMObject::unsetPendingActivity):

  • dom/ContextDestructionObserver.cpp: Added.

(WebCore):
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/ContextDestructionObserver.h: Added.

(WebCore):
(ContextDestructionObserver):
(WebCore::ContextDestructionObserver::scriptExecutionContext):

  • dom/DOMAllInOne.cpp:
9:05 PM Changeset in webkit [108953] by commit-queue@webkit.org
  • 2 edits in trunk

Update .gitignore for project property files generated by Eclipse.
https://bugs.webkit.org/show_bug.cgi?id=79463

Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-02-26
Reviewed by Andreas Kling.

  • .gitignore: Ignore .project and .cproject
8:16 PM Changeset in webkit [108952] by krit@webkit.org
  • 36 edits in trunk/Source/WebCore

2012-02-26 Dirk Schulze <krit@webkit.org>

Cleanup of Adobes copyright text. The text got harmonized with copyright texts of other companies.

Rubber stamped by Adam Barth.

  • css/CSSWrapShapes.cpp:
  • css/CSSWrapShapes.h:
  • css/WebKitCSSRegionRule.cpp:
  • css/WebKitCSSRegionRule.h:
  • css/WebKitCSSRegionRule.idl:
  • css/WebKitCSSShaderValue.cpp:
  • css/WebKitCSSShaderValue.h:
  • dom/WebKitNamedFlow.cpp:
  • dom/WebKitNamedFlow.h:
  • dom/WebKitNamedFlow.idl:
  • loader/cache/CachedShader.cpp:
  • loader/cache/CachedShader.h:
  • platform/graphics/filters/CustomFilterMesh.cpp:
  • platform/graphics/filters/CustomFilterMesh.h:
  • platform/graphics/filters/CustomFilterNumberParameter.h:
  • platform/graphics/filters/CustomFilterOperation.cpp:
  • platform/graphics/filters/CustomFilterOperation.h:
  • platform/graphics/filters/CustomFilterParameter.h:
  • platform/graphics/filters/CustomFilterProgram.cpp:
  • platform/graphics/filters/CustomFilterProgram.h:
  • platform/graphics/filters/CustomFilterProgramClient.h:
  • platform/graphics/filters/CustomFilterShader.cpp:
  • platform/graphics/filters/CustomFilterShader.h:
  • platform/graphics/filters/FECustomFilter.cpp:
  • platform/graphics/filters/FECustomFilter.h:
  • rendering/FilterEffectObserver.h:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/style/StyleCachedShader.cpp:
  • rendering/style/StyleCachedShader.h:
  • rendering/style/StyleCustomFilterProgram.h:
  • rendering/style/StylePendingShader.h:
  • rendering/style/StyleShader.h:
8:13 PM Changeset in webkit [108951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Use Functional instead of a MessageQueue for messages to the LayerTreeHostProxy
renderer.
https://bugs.webkit.org/show_bug.cgi?id=79478

This makes a lot of the broilerplate code for message-passing unnecessary, and
results in a much more succinct implementation.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-26
Reviewed by Noam Rosenthal.

  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):

8:07 PM Changeset in webkit [108950] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LayoutTests/fast/xpath/xpath-functional-test.html is crashing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=79616

Reviewed by Oliver Hunt.

Guard against the fact that in JSVALUE64, JSValue().isCell() == true.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::validate):

8:05 PM Changeset in webkit [108949] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should support activations and nested functions
https://bugs.webkit.org/show_bug.cgi?id=79554

Reviewed by Sam Weinig.

Fix 32-bit. The 32-bit function+activation code had some really weird
register reuse bugs.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:02 PM Changeset in webkit [108948] by fpizlo@apple.com
  • 9 edits in trunk/LayoutTests

Unreviewed, update expectation files due to slight changes in the text
of exceptions.

  • sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
7:50 PM Changeset in webkit [108947] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix for SL.

  • Platform/mac/RemoteLayerClient.mm:

(WebKit::RemoteLayerClient::RemoteLayerClient):

7:12 PM Changeset in webkit [108946] by weinig@apple.com
  • 13 edits
    2 copies in trunk/Source/WebKit2

Encapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient class
https://bugs.webkit.org/show_bug.cgi?id=79612

Reviewed by Anders Carlsson.

  • Platform/mac/RemoteLayerClient.h:
  • Platform/mac/RemoteLayerClient.mm:

(WebKit::RemoteLayerClient::create):
(WebKit::RemoteLayerClient::RemoteLayerClient):
(WebKit::RemoteLayerClient::~RemoteLayerClient):
(WebKit::RemoteLayerClient::clientID):
(WebKit::RemoteLayerClient::invalidate):
New class that encapsulates calls to WKSI WKCARemoteLayerClient*. For platforms
where the use of WKSI is not necessary, due to CARemoteLayerClient being available,
stop using WKSI.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::platformInitialize):
(WebKit::PluginControllerProxy::platformDestroy):
(WebKit::PluginControllerProxy::remoteLayerClientID):
(WebKit::PluginControllerProxy::platformGeometryDidChange):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::disposeOfLayerClient):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

(LayerTreeHostCAMac):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::invalidate):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Switch to using RemoteLayerClient.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Use CARemoteLayerServer directly if available.

6:57 PM Changeset in webkit [108945] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r108892.

  • platform/chromium/test_expectations.txt:
6:45 PM Changeset in webkit [108944] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r108896

  • platform/chromium/test_expectations.txt:
6:07 PM Changeset in webkit [108943] by fpizlo@apple.com
  • 13 edits
    1 add in trunk/Source/JavaScriptCore

Getting the instruction stream for a code block should not require two loads
https://bugs.webkit.org/show_bug.cgi?id=79608

Reviewed by Sam Weinig.

Introduced the RefCountedArray class, which contains a single inline pointer
to a ref-counted non-resizeable vector backing store. This satisfies the
requirements of CodeBlock, which desires the ability to share instruction
streams with other CodeBlocks. It also reduces the number of loads required
for getting the instruction stream by one.

This patch also gets rid of the bytecode discarding logic, since we don't
use it anymore and it's unlikely to ever work right with DFG or LLInt. And
I didn't feel like porting dead code to use RefCountedArray.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC::instructionOffsetForNth):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::newLabel):

  • bytecompiler/BytecodeGenerator.h:

(JSC):
(BytecodeGenerator):
(JSC::BytecodeGenerator::instructions):

  • bytecompiler/Label.h:

(JSC::Label::Label):
(Label):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • jit/JITExceptions.cpp:

(JSC::genericThrow):

  • llint/LowLevelInterpreter32_64.asm:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):

  • wtf/RefCountedArray.h: Added.

(WTF):
(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):
(WTF::RefCountedArray::operator=):
(WTF::RefCountedArray::~RefCountedArray):
(WTF::RefCountedArray::size):
(WTF::RefCountedArray::data):
(WTF::RefCountedArray::begin):
(WTF::RefCountedArray::end):
(WTF::RefCountedArray::at):
(WTF::RefCountedArray::operator[]):
(Header):
(WTF::RefCountedArray::Header::size):
(WTF::RefCountedArray::Header::payload):
(WTF::RefCountedArray::Header::fromPayload):

  • wtf/Platform.h:
5:48 PM Changeset in webkit [108942] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

[Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=79593

Reviewed by Adam Barth.

This patch halves the execution time of Bindings/dom-attributes.html
in order to avoid timeout in Chromium. The reason for the timeout is that
V8 DOM bindings are too much slower than JSC bindings.
I am a bit afraid that this patch will reduce the accuracy of the
perf test results, but it would make sense to reduce the execution time
until we fix the performance issue in V8 DOM bindings.

  • Bindings/dom-attributes.html:
5:19 PM Changeset in webkit [108941] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Take 2 build fix.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

5:14 PM Changeset in webkit [108940] by noel.gordon@gmail.com
  • 1 edit
    4 deletes in trunk/LayoutTests

[chromium] Update expectations for svg carto.net tests
https://bugs.webkit.org/show_bug.cgi?id=79423

Unreviewed. Optimize svg/carto.net/scrollbar.svg and svg/carto.net/selectionlist.svg
test baselines.

  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
5:12 PM Changeset in webkit [108939] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Compile fix for CCLayerTreeHostImpl test.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

5:11 PM Changeset in webkit [108938] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[EFL] Implementation of GraphicsContext3D for EFL port
https://bugs.webkit.org/show_bug.cgi?id=79452

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-02-26
Reviewed by Noam Rosenthal.

Evas_GL is used to do OpenGL rendering on Evas, in which
a structure 'Evas_GL_API' contains all the OpenGL functions.

GraphicsContext3D in EFL port should call OpenGL functions indirectly
through the Evas_GL_API, and not use GraphicsContext3DOpenGL(Common).

So, we use the GraphicsContext3DPrivate to delegate all OpenGL function calls,
and it will be implemented to use Evas_GL (bug 62961).

No new tests. No behavior change.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::getImageData):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
(WebCore::GraphicsContext3D::isResourceSafe):

5:04 PM Changeset in webkit [108937] by jamesr@google.com
  • 10 edits in trunk/Source

[chromium] Wire up shouldUpdateScrollPositionOnMainThread and nonFastScrollableRegion to compositor
https://bugs.webkit.org/show_bug.cgi?id=79155

Reviewed by Adam Barth.

Source/WebCore:

This hooks up ScrollingCoordinator::setNonFastScrollableRegion() and
ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread() to the chromium compositor
implementation and implements them on the impl thread.

New compositor behavior is covered by unit tests in LayerChromiumTests and CCLayerTreeHostImplTests. The rest is
just glue code.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setShouldScrollOnMainThread):
(WebCore):
(WebCore::LayerChromium::setNonFastScrollableRegion):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::shouldScrollOnMainThread):
(WebCore::CCLayerImpl::setShouldScrollOnMainThread):
(CCLayerImpl):
(WebCore::CCLayerImpl::nonFastScrollableRegion):
(WebCore::CCLayerImpl::setNonFastScrollableRegion):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollBegin):

Source/WebKit/chromium:

Add new tests for shouldScrollOnMainThread and nonFastScrollableRegion properties.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/LayerChromiumTest.cpp:
4:52 PM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
4:25 PM Changeset in webkit [108936] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_supplemental_method4):

2:51 PM Changeset in webkit [108935] by commit-queue@webkit.org
  • 8 edits in trunk

StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name
https://bugs.webkit.org/show_bug.cgi?id=79571

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2012-02-26
Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):

  • parser/Parser.cpp:

(JSC::::parseProperty):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createGetterOrSetterProperty):

LayoutTests:

  • fast/js/property-getters-and-setters-expected.txt:
  • fast/js/script-tests/property-getters-and-setters.js:

(o9.string_appeared_here.7.get string_appeared_here):
(o9.set string_appeared_here):
(get shouldBe):
(o10.string_appeared_here.7.get 42):
(o10.set 42):

  • platform/chromium/fast/js/property-getters-and-setters-expected.txt:
2:41 PM Changeset in webkit [108934] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Implement fast path for op_new_array in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

heap/CopiedAllocator.h:
(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.

  • heap/CopiedSpace.h:

(CopiedSpace): Friended the JIT to allow access to isOversize.
(JSC::CopiedSpace::allocator):

  • heap/Heap.h:

(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): New slow path that just bails out to a stub call if we
fail in any way on the fast path.

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h: Added lots of offset functions for all the fields that we need to

initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

10:06 AM Changeset in webkit [108933] by inferno@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r108547.
http://trac.webkit.org/changeset/108547
https://bugs.webkit.org/show_bug.cgi?id=79606

Crashes on ClusterFuzz (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-26

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

  • fast/css-generated-content/first-letter-textbox-parent-crash-expected.txt: Removed.
  • fast/css-generated-content/first-letter-textbox-parent-crash.html: Removed.
3:11 AM Changeset in webkit [108932] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r108681.

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC::Interpreter::getStackTrace):

12:55 AM Changeset in webkit [108931] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r108681.

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):

Note: See TracTimeline for information about the timeline view.