Timeline
Mar 3, 2012:
- 9:56 PM Changeset in webkit [109673] by
-
- 4 edits in trunk/Source/JavaScriptCore
Split JSArray's Put & DefineOwnProperty traps.
https://bugs.webkit.org/show_bug.cgi?id=80217
Reviewed by Filip Pizlo.
putByIndex() provides similar behavior to put(), but for indexed property names.
Many places in ArrayPrototype call putByIndex() where they really mean to call
DefineOwnProperty. This is only okay due to a bug – putByIndex should be
calling numeric accessors (& respecting numeric read only properties) on the
prototype chain, but isn't. Add a new putDirectIndex (matching JSObject's
putDirect* methods), to correctly provide a fast DefineOwnProperty interface.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
- runtime/JSArray.cpp:
(JSC):
(JSC::reject):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
- runtime/JSArray.h:
(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):
- 9:04 PM Changeset in webkit [109672] by
-
- 4 edits in trunk/Source/WebCore
Remove the unused function WebCore::protocolIsInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80218
Reviewed by Anders Carlsson.
- WebCore.order:
- platform/KURL.cpp:
- platform/KURL.h:
(WebCore):
- 7:49 PM Changeset in webkit [109671] by
-
- 6 edits in trunk/Source
Implement the basis of KURLWTFURL
https://bugs.webkit.org/show_bug.cgi?id=79600
Reviewed by Adam Barth.
Source/JavaScriptCore:
Add an API to know if a ParsedURL is valid.
- wtf/url/api/ParsedURL.cpp:
(WTF::ParsedURL::ParsedURL):
(WTF):
(WTF::ParsedURL::isolatedCopy): This is needed by APIs moving URL objects between thread
and by KURL's detach() on write.
(WTF::ParsedURL::baseAsString):
(WTF::ParsedURL::segment):
Add a stronger constraint on accessors: the client of this API should never ask for the segments
on an invalid URL.
- wtf/url/api/ParsedURL.h:
(WTF):
(WTF::ParsedURL::ParsedURL):
(ParsedURL):
(WTF::ParsedURL::isValid):
Source/WebCore:
Add a simple, non-optimized, implementation for the main methods of KURL based
on ParsedURL.
- platform/KURLWTFURL.cpp:
(WebCore):
(WebCore::detach):
(WebCore::KURL::KURL):
(WebCore::KURL::copy):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::hasPort):
(WebCore::KURL::port):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::query):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::baseAsString):
(WebCore::KURL::fileSystemPath):
(WebCore::KURL::protocolIs):
(WebCore::KURL::protocolIsInHTTPFamily):
(WebCore::KURL::setProtocol):
(WebCore::KURL::setHost):
(WebCore::KURL::removePort):
(WebCore::KURL::setPort):
(WebCore::KURL::setHostAndPort):
(WebCore::KURL::setUser):
(WebCore::KURL::setPass):
(WebCore::KURL::setPath):
(WebCore::KURL::setQuery):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::protocolHostAndPortAreEqual):
- platform/KURLWTFURLImpl.h:
(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::copy):
(WebCore):
- 7:26 PM Changeset in webkit [109670] by
-
- 24 edits in trunk/Source
Remove the redundant method KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80216
Reviewed by Anders Carlsson.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::addExtraFieldsToRequest):
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::hostForURL):
(WebCore::ResourceLoadScheduler::scheduleLoad):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
- loader/icon/IconController.cpp:
(WebCore::IconController::defaultURL):
- platform/KURL.h:
(KURL):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::set):
(WebCore::findDefaultProtectionSpaceForURL):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
Source/WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):
- src/WebPageSerializer.cpp:
(WebCore::retrieveResourcesForElement):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
- WebHistory.cpp:
(WebHistory::visitedURL):
- 7:08 PM Changeset in webkit [109669] by
-
- 9 edits in trunk
[Qt] Fix static_libs_as_shared build
https://bugs.webkit.org/show_bug.cgi?id=80214
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-03
Reviewed by Tor Arne Vestbø.
Source/WebKit/qt:
Add helper function to be called by WebProcess main
to potentially initialize the QStyle theme.
- WebCoreSupport/InitWebCoreQt.cpp:
(WebKit):
(WebKit::initializeWebKit2Theme):
Source/WebKit2:
Replace (static) link time dependency to WK1 with entrypoint
in the separate WebProcess for activating the QStyle theme if
necessary.
- Target.pri:
- UIProcess/Launcher/ProcessLauncher.h:
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- qt/MainQt.cpp:
(WebKit):
(main):
Tools:
- WebKitTestRunner/qt/main.cpp:
(main): Set the correct environment variable for choosing the theme in the
web process.
- 7:04 PM Changeset in webkit [109668] by
-
- 1 edit9 adds in trunk/Source/WebCore
[BlackBerry] Upstream LayerWebKitThread and its derived classes
https://bugs.webkit.org/show_bug.cgi?id=79871
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-03
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setCanvas):
(WebCore::CanvasLayerWebKitThread::setNeedsDisplay):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/CanvasLayerWebKitThread.h: Added.
(WebCore):
(CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::create):
- platform/graphics/blackberry/LayerData.h: Added.
(WebCore):
(LayerData):
(WebCore::LayerData::LayerData):
(WebCore::LayerData::~LayerData):
(WebCore::LayerData::anchorPoint):
(WebCore::LayerData::anchorPointZ):
(WebCore::LayerData::backgroundColor):
(WebCore::LayerData::borderColor):
(WebCore::LayerData::borderWidth):
(WebCore::LayerData::bounds):
(WebCore::LayerData::doubleSided):
(WebCore::LayerData::frame):
(WebCore::LayerData::masksToBounds):
(WebCore::LayerData::opacity):
(WebCore::LayerData::opaque):
(WebCore::LayerData::position):
(WebCore::LayerData::sublayerTransform):
(WebCore::LayerData::transform):
(WebCore::LayerData::preserves3D):
(WebCore::LayerData::getTextureID):
(WebCore::LayerData::setTextureID):
(WebCore::LayerData::needsTexture):
(WebCore::LayerData::layerProgramShader):
(WebCore::LayerData::isFixedPosition):
(WebCore::LayerData::hasFixedContainer):
(WebCore::LayerData::hasFixedAncestorInDOMTree):
(WebCore::LayerData::pluginView):
(WebCore::LayerData::holePunchRect):
(WebCore::LayerData::hasHolePunchRect):
(WebCore::LayerData::mediaPlayer):
(WebCore::LayerData::canvas):
(WebCore::LayerData::replicate):
(WebCore::LayerData::layerType):
(WebCore::LayerData::includeVisibility):
- platform/graphics/blackberry/LayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::LayerWebKitThread::create):
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::contentsVisible):
(WebCore::LayerWebKitThread::createFrontBufferLock):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setDrawable):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore::LayerWebKitThread::insertSublayer):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayer):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::indexOfSublayer):
(WebCore::LayerWebKitThread::setBounds):
(WebCore::LayerWebKitThread::setFrame):
(WebCore::LayerWebKitThread::rootLayer):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
- platform/graphics/blackberry/LayerWebKitThread.h: Added.
(WebCore):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setAnchorPoint):
(WebCore::LayerWebKitThread::setAnchorPointZ):
(WebCore::LayerWebKitThread::setBackgroundColor):
(WebCore::LayerWebKitThread::setBorderColor):
(WebCore::LayerWebKitThread::setBorderWidth):
(WebCore::LayerWebKitThread::setDoubleSided):
(WebCore::LayerWebKitThread::setMasksToBounds):
(WebCore::LayerWebKitThread::setMaskLayer):
(WebCore::LayerWebKitThread::maskLayer):
(WebCore::LayerWebKitThread::setReplicaLayer):
(WebCore::LayerWebKitThread::replicaLayer):
(WebCore::LayerWebKitThread::setNeedsDisplayOnBoundsChange):
(WebCore::LayerWebKitThread::setOpacity):
(WebCore::LayerWebKitThread::setOpaque):
(WebCore::LayerWebKitThread::setPosition):
(WebCore::LayerWebKitThread::getSublayers):
(WebCore::LayerWebKitThread::setSublayerTransform):
(WebCore::LayerWebKitThread::superlayer):
(WebCore::LayerWebKitThread::setTransform):
(WebCore::LayerWebKitThread::setPreserves3D):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setHasFixedContainer):
(WebCore::LayerWebKitThread::setHasFixedAncestorInDOMTree):
(WebCore::LayerWebKitThread::contents):
(WebCore::LayerWebKitThread::setOwner):
(WebCore::LayerWebKitThread::drawsContent):
(WebCore::LayerWebKitThread::layerCompositingThread):
(WebCore::LayerWebKitThread::setAbsoluteOffset):
(WebCore::LayerWebKitThread::contentsScale):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):
(WebCore::LayerWebKitThread::setNeedsTexture):
(WebCore::LayerWebKitThread::setLayerProgramShader):
(WebCore::LayerWebKitThread::isDrawable):
(WebCore::LayerWebKitThread::boundsChanged):
(WebCore::LayerWebKitThread::setSuperlayer):
(WebCore::LayerWebKitThread::numSublayers):
- platform/graphics/blackberry/PluginLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::PluginLayerWebKitThread::PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::~PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::setPluginView):
(WebCore::PluginLayerWebKitThread::setHolePunchRect):
(WebCore::PluginLayerWebKitThread::setNeedsDisplay):
(WebCore::PluginLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/PluginLayerWebKitThread.h: Added.
(WebCore):
(PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::create):
- platform/graphics/blackberry/VideoLayerWebKitThread.cpp: Added.
(WebCore):
(WebCore::VideoLayerWebKitThread::VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::~VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::setMediaPlayer):
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::setNeedsDisplay):
(WebCore::VideoLayerWebKitThread::boundsChanged):
(WebCore::VideoLayerWebKitThread::updateTextureContentsIfNeeded):
- platform/graphics/blackberry/VideoLayerWebKitThread.h: Added.
(WebCore):
(VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::create):
- 5:06 PM Changeset in webkit [109667] by
-
- 24 edits in trunk
Implement Speech JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=80019
Reviewed by Adam Barth.
.:
Add ENABLE_SCRIPTED_SPEECH.
- configure.ac:
Source/JavaScriptCore:
Add ENABLE_SCRIPTED_SPEECH.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Add ENABLE_SCRIPTED_SPEECH and runtime flag.
No functionality yet, so no new tests.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- Target.pri:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
Source/WebKit/chromium:
Add ENABLE_SCRIPTED_SPEECH and runtime flag.
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableScriptedSpeech):
(WebKit):
(WebKit::WebRuntimeFeatures::isScriptedSpeechEnabled):
Source/WebKit/mac:
Add ENABLE_SCRIPTED_SPEECH.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Add ENABLE_SCRIPTED_SPEECH.
- Configurations/FeatureDefines.xcconfig:
Tools:
Add ENABLE_SCRIPTED_SPEECH.
- Scripts/build-webkit:
- qmake/mkspecs/features/features.prf:
WebKitLibraries:
Add ENABLE_SCRIPTED_SPEECH.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 2:48 PM Changeset in webkit [109666] by
-
- 13 edits1 copy1 add in trunk
DelayNode has a fixed one second max delay time
https://bugs.webkit.org/show_bug.cgi?id=78758
Source/WebCore:
Change DelayNode to accept an optional parameter to specify the
maximum delay allowed. If not specified, the default is 1 sec.
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
Test: webaudio/delaynode-maxdelay.html
webaudio/delaynode-maxdelay-expected.txt
- webaudio/AudioContext.cpp:
(WebCore::AudioContext::createDelayNode): Allow maxDelayTime
parameter to specify max delay.
- webaudio/AudioContext.h: Allow maxDelayTime
parameter to specify max delay but default to 1.
(AudioContext):
- webaudio/AudioContext.idl: createDelayNode takes optional max
delay time parameter.
- webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel): Remove unused
DefaultMaxDelayTime. Set m_maxDelayTime from processor
maxDelayTime.
- webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode): Add maxDelayTime parameter.
- webaudio/DelayNode.h:
(WebCore::DelayNode::create): Add maxDelayTime parameter.
(DelayNode): Add maxDelayTime parameter.
- webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor): Add maxDelayTime
parameter.
- webaudio/DelayProcessor.h:
(DelayProcessor): Add maxDelayTime parameter.
(WebCore::DelayProcessor::maxDelayTime): New slot to hold
maxDelayTime.
LayoutTests:
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
- webaudio/resources/delay-testing.js: Added more informative
messages.
- webaudio/delaynode-expected.txt: Updated result for more
informative messages
- webaudio/delaynode-scheduling-expected.txt: Updated result for
more informative messages.
- webaudio/delaynode-maxdelay-expected.txt: Added
- webaudio/delaynode-maxdelay.html: Added
- 2:30 PM Changeset in webkit [109665] by
-
- 5 edits in trunk/Source/WebCore
Simplified discreteTimeConstantForSampleRate
https://bugs.webkit.org/show_bug.cgi?id=78051
Remove hardcoded constant and simplify computation of discrete
time constant.
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
No new tests needed. Covered by existing AudioParam tests.
- platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
Simplify formula.
- platform/audio/AudioUtilities.h:
(AudioUtilities): Update function signature.
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
cast to float to avoid warnings.
- webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): cast to
float to avoid warnings.
- 11:26 AM Changeset in webkit [109664] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
https://bugs.webkit.org/show_bug.cgi?id=79543
Use QSGNode::inheritedOpacity() and QSGNode::matrix().
Also, remove flags from changedStates() that we don't actually touch.
This is covered by existing API tests.
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- 11:13 AM Changeset in webkit [109663] by
-
- 11 edits in trunk/Source
Fix build with newer versions of clang.
Source/WebCore:
- bindings/objc/DOM.mm:
(-[DOMNode description]):
Remove an unused parameter.
- bridge/objc/objc_instance.mm:
(ObjcInstance::getClass):
Use object_getClass instead of accessing isa directly.
- platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):
Disable the -Wformat-nonliteral warning around the call to CFStringCreateWithFormatAndArguments.
- platform/graphics/mac/WebLayer.mm:
(-[CALayer _descriptionWithPrefix:]):
Use %p for the CALayer pointer, and use %lu for the number of sublayers.
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Cast the NSAttachmentCharacte enum to unichar.
Source/WebKit/mac:
- Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
Use %ld and cast to long.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:value:]):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
- 10:55 AM Changeset in webkit [109662] by
-
- 1 edit2 adds in trunk/LayoutTests
Biquad getFrequencyResponse needs a layout test.
https://bugs.webkit.org/show_bug.cgi?id=79503
Add simple test for getFrequencyResponse.
Patch by Raymond Toy <Raymond Toy> on 2012-03-03
Reviewed by Chris Rogers.
- webaudio/biquad-getFrequencyResponse-expected.txt: Added.
- webaudio/biquad-getFrequencyResponse.html: Added.
- 10:49 AM Changeset in webkit [109661] by
-
- 3 edits in trunk/Source/WebKit/chromium
Fixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
https://bugs.webkit.org/show_bug.cgi?id=80198
Reviewed by Adam Barth.
- src/AssociatedURLLoader.cpp:
- tests/AssociatedURLLoaderTest.cpp:
- 4:34 AM Changeset in webkit [109660] by
-
- 5 edits in trunk
Unreviewed, rolling out r109343.
http://trac.webkit.org/changeset/109343
https://bugs.webkit.org/show_bug.cgi?id=80212
Int32array can't handle values for native nodes because they
have int64 ids (Requested by loislo1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-03
Source/WebCore:
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
LayoutTests:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):
- 1:16 AM Changeset in webkit [109659] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK tests_expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 1:12 AM Changeset in webkit [109658] by
-
- 4 edits in trunk/Source/WebCore
Free up a bit in RenderObject.
http://webkit.org/b/80208
Patch by Andreas Kling <awesomekling@apple.com> on 2012-03-03
Reviewed by Anders Carlsson.
Move m_hasMarkupTruncation to RenderBlock, stealing one bit from m_lineHeight.
This flag is only used by RenderBlock.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::setHasMarkupTruncation):
(WebCore::RenderBlock::hasMarkupTruncation):
(RenderBlock):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
- 1:09 AM Changeset in webkit [109657] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline after r109623.
- editing/selection/select-line-break-with-opposite-directionality-expected.txt:
- 12:35 AM Changeset in webkit [109656] by
-
- 40 edits15 adds in trunk
Implement vw/vh/vmin (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160
The specification related to this implementation is located at http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units and creation of primitive values.
Added new Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin for viewport-relative lengths
and included the support for fetching the value of these relative length units based on the current viewport size.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-03
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html
- css/CSSComputedStyleDeclaration.cpp: Modified to support viewport relative Length types.
(WebCore::getPositionOffsetValue): Ditto.
(WebCore::getBorderRadiusCornerValues): Ditto.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::getBorderRadiusShorthandValue): Ditto.
(WebCore::lineHeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
- css/CSSGrammar.y: Added vw/vh/vmin support.
- css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):
- css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue): Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyBorderRadius::applyValue): Ditto.
(WebCore::ApplyPropertyFontSize::applyValue): Ditto.
(WebCore::ApplyPropertyLineHeight::applyValue): Ditto.
(WebCore::ApplyPropertyVerticalAlign::applyValue): Ditto.
- css/CSSStyleSelector.cpp:
(WebCore::convertToLength): Added support for viewport relative units.
(WebCore::createGridTrackBreadth): Ditto.
(WebCore::CSSStyleSelector::mapFillSize): Ditto.
(WebCore::CSSStyleSelector::mapFillXPosition): Ditto.
(WebCore::CSSStyleSelector::mapFillYPosition): Ditto.
- dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):
- dom/Document.h: Ditto.
(Document):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion): Modified to support viewport relative Length types.
- platform/Length.h: New LengthTypes such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin added.
(WebCore::Length::calcValue): Modified to support viewport relative Length types.
(WebCore::Length::calcMinValue): Ditto.
(WebCore::Length::calcFloatValue): Ditto.
(Length):
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.
- rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight): Modified to support viewport relative Length types.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight): Ditto.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset): Ditto.
(WebCore::RenderBox::paintBoxDecorations): Ditto.
(WebCore::RenderBox::clipRect): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegion): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Ditto.
(WebCore::RenderBox::computeInlineDirectionMargins): Ditto.
(WebCore::RenderBox::computeLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePercentageLogicalHeight): Ditto.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computeBlockDirectionMargins): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX): Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): Ditto.
(WebCore::RenderBoxModelObject::paddingTop): Ditto.
(WebCore::RenderBoxModelObject::paddingBottom): Ditto.
(WebCore::RenderBoxModelObject::paddingLeft): Ditto.
(WebCore::RenderBoxModelObject::paddingRight): Ditto.
(WebCore::RenderBoxModelObject::paddingBefore): Ditto.
(WebCore::RenderBoxModelObject::paddingAfter): Ditto.
(WebCore::RenderBoxModelObject::paddingStart): Ditto.
(WebCore::RenderBoxModelObject::paddingEnd): Ditto.
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect): Ditto.
(WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ditto.
(WebCore::computeBorderImageSide): Ditto.
(WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Ditto.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Ditto.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Ditto.
- rendering/RenderInline.cpp:
(WebCore::computeMargin): Ditto.
(WebCore::RenderInline::lineHeight): Ditto.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::viewportSize): New function to fetch the current viewport size.
(RenderObject):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): Modified to support viewport relative Length types.
- rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarWidth): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarHeight): Ditto.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Ditto.
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth): Ditto.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing): Ditto.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight): Ditto.
- rendering/RenderText.h:
(WebCore::RenderText::marginLeft): Ditto.
(WebCore::RenderText::marginRight): Ditto.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients): Ditto.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Ditto.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox): Ditto.
- rendering/style/RenderStyle.cpp:
(WebCore::calcRadiiFor): Ditto.
(WebCore::RenderStyle::getRoundedBorderFor): Ditto.
- rendering/style/RenderStyle.h: Ditto.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::resolveLengthAttributeForSVG): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
LayoutTests:
- css3/viewport-relative-lengths: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
- fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
Mar 2, 2012:
- 11:43 PM Changeset in webkit [109655] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new crashing test.
- platform/qt-5.0-wk2/Skipped:
- 11:34 PM Changeset in webkit [109654] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, updated expected files.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.png: Added.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
- platform/qt/fast/dom/prototype-inheritance-2-expected.png:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- 9:48 PM Changeset in webkit [109653] by
-
- 4 edits4 adds in trunk
Editor's default paragraph separator is not reset when a frame's document is changed
https://bugs.webkit.org/show_bug.cgi?id=80065
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/execCommand/reset-values-after-navigation.html
- editing/Editor.cpp:
(WebCore::Editor::clear):
LayoutTests:
- editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
- editing/execCommand/reset-values-after-navigation-expected.txt: Added.
- editing/execCommand/reset-values-after-navigation.html: Added.
- editing/execCommand/resources/reset-default-values-helper-1.html: Added.
- editing/execCommand/resources/reset-default-values-helper-2.html: Added.
- 9:31 PM Changeset in webkit [109652] by
-
- 2 edits1 add in trunk/Source/WebCore
Have a copy of plug-in sandboxing API header in WebCore
https://bugs.webkit.org/show_bug.cgi?id=80185
<rdar://problem/8242128>
Reviewed by Anders Carlsson.
- plugins/npapi-sandbox.h: Added.
- WebCore.xcodeproj/project.pbxproj: Added as unused file.
- 7:28 PM Changeset in webkit [109651] by
-
- 1 edit2 adds in trunk/LayoutTests
:empty should apply to elements made empty via page dynamics
https://bugs.webkit.org/show_bug.cgi?id=79734
Reviewed by Antonio Gomes.
- fast/css/pseudo-empty-dynamic-empty-expected.txt: Added.
- fast/css/pseudo-empty-dynamic-empty.html: Added.
- 7:18 PM Changeset in webkit [109650] by
-
- 16 edits in tags/Safari-536.2
Merged r109340.
- 7:18 PM Changeset in webkit [109649] by
-
- 2 edits in trunk/Tools
Fix commit queue, remove duplicate entry.
- Scripts/webkitpy/common/config/committers.py:
- 7:16 PM Changeset in webkit [109648] by
-
- 4 edits in tags/Safari-536.2/Source
Versioning.
- 7:13 PM Changeset in webkit [109647] by
-
- 1 copy in tags/Safari-536.2
New Tag.
- 6:41 PM Changeset in webkit [109646] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expose WebInspector state to client and clean up WebSettings
https://bugs.webkit.org/show_bug.cgi?id=80177
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Expose the Web Inspector state to WebPage client's and
re-order initialization of WebSettings to be alphabetical
matching their definitions.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
- Api/WebPage.h:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- 6:35 PM Changeset in webkit [109645] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py:
- 5:52 PM Changeset in webkit [109644] by
-
- 3 edits in trunk/LayoutTests
ES5.1-15.3.5.4. prohibits Function.caller from Getting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011
We now support getting the caller from within an accessor.
Reviewed by Sam Weinig.
- fast/js/function-dot-arguments-and-caller.html:
- platform/qt/Skipped:
- 5:48 PM Changeset in webkit [109643] by
-
- 1 edit2 adds in trunk/LayoutTests
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760
Unreviewed rebaselining. Cr-Linux returns
application/javascript for .js files instead of text/javascript.
- platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Added.
- 5:47 PM Changeset in webkit [109642] by
-
- 7 edits in trunk/Source/WebCore
Revert borders to integers for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=80175
Reviewed by Eric Seidel.
Change border representation and calculation back to integers to ensure
that borders given the same width are rendered with the same actual width.
This will also avoid unnecessary type conversions when we switch over
to subpixel precision.
No new tests.
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderTop):
(WebCore::RenderBoxModelObject::borderBottom):
(WebCore::RenderBoxModelObject::borderLeft):
(WebCore::RenderBoxModelObject::borderRight):
(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
- rendering/RenderTable.h:
(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(RenderTable):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
- rendering/RenderTableCell.h:
(RenderTableCell):
- 5:32 PM Changeset in webkit [109641] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove an erroneous expected result that showed up in r109303.
- platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.
- 5:24 PM Changeset in webkit [109640] by
-
- 2 edits in trunk/LayoutTests
Mark a few tests as flaky on Leopard debug.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 5:22 PM Changeset in webkit [109639] by
-
- 8 edits in branches/subpixellayout/Source
Change RenderBox::borderBoundingBox to return pixel snapped values and get rid of pixelSnapped version of same.
- 5:22 PM Changeset in webkit [109638] by
-
- 3 edits in trunk/Source/WebKit/blackberry
Accelerated compositing: Checkerboard never goes away
https://bugs.webkit.org/show_bug.cgi?id=79020
RIM PR #134164
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-02
Reviewed by Adam Treat.
Checkerboard appears in accelerated compositing layers when there's no
texture for (part of) a layer. The layer renderer queues up some render
jobs and schedules a commit to make the WebKit thread process those
jobs. Render jobs performed during commit cause texture upload jobs to
be scheduled on the UI thread. Texture uploads are performed when next
drawing the layers.
Unfortunately, sometimes commit operation happens without a subsequent
call draw the layers.
In order to implement one-shot drawing sync, I added a call to
commitRootLayerIfNeeded() in BackingStore::renderContents(), and
I was lucky that most of the time, renderContents() is followed by
blit(Visible)Contents() which in turn draws the layers.
However, render is not always followed by a blit, for example when
rendering offscreen tiles in BackingStore::renderOnIdle(), and in
direct rendering mode.
Fixed by making sure that every call to commitRootLayerIfNeeded() that
returns true is followed by a call to drawLayersOnCommit(), unless a
blit was requested already.
Also tweak the logic for one-shot drawing sync to make the code in
drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
- Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):
- 5:03 PM Changeset in webkit [109637] by
-
- 2 edits in trunk/LayoutTests
Another test fix after r109593. Remove the extra start body tag.
- editing/selection/select-line-break-with-opposite-directionality.html:
- 4:59 PM Changeset in webkit [109636] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed rebaseline for Leopard.
- platform/chromium-mac-leopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- 4:57 PM Changeset in webkit [109635] by
-
- 4 edits5 adds in trunk
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760
Reviewed by Adam Barth.
Source/WebCore:
Most of the code was already there, this just fixes the FIXME
which was causing this feature not to work. Chromium already
had this #ifdef enabled, but other ports (at least Mac) do not.
Test: fast/files/xhr-response-blob.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
LayoutTests:
- fast/files/script-tests/xhr-response-blob.js: Added.
(xhr.onreadystatechange):
- fast/files/xhr-response-blob-expected.txt: Added.
- fast/files/xhr-response-blob.html: Added.
- platform/chromium/fast/files/xhr-response-blob-expected.txt: Added.
- 4:50 PM Changeset in webkit [109634] by
-
- 7 edits1 delete in trunk/Source/WebCore
Revert Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80151
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- page/DOMWindow.idl:
- workers/DOMWindowWorker.idl: Removed.
- 4:39 PM Changeset in webkit [109633] by
-
- 9 edits2 adds in trunk/Source/WebKit2
Move nsStringFromWebCoreString out of PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=80202
Reviewed by Sam Weinig.
nsStringFromWebCoreString() doesn't really belong in PageClientImpl.mm,
and it makes us include PageClientImpl.h in places where we shouldn't.
Move this function into StringUtilities.{h, mm}.
- Platform/mac/StringUtilities.h: Added.
- Platform/mac/StringUtilities.mm: Added.
(WebKit::nsStringFromWebCoreString):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
- UIProcess/mac/WebPageProxyMac.mm:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
- UIProcess/mac/WebPreferencesMac.mm:
- WebKit2.xcodeproj/project.pbxproj:
- 4:29 PM Changeset in webkit [109632] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations cleanup.
Marked a bunch of flakiness as happening only in DEBUG,
and removed a whole set of tests that are no longer flaky.
- platform/chromium/test_expectations.txt:
- 4:19 PM Changeset in webkit [109631] by
-
- 2 edits33 adds in trunk/LayoutTests
Unreviewed rebaseline of SVG feImage tests after r105612 and r106113.
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-position-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-position-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:15 PM Changeset in webkit [109630] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80140
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
we should revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMWindowHTML.idl: Removed.
- page/DOMWindow.idl:
- 4:08 PM Changeset in webkit [109629] by
-
- 9 edits1 add1 delete in trunk/LayoutTests
Unreviewed, rebaseline some SVG tests after r105612.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-invalidation-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium/test_expectations.txt:
- 3:59 PM Changeset in webkit [109628] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80148
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- xml/DOMWindowXML.idl: Removed.
- 3:57 PM Changeset in webkit [109627] by
-
- 3 edits in trunk/Source/JavaScriptCore
When getting the line number of a call into a call frame with no code block, it's
incorrect to rely on the returnPC
https://bugs.webkit.org/show_bug.cgi?id=80195
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- 3:49 PM Changeset in webkit [109626] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, widen flaky crash expectations for FileWriter test.
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [109625] by
-
- 2 edits1 move12 adds1 delete in trunk/LayoutTests
Unreviewed rebaselining, update a bunch of old results for Snow Leopard.
- platform/chromium-linux/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.txt: Added.
- platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt.
- platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
- platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [109624] by
-
- 5 edits in branches/subpixellayout/Source/WebCore/rendering
Clean up paintInfo and absoluteBoundingBox calling code on branch.
- 3:34 PM Changeset in webkit [109623] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix. Don't add an event listener for interactive debugging
when the test is ran inside a DumpRenderTree / WebKitTestRunner.
- editing/selection/select-line-break-with-opposite-directionality.html:
- 3:24 PM Changeset in webkit [109622] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix a ChangeLog typo.
- 3:23 PM Changeset in webkit [109621] by
-
- 2 edits in trunk/Source/WebKit2
Remove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
https://bugs.webkit.org/show_bug.cgi?id=80197
Reviewed by Alexey Proskuryakov.
It doesn't belong there, and it makes the Xcode consider the project to
be invalid, triggering assertions in some builds of Xcode.
- WebKit2.xcodeproj/project.pbxproj:
- 3:10 PM Changeset in webkit [109620] by
-
- 4 edits in trunk
Make webkit-gtk translations respect LINGUAS
https://bugs.webkit.org/show_bug.cgi?id=79605
Patch by Alexandre Rostovtsev <tetromino@gentoo.org> on 2012-03-02
Reviewed by Martin Robinson.
.:
PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS added to root
GNUmakefile.am to ensure that they can be used in the definition of
MOFILES that will be generated by automake.
- GNUmakefile.am:
Source/WebKit/gtk/po:
- GNUmakefile.am:
- 2:48 PM Changeset in webkit [109619] by
-
- 4 edits in trunk/Source/WebCore
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188
Reviewed by Ryosuke Niwa.
Using setNamedItem() in setAttributeNode() implementation made us do unnecessary
checks like whether the element existed or whether the given node was an
attribute. So now setAttributeNode() do less work.
No new tests were added, functionality should be unchanged.
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
- dom/Element.h:
(Element):
(WebCore::Element::attributes): We got rid of ensureUpdatedAttributes(), next in
line will be updatedAttributes().
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
- 2:44 PM Changeset in webkit [109618] by
-
- 2 edits in trunk/Source/JavaScriptCore
Expected results updated for checking type conversion
https://bugs.webkit.org/show_bug.cgi?id=80138
Patch by Han Hojong <hojong.han@samsung.com> on 2012-03-02
Reviewed by Gavin Barraclough.
- tests/mozilla/ecma/TypeConversion/9.3.1-3.js:
- 2:41 PM Changeset in webkit [109617] by
-
- 7 edits6 copies3 moves4 adds34 deletes in trunk/LayoutTests
Unreviewed, rolling out r109602.
http://trac.webkit.org/changeset/109602
https://bugs.webkit.org/show_bug.cgi?id=80194
some TEXT baselines were wrong and some baselines were wrongly
removed (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-02
- platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Removed.
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium-mac/fast/clip/008-expected.png: Added.
- platform/chromium-mac/fast/clip/011-expected.png: Added.
- platform/chromium-mac/fast/clip/012-expected.png: Added.
- platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win/fast/clip/008-expected.txt:
- platform/chromium-win/fast/clip/011-expected.txt:
- platform/chromium-win/fast/clip/012-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- 2:34 PM Changeset in webkit [109616] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Widen/correct a few chromium expectations.
- platform/chromium/test_expectations.txt:
- 2:25 PM Changeset in webkit [109615] by
-
- 2 edits in trunk/PerformanceTests
DOM tests take too long to run
https://bugs.webkit.org/show_bug.cgi?id=80082
Reviewed by Eric Seidel.
Reduce benchmark.timeToRun from 500ms to 100ms. Doesn't seem to affect test results much
(except DOM/DOMTable.html) but significantly reduces the runtime of tests.
- DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):
- 2:16 PM Changeset in webkit [109614] by
-
- 2 edits in trunk/LayoutTests
Rebaseline an inspector test after r109599.
"evt" was changed to "event", lengthening it by two characters.
Unreviewed gardening.
- platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
- 2:00 PM Changeset in webkit [109613] by
-
- 2 edits in trunk/Tools
Add the Chromium Lion canary bot to the flakiness dashboard.
- TestResultServer/static-dashboards/builders.js:
- 1:59 PM Changeset in webkit [109612] by
-
- 4 edits3 adds in trunk
Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684
Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.
Source/WebCore:
The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.
Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
LayoutTests:
- fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.
Test case to check un-clipped border logic
- platform/chromium/test_expectations.txt:
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- 1:45 PM Changeset in webkit [109611] by
-
- 12 edits in trunk/Source/WebCore
[V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947
Reviewed by Adam Barth.
This changes the generated bindings code to only generate the Document code for the Document wrappers.
No new tests. Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 1:40 PM Changeset in webkit [109610] by
-
- 3 edits2 adds in trunk
animation-timing-function falls back to ease when overriding animation-name
https://bugs.webkit.org/show_bug.cgi?id=71623
Source/WebCore:
In this patch the animation name needs to be the first value declared, if
a different value is found, we do not check for the animation name again.
Reviewed by Dean Jackson.
Test: animations/animation-shorthand-overriding.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
LayoutTests:
Add a test to verify if the override the animation-name property works when the parent
animation did not set the animation name.
Reviewed by Dean Jackson.
- animations/animation-shorthand-overriding-expected.txt: Added.
- animations/animation-shorthand-overriding.html: Added.
- 1:37 PM Changeset in webkit [109609] by
-
- 6 edits1 move1 add1 delete in trunk/Source/WebCore
[GTK] [AC] Connect WebGL to the TextureMapperGL code
https://bugs.webkit.org/show_bug.cgi?id=78968
Reviewed by Gustavo Noronha Silva.
No new tests. This is covered by existing accelerated compositing and
WebGL tests.
Rely on the shared version of GL acquisition from GLContext. This reduces
a lot of code and now allows us to connect WebGL into the accelerated compositing
rendering path.
- GNUmakefile.list.am: GLContext should be included for all X11 builds now.
There are no longer GTK+ specific versions of GraphicsContext3D.
- platform/graphics/GraphicsContext3D.h: Add a default argument for
resolveMultisamplingIfNecessary. This will resolve the entire texture.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp: GraphicsContext3D is
now responsible for creating GraphicsContext3DPrivate in the constructor.
(WebCore::GraphicsContext3D::platformLayer): Now return m_private.
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Added.
- platform/graphics/cairo/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h.
- platform/graphics/glx/GraphicsContext3DPrivate.cpp: Removed.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Properly
handle the default argument.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Use the new default argument now.
(WebCore::GraphicsContext3D::readRenderingResults): Ditto.
- 1:33 PM Changeset in webkit [109608] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix spelling mistake in header guard
Reviewed by Noam Rosenthal.
- 1:32 PM Changeset in webkit [109607] by
-
- 2 edits in trunk
[Qt] Remove deleted file from api.pro
Reviewed by Noam Rosenthal.
- 1:13 PM Changeset in webkit [109606] by
-
- 3 edits in trunk/Tools
links for virtual tests are broken in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80180
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
(linkHTMLToOpenWindow):
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testLinkHTMLToOpenWindow): added.
- 1:08 PM Changeset in webkit [109605] by
-
- 5 edits3 adds2 deletes in trunk/Source
[GTK] [AC] Generalize WindowContextGL
https://bugs.webkit.org/show_bug.cgi?id=78969
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
No new tests. This should not change functionality.
- GNUmakefile.list.am: Added new files to source list.
- platform/graphics/cairo/GLContext.h: Added. An abstraction for all GL contexts.
- platform/graphics/glx/GLContextGLX.cpp: Added. This file is composed of very little
new code, as the logic for instantiating offscreen GL contexts is copied from
GraphicsContext3DPrivate. The code duplication will be removed in a followup patch.
(WebCore::GLContext::platformContext):
- platform/graphics/gtk/GLContextGtk.cpp: Added. This includes some helper factories
for creating and caching GL contexts for GTK+ widgets.
Source/WebKit/gtk:
Use GLContext instead of WindowContextGL. Remove a few unnecessary
namespace specifiers in the implementation of AcceleratedCompositingContext.
- WebCoreSupport/AcceleratedCompositingContext.h: Now we find the GLContext
of our widget, which is cached in WebCore. Remove m_initialized as it isn't needed.
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): No longer initialize
m_initialized.
(WebKit::AcceleratedCompositingContext::glContext): Added.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Use glContext() now.
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer): Ditto.
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted): Remove unnecessary namespace specifier.
(WebKit::AcceleratedCompositingContext::notifySyncRequired): Ditto.
(WebKit::AcceleratedCompositingContext::paintContents): Ditto.
(WebKit::AcceleratedCompositingContext::showDebugBorders): Ditto.
(WebKit::AcceleratedCompositingContext::showRepaintCounter): Ditto.
- 12:58 PM Changeset in webkit [109604] by
-
- 6 edits2 adds in trunk/LayoutTests
new baselines for Skia shadows
Unreviewed rebaselining.
- platform/chromium-win-vista/svg/css/group-with-shadow-expected.png:
- platform/chromium-win-xp/svg/css: Added.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium-win/svg/css/group-with-shadow-expected.png:
- platform/chromium/test_expectations.txt:
- 12:54 PM Changeset in webkit [109603] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Suppress an inspector test timing out after r109561.
- platform/chromium/test_expectations.txt:
- 12:45 PM Changeset in webkit [109602] by
-
- 7 edits40 adds13 deletes in trunk/LayoutTests
Unreviewed Chromium rebaselining.
Those tests have consistent results with other platforms and with the expected
result so unmark and rebaseline them.
- platform/chromium-linux-x86/fast/box-shadow: Added.
- platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
- platform/chromium-mac/fast/clip/008-expected.png: Removed.
- platform/chromium-mac/fast/clip/011-expected.png: Removed.
- platform/chromium-mac/fast/clip/012-expected.png: Removed.
- platform/chromium-win-vista/fast/box-shadow: Added.
- platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win-xp/fast/box-shadow: Added.
- platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win/fast/clip/008-expected.txt:
- platform/chromium-win/fast/clip/011-expected.txt:
- platform/chromium-win/fast/clip/012-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
- 12:39 PM Changeset in webkit [109601] by
-
- 2 edits9 adds in trunk/LayoutTests
Rebaselining SVG foreignObject tests after r108494.
Unreviewed gardening.
- platform/chromium-linux/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-mac-leopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 12:34 PM Changeset in webkit [109600] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove TRACE_EVENT from CCQuadCuller::cullOccludedQuads.
https://bugs.webkit.org/show_bug.cgi?id=80174
Reviewed by James Robinson.
Covered by existing chromium unit tests.
Firing TRACE_EVENT once per draw quad is overwhelming.
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
- 12:30 PM Changeset in webkit [109599] by
-
- 3 edits2 adds in trunk
[V8] Make inline event attributes use evt for SVG and event otherwise
https://bugs.webkit.org/show_bug.cgi?id=80167
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/dom/inline-event-attributes-event-param-name.html
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
LayoutTests:
- fast/dom/inline-event-attributes-event-param-name-expected.txt: Added.
- fast/dom/inline-event-attributes-event-param-name.html: Added.
- 12:11 PM Changeset in webkit [109598] by
-
- 2 edits in trunk/Source/WebCore
Sync PageCache debugging with PageCache behaviour
https://bugs.webkit.org/show_bug.cgi?id=79943
Sync up the debug printing code in PageCache with the actual logic,
and clean up the debug printing at the same time.
Reviewed by Brady Eidson.
No new tests, as this is a refactor of debug only code.
- history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
- 12:07 PM Changeset in webkit [109597] by
-
- 2 edits in trunk/LayoutTests
Fix expectation for svg/foreignObject/fO-parent-display-changes.svg.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 12:05 PM Changeset in webkit [109596] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, suppress some failures in shadow tests due to the skia roll.
- platform/chromium/test_expectations.txt:
- 12:01 PM Changeset in webkit [109595] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout test fast/events/overflow-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=52064
Reviewed by Simon Fraser.
Try to make the test less flaky.
- fast/events/overflow-events.html:
Ensure that the 'overflow' events arrive one at a time in order (there is no guarantee that they *do* dispatch
though). Also added a clearer message if we fail the test. That should help us if the test is still flaky.
- 11:58 AM Changeset in webkit [109594] by
-
- 6 edits4 adds in trunk
Source/WebCore: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
<rdar://problem/10432233>
Reviewed by Antti Koivisto.
Test: fast/dom/Window/navigated-window-properties.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore): Remove custom getters for window.location and window.history; they
were unnecessary and did the wrong thing when DOMWindow returned null values
for these.
- page/DOMWindow.idl: ditto
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException): Remove assert about null values and update comment,
since this is now an expected state for navigated inner windows.
LayoutTests: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
Reviewed by Antti Koivisto.
- fast/dom/Window/navigated-window-properties-expected.txt: Added.
- fast/dom/Window/navigated-window-properties.html: Added.
- fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
- fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
- 11:54 AM Changeset in webkit [109593] by
-
- 9 edits2 adds in trunk
REGRESSION(r74971): Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by inline text boxes created by BRs being placed at the end of the line
according to the block's direction regardless of its unicode bidi-level. e.g. if we have
<div dir="rtl"><span dir="ltr">hello<br>world</span></div>
the inline box generated by the br has the bidi-level of 2 like the rest of text in the span.
This inline text box gives an illusion of having text on the left of "hello" to hit testing
and editing code and causes all sorts of problems.
Fixed the bug by replacing calls to nextLeafChild and prevLeafChild by newly introduced
nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak. These two functions will
return 0 when they hit the end of a line or inline text box that's a line break. In effect,
hit testing and editing code can ignore inline boxes generated by br's.
In the long term, we should move these two functions into RenderedPosition along with the rest
of code that converts a Position and an inline box, offset pair.
Test: editing/selection/select-line-break-with-opposite-directionality.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::prevLeafChild):
(WebCore::RenderedPosition::nextLeafChild):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):
(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):
- rendering/InlineBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
- rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): If we're on the left of a RTL line, we should stay at
upstream position since we're at the end of a line.
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi): Merge the two special cases into
the general loop as the comment suggests. Skip an inline text box for a line break at the left
edge when there are more line boxes on the line.
(WebCore::RenderText::positionForPoint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): Ignore line boxes created for
line boxes when there are other boxes on the line.
LayoutTests:
Add a regression test for selecting multiline bidirectional text.
- editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
- editing/selection/select-line-break-with-opposite-directionality.html: Added.
- 11:48 AM Changeset in webkit [109592] by
-
- 7 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=80161
PR: 141157
BlackBerryPlatformScreen.h API has been updated. Reflect those
changes in our usage.
Source/WebCore:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenAvailableRect):
(WebCore::screenRect):
Source/WebKit/blackberry:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::tileWidth):
(BlackBerry::WebKit::BackingStorePrivate::tileHeight):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::createCompositingSurface):
- 11:47 AM Changeset in webkit [109591] by
-
- 14 edits1 move7 adds2 deletes in trunk/LayoutTests
Chromium rebaselines after r109512.
Unreviewed gardening.
- platform/chromium-linux/fast/block/float/026-expected.png:
- platform/chromium-linux/fast/block/float/028-expected.png:
- platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-mac-leopard/fast/block/float/026-expected.png:
- platform/chromium-mac-leopard/fast/block/float/028-expected.png:
- platform/chromium-mac-leopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium/fast/events/offsetX-offsetY-expected.txt.
- platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
- platform/chromium-mac/fast/block/float/026-expected.png: Removed.
- platform/chromium-mac/fast/block/float/028-expected.png: Removed.
- platform/chromium-win/fast/block/float/026-expected.png:
- platform/chromium-win/fast/block/float/026-expected.txt:
- platform/chromium-win/fast/block/float/028-expected.png:
- platform/chromium-win/fast/block/float/028-expected.txt:
- platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
- platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:44 AM Changeset in webkit [109590] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Allow plugins to set opaque() on their platform layer
https://bugs.webkit.org/show_bug.cgi?id=80171
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-02
Reviewed by James Robinson.
- public/WebPluginContainer.h:
(WebPluginContainer):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 11:41 AM Changeset in webkit [109589] by
-
- 2 edits in trunk/Source/WebCore
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Unreviewed build fix.
- rendering/RenderBlock.cpp:
(OverflowEventDispatcher): Removed the unused function.
- 11:28 AM Changeset in webkit [109588] by
-
- 111 edits3 adds29 deletes in trunk/LayoutTests
Unreviewed rebaselining of images affected by these changes:
https://bugs.webkit.org/show_bug.cgi?id=76556 ('Match style of platform error underline for misspellings')
https://bugs.webkit.org/show_bug.cgi?id=78117 ('[Skia Mac] Make misspelling underline dots unclipped')
- platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png:
[139 lines deleted]
- platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:24 AM Changeset in webkit [109587] by
-
- 6 edits2 adds in trunk
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/events/overflow-events-writing-mode.html
This moves the 'overflow' event dispatch from RenderLayer to an helper class
OverflowEventDispatcher. For now, the class lives in RenderBlock as it matches
the existing code but it may be moved later to its own class as FrameView could
benefit from it too or if we need to support 'overflow' events on RenderBoxes.
- rendering/RenderBlock.cpp:
(WebCore):
(OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::~OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::computeOverflowStatus):
RAII dispatcher class that stores the information before layout and compare
them after to dispatch the right information.
(WebCore::RenderBlock::layout): Added an instance of OverflowEventDispatcher.
- rendering/RenderBox.h:
(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):
Helper method to know if we have an horizontal / vertical layout overflow.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
Removed the scroll tracking logic as we don't need it anymore. This removes
3 booleans from RenderLayer.
LayoutTests:
- fast/events/overflow-events-writing-mode.html: Added.
- fast/events/overflow-events-writing-mode-expected.txt: Added.
Added a test for overflow events in a vertical writing mode.
- 11:05 AM Changeset in webkit [109586] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline a test on Leopard after expectation was removed in r109516.
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
- 11:02 AM Changeset in webkit [109585] by
-
- 8 edits in trunk/Source/WebCore
Create a method in Element to compare attributes with other Element
https://bugs.webkit.org/show_bug.cgi?id=80169
Reviewed by Ryosuke Niwa.
Avoid manually peeking at attribute storage to get this information. This
simplify the callsites. The actual implementation of comparison was moved to
ElementAttributeData. The mapsEquivalent() function still exists for the sake
of DocumentType nodes.
- dom/Element.cpp:
(WebCore::Element::hasEquivalentAttributes):
(WebCore):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::isEquivalent):
(WebCore):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mapsEquivalent):
- dom/Node.cpp:
(WebCore::Node::isEqualNode):
- editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Use Element::hasTagName() instead of matching
directly to make code a bit clearer.
- 10:03 AM Changeset in webkit [109584] by
-
- 7 edits in trunk/Source
[GTK] Smooth scrolling support
https://bugs.webkit.org/show_bug.cgi?id=16123
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-02
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - no new functionality.
Add the ScrollAnimatorNone class to compilation and enable
the smooth scrolling feature by default at compilation time.
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit/gtk:
Add a new settings option to enable smooth scrolling.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 9:40 AM Changeset in webkit [109583] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=80160
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
Previously when executing window.devicePixelRatio these two pages returned 1 now
they report the devicePixelRatio returned by computeViewportAttributes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 8:55 AM Changeset in webkit [109582] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r109581.
- platform/gtk/security/block-test-expected.txt:
- 8:45 AM Changeset in webkit [109581] by
-
- 4 edits1 add in trunk
[GTK] security/block-test.html baselines differ from mac
https://bugs.webkit.org/show_bug.cgi?id=78343
Reviewed by Martin Robinson.
Tools:
Improved the FrameLoader error heuristics to match mac behavior a
bit more.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(pathFromSoupURI): Handle ftp urls the same as http urls.
(descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
LayoutTests:
GTK baselines updates for two security tests. They're closer to
the mac baselines now.
- platform/gtk/security/block-test-expected.txt: Added.
- platform/gtk/security/block-test-no-port-expected.txt:
- 8:40 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:38 AM Changeset in webkit [109580] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] media/media-can-play-flac-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=80124
Reviewed by Martin Robinson.
Handle audio/x-flac in the mimeTypeCache() function so that we
advertize both audio/flac and audio/x-flac.
No new tests, this is covered already by media/media-can-play-flac-audio.html.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- 8:37 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:37 AM Changeset in webkit [109579] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109578
- 8:30 AM Changeset in webkit [109578] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalid check in webkit_web_view_set_zoom_level() when zoom-text-only is enabled
https://bugs.webkit.org/show_bug.cgi?id=80150
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_zoom_level() instead of
WKPageGetPageZoomFactor() to get the current effective zoom level
depending on zoom-text-only setting.
- 8:21 AM Changeset in webkit [109577] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=80154
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
- 7:36 AM Changeset in webkit [109576] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Fix typo in patch committed in r109575
Unreviewed typo fix.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Cache the position
in floating point coordinates.
- 7:27 AM Changeset in webkit [109575] by
-
- 5 edits in trunk/Tools
[Qt][WK2] Infinite loop on history navigation, when panning
https://bugs.webkit.org/show_bug.cgi?id=79119
Reviewed by Simon Hausmann.
Make the touch mocking more robust by creating touch events
directly and sending them synchronously to the browser window.
If the sent touch event was not accepted we propagate the
original mouse event to its target.
This way we make sure we only send either a touch or a mouse
event and do not end up in an infinite loop between our mocking
code and the Qt5 automatic mouse event synthesizing.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(touchRectForPosition):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
- MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication):
- 7:14 AM Changeset in webkit [109574] by
-
- 14 edits in trunk
Rename DOMURL to URL in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78214
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-03-02
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. Interface name change.
- html/DOMURL.idl: Added InterfaceName attribute to DOMURL.
LayoutTests:
- fast/files/domurl-script-execution-context-crash-expected.txt:
- fast/files/domurl-script-execution-context-crash.html:
- fast/js/constructor-length.html:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 6:26 AM Changeset in webkit [109573] by
-
- 5 edits2 adds in trunk
Add :scope pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=79077
Source/WebCore:
Add :scope pseudo class name & pseudoId
Add selector check for the new pseudo-class
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/scope-pseudo.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
LayoutTests:
Test new :scope pseudo-class
Reviewed by Antti Koivisto.
- fast/css/style-scoped/scope-pseudo-expected.txt: Added.
- fast/css/style-scoped/scope-pseudo.html: Added.
- 6:25 AM Changeset in webkit [109572] by
-
- 11 edits in trunk/Source/WebKit/qt
[Qt] Documentation cleanup
https://bugs.webkit.org/show_bug.cgi?id=80131
Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-03-02
Reviewed by Simon Hausmann.
QDoc uses different commands to do bold, lists, and italics.
This change updates the documentation accordingly.
QTBUG-24578
- Api/qwebframe.cpp:
- Api/qwebhistory.cpp:
- Api/qwebinspector.cpp:
- Api/qwebpage.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsettings.cpp:
- declarative/qdeclarativewebview.cpp:
- docs/qtwebkit-bridge.qdoc:
- docs/qtwebkit.qdoc:
- docs/qtwebkit.qdocconf:
- 6:16 AM Changeset in webkit [109571] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- 6:07 AM Changeset in webkit [109570] by
-
- 18 edits in trunk/Source
Make parser code not depend on NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=79963
Reviewed by Adam Barth.
Source/WebCore:
Instead of creating Element-less NamedNodeMaps, the parsing code now creates
AttributeVectors, that are used to fill Element via the parserSetAttributes()
method. This allows us to remove even more methods from the NamedNodeMap.
The AttributeVector class contains convenience methods that take the attribute's
QualifiedName as parameter. This class is also used inside ElementAttributeData.
- dom/Attr.h:
(Attr):
- dom/Element.cpp:
(WebCore::Element::getAttribute):
(WebCore::Element::parserSetAttributes): Now we have to create the attribute
storage, and fill it (by Vector::swap()) with the passed attributes. Also use an
early return to reduce indentation.
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
- dom/Element.h:
(Element):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
- dom/ElementAttributeData.cpp:
(WebCore::AttributeVector::removeAttribute):
(WebCore):
- dom/ElementAttributeData.h:
(AttributeVector):
(WebCore::AttributeVector::create):
(WebCore::AttributeVector::attributeItem):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute): Boolean parameter isn't necessary
since all the callers used 'false', indicating that duplicates were not allowed.
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::mapsEquivalent):
- dom/NamedNodeMap.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore):
- html/parser/HTMLTreeBuilder.h:
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAttributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
- xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
Source/WebKit/chromium:
- src/WebNamedNodeMap.cpp:
(WebKit::WebNamedNodeMap::attributeItem):
- 5:53 AM Changeset in webkit [109569] by
-
- 2 edits in trunk/Tools
[Qt] Use 'all' as default target when debug_and_release is in effect
When debug_and_release is enabled, in combination with build_all,
qmake will generate an aggregate makefile that calls make on both
the debug and the release makefiles, but with the 'all' target.
In this case we can't use 'first' as the default target, as the
extra targets would then not be run, so we append extra targets
to 'all' instead.
Reviewed by Simon Hausmann.
- 5:48 AM Changeset in webkit [109568] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: assertion failure in JSMainThreadExecState::instrumentedCall
https://bugs.webkit.org/show_bug.cgi?id=80152
Extracted common code of JS call instrumentation into instrumentFunctionCall method
and call it directly where the instrumentation is needed instead of calling
JSMainThreadExecState::instrumentedCall which works on the main thread only.
Reviewed by Pavel Feldman.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
- 5:46 AM Changeset in webkit [109567] by
-
- 2 edits in trunk/Tools
[Qt] Make sure activeBuildConfig() returns the right config
Using isActiveConfig fails, as that only checks if the given
argument is in CONFIG, not the order.
Reviewed by Simon Hausmann.
- 5:35 AM Changeset in webkit [109566] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/Skipped: Unskip non-existent files.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- 5:31 AM Changeset in webkit [109565] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80101
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
- html/HTMLTextAreaElement.idl: Reorder attribute/method position.
- 5:30 AM Changeset in webkit [109564] by
-
- 3 edits in trunk/Source/WebCore
Build fix after r109538.
- CMakeLists.txt:
- Modules/websockets/WebSocketDeflater.cpp:
- 5:27 AM Changeset in webkit [109563] by
-
- 10 edits2 adds in trunk
Scoped stylesheets don't appear to work in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79549
Source/WebCore:
Make the scope stack in CSSStyleSelector use ContainerNode* instead of Element*.
Adapt using sites accordingly.
Push the ShadowRoot to the scope stack in the same way that elements are pushed.
Fix an issue with removedFromDocument() on destruction.
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/style-scoped-in-shadow.html
- css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::ruleSetForScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::setupScopeStack):
(WebCore::CSSStyleSelector::pushScope):
(WebCore):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::pushParentElement):
(WebCore::CSSStyleSelector::popParentElement):
(WebCore::CSSStyleSelector::pushParentShadowRoot):
(WebCore::CSSStyleSelector::popParentShadowRoot):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::pushScope):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::CSSStyleSelector::scopeStackIsConsistent):
(WebCore::CSSStyleSelector::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
- css/SelectorChecker.h:
(SelectorCheckingContext):
- dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
(WebCore):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFromDocument):
LayoutTests:
Test that <style scoped> works in shadow DOM as direct child of the ShadowRoot
Reviewed by Antti Koivisto.
- fast/css/style-scoped/style-scoped-in-shadow-expected.txt: Added.
- fast/css/style-scoped/style-scoped-in-shadow.html: Added.
- 5:24 AM Changeset in webkit [109562] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80097
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
- html/HTMLSelectElement.idl: Reorder attribute/method position.
- 5:22 AM Changeset in webkit [109561] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80146
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
- 5:15 AM Changeset in webkit [109560] by
-
- 3 edits in trunk
Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
- 5:06 AM WebKitGTK/1.8.x edited by
- (diff)
- 4:59 AM Changeset in webkit [109559] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Build fix for LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80099
Unreviewed build fix.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- 4:58 AM Changeset in webkit [109558] by
-
- 4 edits in trunk/Source
Fix build on AppleWebKit after 109548.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- mac/WebKit2.order:
- 4:47 AM Changeset in webkit [109557] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLOptionElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80095
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLOptionElement.idl: Reorder attribute/method position.
- 4:45 AM Changeset in webkit [109556] by
-
- 12 edits3 adds in trunk/Source/WebCore
WorkerContext shouldn't know about IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=80094
Reviewed by Kentaro Hara.
There are still a couple IndexedDB stragglers we should clean up in
WebCore proper. This patch moves some IndexedDB logic from
WorkerContext into the indexeddb module.
In the process of writing this patch, I noticed that some IndexedDB
files were missing from various build systems, so I added them. I
suspect that means IndexedDB is only enabled by default on Chromium.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/indexeddb/WorkerContextIndexedDatabase.cpp: Added.
(WebCore):
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::~WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
(WebCore::WorkerContextIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/WorkerContextIndexedDatabase.h: Added.
(WebCore):
(WorkerContextIndexedDatabase):
- Modules/indexeddb/WorkerContextIndexedDatabase.idl: Added.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WebCore):
(WorkerContext):
- workers/WorkerContext.idl:
- 4:45 AM Changeset in webkit [109555] by
-
- 5 edits in trunk
[Qt] Fix tests run with WTR not using QStyle theme
https://bugs.webkit.org/show_bug.cgi?id=80147
Reviewed by Csaba Osztrogonác.
Source/WebKit2:
Use an environment variable (set by WTR) to select the QStyle theme.
This is a temporary kludge until we rebase the layout tests to use the
QStyle independent "mobile" theme. This also temporarily breaks the
force_static_libs_as_shared build.
- Target.pri:
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
Tools:
- WebKitTestRunner/qt/main.cpp:
(main): Set environment variable for web process to use QStyle theme.
- 4:29 AM Changeset in webkit [109554] by
-
- 4 edits1 delete in trunk
Tools: Unreviewed, remove debug print call.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(descriptionSuitableForTestResult):
LayoutTests: Unreviewed, unskip security/block-test.html and remove its GTK
baseline, the platform-agnostic baseline match.
- platform/gtk/Skipped:
- platform/gtk/security/block-test-expected.txt: Removed.
- 4:23 AM Changeset in webkit [109553] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 4:16 AM Changeset in webkit [109552] by
-
- 8 edits in trunk
[Qt] Compile WebCore without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=80141
Reviewed by Tor Arne Vestbø.
.:
- Source/api.pri: Use QT += opengl for the WebKit1 bits, such as the QGLWidget
usage in PageClientQt.cpp. Previously this dependency came implicitly through WebCore.pri.
Source/WebCore:
- Target.pri: Don't add widgets to QT.
- WebCore.pri: Use QT += opengl only with Qt 4, because it has an implicit QtWidgets
dependency. With Qt 5 all necessary OpenGL API is part of QtGui (with a QOpenGL* prefix).
Source/WebKit2:
- Shared/qt/WebEventFactoryQt.cpp: Removed unnecessary include.
- Target.pri: Require widgets for WK2 for the moment, until bug #79458
is fixed.
- 3:57 AM Changeset in webkit [109551] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLFormElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80093
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes
- html/HTMLFormElement.idl: Reorder attribute/method position.
- 3:54 AM Changeset in webkit [109550] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLButtonElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80091
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLButtonElement.idl: Reorder attribute/method position.
- 3:43 AM Changeset in webkit [109549] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Build system cleanup
Rubber-stamped by Antti Koivisto.
- tests/MIMESniffing/MIMESniffing.pro: Don't link in WTFAssertions.cpp for ASSERT, now
that the symbols are properly exported with export macros from the DLL.
- 3:40 AM Changeset in webkit [109548] by
-
- 15 edits in trunk/Source
Suspend/Resume API for pausing timers and animations.
https://bugs.webkit.org/show_bug.cgi?id=76063
Source/WebCore:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
- dom/ActiveDOMObject.h:
New ReasonForSuspension: PageWillBePaused.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend): Handle new ReasonForSuspension.
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setDocument):
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- page/Frame.h:
(WebCore::Frame::activeDOMObjectsAndAnimationsSuspended):
Frame now maintains a state of suspending animation and ActiveDOMObjects,
which is inherited to all child-frames.
- page/Page.cpp:
(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
- page/Page.h:
Functions for suspending and resuming active DOM objects and animations in all frames.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
WillRenderImage now checks for suspension. This causes animated images to pause
together with all other types of animations.
Source/WebKit2:
Based on the initial work of Zalan Bujtas <zalan.bujtas@nokia.com>,
Adds suspend and resume API for WebKit2 and uses it in Qt to
suspend animations and DOM timers during panning and zoom.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:33 AM Changeset in webkit [109547] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLFieldSetElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80092
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLFieldSetElement.idl: Reorder attribute/method position.
- 3:28 AM Changeset in webkit [109546] by
-
- 3 edits in trunk/Source/WebCore
possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676
Rubber-stamped by Simon Hausmann.
Remove the speculative fix (the problem was elsewhere, http://trac.webkit.org/changeset/104845).
Also remove the debugging code added for this bug.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
(Document):
- 3:16 AM Changeset in webkit [109545] by
-
- 11 edits in trunk
Web Inspector: Implement suggestions in Watch Expressions
https://bugs.webkit.org/show_bug.cgi?id=79912
Source/WebCore:
Drive-by: make subproperties in ObjectPropertySections editable
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completionsForTextPrompt):
- inspector/front-end/DatabaseQueryView.js:
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.renderPromptAsBlock):
(WebInspector.ObjectPropertyTreeElement.prototype.elementAndValueToEdit):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing.blurListener):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted):
(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):
(WebInspector.ObjectPropertyPrompt):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.renderPromptAsBlock):
(WebInspector.WatchExpressionTreeElement.prototype.elementAndValueToEdit):
(WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
- inspector/front-end/inspector.css:
(.watch-expressions > li.editing-sub-part .text-prompt):
LayoutTests:
Reviewed by Pavel Feldman.
- http/tests/inspector/console-cd-completions.html:
- inspector/debugger/debugger-completions-on-call-frame.html:
- 2:55 AM Changeset in webkit [109544] by
-
- 4 edits in trunk
[EFL] Build warning : comparison between signed and unsigned integer expressions.
https://bugs.webkit.org/show_bug.cgi?id=79860
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-03-02
Reviewed by Hajime Morita.
Fixed build warnings which are getting generated when comparing signed
and unsigned integer expressions.
- Source/WebCore/bindings/js/JSDocumentCustom.cpp:
- Source/WebCore/platform/ContextMenu.cpp:
- Source/WebKit/efl/ewk/ewk_view_single.cpp:
- 2:46 AM Changeset in webkit [109543] by
-
- 3 edits3 adds in trunk
REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: fast/css/pending-stylesheet-repaint.html
If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.
- dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
LayoutTests:
- fast/css/pending-stylesheet-repaint-expected.png: Added.
- fast/css/pending-stylesheet-repaint-expected.txt: Added.
- fast/css/pending-stylesheet-repaint.html: Added.
- 2:43 AM Changeset in webkit [109542] by
-
- 11 edits1 copy3 moves in trunk
[Qt] Move QStyle theming code out of WebCore into WebKit1
https://bugs.webkit.org/show_bug.cgi?id=80128
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/api.pri: Adjust to moving source files.
Source/WebCore:
Moved QStyle dependant code into WebKit1, where it's okay to depend on
QtWidgets/QStyle. Added factory hooks into RenderThemeQt to allow changing
the default "mobile" style to QStyle on start-up.
- Target.pri:
- platform/qt/RenderThemeQt.cpp:
(WebCore):
(WebCore::RenderThemeQt::setCustomTheme):
(WebCore::RenderThemeQt::customScrollbarTheme):
(WebCore::createTheme):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
- platform/qt/RenderThemeQt.h:
(WebCore):
(RenderThemeQt):
- platform/qt/RenderThemeQtMobile.cpp:
- platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
Source/WebKit/qt:
Moved the bulk of the QStyle dependant code here, where it's okay to depend on QtWidgets/QStyle.
Install the QStyle factory functions in initWebCoreQt.cpp.
- Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
- WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
- WebCoreSupport/ScrollbarThemeQStyle.cpp: Copied from Source/WebCore/platform/qt/ScrollbarThemeQt.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):
- WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQt.h.
(WebCore):
(ScrollbarThemeQStyle):
- 2:40 AM Changeset in webkit [109541] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColumnRuleStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80085
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 2:39 AM Changeset in webkit [109540] by
-
- 16 edits in trunk/Source/WebCore
Web Inspector: enable Timeline panel for workers
https://bugs.webkit.org/show_bug.cgi?id=80130
Enabled Timeline panel for worker inspector. Refactored
JS function calls instrumentation to work for both
worker contexts and documents.
Reviewed by Pavel Feldman.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore):
(WebCore::JSMainThreadExecState::instrumentedCall):
- bindings/js/ScriptState.cpp:
(WebCore::scriptExecutionContextFromScriptState):
(WebCore):
- bindings/js/ScriptState.h:
(WebCore):
- bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::scriptExecutionContext):
(WebCore):
(WebCore::scriptExecutionContextFromScriptState):
- bindings/v8/ScriptState.h:
(WebCore):
(ScriptState):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::instrumentedCallFunction):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
- inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
- 2:37 AM Changeset in webkit [109539] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK tests expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 2:24 AM Changeset in webkit [109538] by
-
- 18 edits1 copy12 adds in trunk
Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522
Source/JavaScriptCore:
Added USE(ZLIB) flag.
Reviewed by Kent Tamura.
- wtf/Platform.h:
Source/WebCore:
Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.
Reviewed by Kent Tamura.
Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html
- CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.gyp/WebCore.gyp: Added zlib dependency.
- WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
- WebCore.xcodeproj/project.pbxproj: Ditto.
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect): Set m_extensions.
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.
- websockets/WebSocketChannel.h:
- websockets/WebSocketDeflateFramer.cpp: Added.
(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):
- websockets/WebSocketDeflateFramer.h: Added.
(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):
LayoutTests:
Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.
(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
- http/tests/websocket/tests/hybi/send-file-blob_wsh.py:
(_retrieve_frame):
(web_socket_transfer_data):
- platform/efl/Skipped: Skips tests rely on zlib
- platform/qt/Skipped: Ditto.
- 2:21 AM Changeset in webkit [109537] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 1:59 AM Changeset in webkit [109536] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values.
https://bugs.webkit.org/show_bug.cgi?id=79691
Reviewed by Pavel Feldman.
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode.prototype.createCell):
(WebInspector.IDBDataGridNode.prototype._formatValue):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get subtype):
- inspector/front-end/indexedDBViews.css:
(.indexed-db-data-view .data-grid .data-container td):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column div.primitive-value):
(.indexed-db-data-view .data-grid .data-container td .section .header .title):
- 1:57 AM Changeset in webkit [109535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark
fast/frames/flattening/frameset-flattening-advanced.html as flaky in GTK.
- platform/gtk/test_expectations.txt:
- 1:50 AM Changeset in webkit [109534] by
-
- 2 edits in trunk/Tools
Updated EventSender to send complete gesture events.
https://bugs.webkit.org/show_bug.cgi?id=80075
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-02
Reviewed by Adam Barth.
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::gestureEvent): set additional parameters in sent events.
- 1:35 AM Changeset in webkit [109533] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix WebKit2 GTK+ build.
- GNUmakefile.am: allow WebKitWebProcess to link with zlib properly.
- 1:32 AM Changeset in webkit [109532] by
-
- 7 edits in trunk
[Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79765
Patch by Wei James <james.wei@intel.com> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
- webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- webaudio/AudioContext.h:
(WebCore):
(AudioContext):
(WebCore::AudioContext::maxNumberOfChannels):
- webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:30 AM Changeset in webkit [109531] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 1:22 AM Changeset in webkit [109530] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80066
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 1:20 AM Changeset in webkit [109529] by
-
- 8 edits2 adds in trunk
Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-defaultparagraphseparator-command
Test: editing/execCommand/default-paragraph-separator.html
- editing/Editor.cpp:
(WebCore::Editor::Editor):
- editing/Editor.h:
(WebCore::Editor::defaultParagraphSeparator):
(WebCore::Editor::setDefaultParagraphSeparator):
(Editor):
- editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator):
(WebCore):
(WebCore::valueDefaultParagraphSeparator):
(WebCore::createCommandMap):
- editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::create):
(WebCore):
- html/HTMLParagraphElement.h:
(HTMLParagraphElement):
Added create(Document*) method that defaults to pTag as the QualifiedName.
LayoutTests:
- editing/execCommand/default-paragraph-separator-expected.txt: Added.
- editing/execCommand/default-paragraph-separator.html: Added.
- 1:12 AM Changeset in webkit [109528] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix errors in LayerRendererChromium cleanup
https://bugs.webkit.org/show_bug.cgi?id=80064
Reviewed by James Robinson.
Tested manually by forcing lost context while rendering Flash on
Mac OS in a Debug build.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- 1:05 AM Changeset in webkit [109527] by
-
- 3 edits in trunk/Source/WebCore
Fix errors found when building the Mac port with ICONDATABASE disabled.
https://bugs.webkit.org/show_bug.cgi?id=80059
Reviewed by Brady Eidson.
- WebCore.exp.in: Only export IconDatabase symbols when the feature is
enabled.
- loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): WebKit calls this static method, so it
should be defined on the stub class.
(WebCore::IconDatabase::allowDatabaseCleanup): Ditto.
(WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto.
- 12:55 AM Changeset in webkit [109526] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix a warning in InputHandler::learnText()
https://bugs.webkit.org/show_bug.cgi?id=80049
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Fix a warning of the comparison "textInField.length() <=
MaxLearnTextDataSize" in InputHandler::learnText().
Rubber-stamped internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::learnText):
- 12:50 AM Changeset in webkit [109525] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80056
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 12:33 AM Changeset in webkit [109524] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
https://bugs.webkit.org/show_bug.cgi?id=79646
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-02
Reviewed by Andreas Kling.
INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement
and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction
with Ewk_Context_Menu_Action.
To avoid similar case in the feature I added checks between WebCore and
WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_contextmenu.h:
- 12:22 AM WebKitGTK/1.8.x edited by
- Added r109509 as proposed merge (diff)
- 12:15 AM Changeset in webkit [109523] by
-
- 1 edit2 adds in trunk/LayoutTests
reflection computed style test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75902
Reviewed by Ojan Vafai.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/reflection-computed-style-expected.txt: Added.
- css3/calc/reflection-computed-style.html: Added.
- 12:15 AM Changeset in webkit [109522] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for platforms that have DFG_JIT disabled but PARALLEL_GC enabled.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- 12:11 AM Changeset in webkit [109521] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Send didCommitAndDrawFrame after swap
https://bugs.webkit.org/show_bug.cgi?id=80052
Patch by John Bauman <jbauman@chromium.org> on 2012-03-02
Reviewed by James Robinson.
Sending didCommitAndDrawFrame before the swap was causing plugins to
redraw themselves between compositing and the swap, which reduces
opportunities for optimization.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
(WebCore):
(WebCore::CCSingleThreadProxy::didSwapFrame):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- 12:06 AM Changeset in webkit [109520] by
-
- 8 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/Skipped: Skip 2 new failing tests and unskip a new
media test that should pass on GTK.
- platform/gtk/editing/inserting/5994480-2-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/fast/multicol/span/clone-summary-expected.txt:
- 12:04 AM Changeset in webkit [109519] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFGCodeBlocks should not trace CodeBlocks that are also going to be traced by
virtue of being in the transitive closure
https://bugs.webkit.org/show_bug.cgi?id=80098
Reviewed by Anders Carlsson.
If DFGCodeBlocks traces a CodeBlock that might also be traced via its owner Executable,
then you might have the visitAggregate() method called concurrently by multiple threads.
This is benign on 64-bit -- visitAggregate() and everything it calls turns out to be
racy and slightly imprecise but not unsound. But on 32-bit, visitAggregate() may crash
due to word tearing in ValueProfile bucket updates inside of computeUpdatedPrediction().
It would seem that the fix is just to have DFGCodeBlocks not trace CodeBlocks that are
not jettisoned. But CodeBlocks may be jettisoned later during the GC, so it must trace
any CodeBlock that it knows to be live by virtue of it being reachable from the stack.
Hence the real fix is to make sure that concurrent calls into CodeBlock::visitAggregate()
don't lead to two threads racing over each other as they clobber state. This patch
achieves this with a simple CAS loop: whichever thread wins the CAS race (which is
trivially linearizable) will get to trace the CodeBlock; all other threads give up and
go home.
Unfortunately there will be no new tests. It's possible to reproduce this maybe 1/10
times by running V8-v6's raytrace repeatedly, using the V8 harness hacked to rerun it
even when it's gotten sufficient counts. But that takes a while - sometimes up to a
minute to get a crash. I have no other reliable repro case.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
(DFGData):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::clearMarks):
- 12:01 AM Changeset in webkit [109518] by
-
- 7 edits8 adds in trunk
AudioParam needs tests for the parameter automation routines.
https://bugs.webkit.org/show_bug.cgi?id=77666
Patch by Raymond Toy <Raymond Toy> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
Tests: webaudio/audioparam-linearRampToValueAtTime.html
webaudio/audioparam-setTargetValueAtTime.html
webaudio/audioparam-setValueAtTime.html
webaudio/audioparam-setValueCurveAtTime.html
- webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Round the
curveIndex to fix timing issue in setValueCurveAtTime.
LayoutTests:
- webaudio/audioparam-exponentialRampToValueAtTime.html:
- webaudio/audioparam-linearRampToValueAtTime-expected.txt: Added.
- webaudio/audioparam-linearRampToValueAtTime.html: Added.
- webaudio/audioparam-setTargetValueAtTime-expected.txt: Added.
- webaudio/audioparam-setTargetValueAtTime.html: Added.
- webaudio/audioparam-setValueAtTime-expected.txt: Added.
- webaudio/audioparam-setValueAtTime.html: Added.
- webaudio/audioparam-setValueCurveAtTime-expected.txt: Added.
- webaudio/audioparam-setValueCurveAtTime.html: Added.
- webaudio/resources/audioparam-testing.js:
(renderLength):
(createConstantArray):
(createLinearRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction.return.var):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/audio-testing.js: Moved isValidNumber from
biquad-testing.js to here.
- webaudio/resources/biquad-testing.js: Moved isValidNumber from
here to audio-testing.js.
