Timeline

Mar 12, 2012:

11:42 PM Changeset in webkit [110541] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Switch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
​https://bugs.webkit.org/show_bug.cgi?id=80935

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-03-12
Reviewed by Kent Tamura.

ICU seems to have issues with non-well-formed locale strings.
Currently, the only port that uses LocaleToScriptMappingICU.cpp is
Chromium.

No new tests. LocaleToScriptMappingDefault.cpp is already used by
other ports and covered by existing tests.

• WebCore.gyp/WebCore.gyp:

11:15 PM Changeset in webkit [110540] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

Fix test cases for RegExp multiline
​https://bugs.webkit.org/show_bug.cgi?id=80822

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

• tests/mozilla/js1_2/regexp/RegExp_multiline.js:
• tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js:
• tests/mozilla/js1_2/regexp/beginLine.js:
• tests/mozilla/js1_2/regexp/endLine.js:

10:38 PM Changeset in webkit [110539] by commit-queue@webkit.org

• 21 edits
  1 add in trunk/Source/WebCore

Fix IndexedDB build with JSC
​https://bugs.webkit.org/show_bug.cgi?id=80207

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-12
Reviewed by Adam Barth.

This fixes the build of WebKit when IndexedDB is enabled. Most functions were added
empty implementation, it compiles but IndexedDB is not working.

• DerivedSources.make: Added missing IDL files.
• Modules/indexeddb/IDBDatabaseBackendImpl.h: Fix warnings and build errors.

(IDBDatabaseBackendImpl):

• Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: ditto.

(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase): ditto.

• Modules/indexeddb/IDBFactoryBackendImpl.cpp: ditto.

(WebCore::IDBFactoryBackendImpl::openBackingStore):

• Modules/indexeddb/IDBIndexBackendImpl.cpp: ditto.

(WebCore::IDBIndexBackendImpl::countInternal):

• Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Fix the method signature and add

an empty implementation.
(WebCore):
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

• Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Fix warnings.

(WebCore::IDBObjectStoreBackendImpl::countInternal):

• Modules/indexeddb/IDBPendingTransactionMonitor.cpp: ditto.

(WebCore::transactions):

• Modules/indexeddb/IDBRequest.cpp: ditto.

(WebCore::IDBRequest::resetReadyState):

• Modules/indexeddb/IDBRequest.h: ditto.

(WebCore::IDBRequest::onSuccessWithPrefetch):
(WebCore):
(WebCore::JSIDBVersionChangeRequest::visitChildren):

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue): Fix the creation of IDBKeys.
(WebCore::createOptionsObjectFromValue): Add an empty implementation of
the handling of database options (IDBObjectStoreParameters).
(WebCore):

• bindings/js/IDBBindingUtilities.h:

(WebCore):

• bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS): Add the missing IDBAny's types.

• bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS): Add the missing IDBKey's types.

• bindings/js/JSIDBVersionChangeRequestCustom.cpp: Added.

IDBVersionChangeRequest has the attribute EventTarget so it requires
the visitChildren() function. An empty implementation was added.

• bindings/js/OptionsObject.h: Add an empty implementation.

(WebCore):
(OptionsObject):
(WebCore::OptionsObject::OptionsObject):
(WebCore::OptionsObject::isObject):
(WebCore::OptionsObject::isUndefinedOrNull):
(WebCore::OptionsObject::get):
(WebCore::OptionsObject::getWithUndefinedOrNullCheck):

• bindings/js/SerializedScriptValue.cpp: Add the missing functions needed by IndexedDB.

(WebCore):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

• bindings/js/SerializedScriptValue.h:

(SerializedScriptValue):

• bindings/scripts/CodeGeneratorJS.pm: Modify the code generator to:

-Support the IDBKey type correctly.
-Support the OptionsObject type.
-Generate valid function call for static functions.
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):

• inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

10:36 PM Changeset in webkit [110538] by morrita@google.com

• 4 edits in trunk/Source

Unreviewed, rolling out r110529.
​http://trac.webkit.org/changeset/110529
​https://bugs.webkit.org/show_bug.cgi?id=80969

breaks mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

• platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

• tests/CCOcclusionTrackerTest.cpp:

(WebCore):

10:03 PM Changeset in webkit [110537] by morrita@google.com

• 42 edits
  2 copies in trunk

Unreviewed, rolling out r110524.
​http://trac.webkit.org/changeset/110524
​https://bugs.webkit.org/show_bug.cgi?id=80936

breaks chromium win build. (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

• Target.pri:
• UseV8.cmake:
• WebCore.gypi:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

• bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

• bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

• bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

• bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

• bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

• bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

• bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

• bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

• bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

• bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

• css/CSSStyleSheet.idl:
• css/StyleSheet.idl:
• dom/DOMStringMap.idl:
• dom/NamedNodeMap.idl:
• html/DOMTokenList.idl:
• html/track/TextTrackList.idl:

LayoutTests:

• platform/chromium/test_expectations.txt:

9:20 PM Changeset in webkit [110536] by haraken@chromium.org

• 3 edits in trunk/Source/WebCore

[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
​https://bugs.webkit.org/show_bug.cgi?id=80924

Reviewed by Adam Barth.

getCachedWrapperSlow() is called by getCachedWrapper() only,
and getCachedWrapperSlow() just calls getCachedWrapperInline().
Thus, this patch expands getCachedWrapperInline() into getCachedWrapper(),
and removes getCachedWrapperSlow().

No tests. No change in behavior.

• bindings/v8/V8DOMWrapper.cpp:
• bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

9:03 PM Changeset in webkit [110535] by haraken@chromium.org

• 13 edits in trunk/Source/WebCore

[V8][Refactoring] Remove existingWrapper() from generated code
​https://bugs.webkit.org/show_bug.cgi?id=80927

Reviewed by Adam Barth.

Currently wrap() calls existingWrapper(), and existingWrapper()
just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.

Test: bindings/scripts/test/*

• bindings/scripts/CodeGeneratorV8.pm: Removed existingWrapper().

(GenerateHeader):
(GenerateNormalAttrGetter):

• bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.

(V8Float64Array):
(WebCore::V8Float64Array::wrap):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

8:33 PM Changeset in webkit [110534] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[chromium] Use tileRect instead of pointer derefs
​https://bugs.webkit.org/show_bug.cgi?id=80919

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

• platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

8:14 PM Changeset in webkit [110533] by ojan@chromium.org

• 3 edits in trunk/Tools

webkit-patch optimize-baselines sometimes creates a mac-future result
​https://bugs.webkit.org/show_bug.cgi?id=80717

Reviewed by Adam Barth.

• Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(_baseline_search_hypergraph):
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._filter_virtual_ports):

• Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_no_add_mac_future):

7:45 PM Changeset in webkit [110532] by commit-queue@webkit.org

• 8 edits
  8 adds in trunk

SVG should support transform-origin and relative values
​https://bugs.webkit.org/show_bug.cgi?id=79068

Patch by Hans Muller <​hmuller@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

Source/WebCore:

Added SVG support for the CSS 'transform-origin' property and for percentage
values in the transform translate function. The changes conform to
​http://dev.w3.org/csswg/css3-transforms/.

Tests: svg/transforms/percent-transform-values.xhtml

svg/transforms/transform-origin-css-property.xhtml

• css/svg.css:

(*):
(html|* > svg):
Default transform-origin for SVG elements is 0 0.

• platform/Length.h:

(WebCore::Length::calcFloatValue):
Added a calcFloatValue overload whose max parameter (for percent lengths) is a float.
The original version will be obsolete when the sub-pixel layout support is completed.

• rendering/style/RenderStyle.cpp:
• rendering/style/RenderStyle.h:

(WebCore):
(WebCore::requireTransformOrigin):
Transforms that only include translations don't depend on the transform-origin.

(WebCore::RenderStyle::applyTransform):
SVG elements interpret non-percentage/keyword transform-origin values relative to their viewport,
unlike HTML which interprets all transform-origin values relative to the element's origin.
The new FloatRect applyTransform() function handles SVG semantics. Similarly, SVG elements interpret
percentage/keyword transform-origin values relative to the origin of their objectBoundingBox(), HTML
uses the borderBox. All this per ​http://dev.w3.org/csswg/css3-transforms/.

• svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

LayoutTests:

Added tests for SVG CSS transform-origin property support and for
CSS translations specified with percentages and applied to an SVG element.

• svg/transforms/change-transform-origin-css-expected.xhtml: Added.
• svg/transforms/change-transform-origin-css.xhtml: Added.
• svg/transforms/change-transform-origin-presentation-attribute-expected.xhtml: Added.
• svg/transforms/change-transform-origin-presentation-attribute.xhtml: Added.
• svg/transforms/percent-transform-values-expected.txt: Added.
• svg/transforms/percent-transform-values.xhtml: Added.
• svg/transforms/transform-origin-css-property-expected.xhtml: Added.
• svg/transforms/transform-origin-css-property.xhtml: Added.

7:42 PM Changeset in webkit [110531] by morrita@google.com

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed Windows build fix.

• src/WebViewImpl.cpp:

7:29 PM Changeset in webkit [110530] by weinig@apple.com

• 2 edits in trunk/LayoutTests

Fix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
​https://bugs.webkit.org/show_bug.cgi?id=80925

Reviewed by Maciej Stachowiak.

• fast/events/input-element-display-none-in-dragleave-crash.html:

Add call to eventSender.mouseUp().

7:27 PM Changeset in webkit [110529] by commit-queue@webkit.org

• 4 edits in trunk/Source

[chromium] Use projectQuad to apply inverse mapRect
​https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

• platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

• tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

7:17 PM Changeset in webkit [110528] by leo.yang@torchmobile.com.cn

• 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
​https://bugs.webkit.org/show_bug.cgi?id=80820

Reviewed by Rob Buis.

The BlackBerry is using the FontPlatformData from Chromium porting.

• platform/graphics/FontPlatformData.h:

6:58 PM Changeset in webkit [110527] by jberlin@webkit.org

• 2 edits in trunk/Tools

More Windows build fixing.

• DumpRenderTree/win/WorkQueueItemWin.cpp:

6:52 PM Changeset in webkit [110526] by zmo@google.com

• 3 edits
  2 adds in trunk

After webgl canvas resize, bindings might be lost
​https://bugs.webkit.org/show_bug.cgi?id=80895

Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/webgl/texture-bindings-uneffected-on-resize.html

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::reshape): recover bindings after reshape.

LayoutTests:

• fast/canvas/webgl/texture-bindings-uneffected-on-resize-expected.txt: Added.
• fast/canvas/webgl/texture-bindings-uneffected-on-resize.html: Added.

6:38 PM Changeset in webkit [110525] by haraken@chromium.org

• 5 edits in trunk/Source/WebCore

[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
​https://bugs.webkit.org/show_bug.cgi?id=80920

Reviewed by Adam Barth.

Now getWrapper() is the same as getExistingWrapper().
getWrapperSlow() is the same as getExistingWrapperSlow().
This patch removes getWrapper() and getWrapperSlow().
Also this patch renames getExistingWrapper() to getCachedWrapper().

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

• bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

• bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getWrapper):
(V8DOMWrapper):

• bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

6:37 PM Changeset in webkit [110524] by arv@chromium.org

• 42 edits
  2 deletes in trunk

[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
​https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8).

No new tests. Covered by existing tests.

• Target.pri:
• UseV8.cmake:
• WebCore.gypi:
• bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

• bindings/scripts/IDLAttributes.txt:
• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

• bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

• bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

• bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

• bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

• bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
• bindings/v8/custom/V8DOMStringMapCustom.cpp:
• bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
• bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

• bindings/v8/custom/V8NamedNodeMapCustom.cpp:
• bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

• css/CSSStyleSheet.idl:
• css/StyleSheet.idl:
• dom/DOMStringMap.idl:
• dom/NamedNodeMap.idl:
• html/DOMTokenList.idl:
• html/track/TextTrackList.idl:

LayoutTests:

• platform/chromium/test_expectations.txt:

6:31 PM Changeset in webkit [110523] by jberlin@webkit.org

• 7 edits in trunk/Tools

More Windows build fixing.

• DumpRenderTree/win/AccessibilityControllerWin.cpp:
• DumpRenderTree/win/EditingDelegate.cpp:
• DumpRenderTree/win/EventSender.cpp:
• DumpRenderTree/win/FrameLoadDelegate.cpp:
• DumpRenderTree/win/LayoutTestControllerWin.cpp:
• DumpRenderTree/win/UIDelegate.cpp:

6:29 PM Changeset in webkit [110522] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

Remove obsolete 'CPU' modifier.

Unreviewed, expectations change.

• platform/chromium/test_expectations.txt:

6:27 PM LayoutUnit edited by leviw@chromium.org

(diff)

6:16 PM Changeset in webkit [110521] by barraclough@apple.com

• 3 edits in trunk/LayoutTests

Object.defineProperty doesn't respect attributes when applied to the Global Object
​https://bugs.webkit.org/show_bug.cgi?id=38636
Object.defineProperty doesn't create property on Global Object in the presence of a setter in the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=48911

Rubber stamped by Michael Saboff.

• fast/js/Object-defineProperty-expected.txt:
• fast/js/script-tests/Object-defineProperty.js:
  • Added test cases for bugs #38636 & #48911.

6:13 PM Changeset in webkit [110520] by jberlin@webkit.org

• 3 edits in trunk/Source/WebKit/win

More Windows build fixing.

• MarshallingHelpers.cpp:
• WebDatabaseManager.cpp:

6:10 PM Changeset in webkit [110519] by haraken@chromium.org

• 3 edits in trunk/Source/WebCore

[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
​https://bugs.webkit.org/show_bug.cgi?id=80916

Reviewed by Adam Barth.

This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

• bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

6:05 PM Changeset in webkit [110518] by fpizlo@apple.com

• 8 edits
  2 deletes in trunk/Source/JavaScriptCore

Arithmetic use inference should be procedure-global and should run in tandem
with type propagation
​https://bugs.webkit.org/show_bug.cgi?id=80819
<rdar://problem/11034006>

Reviewed by Gavin Barraclough.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGArithNodeFlagsInferencePhase.cpp: Removed.
• dfg/DFGArithNodeFlagsInferencePhase.h: Removed.
• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):

• dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::flags):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeFlags):

6:02 PM Changeset in webkit [110517] by dpranke@chromium.org

• 1 edit
  165 deletes in trunk/LayoutTests

Remove obsolete chromium-gpu-* platform directories for LayoutTests baselines.

Unreviewed, baselines change.

All of the baselines are now in platform/chromium-*/platform/chromium/virtual/gpu/*.

• platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Removed.
• platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Removed.
• platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Removed.
• platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Removed.
• platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Removed.
• platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Removed.
• platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Removed.
• platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
• platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Removed.
• platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
• platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
• platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
• platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
• platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Removed.
• platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-no-audio-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-transformed-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
• platform/chromium-gpu-linux/media/video-zoom-expected.png: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
• platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-as-image-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-bg-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-bg-zoom-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-transform-skewed-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/image-pattern-rotate-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/patternfill-repeat-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Removed.
• platform/chromium-gpu-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
• platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
• platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
• platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
• platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-no-audio-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-transformed-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-zoom-controls-expected.png: Removed.
• platform/chromium-gpu-mac/media/video-zoom-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Removed.
• platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Removed.
• platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
• platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
• platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
• platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
• platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Removed.
• platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Removed.
• platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Removed.
• platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Removed.
• platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
• platform/chromium-gpu-win/media/video-display-toggle-expected.png: Removed.
• platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Removed.
• platform/chromium-gpu-win/media/video-layer-crash-expected.png: Removed.
• platform/chromium-gpu-win/media/video-no-audio-expected.png: Removed.
• platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Removed.
• platform/chromium-gpu-win/media/video-transformed-expected.png: Removed.
• platform/chromium-gpu-win/media/video-volume-slider-expected.png: Removed.
• platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
• platform/chromium-gpu-win/media/video-zoom-expected.png: Removed.
• platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Removed.
• platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Removed.
• platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Removed.

5:55 PM Changeset in webkit [110516] by dpranke@chromium.org

• 3 edits in trunk/Tools

remove the 'gpu' group from the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=80353

Reviewed by Adam Barth.

Since those bots are obsolete, we don't need this any more.

• TestResultServer/static-dashboards/builders.js:
• TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testHtmlForTestTypeSwitcherGroup):

5:53 PM Changeset in webkit [110515] by haraken@chromium.org

• 7 edits in trunk/Source/WebCore

[V8] Refactor some header includes in V8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=80913

Reviewed by Adam Barth.

This patch refactors some header includes in V8 bindings
required for fixing bug 80841.

No tests. No change in behavior.

• bindings/v8/DOMDataStore.h:

(DOMDataStore):

• bindings/v8/V8DOMMap.h:
• bindings/v8/V8DOMWrapper.cpp:
• bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::isolatedContext):

• bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(V8IsolatedContext):

• bindings/v8/WorldContextHandle.cpp:

5:50 PM Changeset in webkit [110514] by dpranke@chromium.org

• 19 edits in trunk/Tools

remove graphics_type from webkitpy.layout_tests.models.test_configuration
​https://bugs.webkit.org/show_bug.cgi?id=80643

Reviewed by Ojan Vafai.

Now that the chromium-gpu ports are gone, there's no need for
the graphics_type CPU/GPU distinction. Most of this change is
just updating tests accordingly.

• Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests):

• Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfiguration.init):
(TestConfiguration.category_order):
(TestConfiguration.str):
(TestConfiguration.repr):
(TestConfiguration.hash):
(TestConfigurationConverter.to_specifiers_list):

• Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_error_on_different_build_type):
(TestExpectationSerializerTests.test_parsed_to_string):
(TestExpectationSerializerTests.test_reconstitute_only_these):

• Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

• Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.name):
(Port.version):
(Port.test_configuration):

• Scripts/webkitpy/layout_tests/port/builders.py:
• Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

• Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.init):

• Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_check_illegal_port_names):

• Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_baseline_path):

• Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

• Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._generate_all_test_configurations):

• Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._generate_all_test_configurations):

• Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._generate_all_test_configurations):

• Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.all_test_configurations):
(TestPort._all_build_types):

• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
• Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningExpectationsUpdaterTest.test_unknown_failure_type):
(GardeningExpectationsUpdaterTest.test_add_new_expectation):
(GardeningExpectationsUpdaterTest.test_replace_old_expectation):
(GardeningExpectationsUpdaterTest.test_pass_expectation):
(GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
(GardeningExpectationsUpdaterTest.test_spurious_updates):

5:43 PM Changeset in webkit [110513] by dpranke@chromium.org

• 8 edits in trunk/Tools

_runtime_feature_list isn't supported on Apple Mac DRT
​https://bugs.webkit.org/show_bug.cgi?id=80906

Reviewed by Eric Seidel.

It looks like this feature is actually only supported on the Win
DRT port, so this patch reworks the code to make that clearer
and reduce unnecessary overrides.

• Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

• Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._path_to_webcore_library):

• Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._skipped_file_search_paths):

• Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._runtime_feature_list):

• Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(test_skipped_directories_for_features):

• Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):
(WinPort._runtime_feature_list):

• Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_operating_system):
(WinPortTest):
(WinPortTest.test_runtime_feature_list):

5:31 PM Changeset in webkit [110512] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

Fix typo in PageClientImpl where we were overriding viewLayerHostingMode with
a function called layerHostingMode.

Reviewed by Anders Carlsson.

• UIProcess/API/mac/PageClientImpl.h:
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewLayerHostingMode):
Update name and add OVERRIDE to catch this in the future.

5:22 PM Changeset in webkit [110511] by commit-queue@webkit.org

• 11 edits
  13 moves in trunk/Source/WebCore

Unreviewed, rolling out r110501.
​http://trac.webkit.org/changeset/110501
​https://bugs.webkit.org/show_bug.cgi?id=80908

Broke the Apple-Win build (Requested by abarth on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-12

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• WebCore.pri:
• WebCore.xcodeproj/project.pbxproj:
• fileapi/DirectoryEntry.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.cpp.

(WebCore):
(WebCore::DirectoryEntry::DirectoryEntry):
(WebCore::DirectoryEntry::createReader):
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
(WebCore::DirectoryEntry::removeRecursively):

• fileapi/DirectoryEntry.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.h.

(WebCore):
(DirectoryEntry):
(WebCore::DirectoryEntry::create):
(WebCore::DirectoryEntry::isDirectory):

• fileapi/DirectoryEntry.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.idl.
• fileapi/DirectoryEntrySync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp.

(WebCore):
(WebCore::DirectoryEntrySync::DirectoryEntrySync):
(WebCore::DirectoryEntrySync::createReader):
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
(WebCore::DirectoryEntrySync::removeRecursively):

• fileapi/DirectoryEntrySync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.h.

(WebCore):
(DirectoryEntrySync):
(WebCore::DirectoryEntrySync::create):
(WebCore::DirectoryEntrySync::isDirectory):

• fileapi/DirectoryEntrySync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl.
• fileapi/DirectoryReader.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.cpp.

(WebCore):
(WebCore::DirectoryReader::DirectoryReader):
(WebCore::DirectoryReader::readEntries):

• fileapi/DirectoryReader.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.h.

(WebCore):
(DirectoryReader):
(WebCore::DirectoryReader::create):
(WebCore::DirectoryReader::filesystem):

• fileapi/DirectoryReader.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.idl.
• fileapi/DirectoryReaderBase.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderBase.h.

(WebCore):
(DirectoryReaderBase):
(WebCore::DirectoryReaderBase::filesystem):
(WebCore::DirectoryReaderBase::setHasMoreEntries):
(WebCore::DirectoryReaderBase::DirectoryReaderBase):

• fileapi/DirectoryReaderSync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp.

(WebCore):
(WebCore::DirectoryReaderSync::DirectoryReaderSync):
(WebCore::DirectoryReaderSync::readEntries):

• fileapi/DirectoryReaderSync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.h.

(WebCore):
(DirectoryReaderSync):
(WebCore::DirectoryReaderSync::create):

• fileapi/DirectoryReaderSync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl.

5:15 PM Changeset in webkit [110510] by thakis@chromium.org

• 2 edits in trunk/Source/WebCore

[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
​https://bugs.webkit.org/show_bug.cgi?id=80902

Reviewed by Adam Barth.

Follow-up to ​http://codereview.chromium.org/9638015/

No intended behavior change.

• WebCore.gyp/mac/adjust_visibility.sh:

5:14 PM Changeset in webkit [110509] by leviw@chromium.org

• 4 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing/cleaning up rounding in RenderReplaced classes, and removing an unnecessary static_cast in RenderFrameSet.

5:09 PM Changeset in webkit [110508] by eae@chromium.org

• 2 edits in branches/subpixellayout/Source

Qt build fixes for branch.

5:09 PM Changeset in webkit [110507] by jer.noble@apple.com

• 37 edits in trunk/Source/WebCore

WebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
​https://bugs.webkit.org/show_bug.cgi?id=74750

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

To account for AudioNodes which may generate non-silent audio when fed silent input
for a certain amount of time after the last non-silent audio data, add two new virtual
functions tailTime() and latencyTime().

• webaudio/AudioNode.h:

(WebCore::AudioNode::tailTime): Added. Pure virtual.
(WebCore::AudioNode::latencyTime): Added. Pure virtual.

• platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::tailTime): Added. Pure virtual.
(WebCore::AudioProcessor::latencyTime): Added. Pure virtual.

• platform/audio/AudioDSPKernel.h:

(WebCore::AudioDSPKernel::tailTime): Added. Pure virtual.
(WebCore::AudioDSPKernel::latencyTime): Added. Pure virtual.

Added tailTime() and latencyTime() overrides to the following classes:

• platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::tailTime):
(WebCore::AudioDSPKernelProcessor::latencyTime):

• platform/audio/AudioDSPKernelProcessor.h:
• platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::tailTime):
(WebCore::DynamicsCompressor::latencyTime):

• platform/audio/EqualPowerPanner.h:
• platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::tailTime):
(WebCore::HRTFPanner::latencyTime):

• platform/audio/HRTFPanner.h:
• platform/audio/Panner.h:
• webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::tailTime):
(WebCore::AudioBasicProcessorNode::latencyTime):

• webaudio/AudioBasicProcessorNode.h:
• webaudio/AudioChannelMerger.h:
• webaudio/AudioChannelSplitter.h:
• webaudio/AudioDestinationNode.h:
• webaudio/AudioGainNode.h:
• webaudio/AudioPannerNode.h:
• webaudio/AudioSourceNode.h:
• webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::tailTime):
(WebCore::BiquadDSPKernel::latencyTime):

• webaudio/BiquadDSPKernel.h:
• webaudio/BiquadFilterNode.h:
• webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::tailTime):
(WebCore::ConvolverNode::latencyTime):

• webaudio/ConvolverNode.h:
• webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::tailTime):
(WebCore::DelayDSPKernel::latencyTime):

• webaudio/DelayDSPKernel.h:
• webaudio/DelayProcessor.h:
• webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::tailTime):
(WebCore::DynamicsCompressorNode::latencyTime):

• webaudio/DynamicsCompressorNode.h:
• webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::tailTime):
(WebCore::JavaScriptAudioNode::latencyTime):

• webaudio/JavaScriptAudioNode.h:
• webaudio/RealtimeAnalyserNode.h:
• webaudio/WaveShaperDSPKernel.h:

The following functions were added as support for the new AudioNode and AudioProcessor functions:

• platform/audio/Biquad.cpp:

(WebCore::Biquad::latencyFrames):

• platform/audio/Biquad.h:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::latencyFrames):

• platform/audio/ReverbConvolver.h:

(WebCore::ReverbConvolver::latencyFrames):

The following functions were made const-correct:

• platform/audio/HRTFPanner.h:

(WebCore::HRTFPanner::fftSize):

• platform/audio/Reverb.h:

(WebCore::Reverb::impulseResponseLength):

5:07 PM Changeset in webkit [110506] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

WebTileLayers should be opaque
​https://bugs.webkit.org/show_bug.cgi?id=80907
<rdar://problem/11034390>

Reviewed by Andreas Kling.

• platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):
Call -[CALayer setOpaque:] on the newly created WebTileLayer.

5:05 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

4:51 PM Changeset in webkit [110505] by eae@chromium.org

• 4 edits in trunk/Source/WebCore

Fix rounding in scrollbar rect calculations
​https://bugs.webkit.org/show_bug.cgi?id=80894

Reviewed by Eric Seidel.

Fix usage of subpixel units in RenderScrollbar::buttonRect and
RenderScrollbar::trackRect.

No new tests, no new functionality.

• rendering/LayoutTypes.h:

(WebCore::isIntegerValue):
Add dummy isIntegerValue function, will be replaced with actual
implementation once LayoutUnit is remapped to FractionalLayoutUnit.

• rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::trackRect):
Change rect calculations to use pixel snapped values.

• rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):
(WebCore::RenderScrollbarPart::marginTop):
(WebCore::RenderScrollbarPart::marginBottom):
(WebCore::RenderScrollbarPart::marginLeft):
(WebCore::RenderScrollbarPart::marginRight):
Add ASSERT to ensure that scrollbar parts are always aligned to device
pixels.

4:46 PM Changeset in webkit [110504] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GObject IDL Parser] STRING argument should be HASHREF
​https://bugs.webkit.org/show_bug.cgi?id=78877

Patch by C Anthony Risinger <​anthony@xtfx.me> on 2012-03-12
Reviewed by Kentaro Hara.

• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunctions): extendedAttributes are hashes, not strings

4:43 PM Changeset in webkit [110503] by jberlin@webkit.org

• 7 edits in trunk/Source/WebCore

More Windows build fixing.

Use fully qualified paths for WTF headers.

• platform/graphics/cg/ImageSourceCGWin.cpp:
• platform/graphics/win/UniscribeController.h:
• platform/win/DragImageCGWin.cpp:
• platform/win/DragImageCairoWin.cpp:
• platform/win/DragImageWin.cpp:
• rendering/RenderThemeSafari.cpp:

4:40 PM Changeset in webkit [110502] by abarth@webkit.org

• 1 edit
  1 add
  1 delete in trunk/LayoutTests

This baseline also applies to chromium-mac-snowleopard, so we can move
it up the fallback chain.

• platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Removed.
• platform/chromium-mac-snowleopard/fast/events/scrollbar-double-click-expected.txt: Added.

4:38 PM Changeset in webkit [110501] by commit-queue@webkit.org

• 11 edits
  13 moves
  1 add in trunk/Source/WebCore

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
​https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

No new tests, all existing tests pass.

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• GNUmakefile.list.am:
• Modules/filesystem: Added.
• Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
• Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
• Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
• Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
• Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
• Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
• Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
• Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
• Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
• Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
• Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
• Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
• Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
• Target.pri:
• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• WebCore.pri:
• WebCore.xcodeproj/project.pbxproj:
• fileapi/DirectoryEntry.cpp: Removed.
• fileapi/DirectoryEntry.h: Removed.
• fileapi/DirectoryEntry.idl: Removed.
• fileapi/DirectoryEntrySync.cpp: Removed.
• fileapi/DirectoryEntrySync.h: Removed.
• fileapi/DirectoryEntrySync.idl: Removed.
• fileapi/DirectoryReader.cpp: Removed.
• fileapi/DirectoryReader.h: Removed.
• fileapi/DirectoryReader.idl: Removed.
• fileapi/DirectoryReaderBase.h: Removed.
• fileapi/DirectoryReaderSync.cpp: Removed.
• fileapi/DirectoryReaderSync.h: Removed.
• fileapi/DirectoryReaderSync.idl: Removed.

4:34 PM Changeset in webkit [110500] by beidson@apple.com

• 4 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly

Reviewed by Tim Hatcher.

No new tests. (No behavior change)

Changed to hold the StorageArea directly and added a Frame* accessor:

• inspector/InspectorDOMStorageResource.h:

(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
(InspectorDOMStorageResource):

• inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

• inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

4:23 PM Changeset in webkit [110499] by abarth@webkit.org

• 2 edits in trunk/Source/WebCore

[Skia] Release CGImage used to apply color space conversion to SkBitmap
​https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <​bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

• platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

4:15 PM Changeset in webkit [110498] by fpizlo@apple.com

• 20 edits
  1 move
  2 adds in trunk/Source/JavaScriptCore

Node::op and Node::flags should be private
​https://bugs.webkit.org/show_bug.cgi?id=80824
<rdar://problem/11033435>

Reviewed by Gavin Barraclough.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

• dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):

• dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::byValIsPure):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• dfg/DFGNode.cpp: Removed.
• dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::op):
(JSC::DFG::Node::flags):
(JSC::DFG::Node::setOp):
(JSC::DFG::Node::setFlags):
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::clearFlags):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

• dfg/DFGNodeFlags.cpp: Copied from Source/JavaScriptCore/dfg/DFGNode.cpp.
• dfg/DFGNodeFlags.h: Added.

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):

• dfg/DFGNodeType.h: Added.

(DFG):
(JSC::DFG::defaultFlags):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

• dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compare):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

4:10 PM Changeset in webkit [110497] by eae@chromium.org

• 6 edits in branches/subpixellayout/Source

Fix scrollbar rect calculations on branch.

3:59 PM Changeset in webkit [110496] by leviw@chromium.org

• 7 edits in trunk/Source/WebCore

Update LayoutUnit usage in RenderMathML* classes
​https://bugs.webkit.org/show_bug.cgi?id=77916

Reviewed by Eric Seidel.

The purpose of this patch is to ensure MathML rendering does not regress when
we switch to sub-pixel layout. A subsequent patch can likely improve MathML's
rendering when zoom is applied.

To accomplish this without changing the current heuristics for positioning,
we continue to use integers for sizes and locations, using pixel snapping
when communicating with other Rendering classes.

No new tests. No change in behavior.

• rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint): Cleaning up debug painting to be on
pixel boundaries instead of subpixel.

• rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint): Reverting to integers for determining
the vertical offset.
(WebCore::RenderMathMLFraction::baselinePosition):

• rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint): Using integers for height and width
and only accumulating pixel snapped values.
(WebCore::RenderMathMLRoot::layout): Setting padding with integers to
avoid inconsistent rounding based on the root's location.

• rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

• rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint): See RenderMathMLRoot.
(WebCore::RenderMathMLSquareRoot::layout): Ditto.

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::layout):

3:57 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

3:48 PM Changeset in webkit [110495] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Use smaller tiles for right and bottom edges
​https://bugs.webkit.org/show_bug.cgi?id=80893
<rdar://problem/11032873>

Reviewed by Sam Weinig.

• platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::rectForTileIndex):
Intersect the rect with the tile cache bounds.

(WebCore::TileCache::revalidateTiles):
Resize already existing tiles if needed.

(WebCore::TileCache::createTileLayer):
This now takes a tile rect. Use setFrame instead of setting the bounds and position separately.

3:45 PM Changeset in webkit [110494] by enrica@apple.com

• 21 edits in trunk

Source/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

• WebCore.exp.in: Added two exported methods.
• platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Last parameter in the call to wkSetMetadataURL
needs to be wrapped in String before casting to NSString.

Source/WebKit2: WebKit2: remove NSPasteboard access for promised data from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

This patch removes the last remaining access to NSPasteboard from the WebProcess.
The code in WebDragClient::declareAndWriteDragImage now packages all the data
required for the drag and the promised drag types and sends one request to the UI
process that will place the data in the NSPasteboard when appropriate.

• UIProcess/API/mac/PageClientImpl.h: Added setPromisedData method.
• UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPromisedData):

• UIProcess/API/mac/WKView.mm:

(matchesExtensionOrEquivalent): Added.
(fileExists): Added.
(pathWithUniqueFilenameForPath): Added.
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):

• UIProcess/API/mac/WKViewInternal.h: Added _setPromisedData.
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h: Added method for the new message.
• UIProcess/WebPageProxy.messages.in: Added setPromisedData message.
• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPromisedData):

• WebProcess/WebCoreSupport/WebDragClient.cpp:
• WebProcess/WebCoreSupport/WebDragClient.h:
• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added SetMetadataURL.

WebKitLibraries: WebKit2: remove NSPasteboard access for promised data from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=80073

• WebKitSystemInterface.h: Touched the file to make build system happy.
• libWebKitSystemInterfaceLeopard.a:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceSnowLeopard.a:

3:40 PM Changeset in webkit [110493] by abarth@webkit.org

• 10 edits in trunk/LayoutTests

Update expected results after ​http://trac.webkit.org/changeset/110480.
These results are very similar to our previous results and seem
slightly improved AFAICT.

• platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
• platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
• platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
• platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
• platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
• platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
• platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
• platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:

3:38 PM Changeset in webkit [110492] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
​https://bugs.webkit.org/show_bug.cgi?id=80831

Patch by Andy Chen <​andchen@rim.com> on 2012-03-12
Reviewed by Antonio Gomes.

• WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):

• WebKitSupport/InPageSearchManager.h:

3:37 PM Changeset in webkit [110491] by abarth@webkit.org

• 1 edit
  1 add in trunk/LayoutTests

Restore previous expecation for chromium-mac-leopard. rniwa says this
is the right thing to do.

• platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Added.

3:28 PM Changeset in webkit [110490] by rniwa@webkit.org

• 3 edits in trunk/LayoutTests

Yet another Mac rebaseline.

• editing/pasteboard/dataTransfer-setData-getData-expected.txt:
• platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:

3:24 PM Changeset in webkit [110489] by commit-queue@webkit.org

• 3 edits
  1 add
  4 deletes in trunk/LayoutTests

Convert some fast/regions pixel tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=79132

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

• fast/regions/floats-basic-in-variable-width-regions-expected.html: Added.
• fast/regions/floats-basic-in-variable-width-regions.html:
• platform/chromium/test_expectations.txt:
• platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
• platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
• platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
• platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.

3:22 PM Changeset in webkit [110488] by ap@apple.com

• 2 edits in trunk/Source/WebCore

clang build fix

• css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): Reorder

boolean operators, so that a warning about "use of logical

with constant operand" doesn't

appear.

3:17 PM Changeset in webkit [110487] by inferno@chromium.org

• 3 edits
  2 adds in trunk

Crash in Text::splitText due to mutation events.
​https://bugs.webkit.org/show_bug.cgi?id=80828

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/split-text-crash.xhtml

• dom/Range.cpp:

(WebCore::Range::insertNode): replace m_start.container() calls with ref protected node.

LayoutTests:

• fast/text/split-text-crash-expected.txt: Added.
• fast/text/split-text-crash.xhtml: Added.

2:59 PM Changeset in webkit [110486] by abarth@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix clang build for CCOcclusionTracker tests
​https://bugs.webkit.org/show_bug.cgi?id=80891

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

• tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):

2:59 PM Changeset in webkit [110485] by kbr@google.com

• 6 edits in trunk

Null argument to texSubImage2D crashes
​https://bugs.webkit.org/show_bug.cgi?id=80778

Reviewed by Dean Jackson.

Source/WebCore:

Generate INVALID_VALUE OpenGL error upon receiving null argument.
Final behavior still being decided on public-webgl mailing list.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncData):

• html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated tex-sub-image-2d-bad-args test to verify new behavior.

• fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt:
• fast/canvas/webgl/tex-sub-image-2d-bad-args.html:

2:54 PM Changeset in webkit [110484] by macpherson@chromium.org

• 4 edits in trunk/Source/WebCore

Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly.
​https://bugs.webkit.org/show_bug.cgi?id=80484

Reviewed by Julien Chaffraix.

No new tests / code cleanup only.

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

• css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyClip::convertToLength):

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

2:52 PM Changeset in webkit [110483] by senorblanco@chromium.org

• 11 edits in trunk/Source

[chromium] Restore canvas2D acceleration after context loss.
​https://bugs.webkit.org/show_bug.cgi?id=80629

Reviewed by James Robinson.

Covered by existing canvas tests, and manual testing (killing the GPU
process).

Source/WebCore:

• platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

• platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

• platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::applyFilters):

• platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::get):
(WebCore):
(WebCore::SharedGraphicsContext3D::get):

• platform/graphics/gpu/SharedGraphicsContext3D.h:

(SharedGraphicsContext3D):

• platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

• platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore):

• platform/graphics/skia/PlatformContextSkia.h:

(WebCore):
(WebCore::PlatformContextSkia::isAccelerated):
(WebCore::PlatformContextSkia::setAccelerated):
(PlatformContextSkia):

Source/WebKit/chromium:

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):

2:51 PM Changeset in webkit [110482] by leviw@chromium.org

• 7 edits in branches/subpixellayout/Source

Fixing misaligned painting in RenderListBox and RenderFileUploadControl. Correcting width calculations for platform code in RenderFileUploadControl. Changing RenderLayer::absoluteBoundingBox to a pixel snapped IntRect, which simplifies platform code.

2:36 PM Changeset in webkit [110481] by staikos@webkit.org

• 2 edits in trunk/Source/WebCore

It doesn't make sense to return const unsigned, and GCC warns about it.
Remove const.
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

• platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:

(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::offsetX):

2:33 PM Changeset in webkit [110480] by Beth Dakin

• 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>

Reviewed by Dan Bernstein.

With ​http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):

2:28 PM Changeset in webkit [110479] by cevans@google.com

• 1 edit in branches/chromium/1025/Source/WebCore/xml/XMLErrors.cpp

Merge 110111
BUG=117226
Review URL: ​https://chromiumcodereview.appspot.com/9689032

2:17 PM Changeset in webkit [110478] by commit-queue@webkit.org

• 7 edits
  2 deletes in trunk

Cleanup obsolete files.
​https://bugs.webkit.org/show_bug.cgi?id=80737

Patch by Scott Byer <​scottbyer@chromium.org> on 2012-03-12
Reviewed by James Robinson.

.:

• wscript:

Source/WebCore:

No new code.

• GNUmakefile.list.am:
• PlatformWinCE.cmake:
• Target.pri:
• WebCore.vcproj/WebCore.vcproj:
• platform/ScrollAnimatorWin.cpp: Removed.
• platform/ScrollAnimatorWin.h: Removed.

2:15 PM Changeset in webkit [110477] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Make texImage2D error for wrong size ArrayBufferView more helpful
​https://bugs.webkit.org/show_bug.cgi?id=80868

It took me about 30 minutes to figure out my texImage2D was failing
not because my ArrayBufferView was too small but because the default
alignment is 4. A better error message might help devs find this issue
faster.

Patch by Gregg Tavares <​gman@google.com> on 2012-03-12
Reviewed by Kenneth Russell.

No new tests as no new functionality.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncData):

2:08 PM Changeset in webkit [110476] by Dimitri Glazkov

• 5 edits
  1 add in trunk/LayoutTests

4 shadow DOM tests fail on Mac port
​https://bugs.webkit.org/show_bug.cgi?id=80869

Reviewed by Ryosuke Niwa.

• fast/dom/shadow/content-element-move.html: Changed to use ensureShadowRoot.
• fast/dom/shadow/iframe-shadow.html: Changed to use WebKitShadowRoot polyfil.
• fast/dom/shadow/resources/polyfill.js: Added.
• fast/dom/shadow/shadow-on-image.html: Changed to use WebKitShadowRoot polyfil.
• platform/wk2/Skipped: Added a test that should have been skipped when landed.

2:07 PM Changeset in webkit [110475] by alexis.menard@openbossa.org

• 4 edits in trunk/LayoutTests

Update include path of the test scripts after r110470.

Reviewed by Philippe Normand.

• fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html:
• fast/dom/HTMLSelectElement/select-selectedIndex.html:
• fast/dom/HTMLSelectElement/select-selectedOptions.html:

2:04 PM Changeset in webkit [110474] by adamk@chromium.org

• 1 edit
  1 add in trunk/LayoutTests

Add test expectations accidentally left out of r110465.

• fast/mutation/delivery-order-expected.txt: Added.

2:01 PM Changeset in webkit [110473] by cevans@google.com

• 1 edit in branches/chromium/1025/Source/WebCore/dom/ContainerNode.cpp

Merge 110139
BUG=117226

1:47 PM Changeset in webkit [110472] by rniwa@webkit.org

• 1 edit
  2 deletes in trunk/LayoutTests

Mac rebaseline. Offset is always 700px now.

• platform/mac/fast/events/scrollbar-double-click-expected.txt: Removed.
• platform/win/fast/events/scrollbar-double-click-expected.txt: Removed.

1:43 PM Changeset in webkit [110471] by eae@chromium.org

• 5168 edits
  3892 copies
  731 deletes in branches/subpixellayout

Merge trunk changes up intil r110435 into subpixel branch.

1:33 PM Changeset in webkit [110470] by alexis.menard@openbossa.org

• 1 edit
  8 adds
  8 deletes in trunk/LayoutTests

Move <select> related layout tests in the place they should be.

Reviewed by Andreas Kling.

• fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942-expected.txt: Added.
• fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942.html: Added.
• fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Added.
• fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Added.
• fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html: Added.
• fast/dom/HTMLSelectElement/select-selectedIndex.html: Added.
• fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
• fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
• fast/dom/select-selectedIndex-bug-12942-expected.txt: Removed.
• fast/dom/select-selectedIndex-bug-12942.html: Removed.
• fast/dom/select-selectedIndex-expected.txt: Removed.
• fast/dom/select-selectedIndex-multiple-expected.txt: Removed.
• fast/dom/select-selectedIndex-multiple.html: Removed.
• fast/dom/select-selectedIndex.html: Removed.
• fast/dom/select-selectedOptions-expected.txt: Removed.
• fast/dom/select-selectedOptions.html: Removed.

1:26 PM Changeset in webkit [110469] by timothy_horton@apple.com

• 8 edits in trunk/Source/WebCore

Infinite repaint loop with SVGImageCache and deferred repaint timers
​https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

• page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):

• page/FrameView.h:

(FrameView):
(WebCore::FrameView::repaintsDisabled):

• rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

• svg/graphics/SVGImage.h:

(WebCore):

• svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

• svg/graphics/SVGImageCache.h:

(SVGImageCache):

1:26 PM Changeset in webkit [110468] by dgrogan@chromium.org

• 125 edits in trunk/LayoutTests

IndexedDB: layout test style update
​https://bugs.webkit.org/show_bug.cgi?id=80555

Change layoutTestController.waitUntilDone to var jsTestIsAsync = true
and idb-specific done() to finishJSTest();

Following the uniform style results in less overall code and makes
them easier to convert to worker layout tests.

Reviewed by Tony Chang.

• storage/indexeddb/constants.html:
• storage/indexeddb/create-and-remove-object-store.html:
• storage/indexeddb/create-object-store-options.html:
• storage/indexeddb/createObjectStore-name-argument-required.html:
• storage/indexeddb/createObjectStore-null-name.html:
• storage/indexeddb/cursor-continue.html:
• storage/indexeddb/cursor-delete.html:
• storage/indexeddb/cursor-inconsistency.html:
• storage/indexeddb/cursor-index-delete.html:
• storage/indexeddb/cursor-key-order.html:
• storage/indexeddb/cursor-primary-key-order.html:
• storage/indexeddb/cursor-reverse-bug.html:
• storage/indexeddb/cursor-skip-deleted.html:
• storage/indexeddb/cursor-update-value-argument-required.html:
• storage/indexeddb/cursor-update.html:
• storage/indexeddb/data-corruption.html:
• storage/indexeddb/database-basics.html:
• storage/indexeddb/database-name-undefined.html:
• storage/indexeddb/database-odd-names.html:
• storage/indexeddb/database-quota.html:
• storage/indexeddb/delete-closed-database-object.html:
• storage/indexeddb/delete-range.html:
• storage/indexeddb/deleteIndex.html:
• storage/indexeddb/deleteObjectStore-name-argument-required.html:
• storage/indexeddb/deleteObjectStore-null-name.html:
• storage/indexeddb/duplicates.html:
• storage/indexeddb/error-causes-abort-by-default.html:
• storage/indexeddb/exception-in-event-aborts-expected.txt:
• storage/indexeddb/exception-in-event-aborts.html:
• storage/indexeddb/factory-basics.html:
• storage/indexeddb/factory-cmp.html:
• storage/indexeddb/factory-deletedatabase-interactions.html:
• storage/indexeddb/factory-deletedatabase.html:
• storage/indexeddb/index-count.html:
• storage/indexeddb/index-cursor.html:
• storage/indexeddb/index-get-key-argument-required.html:
• storage/indexeddb/index-multientry.html:
• storage/indexeddb/index-unique.html:
• storage/indexeddb/invalid-keys.html:
• storage/indexeddb/key-generator.html:
• storage/indexeddb/key-sort-order-across-types.html:
• storage/indexeddb/key-sort-order-date.html:
• storage/indexeddb/key-type-array.html:
• storage/indexeddb/key-type-infinity.html:
• storage/indexeddb/keypath-basics.html:
• storage/indexeddb/keypath-edges.html:
• storage/indexeddb/keypath-fetch-key.html:
• storage/indexeddb/keyrange-required-arguments.html:
• storage/indexeddb/keyrange.html:
• storage/indexeddb/list-ordering.html:
• storage/indexeddb/mozilla/add-twice-failure.html:
• storage/indexeddb/mozilla/autoincrement-indexes.html:
• storage/indexeddb/mozilla/bad-keypath.html:
• storage/indexeddb/mozilla/clear.html:
• storage/indexeddb/mozilla/create-index-unique.html:
• storage/indexeddb/mozilla/create-index-with-integer-keys.html:
• storage/indexeddb/mozilla/create-objectstore-basics.html:
• storage/indexeddb/mozilla/create-objectstore-null-name.html:
• storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
• storage/indexeddb/mozilla/cursor-mutation.html:
• storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
• storage/indexeddb/mozilla/cursors.html:
• storage/indexeddb/mozilla/delete-result.html:
• storage/indexeddb/mozilla/event-source.html:
• storage/indexeddb/mozilla/global-data.html:
• storage/indexeddb/mozilla/indexes.html:
• storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
• storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
• storage/indexeddb/mozilla/key-requirements-put-no-key.html:
• storage/indexeddb/mozilla/key-requirements-put-null-key.html:
• storage/indexeddb/mozilla/key-requirements.html:
• storage/indexeddb/mozilla/object-cursors.html:
• storage/indexeddb/mozilla/object-identity.html:
• storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
• storage/indexeddb/mozilla/object-store-remove-values.html:
• storage/indexeddb/mozilla/objectstorenames.html:
• storage/indexeddb/mozilla/odd-result-order.html:
• storage/indexeddb/mozilla/open-database-null-name.html:
• storage/indexeddb/mozilla/put-get-values.html:
• storage/indexeddb/mozilla/readonly-transactions.html:
• storage/indexeddb/mozilla/readwrite-transactions.html:
• storage/indexeddb/mozilla/readyState.html:
• storage/indexeddb/mozilla/remove-index.html:
• storage/indexeddb/mozilla/remove-objectstore.html:
• storage/indexeddb/mozilla/versionchange-abort.html:
• storage/indexeddb/mozilla/versionchange.html:
• storage/indexeddb/mutating-cursor.html:
• storage/indexeddb/objectStore-required-arguments.html:
• storage/indexeddb/objectstore-autoincrement.html:
• storage/indexeddb/objectstore-clear.html:
• storage/indexeddb/objectstore-count.html:
• storage/indexeddb/objectstore-cursor.html:
• storage/indexeddb/objectstore-removeobjectstore.html:
• storage/indexeddb/odd-strings.html:
• storage/indexeddb/open-close-version.html:
• storage/indexeddb/open-cursor.html:
• storage/indexeddb/open-during-transaction.html:
• storage/indexeddb/queued-commands.html:
• storage/indexeddb/readonly-properties.html:
• storage/indexeddb/readonly.html:
• storage/indexeddb/request-event-propagation.html:
• storage/indexeddb/resources/shared.js:

(unexpectedSuccessCallback):
(unexpectedErrorCallback):
(unexpectedAbortCallback):
(unexpectedCompleteCallback):
(unexpectedBlockedCallback):

• storage/indexeddb/setVersion-null.html:
• storage/indexeddb/setVersion-undefined.html:
• storage/indexeddb/set_version_blocked.html:
• storage/indexeddb/set_version_queue.html:
• storage/indexeddb/structured-clone.html:
• storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
• storage/indexeddb/transaction-abort-with-js-recursion.html:
• storage/indexeddb/transaction-abort.html:
• storage/indexeddb/transaction-after-close.html:
• storage/indexeddb/transaction-and-objectstore-calls.html:
• storage/indexeddb/transaction-crash-on-abort.html:
• storage/indexeddb/transaction-event-propagation.html:
• storage/indexeddb/transaction-read-only.html:
• storage/indexeddb/transaction-rollback.html:
• storage/indexeddb/transaction-storeNames-required.html:
• storage/indexeddb/two-version-changes.html:
• storage/indexeddb/value-undefined.html:
• storage/indexeddb/values-odd-types.html:
• storage/indexeddb/version-change-abort-expected.txt:
• storage/indexeddb/version-change-abort.html:
• storage/indexeddb/version-change-exclusive.html:
• storage/indexeddb/versionchangerequest-activedomobject.html:

1:25 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

1:24 PM Changeset in webkit [110467] by jamesr@google.com

• 5 edits in branches/chromium/1025/Source

Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload
​https://bugs.webkit.org/show_bug.cgi?id=79841

Patch by Dana Jansens <​danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.

Source/WebCore:

We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.

Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.

New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint

TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer

• platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):

• platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

Source/WebKit/chromium:

• tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/9697001

1:21 PM Changeset in webkit [110466] by rniwa@webkit.org

• 4 edits in trunk/LayoutTests

Mac rebaseline.

• platform/mac/fast/dom/Window/window-properties-expected.txt:
• platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

1:11 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

1:11 PM Changeset in webkit [110465] by adamk@chromium.org

• 4 edits
  5 adds in trunk

[MutationObservers] Enforce a consistent order of MutationRecord delivery
​https://bugs.webkit.org/show_bug.cgi?id=80549

Reviewed by Ojan Vafai.

Source/WebCore:

Mutations should be delivered in order of creation.

Tests: fast/mutation/create-during-delivery.html

fast/mutation/delivery-order.html
fast/mutation/mutate-during-delivery.html

• dom/WebKitMutationObserver.cpp:

(WebCore):
(WebCore::WebKitMutationObserver::ObserverLessThan::operator()): Functor for use with std::sort.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::deliverAllMutations): Move observers into a sorted vector before delivery.

• dom/WebKitMutationObserver.h: Add a "priority" member which monotonically increases with each construction.

LayoutTests:

• fast/mutation/create-during-delivery-expected.txt: Added.
• fast/mutation/create-during-delivery.html: Added.
• fast/mutation/delivery-order.html: Added.
• fast/mutation/mutate-during-delivery-expected.txt: Added.
• fast/mutation/mutate-during-delivery.html: Added.

1:08 PM Changeset in webkit [110464] by nduca@chromium.org

• 13 edits in trunk/Source

[Chromium] Force compositeAndReadback through regular scheduling flow
​https://bugs.webkit.org/show_bug.cgi?id=77049

Reviewed by James Robinson.

Source/WebCore:

• platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::onTimerTick):

• platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateControllerClient):

• platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedCommit):
(WebCore):
(WebCore::CCScheduler::vsyncTick):

• platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

• platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedCommit):
(WebCore):

• platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):

• platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

• tests/CCFrameRateControllerTest.cpp:

(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
(FakeCCFrameRateControllerClient):
(WebKitTests::TEST):

• tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
(WTF::TEST_F):

• tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::setNeedsForcedCommit):
(WebCore::StateMachine::needsForcedCommit):
(StateMachine):
(WebCore::TEST):
(WebCore):

12:57 PM Changeset in webkit [110463] by jsbell@chromium.org

• 7 edits
  1 add in trunk/Source

IndexedDB: Handle LevelDB database corruption
​https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

• Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

• platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

• WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
• WebKit.gypi: Add LevelDBTest.cpp
• tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

12:55 PM Changeset in webkit [110462] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1025

Merge 110332
BUG=114056
Review URL: ​https://chromiumcodereview.appspot.com/9689022

12:52 PM Changeset in webkit [110461] by cevans@google.com

• 1 edit
  2 copies in branches/chromium/1025

Merge 110324
BUG=116746
Review URL: ​https://chromiumcodereview.appspot.com/9693006

12:50 PM Changeset in webkit [110460] by peter@chromium.org

• 2 edits in trunk/Tools

[Chromium] Temporary build-fix for the Android bot
​https://bugs.webkit.org/show_bug.cgi?id=80862

Reviewed by Adam Barth.

Manually set the environmental variables required to compile source
files through the Android NDK instead of relying on the envsetup.sh
script. A proper fix will be landed to Chromium ASAP, and following
a Chromium roll into WebKit this code will be removed.

• Scripts/webkitdirs.pm:

(buildChromiumMakefile):

12:47 PM Changeset in webkit [110459] by cevans@google.com

• 8 edits
  2 copies in branches/chromium/1025

Merge 110323
BUG=113902
Review URL: ​https://chromiumcodereview.appspot.com/9695005

12:44 PM Changeset in webkit [110458] by vestbo@webkit.org

• 2 edits in trunk/Tools

[Qt] Use right construct to detect config_test_gccdepends

Reviewed by Andreas Kling.

12:44 PM Changeset in webkit [110457] by vestbo@webkit.org

• 2 edits in trunk/Tools

[Qt] Expose location of WebKit's bin and imports dir through module file

Reviewed by Andreas Kling.

12:24 PM Changeset in webkit [110456] by shawnsingh@chromium.org

• 4 edits in trunk

Fix regression on fast/table/table-row-compositing-repaint-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

​http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

12:20 PM Changeset in webkit [110455] by mikelawther@chromium.org

• 5 edits in trunk

CSS3 calc: enable mixed percent/absolute for font
​https://bugs.webkit.org/show_bug.cgi?id=80813

Reviewed by Ojan Vafai.

Source/WebCore:

Add support for mixed percent/absolute expressions to the font handling class.

• css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):

LayoutTests:

• css3/calc/font-expected.txt:
• css3/calc/font-size-expected.txt:

12:19 PM Changeset in webkit [110454] by cevans@google.com

• 1 edit
  3 copies in branches/chromium/1025

Merge 110326
BUG=116461
Review URL: ​https://chromiumcodereview.appspot.com/9677005

12:18 PM Changeset in webkit [110453] by Laszlo Gombos

• 5 edits in trunk/Source/JavaScriptCore

Minor DataLog fixes
​https://bugs.webkit.org/show_bug.cgi?id=80826

Reviewed by Andreas Kling.

• bytecode/ExecutionCounter.cpp:

Do not include DataLog.h, it is not used.

• jit/ExecutableAllocator.cpp:

Ditto.

• wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):
Add missing semi-colon to the code path where DATA_LOG_FILENAME is defined.

• wtf/HashTable.cpp:

Include DataLog as it is used.

12:00 PM Changeset in webkit [110452] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1025

Merge 108084
BUG=112411
Review URL: ​https://chromiumcodereview.appspot.com/9694004

11:58 AM Changeset in webkit [110451] by reed@google.com

• 2 edits in trunk/LayoutTests

update expectations in preparation for bitmap-sampling fix in skia
​https://bugs.webkit.org/show_bug.cgi?id=80837

Unreviewed

• platform/chromium/test_expectations.txt:

11:51 AM Changeset in webkit [110450] by kling@webkit.org

• 4 edits in trunk/Source/WebCore

Restore Attr::style() functionality.
<​http://webkit.org/b/80678>
<rdar://problem/10933904>

Reviewed by Antti Koivisto.

The neutering of Attr::style() in r106740 broke some internal clients of the Obj-C API,
so this was definitely premature.

Since we no longer have a per-Attribute style object, synthesize one in style() and
hang it off of the Attr. This grows Attr by one pointer, but it's a low-volume object
so it shouldn't matter much.

We recreate the StylePropertySet object on every call to style(), to avoid complicating
things with custom invalidation code.

• dom/Attr.cpp:

(WebCore::Attr::style):

• dom/Attr.h:
• dom/StyledElement.h:

(WebCore::StyledElement::collectStyleForAttribute):

11:38 AM Changeset in webkit [110449] by rniwa@webkit.org

• 8 edits
  2 adds in trunk

REGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
​https://bugs.webkit.org/show_bug.cgi?id=80578

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/style-change-crash.html

• dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):

• dom/Element.h:

(Element):

• dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):

• dom/ElementAttributeData.h:

(ElementAttributeData):

• dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):

LayoutTests:

• fast/regions/select-in-region-crash-expected.txt: Rebaselined.
• svg/css/style-change-crash-expected.txt: Added.
• svg/css/style-change-crash.html: Added.

11:28 AM Changeset in webkit [110448] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

Touch event handler count is not updated when adding handlers to the window.
​https://bugs.webkit.org/show_bug.cgi?id=80756

Source/WebCore:

Touch event handlers added to the window needs to be included when counting the number of touch event
handlers. This makes touch event handler counting identical to wheel event handler counting.

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

Test: fast/events/touch/touch-handler-count.html

• dom/EventNames.h:

(EventNames):
(WebCore::EventNames::isTouchEventType):

• dom/Node.cpp:

(WebCore):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

• testing/Internals.cpp:

(WebCore::Internals::touchEventHandlerCount):
(WebCore):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

LayoutTests:

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

The new layout tests add and remove touch event handlers on the window, document, and a div in the
document, and tests that the count is updated correctly when handlers are added and/or removed.

• fast/events/touch/touch-handler-count-expected.txt: Added.
• fast/events/touch/touch-handler-count.html: Added.

11:02 AM Changeset in webkit [110447] by abecsi@webkit.org

• 6 edits
  1 add in trunk

[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=80832

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Since the ScrollDecorator QML component requires a Flickable in its API
we need to expose the Flickable in QML for now and we also need to add
a notifier because we instantiate the internal Flickable only when the
WebView component completes construction.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewExperimental::flickable):

• UIProcess/API/qt/qquickwebview_p.h:

Tools:

Add a basic scroll indicator component to MiniBrowser so that it
behaves similar to the ScrollDecorator QML component.

• MiniBrowser/qt/MiniBrowser.qrc:
• MiniBrowser/qt/qml/BrowserWindow.qml:
• MiniBrowser/qt/qml/ScrollIndicator.qml: Added.

10:50 AM Changeset in webkit [110446] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] r110296 included an extra $ in @$(AM_V_GEN)
​https://bugs.webkit.org/show_bug.cgi?id=80809

Patch by C Anthony Risinger <​anthony@xtfx.me> on 2012-03-12
Reviewed by Philippe Normand.

• GNUmakefile.am: Add $ to @(AM_V_GEN), else /bin/sh syntax error

10:43 AM Changeset in webkit [110445] by podivilov@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
​https://bugs.webkit.org/show_bug.cgi?id=80834

Reviewed by Vsevolod Vlasov.

• inspector/front-end/ScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):

10:42 AM Changeset in webkit [110444] by ericu@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=75110

Reviewed by Ryosuke Niwa.

Remove expectation now that it's fixed.

• platform/chromium/test_expectations.txt:

10:31 AM Changeset in webkit [110443] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Integer overflow check code in arithmetic operation in classic interpreter
​https://bugs.webkit.org/show_bug.cgi?id=80465

Patch by SangGyu Lee <​sg5.lee@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

10:17 AM Changeset in webkit [110442] by Philippe Normand

• 3 edits in trunk/LayoutTests

Unreviewed, unskip a media test in GTK.

• platform/gtk/Skipped: media/video-volume-slider.html was fixed

in r86535.

• platform/gtk/media/video-volume-slider-expected.txt:

10:14 AM Changeset in webkit [110441] by pfeldman@chromium.org

• 4 edits
  2 adds in trunk

Web Inspector: recognize Float*Array and Int*Array as arrays.
​https://bugs.webkit.org/show_bug.cgi?id=80850

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-external-array.html

• bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::type):

• bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

• inspector/console/console-external-array-expected.txt: Added.
• inspector/console/console-external-array.html: Added.

10:13 AM Changeset in webkit [110440] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk/LayoutTests

Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
​https://bugs.webkit.org/show_bug.cgi?id=80658

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-03-12
Reviewed by Alexey Proskuryakov.

• fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt: Added.
• fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml: Added.

10:09 AM Changeset in webkit [110439] by jocelyn.turcotte@nokia.com

• 4 edits in trunk/Source/WebCore

[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.
​https://bugs.webkit.org/show_bug.cgi?id=80848

Reviewed by Noam Rosenthal.

When rendering a transformed texture on the screen with a fractional
coordinate with linear filtering, the resulting pixel will be blended from
the texels around this fractional position according to their cover ratio.
This produces a slight blur of pixels which give no benefit when rendering
a texture that isn't scaled.

This patch offsets the transform by rounding the translation part of the
layer's transform to align the result to integer coordinates.
Applying the adjustment on the layer transform makes sure that all the tiles
get the same adjustment.

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

• platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::textureSize):

10:08 AM Changeset in webkit [110438] by jocelyn.turcotte@nokia.com

• 6 edits in trunk/Source/WebCore

[TexMapGL] Use textures sized exactly to their contents.
​https://bugs.webkit.org/show_bug.cgi?id=80845

Reviewed by Noam Rosenthal.

This fixes a regression introduced in r108273 as well as the bug it fixed.
The regressing behavior was that textures were rendered shrunk by 1 pixel
and thus would appear blurry on the screen.
The original problem was that garbage contents would appear on filtered
textures since we would reuse textures of different sizes by giving them
a slightly bigger size.

This patch will reuse the texture only if the size matches exactly to allow
edge clamping to work properly when redering with linear filtering.
Reusing textures would only saves us the allocation of graphic memory
anyway, which is negligeable compared to texture upload.

• platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):

• platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

• platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):

• platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgramOpacityAndMask):

10:06 AM Changeset in webkit [110437] by jocelyn.turcotte@nokia.com

• 5 edits in trunk/Source/WebCore

[TexMap] Remove BitmapTexture::destroy.
​https://bugs.webkit.org/show_bug.cgi?id=80844

Reviewed by Noam Rosenthal.

Use the destructor directly instead.

• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::~BitmapTextureGL):

• platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

• platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::BitmapTextureImageBuffer::~BitmapTextureImageBuffer):

9:50 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

9:39 AM Changeset in webkit [110436] by vestbo@webkit.org

• 2 edits in trunk

[Qt] Make sure we set the right library version for Qt 4

r110272 accedentally pruned the variable that ensures this.

Reviewed by Simon Hausmann.

9:06 AM Changeset in webkit [110435] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, slight Skipped list reorganization and unskip a bunch
of inspector tests on GTK.

• platform/gtk/Skipped:

8:56 AM Changeset in webkit [110434] by podivilov@chromium.org

• 16 edits in trunk

Web Inspector: DebuggerModel.Location should have scriptId property.
​https://bugs.webkit.org/show_bug.cgi?id=80830

Reviewed by Vsevolod Vlasov.

Source/WebCore:

• inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

• inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.location):

• inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):

• inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

• inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):

LayoutTests:

• http/tests/inspector/compiler-source-mapping.html:
• http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

• http/tests/inspector/search/search-in-concatenated-script.html:
• http/tests/inspector/search/search-in-script.html:
• inspector/debugger/debugger-scripts.html:
• inspector/debugger/linkifier.html:
• inspector/debugger/raw-source-code.html:
• inspector/debugger/script-formatter.html:

8:50 AM Changeset in webkit [110433] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up culling tests and templatize to test impl constructs
​https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

• tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

8:47 AM Changeset in webkit [110432] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[chromium] A couple early-outs for occlusion tracker
​https://bugs.webkit.org/show_bug.cgi?id=80742

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

• platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

8:45 AM Changeset in webkit [110431] by zeno.albisser@nokia.com

• 2 edits in trunk/Source/WebCore

[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
​https://bugs.webkit.org/show_bug.cgi?id=80840

CoreFoundation/CFBase.h needs to be included to define the type CFTypeRef.

Reviewed by Tor Arne Vestbø.

• platform/mac/WebCoreObjCExtras.h:

8:34 AM Changeset in webkit [110430] by zeno.albisser@nokia.com

• 2 edits in trunk/Source/JavaScriptCore

[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
​https://bugs.webkit.org/show_bug.cgi?id=80827

Qt on Mac uses OS(DARWIN) as well, but we do not want to enable LLINT.

Reviewed by Simon Hausmann.

• wtf/Platform.h:

8:32 AM Changeset in webkit [110429] by staikos@webkit.org

• 2 edits in trunk/Source/WebCore

Remove unused global static variable for BlackBerry.
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

• platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):

8:28 AM Changeset in webkit [110428] by staikos@webkit.org

• 3 edits in trunk/Source/WebCore

Correct usage of NDEBUG to fix warnings on BlackBerry.
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

• platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::sendChangesToDatabase):

• platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::initiateCookieLimitCleanUp):

7:52 AM Changeset in webkit [110427] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=80812

Patch by Ming Xie <​mxie@rim.com> on 2012-03-12
Reviewed by Rob Buis.

• Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
• Scripts/webkitdirs.pm:

(blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define

7:43 AM Changeset in webkit [110426] by Simon Hausmann

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed prospective Qt/Mac build fix

• runtime/JSGlobalData.cpp: use #USE(CF) instead of PLATFORM(MAC) to determine

whether to include CoreFoundation headers, used for JIT configuration in JSGlobalData
constructor.

7:36 AM Changeset in webkit [110425] by timothy@apple.com

• 15 edits in trunk/Source/WebKit2

Update how the Web Inspector resources are loaded.

​https://bugs.webkit.org/show_bug.cgi?id=80814
rdar://problem/10359959

Reviewed by John Sullivan.

• Shared/WebPreferencesStore.h:

(WebKit): Added InspectorUsesWebKitUserInterface.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Removed webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

• Shared/WebProcessCreationParameters.h: Ditto.

(WebProcessCreationParameters): Ditto.

• UIProcess/API/C/WKContext.cpp:
• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorUsesWebKitUserInterface): Added.
(WKPreferencesGetInspectorUsesWebKitUserInterface): Added.

• UIProcess/API/C/WKPreferencesPrivate.h:
• UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Removed webInspectorLocalizedStringsPath.

• UIProcess/WebContext.h:

(WebContext): Ditto.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Use inspectorReallyUsesWebKitUserInterface
to determine if texture should be used.
(WebKit::WebInspectorProxy::inspectorPageURL): Choose the right path.
(WebKit::WebInspectorProxy::inspectorBaseURL): Ditto.

• WebProcess/WebPage/WebInspector.h:
• WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::setInspectorUsesWebKitUserInterface): Added.
(WebKit::WebInspector::localizedStringsURL):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Call WebInspector::setInspectorUsesWebKitUserInterface.

• WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Removed call to WebInspector::setLocalizedStringsPath.

7:33 AM Changeset in webkit [110424] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=80833

Unreviewed gardening.

• platform/qt/Skipped: Skip fast/table/table-row-compositing-repaint-crash.html to paint the bot green.

7:24 AM WebKit Team edited by yi.4.shen@nokia.com

(diff)

6:59 AM Changeset in webkit [110423] by loislo@chromium.org

• 6 edits in trunk

Re-apply the patch after v8 roll to r11000.

Web Inspector: move heap snapshot nodes data to external array.
​https://bugs.webkit.org/show_bug.cgi?id=79911

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests:
heap-shapshot.html
heap-shapshot-loader.html

• inspector/front-end/HeapSnapshot.js:

(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):

LayoutTests:

• inspector/profiler/heap-snapshot-loader.html:
• inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):

5:57 AM Changeset in webkit [110422] by Simon Hausmann

• 5 edits in trunk

[Qt] Fix build with newer Qt 5.

Reviewed by Tor Arne Vestbø.

Source/WebCore:

• platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Use DefaultCodec instead of the
deprecated CodecForTR.

Tools:

Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
we should disable -Werror.

Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
implicit load was removed recently.

• qmake/mkspecs/features/default_pre.prf:
• qmake/mkspecs/features/unix/default_post.prf:

5:31 AM Changeset in webkit [110421] by loislo@chromium.org

• 3 edits in trunk/PerformanceTests

Web Inspector: chromium: increase heap snapshot performance coverage.
​https://bugs.webkit.org/show_bug.cgi?id=80829

Reviewed by Yury Semikhatsky.

• inspector/detailed-heapshots-smoke-test.html:
• inspector/performance-test.js:

(initialize_TimeTracker.InspectorTest.measureFunction):

4:27 AM Changeset in webkit [110420] by hans@chromium.org

• 14 edits
  1 copy
  4 adds in trunk

Speech JavaScript API: SpeechRecognitionEvent
​https://bugs.webkit.org/show_bug.cgi?id=80513

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechRecognitionEvent.
(Spec: ​http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/events/constructors/speech-recognition-event-constructor.html

• Modules/speech/DOMWindowSpeech.idl:
• Modules/speech/SpeechRecognitionEvent.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionEventInit::SpeechRecognitionEventInit):
(WebCore::SpeechRecognitionEvent::create):
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::createResultDeleted):
(WebCore::SpeechRecognitionEvent::createError):
(WebCore::SpeechRecognitionEvent::interfaceName):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

• Modules/speech/SpeechRecognitionEvent.h: Added.

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::result):
(WebCore::SpeechRecognitionEvent::error):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::resultHistory):

• Modules/speech/SpeechRecognitionEvent.idl:
• WebCore.gypi:
• bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):

• bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):
(WebCore):

• bindings/v8/OptionsObject.h:

(WebCore):
(OptionsObject):

• dom/EventNames.h:

(WebCore):

• dom/EventNames.in:

LayoutTests:

Add test for SpeechRecognitionEvent.
Update Skipped files for all ports except Chromium.

• fast/events/constructors/speech-recognition-event-constructor-expected.txt: Added.
• fast/events/constructors/speech-recognition-event-constructor.html: Added.
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:

2:50 AM Changeset in webkit [110419] by fpizlo@apple.com

• 17 edits
  1 add in trunk/Source/JavaScriptCore

All DFG nodes should have a mutable set of flags
​https://bugs.webkit.org/show_bug.cgi?id=80779
<rdar://problem/11026218>

Reviewed by Gavin Barraclough.

Got rid of NodeId, and placed all of the flags that distinguished NodeId
from NodeType into a separate Node::flags field. Combined what was previously
ArithNodeFlags into Node::flags.

In the process of debugging, I found that the debug support in the virtual
register allocator was lacking, so I improved it. I also realized that the
virtual register allocator was assuming that the nodes in a basic block were
contiguous, which is no longer the case. So I fixed that. The fix also made
it natural to have more extreme assertions, so I added them. I suspect this
will make it easier to catch virtual register allocation bugs in the future.

This is mostly performance neutral; if anything it looks like a slight
speed-up.

This patch does leave some work for future refactorings; for example, Node::op
is unencapsulated. This was already the case, though now it feels even more
like it should be. I avoided doing that because this patch has already grown
way bigger than I wanted.

Finally, this patch creates a DFGNode.cpp file and makes a slight effort to
move some unnecessarily inline stuff out of DFGNode.h.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::opName):
(JSC::DFG::Graph::dump):
(DFG):

• dfg/DFGNode.cpp: Added.

(DFG):
(JSC::DFG::arithNodeFlagsAsString):

• dfg/DFGNode.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::defaultFlags):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

• dfg/DFGScoreBoard.h:

(ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::assertClear):
(JSC::DFG::ScoreBoard::use):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

2:19 AM Changeset in webkit [110418] by caseq@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, remove flakiness flags for timeline-start-time.html following a fix in r100417.
​https://bugs.webkit.org/show_bug.cgi?id=80803

• platform/chromium/test_expectations.txt:

2:02 AM Changeset in webkit [110417] by caseq@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed flakiness fix.

• inspector/timeline/timeline-start-time.html:

1:59 AM Changeset in webkit [110416] by Philippe Normand

• 15 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110409. And skip a new GTK
layout test failing after r110371.

• platform/gtk/Skipped:
• platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
• platform/gtk/fast/layers/video-layer-expected.txt:
• platform/gtk/media/audio-controls-rendering-expected.txt:
• platform/gtk/media/audio-repaint-expected.txt:
• platform/gtk/media/controls-strict-expected.txt:
• platform/gtk/media/controls-styling-expected.txt:
• platform/gtk/media/controls-without-preload-expected.txt:
• platform/gtk/media/media-controls-clone-expected.txt:
• platform/gtk/media/media-document-audio-repaint-expected.txt:
• platform/gtk/media/video-controls-rendering-expected.txt:
• platform/gtk/media/video-empty-source-expected.txt:
• platform/gtk/media/video-no-audio-expected.txt:
• platform/gtk/media/video-zoom-controls-expected.txt:

1:52 AM Changeset in webkit [110415] by rolandsteiner@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed: Fix typos in fast/css/style-scoped/style-scoped-basic.html layout test.

• fast/css/style-scoped/style-scoped-basic.html:

1:38 AM Changeset in webkit [110414] by tkent@chromium.org

• 3 edits in trunk/Source/WebCore

Use ICU C API instead of C++ API in LocalizedNumberICU
​https://bugs.webkit.org/show_bug.cgi?id=80815
​https://bugs.gentoo.org/show_bug.cgi?id=407401

Reviewed by Hajime Morita.

ICU 4.8 doesn't have kNumberStyle. We had better to use ICU C API in
general to avoid such issues.

This patch should not make any behavior change.

• platform/text/LocalizedNumberICU.cpp:

(WebCore::ICULocale::ICULocale):
Change the argument type: icu::Locale -> const char*
(WebCore::ICULocale::~ICULocale): Delete m_numberFormat with unum_close().
(WebCore::ICULocale::create): Do not create icu::Locale.
(WebCore::ICULocale::createForCurrentLocale): ditto.
(WebCore::ICULocale::setDecimalSymbol):
Use unum_getSymbol() instead of DecimalFormatSymbols::getSymbol().
(WebCore::ICULocale::setDecimalTextAttribute):
Added. A utility function to store prefixes and suffixes.
(WebCore::ICULocale::initializeDecimalFormat):

• unum_open(), instead of NumberFormat::createInstance().
• Use C API symbols.
• Cache positive/negative prefixes/suffixes.

(WebCore::ICULocale::convertToLocalizedNumber): Use cached prefixes and suffixes.
(WebCore::matches): Stop using template because we don't use UString anymore.
(WebCore::ICULocale::detectSignAndGetDigitRange):

• Use cached prefixes and suffixes.
• Use String::startsWith() and endsWith().

(WebCore::ICULocale::convertFromLocalizedNumber):

• platform/text/LocalizedNumberICU.h:

(ICULocale):

1:32 AM Changeset in webkit [110413] by podivilov@chromium.org

• 8 edits in trunk

Web Inspector: decouple LiveLocation from RawSourceCode.
​https://bugs.webkit.org/show_bug.cgi?id=80785

Reviewed by Vsevolod Vlasov.

Source/WebCore:

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):

• inspector/front-end/RawSourceCode.js:
• inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.init):
(WebInspector.LiveLocation.prototype.dispose):
(WebInspector.LiveLocation.prototype._update):

LayoutTests:

• inspector/debugger/callstack-placards-discarded-expected.txt:
• inspector/debugger/callstack-placards-discarded.html:
• inspector/debugger/linkifier.html:

12:14 AM Changeset in webkit [110412] by aestes@apple.com

• 2 edits in trunk/Source/WebKit2

Remove unnecessary call to NSSizeToCGSize().
​https://bugs.webkit.org/show_bug.cgi?id=80817

Reviewed by Dan Bernstein.

There is no need to call NSSizeToCGSize() to convert an IntSize to a
CGSize. IntSize defines a conversion function to CGSize that will do
this for us implicitly.

• UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::backingStoreContext): Do not call NSSizeToCGSize().

Mar 11, 2012:

1:11 AM Changeset in webkit [110389] by mjs@apple.com

• 4 edits
  1 add in trunk

Add --instruments option to sunspider to profile with Instruments
​https://bugs.webkit.org/show_bug.cgi?id=80783

Reviewed by Filip Pizlo.

PerformanceTests/SunSpider:

• resources/TimeProfile20us.tracetemplate: Added.
• sunspider:

(runTestsOnce):

Tools:

• Scripts/run-sunspider:

12:26 AM Changeset in webkit [110388] by ostapenko.viatcheslav@nokia.com

• 9 edits
  1 copy
  1 move
  1 add in trunk

[Qt] [WK2] Support threaded renderer in WK2
​https://bugs.webkit.org/show_bug.cgi?id=76661

Source/WebCore:

Reviewed by Noam Rosenthal.

Add TransformationMatrix conversions from/to Qt QMatrix4x4. Used by Qt WebKit2
rendering and tested by Qt WebKit2 API tests.

• platform/graphics/qt/TransformationMatrixQt.cpp:

(WebCore::TransformationMatrix::operator QMatrix4x4):
(WebCore):
(WebCore::TransformationMatrix::TransformationMatrix):

• platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit2:

Reviewed by Noam Rosenthal.

Implement Qt5 threaded rendering support for Qt WebKit2.
Parts of LayerTreeHostProxy which contain layer tree and layer painting objects
are moved to separate class called WebLayerTreeRenderer. WebLayerTreeRenderer is
thread safe ref counted and referenced by LayerTreeHostProxy and paint node.
All layer tree and graphics objects are created, accessed and deallocated from Qt
Scenegraph's paint thread only.
Layer tree updates from render queue are fetched in updatePaintNode call stack when
main thread is locked.
Messages from paint thread to web process are passed through MainThreadGuardedInvoker
call gate (implemented by Noam Rosenthal and previously reviewed by Kenneth Rohde
Christiansen).

• Target.pri:
• UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyNode::PageProxyNode):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(PageProxyNode::layerTreeRenderer):
(PageProxyNode):
(PageProxyNode::setScale):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

• UIProcess/LayerTreeHostProxy.cpp: Added.

(WebKit):
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::~LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::purgeBackingStores):

• UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::layerTreeRenderer):

• UIProcess/WebLayerTreeRenderer.cpp: Renamed from Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp.

(WebKit):
(MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::WebLayerTreeRenderer::callOnMainTread):
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::~WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::createLayer):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::syncAnimations):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRectForScaling):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::ensureLayer):
(WebKit::WebLayerTreeRenderer::setRootLayerID):
(WebKit::WebLayerTreeRenderer::getBackingStore):
(WebKit::WebLayerTreeRenderer::createTile):
(WebKit::WebLayerTreeRenderer::removeTile):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):
(WebKit::WebLayerTreeRenderer::destroyImage):
(WebKit::WebLayerTreeRenderer::assignImageToLayer):
(WebKit::WebLayerTreeRenderer::swapBuffers):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::ensureRootLayer):
(WebKit::WebLayerTreeRenderer::syncRemoteContent):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
(WebKit::WebLayerTreeRenderer::appendUpdate):

• UIProcess/WebLayerTreeRenderer.h: Copied from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.

(WebKit):
(WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::layerByID):
(WebKit::WebLayerTreeRenderer::rootLayer):
(WebKit::WebLayerTreeRenderer::notifyAnimationStarted):
(WebKit::WebLayerTreeRenderer::notifySyncRequired):
(WebKit::WebLayerTreeRenderer::showDebugBorders):
(WebKit::WebLayerTreeRenderer::showRepaintCounter):
(WebKit::WebLayerTreeRenderer::paintContents):

Tools:

Remove disabling of threaded rendering.

Reviewed by Noam Rosenthal.

• MiniBrowser/qt/main.cpp:

(main):

Mar 10, 2012:

11:07 PM Changeset in webkit [110411] by ukai@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

• platform/chromium/test_expectations.txt:

10:59 PM Changeset in webkit [110410] by ukai@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

• platform/chromium/test_expectations.txt:

9:47 PM Changeset in webkit [110409] by commit-queue@webkit.org

• 16 edits in trunk

Source/WebCore: The main code structure for placing future text track cue rendering
code and main outer rendering steps.
​https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

No new tests. Only refactoring, but some chromium tests require rebaselining
and have been marked accordingly.

• css/mediaControls.css:

(::-webkit-media-controls): Changed the default display to -webkit-box, as
captions need to always be rendered on top of the controls, if they are visible.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box
(video::-webkit-media-text-track-container): The position of the container is
now relative, handled by -webkit-box.
(video::-webkit-media-text-track-display): Adjusted text color to match
the color required in the WebVTT spec (section 3.5.1 'color' property)

• css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added a timer
for the webkit fade out transition event. This timer is required for setting
the display property to 'none', when the fade out transition is over. Otherwise,
captions would not be displayed at the bottom of the video.
(WebCore::MediaControlPanelElement::startTimer): Added.
(WebCore):
(WebCore::MediaControlPanelElement::stopTimer): Added.
(WebCore::MediaControlPanelElement::transitionTimerFired): Added. If the current
state of the controls is transparent, the display property is set to 'none'.
(WebCore::MediaControlPanelElement::makeOpaque): The inline display:'none' property
is removed before the fade in transition.
(WebCore::MediaControlPanelElement::makeTransparent): Added the timer start.
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
Removed m_bottom as it is not needed anymore.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added. Main
function for the rendering rules.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): The bottom position
needs not to be set anymore.

• html/shadow/MediaControlElements.h:

(MediaControlPanelElement): Added timer internals.
(MediaControlTextTrackContainerElement): Added updateDisplay() and removed unused
variables.

(WebCore):

• html/shadow/MediaControlRootElement.cpp: Removed m_textTrackDisplay

and duplicated code with MediaControlRootElementChromium (only minimum
function calls to the main text track container)
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::createTextTrackDisplay):
(WebCore::MediaControlRootElement::updateTextTrackDisplay):

• html/shadow/MediaControlRootElementChromium.cpp: Removed m_textTrackDisplay

and duplicate code with MediaControlRootElement (only minimum function calls
to the main text track container remained)
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

(WebCore):

• html/track/TextTrackCue.cpp: Enhanced structure for supporting more complex

rendering required by the WebVTT spec.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueDidChange): Mark the display tree as obsolete, so that
it needs to be re-computed.
(WebCore::TextTrackCue::setIsActive): The display tree needs to be removed as
soon as the cue becomes inactive. Adjusted this method to support the functionality.
(WebCore):
(WebCore::TextTrackCue::determineDisplayParameters): Added. This method will hold
main positioning parameter computations for a TextTrackCue
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Added. This method returns the root node
of the CSS boxes that need to be displayed on top of the video, for the current
instance.

• html/track/TextTrackCue.h:

(WebCore):
(TextTrackCue):

LayoutTests: Updated layout tests for basic rendering of cues.
Some Chromium tests require rebaselining and have been marked accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

• media/media-controls.js: Adjusted helper function.

(mediaControlsElement):
(textTrackDisplayElement): If the method is called with only
one parameter, it returns the text track container instead of
a specific cue.

• media/track/track-cue-mutable-text-expected.txt: Adjusted.
• media/track/track-cue-nothing-to-render-expected.txt: Adjusted.
• media/track/track-cue-rendering-expected.txt: Adjusted.
• media/track/track-cue-rendering.html: Adjusted.
• platform/chromium/test_expectations.txt: Marked tests that need to

be rebaselined accordingly.

9:04 PM Changeset in webkit [110408] by noel.gordon@gmail.com

• 2 edits
  1 add in trunk/LayoutTests

Unreviewed gardening. Rebaseline svg/text/foreignObject-repaint.xml to close
out ​http://crbug.com/11483

• platform/chromium-linux/svg/text/foreignObject-repaint-expected.png: Added.
• platform/chromium/test_expectations.txt:

8:57 PM Changeset in webkit [110407] by ukai@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations

• platform/chromium/test_expectations.txt:

7:26 PM Changeset in webkit [110406] by ukai@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

• platform/chromium/test_expectations.txt:

6:29 PM Changeset in webkit [110405] by commit-queue@webkit.org

• 8 edits in trunk/Source

Unreviewed, rolling out r110359.
​http://trac.webkit.org/changeset/110359
​https://bugs.webkit.org/show_bug.cgi?id=80799

SelectPopupMenuTest.ClickItem failure (Requested by ukai on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-11

Source/WebCore:

• platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

• platform/chromium/PopupListBox.h:

(PopupContainerSettings):

• platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

• platform/chromium/PopupMenuChromium.h:

(PopupMenuChromium):

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

6:29 PM Changeset in webkit [110404] by timothy@apple.com

• 3 edits in trunk/Source

Mac build fix.

6:14 PM Changeset in webkit [110403] by timothy@apple.com

• 4 edits in trunk/Source/WebKit

Update how the Web Inspector resources are loaded.

​https://bugs.webkit.org/show_bug.cgi?id=80798
rdar://problem/10359959

Reviewed by Brian Weinstein.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Add a framework.

Source/WebKit/mac:

• WebCoreSupport/WebInspectorClient.mm:

(useWebKitWebInspector): Return if we are using the WebCore resources for compatibility
with local and nightly builds.
(WebInspectorFrontendClient::localizedStringsURL): Decide what path to use.
(-[WebInspectorWindowController init]): Ditto.
(-[WebInspectorWindowController window]): Decide if the window is textured or not.

5:40 PM Changeset in webkit [110402] by timothy@apple.com

• 2 edits in trunk/Source/WebCore

Fix a crash opening the Web Inspector in WebKit1 clients.

The call to InspectorFrontendClientLocal::setAttachedWindow is preformed really early in the process,
causing it to crash almost every time. It should use evaluateOnLoad instead of evaluateAsBoolean.

<rdar://problem/10951109> Crash when bringing up Web Inspector in WebKit1 client
​https://bugs.webkit.org/show_bug.cgi?id=80796

Reviewed by Brian Weinstein.

• inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Use evaluateOnLoad instead of evaluateAsBoolean.

3:17 PM Changeset in webkit [110401] by shawnsingh@chromium.org

• 3 edits
  3 adds in trunk

REGRESSION (r93614): scrolling div does not repaint
​https://bugs.webkit.org/show_bug.cgi?id=80641

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/newly-composited-repaint-rect.html

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When a layer
becomes newly composited and creates its backing, the repaintRect
may become invalid. This patch recomputes repaintRects in this
case.

LayoutTests:

• compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
• compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
• compositing/repaint/newly-composited-repaint-rect.html: Added.

3:07 PM Changeset in webkit [110400] by jochen@chromium.org

• 1 edit
  2 copies in branches/chromium/1025

Merge 108780 - [v8] when a named item on document goes out of scope, actually remove it
​https://bugs.webkit.org/show_bug.cgi?id=79409

Reviewed by Adam Barth.

Source/WebCore:

The original change already included the code, but it led to some
problems, so it was reverted in ​http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.

Test: fast/dom/HTMLDocument/named-item.html

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemRemoved):

LayoutTests:

• fast/dom/HTMLDocument/named-item-expected.txt: Added.
• fast/dom/HTMLDocument/named-item.html: Added.

TBR=​jochen@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9667038

1:12 PM Changeset in webkit [110399] by staikos@webkit.org

• 2 edits in trunk/Source/WebCore

Enable JPEG encoding for BlackBerry.
​https://bugs.webkit.org/show_bug.cgi?id=80792

Reviewed by Antonio Gomes.

• PlatformBlackBerry.cmake:

12:52 PM Changeset in webkit [110398] by barraclough@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Inconsistent SyntaxError from new Function(...)
​https://bugs.webkit.org/show_bug.cgi?id=59795

Rubber stamped by Oliver Hunt.

• fast/js/function-constructor-error-expected.txt: Added.
• fast/js/function-constructor-error.html: Added.
• fast/js/script-tests/function-constructor-error.js: Added.
  • Adding test cases.

12:50 PM Changeset in webkit [110397] by mitz@apple.com

• 12 edits
  4 adds in trunk/Source/WebKit2

WebKit2 lacks API for obtaining a representation of the RenderLayer tree of a page, like WebRenderLayer
<​http://webkit.org/b/80791>

Reviewed by Anders Carlsson.

• CMakeLists.txt:
• GNUmakefile.am:

• Shared/API/c/WKBase.h: Added a type definition of WKRenderLayerRef.

• Shared/API/c/WKRenderLayer.cpp: Added.

(WKRenderLayerGetTypeID): Added. Returns the WKRenderLayer type ID.
(WKRenderLayerCopyRendererName): Added this getter wrapper.
(WKRenderLayerCopyElementTagName): Ditto.
(WKRenderLayerCopyElementID): Ditto.
(WKRenderLayerGetElementClassNames): Ditto.
(WKRenderLayerGetAbsoluteBounds): Ditto.
(WKRenderLayerIsClipping): Ditto.
(WKRenderLayerIsClipped): Ditto.
(WKRenderLayerIsReflection): Ditto.
(WKRenderLayerGetCompositingLayerType): Ditto.
(WKRenderLayerGetNegativeZOrderList): Ditto.
(WKRenderLayerGetNormalFlowList): Ditto.
(WKRenderLayerGetPositiveZOrderList): Ditto.

• Shared/API/c/WKRenderLayer.h: Added.

• Shared/APIObject.h: Added TypeRenderLayer to the APIObject::Type enum.

• Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode): Added WebRenderLayer encoding.
(WebKit::UserMessageDecoder::baseDecode): Added WebRenderLayer decoding.

• Shared/WebRenderLayer.cpp: Added.

(WebKit::WebRenderLayer::create): Added. Creates a WebRenderLayer for the page’s main
frame’s root layer.
(WebKit::WebRenderLayer::createArrayFromLayerList): Added this helper function.
(WebKit::WebRenderLayer::WebRenderLayer): Added. Constructs a WebRenderLayer with the
renderer name, element tag, ID and class names, metrics, child lists, and compositing
layer properties of the given RenderLayer.

• Shared/WebRenderLayer.h: Added.

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::negativeZOrderList):
(WebKit::WebRenderLayer::normalFlowList):
(WebKit::WebRenderLayer::positiveZOrderList):
(WebKit::WebRenderLayer::renderObjectName):
(WebKit::WebRenderLayer::elementTagName):
(WebKit::WebRenderLayer::elementID):
(WebKit::WebRenderLayer::elementClassNames):
(WebKit::WebRenderLayer::isReflection):
(WebKit::WebRenderLayer::isClipping):
(WebKit::WebRenderLayer::isClipped):
(WebKit::WebRenderLayer::compositingLayerType):
(WebKit::WebRenderLayer::absoluteBoundingBox):
(WebKit::WebRenderLayer::WebRenderLayer):

• Target.pri

• UIProcess/API/C/WKAPICast.h: Added a mapping between WKRenderLayerRef and WebRenderLayer.

• WebKit2.xcodeproj/project.pbxproj: Added WebRenderLayer.{cpp,h} and WKRenderLayer.{cpp,h}.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderLayerTree): Added this bundle API for getting the layer tree.

• WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

• win/WebKit2.vcproj:

11:58 AM Changeset in webkit [110396] by barraclough@apple.com

• 5 edits in trunk

Source/JavaScriptCore: LLInt should support JSVALUE64
​https://bugs.webkit.org/show_bug.cgi?id=79609
<rdar://problem/10063437>

Patch by Filip Pizlo <​fpizlo@apple.com> on 2012-03-10
Reviewed by Gavin Barraclough and Oliver Hunt.

Ported the LLInt, which previously only worked on 32-bit, to 64-bit. This
patch moves a fair bit of code from LowLevelInterpreter32_64.asm to the common
file, LowLevelInterpreter.asm. About 1/3 of the LLInt did not have to be
specialized for value representation.

Also made some minor changes to offlineasm and the slow-paths.

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LLIntEntrypoints.cpp:
• llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::jitCompileAndSetHeuristics):

• llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::SlowPathReturnType::SlowPathReturnType):
(JSC::LLInt::encodeResult):

• llint/LLIntThunks.cpp:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/armv7.rb:
• offlineasm/asm.rb:
• offlineasm/ast.rb:
• offlineasm/backends.rb:
• offlineasm/instructions.rb:
• offlineasm/parser.rb:
• offlineasm/registers.rb:
• offlineasm/transform.rb:
• offlineasm/x86.rb:
• wtf/Platform.h:

LayoutTests: Object.freeze broken on latest Nightly
​https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

• fast/js/preventExtensions-expected.txt:
• fast/js/script-tests/preventExtensions.js:
  • Added test cases.

10:34 AM Changeset in webkit [110395] by pfeldman@chromium.org

• 6 edits
  2 adds in trunk

Web Inspector: console.log attempts to substitute any "%" character in the message.
​https://bugs.webkit.org/show_bug.cgi?id=80504

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-string-format.html

• inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):

• inspector/front-end/ProfileDataGridTree.js:
• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

• inspector/front-end/utilities.js:

LayoutTests:

• inspector/console/console-string-format-expected.txt: Added.
• inspector/console/console-string-format.html: Added.

9:35 AM Changeset in webkit [110394] by caseq@chromium.org

• 6 edits
  2 adds in trunk

Web Inspector: use monotonically increasing time in timeline agent
​https://bugs.webkit.org/show_bug.cgi?id=80786

Reviewed by Pavel Feldman.

• bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::timestamp):
(WebCore):

• inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timestamp):

8:09 AM Changeset in webkit [110393] by vsevik@chromium.org

• 5 edits
  3 adds in trunk

Web Inspector: Network panel does not show responses for application/json data
​https://bugs.webkit.org/show_bug.cgi?id=80684

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/async-xhr-json-mime-type.html

• inspector/InspectorPageAgent.cpp:

(WebCore::createXHRTextDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

• inspector/InspectorPageAgent.h:
• inspector/NetworkResourcesData.cpp:

(WebCore::createOtherResourceTextDecoder):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):

LayoutTests:

• http/tests/inspector/network/async-xhr-json-mime-type-expected.txt: Added.
• http/tests/inspector/network/async-xhr-json-mime-type.html: Added.
• http/tests/inspector/network/resources/json.php: Added.

7:59 AM Changeset in webkit [110392] by vsevik@chromium.org

• 3 edits
  3 adds in trunk

Web Inspector: CSS content is not shown when stylesheet is loaded with invalid mime type in quirks mode.
​https://bugs.webkit.org/show_bug.cgi?id=80528

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):

LayoutTests:

• http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt: Added.
• http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html: Added.
• http/tests/inspector/resource-tree/resources/stylesheet-text-plain.php: Added.

6:15 AM Changeset in webkit [110391] by pfeldman@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] add provisional test for the downstream sanity test.
​https://bugs.webkit.org/show_bug.cgi?id=80784

Reviewed by Yury Semikhatsky.

• src/js/Tests.js:

(.TestSuite.prototype.checkLogAndErrorMessages.validMessage):
(.TestSuite.prototype.checkLogAndErrorMessages.onConsoleMessage):
(.TestSuite.prototype.checkLogAndErrorMessages):

3:11 AM Changeset in webkit [110390] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

<​http://webkit.org/b/80782> Web Inspector: Crash using released frontendClient when resizing window with closed inspector

The WebInspectorFrontendClient reference should be cleared when the
WebInspectorClient::closeInspectorFrontend is called. This adds a
destroyInspectorPage to mirror createInspectorPage and clear the weak
pointers that are no longer valid.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-03-11
Reviewed by Pavel Feldman.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::didResizeMainFrame):

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::destroyInspectorPage):

• WebProcess/WebPage/WebInspector.h: