Timeline
Mar 13, 2012:
- 11:54 PM Changeset in webkit [110665] by
-
- 19 edits in trunk
Source/WebCore: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.
Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.
No new tests. Existing tests are updated.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.
- html/HiddenInputType.h: Added isLabelable returning false.
- html/InputType.cpp:
(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):
- html/InputType.h:
(InputType): Added isLabelable declaration.
LayoutTests: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.
- fast/forms/label/labelable-elements-expected.txt:
- fast/forms/label/labelable-elements.html:
- fast/forms/label/labels-add-htmlFor-label-expected.txt:
- fast/forms/label/labels-add-parent-label-expected.txt:
- fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-multiple-sibling-labels-expected.txt:
- fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
- fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-remove-htmlFor-label-expected.txt:
- fast/forms/label/labels-remove-parent-label-expected.txt:
- fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
- platform/chromium/fast/forms/label/labelable-elements-expected.txt:
- platform/mac/fast/forms/label/labelable-elements-expected.txt:
- 11:35 PM Changeset in webkit [110664] by
-
- 15 edits in trunk
[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
Source/WebCore:
This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.
Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.
- html/HTMLOutputElement.h: Implement virtual method isLabelable.
LayoutTests:
This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.
- fast/forms/label/labelable-elements-expected.txt:
- fast/forms/label/labels-add-htmlFor-label-expected.txt:
- fast/forms/label/labels-add-parent-label-expected.txt:
- fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-multiple-sibling-labels-expected.txt:
- fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
- fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-remove-htmlFor-label-expected.txt:
- fast/forms/label/labels-remove-parent-label-expected.txt:
- fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
- platform/chromium/fast/forms/label/labelable-elements-expected.txt:
- platform/mac/fast/forms/label/labelable-elements-expected.txt
- 11:24 PM Changeset in webkit [110663] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking some tests flaky.
- platform/chromium/test_expectations.txt:
- 8:19 PM Changeset in webkit [110662] by
-
- 3 edits in trunk/Source/WebCore
Move opacity clamping into RenderStyle setter.
https://bugs.webkit.org/show_bug.cgi?id=76966
Reviewed by Eric Seidel.
Covered by existing tests.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::setOpacity):
- 7:54 PM Changeset in webkit [110661] by
-
- 4 edits in trunk/Source/JavaScriptCore
ValueToInt32 speculation will cause OSR exits even when it does not have to
https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/11043926>
Reviewed by Anders Carlsson.
Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead
of exiting, if it doesn't know what speculations to perform.
2) ValueToInt32 will speculate boolean if it sees this to be profitable.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
- 7:47 PM Changeset in webkit [110660] by
-
- 2 edits in trunk/Source/JavaScriptCore
More Windows build fixing
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 7:40 PM Changeset in webkit [110659] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 7:28 PM Changeset in webkit [110658] by
-
- 3 edits3 copies in branches/chromium/1025
Merge 110593
BUG=112317
Review URL: https://chromiumcodereview.appspot.com/9703008
- 7:12 PM Changeset in webkit [110657] by
-
- 9 edits in trunk/Source/JavaScriptCore
Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673
Reviewed by Geoffrey Garen.
- parser/Lexer.cpp:
(JSC::::lex):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).
- runtime/LiteralParser.cpp:
(JSC::::Lexer::lexNumber):
- tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that
we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.
- wtf/dtoa.cpp:
(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.
- wtf/dtoa.h:
- wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the
Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).
- wtf/text/WTFString.cpp:
(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.
- 6:38 PM Changeset in webkit [110656] by
-
- 3 edits in trunk/Source/WebCore
Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856
Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent
Reviewed by Julien Chaffraix.
No change in behavior expected.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderObjectChildList.h:
(WebCore):
(RenderObjectChildList):
- 6:37 PM Changeset in webkit [110655] by
-
- 131 edits112 copies18 moves54 adds23 deletes in trunk/LayoutTests
FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.
- 6:26 PM Changeset in webkit [110654] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.
- dfg/DFGOperations.h:
- llint/LLIntSlowPaths.h:
- 6:09 PM Changeset in webkit [110653] by
-
- 4 edits in trunk/Source/WebKit2
Find bouncy doesn’t hide when a subframe is scrolled
https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>
Reviewed by Andreas Kling.
Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
- WebProcess/WebPage/FindController.h:
(FindController):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageDidScroll):
- 6:07 PM Changeset in webkit [110652] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194
Skip yet another test that uses eventSender.
- platform/wk2/Skipped:
- 5:46 PM Changeset in webkit [110651] by
-
- 3 edits in trunk/Source/JavaScriptCore
Functions with C linkage should return POD types
https://bugs.webkit.org/show_bug.cgi?id=81061
Reviewed by Mark Rowe.
- dfg/DFGOperations.h:
- llint/LLIntSlowPaths.h:
(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):
- 5:36 PM Changeset in webkit [110650] by
-
- 14 edits in trunk/LayoutTests
Remove duplicate GC functions from layout tests
https://bugs.webkit.org/show_bug.cgi?id=81047
Reviewed by Ojan Vafai.
- fast/canvas/webgl/shader-deleted-by-accessor.html:
- fast/dom/Window/customized-property-survives-gc.html:
- fast/dom/inline-event-attributes-lookup-removed-form.html:
- fast/dom/inline-event-attributes-lookup-removed.html:
- fast/dom/shadow/gc-shadow.html:
- fast/filesystem/resources/file-writer-gc-blob.js:
- fast/forms/input-image-submit.html:
- fast/forms/interactive-validation-remove-node-in-handler.html:
- fast/forms/select-set-length-with-mutation-remove.html:
- fast/js/resources/js-test-pre.js:
(gc.else.gcRec):
(gc):
- http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
- http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
- webaudio/mediaelementaudiosourcenode-gc.html:
- 5:31 PM Changeset in webkit [110649] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689
Add more tests that use setEditingBehavior to the wk2 Skipped list.
- platform/wk2/Skipped:
- 5:28 PM Changeset in webkit [110648] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
https://bugs.webkit.org/show_bug.cgi?id=78529
After r110620, root layer scrollbars are drawn opaque, so they no
longer differ between debug and release due to alpha values.
Rebaselining this test.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium/test_expectations.txt:
- 5:27 PM Changeset in webkit [110647] by
-
- 2 edits in trunk/LayoutTests
- platform/mac/fast/js/global-constructors-expected.txt: Added Selection.toString and WebKitMutationObserver.toString. Selection got exposed in <http://trac.webkit.org/changeset/109306>, and WebKitMutationObserver was probably failing for even longer.
- 5:18 PM Changeset in webkit [110646] by
-
- 2 edits in trunk/Source/WebCore
Fix potential crash when loading test results
https://bugs.webkit.org/show_bug.cgi?id=81062
<rdar://problem/11041732>
Reviewed by Dean Jackson.
If RenderLayerBacking::isSimpleContainerCompositingLayer() is called early,
before the document has a documentElement(), then it crashes. Fix with
a null check on documentElement().
No test because it's timing dependent.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- 5:08 PM Changeset in webkit [110645] by
-
- 3 edits in trunk/LayoutTests
platform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=81058
Add unreviewed expected failing result (which may actually be correct) for mac.
- platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- 5:06 PM Changeset in webkit [110644] by
-
- 2 edits in trunk/LayoutTests
MediaStream is not enabled on Mac. Skip all related tests.
- platform/mac/Skipped:
- 4:58 PM Changeset in webkit [110643] by
-
- 3 edits1 add in trunk
<rdar://problem/11025225> Assertion failure in RenderView::computeRectForRepaint() (!repaintContainer repaintContainer == this) at store.apple.com https://bugs.webkit.org/show_bug.cgi?id=81051
Reviewed by Simon Fraser.
.:
- ManualTests/inline-repaint-container.html: Added.
Source/WebCore:
Test: ManualTests/inline-repaint-container.html.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): This function was not handling the
case of the repaint container being a descendant of the containing block correctly, leading
to the assertion failure, but also to a correctness bug seen in the new test. If the repaint
container is a descendant of the containing block, just return the rect in the repaint
container coordinates.
- 4:57 PM Changeset in webkit [110642] by
-
- 4 edits2 adds in trunk
<rdar://problem/11025217> [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText
https://bugs.webkit.org/show_bug.cgi?id=77044
Reviewed by Sam Weinig.
Source/WebCore:
Test: platform/mac/fast/text/core-text-fallback-to-unknown-font.html
Handle the case of Core Text choosing a fallback font that NSFontManager cannot find by name.
- platform/graphics/FontCache.h:
(FontCache): Made ComplexTextController a friend class.
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the
failing assertion, which was not true, and added code to handle the case where a font
cannot be found by name by using the font as returned from Core Text.
LayoutTests:
- platform/mac/fast/text/core-text-fallback-to-unknown-font-expected.txt: Added.
- platform/mac/fast/text/core-text-fallback-to-unknown-font.html: Added.
- 4:56 PM Changeset in webkit [110641] by
-
- 43 edits2 deletes in trunk
[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880
Reviewed by Adam Barth.
Source/WebCore:
We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.
To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).
Second try. This time with an added include in TextTrackList.cpp.
No new tests. Covered by existing tests.
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- css/CSSStyleSheet.idl:
- css/StyleSheet.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- html/DOMTokenList.idl:
- html/track/TextTrackList.cpp:
- html/track/TextTrackList.idl:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 4:45 PM Changeset in webkit [110640] by
-
- 3 edits2 adds in trunk
MathML crash in WebCore::Node::previousSibling()
https://bugs.webkit.org/show_bug.cgi?id=80773
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-13
Reviewed by Julien Chaffraix.
Source/WebCore:
When adding child for msub render, if the child is mtr or mtd render,
we will creat an anonymous render as the container. As the anonymous
render's node is 0, accessing it directly can cause crash.
We should do a valid check of the node before using. In addition to
that, for msub, attach the anonymous render and it's children to render
tree. For msubsup, such kind of situation should never happen based on
the current codebase.
Test: mathml/msub-anonymous-child-render-crash.html
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
LayoutTests:
- mathml/msub-anonymous-child-render-crash-expected.txt: Added.
- mathml/msub-anonymous-child-render-crash.html: Added.
- 4:43 PM Changeset in webkit [110639] by
-
- 17 edits14 deletes in trunk
[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
https://bugs.webkit.org/show_bug.cgi?id=81021
Reviewed by Ryosuke Niwa.
Reverting the original patch as we need a better solution.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Node.cpp:
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):
- dom/Node.h:
(Node):
- dom/NodeRareData.h:
(NodeListsNodeData):
- dom/RegionNodeList.cpp: Removed.
- dom/RegionNodeList.h: Removed.
- dom/WebKitNamedFlow.cpp:
- dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
- rendering/RenderFlowThread.cpp:
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
- fast/regions/get-regions-by-content-node-expected.txt: Removed.
- fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Removed.
- fast/regions/get-regions-by-content-node-horiz-bt.html: Removed.
- fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Removed.
- fast/regions/get-regions-by-content-node-horiz-tb.html: Removed.
- fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Removed.
- fast/regions/get-regions-by-content-node-vert-lr.html: Removed.
- fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Removed.
- fast/regions/get-regions-by-content-node-vert-rl.html: Removed.
- fast/regions/get-regions-by-content-node.html: Removed.
- fast/regions/get-regions-by-content-node2-expected.txt: Removed.
- fast/regions/get-regions-by-content-node2.html: Removed.
- 4:39 PM Changeset in webkit [110638] by
-
- 8 edits in trunk/Source/WebKit2
Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044
This code was written by Jessie Berlin.
Reviewed by Brady Eidson.
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadWebArchiveData): Added.
- UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadWebArchiveData): Added.
- UIProcess/WebPageProxy.h: Added loadWebArchiveData().
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadWebArchiveData): Added.
- WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().
- WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.
- 4:31 PM Changeset in webkit [110637] by
-
- 2 edits in trunk/LayoutTests
Note that this test is flaky. The flakiness dashboard says that this
test has been flaky for a while.
- platform/chromium/test_expectations.txt:
- 4:28 PM Changeset in webkit [110636] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Add a Leopard-specific baseline for
fast/forms/file/file-input-pressed-state and generalize the
chromium-win-vista baseline to include all of windows.
- platform/chromium-mac-leopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
- platform/chromium-win-vista/fast/forms/file: Removed.
- platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Removed.
- platform/chromium-win-xp/fast/forms/file: Removed.
- platform/chromium-win/fast/forms/file/file-input-pressed-state-expected.png: Added.
- 4:28 PM Changeset in webkit [110635] by
-
- 6 edits in trunk/Source
[chromium] wrong transform causing incorrect culling
https://bugs.webkit.org/show_bug.cgi?id=80471
Reviewed by James Robinson.
Source/WebCore:
Unit test added to CCRenderSurfaceTest.cpp
In addition to using originTransform() instead of drawTransform(),
this patch shuffles a bit of code so that a unit test can be
easily added.
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):
(WebCore):
- 4:18 PM Changeset in webkit [110634] by
-
- 1 edit2 adds in trunk/LayoutTests
more multiline flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=81025
Reviewed by Ojan Vafai.
Add a test case for wrap-reverse to verify that we align with the end of the flexbox.
- css3/flexbox/multiline-reverse-wrap-overflow-expected.txt: Added.
- css3/flexbox/multiline-reverse-wrap-overflow.html: Added.
- 4:11 PM Changeset in webkit [110633] by
-
- 2 edits in trunk/LayoutTests
fast/loader/form-submission-after-beforeunload-cancel.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=81024
Reviewed by Andy Estes.
- fast/loader/form-submission-after-beforeunload-cancel.html:
Give the form post a better chance of loading before the FAIL timer.
- 4:00 PM Changeset in webkit [110632] by
-
- 4 edits2 adds in trunk
Alternate xml-stylesheets with no title are loaded, in violation of the CSSOM draft
https://bugs.webkit.org/show_bug.cgi?id=77549
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.
Source/WebCore:
Amended code to ignore alternate stylesheets that do not have a title attribute.
Test: fast/css/xml-stylesheet-alternate-no-title.xhtml
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
LayoutTests:
Added new text test, modified existing test: added title attribute to alternate stylesheet.
- fast/css/xml-stylesheet-alternate-no-title-expected.txt: Added.
- fast/css/xml-stylesheet-alternate-no-title.xhtml: Added.
- fast/css/xml-stylesheet-alternate-processing.xhtml:
- 3:59 PM Changeset in webkit [110631] by
-
- 8 edits in trunk/Source/JavaScriptCore
Loads from UInt32Arrays should not result in a double up-convert if it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=80979
<rdar://problem/11036848>
Reviewed by Oliver Hunt.
Also improved DFG IR dumping to include type information in a somewhat more
intuitive way.
- bytecode/PredictedType.cpp:
(JSC::predictionToAbbreviatedString):
(JSC):
- bytecode/PredictedType.h:
(JSC):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
- 3:57 PM Changeset in webkit [110630] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Input focus state should unfocus the frame selection instead of the field.
https://bugs.webkit.org/show_bug.cgi?id=81023
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.
PR 137400.
Prevent cursor drawing by unfocusing the frame selection
when input mode is not ready.
Greatly simplify the decision to focus input fields by removing
all ties to the page load state and base it on input. Input mode
is disabled when a page load begins and enabled on any user input.
The field is focused and ready for input immediately, only the
frame selection (or cursor) is unfocused.
Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- Api/WebPageClient.h:
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldBeginEditing):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::enableInputMode):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::setComposingText):
- WebKitSupport/InputHandler.h:
(InputHandler):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 3:53 PM Changeset in webkit [110629] by
-
- 4 edits in trunk/Source/WebCore
Revert RenderLayer::absoluteBoundingBox to an IntRect
https://bugs.webkit.org/show_bug.cgi?id=81017
Reviewed by Eric Seidel.
Reverting RenderLayer::absoluteBoundingBox to an (pixel snapped) IntRect. Whenever
possible, we use integers representing for absolute coordinates. This is especially
relevant for methods, such as this one, that are exported and used in platform code.
No new tests. No change in behavior.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::absoluteBoundingBox):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): This intersects
the absolute bounding box with the FrameView, which uses all integer values. It's
the only use of absoluteBoundingBox in WebCore.
- 3:51 PM Changeset in webkit [110628] by
-
- 1 edit7 adds in trunk/LayoutTests
Adding missing results.
- platform/mac/media/audio-repaint-expected.txt: Added.
- platform/mac/media/controls-strict-expected.txt: Added.
- platform/mac/media/video-controls-rendering-expected.txt: Added.
- platform/mac/media/video-no-audio-expected.txt: Added.
- platform/mac/media/video-display-toggle-expected.txt: Added. These already had PNG results, but no text results for platform/mac.
- platform/mac/media/controls-layout-direction-expected.png: Added.
- platform/mac/media/video-playing-and-pause-expected.png: Added. These had text results, but no pixel ones.
- 3:50 PM Changeset in webkit [110627] by
-
- 4 edits in trunk/Source
[chromium] vsync ticks are needed in invisible tabs when we are still updating resources
https://bugs.webkit.org/show_bug.cgi?id=80910
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
Source/WebKit/chromium:
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
- 3:40 PM Changeset in webkit [110626] by
-
- 3 edits14 adds in trunk
Alternate stylesheets (without title attribute) are loaded on refresh
https://bugs.webkit.org/show_bug.cgi?id=24354
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.
Source/WebCore:
Alternate stylesheets are now ignored in <link> tags if
they have no title attribute (per spec).
Tests: fast/css/link-alternate-stylesheet-1.html
fast/css/link-alternate-stylesheet-2.html
fast/css/link-alternate-stylesheet-3.html
fast/css/link-alternate-stylesheet-4.html
fast/css/link-alternate-stylesheet-5.html
- dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):
LayoutTests:
Addapted alternate stylesheet tests from http://robballou.com/switcher/sandbox/alternate1.php
- fast/css/link-alternate-stylesheet-1-expected.txt: Added.
- fast/css/link-alternate-stylesheet-1.html: Added.
- fast/css/link-alternate-stylesheet-2-expected.txt: Added.
- fast/css/link-alternate-stylesheet-2.html: Added.
- fast/css/link-alternate-stylesheet-3-expected.txt: Added.
- fast/css/link-alternate-stylesheet-3.html: Added.
- fast/css/link-alternate-stylesheet-4-expected.txt: Added.
- fast/css/link-alternate-stylesheet-4.html: Added.
- fast/css/link-alternate-stylesheet-5-expected.txt: Added.
- fast/css/link-alternate-stylesheet-5.html: Added.
- fast/css/resources/basic.css: Added.
(body):
(code):
(#source):
- fast/css/resources/high.css: Added.
(body):
(h1):
- fast/css/resources/normal.css: Added.
(body):
(h1):
- fast/css/resources/small.css: Added.
(body):
- 3:36 PM Changeset in webkit [110625] by
-
- 2 edits in trunk/LayoutTests
WKTR needs an implementation of setAsynchronousSpellCheckingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=81042
Skip some tests on Mac WK2 that use setAsynchronousSpellCheckingEnabled.
- platform/mac-wk2/Skipped:
- 3:35 PM Changeset in webkit [110624] by
-
- 4 edits1 add in trunk/Source
Region::contains(IntPoint) is slow
https://bugs.webkit.org/show_bug.cgi?id=81008
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Anders Carlsson.
Source/WebCore:
Speed up Region::contains(IntPoint) by directly testing if the point
is inside the Region's shape, rather than using a temporary 1x1 Region
for the test.
Unit test: RegionTest.containsPoint
- platform/graphics/Region.cpp:
(WebCore::Region::contains):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/RegionTest.cpp: Added.
(WebCore):
(WebCore::TEST):
- 3:32 PM Changeset in webkit [110623] by
-
- 1 edit2 adds in trunk/LayoutTests
Copy the platform-independent result for this test to chromium-mac to
hide the failing result added to apple-mac in
http://trac.webkit.org/changeset/110614.
- platform/chromium/fast/forms/label: Added.
- platform/chromium/fast/forms/label/labelable-elements-expected.txt: Added.
- 3:21 PM Changeset in webkit [110622] by
-
- 1 edit1 add in trunk/LayoutTests
For some reason chromium-win and chromium-linux have a different number
of spaces in the expected results file.
- platform/chromium-win/media/sources-fallback-codecs-expected.txt: Added.
- 3:13 PM Changeset in webkit [110621] by
-
- 2 edits in trunk/LayoutTests
Merge expectations for
svg/as-background-image/svg-as-background-6.html. Previously, Snow
Leopard had different expectations than every other platform, but the
behavior seems to match the expectations for other platforms.
Really what's going on is that this is a bad test for the reasons
explained in the test_expectations.txt file. I'm not entirely sure how
to fix the test to have repeatable results.
This patch also notes some more compositing reflection tests as flaky,
similar to the failures in
https://bugs.webkit.org/show_bug.cgi?id=79823. These tests have been
flaky for a while, but they seem to be failing more frequently now. I
couldn't find any recent changes to explain why that might be.
- platform/chromium/test_expectations.txt:
- 3:06 PM Changeset in webkit [110620] by
-
- 4 edits in trunk
[chromium] Mark root layer scrollbars as always opaque to disable blending
https://bugs.webkit.org/show_bug.cgi?id=79951
Reviewed by James Robinson.
Source/WebCore:
Now that scrollbar layers exist, mark non-overlay root scrollbars as
opaque. This disables blending for correctness and performance.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::scrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTileQuad):
LayoutTests:
Mark canvas-text-alignment.html as failing on Linux in general, not
just in debug. I believe that with this change, the same image will
pass on both release and debug, but will land that change separately.
- platform/chromium/test_expectations.txt:
- 2:59 PM Changeset in webkit [110619] by
-
- 5 edits in trunk
[EFL][DRT] Expose window.internals object
https://bugs.webkit.org/show_bug.cgi?id=79900
Exposes window.internals for EFL's DRT. Makes possible to
remove some tests from the skip list.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-13
Reviewed by Antonio Gomes.
Tools:
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
LayoutTests:
- platform/efl/Skipped:
- 2:59 PM Changeset in webkit [110618] by
-
- 2 edits in trunk/Source/WebCore
Remove vestigal abortEvent from image attribute.
https://bugs.webkit.org/show_bug.cgi?id=80795
Reviewed by Adam Barth.
It seems we installed a listener for the abort event on images,
but never ever raised them. So this patch removes it. This could
cause different behaviour if the user sends abort events directly
at an image element, although addEventListener will still work.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
- 2:52 PM Changeset in webkit [110617] by
-
- 2 edits in trunk/Source/JavaScriptCore
The callback is only used if SA_RESTART is defined. Compile it out
otherwise to avoid a warning.
https://bugs.webkit.org/show_bug.cgi?id=80926
Reviewed by Alexey Proskuryakov.
- heap/MachineStackMarker.cpp:
(JSC):
- 2:51 PM Changeset in webkit [110616] by
-
- 1 edit1 add in trunk/LayoutTests
Add a mac-specific baseline for this new test introduced in
http://trac.webkit.org/changeset/110593. This test is interested in
whether it crashes, not in a 1px difference in text metrics.
- platform/chromium-mac-snowleopard/svg/custom/delete-text-crash-expected.txt: Added.
- 2:48 PM Changeset in webkit [110615] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove bogus expectation.
- platform/chromium-mac/fast/dom/nodesFromRect-basic-expected.txt: Removed.
- 2:43 PM Changeset in webkit [110614] by
-
- 1 edit2 adds in trunk/LayoutTests
r110542: New fast/forms/label/labelable-elements.html fails.
https://bugs.webkit.org/show_bug.cgi?id=80985
Add failing expected results for Mac to get the bots green.
- platform/mac/fast/forms/label/labelable-elements-expected.txt: Added.
- 2:42 PM Changeset in webkit [110613] by
-
- 1 edit3 adds1 delete in trunk/LayoutTests
Add image baselines after http://trac.webkit.org/changeset/110598.
These tests show the platform-specific file chooser UI.
- platform/chromium-linux-x86/fast/forms/file: Removed.
- platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
- platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Added.
- 2:37 PM Changeset in webkit [110612] by
-
- 1 edit2 adds in trunk/LayoutTests
css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT
https://bugs.webkit.org/show_bug.cgi?id=81029
<rdar://problem/11040673>
Add unreviewed expected failing result for mac.
- platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
- 2:36 PM Changeset in webkit [110611] by
-
- 279 edits180 copies32 moves117 adds1 delete in trunk/LayoutTests
Chromium-Lion rebaselines.
- 2:30 PM Changeset in webkit [110610] by
-
- 2 edits in trunk/Source/WebKit/qt
Attempt to fix QtMinimal bot after r110595
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- 2:22 PM Changeset in webkit [110609] by
-
- 2 edits in trunk/Source/WebKit/qt
Another attempt at fixing QtMinimal bot after r110595
Blind fix, unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
- WebCoreSupport/GeolocationClientQt.h:
- 2:18 PM Changeset in webkit [110608] by
-
- 5 edits3 adds in trunk
Source/WebCore: Rework how a CachedRawResource decides if it can be reused
for a given ResourceRequest. Ensure method, body, cookie policy,
and all headers match.
http://bugs.webkit.org/show_bug.cgi?id=79325
Reviewed by Oliver Hunt.
Test: http/tests/cache/xhr-body.html
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::canReuse):
- loader/cache/CachedRawResource.h: Take a ResourceRequest in canReuse().
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Remove Range header
check, since it is now redundant.
LayoutTests: Test for http://bugs.webkit.org/show_bug.cgi?id=79325.
Reviewed by Oliver Hunt.
- http/tests/cache/resources/body.php: Added.
- http/tests/cache/xhr-body-expected.txt: Added.
- http/tests/cache/xhr-body.html: Added.
- 2:15 PM Changeset in webkit [110607] by
-
- 6 edits1 delete in trunk/LayoutTests
Updating some Mac results in media directory.
- platform/chromium-mac/media/sources-fallback-codecs-expected.txt: Removed.
- media/sources-fallback-codecs-expected.txt: Chromium result just matched what actually happened on Mac, so merging it into cross-platform.
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/mac/media/video-playing-and-pause-expected.txt: Updated for render tree changes. I'm getting the same results locally as buildbot does.
- 2:12 PM Changeset in webkit [110606] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed rebaseline of fast/css/getComputedStyle/computed-style(without-renderer).html for mac, adding -webkit-grid-*
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 2:10 PM Changeset in webkit [110605] by
-
- 2 edits in trunk/Source/JavaScriptCore
Dump the generated code for ARM_TRADITIONAL
https://bugs.webkit.org/show_bug.cgi?id=80975
Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-13
Reviewed by Gavin Barraclough.
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::dumpCode):
- 2:06 PM Changeset in webkit [110604] by
-
- 4 edits in trunk/Source/WebKit/qt
Attempt to fix QtMinimal bot after r110595
Blind fix, unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
- WebCoreSupport/GeolocationPermissionClientQt.h:
- 2:03 PM Changeset in webkit [110603] by
-
- 6 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r110587.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 2:02 PM Changeset in webkit [110602] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align GCC warning
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Dan Bates.
This touches unpackOneRowOfBGRA8ToRGBA8.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- 1:59 PM Changeset in webkit [110601] by
-
- 3 edits in trunk/Source/WebCore
Refactor some code that is used to check whether a layer needs backing store
https://bugs.webkit.org/show_bug.cgi?id=80917
Reviewed by Dean Jackson.
Move some code out of isSimpleContainerCompositingLayer() in two new
methods to make the code more self-descriptive.
No behavior change, so no tests.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- 1:47 PM Changeset in webkit [110600] by
-
- 2 edits in trunk/Source/WebKit/chromium
Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
https://bugs.webkit.org/show_bug.cgi?id=80905
Reviewed by Eric Seidel.
This won't cause chrome to use the PageCache, but it will cause our histogram statistics
describing PageCache use to be more accurate.
- src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):
- 1:30 PM Changeset in webkit [110599] by
-
- 8 edits in trunk/LayoutTests
Too many tests (200+ on SL, 80+ on Lion) tests are failing on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80447
Unreviewed test rebaseline after r110072.
- platform/mac/test_expectations.txt:
- platform/mac/Skipped:
Moved an entry from test_expectations.txt to Skipped as it was failing differently
that expected (same image, different text baseline).
- platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
- platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
- platform/mac/fast/clip/008-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/repaint/overflow-delete-line-expected.txt:
Rebaselined those tests.
- 1:15 PM Changeset in webkit [110598] by
-
- 4 edits3 adds in trunk
REGRESSION(r99369): File input button doesn't highlight when pressed
https://bugs.webkit.org/show_bug.cgi?id=79385
Reviewed by Kent Tamura.
Source/WebCore:
Fixes an issue where the file input button doesn't highlight on mouse press.
Currently we always override the active state of the button with whether
a dragged file is being hovered over the file input control (i.e. can the control
receive a dropped file; HTMLInputElement::canReceiveDroppedFiles()).
Instead, we should only override the active state of the button when the state
changes for whether we can receive dropped files (e.g. during a drag) so that
we honor the active state of the button when it is pressed.
Test: fast/forms/file/file-input-pressed-state.html
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl):
(WebCore::RenderFileUploadControl::updateFromElement):
- rendering/RenderFileUploadControl.h:
(RenderFileUploadControl):
LayoutTests:
Add test to ensure that the file input button visually changes when pressed.
- fast/forms/file/file-input-pressed-state-expected.txt: Added.
- fast/forms/file/file-input-pressed-state.html: Added.
- platform/mac/fast/forms/file/file-input-pressed-state-expected.png: Added.
- 1:15 PM Changeset in webkit [110597] by
-
- 2 edits in branches/chromium/1025/Source/WebCore
Merge 110499 - [Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892
Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.
Regressions should be covered by any test that does image decode on the mac.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):
TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9689079
- 1:14 PM Changeset in webkit [110596] by
-
- 34 edits1 add in trunk
[chromium] Use CCOcclusionTracker for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80743
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.
Source/WebCore:
In this CL we enable the use of CCOcclusionTracker for draw-side
culling. This means moving from a per-quad culling model to a
per-layer model.
When calculating RenderPasses, we construct the set of passes,
then iterate over layers in front-to-back order. We make
CCQuadCuller instantiable, and pass it to the layer
appendQuads() methods instead of the bare list, where it can
filter quads before the end up in the list.
Covered by existing tests.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPass):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
(CCCanvasLayerImpl):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::appendGutterQuads):
(WebCore::CCLayerImpl::appendDebugBorderQuad):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(CCPluginLayerImpl):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
- platform/graphics/chromium/cc/CCQuadCuller.h:
(WebCore):
(CCQuadCuller):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCQuadList):
(WebCore::CCQuadList::backToFrontBegin):
(WebCore::CCQuadList::backToFrontEnd):
(CCRenderPass):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
- tests/CCQuadCullerTest.cpp:
(TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::layerScissorRectInTargetSurface):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):
- tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
- tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
- tests/MockCCQuadCuller.h: Added.
(WebCore):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(WebCore::MockCCQuadCuller::append):
(WebCore::MockCCQuadCuller::quadList):
LayoutTests:
- platform/chromium-linux/compositing/direct-image-compositing-expected.png:
- platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium/test_expectations.txt:
- 1:10 PM Changeset in webkit [110595] by
-
- 90 edits4 deletes in trunk
Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
https://bugs.webkit.org/show_bug.cgi?id=78853
Patch by Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
Reviewed by Adam Barth.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- wtf/Platform.h:
Source/WebCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/geolocation/Geolocation.cpp:
(WebCore):
(WebCore::createPositionError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- Modules/geolocation/Geolocation.h:
(WebCore):
(Geolocation):
- Modules/geolocation/GeolocationController.cpp:
- Modules/geolocation/GeolocationController.h:
- Modules/geolocation/GeolocationError.h:
- Modules/geolocation/GeolocationPosition.h:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSGeolocationCustom.cpp:
- loader/EmptyClients.h:
(EmptyChromeClient):
- page/ChromeClient.h:
(ChromeClient):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(Page):
- platform/GeolocationService.cpp: Removed.
- platform/GeolocationService.h: Removed.
- platform/mock/GeolocationClientMock.cpp:
- platform/mock/GeolocationClientMock.h:
- platform/mock/GeolocationServiceMock.cpp: Removed.
- platform/mock/GeolocationServiceMock.h: Removed.
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebKitSupport/DumpRenderTreeSupport.cpp:
(toGeolocationClientMock):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
Source/WebKit/chromium:
- features.gypi:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
(ChromeClientImpl):
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
- WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::scrollRectIntoView):
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
- WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
- WebCoreSupport/GeolocationClientGtk.h:
(WebKit):
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::lastPosition):
- WebView/WebGeolocationPosition.mm:
(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
- WebView/WebGeolocationPositionInternal.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(toGeolocationClientMock):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
- WebCoreSupport/GeolocationClientQt.h:
(WebCore):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::lastPosition):
- WebGeolocationPosition.cpp:
(WebGeolocationPosition::initWithTimestamp):
(core):
- WebGeolocationPosition.h:
(WebGeolocationPosition):
(WebGeolocationPosition::impl):
- WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
Source/WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):
Source/WebKit/wx:
- WebKitSupport/ChromeClientWx.cpp:
- WebKitSupport/ChromeClientWx.h:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
- WebProcess/WebCoreSupport/WebGeolocationClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- mac/WebKit2.order:
Tools:
- Scripts/build-webkit:
- qmake/mkspecs/features/features.prf:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 1:05 PM Changeset in webkit [110594] by
-
- 29 edits in trunk
Convert nodesFromRect tests to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=80886
Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <agomes@rim.com>
Source/WebCore:
Add Internals::nodesFromRect implementation to unify
the codepath for testing Document::nodesFromRect in a
cross port way.
No new tests, since we are improving here the infra-structure
for testing a specific method.
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/gtk:
Removed DRTSupportGtk::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Removed mac specific support for nodesFromRect for testing purposes only,
since it can work in a cross-port way through the Internals interface.
- WebKit.order:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit/qt:
Removed DRTSupportQt::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
This clean up allows to remove port specific bits of each
DRT implementation that supports testing Document::nodesFromRect,
in favor of making use of the 'Internals' interface to test it.
This makes its code conveniently more expansible and cleaner.
Also removed stubs from Win and EFL, Wn and BlackBerry DRTs.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
LayoutTests:
Adjust nodesFromRect tests to use Internals
instead of LayoutTestController interface.
- fast/dom/resources/nodesFromRect.js:
(check):
- 12:48 PM Changeset in webkit [110593] by
-
- 5 edits3 adds in trunk
Fix the use of stale text fragments
https://bugs.webkit.org/show_bug.cgi?id=80729
Patch by Philip Rogers <pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.
Test: svg/custom/delete-text-crash.html
- rendering/InlineBox.h:
(InlineBox):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):
- rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):
LayoutTests:
- svg/custom/delete-text-crash-expected.png: Added.
- svg/custom/delete-text-crash-expected.txt: Added.
- svg/custom/delete-text-crash.html: Added.
- 12:33 PM Changeset in webkit [110592] by
-
- 4 edits6 copies30 adds in trunk/LayoutTests
Fix some broken layout test rebaselines from the various chromium-lion
rebaselining patches. The bugs in the rebaseline tool that caused the breakages
are now fixed.
- platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
- platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
- platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Added.
- platform/chromium-mac-leopard/fast/block/basic/014-expected.png: Added.
- platform/chromium-mac-leopard/fast/block/basic/020-expected.png: Added.
- platform/chromium-mac-leopard/fast/block/float/dynamic-unfloat-pref-width-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/block/margin-collapse/044-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/block/margin-collapse/045-expected.png: Added.
- platform/chromium-mac-leopard/fast/block/positioning/054-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/pseudo-element-line-break-expected.png: Added.
- platform/chromium-mac-leopard/fast/events/onload-re-entry-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/disabled-select-change-index-expected.txt:
- platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.png: Added.
- platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Added.
- platform/chromium-mac-leopard/fast/inline/002-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/inline/vertical-align-text-bottom-expected.png: Added.
- platform/chromium-mac-leopard/fast/invalid/002-expected.png: Added.
- platform/chromium-mac-leopard/fast/invalid/005-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/invalid/007-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/invalid/020-expected.png: Added.
- platform/chromium-mac-leopard/fast/invalid/missing-end-tag-expected.png: Added.
- platform/chromium-mac-leopard/fast/lists/006-expected.png: Added.
- platform/chromium-mac-leopard/fast/loader/text-document-wrapping-expected.png: Added.
- platform/chromium-mac-leopard/fast/parser/tabs-in-scripts-expected.png: Added.
- platform/chromium-mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Added.
- platform/chromium-mac-leopard/fast/replaced/three-selects-break-expected.png: Added.
- platform/chromium-mac-leopard/fast/selectors/002-expected.png: Added.
- platform/chromium-mac-leopard/fast/table/001-expected.png: Added.
- platform/chromium-mac-leopard/fast/table/010-expected.png: Added.
- platform/chromium-mac-leopard/fast/table/013-expected.png: Added.
- platform/chromium-mac-leopard/fast/table/015-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
- platform/chromium-mac-leopard/fast/table/022-expected.png: Added.
- platform/chromium-mac-leopard/scrollbars/basic-scrollbar-expected.png: Added.
- platform/chromium-mac-leopard/scrollbars/disabled-scrollbar-expected.png: Added.
- platform/chromium-mac-leopard/scrollbars/scrollbar-buttons-expected.png: Added.
- platform/chromium-mac-leopard/scrollbars/scrollbar-orientation-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
- platform/chromium/test_expectations.txt:
- 12:27 PM Changeset in webkit [110591] by
-
- 4 edits in trunk/Source/WebCore
SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437
Reviewed by Dirk Schulze.
Blind fix for some GC related assertions firing on v8.
Assure that animationStarted/animationEnded calls are happening
on the same SVGAnimatedProperty. Always call animationEnded(),
even if we shouldn't do anything for the target element, as its
destructed, as we still have to reset m_isAnimating.
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):
- svg/SVGAnimateElement.h:
(SVGAnimateElement):
- svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
- 12:19 PM Changeset in webkit [110590] by
-
- 208 edits137 copies56 moves97 adds8 deletes in trunk/LayoutTests
Chromium-Lion rebaselines.
- 12:12 PM Changeset in webkit [110589] by
-
- 12 edits13 moves in trunk/Source/WebCore
Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-13
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/filesystem: Added.
- Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
- Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
- Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
- Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
- Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
- Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
- Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
- Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
- Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
- Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
- Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
- Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
- Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/DirectoryEntry.cpp: Removed.
- fileapi/DirectoryEntry.h: Removed.
- fileapi/DirectoryEntry.idl: Removed.
- fileapi/DirectoryEntrySync.cpp: Removed.
- fileapi/DirectoryEntrySync.h: Removed.
- fileapi/DirectoryEntrySync.idl: Removed.
- fileapi/DirectoryReader.cpp: Removed.
- fileapi/DirectoryReader.h: Removed.
- fileapi/DirectoryReader.idl: Removed.
- fileapi/DirectoryReaderBase.h: Removed.
- fileapi/DirectoryReaderSync.cpp: Removed.
- fileapi/DirectoryReaderSync.h: Removed.
- fileapi/DirectoryReaderSync.idl: Removed.
- 12:06 PM Changeset in webkit [110588] by
-
- 9 edits4 adds in trunk
animation-iteration-count does not handle floating point values correctly.
https://bugs.webkit.org/show_bug.cgi?id=69531
Source/WebCore:
Implements support for non-integers animation-iteration-count numbers.
Non-integer numbers will cause the animation to end part-way through a cycle.
Reviewed by Dean Jackson.
Tests: animations/fill-mode-iteration-count-non-integer.html
animations/keyframes-iteration-count-non-integer.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationIterationCount):
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::progress):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseAnimationAtTime):
- platform/animation/Animation.h:
(WebCore::Animation::iterationCount):
(WebCore::Animation::setIterationCount):
(Animation):
(WebCore::Animation::initialAnimationIterationCount):
LayoutTests:
Reviewed by Dean Jackson.
- animations/fill-mode-iteration-count-non-integer-expected.txt: Added.
- animations/fill-mode-iteration-count-non-integer.html: Added.
- animations/keyframes-iteration-count-non-integer-expected.txt: Added.
- animations/keyframes-iteration-count-non-integer.html: Added.
- 11:51 AM Changeset in webkit [110587] by
-
- 25 edits10 moves in trunk
MediaStream API: Rename PeerConnection to DeprecatedPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=80692
Reviewed by Adam Barth.
First patch in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Source/WebCore:
Patch covered by modified existing tests.
- GNUmakefile.list.am:
- Modules/mediastream/DOMWindowMediaStream.idl:
- Modules/mediastream/DeprecatedPeerConnection.cpp: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.cpp.
(WebCore):
(WebCore::DeprecatedPeerConnection::create):
(WebCore::DeprecatedPeerConnection::DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::~DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::processSignalingMessage):
(WebCore::DeprecatedPeerConnection::readyState):
(WebCore::DeprecatedPeerConnection::send):
(WebCore::DeprecatedPeerConnection::addStream):
(WebCore::DeprecatedPeerConnection::removeStream):
(WebCore::DeprecatedPeerConnection::localStreams):
(WebCore::DeprecatedPeerConnection::remoteStreams):
(WebCore::DeprecatedPeerConnection::close):
(WebCore::DeprecatedPeerConnection::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnection::didGenerateSDP):
(WebCore::DeprecatedPeerConnection::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnection::didAddRemoteStream):
(WebCore::DeprecatedPeerConnection::didRemoveRemoteStream):
(WebCore::DeprecatedPeerConnection::interfaceName):
(WebCore::DeprecatedPeerConnection::scriptExecutionContext):
(WebCore::DeprecatedPeerConnection::stop):
(WebCore::DeprecatedPeerConnection::eventTargetData):
(WebCore::DeprecatedPeerConnection::ensureEventTargetData):
(WebCore::DeprecatedPeerConnection::scheduleInitialNegotiation):
(WebCore::DeprecatedPeerConnection::initialNegotiationTimerFired):
(WebCore::DeprecatedPeerConnection::ensureStreamChangeScheduled):
(WebCore::DeprecatedPeerConnection::streamChangeTimerFired):
(WebCore::DeprecatedPeerConnection::scheduleReadyStateChange):
(WebCore::DeprecatedPeerConnection::readyStateChangeTimerFired):
(WebCore::DeprecatedPeerConnection::changeReadyState):
- Modules/mediastream/DeprecatedPeerConnection.h: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.h.
(WebCore):
(DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::didChangeState):
(WebCore::DeprecatedPeerConnection::refEventTarget):
(WebCore::DeprecatedPeerConnection::derefEventTarget):
- Modules/mediastream/DeprecatedPeerConnection.idl: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.idl.
- Modules/mediastream/SignalingCallback.h:
(WebCore):
(SignalingCallback):
- Modules/mediastream/SignalingCallback.idl:
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):
- bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Renamed from Source/WebCore/bindings/js/JSPeerConnectionCustom.cpp.
(WebCore):
(WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection):
- dom/EventTarget.h:
(WebCore):
- dom/EventTargetFactory.in:
- platform/mediastream/DeprecatedPeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandler.h.
(WebCore):
(DeprecatedPeerConnectionHandler):
- platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandlerClient.h.
(WebCore):
(DeprecatedPeerConnectionHandlerClient):
(WebCore::DeprecatedPeerConnectionHandlerClient::~DeprecatedPeerConnectionHandlerClient):
- platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/gstreamer/PeerConnectionHandler.cpp.
(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):
Source/WebKit/chromium:
- WebKit.gyp:
- bridge/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandler.cpp.
(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):
- bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.cpp.
(WebCore):
(WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::~DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::stop):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didRemoveRemoteStream):
- bridge/DeprecatedPeerConnectionHandlerInternal.h: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.h.
(WebKit):
(WebCore):
(DeprecatedPeerConnectionHandlerInternal):
LayoutTests:
- fast/dom/call-a-constructor-as-a-function.html:
- fast/mediastream/peerconnection-Attributes-expected.txt:
- fast/mediastream/peerconnection-addstream-expected.txt:
- fast/mediastream/peerconnection-argument-types-expected.txt:
- fast/mediastream/peerconnection-eventlistener-optional-argument.html:
- fast/mediastream/peerconnection-mediastreamlist.html:
- fast/mediastream/peerconnection-removestream-expected.txt:
- fast/mediastream/script-tests/Attributes.js:
- fast/mediastream/script-tests/argument-types.js:
- fast/mediastream/script-tests/peerconnection-addstream.js:
- fast/mediastream/script-tests/peerconnection-removestream.js:
- platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
- platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
- 11:49 AM Changeset in webkit [110586] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=81014
Reviewed by Sam Weinig.
Remove a plug-in halter related WebUIDelegate method.
- WebView/WebUIDelegatePrivate.h:
- 11:34 AM Changeset in webkit [110585] by
-
- 6 edits in trunk/Tools
Rebaselining for a new port doesn't work right with multiple fallback ports
https://bugs.webkit.org/show_bug.cgi?id=80932
Reviewed by Adam Barth.
Since chromium-leopard also falls back to mac-leopard, we need to
copy the existing result for both chromium-leopard and chromium-snowleopard
before doing lion rebaselines.
- Scripts/webkitpy/layout_tests/port/builders.py:
(fallback_port_names_for_new_port):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):
- 11:21 AM Changeset in webkit [110584] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: front-end compilation was broken while supporting large arrays.
https://bugs.webkit.org/show_bug.cgi?id=81013
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ExtensionPanel.js:
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):
- inspector/front-end/RemoteObject.js:
- 11:17 AM Changeset in webkit [110583] by
-
- 7 edits2 adds in trunk
flexbox's computePreferredLogicalWidth needs to take multiline into account
https://bugs.webkit.org/show_bug.cgi?id=80931
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: css3/flexbox/multiline-shrink-to-fit-expected.html
css3/flexbox/multiline-shrink-to-fit.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Set min/max preferredLogicalWidth based on always breaking or never breaking.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Add a FIXME.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Don't change the width after computePreferredWidth has been called.
LayoutTests:
- css3/flexbox/cross-axis-scrollbar.html:
- css3/flexbox/multiline-align.html:
- css3/flexbox/multiline-pack.html:
- css3/flexbox/multiline-shrink-to-fit-expected.html: Added.
- css3/flexbox/multiline-shrink-to-fit.html: Added.
- css3/flexbox/multiline.html:
- 11:10 AM Changeset in webkit [110582] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove SlotVisitor::copy() method.
https://bugs.webkit.org/show_bug.cgi?id=80973
Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-13
Reviewed by Geoffrey Garen.
SlotVisitor::copy() method isn't called anywhere.
- heap/MarkStack.cpp: Remove definition of SlotVisitor::copy() method.
- heap/SlotVisitor.h: Remove declaration of SlotVisitor::copy() method.
- 11:05 AM Changeset in webkit [110581] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r110469.
http://trac.webkit.org/changeset/110469
https://bugs.webkit.org/show_bug.cgi?id=81010
This patch still appears to crash (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-13
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
- page/FrameView.h:
(FrameView):
- rendering/RenderView.cpp:
(WebCore::RenderView::shouldRepaint):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):
- svg/graphics/SVGImageCache.h:
(SVGImageCache):
- 11:02 AM Changeset in webkit [110580] by
-
- 11 edits2 adds in trunk
Add a method to window.internals to enable testing of inspector highlight rects
https://bugs.webkit.org/show_bug.cgi?id=80338
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-13
Reviewed by Pavel Feldman.
.:
- Source/autotools/symbols.filter: Export symbols for GTK.
Source/WebCore:
Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.
Test: inspector/elements/highlight-node.html
- WebCore.exp.in: Export symbols.
- testing/Internals.cpp:
(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):
- testing/Internals.h:
(WebCore):
(Internals):
- testing/Internals.idl:
Add inspectorHighlightRects to the window.internals interface.
Source/WebKit2:
- win/WebKit2.def: Export symbols for win.
- win/WebKit2CFLite.def: Same as above.
LayoutTests:
- inspector/elements/highlight-node-expected.txt: Added.
- inspector/elements/highlight-node.html: Added.
- 10:57 AM Changeset in webkit [110579] by
-
- 2 edits in trunk/Websites/webkit.org
Working With Code > Installing Developer Tools needs to be updated with OS X Lion & App Store details
https://bugs.webkit.org/show_bug.cgi?id=80429
Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-13
Reviewed by Dan Bernstein.
- building/tools.html:
- 10:30 AM Changeset in webkit [110578] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove sublayers before clamping just in case the layer already exists
https://bugs.webkit.org/show_bug.cgi?id=80989
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.
Discovered when trying to add a highlight sublayer for web inspector. Since that layer
may already exist in the tree we need to see if it will be pruned before we clamp on the
size.
This was manually tested during the writing of another patch to add web inspector highlights
to accelrated compositing.
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::insertSublayer):
- 10:25 AM Changeset in webkit [110577] by
-
- 2 edits in trunk/LayoutTests
Note that fast/loader/window-properties-restored-from-page-cache.html
depends on the page cache.
- platform/chromium/test_expectations.txt:
- 9:37 AM Changeset in webkit [110576] by
-
- 9 edits3 adds in trunk
Web Inspector: Add snippets model.
https://bugs.webkit.org/show_bug.cgi?id=80863
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/debugger/snippets-model.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SnippetsModel.js: Added.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/debugger/snippets-model-expected.txt: Added.
- inspector/debugger/snippets-model.html: Added.
- 9:33 AM Changeset in webkit [110575] by
-
- 3 edits in trunk/Tools
[Qt] Tweak minibrowser UI
Add some margins to the scroll indicators, and set a dark background
color so you see the page dimensions.
Reviewed by Antonio Gomes.
- 9:11 AM Changeset in webkit [110574] by
-
- 111 edits in trunk/LayoutTests
[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703
Reviewed by Rob Buis.
Overhaul the svg/animation frameworks, to be more stable.
Especially discrete animations were flaky on Qt, because some tests still sampled
at integral times like 2.0s, instead of 1.999s (before change), and 2.001s (after change).
Always use shouldBeCloseEnough() when comparing font-sizes/color values/, as there's
always an uncertainity about the actual sampling time (low but may lead to 40.01px values, instead of 40px).
This makes these tests also stable in Firefox/Opera, which was the ultimate goal!
- platform/qt/Skipped: Unskip svg/animation tests.
- svg/animations/additive-values-width-animation-expected.txt:
- svg/animations/animate-color-calcMode-discrete-expected.txt:
- svg/animations/animate-color-fill-currentColor-expected.txt:
- svg/animations/animate-color-fill-from-by-expected.txt:
- svg/animations/animate-color-rgba-calcMode-discrete-expected.txt:
- svg/animations/animate-color-transparent-expected.txt:
- svg/animations/animate-currentColor-expected.txt:
- svg/animations/animate-dynamic-update-attributeName-expected.txt:
- svg/animations/animate-elem-03-t-drt-expected.txt:
- svg/animations/animate-end-attribute-expected.txt:
- svg/animations/animate-from-to-keyTimes-expected.txt:
- svg/animations/animate-inherit-css-property-expected.txt:
- svg/animations/animate-keySplines-expected.txt:
- svg/animations/animate-number-calcMode-discrete-expected.txt:
- svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
- svg/animations/attributeTypes-expected.txt:
- svg/animations/resources/SVGAnimationTestCase.js:
(expectColor):
(expectFillColor):
(moveAnimationTimelineAndSample):
- svg/animations/script-tests/additive-values-width-animation.js:
(executeTest):
- svg/animations/script-tests/animVal-basics.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-by.js:
(sample1):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-from-by.js:
(sample1):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-from-to.js:
(sample1):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-to.js:
(sample1):
(executeTest):
- svg/animations/script-tests/animate-calcMode-spline-values.js:
(sample1):
(executeTest):
- svg/animations/script-tests/animate-color-calcMode-discrete.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-color-fill-currentColor.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-color-fill-from-by.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:
(parseAlphaFromColor):
(red):
- svg/animations/script-tests/animate-color-transparent.js:
(expectTransparent):
(expectOtherColor):
- svg/animations/script-tests/animate-currentColor.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-dynamic-update-attributeName.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-03-t-drt.js:
(parseFontSizeFromString):
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-end-attribute.js:
(sample1):
(sample2):
- svg/animations/script-tests/animate-endElement-beginElement.js:
(sample1):
- svg/animations/script-tests/animate-from-to-keyTimes.js:
- svg/animations/script-tests/animate-gradient-transform.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-inherit-css-property.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-insert-begin.js:
(sample1):
(sample2):
- svg/animations/script-tests/animate-insert-no-begin.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/animate-keySplines.js:
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:
(executeTest):
- svg/animations/script-tests/animate-number-calcMode-discrete.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/animate-path-animation-Cc-Ss.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-path-animation-Qq-Tt.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-path-to-animation.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/animateTransform-pattern-transform.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/attributeTypes.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/multiple-animations-fill-freeze.js:
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
- svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:
(executeTest):
- svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgboolean-animation-1.js:
(executeTest):
- svg/animations/script-tests/svginteger-animation-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-2.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-invalid-value-3.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-number-to-number.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-cm.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-ems.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-exs.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-in.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-number.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pc.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-pt.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglength-animation-px-to-px.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglength-animation-unitType.js:
(executeTest):
- svg/animations/script-tests/svglength-animation-values.js:
(sample1):
(sample2):
(sample4):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-2.js:
(sample1):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-3.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-4.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svglengthlist-animation-5.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgnumber-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumber-animation-2.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumber-animation-3.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgnumberlist-animation-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgnumberlist-animation-2.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgpath-animation-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgpointlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgpointlist-animation-2.js:
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgrect-animation-1.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgrect-animation-2.js:
(sample1):
(sample2):
(executeTest):
- svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:
(executeTest):
- svg/animations/script-tests/svgtransform-animation-1.js:
(sample1):
(sample2):
- svg/animations/script-tests/svgtransform-animation-discrete.js:
(sample1):
(executeTest):
- svg/animations/svglength-animation-invalid-value-1-expected.txt:
- svg/animations/svglength-animation-invalid-value-2-expected.txt:
- svg/animations/svglength-animation-invalid-value-3-expected.txt:
- svg/animations/svglength-animation-unitType-expected.txt:
- svg/animations/svgnumber-animation-1-expected.txt:
- svg/animations/svgnumber-animation-2-expected.txt:
- svg/animations/svgnumber-animation-3-expected.txt:
- svg/animations/svgtransform-animation-discrete-expected.txt:
- 9:08 AM Changeset in webkit [110573] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: chromium build fix.
- history/CachedFrame.cpp:
- 9:03 AM Changeset in webkit [110572] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: refactor copy-paste getter methods
https://bugs.webkit.org/show_bug.cgi?id=80923
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-13
Reviewed by Yury Semikhatsky.
Several methods are combined in one using C++ templates.
- inspector/CodeGeneratorInspector.py:
- 9:00 AM Changeset in webkit [110571] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix cast-align warning in QuotesData.cpp
https://bugs.webkit.org/show_bug.cgi?id=80601
Reviewed by Nikolas Zimmermann.
Fix warning by adding variable of correct return type.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create):
- 8:57 AM Changeset in webkit [110570] by
-
- 12 edits2 adds in trunk
<rdar://problem/7908830> and https://bugs.webkit.org/show_bug.cgi?id=34679 Location and other objects are dysfunctional after a document gets restored from page cache
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/loader/window-properties-restored-from-page-cache.html
Give DOMWindowProperties the ability to reconnect to their Frame:
- page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::reconnectFrame):
- page/DOMWindowProperty.h:
(DOMWindowProperty):
Let ApplicationCache do some extra work when reconnecting:
- loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::reconnectFrame):
(WebCore):
- loader/appcache/DOMApplicationCache.h:
(DOMApplicationCache):
Let IndexDB do some extra work when reconnecting:
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::reconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
Tell the DOMWindow to suspend to the page cache:
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
Tell the DOMWindow to resume from the page cache:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow): Call clearDOMWindowProperties directly instead of clear()
(WebCore::DOMWindow::frameDestroyed): Ditto.
(WebCore::DOMWindow::clear): Only clear if the DOMWindow is not suspended for the page cache.
(WebCore::DOMWindow::suspendForPageCache): Disconnect properties and set the page cache flag.
(WebCore::DOMWindow::resumeFromPageCache): Reconnect properties and revert the page cache flag.
(WebCore::DOMWindow::disconnectDOMWindowProperties): Only disconnect the registered properties.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties): Disconnect the registered properties then clear them out.
For all of the following, if the DOMWindow is not displayed in a frame (i.e., it is suspended), do nothing:
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::getSelection):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::webkitStorageInfo):
- page/DOMWindow.h:
LayoutTests:
- fast/loader/window-properties-restored-from-page-cache-expected.txt: Added.
- fast/loader/window-properties-restored-from-page-cache.html: Added.
- 8:43 AM Changeset in webkit [110569] by
-
- 4 edits in trunk/Source
[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test: CCOcclusionTrackerTest3dTransform
CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
- 8:40 AM Changeset in webkit [110568] by
-
- 7 edits in trunk
[EFL] [DRT] Implement scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=79601
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-03-13
Reviewed by Gustavo Noronha Silva.
Source/WebKit/efl:
Added a new API to deliver all mutations explicitly.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
and is taken over to sendKeyDown.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
- DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(createKeyEventInfo):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):
LayoutTests:
Removed following two skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html
- platform/efl/Skipped:
- 8:28 AM Changeset in webkit [110567] by
-
- 2 edits in trunk/Source/WebCore
New PageCache histogram which counts failures ignoring Settings.
https://bugs.webkit.org/show_bug.cgi?id=80864
Reviewed by Brady Eidson.
Chrome has a command line switch to turn on the page cache.
Currently it doesn't work, but it can cause the PageCache reasons
for failure count to read lower than it should. Add a new
histogram to report the corrected value.
- history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
- 8:24 AM Changeset in webkit [110566] by
-
- 3 edits in trunk/Source/WebCore
Fix signed/unsigned mismatch compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Alexey Proskuryakov.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
- platform/network/MIMESniffing.cpp:
- 8:21 AM Changeset in webkit [110565] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r110510.
http://trac.webkit.org/changeset/110510
https://bugs.webkit.org/show_bug.cgi?id=80987
depends on chromium r 125700, which isn't rolled into webkit
yet :-/ (Requested by thakis_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-13
- WebCore.gyp/mac/adjust_visibility.sh:
- 8:18 AM Changeset in webkit [110564] by
-
- 5 edits in trunk/Source
Make ApplicationCacheHost::canCacheInPageCache() non-const.
https://bugs.webkit.org/show_bug.cgi?id=80904
Reviewed by Alexey Proskuryakov.
A const pointer to a large object like ApplicationCacheHost is not our standard
practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898
Source/WebCore:
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):
- loader/appcache/ApplicationCacheHost.h:
(ApplicationCacheHost):
Source/WebKit/chromium:
- src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):
- 8:14 AM Changeset in webkit [110563] by
-
- 7 edits2 adds in trunk
Crash in WebCore::GraphicsContext::paintingDisabled
https://bugs.webkit.org/show_bug.cgi?id=80669
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.
So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.
Tests: svg/custom/circular-clip-path-references-crash-expected.svg
svg/custom/circular-clip-path-references-crash.svg
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::clipToTextMask):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clipToImageBuffer):
- rendering/svg/SVGImageBufferTools.h:
(SVGImageBufferTools):
LayoutTests:
- svg/custom/circular-clip-path-references-crash-expected.svg: Added.
- svg/custom/circular-clip-path-references-crash.svg: Added.
- 8:02 AM Changeset in webkit [110562] by
-
- 4 edits1 delete in trunk/Source/WebKit/blackberry
Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
https://bugs.webkit.org/show_bug.cgi?id=80984
Remove ActiveNodeContext, and switch the implementation to
provide a BlackBerry::Platform::WebContext. The new object
adds an explicit IsImage flag, as well as IsAudio and IsVideo
for the HTML5 elements.
Note that for many videos both IsVideo and IsAudio will be true,
as videos typically have audio streams as well.
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-13
Reviewed by George Staikos.
- Api/ActiveNodeContext.h: Removed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):
- Api/WebPage.h:
- Api/WebPage_p.h:
- 7:57 AM Changeset in webkit [110561] by
-
- 2 edits in trunk/Source/WebCore
Fix an enumeration name in ReasonsFrameCannotBeInPageCache.
https://bugs.webkit.org/show_bug.cgi?id=80849
Reviewed by Brady Eidson.
It seems that somebody goofed, and named one of the
ReasonsFrameCannotBeInPageCache antonymically.
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
- 7:38 AM Changeset in webkit [110560] by
-
- 10 edits in trunk/Source/WebCore
File upload control should use File.name() rather than File.path() to show chosen filenames
https://bugs.webkit.org/show_bug.cgi?id=80970
In some rare cases (e.g. files from FileSystem API or files created
using the newly added WebKit API) File.name has different displayName
from the basename of file.path, and in the file uploader controller we
should use File.name rather than File.path.
Reviewed by Kent Tamura.
No new tests: existing tests should pass as this should not change
behavior in regular use cases. (New behavior where File.name differs
from File.path can be only tested in chromeos environment, therefore
not adding new tests for that)
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::fileListNameForWidth): Updated to handle FileList.
- platform/gtk/RenderThemeGtk.h:
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth): Updated to handle FileList.
- platform/qt/RenderThemeQt.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::fileTextValue): Changed to pass FileList rather than FileList->paths().
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::fileListNameForWidth): Updated to handle FileList and use File.name for displaying the file name.
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::fileListNameForWidth): Updated to handle FileList.
- 7:09 AM Changeset in webkit [110559] by
-
- 2 edits in trunk/PerformanceTests
Dromaeo perf-tests results are wrong
https://bugs.webkit.org/show_bug.cgi?id=80974
Reviewed by Hajime Morita.
Dromaeo perf-tests had reported the sum of runs/seconds as "ms".
This patch fixes them to report the execution time per run.
At present, they report "0.0ms" for "stdev". This is because
dromaeorunner.js can just know stdev of "runs/seconds"
and cannot calculate stdev of "ms" from that. We can fix it later.
- Dromaeo/resources/dromaeorunner.js:
(.):
- 7:09 AM Changeset in webkit [110558] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip some tests until fix.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-13
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 7:06 AM Changeset in webkit [110557] by
-
- 13 edits in trunk/Source
Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths
https://bugs.webkit.org/show_bug.cgi?id=80719
Reviewed by Kent Tamura.
Source/WebCore:
No new tests: this change itself shouldn't change existing behavior.
- fileapi/File.cpp:
(WebCore::createBlobDataForFileWithName): Renamed from createBlobDataForFileSystemFile.
- fileapi/File.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState): Updated to handle File.name.
(WebCore::FileInputType::restoreFormControlState): Ditto.
(WebCore::FileInputType::setFileList): Changed the signature to take
FileChooserFileInfo.
(WebCore::FileInputType::filesChosen): Ditto.
(WebCore::FileInputType::receiveDroppedFiles):
- html/FileInputType.h:
(FileInputType):
- platform/FileChooser.cpp:
(WebCore::FileChooser::chooseFiles): Added an overloaded method that
takes FileChooserFileInfo.
(WebCore):
- platform/FileChooser.h:
(WebCore::FileChooserFileInfo::FileChooserFileInfo): Added.
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Removed surrouonding ifdefs as this function is now used even if FILE_SYSTEM is not enabled.
- platform/MIMETypeRegistry.h:
(MIMETypeRegistry):
Source/WebKit/chromium:
- public/WebFileChooserCompletion.h:
(SelectedFileInfo): Added.
(WebFileChooserCompletion):
(WebKit::WebFileChooserCompletion::didChooseFile): Added an overloaded
method that takes SelectedFileInfo.
- src/WebFileChooserCompletionImpl.cpp:
(WebKit::WebFileChooserCompletionImpl::didChooseFile): Ditto.
(WebKit):
- src/WebFileChooserCompletionImpl.h:
(WebFileChooserCompletionImpl):
- 5:38 AM Changeset in webkit [110556] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Remove a duplicate allocation of matrix entry.
https://bugs.webkit.org/show_bug.cgi?id=79362
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-03-13
Reviewed by Zoltan Herczeg.
A matrix entry is created when calling ewk_matrix_new.
Another matrix is created inside ewk_tile_matrix_zoom_level_set.
This patch is for getting rid of a duplicated creation of the matrix.
- ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_ewk_tiled_backing_store_zoom_set_internal):
- ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_size_get):
- ewk/ewk_tiled_matrix.h:
- 5:28 AM Changeset in webkit [110555] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping some more failing tests.
- platform/chromium/test_expectations.txt:
- 5:25 AM Changeset in webkit [110554] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed inspector compilation module name fix after r110550.
- inspector/compile-front-end.py:
- 5:24 AM Changeset in webkit [110553] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Set correct device width and height.
https://bugs.webkit.org/show_bug.cgi?id=80980
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-13
Reviewed by Tor Arne Vestbø.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::computeViewportConstraints):
- 3:00 AM Changeset in webkit [110552] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip new failing test on GTK.
- platform/gtk/Skipped:
- 2:57 AM Changeset in webkit [110551] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking a test as fail which needs reaseline.
- platform/chromium/test_expectations.txt:
- 2:47 AM Changeset in webkit [110550] by
-
- 2 edits1 add in trunk/Source/WebCore
Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
https://bugs.webkit.org/show_bug.cgi?id=80872
Reviewed by Pavel Feldman.
- inspector/compile-front-end.py: Added.
- inspector/compile-front-end.sh:
- 2:10 AM Changeset in webkit [110549] by
-
- 7 edits1 copy in trunk/Source/WebCore
Web Inspector: move ResourceScriptMapping to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=80859
Reviewed by Vsevolod Vlasov.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/ResourceScriptMapping.js: Copied from Source/WebCore/inspector/front-end/ScriptMapping.js.
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype.setFormatSource):
(WebInspector.ResourceScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.ResourceScriptMapping.prototype.reset):
- inspector/front-end/ScriptMapping.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 1:56 AM Changeset in webkit [110548] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skipping some failing tests.
- platform/chromium/test_expectations.txt:
- 1:48 AM Changeset in webkit [110547] by
-
- 29 edits3 moves in trunk/Source/WebCore
Rename OptionsObject to Dictionary
https://bugs.webkit.org/show_bug.cgi?id=80802
Reviewed by Adam Barth.
For clarification, rename OptionsObject.{h,cpp} to Dictionary.{h,cpp}.
This patch just renames and sorts alphabetically.
No tests. No change in behavior.
- GNUmakefile.list.am:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
- Modules/indexeddb/IDBDatabase.h:
(WebCore::IDBDatabase::createObjectStore):
(IDBDatabase):
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBKeyRange.h:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::createIndex):
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStore.idl:
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/Dictionary.h: Renamed from Source/WebCore/bindings/js/OptionsObject.h.
(WebCore):
(Dictionary):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createDictionaryFromValue):
- bindings/js/IDBBindingUtilities.h:
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(GetNativeType):
(JSValueToNative):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::optionsObject):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_options_object):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj optionsObject:ooo:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::optionsObjectCallback):
- bindings/v8/Dictionary.cpp: Renamed from Source/WebCore/bindings/v8/OptionsObject.cpp.
(WebCore):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::~Dictionary):
(WebCore::Dictionary::operator=):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::getKey):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
- bindings/v8/Dictionary.h: Renamed from Source/WebCore/bindings/v8/OptionsObject.h.
(WebCore):
(Dictionary):
- bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
- 1:38 AM Changeset in webkit [110546] by
-
- 5 edits in trunk
REGRESSION: Spellcheck tests hit assertions on Mac.
https://bugs.webkit.org/show_bug.cgi?id=80883
Reviewed by Ryosuke Niwa.
Source/WebKit/mac:
The bug was caused by the closure object created in requestCheckingOfString accessing
request's member variables even though the request object is not an NSObject or allocated
in stack. This resulted in the closure not being able to access those variables when invoked.
Fixed the bug by making local copies of those member variables.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::requestCheckingOfString):
LayoutTests:
Some words used in spellcheck-paste.js are considered as correct spellings in Mac's spellchecker.
This patch changes them into 'zz' so that Mac's spellchecker can make them as misspelling.
- editing/spelling/script-tests/spellcheck-paste.js:
(pasteAndVerify.trial):
(pasteAndVerify):
(tests):
- editing/spelling/spellcheck-paste-expected.txt:
- 1:27 AM Changeset in webkit [110545] by
-
- 110 edits37 adds in trunk
SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437
Reviewed by Dirk Schulze.
Source/WebCore:
Begin implementing the last missing core piece of the SVG DOM: proper animVal support.
Most SVG DOM interfaces exposing eg. lengths use SVGAnimatedLength. eg. from SVGRectElement:
"readonly attribute SVGAnimatedLength x;" SVGAnimatedXXX contains following methods:
"readonly attribute SVGLength baseVal; readonly attribute SVGLength animVal;"
From SVG DOM perspective, animVal and baseVal are two distinctive objects, animVal != baseVal.
Its underlying value is the same though, if no animation is running on that attribute.
As soon as a SMIL animation starts animating an SVGAnimated* target attribute, its
baseVal and animVal may begin to differ. The animVal always reflect the current animated
value (including all effects of additive/accumulated animations) which is shown on screen
when eg animating the width of a <rect>. The baseVal is is equal to the underlying XML
property value / SVG DOM value, but may be influenced through dynamic changes.
(Consider changing rect1.width.baseVal.value while 'width' is animated)
During the last year we prepared our animation code to turn on animVal support.
This patch adds the last missing pieces to turn on animVal support for the SVGLength.
SVGLengthList and all other types will follow, one after the other.
I've decided to write an exhaustive ChangeLog, as this as the base for any future
work in this area - hopefully making this more reviewable.
Tests: svg/animations/additive-from-to-width-animation.html
svg/animations/additive-values-width-animation.html
svg/animations/change-baseVal-while-animating-fill-freeze-2.html
svg/animations/change-baseVal-while-animating-fill-freeze.html
svg/animations/change-baseVal-while-animating-fill-remove-2.html
svg/animations/change-baseVal-while-animating-fill-remove.html
svg/animations/change-target-while-animating-SVG-property.html
svg/animations/multiple-animations-fill-freeze.html
svg/animations/remove-animation-element-while-animation-is-running.html
svg/repaint/repainting-after-animation-element-removal.svg
- svg/SVGAnimateElement.cpp: Remove unnecessary std namespace inclusion.
(WebCore::SVGAnimateElement::SVGAnimateElement): Remove now-obsolete m_aboutToStopAnimation.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Swap assertion order, to test hasTagName() _before_ casting.
(WebCore::SVGAnimateElement::resetToBaseValue):
Stop relying on the cached baseValue (breaking additive="sum"+values animation) for SVG DOM primitive animations.
Avoid any string roundtrips previously needed to reset the SVGAnimatedType to the base value. Just grab the
currentBaseValue() from the associated SVGAnimatedProperty, which includes all dynamic changes to the baseVal
either by SVG DOM or setAttribute() calls - this way we don't need to utilize the buggy cache in SMILTimeContainer,
which can be removed once all SVG DOM primitive types switched to the new animVal concept.
NOTE: When multiple animations of the same attribute are applied to a target element, resetToBaseValue() will be called
for the highest priority SVGSMILElement, on every animation step! Consider two <animate> elements, applied to a target
<rect> which both animate the 'x' attribute, one from 0s to 2s, the other from 4s to 6s. The last <animate> element
will reuse the SVGAnimatedType m_animatedType from the first <animate> element, and never create an own m_animatedType.
When the animation starts the first time at 0s, we update the rect.x.animVals SVGLength* pointer, to point to the
SVGAnimatedType of the first <animate> element, owning the m_animatedType. From that point on each call to rect.x.animVal
will always return the same value as the SVGAnimatedType of the first <animate> element holds. Now after 2s the first
<animate> element becomes inactive, but its m_animatedType remains alive. The bindings don't notice this change at all.
Now at 4s, the second animation element gets active. It reuses the SVGAnimatedType of the first <animate> element, and
applies its animation changes to that SVGAnimatedType, which is immediately reflected in the bindings w/o any additional
work. It's very important for the understanding when animationStarted/animationEnded need to be called.
(WebCore::SVGAnimateElement::applyResultsToTarget): Remove now-obsolete m_aboutToStopAnimation logic. No need to know it at this point.
(WebCore::SVGAnimateElement::targetElementWillChange):
Renamed from targetElementDidChange(). This method is called from SVGSMILElement for following conditions:
- animation element is destructed
- animation element is removed from document
- target element of animation is destructed
- target element of animation is removed from document
- target element of animation changes id
Whenever any of this happens, we need to reset the animVal. Resetting the animVal involves resetting the PropertyType* pointer,
eg. SVGLength*, from the animVal property tear off, belonging to a certain SVGAnimatedProperty (eg. rect.x) to the initial
value again, which is the 'm_x' of the SVGRectElement. This is needed as the SVGAnimatedType the animVal currently points to,
if an animation is/was running, is destructed in targetElementWillChange(), to reset the SVGAnimateElement to the initial
state before it received a target. This is the only place which destructed the m_animatedType, and thus the only place that
needs to take care of resetting the animVal pointers.
- svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::constructFromCopy):
Add a new constructFromCopy(SVGGenericAnimatedType) function to SVGAnimatedLengthAnimator.
It takes a type-unsafe SVGGenericAnimatedType - the caller has to guarantee the type matches.
This is strictly enforced for the single caller of constructFromCopy, and guaranteed to be safe.
- svg/SVGAnimatedLength.h: Add new constructFromCopy method, which is used to avoid string-roundtrips when resetting to base values.
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal): Only returns true for AnimatedLength, for now.
(WebCore::SVGAnimatedType::setVariantValue): Takes a SVGGenericAnimatedType, assuming the type matches. Callers have to guarantee type-safety!
- svg/SVGAnimatedType.h:
(SVGAnimatedType): Add new static supportsAnimVal(AnimatedPropertyType) function.
(WebCore::SVGAnimatedType::variantValue): Add a generic accessor for all animated types, called variant(). Only one place uses this.
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::constructFromCopy):
New method to construct an eg. SVGAnimatedLengthAnimator right from a SVGLength, instead of a String.
In that case the SVGAnimatedType just stores a pointer to the underlying SVGLength, no copying and or other roundtrips involved.
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::svgAttributeChanged):
Implement this instead of attributeChanged. The previous implementation reset the animation state to Inactive, causing a full
rebuild, whenever any attribute changes, even though it might not be related for the animation element, eg.
animate.setAttribute("stdDeviationX", "foobar"). Fix that by checking if we support the attribute (keyTimes/keySplines/etc..)
, if not pass it on to SVGSMILElement (which supports begin/end/etc..) to check if it can handle that.
(WebCore::SVGAnimationElement::animationAttributeChanged):
Called from our svgAttributeChanged, and/or from SVGSMILElement::svgAttributeChanged, whenever a _known_ attribute has changed.
This sledgehammer should be used with care, instead of each time attributeChanged() is called :-)
(WebCore::setTargetAttributeAnimatedCSSValue):
Remove support for removing properties from the override style sheet. I've added this optimization too early, we should reevaluate
this once more types support animVal. It currently complexifies the logic too much, requiring setAttributeAnimatedValue to know
if the animation ends (and that's not easy to figure out, at least not using started/endedActiveInterval, as I anticipated).
(WebCore::findMatchingAnimatedProperty):
Add helper functions which retrieves a SVGAnimatedProperty* for a given SVGElement* targetElement, an attributeName, and an attribute
type. eg. findMatchingAnimatedProperty(myRectElement, SVGNames::xAttr, AnimatedLength) returns the SVGAnimatedProperty which is
exposed to JS, that holds: SVGProperty* baseVal, and SVGProperty* animVal. (Lazily created if they got accessed from JS.). This is
used to update the animVal pointing to a new eg. SVGLength* value, once animation has started, to make rect->x() return that new
SVGLength* value (internally), and to reflect the current animated value in rect.x.animVal.value from JS.
(WebCore::SVGAnimationElement::applyAnimatedValue): Refactored from setTargetAttributeAnimatedValue, to simplify the code.
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):
Helper function to share code betweeen animationStarted/animationEnded.
It takes a SVGAnimatedProperty* and a SVGAnimatedType* which may be zero, indicating that the animation ended.
It calls animationStarted/animationEnded on the given SVGAnimatedProperty, to update the animVal state.
It also figures out all instances of the target element, and their SVGAnimatedProperties that may need updating.
(WebCore::SVGAnimationElement::animationStarted): Uses the helper above, passing on the given animatedType.
(WebCore::SVGAnimationElement::animationEnded): Uses the helper above, passing 0 as animatedType.
(WebCore::InstanceUpdateBlocker::InstanceUpdateBlocker):
Added new helper struct, doing element->setInstancesUpdatedBlock(true) on construction and setInstancesUpdatesBlocked(false) on
destruction, making it impossible to forget one. If we ever rewrite svgAttributeChanged & co to auto-update the cloned instances,
this can go away.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
Now takes an SVGAnimatedType* instead of a String parameter. In order to avoid string-roundtrips for animVal support, let us
decide if we need to construct a String out of it, or not. For animations supporting animVal (only SVGLength) we don't need
to update any attribute or animVal pointer here, that happens automatically! We only need to notify the targetElement eg,
that its xAttr changed! Previously we had to call targetElement->setAttribute("x", "...") on every animation step for
SVGLength animations - that's gone now! The SVGAnimatedType pointers remains the same during the whole animation, so there's
no need to call animationStarted() at each animated step!
(WebCore::SVGAnimationElement::animatedPropertyForType):
Helper function returning a SVGAnimatedProperty* for the current target element & current target attribute, if the
current animation is running on a type supporting animVal (SVGLength), or returning 0. This is needed for SVGAnimateElement.
Reuses the existing findMatchingAnimatedProperty code.
- svg/SVGAnimationElement.h:
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
Add comment to clarify why caching baseValues is just wrong. For SVGLength animations the problem is now gone.
This is exercised using the new additive-from-to-width-animation.html & additive-values-width-animation.html tests.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::removedFromDocument):
Since animVal requires that the SVGAnimatedProperties are correctly reset if an animation element is removed from the document,
we have to call targetElementWillChange(0) from here. That requires to move the "m_attributeName = anyQName()" line down,
otherwise targetElementWillChange() would early exit, as no valid attributeName was specified.
This is verified using the new svg/animations/remove-animation-element-while-animation-is-running.html
and svg/repaint/repainting-after-animation-element-removal.svg tests.
(WebCore::SVGSMILElement::isSupportedAttribute): Add function like all SVG*Elements have identifying their supported attributes.
(WebCore::SVGSMILElement::svgAttributeChanged):
Implement svgAttributeChanged instead of attributeChanged. Only take action if the attribute is actually supported.
If one of the common attributes like begin/end/etc. changed, be sure to call animationAttributeChanged() so that our
ancestor-classes get notified about this and can take action as well. NOTE: This is not about animating begin/end attributes,
but about pure DOM changes. begin/end/et.. are not exposed to the SVG DOM, we still reuse the svgAttributeChanged logic
for consistency. (This does NOT make those attributes animatable, nothing this here as it came up while reviewing).
(WebCore::SVGSMILElement::targetElement): Adapt logic to targetElementDidChange -> targetElementWillChange change.
(WebCore::SVGSMILElement::targetElementWillChange):
Renamed from targetElementDidChange. Added "oldTarget" as parameter as well. Our ancestor-classes like SVGAnimateElement
use this to properly deregister the animVal in the old target, before resetting the SVGAnimatedType, otherwise we'd leave
dangling pointers around (verified manually by guard malloc runs, that none of this happens).
Also add a default implementation here in targetElementWillChange, that ancestor classes have to call.
Now we properly call endedActiveInterval() if the m_activeState is currently Active, so that animations are shut-down
just like if the animation properly ends (use the same cleanup routines, etc.). Not doing that now leads to assertions.
(WebCore::SVGSMILElement::resetTargetElement):
Instead of forcing m_activeState to be inactive, use the standard methods to end the animation.
targetElementWillChange(m_targetElement, 0) and animationAttributeChanged().
resetTargetElement() is only called by SVGDocumentExtensions::removeAllAnimationElementsFromTarget() for following conditions:
- targetElement gets destructed
- targetElement gets removed from the document
- targetElement id changes
If the targetElement gets destructed or removed, no actions need to be taken, as the SVGAnimatedPropertys are teared down
as well. But if only the id changes, we still have to properly disconnect the animVals - this is all handled through
targetElementWillChange now - that's why this has to be called from here as well.
That explains why targetElementWillChange() now needs to check if the targetElement is destructing or not.
- svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
Pass the AnimatedPropertyType from the SVGPropertyInfo to the SVGAnimatedProperties.
Requires mechanic changes in all SVGAnimated* classes. We need acccess to the AnimatedPropertyType
to verify the SVGAnimatedType objects, passed to animationStarted, match our type. This is to enforce
strict type-checking, whenever SVGGenericAnimatedTypes are passed around.
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):
- svg/properties/SVGAnimatedListPropertyTearOff.h: Ditto.
(WebCore::SVGAnimatedListPropertyTearOff::create):
(WebCore::SVGAnimatedListPropertyTearOff::SVGAnimatedListPropertyTearOff):
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Ditto.
(WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
- svg/properties/SVGAnimatedProperty.h: Store AnimatedPropertyType, add accessors.
(WebCore::SVGAnimatedProperty::animatedPropertyType): Add accessor.
(WebCore::SVGAnimatedProperty::animationValueChanged): New animVal related functions to be implemented in the animated tear offs.
(WebCore::SVGAnimatedProperty::animationStarted): Ditto.
(WebCore::SVGAnimatedProperty::animationEnded): Ditto.
(WebCore::SVGAnimatedProperty::currentBaseValue):
Generic accessor for the baseVal: returns a SVGGenericAnimatedType.
It takes an AnimatedPropertyType as input, that's only needed to verify that the type we're returning matches
the expectation of the caller. If not, return 0 to avoid any potential casting mistakes, which would lead to crashes.
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty): Store m_animatedPropertyType.
- svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::create): Same changes as in the other tear offs: pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue): Returns &m_property, if the type matches (see above).
(SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::animationValueChanged): No-op for non list types, don't need to do anything here.
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
Store the currently animated value in the animVal() property tear off, that's also re-used as-is for the JS bindings.
As this is important, here's an example of how this affects methods like rect->x() used in the renderers.
Setting m_isAnimating to true, redirects any rect->x() calls that previously returned rect->m_x, to
rect->xAnimated()->animVal()->propertyReference() (which returns the same SVGLength& that the SVGAnimatedElement
m_animatedType contains). Calling rect->setXBaseValue() still modifies rect->m_x, and is used by all parseAttribute()
methods in svg/ as setAttribute() calls only ever modify the "baseValue", never the current animated value.
rect.x.baseVal will return a SVGLength object corresponding to rect->m_x.
rect.x.animVal will return a SVGLength object corresponding to rect->xAnimated()->animVal()->propertyReference().
These implementation details are all hidden in the SVGAnimatedPropertyMacros. Here's an example from SVGRectElement:
DECLARE_ANIMATED_LENGTH(X, x) -> Replace PropertyType with 'SVGLength', LowerProperty with 'x', and UpperProperty with 'X'.
PropertyType& LowerProperty() const
{
if (TearOffType* wrapper = SVGAnimatedProperty::lookupWrapper<UseOwnerType, TearOffType, IsDerivedFromSVGElement<UseOwnerType>::value>(this, LowerProperty##PropertyInfo())) {
if (wrapper->isAnimating())
return wrapper->currentAnimatedValue();
}
return m_##LowerProperty.value;
}
PropertyType& LowerProperty##BaseValue() const
{
return m_##LowerProperty.value;
}
void set##UpperProperty##BaseValue(const PropertyType& type)
{
m_##LowerProperty.value = type;
}
Any code outside of svg/, eg. in rendering/svg, does not need to care about any baseVal/animVal differences.
During layout eg. RenderSVGRect calls rect->x().value(someLengthContext) to get the current 'x' as float. If an animation
is running on that rect element it will automatically retrieve the last set animated value here - all under the hood.
I hope that sheds some light in those myserious functions, they were designed with animVal in mind, but we never had that until now :-)
(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): Add destructor to debug builds veryifing that m_isAnimating is false.
- svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.
(WebCore::SVGAnimatedStaticPropertyTearOff::create):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Ditto.
(WebCore::SVGAnimatedTransformListPropertyTearOff::create):
(WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):
- svg/properties/SVGPropertyInfo.h: Add SVGGenericAnimatedType definition.
- svg/properties/SVGPropertyTearOff.h: Remove obsolete updateAnimVal method - switched to using setValue directly.
LayoutTests:
Update test expectations after turning on animVal support for SVGLength, the first primitive now support animVal.
Added several new tests, checking additive behaviour with SVGLength objects, removing animation elements
while animations are running (+ test repainting of those cases), etc.
- platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
- platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
- svg/animations/additive-from-to-width-animation-expected.txt: Added.
- svg/animations/additive-from-to-width-animation.html: Added.
- svg/animations/additive-values-width-animation-expected.txt: Added.
- svg/animations/additive-values-width-animation.html: Added.
- svg/animations/animVal-basics-expected.txt:
- svg/animations/animate-calcMode-spline-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-by-expected.txt:
- svg/animations/animate-calcMode-spline-from-to-expected.txt:
- svg/animations/animate-calcMode-spline-to-expected.txt:
- svg/animations/animate-calcMode-spline-values-expected.txt:
- svg/animations/animate-elem-02-t-drt-expected.txt:
- svg/animations/animate-elem-09-t-drt-expected.txt:
- svg/animations/animate-elem-10-t-drt-expected.txt:
- svg/animations/animate-elem-11-t-drt-expected.txt:
- svg/animations/animate-elem-12-t-drt-expected.txt:
- svg/animations/animate-elem-13-t-drt-expected.txt:
- svg/animations/animate-elem-14-t-drt-expected.txt:
- svg/animations/animate-elem-15-t-drt-expected.txt:
- svg/animations/animate-elem-16-t-drt-expected.txt:
- svg/animations/animate-elem-17-t-drt-expected.txt:
- svg/animations/animate-elem-18-t-drt-expected.txt:
- svg/animations/animate-elem-19-t-drt-expected.txt:
- svg/animations/animate-end-attribute-expected.txt:
- svg/animations/animate-endElement-beginElement-expected.txt:
- svg/animations/animate-from-to-keyTimes-expected.txt:
- svg/animations/animate-insert-begin-expected.txt:
- svg/animations/animate-insert-no-begin-expected.txt:
- svg/animations/animate-keySplines-expected.txt:
- svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
- svg/animations/attributeTypes-expected.txt:
- svg/animations/change-baseVal-while-animating-fill-freeze-2-expected.txt: Added.
- svg/animations/change-baseVal-while-animating-fill-freeze-2.html: Added.
- svg/animations/change-baseVal-while-animating-fill-freeze-expected.txt: Added.
- svg/animations/change-baseVal-while-animating-fill-freeze.html: Added.
- svg/animations/change-baseVal-while-animating-fill-remove-2-expected.txt: Added.
- svg/animations/change-baseVal-while-animating-fill-remove-2.html: Added.
- svg/animations/change-baseVal-while-animating-fill-remove-expected.txt: Added.
- svg/animations/change-baseVal-while-animating-fill-remove.html: Added.
- svg/animations/change-target-while-animating-SVG-property-expected.txt: Added.
- svg/animations/change-target-while-animating-SVG-property.html: Added.
- svg/animations/multiple-animations-fill-freeze-expected.txt: Added.
- svg/animations/multiple-animations-fill-freeze.html: Added.
- svg/animations/remove-animation-element-while-animation-is-running-expected.txt: Added.
- svg/animations/remove-animation-element-while-animation-is-running.html: Added.
- svg/animations/resources/additive-from-to-width-animation.svg: Added.
- svg/animations/resources/additive-values-width-animation.svg: Added.
- svg/animations/resources/change-baseVal-while-animating-fill-freeze.svg: Added.
- svg/animations/resources/change-baseVal-while-animating-fill-remove.svg: Added.
- svg/animations/resources/change-target-while-animating-SVG-property.svg: Added.
- svg/animations/resources/multiple-animations-fill-freeze.svg: Added.
- svg/animations/resources/remove-animation-element-while-animation-is-running.svg: Added.
- svg/animations/script-tests/additive-from-to-width-animation.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/additive-values-width-animation.js: Added.
(sample1):
(sample2):
(sample3):
(changeBaseVal):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/animVal-basics.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-calcMode-spline-by.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-calcMode-spline-from-by.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-calcMode-spline-from-to.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-calcMode-spline-to.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-calcMode-spline-values.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-elem-02-t-drt.js:
(sampleAfterBegin):
(sampleAfterMid):
(sampleAfterBeginOfFirstRepetition):
(sampleAfterMidOfFirstRepetition):
- svg/animations/script-tests/animate-elem-09-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-10-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-11-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-12-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-13-t-drt.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-elem-14-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-15-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-16-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-17-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-18-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-elem-19-t-drt.js:
(sample1):
(sample2):
(sample3):
(sample4):
- svg/animations/script-tests/animate-end-attribute.js:
(sample2):
(sample3):
- svg/animations/script-tests/animate-endElement-beginElement.js:
(sample1):
- svg/animations/script-tests/animate-from-to-keyTimes.js:
(sample1):
(sample2):
- svg/animations/script-tests/animate-insert-begin.js:
(sample1):
(sample2):
- svg/animations/script-tests/animate-insert-no-begin.js:
(sample1):
(sample2):
- svg/animations/script-tests/animate-keySplines.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/attributeTypes.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/change-baseVal-while-animating-fill-freeze-2.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/change-baseVal-while-animating-fill-freeze.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/change-baseVal-while-animating-fill-remove-2.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/change-baseVal-while-animating-fill-remove.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/change-target-while-animating-SVG-property.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
- svg/animations/script-tests/multiple-animations-fill-freeze.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(executeTest):
- svg/animations/script-tests/remove-animation-element-while-animation-is-running.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/svglength-animation-LengthModeHeight.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-LengthModeOther.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-LengthModeWidth.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-invalid-value-1.js:
(sample2):
- svg/animations/script-tests/svglength-animation-invalid-value-2.js:
(sample2):
- svg/animations/script-tests/svglength-animation-invalid-value-3.js:
(sample2):
- svg/animations/script-tests/svglength-animation-number-to-number.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-cm.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-ems.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-exs.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-in.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-number.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-pc.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-percentage.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-pt.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-px-to-px.js:
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-unitType.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/svglength-animation-values.js:
(sample2):
(sample3):
(sample4):
(sample5):
- svg/animations/svglength-animation-LengthModeHeight-expected.txt:
- svg/animations/svglength-animation-LengthModeOther-expected.txt:
- svg/animations/svglength-animation-LengthModeWidth-expected.txt:
- svg/animations/svglength-animation-invalid-value-1-expected.txt:
- svg/animations/svglength-animation-invalid-value-2-expected.txt:
- svg/animations/svglength-animation-invalid-value-3-expected.txt:
- svg/animations/svglength-animation-number-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-cm-expected.txt:
- svg/animations/svglength-animation-px-to-ems-expected.txt:
- svg/animations/svglength-animation-px-to-exs-expected.txt:
- svg/animations/svglength-animation-px-to-in-expected.txt:
- svg/animations/svglength-animation-px-to-number-expected.txt:
- svg/animations/svglength-animation-px-to-pc-expected.txt:
- svg/animations/svglength-animation-px-to-percentage-expected.txt:
- svg/animations/svglength-animation-px-to-pt-expected.txt:
- svg/animations/svglength-animation-px-to-px-expected.txt:
- svg/animations/svglength-animation-unitType-expected.txt:
- svg/animations/svglength-animation-values-expected.txt:
- svg/repaint/repainting-after-animation-element-removal.svg: Added.
- 1:12 AM Changeset in webkit [110544] by
-
- 3 edits in trunk/Source/WebCore
Implement CSSPropertyTextOverflow in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80934
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 12:28 AM Changeset in webkit [110543] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, inspector test rebaseline after r110532.
- inspector/styles/svg-style-expected.txt:
- 12:24 AM Changeset in webkit [110542] by
-
- 16 edits7 adds in trunk/LayoutTests
[Forms] Re-factor label.for tests for extending test coverage
https://bugs.webkit.org/show_bug.cgi?id=80574
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.
This patch changes label.labels attribute testing with using shared
utility functions, createFormControlDataSet for representing form
related information of HTML5 specification and setupLabelsTeset for
populating test sample dom tree and data set.
This patch extends coverage of existing label.labels test to cover
defined in the specification, labelable-elements.html, and adds
multiple label entries tests, labels-multiple-*.html.
Note: test failure of hidden input type will be fixed by
https://bugs.webkit.org/show_bug.cgi?id=80403
Note: test failure of output element will be fixed by
https://bugs.webkit.org/show_bug.cgi?id=80466
- fast/forms/label/labelable-elements-expected.txt: Added.
- fast/forms/label/labelable-elements.html: Added.
- fast/forms/label/labels-add-htmlFor-label-expected.txt:
- fast/forms/label/labels-add-htmlFor-label.html:
- fast/forms/label/labels-add-parent-label-expected.txt:
- fast/forms/label/labels-add-parent-label.html:
- fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-change-htmlFor-attribute.html:
- fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
- fast/forms/label/labels-multiple-sibling-labels.html: Added.
- fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
- fast/forms/label/labels-parent-and-sibling-labels.html: Added.
- fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-remove-htmlFor-attribute.html:
- fast/forms/label/labels-remove-htmlFor-label-expected.txt:
- fast/forms/label/labels-remove-htmlFor-label.html:
- fast/forms/label/labels-remove-parent-label-expected.txt:
- fast/forms/label/labels-remove-parent-label.html:
- fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
- fast/forms/label/labels-set-htmlFor-attribute.html:
- fast/forms/resources/common.js:
(createFormControlDataSet): Returns form control data set for providing
labelable elements and supported elements information.
- fast/forms/resources/label-test-util.js: Added.
(setupLabelsTest.return.dataSet.dataSet.getLabelableElementData):
(setupLabelsTest): Populate dom tree for unit tests.
Mar 12, 2012:
- 11:42 PM Changeset in webkit [110541] by
-
- 2 edits in trunk/Source/WebCore
Switch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=80935
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Kent Tamura.
ICU seems to have issues with non-well-formed locale strings.
Currently, the only port that uses LocaleToScriptMappingICU.cpp is
Chromium.
No new tests. LocaleToScriptMappingDefault.cpp is already used by
other ports and covered by existing tests.
- WebCore.gyp/WebCore.gyp:
- 11:15 PM Changeset in webkit [110540] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fix test cases for RegExp multiline
https://bugs.webkit.org/show_bug.cgi?id=80822
Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.
- tests/mozilla/js1_2/regexp/RegExp_multiline.js:
- tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js:
- tests/mozilla/js1_2/regexp/beginLine.js:
- tests/mozilla/js1_2/regexp/endLine.js:
- 10:38 PM Changeset in webkit [110539] by
-
- 21 edits1 add in trunk/Source/WebCore
Fix IndexedDB build with JSC
https://bugs.webkit.org/show_bug.cgi?id=80207
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-12
Reviewed by Adam Barth.
This fixes the build of WebKit when IndexedDB is enabled. Most functions were added
empty implementation, it compiles but IndexedDB is not working.
- DerivedSources.make: Added missing IDL files.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Fix warnings and build errors.
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: ditto.
(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase): ditto.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp: ditto.
(WebCore::IDBFactoryBackendImpl::openBackingStore):
- Modules/indexeddb/IDBIndexBackendImpl.cpp: ditto.
(WebCore::IDBIndexBackendImpl::countInternal):
- Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Fix the method signature and add
an empty implementation.
(WebCore):
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Fix warnings.
(WebCore::IDBObjectStoreBackendImpl::countInternal):
- Modules/indexeddb/IDBPendingTransactionMonitor.cpp: ditto.
(WebCore::transactions):
- Modules/indexeddb/IDBRequest.cpp: ditto.
(WebCore::IDBRequest::resetReadyState):
- Modules/indexeddb/IDBRequest.h: ditto.
(WebCore::IDBRequest::onSuccessWithPrefetch):
(WebCore):
(WebCore::JSIDBVersionChangeRequest::visitChildren):
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue): Fix the creation of IDBKeys.
(WebCore::createOptionsObjectFromValue): Add an empty implementation of
the handling of database options (IDBObjectStoreParameters).
(WebCore):
- bindings/js/IDBBindingUtilities.h:
(WebCore):
- bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS): Add the missing IDBAny's types.
- bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS): Add the missing IDBKey's types.
- bindings/js/JSIDBVersionChangeRequestCustom.cpp: Added.
IDBVersionChangeRequest has the attribute EventTarget so it requires
the visitChildren() function. An empty implementation was added.
- bindings/js/OptionsObject.h: Add an empty implementation.
(WebCore):
(OptionsObject):
(WebCore::OptionsObject::OptionsObject):
(WebCore::OptionsObject::isObject):
(WebCore::OptionsObject::isUndefinedOrNull):
(WebCore::OptionsObject::get):
(WebCore::OptionsObject::getWithUndefinedOrNullCheck):
- bindings/js/SerializedScriptValue.cpp: Add the missing functions needed by IndexedDB.
(WebCore):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/scripts/CodeGeneratorJS.pm: Modify the code generator to:
-Support the IDBKey type correctly.
-Support the OptionsObject type.
-Generate valid function call for static functions.
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
- 10:36 PM Changeset in webkit [110538] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r110529.
http://trac.webkit.org/changeset/110529
https://bugs.webkit.org/show_bug.cgi?id=80969
breaks mac build (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12
Source/WebCore:
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebCore):
- 10:03 PM Changeset in webkit [110537] by
-
- 42 edits2 copies in trunk
Unreviewed, rolling out r110524.
http://trac.webkit.org/changeset/110524
https://bugs.webkit.org/show_bug.cgi?id=80936
breaks chromium win build. (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12
Source/WebCore:
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- css/CSSStyleSheet.idl:
- css/StyleSheet.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- html/DOMTokenList.idl:
- html/track/TextTrackList.idl:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 9:20 PM Changeset in webkit [110536] by
-
- 3 edits in trunk/Source/WebCore
[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=80924
Reviewed by Adam Barth.
getCachedWrapperSlow() is called by getCachedWrapper() only,
and getCachedWrapperSlow() just calls getCachedWrapperInline().
Thus, this patch expands getCachedWrapperInline() into getCachedWrapper(),
and removes getCachedWrapperSlow().
No tests. No change in behavior.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
- 9:03 PM Changeset in webkit [110535] by
-
- 13 edits in trunk/Source/WebCore
[V8][Refactoring] Remove existingWrapper() from generated code
https://bugs.webkit.org/show_bug.cgi?id=80927
Reviewed by Adam Barth.
Currently wrap() calls existingWrapper(), and existingWrapper()
just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.
Test: bindings/scripts/test/*
- bindings/scripts/CodeGeneratorV8.pm: Removed existingWrapper().
(GenerateHeader):
(GenerateNormalAttrGetter):
- bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
- 8:33 PM Changeset in webkit [110534] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Use tileRect instead of pointer derefs
https://bugs.webkit.org/show_bug.cgi?id=80919
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.
Covered by existing tests.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTileQuad):
- 8:14 PM Changeset in webkit [110533] by
-
- 3 edits in trunk/Tools
webkit-patch optimize-baselines sometimes creates a mac-future result
https://bugs.webkit.org/show_bug.cgi?id=80717
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(_baseline_search_hypergraph):
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._filter_virtual_ports):
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_no_add_mac_future):
- 7:45 PM Changeset in webkit [110532] by
-
- 8 edits8 adds in trunk
SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068
Patch by Hans Muller <hmuller@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.
Source/WebCore:
Added SVG support for the CSS 'transform-origin' property and for percentage
values in the transform translate function. The changes conform to
http://dev.w3.org/csswg/css3-transforms/.
Tests: svg/transforms/percent-transform-values.xhtml
svg/transforms/transform-origin-css-property.xhtml
- css/svg.css:
(*):
(html|* > svg):
Default transform-origin for SVG elements is 0 0.
- platform/Length.h:
(WebCore::Length::calcFloatValue):
Added a calcFloatValue overload whose max parameter (for percent lengths) is a float.
The original version will be obsolete when the sub-pixel layout support is completed.
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
(WebCore):
(WebCore::requireTransformOrigin):
Transforms that only include translations don't depend on the transform-origin.
(WebCore::RenderStyle::applyTransform):
SVG elements interpret non-percentage/keyword transform-origin values relative to their viewport,
unlike HTML which interprets all transform-origin values relative to the element's origin.
The new FloatRect applyTransform() function handles SVG semantics. Similarly, SVG elements interpret
percentage/keyword transform-origin values relative to the origin of their objectBoundingBox(), HTML
uses the borderBox. All this per http://dev.w3.org/csswg/css3-transforms/.
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
LayoutTests:
Added tests for SVG CSS transform-origin property support and for
CSS translations specified with percentages and applied to an SVG element.
- svg/transforms/change-transform-origin-css-expected.xhtml: Added.
- svg/transforms/change-transform-origin-css.xhtml: Added.
- svg/transforms/change-transform-origin-presentation-attribute-expected.xhtml: Added.
- svg/transforms/change-transform-origin-presentation-attribute.xhtml: Added.
- svg/transforms/percent-transform-values-expected.txt: Added.
- svg/transforms/percent-transform-values.xhtml: Added.
- svg/transforms/transform-origin-css-property-expected.xhtml: Added.
- svg/transforms/transform-origin-css-property.xhtml: Added.
- 7:42 PM Changeset in webkit [110531] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed Windows build fix.
- src/WebViewImpl.cpp:
- 7:29 PM Changeset in webkit [110530] by
-
- 2 edits in trunk/LayoutTests
Fix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
https://bugs.webkit.org/show_bug.cgi?id=80925
Reviewed by Maciej Stachowiak.
- fast/events/input-element-display-none-in-dragleave-crash.html:
Add call to eventSender.mouseUp().
- 7:27 PM Changeset in webkit [110529] by
-
- 4 edits in trunk/Source
[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test: CCOcclusionTrackerTest3dTransform
CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
- 7:17 PM Changeset in webkit [110528] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=80820
Reviewed by Rob Buis.
The BlackBerry is using the FontPlatformData from Chromium porting.
- platform/graphics/FontPlatformData.h:
- 6:58 PM Changeset in webkit [110527] by
-
- 2 edits in trunk/Tools
More Windows build fixing.
- DumpRenderTree/win/WorkQueueItemWin.cpp:
- 6:52 PM Changeset in webkit [110526] by
-
- 3 edits2 adds in trunk
After webgl canvas resize, bindings might be lost
https://bugs.webkit.org/show_bug.cgi?id=80895
Reviewed by Stephen White.
Source/WebCore:
Test: fast/canvas/webgl/texture-bindings-uneffected-on-resize.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::reshape): recover bindings after reshape.
LayoutTests:
- fast/canvas/webgl/texture-bindings-uneffected-on-resize-expected.txt: Added.
- fast/canvas/webgl/texture-bindings-uneffected-on-resize.html: Added.
- 6:38 PM Changeset in webkit [110525] by
-
- 5 edits in trunk/Source/WebCore
[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
https://bugs.webkit.org/show_bug.cgi?id=80920
Reviewed by Adam Barth.
Now getWrapper() is the same as getExistingWrapper().
getWrapperSlow() is the same as getExistingWrapperSlow().
This patch removes getWrapper() and getWrapperSlow().
Also this patch renames getExistingWrapper() to getCachedWrapper().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getWrapperSlow):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getWrapper):
(V8DOMWrapper):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 6:37 PM Changeset in webkit [110524] by
-
- 42 edits2 deletes in trunk
[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880
Reviewed by Adam Barth.
Source/WebCore:
We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.
To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8).
No new tests. Covered by existing tests.
- Target.pri:
- UseV8.cmake:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
- bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- css/CSSStyleSheet.idl:
- css/StyleSheet.idl:
- dom/DOMStringMap.idl:
- dom/NamedNodeMap.idl:
- html/DOMTokenList.idl:
- html/track/TextTrackList.idl:
LayoutTests:
- platform/chromium/test_expectations.txt:
- 6:31 PM Changeset in webkit [110523] by
-
- 7 edits in trunk/Tools
More Windows build fixing.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
- DumpRenderTree/win/EditingDelegate.cpp:
- DumpRenderTree/win/EventSender.cpp:
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/win/UIDelegate.cpp:
- 6:29 PM Changeset in webkit [110522] by
-
- 2 edits in trunk/LayoutTests
Remove obsolete 'CPU' modifier.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 6:27 PM LayoutUnit edited by
- (diff)
- 6:16 PM Changeset in webkit [110521] by
-
- 3 edits in trunk/LayoutTests
Object.defineProperty doesn't respect attributes when applied to the Global Object
https://bugs.webkit.org/show_bug.cgi?id=38636
Object.defineProperty doesn't create property on Global Object in the presence of a setter in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=48911
Rubber stamped by Michael Saboff.
- fast/js/Object-defineProperty-expected.txt:
- fast/js/script-tests/Object-defineProperty.js:
- Added test cases for bugs #38636 & #48911.
- 6:13 PM Changeset in webkit [110520] by
-
- 3 edits in trunk/Source/WebKit/win
More Windows build fixing.
- MarshallingHelpers.cpp:
- WebDatabaseManager.cpp:
- 6:10 PM Changeset in webkit [110519] by
-
- 3 edits in trunk/Source/WebCore
[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
https://bugs.webkit.org/show_bug.cgi?id=80916
Reviewed by Adam Barth.
This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getWrapperSlow):
- 6:05 PM Changeset in webkit [110518] by
-
- 8 edits2 deletes in trunk/Source/JavaScriptCore
Arithmetic use inference should be procedure-global and should run in tandem
with type propagation
https://bugs.webkit.org/show_bug.cgi?id=80819
<rdar://problem/11034006>
Reviewed by Gavin Barraclough.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArithNodeFlagsInferencePhase.cpp: Removed.
- dfg/DFGArithNodeFlagsInferencePhase.h: Removed.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::flags):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeFlags):
- 6:02 PM Changeset in webkit [110517] by
-
- 1 edit165 deletes in trunk/LayoutTests
Remove obsolete chromium-gpu-* platform directories for LayoutTests baselines.
Unreviewed, baselines change.
All of the baselines are now in platform/chromium-*/platform/chromium/virtual/gpu/*.
- platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Removed.
- platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Removed.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Removed.
- platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Removed.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Removed.
- platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Removed.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Removed.
- platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
- platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
- platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
- platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Removed.
- platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-no-audio-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-transformed-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-gpu-linux/media/video-zoom-expected.png: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
- platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-as-image-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-bg-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-bg-zoom-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-transform-skewed-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/image-pattern-rotate-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/patternfill-repeat-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Removed.
- platform/chromium-gpu-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
- platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-no-audio-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-transformed-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-gpu-mac/media/video-zoom-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Removed.
- platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
- platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
- platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Removed.
- platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Removed.
- platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Removed.
- platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Removed.
- platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
- platform/chromium-gpu-win/media/video-display-toggle-expected.png: Removed.
- platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Removed.
- platform/chromium-gpu-win/media/video-layer-crash-expected.png: Removed.
- platform/chromium-gpu-win/media/video-no-audio-expected.png: Removed.
- platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Removed.
- platform/chromium-gpu-win/media/video-transformed-expected.png: Removed.
- platform/chromium-gpu-win/media/video-volume-slider-expected.png: Removed.
- platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-gpu-win/media/video-zoom-expected.png: Removed.
- platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Removed.
- platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Removed.
- platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Removed.
- 5:55 PM Changeset in webkit [110516] by
-
- 3 edits in trunk/Tools
remove the 'gpu' group from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80353
Reviewed by Adam Barth.
Since those bots are obsolete, we don't need this any more.
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testPlatformAndBuildType):
(testHtmlForTestTypeSwitcherGroup):
- 5:53 PM Changeset in webkit [110515] by
-
- 7 edits in trunk/Source/WebCore
[V8] Refactor some header includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80913
Reviewed by Adam Barth.
This patch refactors some header includes in V8 bindings
required for fixing bug 80841.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.h:
(DOMDataStore):
- bindings/v8/V8DOMMap.h:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::isolatedContext):
- bindings/v8/V8IsolatedContext.h:
(WebCore::V8IsolatedContext::getEntered):
(V8IsolatedContext):
- bindings/v8/WorldContextHandle.cpp:
- 5:50 PM Changeset in webkit [110514] by
-
- 19 edits in trunk/Tools
remove graphics_type from webkitpy.layout_tests.models.test_configuration
https://bugs.webkit.org/show_bug.cgi?id=80643
Reviewed by Ojan Vafai.
Now that the chromium-gpu ports are gone, there's no need for
the graphics_type CPU/GPU distinction. Most of this change is
just updating tests accordingly.
- Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
(TestExpectationEditorTests):
- Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfiguration.init):
(TestConfiguration.category_order):
(TestConfiguration.str):
(TestConfiguration.repr):
(TestConfiguration.hash):
(TestConfigurationConverter.to_specifiers_list):
- Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(make_mock_all_test_configurations_set):
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_error_on_different_build_type):
(TestExpectationSerializerTests.test_parsed_to_string):
(TestExpectationSerializerTests.test_reconstitute_only_these):
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
(Port.name):
(Port.version):
(Port.test_configuration):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.init):
- Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
(ChromiumLinuxPortTest.test_check_illegal_port_names):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_baseline_path):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._generate_all_test_configurations):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.all_test_configurations):
(TestPort._all_build_types):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningExpectationsUpdaterTest.test_unknown_failure_type):
(GardeningExpectationsUpdaterTest.test_add_new_expectation):
(GardeningExpectationsUpdaterTest.test_replace_old_expectation):
(GardeningExpectationsUpdaterTest.test_pass_expectation):
(GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
(GardeningExpectationsUpdaterTest.test_spurious_updates):
- 5:43 PM Changeset in webkit [110513] by
-
- 8 edits in trunk/Tools
_runtime_feature_list isn't supported on Apple Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=80906
Reviewed by Eric Seidel.
It looks like this feature is actually only supported on the Win
DRT port, so this patch reworks the code to make that clearer
and reduce unnecessary overrides.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._path_to_webcore_library):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._skipped_file_search_paths):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._runtime_feature_list):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(test_skipped_directories_for_features):
- Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort._runtime_feature_list):
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_operating_system):
(WinPortTest):
(WinPortTest.test_runtime_feature_list):
- 5:31 PM Changeset in webkit [110512] by
-
- 3 edits in trunk/Source/WebKit2
Fix typo in PageClientImpl where we were overriding viewLayerHostingMode with
a function called layerHostingMode.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::viewLayerHostingMode):
Update name and add OVERRIDE to catch this in the future.
- 5:22 PM Changeset in webkit [110511] by
-
- 11 edits13 moves in trunk/Source/WebCore
Unreviewed, rolling out r110501.
http://trac.webkit.org/changeset/110501
https://bugs.webkit.org/show_bug.cgi?id=80908
Broke the Apple-Win build (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/DirectoryEntry.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.cpp.
(WebCore):
(WebCore::DirectoryEntry::DirectoryEntry):
(WebCore::DirectoryEntry::createReader):
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
(WebCore::DirectoryEntry::removeRecursively):
- fileapi/DirectoryEntry.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.h.
(WebCore):
(DirectoryEntry):
(WebCore::DirectoryEntry::create):
(WebCore::DirectoryEntry::isDirectory):
- fileapi/DirectoryEntry.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.idl.
- fileapi/DirectoryEntrySync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp.
(WebCore):
(WebCore::DirectoryEntrySync::DirectoryEntrySync):
(WebCore::DirectoryEntrySync::createReader):
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
(WebCore::DirectoryEntrySync::removeRecursively):
- fileapi/DirectoryEntrySync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.h.
(WebCore):
(DirectoryEntrySync):
(WebCore::DirectoryEntrySync::create):
(WebCore::DirectoryEntrySync::isDirectory):
- fileapi/DirectoryEntrySync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl.
- fileapi/DirectoryReader.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.cpp.
(WebCore):
(WebCore::DirectoryReader::DirectoryReader):
(WebCore::DirectoryReader::readEntries):
- fileapi/DirectoryReader.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.h.
(WebCore):
(DirectoryReader):
(WebCore::DirectoryReader::create):
(WebCore::DirectoryReader::filesystem):
- fileapi/DirectoryReader.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.idl.
- fileapi/DirectoryReaderBase.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderBase.h.
(WebCore):
(DirectoryReaderBase):
(WebCore::DirectoryReaderBase::filesystem):
(WebCore::DirectoryReaderBase::setHasMoreEntries):
(WebCore::DirectoryReaderBase::DirectoryReaderBase):
- fileapi/DirectoryReaderSync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp.
(WebCore):
(WebCore::DirectoryReaderSync::DirectoryReaderSync):
(WebCore::DirectoryReaderSync::readEntries):
- fileapi/DirectoryReaderSync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.h.
(WebCore):
(DirectoryReaderSync):
(WebCore::DirectoryReaderSync::create):
- fileapi/DirectoryReaderSync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl.
- 5:15 PM Changeset in webkit [110510] by
-
- 2 edits in trunk/Source/WebCore
[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
https://bugs.webkit.org/show_bug.cgi?id=80902
Reviewed by Adam Barth.
Follow-up to http://codereview.chromium.org/9638015/
No intended behavior change.
- WebCore.gyp/mac/adjust_visibility.sh:
- 5:14 PM Changeset in webkit [110509] by
-
- 4 edits in branches/subpixellayout/Source/WebCore/rendering
Fixing/cleaning up rounding in RenderReplaced classes, and removing an unnecessary static_cast in RenderFrameSet.
- 5:09 PM Changeset in webkit [110508] by
-
- 2 edits in branches/subpixellayout/Source
Qt build fixes for branch.
- 5:09 PM Changeset in webkit [110507] by
-
- 37 edits in trunk/Source/WebCore
WebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
https://bugs.webkit.org/show_bug.cgi?id=74750
Reviewed by Chris Rogers.
No new tests; optimization of existing code path, so covered by existing tests.
To account for AudioNodes which may generate non-silent audio when fed silent input
for a certain amount of time after the last non-silent audio data, add two new virtual
functions tailTime() and latencyTime().
- webaudio/AudioNode.h:
(WebCore::AudioNode::tailTime): Added. Pure virtual.
(WebCore::AudioNode::latencyTime): Added. Pure virtual.
- platform/audio/AudioProcessor.h:
(WebCore::AudioProcessor::tailTime): Added. Pure virtual.
(WebCore::AudioProcessor::latencyTime): Added. Pure virtual.
- platform/audio/AudioDSPKernel.h:
(WebCore::AudioDSPKernel::tailTime): Added. Pure virtual.
(WebCore::AudioDSPKernel::latencyTime): Added. Pure virtual.
Added tailTime() and latencyTime() overrides to the following classes:
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::tailTime):
(WebCore::AudioDSPKernelProcessor::latencyTime):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/DynamicsCompressor.h:
(WebCore::DynamicsCompressor::tailTime):
(WebCore::DynamicsCompressor::latencyTime):
- platform/audio/EqualPowerPanner.h:
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::tailTime):
(WebCore::HRTFPanner::latencyTime):
- platform/audio/HRTFPanner.h:
- platform/audio/Panner.h:
- webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::tailTime):
(WebCore::AudioBasicProcessorNode::latencyTime):
- webaudio/AudioBasicProcessorNode.h:
- webaudio/AudioChannelMerger.h:
- webaudio/AudioChannelSplitter.h:
- webaudio/AudioDestinationNode.h:
- webaudio/AudioGainNode.h:
- webaudio/AudioPannerNode.h:
- webaudio/AudioSourceNode.h:
- webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::tailTime):
(WebCore::BiquadDSPKernel::latencyTime):
- webaudio/BiquadDSPKernel.h:
- webaudio/BiquadFilterNode.h:
- webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::tailTime):
(WebCore::ConvolverNode::latencyTime):
- webaudio/ConvolverNode.h:
- webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::tailTime):
(WebCore::DelayDSPKernel::latencyTime):
- webaudio/DelayDSPKernel.h:
- webaudio/DelayProcessor.h:
- webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::tailTime):
(WebCore::DynamicsCompressorNode::latencyTime):
- webaudio/DynamicsCompressorNode.h:
- webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::tailTime):
(WebCore::JavaScriptAudioNode::latencyTime):
- webaudio/JavaScriptAudioNode.h:
- webaudio/RealtimeAnalyserNode.h:
- webaudio/WaveShaperDSPKernel.h:
The following functions were added as support for the new AudioNode and AudioProcessor functions:
- platform/audio/Biquad.cpp:
(WebCore::Biquad::latencyFrames):
- platform/audio/Biquad.h:
- platform/audio/Reverb.cpp:
(WebCore::Reverb::latencyFrames):
- platform/audio/ReverbConvolver.h:
(WebCore::ReverbConvolver::latencyFrames):
The following functions were made const-correct:
- platform/audio/HRTFPanner.h:
(WebCore::HRTFPanner::fftSize):
- platform/audio/Reverb.h:
(WebCore::Reverb::impulseResponseLength):
- 5:07 PM Changeset in webkit [110506] by
-
- 2 edits in trunk/Source/WebCore
WebTileLayers should be opaque
https://bugs.webkit.org/show_bug.cgi?id=80907
<rdar://problem/11034390>
Reviewed by Andreas Kling.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):
Call -[CALayer setOpaque:] on the newly created WebTileLayer.
- 5:05 PM WebKitGTK/1.8.x edited by
- (diff)
- 4:51 PM Changeset in webkit [110505] by
-
- 4 edits in trunk/Source/WebCore
Fix rounding in scrollbar rect calculations
https://bugs.webkit.org/show_bug.cgi?id=80894
Reviewed by Eric Seidel.
Fix usage of subpixel units in RenderScrollbar::buttonRect and
RenderScrollbar::trackRect.
No new tests, no new functionality.
- rendering/LayoutTypes.h:
(WebCore::isIntegerValue):
Add dummy isIntegerValue function, will be replaced with actual
implementation once LayoutUnit is remapped to FractionalLayoutUnit.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::trackRect):
Change rect calculations to use pixel snapped values.
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
(WebCore::RenderScrollbarPart::marginTop):
(WebCore::RenderScrollbarPart::marginBottom):
(WebCore::RenderScrollbarPart::marginLeft):
(WebCore::RenderScrollbarPart::marginRight):
Add ASSERT to ensure that scrollbar parts are always aligned to device
pixels.
- 4:46 PM Changeset in webkit [110504] by
-
- 2 edits in trunk/Source/WebCore
[GObject IDL Parser] STRING argument should be HASHREF
https://bugs.webkit.org/show_bug.cgi?id=78877
Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Kentaro Hara.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunctions): extendedAttributes are hashes, not strings
- 4:43 PM Changeset in webkit [110503] by
-
- 7 edits in trunk/Source/WebCore
More Windows build fixing.
Use fully qualified paths for WTF headers.
- platform/graphics/cg/ImageSourceCGWin.cpp:
- platform/graphics/win/UniscribeController.h:
- platform/win/DragImageCGWin.cpp:
- platform/win/DragImageCairoWin.cpp:
- platform/win/DragImageWin.cpp:
- rendering/RenderThemeSafari.cpp:
- 4:40 PM Changeset in webkit [110502] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
This baseline also applies to chromium-mac-snowleopard, so we can move
it up the fallback chain.
- platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/events/scrollbar-double-click-expected.txt: Added.
- 4:38 PM Changeset in webkit [110501] by
-
- 11 edits13 moves1 add in trunk/Source/WebCore
Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-12
Reviewed by Adam Barth.
No new tests, all existing tests pass.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/filesystem: Added.
- Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
- Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
- Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
- Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
- Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
- Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
- Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
- Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
- Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
- Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
- Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
- Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
- Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
- Target.pri:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/DirectoryEntry.cpp: Removed.
- fileapi/DirectoryEntry.h: Removed.
- fileapi/DirectoryEntry.idl: Removed.
- fileapi/DirectoryEntrySync.cpp: Removed.
- fileapi/DirectoryEntrySync.h: Removed.
- fileapi/DirectoryEntrySync.idl: Removed.
- fileapi/DirectoryReader.cpp: Removed.
- fileapi/DirectoryReader.h: Removed.
- fileapi/DirectoryReader.idl: Removed.
- fileapi/DirectoryReaderBase.h: Removed.
- fileapi/DirectoryReaderSync.cpp: Removed.
- fileapi/DirectoryReaderSync.h: Removed.
- fileapi/DirectoryReaderSync.idl: Removed.
- 4:34 PM Changeset in webkit [110500] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly
Reviewed by Tim Hatcher.
No new tests. (No behavior change)
Changed to hold the StorageArea directly and added a Frame* accessor:
- inspector/InspectorDOMStorageResource.h:
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
(InspectorDOMStorageResource):
- inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
- 4:23 PM Changeset in webkit [110499] by
-
- 2 edits in trunk/Source/WebCore
[Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892
Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.
Regressions should be covered by any test that does image decode on the mac.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::resolveColorSpace):
- 4:15 PM Changeset in webkit [110498] by
-
- 20 edits1 move2 adds in trunk/Source/JavaScriptCore
Node::op and Node::flags should be private
https://bugs.webkit.org/show_bug.cgi?id=80824
<rdar://problem/11033435>
Reviewed by Gavin Barraclough.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):
- dfg/DFGArithNodeFlagsInferencePhase.cpp:
(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::byValIsPure):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(DFG):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
- dfg/DFGNode.cpp: Removed.
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::op):
(JSC::DFG::Node::flags):
(JSC::DFG::Node::setOp):
(JSC::DFG::Node::setFlags):
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::clearFlags):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
- dfg/DFGNodeFlags.cpp: Copied from Source/JavaScriptCore/dfg/DFGNode.cpp.
- dfg/DFGNodeFlags.h: Added.
(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
- dfg/DFGNodeType.h: Added.
(DFG):
(JSC::DFG::defaultFlags):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):
- dfg/DFGRedundantPhiEliminationPhase.cpp:
(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 4:10 PM Changeset in webkit [110497] by
-
- 6 edits in branches/subpixellayout/Source
Fix scrollbar rect calculations on branch.
- 3:59 PM Changeset in webkit [110496] by
-
- 7 edits in trunk/Source/WebCore
Update LayoutUnit usage in RenderMathML* classes
https://bugs.webkit.org/show_bug.cgi?id=77916
Reviewed by Eric Seidel.
The purpose of this patch is to ensure MathML rendering does not regress when
we switch to sub-pixel layout. A subsequent patch can likely improve MathML's
rendering when zoom is applied.
To accomplish this without changing the current heuristics for positioning,
we continue to use integers for sizes and locations, using pixel snapping
when communicating with other Rendering classes.
No new tests. No change in behavior.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint): Cleaning up debug painting to be on
pixel boundaries instead of subpixel.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint): Reverting to integers for determining
the vertical offset.
(WebCore::RenderMathMLFraction::baselinePosition):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint): Using integers for height and width
and only accumulating pixel snapped values.
(WebCore::RenderMathMLRoot::layout): Setting padding with integers to
avoid inconsistent rounding based on the root's location.
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):
- rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint): See RenderMathMLRoot.
(WebCore::RenderMathMLSquareRoot::layout): Ditto.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::layout):
- 3:57 PM WebKitGTK/1.8.x edited by
- (diff)
- 3:48 PM Changeset in webkit [110495] by
-
- 3 edits in trunk/Source/WebCore
Use smaller tiles for right and bottom edges
https://bugs.webkit.org/show_bug.cgi?id=80893
<rdar://problem/11032873>
Reviewed by Sam Weinig.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::rectForTileIndex):
Intersect the rect with the tile cache bounds.
(WebCore::TileCache::revalidateTiles):
Resize already existing tiles if needed.
(WebCore::TileCache::createTileLayer):
This now takes a tile rect. Use setFrame instead of setting the bounds and position separately.
- 3:45 PM Changeset in webkit [110494] by
-
- 21 edits in trunk
Source/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073
Reviewed by Alexey Proskuryakov.
- WebCore.exp.in: Added two exported methods.
- platform/mac/FileSystemMac.mm:
(WebCore::setMetaData): Last parameter in the call to wkSetMetadataURL
needs to be wrapped in String before casting to NSString.
Source/WebKit2: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073
Reviewed by Alexey Proskuryakov.
This patch removes the last remaining access to NSPasteboard from the WebProcess.
The code in WebDragClient::declareAndWriteDragImage now packages all the data
required for the drag and the promised drag types and sends one request to the UI
process that will place the data in the NSPasteboard when appropriate.
- UIProcess/API/mac/PageClientImpl.h: Added setPromisedData method.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setPromisedData):
- UIProcess/API/mac/WKView.mm:
(matchesExtensionOrEquivalent): Added.
(fileExists): Added.
(pathWithUniqueFilenameForPath): Added.
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
- UIProcess/API/mac/WKViewInternal.h: Added _setPromisedData.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h: Added method for the new message.
- UIProcess/WebPageProxy.messages.in: Added setPromisedData message.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPromisedData):
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added SetMetadataURL.
WebKitLibraries: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073
- WebKitSystemInterface.h: Touched the file to make build system happy.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 3:40 PM Changeset in webkit [110493] by
-
- 10 edits in trunk/LayoutTests
Update expected results after http://trac.webkit.org/changeset/110480.
These results are very similar to our previous results and seem
slightly improved AFAICT.
- platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
- platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
- 3:38 PM Changeset in webkit [110492] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=80831
Patch by Andy Chen <andchen@rim.com> on 2012-03-12
Reviewed by Antonio Gomes.
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
- WebKitSupport/InPageSearchManager.h:
- 3:37 PM Changeset in webkit [110491] by
-
- 1 edit1 add in trunk/LayoutTests
Restore previous expecation for chromium-mac-leopard. rniwa says this
is the right thing to do.
- platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Added.
- 3:28 PM Changeset in webkit [110490] by
-
- 3 edits in trunk/LayoutTests
Yet another Mac rebaseline.
- editing/pasteboard/dataTransfer-setData-getData-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- 3:24 PM Changeset in webkit [110489] by
-
- 3 edits1 add4 deletes in trunk/LayoutTests
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=79132
Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.
- fast/regions/floats-basic-in-variable-width-regions-expected.html: Added.
- fast/regions/floats-basic-in-variable-width-regions.html:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
- platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
- platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
- 3:22 PM Changeset in webkit [110488] by
-
- 2 edits in trunk/Source/WebCore
clang build fix
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): Reorder
boolean operators, so that a warning about "use of logical with constant operand" doesn't appear.
- 3:17 PM Changeset in webkit [110487] by
-
- 3 edits2 adds in trunk
Crash in Text::splitText due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=80828
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/text/split-text-crash.xhtml
- dom/Range.cpp:
(WebCore::Range::insertNode): replace m_start.container() calls with ref protected node.
LayoutTests:
- fast/text/split-text-crash-expected.txt: Added.
- fast/text/split-text-crash.xhtml: Added.
- 2:59 PM Changeset in webkit [110486] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix clang build for CCOcclusionTracker tests
https://bugs.webkit.org/show_bug.cgi?id=80891
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adam Barth.
- tests/CCOcclusionTrackerTest.cpp:
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
- 2:59 PM Changeset in webkit [110485] by
-
- 6 edits in trunk
Null argument to texSubImage2D crashes
https://bugs.webkit.org/show_bug.cgi?id=80778
Reviewed by Dean Jackson.
Source/WebCore:
Generate INVALID_VALUE OpenGL error upon receiving null argument.
Final behavior still being decided on public-webgl mailing list.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncData):
- html/canvas/WebGLRenderingContext.h:
LayoutTests:
Updated tex-sub-image-2d-bad-args test to verify new behavior.
- fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt:
- fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
- 2:54 PM Changeset in webkit [110484] by
-
- 4 edits in trunk/Source/WebCore
Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly.
https://bugs.webkit.org/show_bug.cgi?id=80484
Reviewed by Julien Chaffraix.
No new tests / code cleanup only.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 2:52 PM Changeset in webkit [110483] by
-
- 11 edits in trunk/Source
[chromium] Restore canvas2D acceleration after context loss.
https://bugs.webkit.org/show_bug.cgi?id=80629
Reviewed by James Robinson.
Covered by existing canvas tests, and manual testing (killing the GPU
process).
Source/WebCore:
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::applyFilters):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::get):
(WebCore):
(WebCore::SharedGraphicsContext3D::get):
- platform/graphics/gpu/SharedGraphicsContext3D.h:
(SharedGraphicsContext3D):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore):
- platform/graphics/skia/PlatformContextSkia.h:
(WebCore):
(WebCore::PlatformContextSkia::isAccelerated):
(WebCore::PlatformContextSkia::setAccelerated):
(PlatformContextSkia):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sharedGraphicsContext3D):
- 2:51 PM Changeset in webkit [110482] by
-
- 7 edits in branches/subpixellayout/Source
Fixing misaligned painting in RenderListBox and RenderFileUploadControl. Correcting width calculations for platform code in RenderFileUploadControl. Changing RenderLayer::absoluteBoundingBox to a pixel snapped IntRect, which simplifies platform code.
- 2:36 PM Changeset in webkit [110481] by
-
- 2 edits in trunk/Source/WebCore
It doesn't make sense to return const unsigned, and GCC warns about it.
Remove const.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Antonio Gomes.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:
(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::offsetX):
- 2:33 PM Changeset in webkit [110480] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>
Reviewed by Dan Bernstein.
With http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):
- 2:28 PM Changeset in webkit [110479] by
-
- 1 edit in branches/chromium/1025/Source/WebCore/xml/XMLErrors.cpp
Merge 110111
BUG=117226
Review URL: https://chromiumcodereview.appspot.com/9689032
- 2:17 PM Changeset in webkit [110478] by
-
- 7 edits2 deletes in trunk
Cleanup obsolete files.
https://bugs.webkit.org/show_bug.cgi?id=80737
Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-12
Reviewed by James Robinson.
.:
- wscript:
Source/WebCore:
No new code.
- GNUmakefile.list.am:
- PlatformWinCE.cmake:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- platform/ScrollAnimatorWin.cpp: Removed.
- platform/ScrollAnimatorWin.h: Removed.
- 2:15 PM Changeset in webkit [110477] by
-
- 2 edits in trunk/Source/WebCore
Make texImage2D error for wrong size ArrayBufferView more helpful
https://bugs.webkit.org/show_bug.cgi?id=80868
It took me about 30 minutes to figure out my texImage2D was failing
not because my ArrayBufferView was too small but because the default
alignment is 4. A better error message might help devs find this issue
faster.
Patch by Gregg Tavares <gman@google.com> on 2012-03-12
Reviewed by Kenneth Russell.
No new tests as no new functionality.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncData):
- 2:08 PM Changeset in webkit [110476] by
-
- 5 edits1 add in trunk/LayoutTests
4 shadow DOM tests fail on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80869
Reviewed by Ryosuke Niwa.
- fast/dom/shadow/content-element-move.html: Changed to use ensureShadowRoot.
- fast/dom/shadow/iframe-shadow.html: Changed to use WebKitShadowRoot polyfil.
- fast/dom/shadow/resources/polyfill.js: Added.
- fast/dom/shadow/shadow-on-image.html: Changed to use WebKitShadowRoot polyfil.
- platform/wk2/Skipped: Added a test that should have been skipped when landed.
- 2:07 PM Changeset in webkit [110475] by
-
- 4 edits in trunk/LayoutTests
Update include path of the test scripts after r110470.
Reviewed by Philippe Normand.
- fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html:
- fast/dom/HTMLSelectElement/select-selectedIndex.html:
- fast/dom/HTMLSelectElement/select-selectedOptions.html:
- 2:04 PM Changeset in webkit [110474] by
-
- 1 edit1 add in trunk/LayoutTests
Add test expectations accidentally left out of r110465.
- fast/mutation/delivery-order-expected.txt: Added.
- 2:01 PM Changeset in webkit [110473] by
-
- 1 edit in branches/chromium/1025/Source/WebCore/dom/ContainerNode.cpp
Merge 110139
BUG=117226
- 1:47 PM Changeset in webkit [110472] by
-
- 1 edit2 deletes in trunk/LayoutTests
Mac rebaseline. Offset is always 700px now.
- platform/mac/fast/events/scrollbar-double-click-expected.txt: Removed.
- platform/win/fast/events/scrollbar-double-click-expected.txt: Removed.
- 1:43 PM Changeset in webkit [110471] by
-
- 5168 edits3892 copies731 deletes in branches/subpixellayout
Merge trunk changes up intil r110435 into subpixel branch.
- 1:33 PM Changeset in webkit [110470] by
-
- 1 edit8 adds8 deletes in trunk/LayoutTests
Move <select> related layout tests in the place they should be.
Reviewed by Andreas Kling.
- fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942-expected.txt: Added.
- fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942.html: Added.
- fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Added.
- fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Added.
- fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html: Added.
- fast/dom/HTMLSelectElement/select-selectedIndex.html: Added.
- fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
- fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
- fast/dom/select-selectedIndex-bug-12942-expected.txt: Removed.
- fast/dom/select-selectedIndex-bug-12942.html: Removed.
- fast/dom/select-selectedIndex-expected.txt: Removed.
- fast/dom/select-selectedIndex-multiple-expected.txt: Removed.
- fast/dom/select-selectedIndex-multiple.html: Removed.
- fast/dom/select-selectedIndex.html: Removed.
- fast/dom/select-selectedOptions-expected.txt: Removed.
- fast/dom/select-selectedOptions.html: Removed.
- 1:26 PM Changeset in webkit [110469] by
-
- 8 edits in trunk/Source/WebCore
Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>
Reviewed by Nikolas Zimmermann.
Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.
Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.
No new tests, as the problem only occurs in a nonstandard configuration.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):
- page/FrameView.h:
(FrameView):
(WebCore::FrameView::repaintsDisabled):
- rendering/RenderView.cpp:
(WebCore::RenderView::shouldRepaint):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):
- svg/graphics/SVGImage.h:
(WebCore):
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):
- svg/graphics/SVGImageCache.h:
(SVGImageCache):
- 1:26 PM Changeset in webkit [110468] by
-
- 125 edits in trunk/LayoutTests
IndexedDB: layout test style update
https://bugs.webkit.org/show_bug.cgi?id=80555
Change layoutTestController.waitUntilDone to var jsTestIsAsync = true
and idb-specific done() to finishJSTest();
Following the uniform style results in less overall code and makes
them easier to convert to worker layout tests.
Reviewed by Tony Chang.
- storage/indexeddb/constants.html:
- storage/indexeddb/create-and-remove-object-store.html:
- storage/indexeddb/create-object-store-options.html:
- storage/indexeddb/createObjectStore-name-argument-required.html:
- storage/indexeddb/createObjectStore-null-name.html:
- storage/indexeddb/cursor-continue.html:
- storage/indexeddb/cursor-delete.html:
- storage/indexeddb/cursor-inconsistency.html:
- storage/indexeddb/cursor-index-delete.html:
- storage/indexeddb/cursor-key-order.html:
- storage/indexeddb/cursor-primary-key-order.html:
- storage/indexeddb/cursor-reverse-bug.html:
- storage/indexeddb/cursor-skip-deleted.html:
- storage/indexeddb/cursor-update-value-argument-required.html:
- storage/indexeddb/cursor-update.html:
- storage/indexeddb/data-corruption.html:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/database-name-undefined.html:
- storage/indexeddb/database-odd-names.html:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/delete-closed-database-object.html:
- storage/indexeddb/delete-range.html:
- storage/indexeddb/deleteIndex.html:
- storage/indexeddb/deleteObjectStore-name-argument-required.html:
- storage/indexeddb/deleteObjectStore-null-name.html:
- storage/indexeddb/duplicates.html:
- storage/indexeddb/error-causes-abort-by-default.html:
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/indexeddb/exception-in-event-aborts.html:
- storage/indexeddb/factory-basics.html:
- storage/indexeddb/factory-cmp.html:
- storage/indexeddb/factory-deletedatabase-interactions.html:
- storage/indexeddb/factory-deletedatabase.html:
- storage/indexeddb/index-count.html:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/index-get-key-argument-required.html:
- storage/indexeddb/index-multientry.html:
- storage/indexeddb/index-unique.html:
- storage/indexeddb/invalid-keys.html:
- storage/indexeddb/key-generator.html:
- storage/indexeddb/key-sort-order-across-types.html:
- storage/indexeddb/key-sort-order-date.html:
- storage/indexeddb/key-type-array.html:
- storage/indexeddb/key-type-infinity.html:
- storage/indexeddb/keypath-basics.html:
- storage/indexeddb/keypath-edges.html:
- storage/indexeddb/keypath-fetch-key.html:
- storage/indexeddb/keyrange-required-arguments.html:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/list-ordering.html:
- storage/indexeddb/mozilla/add-twice-failure.html:
- storage/indexeddb/mozilla/autoincrement-indexes.html:
- storage/indexeddb/mozilla/bad-keypath.html:
- storage/indexeddb/mozilla/clear.html:
- storage/indexeddb/mozilla/create-index-unique.html:
- storage/indexeddb/mozilla/create-index-with-integer-keys.html:
- storage/indexeddb/mozilla/create-objectstore-basics.html:
- storage/indexeddb/mozilla/create-objectstore-null-name.html:
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
- storage/indexeddb/mozilla/cursor-mutation.html:
- storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
- storage/indexeddb/mozilla/cursors.html:
- storage/indexeddb/mozilla/delete-result.html:
- storage/indexeddb/mozilla/event-source.html:
- storage/indexeddb/mozilla/global-data.html:
- storage/indexeddb/mozilla/indexes.html:
- storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
- storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
- storage/indexeddb/mozilla/key-requirements-put-no-key.html:
- storage/indexeddb/mozilla/key-requirements-put-null-key.html:
- storage/indexeddb/mozilla/key-requirements.html:
- storage/indexeddb/mozilla/object-cursors.html:
- storage/indexeddb/mozilla/object-identity.html:
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
- storage/indexeddb/mozilla/object-store-remove-values.html:
- storage/indexeddb/mozilla/objectstorenames.html:
- storage/indexeddb/mozilla/odd-result-order.html:
- storage/indexeddb/mozilla/open-database-null-name.html:
- storage/indexeddb/mozilla/put-get-values.html:
- storage/indexeddb/mozilla/readonly-transactions.html:
- storage/indexeddb/mozilla/readwrite-transactions.html:
- storage/indexeddb/mozilla/readyState.html:
- storage/indexeddb/mozilla/remove-index.html:
- storage/indexeddb/mozilla/remove-objectstore.html:
- storage/indexeddb/mozilla/versionchange-abort.html:
- storage/indexeddb/mozilla/versionchange.html:
- storage/indexeddb/mutating-cursor.html:
- storage/indexeddb/objectStore-required-arguments.html:
- storage/indexeddb/objectstore-autoincrement.html:
- storage/indexeddb/objectstore-clear.html:
- storage/indexeddb/objectstore-count.html:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/odd-strings.html:
- storage/indexeddb/open-close-version.html:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/open-during-transaction.html:
- storage/indexeddb/queued-commands.html:
- storage/indexeddb/readonly-properties.html:
- storage/indexeddb/readonly.html:
- storage/indexeddb/request-event-propagation.html:
- storage/indexeddb/resources/shared.js:
(unexpectedSuccessCallback):
(unexpectedErrorCallback):
(unexpectedAbortCallback):
(unexpectedCompleteCallback):
(unexpectedBlockedCallback):
- storage/indexeddb/setVersion-null.html:
- storage/indexeddb/setVersion-undefined.html:
- storage/indexeddb/set_version_blocked.html:
- storage/indexeddb/set_version_queue.html:
- storage/indexeddb/structured-clone.html:
- storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
- storage/indexeddb/transaction-abort-with-js-recursion.html:
- storage/indexeddb/transaction-abort.html:
- storage/indexeddb/transaction-after-close.html:
- storage/indexeddb/transaction-and-objectstore-calls.html:
- storage/indexeddb/transaction-crash-on-abort.html:
- storage/indexeddb/transaction-event-propagation.html:
- storage/indexeddb/transaction-read-only.html:
- storage/indexeddb/transaction-rollback.html:
- storage/indexeddb/transaction-storeNames-required.html:
- storage/indexeddb/two-version-changes.html:
- storage/indexeddb/value-undefined.html:
- storage/indexeddb/values-odd-types.html:
- storage/indexeddb/version-change-abort-expected.txt:
- storage/indexeddb/version-change-abort.html:
- storage/indexeddb/version-change-exclusive.html:
- storage/indexeddb/versionchangerequest-activedomobject.html:
- 1:25 PM WebKitGTK/1.8.x edited by
- (diff)
- 1:24 PM Changeset in webkit [110467] by
-
- 5 edits in branches/chromium/1025/Source
Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.
Source/WebCore:
We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.
Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.
New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9697001
- 1:21 PM Changeset in webkit [110466] by
-
- 4 edits in trunk/LayoutTests
Mac rebaseline.
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- 1:11 PM WebKitGTK/1.8.x edited by
- (diff)
- 1:11 PM Changeset in webkit [110465] by
-
- 4 edits5 adds in trunk
[MutationObservers] Enforce a consistent order of MutationRecord delivery
https://bugs.webkit.org/show_bug.cgi?id=80549
Reviewed by Ojan Vafai.
Source/WebCore:
Mutations should be delivered in order of creation.
Tests: fast/mutation/create-during-delivery.html
fast/mutation/delivery-order.html
fast/mutation/mutate-during-delivery.html
- dom/WebKitMutationObserver.cpp:
(WebCore):
(WebCore::WebKitMutationObserver::ObserverLessThan::operator()): Functor for use with std::sort.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::deliverAllMutations): Move observers into a sorted vector before delivery.
- dom/WebKitMutationObserver.h: Add a "priority" member which monotonically increases with each construction.
LayoutTests:
- fast/mutation/create-during-delivery-expected.txt: Added.
- fast/mutation/create-during-delivery.html: Added.
- fast/mutation/delivery-order.html: Added.
- fast/mutation/mutate-during-delivery-expected.txt: Added.
- fast/mutation/mutate-during-delivery.html: Added.
- 1:08 PM Changeset in webkit [110464] by
-
- 13 edits in trunk/Source
[Chromium] Force compositeAndReadback through regular scheduling flow
https://bugs.webkit.org/show_bug.cgi?id=77049
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::onTimerTick):
- platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateControllerClient):
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setNeedsForcedCommit):
(WebCore):
(WebCore::CCScheduler::vsyncTick):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedCommit):
(WebCore):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(CCSchedulerStateMachine):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):
Source/WebKit/chromium:
- tests/CCFrameRateControllerTest.cpp:
(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
(FakeCCFrameRateControllerClient):
(WebKitTests::TEST):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
(WTF::TEST_F):
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::StateMachine::setNeedsForcedCommit):
(WebCore::StateMachine::needsForcedCommit):
(StateMachine):
(WebCore::TEST):
(WebCore):
- 12:57 PM Changeset in webkit [110463] by
-
- 7 edits1 add in trunk/Source
IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413
Source/WebCore:
Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.
Reviewed by Tony Chang.
Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'
- Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.
(WebCore::IDBLevelDBBackingStore::open):
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::destroy):
(WebCore):
- platform/leveldb/LevelDBDatabase.h:
(LevelDBDatabase):
Source/WebKit/chromium:
Reviewed by Tony Chang.
- WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
- WebKit.gypi: Add LevelDBTest.cpp
- tests/LevelDBTest.cpp: Added.
(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):
- 12:55 PM Changeset in webkit [110462] by
-
- 2 edits2 copies in branches/chromium/1025
Merge 110332
BUG=114056
Review URL: https://chromiumcodereview.appspot.com/9689022
- 12:52 PM Changeset in webkit [110461] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 110324
BUG=116746
Review URL: https://chromiumcodereview.appspot.com/9693006
- 12:50 PM Changeset in webkit [110460] by
-
- 2 edits in trunk/Tools
[Chromium] Temporary build-fix for the Android bot
https://bugs.webkit.org/show_bug.cgi?id=80862
Reviewed by Adam Barth.
Manually set the environmental variables required to compile source
files through the Android NDK instead of relying on the envsetup.sh
script. A proper fix will be landed to Chromium ASAP, and following
a Chromium roll into WebKit this code will be removed.
- Scripts/webkitdirs.pm:
(buildChromiumMakefile):
- 12:47 PM Changeset in webkit [110459] by
-
- 8 edits2 copies in branches/chromium/1025
Merge 110323
BUG=113902
Review URL: https://chromiumcodereview.appspot.com/9695005
- 12:44 PM Changeset in webkit [110458] by
-
- 2 edits in trunk/Tools
[Qt] Use right construct to detect config_test_gccdepends
Reviewed by Andreas Kling.
- 12:44 PM Changeset in webkit [110457] by
-
- 2 edits in trunk/Tools
[Qt] Expose location of WebKit's bin and imports dir through module file
Reviewed by Andreas Kling.
- 12:24 PM Changeset in webkit [110456] by
-
- 4 edits in trunk
Fix regression on fast/table/table-row-compositing-repaint-crash.html
https://bugs.webkit.org/show_bug.cgi?id=80804
Reviewed by Simon Fraser.
Covered by existing tests.
http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
- 12:20 PM Changeset in webkit [110455] by
-
- 5 edits in trunk
CSS3 calc: enable mixed percent/absolute for font
https://bugs.webkit.org/show_bug.cgi?id=80813
Reviewed by Ojan Vafai.
Source/WebCore:
Add support for mixed percent/absolute expressions to the font handling class.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):
LayoutTests:
- css3/calc/font-expected.txt:
- css3/calc/font-size-expected.txt:
- 12:19 PM Changeset in webkit [110454] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 110326
BUG=116461
Review URL: https://chromiumcodereview.appspot.com/9677005
- 12:18 PM Changeset in webkit [110453] by
-
- 5 edits in trunk/Source/JavaScriptCore
Minor DataLog fixes
https://bugs.webkit.org/show_bug.cgi?id=80826
Reviewed by Andreas Kling.
- bytecode/ExecutionCounter.cpp:
Do not include DataLog.h, it is not used.
- jit/ExecutableAllocator.cpp:
Ditto.
- wtf/DataLog.cpp:
(WTF::initializeLogFileOnce):
Add missing semi-colon to the code path where DATA_LOG_FILENAME is defined.
- wtf/HashTable.cpp:
Include DataLog as it is used.
- 12:00 PM Changeset in webkit [110452] by
-
- 2 edits2 copies in branches/chromium/1025
Merge 108084
BUG=112411
Review URL: https://chromiumcodereview.appspot.com/9694004
- 11:58 AM Changeset in webkit [110451] by
-
- 2 edits in trunk/LayoutTests
update expectations in preparation for bitmap-sampling fix in skia
https://bugs.webkit.org/show_bug.cgi?id=80837
Unreviewed
- platform/chromium/test_expectations.txt:
- 11:51 AM Changeset in webkit [110450] by
-
- 4 edits in trunk/Source/WebCore
Restore Attr::style() functionality.
<http://webkit.org/b/80678>
<rdar://problem/10933904>
Reviewed by Antti Koivisto.
The neutering of Attr::style() in r106740 broke some internal clients of the Obj-C API,
so this was definitely premature.
Since we no longer have a per-Attribute style object, synthesize one in style() and
hang it off of the Attr. This grows Attr by one pointer, but it's a low-volume object
so it shouldn't matter much.
We recreate the StylePropertySet object on every call to style(), to avoid complicating
things with custom invalidation code.
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Attr.h:
- dom/StyledElement.h:
(WebCore::StyledElement::collectStyleForAttribute):
- 11:38 AM Changeset in webkit [110449] by
-
- 8 edits2 adds in trunk
REGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=80578
Reviewed by Andreas Kling.
Source/WebCore:
Test: svg/css/style-change-crash.html
- dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
LayoutTests:
- fast/regions/select-in-region-crash-expected.txt: Rebaselined.
- svg/css/style-change-crash-expected.txt: Added.
- svg/css/style-change-crash.html: Added.
- 11:28 AM Changeset in webkit [110448] by
-
- 8 edits2 adds in trunk
Touch event handler count is not updated when adding handlers to the window.
https://bugs.webkit.org/show_bug.cgi?id=80756
Source/WebCore:
Touch event handlers added to the window needs to be included when counting the number of touch event
handlers. This makes touch event handler counting identical to wheel event handler counting.
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.
Test: fast/events/touch/touch-handler-count.html
- dom/EventNames.h:
(EventNames):
(WebCore::EventNames::isTouchEventType):
- dom/Node.cpp:
(WebCore):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
- testing/Internals.cpp:
(WebCore::Internals::touchEventHandlerCount):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.
The new layout tests add and remove touch event handlers on the window, document, and a div in the
document, and tests that the count is updated correctly when handlers are added and/or removed.
- fast/events/touch/touch-handler-count-expected.txt: Added.
- fast/events/touch/touch-handler-count.html: Added.
- 11:02 AM Changeset in webkit [110447] by
-
- 6 edits1 add in trunk
[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=80832
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
Since the ScrollDecorator QML component requires a Flickable in its API
we need to expose the Flickable in QML for now and we also need to add
a notifier because we instantiate the internal Flickable only when the
WebView component completes construction.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewExperimental::flickable):
- UIProcess/API/qt/qquickwebview_p.h:
Tools:
Add a basic scroll indicator component to MiniBrowser so that it
behaves similar to the ScrollDecorator QML component.
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/qml/BrowserWindow.qml:
- MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
- 10:50 AM Changeset in webkit [110446] by
-
- 2 edits in trunk/Tools
[GTK] r110296 included an extra $ in @$(AM_V_GEN)
https://bugs.webkit.org/show_bug.cgi?id=80809
Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Philippe Normand.
- GNUmakefile.am: Add
$to @(AM_V_GEN), else /bin/sh syntax error
- 10:43 AM Changeset in webkit [110445] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80834
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):
- 10:42 AM Changeset in webkit [110444] by
-
- 2 edits in trunk/LayoutTests
[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=75110
Reviewed by Ryosuke Niwa.
Remove expectation now that it's fixed.
- platform/chromium/test_expectations.txt:
- 10:31 AM Changeset in webkit [110443] by
-
- 2 edits in trunk/Source/JavaScriptCore
Integer overflow check code in arithmetic operation in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465
Patch by SangGyu Lee <sg5.lee@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- 10:17 AM Changeset in webkit [110442] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, unskip a media test in GTK.
- platform/gtk/Skipped: media/video-volume-slider.html was fixed
in r86535.
- platform/gtk/media/video-volume-slider-expected.txt:
- 10:14 AM Changeset in webkit [110441] by
-
- 4 edits2 adds in trunk
Web Inspector: recognize Float*Array and Int*Array as arrays.
https://bugs.webkit.org/show_bug.cgi?id=80850
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/console/console-external-array.html
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::type):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):
LayoutTests:
- inspector/console/console-external-array-expected.txt: Added.
- inspector/console/console-external-array.html: Added.
- 10:13 AM Changeset in webkit [110440] by
-
- 1 edit2 adds in trunk/LayoutTests
Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=80658
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Alexey Proskuryakov.
- fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt: Added.
- fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml: Added.
- 10:09 AM Changeset in webkit [110439] by
-
- 4 edits in trunk/Source/WebCore
[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.
https://bugs.webkit.org/show_bug.cgi?id=80848
Reviewed by Noam Rosenthal.
When rendering a transformed texture on the screen with a fractional
coordinate with linear filtering, the resulting pixel will be blended from
the texels around this fractional position according to their cover ratio.
This produces a slight blur of pixels which give no benefit when rendering
a texture that isn't scaled.
This patch offsets the transform by rounding the translation part of the
layer's transform to align the result to integer coordinates.
Applying the adjustment on the layer transform makes sure that all the tiles
get the same adjustment.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
- platform/graphics/texmap/TextureMapperGL.h:
(WebCore::BitmapTextureGL::textureSize):
- 10:08 AM Changeset in webkit [110438] by
-
- 6 edits in trunk/Source/WebCore
[TexMapGL] Use textures sized exactly to their contents.
https://bugs.webkit.org/show_bug.cgi?id=80845
Reviewed by Noam Rosenthal.
This fixes a regression introduced in r108273 as well as the bug it fixed.
The regressing behavior was that textures were rendered shrunk by 1 pixel
and thus would appear blurry on the screen.
The original problem was that garbage contents would appear on filtered
textures since we would reuse textures of different sizes by giving them
a slightly bigger size.
This patch will reuse the texture only if the size matches exactly to allow
edge clamping to work properly when redering with linear filtering.
Reusing textures would only saves us the allocation of graphic memory
anyway, which is negligeable compared to texture upload.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
- platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL):
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):
- platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgramOpacityAndMask):
- 10:06 AM Changeset in webkit [110437] by
-
- 5 edits in trunk/Source/WebCore
[TexMap] Remove BitmapTexture::destroy.
https://bugs.webkit.org/show_bug.cgi?id=80844
Reviewed by Noam Rosenthal.
Use the destructor directly instead.
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::~BitmapTextureGL):
- platform/graphics/texmap/TextureMapperGL.h:
(BitmapTextureGL):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(WebCore::BitmapTextureImageBuffer::~BitmapTextureImageBuffer):
- 9:50 AM WebKitGTK/1.8.x edited by
- (diff)
- 9:39 AM Changeset in webkit [110436] by
-
- 2 edits in trunk
[Qt] Make sure we set the right library version for Qt 4
r110272 accedentally pruned the variable that ensures this.
Reviewed by Simon Hausmann.
- 9:06 AM Changeset in webkit [110435] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, slight Skipped list reorganization and unskip a bunch
of inspector tests on GTK.
- platform/gtk/Skipped:
- 8:56 AM Changeset in webkit [110434] by
-
- 16 edits in trunk
Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.location):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):
LayoutTests:
- http/tests/inspector/compiler-source-mapping.html:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- http/tests/inspector/search/search-in-concatenated-script.html:
- http/tests/inspector/search/search-in-script.html:
- inspector/debugger/debugger-scripts.html:
- inspector/debugger/linkifier.html:
- inspector/debugger/raw-source-code.html:
- inspector/debugger/script-formatter.html:
- 8:50 AM Changeset in webkit [110433] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.
- tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
- 8:47 AM Changeset in webkit [110432] by
-
- 2 edits in trunk/Source/WebCore
[chromium] A couple early-outs for occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=80742
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.
Covered by existing tests.
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):
- 8:45 AM Changeset in webkit [110431] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
https://bugs.webkit.org/show_bug.cgi?id=80840
CoreFoundation/CFBase.h needs to be included to define the type CFTypeRef.
Reviewed by Tor Arne Vestbø.
- platform/mac/WebCoreObjCExtras.h:
- 8:34 AM Changeset in webkit [110430] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
https://bugs.webkit.org/show_bug.cgi?id=80827
Qt on Mac uses OS(DARWIN) as well, but we do not want to enable LLINT.
Reviewed by Simon Hausmann.
- wtf/Platform.h:
- 8:32 AM Changeset in webkit [110429] by
-
- 2 edits in trunk/Source/WebCore
Remove unused global static variable for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Alexey Proskuryakov.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
- 8:28 AM Changeset in webkit [110428] by
-
- 3 edits in trunk/Source/WebCore
Correct usage of NDEBUG to fix warnings on BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Alexey Proskuryakov.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::sendChangesToDatabase):
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::initiateCookieLimitCleanUp):
- 7:52 AM Changeset in webkit [110427] by
-
- 3 edits in trunk/Tools
[BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=80812
Patch by Ming Xie <mxie@rim.com> on 2012-03-12
Reviewed by Rob Buis.
- Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
- 7:43 AM Changeset in webkit [110426] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed prospective Qt/Mac build fix
- runtime/JSGlobalData.cpp: use #USE(CF) instead of PLATFORM(MAC) to determine
whether to include CoreFoundation headers, used for JIT configuration in JSGlobalData
constructor.
- 7:36 AM Changeset in webkit [110425] by
-
- 15 edits in trunk/Source/WebKit2
Update how the Web Inspector resources are loaded.
https://bugs.webkit.org/show_bug.cgi?id=80814
rdar://problem/10359959
Reviewed by John Sullivan.
- Shared/WebPreferencesStore.h:
(WebKit): Added InspectorUsesWebKitUserInterface.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Removed webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.
- Shared/WebProcessCreationParameters.h: Ditto.
(WebProcessCreationParameters): Ditto.
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetInspectorUsesWebKitUserInterface): Added.
(WKPreferencesGetInspectorUsesWebKitUserInterface): Added.
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess): Removed webInspectorLocalizedStringsPath.
- UIProcess/WebContext.h:
(WebContext): Ditto.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Use inspectorReallyUsesWebKitUserInterface
to determine if texture should be used.
(WebKit::WebInspectorProxy::inspectorPageURL): Choose the right path.
(WebKit::WebInspectorProxy::inspectorBaseURL): Ditto.
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::setInspectorUsesWebKitUserInterface): Added.
(WebKit::WebInspector::localizedStringsURL):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange): Call WebInspector::setInspectorUsesWebKitUserInterface.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Removed call to WebInspector::setLocalizedStringsPath.
- 7:33 AM Changeset in webkit [110424] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=80833
Unreviewed gardening.
- platform/qt/Skipped: Skip fast/table/table-row-compositing-repaint-crash.html to paint the bot green.
- 7:24 AM WebKit Team edited by
- (diff)
- 6:59 AM Changeset in webkit [110423] by
-
- 6 edits in trunk
Re-apply the patch after v8 roll to r11000.
Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Tests:
heap-shapshot.html
heap-shapshot-loader.html
- inspector/front-end/HeapSnapshot.js:
(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
LayoutTests:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
- 5:57 AM Changeset in webkit [110422] by
-
- 5 edits in trunk
[Qt] Fix build with newer Qt 5.
Reviewed by Tor Arne Vestbø.
Source/WebCore:
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::fileListNameForWidth): Use DefaultCodec instead of the
deprecated CodecForTR.
Tools:
Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
we should disable -Werror.
Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
implicit load was removed recently.
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/unix/default_post.prf:
- 5:31 AM Changeset in webkit [110421] by
-
- 3 edits in trunk/PerformanceTests
Web Inspector: chromium: increase heap snapshot performance coverage.
https://bugs.webkit.org/show_bug.cgi?id=80829
Reviewed by Yury Semikhatsky.
- inspector/detailed-heapshots-smoke-test.html:
- inspector/performance-test.js:
(initialize_TimeTracker.InspectorTest.measureFunction):
- 4:27 AM Changeset in webkit [110420] by
-
- 14 edits1 copy4 adds in trunk
Speech JavaScript API: SpeechRecognitionEvent
https://bugs.webkit.org/show_bug.cgi?id=80513
Reviewed by Adam Barth.
Source/WebCore:
Implement SpeechRecognitionEvent.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)
Test: fast/events/constructors/speech-recognition-event-constructor.html
- Modules/speech/DOMWindowSpeech.idl:
- Modules/speech/SpeechRecognitionEvent.cpp: Added.
(WebCore):
(WebCore::SpeechRecognitionEventInit::SpeechRecognitionEventInit):
(WebCore::SpeechRecognitionEvent::create):
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::createResultDeleted):
(WebCore::SpeechRecognitionEvent::createError):
(WebCore::SpeechRecognitionEvent::interfaceName):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
- Modules/speech/SpeechRecognitionEvent.h: Added.
(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::result):
(WebCore::SpeechRecognitionEvent::error):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::resultHistory):
- Modules/speech/SpeechRecognitionEvent.idl:
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):
- bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get):
(WebCore):
- bindings/v8/OptionsObject.h:
(WebCore):
(OptionsObject):
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
LayoutTests:
Add test for SpeechRecognitionEvent.
Update Skipped files for all ports except Chromium.
- fast/events/constructors/speech-recognition-event-constructor-expected.txt: Added.
- fast/events/constructors/speech-recognition-event-constructor.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 2:50 AM Changeset in webkit [110419] by
-
- 17 edits1 add in trunk/Source/JavaScriptCore
All DFG nodes should have a mutable set of flags
https://bugs.webkit.org/show_bug.cgi?id=80779
<rdar://problem/11026218>
Reviewed by Gavin Barraclough.
Got rid of NodeId, and placed all of the flags that distinguished NodeId
from NodeType into a separate Node::flags field. Combined what was previously
ArithNodeFlags into Node::flags.
In the process of debugging, I found that the debug support in the virtual
register allocator was lacking, so I improved it. I also realized that the
virtual register allocator was assuming that the nodes in a basic block were
contiguous, which is no longer the case. So I fixed that. The fix also made
it natural to have more extreme assertions, so I added them. I suspect this
will make it easier to catch virtual register allocation bugs in the future.
This is mostly performance neutral; if anything it looks like a slight
speed-up.
This patch does leave some work for future refactorings; for example, Node::op
is unencapsulated. This was already the case, though now it feels even more
like it should be. I avoided doing that because this patch has already grown
way bigger than I wanted.
Finally, this patch creates a DFGNode.cpp file and makes a slight effort to
move some unnecessarily inline stuff out of DFGNode.h.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArithNodeFlagsInferencePhase.cpp:
(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::opName):
(JSC::DFG::Graph::dump):
(DFG):
- dfg/DFGNode.cpp: Added.
(DFG):
(JSC::DFG::arithNodeFlagsAsString):
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::defaultFlags):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):
- dfg/DFGScoreBoard.h:
(ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::assertClear):
(JSC::DFG::ScoreBoard::use):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 2:19 AM Changeset in webkit [110418] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove flakiness flags for timeline-start-time.html following a fix in r100417.
https://bugs.webkit.org/show_bug.cgi?id=80803
- platform/chromium/test_expectations.txt:
- 2:02 AM Changeset in webkit [110417] by
-
- 2 edits in trunk/LayoutTests
Unreviewed flakiness fix.
- inspector/timeline/timeline-start-time.html:
- 1:59 AM Changeset in webkit [110416] by
-
- 15 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r110409. And skip a new GTK
layout test failing after r110371.
- platform/gtk/Skipped:
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/gtk/fast/layers/video-layer-expected.txt:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/media-controls-clone-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.txt:
- 1:52 AM Changeset in webkit [110415] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: Fix typos in fast/css/style-scoped/style-scoped-basic.html layout test.
- fast/css/style-scoped/style-scoped-basic.html:
- 1:38 AM Changeset in webkit [110414] by
-
- 3 edits in trunk/Source/WebCore
Use ICU C API instead of C++ API in LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=80815
https://bugs.gentoo.org/show_bug.cgi?id=407401
Reviewed by Hajime Morita.
ICU 4.8 doesn't have kNumberStyle. We had better to use ICU C API in
general to avoid such issues.
This patch should not make any behavior change.
- platform/text/LocalizedNumberICU.cpp:
(WebCore::ICULocale::ICULocale):
Change the argument type: icu::Locale -> const char*
(WebCore::ICULocale::~ICULocale): Delete m_numberFormat with unum_close().
(WebCore::ICULocale::create): Do not create icu::Locale.
(WebCore::ICULocale::createForCurrentLocale): ditto.
(WebCore::ICULocale::setDecimalSymbol):
Use unum_getSymbol() instead of DecimalFormatSymbols::getSymbol().
(WebCore::ICULocale::setDecimalTextAttribute):
Added. A utility function to store prefixes and suffixes.
(WebCore::ICULocale::initializeDecimalFormat):
- unum_open(), instead of NumberFormat::createInstance().
- Use C API symbols.
- Cache positive/negative prefixes/suffixes.
(WebCore::ICULocale::convertToLocalizedNumber): Use cached prefixes and suffixes.
(WebCore::matches): Stop using template because we don't use UString anymore.
(WebCore::ICULocale::detectSignAndGetDigitRange):
- Use cached prefixes and suffixes.
- Use String::startsWith() and endsWith().
(WebCore::ICULocale::convertFromLocalizedNumber):
- platform/text/LocalizedNumberICU.h:
(ICULocale):
- 1:32 AM Changeset in webkit [110413] by
-
- 8 edits in trunk
Web Inspector: decouple LiveLocation from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80785
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
- inspector/front-end/RawSourceCode.js:
- inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.init):
(WebInspector.LiveLocation.prototype.dispose):
(WebInspector.LiveLocation.prototype._update):
LayoutTests:
- inspector/debugger/callstack-placards-discarded-expected.txt:
- inspector/debugger/callstack-placards-discarded.html:
- inspector/debugger/linkifier.html:
- 12:14 AM Changeset in webkit [110412] by
-
- 2 edits in trunk/Source/WebKit2
Remove unnecessary call to NSSizeToCGSize().
https://bugs.webkit.org/show_bug.cgi?id=80817
Reviewed by Dan Bernstein.
There is no need to call NSSizeToCGSize() to convert an IntSize to a
CGSize. IntSize defines a conversion function to CGSize that will do
this for us implicitly.
- UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::backingStoreContext): Do not call NSSizeToCGSize().
