Timeline



Mar 19, 2012:

11:49 PM Changeset in webkit [111367] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] New test introduced in r110532 fails on 32 bit.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
11:48 PM Changeset in webkit [111366] by jochen@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
​https://bugs.webkit.org/show_bug.cgi?id=80983

Reviewed by Darin Adler.

This allows printing a backtrace acquired by an earlier WTFGetBacktrace
call which is useful for local debugging.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
11:43 PM Changeset in webkit [111365] by keishi@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

[chromium] Rebaselining nested-fragment-parser-crash.html again.

  • platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
11:37 PM Changeset in webkit [111364] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Build fix for Debug build after r111358

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-19

  • bindings/js/CachedScriptSourceProvider.h:
  • bindings/js/StringSourceProvider.h:
11:35 PM Changeset in webkit [111363] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

fast/table/max-width-integer-overflow.html should be skipped because it gives
different results on 32- and 64-bit systems.

Patch by János Badics <János Badics> on 2012-03-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
11:17 PM Changeset in webkit [111362] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Add FractionalLayoutUnit version of blend to AnimationUtilities
​https://bugs.webkit.org/show_bug.cgi?id=81572

Reviewed by Eric Seidel.

Add version of blend method that operates on FractionalLayoutUnits. This
will be used in place of the integer version in many places once we
enable support for subpixel layout.

No new tests.

  • platform/FractionalLayoutUnit.h:

Include math.h to make GTK build happy.

  • platform/animation/AnimationUtilities.h:

(WebCore::blend):

10:58 PM Changeset in webkit [111361] by abarth@webkit.org
  • 46 edits
    2 adds
    25 deletes in trunk

Remove support for "magic" iframe
​https://bugs.webkit.org/show_bug.cgi?id=81590

Reviewed by Eric Seidel.

Source/WebCore:

This patch removes support for "magic" iframe, which previously allowed
an iframe to be transfered from one document to another without
reloading the iframe. The idea behind this feature was to let sites
create "pop out" windows that could outlive their parents by
transfering state to these windows via these magic iframes.

Unforuntately, this feature was never implemented by other browsers and
has been the source of a series of security vulnerabilities. Although
we have fixed each vulnerability as it has been discovered, the feature
is still a complex corner case that isn't widely exercised on the web.
For that reason, it's likely to have more vulnerabilities in the
future.

I'm not aware of any web sites that use this feature anymore. There
were a handful of them, but we appear to have been successful in
evangalizing them to move away from "magic" iframe.

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

  • html/HTMLFrameElementBase.cpp:

(WebCore):
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

  • loader/DocumentLoader.cpp:

(WebCore):

  • loader/DocumentLoader.h:

(DocumentLoader):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::createFrame):

  • loader/FrameLoader.cpp:

(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • loader/ResourceLoadNotifier.cpp:

(WebCore):

  • loader/ResourceLoadNotifier.h:

(ResourceLoadNotifier):

  • page/Frame.cpp:

(WebCore):

  • page/Frame.h:

(Frame):

Source/WebKit/blackberry:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::didDetectXSS):

Source/WebKit/chromium:

Remove FrameLoaderClient methods that no longer exist.

  • public/WebFrameClient.h:

(WebFrameClient):

  • src/FrameLoaderClientImpl.cpp:

(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/qt:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit/wince:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

Remove FrameLoaderClient methods that no longer exist.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

Remove FrameLoaderClient methods that no longer exist.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

Remove tests of magic iframe. These tests don't reall make sense to
keep without the feature.

  • fast/frames/adopt-iframe-into-itself-expected.txt: Added.
  • fast/frames/adopt-iframe-into-itself.html: Added.
    • I've added a test about adopting an iframe into itself. We might already have a test for this, but it covers a mistake I made in an earlier iteration of this patch.
  • fast/frames/iframe-reparenting-adopt-node-expected.txt: Removed.
  • fast/frames/iframe-reparenting-adopt-node.html: Removed.
  • fast/frames/iframe-reparenting-embed-elements-expected.txt: Removed.
  • fast/frames/iframe-reparenting-embed-elements.html: Removed.
  • fast/frames/iframe-reparenting-expected.txt: Removed.
  • fast/frames/iframe-reparenting-fail-load-expected.txt: Removed.
  • fast/frames/iframe-reparenting-fail-load.html: Removed.
  • fast/frames/iframe-reparenting-new-page-expected.txt: Removed.
  • fast/frames/iframe-reparenting-new-page.html: Removed.
  • fast/frames/iframe-reparenting-plugins-expected.txt: Removed.
  • fast/frames/iframe-reparenting-plugins.html: Removed.
  • fast/frames/iframe-reparenting.html: Removed.
  • fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Removed.
  • fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Removed.
  • fast/frames/resources/iframe-reparenting-embed-frame1.html: Removed.
  • fast/frames/resources/iframe-reparenting-embed-iframe.html: Removed.
  • fast/frames/resources/iframe-reparenting-frame1.html: Removed.
  • fast/frames/resources/iframe-reparenting-frame2.html: Removed.
  • fast/frames/resources/iframe-reparenting-iframe-content.html: Removed.
  • fast/frames/resources/iframe-reparenting-new-page-1.html: Removed.
  • fast/frames/resources/iframe-reparenting-new-page-2.html: Removed.
  • fast/frames/resources/iframe-reparenting-new-page-iframe.html: Removed.
  • fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Removed.
  • fast/frames/resources/iframe-reparenting-plugins-new-page.html: Removed.
  • fast/frames/script-tests/iframe-reparenting-new-page.js: Removed.
10:37 PM Changeset in webkit [111360] by jchaffraix@webkit.org
  • 3 edits
    5 adds in trunk

REGRESSION(r110072): Improper repainting on table with overflow: hidden
​https://bugs.webkit.org/show_bug.cgi?id=81460

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/repaint/table-hover-on-link.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout): Add a call to RenderBlock::updateCachedSizeForOverflowClip
so that we properly keep our cached size up to date. This fixes the problem for now but the
real solution is to make sure it is called on all classes that needs to. This is tracked by
bug 81461.

LayoutTests:

  • fast/repaint/table-hover-on-link-expected.txt: Added.
  • fast/repaint/table-hover-on-link.html: Added.
  • platform/chromium-linux/fast/repaint/table-hover-on-link-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-hover-on-link-expected.png: Added.
  • platform/mac/fast/repaint/table-hover-on-link-expected.png: Added.

There seem to be some small color difference here (maybe color profile related).

10:29 PM Changeset in webkit [111359] by commit-queue@webkit.org
  • 5 edits
    8 adds in trunk

Add support for crossorigin attribute in script elements
​https://bugs.webkit.org/show_bug.cgi?id=81438

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-03-19
Reviewed by Adam Barth.

Source/WebCore:

Works similarly to img and its crossorigin attribute. In the future it
could allow for things like showing full error messages in error
handlers, etc.

Tests: http/tests/security/script-crossorigin-loads-correctly.html

http/tests/security/script-crossorigin-loads-same-origin.html
http/tests/security/script-with-failed-cors-check-fails-to-load.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:

(ScriptElement):

  • html/HTMLScriptElement.idl:

LayoutTests:

  • http/tests/security/resources/alert-fail.js: Added.
  • http/tests/security/resources/cors-script.php: Added.
  • http/tests/security/script-crossorigin-loads-correctly-expected.txt: Added.
  • http/tests/security/script-crossorigin-loads-correctly.html: Added.
  • http/tests/security/script-crossorigin-loads-same-origin-expected.txt: Added.
  • http/tests/security/script-crossorigin-loads-same-origin.html: Added.
  • http/tests/security/script-with-failed-cors-check-fails-to-load-expected.txt: Added.
  • http/tests/security/script-with-failed-cors-check-fails-to-load.html: Added.
10:24 PM Changeset in webkit [111358] by benjamin@webkit.org
  • 6 edits in trunk/Source

Do not copy the script source in the SourceProvider, just reference the existing string
​https://bugs.webkit.org/show_bug.cgi?id=81466

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • parser/SourceCode.h: Remove the unused, and incorrect, function data().
  • parser/SourceProvider.h: Add OVERRIDE for clarity.

Source/WebCore:

Instead of creating a copy of the string with 16bits characters, we just return
a shared StringImpl.

  • bindings/js/CachedScriptSourceProvider.h:
  • bindings/js/StringSourceProvider.h:
10:21 PM Changeset in webkit [111357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

A quick early-out for Region::contains() test
​https://bugs.webkit.org/show_bug.cgi?id=81625

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-19
Reviewed by Anders Carlsson.

If the bounds of region B include a row/column that is outside the bounds of
region A, then region B contains a pixel within that row/column that is
outside of region A.

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):

10:20 PM Changeset in webkit [111356] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix the EFL build.

  • platform/graphics/efl/IconEfl.cpp:
10:15 PM Changeset in webkit [111355] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Division optimizations fail to infer cases of truncated division and
mishandle -2147483648/-1
​https://bugs.webkit.org/show_bug.cgi?id=81428
<rdar://problem/11067382>

Reviewed by Oliver Hunt.

If you're a division over integers and you're only used as an integer, then you're
an integer division and remainder checks become unnecessary. If you're dividing
-2147483648 by -1, don't crash.

  • assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::add32):

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • llint/LowLevelInterpreter64.asm:
10:04 PM Changeset in webkit [111354] by eric@webkit.org
  • 36 edits in trunk/Source/WebCore

Fix more WTF header include paths in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=81602

Reviewed by Martin Robinson.

Chromium, Mac and Win already build w/o including wtf subdirectories
in their include paths for WebCore/WebKit. Gtk, Qt, and other ports
should eventually do the same. This patch fixes up a few loose
wtf includes in these ports using some search/replace across WebCore.
If the EWS bots pass this patch doesn't really need any other review.

  • accessibility/gtk/AXObjectCacheAtk.cpp:
  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
  • platform/KURL.cpp:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
  • platform/audio/gtk/AudioBusGtk.cpp:
  • platform/clutter/GRefPtrClutter.h:
  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/ImageBufferGtk.cpp:
  • platform/graphics/pango/FontPango.cpp:
  • platform/graphics/qt/ImageBufferDataQt.h:
  • platform/graphics/wx/ImageBufferDataWx.h:
  • platform/gtk/ContextMenuGtk.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/GOwnPtrGtk.h:
  • platform/gtk/GtkAuthenticationDialog.h:
  • platform/gtk/GtkPopupMenu.cpp:
  • platform/gtk/LanguageGtk.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/gtk/PopupMenuGtk.cpp:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • platform/network/soup/GOwnPtrSoup.h:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/ResourceResponseSoup.cpp:
  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SoupURIUtils.cpp:
  • platform/text/TextEncoding.cpp:
  • platform/text/gtk/TextBreakIteratorGtk.cpp:
  • platform/text/gtk/TextCodecGtk.cpp:
  • platform/text/gtk/TextCodecGtk.h:
9:53 PM Changeset in webkit [111353] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

Move the extra logical height distribution into RenderTable as a new step in our layout algorithm
​https://bugs.webkit.org/show_bug.cgi?id=81548

Reviewed by Tony Chang.

Refactoring, no expected change in behavior.

Moving the distribution step into RenderTable is needed to implement a better distribution algorithm that would
span several RenderTableSection (which is what IE and FF are doing right now).

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::distributeExtraLogicalHeight):
(WebCore::RenderTable::layout):
Moved the distribution step into distributeExtraLogicalHeight. While at it, changed the code to make use of the helper
methods to iterate over the sections and explicitly floor the LayoutUnit before calling distributeExtraLogicalHeight.

  • rendering/RenderTable.h:

Added distributeExtraLogicalHeight.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Changed the method signature as it doesn't handle the distribution step anymore.

  • rendering/RenderTableSection.h:

Updated layoutRows signature and exposed distributeExtraLogicalHeightToRows for RenderTable use.

9:50 PM Changeset in webkit [111352] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another attempt at fixing the Windows build.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerDeviceScaleFactor):

9:48 PM Changeset in webkit [111351] by andersca@apple.com
  • 2 edits
    1 move
    9 deletes in trunk/LayoutTests

plugins/application-plugin-plugins-disabled.html should be a Qt specific test
​https://bugs.webkit.org/show_bug.cgi?id=81628

Reviewed by Jessie Berlin.

This test tests an "application specific plug-in" feature that only Qt has so this should be
a Qt specific test.

  • platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-mac-leopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
  • platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
  • platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/mac/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
  • platform/qt/plugins/application-plugin-plugins-disabled.html: Renamed from LayoutTests/plugins/application-plugin-plugins-disabled.html.
  • platform/wk2/Skipped:
9:47 PM Changeset in webkit [111350] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add registerURLSchemeAsEmptyDocument to WebSecurityPolicy
​https://bugs.webkit.org/show_bug.cgi?id=81421

Patch by Charlie Reis <​creis@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

  • public/WebSecurityPolicy.h:

(WebSecurityPolicy):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsEmptyDocument):
(WebKit):

9:45 PM Changeset in webkit [111349] by keishi@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Rebaseline caused by r111334

  • platform/chromium-linux-x86/fast/repaint/canvas-putImageData-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/canvas-putImageData-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Added.
9:39 PM Changeset in webkit [111348] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build break because of PlatformString.h
​https://bugs.webkit.org/show_bug.cgi?id=81619

Unreviewed. Fix build break because of PlatformString.h.

  • platform/graphics/efl/IconEfl.cpp: Include PlatformString.h from text directory.
9:25 PM Changeset in webkit [111347] by eric@webkit.org
  • 8 edits in trunk/Source/WebCore

Fix CrWin build after r111258.
​https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.
I also fixed similarly incorrect wtf/ includes for other ports
(which aren't yet as strict as Chromium about wtf includes).

  • platform/blackberry/CookieManager.cpp:
  • platform/blackberry/CookieParser.cpp:
  • platform/blackberry/ParsedCookie.cpp:
  • platform/blackberry/SharedTimerBlackBerry.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp:
  • platform/graphics/texmap/TextureMapperAnimation.cpp:
  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):

9:04 PM Changeset in webkit [111346] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] Four http/tests/xmlhttprequest tests fail on mac-wk2
​https://bugs.webkit.org/show_bug.cgi?id=81627

Unreviewed; skip failing http/tests/xmlhttprequest tests on mac-wk2.

  • platform/mac-wk2/Skipped:
8:51 PM Changeset in webkit [111345] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.8

Update the NEWS and version for the WebKitGTK+ 1.7.92 release.

Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac:

Source/WebKit/gtk:

  • NEWS:
8:48 PM Changeset in webkit [111344] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix CrWin build after r111258.
​https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
  • platform/graphics/texmap/TextureMapperAnimation.h:
8:46 PM Changeset in webkit [111343] by jberlin@webkit.org
  • 5 edits in trunk/Tools

Unreviewed; roll out ​http://trac.webkit.org/changeset/111307 and ​http://trac.webkit.org/changeset/111293
because they broke running the layout tests on mac.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash):

8:32 PM Changeset in webkit [111342] by tony@chromium.org
  • 29 edits in trunk

add css parsing of flex-line-pack
​https://bugs.webkit.org/show_bug.cgi?id=81427

Reviewed by Ojan Vafai.

Source/WebCore:

Spec: ​http://dev.w3.org/csswg/css3-flexbox/#flex-line-pack

Updated tests in css3/flexbox/css-properties.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EFlexLinePack):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
8:27 PM Changeset in webkit [111341] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

​http://bugs.webkit.org/show_bug.cgi?id=81618

fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
parser test that times out waiting for notifyDone

Unreviewed.

Skip test that times out on the Lion WK1 bots.

  • platform/mac/Skipped:
8:22 PM Changeset in webkit [111340] by kov@webkit.org
  • 9 edits in trunk

[GTK] libWebCore.la has become too big for make
​https://bugs.webkit.org/show_bug.cgi?id=81582

Unreviewed build fix.

Source/WebCore:

  • GNUmakefile.am: build an intermediate library for modules, so that the list

of source files used to build WebCore can be split and not reach make's limits;
also try to force relinking libWebCore.la and libWebCoreModules.la when the
GNUmakefile.am or GNUmakefile.list.am change

Source/WebKit/gtk:

  • GNUmakefile.am: link-in the new libDerivedWebCore.la

Source/WebKit2:

  • GNUmakefile.am: link-in the new libWebCoreModules.la
8:17 PM Changeset in webkit [111339] by Stephanie Lewis
  • 3 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
8:14 PM Changeset in webkit [111338] by keishi@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fixing build. Adding missing virtual.

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

8:13 PM Changeset in webkit [111337] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] http/tests/websocket/tests/hixie76/frame-lengths.html times out on mac-wk2
​https://bugs.webkit.org/show_bug.cgi?id=81624

Unreviewed; skip timing out http/tests/websocket/tests/hixie76/frame-lengths.html on mac-wk2

  • platform/mac-wk2/Skipped:
8:12 PM Changeset in webkit [111336] by Stephanie Lewis
  • 1 edit
    1 add in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=81615
fast/parser/nested-fragment-parser-crash.html is failing on the lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
8:10 PM Changeset in webkit [111335] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Push culled tiles that are prepainted
​https://bugs.webkit.org/show_bug.cgi?id=81552

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

If a tile was culled during paint, but then prepainted in the following
idle paint pass, it was still marked as culled (and thus dirty) and not
pushed to the impl side.

Renames tile->m_updateCulled to tile->m_updated. This value is true if
the tile is updated any time during a commit, and remains false if it
is culled every time the layer is painted.

Unit test: TiledLayerChromiumTest.pushIdlePaintedOccludedTiles

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

8:09 PM Changeset in webkit [111334] by Stephanie Lewis
  • 3 edits
    1 add in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
8:08 PM Changeset in webkit [111333] by keishi@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Rebaselining float-in-float-hit-testing and 056 in response
to r111281.

  • platform/chromium-mac/fast/block/float/float-in-float-hit-testing-expected.txt: Added.
  • platform/chromium-mac/fast/block/margin-collapse/056-expected.txt: Added.
8:05 PM Changeset in webkit [111332] by jberlin@webkit.org
  • 18 edits
    4 adds in trunk/LayoutTests

A bunch of media tests failing on Lion Intel Debug WebKit1 and WebKit2 testers.
​https://bugs.webkit.org/show_bug.cgi?id=81623

Rebaseline failing mac and mac-wk2 media tests.

  • platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Added.
  • platform/mac-wk2/media/video-playing-and-pause-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-layout-direction-expected.png:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/video-colorspace-yuv420-expected.png: Added.
  • platform/mac/media/video-colorspace-yuv422-expected.png: Added.
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.png:
  • platform/mac/media/video-playing-and-pause-expected.txt:
  • platform/mac/media/video-size-intrinsic-scale-expected.txt: Added.
8:02 PM Changeset in webkit [111331] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix Windows build.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerDeviceScaleFactor):

7:57 PM Changeset in webkit [111330] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Snow Leopard build.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

7:54 PM Changeset in webkit [111329] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium compile fix - put all TRACE_*s in their own scope explicitly.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

7:52 PM Changeset in webkit [111328] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html fails after r97360
​https://bugs.webkit.org/show_bug.cgi?id=70245

Unreviewed; skip failing http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html on mac-wk2.

  • platform/mac-wk2/Skipped:
7:48 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:47 PM Changeset in webkit [111327] by Martin Robinson
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merging r111316

7:47 PM Changeset in webkit [111326] by Stephanie Lewis
  • 4 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
7:47 PM Changeset in webkit [111325] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110866

7:46 PM Changeset in webkit [111324] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110847

7:46 PM Changeset in webkit [111323] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110845

7:45 PM Changeset in webkit [111322] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110062

7:45 PM Changeset in webkit [111321] by tony@chromium.org
  • 2 edits in trunk

clean up gitignore
​https://bugs.webkit.org/show_bug.cgi?id=81594

Reviewed by James Robinson.

  • .gitignore: .suo files are per-user files used by VS2010. .ninja

files are no longer generated in the tree-- they are generated in the
build directory.

7:45 PM Changeset in webkit [111320] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110060

7:44 PM Changeset in webkit [111319] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110059

7:44 PM Changeset in webkit [111318] by Stephanie Lewis
  • 3 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=81608 fast/multicol/span/span-as-immediate… fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
7:42 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:40 PM Changeset in webkit [111317] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] http/tests/navigation/https-in-page-cache.html times out on mac-wk2
​https://bugs.webkit.org/show_bug.cgi?id=81622

Unreviewed; skip failing http/tests/navigation/https-in-page-cache.html on mac-wk2.

  • platform/mac-wk2/Skipped:
7:34 PM Changeset in webkit [111316] by Martin Robinson
  • 5 edits in trunk

Source/WebKit/gtk: [GTK] Allow running run-gtk-tests during 'make dist'
​https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

  • GNUmakefile.am: Remove 'make check' rules from the makefile

Instead this functionality is now in the Tools makefile.

Tools: [GTK] Allow running run-gtk-tests during 'make distcheck'
​https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

Modify the build and run-gtk-tests so that it can run during 'make distcheck'

  • GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the

main command run during 'make check.'

  • Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer

a requirement to run it. If jhbuild isn't around it will simply not start the
SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
main loop and simply use the main loop in a synchronous method to start SPI
daemons. Did a bunch of general cleanup around these tasks.

7:30 PM Changeset in webkit [111315] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] http/tests/navigation/anchor-frames-gbk.html fails
​https://bugs.webkit.org/show_bug.cgi?id=76896
<rdar://problem/11078978>

Unreviewed; skip failing http/tests/navigation/anchor-frames-gbk.html on mac-wk2.

  • platform/mac-wk2/Skipped:
7:28 PM Changeset in webkit [111314] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] return true/false on GestureFlingCancel if a fling was stopped
​https://bugs.webkit.org/show_bug.cgi?id=81563

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

7:27 PM Changeset in webkit [111313] by kubo@profusion.mobi
  • 5 edits in trunk/Tools

jhbuild: Use the multiprocessing module to get the number of CPUs.
​https://bugs.webkit.org/show_bug.cgi?id=81585

Reviewed by Martin Robinson.

Now that support for Python 2.5 has been dropped, we can safely
use multiprocessing.cpu_count() to obtain the current number of
CPUs in the system instead of running a webkitperl script for
that.

  • efl/common.py:

(top_level_path):

  • efl/jhbuildrc:
  • gtk/common.py:

(build_path):

  • gtk/jhbuildrc:
7:25 PM Changeset in webkit [111312] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[chromium] Adding support for GL_EXT_discard_framebuffer.
​https://bugs.webkit.org/show_bug.cgi?id=81383

Patch by Michal Mocny <​mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::discardFramebufferEXT):
(WebKit::WebGraphicsContext3D::ensureFramebufferCHROMIUM):

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::discardFramebufferEXT):
(WebKit::FakeWebGraphicsContext3D::ensureFramebufferCHROMIUM):
(FakeWebGraphicsContext3D):

7:20 PM Changeset in webkit [111311] by ojan@chromium.org
  • 2 edits in trunk/Tools

We should only add a live event listener once, not once per TestSelector.
Adding one per TestSelector would cause accordion('option', 'active') to
incorrectly be "false" if you examine multiple sets of tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
7:19 PM Changeset in webkit [111310] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Refactor ContainerNode::replaceChild to match other mutation methods and share code
​https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Use collectTargetNodes rather than walking through DocumentFragment children.
Insert before rather than inserting after. Dispatch to other methods to update parent/sibling pointers.
(WebCore::ContainerNode::appendChild): Call appendChildToContainer to update parent/sibling pointers.
(WebCore::ContainerNode::parserAddChild): Use type inference in call to appendChildToContainer.

7:19 PM Changeset in webkit [111309] by timothy_horton@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

http/tests/misc/acid3.html fails on mac-lion-wk2
​https://bugs.webkit.org/show_bug.cgi?id=81621
<rdar://problem/11078942>

Unreviewed; check in failing results for mac-wk2.

  • platform/mac-wk2/http/tests/misc/acid3-expected.png: Added.
  • platform/mac-wk2/http/tests/misc/acid3-expected.txt: Added.
7:15 PM Changeset in webkit [111308] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[chromium] Times in the cc should be expressed in seconds.
​https://bugs.webkit.org/show_bug.cgi?id=80514

Patch by Ian Vollick <​vollick@chromium.org> on 2012-03-19
Reviewed by James Robinson.

Source/WebCore:

Updated timer tests to use seconds.

  • platform/TouchFlingPlatformGestureCurve.h:

(TouchFlingPlatformGestureCurve):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h:

(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::create):
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebCore):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(CCDelayBasedTimeSource):

  • platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurve):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):
(WebCore::CCThreadProxy::beginContextRecreation):
(WebCore::CCThreadProxy::tryToRecreateContext):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCTimer.cpp:

(WebCore::CCTimer::startOneShot):

  • platform/graphics/chromium/cc/CCTimer.h:

(CCTimer):

Source/WebKit/chromium:

  • tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCThread::pendingDelayMs):
(WebKitTests::FakeCCDelayBasedTimeSource::create):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(FakeCCDelayBasedTimeSource):

  • tests/CCTimerTest.cpp:

(WebKitTests::TEST_F):

7:10 PM Changeset in webkit [111307] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix typo introduced in r111293.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash):

7:09 PM Changeset in webkit [111306] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Simplify SmallStrings
​https://bugs.webkit.org/show_bug.cgi?id=81445

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-03-19
Reviewed by Gavin Barraclough.

SmallStrings had two methods that should not be public: count() and clear().

The method clear() is effectively replaced by finalizeSmallStrings(). The body
of the method was moved to the constructor since the code is obvious.

The method count() is unused.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):

  • runtime/SmallStrings.h:

(SmallStrings):

7:04 PM Changeset in webkit [111305] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] WebKitTestRunner needs to print frame load delegate information
​https://bugs.webkit.org/show_bug.cgi?id=42705

Skip http/tests/loading/state-object-security-exception.html until WKTR prints frame load delegate information.

  • platform/wk2/Skipped:
7:04 PM Changeset in webkit [111304] by Martin Robinson
  • 17 edits
    4 adds in releases/WebKitGTK/webkit-1.8

Merging r110999

7:01 PM Changeset in webkit [111303] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

fast/dom/Window/window-properties.html failing on Lion Intel Debug WebKit1 and WebKit2
testers.
​https://bugs.webkit.org/show_bug.cgi?id=81612

Update the expected (failing?) results to get the bots green.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
7:01 PM Changeset in webkit [111302] by jberlin@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

fast/harness/page-cache-crash-on-data-urls.html and fast/harness/use-page-cache.html fail on
Lion Intel Debug WebKit2 testers.
​https://bugs.webkit.org/show_bug.cgi?id=81616

Skip the flakey one and add expected failing results for the other.

  • platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Added.
  • platform/wk2/Skipped:
7:00 PM Changeset in webkit [111301] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merging r111110

6:52 PM Changeset in webkit [111300] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging 110762

6:51 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
6:45 PM Changeset in webkit [111299] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop messing with the AppKit grow box on platforms that don't support it
<rdar://problem/10752048>
​https://bugs.webkit.org/show_bug.cgi?id=81614

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
(-[WKView _didChangeScrollbarsForMainFrame]):
Snow Leopard was the last Mac OS to need a grow box.

6:45 PM Changeset in webkit [111298] by Martin Robinson
  • 6 edits
    2 deletes in releases/WebKitGTK/webkit-1.8

Merging r110478

6:41 PM Changeset in webkit [111297] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
​https://bugs.webkit.org/show_bug.cgi?id=81613

Unreviewed; skip http/tests/loading/progress-finished-callback.html on mac-wk2.

  • platform/mac-wk2/Skipped:
6:40 PM Changeset in webkit [111296] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r111027

6:37 PM Changeset in webkit [111295] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110446

6:35 PM Changeset in webkit [111294] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r110296

6:33 PM Changeset in webkit [111293] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: get ServerProcess out of the reportcrash business
​https://bugs.webkit.org/show_bug.cgi?id=81600

Reviewed by Adam Barth.

ServerProcess was half-aware that ReportCrash might run
sometimes, and that the process ServerProcess was talking to
might have its own crashing subprocesses; neither of these
things really worked right and it made the logic convoluted, so
this change makes handling crashes completely separate from the
server_process code, so that it can focus on just I/O to the
subprocess.

There should be no functional changes resulting from this patch.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):
(MockServerProcess):
(MockServerProcess.has_crashed):

6:29 PM Changeset in webkit [111292] by timothy_horton@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed new mac baselines for fast/css/font-family-pictograph and fast/css/pseudo-first-line-border-width.

  • platform/mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.txt:
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Added.
6:28 PM Changeset in webkit [111291] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: crashlog parsing is broken
​https://bugs.webkit.org/show_bug.cgi?id=81586

Reviewed by Adam Barth.

Seeking on a file opened through codecs() appears to not work
correctly (at least on SL).

The code was more complicated than it needed to be, so I have
revamped it to just read a full crashlog at once and then look
for matches.

I have also added the ability to optionally propagate
errors back (which can be helpful to debug races when ReportCrash is
still running and you need to see that you couldn't open some
files, rather than just ignoring them).

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):

6:28 PM Changeset in webkit [111290] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

fast/loader/window-properties-restored-from-page-cache.html timing out on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81609

Skip it to get the bots green.

  • platform/wk2/Skipped:
6:25 PM Changeset in webkit [111289] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: clean up some port._filesystem references to not reference private members
​https://bugs.webkit.org/show_bug.cgi?id=81595

Reviewed by Eric Seidel.

There should be no functional changes in this patch, just some
refactoring. Also, fixes a minor nit in write_image_diff_files(()

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._save_baseline_data):
(SingleTestRunner._handle_error):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):
(TestResultWriter.init):
(TestResultWriter._make_output_directory):
(TestResultWriter.output_filename):
(TestResultWriter._output_testname):
(TestResultWriter.write_output_files):
(TestResultWriter.write_stderr):
(TestResultWriter.write_crash_report):
(TestResultWriter.create_text_diff_and_write_result):
(TestResultWriter.write_image_diff_files):
(copy_file):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image):

6:22 PM Changeset in webkit [111288] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
​https://bugs.webkit.org/show_bug.cgi?id=81598

Reviewed by Eric Seidel.

"DumpRenderTree" shouldn't be hard-coded here, since some other
process may actually be crashing (WebKitTestRunner, WebProcess, etc.)

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

6:21 PM Changeset in webkit [111287] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: allow instance data in TestFailure objects
​https://bugs.webkit.org/show_bug.cgi?id=81580

Reviewed by Tony Chang.

Current TestFailures are basically enums, but it would be nice,
especially for crashes, if they contained the name and pid of
the process that crashed.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.message):
(FailureTimeout.message):
(FailureCrash):
(FailureCrash.init):
(FailureCrash.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):

  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_equals):
(TestFailuresTest):
(TestFailuresTest.test_crashes):

6:16 PM Changeset in webkit [111286] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

A bunch of jquery tests are timing out on the Lion Intel Debug WebKit2 testers.
​https://bugs.webkit.org/show_bug.cgi?id=81606

Skip them to get the bots green.

  • platform/wk2/Skipped:
6:13 PM Changeset in webkit [111285] by nduca@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

[chromium] Stop deriving WebCompositor from WebCompositorInputHandler
​https://bugs.webkit.org/show_bug.cgi?id=80586

Reviewed by Darin Fisher.

  • public/WebCompositor.h:

(WebKit):

  • public/WebCompositorInputHandler.h:

(WebCompositorInputHandler):

  • public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::didActivateCompositor):

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandler::fromIdentifier):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

6:06 PM Changeset in webkit [111284] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

A bunch of media tests time out on the Lion Intel Debug WebKit1 and WebKit2 testers.
​https://bugs.webkit.org/show_bug.cgi?id=81604

Skip them to get the bots green.

  • platform/mac/Skipped:
  • platform/wk2/Skipped:
6:02 PM Changeset in webkit [111283] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed new mac baseline for compositing/repaint/become-overlay-composited-layer.html.

  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png:
  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.txt:
5:53 PM Changeset in webkit [111282] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed skip of canvas/philip/tests/2d.path.arc.scale.1.html as an addition to ​http://trac.webkit.org/changeset/111278

  • platform/mac/Skipped:
5:47 PM Changeset in webkit [111281] by timothy_horton@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed mac baselines for some fast/block tests after ​http://trac.webkit.org/changeset/97596

  • platform/mac/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/mac/fast/block/margin-collapse/056-expected.txt:
5:40 PM Changeset in webkit [111280] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

A bunch of inspector tests time out on Lion Intel Debug WebKit2 testers.
​https://bugs.webkit.org/show_bug.cgi?id=81601

Skip them on WK2 to get the bots green.

  • platform/wk2/Skipped:
5:37 PM Changeset in webkit [111279] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Relative-height block SVG root not layed out on container height change
​https://bugs.webkit.org/show_bug.cgi?id=81513

Patch by Florin Malita <​fmalita@google.com> on 2012-03-19
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/custom/svg-percent-scale-block-expected.html

svg/custom/svg-percent-scale-block.html

A couple of places still have style()->logical{Min,Max,}Height percent checks,
which do not work for SVG elements. This patch adds a virtual hasRelativeLogicalHeight()
RenderBox method to replace the explicit style checks.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasRelativeLogicalHeight):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add virtual hasRelativeLogicalHeight().

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks, if possible.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::hasRelativeLogicalHeight):
(WebCore):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):
Add hasRelativeLogicalHeight() override.

LayoutTests:

  • svg/custom/svg-percent-scale-block-expected.html: Added.
  • svg/custom/svg-percent-scale-block.html: Added.
5:33 PM Changeset in webkit [111278] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Four fast/canvas tests are flaky (fail on bots, not locally, or vice versa)
​https://bugs.webkit.org/show_bug.cgi?id=81599
<rdar://problem/11078302>

Unreviewed skip of four flaky tests:

fast/canvas/canvas-createPattern-fillRect-shadow.html
fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
fast/canvas/canvas-fillRect-gradient-shadow.html
fast/canvas/set-colors.html

  • platform/mac/Skipped:
5:20 PM Changeset in webkit [111277] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Assertion failure in RenderBlock::addChildIgnoringAnonymousColumnBlocks when running fullscreen/full-screen-twice-crash.html
causing "crashes" on the Lion Intel Debug WebKit2 test bots.
​https://bugs.webkit.org/show_bug.cgi?id=81171

Reviewed by Dan Bernstein.

No new tests; fixes fullscreen/* tests when running in WebKitTestRunner (WebKit2).

Add a special-case check if the parent anonymous container is a full screen renderer or placeholder.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

5:12 PM Changeset in webkit [111276] by enrica@apple.com
  • 20 edits in trunk/Source

WebKit2: create sandbox extensions for files that are dropped in an input control.
​https://bugs.webkit.org/show_bug.cgi?id=81153
<rdar://problem/11031207>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

  • page/DragActions.h: Added new drag action to be used by the WebDragClient.
  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Added call to the drag client with the new action.

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action.
We want to avoid any unwanted side effects for the WebKit clients.

Source/WebKit2:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added template that takes 8 arguments.

  • Shared/SandboxExtension.h:

(HandleArray): Added new class to handle an array of sandbox extension handles.
(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

  • Shared/mac/SandboxExtensionMac.mm: Added new class implementation.

(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

  • UIProcess/API/mac/WKView.mm:

(createSandboxExtensionsForFileUpload):
(-[WKView performDragOperation:]): Added logic to create the sandbox extensions for each
file/directory being dropped.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction): Added the handle array parameter.

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleDropEvent):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::Drop):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::willPerformDragDestinationAction): Added handling of the new DragActionUpload.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType): Implemented using message to the UI process.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::performUploadDragDestinationAction): Added method that consumes the received extensions.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:08 PM Changeset in webkit [111275] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Chromium Win
​https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

  • platform/graphics/chromium/TransparencyWin.h:
5:02 PM Changeset in webkit [111274] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the chromium world.
​https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

  • rendering/RenderThemeChromiumSkia.cpp:
4:59 PM Changeset in webkit [111273] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG can no longer compile V8-v4/regexp in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=81592

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:59 PM Changeset in webkit [111272] by beidson@apple.com
  • 6 edits
    2 adds in trunk

<rdar://problem/10917120> and ​https://bugs.webkit.org/show_bug.cgi?id=81066
Crash in 3rd party WebKit apps under XHR/Cache code

Reviewed by Antti Koivisto.

Source/WebCore:

No new layout tests.
TestWebKitAPI test MemoryCachePruneWithinResourceLoadDelegate included

A CachedResource representing an XHR was being deleted by cache pruning during a delegate callback.
This worked until ​http://trac.webkit.org/changeset/98380

  • history/PageCache.cpp:

(WebCore::PageCache::releaseAutoreleasedPagesNow): Only trigger pruning after the page cache

autorelease if it was enabled before.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadResource): Disable pruning before loading the resource and

re-enable it afterwards if necessary.

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::pruneEnabled):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
  • TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.

(-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

4:46 PM Changeset in webkit [111271] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):

4:45 PM Changeset in webkit [111270] by jamesr@google.com
  • 10 edits in trunk/Source

[chromium] Implement fling-by-wheel on compositor thread
​https://bugs.webkit.org/show_bug.cgi?id=81462

Reviewed by Adrienne Walker.

Source/WebCore:

Adds compositor thread support for a fling type implemented as a sequence of wheel scrolls. Covered by new tests
in WebCompositorInputHandlerImplTests.

  • platform/graphics/chromium/cc/CCInputHandler.h:

(CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scheduleAnimation):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Implement fling-by-wheel and beef up existing unit test coverage considerably by using gmock instead of mocking
by hand.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • tests/WebCompositorInputHandlerImplTest.cpp:
4:36 PM Changeset in webkit [111269] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Prediction propagation for UInt32ToNumber incorrectly assumes that outs outcome does not
change throughout the fixpoint
​https://bugs.webkit.org/show_bug.cgi?id=81583

Reviewed by Michael Saboff.

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

4:33 PM Changeset in webkit [111268] by eae@chromium.org
  • 11 edits in trunk/Source

Source/WebCore: [mac/chromium] Change platform code to use pixelSnappedRect methods
​https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

Change platform code to use Node::getPixelSnappedRect,
pixelSnappedBoundingBoxRect and pixelSnappedAbsoluteClippedOverflowRect
to avoid exposing subpixel types to the platform layer.

No new tests.

  • WebCore.exp.in:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect):
Add pixelSnapped version of absoluteClippedOverflowRect

(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

Source/WebKit/chromium: [mac/chromium] Change platform code to use pixelSnappedRect methods
​https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/mac: [mac/chromium] Change platform code to use pixelSnappedRect methods
​https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView actualVisibleRectInWindow]):

  • WebView/WebFrame.mm:

(-[WebFrame _getVisibleRect:]):
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

  • WebView/WebView.mm:

(-[WebView _dashboardRegions]):
(-[WebView trackedRepaintRects]):

Source/WebKit/qt: [mac/qt/chromium] Change platform code to use pixelSnappedRect methods
​https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

  • Api/qwebelement.cpp:

(QWebElement::geometry):
(QWebElement::render):

4:20 PM Changeset in webkit [111267] by beidson@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/10848575> and ​https://bugs.webkit.org/show_bug.cgi?id=81516
REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format

Reviewed by Enrica Casucci.

Source/WebCore:

r107435 started saving/restoring URLs as strings.
We need to go back to setting the URL on the pasteboard using AppKit URL pasteboard APIs.

WebKit API test: ContextMenuCanCopyURL
No WebKit2 API test possible at this time.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setURL):

Tools:

Bring up a context menu on a link, copy the link, then verify the pasteboard contents
are in the correct format.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
  • TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.

(-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::contextMenuCopyLink):
(TestWebKitAPI::TEST):

4:14 PM PythonGuidelines edited by kubo@profusion.mobi
Python 2.6 is now the minimum supported version, see bug 71593 (diff)
4:11 PM Changeset in webkit [111266] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Make the TileCache work with HiDPI again
​https://bugs.webkit.org/show_bug.cgi?id=81569
<rdar://problem/11031542>

Reviewed by Sam Weinig.

Set the contentsScale of the individual tile layers to be the same as the device scale factor.
Also, take into account the fact that the value passed to TileCache::setScale is the product of the
page scale factor and the device scale factor, so divide it by the device scale factor before storing
it in m_scale.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):
(WebCore):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCALayerClient.h:

(PlatformCALayerClient):

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
(WebCore::TileCache::setScale):
(WebCore::TileCache::createTileLayer):

4:02 PM Changeset in webkit [111265] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Shadow DOM is not enabled on Mac, so skip the whole directory instead of skipping the tests
one by one.

  • platform/mac/Skipped:
4:01 PM Changeset in webkit [111264] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GC should not attempt to clear LLInt instruction inline caches for code blocks that are in
the process of being generated
​https://bugs.webkit.org/show_bug.cgi?id=81565

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

3:53 PM Changeset in webkit [111263] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to layer tree information not updated when moving run-in children.
​https://bugs.webkit.org/show_bug.cgi?id=81265

Reviewed by Julien Chaffraix.

Source/WebCore:

We need to do a full removal as the run-in child is getting inserted into
the neighbouring block and |blockRunIn| is going to be destroyed later
in the function.

Test: fast/runin/run-in-layer-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

  • fast/runin/run-in-layer-not-removed-crash-expected.txt: Added.
  • fast/runin/run-in-layer-not-removed-crash.html: Added.
3:52 PM Changeset in webkit [111262] by ojan@chromium.org
  • 3 edits in trunk/Tools

Make the selected item in the accordion a link to the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=81571

Reviewed by Dimitri Glazkov.

Also, make it so that you can select the text of the link, instead of the current behavior
of acting as if you had clicked on the accordion header.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3:42 PM Changeset in webkit [111261] by dpranke@chromium.org
  • 3 edits in trunk/Tools

NRWT runs some tests that are skipped with -i command line option
​https://bugs.webkit.org/show_bug.cgi?id=81535

Reviewed by Ojan Vafai.

This change modifies the interaction of Skipped files and
test_expectations files so that entries in Skipped files (and
the -i command line) override *everything* in the expectations
file.

Specifically, a directory in a Skipped file will cause all of
the tests in the dir to be skipped even if individual tests in
the dir are listed in the test_expectations.txt.

Skipped files also override anything in an overrides files.

This seems to make more intuitive sense, since if you list
something in the Skips file (and even more specify it on the
command line) you probably want it to be universally applied.

Theoretically we could add more precedence levels and have full
paths in an expectations file override dirs in a Skipped file
(but not the command line), but I don't know yet that that level
of complexity is justified.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_skipped_tests):
(TestExpectations._add_test):
(TestExpectations._add_expectations):
(TestExpectations._add_expectation_line):
(TestExpectations._already_seen_better_match):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_more_specific_override_resets_skip):
(SkippedTests):
(SkippedTests.get_exp):
(SkippedTests.assert_exp):
(SkippedTests.test_skipped_tests_work):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):

3:27 PM Changeset in webkit [111260] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove misleading double-if
​https://bugs.webkit.org/show_bug.cgi?id=81557

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Simple code cleanup, no functionality change.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

3:17 PM Changeset in webkit [111259] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] speed up text selection for large selections
​https://bugs.webkit.org/show_bug.cgi?id=81536

When selecting large disjoint areas of text the cost
of calculating the IntRectRegion union becomes very
expensive. Simply placing all of the text quads into
the IntRectRegion is faster despite the larger memory
footprint and the additional calculations at render
time.

Patch by Tyler Abbott <​tabbott@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

3:16 PM Changeset in webkit [111258] by eric@webkit.org
  • 79 edits in trunk

Fix WTF header include discipline in Chromium WebKit
​https://bugs.webkit.org/show_bug.cgi?id=81281

Reviewed by James Robinson.

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • wtf/unicode/icu/CollatorICU.cpp:

Source/WebCore:

I also fixed some bad include dicipline for other ports
as well. Those changes are not yet necessary for those ports
to keep building, but soon should be as those authors
remove all the extra WTF includes from WebCore and other non-WTF projects.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:
  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8AudioContextCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Float64ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bridge/qt/qt_runtime.cpp:
  • editing/gtk/FrameSelectionGtk.cpp:
  • loader/archive/mhtml/MHTMLArchive.cpp:
  • platform/ScrollAnimatorNone.cpp:
  • platform/blackberry/CookieMap.h:
  • platform/blackberry/CookieParser.h:
  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
  • platform/chromium/DragImageChromiumSkia.cpp:
  • platform/chromium/PlatformCursor.h:
  • platform/chromium/PlatformSupport.h:
  • platform/chromium/PopupMenuPrivate.h:
  • platform/chromium/TraceEvent.h:
  • platform/chromium/WidgetChromium.cpp:
  • platform/efl/RefPtrEfl.h:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/chromium/RateLimiter.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/efl/IconEfl.cpp:
  • platform/graphics/gstreamer/GStreamerGWorld.h:
  • platform/graphics/gtk/IconGtk.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp:
  • platform/gtk/PlatformMouseEventGtk.cpp:
  • platform/leveldb/LevelDBSlice.h:
  • platform/mediastream/MediaStreamCenter.cpp:
  • platform/network/soup/SocketStreamHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/qt/RenderThemeQtMobile.cpp:
  • platform/wx/MouseEventWx.cpp:
  • platform/wx/wxcode/win/fontprops.cpp:

Source/WebKit/chromium:

  • src/CompositionUnderlineBuilder.h:
  • src/CompositionUnderlineVectorBuilder.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/WebArrayBuffer.cpp:
  • src/WebArrayBufferView.cpp:
  • src/WebBindings.cpp:
  • src/WebColorName.cpp:
  • src/WebGeolocationClientMock.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebSocketImpl.cpp:
  • src/WebViewImpl.cpp:
  • tests/FrameTestHelpers.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
3:03 PM Changeset in webkit [111257] by Lucas Forschler
  • 8 edits in branches/safari-534.55-branch/Source/JavaScriptCore

Merged r111162.

3:03 PM Changeset in webkit [111256] by commit-queue@webkit.org
  • 4 edits
    5 adds in trunk

[BlackBerry] Add new layout test for text match marker
​https://bugs.webkit.org/show_bug.cgi?id=81531

Tools:

Make the LayoutTestControllerBlackBerry::findString to test the
BlackBerry port implementation.

Patch by Andy Chen <​andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::findString):

LayoutTests:

Patch by Andy Chen <​andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

Add a new layout test for text match marker for BlackBerry port

  • platform/blackberry/editing/text-iterator/findString-markers-expected.txt: Added.
  • platform/blackberry/editing/text-iterator/findString-markers.html: Added.
2:54 PM Changeset in webkit [111255] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

r109204 updated the chromium expected results for
inspector/timeline/timeline-animation-frame.html and timeline-paint.html, but did not update
the cross-platform results.

Update the cross-platform results.

  • inspector/timeline/timeline-animation-frame-expected.txt:
  • inspector/timeline/timeline-paint-expected.txt:
2:44 PM Changeset in webkit [111254] by fpizlo@apple.com
  • 17 edits
    2 moves in trunk/Source/JavaScriptCore

DFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
​https://bugs.webkit.org/show_bug.cgi?id=81556

Rubber stamped by Gavin Barraclough.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):

  • dfg/DFGAdjacencyList.h: Copied from Source/JavaScriptCore/dfg/DFGNodeReferenceBlob.h.

(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::child1):
(JSC::DFG::AdjacencyList::child2):
(JSC::DFG::AdjacencyList::child3):
(JSC::DFG::AdjacencyList::setChild1):
(JSC::DFG::AdjacencyList::setChild2):
(JSC::DFG::AdjacencyList::setChild3):
(JSC::DFG::AdjacencyList::child1Unchecked):
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::performSubstitution):

  • dfg/DFGEdge.h: Copied from Source/JavaScriptCore/dfg/DFGNodeUse.h.

(DFG):
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(Edge):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(Graph):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(Node):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::arithNodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):

  • dfg/DFGNodeReferenceBlob.h: Removed.
  • dfg/DFGNodeUse.h: Removed.
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

2:37 PM Changeset in webkit [111253] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Invalidate/update evicted tiles during commit
​https://bugs.webkit.org/show_bug.cgi?id=81529

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

A previous change caused a regression where evicted (invalid) tiles
were no longer marked as dirty and updated. The regress was caused
in ​https://bugs.webkit.org/show_bug.cgi?id=81175 and is fixed here.

Unit test: TiledLayerChromiumTest.pushDeletedTiles

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

2:36 PM Changeset in webkit [111252] by eae@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Revert unnecessary changes on branch.

2:35 PM Changeset in webkit [111251] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81549

Reviewed by Eric Seidel.

This appears to be the only PLATFORM(TORCHMOBILE) ifdef in WebCore. I
don't believe this ifdef is needed anymore.

  • loader/MainResourceLoader.cpp:

(WebCore::shouldLoadAsEmptyDocument):
(WebCore):

2:34 PM Changeset in webkit [111250] by barraclough@apple.com
  • 6 edits in trunk

Object.freeze broken on latest Nightly
​https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • defineOwnProperty was checking for correct behaviour, provided that length/callee hadn't been overrridden. instead, just reify length/callee & rely on JSObject::defineOwnProperty.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

  • for arguments/caller/length properties, defineOwnProperty was incorrectly asserting that the object must be extensible; this is incorrect since these properties should already exist on the object. In addition, it was asserting that the arguments/caller values must match the corresponding magic data properties, but for strict mode function this is incorrect. Instead, just reify the arguments/caller accessor & defer to JSObject::defineOwnProperty.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:

(shouldBeTrue):
(shouldBeFalse.shouldBeFalse.preventExtensionsFreezeIsFrozen):

  • Added test cases.
2:30 PM Changeset in webkit [111249] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r111207.
​http://trac.webkit.org/changeset/111207
​https://bugs.webkit.org/show_bug.cgi?id=81561

Causing chromium unit test failure (Requested by reveman on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-19

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

Source/WebKit/chromium:

  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h:
2:30 PM Changeset in webkit [111248] by Lucas Forschler
  • 5 edits in branches/safari-534.55-branch/Source

Versioning.

2:27 PM Changeset in webkit [111247] by tommyw@google.com
  • 2 edits
    4 adds in trunk/Source/WebKit/chromium

[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
​https://bugs.webkit.org/show_bug.cgi?id=81341

Reviewed by Darin Fisher.

Simple WebKit representations of the WebCore/platform versions.

  • WebKit.gyp:
  • public/platform/WebICEOptions.h: Added.

(WebCore):
(WebKit):
(WebICEOptions):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::~WebICEOptions):
(WebKit::WebICEOptions::operator=):
(WebKit::WebICEOptions::isNull):

  • public/platform/WebMediaHints.h: Added.

(WebCore):
(WebKit):
(WebMediaHints):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::~WebMediaHints):
(WebKit::WebMediaHints::operator=):
(WebKit::WebMediaHints::isNull):

  • src/WebICEOptions.cpp: Added.

(WebKit):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::assign):
(WebKit::WebICEOptions::reset):
(WebKit::WebICEOptions::candidateTypeToUse):

  • src/WebMediaHints.cpp: Added.

(WebKit):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::assign):
(WebKit::WebMediaHints::reset):
(WebKit::WebMediaHints::audio):
(WebKit::WebMediaHints::video):

2:26 PM Changeset in webkit [111246] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

NPRuntime support for out-of-process plug-ins.
​https://bugs.webkit.org/show_bug.cgi?id=48346

This issue was marked as fixed on 2011-01-11, but the tests that required that support were
never taken off the WK2 Skipped list.

Update the WK2 Skipped list to not skip the passing tests, and move the ones that still fail
to a separate section of the list.

  • platform/wk2/Skipped:
2:24 PM Changeset in webkit [111245] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unnecessary CALayer overrides from WebTileCacheLayer
​https://bugs.webkit.org/show_bug.cgi?id=81562

Reviewed by Dan Bernstein.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:
2:18 PM Changeset in webkit [111244] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLInt get_by_pname slow path incorrectly assumes that the operands are not constants
​https://bugs.webkit.org/show_bug.cgi?id=81559

Reviewed by Michael Saboff.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

2:05 PM Changeset in webkit [111243] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

Correct usage of LayoutUnits in page code in preparation for turning on subpixel layout
​https://bugs.webkit.org/show_bug.cgi?id=81538

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and conversions between types in page code.

No new tests.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
Explicitly cast long to int. InspectorInstrumentation requires a long and
FractionalLayoutUnit has no constructor that takes long.

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):
Pixel snap overflow rect as selection rects are integer based.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):
Pixel snap repaint rects when computing update rect as all scrolling is
done on integer bounds.

  • page/GestureTapHighlighter.cpp:

Change rects vector to IntRect as addFocusRingRects operates on IntRects.

  • page/Page.cpp:

(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
Change paint methods to take a LayoutRect paint rect.

  • page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode):
Change distance calculation to use floats instead of converting to float
at the end.

2:02 PM Changeset in webkit [111242] by Lucas Forschler
  • 2 edits in branches/safari-534.55-branch/Source/JavaScriptCore

Merged r110818.

2:00 PM Changeset in webkit [111241] by ojan@chromium.org
  • 3 edits in trunk/Tools

Don't show WONTFIX tests in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=81554

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1:59 PM Changeset in webkit [111240] by hyatt@apple.com
  • 6 edits
    4 adds in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=81553

[New Multicolumn] Stub out classes to represent sets of column region boxes.

RenderRegionSet is an abstract class representing a set of contiguous anonymous
same-size regions.

RenderMultiColumnSet derives from RenderRegionSet and represents a set of contiguous
columns. It will also handle unique column behavior like column rule painting.

Eventually there will be a RenderPageSet derived class for printing/pages, but
that will come later after I finish rebuilding multi-column layout.

Reviewed by Dan Bernstein.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderMultiColumnSet.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::renderName):

  • rendering/RenderMultiColumnSet.h: Added.

(WebCore):
(RenderMultiColumnSet):

  • rendering/RenderRegionSet.cpp: Added.

(WebCore):
(WebCore::RenderRegionSet::RenderRegionSet):

  • rendering/RenderRegionSet.h: Added.

(WebCore):
(RenderRegionSet):

1:54 PM Changeset in webkit [111239] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Add playback state for AudioBufferSourceNode and add number of active nodes
​https://bugs.webkit.org/show_bug.cgi?id=79701

Source/WebCore:

Add a playback state to AudioBufferSourceNode so that the user can
tell if the node is scheduled, playing, or finished.

For an AudioContext, add a count of the number of
AudioBufferSourceNode's that are active (playing audio).

Deleted m_isPlaying and m_hasFinished. For the record, m_isPlaying
is the same as a playbackState of SCHEDULED_STATE or PLAYING_STATE.
m_hasFinished is equivalent to a playbackState of FINISHED_STATE.

Patch by Raymond Toy <Raymond Toy> on 2012-03-19
Reviewed by Chris Rogers.

Test: webaudio/audiobuffersource-playbackState.html

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
initialize playbackState, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::process): Update playbackState
(WebCore::AudioBufferSourceNode::finish): Update playbackState
(WebCore::AudioBufferSourceNode::noteOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteGrainOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteOff): Use playbackState

  • webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode): Define states, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::playbackState): Added.

  • webaudio/AudioBufferSourceNode.idl: Define constants for the

playback state, add attribute playbackState.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::activeSourceCount): Added.
(WebCore::AudioContext::incrementActiveSourceCount): Added.
(WebCore::AudioContext::decrementActiveSourceCount): Added.

  • webaudio/AudioContext.h:

(AudioContext):

  • webaudio/AudioContext.idl: Add attribute activeSourceCount.

LayoutTests:

Patch by Raymond Toy <Raymond Toy> on 2012-03-19
Reviewed by Chris Rogers.

  • webaudio/audiobuffersource-playbackState-expected.txt: Added.
  • webaudio/audiobuffersource-playbackState.html: Added.
1:43 PM Changeset in webkit [111238] by Lucas Forschler
  • 1 copy in branches/safari-534.55-branch

New Branch.

1:43 PM Changeset in webkit [111237] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r109014.
​http://trac.webkit.org/changeset/109014
​https://bugs.webkit.org/show_bug.cgi?id=81551

Causing crashes (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-19

Source/WebCore:

  • rendering/style/RenderStyle.h:

LayoutTests:

  • css3/flexbox/inline-flexbox-expected.html: Removed.
  • css3/flexbox/inline-flexbox.html: Removed.
1:43 PM Changeset in webkit [111236] by Lucas Forschler
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Rollout 110818.

1:41 PM Changeset in webkit [111235] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Make WebFrameLoaderClient::createFrame more like WebKit1 version.
​https://bugs.webkit.org/show_bug.cgi?id=81550

Covered by existing tests.

Reviewed by Jessie Berlin.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame):
1:39 PM Changeset in webkit [111234] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
​https://bugs.webkit.org/show_bug.cgi?id=77013

We should use mmap(PROT_NONE, MAP_LAZY) instead of posix_madvise() to
implement memory decommitting for QNX.

Patch by Yong Li <​yoli@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

1:29 PM Changeset in webkit [111233] by Chris Fleizach
  • 6 edits
    1 delete in trunk

platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81530

Reviewed by Jessie Berlin.

Tools:

Add rowAtIndex to WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::rowAtIndex):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR):
(WTR::AccessibilityUIElement::rowAtIndex):

LayoutTests:

  • platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.
1:28 PM Changeset in webkit [111232] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

editing/input/reveal-edit-on-input-vertically.html and
editing/input/reveal-contenteditable-on-input-vertically.html timing out on Lion Intel Debug
WebKit2 testers

Add those tests to the WK2 Skipped list.

  • platform/wk2/Skipped:
1:26 PM Changeset in webkit [111231] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, remove headers that no longer exist or moved in WebCore.gypi.

  • WebCore.gypi:
1:24 PM Changeset in webkit [111230] by eae@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fix type conversions on branch to match trunk.

1:24 PM Changeset in webkit [111229] by mihnea@adobe.com
  • 9 edits
    2 adds in trunk

[CSSRegions]Implement NamedFlow::contentNodes attribute
​https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

Source/WebCore:

Test: fast/regions/webkit-named-flow-content-nodes.html

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::detach):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
(WebCore::WebKitNamedFlow::registerContentNode):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::unregisterContentNode):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

  • fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
  • fast/regions/webkit-named-flow-content-nodes.html: Added.
1:23 PM Changeset in webkit [111228] by ojan@chromium.org
  • 11 edits in trunk/Tools

Change garden-o-matic All Failures tab to Expected Failures
​https://bugs.webkit.org/show_bug.cgi?id=81540

Reviewed by Dimitri Glazkov.

Also, fix some broken unittests that had just gotten stale.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1:19 PM Changeset in webkit [111227] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

ConvolverNode should not incur processing latency
​https://bugs.webkit.org/show_bug.cgi?id=75564

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2012-03-19
Reviewed by Chris Rogers.

Source/WebCore:

Add the DirectConvolver instead of FFTConvolver for the processing of the leading portion of impulse response.

  • WebCore.gypi:
  • platform/audio/DirectConvolver.cpp: Added.

(WebCore):
(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):

  • platform/audio/DirectConvolver.h: Added.

(WebCore):
(DirectConvolver):
(WebCore::DirectConvolver::convolveSize):

  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

  • platform/audio/ReverbConvolver.h:
  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
(WebCore::ReverbConvolverStage::reset):

  • platform/audio/ReverbConvolverStage.h:

(WebCore):
(ReverbConvolverStage):

LayoutTests:

No need to check the initial silent part because the latency issue of ConvolverNode is fixed.

  • webaudio/convolution-mono-mono-expected.txt:
  • webaudio/resources/convolution-testing.js:

(checkTriangularPulse):
(checkTail1):
(checkConvolvedResult.return.var):
(checkConvolvedResult):

1:13 PM Changeset in webkit [111226] by andersca@apple.com
  • 6 edits in trunk/Source

Source/WebCore: Find in page highlights get out of place when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=81543

Reviewed by Sam Weinig.

Remove a now unused function from GraphicsLayer.

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

Source/WebKit2: Find in page highlights get out of place when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=81543
<rdar://problem/10932590>

Reviewed by Sam Weinig.

When we have a page overlay layer, always force a full repaint of it whenever the page changes.
If this turns out to be a real performance problem (measurements suggest that it isn't), we could once
again try to figure out when a full page repaint is needed. Doing so could probably be more expensive than
simply repainting the page, given that a page overlay consists of a bunch of rect-fills mostly.

Also turn on accelerated drawing for the page overlay layer, since that cut CPU usage in half when scrolling
on a page that had a find overlay visible.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

1:12 PM Changeset in webkit [111225] by jsbell@chromium.org
  • 16 edits in trunk/LayoutTests

IndexedDB: Test cleanup - don't create transactions w/in transaction callback
​https://bugs.webkit.org/show_bug.cgi?id=81532

The spec precludes creating transactions within a synchronous transaction callback;
for the current implementation, that's only the success callback for a setVersion()
call. This isn't enforced yet - see ​http://webkit.org/b/80547

Reviewed by Tony Chang.

  • storage/indexeddb/create-and-remove-object-store.html: Split out oncomplete handler.
  • storage/indexeddb/create-object-store-options.html: Split out oncomplete handler.
  • storage/indexeddb/factory-deletedatabase.html: Listen on complete event.
  • storage/indexeddb/mozilla/autoincrement-indexes.html: Split out oncomplete handler.
  • storage/indexeddb/mozilla/clear.html: Listen on complete event.
  • storage/indexeddb/mozilla/indexes.html: Split out oncomplete handler.
  • storage/indexeddb/mozilla/readonly-transactions.html: Split out oncomplete handler.
  • storage/indexeddb/mozilla/readwrite-transactions.html: Split out oncomplete handler.
  • storage/indexeddb/noblobs.html: Pass function reference, don't call function.
  • storage/indexeddb/objectstore-clear.html: Split out oncomplete handler.
  • storage/indexeddb/objectstore-removeobjectstore.html: Listen on complete event.
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Split out oncomplete handler.
  • storage/indexeddb/transaction-abort-with-js-recursion.html: Split out oncomplete handler.
  • storage/indexeddb/transaction-crash-on-abort.html: Split out oncomplete handler.
  • storage/indexeddb/two-version-changes.html: Split out oncomplete handler.
1:09 PM Changeset in webkit [111224] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as flaky for image
tests on all flavors of Chromium.

  • platform/chromium/test_expectations.txt:
12:59 PM Changeset in webkit [111223] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed - revent a couple of files accidentally committed.

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

12:58 PM Changeset in webkit [111222] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Marking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium Snowleopard.

  • platform/chromium/test_expectations.txt:
12:49 PM Changeset in webkit [111221] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

r98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updating the
expected results.

Update the expected results.

  • platform/mac-wk2/plugins/contents-scale-factor-expected.txt:
12:46 PM Changeset in webkit [111220] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] DRT crashes at shutdown.
​https://bugs.webkit.org/show_bug.cgi?id=81504

Patch by Hao Zheng <​zhenghao@chromium.org> on 2012-03-19
Reviewed by James Robinson.

WebCompositor must be destroyed after WebView is properly destroyed,
or some compositor objects like CCLayerTreeHost may not be destroyed.
However, it is really hard to make the destruction order correct
explicitly in ~TestShell. So move it out to DumpRenderTree.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::~TestShell):

12:43 PM Changeset in webkit [111219] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

When Find overlay first appears and the page scrolls, the scrolling happens through a fade
​https://bugs.webkit.org/show_bug.cgi?id=81539
<rdar://problem/11031093>

Reviewed by Dan Bernstein.

Disable implicit animations when adding the page overlay layer to its superlayer.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

12:41 PM Changeset in webkit [111218] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
​https://bugs.webkit.org/show_bug.cgi?id=81537

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-19

  • platform/chromium/test_expectations.txt:
12:28 PM Changeset in webkit [111217] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=81534

[New Multicolumn] Make the multi-column block re-layout its children when the column width/count change.
Cache the count/width on the multi-column block for easy access.

Reviewed by Antti Koivisto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

Virtualize the code that recomputes the logical width for a block and sets relayoutChildren to true,
so that column code can subclass the method to also check for changes in the column width/count.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
The column count/width determination algorithm in one method on the RenderMultiColumnBlock. It's a copy
of the code from RenderBlock (which will be going away eventually).

(WebCore::RenderMultiColumnBlock::recomputeLogicalWidth):

  • rendering/RenderMultiColumnBlock.h:

(RenderMultiColumnBlock):
Subclassed method to also check for changes in the column width to set relayoutChildren to true.

12:19 PM Changeset in webkit [111216] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct with have backbuffer suggestion.
​https://bugs.webkit.org/show_bug.cgi?id=81279

Patch by Michal Mocny <​mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

Adding a suggestHaveBackbuffer hint to the WebGraphicsContext3D memory allocation callback.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::onMemoryAllocationChanged):

  • chromium/public/WebGraphicsMemoryAllocation.h: Added.

(WebKit):
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationCHROMIUM::GpuMemoryAllocationCHROMIUM):
(GpuMemoryAllocationChangedCallbackCHROMIUM):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):

12:14 PM Changeset in webkit [111215] by dpranke@chromium.org
  • 2 edits in trunk/Tools

add dpranke to webkitpy watchlist
​https://bugs.webkit.org/show_bug.cgi?id=81433

Reviewed by Benjamin Poulain.

  • Scripts/webkitpy/common/config/watchlist:
12:11 PM Changeset in webkit [111214] by tony@chromium.org
  • 9 edits in trunk

flex-item-align: stretch should only grow, never shrink
​https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html: New test cases.
  • platform/chromium/test_expectations.txt: Mark as failing on Windows

because of mock scrollbar rendering bug.

12:08 PM Changeset in webkit [111213] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test-webkitpy is failing on SL/Python 2.6.1
​https://bugs.webkit.org/show_bug.cgi?id=81533

Reviewed by Ojan Vafai.

It appears that itertools.combinations() is buggy in 2.6.1; this
backports the implementation from 2.7.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations):

12:02 PM Changeset in webkit [111212] by vsevik@chromium.org
  • 9 edits in trunk

Web Inspector: Implement snippets evaluation.
​https://bugs.webkit.org/show_bug.cgi?id=81334

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evaluateUsingTextPrompt):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):

  • inspector/front-end/SnippetsModel.js:
  • inspector/front-end/externs.js:

(WebInspector.evaluateInConsole):

  • inspector/front-end/inspector.js:

(WebInspector.evaluateInConsole):

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt:
  • inspector/debugger/snippets-model.html:
11:39 AM Changeset in webkit [111211] by jsbell@chromium.org
  • 139 edits in trunk/LayoutTests

IndexedDB: LayoutTests don't need explicit console div
​https://bugs.webkit.org/show_bug.cgi?id=81370

Remove unneeded div and p tags (added by js-test-pre.js) and
unnecessary jsTestIsAsync = true (set by shared.js).

Reviewed by Tony Chang.

  • storage/indexeddb/basics-shared-workers.html:
  • storage/indexeddb/basics-workers.html:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-basics-workers.html:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-population.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering-expected.txt:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-workers.html:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/prefetch-bugfix-108071.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort-workers.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
11:36 AM Changeset in webkit [111210] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81530

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Added.
11:36 AM Changeset in webkit [111209] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
​https://bugs.webkit.org/show_bug.cgi?id=81269

Generate the UserAgent lazily, using it as the default for the
WebSettings object. BlackBerry::Platform::DeviceInfo is used
to ensure the information is accurate to the specific device.

Remove the !isEmpty() assert when fetching the UA from the
WebSettings object, as it will now always be properly initialized.

Add a static initializer block to ensure defaultUserAgent() is
thread-safe from that moment onward.

Patch by Mike Lattanzio <​mlattanzio@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::setUserAgentString):

  • Api/WebSettings.h:
11:33 AM Changeset in webkit [111208] by tommyw@google.com
  • 3 edits
    3 adds in trunk/Source/WebCore

MediaStream API (JSEP): Introducing PeerConnection00Handler
​https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

  • platform/mediastream/PeerConnection00Handler.h: Added.

(WebCore):
(PeerConnection00Handler):

  • platform/mediastream/PeerConnection00HandlerClient.h: Added.

(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

11:27 AM Changeset in webkit [111207] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
​https://bugs.webkit.org/show_bug.cgi?id=80988

Patch by David Reveman <​reveman@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/Platform:

Add EXT_occlusion_query API to WebGraphicsContext3D.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

Source/WebCore:

Expose EXT_occlusion_query API to WebKit compositor. Add
GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query
enums.

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

Source/WebKit/chromium:

Expose EXT_occlusion_query API to WebKit compositor.

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::createQueryEXT):
(WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
(WebKit::FakeWebGraphicsContext3D::isQueryEXT):
(WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
(WebKit::FakeWebGraphicsContext3D::endQueryEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
(FakeWebGraphicsContext3D):

11:16 AM Changeset in webkit [111206] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input fields with id of e-mail and url should be styled as such.
​https://bugs.webkit.org/show_bug.cgi?id=81364

Reviewed by Rob Buis.

Be less aggressive on matching url, and update as suggested by Rob.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

11:02 AM Changeset in webkit [111205] by mikelawther@chromium.org
  • 3 edits
    1 move in trunk

CSS3 calc: make mask images work with mixed percent/absolute
​https://bugs.webkit.org/show_bug.cgi?id=81477

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/simple-composited-mask-expected.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

  • css3/calc/simple-composited-mask-expected.html: Renamed from LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html.
10:52 AM Changeset in webkit [111204] by abarth@webkit.org
  • 2 edits in trunk/Tools

Optimize the cleanup sequence in the start-queue.sh script
​https://github.com/abarth/webkit/pull/1

Patch by David Michael Barr <​davidbarr@google.com> on 2012-03-19
Reviewed by Adam Barth.

Updating the working copy is an expensive operation
for a repository the size of WebKit.
Attempt to reset only to the target revision.

  • EWSTools/start-queue.sh:
10:46 AM Changeset in webkit [111203] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Style cleanup in Modules/filesystem/
​https://bugs.webkit.org/show_bug.cgi?id=81520

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • Modules/filesystem/AsyncFileWriter.h:

(WebCore::AsyncFileWriter::~AsyncFileWriter):

  • Modules/filesystem/AsyncFileWriterClient.h:

(WebCore::AsyncFileWriterClient::~AsyncFileWriterClient):

  • Modules/filesystem/DOMFilePath.cpp:

(WebCore::DOMFilePath::getDirectory):

  • Modules/filesystem/DOMFilePath.h:

(DOMFilePath):

  • Modules/filesystem/DOMFileSystemBase.h:

(DOMFileSystemBase):

  • Modules/filesystem/DirectoryEntry.h:
  • Modules/filesystem/DirectoryEntrySync.h:
  • Modules/filesystem/EntryArray.h:

(EntryArray):

  • Modules/filesystem/FileEntry.h:

(FileEntry):

  • Modules/filesystem/FileSystemCallbacks.h:

(FileSystemCallbacksBase):

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::abort):

10:37 AM Changeset in webkit [111202] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when closing an inspected web page with tiled drawing enabled
​https://bugs.webkit.org/show_bug.cgi?id=81524
<rdar://problem/11062396>

Reviewed by Sam Weinig.

Guard against the WebPage's underlying WebCore Page being null, which can happen
when the inspector highlight overlay is uninstalled by the inspector when the inspected
page goes away.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

10:37 AM Changeset in webkit [111201] by ap@apple.com
  • 2 edits in trunk/LayoutTests

FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load-last-non-html-frame.php
​https://bugs.webkit.org/show_bug.cgi?id=81365

  • platform/wk2/Skipped: Skipped the test.
10:34 AM Changeset in webkit [111200] by mikelawther@chromium.org
  • 3 edits
    1 move in trunk

CSS3 calc: background positioning works with mixed percent/absolute expressions
​https://bugs.webkit.org/show_bug.cgi?id=81478

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/background-position-parsing-expected.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

  • css3/calc/background-position-parsing-expected.html: Renamed from LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html.
10:10 AM Changeset in webkit [111199] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

Merge _q_commitScaleChange and _q_commitPositionChange
​https://bugs.webkit.org/show_bug.cgi?id=81511

Reviewed by Simon Hausmann.

Both methods were used for notifying WebCore of the new
viewport and re-tiling. The methods are merge into
_q_contentViewportChanged.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::_q_resume):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

10:09 AM Changeset in webkit [111198] by ahf@0x90.dk
  • 2 edits in trunk/Source/WebCore

Add NodeRenderStyle.h to TouchAdjustment.cpp

Unreviewed build fix after r111185.

  • page/TouchAdjustment.cpp:
9:57 AM Changeset in webkit [111197] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Another Windows build fix after r111129.

9:53 AM Changeset in webkit [111196] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer to it
​https://bugs.webkit.org/show_bug.cgi?id=81476

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

9:48 AM Changeset in webkit [111195] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

Cross-platform processor core counter: fix build on FreeBSD.
​https://bugs.webkit.org/show_bug.cgi?id=81482

Reviewed by Zoltan Herczeg.

The documentation of sysctl(3) shows that <sys/types.h> should be
included before <sys/sysctl.h> (sys/types.h tends to be the first
included header in general).

This should fix the build on FreeBSD and other systems where
sysctl.h really depends on types defined in types.h.

  • wtf/NumberOfCores.cpp:
9:46 AM Changeset in webkit [111194] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics/MediaPlayer.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81489

Reviewed by Rob Buis.

  • platform/graphics/MediaPlayer.cpp:
9:43 AM Changeset in webkit [111193] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

Adjust architecture type of the EFL build bot.
​https://bugs.webkit.org/show_bug.cgi?id=81452

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2012-03-19
Reviewed by Tony Chang.

  • BuildSlaveSupport/build.webkit.org-config/config.json: The

buildslave is a 64-bit machine, therefore describe it as being
x86_64, not i386.

9:37 AM Changeset in webkit [111192] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Set the svn:ignore property on the Xcode project.

  • WTF.xcodeproj: Added property svn:ignore.
9:23 AM Changeset in webkit [111191] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
​https://bugs.webkit.org/show_bug.cgi?id=81312

Reviewed by Rob Buis.

  • platform/PlatformKeyboardEvent.h:

(Platform):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
Add BlackBerry specific constructor and member fields.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Change the parameter type to const reference type to adapt to the declaration.

9:22 AM Changeset in webkit [111190] by ahf@0x90.dk
  • 2 edits in trunk/Tools

[Qt] printLoadedUrls prints "Object" instead of the actual URL. ​https://bugs.webkit.org/show_bug.cgi?id=81514

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
9:21 AM Changeset in webkit [111189] by leviw@chromium.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaselining fixed-position-scroll now that more bots have come in.

  • platform/chromium-mac-snowleopard/compositing/layer-creation: Removed.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
  • platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
9:18 AM Changeset in webkit [111188] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix after r111129.

9:07 AM Changeset in webkit [111187] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
​https://bugs.webkit.org/show_bug.cgi?id=81491

Reviewed by Philippe Normand.

For the find_path(), find_library() etc CMake calls to find the
dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
set, otherwise CMake cannot know the dependencies exist and will only
look in the standard directories.

  • efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with

the jhbuild Root directory.

9:05 AM Changeset in webkit [111186] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

[EFL] Add XDG env vars to jhbuildrc
​https://bugs.webkit.org/show_bug.cgi?id=81510

Needed to ensure correct glib behaviour in jhbuild environment.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Philippe Normand.

  • efl/jhbuildrc:
8:33 AM Changeset in webkit [111185] by commit-queue@webkit.org
  • 27 edits
    11 adds in trunk

Select best target for tap gesture.
​https://bugs.webkit.org/show_bug.cgi?id=78801

Source/WebCore:

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.
IntRect changes reviewed by Dave Hyatt.

The new API is available through EventHandler::bestClickableNodeForTouchPoint, but
implementation details have been placed in page/TouchAdjustment.

The default hit detection is performed by measuring the distance to the center
lines of the absolute rects of the hit nodes. Absolute rects are used instead
of bounding rects to make hit-detecting against links over line breaks. Distance
to center line is used to make it easier to hit small links next to large links.
For line-rects the distance to the center-line is a better expression of the distance
to a rectangles center than the distance to the center-point.

Tests: touchadjustment/event-triggered-widgets.html

touchadjustment/html-label.html
touchadjustment/nested-touch.html
touchadjustment/touch-inlines.html

  • Target.pri:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):

  • page/EventHandler.h:
  • page/TouchAdjustment.cpp: Added.

(WebCore::TouchAdjustment::QuadForHitTest::QuadForHitTest):
(WebCore::TouchAdjustment::QuadForHitTest::node):
(WebCore::TouchAdjustment::QuadForHitTest::quad):
(WebCore::TouchAdjustment::QuadForHitTest::boundingBox):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::appendAbsoluteQuadsForNodeToHitTestList):
(WebCore::TouchAdjustment::compileQuadsForHitTesting):
(WebCore::TouchAdjustment::distanceSquaredToQuadCenterLine):
(WebCore::TouchAdjustment::findNodeWithLowestMetric):
(WebCore::findBestClickableCandidate):

  • page/TouchAdjustment.h: Added.
  • platform/graphics/FloatQuad.h:

(WebCore::FloatQuad::center):

  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::distanceSquaredToPoint):

  • platform/graphics/IntRect.cpp:

(WebCore::distanceToInterval):
(WebCore::IntRect::differenceToPoint):
(WebCore::IntRect::differenceFromCenterLineToPoint):

  • platform/graphics/IntRect.h:

(WebCore::IntRect::distanceSquaredToPoint):
(WebCore::IntRect::distanceSquaredFromCenterLineToPoint):

  • platform/graphics/IntSize.h:

(WebCore::IntSize::diagonalLengthSquared):

  • testing/Internals.cpp:

(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Send radius to handlePotentialSingleTapEvent so it can do the same hit
detection the tap gesture later does.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handlePotentialActivation):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Add TOUCH_ADJUSTMENT to enabled features.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Test of touch adjustments. Tests several both normal and tricky cases.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • touchadjustment/event-triggered-widgets-expected.txt: Added.
  • touchadjustment/event-triggered-widgets.html: Added.
  • touchadjustment/html-label-expected.txt: Added.
  • touchadjustment/html-label.html: Added.
  • touchadjustment/nested-touch-expected.txt: Added.
  • touchadjustment/nested-touch.html: Added.
  • touchadjustment/touch-inlines-expected.txt: Added.
  • touchadjustment/touch-inlines.html: Added.
8:11 AM Changeset in webkit [111184] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add ENABLED(FILE_SYSTEM) to DOMFilePath.h
​https://bugs.webkit.org/show_bug.cgi?id=81393

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-03-19
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

  • Modules/filesystem/DOMFilePath.h:
7:54 AM Changeset in webkit [111183] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-19

  • DEPS:
7:51 AM Changeset in webkit [111182] by commit-queue@webkit.org
  • 7 edits
    8 adds in trunk

[chromium] synthesize wheel events for fling on main thread
​https://bugs.webkit.org/show_bug.cgi?id=81458

Source/WebKit/chromium:

Support track pad fling by generating a sequence of wheel events.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::scrollBy): Call-back from PlatformGestureCurve to dispatch wheel event.
(WebKit):
(WebKit::WebViewImpl::gestureEvent): Handle GestureFlingStart and GestureFlingCancel.
(WebKit::WebViewImpl::updateAnimations): Requests a PlatformGestureCurve to animate forward.
(WebKit::WebViewImpl::didCommitLoad): Halt flings on navigations.

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

Tools:

Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureFlingCancel):
(EventSender::gestureFlingStart):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests:

Show that the GestureFlingStart and GestureFlingEnd events are handled and
connect up with WebViewImpl

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
  • fast/events/touch/gesture/pad-gesture-cancel.html: Added.
  • fast/events/touch/gesture/pad-gesture-cancel.js: Added.

(recordWheelEvent):
(if):

  • fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
  • fast/events/touch/gesture/pad-gesture-fling.html: Added.
  • fast/events/touch/gesture/pad-gesture-fling.js: Added.

(recordWheelEvent):
(if):

  • platform/chromium/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
7:47 AM Changeset in webkit [111181] by kkristof@inf.u-szeged.hu
  • 1 edit
    3 adds in trunk/LayoutTests

[Qt] Unreviewed. Add new platform specific expectation after r110667.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Added.
  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Added.
7:45 AM Changeset in webkit [111180] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
​https://bugs.webkit.org/show_bug.cgi?id=81115

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-03-19
Reviewed by Benjamin Poulain.

The compositor tried to avoid rendering the same stuff twice, using a
mechanism that didn't work properly and has been redundant since we
introduced deferred blits. Remove this code.

Reviewed internally by Robin Cao.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:
7:42 AM Changeset in webkit [111179] by ahf@0x90.dk
  • 5 edits in trunk/Tools

[Qt] Add command line option to set the user agent in the MiniBrowser ​https://bugs.webkit.org/show_bug.cgi?id=81508

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webViewExperimental):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setUserAgent):
(WindowOptions::userAgent):
(WindowOptions):

7:42 AM Changeset in webkit [111178] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebKit2

[Qt] Add experimental API for dynamically changing the UA string

Reviewed by Simon Hausmann.

This patch adds a new property named userAgent to the
QQuickWebViewExperimental type which allows us to dynamically change
the user agent string from the QML API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):

  • UIProcess/API/qt/qquickwebview_p.h:
7:41 AM Changeset in webkit [111177] by ahf@0x90.dk
  • 4 edits
    1 delete in trunk/Tools

[Qt] Remove dead user agent code from the MiniBrowser.

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/BrowserWindow.cpp:
  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/useragentlist.txt: Removed.
7:38 AM Changeset in webkit [111176] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

inspector highlight of SVG root element with viewbox does not match dimensions of element
​https://bugs.webkit.org/show_bug.cgi?id=78037

Patch by Max Vujovic <​mvujovic@adobe.com> on 2012-03-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Functions such as RenderBox::absoluteQuads and DOMNodeHighlighter::getOrDrawNodeHighlight
eventually call RenderSVGRoot::mapLocalToContainer, passing along local CSS box coordinates.

However, before this patch, RenderSVGRoot::mapLocalToContainer expected local SVG viewport
coordinates. This caused the inspector highlight to be incorrectly sized and positioned.

Now, RenderSVGRoot::mapLocalToContainer expects local CSS box coordinates, like other HTML
renderers.

Test: inspector/elements/highlight-svg-root.html

  • dom/Element.cpp:

(WebCore::Element::getBoundingClientRect):

Now, the SVG root element can use the code path for elements with CSS boxes to calculate
its bounding client rect.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

RenderSVGRoot::mapLocalToContainer no longer needs to apply the
localToBorderBoxTransform to convert from local SVG viewport coordinates to local CSS
box coordinates. Now, it receives local CSS box coordinates.

  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::localToBorderBoxTransform):

RenderSVGRoot::localToBorderBoxTransform has been exposed for child elements in the SVG
namespace to use when mapping from local SVG viewport coordinates to local CSS box
coordinates.

(RenderSVGRoot):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

Elements in the SVG namespace should now apply the localToBorderBoxTransform at the
SVG/HTML boundary (aka RenderSVGRoot) when mapping their coordinates up the render tree.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

Same as above. This method is eventually used in the SVGLocatable::getScreenCTM
calculation.

LayoutTests:

  • inspector/elements/highlight-svg-root-expected.txt: Added.
  • inspector/elements/highlight-svg-root.html: Added.
7:35 AM Changeset in webkit [111175] by kubo@profusion.mobi
  • 2 edits in trunk/Tools

jhbuild: Call jhbuild's autogen.sh via bash.
​https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

7:30 AM Changeset in webkit [111174] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Prefix run-launcher with run-with-jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=81503

Patch by Philippe Normand <​pnormand@igalia.com> on 2012-03-19
Reviewed by Hajime Morita.

  • Scripts/run-launcher:
3:47 AM Changeset in webkit [111173] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Adding slow to full-screen-restrictions.html on WIN.

  • platform/chromium/test_expectations.txt:
3:47 AM Changeset in webkit [111172] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Prefix run-launcher with run-with-jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=80026

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Hajime Morita.

  • Scripts/run-launcher:
3:34 AM Changeset in webkit [111171] by hbono@chromium.org
  • 2 edits in trunk/Source/WebCore

Add a copy constructor to CollapsedBorderValue
​https://bugs.webkit.org/show_bug.cgi?id=81502

Reviewed by Hajime Morita.

Due to the lack of this copy constructor, GCC (x86) creates a broken copy
constructor and it causes a build break on Google Chrome.

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(CollapsedBorderValue):

2:56 AM Changeset in webkit [111170] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Gardening.

Patch by Balazs Ankes <​bank@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip a new failing test, remove a non-existent test, order entries.
  • platform/qt/fast/events/resize-events-expected.png: Added.
  • platform/qt/fast/events/resize-events-expected.txt: Added.
2:48 AM Changeset in webkit [111169] by keishi@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[chromium] Rebaseline due to r111139

  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added.
2:10 AM Changeset in webkit [111168] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Rebaseline due to r111156

  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
1:59 AM Changeset in webkit [111167] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed gardening. Adding missing cr-snowleopard layer creation expectations.

  • platform/chromium-mac-snowleopard/compositing/layer-creation: Added.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
1:49 AM Changeset in webkit [111166] by Philippe Normand
  • 162 edits
    9 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110759 and r108185.

  • platform/gtk/editing/inserting/before-after-input-element-expected.txt:
  • platform/gtk/editing/pasteboard/4806874-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/input-field-1-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/expanding-selections-expected.txt:
  • platform/gtk/editing/selection/leave-requested-block-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/gtk/fast/block/float/033-expected.txt: Added.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
  • platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
  • platform/gtk/fast/block/float/in-margin-expected.txt:
  • platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/font-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt:
  • platform/gtk/fast/clip/017-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/invalidation-errors-2-expected.txt:
  • platform/gtk/fast/css/invalidation-errors-expected.txt:
  • platform/gtk/fast/css/line-height-expected.txt:
  • platform/gtk/fast/css/nested-layers-with-hover-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/dom/isindex-001-expected.txt:
  • platform/gtk/fast/dom/isindex-002-expected.txt:
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/events/mouse-relative-position-expected.txt: Added.
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/input-width-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/gtk/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/overflow/004-expected.txt:
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/gtk/fast/overflow/line-clamp-expected.txt:
  • platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/gtk/fast/repaint/layer-outline-expected.txt:
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt:
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
  • platform/gtk/fast/table/003-expected.txt:
  • platform/gtk/fast/table/029-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/gtk/fast/table/overflowHidden-expected.txt:
  • platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
  • platform/gtk/fast/table/text-field-baseline-expected.txt:
  • platform/gtk/fast/text/selection-painted-separately-expected.txt:
  • platform/gtk/fast/text/selection-rect-rounding-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/svg/hixie/mixed/003-expected.txt:
  • platform/gtk/tables/mozilla/bugs/45621-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
1:36 AM Changeset in webkit [111165] by leviw@chromium.org
  • 1 edit
    3 adds
    4 deletes in trunk/LayoutTests

Unreviewed gardening. Fixing expectations due to new Mac Lion baselines.

  • platform/chromium-linux-x86/css2.1/20110323: Removed.
  • platform/chromium-linux/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
1:24 AM Changeset in webkit [111164] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening

  • platform/gtk/Skipped: Move the 2 http tests skipped in r111161

to the showModal section.

  • platform/gtk/test_expectations.txt: Unskip tests needing rebaseline.
1:21 AM Changeset in webkit [111163] by leviw@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed gardening: updating max-width-integer-overflow test expectations post 111156, which
eliminated code dealing with 28-bit lengths.

  • platform/chromium-win-vista/fast/table: Added.
  • platform/chromium-win-vista/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.txt: Added.
1:12 AM Changeset in webkit [111162] by barraclough@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

JSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value from convertToType
​https://bugs.webkit.org/show_bug.cgi?id=81468 <rdar://problem/11034745>

Reviewed by Oliver Hunt.

The API specifies that convertToType may opt not to handle a conversion:

"@result The objects's converted value, or NULL if the object was not converted."

In which case, it would propagate first up the JSClass hierarchy, calling its superclass's
conversion functions, and failing that call the JSObject::defaultValue function.

Unfortunately this behaviour was removed in bug#69677/bug#69858, and instead we now rely on
the toStringCallback/valueOfCallback function introduced in bug#69156. Even after a fix in
bug#73368, these will return the result from the first convertToType they find, regardless
of whether this result is null, and if no convertToType method is found in the api class
hierarchy (possible if toStringCallback/valueOfCallback was accessed off the prototype
chain), they will also return a null pointer. This is unsafe.

It would be easy to make the approach based around toStringCallback/valueOfCallback continue
to walk the api class hierarchy, but making the fallback to defaultValue would be problematic
(since defaultValue calls toStringCallback/valueOfCallback, this would infinitely recurse).
Making the fallback work with toString/valueOf methods attached to api objects is probably
not the right thing to do – instead, we should just implement the defaultValue trap for api
objects.

In addition, this bug highlights that fact that JSCallbackFunction::call will allow a hard
null to be returned from C to JavaScript - this is not okay. Handle with an exception.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • Should be null checking the return value.

(JSC):

  • Remove toStringCallback/valueOfCallback.
  • API/JSCallbackFunction.h:

(JSCallbackFunction):

  • Remove toStringCallback/valueOfCallback.
  • API/JSCallbackObject.h:

(JSCallbackObject):

  • Add defaultValue mthods to JSCallbackObject.
  • API/JSCallbackObjectFunctions.h:

(JSC::::defaultValue):

  • Add defaultValue mthods to JSCallbackObject.
  • API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

  • Remove toStringCallback/valueOfCallback.
  • API/tests/testapi.js:
    • Revert this test, now we no longer artificially introduce a toString method onto the api object.
1:01 AM Changeset in webkit [111161] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r111156 and skip 2 new http tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/table/max-width-integer-overflow-expected.txt:
12:11 AM Changeset in webkit [111160] by keishi@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Fix build that was broken by r111137

Fixed was ambiguous because of MacTypes.h

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::addTransformAnimationToLayer):

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::addTransformAnimationToLayer):

12:01 AM Changeset in webkit [111159] by timothy_horton@apple.com
  • 2 edits
    25 adds
    2 deletes in trunk/LayoutTests

Unreviewed new baselines of various tests for Mac.

Mar 18, 2012:

11:59 PM Changeset in webkit [111158] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed. Disable -Werror on x86 until proper fix.
​https://bugs.webkit.org/show_bug.cgi?id=81498

  • qmake/mkspecs/features/unix/default_post.prf:
11:58 PM Changeset in webkit [111157] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fallback to common script when per-script font setting is the empty string
​https://bugs.webkit.org/show_bug.cgi?id=81329

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/text/international/font-fallback-to-common-script.html

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyForScript): Remove the setting when the per-script font family is the empty string.

LayoutTests:

  • fast/text/international/font-fallback-to-common-script-expected.html: Added.
  • fast/text/international/font-fallback-to-common-script.html: Added.
11:37 PM Changeset in webkit [111156] by macpherson@chromium.org
  • 8 edits in trunk

Remove remnants of code that assume Lengths are 28 bit integers.
​https://bugs.webkit.org/show_bug.cgi?id=67976

Reviewed by Eric Seidel.

Source/WebCore:

Test: LayoutTests/fast/table/max-width-integer-overflow-expected.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Bound by INT_MAX and INT_MIN instead of 28 bit bounds.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue):
Use PrimitiveValue::computeLength function directly.

  • platform/Length.h:

Remove 28 bit integer limit constants.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Use std::numeric_limits.

LayoutTests:

  • platform/mac/fast/table/max-width-integer-overflow-expected.png:
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt:
11:16 PM Changeset in webkit [111155] by shinyak@chromium.org
  • 18 edits in trunk

Should remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
​https://bugs.webkit.org/show_bug.cgi?id=79307

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since RuntimeEnabledFeatures::multipleShadowSubtreesEnabled was introduced for
temporal unstability of multiple shadow roots. We should remove it now, and
enable it by default.

Test: fast/dom/shadow/shadow-root-js-api.html should cover this change.
The other shadow related tests should also covers this change.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::addShadowRoot):

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Removed multipleShadowSubtresEnabled from tests.

  • fast/dom/shadow/get-element-by-id-in-shadow-root.html:
  • fast/dom/shadow/multiple-shadowroot-adopt.html:
  • fast/dom/shadow/multiple-shadowroot-rendering.html:
  • fast/dom/shadow/multiple-shadowroot.html:
  • fast/dom/shadow/shadow-element-rendering-multiple.html:
  • fast/dom/shadow/shadow-element-rendering-single.html:
  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
11:07 PM Changeset in webkit [111154] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark js-late-gradient-creation.svg as flaky

  • platform/chromium/test_expectations.txt:
10:23 PM Changeset in webkit [111153] by keishi@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix test that was broken by r111128

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST): ScrollByPixel no longer animates.

9:45 PM Changeset in webkit [111152] by keishi@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

[chromium] Rebaseline aria-checkbox-sends-notification.html

  • platform/chromium-win-xp/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
9:35 PM Changeset in webkit [111151] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

Skip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM flag is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=81336

Patch by Hayato Ito <​hayato@chromium.org> on 2012-03-18
Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/resources/shadow-dom.js:

(createDOM):
(isShadowRoot):

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
8:36 PM Changeset in webkit [111150] by kubo@profusion.mobi
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Include ICU_INCLUDE_DIRS when building.
​https://bugs.webkit.org/show_bug.cgi?id=81483

Reviewed by Daniel Bates.

So far, only the ICU libraries were being included when building
JavaScriptCore, however the include path is also needed, otherwise the
build will fail when ICU is installed into a non-standard location.

  • PlatformEfl.cmake: Include ${ICU_INCLUDE_DIRS}.
7:40 PM Changeset in webkit [111149] by hayato@chromium.org
  • 6 edits in trunk/LayoutTests

Skip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM flag is disabled.
​https://bugs.webkit.org/show_bug.cgi?id=81336

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/resources/shadow-dom.js:

(createDOM):
(isShadowRoot):

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
7:21 PM Changeset in webkit [111148] by keishi@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Rebaseline SL results for video-opacity-overlay.html and load-video-in-reflection.html

  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added.
7:12 PM Changeset in webkit [111147] by keishi@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] Rebaseline results for win shadow-drawing.html

  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added.
7:06 PM Changeset in webkit [111146] by keishi@webkit.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[chromium] Rebaseline to add expected results for fixed-position-scroll.html

  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-scroll-expected.png.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
6:07 PM Changeset in webkit [111145] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Don't occlude on main-thread behind layers/surfaces with impl-thread animations
​https://bugs.webkit.org/show_bug.cgi?id=81354

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-18
Reviewed by Adrienne Walker.

Source/WebCore:

Layers and surfaces can have an animating opacity or translation on the
impl thread. In this case, the main thread does not know their actual
values, and treats these values as "unknowns". This means we can't use
them for marking areas of the screen as occluded, and we can't consider
a part of a layer occluded in a space that we can not reliably transform
to.

Unit test: CCOcclusionTrackerTestAnimationOpacity0OnMainThread

CCOcclusionTrackerTestAnimationOpacity1OnMainThread
CCOcclusionTrackerTestAnimationTranslateOnMainThread

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::layerOpacityKnown):
(WebCore::layerTransformsToTargetKnown):
(WebCore::layerTransformsToScreenKnown):
(WebCore):
(WebCore::surfaceOpacityUnknown):
(WebCore::surfaceTransformsToTargetUnknown):
(WebCore::surfaceTransformsToScreenUnknown):
(WebCore::::finishedTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(WebCore::addOpacityAnimationToLayer):
(WebCore::addTransformAnimationToLayer):
(CCOcclusionTrackerTestAnimationOpacity1OnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(CCOcclusionTrackerTestAnimationOpacity0OnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(CCOcclusionTrackerTestAnimationTranslateOnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):

5:58 PM Changeset in webkit [111144] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Animating opacity is not opaque and should create a render surface on main thread
​https://bugs.webkit.org/show_bug.cgi?id=81401

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-18
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerOpacityIsOpaque):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

5:39 PM Changeset in webkit [111143] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

WebCore::BitmapImage::getCGImageRef should not be used off the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=81441

Reviewed by Anders Carlsson.

Covered by existing tests.

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
Add back main thread assertions.

  • platform/graphics/cg/PatternCG.cpp:

(PatternCallbackData):
(WebCore::patternCallback):
(WebCore::patternReleaseOnMainThreadCallback):
(WebCore::Pattern::createPlatformPattern):
Instead of pulling out the CGImageRef in the pattern callback, do it upfront.

5:31 PM UsingGitHub edited by abarth@webkit.org
(diff)
5:23 PM Changeset in webkit [111142] by ahf@0x90.dk
  • 2 edits in trunk/Source/WebCore

[Qt] Don't prepare SQL statements when the database is not open ​https://bugs.webkit.org/show_bug.cgi?id=81470

Reviewed by Kenneth Rohde Christiansen.

Already covered by existing tests.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::loadCookies):

4:50 PM Changeset in webkit [111141] by haraken@chromium.org
  • 13 edits
    3 deletes in trunk/Source/WebCore

Unreviewed, rolling out r110994 due to Chromium crash

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • notifications/DOMWindowNotifications.cpp: Removed.
  • notifications/DOMWindowNotifications.h: Removed.
  • notifications/DOMWindowNotifications.idl: Removed.
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl:
  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

4:39 PM Changeset in webkit [111140] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r111086.
​http://trac.webkit.org/changeset/111086
​https://bugs.webkit.org/show_bug.cgi?id=81374

Chromium crash

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrame):

4:07 PM Changeset in webkit [111139] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

Invalidation issue when creating backing layer for fixed positioned element.
​https://bugs.webkit.org/show_bug.cgi?id=80647

Patch by David Reveman <​reveman@chromium.org> on 2012-03-18
Reviewed by James Robinson.

Source/WebCore:

Ensure that root layer is correctly invalidated by handling scroll and
invalidation from movement of fixed position elements prior to creating
any backing layers.

Test: compositing/layer-creation/fixed-position-scroll.html

  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore):
(WebCore::FrameView::updateFixedElementsAfterScrolling):

  • page/FrameView.h:

(FrameView):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollTo):

  • platform/ScrollView.h:

(WebCore::ScrollView::repaintFixedElementsAfterScrolling):
(WebCore::ScrollView::updateFixedElementsAfterScrolling):

LayoutTests:

  • compositing/layer-creation/fixed-position-scroll.html: Added.
  • platform/chromium-linux/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
3:52 PM Changeset in webkit [111138] by noam.rosenthal@nokia.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph integration
​https://bugs.webkit.org/show_bug.cgi?id=81368

Reviewed by Simon Hausmann.

Moved the QtScenegraph integration classes to a separate file,
QtWebPageSGNode. The nodes created for QQuickWebPage now include
a QSGTransformNode that controls the contentsScale, a
QSGSimpleRectNode that controls the background color, and a
QSGRenderNode subclass that renders the actual contents.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::updatePaintNode):

  • UIProcess/qt/QtWebPageSGNode.cpp: Added.
  • UIProcess/qt/QtWebPageSGNode.h: Added.
2:58 PM Changeset in webkit [111137] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Transform animation state should be inherited from parents
​https://bugs.webkit.org/show_bug.cgi?id=81363

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-18
Reviewed by Adrienne Walker.

Source/WebCore:

Adds a drawTransformIsAnimating() and screenSpaceTransformIsAnimating()
to the layer classes, and similar to the surface classes. These inherit
the values from their parents in the same way that the transforms
themselves do, and reflect if the layer's transform is being affected
by some active animation.

These can be used in main-thread culling when determining if the layer's
position is static in the given coordinate space or being animated.

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::drawTransformIsAnimating):
(WebCore::LayerChromium::setDrawTransformIsAnimating):
(WebCore::LayerChromium::screenSpaceTransformIsAnimating):
(WebCore::LayerChromium::setScreenSpaceTransformIsAnimating):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::targetSurfaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::setTargetSurfaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::screenSpaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransformsAreAnimating):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::drawTransformIsAnimating):
(WebCore::CCLayerImpl::setDrawTransformIsAnimating):
(WebCore::CCLayerImpl::screenSpaceTransformIsAnimating):
(WebCore::CCLayerImpl::setScreenSpaceTransformIsAnimating):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::targetSurfaceTransformsAreAnimating):
(WebCore::CCRenderSurface::setTargetSurfaceTransformsAreAnimating):
(WebCore::CCRenderSurface::screenSpaceTransformsAreAnimating):
(WebCore::CCRenderSurface::setScreenSpaceTransformsAreAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::addOpacityAnimationToLayer):
(WebCore):
(WebCore::addTransformAnimationToLayer):
(WebCore::TEST):

12:28 PM Changeset in webkit [111136] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] The background is visible for tiles inside the contents area which are not ready
​https://bugs.webkit.org/show_bug.cgi?id=81349

Reviewed by Simon Hausmann.

Split PageProxyNode to BackgroundSGNode and ContentsSGNode.
BackgroundSGNode paints a solid background, either white or transparent
(depending on drawsTransparentBackground flag).

  • UIProcess/API/qt/qquickwebpage.cpp:

(ContentsSGNode):
(ContentsSGNode::ContentsSGNode):
(ContentsSGNode::changedStates):
(ContentsSGNode::~ContentsSGNode):
(BackgroundSGNode):
(BackgroundSGNode::BackgroundSGNode):
(BackgroundSGNode::contentsNode):
(QQuickWebPage::updatePaintNode):

12:17 PM Changeset in webkit [111135] by psolanki@apple.com
  • 3 edits in trunk/Source/WebCore

Fix compile when FULLSCREEN_API is not enabled on Mac
​https://bugs.webkit.org/show_bug.cgi?id=81474

Reviewed by Ada Chan.

Guard the full screen api code inside ENABLE(FULLSCREEN_API).

No new tests because no functional changes.

  • platform/mac/WebCoreFullScreenWindow.h:
  • platform/mac/WebCoreFullScreenWindow.mm:
11:47 AM Changeset in webkit [111134] by Lucas Forschler
  • 1 copy in tags/Safari-534.56.1

New tag.

9:59 AM Changeset in webkit [111133] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Change the initial buffer size of a plain text
​https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

r111109 changed the initial buffer size of a plain text
from 1<<16 to 1<<15 in Chromium/Mac only, for the following reasons:

  • As far as I experimented locally, while 1<<15 is better than 1<<16 in Chromium/Mac,

1<<15 and 1<<16 are the same in AppleWebKit/Mac and Chromium/Linux (their performance
"gap" exists at between 1<<17 and 1<<18).

  • The reason why I changed 1<<16 to 1<<15 in Chromium/Mac only is that

the value highly depends on the underlying malloc system and I was a bit afraid
that changing to 1<<15 _might_ cause unintentional performance regression in some
platform.

That being said, it seems that 1<<15 would not be worse than 1<<16 in all platforms,
and we should just keep the value consistent. In the first place, according to anttik
(who wrote 1<<16 a long time ago), there was no strong reason for 1<<16.

Based on these observations (See ​https://bugs.webkit.org/show_bug.cgi?id=81192
for more details), this patch unifies the value to 1<<15 in all platforms.

No tests. No change in behavior.

  • editing/TextIterator.cpp:

(WebCore::plainTextToMallocAllocatedBuffer):

4:33 AM Changeset in webkit [111132] by robert@webkit.org
  • 4 edits
    13 adds in trunk

CSS 2.1 failure: eof-003.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=78538

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: css2.1/20110323/eof-001.htm

css2.1/20110323/eof-003.htm
css2.1/20110323/eof-004.htm
css2.1/20110323/eof-005.htm
css2.1/20110323/eof-006.htm
css2.1/20110323/eof-007.htm

This patch fixes eof-003.htm, eof-005.htm and eof-006.htm. The other eof-* tests already pass.

  • css/CSSGrammar.y: Allow EOF as well as ';' to terminate import rules.

This should probably be done for other rules in a separate patch.

  • css/CSSParser.cpp:

(WebCore::CSSParser::checkAndSkipString): Allow strings to end with EOF.
(WebCore::CSSParser::parseString): ditto

LayoutTests:

  • css2.1/20110323/eof-001-expected.html: Added.
  • css2.1/20110323/eof-001.htm: Added.
  • css2.1/20110323/eof-003-expected.html: Added.
  • css2.1/20110323/eof-003.htm: Added.
  • css2.1/20110323/eof-004-expected.html: Added.
  • css2.1/20110323/eof-004.htm: Added.
  • css2.1/20110323/eof-005-expected.html: Added.
  • css2.1/20110323/eof-005.htm: Added.
  • css2.1/20110323/eof-006-expected.html: Added.
  • css2.1/20110323/eof-006.htm: Added.
  • css2.1/20110323/eof-007-expected.html: Added.
  • css2.1/20110323/eof-007.htm: Added.
  • css2.1/20110323/support/eof-green.css: Added.
1:18 AM FeatureFlags edited by tkent@chromium.org
(diff)
Note: See TracTimeline for information about the timeline view.