⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 24, 2012:

10:03 PM Changeset in webkit [112024] by nduca@chromium.org
  • 9 edits in trunk/Source

[chromium] Instrument gesture animations with async traces
​https://bugs.webkit.org/show_bug.cgi?id=82076

Reviewed by Adrienne Walker.

Source/WebCore:

  • platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::~ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurve.h:

(PlatformGestureCurve):

  • platform/TouchpadFlingPlatformGestureCurve.h:

(WebCore::TouchpadFlingPlatformGestureCurve::debugName):

  • platform/WheelFlingPlatformGestureCurve.h:

(WebCore::WheelFlingPlatformGestureCurve::debugName):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::~CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurve):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebCore::PlatformGestureToCCGestureAdapter::debugName):
(PlatformGestureToCCGestureAdapter):

9:24 PM Changeset in webkit [112023] by jpfau@apple.com
  • 6 edits in trunk

XML error document creation should not fire mutation events
​https://bugs.webkit.org/show_bug.cgi?id=80765

Reviewed by Adam Barth.

Source/WebCore:

Broke two tests that expected the old behavior, which have now been updated.

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

LayoutTests:

Fixed tests that relied on old behavior.

  • fast/css/stylesheet-candidate-nodes-crash-expected.txt:
  • fast/css/stylesheet-candidate-nodes-crash.xhtml:
  • fast/dom/xml-parser-error-message-crash-expected.txt:
9:08 PM Changeset in webkit [112022] by commit-queue@webkit.org
  • 11 edits
    3 adds in trunk

ForeignObject content is zoomed two times
​https://bugs.webkit.org/show_bug.cgi?id=76282

Patch by Florin Malita <​fmalita@google.com> on 2012-03-24
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/zoom/page/zoom-foreign-content.svg

Reset the effective zoom property for FO-nested content to avoid
having the zoom factor applied multiple times (zooming is handled by
the top level SVG root element).

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

LayoutTests:

  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:

Rebaseline cr-linux expectations.

  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:

Updated zoom-foreignObject.svg expectations, pending rebaseline.

  • svg/zoom/page/zoom-foreign-content-expected.png: Added.
  • svg/zoom/page/zoom-foreign-content-expected.txt: Added.
  • svg/zoom/page/zoom-foreign-content.svg: Added.
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/text/zoom-foreignObject.svg:

Updated test to cover SVG FO text.

9:03 PM Changeset in webkit [112021] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AX: Support solution to handle invalid ax text marker
​https://bugs.webkit.org/show_bug.cgi?id=82023

Reviewed by Oliver Hunt.

Source/WebCore:

This provides methods to better use text markers so that assistive technologies
can know when they are valid, and can convert them to and from absolute positions.

Test: platform/mac/accessibility/textmarker-routines.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(indexForTextMarkerCallback):
(isTextMarkerValidCallback):
(textMarkerForIndexCallback):
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::isTextMarkerValid):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::isTextMarkerValid):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):

LayoutTests:

  • platform/mac/accessibility/textmarker-routines-expected.txt: Added.
  • platform/mac/accessibility/textmarker-routines.html: Added.
8:59 PM Changeset in webkit [112020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Quick fix for rendering controls regression.
​https://bugs.webkit.org/show_bug.cgi?id=82125

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-24
Reviewed by Eric Carlson.

Only temporary fix. Tests to cover the problem should be added

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeOpaque): The display:none
property should be toggled only by the media element now.
(WebCore::MediaControlPanelElement::makeTransparent): The timer
that toggles the dispalay:none shouldn't be used now.

8:50 PM Changeset in webkit [112019] by kov@webkit.org
  • 12 edits in trunk/Tools

Unreviewed, rolling out r112014.
​http://trac.webkit.org/changeset/112014
​https://bugs.webkit.org/show_bug.cgi?id=82138

Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-24

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_http_locking):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(AbstractWorker.run):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):

  • Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:

(WorkerTest.test_default_platform_in_worker):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.is):
(MeteredStream.init):
(MeteredStream.write):
(MeteredStream.update):
(MeteredStream._overwrite):
(MeteredStream._reset):

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(TestMeteredStream):
(TestMeteredStream.test_regular):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(_configure_logging):
(_restore_logging):
(Printer.init):
(Printer.cleanup):
(Printer.print_progress):
(Printer.print_update):
(Printer._write):
(Printer):
(Printer._update):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.get_printer):
(Testprinter.test_print_progress):
(Testprinter.test_print_progress.mock_time):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_pause_before_testing):

7:29 PM Changeset in webkit [112018] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 64-bit Branch implementation should not be creating a JSValueOperand that
it isn't going to use
​https://bugs.webkit.org/show_bug.cgi?id=82136

Reviewed by Geoff Garen.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

6:41 PM Changeset in webkit [112017] by kevino@webkit.org
  • 7 edits in trunk

[wx] Unreviewed. Fix the build after WTF move.

6:32 PM Changeset in webkit [112016] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed. Add header needed for compilation.

5:46 PM Changeset in webkit [112015] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG double voting may be overzealous in the case of variables that end up
being used as integers
​https://bugs.webkit.org/show_bug.cgi?id=82008

Reviewed by Oliver Hunt.

Cleaned up propagation, making the intent more explicit in most places.
Back-propagate NodeUsedAsInt for cases where a node was used in a context
that is known to strongly prefer integers.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):

2:22 PM Changeset in webkit [112014] by dpranke@chromium.org
  • 12 edits in trunk/Tools

clean up NRWT logging/metering, be less verbose
​https://bugs.webkit.org/show_bug.cgi?id=73846

Reviewed by Ojan Vafai.

This patch totally rewrites the metered_stream module and
changes the way it and the printing module now interact with the
logging subsystem.

The printing module becomes a dumb layout_tests-specific wrapper around
the metered stream. All of the intelligence of how and when to
actually write (or erase) lines and how things interact with
logging moves into the metered stream.

As of now, anything written to the metered stream *bypasses the
logging system*. If a logger is passed to the meter constructor,
the metered stream will also attach a log handler so that all
messages fed to the logger will also be written to the metered
stream. This detangles the logic that used to exist where
sometimes the meter would write to the logger and sometimes the
logger would write to the meter.

All of this makes the logic generic and reusable for
test-webkitpy (coming in another patch). It also helps clarify
what the mysterious "configure_logging" parameter to the printer
constructor used to do (that parameter itself is gone now, and
by default the printer and metered_stream will not ever touch
the logging system; this makes a bunch of tests less fragile).

All of the above should produce no user-visible changes.

However, to also fix the bug in question, we change the message
format in --verbose mode to %H:%M:%S.%frac %pid %message,
eliminating the date, file:lineno, and level parameters. I am
making this change at the same time because it would be
difficult to write things consistently between the logs and the
metered stream if we were still logging the file:lineno.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Remove the configure_logging parameter
  • Scripts/webkitpy/layout_tests/controllers/worker.py: Use metered stream to configure the logging (we don't need a printer) and be careful about when and how we manipulate the log level and handlers on the root logger.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Pass in the root logger so that log messages are formatted properly, and set the log level outside of any routines called by unit tests so as to not interfere.
  • Scripts/webkitpy/layout_tests/views/manager_worker_broker.py: remove a duplicate log message.
  • Scripts/webkitpy/layout_tests/views/metered_stream.py: complete rewrite :).
  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: complete rewrite :).
  • Scripts/webkitpy/layout_tests/views/printing.py: move the logging configuration into metered_stream, and also move the "when should I log progress messages" into metered stream.
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py: remove tests that are no longer necessary.
  • Scripts/webkitpy/performance_tests/perftestsrunner.py: remove the configure_logging parameter.
  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: update the test; since the printer no longer writes to the log, we need to check what is written to the regular_output instead. (test_run_test_pause_before_testing):
1:15 PM Changeset in webkit [112013] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::Node::shouldNotSpeculateInteger() should be eliminated
​https://bugs.webkit.org/show_bug.cgi?id=82123

Reviewed by Geoff Garen.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(Node):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

1:03 PM Changeset in webkit [112012] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash in ApplyStyleCommand::applyInlineStyleToNodeRange.
​https://bugs.webkit.org/show_bug.cgi?id=81959

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/execCommand/apply-style-command-crash.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): RefPtr the weak
node iterator |node|.

  • editing/ApplyStyleCommand.h:

(ApplyStyleCommand): convert |startNode| and |pastEndNode| into PassRefPtr.

LayoutTests:

  • editing/execCommand/apply-style-command-crash-expected.txt: Added.
  • editing/execCommand/apply-style-command-crash.html: Added.
12:13 PM Changeset in webkit [112011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Increase getByIdSlowCase ConstantSpace/InstructionSpace for CPU(ARM_TRADITIONAL)
​https://bugs.webkit.org/show_bug.cgi?id=81521

Increase sequenceGetByIdSlowCaseConstantSpace and sequenceGetByIdSlowCaseInstructionSpace
for CPU(ARM_TRADITIONAL) to fit actual need.

Patch by Yong Li <​yoli@rim.com> on 2012-03-24
Reviewed by Oliver Hunt.

  • jit/JIT.h:

(JIT):

10:08 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:06 AM Changeset in webkit [112010] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 112002

10:05 AM Changeset in webkit [112009] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 112001

10:05 AM Changeset in webkit [112008] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Reverting r90755 (Merging 112000)

10:04 AM Changeset in webkit [112007] by kov@webkit.org
  • 1 edit
    1 add in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 111999

10:02 AM Changeset in webkit [112006] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 111998

10:02 AM Changeset in webkit [112005] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 111997.

10:01 AM Changeset in webkit [112004] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/gtk

[GTK] Replace occurrences of "uri" in the documentation with "URI"
​https://bugs.webkit.org/show_bug.cgi?id=82025

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

In documentation "uri" should really be written as "URI" so
we should fix all existing strings.

  • webkit/webkitdownload.cpp: Replace "uri" with "URI."
  • webkit/webkitnetworkrequest.cpp: Ditto.
  • webkit/webkitnetworkresponse.cpp: Ditto.
  • webkit/webkitwebhistoryitem.cpp: Ditto.
  • webkit/webkitwebresource.cpp: Ditto.

(webkit_web_resource_class_init):

10:00 AM Changeset in webkit [112003] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging r111996.

9:51 AM Changeset in webkit [112002] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated German translation
​https://bugs.webkit.org/show_bug.cgi?id=77834

Patch by Christian Kirbach <​Christian.Kirbach@googlemail.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • de.po:
9:46 AM Changeset in webkit [112001] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated Norwegian bokmål translation for webkitgtk
​https://bugs.webkit.org/show_bug.cgi?id=73891

Patch by Kjartan Maraas <​kmaraas@gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • nb.po:
9:37 AM Changeset in webkit [112000] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed, rolling out r90755.
​http://trac.webkit.org/changeset/90755
​https://bugs.webkit.org/show_bug.cgi?id=44410

This is actually less up-to-date then the one we committed
before

  • id.po:
9:32 AM Changeset in webkit [111999] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

[l10n] [mr] WebKitGTK+ Marathi Translations
​https://bugs.webkit.org/show_bug.cgi?id=82014

Patch by Sandeep Shedmake <​sshedmak@redhat.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • mr.po: Added.
9:26 AM Changeset in webkit [111998] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated en_GB translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=82093

Patch by Chris Leonard <​cjl@laptop.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • en_GB.po:
9:21 AM Changeset in webkit [111997] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Add Galician translations for webkitgtk
​https://bugs.webkit.org/show_bug.cgi?id=67591

Patch by Fran Dieguez <​frandieguez@gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • gl.po:
9:11 AM Changeset in webkit [111996] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Slovenian translation update
​https://bugs.webkit.org/show_bug.cgi?id=68504

Patch by Matej Urbančič <​mateju@svn.gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • sl.po:
9:08 AM Changeset in webkit [111995] by kov@webkit.org
  • 2 edits in trunk/Tools

Add myself and Martin Robinson to: * GStreamerGraphics * GtkWebKit2PublicAPI * SoupNetwork and to the newly created WebKitGTKTranslations.

Rubber-stamped by Martin Robinson.

  • Scripts/webkitpy/common/config/watchlist:
8:36 AM Changeset in webkit [111994] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2012-03-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: restoring chromium's expectations for effect-custom-parameters-expected.png.

  • platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
8:23 AM Changeset in webkit [111993] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] Implement PageClient::isViewWindowActive()
​https://bugs.webkit.org/show_bug.cgi?id=81143

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-03-24
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

6:34 AM Changeset in webkit [111992] by jesus@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix since we use "-Werror=unused-but-set-variable".

The variable 'it' was set at TextureMapperShaderManager.h:110 but never used.

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderManager::getShaderProgram):

4:51 AM Changeset in webkit [111991] by pfeldman@chromium.org
  • 13 edits
    3 adds in trunk/LayoutTests

Updated chromium baselines wrt button selection changes in r111946.
Not reviewed.

  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-win-vista/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-win-vista/editing/selection/3690703-expected.png: Added.
  • platform/chromium-win-vista/editing/selection/3690719-expected.png: Added.
3:45 AM Changeset in webkit [111990] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updating chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:07 AM Changeset in webkit [111989] by mitz@apple.com
  • 1 edit
    4 copies in trunk/LayoutTests

Added Mac expected results for these two tests. The results were accidentally removed in
r111545, even though these tests were not converted into reftests.

  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Copied from LayoutTests/platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Copied from LayoutTests/platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt.
1:54 AM Changeset in webkit [111988] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added Mac expected results for this test that was added in r111139.

  • platform/mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/mac/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
1:49 AM Changeset in webkit [111987] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added Mac expected results for this test that was added in r111946.

  • platform/mac/editing/selection/selection-button-text-expected.png: Added.
  • platform/mac/editing/selection/selection-button-text-expected.txt: Added.
1:37 AM Changeset in webkit [111986] by zeno.albisser@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][WK2] Make TextureMapperShaderManager::getShaderProgram() not be a template.
​https://bugs.webkit.org/show_bug.cgi?id=82049

Change the getShaderProgram() function to not be a template.
This is a workaround for a compiler bug that leads to an assert
when compiling in debug mode on mac.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::beginClip):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(TextureMapperShaderManager):

1:36 AM Changeset in webkit [111985] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
1:10 AM Changeset in webkit [111984] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
12:01 AM Changeset in webkit [111983] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:

Mar 23, 2012:

11:51 PM Changeset in webkit [111982] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] Incorrect replica originTransform used in CCDamageTracker
​https://bugs.webkit.org/show_bug.cgi?id=82118

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCDamageTrackerTest.cpp

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

11:44 PM Changeset in webkit [111981] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
11:27 PM Changeset in webkit [111980] by pfeldman@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

Not reviewed: adding chromium baselines.

  • platform/chromium-linux/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-linux/editing/selection/selection-button-text-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Added.
  • platform/chromium-win-vista/editing/selection/selection-button-text-expected.png: Added.
  • platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt: Added.
11:22 PM Changeset in webkit [111979] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
10:54 PM Changeset in webkit [111978] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] When prepainting fails, tiles dirty rects may be cleared
​https://bugs.webkit.org/show_bug.cgi?id=82107

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.

Source/WebCore:

When prepainting, if a tile is unable to be reserved due to memory
limits, we bail out of prepareToUpdateTiles. But we would have
cleared the dirty rect of any previous tiles. This leaves them
in a bad state where their textures are reserved, but their textureIds
are set to 0, and they are not marked dirty. This means that they will
not be updated and displayed if they become visible, since it is
assumed that valid textures with zero textureId must have a dirty
region.

We fix this by not clearing the dirty rects until we know we are
going to update the layer.

Unit test: TiledLayerChromiumTest.pushTilesAfterIdlePaintFailed

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::hasTextureIdForTileAt):
(WebCore):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTextureAllocator::createTexture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(FakeCCTiledLayerImpl):
(WTF::FakeCCTiledLayerImpl::hasTextureIdForTileAt):
(WTF::TEST):
(WTF):

10:21 PM Changeset in webkit [111977] by Stephanie Lewis
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=81963 WebProcess can get stuck in GC during many low memory signals.
<rdar://problem/11094830> WebProcess appears to get stuck in its GC handler (81963).
Remove the call to garbage collect in low memory signal handler. Did some testing with hitting the low memory handler
during Membuster and we would get back at most 100k - 200k. That isn't enough to help the system, and in
that state the GC collection can take a substantial amount of time.

Reviewed by Geoff Garen.

Performance Change, no change in behavior.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

9:07 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
9:04 PM Changeset in webkit [111976] by Martin Robinson
  • 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/Element.cpp

Fix a bad merge.

8:30 PM Changeset in webkit [111975] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated the Mac expected results for this test after CSS shaders were disabled in r111893.
WebKitCSSFilterValue.CSS_FILTER_CUSTOM is no longer defined.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
8:23 PM Changeset in webkit [111974] by fpizlo@apple.com
  • 9 edits
    2 adds in trunk/Source/JavaScriptCore

DFG Fixup should be able to short-circuit trivial ValueToInt32's
​https://bugs.webkit.org/show_bug.cgi?id=82030

Reviewed by Michael Saboff.

Takes the fixup() method of the prediction propagation phase and makes it
into its own phase. Adds the ability to short-circuit trivial ValueToInt32
nodes, and mark pure ValueToInt32's as such.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCommon.h:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp: Added.

(DFG):
(FixupPhase):
(JSC::DFG::FixupPhase::FixupPhase):
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::performFixup):

  • dfg/DFGFixupPhase.h: Added.

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(PredictionPropagationPhase):

8:11 PM Changeset in webkit [111973] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

tryReallocate could break the zero-ed memory invariant of CopiedBlocks
​https://bugs.webkit.org/show_bug.cgi?id=82087

Reviewed by Filip Pizlo.

Removing this optimization turned out to be ~1% regression on kraken, so I simply
undid the modification to the current block if we fail.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryReallocate): Undid the reset in the CopiedAllocator if we fail
to reallocate from the current block.

7:27 PM Changeset in webkit [111972] by ojan@chromium.org
  • 1 edit
    5 moves
    4 adds
    37 deletes in trunk/LayoutTests

Fix more Chromium 10.6/10.5 tests that broke with r111917. There's a bug
with garden-o-matic when rebaselining all the Chromium Mac ports.
Other ports seem fine.

7:23 PM Changeset in webkit [111971] by wjmaclean@chromium.org
  • 4 edits in trunk/Source

[chromium] CCLayerTreeHostImpl::scrollBegin() should return ScrollFailed for CCInputHandlerClient::Gesture type when wheel handlers found.
​https://bugs.webkit.org/show_bug.cgi?id=82106

Reviewed by Adrienne Walker.

Source/WebCore:

Existing unit tests updated.

With gesture scroll events now being handled as mouse wheel events, we should not start a gesture scroll when
wheel handlers are present.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollBegin):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

7:22 PM Changeset in webkit [111970] by Martin Robinson
  • 3 edits
    1 add
    1 delete in releases/WebKitGTK/webkit-1.8

Merging r111882

7:20 PM Changeset in webkit [111969] by abarth@webkit.org
  • 12 edits
    3 adds in trunk/Source/WebCore

Move Notifications APIs from WorkerContext.idl to WorkerContextNotifications.idl
​https://bugs.webkit.org/show_bug.cgi?id=79635

Reviewed by Kentaro Hara.

This patch moves the NotificationCenter from WorkerContext to
WorkerContextNotificiations, reducing clutter in WorkerContext. After
this patch, Notifications are almost entirely contained in the
notifications directory.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::~WorkerContext):

  • workers/WorkerContext.h:

(WebCore):
(WorkerContext):

  • workers/WorkerContext.idl:
7:15 PM Changeset in webkit [111968] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] RootLayer was not being checked for null causing segfaults very rarely.
​https://bugs.webkit.org/show_bug.cgi?id=82111

Patch by Michal Mocny <​mmocny@google.com> on 2012-03-23
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

7:13 PM Changeset in webkit [111967] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r111400

7:12 PM Changeset in webkit [111966] by Martin Robinson
  • 46 edits
    2 adds
    25 deletes in releases/WebKitGTK/webkit-1.8

Merging r111361

6:39 PM Changeset in webkit [111965] by Martin Robinson
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110938

6:38 PM Changeset in webkit [111964] by Martin Robinson
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110925

6:28 PM Changeset in webkit [111963] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] Fix race bug that clobbers CCLayerImpl updateRect
​https://bugs.webkit.org/show_bug.cgi?id=82109

Reviewed by Dirk Pranke.

Source/WebCore:

If the main thread commits twice before the impl thread actually
draws, then the updateRect of the first frame gets lost forever,
and not propagated to the damage tracker.

The solution is to accumulate the updateRect. The CCLayerImpl
updateRect is already being correctly cleared at the appropriate
time after drawing.

Unit test added to LayerChromiumTest.cpp.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

Source/WebKit/chromium:

  • tests/LayerChromiumTest.cpp:
6:25 PM Changeset in webkit [111962] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r110888

6:13 PM Changeset in webkit [111961] by ojan@chromium.org
  • 2 edits
    11 moves
    3 adds
    66 deletes in trunk

Fix Chromium 10.6/10.5 tests that broke with r111917. There's a bug
with garden-o-matic when rebaselining all the Chromium Mac ports.
Other ports seem fine.

6:13 PM Changeset in webkit [111960] by Martin Robinson
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110598

6:12 PM Changeset in webkit [111959] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source/WebKit/blackberry

[BlackBerry] Add WebPageCompositor class to BlackBerry WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=81121
RIM PR: 136687

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-03-23
Reviewed by Rob Buis.

The idea is for the API client to use a WebPageCompositor object to
render the WebPage when there's no screen window available.

The WebPageCompositorPrivate becomes reference counted in order to be
kept alive either because it's used for accelerated compositing layers
or used for the WebPageCompositor API. It can still work standalone.

Clean up some code - no need to keep track of a separate boolean
WebPagePrivate::m_isAcceleratedCompositingActive when the state of
m_compositor can tell you.

Also remove duplicated code from WebPagePrivate - go directly to the
compositor object instead, if you need to draw the AC layers.

Reviewed internally by Robin Cao and the hasBlitJobs/blitOnIdle change
by Filip Spacek.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::hasBlitJobs):
(BlackBerry::WebKit::BackingStore::blitOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
(BlackBerry::WebKit::BackingStorePrivate::buffer):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):

  • Api/WebPage.h:
  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
(BlackBerry::WebKit::WebPageCompositorPrivate::compositorDestroyed):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::client):
(BlackBerry::WebKit::WebPageCompositor::prepareFrame):
(BlackBerry::WebKit::WebPageCompositor::render):
(BlackBerry::WebKit::WebPageCompositor::cleanup):
(BlackBerry::WebKit::WebPageCompositor::contextLost):

  • Api/WebPageCompositor.h: Added.
  • Api/WebPageCompositorClient.h: Added.
  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::create):
(BlackBerry::WebKit::WebPageCompositorPrivate::context):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameTimestamp):
(BlackBerry::WebKit::WebPageCompositorPrivate::page):
(BlackBerry::WebKit::WebPageCompositorPrivate::client):

  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::client):
(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(BlackBerry::WebKit::WebPagePrivate::compositor):

6:11 PM Changeset in webkit [111958] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110401

6:10 PM Changeset in webkit [111957] by Martin Robinson
  • 3 edits in releases/WebKitGTK/webkit-1.8

Merging r110331

6:08 PM Changeset in webkit [111956] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110243

6:07 PM Changeset in webkit [111955] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r110178.diff

6:06 PM Changeset in webkit [111954] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110065

6:04 PM Changeset in webkit [111953] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r110063

6:03 PM Changeset in webkit [111952] by Martin Robinson
  • 6 edits
    4 adds in releases/WebKitGTK/webkit-1.8

Merging r109594

6:00 PM BuildingGtk edited by kov@webkit.org
(diff)
5:58 PM Changeset in webkit [111951] by Martin Robinson
  • 9 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r109593

5:58 PM Changeset in webkit [111950] by rafaelw@chromium.org
  • 6 edits in trunk

[MutationObservers] attributeFilter should be case sensitive at all times
​https://bugs.webkit.org/show_bug.cgi?id=81822

Reviewed by Ryosuke Niwa.

Source/WebCore:

This removes the behavior in MutationObserverRegistration which treats
attributeFilter as case insensitive for HTML elements in HTML documents.

Relevant tests have been updated.

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h:

(MutationObserverRegistration):

LayoutTests:

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
5:55 PM Changeset in webkit [111949] by haraken@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Move WebSocket APIs from WorkerContext.idl to WorkerContextWebSocket.idl
​https://bugs.webkit.org/show_bug.cgi?id=79663

Reviewed by Adam Barth.

For WebKit modularization, this patch moves WebSocket APIs from WorkerContext.idl
to WorkerContextWebSocket.idl.

Tests: http/tests/websocket/tests/hybi/workers/* (No change in test results)

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/websockets/WorkerContextWebSocket.idl: Added.
  • WebCore.gypi:
  • WebCore.xcodeproj/project.xcodeproj:
  • workers/WorkerContext.idl:
5:55 PM Changeset in webkit [111948] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r109543

5:54 PM Changeset in webkit [111947] by Martin Robinson
  • 4 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merging r109503

5:54 PM Changeset in webkit [111946] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

REGRESSION: can select text of an input button
​https://bugs.webkit.org/show_bug.cgi?id=13624

Patch by Parag Radke <​parag@motorola.com> on 2012-03-23
Reviewed by Ryosuke Niwa.

Source/WebCore:

Text in a button should never have a selection background of its own painted
but if the button is inside an editable area, then the whole button should
have it's selection background painted.

Test: editing/selection/selection-button-text.html

  • rendering/RenderButton.h:

Added implementation for the virtual function canBeSelectionLeaf()
which returns true if the button renderer is editable, false other wise.

  • rendering/RenderTextFragment.h:

Added implementation for the virtual function canBeSelectionLeaf()
which returns true if the text fragment renderer is editable, false other wise.

LayoutTests:

Added a pixel test case to test the selection background for button label text.

  • editing/selection/selection-button-text.html: Added.
  • platform/gtk/editing/selection/selection-button-text-expected.png: Added.
  • platform/gtk/editing/selection/selection-button-text-expected.txt: Added.
5:53 PM Changeset in webkit [111945] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: don't wait for safari to exit before exiting after showing the results file
​https://bugs.webkit.org/show_bug.cgi?id=81845

Reviewed by Ryosuke Niwa.

Prior to this change, if you ran new-run-webkit-tests and
displayed the HTML results file at the end, we would block
waiting for the user to quit the browser. There doesn't seem to
be a need for that, and the Chromium ports don't do this.

Also, update the mac tests to capture the output and be quiet :).

  • Scripts/webkitpy/common/system/executive_mock.py: Make popen() testable, implement should_log for it.
  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py: Silence some of the tests via outputcapture.
5:52 PM Changeset in webkit [111944] by Martin Robinson
  • 5 edits
    4 adds in releases/WebKitGTK/webkit-1.8

Merging r109480

5:51 PM Changeset in webkit [111943] by Martin Robinson
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging r109034

5:44 PM Changeset in webkit [111942] by Martin Robinson
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merging r109021

5:34 PM Changeset in webkit [111941] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary ASSERT from LoadableTextTrack::trackElementIndex
​https://bugs.webkit.org/show_bug.cgi?id=82095

Reviewed by Dan Bernstein.

No new tests, removed a bogus ASSERT that was sometimes triggered by tests.

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::trackElementIndex): Remove ASSERT.

5:32 PM Changeset in webkit [111940] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r108878

5:30 PM Changeset in webkit [111939] by Martin Robinson
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r108668

5:29 PM Changeset in webkit [111938] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Layout Test media/video-source-load.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=82094

Reviewed by Alexey Proskuryakov.

No new tests, tested by media/video-source-load.html.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::sourceWasAdded): Set m_nextChildNodeToConsider when called

with networkState == NETWORK_EMPTY because the resource selection algorithm has
not started yet.

5:25 PM Changeset in webkit [111937] by Martin Robinson
  • 8 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merging r108574

5:24 PM Changeset in webkit [111936] by Martin Robinson
  • 6 edits
    14 adds in releases/WebKitGTK/webkit-1.8

Merging r108494

5:23 PM Changeset in webkit [111935] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r108490

5:22 PM Changeset in webkit [111934] by mitz@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Added Mac WebKit2 expected results for this test. The fact that it is failing is tracked by
<​http://webkit.org/b/82020>.

  • platform/mac-wk2/plugins/netscape-dom-access-and-reload-expected.txt: Added.
5:09 PM Changeset in webkit [111933] by rniwa@webkit.org
  • 3 edits in branches/chromium/1025/Source/WebCore/dom

Merge r110925 into 1025 branch.

5:01 PM Changeset in webkit [111932] by Martin Robinson
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r108417

4:55 PM Changeset in webkit [111931] by ap@apple.com
  • 8 edits in trunk/Source

[Mac] No need for platform-specific ENABLE_BLOB values
​https://bugs.webkit.org/show_bug.cgi?id=82102

Reviewed by David Kilzer.

  • Configurations/FeatureDefines.xcconfig:
4:41 PM Changeset in webkit [111930] by tkent@chromium.org
  • 5 edits
    2 adds in trunk/Source/WebCore

Add TextFieldDecorator and TextFieldDecorationElement
​https://bugs.webkit.org/show_bug.cgi?id=80580

Reviewed by Dimitri Glazkov.

These classes will be used to add a decoration icon to a text field
<input> from outside of WebCore. We have a plan to use them in Chromium
port. So this patch doesn't add TextFieldDecorationElement.{cpp,h} to
non-Chromium build files.

How it works:
When a shadow subtree for a text field is created, we ask ChromeClient
to decorate it. ChromeClient appends a TextFieldDecorationElement to the
existing shadow subtree or another shadow tree. A TextFieldDecorator is
associated to a TextFieldDecorationElement, and it provides decoration
icon images and a click handler.

No new tests. This patch won't make any behavior change for now.

  • WebCore.gypi: Add TextFieldDecorationElement.cpp and TextFieldDecorationElement.h
  • dom/Element.h:

(WebCore::Element::isTextFieldDecoration):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
Calls ChromeClient::willAddTextFieldDecorationsTo() and addTextFieldDecorationsTo().

  • html/shadow/TextFieldDecorationElement.cpp: Added.

(WebCore::TextFieldDecorator::~TextFieldDecorator):
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::create):
(WebCore::TextFieldDecorationElement::isTextFieldDecoration):
(WebCore::TextFieldDecorationElement::updateImage):
(WebCore::TextFieldDecorationElement::customStyleForRenderer):
Sets the size to a square of the font-size.
(WebCore::TextFieldDecorationElement::createRenderer):
Always creates a RenderImage.
(WebCore::TextFieldDecorationElement::attach):
Sets an image for appropriate state.
(WebCore::TextFieldDecorationElement::isMouseFocusable):
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Delegate a click event to the corresponding function of TextFieldDecorator.

  • html/shadow/TextFieldDecorationElement.h: Added.

(TextFieldDecorator): Added.
(TextFieldDecorationElement): Added.
(WebCore::toTextFieldDecorationElement): Added.

  • page/ChromeClient.h:

(WebCore::ChromeClient::willAddTextFieldDecorationsTo): Add an empty implementation.
(WebCore::ChromeClient::addTextFieldDecorationsTo): ditto.

4:31 PM Changeset in webkit [111929] by kov@webkit.org
  • 4 edits in trunk/Tools

[GTK] libgcrypt and p11-kit should not be in jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=82073

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged): new function that isolates the
jhbuild configuration change checking from the autogen logic.
(mustReRunAutogen): code for the new function lived here.
(buildAutotoolsProject): now calls jhbuildConfigurationChanged
itself, and cleans up the jhbuild root if configuration has
changed; it also forces autogen to be run in that case, to
make sure the new libraries are used.

  • gtk/jhbuild.modules: removed libgcrypt and p11-kit.
  • jhbuild/jhbuild-wrapper:

(ensure_jhbuild): this might be run inside a jhbuild environment,
in which case aclocal fails when trying to use the now deleted
aclocal directory in the jhbuild prefix, so work around that.

4:08 PM Changeset in webkit [111928] by kareng@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebKit/chromium/features.gypi

Revert 111620 - Revert 103349 - enable USE_SKIA_TEXT by default, replacing GDI for all text drawing
​https://bugs.webkit.org/show_bug.cgi?id=74928

Reviewed by Stephen White.

  • features.gypi:

TBR=​reed@google.com
Review URL: ​https://chromiumcodereview.appspot.com/9832001

TBR=​kareng@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9837068

4:00 PM Changeset in webkit [111927] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r108851.
​http://trac.webkit.org/changeset/108851
​https://bugs.webkit.org/show_bug.cgi?id=82098

"Revert the addition of unnecessary, deprecated functions in
WKPreferences.h" (Requested by estes on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-23

  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKPreferences.h:
3:54 PM Changeset in webkit [111926] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test_expectations update for chromium.

  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [111925] by adamk@chromium.org
  • 5 edits
    2 adds in trunk

Match DOM4 spec with respect to DocumentFragment insertion
​https://bugs.webkit.org/show_bug.cgi?id=82089

Reviewed by Ryosuke Niwa.

Source/WebCore:

DOM4 specifies the behavior of appendChild, insertBefore, and replaceChild
in terms of "mutation algorithms":

​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#mutation-algorithms

This change updates WebKit to match, in particular with regard to DocumentFragments.
Previously, ContainerNode would remove nodes one at a time, then add them to the new parent.
When combined with MutationObservers, this results in overly-verbose mutation records.
Now we create as few records as possible, matching the spec as well as Gecko's implementation
of MutationObservers.

Note that we still need to check validity each time through the loop,
since inserting a node may dispatch events. In a future change, I hope
to move these events so that they fire only after all nodes are inserted,
but that's too much to tackle all in one.

Tests: fast/mutation/document-fragment-insertion.html

  • dom/ContainerNode.cpp:

(WebCore::collectChildrenAndRemoveFromOldParent): New helper method
combining collectTargetNodes() with the removal of the collected nodes from
their old parent, if any.
(WebCore::ContainerNode::insertBefore): Use new helper method instead
of removing nodes one at a time from the fragment.
(WebCore::ContainerNode::replaceChild): ditto. Also removed some redundant asserts
and moved the "do nothing" check out of the loop.
(WebCore::ContainerNode::appendChild): Use new helper method.

LayoutTests:

  • fast/dom/Node/fragment-mutation-expected.txt:
  • fast/dom/Node/fragment-mutation.html: Removed tests that no longer make sense

since the DocumentFragment has no children by the time DOMSubtreeModified is called.

  • fast/mutation/document-fragment-insertion-expected.txt: Added.
  • fast/mutation/document-fragment-insertion.html: Added.
3:44 PM Changeset in webkit [111924] by kareng@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebKit/chromium/features.gypi

Revert 111450 - disabling Mutation Observers on Chromium branch 1025

TBR=​rafaelw@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9845042

3:43 PM Changeset in webkit [111923] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline of css3 filter test for chromium linux.

  • platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
3:41 PM Changeset in webkit [111922] by senorblanco@chromium.org
  • 4 edits
    1 add in trunk

[skia] Switch to Skia's implementation of the feMorphology filter.
​https://bugs.webkit.org/show_bug.cgi?id=82085

Reviewed by Dirk Schulze.

Covered by existing tests in svg/filters/.

  • WebCore.gypi:
  • platform/graphics/filters/FEMorphology.h:

(FEMorphology):

  • platform/graphics/filters/skia/FEMorphologySkia.cpp: Added.

(WebCore):
(WebCore::FEMorphology::platformApplySkia):

3:37 PM Changeset in webkit [111921] by mitz@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Putting the y in 'already'

3:35 PM Changeset in webkit [111920] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 3)
​https://bugs.webkit.org/show_bug.cgi?id=82027

Reviewed by Kentaro Hara.

Rather than watching for willDetachPage, NotificationCenter can just
override ActiveDOMObject::stop directly to be notified when it needs to
stop.

Switching NotificationCenter over to using ActiveDOMObject callbacks
frees DOMWindowNotification to implement reconnectFrame. However, this
is only really a victory in princple because NotificationCenter always
returns false for canSuspend(), which means we'll never actually use
the reconnectFrame functionality. However, this patch does move us
closer to the time when NotificationCenter can implement
ActiveDOMObject::suspend/resume to play nice with the PageCache.

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrame):
(WebCore::DOMWindowNotifications::reconnectFrame):

  • notifications/DOMWindowNotifications.h:

(DOMWindowNotifications):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::stop):

  • notifications/NotificationCenter.h:

(NotificationCenter):

3:25 PM Changeset in webkit [111919] by dcheng@chromium.org
  • 9 edits
    2 adds in trunk

[chromium] Support file drag out using DataTransferItemList::add(File)
​https://bugs.webkit.org/show_bug.cgi?id=81261

Reviewed by Tony Chang.

Source/WebCore:

Original patch by Varun Jain <​varunjain@chromium.org>.
I've updated the original patch to remove 'downloadurl' handling since it's not tested, nor
is it necessary for File objects, since File objects correspond to a native filesystem path.

Test: fast/events/drag-dataTransferItemList-file-handling.html

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::add):

Source/WebKit/chromium:

Original patch by Varun Jain <​varunjain@chromium.org>.
I've updated the original patch to add some asserts for conditions we shouldn't encounter as
well as removing some redundant null checks.

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):

LayoutTests:

  • fast/events/drag-dataTransferItemList-file-handling-expected.txt: Added.
  • fast/events/drag-dataTransferItemList-file-handling.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:22 PM Changeset in webkit [111918] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added all tests that crashed more than once on the Lion WebKit2 bots between r111867
and r111906 to the Mac WebKit2 skip list (that weren’t alread on the list).

Rubber-stamped by Geoff Garen.

  • platform/mac-wk2/Skipped:
3:19 PM Changeset in webkit [111917] by ojan@chromium.org
  • 2 edits in trunk/Tools

garden-o-matic scrolls to the top of the page when you click an accordion item
​https://bugs.webkit.org/show_bug.cgi?id=82088

Reviewed by Adam Barth.

Check the scroll position and make sure that the clicked accordion item is visible.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3:17 PM Changeset in webkit [111916] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark fast/dom/nodesFromRect-basic.html as passing; it seems to have been fixed by r110594.

Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
3:14 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
3:14 PM Changeset in webkit [111915] by Martin Robinson
  • 4 edits in trunk/Source/WebKit/gtk

[Gtk] Webkit fails to build with --disable-geolocation
​https://bugs.webkit.org/show_bug.cgi?id=81451

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-03-23
Reviewed by Benjamin Poulain.

Wrap uses of WebCore::Geolocation in WebKitGeolocationPolicyDecision
and WebKitWebView in ifdefs, removing compilation errors when compiling
with geolocation support disabled. Affected public API methods are then
stubs, throwing a warning that feature was not enabled at compile-time.

  • webkit/webkitgeolocationpolicydecision.cpp:

(_WebKitGeolocationPolicyDecisionPrivate):
(webkit_geolocation_policy_decision_new):
(webkit_geolocation_policy_allow):
(webkit_geolocation_policy_deny):

  • webkit/webkitgeolocationpolicydecisionprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

3:10 PM Changeset in webkit [111914] by Martin Robinson
  • 27 edits in trunk/Source

[GObject bindings] Supplemental interfaces are not disabled with the "Conditional" attribute
​https://bugs.webkit.org/show_bug.cgi?id=80030

Patch by Zan Dobersek <​zandobersek@gmail.com> on 2012-03-23
Reviewed by Martin Robinson.

Source/WebCore:

Changes in CodeGeneratorGObject.pm:

  • group implementation of private helpers and guard them inside

an ifdef if a root conditional attribute is present.

  • always define the type of a GObject binding, even if the root

conditional feature is not enabled

  • the methods are generated as well, but are simply stubs if the

feature is not enabled, throwing a warning upon interaction.

  • if the method itself is guarded by a conditional attribute,

the stub implementation gains one more level of depth, throwing
a warning if the method's conditional feature is not enabled
but the root conditional feature is.

  • small style fixes in random places.

Also changed are GObject baselines for binding tests.

No new tests - no new testable functionality.

  • bindings/gobject/GNUmakefile.am:
  • bindings/scripts/CodeGeneratorGObject.pm:

(HumanReadableConditional):
(GenerateConditionalWarn):
(GenerateProperty):
(GenerateProperties):
(GenerateFunction):
(GenerateFunctions):
(GenerateCFile):
(GenerateEventTargetIface):
(Generate):
(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit):
(WebKit::kit):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_finalize):
(webkit_dom_float64array_foo):

  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit):
(WebKit::kit):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_exciting_function):
(webkit_dom_test_active_dom_object_post_message):
(webkit_dom_test_active_dom_object_get_exciting_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_callback_with_no_param):
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_with_string_list):

  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit):
(WebKit::kit):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_another_function):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit):
(WebKit::kit):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_item):
(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_supplemental_method4):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):

  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit):
(WebKit::kit):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit):
(WebKit::kit):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_constructed):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_int_method):
(webkit_dom_test_obj_int_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_serialized_value):
(webkit_dom_test_obj_idb_key):
(webkit_dom_test_obj_options_object):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context):
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_class_method):
(webkit_dom_test_obj_class_method_with_optional):
(webkit_dom_test_obj_overloaded_method1):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert3):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_mutable_point_function):
(webkit_dom_test_obj_immutable_point_function):
(webkit_dom_test_obj_orange):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_get_read_only_int_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_short_attr):
(webkit_dom_test_obj_set_short_attr):
(webkit_dom_test_obj_get_unsigned_short_attr):
(webkit_dom_test_obj_set_unsigned_short_attr):
(webkit_dom_test_obj_get_int_attr):
(webkit_dom_test_obj_set_int_attr):
(webkit_dom_test_obj_get_long_long_attr):
(webkit_dom_test_obj_set_long_long_attr):
(webkit_dom_test_obj_get_unsigned_long_long_attr):
(webkit_dom_test_obj_set_unsigned_long_long_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_xml_obj_attr):
(webkit_dom_test_obj_set_xml_obj_attr):
(webkit_dom_test_obj_get_create):
(webkit_dom_test_obj_set_create):
(webkit_dom_test_obj_get_reflected_string_attr):
(webkit_dom_test_obj_set_reflected_string_attr):
(webkit_dom_test_obj_get_reflected_integral_attr):
(webkit_dom_test_obj_set_reflected_integral_attr):
(webkit_dom_test_obj_get_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_set_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_get_reflected_boolean_attr):
(webkit_dom_test_obj_set_reflected_boolean_attr):
(webkit_dom_test_obj_get_reflected_url_attr):
(webkit_dom_test_obj_set_reflected_url_attr):
(webkit_dom_test_obj_get_reflected_custom_integral_attr):
(webkit_dom_test_obj_set_reflected_custom_integral_attr):
(webkit_dom_test_obj_get_reflected_custom_boolean_attr):
(webkit_dom_test_obj_set_reflected_custom_boolean_attr):
(webkit_dom_test_obj_get_reflected_custom_url_attr):
(webkit_dom_test_obj_set_reflected_custom_url_attr):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_get_string_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_get_content_document):
(webkit_dom_test_obj_get_mutable_point):
(webkit_dom_test_obj_set_mutable_point):
(webkit_dom_test_obj_get_immutable_point):
(webkit_dom_test_obj_set_immutable_point):
(webkit_dom_test_obj_get_strict_float):
(webkit_dom_test_obj_set_strict_float):
(webkit_dom_test_obj_get_description):
(webkit_dom_test_obj_get_id):
(webkit_dom_test_obj_set_id):
(webkit_dom_test_obj_get_hash):

  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
(webkit_dom_test_serialized_script_value_interface_get_value):
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

Source/WebKit/gtk:

Add a private macro that can be used when necessary to throw a warning
about a future not enabled at compile-time.

  • webkit/webkitglobalsprivate.h:
3:09 PM Changeset in webkit [111913] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Record painted pixel counts for measuring effectiveness of per-tile painting
​https://bugs.webkit.org/show_bug.cgi?id=82057

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.

Source/WebCore:

Adds painted pixel metrics to CCOverdrawMetrics class, and calls in
to report painted areas when updating tiles in the TiledLayerChromium
class.

Unit test: TiledLayerChromiumTest.opaqueContentsRegion

TiledLayerChromiumTest.pixelsPaintedMetrics

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didPaint):
(WebCore):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsPainted):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

3:05 PM Changeset in webkit [111912] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderBlock::splitBlocks.
​https://bugs.webkit.org/show_bug.cgi?id=81926

Reviewed by Julien Chaffraix.

Source/WebCore:

We are updating the :after content before calling splitFlow. The :after content
gets blown away since it will go to the continuation. beforeChild was earlier
set to the first child. Being the last anonymous block, its children gets pulled
up in collapseAnonymousBoxChild and it gets destroyed. So, we need to update
beforeChild value.

Test: fast/multicol/span/update-after-content-before-child-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

LayoutTests:

  • fast/multicol/span/update-after-content-before-child-crash.html: Added.
3:03 PM Changeset in webkit [111911] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix.

  • win/WebKit2CFLite.def: Add missing export symbols so that other

tools can link properly.

2:47 PM Changeset in webkit [111910] by tomz@codeaurora.org
  • 6 edits
    42 adds in trunk/LayoutTests

Integrate IETC CSS : textshadow tests
​https://bugs.webkit.org/show_bug.cgi?id=81936

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-03-23
Reviewed by Adam Barth.

  • ietestcenter/TestSupport/FeatureDetection.js: Added.
  • ietestcenter/css3/support/TahomaNarrow.ttf: Added.
  • ietestcenter/css3/support/TahomaNormal.ttf: Added.
  • ietestcenter/css3/support/TahomaT.ttf: Added.
  • ietestcenter/css3/support/ahem.ttf: Added.
  • ietestcenter/css3/support/black_color.png: Added.
  • ietestcenter/css3/support/black_red.png: Added.
  • ietestcenter/css3/support/blue_color.png: Added.
  • ietestcenter/css3/support/cat.png: Added.
  • ietestcenter/css3/support/flexbox_100r_50g_100r_50g_100g.png: Added.
  • ietestcenter/css3/support/flexbox_100x100_green.png: Added.
  • ietestcenter/css3/support/flexbox_100x100_red.png: Added.
  • ietestcenter/css3/support/flexbox_100x100g_red.png: Added.
  • ietestcenter/css3/support/flexbox_200x100_red.png: Added.
  • ietestcenter/css3/support/flexbox_200x100g_red.png: Added.
  • ietestcenter/css3/support/flexbox_300x100_red.png: Added.
  • ietestcenter/css3/support/flexbox_300x150_100red.png: Added.
  • ietestcenter/css3/support/flexbox_300x200_red.png: Added.
  • ietestcenter/css3/support/flexbox_300x50_100_80_baseline_red.png: Added.
  • ietestcenter/css3/support/flexbox_300x50_100_80_red.png: Added.
  • ietestcenter/css3/support/green_color.png: Added.
  • ietestcenter/css3/support/red_color.png: Added.
  • ietestcenter/css3/support/red_space_pb.png: Added.
  • ietestcenter/css3/support/scope-003.css: Added.
  • ietestcenter/css3/support/space_border_box.png: Added.
  • ietestcenter/css3/support/syntax-018.css: Added.
  • ietestcenter/css3/support/syntax-019.css: Added.
  • ietestcenter/css3/support/white_color.png: Added.
  • ietestcenter/css3/text/textshadow-001.htm: Added.
  • ietestcenter/css3/text/textshadow-002.htm: Added.
  • ietestcenter/css3/text/textshadow-003.htm: Added.
  • ietestcenter/css3/text/textshadow-004.htm: Added.
  • ietestcenter/css3/text/textshadow-005.htm: Added.
  • ietestcenter/css3/text/textshadow-006.htm: Added.
  • ietestcenter/css3/text/textshadow-007.htm: Added.
  • ietestcenter/css3/text/textshadow-008.htm: Added.
  • ietestcenter/css3/text/textshadow-009.htm: Added.
  • ietestcenter/css3/text/textshadow-010.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
2:45 PM Changeset in webkit [111909] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Improved composited debug borders
​https://bugs.webkit.org/show_bug.cgi?id=82071

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.

Fix the problem with missing debug borders. Since we append quads
to the list front to back now, we draw the quads in the list from
back to front of the list. Which means if the debug quad is added
after the layer it is drawing around, the layer can draw over top
of its debug quad. Reverse the ordering when appending to fix it.

Make the border red around tiles that are checkerboarded. Missing
tiles in non-root layers are drawn clear, so this makes them more
visible.

Put a blue border around each render surface, and a purple border
on their replicas.

No new tests.

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore):
(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::hasReplica):
(WebCore):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore):
(WebCore::CCTiledLayerImpl::appendQuads):

2:40 PM Changeset in webkit [111908] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Move code that calls setAcceleratesDrawing() on GraphicsLayers into RenderLayerBacking
​https://bugs.webkit.org/show_bug.cgi?id=82092

Reviewed by Dean Jackson.

A RenderLayerBacking manages several GraphicsLayers, but RenderLayerCompositor
was only calling setAcceleratesDrawing() on the one it knows about. Fix by moving
this setting code down into RenderLayerBacking.

RenderLayerCompositor now caches the setAcceleratesDrawing setting, as it does
for other compositing-related settings, so that RenderLayerBacking doesn't have
to grovel for Settings every time.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateBacking):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::acceleratedDrawingEnabled):
(RenderLayerCompositor):

2:38 PM Changeset in webkit [111907] by msaboff@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Reverting unintential change to JavaScriptCore xcode project file
checked in with change set r111906.

2:27 PM Changeset in webkit [111906] by msaboff@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::compileValueToInt32 Sometime Generates GPR to FPR reg back to GPR
​https://bugs.webkit.org/show_bug.cgi?id=81805

Reviewed by Filip Pizlo.

Added SpeculativeJIT::checkGeneratedType() to determine the current format
of an operand. Used that information in SpeculativeJIT::compileValueToInt32
to generate code that will use integer and JSValue types in integer
format directly without a conversion to double.

(JSC::DFG::SpeculativeJIT::checkGeneratedType):
(DFG):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(SpeculativeJIT):

2:24 PM HackingGtk edited by Martin Robinson
(diff)
2:19 PM Changeset in webkit [111905] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added all tests that crashed more than once on the Lion WebKit2 bots between r111885
and r111892 to the Mac WebKit2 skip list (that weren’t alread on the list).

Rubber-stamped by Geoff Garen.

  • platform/mac-wk2/Skipped:
2:16 PM Changeset in webkit [111904] by tony@chromium.org
  • 2 edits in trunk/Source/WTF

[chromium] Unreviewed, move a comment closer to where it matters and
make it more specific.

  • WTF.gyp/WTF.gyp:
2:10 PM Changeset in webkit [111903] by enne@google.com
  • 2 edits
    1 move
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, rebaseline platform/chromium/compositing/3d-corners.html
​https://bugs.webkit.org/show_bug.cgi?id=69124

Somebody checked in an incorrect windows expectation missing a
newline. Fixing.

  • platform/chromium-mac/platform/chromium/compositing/3d-corners-expected.png: Renamed from LayoutTests/platform/chromium/platform/chromium/compositing/3d-corners-expected.png.
  • platform/chromium-win/platform/chromium/compositing/3d-corners-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:09 PM Changeset in webkit [111902] by dpranke@chromium.org
  • 4 edits in trunk/Tools

LayoutTestHelper could get torn down earlier (mostly to reset color profile)
​https://bugs.webkit.org/show_bug.cgi?id=80567

Reviewed by Ryosuke Niwa.

Move clean_up_run to occur right after we finish testing and
before we start processing the results. Also makes set_up_run()
and clean_up_run() private since there's no real need for
callers to be aware of them.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run):
(Manager.run):
(Manager._clean_up_run):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_http_locking):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):

2:02 PM Changeset in webkit [111901] by Beth Dakin
  • 7 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=82083

Rubber-stamped by Simon Fraser.

This patch is just a name change. getExistingScrollAnimator() (which was
added earlier today) is now existingScrollAnimator().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTapDown):

  • page/FrameView.cpp:

(WebCore::FrameView::setAnimatorsAreActive):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::willStartLiveResize):
(WebCore::ScrollableArea::willEndLiveResize):
(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):
(WebCore::ScrollableArea::contentsResized):
(WebCore::ScrollableArea::serviceScrollAnimations):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::existingScrollAnimator):

2:00 PM Changeset in webkit [111900] by rniwa@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Revert r111891. Instead, add editing/inserting/insert-bg-font.html to the list of failing tests.
Again, the failure is tracked by the bug ​https://bugs.webkit.org/show_bug.cgi?id=82079.

  • platform/mac-lion/Skipped:
  • platform/mac-lion/editing: Removed.
  • platform/mac-lion/editing/inserting: Removed.
  • platform/mac-lion/editing/inserting/insert-bg-font-expected.txt: Removed.
1:56 PM Changeset in webkit [111899] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash due to accessing removed parent lineboxes when clearing selection.
​https://bugs.webkit.org/show_bug.cgi?id=81359

Reviewed by Eric Seidel.

Source/WebCore:

Similar to r110323, adds the canUpdateSelectionOnRootLineBoxes
check to more places.

Test: editing/selection/clear-selection-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):

  • rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::RenderSelectionInfo):
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):

LayoutTests:

  • editing/selection/clear-selection-crash-expected.txt: Added.
  • editing/selection/clear-selection-crash.html: Added.
1:47 PM Changeset in webkit [111898] by sfalken@apple.com
  • 3 edits
    2 adds in trunk/Source

Update Apple Windows build files for WTF move
​https://bugs.webkit.org/show_bug.cgi?id=82069

Reviewed by Jessie Berlin.

../JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Removed WTF and WTFGenerated.

../WTF:

  • WTF.vcproj/WTF.make: Added.
  • WTF.vcproj/WTF.sln: Added.
1:45 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:43 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:40 PM Changeset in webkit [111897] by ojan@chromium.org
  • 2 edits
    57 moves
    1863 adds
    57 deletes in trunk/LayoutTests

Initial triage pass of css3/selectors3/xml for the Chromium ports.
The difference from the Apple Mac results are all text rendering or
cases where the Chromium result is clearly correct and the Apple Mac
result is clearly incorrect.

All changes done to the non-chromium ports were done automatically
by "webkit-patch optimize-baselines".

1:40 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:37 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:36 PM Changeset in webkit [111896] by Beth Dakin
  • 7 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=82083
Too many ScrollAnimators are allocated on pages with frames

Reviewed by Geoffrey Garen.

This patch adds a new getter to ScrollableArea called
getExistingScrollAnimator() unlike scrollAnimator() this new function will
just return null if there is not already a ScrollAnimator. Callers should use
this new function when they have business with ScrollAnimator that does not
need to do anything when there are no scrollbars.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTapDown):

  • page/FrameView.cpp:

(WebCore::FrameView::setAnimatorsAreActive):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::willStartLiveResize):
(WebCore::ScrollableArea::willEndLiveResize):
(WebCore::ScrollableArea::contentAreaWillPaint):
(WebCore::ScrollableArea::mouseEnteredContentArea):
(WebCore::ScrollableArea::mouseExitedContentArea):
(WebCore::ScrollableArea::mouseMovedInContentArea):
(WebCore::ScrollableArea::contentAreaDidShow):
(WebCore::ScrollableArea::contentAreaDidHide):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
(WebCore::ScrollableArea::contentsResized):
(WebCore::ScrollableArea::serviceScrollAnimations):

  • platform/ScrollableArea.h:

(ScrollableArea):
(WebCore::ScrollableArea::getExistingScrollAnimator):

1:26 PM Changeset in webkit [111895] by eric.carlson@apple.com
  • 7 edits
    2 adds in trunk

Deal with DOM modifications when evaluating source elements.
​https://bugs.webkit.org/show_bug.cgi?id=81163

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: media/video-beforeload-remove-source.html

  • dom/ContainerNode.cpp: Make NodeVector and collectNodes public, renamed as getChildNodes.

(WebCore::ContainerNode::takeAllChildrenFrom): collectNodes -> getChildNodes.
(WebCore::ContainerNode::willRemove): collectNodes -> getChildNodes.
(WebCore::ContainerNode::willRemoveChildren): collectNodes -> getChildNodes.
(WebCore::ContainerNode::insertedIntoDocument): collectNodes -> getChildNodes.
(WebCore::ContainerNode::removedFromDocument): collectNodes -> getChildNodes.

  • dom/ContainerNode.h:

(WebCore::getChildNodes):

  • editing/ReplaceSelectionCommand.cpp: Remove unused NodeVector declaration.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): m_nextChildNodeToConsider and m_currentSourceNode

are now RefPtrs.

(WebCore::HTMLMediaElement::loadTimerFired): Protect HTMLMediaElement from being deleted during

a DOM modification during an event callback.

(WebCore::HTMLMediaElement::load): Ditto.
(WebCore::HTMLMediaElement::selectMediaResource): Set m_nextChildNodeToConsider to the first

child node, it will be the first node considered.

(WebCore::HTMLMediaElement::havePotentialSourceChild): m_nextChildNodeToConsider and m_currentSourceNode

are now RefPtrs.

(WebCore::HTMLMediaElement::selectNextSourceChild): Collect all child nodes in a vector before

looking for <source> nodes because 'beforeload' event handlers can mutate the DOM. Don't
use a <source> that is no longer a child node after 'beforeload'. Use 0 to represent the end
of the child node list because m_nextChildNodeToConsider is now a RefPtr so using the previous
sentinel, "this", would cause a retain cycle.

(WebCore::HTMLMediaElement::sourceWasAdded): m_nextChildNodeToConsider and m_currentSourceNode

are now RefPtrs.

(WebCore::HTMLMediaElement::sourceWillBeRemoved): Ditto.
(WebCore::HTMLMediaElement::getPluginProxyParams): Protect HTMLMediaElement from being deleted during

a DOM modification during an event callback.

  • html/HTMLMediaElement.h:

LayoutTests:

  • media/video-beforeload-remove-source-expected.txt: Added.
  • media/video-beforeload-remove-source.html: Added.
1:24 PM Changeset in webkit [111894] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added all tests that crashed more than once on the Lion WebKit2 bots between r111865
and r111885 to the Mac WebKit2 skip list (that weren’t alread on the list).

Rubber-stamped by Geoff Garen.

  • platform/mac-wk2/Skipped:
1:18 PM Changeset in webkit [111893] by dino@apple.com
  • 14 edits in trunk

Disable CSS_SHADERS in Apple builds ​https://bugs.webkit.org/show_bug.cgi?id=81996

Source/JavaScriptCore:

Reviewed by Simon Fraser.

Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Simon Fraser.

Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Reviewed by Simon Fraser.

Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Simon Fraser.

Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Simon Fraser.

Put ENABLE_CSS_SHADERS into Platform.h, but disable for
Apple builds.

  • wtf/Platform.h:

Tools:

Reviewed by Simon Fraser.

  • Scripts/build-webkit:

LayoutTests:

Add css3/filters/custom to the skipped list.

Reviewed by Simon Fraser.

  • platform/mac/Skipped:
1:07 PM Changeset in webkit [111892] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated Mac expected results for these tests by reverting r111339, now that bug 81826 was
fixed in r111882.

  • platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
1:03 PM Changeset in webkit [111891] by rniwa@webkit.org
  • 1 edit
    1 copy
    4 adds in trunk/LayoutTests

Add a failing expectation for the bug 82079.

  • platform/editing: Added.
  • platform/editing/inserting: Added.
  • platform/mac-lion/editing: Added.
  • platform/mac-lion/editing/inserting: Added.
  • platform/mac-lion/editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/editing/inserting/insert-bg-font-expected.txt.
1:00 PM Changeset in webkit [111890] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

Relanding(r111754): HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called
​https://bugs.webkit.org/show_bug.cgi?id=80428

.:

Patch by Dave Michael <​dmichael@chromium.org> on 2012-03-23

Source/WebCore:

Patch by Dave Michael <​dmichael@chromium.org> on 2012-03-23
Reviewed by Eric Seidel and Ryosuke Niwa.

Make HTMLPluginElement release its m_NPObject in detach() to break a
reference-counting cycle that happens on reload or navigation. With this
change, HTMLPlugInElement::removedFromDocument is unnecessary, so it
was removed. Note that Releasing m_NPObject does not result in a call to
the plugin; it simply releases a reference count on the wrapper object
for this HTMLPlugInElement. (The plugin's NPP_Deallocate is invoked
when the render tree is destroyed, when PluginView calls
PluginPackage::unload.) Thus, it is safe to release m_NPObject in
detach, because it can not result in layout or style changes.

Also added numberOfLiveNodes() and numberOfLiveDocuments() to
window.internals to enable testing.

Test: plugins/netscape-dom-access-and-reload.html

  • WebCore.exp.in:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::detach):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::numberOfLiveNodes):
(WebCore::Internals::numberOfLiveDocuments):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Patch by Dave Michael <​dmichael@chromium.org> on 2012-03-23
Reviewed by Eric Seidel and Ryosuke Niwa.

  • win/WebKit2.def: Export a symbol for InspectorCounters::counterValue
  • win/WebKit2CFLite.def: Export a symbol for InspectorCounters::counterValue

LayoutTests:

Patch by Dave Michael <​dmichael@chromium.org> on 2012-03-23
Reviewed by Eric Seidel and Ryosuke Niwa.

Due to unfortunate copy/paste laziness, the new test was using the same
window.sessionStorage as plugins/reloadplugins-and-pages.html, so that
if the tests were run in the same session, reloadplugins-and-pages.html
would *not* reload as it was supposed to, causing a text mismatch. This
patch uses a more appropriate and unique name so that these two tests
won't affect each other.

  • plugins/netscape-dom-access-and-reload-expected.txt: Added.
  • plugins/netscape-dom-access-and-reload.html: Added.
12:57 PM Changeset in webkit [111889] by barraclough@apple.com
  • 13 edits
    3 adds in trunk/Source/JavaScriptCore

RexExp constructor last match properties should not rely on previous ovector
​https://bugs.webkit.org/show_bug.cgi?id=82077

Reviewed by Oliver Hunt.

This change simplifies matching, and will enable subpattern results to be fully lazily generated in the future.

This patch changes the scheme used to lazily generate the last match properties of the RegExp object.
Instead of relying on the results in the ovector, we can instead lazily generate the subpatters using
a RegExpMatchesArray. To do so we just need to store the input, the regexp matched, and the match
location (the MatchResult). When the match is accessed or the input is set, we reify results. We use
a special value of setting the saved result to MatchResult::failed() to indicated that we're in a
reified state. This means that next time a match is performed, the store of the result will
automatically blow away the reified value.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new files.
  • runtime/RegExp.cpp:

(JSC::RegExpFunctionalTestCollector::outputOneTest):

  • changed 'subPattern' -> 'subpattern' (there was a mix in JSC, 'subpattern' was more common).
  • runtime/RegExpCachedResult.cpp: Added.

(JSC::RegExpCachedResult::visitChildren):
(JSC::RegExpCachedResult::lastResult):
(JSC::RegExpCachedResult::setInput):

  • New methods, mark GC objects, lazily create the matches array, and record a user provided input (via assignment to RegExp.inupt).
  • runtime/RegExpCachedResult.h: Added.

(RegExpCachedResult):

  • Added new class.

(JSC::RegExpCachedResult::RegExpCachedResult):
(JSC::RegExpCachedResult::record):
(JSC::RegExpCachedResult::input):

  • Initialize the object, record the result of a RegExp match, access the stored input property.
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):

  • Initialize m_result/m_multiline properties.

(JSC::RegExpConstructor::visitChildren):

  • Make sure the cached results (or lazy source for them) are marked.

(JSC::RegExpConstructor::getBackref):
(JSC::RegExpConstructor::getLastParen):
(JSC::RegExpConstructor::getLeftContext):
(JSC::RegExpConstructor::getRightContext):

  • Moved from RegExpConstructor, moved to RegExpCachedResult, and using new caching scheme.

(JSC::regExpConstructorInput):
(JSC::setRegExpConstructorInput):

  • Changed to use RegExpCachedResult.
  • runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::create):
(RegExpConstructor):
(JSC::RegExpConstructor::setMultiline):
(JSC::RegExpConstructor::multiline):

  • Move multiline property onto the constructor object; it is not affected by the last match.

(JSC::RegExpConstructor::setInput):
(JSC::RegExpConstructor::input):

  • These defer to RegExpCachedResult.

(JSC::RegExpConstructor::performMatch):

  • runtime/RegExpMatchesArray.cpp: Added.

(JSC::RegExpMatchesArray::visitChildren):

  • Eeeep! added missing visitChildren!

(JSC::RegExpMatchesArray::finishCreation):
(JSC::RegExpMatchesArray::reifyAllProperties):
(JSC::RegExpMatchesArray::reifyMatchProperty):

  • Moved from RegExpConstructor.cpp.

(JSC::RegExpMatchesArray::leftContext):
(JSC::RegExpMatchesArray::rightContext):

  • Since the match start/
  • runtime/RegExpMatchesArray.h:

(RegExpMatchesArray):

  • Declare new methods & structure flags.
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

  • performMatch now requires the JSString input, to cache.
  • runtime/StringPrototype.cpp:

(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

  • performMatch now requires the JSString input, to cache.
12:49 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
12:37 PM Changeset in webkit [111888] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

CSSParser doesn't set border-*-width/style/color to initial by border shorthand property
​https://bugs.webkit.org/show_bug.cgi?id=82040

Reviewed by Antti Koivisto.

Source/WebCore:

The border shorthand property sets values for border-width, border-style, and border-color shorthand properties.
While CSSParser::parseValue can process these shorthand properties properly and set the longhand properties
such as border-top-width, border-right-width, ... border-left-color, CSSParser::addProperty can't and the
initialization in parseShorthand fails for the border property.

Fixed the bug by explicitly initializing longhand properties.

Changing the behavior here is unlikely to break the Web since our behavior already differs from that of Firefox
and Internet Explorer. Both of those browsers return the actual initial values such as "medium" and "currentColor".
This discrepancy is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=82078.

Test: fast/css/border-shorthand-initialize-longhands.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Uses borderAbridgedLonghand.
(WebCore::CSSParser::parseShorthand): Uses longhand properties for initialization if one is available.
This allows us to initialize multiple properties (e.g. border-*-color) for a single property missing in the set.

  • css/CSSPropertyLonghand.cpp:

(WebCore::borderAbridgedLonghand): Added. The longhand here (border-width, border-style, border-color) is
"abridged" in the sense that they're still shorthands.

  • css/CSSPropertyLonghand.h:

(WebCore::CSSPropertyLonghand::CSSPropertyLonghand):
(CSSPropertyLonghand): Added the version that takes longhand instances for initialization purposes.
(WebCore::CSSPropertyLonghand::longhandsForInitialization):

LayoutTests:

Added a comprehensive regression test.

  • fast/css/border-shorthand-initialize-longhands-expected.txt: Added.
  • fast/css/border-shorthand-initialize-longhands.html: Added.
  • inspector/styles/styles-new-API-expected.txt: Correctly lists border's longhand properties.
12:30 PM Changeset in webkit [111887] by tony@chromium.org
  • 10 edits in trunk

[chromium] rename newwtf target back to wtf
​https://bugs.webkit.org/show_bug.cgi?id=82064

Reviewed by Adam Barth.

Source/JavaScriptCore:

Source/Platform:

  • Platform.gyp/Platform.gyp:

Source/WebCore:

No new tests, only renaming a build target.

  • WebCore.gyp/WebCore.gyp:

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12:24 PM Changeset in webkit [111886] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Turn off painting of scrollbars on compositor thread for unsupported platforms
​https://bugs.webkit.org/show_bug.cgi?id=82066

Reviewed by James Robinson.

With threaded compositing, OSX will crash and Windows will have black
scrollbars. Fix that by reverting to the previosu behavior of updating
scrollbars on the main thread instead.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollbarLayerDidChange):

12:19 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
11:40 AM Changeset in webkit [111885] by ojan@chromium.org
  • 2 edits
    57 moves
    1749 adds
    57 deletes in trunk/LayoutTests

Initial triage pass of css3/selectors3/xhtml for the Chromium ports.
The difference from the Apple Mac results are all text rendering or
cases where the Chromium results is clearly correct and the Apple Mac
result is clearly incorrect.

All changes done to the non-chromium ports were done automatically
by "webkit-patch optimize-baselines".

11:34 AM Changeset in webkit [111884] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore
<rdar://problem/7883987> ASSERTION FAILED: ASSERT(input == AnimationStateInputEndTimerFired
input == AnimationStateInputPlayStatePaused) in AnimationBase::updateStateMachine causing multiple "crashes" on Lion Intel Debug WebKit testers

​https://bugs.webkit.org/show_bug.cgi?id=81351

Rubber-stamped by Jessie Berlin.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine): Replaced the assertion with a LOG_ERROR so that
the issue is still noticeable, but it does not automatically make the debug bots red.

11:30 AM Changeset in webkit [111883] by mikelawther@chromium.org
  • 3 edits
    1 move in trunk

CSS3 calc: image sizing works with mixed percentage/absolute
​https://bugs.webkit.org/show_bug.cgi?id=82017

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/img-size-expected.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

LayoutTests:

Test is now expected to match.

  • css3/calc/img-size-expected.html: Renamed from LayoutTests/css3/calc/img-size-expected-mismatch.html.
11:27 AM Changeset in webkit [111882] by jchaffraix@webkit.org
  • 9 edits
    1 move in trunk

REGRESSION(107971): Google Voice contact list is broken in WebKit due to badly allocating the extra height
​https://bugs.webkit.org/show_bug.cgi?id=81826

Reviewed by Tony Chang.

Source/WebCore:

Covered by tables/mozilla/bugs/bug27038-{1|2}.html.

This partly reverts r107971: the extra logical height distribution change was not needed
to fix the bug (it is needed by the test though). We revert to giving all the extra height
to the first tbody and not the first section.

This is broken but unfortunately some websites are relying on that. Getting a real
distribution algorithm is covered by bug 81824. However this is super tricky to get
right and I did not want to add more compatibility risks until I have something solid.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::distributeExtraLogicalHeight):

LayoutTests:

  • fast/table/double-height-table-no-tbody.html-disabled: Renamed from LayoutTests/fast/table/double-height-table-no-tbody.html.

Disabled this test as it relies on our algorithm not to discriminate between first sections.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:

Mark those 2 tests as needing a new baseline again.

  • platform/efl/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/win/Skipped:

Those platforms did not rebaseline those 2 tests so they should automatically pass them.

11:23 AM Changeset in webkit [111881] by eae@chromium.org
  • 5 edits
    20 adds in trunk/LayoutTests

Unreviewed rebasline, add expectations for new test introducted in r111872.

  • platform/chromium-mac-leopard/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-mac-leopard/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-mac/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-win-vista/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-win-vista/platform/chromium/virtual: Added.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu: Added.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast: Added.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas: Added.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-win-xp/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/gpu: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
11:14 AM Changeset in webkit [111880] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimize for IPP in DirectConvolver::process()
​https://bugs.webkit.org/show_bug.cgi?id=80255

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2012-03-23
Reviewed by Chris Rogers.

Increase ~2X performance by conv() in IPP.

  • platform/audio/DirectConvolver.cpp:

(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):

  • platform/audio/DirectConvolver.h:

(DirectConvolver):

11:12 AM Changeset in webkit [111879] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added more appcache tests to the Mac WebKit2 skip list due to intermittent failures.
<​http://webkit.org/b/82061> tracks this issue.

  • platform/mac-wk2/Skipped:
11:08 AM Changeset in webkit [111878] by Philippe Normand
  • 5 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline after r111876 and r111731.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/ruby/ruby-text-before-child-split-expected.txt: Added.
10:19 AM Changeset in webkit [111877] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Simplify memory usage tracking in CopiedSpace
​https://bugs.webkit.org/show_bug.cgi?id=80705

Reviewed by Filip Pizlo.

  • heap/CopiedAllocator.h:

(CopiedAllocator): Rename currentUtilization to currentSize.
(JSC::CopiedAllocator::currentCapacity):

  • heap/CopiedBlock.h:

(CopiedBlock):
(JSC::CopiedBlock::payload): Move the implementation of payload() out of the class
declaration.
(JSC):
(JSC::CopiedBlock::size): Add new function to calculate the block's size.
(JSC::CopiedBlock::capacity): Ditto for capacity.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::CopiedSpace): Remove old bogus memory stats fields and add a new
field for the water mark.
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase): When we fail to allocate from the current
block, we need to update our current water mark with the size of the block.
(JSC::CopiedSpace::tryAllocateOversize): When we allocate a new oversize block, we
need to update our current water mark with the size of the used portion of the block.
(JSC::CopiedSpace::tryReallocate): We don't need to update the water mark when
reallocating because it will either get accounted for when we fill up the block later
in the case of being able to reallocate in the current block or it will get picked up
immediately because we'll have to get a new block.
(JSC::CopiedSpace::tryReallocateOversize): We do, however, need to update in when
realloc-ing an oversize block because we deallocate the old block and allocate a brand
new one.
(JSC::CopiedSpace::doneFillingBlock): Update the water mark as blocks are returned to
the CopiedSpace by the SlotVisitors.
(JSC::CopiedSpace::doneCopying): Add in any pinned blocks to the water mark.
(JSC::CopiedSpace::getFreshBlock): We use the Heap's new function to tell us whether or
not we should collect now instead of doing the calculation ourself.
(JSC::CopiedSpace::destroy):
(JSC):
(JSC::CopiedSpace::size): Manually calculate the size of the CopiedSpace, similar to how
MarkedSpace does.
(JSC::CopiedSpace::capacity): Ditto for capacity.

  • heap/CopiedSpace.h:

(JSC::CopiedSpace::waterMark):
(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::startedCopying): Reset water mark to 0 when we start copying during a
collection.
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::allocateFromBlock):

  • heap/Heap.cpp:

(JSC::Heap::size): Incorporate size of CopiedSpace into the total size of the Heap.
(JSC::Heap::capacity): Ditto for capacity.
(JSC::Heap::collect):

  • heap/Heap.h:

(Heap):
(JSC::Heap::shouldCollect): New function for other sub-parts of the Heap to use to
determine whether they should initiate a collection or continue to allocate new blocks.
(JSC):
(JSC::Heap::waterMark): Now is the sum of the water marks of the two sub-parts of the
Heap (MarkedSpace and CopiedSpace).

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase): Changed to use the Heap's new shouldCollect() function.

10:16 AM Changeset in webkit [111876] by tommyw@google.com
  • 7 edits
    1 copy
    4 adds in trunk/Source/WebCore

MediaStream API (JSEP): Introducing PeerConnection00 and IceCallback
​https://bugs.webkit.org/show_bug.cgi?id=81657

Reviewed by Adam Barth.

Last major WebCore patch for the JSEP PeerConnection, together with the associated
IceCallback (they both depend on each other and IceCallback has very few lines of real code).

My next patch after this one will do a major overhaul of the existing layout tests
and add a few new ones.

  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/IceCallback.h: Added.

(WebCore):
(IceCallback):
(WebCore::IceCallback::~IceCallback):

  • Modules/mediastream/IceCallback.idl: Added.
  • Modules/mediastream/PeerConnection00.cpp: Added.

(WebCore):
(WebCore::PeerConnection00::create):
(WebCore::PeerConnection00::PeerConnection00):
(WebCore::PeerConnection00::~PeerConnection00):
(WebCore::PeerConnection00::hasLocalAudioTrack):
(WebCore::PeerConnection00::hasLocalVideoTrack):
(WebCore::PeerConnection00::parseMediaHints):
(WebCore::PeerConnection00::createOffer):
(WebCore::PeerConnection00::createAnswer):
(WebCore::PeerConnection00::setLocalDescription):
(WebCore::PeerConnection00::setRemoteDescription):
(WebCore::PeerConnection00::localDescription):
(WebCore::PeerConnection00::remoteDescription):
(WebCore::PeerConnection00::startIce):
(WebCore::PeerConnection00::processIceMessage):
(WebCore::PeerConnection00::readyState):
(WebCore::PeerConnection00::iceState):
(WebCore::PeerConnection00::addStream):
(WebCore::PeerConnection00::removeStream):
(WebCore::PeerConnection00::localStreams):
(WebCore::PeerConnection00::remoteStreams):
(WebCore::PeerConnection00::close):
(WebCore::PeerConnection00::didGenerateIceCandidate):
(WebCore::PeerConnection00::didChangeReadyState):
(WebCore::PeerConnection00::didChangeIceState):
(WebCore::PeerConnection00::didAddRemoteStream):
(WebCore::PeerConnection00::didRemoveRemoteStream):
(WebCore::PeerConnection00::interfaceName):
(WebCore::PeerConnection00::scriptExecutionContext):
(WebCore::PeerConnection00::stop):
(WebCore::PeerConnection00::eventTargetData):
(WebCore::PeerConnection00::ensureEventTargetData):
(WebCore::PeerConnection00::changeReadyState):
(WebCore::PeerConnection00::changeIceState):

  • Modules/mediastream/PeerConnection00.h: Added.

(WebCore):
(PeerConnection00):
(WebCore::PeerConnection00::refEventTarget):
(WebCore::PeerConnection00::derefEventTarget):

  • Modules/mediastream/PeerConnection00.idl: Added.
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):

  • bindings/js/JSPeerConnection00Custom.cpp: Added.

(WebCore):
(WebCore::JSPeerConnection00Constructor::constructJSPeerConnection00):

  • dom/EventTargetFactory.in:
10:13 AM Changeset in webkit [111875] by enne@google.com
  • 4 edits in trunk/Source

[chromium] Fix scrollbarLayerLostContext flaky test crash on 10.6
​https://bugs.webkit.org/show_bug.cgi?id=82062

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

Source/WebKit/chromium:

Override the paint function so that it becomes a no-op. Painting
scrollbars on the impl thread is not yet supported on platforms other
than Linux or ChromeOS.

  • tests/CCLayerTreeHostImplTest.cpp:

(ScrollbarLayerFakePaint):
(WebKitTests::ScrollbarLayerFakePaint::create):
(WebKitTests::ScrollbarLayerFakePaint::paint):
(WebKitTests::ScrollbarLayerFakePaint::ScrollbarLayerFakePaint):
(WebKitTests):
(WebKitTests::TEST_F):

10:10 AM Changeset in webkit [111874] by tommyw@google.com
  • 7 edits in trunk/Source

[chromium] MediaStream API (JSEP): Extending WebMediaStreamCenter
​https://bugs.webkit.org/show_bug.cgi?id=81924

Reviewed by Adam Barth.

Source/WebCore:

Nothing to test, just moving methods.

  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::constructSDP):
(WebCore):

Source/WebKit/chromium:

Adding the two constructSDP methods.

  • bridge/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::constructSDP):
(WebCore):

  • bridge/MediaStreamCenterInternal.cpp:

(WebCore::MediaStreamCenterInternal::constructSDP):
(WebCore):

  • bridge/MediaStreamCenterInternal.h:

(WebCore):
(MediaStreamCenterInternal):

  • public/platform/WebMediaStreamCenter.h:

(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::constructSDP):

10:07 AM Changeset in webkit [111873] by mitz@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Restored part of a change log entry that I deleted by accident in r111870

9:58 AM Changeset in webkit [111872] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

Reuse buffer allocation if canvas size does not change
​https://bugs.webkit.org/show_bug.cgi?id=80871

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-03-23
Reviewed by Stephen White.

Source/WebCore:

If the user changes the width or height attributes of a canvas element,
the contents of the canvas should be cleared and the context state
should be reset. This has become a common idiom to clear the canvas
"efficiently" at the start of a frame.

Previously, this code path triggered a full reallocation of the image
buffer backing the canvas, leading to reduced performance. This patch
implements an optimization where we reuse the previous image buffer
allocation if the size of the canvas did not change. Also, instead of
clearing the canvas every time its dimensions are touched, we only clear
if anything has been drawn into the canvas since it was previously
cleared.

Note that for now this optimization only applies for 2D canvases,
since it is not entirely clear how touching the dimensions of a WebGL
canvas should work.

Test: fast/canvas/canvas-resize-after-paint-without-layout.html +

existing layout tests for canvas resetting.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer): Save the initial
graphics context state so we can restore it without creating a new
context.
(WebCore::HTMLCanvasElement::clearImageBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::clearCopiedImage):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::reset): No need to notify the
compositor when the context is reset, because clearing the image buffer
does the same thing. We can also skip the notification if we did not
have an image buffer at the time of the reset, because the reset will
not have any visual impact in this case. Finally, if the canvas size
did change, the notification is also unnecessary because of the call
to RenderObject::repaint() from HTMLCanvasElement::reset().

LayoutTests:

Add layout test to check canvas resizing without changing its layout size.

We also update the expected image one canvas clearing test. The test
is setting the size of a canvas and expecting it to be cleared in the process.
With the optimization to retain the underlying ImageBuffer, we no longer call
RenderReplaced::repaint() as a part of this process. This function used to
repaint both the canvas itself (100x50) as well as its local selection
rectangle (100x54).

In this case the local selection rectangle is larger than the canvas because
the canvas is contained within an anonymous RenderBlock that also has two empty
text nodes. The extra 4 pixels are needed for drawing the selection rectangle
around any descenders in the the text of those nodes.

Since clearing the canvas has no effect on the selection rectangle, we only
need to repaint the area of the canvas itself.

  • fast/canvas/canvas-resize-after-paint-without-layout.html: Added.
  • fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Added.
  • platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Updated.
9:54 AM Changeset in webkit [111871] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix some code generation warnings on GTK+.

Reviewed by Gustavo Noronha Silva.

No new tests. This just fixes warnings.

  • GNUmakefile.am: Remove nonexistent directories from the list IDL directories.
9:50 AM Changeset in webkit [111870] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added all tests that failed more than once on the Lion WebKit2 Release bot between r111814
and r111865 to the Mac WebKit2 skip list (that weren’t alread on the list).

Rubber-stamped by Geoff Garen.

  • platform/mac-wk2/Skipped:
9:40 AM Changeset in webkit [111869] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added all tests that failed more than once on the Lion WebKit2 Debug bot between r111808 and
r111849 to the Mac WebKit2 skip list (that weren’t alread on the list).

Rubber-stamped by Geoff Garen.

  • platform/mac-wk2/Skipped:
9:35 AM Changeset in webkit [111868] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added all appcache tests to the Mac WebKit2 skip list due to intermittent failures. Filed
<​http://webkit.org/b/82061> to track this issue.

  • platform/mac-wk2/Skipped:
9:32 AM Changeset in webkit [111867] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r111751.
​http://trac.webkit.org/changeset/111751
​https://bugs.webkit.org/show_bug.cgi?id=82060

caused 15% page cycler regression for chromium-linux
(Requested by eae on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-23

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

9:14 AM Changeset in webkit [111866] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
the Lion Intel WebKit2 Debug bots.
​https://bugs.webkit.org/show_bug.cgi?id=81012.

Rubber-stamped by Dan Bernstein.

Add a step to kill the pasteboard server while we investigate what is causing these
assertion failures (to get the bots green).

  • BuildSlaveSupport/kill-old-processes:
9:04 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
8:46 AM Changeset in webkit [111865] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

Support [ImplementedAs] for attributes
​https://bugs.webkit.org/show_bug.cgi?id=81605

Reviewed by Adam Barth.

[ImplementedAs] just supports methods. [ImplementedAs] should support
attributes too.

Explained here: ​https://trac.webkit.org/wiki/WebKitIDL#ImplementedAs

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGenerator.pm: Modified to support [ImplementedAs] for attributes.

(AttributeNameForGetterAndSetter):

  • bindings/scripts/test/TestObj.idl: Added a test case.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::strawberry):
(WebDOMTestObj::setStrawberry):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjStrawberry):
(WebCore::setJSTestObjStrawberry):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj strawberry]):
(-[DOMTestObj setStrawberry:]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::strawberryAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::strawberryAttrSetter):
(WebCore):

8:43 AM Changeset in webkit [111864] by Martin Robinson
  • 9 edits in trunk/Tools

[check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
​https://bugs.webkit.org/show_bug.cgi?id=81986

Reviewed by David Levin.

Track whether or not errors are filtered in error handlers. If an
alphabetical sorting error is reported for a header and filtered, try
reporting it for the other potential source of the error. This ensures
that the style bot can still find new sorting errors in both potential
situations:

#include <foo.h> <-- 1. edited line
#include <baz.h> <-- 2. edited line

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line): Potentially report the error for both lines,
if the first error is filtered.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of

test that allows only reporting errors for certain lines. This verifies that
when one line of an ordering error is filtered, the error is reported on the
other line.
(ErrorCollector.init):
(ErrorCollector.call):
(CppStyleTestBase.perform_lint):
(CppStyleTestBase.perform_language_rules_check):
(CppStyleTestBase.assert_language_rules_check):
(OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
Added a new test that verifies that when one line of the two lines of an ordering
error occur, the error is reported on the other line.

  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:

(MockErrorHandler.call): Report True because the error is handled.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(ErrorCollector.call): Ditto.

  • Scripts/webkitpy/style/checkers/watchlist_unittest.py:

(MockErrorHandler.call): Ditto.

  • Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:

(TestErrorHandler.call): Ditto.

  • Scripts/webkitpy/style/checkers/xml_unittest.py:

(MockErrorHandler.call): Ditto.

  • Scripts/webkitpy/style/error_handlers.py:

(DefaultStyleErrorHandler.call): Report True if the error is handled
and False if it is filtered.

8:04 AM Changeset in webkit [111863] by Patrick Gansterer
  • 2 edits in trunk/Tools

Build fix for WinCE after r111778.

  • WinCELauncher/CMakeLists.txt:
7:53 AM Changeset in webkit [111862] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove unused variables from unittest.
​https://bugs.webkit.org/show_bug.cgi?id=82054

Patch by Jonathan Backer <​backer@chromium.org> on 2012-03-23
Reviewed by Adrienne Walker.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

7:43 AM Changeset in webkit [111861] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Try to skip the test before the crashing one.

  • platform/qt-5.0-wk2/Skipped:
7:40 AM Changeset in webkit [111860] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unskipped some tests that don't fail on Qt5.
3 of them still fail on Qt5-wk2 so these tests will be skipped

Patch by János Badics <János Badics> on 2012-03-23
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
7:25 AM Changeset in webkit [111859] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r111855.
​http://trac.webkit.org/changeset/111855
​https://bugs.webkit.org/show_bug.cgi?id=82053

It broke 30+ tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-23

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

7:04 AM Changeset in webkit [111858] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped: Skip one more crashing test.
7:00 AM Changeset in webkit [111857] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip crashing tests to paint the bot green.
6:27 AM Changeset in webkit [111856] by tommyw@google.com
  • 8 edits in trunk/Source/WebCore

The JSC code generator doesn't generate correct code for Constructors
​https://bugs.webkit.org/show_bug.cgi?id=82046

Reviewed by Kentaro Hara.

The main bulk of generated code for constructors uses the name jsConstructor
for the created object, and then calls GenerateParametersCheck which generates
code that uses the name castedThis.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObjConstructor::constructJSTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

6:27 AM Changeset in webkit [111855] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Implement PageClient::isViewWindowActive()
​https://bugs.webkit.org/show_bug.cgi?id=81143

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-03-23
Reviewed by Kenneth Rohde Christiansen.

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

6:10 AM Changeset in webkit [111854] by leviw@chromium.org
  • 11 edits in branches/subpixellayout/Source/WebCore/rendering

Correct localSelectionRect to be a LayourRect since it's in local coordinates.

6:01 AM Changeset in webkit [111853] by tommyw@google.com
  • 13 edits in trunk/Source/WebCore

The JSC code generator can't handle boolean arguments for Callbacks
​https://bugs.webkit.org/show_bug.cgi?id=82045

Reviewed by Kentaro Hara.

CodeGeneratorJS.pm only handles DOMStrings and objects as arguments
for a Callback, so I added support for boolean values as well.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::callbackWithBoolean):

  • bindings/scripts/test/CPP/WebDOMTestCallback.h:

(WebDOMTestCallback):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(webkit_dom_test_callback_callback_with_boolean):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):

  • bindings/scripts/test/JS/JSTestCallback.h:

(JSTestCallback):

  • bindings/scripts/test/ObjC/DOMTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:

(-[DOMTestCallback callbackWithBoolean:]):

  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):

  • bindings/scripts/test/V8/V8TestCallback.h:

(V8TestCallback):

5:41 AM Changeset in webkit [111852] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Touch adjustment forgets some subtarget quads.
​https://bugs.webkit.org/show_bug.cgi?id=82044

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not uncritically skip all nodes that are ancestors to other test results.
Instead return the inner-most element if multiple nodes have the same distance.

Test: touchadjustment/block-testing.html

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

LayoutTests:

  • touchadjustment/block-testing-expected.txt: Added.
  • touchadjustment/block-testing.html: Added.
5:23 AM Changeset in webkit [111851] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

TouchAdjustment does not correct for frame position
​https://bugs.webkit.org/show_bug.cgi?id=82043

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Convert geometry to window coordinates before calculating distance.

Test: touchadjustment/iframe.html

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::distanceSquaredToTargetCenterLine):

LayoutTests:

Add test that will fail if frame position is not adjusted for.

  • touchadjustment/iframe-expected.txt: Added.
  • touchadjustment/iframe.html: Added.
  • touchadjustment/resources/inner-frame.html: Added.
5:17 AM Changeset in webkit [111850] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Disable the flickable when pinching.

Reviewed by Kenneth Rohde Christiansen.

Set the interactivity of the internal flickable to false
when pinching so that it does not react to mouse events
which might break pinch zoom.
This is a temporal workaround and needed until the event
propagation in QtQuick is fixed.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):

5:07 AM Changeset in webkit [111849] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixed minor WebInspector display issue
Clicking on disabled sections in Styles Sidebar Pane creates new elements.
​https://bugs.webkit.org/show_bug.cgi?id=81925

Patch by Vlad Voicu <​vladv@rosedu.org> on 2012-03-23
Reviewed by Timothy Hatcher

No new tests should be required.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):

5:02 AM Changeset in webkit [111848] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod5Callback):
(WebCore::TestObjInternal::overloadedMethodCallback):

4:14 AM Changeset in webkit [111847] by Carlos Garcia Campos
  • 6 edits
    1 add in trunk/Source/WebKit/gtk

[GTK] Add a way to expose well known names for items in the default context menu
​https://bugs.webkit.org/show_bug.cgi?id=67660

Reviewed by Martin Robinson.

Add WebKitContextMenuAction enum containing all possible context
menu item actions.

  • GNUmakefile.am: Add new files to compilation.
  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::inputMethodsMenuItem): Use WebCore context menu classes
to create the context menu and its items to make sure all items
have a GtkAction associated.
(WebKit::insertControlCharacter):
(WebKit::unicodeMenuItem): Ditto.

  • tests/testcontextmenu.c: Added.

(testInfoNew):
(testInfoDestroy):
(contextMenuFixtureSetup):
(contextMenuFixtureTeardown):
(checkAction):
(checkActionWithSubmenu):
(checkSeparator):
(contextMenuCallback):
(pushEvent):
(loadStatusCallback):
(mapEventCallback):
(testContextMenu):
(contextMenuCustomItemCallback):
(testContextMenuCustomItem):
(main):

  • webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action): Return the
WebKitContextMenuAction for the given context menu item.

  • webkit/webkitglobals.h:
3:19 AM Changeset in webkit [111846] by peter@chromium.org
  • 2 edits in trunk/Tools

Unreviewed buildfix for the Chromium Android builder.

Disable the ImageDiff target for now. Android needs to build this for
host rather than for target (as other configurations do), but since the
WTF move the dependency chain got significantly more complicated.

I'll work out a proper fix in the following bug, but since several
things are broken due to this, this buildfix should be landed first.
​https://bugs.webkit.org/show_bug.cgi?id=82039

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3:16 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
2:52 AM Changeset in webkit [111845] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

cssText should use StringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=82028

Reviewed by Hajime Morita.

Make StylePropertySet::asText more efficient by deploying StringBuilder;
avoids heap churn by String::operator+ and String::operator+=.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):

2:40 AM Changeset in webkit [111844] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Rename a variable name in API documentation.

Rename keyboard_mode to triggered_with_keyboard in
WebKitWebView::context-menu signal documentation as suggested by
Martin and Gustavo. I forgot to make this change before landing
previous patch.

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

2:29 AM Changeset in webkit [111843] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit/gtk

[GTK] Add a signal to allow applications to handle its own context menu
​https://bugs.webkit.org/show_bug.cgi?id=49904

Reviewed by Gustavo Noronha Silva.

  • tests/testhittestresult.c:

(load_status_cb): Test x, y properties of WebKitHitTestResult.

  • webkit/webkithittestresult.cpp:

(webkit_hit_test_result_get_property):
(webkit_hit_test_result_set_property):
(webkit_hit_test_result_class_init): Add x and y construct only
properties to keep the coordinates of the event relative to view's
widget.
(WebKit::kit):

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init): Mark enable-default-context-menu
property as deprecated.

  • webkit/webkitwebview.cpp:

(prepareMouseEventForFrame):
(defaultContextMenuEnabled): Helper function to check whether
default context menu setting is enabled or not.
(webkit_web_view_forward_context_menu_event): Emit the new
context-menu signal.
(webkit_web_view_popup_menu_handler):
(webkit_web_view_button_press_event):
(webkit_web_view_class_init): Add new context-menu signal and mark
populate-popup as deprecated.

  • webkitmarshal.list:
2:26 AM Changeset in webkit [111842] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a failing test.

  • platform/qt-4.8/Skipped:
2:25 AM April 2012 Meeting edited by rniwa@webkit.org
(diff)
2:21 AM Changeset in webkit [111841] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium DEPS roll r127913:r128426.

  • DEPS:
2:10 AM Changeset in webkit [111840] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove the failing expectation added in r111831 for the test added in r111754
since r111754 was rolled out in r111839.

  • platform/mac-wk2/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
2:04 AM Changeset in webkit [111839] by rniwa@webkit.org
  • 13 edits
    2 deletes in trunk

REGRESSION(r111754): plugins/reloadplugins-and-pages.html fails on all platforms
​https://bugs.webkit.org/show_bug.cgi?id=82035

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Rollout r111754 since it caused a test to fail and the test added by the patch
is failing on Mac WebKit 2.

  • WebCore.exp.in:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::detach):
(WebCore):
(WebCore::HTMLPlugInElement::removedFromDocument):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • plugins/netscape-dom-access-and-reload-expected.txt: Removed.
  • plugins/netscape-dom-access-and-reload.html: Removed.
1:35 AM Changeset in webkit [111838] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Fix GTK+ build after r111707.

  • WebCoreSupport/UserMediaClientGtk.h:
1:27 AM Changeset in webkit [111837] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

GTK rebaselines.

  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
1:04 AM Changeset in webkit [111836] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=82026

Reviewed by Kentaro Hara.

This patch removes DOMWindow::resetNotifications, which was unneeded
special-case logic for clearing the notifications center. The previous
patch that tried to accomplish the same thing did not override
willDetachPage, which is why it caused crashes.

There's actually a cleaner way to handle these cases, which will let us
implement reconnectFrame, but that will need to wait for the next
patch.

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore):
(WebCore::DOMWindowNotifications::disconnectFrame):
(WebCore::DOMWindowNotifications::willDetachPage):
(WebCore::DOMWindowNotifications::reset):

  • notifications/DOMWindowNotifications.h:

(DOMWindowNotifications):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):

  • page/DOMWindow.h:

(DOMWindow):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

12:25 AM Changeset in webkit [111835] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][DRT] Implement LayoutTestController's methods related with editing.
​https://bugs.webkit.org/show_bug.cgi?id=80136

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2012-03-23
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

Implements DumpRenderTreeSupportEfl's and EditorClientEfl's methods related with editing.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled): New function.
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled): New function.

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::setSmartInsertDeleteEnabled): New function.
(WebCore):
(WebCore::EditorClientEfl::smartInsertDeleteEnabled): Add implementation.
(WebCore::EditorClientEfl::setSelectTrailingWhitespaceEnabled): New function.
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled): Add implementation.
(WebCore::EditorClientEfl::EditorClientEfl):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Tools:

Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
setSelectTrailingWhitespaceEnabled.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setSmartInsertDeleteEnabled):
(LayoutTestController::setSelectTrailingWhitespaceEnabled):

LayoutTests:

Enables tests connected with setSelectTrailingWhitespaceEnabled and setSmartInsertDeleteEnabled.
Tests related with spelling can not be enabled in this patch because WebKit-Efl doesn't
support spell checking (missing TextCheckerClient implementation).

  • platform/efl/Skipped:
12:14 AM Changeset in webkit [111834] by rniwa@webkit.org
  • 3 edits in trunk/Source

BitVector::resizeOutOfLine doesn't memset when converting an inline buffer
​https://bugs.webkit.org/show_bug.cgi?id=82012

Reviewed by Filip Pizlo.

Initialize out-of-line buffers while extending an inline buffer. Also export symbols to be used in WebCore.

  • wtf/BitVector.cpp:

(WTF::BitVector::resizeOutOfLine):

  • wtf/BitVector.h:

(BitVector):
(OutOfLineBits):

Note: See TracTimeline for information about the timeline view.