Timeline



Mar 25, 2012:

11:44 PM Changeset in webkit [112055] by hayato@chromium.org
  • 27 edits
    4 adds in trunk

[Shadow DOM] Add Reified DOM Tree traversal internal APIs.
​https://bugs.webkit.org/show_bug.cgi?id=79197

Reviewed by Dimitri Glazkov.

Add internal APIs which can be used to traverse Reified DOM tree, which is
a result of node distribution algorithm explained in Shadow DOM spec.
​https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html

Every public functions defined in ReifiedTreeTraversal are static
functions and are named in a similar way to ones defined in WebCore::Node class.
The only difference is that ReifiedTreeTraversal APIs consider shadow
hosts and also traverse nodes is Shadow DOM subtrees, crossing shadow's upper and lower boundary
transparently.

There is no actual client which uses these APIs. Follow-up patches for FocusNavigation
and EventDispatcher will use the APIs so that they can traverse node in reified tree order.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/shadow/reified-tree-traversal.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ReifiedTreeTraversal.cpp: Added.

(WebCore):
(WebCore::isShadowHost):
(WebCore::shadowTreeFor):
(WebCore::shadowTreeOfParent):
(WebCore::ReifiedTreeTraversal::firstChild):
(WebCore::ReifiedTreeTraversal::lastChild):
(WebCore::ReifiedTreeTraversal::lastChildWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::traverseChild):
(WebCore::ReifiedTreeTraversal::traverseLightChildren):
(WebCore::ReifiedTreeTraversal::traverseNode):
(WebCore::ReifiedTreeTraversal::nextSibling):
(WebCore::ReifiedTreeTraversal::previousSibling):
(WebCore::ReifiedTreeTraversal::traverseSiblingOrBackToInsertionPoint):
(WebCore::ReifiedTreeTraversal::traverseSiblingInCurrentTree):
(WebCore::ReifiedTreeTraversal::traverseSiblingOrBackToYoungerShadowRoot):
(WebCore::ReifiedTreeTraversal::escapeFallbackContentElement):
(WebCore::ReifiedTreeTraversal::traverseNodeEscapingFallbackContents):
(WebCore::ReifiedTreeTraversal::parentNode):
(WebCore::ReifiedTreeTraversal::parentNodeWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::parentNodeOrBackToInsertionPoint):
(WebCore::ReifiedTreeTraversal::parentNodeInCurrentTree):
(WebCore::ReifiedTreeTraversal::parentNodeBackToYoungerShadowRootOrHost):
(WebCore::ReifiedTreeTraversal::adjustedParentNode):
(WebCore::ReifiedTreeTraversal::traverseNextNode):
(WebCore::ReifiedTreeTraversal::traverseNextNodeWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::traversePreviousNode):
(WebCore::ReifiedTreeTraversal::traversePreviousNodeWithoutCrossingUpperBoundary):

  • dom/ReifiedTreeTraversal.h: Added.

(WebCore):
(ReifiedTreeTraversal):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::insertionPointFor):
(WebCore::ShadowTree::selectionFor):
(WebCore):

  • dom/ShadowTree.h:

(WebCore):
(ShadowTree):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::findFor):

  • html/shadow/HTMLContentSelector.h:

(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):

  • html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore::toInsertionPoint):
(WebCore):

  • testing/Internals.cpp:

(WebCore::Internals::nextSiblingInReifiedTree):
(WebCore):
(WebCore::Internals::firstChildInReifiedTree):
(WebCore::Internals::lastChildInReifiedTree):
(WebCore::Internals::traverseNextNodeInReifiedTree):
(WebCore::Internals::traversePreviousNodeInReifiedTree):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/reified-tree-traversal-expected.txt: Added.
  • fast/dom/shadow/reified-tree-traversal.html: Added.
  • platform/efl/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
11:20 PM Changeset in webkit [112054] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] unexpected result in fast/js/large-expressions.html
​https://bugs.webkit.org/show_bug.cgi?id=76379

  • platform/qt/Skipped: Skip it until proper fix.
11:17 PM Changeset in webkit [112053] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Web Inspector: Indenting fully selected line should not indent the line next to it
​https://bugs.webkit.org/show_bug.cgi?id=81758

Source/WebCore:

In the editor, you can select a whole line by moving caret at 0 column
position and pressing Shift + Arrow Down/Up. After that, pressing Tab
indents 2 lines: fully selected one and the line next to it. The patch
changes this behaviour to indent only fully selected line since that is
what pretty-match all the other code editors do.

Patch by Nikita Vasilyev <​me@elv1s.ru> on 2012-03-25
Reviewed by Pavel Feldman.

Test: inspector/editor/indentation.html

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype._indentLines):

Do not insert indent at the begging of the last line if a selection
ends on its 0 column.

(WebInspector.TextEditorMainPanel.prototype._unindentLines):

Do not remove indent at the begging of the last line if a selection
ends on its 0 column.

LayoutTests:

Patch by Nikita Vasilyev <​me@elv1s.ru> on 2012-03-25
Reviewed by Pavel Feldman.

  • inspector/editor/indentation-expected.txt: Added.
  • inspector/editor/indentation.html: Added.
11:12 PM Changeset in webkit [112052] by Csaba Osztrogonác
  • 1 edit
    1 move in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r112023.

  • platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Removed unnecessary Qt specific txt.
  • platform/qt/fast/dom/xml-parser-error-message-crash-expected.txt: Updated.
11:11 PM Changeset in webkit [112051] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash in ContainerNode::resumePostAttachCallbacks.
​https://bugs.webkit.org/show_bug.cgi?id=82159

Reviewed by Hajime Morita.

Source/WebCore:

Test: plugins/object-onfocus-mutation-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::resumePostAttachCallbacks): dispatching post attach
callbacks when our attach depth is 1 can fire mutation events such as onfocus
which can blow away |this|. Need to protect it with a RefPtr.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::attach): add calls to suspend attach callbacks
until the function completes.

LayoutTests:

  • plugins/object-onfocus-mutation-crash-expected.txt: Added.
  • plugins/object-onfocus-mutation-crash.html: Added.
11:04 PM Changeset in webkit [112050] by Csaba Osztrogonác
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening after r112022.

  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
11:02 PM Changeset in webkit [112049] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Layers with animating transforms should prepaint even if they are not visible yet
​https://bugs.webkit.org/show_bug.cgi?id=82117

Patch by Dana Jansens <​danakj@chromium.org> on 2012-03-25
Reviewed by Adrienne Walker.

Source/WebCore:

For animating transforms, instead of early-outing when the layer's
visible rect is empty, let it prepaint regardless.

For now, we just only paint the outermost tiles, and only for small
layers, with at most 9 tiles.

This changes the behaviour of ContentLayerChromium's
idlePaintContentsIfDirty() so I've guarded the behaviour of the two
prepainting functions that it calls to ensure the old behaviour holds
without animations, and the new behaviour works with them.

Unit test: TiledLayerChromiumTest.idlePaintZeroSizedLayer

TiledLayerChromiumTest.idlePaintZeroSizedAnimatingLayer
TiledLayerChromiumTest.idlePaintNonVisibleLayers
TiledLayerChromiumTest.idlePaintNonVisibleAnimatingLayers

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::numPaintedTiles):
(TiledLayerChromium):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::tileSize):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):
(WTF::idlePaintRepeat):
(WTF::testHaveOuterTiles):

10:47 PM Changeset in webkit [112048] by kevino@webkit.org
  • 7 edits
    1 add in trunk

[wx] Unreviewed build fix. Move WTF to its own static lib build.

10:37 PM Changeset in webkit [112047] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing tests, decrease test coverage.

9:46 PM Changeset in webkit [112046] by kubo@profusion.mobi
  • 213 edits
    6 copies
    2 adds in trunk/LayoutTests

[EFL] More gardening. Update baselines and expectations in
fast/table and fast/text after the recent jhbuild and font
updates.

  • platform/efl/fast/table/002-expected.png:
  • platform/efl/fast/table/003-expected.png:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/004-expected.png:
  • platform/efl/fast/table/005-expected.png:
  • platform/efl/fast/table/007-expected.png:
  • platform/efl/fast/table/009-expected.png:
  • platform/efl/fast/table/012-expected.png:
  • platform/efl/fast/table/016-expected.png:
  • platform/efl/fast/table/017-expected.png:
  • platform/efl/fast/table/018-expected.png:
  • platform/efl/fast/table/020-expected.png:
  • platform/efl/fast/table/023-expected.png:
  • platform/efl/fast/table/025-expected.png:
  • platform/efl/fast/table/028-expected.png:
  • platform/efl/fast/table/028-vertical-expected.png:
  • platform/efl/fast/table/030-expected.png:
  • platform/efl/fast/table/035-expected.png:
  • platform/efl/fast/table/035-vertical-expected.png:
  • platform/efl/fast/table/036-expected.png:
  • platform/efl/fast/table/038-expected.png:
  • platform/efl/fast/table/038-vertical-expected.png:
  • platform/efl/fast/table/039-expected.png:
  • platform/efl/fast/table/041-expected.png:
  • platform/efl/fast/table/100-percent-cell-width-expected.png:
  • platform/efl/fast/table/add-before-anonymous-child-expected.png:
  • platform/efl/fast/table/append-cells-expected.png:
  • platform/efl/fast/table/append-cells2-expected.png:
  • platform/efl/fast/table/auto-with-percent-height-expected.png:
  • platform/efl/fast/table/auto-with-percent-height-vertical-expected.png:
  • platform/efl/fast/table/border-collapsing/001-expected.png:
  • platform/efl/fast/table/border-collapsing/001-vertical-expected.png:
  • platform/efl/fast/table/border-collapsing/002-expected.png:
  • platform/efl/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/efl/fast/table/border-collapsing/003-expected.png:
  • platform/efl/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
  • platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
  • platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
  • platform/efl/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
  • platform/efl/fast/table/cell-absolute-child-expected.png:
  • platform/efl/fast/table/cell-pref-width-invalidation-expected.txt:
  • platform/efl/fast/table/cell-width-auto-expected.png:
  • platform/efl/fast/table/cellindex-expected.png:
  • platform/efl/fast/table/colgroup-preceded-by-caption-expected.png:
  • platform/efl/fast/table/colgroup-spanning-groups-rules-expected.png:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/efl/fast/table/dynamic-cellpadding-expected.png:
  • platform/efl/fast/table/dynamic-descendant-percentage-height-expected.png:
  • platform/efl/fast/table/early-table-layout-expected.png:
  • platform/efl/fast/table/edge-offsets-expected.png:
  • platform/efl/fast/table/fixed-nested-expected.png:
  • platform/efl/fast/table/fixed-table-non-cell-in-row-expected.png:
  • platform/efl/fast/table/fixed-table-with-percent-inside-percent-table-expected.png:
  • platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png:
  • platform/efl/fast/table/fixed-table-with-percent-width-inside-div-expected.png:
  • platform/efl/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png:
  • platform/efl/fast/table/fixed-table-with-small-percent-width-expected.png:
  • platform/efl/fast/table/floating-th-expected.png:
  • platform/efl/fast/table/form-with-table-style-expected.png:
  • platform/efl/fast/table/generated-caption-expected.png:
  • platform/efl/fast/table/giantRowspan2-expected.png:
  • platform/efl/fast/table/height-percent-test-expected.png:
  • platform/efl/fast/table/insert-before-anonymous-ancestors-expected.png:
  • platform/efl/fast/table/insert-cell-before-form-expected.png:
  • platform/efl/fast/table/insert-row-before-form-expected.png:
  • platform/efl/fast/table/invisible-cell-background-expected.png:
  • platform/efl/fast/table/large-width-expected.png:
  • platform/efl/fast/table/max-width-integer-overflow-expected.txt:
  • platform/efl/fast/table/nobr-expected.png:
  • platform/efl/fast/table/overflowHidden-expected.png:
  • platform/efl/fast/table/overflowHidden-expected.txt:
  • platform/efl/fast/table/percent-heights-expected.png:
  • platform/efl/fast/table/relative-position-containment-expected.png:
  • platform/efl/fast/table/remove-td-display-none-expected.png:
  • platform/efl/fast/table/row-height-recalc-expected.png:
  • platform/efl/fast/table/rowindex-expected.png:
  • platform/efl/fast/table/rowspan-paint-order-vertical-expected.png:
  • platform/efl/fast/table/rtl-cell-display-none-assert-expected.png:
  • platform/efl/fast/table/rules-attr-dynchange1-expected.png:
  • platform/efl/fast/table/rules-attr-dynchange2-expected.png:
  • platform/efl/fast/table/spanOverlapRepaint-expected.png:
  • platform/efl/fast/table/table-after-child-in-table-expected.png:
  • platform/efl/fast/table/table-and-parts-outline-expected.png:
  • platform/efl/fast/table/table-before-child-in-table-expected.png:
  • platform/efl/fast/table/table-before-child-style-update-expected.png: Copied from LayoutTests/platform/efl/fast/text/whitespace/014-expected.png.
  • platform/efl/fast/table/table-cell-after-child-in-block-expected.png:
  • platform/efl/fast/table/table-cell-before-child-in-block-expected.png:
  • platform/efl/fast/table/table-cell-before-child-in-table-expected.png:
  • platform/efl/fast/table/table-display-types-expected.png:
  • platform/efl/fast/table/table-display-types-strict-expected.png:
  • platform/efl/fast/table/table-display-types-vertical-expected.png:
  • platform/efl/fast/table/table-hspace-align-center-expected.png:
  • platform/efl/fast/table/table-row-after-child-in-block-expected.png:
  • platform/efl/fast/table/table-row-before-child-in-block-expected.png:
  • platform/efl/fast/table/table-row-before-child-in-table-expected.png:
  • platform/efl/fast/table/table-row-before-child-style-update-expected.png: Copied from LayoutTests/platform/efl/fast/text/whitespace/014-expected.png.
  • platform/efl/fast/table/table-row-style-not-updated-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png.
  • platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
  • platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png: Copied from LayoutTests/platform/efl/fast/table/height-percent-test-expected.png.
  • platform/efl/fast/table/table-style-not-updated-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png.
  • platform/efl/fast/table/text-field-baseline-expected.png:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/table/unbreakable-images-quirk-expected.png:
  • platform/efl/fast/table/unused-percent-heights-expected.png:
  • platform/efl/fast/table/vertical-align-baseline-expected.png:
  • platform/efl/fast/text/atsui-kerning-and-ligatures-expected.png:
  • platform/efl/fast/text/atsui-multiple-renderers-expected.png:
  • platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/efl/fast/text/atsui-partial-selection-expected.png:
  • platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png:
  • platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/efl/fast/text/atsui-spacing-features-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/efl/fast/text/backslash-to-yen-sign-expected.png:
  • platform/efl/fast/text/basic/001-expected.png:
  • platform/efl/fast/text/basic/002-expected.png:
  • platform/efl/fast/text/basic/003-expected.png:
  • platform/efl/fast/text/basic/004-expected.png:
  • platform/efl/fast/text/basic/006-expected.png:
  • platform/efl/fast/text/basic/007-expected.png:
  • platform/efl/fast/text/basic/008-expected.png:
  • platform/efl/fast/text/basic/012-expected.png:
  • platform/efl/fast/text/basic/014-expected.png:
  • platform/efl/fast/text/basic/015-expected.png:
  • platform/efl/fast/text/basic/generic-family-changes-expected.png:
  • platform/efl/fast/text/basic/generic-family-reset-expected.png:
  • platform/efl/fast/text/break-word-expected.png:
  • platform/efl/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/efl/fast/text/capitalize-preserve-nbsp-expected.png:
  • platform/efl/fast/text/cg-vs-atsui-expected.png:
  • platform/efl/fast/text/decorations-transformed-expected.png:
  • platform/efl/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
  • platform/efl/fast/text/emphasis-avoid-ruby-expected.png:
  • platform/efl/fast/text/emphasis-overlap-expected.png:
  • platform/efl/fast/text/fake-italic-expected.png:
  • platform/efl/fast/text/hyphenate-character-expected.png:
  • platform/efl/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/efl/fast/text/hyphenate-limit-lines-expected.png:
  • platform/efl/fast/text/justified-selection-at-edge-expected.png:
  • platform/efl/fast/text/justified-selection-expected.png:
  • platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
  • platform/efl/fast/text/justify-padding-distribution-expected.png: Added.
  • platform/efl/fast/text/line-breaks-after-white-space-expected.png:
  • platform/efl/fast/text/line-breaks-expected.png:
  • platform/efl/fast/text/monospace-width-cache-expected.png:
  • platform/efl/fast/text/reset-emptyRun-expected.png:
  • platform/efl/fast/text/selection-hard-linebreak-expected.png:
  • platform/efl/fast/text/shadow-translucent-fill-expected.png:
  • platform/efl/fast/text/should-use-atsui-expected.png:
  • platform/efl/fast/text/soft-hyphen-4-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-inside-percent-table-expected.png.
  • platform/efl/fast/text/softHyphen-expected.png:
  • platform/efl/fast/text/text-letter-spacing-expected.png:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.png:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/fast/text/wbr-expected.png:
  • platform/efl/fast/text/wbr-in-pre-crash-expected.png:
  • platform/efl/fast/text/whitespace/002-expected.png:
  • platform/efl/fast/text/whitespace/002-expected.txt:
  • platform/efl/fast/text/whitespace/003-expected.png:
  • platform/efl/fast/text/whitespace/003-expected.txt:
  • platform/efl/fast/text/whitespace/004-expected.png:
  • platform/efl/fast/text/whitespace/004-expected.txt:
  • platform/efl/fast/text/whitespace/005-expected.png:
  • platform/efl/fast/text/whitespace/005-expected.txt:
  • platform/efl/fast/text/whitespace/006-expected.png:
  • platform/efl/fast/text/whitespace/006-expected.txt:
  • platform/efl/fast/text/whitespace/007-expected.png:
  • platform/efl/fast/text/whitespace/007-expected.txt:
  • platform/efl/fast/text/whitespace/008-expected.png:
  • platform/efl/fast/text/whitespace/008-expected.txt:
  • platform/efl/fast/text/whitespace/009-expected.png:
  • platform/efl/fast/text/whitespace/009-expected.txt:
  • platform/efl/fast/text/whitespace/010-expected.png:
  • platform/efl/fast/text/whitespace/010-expected.txt:
  • platform/efl/fast/text/whitespace/011-expected.png:
  • platform/efl/fast/text/whitespace/011-expected.txt:
  • platform/efl/fast/text/whitespace/012-expected.png:
  • platform/efl/fast/text/whitespace/012-expected.txt:
  • platform/efl/fast/text/whitespace/013-expected.png:
  • platform/efl/fast/text/whitespace/013-expected.txt:
  • platform/efl/fast/text/whitespace/014-expected.png:
  • platform/efl/fast/text/whitespace/014-expected.txt:
  • platform/efl/fast/text/whitespace/015-expected.png:
  • platform/efl/fast/text/whitespace/015-expected.txt:
  • platform/efl/fast/text/whitespace/016-expected.png:
  • platform/efl/fast/text/whitespace/016-expected.txt:
  • platform/efl/fast/text/whitespace/018-expected.png:
  • platform/efl/fast/text/whitespace/018-expected.txt:
  • platform/efl/fast/text/whitespace/020-expected.png:
  • platform/efl/fast/text/whitespace/020-expected.txt:
  • platform/efl/fast/text/whitespace/021-expected.png:
  • platform/efl/fast/text/whitespace/021-expected.txt:
  • platform/efl/fast/text/whitespace/022-expected.png:
  • platform/efl/fast/text/whitespace/025-expected.png:
  • platform/efl/fast/text/whitespace/025-expected.txt:
  • platform/efl/fast/text/whitespace/027-expected.png:
  • platform/efl/fast/text/whitespace/027-expected.txt:
  • platform/efl/fast/text/whitespace/030-expected.png:
  • platform/efl/fast/text/whitespace/030-expected.txt:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.png:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
  • platform/efl/fast/text/whitespace/tab-character-basics-expected.png:
  • platform/efl/fast/text/wide-zero-width-space-expected.png:
  • platform/efl/fast/text/word-break-expected.png:
  • platform/efl/fast/text/word-break-run-rounding-expected.png:
  • platform/efl/fast/text/word-break-soft-hyphen-expected.png:
  • platform/efl/fast/text/word-space-expected.png:
9:08 PM Changeset in webkit [112045] by kubo@profusion.mobi
  • 2 edits
    2 adds in trunk/LayoutTests

[EFL] Unreviewed gardening, add some baselines and skip a few
tests in fast/events.

  • platform/efl/Skipped:
  • platform/efl/fast/events/resize-events-expected.png: Added.
  • platform/efl/fast/events/resize-events-expected.txt: Added.
7:33 PM Changeset in webkit [112044] by kubo@profusion.mobi
  • 14 edits
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening, update baselines in editing/, media/
and scrollbars/.

  • platform/efl/editing/unsupported-content/table-type-after-expected.png:
  • platform/efl/editing/unsupported-content/table-type-before-expected.png:
  • platform/efl/media/controls-layout-direction-expected.png: Added.
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-empty-source-expected.png:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
  • platform/efl/scrollbars/basic-scrollbar-expected.png:
  • platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
  • platform/efl/scrollbars/disabled-scrollbar-expected.png:
  • platform/efl/scrollbars/scrollbar-buttons-expected.png:
  • platform/efl/scrollbars/scrollbar-orientation-expected.png:
7:17 PM Changeset in webkit [112043] by kubo@profusion.mobi
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Update baseline in animations/ after
the recent jhbuild/fonts updates.

  • platform/efl/animations/state-at-end-event-expected.png:
7:09 PM Changeset in webkit [112042] by kubo@profusion.mobi
  • 7 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Update some fonts/ baselines after the
recent jhbuild/fonts updates.

  • platform/efl/fonts/cursive-expected.png:
  • platform/efl/fonts/default-expected.png:
  • platform/efl/fonts/fantasy-expected.png:
  • platform/efl/fonts/monospace-expected.png:
  • platform/efl/fonts/sans-serif-expected.png:
  • platform/efl/fonts/serif-expected.png:
5:57 PM Changeset in webkit [112041] by kubo@profusion.mobi
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Update some tables/layering/ baselines.

  • platform/efl/tables/layering/paint-test-layering-1-expected.png:
  • platform/efl/tables/layering/paint-test-layering-2-expected.png:
4:50 PM Changeset in webkit [112040] by fpizlo@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

DFG int-to-double conversion should be revealed to CSE
​https://bugs.webkit.org/show_bug.cgi?id=82135

Reviewed by Oliver Hunt.

This introduces the notion of an Int32ToDouble node, which is injected
into the graph anytime we know that we have a double use of a node that
was predicted integer. The Int32ToDouble simplifies double speculation
on integers by skipping the path that would unbox doubles, if we know
that the value is already proven to be an integer. It allows integer to
double conversions to be subjected to common subexpression elimination
(CSE) by allowing the CSE phase to see where these conversions are
occurring. Finally, it allows us to see when a constant is being used
as both a double and an integer. This is a bit odd, since it means that
sometimes a double use of a constant will not refer directly to the
constant. This should not cause problems, for now, but it may require
some canonizalization in the future if we want to support strength
reductions of double operations based on constants.

To allow injection of nodes into the graph, this change introduces the
DFG::InsertionSet, which is a way of lazily inserting elements into a
list. This allows the FixupPhase to remain O(N) despite performing
multiple injections in a single basic block. Without the InsertionSet,
each injection would require performing an insertion into a vector,
which is O(N), leading to O(N2) performance overall. With the
InsertionSet, each injection simply records what insertion would have
been performed, and all insertions are performed at once (via
InsertionSet::execute) after processing of a basic block is completed.

(JSC::isActionableIntMutableArrayPrediction):
(JSC):
(JSC::isActionableFloatMutableArrayPrediction):
(JSC::isActionableTypedMutableArrayPrediction):
(JSC::isActionableMutableArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:

(JSC::DFG::useKindToString):
(DFG):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupBlock):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGInsertionSet.h: Added.

(DFG):
(Insertion):
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::index):
(JSC::DFG::Insertion::element):
(InsertionSet):
(JSC::DFG::InsertionSet::InsertionSet):
(JSC::DFG::InsertionSet::append):
(JSC::DFG::InsertionSet::execute):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(DFG):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:35 PM Changeset in webkit [112039] by fpizlo@apple.com
  • 8 edits
    1 move in trunk/Source/JavaScriptCore

DFGOperands should be moved out of the DFG and into bytecode
​https://bugs.webkit.org/show_bug.cgi?id=82151

Reviewed by Dan Bernstein.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Operands.h: Copied from Source/JavaScriptCore/dfg/DFGOperands.h.
  • dfg/DFGBasicBlock.h:
  • dfg/DFGNode.h:
  • dfg/DFGOSREntry.h:
  • dfg/DFGOSRExit.h:
  • dfg/DFGOperands.h: Removed.
  • dfg/DFGVariableAccessData.h:
2:47 PM Changeset in webkit [112038] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Don't use CSSRuleList for child rule ownership
​https://bugs.webkit.org/show_bug.cgi?id=82127

Reviewed by Andreas Kling.

Update for the new CSSStyleSheet.cssRules uniqueness behavior.

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
1:58 PM Changeset in webkit [112037] by Antti Koivisto
  • 19 edits in trunk/Source/WebCore

Don't use CSSRuleList for child rule ownership
​https://bugs.webkit.org/show_bug.cgi?id=82127

Reviewed by Andreas Kling.

CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule use CSSRuleList for storing children.
They should use a simple rule vector instead. CSSRuleList is a CSSOM type that should be
instantiated on-demand for API purposes only.

  • Use Vector<RefPtr<CSSRule>> for storing the rule children of CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule.
  • Add direct accessors, use internally instead of CSSRuleList.
  • Make CSSRuleList an abstract base. Add concrete subclasses for dealing with the underlying storage.
  • Instantiate CSSRuleLists on-demand.
  • Make CSSStyleSheet.cssRules always return the same object instance. This matches Firefox and the rest of our CSSOM implementation. Tested by fast/dom/gc-9.html.


The patch decouples internals from the external API. It simplifies the child rule ownership and reduces
indirection. Memory use of css rules with children is reduced (by a ptr, refcount and heap allocation overhead).

  • css/CSSGrammar.y:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::cssText):
(WebCore::CSSMediaRule::cssRules):

  • css/CSSMediaRule.h:

(WebCore::CSSMediaRule::create):
(CSSMediaRule):
(WebCore::CSSMediaRule::ruleCount):
(WebCore::CSSMediaRule::ruleAt):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createRuleList):
(WebCore::CSSParser::createRegionRule):

  • css/CSSParser.h:

(WebCore):

  • css/CSSRuleList.cpp:

(WebCore):
(WebCore::StaticCSSRuleList::StaticCSSRuleList):
(WebCore::StaticCSSRuleList::~StaticCSSRuleList):
(WebCore::StaticCSSRuleList::deref):
(WebCore::StaticCSSRuleList::item):

  • css/CSSRuleList.h:

(CSSRuleList):

Turn CSSRuleList into abstract interface.


(StaticCSSRuleList):
(WebCore::StaticCSSRuleList::create):
(WebCore::StaticCSSRuleList::ref):
(WebCore::StaticCSSRuleList::rules):
(WebCore::StaticCSSRuleList::styleSheet):
(WebCore::StaticCSSRuleList::length):

Concrete implementation for fixed list of rules.


(WebCore):
(LiveCSSRuleList):
(WebCore::LiveCSSRuleList::LiveCSSRuleList):
(WebCore::LiveCSSRuleList::ref):
(WebCore::LiveCSSRuleList::deref):
(WebCore::LiveCSSRuleList::length):
(WebCore::LiveCSSRuleList::item):
(WebCore::LiveCSSRuleList::styleSheet):

Concrete implemenation for live list backed by the underlying container rule.
LiveCSSRuleList is owned by the underlying rule. Refcount is forwarded.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/CSSStyleSheet.cpp:


The same scheme for CSSStyleSheet.cssRule as with container rules.


(StyleSheetCSSRuleList):
(WebCore::StyleSheetCSSRuleList::StyleSheetCSSRuleList):
(WebCore::StyleSheetCSSRuleList::ref):
(WebCore::StyleSheetCSSRuleList::deref):
(WebCore::StyleSheetCSSRuleList::length):
(WebCore::StyleSheetCSSRuleList::item):
(WebCore::StyleSheetCSSRuleList::styleSheet):
(WebCore):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):

  • css/CSSStyleSheet.h:

(CSSStyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore):
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::findRuleIndex):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore::WebKitCSSKeyframesRule::cssRules):

  • css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::ruleCount):
(WebCore::WebKitCSSKeyframesRule::ruleAt):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
(WebCore::WebKitCSSRegionRule::cssRules):

  • css/WebKitCSSRegionRule.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):

1:00 PM Changeset in webkit [112036] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove duplicated GenerateConditionalString() from code generators
​https://bugs.webkit.org/show_bug.cgi?id=82148

Reviewed by Adam Barth.

Previously GenerateConditionalString()s were defined in each code generator,
and they were doing the same thing. This patch puts GenerateConditionalString()
in CodeGenerator.pm and removes duplicated GenerateConditionalString()s.

No tests. No change in the generated code.

  • bindings/scripts/CodeGenerator.pm:

(GenerateConditionalString):

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateProperties):
(GenerateFunction):
(WriteData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateBatchedAttributeData):
(GenerateImplementation):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):

12:51 PM Changeset in webkit [112035] by haraken@chromium.org
  • 9 edits
    6 moves in trunk/Source/WebCore

Move DOMWindowSQLDatabase.* to DOMWindowWebDatabase.*, and move WorkerContextSQLDatabase.* to WorkerContextWebDatabase.*
​https://bugs.webkit.org/show_bug.cgi?id=82146

Reviewed by Adam Barth.

Now SQLDatabase is renamed to WebDatabase (See Modules/webdatabase/).
We should move DOMWindowSQLDatabase.* to DOMWindowWebDatabase.*,
and move WorkerContextSQLDatabase.* to WorkerContextWebDatabase.*.
We'll rename the SQL_DATABASE flag to the WEB_DATABASE flag in a follow-up patch.

No tests. No change in behavior.

  • Modules/webdatabase/DOMWindowWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.cpp.

(WebCore):
(WebCore::DOMWindowWebDatabase::openDatabase):

  • Modules/webdatabase/DOMWindowWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.h.

(WebCore):
(DOMWindowWebDatabase):
(WebCore::DOMWindowWebDatabase::DOMWindowWebDatabase):
(WebCore::DOMWindowWebDatabase::~DOMWindowWebDatabase):

  • Modules/webdatabase/DOMWindowWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.idl.
  • Modules/webdatabase/WorkerContextWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.cpp.

(WebCore):
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):

  • Modules/webdatabase/WorkerContextWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.h.

(WebCore):
(WorkerContextWebDatabase):
(WebCore::WorkerContextWebDatabase::WorkerContextWebDatabase):
(WebCore::WorkerContextWebDatabase::~WorkerContextWebDatabase):

  • Modules/webdatabase/WorkerContextWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.idl.
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
12:47 PM Changeset in webkit [112034] by kevino@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

[wx] Unreviewed build fix. Add header needed for Unix builds.

12:19 PM Changeset in webkit [112033] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebKit2

Unreviewed build fix for QtWebKit on Mac OS X.

  • UIProcess/API/qt/tests/bytearraytestdata.cpp:

(ByteArrayTestData::~ByteArrayTestData):

  • UIProcess/API/qt/tests/bytearraytestdata.h:
12:14 PM Changeset in webkit [112032] by pfeldman@chromium.org
  • 4 edits
    2 moves
    4 deletes in trunk/LayoutTests

Not reviewed: fixing Chromium Win7 baselines for editing/selection tests.

  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Removed.
  • platform/chromium-win-vista/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-win-vista/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-win-vista/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/editing/selection/selection-button-text-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.png.
  • platform/chromium-win/editing/selection/selection-button-text-expected.txt: Renamed from LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt.
12:07 PM Changeset in webkit [112031] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Rebaseline chromium foreignObject results, after Nikolas's rebaselines.

  • platform/chromium-win/svg/zoom/page/zoom-foreign-content-expected.png: Added.
10:41 AM Changeset in webkit [112030] by schenney@chromium.org
  • 5 edits
    3 adds in trunk

Avoid race condition when iterating over pending resources
​https://bugs.webkit.org/show_bug.cgi?id=82115

Patch by Philip Rogers <​pdr@google.com> on 2012-03-25
Reviewed by Nikolas Zimmermann.

Source/WebCore:

We can hit a race condition in SVGStyledElement::buildPendingResourcesIfNeeded
where pending elements can become non-pending while we iterate over them.

This patch cleans up buildPendingResourcesIfNeeded and re-works how pending
resources are removed. Because pending resources can be modified while
iterating over them, we introduce m_pendingResourcesForRemoval that
holds pending resources that are marked for removal. Instead of iterating
over this list we simply remove each pending resource from
m_pendingResourcesForRemoval; if a pending resource is modified or removed
during the processing of another pending resource this list is updated before
the next element can be accessed.

This change also removes removePendingResourceForElement which is no longer
referenced.

Test: http/tests/svg/change-id-with-pending-resources.html

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):

  • svg/SVGDocumentExtensions.h:

(SVGDocumentExtensions):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):

LayoutTests:

  • http/tests/svg/change-id-with-pending-resources-expected.txt: Added.
  • http/tests/svg/change-id-with-pending-resources.html: Added.
  • http/tests/svg/resources/svg-use-defs-rect.svg: Added.
10:18 AM Changeset in webkit [112029] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

10:06 AM Changeset in webkit [112028] by Lucas Forschler
  • 1 copy in tags/Safari-536.4

New Tag.

5:39 AM Changeset in webkit [112027] by Nikolas Zimmermann
  • 7 edits in trunk/LayoutTests

2012-03-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Rebaseline foreignObject results, after Florins changes.
Eventually the zoom-foreign-content-expected.png needs to be moved to platform/mac/, let's see.

  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/mac/test_expectations.txt:
  • svg/zoom/page/zoom-foreign-content-expected.png:
5:16 AM Changeset in webkit [112026] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor
​https://bugs.webkit.org/show_bug.cgi?id=82104
RIM PR: 145963

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-03-25
Reviewed by Rob Buis.

Source/WebCore:

The embedder may use vertex buffers, which affected the interpretation
our vertex array pointers from memory pointers to offsets into a vertex
buffer. The resulting geometry often resulted in no visible layers on
screen.

Fixed by getting rid of any bound buffer when we enter
LayerRenderer::drawLayers().

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawLayers):

Source/WebKit/blackberry:

The root layer may be set before we have a layer renderer, because the
latter is not created until we get an OpenGL context from the embedder.

Fixed by setting the root layer on the layer renderer when it's created
instead of assuming a certain order of events.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):

3:41 AM Changeset in webkit [112025] by pfeldman@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed: new chromium baseline for r112022.

  • platform/chromium-mac/svg/zoom/page/zoom-foreign-content-expected.png: Added.

Mar 24, 2012:

10:03 PM Changeset in webkit [112024] by nduca@chromium.org
  • 9 edits in trunk/Source

[chromium] Instrument gesture animations with async traces
​https://bugs.webkit.org/show_bug.cgi?id=82076

Reviewed by Adrienne Walker.

Source/WebCore:

  • platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::~ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurve.h:

(PlatformGestureCurve):

  • platform/TouchpadFlingPlatformGestureCurve.h:

(WebCore::TouchpadFlingPlatformGestureCurve::debugName):

  • platform/WheelFlingPlatformGestureCurve.h:

(WebCore::WheelFlingPlatformGestureCurve::debugName):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::~CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurve):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebCore::PlatformGestureToCCGestureAdapter::debugName):
(PlatformGestureToCCGestureAdapter):

9:24 PM Changeset in webkit [112023] by jpfau@apple.com
  • 6 edits in trunk

XML error document creation should not fire mutation events
​https://bugs.webkit.org/show_bug.cgi?id=80765

Reviewed by Adam Barth.

Source/WebCore:

Broke two tests that expected the old behavior, which have now been updated.

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

LayoutTests:

Fixed tests that relied on old behavior.

  • fast/css/stylesheet-candidate-nodes-crash-expected.txt:
  • fast/css/stylesheet-candidate-nodes-crash.xhtml:
  • fast/dom/xml-parser-error-message-crash-expected.txt:
9:08 PM Changeset in webkit [112022] by commit-queue@webkit.org
  • 11 edits
    3 adds in trunk

ForeignObject content is zoomed two times
​https://bugs.webkit.org/show_bug.cgi?id=76282

Patch by Florin Malita <​fmalita@google.com> on 2012-03-24
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/zoom/page/zoom-foreign-content.svg

Reset the effective zoom property for FO-nested content to avoid
having the zoom factor applied multiple times (zooming is handled by
the top level SVG root element).

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

LayoutTests:

  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:

Rebaseline cr-linux expectations.

  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:

Updated zoom-foreignObject.svg expectations, pending rebaseline.

  • svg/zoom/page/zoom-foreign-content-expected.png: Added.
  • svg/zoom/page/zoom-foreign-content-expected.txt: Added.
  • svg/zoom/page/zoom-foreign-content.svg: Added.
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/text/zoom-foreignObject.svg:

Updated test to cover SVG FO text.

9:03 PM Changeset in webkit [112021] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AX: Support solution to handle invalid ax text marker
​https://bugs.webkit.org/show_bug.cgi?id=82023

Reviewed by Oliver Hunt.

Source/WebCore:

This provides methods to better use text markers so that assistive technologies
can know when they are valid, and can convert them to and from absolute positions.

Test: platform/mac/accessibility/textmarker-routines.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(indexForTextMarkerCallback):
(isTextMarkerValidCallback):
(textMarkerForIndexCallback):
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::isTextMarkerValid):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::isTextMarkerValid):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):

LayoutTests:

  • platform/mac/accessibility/textmarker-routines-expected.txt: Added.
  • platform/mac/accessibility/textmarker-routines.html: Added.
8:59 PM Changeset in webkit [112020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Quick fix for rendering controls regression.
​https://bugs.webkit.org/show_bug.cgi?id=82125

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-24
Reviewed by Eric Carlson.

Only temporary fix. Tests to cover the problem should be added

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeOpaque): The display:none
property should be toggled only by the media element now.
(WebCore::MediaControlPanelElement::makeTransparent): The timer
that toggles the dispalay:none shouldn't be used now.

8:50 PM Changeset in webkit [112019] by kov@webkit.org
  • 12 edits in trunk/Tools

Unreviewed, rolling out r112014.
​http://trac.webkit.org/changeset/112014
​https://bugs.webkit.org/show_bug.cgi?id=82138

Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-03-24

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_http_locking):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(AbstractWorker.run):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):

  • Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:

(WorkerTest.test_default_platform_in_worker):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.is):
(MeteredStream.init):
(MeteredStream.write):
(MeteredStream.update):
(MeteredStream._overwrite):
(MeteredStream._reset):

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(TestMeteredStream):
(TestMeteredStream.test_regular):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(_configure_logging):
(_restore_logging):
(Printer.init):
(Printer.cleanup):
(Printer.print_progress):
(Printer.print_update):
(Printer._write):
(Printer):
(Printer._update):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.get_printer):
(Testprinter.test_print_progress):
(Testprinter.test_print_progress.mock_time):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_pause_before_testing):

7:29 PM Changeset in webkit [112018] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG 64-bit Branch implementation should not be creating a JSValueOperand that
it isn't going to use
​https://bugs.webkit.org/show_bug.cgi?id=82136

Reviewed by Geoff Garen.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

6:41 PM Changeset in webkit [112017] by kevino@webkit.org
  • 7 edits in trunk

[wx] Unreviewed. Fix the build after WTF move.

6:32 PM Changeset in webkit [112016] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Unreviewed. Add header needed for compilation.

5:46 PM Changeset in webkit [112015] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG double voting may be overzealous in the case of variables that end up
being used as integers
​https://bugs.webkit.org/show_bug.cgi?id=82008

Reviewed by Oliver Hunt.

Cleaned up propagation, making the intent more explicit in most places.
Back-propagate NodeUsedAsInt for cases where a node was used in a context
that is known to strongly prefer integers.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):

2:22 PM Changeset in webkit [112014] by dpranke@chromium.org
  • 12 edits in trunk/Tools

clean up NRWT logging/metering, be less verbose
​https://bugs.webkit.org/show_bug.cgi?id=73846

Reviewed by Ojan Vafai.

This patch totally rewrites the metered_stream module and
changes the way it and the printing module now interact with the
logging subsystem.

The printing module becomes a dumb layout_tests-specific wrapper around
the metered stream. All of the intelligence of how and when to
actually write (or erase) lines and how things interact with
logging moves into the metered stream.

As of now, anything written to the metered stream *bypasses the
logging system*. If a logger is passed to the meter constructor,
the metered stream will also attach a log handler so that all
messages fed to the logger will also be written to the metered
stream. This detangles the logic that used to exist where
sometimes the meter would write to the logger and sometimes the
logger would write to the meter.

All of this makes the logic generic and reusable for
test-webkitpy (coming in another patch). It also helps clarify
what the mysterious "configure_logging" parameter to the printer
constructor used to do (that parameter itself is gone now, and
by default the printer and metered_stream will not ever touch
the logging system; this makes a bunch of tests less fragile).

All of the above should produce no user-visible changes.

However, to also fix the bug in question, we change the message
format in --verbose mode to %H:%M:%S.%frac %pid %message,
eliminating the date, file:lineno, and level parameters. I am
making this change at the same time because it would be
difficult to write things consistently between the logs and the
metered stream if we were still logging the file:lineno.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Remove the configure_logging parameter
  • Scripts/webkitpy/layout_tests/controllers/worker.py: Use metered stream to configure the logging (we don't need a printer) and be careful about when and how we manipulate the log level and handlers on the root logger.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Pass in the root logger so that log messages are formatted properly, and set the log level outside of any routines called by unit tests so as to not interfere.
  • Scripts/webkitpy/layout_tests/views/manager_worker_broker.py: remove a duplicate log message.
  • Scripts/webkitpy/layout_tests/views/metered_stream.py: complete rewrite :).
  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: complete rewrite :).
  • Scripts/webkitpy/layout_tests/views/printing.py: move the logging configuration into metered_stream, and also move the "when should I log progress messages" into metered stream.
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py: remove tests that are no longer necessary.
  • Scripts/webkitpy/performance_tests/perftestsrunner.py: remove the configure_logging parameter.
  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: update the test; since the printer no longer writes to the log, we need to check what is written to the regular_output instead. (test_run_test_pause_before_testing):
1:15 PM Changeset in webkit [112013] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::Node::shouldNotSpeculateInteger() should be eliminated
​https://bugs.webkit.org/show_bug.cgi?id=82123

Reviewed by Geoff Garen.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(Node):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

1:03 PM Changeset in webkit [112012] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash in ApplyStyleCommand::applyInlineStyleToNodeRange.
​https://bugs.webkit.org/show_bug.cgi?id=81959

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/execCommand/apply-style-command-crash.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): RefPtr the weak
node iterator |node|.

  • editing/ApplyStyleCommand.h:

(ApplyStyleCommand): convert |startNode| and |pastEndNode| into PassRefPtr.

LayoutTests:

  • editing/execCommand/apply-style-command-crash-expected.txt: Added.
  • editing/execCommand/apply-style-command-crash.html: Added.
12:13 PM Changeset in webkit [112011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Increase getByIdSlowCase ConstantSpace/InstructionSpace for CPU(ARM_TRADITIONAL)
​https://bugs.webkit.org/show_bug.cgi?id=81521

Increase sequenceGetByIdSlowCaseConstantSpace and sequenceGetByIdSlowCaseInstructionSpace
for CPU(ARM_TRADITIONAL) to fit actual need.

Patch by Yong Li <​yoli@rim.com> on 2012-03-24
Reviewed by Oliver Hunt.

  • jit/JIT.h:

(JIT):

10:08 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
10:06 AM Changeset in webkit [112010] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 112002

10:05 AM Changeset in webkit [112009] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 112001

10:05 AM Changeset in webkit [112008] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Reverting r90755 (Merging 112000)

10:04 AM Changeset in webkit [112007] by kov@webkit.org
  • 1 edit
    1 add in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 111999

10:02 AM Changeset in webkit [112006] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 111998

10:02 AM Changeset in webkit [112005] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging 111997.

10:01 AM Changeset in webkit [112004] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/gtk

[GTK] Replace occurrences of "uri" in the documentation with "URI"
​https://bugs.webkit.org/show_bug.cgi?id=82025

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

In documentation "uri" should really be written as "URI" so
we should fix all existing strings.

  • webkit/webkitdownload.cpp: Replace "uri" with "URI."
  • webkit/webkitnetworkrequest.cpp: Ditto.
  • webkit/webkitnetworkresponse.cpp: Ditto.
  • webkit/webkitwebhistoryitem.cpp: Ditto.
  • webkit/webkitwebresource.cpp: Ditto.

(webkit_web_resource_class_init):

10:00 AM Changeset in webkit [112003] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/po

Merging r111996.

9:51 AM Changeset in webkit [112002] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated German translation
​https://bugs.webkit.org/show_bug.cgi?id=77834

Patch by Christian Kirbach <​Christian.Kirbach@googlemail.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • de.po:
9:46 AM Changeset in webkit [112001] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated Norwegian bokmål translation for webkitgtk
​https://bugs.webkit.org/show_bug.cgi?id=73891

Patch by Kjartan Maraas <​kmaraas@gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • nb.po:
9:37 AM Changeset in webkit [112000] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed, rolling out r90755.
​http://trac.webkit.org/changeset/90755
​https://bugs.webkit.org/show_bug.cgi?id=44410

This is actually less up-to-date then the one we committed
before

  • id.po:
9:32 AM Changeset in webkit [111999] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

[l10n] [mr] WebKitGTK+ Marathi Translations
​https://bugs.webkit.org/show_bug.cgi?id=82014

Patch by Sandeep Shedmake <​sshedmak@redhat.com> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • mr.po: Added.
9:26 AM Changeset in webkit [111998] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated en_GB translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=82093

Patch by Chris Leonard <​cjl@laptop.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • en_GB.po:
9:21 AM Changeset in webkit [111997] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Add Galician translations for webkitgtk
​https://bugs.webkit.org/show_bug.cgi?id=67591

Patch by Fran Dieguez <​frandieguez@gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • gl.po:
9:11 AM Changeset in webkit [111996] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Slovenian translation update
​https://bugs.webkit.org/show_bug.cgi?id=68504

Patch by Matej Urbančič <​mateju@svn.gnome.org> on 2012-03-24
Reviewed by Gustavo Noronha Silva.

  • sl.po:
9:08 AM Changeset in webkit [111995] by kov@webkit.org
  • 2 edits in trunk/Tools

Add myself and Martin Robinson to: * GStreamerGraphics * GtkWebKit2PublicAPI * SoupNetwork and to the newly created WebKitGTKTranslations.

Rubber-stamped by Martin Robinson.

  • Scripts/webkitpy/common/config/watchlist:
8:36 AM Changeset in webkit [111994] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2012-03-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: restoring chromium's expectations for effect-custom-parameters-expected.png.

  • platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
8:23 AM Changeset in webkit [111993] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] Implement PageClient::isViewWindowActive()
​https://bugs.webkit.org/show_bug.cgi?id=81143

Patch by Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org> on 2012-03-24
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

6:34 AM Changeset in webkit [111992] by jesus@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix since we use "-Werror=unused-but-set-variable".

The variable 'it' was set at TextureMapperShaderManager.h:110 but never used.

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderManager::getShaderProgram):

4:51 AM Changeset in webkit [111991] by pfeldman@chromium.org
  • 13 edits
    3 adds in trunk/LayoutTests

Updated chromium baselines wrt button selection changes in r111946.
Not reviewed.

  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-win-vista/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-win-vista/editing/selection/3690703-expected.png: Added.
  • platform/chromium-win-vista/editing/selection/3690719-expected.png: Added.
3:45 AM Changeset in webkit [111990] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updating chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:07 AM Changeset in webkit [111989] by mitz@apple.com
  • 1 edit
    4 copies in trunk/LayoutTests

Added Mac expected results for these two tests. The results were accidentally removed in
r111545, even though these tests were not converted into reftests.

  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Copied from LayoutTests/platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Copied from LayoutTests/platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt.
1:54 AM Changeset in webkit [111988] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added Mac expected results for this test that was added in r111139.

  • platform/mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/mac/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
1:49 AM Changeset in webkit [111987] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added Mac expected results for this test that was added in r111946.

  • platform/mac/editing/selection/selection-button-text-expected.png: Added.
  • platform/mac/editing/selection/selection-button-text-expected.txt: Added.
1:37 AM Changeset in webkit [111986] by zeno.albisser@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][WK2] Make TextureMapperShaderManager::getShaderProgram() not be a template.
​https://bugs.webkit.org/show_bug.cgi?id=82049

Change the getShaderProgram() function to not be a template.
This is a workaround for a compiler bug that leads to an assert
when compiling in debug mode on mac.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::beginClip):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderManager::getShaderProgram):
(TextureMapperShaderManager):

1:36 AM Changeset in webkit [111985] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
1:10 AM Changeset in webkit [111984] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
12:01 AM Changeset in webkit [111983] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.