Context Navigation

← Previous Period
Next Period →

Timeline

Mar 26, 2012:

11:56 PM Changeset in webkit [112212] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

platform/chromium/test_expectations.txt:

11:39 PM Changeset in webkit [112211] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

platform/chromium/test_expectations.txt:

11:36 PM Changeset in webkit [112210] by kubo@profusion.mobi

36 edits in trunk/LayoutTests

[EFL] More gardening, update some fast/replaced expectations.

platform/efl/fast/replaced/001-expected.png:
platform/efl/fast/replaced/002-expected.png:
platform/efl/fast/replaced/003-expected.png:
platform/efl/fast/replaced/004-expected.png:
platform/efl/fast/replaced/005-expected.png:
platform/efl/fast/replaced/007-expected.png:
platform/efl/fast/replaced/absolute-image-sizing-expected.png:
platform/efl/fast/replaced/absolute-position-percentage-height-expected.png:
platform/efl/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/efl/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/efl/fast/replaced/applet-disabled-positioned-expected.png:
platform/efl/fast/replaced/applet-rendering-java-disabled-expected.png:
platform/efl/fast/replaced/border-radius-clip-expected.png:
platform/efl/fast/replaced/image-resize-width-expected.png:
platform/efl/fast/replaced/image-sizing-expected.png:
platform/efl/fast/replaced/image-solid-color-with-alpha-expected.png:
platform/efl/fast/replaced/inline-box-wrapper-handover-expected.png:
platform/efl/fast/replaced/max-width-percent-expected.png:
platform/efl/fast/replaced/object-align-hspace-vspace-expected.png:
platform/efl/fast/replaced/outline-replaced-elements-expected.png:
platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
platform/efl/fast/replaced/replaced-breaking-expected.png:
platform/efl/fast/replaced/replaced-breaking-expected.txt:
platform/efl/fast/replaced/replaced-breaking-mixture-expected.png:
platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
platform/efl/fast/replaced/selection-rect-in-table-cell-expected.png:
platform/efl/fast/replaced/selection-rect-transform-expected.png:
platform/efl/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/efl/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/efl/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/efl/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/efl/fast/replaced/width100percent-button-expected.png:
platform/efl/fast/replaced/width100percent-image-expected.png:
platform/efl/fast/replaced/width100percent-textarea-expected.png:
platform/efl/fast/replaced/width100percent-textfield-expected.png:

11:23 PM Changeset in webkit [112209] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: chromium test expectations lint.

platform/chromium/test_expectations.txt:

11:06 PM Changeset in webkit [112208] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: marking fast/events/platform-wheelevent-* as flaky on
Chromium Snow Leopard.

platform/chromium/test_expectations.txt:

10:32 PM Changeset in webkit [112207] by commit-queue@webkit.org

14 edits in trunk/Source/WebCore

Unreviewed, rolling out r112199.
http://trac.webkit.org/changeset/112199
https://bugs.webkit.org/show_bug.cgi?id=82295

Breaks Chromium Win compilation (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-26

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
(WebCore):

bindings/v8/V8DOMWrapper.h:

(WebCore):
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

10:09 PM Changeset in webkit [112206] by senorblanco@chromium.org

2 edits in trunk/Source/WebKit/chromium

Disable CCLayerTreeHostTestSetSingleLostContext.runMultiThread.
https://bugs.webkit.org/show_bug.cgi?id=82285

Reviewed by James Robinson.

tests/CCLayerTreeHostTest.cpp:

(WTF::TEST_F):

9:41 PM Changeset in webkit [112205] by scherkus@chromium.org

4 edits
2 deletes in trunk/Source/WebKit/chromium

[chromium] Remove WebMediaElement from Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=82277

Reviewed by James Robinson.

This was added in r63859 but is no longer used by anyone.

WebKit.gyp:
public/WebMediaElement.h: Removed.
src/WebMediaElement.cpp: Removed.

9:25 PM Changeset in webkit [112204] by commit-queue@webkit.org

1 edit
2 moves in trunk/LayoutTests

Fix flaky test fast/eventsource/eventsource-url-attribute.html
https://bugs.webkit.org/show_bug.cgi?id=82257

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-26
Reviewed by Ryosuke Niwa.

The test used http://localhost, chosen as a semi-random url, but since
it doesn't return a text/event-stream mime-type sometimes a console
warning would appear. Moved the test to the http folder and changed it
to use a resource with the correct mime-type.

http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.

8:58 PM Changeset in webkit [112203] by ddkilzer@apple.com

3 edits in trunk/Source/WebCore

Build system prep work for upstreaming iOS changes
<http://webkit.org/b/82267>

Reviewed by Mark Rowe.

DerivedSources.make: Move 'bison' into a variable and use

xcrun to find it on Mac OS X.

bindings/scripts/preprocessor.pm:

(applyPreprocessor): Add local @args variable. On iOS, the
compiler needs additional "-isysroot $(SDKROOT)" arguments when
invoked, so it's easier to add them to an array, especially if
$SDKROOT contains a space in the path. Remove now-redundant
$gccLocation variable.

8:50 PM Changeset in webkit [112202] by dgrogan@chromium.org

124 edits
119 copies
3 adds in trunk/LayoutTests

Extract logic of indexeddb html layout tests into js files that can
be run from either a worker or a window.

The two changed -expected.txt files are just for line numbers in JS
error messages.

Skipped were:

transaction-abort-with-js-recursion.html
transaction-abort-with-js-recursion-cross-frame.html
noblobs.html
structured-clone.html
tutorial.html

The first four simulate mouse events and the last isn't really a test.
structured-clone.html will be refactored for worker compatibility in a
future patch.

https://bugs.webkit.org/show_bug.cgi?id=81440

Reviewed by Tony Chang.

storage/indexeddb/constants.html:
storage/indexeddb/create-and-remove-object-store.html:
storage/indexeddb/create-object-store-options.html:

... every html file in storage/indexeddb except the ones listed above

storage/indexeddb/exception-in-event-aborts-expected.txt:

line number in javascript error message changed

storage/indexeddb/version-change-abort-expected.txt:

line number in javascript error message changed

8:50 PM Changeset in webkit [112201] by Nate Chapin

11 edits in trunk/Source/WebCore

Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedCSSStyleSheet.h:
loader/cache/CachedFont.cpp:
loader/cache/CachedFont.h:
loader/cache/CachedImage.cpp:
loader/cache/CachedResource.h: Make checkNotify()

virtual, so the right checkNotify() gets called in error().

loader/cache/CachedScript.cpp:
loader/cache/CachedScript.h:
loader/cache/CachedXSLStyleSheet.cpp:
loader/cache/CachedXSLStyleSheet.h:

8:16 PM Changeset in webkit [112200] by commit-queue@webkit.org

7 edits
2 adds in trunk

Assert failure from capitalized RenderTextFragment
https://bugs.webkit.org/show_bug.cgi?id=82096

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

The cause of this bug was the call to RenderTextFragment::setTextInternal
resulting from a style change from RenderObject::addChild. The idea here
is to better separate the code path for transforming existing text from
the code path for replacing the underlying text of a node. For
RenderTextFragment this has to be clear because only in the latter case
does the first-letter get reset.

rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Added call to transformText

rendering/RenderText.cpp:

(WebCore::RenderText::styleDidChange): Added call to transformText
(WebCore::RenderText::transformText): Added

rendering/RenderText.h:

(WebCore::RenderText::setText): Changed to virtual so RenderTextFragment can override
(WebCore::RenderText::transformText): Added

rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::styleDidChange): Removed references to
m_allowFragmentReset which was the previous approach to separating the
code paths
(WebCore::RenderTextFragment::setTextInternal): Deleted
(WebCore::RenderTextFragment::setText): Added with most of logic that was
previously in setTextInternal
(WebCore::RenderTextFragment::transformText): Added

rendering/RenderTextFragment.h:

(WebCore::RenderTextFragment::setText): Added
(WebCore::RenderTextFragment::transformText): Added
(WebCore::RenderTextFragment::setTextInternal): Deleted

LayoutTests:

Test that exercises failure condition in bug 82096.

fast/css/first-letter-capitalized-edit-select-crash-expected.txt: Added
fast/css/first-letter-capitalized-edit-select-crash.html: Added

7:58 PM Changeset in webkit [112199] by adamk@chromium.org

14 edits in trunk/Source/WebCore

Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Adam Barth.

This moves leakRef() calls out of generated code, centralizing them in
V8DOMWrapper implementation. Ideally, WeakReferenceMap::set would take
PassRefPtrs, but that's tricky given that some WeakReferenceMap's KeyType is 'void'
(which clearly can't be wrapped in a PassRefPtr).

Updated binding tests to reflect changes in CodeGeneratorV8.pm, no change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use GetDomMapFunction instead of custom logic.
(GenerateNamedConstructorCallback): ditto.
(GenerateToV8Converters): Call V8DOMWrapper::setJSWrapper* method
instead of directly accessing the wrapper maps and calling set.
(GetDomMapFunction): Refactored to call new GetDomWrapperMapName function.
(GetDomWrapperMapName): Helper pulled out of GetDomMapFunction.

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

bindings/v8/V8DOMWrapper.cpp: Moved setJSWrapperForDOMNode method to header to inline it.
bindings/v8/V8DOMWrapper.h:

(WebCore): Forward decls.
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Made inline.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): ditto.
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Refactored into two methods;
this one handles non-active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): Pulled out of previouse
DOMNode method, now handles only active Nodes.
(WebCore::V8DOMWrapper::setJSWrapperForDOMSVGElementInstance): New helper method for SVGElementInstances.

7:45 PM Changeset in webkit [112198] by psolanki@apple.com

21 edits in trunk/Source

Fix typo in method name - WebCore::miminumValueForLength should be WebCore::minimumValueForLength
https://bugs.webkit.org/show_bug.cgi?id=82254

Reviewed by Benjamin Poulain.

Source/WebCore:

No new tests because no functional changes.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):
(WebCore::valueForLength):

css/LengthFunctions.h:

(WebCore):

html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

rendering/RenderInline.cpp:

(WebCore::computeMargin):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):

rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

rendering/RenderText.h:

(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):

rendering/style/RenderStyle.h:

Source/WebKit2:

WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

7:42 PM Changeset in webkit [112197] by shinyak@chromium.org

3 edits
2 adds in trunk

Triggers assertion if dragging from outside of <meter> in a shadow tree to inside of it.
https://bugs.webkit.org/show_bug.cgi?id=82177

Reviewed by Dimitri Glazkov.

Source/WebCore:

VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries has moved the start position or
the end position to the invalid position, i.e. position after (before) the non-existing node.

This patch fixes the problem, and adds assertion that the selection does not cross shadow boundaries.

Test: fast/dom/shadow/drag-to-meter-in-shadow-crash.html

editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

LayoutTests:

fast/dom/shadow/drag-to-meter-in-shadow-crash-expected.txt: Added.
fast/dom/shadow/drag-to-meter-in-shadow-crash.html: Added.

7:41 PM Changeset in webkit [112196] by commit-queue@webkit.org

11 edits in trunk

Enable layout testing of the scroll animator.
https://bugs.webkit.org/show_bug.cgi?id=81858
Add a call to the InternalSettings that layout tests can use to
turn on scroll animation. Enable animation updates for the
Chromium platform DRT when scroll animation has been turned on in
a test. This should be a no-op for all current layout tests.

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-26
Reviewed by James Robinson.

Source/WebCore:

No new tests. Layout test results should be unchanged.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEnableScrollAnimator):
(WebCore):
(WebCore::InternalSettings::scrollAnimatorEnabled):

testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::scrollAnimatorEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::serviceAnimation):
(WebViewHost::scheduleAnimation):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

7:29 PM Changeset in webkit [112195] by commit-queue@webkit.org

10 edits
1 copy
7 adds in trunk

[Qt][WK2] Support multi-file upload
https://bugs.webkit.org/show_bug.cgi?id=81589

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-26
Reviewed by Simon Hausmann.

Source/WebKit2:

Added 'allowMutipleFiles' property to filePicker context property to indicate whether to allow
multiple file selections.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::chooseFiles):

UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_multiFileUpload.qml: Added.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml:
UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Added.
UIProcess/API/qt/tests/qmltests/common/singlefileupload.html:
UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Added.

(updateTitle):

UIProcess/qt/QtDialogRunner.cpp:

(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::allowMultipleFiles):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):

UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

Tools:

Modified filePicker to support multi-file upload.

MiniBrowser/qt/MiniBrowser.qrc:
MiniBrowser/qt/icons/checkbox_checked.png: Added.
MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
MiniBrowser/qt/js/MultiSelect.js: Added.

(values):
(isSelected):
(removeValue):

MiniBrowser/qt/qml/CheckBox.qml: Added.
MiniBrowser/qt/qml/FilePicker.qml:

7:17 PM Changeset in webkit [112194] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebCore

Fix minor spell error in DocumentLoader.h
https://bugs.webkit.org/show_bug.cgi?id=82141

Reviewed by Nate Chapin.

Just fix spell error, no new tests.

loader/DocumentLoader.h:

(WebCore::DocumentLoader::setClientRedirectSourceForHistory):

7:13 PM Changeset in webkit [112193] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[Skia] Remove use of deprecated Skia constant and struct field names
https://bugs.webkit.org/show_bug.cgi?id=81034

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-26
Reviewed by James Robinson.

No behavior change, so no tests. The modified code is executed by many existing tests.

platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):

platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

7:03 PM Changeset in webkit [112192] by commit-queue@webkit.org

6 edits in trunk/Source/JavaScriptCore

Unaligned userspace access for SH4 platforms
https://bugs.webkit.org/show_bug.cgi?id=79104

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-26
Reviewed by Gavin Barraclough.

assembler/AbstractMacroAssembler.h:

(Jump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):

assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::extraInstrForBranch):
(SH4Assembler):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):

jit/JIT.h:

(JIT):

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

7:01 PM Changeset in webkit [112191] by nduca@chromium.org

21 edits in trunk/Source

[chromium] Add isInputThrottled/didBecomeReadyForAdditionalInput to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=82265

Source/Platform:

Reviewed by James Robinson.

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::didCommit):

Source/WebCore:

In threaded compositing mode, the WebWidget is self-scheduled,
receiving damage and processing it without forwarding that damage
up to the embedding WebWidgetClient. In Chromium's case, the
client uses the presence of damage to perform input flow
control. This patch exposes the need for input flow control to the
embedder, while keeping the actual logic about what exactly
warrants input flow control inside the implementation.

Reviewed by James Robinson.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::commitRequested):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(CCLayerTreeHost):

platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitRequested):
(WebCore):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::commitRequested):
(WebCore):

platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Reviewed by James Robinson.

public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::isInputThrottled):

public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::didBecomeReadyForAdditionalInput):

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::commitRequested):
(WebKit):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit):

src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::isInputThrottled):
(WebKit):
(WebKit::WebViewImpl::didCommit):

src/WebViewImpl.h:

(WebViewImpl):

tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::didCommit):
(MockLayerTreeHostClient):

tests/FakeCCLayerTreeHostClient.h:

(FakeCCLayerTreeHostClient):

6:59 PM Changeset in webkit [112190] by abarth@webkit.org

7 edits in trunk

When <img crossorigin> fails the CORS check, we should fire the error event
https://bugs.webkit.org/show_bug.cgi?id=81998

Reviewed by Nate Chapin.

Source/WebCore:

The spec says we're supposed to fire the error event when the CORS
check fails, but we haven't been. This patch is larger than it might
otherwise be because we're firing the event asynchronously, but that
seems like the right thing to do.

Tests: http/tests/security/img-with-failed-cors-check-fails-to-load.html

dom/Document.cpp:

(WebCore::Document::implicitClose):

loader/ImageLoader.cpp:

(WebCore::errorEventSender):
(WebCore):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::dispatchPendingEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvents):

loader/ImageLoader.h:

(ImageLoader):

LayoutTests:

Check that we're firing the error event in this case.

http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt:
http/tests/security/img-with-failed-cors-check-fails-to-load.html:

6:56 PM Changeset in webkit [112189] by mhahnenberg@apple.com

4 edits in trunk/Tools

Retry crashing tests serially at the end of NRWT on Apple Mac
https://bugs.webkit.org/show_bug.cgi?id=82233

Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

Scripts/webkitpy/layout_tests/port/base.py:

(Port.should_retry_crashes):

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.should_retry_crashes):

6:32 PM Changeset in webkit [112188] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Rebaseline after r112177.

fast/dom/css-dom-read-2-expected.txt:

6:31 PM Changeset in webkit [112187] by senorblanco@chromium.org

10 edits in trunk/Source/WebCore

Make filters and the threaded compositor play well together.
https://bugs.webkit.org/show_bug.cgi?id=78139

Use a dedicated GraphicsContext3D instance for all filters calls in
the threaded case. Clone all FilterOperations for thread safety
in the threaded case.

Reviewed by James Robinson.

Covered by tests in LayoutTests/css3/filters.

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setFilters):
Set a global flag if we've seen content with filters, so we know
we need to create the filter context.
(WebCore::LayerChromium::pushPropertiesTo):
Clone all filter operations if we're in the threaded case.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::needsFilterContext):
(WebCore::CCLayerTreeHost::setNeedsFilterContext):
(CCLayerTreeHost):
Add flag and accessors for needsFilterContext.

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::applyFilters):
Pick up the appropriate context from SharedGraphicsContext3D,
depending if we're in the threaded case or not.

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::recreateContext):
For the threaded compositor re-create the filter context
alongside the main compositor context on lost context, if requested.
(WebCore::CCThreadProxy::beginFrame):
Create the filter context in beginFrame, if it was resquested and is
NULL. This handles the first-use case.

platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::clone):
Assert if trying to clone the custom filter operation (it has
non-threadsafe members).

platform/graphics/filters/FilterOperation.h:

(WebCore::DefaultFilterOperation::clone):
(WebCore::PassthroughFilterOperation::clone):
(WebCore::ReferenceFilterOperation::clone):
(WebCore::BasicColorMatrixFilterOperation::clone):
(WebCore::BasicComponentTransferFilterOperation::clone):
(WebCore::GammaFilterOperation::clone):
(WebCore::BlurFilterOperation::clone):
(WebCore::DropShadowFilterOperation::clone):
Add clone methods for all FilterOperations.

platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):
(WebCore::SharedGraphicsContext3DImpl::getContext):
(WebCore::SharedGraphicsContext3DImpl::createContext):
(WebCore::SharedGraphicsContext3D::get):
(WebCore::getOrCreateContextForImplThread):
(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):
Split out context creation, lost context recovery, and retrieval
into separate functions, so the impl thread can use only the parts
it wants on the threads it wants (create and have on main, get on impl).
Add asserts to ensure that's how they're called.

platform/graphics/gpu/SharedGraphicsContext3D.h:

(SharedGraphicsContext3D):
Reuse the SharedGraphicsContext infrastructure to create a new
context singleton for filter use in the threaded compositor.

6:21 PM Changeset in webkit [112186] by rniwa@webkit.org

1 edit in trunk/Source/WTF/ChangeLog

Set eol-style: native on WTF.sln per Ryan Sleevi's request.

WTF.vcproj/WTF.sln: Added property svn:eol-style.

6:12 PM Changeset in webkit [112185] by rniwa@webkit.org

2 edits in trunk/Source/WTF

Chromium build fix; add BitVector.h/cpp to gypi.

WTF.gypi:

6:09 PM Changeset in webkit [112184] by abarth@webkit.org

22 edits
4 adds in trunk

FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
https://bugs.webkit.org/show_bug.cgi?id=81020

Reviewed by Eric Seidel.

Source/WebCore:

The vast majority of security checks in the browser should use a
ScriptExecutionContext (aka a Document) to designate "who" is
attempting to perform a given action. Unfortunately,
shouldAllowNavigation was using a Frame to designate "who" is
attempting the navigation.

In cases when the executing script is "inactive" (i.e., belongs to a
document that is not currently displayed in a Frame), using the Frame
can cause us to grant the script the privileges of the document that's
currently displayed in the Frame rather than the one that contains the
script.

This patch moves shouldAllowNavigation from FrameLoader to Document
(and renames it to canNavigate), effectively change the context object
from a Frame to a Document.

Test: http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html

bindings/generic/BindingSecurity.h:

(BindingSecurity):
(WebCore):

bindings/v8/V8Utilities.cpp:

(WebCore):

bindings/v8/V8Utilities.h:

(WebCore):

Deletes unused code.

dom/Document.cpp:

(WebCore::canAccessAncestor):
(WebCore):
(WebCore::Document::canNavigate):

canNavigate is copied from FrameLoader::shouldAllowNavigation. I've added a null-check bailout if the document is inactive.

dom/Document.h:

(Document):

loader/FormState.cpp:

(WebCore::FormState::FormState):
(WebCore::FormState::create):

loader/FormState.h:

(WebCore):
(FormState):
(WebCore::FormState::sourceDocument):

loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

Changes the context object from Frame to Document.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore):
(WebCore::FrameLoader::findFrameForNavigation):

FrameLoader::findFrameForNavigation still incorrectly uses Frame as the context object, but that's a bug for another patch.

(WebCore::createWindow):

loader/FrameLoader.h:

(FrameLoader):

loader/NavigationScheduler.cpp:

(WebCore::ScheduledFormSubmission::fire):

page/DOMWindow.cpp:

(WebCore::DOMWindow::close):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::open):

page/History.cpp:

(WebCore::History::go):

Source/WebKit/mac:

Update call site to new function name.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchWillSubmitForm):

Source/WebKit/win:

Update call site to new function name.

WebFrame.cpp:

(WebFrame::dispatchWillSubmitForm):

Source/WebKit2:

Update call site to new function name.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

LayoutTests:

Test that a script from an inactive document doesn't inherit the
navigation privileges of the document that currently occupies the
frame.

http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt: Added.
http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Added.
http/tests/security/frameNavigation/resources/fail.html: Added.
http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html:
http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html: Added.

6:02 PM Changeset in webkit [112183] by rniwa@webkit.org

1 edit in trunk/ChangeLog

Trigger a build on Chromium Linux boxes to see if clean builds succeed or not.

5:16 PM Changeset in webkit [112182] by vangelis@chromium.org

5 edits in trunk/Source

[chromium] Simplify and fix CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=82114

Source/WebCore:

A significant cleanup, simplification and improvement of the CCLayerSorter code.
Simplified the LayerShape structure to use WebCore's FloatQuad for all overlap tests.
By treating every layer as two triangles, the old overlap code did a lot of redundant work
including testing two of the vertices of the layer and its diagonal twice. The new overlap
tests check:

The four corners of each of the two layers against the other layer.
The four edges of each layer against the edges of the other layer.

Unlike the old code, the new code has no early-outs in the overlap tests as those where causing
us to miss legitimate overlaps.
A new technique for breaking dependency cycles introduced by intersecting layers is implemented.
Instead of arbitrarily breaking cycles by choosing the node in the graph with the smallest number of
incoming edges (i.e. layers that need to be drawn before it) we chose the one with the smallest sum
of graph edge weights (defined as the max depth difference between two layers). Layers that intersect
have their respective graph edge weight set to zero, making them more likely to be picked for breaking
the cycles (it's not a perfect solution but it seems to perform much better than the previous one).

In addition to being overly complex and doing reduntant work, the old code was missing a
perspective divide when computing the coordinates of the layer's corners in the projected plane
which was the source of a lot of mis-sorted results.

In all, these improvements, fix a lot of outstanding issues with layer sorting, on pages such as:
http://www.keithclark.co.uk/labs/3dcss/demo/
http://2012.beercamp.com
https://developer.mozilla.org/fr/demos/detail/the-box/launch

Tests: CCLayerSorter unit tests.

Reviewed by Kenneth Russell.

platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore):
(WebCore::perpProduct):
(WebCore::edgeEdgeTest):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::LayerShape::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::createGraphNodes):
(WebCore::CCLayerSorter::createGraphEdges):
(WebCore::CCLayerSorter::sort):

platform/graphics/chromium/cc/CCLayerSorter.h:

(WebCore::CCLayerSorter::CCLayerSorter):
(CCLayerSorter):
(LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):
(GraphNode):
(WebCore::CCLayerSorter::GraphEdge::GraphEdge):
(GraphEdge):

Source/WebKit/chromium:

Adjustments to the CCLayerSorter unit tests to account for API changes in the
CCLayerSorter class.

Reviewed by Kenneth Russell.

tests/CCLayerSorterTest.cpp:

(WebCore):
(WebCore::TEST):

5:12 PM Changeset in webkit [112181] by mhahnenberg@apple.com

2 edits in trunk/Tools

NRWT should retry failures serially
https://bugs.webkit.org/show_bug.cgi?id=82241

Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests): Add another parameter to specify the number of workers to use.
(Manager.run): Run the failures serially.

5:12 PM Changeset in webkit [112180] by rniwa@webkit.org

2 edits in trunk/Source/WTF

Touch BitVector as a speculative fix for Chromium Linux.

wtf/BitVector.h:

(BitVector):

5:10 PM Changeset in webkit [112179] by ojan@chromium.org

37 edits
1 copy
7 moves
50 adds
15 deletes in trunk/LayoutTests

More Chromium rebaselines for assorted failing tests. Almost all of the differences
are text rendering or antialiasing. Some of them are imperceptibly different shades
of a color for tests that aren't testing that (e.g the test tests clipping).

5:09 PM Changeset in webkit [112178] by fsamuel@chromium.org

7 edits in trunk/Source/WebCore

[Chromium] Using WebViewPlugins with --force-compositing-mode causes an ASSERT to fail
https://bugs.webkit.org/show_bug.cgi?id=81954

Reviewed by James Robinson.

A static variable s_inPaintContents is set when painting, and it ensures
that we don't delete GraphicsLayers or create GraphicsLayers while painting.

However, because this variable is static, it does not permit the existence
of multiple WebViews in different stages (one laying out and one painting).

This manifests itself if one attempts to use the --force-compositing-mode
in Chromium and attempts to navigate to a page with a missing or old plugin
or a browser plugin (which uses a WebViewPlugin as a placeholder until it's
done loading).

The solution to simplify debugging is to make this flag per-Page.
We can access Page from RenderLayerBacking which is a GraphicsLayerClient.
We add a new method GraphicsLayerClient::verifyNotPainting with a default
(do nothing) implementation and override it in RenderLayerBacking to
test the flag set in Page.

page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(Page):
(WebCore::Page::setIsPainting):
(WebCore::Page::isPainting):

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

platform/graphics/GraphicsLayerClient.h:

(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::verifyNotPainting):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):
(WebCore):
(WebCore::RenderLayerBacking::verifyNotPainting):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

4:59 PM Changeset in webkit [112177] by rniwa@webkit.org

17 edits
2 adds in trunk

cssText should use shorthand notations
https://bugs.webkit.org/show_bug.cgi?id=81737

Reviewed by Enrica Casucci.

Source/JavaScriptCore:

Export symbols of BitVector on Windows.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WebCore:

Use shorthand properties to serialize style properties for cssText.

The overall algorithm is to look for any property that has a shorthand, and then check if
the shorthand value could be obtained (the condition is quite complicated for border properties).
If it could, then append that value to the string builder, and set the corresponding entries in
shorthandPropertyAppeared and shorthandPropertyUsed. If not, only turn on the bit in
shorthandPropertyAppeared on to avoid calling getPropertyValue again for longhand properties
that use the same shorthand property when we cannot use the shorthand.

Test: fast/css/cssText-shorthand.html

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):

Source/WTF:

wtf/BitVector.h:

(BitVector):
(WTF::BitVector::ensureSizeAndSet): Added.

LayoutTests:

Rebaseline existing tests and add a regression test for unprefixed CSS properties with
the exception of -webkit-border-horizontal/vertical-spacing (the shorthand version of
these properties (border-spacing) is unprefixed.

editing/pasteboard/paste-and-sanitize-expected.txt: Uses border instead of longhand

properties as desired.

editing/pasteboard/paste-and-sanitize.html:
editing/style/non-inheritable-styles-expected.txt: Ditto.
fast/css/background-position-serialize-expected.txt: No longer emits "background-*:

initial" as desired.

fast/css/cssText-shorthand-expected.txt: Added.
fast/css/cssText-shorthand.html: Added.
fast/css/remove-shorthand-expected.txt:
fast/css/remove-shorthand.html: Modified to do elaborative comparison of the lists of

properties before and after removing a shorthand since now removing a shorthand property
may end up adding new longhand property.

fast/css/uri-token-parsing-expected.txt:
fast/css/uri-token-parsing.html: Uses shorthand properties instead of longhand equivalents.
inspector/styles/styles-update-from-js-expected.txt: Ditto.
printing/page-rule-css-text-expected.txt: Ditto.

4:53 PM Changeset in webkit [112176] by enne@google.com

3 edits in trunk/Tools

Allow expectations on directories in virtual test suites
https://bugs.webkit.org/show_bug.cgi?id=82250

Reviewed by Dirk Pranke.

lookup_virtual_test_base was only returning valid results for files
and not directories. Fix by falling back to the virtual test suite
mapping if possible.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.lookup_virtual_test_base):

Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.skipped_tests):
(TestPort.virtual_test_suites):

4:42 PM Changeset in webkit [112175] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Never remove root compositing layers in the web process
https://bugs.webkit.org/show_bug.cgi?id=82255
<rdar://problem/11058521>

Reviewed by Sam Weinig.

Since we never leave accelerated compositing mode when using tiled drawing, we should
never remove root compositing layers in the web process.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

4:39 PM Changeset in webkit [112174] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Chromium] Add Android keycodes
https://bugs.webkit.org/show_bug.cgi?id=81950

Add the missing Android keycodes listed in the bug.

Patch by Bolin Hsu <bhsu@google.com> on 2012-03-26
Reviewed by Adam Barth.

platform/chromium/KeyCodeConversionAndroid.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

platform/chromium/KeyboardCodes.h:

4:39 PM Changeset in webkit [112173] by dpranke@chromium.org

1 edit in trunk/Tools/ChangeLog

Fix duplicated ChangeLog entry from r112171.

Unreviewed, build fix.

4:37 PM Changeset in webkit [112172] by leviw@chromium.org

2 edits in trunk/Source/WebCore

Switch ColumnInfo::addForcedBreak to LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=82210

Reviewed by Eric Seidel.

Forced breaks are added by local offsets, which should be in LayoutUnits.

No new tests. No change in behavior.

rendering/ColumnInfo.h:

(WebCore::ColumnInfo::addForcedBreak):

4:36 PM Changeset in webkit [112171] by dpranke@chromium.org

12 edits in trunk/Tools

test-webkitpy: split test-finding code into a different module
https://bugs.webkit.org/show_bug.cgi?id=82253

Reviewed by Adam Barth.

Per suggestion from abarth, this change splits all the
filesystem-crawling, test-finding code in test-webkitpy out into
a separate module and switches to using a FileSystem object.
This makes things much more testable, so we also add tests :).

We also add a realpath() method to the Filesystem object, since
test-webkitpy needs that in order to be able to resolve symlinks
properly to determine whether a file is under a particular tree
or not.

Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.realpath):

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.realpath):

Scripts/webkitpy/test/main.py:

(Tester.init):
(Tester.add_tree):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):

Scripts/webkitpy/test/test_finder.py: Added.

(TestDirectoryTree):
(TestDirectoryTree.init):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.find_modules.file_filter):
(TestDirectoryTree.to_module):
(TestDirectoryTree.clean):
(TestFinder):
(TestFinder.init):
(TestFinder.add_tree):
(TestFinder.additional_paths):
(TestFinder.clean_trees):
(TestFinder.is_module):
(TestFinder.to_module):
(TestFinder.find_names):
(TestFinder._exclude):

Scripts/webkitpy/test/test_finder_unittest.py: Added.

(TestFinderTest):
(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.test_additional_system_paths):
(TestFinderTest.test_is_module):
(TestFinderTest.test_to_module):
(TestFinderTest.test_clean):
(TestFinderTest.test_find_names):

4:35 PM Changeset in webkit [112170] by leviw@chromium.org

5 edits in trunk/Source/WebCore

Update LayoutUnit usage in ContainerNode, Element, and ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=82219

Reviewed by Eric Seidel.

No new tests. No change in behavior.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner): linesBoundingBox returns the enclosing IntRect
of the contained lines. Inline's aren't bounded in LayoutUnits nor pixel snapped.

dom/Element.cpp:

(WebCore::Element::boundsInRootViewSpace): Coordinates in root view space are akin to absolute
coordinates, which are always expressed in integers.

dom/Element.h:

(Element):

dom/ElementRareData.h:

(WebCore::defaultMinimumSizeForResizing): Using numeric_limits<LayoutUnit>::max instead of
INT_MAX to avoid overflowing when LayoutUnits are sub-pixel.

4:33 PM Changeset in webkit [112169] by eae@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test_expectations update for chromium.

platform/chromium/test_expectations.txt:

4:31 PM Changeset in webkit [112168] by dpranke@chromium.org

4 edits
2 adds in trunk/Tools

test-webkitpy: split test-finding code into a different module
https://bugs.webkit.org/show_bug.cgi?id=82253

Reviewed by Adam Barth.

Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.realpath):

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.realpath):

Scripts/webkitpy/test/main.py:

(Tester.init):
(Tester.add_tree):
(Tester.run):
(Tester._run_tests):
(Tester._log_exception):

Scripts/webkitpy/test/test_finder.py: Added.

Scripts/webkitpy/test/test_finder_unittest.py: Added.

4:05 PM Changeset in webkit [112167] by adamk@chromium.org

5 edits in trunk/Source/WebCore

Update binding test output for V8 after r112163.

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

4:01 PM Changeset in webkit [112166] by leviw@chromium.org

9 edits in trunk/Source/WebCore

Update localSelectionRect to return a LayoutRect
https://bugs.webkit.org/show_bug.cgi?id=82183

Reviewed by Eric Seidel.

localSelectionRect returns a rectangle in the coordinate space of its renderer,
and therefor should remain LayoutUnits until being promoted to absolute
coordinates or painted. Also fixing an incorrect conversion of startPos and
endPos in selectionRectForRepaint.

No new tests. No change in behavior.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect): Continuing to use enclosingIntRect
for the value being returned from the font engine since these floating point
values should not be pixel snapped.

rendering/InlineTextBox.h:

(InlineTextBox):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::localSelectionRect):

rendering/RenderReplaced.h:

(RenderReplaced):

rendering/RenderText.cpp:

(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint): Fixing an incorrect conversion of
start/endPos to LayoutUnits. These values represent a range of selected characters,
not layout values!

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

3:59 PM Changeset in webkit [112165] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Crash in Canvas2DLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=82243

Patch by Justin Novosad <junov@chromium.org> on 2012-03-26
Reviewed by James Robinson.

Adding null pointer check to prevent crash and texture object
validity check to prevent potential graphics glitch

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::pushPropertiesTo):

3:58 PM Changeset in webkit [112164] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG should assert that argument value recoveries can only be
AlreadyInRegisterFile or Constant
https://bugs.webkit.org/show_bug.cgi?id=82249

Reviewed by Michael Saboff.

Made the assertions that the DFG makes for argument value recoveries match
what Arguments expects.

bytecode/ValueRecovery.h:

(JSC::ValueRecovery::isConstant):
(ValueRecovery):
(JSC::ValueRecovery::isAlreadyInRegisterFile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:57 PM Changeset in webkit [112163] by adamk@chromium.org

11 edits in trunk/Source/WebCore

Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.

bindings/v8/V8Proxy.h:

(WebCore::toV8): Remove explicit ref.

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.

bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): ditto.

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

3:51 PM Changeset in webkit [112162] by ap@apple.com

5 edits in trunk/Source/WebCore

Remove obsolete FormDataStreamMac code
https://bugs.webkit.org/show_bug.cgi?id=82244

Reviewed by Brady Eidson.

platform/network/ResourceHandle.h: Removed ResourceHandle::didSendBodyDataDelegateExists().

platform/network/mac/FormDataStreamMac.h:
platform/network/mac/FormDataStreamMac.mm: Removed code that was needed to call ResourceLoaderClient::didSendData() before Foundation added support for it.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): We no longer need to associate streams with ResourceHandles!

3:49 PM Changeset in webkit [112161] by adamk@chromium.org

4 edits
3 adds in trunk

V8RecursionScope should not hold a raw pointer to ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=82222

Reviewed by Eric Seidel.

Source/WebCore:

Instead of holding onto ScriptExecutionContext, cache the boolean value we
care about (context->isDocument()). This avoids problems if the
context goes away as a result of the script we just ran.

Test: fast/frames/subframe-load-js-url-crash.html

bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext): Check the cached
bool instead of calling into the context.

bindings/v8/V8RecursionScope.h:

(WebCore::V8RecursionScope::V8RecursionScope): Call isDocument from
the constructor and cache the result.
(WebCore::V8RecursionScope::~V8RecursionScope): No longer need to pass
anything to didLeaveScriptContext since it's now a member.
(V8RecursionScope): Make didLeaveScriptContext a member function and
remove its argument. Add member bool to hold the value of isDocument.

LayoutTests:

fast/frames/resources/subframe-load-js-url-crash-iframe.html: Added.
fast/frames/subframe-load-js-url-crash-expected.txt: Added.
fast/frames/subframe-load-js-url-crash.html: Added.

3:47 PM Changeset in webkit [112160] by kubo@profusion.mobi

43 edits
4 copies
55 adds in trunk/LayoutTests

[EFL] Unreviewed gardening i fast/frames, fast/html and
fast/lists.

platform/efl/Skipped:
platform/efl/fast/frames/001-expected.png:
platform/efl/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.png:
platform/efl/fast/frames/frame-navigation-expected.png:
platform/efl/fast/frames/frame-scrolling-attribute-expected.png:
platform/efl/fast/frames/frameset-style-recalc-expected.png:
platform/efl/fast/frames/iframe-scrolling-attribute-expected.png:
platform/efl/fast/frames/iframe-with-frameborder-expected.png:
platform/efl/fast/frames/onlyCommentInIFrame-expected.png:
platform/efl/fast/frames/viewsource-attribute-expected.png:
platform/efl/fast/frames/viewsource-on-image-file-expected.png:
platform/efl/fast/html/details-add-child-1-expected.png: Added.
platform/efl/fast/html/details-add-child-2-expected.png: Added.
platform/efl/fast/html/details-add-details-child-1-expected.png: Added.
platform/efl/fast/html/details-add-details-child-2-expected.png: Added.
platform/efl/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
platform/efl/fast/html/details-add-summary-1-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
platform/efl/fast/html/details-add-summary-10-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-10-expected.png: Added.
platform/efl/fast/html/details-add-summary-2-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-2-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
platform/efl/fast/html/details-add-summary-3-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-3-expected.png: Added.
platform/efl/fast/html/details-add-summary-4-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-4-expected.png: Added.
platform/efl/fast/html/details-add-summary-5-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-5-expected.png: Copied from LayoutTests/platform/efl/fast/lists/li-br-expected.png.
platform/efl/fast/html/details-add-summary-6-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-6-expected.png: Added.
platform/efl/fast/html/details-add-summary-7-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-7-expected.png: Added.
platform/efl/fast/html/details-add-summary-8-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-8-expected.png: Added.
platform/efl/fast/html/details-add-summary-9-and-click-expected.png: Added.
platform/efl/fast/html/details-add-summary-9-expected.png: Added.
platform/efl/fast/html/details-add-summary-child-1-expected.png: Added.
platform/efl/fast/html/details-add-summary-child-2-expected.png: Added.
platform/efl/fast/html/details-nested-1-expected.png: Added.
platform/efl/fast/html/details-nested-2-expected.png: Added.
platform/efl/fast/html/details-no-summary1-expected.png: Added.
platform/efl/fast/html/details-no-summary2-expected.png: Added.
platform/efl/fast/html/details-no-summary3-expected.png: Added.
platform/efl/fast/html/details-no-summary4-expected.png: Added.
platform/efl/fast/html/details-open-javascript-expected.png: Added.
platform/efl/fast/html/details-open1-expected.png: Added.
platform/efl/fast/html/details-open2-expected.png: Added.
platform/efl/fast/html/details-open3-expected.png: Added.
platform/efl/fast/html/details-open4-expected.png: Added.
platform/efl/fast/html/details-open5-expected.png: Added.
platform/efl/fast/html/details-open6-expected.png: Added.
platform/efl/fast/html/details-position-expected.png: Added.
platform/efl/fast/html/details-remove-child-1-expected.png: Added.
platform/efl/fast/html/details-remove-child-2-expected.png: Added.
platform/efl/fast/html/details-remove-summary-1-and-click-expected.png: Added.
platform/efl/fast/html/details-remove-summary-1-expected.png: Added.
platform/efl/fast/html/details-remove-summary-2-and-click-expected.png: Added.
platform/efl/fast/html/details-remove-summary-2-expected.png: Added.
platform/efl/fast/html/details-remove-summary-3-and-click-expected.png: Added.
platform/efl/fast/html/details-remove-summary-3-expected.png: Added.
platform/efl/fast/html/details-remove-summary-4-and-click-expected.png: Added.
platform/efl/fast/html/details-remove-summary-4-expected.png: Added.
platform/efl/fast/html/details-remove-summary-5-and-click-expected.png: Added.
platform/efl/fast/html/details-remove-summary-5-expected.png: Added.
platform/efl/fast/html/details-remove-summary-6-and-click-expected.png: Added.
platform/efl/fast/html/details-remove-summary-6-expected.png: Added.
platform/efl/fast/html/details-remove-summary-child-1-expected.png: Added.
platform/efl/fast/html/details-remove-summary-child-2-expected.png: Added.
platform/efl/fast/html/details-replace-summary-child-expected.png: Added.
platform/efl/fast/html/details-replace-text-expected.png: Added.
platform/efl/fast/html/details-writing-mode-expected.png: Added.
platform/efl/fast/html/link-rel-stylesheet-expected.png:
platform/efl/fast/html/listing-expected.png:
platform/efl/fast/html/marquee-scroll-expected.png:
platform/efl/fast/html/marquee-scrollamount-expected.png:
platform/efl/fast/lists/001-expected.png:
platform/efl/fast/lists/001-vertical-expected.png:
platform/efl/fast/lists/002-expected.png:
platform/efl/fast/lists/002-vertical-expected.png:
platform/efl/fast/lists/003-expected.png:
platform/efl/fast/lists/003-vertical-expected.png:
platform/efl/fast/lists/005-expected.png:
platform/efl/fast/lists/005-vertical-expected.png:
platform/efl/fast/lists/007-expected.png:
platform/efl/fast/lists/007-vertical-expected.png:
platform/efl/fast/lists/008-expected.png:
platform/efl/fast/lists/008-vertical-expected.png:
platform/efl/fast/lists/anonymous-items-expected.png:
platform/efl/fast/lists/big-list-marker-expected.png:
platform/efl/fast/lists/dynamic-marker-crash-expected.png:
platform/efl/fast/lists/li-br-expected.png:
platform/efl/fast/lists/li-style-alpha-huge-value-crash-expected.png:
platform/efl/fast/lists/marker-before-empty-inline-expected.png:
platform/efl/fast/lists/marker-image-error-expected.png:
platform/efl/fast/lists/markers-in-selection-expected.png:
platform/efl/fast/lists/ol-display-types-expected.png:
platform/efl/fast/lists/ol-start-parsing-expected.png:
platform/efl/fast/lists/olstart-expected.png:
platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.png:
platform/efl/fast/lists/scrolled-marker-paint-expected.png:

3:43 PM Changeset in webkit [112159] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] assertion being hit in CCLayerTreeHost::updateCompositorResources
https://bugs.webkit.org/show_bug.cgi?id=82239

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-26
Reviewed by Adrienne Walker.

The assert is incorrect and should check the animation state on
the surface, not the owning layer.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateCompositorResources):

3:41 PM Changeset in webkit [112158] by leviw@chromium.org

3 edits in trunk/Source/WebCore

Correct LayoutUnit usage in RenderFieldSet and RenderMenuItem
https://bugs.webkit.org/show_bug.cgi?id=82179

Reviewed by Julien Chaffraix.

Correcting small misuses of ints vs LayoutUnits in RenderFieldSet and RenderMenuItem. Also
adding zeroLayoutUnit where necessary to fix the sub-pixel build. See below for details.

No new tests. No change in behavior.

rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Clip rects need to be pixel snapped to mirror
the actual coordinates we paint.
(WebCore::RenderFieldset::paintMask): Using zeroLayoutUnit for ternary operation to fix the
sub-pixel build.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup): Correctly using an IntRect for absoluteBoundingBoxRect.
(WebCore::RenderMenuList::clientPaddingLeft): Correcting mismatched return type with header.
(WebCore::RenderMenuList::clientPaddingRight): Ditto.

3:39 PM Changeset in webkit [112157] by ojan@chromium.org

63 edits
2 copies
10 moves
63 adds
11 deletes in trunk/LayoutTests

Chromium rebaselines for test failing due to text rendering or antialiasing differences.
Changes to non-chromium results were from "webkit-patch optimize-baselines".

3:39 PM Changeset in webkit [112156] by mitz@apple.com

3 edits in trunk/Source/WebCore

Tried to fix an unused parameter warning after r112154.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Changed to not pass relayoutChildren to
layoutFlexItems.
(WebCore::RenderFlexibleBox::layoutFlexItems): Removed the unused relayoutChildren parameter.

rendering/RenderFlexibleBox.h:

3:32 PM Changeset in webkit [112155] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

SyntheticStyleCalc on an element should not force recalculation on its children
https://bugs.webkit.org/show_bug.cgi?id=79389

Patch by Rob Arnold <robarnold@fb.com> on 2012-03-26
Reviewed by Simon Fraser.

No new tests. Existing tests cover correctness, not sure how to test for performance.

dom/Element.cpp:

(WebCore::Element::recalcStyle):

3:26 PM Changeset in webkit [112154] by tony@chromium.org

6 edits in trunk

apply cross axis constraints before aligning children in flexbox
https://bugs.webkit.org/show_bug.cgi?id=82240

Reviewed by Ojan Vafai.

Source/WebCore:

We weren't applying max-height constraints before aligning children.
This would cause center, end, stretch alignment to be wrong if we hit
a max-height on a flexbox.

This patch also moves the repositioning logic to happen after
computeLogicalHeight, which will be useful for flex-line-pack.

New test case in css3/flexbox/flex-align.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

rendering/RenderFlexibleBox.h:

LayoutTests:

css3/flexbox/flex-align-expected.txt:
css3/flexbox/flex-align.html:

3:14 PM Changeset in webkit [112153] by kubo@profusion.mobi

2 edits in trunk/Tools

[jhbuild] Use $MAKE if it is defined to build jhbuild itself.
https://bugs.webkit.org/show_bug.cgi?id=82209

Reviewed by Martin Robinson.

Respecting the $MAKE environment variable when it is defined makes
building jhbuild more portable, as some platforms may have GNU
make as gmake, for example.

jhbuild/jhbuild-wrapper:

(install_jhbuild):

3:04 PM Changeset in webkit [112152] by mitz@apple.com

2 edits in trunk/Source/JavaScriptCore

Tried to fix the Windows build.

yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::putRange):

2:59 PM Changeset in webkit [112151] by ojan@chromium.org

2 edits in trunk/LayoutTests

The css3/selectors3/xml tests are flaky on Leopard as well.

platform/chromium/test_expectations.txt:

2:58 PM Changeset in webkit [112150] by dpranke@chromium.org

3 edits in trunk/Tools

add a Tree abstraction to test-webkitpy to better encapsulate things
https://bugs.webkit.org/show_bug.cgi?id=82158

Reviewed by Adam Barth.

There are no functional changes in this patch, but adding a
basic abstraction for the trees we are looking in for python
tests will allow me to add some features later on more easily
(like ignoring certain directories like webkitpy/thirdparty),
and it makes things slightly less hard-coded.

Scripts/test-webkitpy:
Scripts/webkitpy/test/main.py:

(Tester.init):
(Tester):
(Tester.add_tree):
(Tester._parse_args):
(Tester._configure):
(Tester.run):
(Tester._find_modules):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):
(TestDirectoryTree):
(TestDirectoryTree.init):
(TestDirectoryTree.find_modules):
(TestDirectoryTree.clean):

2:56 PM Changeset in webkit [112149] by ojan@chromium.org

5 edits in trunk/Tools

garden-o-matic should special case reftests
https://bugs.webkit.org/show_bug.cgi?id=81812

Reviewed by Adam Barth.

On the examine page, don't show a rebaseline button for reftests.
We still show it on the failure summary page because tests are grouped
together. Long-term, we should make sure webkit-patch rebaseline-test
never tries to rebaseline reftests.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

2:43 PM Changeset in webkit [112148] by andersca@apple.com

2 edits in trunk/Source/WebCore

Find in page overlay and bouncy are not always positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=82247
<rdar://problem/10866139>

Reviewed by Sam Weinig.

In WebCore, a lot of code depends on scroll position updates to happen synchronously, so
update the frame view scroll position before asking the scrolling thread to scroll.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

2:40 PM Changeset in webkit [112147] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed - speculative Windows build fix.

yarr/YarrCanonicalizeUCS2.h:

(JSC::Yarr::getCanonicalPair):

2:30 PM Changeset in webkit [112146] by mitz@apple.com

2 edits in trunk/Source/JavaScriptCore

Fixed builds with assertions disabled.

yarr/YarrCanonicalizeUCS2.h:

(JSC::Yarr::areCanonicallyEquivalent):

2:06 PM Changeset in webkit [112145] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed - errk! - accidentally the whole pbxproj.

JavaScriptCore.xcodeproj/project.pbxproj:

1:34 PM Changeset in webkit [112144] by Nate Chapin

4 edits in trunk/Source/WebCore

Simplify setting loading state in DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=82099

Reviewed by Adam Barth.

The logic for deciding what to return for DocumentLoader::isLoading()
is crazy. It's indirectly based on the ResourceLoaders that have
registered themselves with the DocumentLoader, but we can make that
relationship more direct.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete): Renamed from updateLoading, since it's not actually

updating anything anymore. It now calls DOMWindow::finishedLoading() if loading is in fact done.

(WebCore::DocumentLoader::startLoadingMainResource): The only reason this had a return value was to call

updateLoading() if loading failed. Just call checkLoadComplete() directly (this allows it to
be private, whereas updateLoading() was public).

(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):

loader/DocumentLoader.h:

(WebCore::DocumentLoader::isLoading): Rather than holding a separate bool, return based on the presence

of non-multipart ResourceLoaders directly.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::isLoading): Depend on DocumentLoader::isLoading() for the activeDocumentLoader(),

rather than indirectly the other way around.

(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Remove several assertions that should now be

absolutely identical to the remaining !pdl->isLoading().

(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):

1:13 PM Changeset in webkit [112143] by barraclough@apple.com

11 edits
6 adds in trunk

Greek sigma is handled wrong in case independent regexp.
https://bugs.webkit.org/show_bug.cgi?id=82063

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The bug here is that we assume that any given codepoint has at most one additional value it
should match under a case insensitive match, and that the pair of codepoints that match (if
a codepoint does not only match itself) can be determined by calling toUpper/toLower on the
given codepoint). Life is not that simple.

Instead, pre-calculate a set of tables mapping from a UCS2 codepoint to the set of characters
it may match, under the ES5.1 case-insensitive matching rules. Since unicode is fairly regular
we can pack this table quite nicely, and get it down to 364 entries. This means we can use a
simple binary search to find an entry in typically eight compares.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
yarr/yarr.pri:
- Added new files to build systems.
yarr/YarrCanonicalizeUCS2.cpp: Added.
- New - autogenerated, UCS2 canonicalized comparison tables.
yarr/YarrCanonicalizeUCS2.h: Added.

(JSC::Yarr::rangeInfoFor):

Look up the canonicalization info for a UCS2 character.

(JSC::Yarr::getCanonicalPair):

For a UCS2 character with a single equivalent value, look it up.

(JSC::Yarr::isCanonicallyUnique):

Returns true if no other UCS2 code points are canonically equal.

(JSC::Yarr::areCanonicallyEquivalent):

Compare two values, under canonicalization rules.

yarr/YarrCanonicalizeUCS2.js: Added.
- script used to generate YarrCanonicalizeUCS2.cpp.
yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::tryConsumeBackReference):

Use isCanonicallyUnique, rather than Unicode toUpper/toLower.

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):

Use isCanonicallyUnique, rather than Unicode toUpper/toLower.

yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::putChar):

Updated to determine canonical equivalents correctly.

(JSC::Yarr::CharacterClassConstructor::putUnicodeIgnoreCase):

Added, used to put a non-ascii, non-unique character in a case-insensitive match.

(JSC::Yarr::CharacterClassConstructor::putRange):

Updated to determine canonical equivalents correctly.

(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):

Changed to call putUnicodeIgnoreCase, instead of putChar, avoid a double lookup of rangeInfo.

LayoutTests:

fast/regex/script-tests/unicodeCaseInsensitive.js: Added.

(shouldBeTrue.ucs2CodePoint):

fast/regex/unicodeCaseInsensitive-expected.txt: Added.
fast/regex/unicodeCaseInsensitive.html: Added.
- Added test cases for case-insensitive matches of non-ascii characters.

12:43 PM Changeset in webkit [112142] by jamesr@google.com

6 edits in trunk/Source

Scrollable plugins not registered properly in ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=82163

Reviewed by Anders Carlsson.

Source/WebCore:

Plugins may be scrollable, so we have to add them in the non-fast scrollable region. Tested manually.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::nonFastScrollableRegion):
(WebCore):

page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

plugins/PluginViewBase.h:

(WebCore::PluginViewBase::scrollable):
(PluginViewBase):

Source/WebKit/chromium:

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollable):

src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

12:41 PM Changeset in webkit [112141] by joone.hur@collabora.co.uk

5 edits
4 adds in trunk/Source

[GTK] Build fix for Accelerated Compositing with Clutter
https://bugs.webkit.org/show_bug.cgi?id=81785

Reviewed by Martin Robinson.

Source/WebCore:

AcceleratedCompositingContext was introduced to isolate different accelerated
compositing implementations(r104194), but the Clutter implementation doesn't
build with it. This includes an initial implementation of GraphicsContext3D
and fixes the build error.

GNUmakefile.list.am:
platform/graphics/clutter/DrawingBufferClutter.cpp: Added.

(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

platform/graphics/clutter/GraphicsContext3DClutter.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::getImageData):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::platformLayer):

platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::platformContext):
(WebCore::GraphicsContext3DPrivate::paintToGraphicsLayerActor):

platform/graphics/clutter/GraphicsContext3DPrivate.h: Added.

(WebCore):
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):

Source/WebKit/gtk:

AcceleratedCompositingContext was introduced to isolate different accelerated
compositing implementations(r104194), but the Clutter implementation doesn't
build with it. This fixes the build error.

WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

WebCoreSupport/AcceleratedCompositingContextClutter.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::resizeRootLayer):
(WebKit::AcceleratedCompositingContext::syncLayersNow):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
(WebKit):

12:41 PM Changeset in webkit [112140] by dpranke@chromium.org

12 edits in trunk/Tools

clean up NRWT logging/metering, be less verbose
https://bugs.webkit.org/show_bug.cgi?id=73846

Reviewed by Ojan Vafai.

Re-land r112014 with a build fix for Python 2.6 compatibility.

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_http_locking):

Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(AbstractWorker.run):

Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker._set_up_logging):
(Worker):
(Worker._set_up_host_and_port):
(Worker.run):
(Worker.cleanup):

Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:

(WorkerTest.test_default_platform_in_worker):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.implements):
(MeteredStream._erasure):
(MeteredStream._ensure_newline):
(MeteredStream.init):
(MeteredStream.del):
(MeteredStream.cleanup):
(MeteredStream.write_throttled_update):
(MeteredStream.write_update):
(MeteredStream.write):
(MeteredStream.writeln):
(MeteredStream._erase_last_partial_line):
(_LogHandler):
(_LogHandler.init):
(_LogHandler.emit):

Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(RegularTest):
(RegularTest.setUp):
(RegularTest.tearDown):
(RegularTest.time_fn):
(RegularTest.test_logging_not_included):
(RegularTest._basic):
(RegularTest.test_basic):
(RegularTest._log_after_update):
(RegularTest.test_log_after_update):
(TtyTest):
(TtyTest.test_basic):
(TtyTest.test_log_after_update):
(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):

Scripts/webkitpy/layout_tests/views/printing.py:

(parse_print_options):
(Printer.init):
(Printer.cleanup):
(Printer.print_progress):
(Printer.print_update):
(Printer._write):

Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.get_printer):
(Testprinter.test_print_progress):

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_pause_before_testing):

12:31 PM Changeset in webkit [112139] by kubo@profusion.mobi

2 edits in trunk/Tools

[jhbuild] Revert $MAKE environment hack introduced in r101929.
https://bugs.webkit.org/show_bug.cgi?id=82234

Reviewed by Martin Robinson.

The problem it was supposedly fixing was fixed in jhbuild itself
in git revision da8944d8ca987ca48c91b350257a530050406092, so we
can remove the workaround added to the script.

jhbuild/jhbuild-wrapper:

(install_jhbuild):

12:28 PM Changeset in webkit [112138] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Expose InspectorTypeBuilder.h to other components
https://bugs.webkit.org/show_bug.cgi?id=82226

Patch by Peter Rybin <prybin@chromium.org> on 2012-03-26
Reviewed by Vsevolod Vlasov.

This is a provisional commit that simplifies passing ealy warning system
for the main patch https://bugs.webkit.org/show_bug.cgi?id=81558

WebCore.xcodeproj/project.pbxproj: config file is changed in Xcode UI.

12:19 PM Changeset in webkit [112137] by eae@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test_expectations update for chromium.

platform/chromium/test_expectations.txt:

11:56 AM Changeset in webkit [112136] by eae@chromium.org

1 edit
2 adds
1 delete in trunk/LayoutTests

Unreviewed rebaseline for fast/forms/textfield-overflow.

platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Removed.
platform/chromium-mac/fast/forms/textfield-overflow-expected.png: Added.
platform/chromium-mac/fast/forms/textfield-overflow-expected.txt: Added.

11:54 AM Changeset in webkit [112135] by eae@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test_expectations update for chromium.

platform/chromium/test_expectations.txt:

11:51 AM Changeset in webkit [112134] by commit-queue@webkit.org

4 edits
2 adds in trunk

An <area> element remains focusable even though its associated <img> is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=71788

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-03-26
Reviewed by Andy Estes.

Source/WebCore:

HTMLAreaElement::isFocusable() needs to consider the display and
visibility state.

Test: fast/events/tab-test-not-visible-imagemap.html

html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):
(WebCore::HTMLAreaElement::isFocusable):

html/HTMLAreaElement.h: Make imageElement() const.

(HTMLAreaElement):

LayoutTests:

Test sequential focus navigation.

fast/events/tab-test-not-visible-imagemap-expected.txt: Added.
fast/events/tab-test-not-visible-imagemap.html: Added.

11:44 AM Changeset in webkit [112133] by ojan@chromium.org

2 edits in trunk/LayoutTests

Trim the set of flaky css3/selectors3/xml tests on SnowLeopard to
the set that are actually flaky on the bots.

platform/chromium/test_expectations.txt:

11:39 AM Changeset in webkit [112132] by vestbo@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933

This is a build-fix after r112116.

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-03-26
Reviewed by Tor Arne Vestbø.

UIProcess/API/qt/qwebpreferences_p_p.h:

11:26 AM Changeset in webkit [112131] by jchaffraix@webkit.org

3 edits in trunk/LayoutTests

Fix Qt after r112113 and r112112.

Unreviewed.

platform/qt/Skipped:

Skipped a new test that is failing.

platform/qt/fast/forms/textfield-overflow-expected.txt:

Updated the baseline as it matches other ports.

11:12 AM Changeset in webkit [112130] by antonm@chromium.org

2 edits in trunk/Source/WebCore

Fix a typo in IDL
https://bugs.webkit.org/show_bug.cgi?id=82215

Reviewed by Adam Barth.

No new tests, just a typo fix.

notifications/WorkerContextNotifications.idl:

11:11 AM Changeset in webkit [112129] by pfeldman@chromium.org

1 edit
6 adds in trunk/LayoutTests

Not reviewed: chromium baselines for c543-txt-decor-000.

platform/chromium-linux/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
platform/chromium-mac/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
platform/chromium-win/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
platform/chromium-win/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.

10:55 AM Changeset in webkit [112128] by mitz@apple.com

1 edit
1 delete in trunk/LayoutTests

Removed Mac WebKit2-specific expected results for this test, which were added in r90097.

platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Removed.

10:52 AM Changeset in webkit [112127] by wjmaclean@chromium.org

5 edits in trunk/Source

[chromium] Change handleGestureFling() to use CCInputHandlerClient::Wheel.
https://bugs.webkit.org/show_bug.cgi?id=82133

Reviewed by James Robinson.

Source/WebCore:

Covered by existing unit tests.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollBegin):

Source/WebKit/chromium:

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

10:48 AM Changeset in webkit [112126] by mikelawther@chromium.org

3 edits
2 adds in trunk

CSS3 calc: mixed percent/absolute for box-reflect
https://bugs.webkit.org/show_bug.cgi?id=82161

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/calc/box-reflect-expected.html

css3/calc/box-reflect.html

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

css3/calc/box-reflect-expected.html: Added.
css3/calc/box-reflect.html: Added.

10:45 AM Changeset in webkit [112125] by mikelawther@chromium.org

3 edits
2 adds in trunk

CSS3 calc: mixed percent/absolute support for vertical-align
https://bugs.webkit.org/show_bug.cgi?id=82152

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/calc/vertical-align-expected.html

css3/calc/vertical-align.html

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyVerticalAlign::applyValue):

LayoutTests:

css3/calc/vertical-align-expected.html: Added.
css3/calc/vertical-align.html: Added.

10:43 AM Changeset in webkit [112124] by commit-queue@webkit.org

9 edits
1 move in trunk/Source/WebCore

[BlackBerry] Accelerated compositing updates
https://bugs.webkit.org/show_bug.cgi?id=82058

Patch by Filip Spacek <fspacek@rim.com> on 2012-03-26
Reviewed by Rob Buis.

platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setDevice):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):

platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):

platform/graphics/blackberry/InstrumentedPlatformCanvas.h:

(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):

platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(WebCore::LayerData::needsTexture):
(LayerData):

platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):

platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::setDrawable):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::loadBufferingImageData):

platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Renamed from Source/WebCore/platform/graphics/blackberry/skia/ImageBufferData.h.

(WebCore):
(ImageBufferData):

10:38 AM Changeset in webkit [112123] by kevino@webkit.org

2 edits in trunk/Source/JavaScriptCore

[wx] Unreviewed build fix. Add the build outputs dir to the list of build dirs, so we make sure it finds the API headers on all platforms.

10:38 AM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

10:37 AM Changeset in webkit [112122] by Martin Robinson

3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r112111

10:36 AM Changeset in webkit [112121] by Martin Robinson

6 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r112004

10:29 AM Changeset in webkit [112120] by Martin Robinson

3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r111915

10:25 AM Changeset in webkit [112119] by schenney@chromium.org

7 edits
2 adds in trunk

Source/WebCore: Failure to invalidate text position attributes when DOM changes
https://bugs.webkit.org/show_bug.cgi?id=81464

Reviewed by Nikolas Zimmermann.

The text positioning elements data structure in RenderSVGText must be
updated when either the children of the corresponding element are
modified, or the length of the text inside the elements changes.
Previously, the call to clear the text positioning elements (to force
recomputation) was guarded by a flag. If code tried to invalidate when
the flag was not set, then something set the flag, the elements would
be invalid at use time.

This patch modifies the method that invalidates the positining
attributes so that the action always happens. It also renames the
method to more accurately reflect its function.

Test: svg/custom/delete-modified-text-in-defs-crash.svg

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::setTextInternal): Rename textDOMChanged to invalidateTextPositioningElements

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::invalidateTextPositioningElements): Rename
textDOMChanged to invalidateTextPositioningElements and remove the check against the needsPosition... flag.

rendering/svg/RenderSVGText.h:

(RenderSVGText): Rename textDOMChanged to invalidateTextPositioningElements

svg/SVGAElement.cpp:

(WebCore::SVGAElement::childrenChanged): Rename textDOMChanged to invalidateTextPositioningElements

svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::childrenChanged): Rename textDOMChanged to invalidateTextPositioningElements

LayoutTests: Failure to invalidate text position attributes when DOM changes
https://bugs.webkit.org/show_bug.cgi?id=81464

Reviewed by Nikolas Zimmermann.

svg/custom/delete-modified-text-in-defs-crash-expected.txt: Added.
svg/custom/delete-modified-text-in-defs-crash.svg: Added.

10:22 AM Changeset in webkit [112118] by Martin Robinson

27 edits in releases/WebKitGTK/webkit-1.8/Source

Merging rr111914

10:16 AM Changeset in webkit [112117] by leviw@chromium.org

3 edits in branches/subpixellayout/Source/WebCore

Correcting a usage of linesBoundingBox as a LayoutRect, removing a rename from RenderTheme to minimize patch size, and using new convenience functions in SubframeLoader to simplify logic.

10:04 AM Changeset in webkit [112116] by pierre.rossi@gmail.com

3 edits in trunk/Source/WebKit2

[Qt][WK2] default families are not set in QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=81933

This would result in an attempt to create FontPlatformData
with the -webkit- prefixed family name.
Logic adapted from QWebSettings.

Patch by Pierre Rossi <pierre.rossi@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::initFontDefaults):

UIProcess/API/qt/qwebpreferences_p_p.h:

9:55 AM Changeset in webkit [112115] by commit-queue@webkit.org

8 edits
2 adds in trunk/LayoutTests

Rebaseline zoom-foreignObject.svg CR results
https://bugs.webkit.org/show_bug.cgi?id=82205

Unreviewed Chromium rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-03-26

platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.png:
platform/chromium-mac-leopard/svg/zoom/text/zoom-foreignObject-expected.png: Added.
platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png:
platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png:
platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.png:
platform/chromium/test_expectations.txt:

9:52 AM Changeset in webkit [112114] by jchaffraix@webkit.org

4 edits in trunk

REGRESSION (r110065-r110080): fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute
https://bugs.webkit.org/show_bug.cgi?id=81802

Reviewed by Dan Bernstein.

Source/WebCore:

Covered by fast/forms/placeholder-set-attribute.html which should be less flaky.

Unfortunately no new test case as this bug requires a very specific set of conditions that I couldn't reproduce deterministically.

This is a regression from r110072: RenderTextControlSingleLine would rely on the placeholder's RenderLayer to properly repaint during
the first layout as the placeholder has overflow: hidden set. r110072 removed the layer in this case and thus we miss a repaint.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
For our first layout, we need to make sure our placeholder is painted. layoutBlockChild has a very similar logic to force repaint
on a first layout. We don't hit this logic as the placeholder is explicitly skipped in RenderTextControl::layoutSpecialExcludedChild.

LayoutTests:

platform/mac/Skipped: Unskip the test on Mac. The other platforms are either

skipping it for other reasons or did not have a specific entry for the flakiness.

9:46 AM Changeset in webkit [112113] by jchaffraix@webkit.org

13 edits in trunk

REGRESSION(r110072): fast/forms/textfield-overflow.html is failing
https://bugs.webkit.org/show_bug.cgi?id=80531

Reviewed by Ojan Vafai.

Source/WebCore:

Tested by fast/forms/textfield-overflow.html (re-enabled after this change).

The existing code would happily query layout information before calling layout (FTW!).
The solution is to properly layout our object, then modify some dimensions as needed while
marking ourself as needing layout and then layouting again.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Implemented a proper 2 pass layout algorithm. Removed the |relayoutChildren| logic as:

layoutBlock handles automatically logical height changes.
we were not modifying the logical width between layouts so we don't need to force a

child relayout in this case.

LayoutTests:

platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:

This is a progression. The <input> now takes the full cell's space instead of
being shrunk.

platform/efl/Skipped:
platform/efl/test_expectations.txt:
platform/gtk/Skipped:
platform/gtk/test_expectations.txt:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

Re-enable fast/forms/textfield-overflow.html as it should be passing.
Also disabled colspanMinWidth-vertical.html on platforms without a rebaseline.

platform/chromium/test_expectations.txt:

Ditto and marked fast/repaint/search-field-cancel.html as failing image only.

9:43 AM Changeset in webkit [112112] by pfeldman@chromium.org

1 edit
5 adds
15 deletes in trunk/LayoutTests

Supersede t1504-c543-txt-decor-00-d-g.html with c543-txt-decor-000.html
https://bugs.webkit.org/show_bug.cgi?id=82120

Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-26
Reviewed by Pavel Feldman.

Test css2.1/t1504-c543-txt-decor-00-d-g.html is outdated and had
some issues, hence removed and superseding it with c543-txt-decor-000.html. Also,
copied two support png files from css2.1/support to css2.1/20110323/support.

css2.1/20110323/c543-txt-decor-000-expected.png: Added.
css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
css2.1/20110323/c543-txt-decor-000.html: Added.
css2.1/20110323/support/square-purple.png: Added.
css2.1/20110323/support/square-teal.png: Added.
css2.1/t1504-c543-txt-decor-00-d-g.html: Removed.
platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/chromium-mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/chromium-mac-snowleopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
platform/efl/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/efl/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
platform/mac-leopard/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Removed.
platform/mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.
platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Removed.

9:24 AM Changeset in webkit [112111] by Martin Robinson

3 edits in trunk/Source/WebKit/gtk

WebKitWebView signals with GError parameters cause crashes when using GObject Introspection
https://bugs.webkit.org/show_bug.cgi?id=81977

Patch by Gary Kramlich <grim@reaperworld.com> on 2012-03-26
Reviewed by Martin Robinson.

Added marshalers for BOOLEAN:OBJECT,STRING,BOXED and VOID:OBJECT,OBJECT,BOXED
and changed the signal signatures for WebKitWebView::load-fail and
WebKitWebView::resource-load-failed to use the new marshalers since
GError has been a GBoxed type since Gtk 2.26. This fixes these signals
for the gobject-introspection bindings.

webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

webkitmarshal.list:

9:24 AM Changeset in webkit [112110] by commit-queue@webkit.org

1 edit
2 adds in trunk/Source/WebCore

[BlackBerry] Upstream LayerCompositingThread.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79873

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-26
Reviewed by Rob Buis.

Initial upstream, no new tests.

platform/graphics/blackberry/LayerCompositingThread.cpp: Added.

(WebCore):
(WebCore::LayerCompositingThread::create):
(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::destroyOnCompositingThread):
(WebCore::LayerCompositingThread::setLayerRenderer):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::releaseTextureResources):
(WebCore::LayerCompositingThread::setPluginView):
(WebCore::LayerCompositingThread::setMediaPlayer):
(WebCore::LayerCompositingThread::clearAnimations):
(WebCore::LayerCompositingThread::removeSublayer):
(WebCore::LayerCompositingThread::indexOfSublayer):
(WebCore::LayerCompositingThread::rootLayer):
(WebCore::LayerCompositingThread::removeFromSuperlayer):
(WebCore::LayerCompositingThread::setSublayers):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::setNeedsCommit):
(WebCore::LayerCompositingThread::scheduleCommit):
(WebCore::LayerCompositingThread::updateAnimations):
(WebCore::LayerCompositingThread::hasVisibleHolePunchRect):
(WebCore::LayerCompositingThread::createLayerRendererSurface):

platform/graphics/blackberry/LayerCompositingThread.h: Added.

(Graphics):
(WebCore):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::bindContentsTexture):
(WebCore::LayerCompositingThread::getSublayers):
(WebCore::LayerCompositingThread::setSuperlayer):
(WebCore::LayerCompositingThread::superlayer):
(WebCore::LayerCompositingThread::drawTransform):
(WebCore::LayerCompositingThread::setDrawOpacity):
(WebCore::LayerCompositingThread::drawOpacity):
(WebCore::LayerCompositingThread::layerRendererSurface):
(WebCore::LayerCompositingThread::clearLayerRendererSurface):
(WebCore::LayerCompositingThread::setMaskLayer):
(WebCore::LayerCompositingThread::maskLayer):
(WebCore::LayerCompositingThread::setReplicaLayer):
(WebCore::LayerCompositingThread::replicaLayer):
(WebCore::LayerCompositingThread::getDrawRect):
(WebCore::LayerCompositingThread::getTransformedBounds):
(WebCore::LayerCompositingThread::hasMissingTextures):
(WebCore::LayerCompositingThread::isDirty):
(WebCore::LayerCompositingThread::isVisible):
(WebCore::LayerCompositingThread::setOpacity):
(WebCore::LayerCompositingThread::setTransform):
(WebCore::LayerCompositingThread::hasRunningAnimations):
(WebCore::LayerCompositingThread::numSublayers):

9:19 AM Changeset in webkit [112109] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Add a notification function for detaching to TextFieldDecorator
https://bugs.webkit.org/show_bug.cgi?id=82142

Reviewed by Dimitri Glazkov.

Add willDetach() functio to TextFieldDecorator. This will be
needed if a decorator opens a popup UI on handleClick(), and the
popup UI should be closed when the attaching text field is
detached.

No new tests because of no behavior changes in any platforms.

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::hostInput):
Added. A utilify function to get an HTMLInputElement*.
(WebCore::TextFieldDecorationElement::updateImage): Use hostInput().
(WebCore::TextFieldDecorationElement::customStyleForRenderer): ditto.
(WebCore::TextFieldDecorationElement::detach): Added. Calls TextFieldDecorator::willDetach().
(WebCore::TextFieldDecorationElement::defaultEventHandler): Use hostInput().

html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorator):
(TextFieldDecorationElement):

9:16 AM Changeset in webkit [112108] by mitz@apple.com

2 edits in trunk/Source/WebCore

Tried to fix the 32-bit build after r112021.

accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]):

9:11 AM Changeset in webkit [112107] by Csaba Osztrogonác

2 edits
13 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add Qt specific expected results for new passsing tests.

platform/qt/Skipped: Skip a new failing test.
platform/qt/editing/selection/selection-button-text-expected.png: Added.
platform/qt/editing/selection/selection-button-text-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
platform/qt/svg/custom/use-extern-href-expected.png: Added.
platform/qt/svg/custom/use-extern-href-expected.txt: Added.
platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
platform/qt/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.

8:51 AM Changeset in webkit [112106] by leo.yang@torchmobile.com.cn

7 edits
2 adds in trunk

[BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=82157

Reviewed by Rob Buis.

Source/cmake/OptionsBlackBerry.cmake: Turn on ENABLE_FILE_SYSTEM for blackberry.

Source/WebCore:

AsyncFileSystemBlackBerry is responsible for asynchronous operating
on file system for the blackberry porting. It's just skeleton code
containing no implementation yet.

No new tests because of skeleton code.

PlatformBlackBerry.cmake: Add AsyncFileSystemBlackBerry.cpp if ENABLE_FILE_SYSTEM is on.
platform/AsyncFileSystem.cpp:

(WebCore):

platform/blackberry/AsyncFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::toURL):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):

platform/blackberry/AsyncFileSystemBlackBerry.h: Added.

(WebCore):
(AsyncFileSystemBlackBerry):

Tools:

Scripts/build-webkit:

Make ENABLE_FILE_SYSTEM default on for blackberry.

8:50 AM Changeset in webkit [112105] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[Qt WK2] Disable/enable mouse events when displaying dialogs only for desktop view
https://bugs.webkit.org/show_bug.cgi?id=80542

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-26
Reviewed by Simon Hausmann.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::enableMouseEvents):
(QQuickWebViewLegacyPrivate::disableMouseEvents):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewLegacyPrivate):

8:37 AM Changeset in webkit [112104] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] CredentialBackingStore implement encryptString() and decryptString()
https://bugs.webkit.org/show_bug.cgi?id=82204

Patch by Jonathan Dong <Jonathan Dong> on 2012-03-26
Reviewed by Rob Buis.

Implemented encryptedString() and decryptedString() in class CredentialBackingStore
by calling BlackBerry::Platform::Encryptor::encryptString() and
BlackBerry::Platform::Encryptor::encryptString() respectively.

No new tests.

platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):

8:36 AM Changeset in webkit [112103] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac] Skip failing tests to paint the bot green.

platform/qt-mac/Skipped:

8:30 AM Changeset in webkit [112102] by pfeldman@chromium.org

6 edits in trunk

Web Inspector: 'use strict' exceptions stop in inspector code
https://bugs.webkit.org/show_bug.cgi?id=82199

Reviewed by Yury Semikhatsky.

Source/WebCore:

Accessing callee from within InjectedScript made inspector stop on handled exceptions.
I replaced it with Object.prototype.toString.call(obj) === "[object Arguments]".

inspector/InjectedScriptSource.js:

LayoutTests:

inspector/console/console-format-collections-expected.txt:
inspector/console/console-format-collections.html:
platform/chromium/inspector/console/console-format-collections-expected.txt:

8:26 AM Changeset in webkit [112101] by kubo@profusion.mobi

3 edits in trunk/Tools

[jhbuild] Explicitly disable DTrace when building glib.
https://bugs.webkit.org/show_bug.cgi?id=82145

Reviewed by Gustavo Noronha Silva.

DTrace support is not really needed by WebKit, so disabling it
helps avoid some build errors on more exotic platforms (such as
FreeBSD).

efl/jhbuild.modules:
gtk/jhbuild.modules:

8:23 AM April 2012 Meeting edited by tomz@codeaurora.org

(diff)

8:22 AM April 2012 Meeting edited by tomz@codeaurora.org

(diff)

8:21 AM Changeset in webkit [112100] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Build fix for WinCE after r112039.

interpreter/Register.h:

(Register): Removed inline keyword from decleration since

there is an ALWAYS_INLINE at the definition anyway.

8:16 AM Changeset in webkit [112099] by commit-queue@webkit.org

3 edits
2 adds in trunk

[CSS Regions] In region styling (@-webkit-region) the position for CSS rules is incorrectly computed
https://bugs.webkit.org/show_bug.cgi?id=81901

Patch by Mihai Balan <mibalan@adobe.com> on 2012-03-26
Reviewed by Antti Koivisto.

Source/WebCore:

Right now CSS rules position does not take into account rules that are inside a @-webkit-region
declaration, leading to buggy behavior where rules that appear later in the document are superseded
by rules that appear earlier in the document (opposite as how things should be). The fix updates
the "global" rules counter once the rules in a @-webkit-region declaration have been added.

Tests: fast/regions/region-style-rule-position-expected.html

fast/regions/region-style-rule-position.html

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Ref tests for bug #81901. Testing that CSS rules position is properly computed when having multiple
@-webkit-region declarations.

fast/regions/region-style-rule-position-expected.html: Added.
fast/regions/region-style-rule-position.html: Added.

8:14 AM Changeset in webkit [112098] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove tests, because the original change was rolled out.

platform/qt-5.0-wk2/Skipped:

8:11 AM Changeset in webkit [112097] by leviw@chromium.org

3 edits in branches/subpixellayout/Source/WebCore/rendering

Removing dead code in RenderReplaced, and correcting use of LayoutUnits for integers from HTMLFrameBase.

7:54 AM Changeset in webkit [112096] by jocelyn.turcotte@nokia.com

2 edits in trunk/Source/WebKit2

[Qt] Make sure that purged directly composited images are re-created before a layer's sync.
https://bugs.webkit.org/show_bug.cgi?id=81771

Reviewed by Noam Rosenthal.

This fixes a regression in tst_qquickwebview introduced by r111567.

WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::updateContentBuffers):

7:49 AM Changeset in webkit [112095] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Disable focus ring in the mobile theme.
https://bugs.webkit.org/show_bug.cgi?id=81934

For mobile devices intended to be used only through
touch, the focus rings makes little sense and feels
awkward.

Patch by Pierre Rossi <pierre.rossi@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

No new tests. This is merely a cosmetic touch.

platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::platformFocusRingColor):

7:47 AM Changeset in webkit [112094] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Running these two tests gives different results on 32 and
64 bit systems so they have been skipped until they're fixed.

Patch by JÃ¡nos Badics <János Badics> on 2012-03-26
Reviewed by Csaba OsztrogonÃ¡c.

platform/qt/Skipped:

7:40 AM Changeset in webkit [112093] by Simon Hausmann

7 edits in trunk/Source/WebKit2

[WK2][Qt] Fix compilation without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=79458

Reviewed by Tor Arne Vestbø.

Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent): Replace use of QApplication::wheelScrollLines()
with the constant that is actually used and usually not changed anyway.

Target.pri: Remove widgets from Qt variable.
UIProcess/qt/QtWebPageEventHandler.cpp: Remove unecessary include.
WebProcess.pro: Use widgets for the process (for the time being).
WebProcess/qt/WebProcessMainQt.cpp: Delegate QApplication creation to the caller.

(WebKit::WebProcessMainQt):

qt/MainQt.cpp: Create QApplication here.

(WebKit):
(main):

7:38 AM Changeset in webkit [112092] by charles.wei@torchmobile.com.cn

8 edits in trunk/Source/WebCore

[BlackBerry] Clean up networking code and remove WML support.
https://bugs.webkit.org/show_bug.cgi?id=82170

Reviewed by Rob Buis.

This just removes the WML support of BlackBerry porting, which is already
removed from WebCore. No new tests needed.

platform/blackberry/MIMETypeRegistryBlackBerry.cpp:

(WebCore):

platform/network/blackberry/DeferredData.cpp:

(WebCore::DeferredData::DeferredData):
(WebCore::DeferredData::processDeferredData):

platform/network/blackberry/DeferredData.h:

(DeferredData):
(WebCore::DeferredData::hasDeferredData):

platform/network/blackberry/NetworkJob.cpp:
platform/network/blackberry/NetworkJob.h:

(NetworkJob):

platform/network/blackberry/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):
(ResourceResponse):

platform/network/blackberry/ResourceResponseBlackBerry.cpp:

(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):

7:36 AM Changeset in webkit [112091] by commit-queue@webkit.org

8 edits
2 adds in trunk

Add invalid bounding box concept to SVG containers
https://bugs.webkit.org/show_bug.cgi?id=81104

Patch by Philip Rogers <pdr@google.com> on 2012-03-26
Reviewed by Nikolas Zimmermann.

Source/WebCore:

An empty <g> element needs to use an invalid bounding box because
an empty bounding box isn't the default state. This change
introduces the concept of an invalid object bounding box for
both RenderSVGContainer and RenderSVGRoot. Code that
does not explicitly check that the bounding box is valid
should be unaffected by this change. We use this new invalid
flag in computeContainerBoundingBoxes so that we do not
include invalid bounding boxes.

This change also contains a small fix in
RenderSVGContainer::toRenderSVGContainer which depended on
RenderSVGViewportContainer not inheriting from RenderSVGContainer,
which it now does.

Test: svg/custom/getBBox-empty-container.html

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::updateCachedBoundaries):

rendering/svg/RenderSVGContainer.h:

(WebCore::RenderSVGContainer::isObjectBoundingBoxValid):
(RenderSVGContainer):
(WebCore::toRenderSVGContainer):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::updateCachedBoundaries):

rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

rendering/svg/SVGRenderSupport.cpp:

(WebCore):
(WebCore::updateObjectBoundingBox):
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

svg/custom/getBBox-empty-container-expected.txt: Added.
svg/custom/getBBox-empty-container.html: Added.

7:32 AM Changeset in webkit [112090] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Speed up the retainers build phase.
https://bugs.webkit.org/show_bug.cgi?id=81763

Replacing the edge iterator in retainers building phase
makes it run 10 times faster (400 ms vs. 4 sec).

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-26
Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildRetainers):

7:20 AM Changeset in webkit [112089] by abecsi@webkit.org

2 edits in trunk/Source/WebKit2

Be more careful with git gui usage

Unreviewed typo fix.

UIProcess/qt/QtViewportInteractionEngine.cpp: Remove additional line committed by accident.

(WebKit::QtViewportInteractionEngine::pinchGestureEnded):

7:16 AM Changeset in webkit [112088] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Allow the viewport meta tag to be disabled for testing purposes
https://bugs.webkit.org/show_bug.cgi?id=81940

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-03-26
Reviewed by Adam Barth.

public/WebSettings.h:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setViewportEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::viewportEnabled):

7:04 AM Changeset in webkit [112087] by apavlov@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: Migrate InspectorCSSAgent to strict protocol types
https://bugs.webkit.org/show_bug.cgi?id=81923

Reviewed by Pavel Feldman.

No new tests, as this is a refactoring.

inspector/CodeGeneratorInspector.py:
inspector/InspectorCSSAgent.cpp:

(SelectorProfile):
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

inspector/InspectorStyleSheet.cpp:

(WebCore::buildSourceRangeObject):
(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):

inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::asProtocolValue):
(InspectorStyle):
(InspectorStyleSheet):

6:59 AM Changeset in webkit [112086] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: [chromium] rebaselining plugins/embed-attributes-style.

platform/chromium-linux/plugins/embed-attributes-style-expected.png:

6:50 AM Changeset in webkit [112085] by pfeldman@chromium.org

3 edits in trunk/LayoutTests

Not reviewed: [chromium] rebaselining compositing/plugins/composited-plugin.

platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.png:
platform/chromium-mac-snowleopard/compositing/plugins/composited-plugin-expected.png:

6:23 AM Changeset in webkit [112084] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Taps are sometimes not highlighted.
https://bugs.webkit.org/show_bug.cgi?id=82188

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

Highlight any focusable parent element, or if none is found at least
the element returned by bestClickableNodeForTouchPoint.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

6:15 AM WebKitGTK/Releasing edited by plaes@plaes.org

Add link to Gentoo's make patchset (original patch doesn't apply that … (diff)

6:07 AM Changeset in webkit [112083] by apavlov@chromium.org

3 edits
3 adds in trunk

Web Inspector: [REGRESSION] Workarounds for security checks when retrieving stylesheet rule lists are broken
https://bugs.webkit.org/show_bug.cgi?id=82191

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/modify-cross-domain-rule.html

inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):

LayoutTests:

http/tests/inspector/modify-cross-domain-rule-expected.txt: Added.
http/tests/inspector/modify-cross-domain-rule.html: Added.
http/tests/inspector/styles/modify-cross-domain-rule.css: Added.

(#inspected):

6:05 AM Changeset in webkit [112082] by Carlos Garcia Campos

6 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

GNUmakefile.list.am: Add missing files.

Source/WebCore:

GNUmakefile.list.am: Add missing files.

Source/WTF:

GNUmakefile.list.am: Add config.h to the source file list.

5:58 AM Changeset in webkit [112081] by leviw@chromium.org

10 edits in branches/subpixellayout/Source/WebCore

Reverting RenderTheme painting to integers to avoid making platform code understand LayoutUnits.

5:42 AM Changeset in webkit [112080] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Cookies mismatch when login to gmail.
https://bugs.webkit.org/show_bug.cgi?id=82165

Redirection's response can add or update cookies. The cookies of ResourceRequest is dirty
in this case. We shouldn't copy the dirty cookie header from ResourceRequest to PlatformRequest
for redirection loading.

This issue didn't happen before because we used m_cookieData not the cookie header.
Now we use the cookie header to avoid storing double cookie's data, and m_cookieData is removed.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-26
Reviewed by George Staikos.

No new tests. It is a refactoring issue.

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

5:32 AM Changeset in webkit [112079] by Csaba Osztrogonác

4 edits
253 adds in trunk/LayoutTests

[Qt] Unskip passing tests from the 'new tests without expected results' section.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-03-26
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:
platform/qt/compositing/overflow/ancestor-overflow-expected.png: Added.
platform/qt/compositing/overflow/ancestor-overflow-expected.txt: Added.
platform/qt/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
platform/qt/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
platform/qt/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
platform/qt/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
platform/qt/fast/backgrounds/border-radius-split-background-expected.png: Added.
platform/qt/fast/backgrounds/border-radius-split-background-expected.txt: Added.
platform/qt/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
platform/qt/fast/backgrounds/border-radius-split-background-image-expected.txt: Added.
platform/qt/fast/backgrounds/mask-box-image-expected.png: Added.
platform/qt/fast/backgrounds/mask-box-image-expected.txt: Added.
platform/qt/fast/block/float/fit_line_below_floats-expected.png: Added.
platform/qt/fast/block/float/fit_line_below_floats-expected.txt: Added.
platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
platform/qt/fast/block/float/overhanging-tall-block-expected.png: Added.
platform/qt/fast/block/float/overhanging-tall-block-expected.txt: Added.
platform/qt/fast/block/lineboxcontain/none-expected.png: Added.
platform/qt/fast/block/lineboxcontain/none-expected.txt: Added.
platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
platform/qt/fast/borders/border-image-slice-constrained-expected.png: Added.
platform/qt/fast/borders/border-image-slice-constrained-expected.txt: Added.
platform/qt/fast/borders/border-styles-split-expected.png: Added.
platform/qt/fast/borders/border-styles-split-expected.txt: Added.
platform/qt/fast/borders/mixed-border-styles-radius2-expected.png: Added.
platform/qt/fast/borders/mixed-border-styles-radius2-expected.txt: Added.
platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
platform/qt/fast/box-shadow/inset-box-shadows-expected.png: Added.
platform/qt/fast/box-shadow/inset-box-shadows-expected.txt: Added.
platform/qt/fast/box-shadow/scaled-box-shadow-expected.png: Added.
platform/qt/fast/box-shadow/scaled-box-shadow-expected.txt: Added.
platform/qt/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
platform/qt/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
platform/qt/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
platform/qt/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
platform/qt/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
platform/qt/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
platform/qt/fast/css/font-face-weight-matching-expected.png: Added.
platform/qt/fast/css/font-face-weight-matching-expected.txt: Added.
platform/qt/fast/css/non-empty-span-expected.png: Added.
platform/qt/fast/css/non-empty-span-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
platform/qt/fast/css/transformed-mask-expected.png: Added.
platform/qt/fast/css/transformed-mask-expected.txt: Added.
platform/qt/fast/dom/52776-expected.png: Added.
platform/qt/fast/dom/52776-expected.txt: Added.
platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
platform/qt/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
platform/qt/fast/forms/input-placeholder-visibility-1-expected.png: Added.
platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
platform/qt/fast/forms/input-placeholder-visibility-3-expected.png: Added.
platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
platform/qt/fast/forms/listbox-bidi-align-expected.png: Added.
platform/qt/fast/forms/listbox-bidi-align-expected.txt: Added.
platform/qt/fast/forms/placeholder-position-expected.png:
platform/qt/fast/forms/placeholder-position-expected.txt:
platform/qt/fast/forms/range/input-appearance-range-expected.png: Added.
platform/qt/fast/forms/range/input-appearance-range-expected.txt: Added.
platform/qt/fast/forms/select-overflow-scroll-expected.png: Added.
platform/qt/fast/forms/select-overflow-scroll-expected.txt: Added.
platform/qt/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
platform/qt/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
platform/qt/fast/forms/textfield-focus-ring-expected.png: Added.
platform/qt/fast/forms/textfield-focus-ring-expected.txt: Added.
platform/qt/fast/line-grid/line-align-left-edges-expected.png: Added.
platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Added.
platform/qt/fast/line-grid/line-align-right-edges-expected.png: Added.
platform/qt/fast/line-grid/line-align-right-edges-expected.txt: Added.
platform/qt/fast/line-grid/line-grid-contains-value-expected.png: Added.
platform/qt/fast/line-grid/line-grid-contains-value-expected.txt: Added.
platform/qt/fast/line-grid/line-grid-floating-expected.png: Added.
platform/qt/fast/line-grid/line-grid-floating-expected.txt: Added.
platform/qt/fast/line-grid/line-grid-inside-columns-expected.png: Added.
platform/qt/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
platform/qt/fast/line-grid/line-grid-into-columns-expected.png: Added.
platform/qt/fast/line-grid/line-grid-into-columns-expected.txt: Added.
platform/qt/fast/line-grid/line-grid-into-floats-expected.png: Added.
platform/qt/fast/line-grid/line-grid-into-floats-expected.txt: Added.
platform/qt/fast/line-grid/line-grid-positioned-expected.png: Added.
platform/qt/fast/line-grid/line-grid-positioned-expected.txt: Added.
platform/qt/fast/multicol/positioned-split-expected.png: Added.
platform/qt/fast/multicol/positioned-split-expected.txt: Added.
platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
platform/qt/fast/repaint/transform-rotate-and-remove-expected.png: Added.
platform/qt/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
platform/qt/fast/text/hyphenate-limit-before-after-expected.png: Added.
platform/qt/fast/text/hyphenate-limit-before-after-expected.txt: Added.
platform/qt/fast/text/unicode-variation-selector-expected.png: Added.
platform/qt/fast/text/unicode-variation-selector-expected.txt: Added.
platform/qt/fast/writing-mode/fallback-orientation-expected.png: Added.
platform/qt/fast/writing-mode/fallback-orientation-expected.txt: Added.
platform/qt/http/tests/misc/slow-loading-mask-expected.png: Added.
platform/qt/http/tests/misc/slow-loading-mask-expected.txt: Added.
platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
platform/qt/svg/custom/mask-colorspace-expected.png: Added.
platform/qt/svg/custom/mask-colorspace-expected.txt: Added.
platform/qt/svg/custom/object-no-size-attributes-expected.png: Added.
platform/qt/svg/custom/object-no-size-attributes-expected.txt: Added.
platform/qt/svg/custom/object-sizing-explicit-height-expected.png: Added.
platform/qt/svg/custom/object-sizing-explicit-height-expected.txt: Added.
platform/qt/svg/custom/object-sizing-explicit-width-expected.png: Added.
platform/qt/svg/custom/object-sizing-explicit-width-expected.txt: Added.
platform/qt/svg/custom/path-moveto-only-rendering-expected.png: Added.
platform/qt/svg/custom/path-moveto-only-rendering-expected.txt: Added.
platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png: Added.
platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
platform/qt/svg/custom/relative-sized-image-expected.png: Added.
platform/qt/svg/custom/relative-sized-image-expected.txt: Added.
platform/qt/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
platform/qt/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.txt: Added.
platform/qt/svg/custom/svg-fonts-segmented-expected.png: Added.
platform/qt/svg/custom/svg-fonts-segmented-expected.txt: Added.
platform/qt/svg/custom/use-disappears-after-style-update-expected.png: Added.
platform/qt/svg/custom/use-disappears-after-style-update-expected.txt: Added.
platform/qt/svg/filters/feColorMatrix-offset-expected.png: Added.
platform/qt/svg/filters/feColorMatrix-offset-expected.txt: Added.
platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
platform/qt/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
platform/qt/svg/filters/feImage-change-target-id-expected.png: Added.
platform/qt/svg/filters/feImage-change-target-id-expected.txt: Added.
platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Added.
platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Added.
platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Added.
platform/qt/svg/filters/feImage-late-indirect-update-expected.png: Added.
platform/qt/svg/filters/feImage-late-indirect-update-expected.txt: Added.
platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
platform/qt/svg/filters/feImage-position-expected.png: Added.
platform/qt/svg/filters/feImage-position-expected.txt: Added.
platform/qt/svg/filters/feImage-preserveAspectratio-expected.png: Added.
platform/qt/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
platform/qt/svg/filters/feImage-remove-target-expected.png: Added.
platform/qt/svg/filters/feImage-remove-target-expected.txt: Added.
platform/qt/svg/filters/feImage-subregions-expected.png: Added.
platform/qt/svg/filters/feImage-subregions-expected.txt: Added.
platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
platform/qt/svg/filters/feImage-target-add-to-document-expected.png: Added.
platform/qt/svg/filters/feImage-target-add-to-document-expected.txt: Added.
platform/qt/svg/filters/feImage-target-attribute-change-expected.png: Added.
platform/qt/svg/filters/feImage-target-attribute-change-expected.txt: Added.
platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
platform/qt/svg/filters/feImage-target-changes-id-expected.png: Added.
platform/qt/svg/filters/feImage-target-changes-id-expected.txt: Added.
platform/qt/svg/filters/feImage-target-id-change-expected.png: Added.
platform/qt/svg/filters/feImage-target-id-change-expected.txt: Added.
platform/qt/svg/filters/feImage-target-inline-style-change-expected.png: Added.
platform/qt/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
platform/qt/svg/filters/feImage-target-property-change-expected.png: Added.
platform/qt/svg/filters/feImage-target-property-change-expected.txt: Added.
platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
platform/qt/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
platform/qt/svg/filters/feImage-target-remove-from-document-expected.png: Added.
platform/qt/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
platform/qt/svg/filters/feImage-target-style-change-expected.png: Added.
platform/qt/svg/filters/feImage-target-style-change-expected.txt: Added.
platform/qt/svg/filters/filter-placement-issue-expected.png: Added.
platform/qt/svg/filters/filter-placement-issue-expected.txt: Added.
platform/qt/svg/filters/filter-refresh-expected.png: Added.
platform/qt/svg/filters/filter-refresh-expected.txt: Added.
platform/qt/svg/filters/filterRes1-expected.png: Added.
platform/qt/svg/filters/filterRes1-expected.txt: Added.
platform/qt/svg/filters/filterRes3-expected.png: Added.
platform/qt/svg/filters/filterRes3-expected.txt: Added.
platform/qt/svg/filters/parent-children-with-same-filter-expected.png: Added.
platform/qt/svg/filters/parent-children-with-same-filter-expected.txt: Added.
platform/qt/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
platform/qt/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
platform/qt/svg/foreignObject/fO-parent-display-none-expected.png: Added.
platform/qt/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Added.
platform/qt/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Added.
platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Added.
platform/qt/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
platform/qt/svg/repaint/filter-repaint-expected.png: Added.
platform/qt/svg/repaint/filter-repaint-expected.txt: Added.
platform/qt/svg/text/append-text-node-to-tspan-expected.png: Added.
platform/qt/svg/text/append-text-node-to-tspan-expected.txt: Added.
platform/qt/svg/text/modify-text-node-in-tspan-expected.png: Added.
platform/qt/svg/text/modify-text-node-in-tspan-expected.txt: Added.
platform/qt/svg/text/remove-text-node-from-tspan-expected.png: Added.
platform/qt/svg/text/remove-text-node-from-tspan-expected.txt: Added.
platform/qt/svg/text/remove-tspan-from-text-expected.png: Added.
platform/qt/svg/text/remove-tspan-from-text-expected.txt: Added.
platform/qt/svg/wicd/sizing-flakiness-expected.png: Added.
platform/qt/svg/wicd/sizing-flakiness-expected.txt: Added.

5:11 AM Changeset in webkit [112078] by alexis.menard@openbossa.org

4 edits in trunk/Source/WebCore

Increase code sharing between StylePropertySet and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=81960

Reviewed by Antti Koivisto.

Use longhands declaration from CSSPropertyLonghand in StylePropertySet in order
to avoid code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

css/CSSPropertyLonghand.cpp:

(WebCore::backgroundLonghand):
Re-order the array to match the spec default order.
(WebCore::webkitMaskLonghand):
Re-order to match the original order.
(WebCore::webkitTransformOriginLonghand):
A LayoutTest shows that a property was missing.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::asText):

css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

4:56 AM Changeset in webkit [112077] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Assert in GestureTapHighlighter.
https://bugs.webkit.org/show_bug.cgi?id=82187

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

Adjust the boundaries of the center-rect before performing the intersection test,
since adjusting the boundary may cause a new intersection.

page/GestureTapHighlighter.cpp:

4:52 AM Changeset in webkit [112076] by Antti Koivisto

29 edits in trunk/Source/WebCore

Split MediaList into internal and CSSOM types
https://bugs.webkit.org/show_bug.cgi?id=82149

Reviewed by Andread Kling.

MediaList is a CSSOM type and should not be used internally.

Use new type MediaQuerySet internally to represent a collection of media queries.
Create MediaList wrapper on-demand for CSSOM purposes only.

This moves us forward in separating CSSOM from the internal stylesheet implementation.

MediaQuerySet really belongs to a file of its own but that is not part of this patch.

css/CSSGrammar.y:
css/CSSImportRule.cpp:

(WebCore::CSSImportRule::create):
(WebCore):
(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::media):
(WebCore::CSSImportRule::cssText):

css/CSSImportRule.h:

(WebCore):
(CSSImportRule):
(WebCore::CSSImportRule::mediaQueries):

css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::cssText):

css/CSSMediaRule.h:

(WebCore::CSSMediaRule::create):
(WebCore::CSSMediaRule::media):
(WebCore::CSSMediaRule::mediaQueries):
(CSSMediaRule):

css/CSSParser.cpp:

(WebCore::CSSParser::parseMediaQuery):
(WebCore::CSSParser::createMediaQuerySet):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::updateLastMediaLine):

css/CSSParser.h:

(WebCore):
(CSSParser):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSStyleSheet.cpp:

(WebCore):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::setMediaQueries):

css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::mediaQueries):

css/MediaList.cpp:

(WebCore):
(WebCore::MediaQuerySet::MediaQuerySet):
(WebCore::MediaQuerySet::~MediaQuerySet):
(WebCore::parseMediaDescriptor):
(WebCore::MediaQuerySet::parse):
(WebCore::MediaQuerySet::add):
(WebCore::MediaQuerySet::remove):
(WebCore::MediaQuerySet::addMediaQuery):
(WebCore::MediaQuerySet::mediaText):
(WebCore::MediaQuerySet::ensureMediaList):

Use OwnPtr<> for MediaQuery ownership.
Move the appropriate functions to MediaQuerySet.
Clean up a bit to make this more readable and better aligned to WebKit style.

(WebCore::MediaList::MediaList):
(WebCore::MediaList::~MediaList):
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::item):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):

css/MediaList.h:

(WebCore):
(WebCore::MediaQuerySet::create):
(WebCore::MediaQuerySet::createAllowingDescriptionSyntax):
(MediaQuerySet):
(WebCore::MediaQuerySet::queryVector):
(WebCore::MediaQuerySet::lastLine):
(WebCore::MediaQuerySet::setLastLine):
(MediaList):
(WebCore::MediaList::ref):
(WebCore::MediaList::deref):
(WebCore::MediaList::length):
(WebCore::MediaList::mediaText):
(WebCore::MediaList::queries):

css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::eval):

css/MediaQueryEvaluator.h:

(WebCore):
(MediaQueryEvaluator):

css/MediaQueryList.cpp:

(WebCore::MediaQueryList::create):
(WebCore::MediaQueryList::MediaQueryList):

css/MediaQueryList.h:

(WebCore):
(MediaQueryList):

css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::evaluate):
(WebCore::MediaQueryMatcher::matchMedia):

css/MediaQueryMatcher.h:

(WebCore):
(MediaQueryMatcher):

css/StyleMedia.cpp:

(WebCore::StyleMedia::matchMedium):

css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

Move the media query ownership to CSSStyleSheet where it belongs.

(WebCore):

css/StyleSheet.h:

(WebCore::StyleSheet::media):
(StyleSheet):

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):

dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::setCSSStyleSheet):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectNextSourceChild):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLNames::PreloadTask::linkMediaAttributeIsScreen):

inspector/InspectorStyleSheet.cpp:

(WebCore::buildMediaObject):

4:17 AM Changeset in webkit [112075] by zeno.albisser@nokia.com

2 edits in trunk/Source/WebCore

[Qt]WK2] TextureMapperShaderManager should query the program map before creating new shader program instances.
https://bugs.webkit.org/show_bug.cgi?id=82178

If TextureMapperShaderManager already has a reference to an instance of the
requested shader program type, this instance should be reused instead of
creating a new one.

Reviewed by Noam Rosenthal.

platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderManager::getShaderProgram):

4:00 AM Changeset in webkit [112074] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Removing an unused paramter in LayoutRepainter.

3:51 AM Changeset in webkit [112073] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r111993.
http://trac.webkit.org/changeset/111993
https://bugs.webkit.org/show_bug.cgi?id=82184

It broke layout and API tests and made WTR crash (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-26

Source/WebKit2:

UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

3:18 AM Changeset in webkit [112072] by yurys@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: dedicated worker inspector is empty
https://bugs.webkit.org/show_bug.cgi?id=82181

"beforeunload" event for worker inspector front-end is ingnored if the
window url is "about:blank" as it is just unload of the default content
before the front-end page load.

Reviewed by Pavel Feldman.

inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._workerInspectorClosing):

3:15 AM Changeset in webkit [112071] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: split nodes and containment edges into two different arrays
https://bugs.webkit.org/show_bug.cgi?id=81930

Extract heap profile nodes and edges into two separate arrays. This
way we will have a continuous array of the heap graph nodes and can
aviod additional mapping between node index and its position in the
heap snapshot.

Reviewed by Pavel Feldman.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildContinuousNodeArray):
(WebInspector.HeapSnapshot.prototype._createOnlyNodesArray):
(WebInspector.HeapSnapshot.prototype._restoreNodeTypes):
(WebInspector.HeapSnapshot.prototype._createRetainmentEdgesArray):
(WebInspector.HeapSnapshot.prototype._createContainmentEdgesArray):

inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

2:55 AM Changeset in webkit [112070] by podivilov@chromium.org

5 edits in trunk

Web Inspector: move resource loading logic from SourceMapParser to CompilerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=81897

Reviewed by Vsevolod Vlasov.

Source/WebCore:

SourceMapParser should only deal with payload parsing.

inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.SourceMapPayload):
(WebInspector.SourceMapParser):
(WebInspector.SourceMapParser.prototype.sourceContent):
(WebInspector.SourceMapParser.prototype.findEntry):
(WebInspector.SourceMapParser.prototype.findEntryReversed):

inspector/front-end/ContentProviders.js:

(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):

LayoutTests:

http/tests/inspector/compiler-script-mapping.html:

2:36 AM Changeset in webkit [112069] by pfeldman@chromium.org

1 edit
4 moves
2 adds
23 deletes in trunk/LayoutTests

Reverting r112060, css3/selector3 expectations for chromium.

2:28 AM Changeset in webkit [112068] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Adding missing pixel snapping in RenderFieldSet and changing a toInt() call to an abstraction-friendly floorToInt().

2:27 AM Changeset in webkit [112067] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: marking more flaky chromium css3/selector3 tests.

platform/chromium/test_expectations.txt:

2:07 AM Changeset in webkit [112066] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: replace indexOf('a text') === 0 with RegExp because it is much faster.
https://bugs.webkit.org/show_bug.cgi?id=82175

We were using aString.indexOf("Window") but it is not effective from performance point of view.
I'm replaced it with RegExp.

Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isWindow):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):

2:04 AM Changeset in webkit [112065] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: marking flaky chromium css3/selector3 tests.

platform/chromium/test_expectations.txt:

1:56 AM Changeset in webkit [112064] by pfeldman@chromium.org

6 edits in trunk

Web Inspector: breakpoints should be disabled while live editing JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=81947

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change disables (removes from the backend) the breakpoints while editing script.
Undoing or committing the change restores the breakpoints. Main logic is implemented within
JavaScriptSourceFrame, but it required minor tweaking of the text editor: more correct
undo/redo wrapper and better detection of the noop opterations.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):

inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.before):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.after):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):

LayoutTests:

inspector/editor/highlighter-basics-expected.txt:

1:55 AM Changeset in webkit [112063] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed gardening, remove non-existing tests from Skipped lists.

platform/qt/Skipped:
platform/wk2/Skipped:

1:38 AM Changeset in webkit [112062] by Philippe Normand

1 edit
7 adds in trunk/LayoutTests

Unreviewed, GTK baselines for new fast/hidpi tests.

platform/gtk/fast/hidpi/image-set-as-background-expected.txt: Added.
platform/gtk/fast/hidpi/image-set-background-repeat-expected.txt: Added.
platform/gtk/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt: Added.
platform/gtk/fast/hidpi/image-set-simple-expected.txt: Added.
platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt: Added.

1:35 AM Changeset in webkit [112061] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderListMarker.cpp

Second round of RenderListMarker cleanup. Properly measuring text with integers.

1:27 AM Changeset in webkit [112060] by pfeldman@chromium.org

1 edit
314 adds in trunk/LayoutTests

Not reviewed: chromium expectations for css3/selectors3 re-added for snow -leopard.

platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-1-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-10-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-11-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-118-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-119-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-120-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-121-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-122-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-13-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-144-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145b-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-148-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14d-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14e-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-150-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-151-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-152-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-153-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-154-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155d-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-157-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-158-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-159-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15c-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-16-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-160-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-17-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170d-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-171-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173a-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174a-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-176-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-178-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-180a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-181-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-182-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-183-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184d-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184e-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184f-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-2-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-20-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-22-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-25-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-30-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-31-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-32-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-33-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-34-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-35-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-36-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-37-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-38-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-4-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42a-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44d-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45c-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-47-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-48-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-49-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-49-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-5-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-50-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-51-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-52-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-53-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-54-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-55-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-56-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-59-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-6-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-60-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-61-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-62-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-63-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-65-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-67-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-70-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-79-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-8-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-80-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-83-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-86-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-89-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-9-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-91-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-92-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-93-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-95-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d1-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d1-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d1b-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d2-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d2-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d3-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d3-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d4-expected.png: Added.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-d4-expected.txt: Added.

1:02 AM Changeset in webkit [112059] by nduca@chromium.org

13 edits in trunk/Source

[chromium] Route willBeginFrame from compositor to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=82171

Reviewed by Darin Fisher.

Source/Platform:

chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(WebCore::CCLayerTreeHost::willBeginFrame):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):

Source/WebKit/chromium:

public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::willBeginCompositorFrame):

src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit):

src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willBeginFrame):
(WebKit):

src/WebViewImpl.h:

(WebViewImpl):

tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::willBeginFrame):
(MockLayerTreeHostClient):

tests/FakeCCLayerTreeHostClient.h:

(WebCore::FakeCCLayerTreeHostClient::willBeginFrame):

12:34 AM Changeset in webkit [112058] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, skip plugins/netscape-dom-access-and-reload.html
failing on GTK and Qt.

platform/gtk/Skipped:
platform/qt/Skipped:

12:27 AM Changeset in webkit [112057] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r112022.

platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:

12:20 AM Changeset in webkit [112056] by pfeldman@chromium.org

2 edits
293 deletes in trunk/LayoutTests

Not reviewed: [chromium] preparing to generate proper snow leopard css3/selectors3/xml tests.

platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-1-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-10-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-100b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-101b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-102b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-103b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-104b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-105b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-106b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-107b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-108b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-109b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-11-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-110b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-111b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-112b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-113b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-114b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-115b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-116b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-117b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-118-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-119-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-120-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-121-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-121-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-122-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-123b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-124b-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-125b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-126b-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-127b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-128b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-129b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-13-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-130b-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-131b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-132b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-133b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-134b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-135b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-136b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-137b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-138b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-139b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-140b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-141b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-142b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-143b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-144-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-145b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-146b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-147b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-148-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-149b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14d-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-14e-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-150-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-151-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-152-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-153-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-154-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-155d-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-156c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-157-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-158-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-159-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-15b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-16-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-160-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-166a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-167a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-168a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-169a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-17-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-170d-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-171-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-172b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-173b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-174b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-175c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-176-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-177b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-178-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-179a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-180a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-181-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-182-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-183-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184d-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184e-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-184f-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-18c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-2-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-20-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-21c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-22-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-25-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-27b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-28b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-29b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-30-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-31-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-32-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-33-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-34-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-35-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-36-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-37-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-38-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-3a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-4-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-41a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-42a-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-43b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-44d-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-45c-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-46b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-47-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-48-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-49-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-5-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-50-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-51-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-52-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-53-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-54-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-55-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-56-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-57b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-59-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-6-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-60-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-61-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-62-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-63-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-65-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-66b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-67-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-70-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-72b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-73b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-74b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-75b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-76b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-77b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-78b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-79-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-7b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-8-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-80-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-81b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-82b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-83-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-86-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-87b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-88b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-89-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-9-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-90b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-91-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-92-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-93-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-94b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-95-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-95-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-96b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-97b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-98b-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-99b-expected.png: Removed.
platform/chromium/test_expectations.txt:

Mar 25, 2012:

11:44 PM Changeset in webkit [112055] by hayato@chromium.org

27 edits
4 adds in trunk

[Shadow DOM] Add Reified DOM Tree traversal internal APIs.
https://bugs.webkit.org/show_bug.cgi?id=79197

Reviewed by Dimitri Glazkov.

Add internal APIs which can be used to traverse Reified DOM tree, which is
a result of node distribution algorithm explained in Shadow DOM spec.
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html

Every public functions defined in ReifiedTreeTraversal are static
functions and are named in a similar way to ones defined in WebCore::Node class.
The only difference is that ReifiedTreeTraversal APIs consider shadow
hosts and also traverse nodes is Shadow DOM subtrees, crossing shadow's upper and lower boundary
transparently.

There is no actual client which uses these APIs. Follow-up patches for FocusNavigation
and EventDispatcher will use the APIs so that they can traverse node in reified tree order.

Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/shadow/reified-tree-traversal.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/ReifiedTreeTraversal.cpp: Added.

(WebCore):
(WebCore::isShadowHost):
(WebCore::shadowTreeFor):
(WebCore::shadowTreeOfParent):
(WebCore::ReifiedTreeTraversal::firstChild):
(WebCore::ReifiedTreeTraversal::lastChild):
(WebCore::ReifiedTreeTraversal::lastChildWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::traverseChild):
(WebCore::ReifiedTreeTraversal::traverseLightChildren):
(WebCore::ReifiedTreeTraversal::traverseNode):
(WebCore::ReifiedTreeTraversal::nextSibling):
(WebCore::ReifiedTreeTraversal::previousSibling):
(WebCore::ReifiedTreeTraversal::traverseSiblingOrBackToInsertionPoint):
(WebCore::ReifiedTreeTraversal::traverseSiblingInCurrentTree):
(WebCore::ReifiedTreeTraversal::traverseSiblingOrBackToYoungerShadowRoot):
(WebCore::ReifiedTreeTraversal::escapeFallbackContentElement):
(WebCore::ReifiedTreeTraversal::traverseNodeEscapingFallbackContents):
(WebCore::ReifiedTreeTraversal::parentNode):
(WebCore::ReifiedTreeTraversal::parentNodeWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::parentNodeOrBackToInsertionPoint):
(WebCore::ReifiedTreeTraversal::parentNodeInCurrentTree):
(WebCore::ReifiedTreeTraversal::parentNodeBackToYoungerShadowRootOrHost):
(WebCore::ReifiedTreeTraversal::adjustedParentNode):
(WebCore::ReifiedTreeTraversal::traverseNextNode):
(WebCore::ReifiedTreeTraversal::traverseNextNodeWithoutCrossingUpperBoundary):
(WebCore::ReifiedTreeTraversal::traversePreviousNode):
(WebCore::ReifiedTreeTraversal::traversePreviousNodeWithoutCrossingUpperBoundary):

dom/ReifiedTreeTraversal.h: Added.

(WebCore):
(ReifiedTreeTraversal):

dom/ShadowTree.cpp:

(WebCore::ShadowTree::insertionPointFor):
(WebCore::ShadowTree::selectionFor):
(WebCore):

dom/ShadowTree.h:

(WebCore):
(ShadowTree):

html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::findFor):

html/shadow/HTMLContentSelector.h:

(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):

html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore::toInsertionPoint):
(WebCore):

testing/Internals.cpp:

(WebCore::Internals::nextSiblingInReifiedTree):
(WebCore):
(WebCore::Internals::firstChildInReifiedTree):
(WebCore::Internals::lastChildInReifiedTree):
(WebCore::Internals::traverseNextNodeInReifiedTree):
(WebCore::Internals::traversePreviousNodeInReifiedTree):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

fast/dom/shadow/reified-tree-traversal-expected.txt: Added.
fast/dom/shadow/reified-tree-traversal.html: Added.
platform/efl/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

11:20 PM Changeset in webkit [112054] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] unexpected result in fast/js/large-expressions.html
https://bugs.webkit.org/show_bug.cgi?id=76379

platform/qt/Skipped: Skip it until proper fix.

11:17 PM Changeset in webkit [112053] by commit-queue@webkit.org

3 edits
2 adds in trunk

Web Inspector: Indenting fully selected line should not indent the line next to it
https://bugs.webkit.org/show_bug.cgi?id=81758

Source/WebCore:

In the editor, you can select a whole line by moving caret at 0 column
position and pressing Shift + Arrow Down/Up. After that, pressing Tab
indents 2 lines: fully selected one and the line next to it. The patch
changes this behaviour to indent only fully selected line since that is
what pretty-match all the other code editors do.

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-03-25
Reviewed by Pavel Feldman.

Test: inspector/editor/indentation.html

inspector/front-end/TextViewer.js:

(WebInspector.TextEditorMainPanel.prototype._indentLines):

Do not insert indent at the begging of the last line if a selection
ends on its 0 column.

(WebInspector.TextEditorMainPanel.prototype._unindentLines):

Do not remove indent at the begging of the last line if a selection
ends on its 0 column.

LayoutTests:

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-03-25
Reviewed by Pavel Feldman.

inspector/editor/indentation-expected.txt: Added.
inspector/editor/indentation.html: Added.

11:12 PM Changeset in webkit [112052] by Csaba Osztrogonác

1 edit
1 move in trunk/LayoutTests

[Qt] Unreviewed morning gardening after r112023.

platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Removed unnecessary Qt specific txt.
platform/qt/fast/dom/xml-parser-error-message-crash-expected.txt: Updated.

11:11 PM Changeset in webkit [112051] by inferno@chromium.org

4 edits
2 adds in trunk

Crash in ContainerNode::resumePostAttachCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=82159

Reviewed by Hajime Morita.

Source/WebCore:

Test: plugins/object-onfocus-mutation-crash.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::resumePostAttachCallbacks): dispatching post attach
callbacks when our attach depth is 1 can fire mutation events such as onfocus
which can blow away |this|. Need to protect it with a RefPtr.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::attach): add calls to suspend attach callbacks
until the function completes.

LayoutTests:

plugins/object-onfocus-mutation-crash-expected.txt: Added.
plugins/object-onfocus-mutation-crash.html: Added.

11:04 PM Changeset in webkit [112050] by Csaba Osztrogonác

4 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening after r112022.

platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
platform/qt/svg/zoom/text/zoom-foreignObject-expected.png: Added.
platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:

11:02 PM Changeset in webkit [112049] by commit-queue@webkit.org

6 edits in trunk/Source

[chromium] Layers with animating transforms should prepaint even if they are not visible yet
https://bugs.webkit.org/show_bug.cgi?id=82117

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-25
Reviewed by Adrienne Walker.

Source/WebCore:

For animating transforms, instead of early-outing when the layer's
visible rect is empty, let it prepaint regardless.

For now, we just only paint the outermost tiles, and only for small
layers, with at most 9 tiles.

This changes the behaviour of ContentLayerChromium's
idlePaintContentsIfDirty() so I've guarded the behaviour of the two
prepainting functions that it calls to ensure the old behaviour holds
without animations, and the new behaviour works with them.

Unit test: TiledLayerChromiumTest.idlePaintZeroSizedLayer

TiledLayerChromiumTest.idlePaintZeroSizedAnimatingLayer
TiledLayerChromiumTest.idlePaintNonVisibleLayers
TiledLayerChromiumTest.idlePaintNonVisibleAnimatingLayers

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::numPaintedTiles):
(TiledLayerChromium):

Source/WebKit/chromium:

tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::tileSize):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):
(WTF::idlePaintRepeat):
(WTF::testHaveOuterTiles):

10:47 PM Changeset in webkit [112048] by kevino@webkit.org

7 edits
1 add in trunk

[wx] Unreviewed build fix. Move WTF to its own static lib build.

10:37 PM Changeset in webkit [112047] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing tests, decrease test coverage.

platform/qt-5.0-wk2/Skipped: Skip new failing tests - https://bugs.webkit.org/show_bug.cgi?id=82167
platform/qt/Skipped: Skip a new failing test because ENABLE(MUTATION_OBSERVERS) is disabled.

9:46 PM Changeset in webkit [112046] by kubo@profusion.mobi

213 edits
6 copies
2 adds in trunk/LayoutTests

[EFL] More gardening. Update baselines and expectations in
fast/table and fast/text after the recent jhbuild and font
updates.

platform/efl/fast/table/002-expected.png:
platform/efl/fast/table/003-expected.png:
platform/efl/fast/table/003-expected.txt:
platform/efl/fast/table/004-expected.png:
platform/efl/fast/table/005-expected.png:
platform/efl/fast/table/007-expected.png:
platform/efl/fast/table/009-expected.png:
platform/efl/fast/table/012-expected.png:
platform/efl/fast/table/016-expected.png:
platform/efl/fast/table/017-expected.png:
platform/efl/fast/table/018-expected.png:
platform/efl/fast/table/020-expected.png:
platform/efl/fast/table/023-expected.png:
platform/efl/fast/table/025-expected.png:
platform/efl/fast/table/028-expected.png:
platform/efl/fast/table/028-vertical-expected.png:
platform/efl/fast/table/030-expected.png:
platform/efl/fast/table/035-expected.png:
platform/efl/fast/table/035-vertical-expected.png:
platform/efl/fast/table/036-expected.png:
platform/efl/fast/table/038-expected.png:
platform/efl/fast/table/038-vertical-expected.png:
platform/efl/fast/table/039-expected.png:
platform/efl/fast/table/041-expected.png:
platform/efl/fast/table/100-percent-cell-width-expected.png:
platform/efl/fast/table/add-before-anonymous-child-expected.png:
platform/efl/fast/table/append-cells-expected.png:
platform/efl/fast/table/append-cells2-expected.png:
platform/efl/fast/table/auto-with-percent-height-expected.png:
platform/efl/fast/table/auto-with-percent-height-vertical-expected.png:
platform/efl/fast/table/border-collapsing/001-expected.png:
platform/efl/fast/table/border-collapsing/001-vertical-expected.png:
platform/efl/fast/table/border-collapsing/002-expected.png:
platform/efl/fast/table/border-collapsing/002-vertical-expected.png:
platform/efl/fast/table/border-collapsing/003-expected.png:
platform/efl/fast/table/border-collapsing/003-vertical-expected.png:
platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
platform/efl/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
platform/efl/fast/table/cell-absolute-child-expected.png:
platform/efl/fast/table/cell-pref-width-invalidation-expected.txt:
platform/efl/fast/table/cell-width-auto-expected.png:
platform/efl/fast/table/cellindex-expected.png:
platform/efl/fast/table/colgroup-preceded-by-caption-expected.png:
platform/efl/fast/table/colgroup-spanning-groups-rules-expected.png:
platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
platform/efl/fast/table/dynamic-cellpadding-expected.png:
platform/efl/fast/table/dynamic-descendant-percentage-height-expected.png:
platform/efl/fast/table/early-table-layout-expected.png:
platform/efl/fast/table/edge-offsets-expected.png:
platform/efl/fast/table/fixed-nested-expected.png:
platform/efl/fast/table/fixed-table-non-cell-in-row-expected.png:
platform/efl/fast/table/fixed-table-with-percent-inside-percent-table-expected.png:
platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png:
platform/efl/fast/table/fixed-table-with-percent-width-inside-div-expected.png:
platform/efl/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png:
platform/efl/fast/table/fixed-table-with-small-percent-width-expected.png:
platform/efl/fast/table/floating-th-expected.png:
platform/efl/fast/table/form-with-table-style-expected.png:
platform/efl/fast/table/generated-caption-expected.png:
platform/efl/fast/table/giantRowspan2-expected.png:
platform/efl/fast/table/height-percent-test-expected.png:
platform/efl/fast/table/insert-before-anonymous-ancestors-expected.png:
platform/efl/fast/table/insert-cell-before-form-expected.png:
platform/efl/fast/table/insert-row-before-form-expected.png:
platform/efl/fast/table/invisible-cell-background-expected.png:
platform/efl/fast/table/large-width-expected.png:
platform/efl/fast/table/max-width-integer-overflow-expected.txt:
platform/efl/fast/table/nobr-expected.png:
platform/efl/fast/table/overflowHidden-expected.png:
platform/efl/fast/table/overflowHidden-expected.txt:
platform/efl/fast/table/percent-heights-expected.png:
platform/efl/fast/table/relative-position-containment-expected.png:
platform/efl/fast/table/remove-td-display-none-expected.png:
platform/efl/fast/table/row-height-recalc-expected.png:
platform/efl/fast/table/rowindex-expected.png:
platform/efl/fast/table/rowspan-paint-order-vertical-expected.png:
platform/efl/fast/table/rtl-cell-display-none-assert-expected.png:
platform/efl/fast/table/rules-attr-dynchange1-expected.png:
platform/efl/fast/table/rules-attr-dynchange2-expected.png:
platform/efl/fast/table/spanOverlapRepaint-expected.png:
platform/efl/fast/table/table-after-child-in-table-expected.png:
platform/efl/fast/table/table-and-parts-outline-expected.png:
platform/efl/fast/table/table-before-child-in-table-expected.png:
platform/efl/fast/table/table-before-child-style-update-expected.png: Copied from LayoutTests/platform/efl/fast/text/whitespace/014-expected.png.
platform/efl/fast/table/table-cell-after-child-in-block-expected.png:
platform/efl/fast/table/table-cell-before-child-in-block-expected.png:
platform/efl/fast/table/table-cell-before-child-in-table-expected.png:
platform/efl/fast/table/table-display-types-expected.png:
platform/efl/fast/table/table-display-types-strict-expected.png:
platform/efl/fast/table/table-display-types-vertical-expected.png:
platform/efl/fast/table/table-hspace-align-center-expected.png:
platform/efl/fast/table/table-row-after-child-in-block-expected.png:
platform/efl/fast/table/table-row-before-child-in-block-expected.png:
platform/efl/fast/table/table-row-before-child-in-table-expected.png:
platform/efl/fast/table/table-row-before-child-style-update-expected.png: Copied from LayoutTests/platform/efl/fast/text/whitespace/014-expected.png.
platform/efl/fast/table/table-row-style-not-updated-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png.
platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png: Copied from LayoutTests/platform/efl/fast/table/height-percent-test-expected.png.
platform/efl/fast/table/table-style-not-updated-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png.
platform/efl/fast/table/text-field-baseline-expected.png:
platform/efl/fast/table/text-field-baseline-expected.txt:
platform/efl/fast/table/unbreakable-images-quirk-expected.png:
platform/efl/fast/table/unused-percent-heights-expected.png:
platform/efl/fast/table/vertical-align-baseline-expected.png:
platform/efl/fast/text/atsui-kerning-and-ligatures-expected.png:
platform/efl/fast/text/atsui-multiple-renderers-expected.png:
platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
platform/efl/fast/text/atsui-partial-selection-expected.png:
platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png:
platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png:
platform/efl/fast/text/atsui-spacing-features-expected.png:
platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
platform/efl/fast/text/backslash-to-yen-sign-expected.png:
platform/efl/fast/text/basic/001-expected.png:
platform/efl/fast/text/basic/002-expected.png:
platform/efl/fast/text/basic/003-expected.png:
platform/efl/fast/text/basic/004-expected.png:
platform/efl/fast/text/basic/006-expected.png:
platform/efl/fast/text/basic/007-expected.png:
platform/efl/fast/text/basic/008-expected.png:
platform/efl/fast/text/basic/012-expected.png:
platform/efl/fast/text/basic/014-expected.png:
platform/efl/fast/text/basic/015-expected.png:
platform/efl/fast/text/basic/generic-family-changes-expected.png:
platform/efl/fast/text/basic/generic-family-reset-expected.png:
platform/efl/fast/text/break-word-expected.png:
platform/efl/fast/text/capitalize-empty-generated-string-expected.png:
platform/efl/fast/text/capitalize-preserve-nbsp-expected.png:
platform/efl/fast/text/cg-vs-atsui-expected.png:
platform/efl/fast/text/decorations-transformed-expected.png:
platform/efl/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
platform/efl/fast/text/emphasis-avoid-ruby-expected.png:
platform/efl/fast/text/emphasis-overlap-expected.png:
platform/efl/fast/text/fake-italic-expected.png:
platform/efl/fast/text/hyphenate-character-expected.png:
platform/efl/fast/text/hyphenate-limit-before-after-expected.png:
platform/efl/fast/text/hyphenate-limit-lines-expected.png:
platform/efl/fast/text/justified-selection-at-edge-expected.png:
platform/efl/fast/text/justified-selection-expected.png:
platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
platform/efl/fast/text/justify-padding-distribution-expected.png: Added.
platform/efl/fast/text/line-breaks-after-white-space-expected.png:
platform/efl/fast/text/line-breaks-expected.png:
platform/efl/fast/text/monospace-width-cache-expected.png:
platform/efl/fast/text/reset-emptyRun-expected.png:
platform/efl/fast/text/selection-hard-linebreak-expected.png:
platform/efl/fast/text/shadow-translucent-fill-expected.png:
platform/efl/fast/text/should-use-atsui-expected.png:
platform/efl/fast/text/soft-hyphen-4-expected.png: Copied from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-inside-percent-table-expected.png.
platform/efl/fast/text/softHyphen-expected.png:
platform/efl/fast/text/text-letter-spacing-expected.png:
platform/efl/fast/text/textIteratorNilRenderer-expected.png:
platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
platform/efl/fast/text/wbr-expected.png:
platform/efl/fast/text/wbr-in-pre-crash-expected.png:
platform/efl/fast/text/whitespace/002-expected.png:
platform/efl/fast/text/whitespace/002-expected.txt:
platform/efl/fast/text/whitespace/003-expected.png:
platform/efl/fast/text/whitespace/003-expected.txt:
platform/efl/fast/text/whitespace/004-expected.png:
platform/efl/fast/text/whitespace/004-expected.txt:
platform/efl/fast/text/whitespace/005-expected.png:
platform/efl/fast/text/whitespace/005-expected.txt:
platform/efl/fast/text/whitespace/006-expected.png:
platform/efl/fast/text/whitespace/006-expected.txt:
platform/efl/fast/text/whitespace/007-expected.png:
platform/efl/fast/text/whitespace/007-expected.txt:
platform/efl/fast/text/whitespace/008-expected.png:
platform/efl/fast/text/whitespace/008-expected.txt:
platform/efl/fast/text/whitespace/009-expected.png:
platform/efl/fast/text/whitespace/009-expected.txt:
platform/efl/fast/text/whitespace/010-expected.png:
platform/efl/fast/text/whitespace/010-expected.txt:
platform/efl/fast/text/whitespace/011-expected.png:
platform/efl/fast/text/whitespace/011-expected.txt:
platform/efl/fast/text/whitespace/012-expected.png:
platform/efl/fast/text/whitespace/012-expected.txt:
platform/efl/fast/text/whitespace/013-expected.png:
platform/efl/fast/text/whitespace/013-expected.txt:
platform/efl/fast/text/whitespace/014-expected.png:
platform/efl/fast/text/whitespace/014-expected.txt:
platform/efl/fast/text/whitespace/015-expected.png:
platform/efl/fast/text/whitespace/015-expected.txt:
platform/efl/fast/text/whitespace/016-expected.png:
platform/efl/fast/text/whitespace/016-expected.txt:
platform/efl/fast/text/whitespace/018-expected.png:
platform/efl/fast/text/whitespace/018-expected.txt:
platform/efl/fast/text/whitespace/020-expected.png:
platform/efl/fast/text/whitespace/020-expected.txt:
platform/efl/fast/text/whitespace/021-expected.png:
platform/efl/fast/text/whitespace/021-expected.txt:
platform/efl/fast/text/whitespace/022-expected.png:
platform/efl/fast/text/whitespace/025-expected.png:
platform/efl/fast/text/whitespace/025-expected.txt:
platform/efl/fast/text/whitespace/027-expected.png:
platform/efl/fast/text/whitespace/027-expected.txt:
platform/efl/fast/text/whitespace/030-expected.png:
platform/efl/fast/text/whitespace/030-expected.txt:
platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
platform/efl/fast/text/whitespace/pre-break-word-expected.png:
platform/efl/fast/text/whitespace/pre-break-word-expected.txt:
platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.txt:
platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.txt:
platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
platform/efl/fast/text/whitespace/tab-character-basics-expected.png:
platform/efl/fast/text/wide-zero-width-space-expected.png:
platform/efl/fast/text/word-break-expected.png:
platform/efl/fast/text/word-break-run-rounding-expected.png:
platform/efl/fast/text/word-break-soft-hyphen-expected.png:
platform/efl/fast/text/word-space-expected.png:

9:08 PM Changeset in webkit [112045] by kubo@profusion.mobi

2 edits
2 adds in trunk/LayoutTests

[EFL] Unreviewed gardening, add some baselines and skip a few
tests in fast/events.

platform/efl/Skipped:
platform/efl/fast/events/resize-events-expected.png: Added.
platform/efl/fast/events/resize-events-expected.txt: Added.

7:33 PM Changeset in webkit [112044] by kubo@profusion.mobi

14 edits
1 add in trunk/LayoutTests

[EFL] Unreviewed gardening, update baselines in editing/, media/
and scrollbars/.

platform/efl/editing/unsupported-content/table-type-after-expected.png:
platform/efl/editing/unsupported-content/table-type-before-expected.png:
platform/efl/media/controls-layout-direction-expected.png: Added.
platform/efl/media/media-controls-clone-expected.png:
platform/efl/media/media-controls-clone-expected.txt:
platform/efl/media/video-empty-source-expected.png:
platform/efl/media/video-empty-source-expected.txt:
platform/efl/media/video-zoom-controls-expected.png:
platform/efl/media/video-zoom-controls-expected.txt:
platform/efl/scrollbars/basic-scrollbar-expected.png:
platform/efl/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
platform/efl/scrollbars/disabled-scrollbar-expected.png:
platform/efl/scrollbars/scrollbar-buttons-expected.png:
platform/efl/scrollbars/scrollbar-orientation-expected.png:

7:17 PM Changeset in webkit [112043] by kubo@profusion.mobi

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Update baseline in animations/ after
the recent jhbuild/fonts updates.

platform/efl/animations/state-at-end-event-expected.png:

7:09 PM Changeset in webkit [112042] by kubo@profusion.mobi

7 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Update some fonts/ baselines after the
recent jhbuild/fonts updates.

platform/efl/fonts/cursive-expected.png:
platform/efl/fonts/default-expected.png:
platform/efl/fonts/fantasy-expected.png:
platform/efl/fonts/monospace-expected.png:
platform/efl/fonts/sans-serif-expected.png:
platform/efl/fonts/serif-expected.png:

5:57 PM Changeset in webkit [112041] by kubo@profusion.mobi

3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Update some tables/layering/ baselines.

platform/efl/tables/layering/paint-test-layering-1-expected.png:
platform/efl/tables/layering/paint-test-layering-2-expected.png:

4:50 PM Changeset in webkit [112040] by fpizlo@apple.com

14 edits
1 add in trunk/Source/JavaScriptCore

DFG int-to-double conversion should be revealed to CSE
https://bugs.webkit.org/show_bug.cgi?id=82135

Reviewed by Oliver Hunt.

This introduces the notion of an Int32ToDouble node, which is injected
into the graph anytime we know that we have a double use of a node that
was predicted integer. The Int32ToDouble simplifies double speculation
on integers by skipping the path that would unbox doubles, if we know
that the value is already proven to be an integer. It allows integer to
double conversions to be subjected to common subexpression elimination
(CSE) by allowing the CSE phase to see where these conversions are
occurring. Finally, it allows us to see when a constant is being used
as both a double and an integer. This is a bit odd, since it means that
sometimes a double use of a constant will not refer directly to the
constant. This should not cause problems, for now, but it may require
some canonizalization in the future if we want to support strength
reductions of double operations based on constants.

To allow injection of nodes into the graph, this change introduces the
DFG::InsertionSet, which is a way of lazily inserting elements into a
list. This allows the FixupPhase to remain O(N) despite performing
multiple injections in a single basic block. Without the InsertionSet,
each injection would require performing an insertion into a vector,
which is O(N), leading to O(N^{2) performance overall. With the

InsertionSet, each injection simply records what insertion would have

been performed, and all insertions are performed at once (via

InsertionSet::execute) after processing of a basic block is completed.}

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/PredictedType.h:

(JSC::isActionableIntMutableArrayPrediction):
(JSC):
(JSC::isActionableFloatMutableArrayPrediction):
(JSC::isActionableTypedMutableArrayPrediction):
(JSC::isActionableMutableArrayPrediction):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCommon.h:

(JSC::DFG::useKindToString):
(DFG):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupBlock):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGInsertionSet.h: Added.

(DFG):
(Insertion):
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::index):
(JSC::DFG::Insertion::element):
(InsertionSet):
(JSC::DFG::InsertionSet::InsertionSet):
(JSC::DFG::InsertionSet::append):
(JSC::DFG::InsertionSet::execute):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(DFG):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:35 PM Changeset in webkit [112039] by fpizlo@apple.com

8 edits
1 move in trunk/Source/JavaScriptCore

DFGOperands should be moved out of the DFG and into bytecode
https://bugs.webkit.org/show_bug.cgi?id=82151

Reviewed by Dan Bernstein.

GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Operands.h: Copied from Source/JavaScriptCore/dfg/DFGOperands.h.
dfg/DFGBasicBlock.h:
dfg/DFGNode.h:
dfg/DFGOSREntry.h:
dfg/DFGOSRExit.h:
dfg/DFGOperands.h: Removed.
dfg/DFGVariableAccessData.h:

2:47 PM Changeset in webkit [112038] by Antti Koivisto

3 edits in trunk/LayoutTests

Don't use CSSRuleList for child rule ownership
https://bugs.webkit.org/show_bug.cgi?id=82127

Reviewed by Andreas Kling.

Update for the new CSSStyleSheet.cssRules uniqueness behavior.

fast/dom/gc-9-expected.txt:
fast/dom/gc-9.html:

1:58 PM Changeset in webkit [112037] by Antti Koivisto

19 edits in trunk/Source/WebCore

Don't use CSSRuleList for child rule ownership
https://bugs.webkit.org/show_bug.cgi?id=82127

Reviewed by Andreas Kling.

CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule use CSSRuleList for storing children.
They should use a simple rule vector instead. CSSRuleList is a CSSOM type that should be
instantiated on-demand for API purposes only.

Use Vector<RefPtr<CSSRule>> for storing the rule children of CSSMediaRule, WebKitCSSKeyframesRule and WebKitRegionRule.
Add direct accessors, use internally instead of CSSRuleList.
Make CSSRuleList an abstract base. Add concrete subclasses for dealing with the underlying storage.
Instantiate CSSRuleLists on-demand.
Make CSSStyleSheet.cssRules always return the same object instance. This matches Firefox and the rest of our CSSOM implementation. Tested by fast/dom/gc-9.html.

The patch decouples internals from the external API. It simplifies the child rule ownership and reduces
indirection. Memory use of css rules with children is reduced (by a ptr, refcount and heap allocation overhead).

css/CSSGrammar.y:
css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::cssText):
(WebCore::CSSMediaRule::cssRules):

css/CSSMediaRule.h:

(WebCore::CSSMediaRule::create):
(CSSMediaRule):
(WebCore::CSSMediaRule::ruleCount):
(WebCore::CSSMediaRule::ruleAt):

css/CSSParser.cpp:

(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createRuleList):
(WebCore::CSSParser::createRegionRule):

css/CSSParser.h:

(WebCore):

css/CSSRuleList.cpp:

(WebCore):
(WebCore::StaticCSSRuleList::StaticCSSRuleList):
(WebCore::StaticCSSRuleList::~StaticCSSRuleList):
(WebCore::StaticCSSRuleList::deref):
(WebCore::StaticCSSRuleList::item):

css/CSSRuleList.h:

(CSSRuleList):

Turn CSSRuleList into abstract interface.

(StaticCSSRuleList):
(WebCore::StaticCSSRuleList::create):
(WebCore::StaticCSSRuleList::ref):
(WebCore::StaticCSSRuleList::rules):
(WebCore::StaticCSSRuleList::styleSheet):
(WebCore::StaticCSSRuleList::length):

Concrete implementation for fixed list of rules.

(WebCore):
(LiveCSSRuleList):
(WebCore::LiveCSSRuleList::LiveCSSRuleList):
(WebCore::LiveCSSRuleList::ref):
(WebCore::LiveCSSRuleList::deref):
(WebCore::LiveCSSRuleList::length):
(WebCore::LiveCSSRuleList::item):
(WebCore::LiveCSSRuleList::styleSheet):

Concrete implemenation for live list backed by the underlying container rule.
LiveCSSRuleList is owned by the underlying rule. Refcount is forwarded.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

css/CSSStyleSelector.h:

(CSSStyleSelector):

css/CSSStyleSheet.cpp:

The same scheme for CSSStyleSheet.cssRule as with container rules.

(StyleSheetCSSRuleList):
(WebCore::StyleSheetCSSRuleList::StyleSheetCSSRuleList):
(WebCore::StyleSheetCSSRuleList::ref):
(WebCore::StyleSheetCSSRuleList::deref):
(WebCore::StyleSheetCSSRuleList::length):
(WebCore::StyleSheetCSSRuleList::item):
(WebCore::StyleSheetCSSRuleList::styleSheet):
(WebCore):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::cssRules):

css/CSSStyleSheet.h:

(CSSStyleSheet):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore):
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::findRuleIndex):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore::WebKitCSSKeyframesRule::cssRules):

css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::ruleCount):
(WebCore::WebKitCSSKeyframesRule::ruleAt):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):

css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
(WebCore::WebKitCSSRegionRule::cssRules):

css/WebKitCSSRegionRule.h:
inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):

1:00 PM Changeset in webkit [112036] by haraken@chromium.org

7 edits in trunk/Source/WebCore

Remove duplicated GenerateConditionalString() from code generators
https://bugs.webkit.org/show_bug.cgi?id=82148

Reviewed by Adam Barth.

Previously GenerateConditionalString()s were defined in each code generator,
and they were doing the same thing. This patch puts GenerateConditionalString()
in CodeGenerator.pm and removes duplicated GenerateConditionalString()s.

No tests. No change in the generated code.

bindings/scripts/CodeGenerator.pm:

(GenerateConditionalString):

bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateProperties):
(GenerateFunction):
(WriteData):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):

bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateBatchedAttributeData):
(GenerateImplementation):
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):

12:51 PM Changeset in webkit [112035] by haraken@chromium.org

9 edits
6 moves in trunk/Source/WebCore

Move DOMWindowSQLDatabase.* to DOMWindowWebDatabase.*, and move WorkerContextSQLDatabase.* to WorkerContextWebDatabase.*
https://bugs.webkit.org/show_bug.cgi?id=82146

Reviewed by Adam Barth.

Now SQLDatabase is renamed to WebDatabase (See Modules/webdatabase/).
We should move DOMWindowSQLDatabase.* to DOMWindowWebDatabase.*,
and move WorkerContextSQLDatabase.* to WorkerContextWebDatabase.*.
We'll rename the SQL_DATABASE flag to the WEB_DATABASE flag in a follow-up patch.

No tests. No change in behavior.

Modules/webdatabase/DOMWindowWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.cpp.

(WebCore):
(WebCore::DOMWindowWebDatabase::openDatabase):

Modules/webdatabase/DOMWindowWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.h.

(WebCore):
(DOMWindowWebDatabase):
(WebCore::DOMWindowWebDatabase::DOMWindowWebDatabase):
(WebCore::DOMWindowWebDatabase::~DOMWindowWebDatabase):

Modules/webdatabase/DOMWindowWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/DOMWindowSQLDatabase.idl.
Modules/webdatabase/WorkerContextWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.cpp.

(WebCore):
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):

Modules/webdatabase/WorkerContextWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.h.

(WebCore):
(WorkerContextWebDatabase):
(WebCore::WorkerContextWebDatabase::WorkerContextWebDatabase):
(WebCore::WorkerContextWebDatabase::~WorkerContextWebDatabase):

Modules/webdatabase/WorkerContextWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextSQLDatabase.idl.

DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

12:47 PM Changeset in webkit [112034] by kevino@webkit.org

2 edits in trunk/Source/WebKit/wx

[wx] Unreviewed build fix. Add header needed for Unix builds.

12:19 PM Changeset in webkit [112033] by ahf@0x90.dk

3 edits in trunk/Source/WebKit2

Unreviewed build fix for QtWebKit on Mac OS X.

UIProcess/API/qt/tests/bytearraytestdata.cpp:

(ByteArrayTestData::~ByteArrayTestData):

UIProcess/API/qt/tests/bytearraytestdata.h:

12:14 PM Changeset in webkit [112032] by pfeldman@chromium.org

4 edits
2 moves
4 deletes in trunk/LayoutTests

Not reviewed: fixing Chromium Win7 baselines for editing/selection tests.

platform/chromium-mac/editing/selection/selection-button-text-expected.txt: Removed.
platform/chromium-win-vista/editing/selection/3690703-2-expected.png: Removed.
platform/chromium-win-vista/editing/selection/3690703-expected.png: Removed.
platform/chromium-win-vista/editing/selection/3690719-expected.png: Removed.
platform/chromium-win/editing/selection/3690703-2-expected.png:
platform/chromium-win/editing/selection/3690703-expected.png:
platform/chromium-win/editing/selection/3690719-expected.png:
platform/chromium-win/editing/selection/selection-button-text-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.png.
platform/chromium-win/editing/selection/selection-button-text-expected.txt: Renamed from LayoutTests/platform/chromium-win-vista/editing/selection/selection-button-text-expected.txt.

12:07 PM Changeset in webkit [112031] by pfeldman@chromium.org

1 edit
1 add in trunk/LayoutTests

Not reviewed. Rebaseline chromium foreignObject results, after Nikolas's rebaselines.

platform/chromium-win/svg/zoom/page/zoom-foreign-content-expected.png: Added.

10:41 AM Changeset in webkit [112030] by schenney@chromium.org

5 edits
3 adds in trunk

Avoid race condition when iterating over pending resources
https://bugs.webkit.org/show_bug.cgi?id=82115

Patch by Philip Rogers <pdr@google.com> on 2012-03-25
Reviewed by Nikolas Zimmermann.

Source/WebCore:

We can hit a race condition in SVGStyledElement::buildPendingResourcesIfNeeded
where pending elements can become non-pending while we iterate over them.

This patch cleans up buildPendingResourcesIfNeeded and re-works how pending
resources are removed. Because pending resources can be modified while
iterating over them, we introduce m_pendingResourcesForRemoval that
holds pending resources that are marked for removal. Instead of iterating
over this list we simply remove each pending resource from
m_pendingResourcesForRemoval; if a pending resource is modified or removed
during the processing of another pending resource this list is updated before
the next element can be accessed.

This change also removes removePendingResourceForElement which is no longer
referenced.

Test: http/tests/svg/change-id-with-pending-resources.html

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):

svg/SVGDocumentExtensions.h:

(SVGDocumentExtensions):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):

LayoutTests:

http/tests/svg/change-id-with-pending-resources-expected.txt: Added.
http/tests/svg/change-id-with-pending-resources.html: Added.
http/tests/svg/resources/svg-use-defs-rect.svg: Added.

10:18 AM Changeset in webkit [112029] by Lucas Forschler

4 edits in trunk/Source

Versioning.

10:06 AM Changeset in webkit [112028] by Lucas Forschler

1 copy in tags/Safari-536.4

New Tag.

5:39 AM Changeset in webkit [112027] by Nikolas Zimmermann

7 edits in trunk/LayoutTests

2012-03-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline foreignObject results, after Florins changes.
Eventually the zoom-foreign-content-expected.png needs to be moved to platform/mac/, let's see.

platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
platform/mac/test_expectations.txt:
svg/zoom/page/zoom-foreign-content-expected.png:

5:16 AM Changeset in webkit [112026] by commit-queue@webkit.org

4 edits in trunk/Source

[BlackBerry] Accelerated compositing layers fail to render when using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=82104
RIM PR: 145963

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-25
Reviewed by Rob Buis.

Source/WebCore:

The embedder may use vertex buffers, which affected the interpretation
our vertex array pointers from memory pointers to offsets into a vertex
buffer. The resulting geometry often resulted in no visible layers on
screen.

Fixed by getting rid of any bound buffer when we enter
LayerRenderer::drawLayers().

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawLayers):

Source/WebKit/blackberry:

The root layer may be set before we have a layer renderer, because the
latter is not created until we get an OpenGL context from the embedder.

Fixed by setting the root layer on the layer renderer when it's created
instead of assuming a certain order of events.

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):

3:41 AM Changeset in webkit [112025] by pfeldman@chromium.org

1 edit
1 add in trunk/LayoutTests

Not reviewed: new chromium baseline for r112022.

platform/chromium-mac/svg/zoom/page/zoom-foreign-content-expected.png: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed