Timeline
Mar 31, 2012:
- 8:27 PM Changeset in webkit [112810] by
-
- 3 edits in tags/Safari-536.5.1/Source/WebCore
Merge r112809.
2012-03-31 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
- WebCore.vcproj/WebCore.make:
- 8:03 PM Changeset in webkit [112809] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix.
- WebCore.vcproj/WebCore.make:
- 6:18 PM Changeset in webkit [112808] by
-
- 5 edits in trunk/Source
Prevent opening external URLs in the Web Inspector's WebView.
All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView.
https://webkit.org/b/82812
rdar://problem/9488558
Reviewed by Joseph Pecoraro.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath.
(-[WebInspectorWindowController inspectorPagePath]): Added.
(-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added.
Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page.
Source/WebKit2:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::decidePolicyForNavigationAction): Added. Only allow non-main frame and the inspector page. All other URLs
will be opened in the inspected page.
(WebKit::WebInspectorProxy::createInspectorPage): Set the policy client and use decidePolicyForNavigationAction.
- UIProcess/WebInspectorProxy.h: Made inspectorPageURL and inspectorBaseURL public for decidePolicyForNavigationAction.
- 4:33 PM Changeset in webkit [112807] by
-
- 7 edits in trunk/Tools
Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
https://bugs.webkit.org/show_bug.cgi?id=82839
Reviewed by Adam Barth.
Also, update various hard-coded lists for WIN7 and Lion ports.
This is necessary since the new list of builders grabbed off the
buildbot includes Lion.
- TestResultServer/static-dashboards/builders.js:
(generateWebkitBuildersFromBuilderList):
(xhr.onreadystatechange):
Don't use dashboard_base's request method to avoid layering violation.
- TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):
(initBuilders):
(haveJsonFilesLoaded):
(g_handleBuildersListLoaded):
Block loading the JSON files for each builder until we actually have a list of builders.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testPlatformAndBuildType):
(testGenerateWebkitBuildersFromBuilderList):
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
Delay generating the page until the builder list has loaded.
- 4:09 PM Changeset in webkit [112806] by
-
- 2 edits in trunk/Source/WebCore
Fix complex strokes on CG platform
https://bugs.webkit.org/show_bug.cgi?id=80423
Patch by Philip Rogers <pdr@google.com> on 2012-03-31
Reviewed by Eric Seidel.
This change fixes a mistake in r112667 where the CG platform did not properly handle
complex strokes. The mistake was to check for complex fills instead of complex strokes,
which resulted in all complex strokes rendering as black.
No new tests, this change is covered by the following existing tests that were regressed:
1) svg/custom/gradient-stroke-width.svg
2) svg/custom/transform-with-shadow-and-gradient.svg
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformStrokeEllipse):
- 4:02 PM Changeset in webkit [112805] by
-
- 3 edits in trunk/Tools
If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799
Reviewed by Eric Seidel.
If we don't run a test, mark it as skipped.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._mark_interrupted_tests_as_skipped):
(Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
- 2:37 PM Changeset in webkit [112804] by
-
- 2 edits in trunk/Tools
One more build fix after r112781 for Chromium Windows.
Don't copy zip .idb files.
- BuildSlaveSupport/built-product-archive:
(copyBuildFiles):
- 2:17 PM Changeset in webkit [112803] by
-
- 3 edits2 adds in trunk
Don't insert linebreaks into text input fields.
https://bugs.webkit.org/show_bug.cgi?id=81660
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/forms/textfield-no-linebreak.html
- editing/TypingCommand.cpp:
(canAppendNewLineFeed): Only assume that a linefeed can be appended, if
after the BeforeTextInserted event the event text is still a newline.
LayoutTests:
- fast/forms/textfield-no-linebreak.html: Added.
- fast/forms/textfield-no-linebreak-expected.html: Added.
- 1:24 PM Changeset in webkit [112802] by
-
- 2 edits in trunk/Tools
Yet another build fix after r112781 for Chromium Windows.
Run webkit-build-directory by perl explicitly.
- BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectory):
- 1:03 PM Changeset in webkit [112801] by
-
- 2 edits in trunk/Source/WebKit2
32-bit plug-ins need to opt into magnified mode
https://bugs.webkit.org/show_bug.cgi?id=82837
<rdar://problem/9104840>
Reviewed by Simon Fraser.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
- 12:59 PM Changeset in webkit [112800] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
[GTK] [Stable] --disable geolocation broken after recent merges
https://bugs.webkit.org/show_bug.cgi?id=82452
No review, as this is just a build fix.
Fix the geolocation build.
- webkit/webkitgeolocationpolicydecision.cpp:
(webkit_geolocation_policy_decision_new): When gelocation is off, just return null.
- webkit/webkitgeolocationpolicydecisionprivate.h: Activate webkit_geolocation_policy_decision_new
for non-Geolocation builds.
- 12:13 PM Changeset in webkit [112799] by
-
- 7 edits in trunk
LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
https://bugs.webkit.org/show_bug.cgi?id=82469
Source/WebCore:
Fix regression from r112391. The test excerising this code path is skipped on Lion, due to a libxml2 bug.
I didn't notice I broke preserveAspectRatio parsing for many corner cases, revert to old logic.
- svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parse):
LayoutTests:
Reviewed by Dirk Schulze.
Unskip test, as the regression is fixed.
- platform/qt/Skipped:
- svg/custom/preserve-aspect-ratio-syntax.svg:
Remove one incorrect testcase (which was actually valid and thus doesn't result in a default pAR attribute value).
Can't rebaseline this on Mac Lion, as its skipped to a libxml2 bug, which will be addressed soon.
- svg/dom/preserve-aspect-ratio-parser-expected.txt:
- svg/dom/preserve-aspect-ratio-parser.html: Switch numbers to constants, so this test is actually readable.
- 11:02 AM Changeset in webkit [112798] by
-
- 15 edits in trunk/Source/WebCore
CSSStyleRules should own their CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=82832
Reviewed by Andreas Kling.
Move the rule properties CSSOM wrapper ownership from the StylePropertySet to the rule itself.
This is preparation for bug 82728 (Split remaining CSSRules into internal and CSSOM types). This
temporarily grows the size of CSSStyleRule by a pointer (82728 will give the memory back and more)
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
(WebCore):
(WebCore::CSSFontFaceRule::style):
- css/CSSFontFaceRule.h:
(WebCore):
(CSSFontFaceRule):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::style):
- css/CSSPageRule.h:
(WebCore):
(CSSPageRule):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::style):
- css/CSSStyleRule.h:
(WebCore):
(CSSStyleRule):
Make the rules own the property CSSOM wrapper.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::ref):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::deref):
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::StyleRuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::ref):
(WebCore::InlineCSSStyleDeclaration::deref):
- css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::clearParentRule):
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::parentRule):
- Rename RuleCSSStyleDeclaration -> StyleRuleCSSStyleDeclaration
- Make StyleRuleCSSStyleDeclaration use regular refcounting since it is no longer owned by the wrapped object.
- Rename hasCSSOMWrapper() -> isMutable(), m_hasCSSOMWrapper -> m_ownsCSSOMWrapper to match the purpose.
(InlineCSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentElement):
- css/StylePropertySet.h:
(StylePropertySet):
(WebCore::StylePropertySet::isMutable):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
- 10:48 AM Changeset in webkit [112797] by
-
- 2 edits in trunk/Tools
Fix the syntax error in master.cfg after r112734.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(unitTestsSupported):
- 7:14 AM Changeset in webkit [112796] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, remove suppressions due to the http://crrev.com/130034 revert.
- platform/chromium/test_expectations.txt:
- 7:09 AM Changeset in webkit [112795] by
-
- 1 edit2 adds in trunk/LayoutTests
Viewport-percentage Lengths: Layout test for vertical-align CSS property
https://bugs.webkit.org/show_bug.cgi?id=82811
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-31
Reviewed by Antti Koivisto.
Adding a layout test for vertical-align CSS property which takes Viewport-percentage length unit.
- css3/viewport-percentage-lengths/viewport-percentage-vertical-align-expected.html: Added.
- css3/viewport-percentage-lengths/viewport-percentage-vertical-align.html: Added.
- 6:34 AM Changeset in webkit [112794] by
-
- 5 edits3 adds in trunk
[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135
Patch by Jonathan Dong <Jonathan Dong> on 2012-03-31
Reviewed by Rob Buis.
.:
RIM PR: 145660
Added manual test for testing the behavior of http authentication
challenge dialog. Both of these two files should be served over http.
- ManualTests/blackberry/http-auth-challenge.html: Added.
- ManualTests/blackberry/http-auth-challenge.php: Added.
Source/WebCore:
RIM PR: 145660
Fixed a regression introduced by r111810, we should cancel the new
request when user press cancel button in http authentication challenge
dialog, and we should also allow sending empty username and password
with the request.
Also removed redundant codes which checked the existence of the
FrameLoaderClient pointer, as we've already moved authenticationChallenge()
out of class FrameLoaderClient, it is not needed.
Manual test added. Testing http authentication dialog relies on user interaction.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
Source/WebKit/blackberry:
RIM PR: 145660
Fixed a regression introduced by r111810, which used the wrong
credential object.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- 6:25 AM Changeset in webkit [112793] by
-
- 2 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed, update expectations for SNOWLEOPARD after r112755
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- 6:06 AM Changeset in webkit [112792] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Upstream BlackBerry change to PlatformTouchEvent and PlatformTouchPoint
https://bugs.webkit.org/show_bug.cgi?id=82828
Reviewed by Rob Buis.
No new tests, just upstream BlackBerry-specific change to
PlatformTouchEvent and PlatformTouchPoint, to make it build
for BlackBerry.
- platform/PlatformTouchEvent.h:
(Platform):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
(PlatformTouchEvent):
(WebCore::PlatformTouchEvent::rotation):
(WebCore::PlatformTouchEvent::scale):
(WebCore::PlatformTouchEvent::doubleTap):
(WebCore::PlatformTouchEvent::touchHold):
- platform/PlatformTouchPoint.h:
(Platform):
(PlatformTouchPoint):
- platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
- 6:00 AM Changeset in webkit [112791] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed, rebaseline test on LEOPARD after r112755
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Added.
- 5:37 AM Changeset in webkit [112790] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Refactor : NetworkJob::handleNotifyHeaderReceived.
https://bugs.webkit.org/show_bug.cgi?id=82825
We should use "else if" to decrease string's compare.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-31
Reviewed by Rob Buis.
No new tests. Refactor.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyHeaderReceived):
- 5:32 AM Changeset in webkit [112789] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream local change of PlatformKeyboardEventBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=82721
Reviewed by Rob Buis.
No new tests, just upstreaming the local change to make the upstreaming
build for BlackBerry.
- platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 4:59 AM Changeset in webkit [112788] by
-
- 3 edits2 adds in trunk
Crash in HTMLFieldSetElement::disabledAttributeChanged.
https://bugs.webkit.org/show_bug.cgi?id=82814
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/fieldset/fieldset-crash.html
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
LayoutTests:
- fast/forms/fieldset/fieldset-crash-expected.txt: Added.
- fast/forms/fieldset/fieldset-crash.html: Added.
- 4:46 AM Changeset in webkit [112787] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, suppress more failures after http://crrev.com/130034
- platform/chromium/test_expectations.txt:
- 4:00 AM Changeset in webkit [112786] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, avoid the need for pixel results (reported for Chromium) for tests added in r112769.
- svg/css/script-tests/svg-attribute-length-parsing.js:
- svg/css/script-tests/svg-attribute-parser-mode.js:
- 3:40 AM Changeset in webkit [112785] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, suppress failures after http://crrev.com/130034
- platform/chromium/test_expectations.txt:
- 12:44 AM Changeset in webkit [112784] by
-
- 8 edits24 copies7 moves15 adds1 delete in trunk/Source
[Chromium] Delete WebKit/chromium/bridge
https://bugs.webkit.org/show_bug.cgi?id=82677
Reviewed by James Robinson.
Source/Platform:
This patch moves all the MediaStream-related platform APIs from
WebKit/chromium/public/platform into Platform/chromium/public. This is
part of a larger project to more clearly separate the platform and
client portions of the Chromium WebKit API.
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createPeerConnectionHandler):
(WebKit::Platform::createPeerConnection00Handler):
(WebKit::Platform::createMediaStreamCenter):
- chromium/public/WebICECandidateDescriptor.h: Copied from Source/WebKit/chromium/public/platform/WebICECandidateDescriptor.h.
- chromium/public/WebICEOptions.h: Copied from Source/WebKit/chromium/public/platform/WebICEOptions.h.
- chromium/public/WebMediaHints.h: Copied from Source/WebKit/chromium/public/platform/WebMediaHints.h.
- chromium/public/WebMediaStreamCenter.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamCenter.h.
- chromium/public/WebMediaStreamCenterClient.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamCenterClient.h.
- chromium/public/WebMediaStreamComponent.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamComponent.h.
- chromium/public/WebMediaStreamDescriptor.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamDescriptor.h.
- chromium/public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamSource.h.
- chromium/public/WebMediaStreamSourcesRequest.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamSourcesRequest.h.
- chromium/public/WebPeerConnection00Handler.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnection00Handler.h.
- chromium/public/WebPeerConnection00HandlerClient.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnection00HandlerClient.h.
- chromium/public/WebPeerConnectionHandler.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnectionHandler.h.
(WebPeerConnectionHandler):
- chromium/public/WebPeerConnectionHandlerClient.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnectionHandlerClient.h.
- chromium/public/WebSessionDescriptionDescriptor.h: Copied from Source/WebKit/chromium/public/platform/WebSessionDescriptionDescriptor.h.
- chromium/public/WebVector.h: Copied from Source/WebKit/chromium/public/platform/WebVector.h.
Source/WebCore:
These files are just moved from the WebKit layer with their include
directives adjusted.
- WebCore.gypi:
- platform/chromium/support/WebICECandidateDescriptor.cpp: Copied from Source/WebKit/chromium/src/WebICECandidateDescriptor.cpp.
- platform/chromium/support/WebICEOptions.cpp: Copied from Source/WebKit/chromium/src/WebICEOptions.cpp.
- platform/chromium/support/WebMediaHints.cpp: Copied from Source/WebKit/chromium/src/WebMediaHints.cpp.
- platform/chromium/support/WebMediaStreamComponent.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamComponent.cpp.
- platform/chromium/support/WebMediaStreamDescriptor.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.
- platform/chromium/support/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamSource.cpp.
- platform/chromium/support/WebMediaStreamSourcesRequest.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamSourcesRequest.cpp.
- platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp: Copied from Source/WebKit/chromium/bridge/DeprecatedPeerConnectionHandler.cpp.
- platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp: Copied from Source/WebKit/chromium/bridge/DeprecatedPeerConnectionHandlerInternal.cpp.
(WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):
- platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h: Copied from Source/WebKit/chromium/bridge/DeprecatedPeerConnectionHandlerInternal.h.
- platform/mediastream/chromium/MediaStreamCenterChromium.cpp: Copied from Source/WebKit/chromium/bridge/MediaStreamCenter.cpp.
- platform/mediastream/chromium/MediaStreamCenterInternal.cpp: Copied from Source/WebKit/chromium/bridge/MediaStreamCenterInternal.cpp.
(WebCore::MediaStreamCenterInternal::MediaStreamCenterInternal):
- platform/mediastream/chromium/MediaStreamCenterInternal.h: Copied from Source/WebKit/chromium/bridge/MediaStreamCenterInternal.h.
- platform/mediastream/chromium/PeerConnection00Handler.cpp: Copied from Source/WebKit/chromium/bridge/PeerConnection00Handler.cpp.
- platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp: Copied from Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp.
(WebCore::PeerConnection00HandlerInternal::PeerConnection00HandlerInternal):
- platform/mediastream/chromium/PeerConnection00HandlerInternal.h: Copied from Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.h.
Source/WebKit/chromium:
Delete WebKit/chromium/bridge. This was a directory we were
experimenting with storing WebCore-namespaced code. Now we're able to
actually keep that code in WebCore itself, which is much more sensible.
- WebKit.gyp:
- bridge: Removed.
- bridge/DeprecatedPeerConnectionHandler.cpp: Removed.
- bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Removed.
- bridge/DeprecatedPeerConnectionHandlerInternal.h: Removed.
- bridge/MediaStreamCenter.cpp: Removed.
- bridge/MediaStreamCenterInternal.cpp: Removed.
- bridge/MediaStreamCenterInternal.h: Removed.
- bridge/PeerConnection00Handler.cpp: Removed.
- bridge/PeerConnection00HandlerInternal.cpp: Removed.
- bridge/PeerConnection00HandlerInternal.h: Removed.
- public/platform/WebICECandidateDescriptor.h: Replaced.
- public/platform/WebICEOptions.h: Replaced.
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
- public/platform/WebMediaHints.h: Replaced.
- public/platform/WebMediaStreamCenter.h: Replaced.
- public/platform/WebMediaStreamCenterClient.h: Replaced.
- public/platform/WebMediaStreamComponent.h: Replaced.
- public/platform/WebMediaStreamDescriptor.h: Replaced.
- public/platform/WebMediaStreamSource.h: Replaced.
- public/platform/WebMediaStreamSourcesRequest.h: Replaced.
- public/platform/WebPeerConnection00Handler.h: Replaced.
- public/platform/WebPeerConnection00HandlerClient.h: Replaced.
- public/platform/WebPeerConnectionHandler.h: Replaced.
- public/platform/WebPeerConnectionHandlerClient.h: Replaced.
- public/platform/WebSessionDescriptionDescriptor.h: Replaced.
- public/platform/WebVector.h: Replaced.
- src/WebICECandidateDescriptor.cpp: Removed.
- src/WebICEOptions.cpp: Removed.
- src/WebMediaHints.cpp: Removed.
- src/WebMediaStreamComponent.cpp: Removed.
- src/WebMediaStreamDescriptor.cpp: Removed.
- src/WebMediaStreamSource.cpp: Removed.
- src/WebMediaStreamSourcesRequest.cpp: Removed.
- 12:15 AM Changeset in webkit [112783] by
-
- 2 edits in trunk/Tools
Another build fix after r112781.
- BuildSlaveSupport/built-product-archive:
(createZip):
- 12:06 AM Changeset in webkit [112782] by
-
- 2 edits in trunk/Tools
Build fix after r112781.
- BuildSlaveSupport/built-product-archive:
(createZipManually):
(createZip):
Mar 30, 2012:
- 11:50 PM Changeset in webkit [112781] by
-
- 4 edits in trunk/Tools
Chromium bots should upload archived built files
https://bugs.webkit.org/show_bug.cgi?id=82666
Reviewed by Tony Chang.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/built-product-archive:
(main):
(determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
call out to webkit-build-directory.
(removeDirectoryIfExists): Extracted.
(copyBuildFiles): Added to avoid archiving useless intermedinate files.
(createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
(createZipManually.addToArchive):
(createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
(archiveBuiltProduct): Add support for Chromium port.
- Scripts/webkit-build-directory: Add support for --platform options.
- 11:10 PM Changeset in webkit [112780] by
-
- 4 edits4 copies4 deletes in trunk/Source
[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
https://bugs.webkit.org/show_bug.cgi?id=82657
Reviewed by James Robinson.
Source/WebCore:
We finally arive at our destination. This patch actually moves
WebCore::ResourceHandle from Source/WebKit/chromium/src to
Source/WebCore/network/chromium, matching its location in other ports.
To make this happen, we also need to move WrappedResourceRequest and
WrappedResourceResponse.
This patch is the last patch from
https://github.com/abarth/webkit/compare/master...webcore-platform
- WebCore.gypi:
- platform/chromium/support/WrappedResourceRequest.h: Copied from Source/WebCore/platform/chromium/support/WrappedResourceRequest.h.
- platform/chromium/support/WrappedResourceResponse.h: Copied from Source/WebCore/platform/chromium/support/WrappedResourceResponse.h.
- platform/network/chromium/ResourceHandle.cpp: Copied from Source/WebCore/platform/network/chromium/ResourceHandle.cpp.
- platform/network/chromium/ResourceHandleInternal.h: Copied from Source/WebCore/platform/network/chromium/ResourceHandleInternal.h.
Source/WebKit/chromium:
- WebKit.gyp:
- src/ResourceHandle.cpp: Removed.
- src/ResourceHandleInternal.h: Removed.
- src/WrappedResourceRequest.h: Removed.
- src/WrappedResourceResponse.h: Removed.
- 10:26 PM Changeset in webkit [112779] by
-
- 2 edits in tags/Safari-536.5.1/Source/JavaScriptCore
Merge r112678.
- 10:26 PM Changeset in webkit [112778] by
-
- 4 edits in tags/Safari-536.5.1/Source
Versioning.
- 10:20 PM Changeset in webkit [112777] by
-
- 1 copy in tags/Safari-536.5.1
New tag.
- 10:16 PM Changeset in webkit [112776] by
-
- 3 edits in trunk/Source/WebCore
Add a compile assert for the size of RenderText
https://bugs.webkit.org/show_bug.cgi?id=82780
Reviewed by Dirk Pranke.
Added an assertion. Also moved m_maxWidth, m_beginMinWidth, and m_endMinWidth
to right beneath m_minWidth so that gcc on GTK+ can pack floats properly.
- rendering/RenderText.cpp:
(SameSizeAsRenderText):
(WebCore):
- rendering/RenderText.h:
(RenderText):
- 10:16 PM Changeset in webkit [112775] by
-
- 2 edits in trunk/Source/WebKit/chromium
Two more link errors. This time it's v8 we're missing.
- WebKitUnitTests.gyp:
- 10:04 PM Changeset in webkit [112774] by
-
- 3 edits in trunk/Source/WebCore
Add a compile assert for the size of ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=82822
Reviewed by Dirk Pranke.
Added the assertion. Also made m_scrollOriginChanged a bitfield so that it can be packed nicely.
- platform/ScrollableArea.cpp:
(SameSizeAsScrollableArea):
(WebCore):
- platform/ScrollableArea.h:
(ScrollableArea):
- 9:44 PM Changeset in webkit [112773] by
-
- 2 edits in trunk/Source/WebKit2
Stop creating the Web Inspector's NSWindow when detaching on close.
This fixes a UI process crash that would happen when detaching because of a Web Process crash.
https://webkit.org/b/82820
rdar://problem/11085467
Reviewed by Dan Bernstein.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDetach): Moved the creation and showing code to the end
and added an early return if we are not visible in the middle.
- 9:35 PM Changeset in webkit [112772] by
-
- 2 edits in trunk/Source/WebKit/chromium
Attempt to fix the Windows component build. It seems we're just
missing GURL now.
- WebKitUnitTests.gyp:
- 9:01 PM Changeset in webkit [112771] by
-
- 17 edits5 deletes in trunk
Reverted r112767, because it caused many vertical text tests to fail.
Source/WebCore:
- WebCore.exp.in:
- platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
- platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):
Tools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/fonts/SampleFont.sfont: Removed.
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
- WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/fonts/SampleFont.sfont: Removed.
LayoutTests:
- fast/text/international/text-spliced-font.html: Removed.
- platform/mac/fast/text/international/text-spliced-font-expected.png: Removed.
- platform/mac/fast/text/international/text-spliced-font-expected.txt: Removed.
- 8:44 PM Changeset in webkit [112770] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the Chromium Mac build after r112767.
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
- 8:36 PM Changeset in webkit [112769] by
-
- 10 edits7 adds in trunk
Colors seem to be parsed using HTML quirks in SVG attributes
https://bugs.webkit.org/show_bug.cgi?id=46112
Source/WebCore:
Reviewed by Eric Seidel.
Finally move to SVGAttributeMode on parsing SVG presentation attributes. SVG attributes are
mainly parsed in the strict mode, which affects strict parsing of colors and no spaces between
values and units. Unit less values are still allowed.
Tests: svg/css/svg-attribute-length-parsing.html
svg/css/svg-attribute-parser-mode.html
- css/CSSGrammar.y: No quirks mode for SVG.
- css/CSSParser.h:
(WebCore::CSSParser::inStrictMode): SVGAttributeMode also implies strict parsing.
(WebCore::CSSParser::inQuirksMode): Remove SVGAttributeMode from quirks mode.
- css/CSSParserMode.h:
(isStrictParserMode): Ditto.
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- svg/SVGStyledElement.cpp: Switch to SVGAttributeMode if we parse a SVG presentation attribute.
(WebCore::SVGStyledElement::getPresentationAttribute):
LayoutTests:
Test that values of SVG presentation attributes are parsed in strict mode. At the moment
this affects strict color parsing and no spaces between values and units.
Reviewed by Eric Seidel.
- svg/animations/script-tests/animate-color-fill-from-by.js:
- svg/css/script-tests/svg-attribute-length-parsing.js: Added.
- svg/css/script-tests/svg-attribute-parser-mode.js: Added.
- svg/css/svg-attribute-length-parsing-expected.txt: Added.
- svg/css/svg-attribute-length-parsing.html: Added.
- svg/css/svg-attribute-parser-mode-expected.txt: Added.
- svg/css/svg-attribute-parser-mode.html: Added.
- 8:24 PM Changeset in webkit [112768] by
-
- 2 edits in trunk/Source/WebKit/chromium
Attempt to fix the Windows component build. The way we link the unit
tests in the component build is kind of nutty. Hopefully this approach
will eliminate the duplicate symbols we've been seeing.
- WebKitUnitTests.gyp:
- 8:13 PM Changeset in webkit [112767] by
-
- 17 edits5 adds in trunk
Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810
CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).
When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.
To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.
Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.
Added test LayoutTests/fast/text/international/text-spliced-font.html
- WebCore.exp.in:
Replaced obsolete FontPlatformData constructor entry.
- platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.
(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.
- platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.
(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.
(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.
(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.
(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.
(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.
(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.
Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810
A new test font of this kind as been added to the test tools for running the webkit-tests
Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Added new dependency SampleFont.sfont
- DumpRenderTree/fonts/SampleFont.sfont: Added.
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
(activateTestingFonts):
Added the registration of the Composite Font Referene sample font
- WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added new dependency SampleFont.sfont
- WebKitTestRunner/fonts/SampleFont.sfont: Added.
LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810
Added new LayoutTests/fast/text/international/text-spliced-font.html
Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.
- fast/text/international/text-spliced-font.html: Added.
- platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
- platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.
- 8:07 PM Changeset in webkit [112766] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Use KURL::protocolIsInHTTPFamily() instead KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=82707
Reviewed by Rob Buis.
No new tests, just BlackBerry build fix.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 7:46 PM Changeset in webkit [112765] by
-
- 9 edits in trunk/Source/WebCore
styleForElement() should use enums instead of bools so we can all understand what it's doing
https://bugs.webkit.org/show_bug.cgi?id=82807
Reviewed by Adam Barth.
No change in behavior, thus no tests.
Mostly this is just replacing true/false with the correct new enum value
or removing true/false from the callsites when they would have been default anyway.
I think this makes the code *way* more clear.
The old code was extra confusing because the defaults were "true, false". :)
The new defaults are AllowStyleSharing, MatchAllRules.
It's very uncommon for callers to want to override either of these behaviors.
I think most callers which specify DisallowStyleSharing likely don't actually need to
(our style-sharing code should be smart enough to only share when safe anyway).
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
- Use enums and remove bogus comment (m_rootDefaultStyle is a RefPtr!)
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- dom/Element.cpp:
(WebCore::Element::styleForRenderer):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getUncachedPseudoStyle):
- Updated to use enums
- Also fixed this to use toElement and modern early-return styles.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeStyleInRegion):
- svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
- 7:36 PM Changeset in webkit [112764] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Headers with no content shouldn't be dropped by platform's request.
https://bugs.webkit.org/show_bug.cgi?id=82691
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-30
Reviewed by Rob Buis.
Test : http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- 7:27 PM Changeset in webkit [112763] by
-
- 2 edits in trunk/LayoutTests
Skip more tests. Tracking bugs are listed in the Skipped file.
- platform/mac/Skipped:
- 7:21 PM Changeset in webkit [112762] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG should optimize a==b for a being an object and b being either an object or
null/undefined, and vice versa
https://bugs.webkit.org/show_bug.cgi?id=82656
Reviewed by Oliver Hunt.
Implements additional object equality optimizations for the case that one
operand is predicted to be an easily speculated object (like FinalObject or
Array) and the other is either an easily speculated object or Other, i.e.
Null or Undefined.
2-5% speed-up on V8/raytrace, leading to a sub-1% progression on V8.
I also took the opportunity to clean up the control flow for the speculation
decisions in the various Compare opcodes. And to fix a build bug in SamplingTool.
And to remove debug cruft I stupidly committed in my last patch.
- bytecode/SamplingTool.h:
(SamplingRegion):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- 7:17 PM Changeset in webkit [112761] by
-
- 2 edits in trunk/LayoutTests
Skip two SVG tests that asserted. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82815
- platform/mac/Skipped:
- 6:37 PM Changeset in webkit [112760] by
-
- 4 edits13 adds in trunk
Add tests for iframe seamless and support for parsing webkitseamless attribute
https://bugs.webkit.org/show_bug.cgi?id=82795
Reviewed by Adam Barth.
Source/WebCore:
This just adds support for parsing/reflecting the "webkitseamess" attribute.
I'll add the actual CSS, navigation, security, and layout changes in
separate follow-up patches.
Tests: fast/frames/seamless/seamless-basic.html
fast/frames/seamless/seamless-css-cascade.html
fast/frames/seamless/seamless-nested.html
fast/frames/seamless/seamless-sandbox-flag.html
- html/HTMLAttributeNames.in:
- html/HTMLIFrameElement.idl:
LayoutTests:
- fast/frames/seamless/resources/css-cascade-child.html: Added.
- fast/frames/seamless/resources/nested-seamless.html: Added.
- fast/frames/seamless/resources/square.html: Added.
- fast/frames/seamless/seamless-basic-expected.txt: Added.
- fast/frames/seamless/seamless-basic.html: Added.
- fast/frames/seamless/seamless-css-cascade-expected.txt: Added.
- fast/frames/seamless/seamless-css-cascade.html: Added.
- fast/frames/seamless/seamless-nested-expected.txt: Added.
- fast/frames/seamless/seamless-nested.html: Added.
- fast/frames/seamless/seamless-sandbox-flag-expected.txt: Added.
- fast/frames/seamless/seamless-sandbox-flag.html: Added.
- 6:15 PM Changeset in webkit [112759] by
-
- 10 edits in trunk/LayoutTests
Unreviewed, fix Leopard/SL expectations for remaining SVG tests.
Also, mark zoom-img-preserveAspectRatio-support-1 as still failing.
- platform/chromium-mac-snowleopard/fast/overflow/overflow-x-y-expected.txt:
- platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
- platform/chromium-mac-snowleopard/svg/custom/mask-colorspace-expected.txt:
- platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-use-expected.txt:
- platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
- platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.txt:
- platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
- platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
- platform/chromium/test_expectations.txt:
- 5:57 PM Changeset in webkit [112758] by
-
- 18 edits in trunk/Source
Change WebKit/WebKit2 platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=82549
Source/WebCore:
Reviewed by Eric Seidel.
Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.
No new tests. No change in functionality.
- dom/Node.h:
(WebCore::Node::pixelSnappedRenderRect):
Add pixel snapped version of renderRect
- rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedFrameRect):
Add pixel snapped version of frameRect
Source/WebKit/chromium:
Reviewed by Eric Seidel.
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::boundingBoxRect):
Use pixelSnappedBoundingBoxRect instead of boundingBoxRect which returns
a LayoutRect.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):
Use roundedPoint instead of point for hit testing as ranges use screen
cordinates which are represented with pixel accuracy.
Source/WebKit/mac:
Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.
Reviewed by Eric Seidel.
- DOM/WebDOMOperations.mm:
(-[DOMNode _renderRect:]):
Source/WebKit/qt:
Reviewed by Eric Seidel.
- Api/qwebelement.cpp:
(QWebElement::geometry):
Replace getRect with getPixelSnappedRect to avoid having to expose
subpixel types to the platform layer.
- Api/qwebpage.cpp:
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
Use pixel snapped element rect when comparing with the touch rect as the
touch rect use screen cordinates which are represented with pixel
accuracy.
- WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::scrollRectIntoView):
Change scrollRectIntoView to take a LayoutRect to match base class
interface.
Source/WebKit2:
Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.
Reviewed by Eric Seidel.
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::renderRect):
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::invalidateScrollbarRect):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::characterIndexForPoint):
- 5:54 PM Changeset in webkit [112757] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=82761
Try to narrow down the cause of this assertion by adding
an assertion about m_frame.
- editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- 5:52 PM Changeset in webkit [112756] by
-
- 5 edits in trunk/Source/WebCore
Fix return type for virtual borderBoundingBox method
https://bugs.webkit.org/show_bug.cgi?id=82561
Reviewed by Eric Seidel.
No new tests, no change in functionality.
- editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
- rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxRect):
Rename pixelSnappedBorderBoxRect to borderBoxRect and remove LayoutRect
version of same as we always want to use the pixel snapped version to
ensure proper rounding and alignment to device pixels.
(The way this rect is pixel snapped, using the m_frameRect location,
makes it hard for calling code to take the subpixel rect and correctly
snap it).
(WebCore::RenderBox::borderBoundingBox):
- rendering/RenderBoxModelObject.h:
Change pure virtual definition of borderBoundingBox to return an IntRect
to match implementation in RenderBox.
(RenderBoxModelObject):
- rendering/RenderInline.h:
(WebCore::RenderInline::borderBoundingBox):
Change overloaded method to IntRect to match RenderBox implementation.
- 5:48 PM April 2012 Meeting edited by
- (diff)
- 5:46 PM Changeset in webkit [112755] by
-
- 17 edits in trunk
shape-inside and shape-outside are not in the list of computed style properties
https://bugs.webkit.org/show_bug.cgi?id=82667
Patch by Bear Travis <betravis@adobe.com> on 2012-03-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adding prefixed shape-inside and shape-outside to the list of computed style properties.
Added properties to existing tests for computed style results
- css/CSSComputedStyleDeclaration.cpp:
(WebCore): added -webkit-shape-inside and -webkit-shape-outside to computedProperties
LayoutTests:
Adding prefixed shape-inside and shape-outside to the list of computed style properties.
Updating tests that look at all properties on a computed style declaration.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 5:31 PM Changeset in webkit [112754] by
-
- 4 edits8 moves in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=82582
Move CPP files related to ResourceHandle to WebCore/platform
Reviewed by James Robinson.
Source/WebCore:
This patch moves a number of files that implement parts of the platform
portion of the Chromium WebKit API from the WebKit layer to
WebCore/platform. These files are in the dependency cone of
ResourceHandle and have no dependencies on anything outside
WebCore/platform.
- WebCore.gypi:
- platform/chromium/support/WebHTTPBody.cpp: Copied from Source/WebKit/chromium/src/WebHTTPBody.cpp.
- platform/chromium/support/WebHTTPLoadInfo.cpp: Copied from Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp.
- platform/chromium/support/WebURL.cpp: Copied from Source/WebKit/chromium/src/WebURL.cpp.
- platform/chromium/support/WebURLError.cpp: Copied from Source/WebKit/chromium/src/WebURLError.cpp.
- platform/chromium/support/WebURLRequest.cpp: Copied from Source/WebKit/chromium/src/WebURLRequest.cpp.
- platform/chromium/support/WebURLRequestPrivate.h: Copied from Source/WebKit/chromium/src/WebURLRequestPrivate.h.
- platform/chromium/support/WebURLResponse.cpp: Copied from Source/WebKit/chromium/src/WebURLResponse.cpp.
- platform/chromium/support/WebURLResponsePrivate.h: Copied from Source/WebKit/chromium/src/WebURLResponsePrivate.h.
Source/WebKit/chromium:
- WebKit.gyp:
- src/WebHTTPBody.cpp: Removed.
- src/WebHTTPLoadInfo.cpp: Removed.
- src/WebURL.cpp: Removed.
- src/WebURLError.cpp: Removed.
- src/WebURLRequest.cpp: Removed.
- src/WebURLRequestPrivate.h: Removed.
- src/WebURLResponse.cpp: Removed.
- src/WebURLResponsePrivate.h: Removed.
- 5:25 PM Changeset in webkit [112753] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed, expectations update.
- platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
- platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 5:13 PM Changeset in webkit [112752] by
-
- 7 edits in trunk/Source/WebCore
Fix usage of LayoutUnits in table code.
https://bugs.webkit.org/show_bug.cgi?id=82765
Reviewed by Eric Seidel.
Clean up usage of ints and LayoutUnits in table code in preparation for
turning on subpixel layout.
No new tests, no change in functionality.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Cast maxWidth to int as all table layout is done on int bounds.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
Change borders to LayoutUnit as paddings can have subpixel precision.
- rendering/RenderTable.h:
(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::columnPositions):
Change getColumnPos and columnPositions to ints as the values are always
on pixel bounds.
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
Remove unnecessary cast.
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
Use LayoutPoint instead of left/top.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderTableSection.h:
Change baseline and baselineDescent to int to avoid unnecessary type
conversion.
- 5:10 PM Changeset in webkit [112751] by
-
- 5 edits in branches/safari-534.56-branch/Source
Versioning.
- 5:09 PM Changeset in webkit [112750] by
-
- 1 copy in tags/Safari-534.56.4
New tag.
- 5:05 PM Changeset in webkit [112749] by
-
- 15 edits14 moves1 add in trunk
Spec renamed Viewport-relative lengths to Viewport-percentage lengths
https://bugs.webkit.org/show_bug.cgi?id=82773
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-30
Reviewed by Antti Koivisto.
As per the latest version of CSS Values and Units Module Level 3 specification released on 29 March 2012
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) Viewport-relative lengths is renamed to Viewport-percentage lengths.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::viewportPercentageLength):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageLength):
(CSSPrimitiveValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/LengthFunctions.cpp:
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
- platform/Length.h:
(WebCore::Length::isViewportPercentage):
(WebCore::Length::viewportPercentageLength):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
- rendering/RenderInline.cpp:
(WebCore::computeMargin):
- rendering/style/RenderStyle.h:
LayoutTests:
- css3/viewport-percentage-lengths: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw.html: Added.
- css3/viewport-relative-lengths: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
- css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
- 5:01 PM Changeset in webkit [112748] by
-
- 2 edits in trunk/LayoutTests
Note more flaky crashes for bug 82505.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 4:47 PM Changeset in webkit [112747] by
-
- 2 edits in trunk/LayoutTests
Skip two WebGL tests. Tracked by https://bugs.webkit.org/show_bug.cgi?id=82805
- platform/mac/Skipped:
- 4:34 PM Changeset in webkit [112746] by
-
- 23 edits in trunk
[wx] Move wxWebKit API into WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=82740
Reviewed by Kevin Ollivier.
- 4:30 PM Changeset in webkit [112745] by
-
- 12 edits24 adds in trunk
[CSS Filters] Drop Shadow is not repainting correctly when repaint area is smaller than the filtered element
https://bugs.webkit.org/show_bug.cgi?id=80323
Source/WebCore:
Reviewed by Dean Jackson.
The problem is that shadow and blur (and custom filters - although not treated in this patch) need the full source image of
the surface that needs to be filtered. Until now the filter was computed only using the area defined by the dirty repaint rectangle.
Those filters need full image source because they displace pixel positions, meaning that pixels in the current dirty rectangle
have a dependency on pixels from the RenderLayer outside the dirty rect. See the bug pictures for an example of how that could go wrong.
The fix is to always keep a copy of the RenderLayer representation in memory. When repaint is needed we still invalidate
only the parts that changed, but the filter is computed using the full source image and not only the dirty rectangle.
In order to make that work, we needed the full repaint rectangle of the current RenderLayer and not just the clipped version that
we get through the ::paint methods. Also, because filters sometime need to repaint more than just the dirty area (because of the
outsets of the filters - ie blur, drop-shadow), it makes it easier to just capture all the repaints in the RenderLayer itself in a
similar way WebKit does now for composited layers. As a result the repaint container can also be a filtered layer (not just composited ones), so
that we can catch all the filter repaints in one place in the RenderLayer. Also with this change I removed the need to add visual overflow to
the RenderBox and also there's no need to patch the repaintUsingContainer. By the way, repaintUsingContainer did not always work because of the
LayoutState optimizations, so repaints during layout would fail (I know that that could be fixed by disabling the LayoutState for filtered areas).
Also part of this patch I extracted a function from RenderLayerCompositor::calculateCompositedBounds, so that we can also use it from RenderLayer.
I called it RenderLayer::calculateLayerBounds and there should be no change in functionality. It now also includes the outsets of the filter. I've
added a different bug to avoid adding the outsets when the filter is computed in hardware. That's because some platforms do not support that yet:
https://bugs.webkit.org/show_bug.cgi?id=81239
Also the visual overflow doesn't include the child RenderLayers, meaning that the outsets would have been applied to the border and not to the bounding box
of the RenderLayer. The end result was that some child RenderLayers could be clipped out of the filtered area.
Tests: css3/filters/filter-repaint-blur.html
css3/filters/filter-repaint-child-layers.html
css3/filters/filter-repaint-composited-fallback-crash.html
css3/filters/filter-repaint-composited-fallback.html
css3/filters/filter-repaint-sepia.html
css3/filters/filter-repaint-shadow-clipped.html
css3/filters/filter-repaint-shadow-rotated.html
css3/filters/filter-repaint-shadow.html
- platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::getOutsets): Drop shadow should only enlarge the outsets and never make them smaller.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Caching the operations.hasFilterThatMovesPixels() in the FilterEffectRenderer.
(WebCore::FilterEffectRenderer::updateBackingStore): It now returns true when the backing store was recreated, so that we can repaint it all.
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect): Separated beginFilterEffect into two methods. One that computed the rects
and one that prepares the draw context.
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRendererHelper):
(FilterEffectRenderer):
(WebCore::FilterEffectRenderer::hasFilterThatMovesPixels):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint): No need to include the outsets in the repaint rect here, we will do it later in RenderLayer.
(WebCore::RenderBox::addVisualEffectOverflow): Removed outsets from the overflow.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint): Removed the outsets from this method. We now compute that in
RenderLayer::setFilterBackendNeedsRepaintingInRect.
- rendering/RenderLayer.cpp:
(WebCore):
In this change I introduce a new dirty rectangle used by filters. It accumulates all the repaint requests inside the filtered layer,
so that we can invalidate the areas that are outside the clipping rectangle. Such cases include "overflow:scroll" and "overflow:hidden", when
we still want to blur or drop shadow based on content that is not actually displayed on screen (but the shadow for that content is visible). That rectangle
is called m_filterRepaintRect and resets back to zero when the next repaint is finished. All the filtered layers that apply blur and drop-shadow
will have an extra backing surface and only the invalidated areas are repainted in that surface. This is very similar to how composited layers work.
(WebCore::RenderLayer::requiresFullLayerImageForFilters): Returns true in CPU mode and only if the layer needs the full source image of
the layer to compute the filter. Otherwise GPU layers already have access to the full bakcing image.
(WebCore::RenderLayer::enclosingFilterLayer): Returns the enclosing layer that returns true on requiresFullLayerImageForFilters.
(WebCore::RenderLayer::enclosingFilterRepaintLayer): Returns the enclosing layer that can be used to repaint the current layer. Usually that
is the RenderView layer or the parent RenderLayer that is composited.
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect): Intercepts all the repaint queries for the filtered layers and uses
enclosingFilterRepaintLayer to enforce the repaint using the parent container.
(WebCore::RenderLayer::paintLayerContents): Consolidated the filters code in one single place. Also, it is now sending the bounding box and the
dirty rect to the FilterEffectRendererHelper::prepareFilterEffect to make sure the backing store is repainted accordingly. In some cases it might
rewrite the dirty rectangle used to paint the current layer, so that all the dirty areas in the backing store are covered.
(WebCore::RenderLayer::calculateLayerBounds): Extracted from RenderLayerCompositor::calculateCompositedBounds.
(WebCore::RenderLayer::updateOrRemoveFilterEffect): We should not create the filter builder when there's no filter specified.
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Now using the code from RenderLayer::calculateLayerBounds
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint): Using RenderLayer::enclosingFilterLayer to also find the parent filtered area.
(WebCore::RenderObject::repaintUsingContainer): Removed the need to add filter outsets in this method. We now compute that in
RenderLayer::setFilterBackendNeedsRepaintingInRect.
LayoutTests:
Reviewed by Dean Jackson.
Added more tests to cover all the repaint issues on filtered RenderLayers.
- css3/filters/filter-repaint-blur-expected.png: Added.
- css3/filters/filter-repaint-blur-expected.txt: Added.
- css3/filters/filter-repaint-blur.html: Added. Checking that the full image of the RenderLayer is used to compute
the blur, even if only a sub-section of the layer has repainted.
- css3/filters/filter-repaint-child-layers-expected.png: Added.
- css3/filters/filter-repaint-child-layers-expected.txt: Added.
- css3/filters/filter-repaint-child-layers.html: Added. Checking that the bounding box of the RenderLayer
and all its children are taken into account when computing the filter box.
- css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
- css3/filters/filter-repaint-composited-fallback-crash-expected.txt: Added.
- css3/filters/filter-repaint-composited-fallback-crash.html: Added. There was a crash when filters changed from CPU to GPU.
- css3/filters/filter-repaint-composited-fallback-expected.png: Added.
- css3/filters/filter-repaint-composited-fallback-expected.txt: Added.
- css3/filters/filter-repaint-composited-fallback.html: Added. Checking that repaint still works when platform GPU is not able to
compute the filter.
- css3/filters/filter-repaint-sepia-expected.png: Added.
- css3/filters/filter-repaint-sepia-expected.txt: Added.
- css3/filters/filter-repaint-sepia.html: Added. Testing that repaint still works correctly on simple filter that do not need the full
source image of the RenderLayer (ie. they are not displacing pixels positions).
- css3/filters/filter-repaint-shadow-clipped-expected.png: Added.
- css3/filters/filter-repaint-shadow-clipped-expected.txt: Added.
- css3/filters/filter-repaint-shadow-clipped.html: Added. Checking that an element that's out of view (clipped by the viewport) can
still drop a shadow that might be visible.
- css3/filters/filter-repaint-shadow-expected.png: Added.
- css3/filters/filter-repaint-shadow-expected.txt: Added.
- css3/filters/filter-repaint-shadow-rotated-expected.png: Added.
- css3/filters/filter-repaint-shadow-rotated-expected.txt: Added. Testing that transforms and clipping applied on filtered areas
work correctly with the new repaint methods.
- css3/filters/filter-repaint-shadow-rotated.html: Added.
- css3/filters/filter-repaint-shadow.html: Added. Checking that the full image of the RenderLayer is used to compute
the shadow, even if only a sub-section of the layer has repainted.
- platform/chromium/test_expectations.txt: Chromium needs expected results for the tests. Also the old filter-repaint.html had incorrect
expected results.
- 4:28 PM Changeset in webkit [112744] by
-
- 2 edits in trunk/LayoutTests
Remove expectations for tests that are now passing.
Unreviewed.
- platform/chromium/test_expectations.txt:
- 4:28 PM Changeset in webkit [112743] by
-
- 2264 edits655 copies63 deletes in branches/subpixellayout
Merge trunk changes up until 112729 into subpixel branch.
- 4:27 PM Changeset in webkit [112742] by
-
- 4 edits in trunk/Source/WebCore
Add a compile assert for the size of BidiContext
https://bugs.webkit.org/show_bug.cgi?id=82793
Reviewed by Eric Seidel.
Added the assertion. Also reduced the number of bits used for bidi levels from
8 to 6 as done in InlineBox since bidi levels require exactly 6 bits.
- rendering/InlineBox.h: Added a comment about why bidi level needs exactly 6 bits.
- platform/text/BidiContext.cpp:
(SameSizeAsBidiContext):
(WebCore):
- platform/text/BidiContext.h:
(BidiContext):
- 4:26 PM Changeset in webkit [112741] by
-
- 6 edits in trunk
Enable OpenType Sanitizer for BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=82782
Reviewed by Eric Seidel.
.:
- Source/cmake/OptionsBlackBerry.cmake: define USE(OPENTYPE_SANITIZER)
Source/WebKit:
- PlatformBlackBerry.cmake: add libots to link
Tools:
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments): add OTS to include path
- 4:04 PM Changeset in webkit [112740] by
-
- 4 edits3 adds in trunk
IndexedDB: Race condition causes version change transaction to commit after onblocked
https://bugs.webkit.org/show_bug.cgi?id=82678
Source/WebCore:
For a version change event, the blocked and success events could both be queued
before either is dispatched. The transaction would erroneously be allowed to commit
after the blocked event was dispatched; it should not be, as the request was not
finished.
Reviewed by Tony Chang.
Test: storage/indexeddb/dont-commit-on-blocked.html
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
LayoutTests:
Landing test marked PASS FAIL as WK82776 prevents it from running in DRT; will
run it as a Chromium browser test for now.
Reviewed by Tony Chang.
- platform/chromium/test_expectations.txt:
- storage/indexeddb/dont-commit-on-blocked.html: Added.
- storage/indexeddb/resources/dont-commit-on-blocked-worker.js: Added.
(request.onsuccess):
(onSetVersionBlocked):
(onSetVersionSuccess):
(onTransactionComplete):
- 4:00 PM Changeset in webkit [112739] by
-
- 2 edits in trunk/Tools
run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
is found.
<rdar://problem/11158581>
Reviewed by Mark Rowe.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._start):
- 4:00 PM Changeset in webkit [112738] by
-
- 2 edits in trunk/LayoutTests
Skip another cookie test. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82749
- platform/mac/Skipped:
- 3:49 PM Changeset in webkit [112737] by
-
- 2 edits in trunk/LayoutTests
Cleanup a bunch of useless junk that's accumulated over time.
Also delete comments that add no value.
- platform/chromium/test_expectations.txt:
- 3:36 PM Changeset in webkit [112736] by
-
- 3 edits in trunk/Source/WebCore
Add a compile assert for the size of FontDescription
https://bugs.webkit.org/show_bug.cgi?id=82786
Reviewed by Eric Seidel.
Added the assertion. Also converted a couple of boolean bitfields to unsinged.
I've verified that the conversions are safe (they're only used in FontDescription.h/cpp).
- platform/graphics/FontDescription.cpp:
(SameSizeAsFontDescription):
(WebCore):
- platform/graphics/FontDescription.h:
(FontDescription):
- 3:32 PM Changeset in webkit [112735] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS from 129593 to 129574.
Unreviewed.
- DEPS:
- 3:27 PM Changeset in webkit [112734] by
-
- 2 edits in trunk/Tools
Disable run-api-tests on release mac builds
https://bugs.webkit.org/show_bug.cgi?id=82788
Reviewed by Ryosuke Niwa.
TestWebKitAPI crashes every time in release builds currently
(https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
run-api-tests on mac release builders.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(unitTestsSupported):
- 3:26 PM Changeset in webkit [112733] by
-
- 3 edits in branches/subpixellayout/Source/WebCore
subpixel branch cleanup
- 3:24 PM Changeset in webkit [112732] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=82741
Reviewed by Andreas Kling.
Modify the #include declarations for several EFL-related files
so that the wtf types are included using the full path.
- ewk/ewk_frame.cpp:
- ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
- ewk/ewk_tiled_matrix.cpp:
- 3:23 PM Changeset in webkit [112731] by
-
- 5 edits1 move in trunk/Source
Move CPP files related to ResourceHandle to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=82582
Reviewed by James Robinson.
Source/WebCore:
Re-land a tiny piece of http://trac.webkit.org/changeset/112572 in the
hopes of not breaking the component build this time.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/support/WebData.cpp: Copied from Source/WebKit/chromium/src/WebData.cpp.
Source/WebKit/chromium:
- WebKit.gyp:
- src/WebData.cpp: Removed.
- 3:21 PM Changeset in webkit [112730] by
-
- 4 edits in trunk/Source/WebCore
Kill CSSTimingFunctionValue.
<http://webkit.org/b/82787>
Reviewed by Antti Koivisto.
Remove CSSTimingFunctionValue and let the 3 subclasses inherit directly from CSSValue.
CSSTimingFunctionValue is a pointless middle-man class that adds nothing.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSTimingFunctionValue.h:
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):
- css/CSSValue.h:
(WebCore::CSSValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSValue::isLinearTimingFunctionValue):
(WebCore::CSSValue::isStepsTimingFunctionValue):
- 2:44 PM Changeset in webkit [112729] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Bump max texture updates per frame to 48
https://bugs.webkit.org/show_bug.cgi?id=82779
Reviewed by James Robinson.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WTF):
- 2:42 PM Changeset in webkit [112728] by
-
- 5 edits in trunk/Source/WebCore
Merge FrameLoader::finishedLoading() into DocumentLoader::finishedLoading().
https://bugs.webkit.org/show_bug.cgi?id=82653
Reviewed by Adam Barth.
No new tests, no functionality change intended.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didFinishLoading):
- 2:23 PM Changeset in webkit [112727] by
-
- 3 edits in trunk/Source/WebCore
Cache origin check result to RuleData
https://bugs.webkit.org/show_bug.cgi?id=82774
Reviewed by Andreas Kling.
You wan't be able to get back to the stylesheet from a css style rule soon.
We need to do the origin check when we know the sheet it came from.
- css/CSSStyleSelector.cpp:
(RuleData):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(RuleSet):
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::RuleFeature::RuleFeature):
(RuleFeature):
(Features):
- 2:16 PM Changeset in webkit [112726] by
-
- 2 edits in trunk/Source/WebCore
Remove deadcode behind "SafeSkia" flag
https://bugs.webkit.org/show_bug.cgi?id=82771
Reviewed by Stephen White.
Just removing dead code (behind obsolete build flag), existing webkit tests apply
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
- 2:14 PM Changeset in webkit [112725] by
-
- 3 edits in trunk/Source/WebCore
Add a compile assert for the size of InlineFlowBox
https://bugs.webkit.org/show_bug.cgi?id=82767
Reviewed by Tony Chang.
Add a compile assert to ensure InlineFlowBox stays small.
Also make some of the member variables not used in RootInlineBox private.
Changing these booleans to unsigned is safe as I've audited all code that
uses these member variables (they're all in InlineFlowBox or RootInlineBox).
- rendering/InlineFlowBox.cpp:
(SameSizeAsInlineFlowBox):
(WebCore):
- rendering/InlineFlowBox.h:
(InlineFlowBox):
- 2:11 PM Changeset in webkit [112724] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, new baseline.
- platform/chromium-win/svg/text/text-align-05-b-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:55 PM Changeset in webkit [112723] by
-
- 3 edits1 add in trunk
Fix defective size_t overflow in GestureTapHighlighter.
https://bugs.webkit.org/show_bug.cgi?id=82605
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-30
Reviewed by Kenneth Rohde Christiansen.
.:
- ManualTests/tap-gesture-in-iframe-with-tap-highlight-crash.html: Added.
Source/WebCore:
In pathForRenderer, the for loop has 'i < rects().size() - 1' as test expression,
where rects().size() returns with size_t.
In case of empty rect, it leads to unsigned int overflow. Overflow value makes
the associated for loop run with invalid values.
Fix it by making loop variable int and stop using size_t type in the test expression.
Also, return early, if no focus ring found.
Manual test added. Tap gesture highlighter is getting triggered by UI process.
- page/GestureTapHighlighter.cpp:
- 1:55 PM Changeset in webkit [112722] by
-
- 2 edits in trunk/Source/WebKit2
Fix Lion build.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
- 1:51 PM Changeset in webkit [112721] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766
Reviewed by Rob Buis.
PR 136593.
Refactor generation of Selection IntRectRegion to avoid
the need for IntRectRegion's helper functions which were
not available when using it as a container without
unioning the rects.
This greatly speeds up rendering by maintaining the distinct
rects as the union operation was length with large numbers of
rects.
Reviewed Internally by Gen Mak, Mike Lattanzio and Tyler Abbott.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::visibleTextQuads):
(DOMSupport):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(WebKit):
(BlackBerry::WebKit::regionRectListContainsPoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- WebKitSupport/SelectionHandler.h:
(WebCore):
(SelectionHandler):
- 1:50 PM Changeset in webkit [112720] by
-
- 31 edits in trunk/Source
GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-30
Reviewed by Adam Barth.
Source/WebCore:
Geolocation now uses the Supplement interface instead of
keeping an instance variable on Page. This allows us to
remove all geolocation-related functions, variables, and
ifdefs out of Page and into Modules/geolocation/.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- Modules/geolocation/Geolocation.h:
(WebCore):
- Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::supplementName):
(WebCore):
(WebCore::provideGeolocationTo):
- Modules/geolocation/GeolocationController.h:
(GeolocationController):
(WebCore::GeolocationController::from):
- WebCore.exp.in:
- page/GeolocationClient.h:
(WebCore):
(GeolocationClient):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
- page/Page.h:
(WebCore):
(PageClients):
(Page):
Source/WebKit/blackberry:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
- WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
Source/WebKit/chromium:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Source/WebKit/gtk:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
- WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
Source/WebKit/mac:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):
Source/WebKit/qt:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
- WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):
Source/WebKit/win:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
Source/WebKit2:
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 1:47 PM Changeset in webkit [112719] by
-
- 2 edits in trunk/Source/WebCore
This is fun.
- WebCore.xcodeproj/project.pbxproj:
- 1:38 PM Changeset in webkit [112718] by
-
- 3 edits in trunk/LayoutTests
Rebaseline due to wkbug.com/80423
https://bugs.webkit.org/show_bug.cgi?id=82743
Patch by Philip Rogers <pdr@google.com> on 2012-03-30
Reviewed by Simon Fraser.
- platform/mac/Skipped:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
- 1:33 PM Changeset in webkit [112717] by
-
- 2 edits in trunk/Source/WebCore
Yet another build fix attempt.
- WebCore.xcodeproj/project.pbxproj:
- 1:29 PM Changeset in webkit [112716] by
-
- 2 edits83 adds in trunk/LayoutTests
Integrate IETC CSS : textshadow tests
https://bugs.webkit.org/show_bug.cgi?id=81936
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-30
Reviewed by Adam Barth.
Adding expected pngs and render tree dumps for IETC text shadow tests.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-001-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-002-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-003-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-004-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-005-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-006-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-007-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-008-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-009-expected.png: Added.
- platform/chromium-linux/ietestcenter/css3/text/textshadow-010-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-001-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-002-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-003-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-004-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-005-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-006-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-007-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-008-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-009-expected.png: Added.
- platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-010-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-001-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-002-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-003-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-004-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-005-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-006-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-007-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-008-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-009-expected.png: Added.
- platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-010-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-005-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-006-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-007-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-008-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-009-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.png: Added.
- platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-005-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-006-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-007-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-008-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-009-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png: Added.
- platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:21 PM Changeset in webkit [112715] by
-
- 19 edits1 delete in trunk/LayoutTests
More SVG rebaselining.
Unreviewed, new baselines and expectations, for:
svg/W3C-SVG-1.1/animate-elem-37-t.svg
svg/W3C-SVG-1.1/animate-elem-81-t.svg
svg/W3C-SVG-1.1/animate-elem-82-t.svg
svg/W3C-SVG-1.1/animate-elem-83-t.svg
svg/W3C-SVG-1.1/struct-frag-02-t.svg
svg/W3C-SVG-1.1/text-align-05-b.svg
svg/text/text-align-05-b.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/W3C-SVG-1.1/types-basicDOM-01-b.svg
- platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
- platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [112714] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Make sure strings do not leak in PluginViewBlackberry.
https://bugs.webkit.org/show_bug.cgi?id=82764
Update PluginViewBlackBerry to follow the changes in
BlackBerry::Platform::Window which now returns std::string instead of char* for
strings. Also copy the windowGroup and rootGroup strings in PluginViewPrivate
instead of just saving a pointer to the returned memory, which could become
invalid at any time.
Patch by Joe Mason <jmason@rim.com> on 2012-03-30
Reviewed by Rob Buis.
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):
- plugins/blackberry/PluginViewPrivateBlackBerry.h:
(PluginViewPrivate):
- 1:03 PM Changeset in webkit [112713] by
-
- 2 edits in trunk/Source/WebCore
Another build fix.
- WebCore.xcodeproj/project.pbxproj:
- 12:56 PM Changeset in webkit [112712] by
-
- 3 edits in trunk/LayoutTests
Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423
One more unreviewed gardening after r112667.
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
- 12:31 PM Changeset in webkit [112711] by
-
- 7 edits1 copy1 move6 adds10 deletes in trunk/LayoutTests
Unreviewed, expectations updates for Lion, Linux for some SVG tests.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/chromium-mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt.
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
- platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- platform/chromium-mac/svg/custom/viewbox-syntax-expected.txt:
- platform/chromium-mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
- platform/chromium-mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
- platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
- platform/chromium-win/svg/custom/viewbox-syntax-expected.txt:
- platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt.
- platform/chromium/test_expectations.txt:
- 12:22 PM Changeset in webkit [112710] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- page/scrolling/mac/ScrollingTreeMac.mm:
- 12:06 PM Changeset in webkit [112709] by
-
- 21 edits3 copies3 moves234 adds6 deletes in trunk/LayoutTests
Chromium garden-o-matic rebaselines for expected failures.
Most of these are one of the following:
-text-rendering differences
-anti-aliasing differences
-form control/scrollbar rendering
-different error messages from V8 vs. JSC
-Mac bots paint repaint shadow at a slightly different shade
- 12:05 PM Changeset in webkit [112708] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=82731
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-30
Reviewed by James Robinson.
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::animateLayers):
(CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::notifyAnimationStarted):
- 11:59 AM Changeset in webkit [112707] by
-
- 11 edits1 add in trunk/Source
Show a scrolling indicator light when compositing borders are turned on
https://bugs.webkit.org/show_bug.cgi?id=82758
<rdar://problem/11143892>
Reviewed by Andreas Kling.
Source/WebCore:
With this change, turning on compositing borders also turn on a tiny indicator in the top left corner.
This indicator uses color coding to show where wheel events are handled and where the scroll layer position is updated:
- Green means that both wheel events and scroll layer position updates are handled on the scrolling thread.
- Yellow means that wheel events need to be dispatched to the main thread (due to wheel event handlers), but that scroll layer position updates still happen on the scrolling thread.
- Red means that scroll layer position updates happen on the main thread (due to background-attachment: fixed or fixed position objects).
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
Call updateDebugRootLayer().
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):
Make this public.
(ScrollingTreeNode):
- page/scrolling/mac/ScrollingTreeMac.mm: Added.
(WebCore::ScrollingTree::setDebugRootLayer):
Set up a new debug info sublayer.
(WebCore::ScrollingTree::updateDebugRootLayer):
Update the debug root layer background color based on the scrolling tree state.
Source/WebKit2:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updatePreferences):
Add a hook for letting drawing area subclasses know when preferences change.
- WebProcess/WebPage/WebPage.cpp:
Call DrawingArea::updatePreferences.
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Call updatePreferences.
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
If compositing borders are enabled, create a debug root layer and tell the scrolling tree about it.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
If we have a debug root layer, make sure it's in front.
- 11:54 AM Changeset in webkit [112706] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: add missing runtime assert method for InspectorObject
https://bugs.webkit.org/show_bug.cgi?id=82753
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-30
Reviewed by Vsevolod Vlasov.
Type validator generator is extended to support missing InspectorObject type and
made more accurate for "int" type.
Strict types are enabled for 2 more domains.
- inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType.generate_validate_method):
(RawTypes.String.get_validate_method_params.ValidateMethodParams):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Object.get_validate_method_params.ValidateMethodParams):
(RawTypes.Object.get_validate_method_params):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding.request_internal_runtime_cast):
- 11:49 AM Changeset in webkit [112705] by
-
- 2 edits in trunk/LayoutTests
Fix a typo in the Skipped list.
- platform/mac/Skipped:
- 11:45 AM Changeset in webkit [112704] by
-
- 6 edits in branches/chromium/1084/LayoutTests/platform
Merge 112696 - Unreviewed rebaseline after r112436
- platform/chromium-linux/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-mac-leopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-win/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium/test_expectations.txt:
TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9956029
- 11:44 AM Changeset in webkit [112703] by
-
- 2 edits in trunk/LayoutTests
Skip some more failing/timing-out tests.
- platform/mac/Skipped:
- 11:42 AM Changeset in webkit [112702] by
-
- 8 edits in branches/chromium/1084
Merge 112436 - [chromium] layer->clipRect() is not initialized for layers that create a renderSurface.
https://bugs.webkit.org/show_bug.cgi?id=74147
Reviewed by Adrienne Walker.
Source/WebCore:
Added 3 additional unit tests; Modified existing unit tests and layout tests.
The layer's clipRect and usesLayerClipping information was not
being initialized for layers that created a renderSurface. (It
was, however, being initialized for the renderSurface itself.)
This patch adds a unit test that reproduces that this is an error,
other unit tests to tightly test the value of clipRect being
initialized, and adds the logic to properly initialize the
clipRect.
Before this patch, this bug was causing flashing on tab-switch on
the apple iphone page. Even worse, with partial swap enabled, the
layers would simply disappear, because the first frame the
clipRect is uninitialized and the layer is not drawn, and the
second frame onwards, the damage tracker correctly things nothing
is damaged, so it doesn't draw that layer again until other damage
causes it to be redrawn.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
Source/WebKit/chromium:
Added 3 more unit tests. One reproduces the clipRect problem in an
integrated manner, the other two directly test that clipRects are
properly initialized.
- tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCLayerTreeTestCommon.h:
(WebKitTests):
LayoutTests:
- platform/chromium/test_expectations.txt: marked test as needing rebaselining
TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9958025
- 11:39 AM Changeset in webkit [112701] by
-
- 4 edits in trunk/Source
[chromium] assertion being hit in CCLayerAnimationController
https://bugs.webkit.org/show_bug.cgi?id=82237
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-30
Reviewed by James Robinson.
Source/WebCore:
Animations are no longer pushed to the impl thread if they have already completed.
Tested in CCLayerAnimationControllerTest.doNotSyncFinishedAnimation
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
Source/WebKit/chromium:
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- 11:32 AM Changeset in webkit [112700] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r112699.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::findPropertyWithId):
- 11:30 AM WebKit Team edited by
- (diff)
- 11:28 AM WebKit Team edited by
- (diff)
- 11:27 AM Changeset in webkit [112699] by
-
- 4 edits in trunk/Source/WebCore
Add a compile assert for the size of CSSProperty
https://bugs.webkit.org/show_bug.cgi?id=82756
Reviewed by Andreas Kling.
Add a compile assert to ensure CSSProperty instances stay small.
Also make member variables of CSSProperty private as they should have been,
and extract wrapValueInCommaSeparatedList from createFontFaceRule.
- css/CSSParser.cpp:
(WebCore::CSSParser::createFontFaceRule):
- css/CSSProperty.cpp:
(SameSizeAsCSSProperty):
(WebCore):
(WebCore::CSSProperty::wrapValueInCommaSeparatedList):
- css/CSSProperty.h:
(CSSProperty):
- 11:24 AM Changeset in webkit [112698] by
-
- 2 edits in trunk/Tools
2012-03-30 Chang Shu <cshu@webkit.org>
Unreviewed. Update my email.
- Scripts/webkitpy/common/config/committers.py:
- 11:20 AM Changeset in webkit [112697] by
-
- 2 edits in trunk/Source/WebCore
Let there be a clean xcodeproj.
- WebCore.xcodeproj/project.pbxproj:
- 11:13 AM Changeset in webkit [112696] by
-
- 7 edits in trunk/LayoutTests
Unreviewed rebaseline after r112436
- platform/chromium-linux/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-mac-leopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium-win/compositing/reflections/nested-reflection-on-overflow-expected.png:
- platform/chromium/test_expectations.txt:
- 11:09 AM Changeset in webkit [112695] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed Chromium Mac build fix.
- src/WebDevToolsAgentPrivate.h:
(WebKit):
- 11:07 AM Changeset in webkit [112694] by
-
- 11 edits2 adds in trunk
AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
https://bugs.webkit.org/show_bug.cgi?id=82745
Reviewed by Simon Fraser.
Source/WebCore:
Test: platform/mac/accessibility/range-for-position.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::index):
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(rangeForPositionCallback):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rangeForPosition):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::rangeForPosition):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR):
LayoutTests:
- platform/mac/accessibility/range-for-position-expected.txt: Added.
- platform/mac/accessibility/range-for-position.html: Added.
- 11:04 AM Changeset in webkit [112693] by
-
- 7 edits in branches/chromium/1084/Source
Merge 112568 - [chromium] Ensure framebuffer exists at the start of beginDrawingFrame.
https://bugs.webkit.org/show_bug.cgi?id=82569
Patch by Michal Mocny <mmocny@google.com> on 2012-03-29
Reviewed by James Robinson.
Source/WebCore:
Updated LayerRendererChromiumTest unittests.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::beginDrawingFrame):
- platform/graphics/chromium/LayerRendererChromium.h:
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
Source/WebKit/chromium:
- tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):
TBR=commit-queue@webkit.org
BUG=120589
Review URL: https://chromiumcodereview.appspot.com/9969020
- 11:02 AM Changeset in webkit [112692] by
-
- 181 edits12 copies10 moves11 adds7 deletes in trunk/LayoutTests
[Chromium] Unreviewed, rebaseline part of expectations after r112667 using garden-o-matic (224 files affected).
- platform/chromium-linux-x86/svg/: [...]
- platform/chromium-linux/svg/: [...]
- platform/chromium-mac-leopard/svg/: [...]
- platform/chromium-mac-snowleopard/svg/: [...]
- platform/chromium-mac/svg/: [...]
- platform/chromium-win-vista/svg/: [...]
- platform/chromium-win-xp/svg/: [...]
- platform/chromium-win/svg/: [...]
- platform/chromium/svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/hixie/shapes/path/001-expected.txt.
- platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
- platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
- platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
- platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Removed.
- svg/hixie/mixed/004-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/mixed/004-expected.txt.
- svg/hixie/mixed/005-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/mixed/005-expected.txt.
- svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
- svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
- svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
- 11:00 AM Changeset in webkit [112691] by
-
- 2 edits in trunk/Source/WebCore
Certain emoji characters should not be displayed in user-visible URL strings.
<https://bugs.webkit.org/show_bug.cgi?id=82739>
<rdar://problem/9205643>
Reviewed by Alexey Proskuryakov
- platform/mac/WebCoreNSURLExtras.mm:
(WebCore::isLookalikeCharacter):
Added five emoji characters to the list.
- 10:54 AM Changeset in webkit [112690] by
-
- 9 edits in trunk/Source/WebKit/chromium
Web Inspector: [Chromium] Implement Chromium-specific part of the device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82612
This change implements the Chromium-specific code for overriding the device metrics, such as screen size
(by setting the FrameView size) and font zoom factor (necessary for certain emulated devices,)
and for painting the gutter overlay covering the WebView area not occupied by the associated FrameView.
Reviewed by Pavel Feldman.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canOverrideDeviceMetrics):
(WebKit):
(WebKit::InspectorClientImpl::overrideDeviceMetrics):
(WebKit::InspectorClientImpl::autoZoomPageToFitWidth):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(OverlayZOrders):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::DeviceMetricsSupport::paintPageOverlay):
(WebKit::DeviceMetricsSupport::frameView):
(WebKit):
(WebKit::WebDevToolsAgentImpl::mainFrameViewCreated):
(WebKit::WebDevToolsAgentImpl::metricsOverridden):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):
(WebKit::WebDevToolsAgentImpl::highlight):
- src/WebDevToolsAgentImpl.h:
(WebCore):
(WebKit):
(WebDevToolsAgentImpl):
- src/WebDevToolsAgentPrivate.h:
(WebKit):
(WebDevToolsAgentPrivate):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setEmulatedTextZoomFactor):
(WebKit):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::emulatedTextZoomFactor):
- 10:53 AM Changeset in webkit [112689] by
-
- 2 edits in trunk/LayoutTests
Skip some more failing tests.
- platform/mac/Skipped:
- 10:37 AM Changeset in webkit [112688] by
-
- 2 edits in trunk/LayoutTests
Skip fast/css/font-face-data-uri.html which is flaky.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=82744
- platform/mac/Skipped:
- 10:35 AM Changeset in webkit [112687] by
-
- 2 edits in trunk/LayoutTests
Skip a test, tracked by https://bugs.webkit.org/show_bug.cgi?id=82743.
- platform/mac/Skipped:
- 10:32 AM Changeset in webkit [112686] by
-
- 3 edits in branches/chromium/1084
Merge 112379 - Web Inspector: breakpoints are not shown in sidebar pane after reload.
https://bugs.webkit.org/show_bug.cgi?id=82351
Reviewed by Pavel Feldman.
Source/WebCore:
When UISourceCode is added to ScriptsPanel, it could already have breakpoints.
We should iterate over existing breakpoints and add them to sidebar pane.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
LayoutTests:
- inspector/debugger/set-breakpoint-expected.txt:
- inspector/debugger/set-breakpoint.html:
TBR=podivilov@chromium.org
BUG=120853
Review URL: https://chromiumcodereview.appspot.com/9958020
- 10:31 AM Changeset in webkit [112685] by
-
- 2 edits in trunk/LayoutTests
Skip two lineboxcontain tests. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82742
- platform/mac/Skipped:
- 10:27 AM Changeset in webkit [112684] by
-
- 3 edits in branches/chromium/1084/Source/WebCore/inspector/front-end
Merge 112677 - Web Inspector: ScriptsNavigator scripts selection/focus polish.
https://bugs.webkit.org/show_bug.cgi?id=82732
Reviewed by Pavel Feldman.
Script could be selected by space in ScriptsNavigator now.
This patch also polishes focus behavior when using ScriptsNavigator.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._scriptSelected): Added focusSource param to give clients possibility to release focus.
(WebInspector.NavigatorScriptTreeElement.prototype.onspace): Added script selection on space pressed.
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
- inspector/front-end/ScriptsPanel.js: _hideNavigatorOverlay moved to the end of events processing to set focus correctly.
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
- inspector/front-end/treeoutline.js:
(TreeOutline.prototype._treeKeyDown): onspace event added.
TBR=vsevik@chromium.org
BUG=121133
Review URL: https://chromiumcodereview.appspot.com/9956025
- 10:17 AM Changeset in webkit [112683] by
-
- 12 edits17 adds in trunk
Split up top-level .gitignore and .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=82687
Patch by David Barr <davidbarr@chromium.org> on 2012-03-30
Reviewed by Tor Arne Vestbø.
.:
Jeff King <peff@peff.net> suggested this on the git mailing list.
http://article.gmane.org/gmane.comp.version-control.git/194294
He reported a 1.6 times speed up for 'git status'.
- .gitattributes:
- .gitignore:
- ManualTests/.gitattributes: Added.
- Source/.gitignore: Added.
- Websites/.gitattributes: Added.
PerformanceTests:
- .gitattributes: Added.
Source/JavaScriptCore:
- JavaScriptCore.gyp/.gitignore: Added.
Source/Platform:
- Platform.gyp/.gitignore: Added.
Source/ThirdParty:
- glu/.gitignore: Added.
Source/WebCore:
No new tests, source control administrivia.
- .gitattributes: Added.
- WebCore.gyp/.gitignore: Added.
Source/WebKit/chromium:
- .gitignore: Added.
Source/WTF:
- WTF.gyp/.gitignore: Added.
Tools:
- .gitattributes: Added.
- .gitignore: Added.
- DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
- TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
LayoutTests:
- .gitattributes: Added.
- .gitignore: Added.
- 10:08 AM Changeset in webkit [112682] by
-
- 3 edits in trunk/Source/WebKit/chromium
pass alpha directly to player, rather than creating a layer (for performance)
https://bugs.webkit.org/show_bug.cgi?id=82360
Reviewed by Stephen White.
Performance change, existing webkit tests apply.
- public/WebMediaPlayer.h:
(WebMediaPlayer):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
- 10:01 AM Changeset in webkit [112681] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/ScriptsNavigator.js
Merge 112656 - Web Inspector: ScriptsNavigator should open scripts with single click (not double click).
https://bugs.webkit.org/show_bug.cgi?id=82723
Reviewed by Pavel Feldman.
This patch makes ScriptsNavigator open scripts with single click.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
TBR=vsevik@chromium.org
BUG=121087
Review URL: https://chromiumcodereview.appspot.com/9963015
- 9:53 AM Changeset in webkit [112680] by
-
- 5 edits in trunk/Source
[WinCE] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=82713
Reviewed by Eric Seidel.
Modify the #include declarations for several WinCE-related files
so that the wtf types are included using the full path.
Source/WebCore:
- platform/graphics/wince/ImageBufferWinCE.cpp:
Source/WebKit/wince:
- WebView.cpp:
- WebView.h:
- 9:50 AM Changeset in webkit [112679] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js
Merge 112661 - Web Inspector: [Regression] Execution line is not revealed after pretty print.
https://bugs.webkit.org/show_bug.cgi?id=82727
Reviewed by Pavel Feldman.
This patch makes JavaScriptSourceFrame reveal execution line after pretty print.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
TBR=vsevik@chromium.org
BUG=121091
Review URL: https://chromiumcodereview.appspot.com/9950021
- 9:47 AM Changeset in webkit [112678] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows (make based) build fix.
- JavaScriptCore.vcproj/JavaScriptCore.make: Copy WTF header files into a place where JavaScriptCore build can see them.
- 9:39 AM Changeset in webkit [112677] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: ScriptsNavigator scripts selection/focus polish.
https://bugs.webkit.org/show_bug.cgi?id=82732
Reviewed by Pavel Feldman.
Script could be selected by space in ScriptsNavigator now.
This patch also polishes focus behavior when using ScriptsNavigator.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._scriptSelected): Added focusSource param to give clients possibility to release focus.
(WebInspector.NavigatorScriptTreeElement.prototype.onspace): Added script selection on space pressed.
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
- inspector/front-end/ScriptsPanel.js: _hideNavigatorOverlay moved to the end of events processing to set focus correctly.
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
- inspector/front-end/treeoutline.js:
(TreeOutline.prototype._treeKeyDown): onspace event added.
- 9:33 AM Changeset in webkit [112676] by
-
- 2 edits in trunk/Source/WebCore
remove unneeded copies of SkPaths, remove unneeded save/restore
https://bugs.webkit.org/show_bug.cgi?id=82641
Reviewed by Stephen White.
Performance change, existing webkit tests apply.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
- 9:31 AM Changeset in webkit [112675] by
-
- 2 edits in trunk/Tools
Actually remove the ChromiumOS GTK builder, like r112673 said it would.
- TestResultServer/static-dashboards/builders.js:
- 9:24 AM Changeset in webkit [112674] by
-
- 4 edits2 adds in trunk
Web Inspector: undo-ing edit that consists of a Tab does not work.
https://bugs.webkit.org/show_bug.cgi?id=82733
Reviewed by Vsevolod Vlasov.
Source/WebCore:
We should never modify the range returned by the edit operation manually.
And we should clone ranges that get into the model so that subsequent edits
don't mutate them.
Drive-by: restore selection after undo via selecting all the text that undo
operation produced.
Test: inspector/editor/text-editor-undo-redo.html
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/TextViewer.js:
LayoutTests:
- inspector/editor/text-editor-undo-redo-expected.txt: Added.
- inspector/editor/text-editor-undo-redo.html: Added.
- 9:23 AM Changeset in webkit [112673] by
-
- 2 edits in trunk/Tools
Update ChromiumOS bot names in builders.js to reflect changes made by
http://crrev.com/129835
Also removes the ChromiumOS GTK builder, which was removed by
http://crrev.com/129835
- TestResultServer/static-dashboards/builders.js:
- 9:18 AM Changeset in webkit [112672] by
-
- 2 edits in trunk/Tools
[GTK] Disable introspection build in the at-spi2-core module.
https://bugs.webkit.org/show_bug.cgi?id=82729
Patch by Vineet Chaudhary <Vineet> on 2012-03-30
Reviewed by Philippe Normand.
This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
- gtk/jhbuild.modules: Disable introspection.
- 9:00 AM Changeset in webkit [112671] by
-
- 177 edits in trunk/LayoutTests
Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423
Unreviewed gardening after r112667.
- platform/qt/svg/ [...] : Updated.
- 8:57 AM Changeset in webkit [112670] by
-
- 8 edits in trunk/Source/WebCore
[wx] Implement Gradient and ImageBuffer support.
https://bugs.webkit.org/show_bug.cgi?id=82710
Reviewed by Kevin Ollivier.
- 8:47 AM Changeset in webkit [112669] by
-
- 16 edits2 adds in trunk
[Qt] Find zoomable area using area-based hit-testing
https://bugs.webkit.org/show_bug.cgi?id=82609
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-30
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Implement API for calculating the best zoomable area for a
tap-to-zoom gesture.
It picks the area with the largest intersection with the touch. In most
cases this will be all areas fully containing the area, and returns the
smallest inner-most of these.
- page/EventHandler.cpp:
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
- page/EventHandler.h:
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeIsZoomTarget):
(WebCore::TouchAdjustment::appendZoomableSubtargets):
(WebCore::TouchAdjustment::compileZoomableSubtargets):
(WebCore::TouchAdjustment::areaOfIntersection):
(WebCore::TouchAdjustment::findAreaWithLargestIntersection):
(WebCore::findBestZoomableArea):
- page/TouchAdjustment.h:
- platform/graphics/IntSize.h:
(WebCore::IntSize::area):
Source/WebKit2:
Add area to findZoomableAreaForPoint and use new TOUCH_ADJUSTMENT
code-path to find the best zoomable area.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findZoomableAreaForPoint):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleDoubleTapEvent):
- WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::WebPage::findZoomableAreaForPoint):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- 8:44 AM Changeset in webkit [112668] by
-
- 3 edits2 adds in trunk
Web Inspector: do not issue attributes modified event if actual values were not changed.
https://bugs.webkit.org/show_bug.cgi?id=82726
Reviewed by Yury Semikhatsky.
Source/WebCore:
When style attribute is invalidated, we re-fetch the attributes values. There is no
point in further dispatching attrs modified event if model stays the same.
Test: inspector/elements/edit-style-attribute.html
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._setAttributesPayload):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
LayoutTests:
- inspector/elements/edit-style-attribute-expected.txt: Added.
- inspector/elements/edit-style-attribute.html: Added.
- 8:37 AM Changeset in webkit [112667] by
-
- 251 edits6 adds in trunk
Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423
Patch by Philip Rogers <pdr@google.com> on 2012-03-30
Reviewed by Eric Seidel.
Source/WebCore:
This patch introduces a special renderer for SVGCircleElements
and SVGEllipseElements to avoid having to use the slower path
rendering code. This patch includes optimized circle code for
the CG platform, and hooks (GC::fillEllipse, GC::strokeEllipse)
are available for other platforms as well.
Tests: svg/hittest/svg-ellipse-non-scale-stroke.xhtml
svg/hittest/svg-ellipse.xhtml
Added a test to exercise hit testing on an ellipse, and on
an ellipse's stroke, to make sure the formulae in this patch
are correct.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillEllipse):
(WebCore):
(WebCore::GraphicsContext::strokeEllipse):
(WebCore::GraphicsContext::fillEllipseAsPath):
(WebCore::GraphicsContext::strokeEllipseAsPath):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore):
(WebCore::GraphicsContext::platformStrokeEllipse):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore):
(WebCore::GraphicsContext::platformStrokeEllipse):
- rendering/svg/RenderSVGAllInOne.cpp:
- rendering/svg/RenderSVGEllipse.cpp: Added.
(WebCore):
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::~RenderSVGEllipse):
(WebCore::RenderSVGEllipse::createShape):
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
(WebCore::RenderSVGEllipse::objectBoundingBox):
(WebCore::RenderSVGEllipse::strokeBoundingBox):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains):
- rendering/svg/RenderSVGEllipse.h: Added.
(WebCore):
(RenderSVGEllipse):
(WebCore::RenderSVGEllipse::isSVGEllipse):
(WebCore::RenderSVGEllipse::renderName):
(WebCore::RenderSVGEllipse::isEmpty):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
(WebCore):
(WebCore::SVGCircleElement::createRenderer):
- svg/SVGCircleElement.h:
(SVGCircleElement):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
(WebCore::SVGEllipseElement::createRenderer):
(WebCore):
- svg/SVGEllipseElement.h:
(SVGEllipseElement):
LayoutTests:
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
- platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
- platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
- platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.txt:
- platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/mac/svg/batik/text/verticalText-expected.txt:
- platform/mac/svg/carto.net/button-expected.txt:
- platform/mac/svg/clip-path/clip-in-mask-expected.txt:
- platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
- platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
- platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
- platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
- platform/mac/svg/clip-path/clip-path-pixelation-expected.txt:
- platform/mac/svg/clip-path/clip-path-transform-1-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
- platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
- platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
- platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
- platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
- platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
- platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/mac/svg/custom/circle-move-invalidation-expected.txt:
- platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
- platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
- platform/mac/svg/custom/dasharrayOrigin-expected.txt:
- platform/mac/svg/custom/focus-ring-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
- platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
- platform/mac/svg/custom/linking-uri-01-b-expected.txt:
- platform/mac/svg/custom/marker-opacity-expected.txt:
- platform/mac/svg/custom/mask-colorspace-expected.txt:
- platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
- platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
- platform/mac/svg/custom/object-sizing-expected.txt:
- platform/mac/svg/custom/object-sizing-explicit-height-expected.txt:
- platform/mac/svg/custom/object-sizing-explicit-width-expected.txt:
- platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt:
- platform/mac/svg/custom/object-sizing-no-width-height-expected.txt:
- platform/mac/svg/custom/path-zero-strokewidth-expected.txt:
- platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt:
- platform/mac/svg/custom/pattern-no-pixelation-expected.txt:
- platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt:
- platform/mac/svg/custom/pattern-rotate-expected.txt:
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
- platform/mac/svg/custom/stroked-pattern-expected.txt:
- platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
- platform/mac/svg/custom/use-css-events-expected.txt:
- platform/mac/svg/custom/use-detach-expected.txt:
- platform/mac/svg/custom/use-elementInstance-methods-expected.txt:
- platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
- platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
- platform/mac/svg/custom/use-modify-target-container-expected.txt:
- platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
- platform/mac/svg/custom/use-on-g-expected.txt:
- platform/mac/svg/custom/use-on-use-expected.txt:
- platform/mac/svg/custom/use-transform-expected.txt:
- platform/mac/svg/custom/width-full-percentage-expected.txt:
- platform/mac/svg/filters/feDropShadow-expected.txt:
- platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt:
- platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt:
- platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt:
- platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt:
- platform/mac/svg/filters/feImage-late-indirect-update-expected.txt:
- platform/mac/svg/hixie/cascade/001-broken-expected.txt:
- platform/mac/svg/hixie/cascade/002-expected.txt:
- platform/mac/svg/hixie/error/001-expected.txt:
- platform/mac/svg/hixie/error/003-expected.txt:
- platform/mac/svg/hixie/error/017-expected.txt:
- platform/mac/svg/hixie/mixed/003-expected.txt:
- platform/mac/svg/hixie/mixed/004-expected.txt:
- platform/mac/svg/hixie/mixed/005-expected.txt:
- platform/mac/svg/hixie/mixed/006-expected.txt:
- platform/mac/svg/hixie/mixed/008-expected.txt:
- platform/mac/svg/hixie/mixed/011-expected.txt:
- platform/mac/svg/hixie/perf/001-expected.txt:
- platform/mac/svg/hixie/perf/002-expected.txt:
- platform/mac/svg/hixie/perf/007-expected.txt:
- platform/mac/svg/hixie/rendering-model/001-expected.txt:
- platform/mac/svg/hixie/rendering-model/002-expected.txt:
- platform/mac/svg/hixie/shapes/path/001-expected.txt:
- platform/mac/svg/hixie/transform/001-expected.txt:
- platform/mac/svg/in-html/circle-expected.txt:
- platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
- platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
- platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
- platform/mac/svg/text/small-fonts-3-expected.txt:
- platform/mac/svg/text/text-align-01-b-expected.txt:
- platform/mac/svg/text/text-align-05-b-expected.txt:
- platform/mac/svg/text/text-fill-opacity-expected.txt:
- platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/mac/svg/wicd/rightsizing-grid-expected.txt:
- platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
- platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
- platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
- platform/qt/Skipped:
- platform/win/Skipped:
- svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt:
- svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt:
- svg/clip-path/clip-path-childs-clipped-expected.txt:
- svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
- svg/clip-path/clip-path-clipped-expected.txt:
- svg/clip-path/clip-path-clipped-nonzero-expected.txt:
- svg/clip-path/clip-path-css-transform-1-expected.txt:
- svg/clip-path/clip-path-css-transform-2-expected.txt:
- svg/clip-path/clip-path-objectBoundingBox-expected.txt:
- svg/clip-path/clip-path-on-clipped-use-expected.txt:
- svg/clip-path/clip-path-on-g-and-child-expected.txt:
- svg/clip-path/clip-path-on-g-expected.txt:
- svg/clip-path/clip-path-on-svg-and-child-expected.txt:
- svg/clip-path/clip-path-on-svg-expected.txt:
- svg/clip-path/clip-path-transform-2-expected.txt:
- svg/clip-path/clip-path-use-as-child-expected.txt:
- svg/css/circle-in-mask-with-shadow-expected.txt:
- svg/css/mask-with-shadow-expected.txt:
- svg/custom/absolute-root-position-masking-expected.txt:
- svg/custom/fill-opacity-update-expected.txt:
- svg/custom/gradient-stroke-width-expected.txt:
- svg/custom/js-late-marker-and-object-creation-expected.txt:
- svg/custom/js-late-marker-creation-expected.txt:
- svg/custom/js-update-bounce-expected.txt:
- svg/custom/marker-changes-expected.txt:
- svg/custom/marker-child-changes-css-expected.txt:
- svg/custom/marker-child-changes-expected.txt:
- svg/custom/marker-strokeWidth-changes-expected.txt:
- svg/custom/marker-viewBox-changes-expected.txt:
- svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt:
- svg/custom/pattern-scaled-pattern-space-expected.txt:
- svg/custom/resource-invalidate-on-target-update-expected.txt:
- svg/custom/stroke-opacity-update-expected.txt:
- svg/custom/use-setAttribute-crash-expected.txt:
- svg/custom/viewBox-hit-expected.txt:
- svg/filters/feImage-reference-svg-primitive-expected.txt:
- svg/filters/filter-clip-expected.txt:
- svg/filters/invalidate-on-child-layout-expected.txt:
- svg/hittest/svg-ellipse-expected.txt: Added.
- svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Added.
- svg/hittest/svg-ellipse-non-scale-stroke.xhtml: Added.
- svg/hittest/svg-ellipse.xhtml: Added.
- svg/hixie/links/001-expected.txt:
- 8:32 AM Changeset in webkit [112666] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update expectations for XP.
- platform/chromium/test_expectations.txt:
- 7:51 AM Changeset in webkit [112665] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, more expectations for BUGWK82505.
- platform/chromium/test_expectations.txt:
- 7:04 AM Changeset in webkit [112664] by
-
- 15 edits in trunk
Add a "preview" state to Page Visibility API implementation
https://bugs.webkit.org/show_bug.cgi?id=81355
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-03-30
Reviewed by Adam Barth.
Updating the Page Visibility API implementation to the current spec version.
Source/WebCore:
This change is covered by fast/events/page-visibility-transition-test.html,
so no new tests needed.
- page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
- page/PageVisibilityState.h:
Source/WebKit/chromium:
- public/WebPageVisibilityState.h:
- src/AssertMatchingEnums.cpp:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
Source/WebKit/efl:
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_view.h:
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setPageVisibility):
LayoutTests:
- fast/events/page-visibility-transition-test-expected.txt:
- fast/events/page-visibility-transition-test.html:
- 6:36 AM Changeset in webkit [112663] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, updated fast/frames/valid.html expectation for LEOPARD.
- platform/chromium/test_expectations.txt:
- 6:35 AM Changeset in webkit [112662] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip another asserting test on debug build
https://bugs.webkit.org/show_bug.cgi?id=82052
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-03-30
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped: Skip asserting test.
- 6:31 AM Changeset in webkit [112661] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Regression] Execution line is not revealed after pretty print.
https://bugs.webkit.org/show_bug.cgi?id=82727
Reviewed by Pavel Feldman.
This patch makes JavaScriptSourceFrame reveal execution line after pretty print.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
- 6:24 AM Changeset in webkit [112660] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: preload field values into local variables for better heap profiler performance
https://bugs.webkit.org/show_bug.cgi?id=82703
Reading from object fields takes a noticable time when the only other thing you do
is just manipulating on big(several million elements) Uint32Array array cells.
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._createContainmentEdgesArray):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
- 6:17 AM Changeset in webkit [112659] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r112489.
http://trac.webkit.org/changeset/112489
https://bugs.webkit.org/show_bug.cgi?id=82725
Tentatively introduces a lot of webfont-related test flakiness
on Snow Leopard (Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-30
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):
- 6:15 AM Changeset in webkit [112658] by
-
- 53 edits in trunk
Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
https://bugs.webkit.org/show_bug.cgi?id=80972
Reviewed by Kent Tamura.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- configure.ac:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.exp.in:
- css/html.css:
- html/ColorInputType.cpp:
- html/ColorInputType.h:
- html/HTMLInputElement.cpp:
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
(WebCore):
(InputTypeNames):
- html/InputType.h:
(InputType):
(InputTypeNames):
- loader/EmptyClients.h:
(EmptyChromeClient):
- page/Chrome.cpp:
(WebCore):
- page/Chrome.h:
(WebCore):
(Chrome):
- page/ChromeClient.h:
(WebCore):
(ChromeClient):
- platform/ColorChooser.h:
- platform/ColorChooserClient.h:
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isColorInputField):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
Source/WebKit/chromium:
- features.gypi:
- src/ChromeClientImpl.cpp:
(WebKit):
- src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
- src/ColorChooserProxy.cpp:
- src/ColorChooserProxy.h:
- src/WebColorChooserClientImpl.cpp:
- src/WebColorChooserClientImpl.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-webkit:
- qmake/mkspecs/features/features.prf:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
- platform/efl/Skipped:
- platform/qt/Skipped:
- 6:12 AM Changeset in webkit [112657] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] EventLoop::platformInit() obsolete.
https://bugs.webkit.org/show_bug.cgi?id=82709
Reviewed by Rob Buis.
No new tests, build fix for BlackBerry porting.
- platform/blackberry/EventLoopBlackBerry.cpp:
- 6:10 AM Changeset in webkit [112656] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: ScriptsNavigator should open scripts with single click (not double click).
https://bugs.webkit.org/show_bug.cgi?id=82723
Reviewed by Pavel Feldman.
This patch makes ScriptsNavigator open scripts with single click.
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
- 5:50 AM Changeset in webkit [112655] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update expectations.
- platform/chromium/test_expectations.txt:
- 5:27 AM Changeset in webkit [112654] by
-
- 3 edits in trunk
[BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=82594
Reviewed by Rob Buis.
Upstreaming feature enablers in cmakeconfig.h.cmake for BlackBerry porting,
and clean up obsolete MACROs in OptionsBlackBerry.cmake.
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmakeconfig.h.cmake:
- 4:54 AM Changeset in webkit [112653] by
-
- 14 edits in trunk/Source/WebCore
IDLParser.pm should be able to parse sequence<T> as method argument.
https://bugs.webkit.org/show_bug.cgi?id=82599
Patch by Vineet Chaudhary <Vineet> on 2012-03-30
Reviewed by Kentaro Hara.
With this patch IDL parser should support sequence<T> as method argument.
Current behaviour is argument name is not parsed hence shows empty spaces instead.
Tests: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorCPP.pm:
(SkipFunction): Skip functions for specific type.
(SkipAttribute): Skip functions for specific type.
(AddIncludesForType): Skip header for sequence<T> type.
(GenerateHeader): Skip header and declaration for sequence<T> type.
(GenerateImplementation): Skip header and implementation for sequence<T> type.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip functions for sequence<T> type.
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction): Skip functions for specific type.
(SkipAttribute): Skip functions for specific type.
(AddForwardDeclarationsForType): Skip header for sequence<T> type.
(AddIncludesForType): Skip header for sequence<T> type.
(GenerateHeader):Skip header and declaration for sequence<T> type.
(GenerateImplementation): Skip header and implementation for sequence<T> type.
- bindings/scripts/CodeGeneratorV8.pm:
(CreateCustomSignature): Add appropriate headers.
- bindings/scripts/IDLStructure.pm: Add support to parse sequence<T>.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: Modified results from run-binding-tests.
(WebDOMTestObj::objMethodWithArgs):
- bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
(webkit_dom_test_obj_obj_method_with_args):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::ConfigureV8TestObjTemplate):
- 4:36 AM Changeset in webkit [112652] by
-
- 11 edits2 adds in trunk
Web Inspector: editing resets line-ending of the whole file
https://bugs.webkit.org/show_bug.cgi?id=82708
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change splits TextEditorModel's setText into setText (for initialization) and
editRange (for editing). Distinguishing between the two allowed properly detecting
the preferred line endings.
Test: inspector/editor/text-editor-line-breaks.html
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorCommand):
(WebInspector.TextEditorModel):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextEditorMainPanel.prototype._unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype._unindentLines):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._editRange):
LayoutTests:
- inspector/editor/highlighter-basics.html:
- inspector/editor/highlighter-long-line.html:
- inspector/editor/highlighter-paste-in-comment.html:
- inspector/editor/indentation.html:
- inspector/editor/text-editor-line-breaks-expected.txt: Added.
- inspector/editor/text-editor-line-breaks.html: Added.
- inspector/editor/text-editor-model.html:
- 4:00 AM Changeset in webkit [112651] by
-
- 21 edits in trunk
[Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
https://bugs.webkit.org/show_bug.cgi?id=82195
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-29
Reviewed by Simon Hausmann.
Source/WebKit/qt:
- declarative/experimental/plugin.cpp:
- declarative/plugin.cpp:
(WebKitQmlPlugin::initializeEngine):
Source/WebKit2:
- UIProcess/API/qt/qquicknetworkreply_p.h:
- UIProcess/API/qt/qquicknetworkrequest_p.h:
- UIProcess/API/qt/qquickwebview.cpp:
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qwebiconimageprovider_p.h:
- UIProcess/API/qt/qwebnavigationhistory.cpp:
- UIProcess/API/qt/qwebnavigationhistory_p.h:
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
- UIProcess/qt/QtDialogRunner.cpp:
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):
- UIProcess/qt/QtFlickProvider.cpp:
- UIProcess/qt/QtFlickProvider.h:
(QtFlickProvider):
- UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):
Tools:
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/main.cpp:
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
- qmake/mkspecs/features/unix/default_post.prf:
- 3:14 AM Changeset in webkit [112650] by
-
- 4 edits1 move in trunk
Web Inspector: Take IndexedDB support out of experiments.
https://bugs.webkit.org/show_bug.cgi?id=82635
Reviewed by Pavel Feldman.
Source/WebCore:
This patch takes inspector IndexedDB support out of experiments and enables tests.
Test: http/tests/inspector/indexeddb/resources-panel.html
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
LayoutTests:
- http/tests/inspector/indexeddb/resources-panel.html: Renamed from LayoutTests/http/tests/inspector/indexeddb/resources-panel.html_disabled.
- 3:06 AM Changeset in webkit [112649] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, more CRASH expectations for BUGWK82505 added.
- platform/chromium/test_expectations.txt:
- 3:03 AM Changeset in webkit [112648] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r112482.
- platform/network/cf/FormDataStreamCFNet.h: Added missing forward decleration.
- 2:46 AM Changeset in webkit [112647] by
-
- 4 edits in trunk
[EFL] Implement LayoutTestController::setMinimumTimerInterval
https://bugs.webkit.org/show_bug.cgi?id=81220
Tools:
Add missing implementation setMinimumTimerInterval to EFL's
LayoutTestController so that we can unskip related tests from the skip list.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-30
Reviewed by Philippe Normand.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setMinimumTimerInterval):
LayoutTests:
Unskip tests connected with setMinimumTimerInterval.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-30
Reviewed by Philippe Normand.
- platform/efl/Skipped:
- 12:45 AM Changeset in webkit [112646] by
-
- 2 edits in trunk/Source/WebCore
[GTK] WebAudio channelSize issue
https://bugs.webkit.org/show_bug.cgi?id=81905
Reviewed by Martin Robinson.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleBuffer): Calculate the audio
buffer duration and frames number from the buffer and caps instead
of relying on the buffer offets that are not always correctly set
depending on the audio file format.
- 12:43 AM Changeset in webkit [112645] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r112582 and r112391.
- platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
- platform/gtk/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
