Context Navigation

← Previous Period
Next Period →

Timeline

Apr 1, 2012:

11:54 PM Changeset in webkit [112832] by abarth@webkit.org

6 edits
2 copies
1 move
2 adds in trunk/Source

[Chromium] Move thread-related APIs from WebKit into Platform
https://bugs.webkit.org/show_bug.cgi?id=82858

Reviewed by Eric Seidel.

Source/Platform:

Platform.gypi:
chromium/public/WebThread.h: Copied from Source/WebKit/chromium/public/platform/WebThread.h.
chromium/public/WebThreadSafeData.h: Copied from Source/WebKit/chromium/public/platform/WebThreadSafeData.h.

Source/WebCore:

This is part of the change discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

WebCore.gypi:
platform/chromium/support/WebThreadSafeData.cpp: Copied from Source/WebKit/chromium/src/WebThreadSafeData.cpp.

Source/WebKit/chromium:

WebKit.gyp:
public/platform/WebThread.h: Replaced.
public/platform/WebThreadSafeData.h: Replaced.
src/WebThreadSafeData.cpp: Removed.

10:21 PM Changeset in webkit [112831] by rniwa@webkit.org

2 edits in trunk

Perf-o-matic build fix after 112829 for Chromium-style tests.

Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

10:07 PM Changeset in webkit [112830] by tkent@chromium.org

5 edits in trunk/Source/WebCore

Fix some problems of text field decoration
https://bugs.webkit.org/show_bug.cgi?id=82693

Reviewed by Dimitri Glazkov.

Fix a problem that decorations are not removed when the input type is

changed.

Add a comment to the 'willDetach' callback.

No new tests because the behavior changes are not visible yet.

GNUMakefile.list.am: Add HTMLShadowElement.*.
html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):
Remove all of ShadowRoot contents, and add a <shadow> element to each of
them. We don't remove ShadowRoots from the tree because it's not
supported well.

html/shadow/TextFieldDecorationElement.cpp:

(getDecorationRootAndDecoratedRoot): A helper function for decorate().
If the input element has a ShadowRoot with single <shadow> child, we
don't create new ShadowRoot and reuse it.
(WebCore::TextFieldDecorationElement::decorate):
Use getDecorationRootAndDecoratedRoot().

html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorator): Add a comment to willDetach().

9:48 PM Changeset in webkit [112829] by rniwa@webkit.org

7 edits in trunk

perf-o-matic should store test results' units
https://bugs.webkit.org/show_bug.cgi?id=82852

Reviewed by Kentaro Hara.

Websites/webkit-perf.appspot.com/models.py:

(Test):
(Test.update_or_insert): Added "unit" to the argument list.
(Test.update_or_insert.execute): Store the unit.
(ReportLog.results_are_well_formed): Moved from ReportHandler.
(ReportLog.results_are_well_formed._is_float_convertible): Ditto.

Websites/webkit-perf.appspot.com/models_unittest.py:

(TestModelTests.test_update_or_insert): Added a test case for "unit" argument.
(TestModelTests.test_update_or_insert_to_update): Ditto.
(ReportLogTests.test_results_are_well_formed): Added.
(ReportLogTests.test_results_are_well_formed.assert_results_are_well_formed): Added.

Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post): Calls ReportLog.results_are_well_formed.

Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post): Passes resultsunit to Test.update_or_insert.

Tools:

Include units in the results JSON.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

9:36 PM Changeset in webkit [112828] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

Fix incorrect path for libWTF.a in Mac project file.

JavaScriptCore.xcodeproj/project.pbxproj: Removed the "../Release" prefix that

would cause other configurations to try to link with the "Release" version of
libWTF.a instead of the correct version.

9:17 PM FeatureFlags edited by tkent@chromium.org

Rename INPUT_COLOR to INPUT_TYPE_COLOR (diff)

8:51 PM Changeset in webkit [112827] by abarth@webkit.org

2 edits in trunk/Websites/bugs.webkit.org

Code review tool no longer needs to work around position:fixed handling on iPad
https://bugs.webkit.org/show_bug.cgi?id=82850

Reviewed by Eric Seidel.

We no longer need to avoid position:fixed on iPad because Mobile Safari
now does something reasonable with position:fixed elements.

code-review.js:

7:53 PM Changeset in webkit [112826] by commit-queue@webkit.org

5 edits in trunk

[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <li.yin@intel.com> on 2012-04-01
Reviewed by Kent Tamura.

Source/WebCore:

When it had no negotiated deflate-frame extension, if browser received the frame with
setting compressed bit, it should fail the connection, and it should cover both
enabling ZLIB port and disabling ZLIB port.

Test: http/tests/websocket/tests/hybi/reserved-bits.html

Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketDeflateFramer::inflate):

LayoutTests:

Solve the problem that Qt Webkit failed when runing the reserved-bits.html
Support both enabled ZLIB and disabled ZLIB scenarios.

http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
http/tests/websocket/tests/hybi/reserved-bits_wsh.py:

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):

7:43 PM Changeset in webkit [112825] by abarth@webkit.org

11 edits in trunk

Clean up Document::canNavigate
https://bugs.webkit.org/show_bug.cgi?id=82282

Reviewed by Eric Seidel.

Source/WebCore:

This patch is just a minor clean up to Document::canNavigate. Eric
asked me to clean up the function when I moved it from FrameLoader. I'm
not sure this patch is much of a win, but at least the comments say
things that are more sensible now.

dom/Document.cpp:

(WebCore::printNavigationErrorMessage):
(WebCore):
(WebCore::Document::canNavigate):

LayoutTests:

Update these test results to show that we're better at printing error
messages now.

http/tests/security/no-popup-from-sandbox-top-expected.txt:
http/tests/security/sandboxed-iframe-form-top-expected.txt:

7:12 PM Changeset in webkit [112824] by rniwa@webkit.org

3 edits in trunk

Admin page should lexicologically sort tests
https://bugs.webkit.org/show_bug.cgi?id=82849

Rubber-stamped by Hajime Morita.

Websites/webkit-perf.appspot.com/js/admin.js:
Websites/webkit-perf.appspot.com/js/config.js:

(sortProperties):
(fetchDashboardManifest):

6:55 PM Changeset in webkit [112823] by rniwa@webkit.org

2 edits in trunk

Revert an inadvertently committed change.

Websites/webkit-perf.appspot.com/app.yaml:

6:46 PM Changeset in webkit [112822] by rniwa@webkit.org

11 edits in trunk

perf-o-matic should have a way to hide some platforms and tests
https://bugs.webkit.org/show_bug.cgi?id=82842

Reviewed by Hajime Morita.

Websites/webkit-perf.appspot.com/admin.html:
Websites/webkit-perf.appspot.com/admin_handlers.py:

(AdminDashboardHandler.get_branches): Change the json format to allow platforms and tests to have
"hidden" boolean states.
(AdminDashboardHandler.get_platforms): Ditto.
(AdminDashboardHandler.get_builders): Just a cleanup. There is no clean for it to have a limit.
(AdminDashboardHandler.get_tests): Change the json format to add "hidden" boolean states.
(ChangeVisibilityHandler): Added.
(ChangeVisibilityHandler.post): Added. Changes the hidden-state (visibility) of a platform and a test.

Websites/webkit-perf.appspot.com/app.yaml: Make sure everything under /admin/ requires admin privilege.
Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post): Don't emit LF after 'OK'.

Websites/webkit-perf.appspot.com/css/admin.css: Added a bunch of rules for hide/show button.
Websites/webkit-perf.appspot.com/js/admin.js:

(submitXHR): Extracted.
(createKeyNameReloader): Added hide/show button on each item and the corresponding ajax request.

Websites/webkit-perf.appspot.com/json_generators.py:

(DashboardJSONGenerator.init): Skip hidden tests and platforms.
(ManifestJSONGenerator.init): Ditto.

Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added tests to ensure perf-o-matic

doesn't include hidden tests and platforms in dashboard and manifest json responses.
(DashboardJSONGeneratorTest.test_value_with_hidden_platform_and_tesst):
(ManifestJSONGeneratorTest.test_value_two_tests):
(ManifestJSONGeneratorTest.test_value_with_hidden_platform_and_test):

Websites/webkit-perf.appspot.com/main.py:
Websites/webkit-perf.appspot.com/models.py:

(Platform): Added the "hidden" property.
(Test): Ditto. Also removed the comment about this class only exists for efficiency purposes since that's
no longer true.

5:27 PM April 2012 Meeting edited by rniwa@webkit.org

(diff)

5:26 PM April 2012 Meeting edited by rniwa@webkit.org

Add more hackathon ideas (diff)

4:15 PM Changeset in webkit [112821] by jonlee@apple.com

21 edits in trunk/Source

Rename notification properties and functions
https://bugs.webkit.org/show_bug.cgi?id=80482
<rdar://problem/10912432>

Reviewed by Kentaro Hara.

Source/WebCore:

Change method name to close(), and set tag property on Notifications, based on discussions in WG:
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

notifications/Notification.cpp:

(WebCore::Notification::~Notification): Use close().
(WebCore::Notification::close):

notifications/Notification.h:

(Notification):
(WebCore::Notification::cancel): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use close().
(WebCore::Notification::replaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use tag().
(WebCore::Notification::setReplaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use setTag().
(WebCore::Notification::tag):
(WebCore::Notification::setTag):

notifications/Notification.idl: Preserve cancel() and replaceID in ENABLE(LEGACY_NOTIFICATIONS), and

close() and tag in ENABLE(NOTIFICATIONS).

Source/WebKit/chromium:

src/WebNotification.cpp:

(WebKit::WebNotification::replaceId): Refactor to call tag().

Source/WebKit/mac:

WebView/WebNotification.h: Rename replaceID to tag.
WebView/WebNotification.mm:

(-[WebNotification tag]):

Source/WebKit/qt:

WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::show): Refactor to call tag().
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): Refactor to call tag().

Source/WebKit2:

Rename APIs to use tag.

UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyTag):

UIProcess/API/C/WKNotification.h:
UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::tag):
(WebNotification):

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

UIProcess/WebPageProxy.h:

(WebPageProxy):

UIProcess/WebPageProxy.messages.in:
WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

4:12 PM Changeset in webkit [112820] by eric@webkit.org

4 edits
11 deletes in trunk

Unreviewed, rolling out r112760.
http://trac.webkit.org/changeset/112760
https://bugs.webkit.org/show_bug.cgi?id=82795

Revert addition of webkitseamless. I'll do this work on
GitHub instead to avoid any half-implemented feature concerns.

Source/WebCore:

html/HTMLAttributeNames.in:
html/HTMLIFrameElement.idl:

LayoutTests:

fast/frames/seamless/resources/css-cascade-child.html: Removed.
fast/frames/seamless/resources/nested-seamless.html: Removed.
fast/frames/seamless/resources/square.html: Removed.
fast/frames/seamless/seamless-basic-expected.txt: Removed.
fast/frames/seamless/seamless-basic.html: Removed.
fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
fast/frames/seamless/seamless-css-cascade.html: Removed.
fast/frames/seamless/seamless-nested-expected.txt: Removed.
fast/frames/seamless/seamless-nested.html: Removed.
fast/frames/seamless/seamless-sandbox-flag-expected.txt: Removed.
fast/frames/seamless/seamless-sandbox-flag.html: Removed.

2:22 PM Changeset in webkit [112819] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Simplify the code that gets accelerated compositing output onto the screen
https://bugs.webkit.org/show_bug.cgi?id=82845

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-01
Reviewed by Rob Buis.

RIM PR: 136381
The code accounted for a now obsolete setup where we used one OpenGL
window for accelerated compositing and one native window for backing
store output, and let the windowing system composite those two. In that
setup an optimization to try and only update the window that had
changed was viable.

Nowadays, we either use an offscreen surface for accelerated
compositing output, which we blend onto the window containing the
backing store output, or render both backing store and accelerated
compositing output directly to one OpenGL window. We always have to
blit the backingstore contents and draw the accelerated compositing
output every frame with these code paths, so don't try to be clever
about it.

Even when we use an OpenGL window, the compositing surface can be non-
null, so don't try to glFinish() and swap the compositing surface when
the GLES2Context is tied to a window.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(WebKit):

Api/BackingStore_p.h:

(BackingStorePrivate):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):

WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::swapBuffers):

1:23 PM Changeset in webkit [112818] by timothy@apple.com

2 edits in trunk/Source/WebCore

Fix a crash when closing a tab/window while the Web Inspector is stopped in the debugger.

https://webkit.org/b/82846
rdar://problem/8133494

Reviewed by Yury Semikhatsky.

bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::didPause): Added assert for page and early return. Also assert that
m_pausedPage is null.
(WebCore::PageScriptDebugServer::didContinue): Page can be null if we are continuing because the Page closed.
So add a null check before using it. Added an assert that the page is null or m_pausedPage.
(WebCore::PageScriptDebugServer::didRemoveLastListener): Added assert for page.

11:40 AM Changeset in webkit [112817] by mitz@apple.com

3 edits in trunk/LayoutTests

Corrected the expected results for this test.

platform/mac/fast/text/international/text-spliced-font-expected.png:
platform/mac/fast/text/international/text-spliced-font-expected.txt:

11:21 AM Changeset in webkit [112816] by mitz@apple.com

18 edits
5 copies in trunk

Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).

When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.

To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

Added test LayoutTests/fast/text/international/text-spliced-font.html

WebCore.exp.in:

Replaced obsolete FontPlatformData constructor entry.

platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.

(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.

platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.

(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.

(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.

(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.

platform/graphics/SimpleFontData.h:

(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.

(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.

(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.

platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.

platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.

(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.

Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

A new test font of this kind as been added to the test tools for running the webkit-tests

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

DumpRenderTree/fonts/SampleFont.sfont: Added.

DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(activateTestingFonts):
Added the registration of the Composite Font Referene sample font

WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

WebKitTestRunner/fonts/SampleFont.sfont: Added.

LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

Added new LayoutTests/fast/text/international/text-spliced-font.html

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

fast/text/international/text-spliced-font.html: Added.
platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.

8:09 AM Changeset in webkit [112815] by gyuyoung.kim@samsung.com

22 edits
39 adds in trunk

Support the Network Information API
https://bugs.webkit.org/show_bug.cgi?id=73528

Reviewed by Adam Barth.

Add network information API feature.

Source/cmake/OptionsEfl.cmake: Add NETWORK_INFO feature.
Source/cmakeconfig.h.cmake: Add NETWORK_INFO feature.

Source/WebCore:

Network Information APIs is to provide an interface for Web Applications to access
the underlying network information of device. In Web Application case, they need to know
what current network interface it uses. Because, it is important to know current network
information(bandwidth, metered) in mobile domain. Thus, Web Application can let user know
whether current network information via this new functionality. In addition, in streaming
service case, Web Application can control content resolution according to kind of network.

http://dvcs.w3.org/hg/dap/raw-file/tip/network-api/index.html

Tests: networkinformation/add-listener-from-callback.html

networkinformation/basic-all-types-of-events.html
networkinformation/basic-operation.html
networkinformation/event-after-navigation.html
networkinformation/multiple-frames.html
networkinformation/updates.html
networkinformation/window-property.html

CMakeLists.txt:
Modules/networkinfo/NavigatorNetworkInfoConnection.cpp: Added.

(WebCore):
(WebCore::NavigatorNetworkInfoConnection::NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::~NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::from):
(WebCore::NavigatorNetworkInfoConnection::webkitConnection):

Modules/networkinfo/NavigatorNetworkInfoConnection.h: Added.

(WebCore):
(NavigatorNetworkInfoConnection):

Modules/networkinfo/NavigatorNetworkInfoConnection.idl: Added.
Modules/networkinfo/NetworkInfo.cpp: Added.

(WebCore):
(WebCore::NetworkInfo::NetworkInfo):

Modules/networkinfo/NetworkInfo.h: Added.

(WebCore):
(NetworkInfo):
(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(WebCore::NetworkInfo::metered):

Modules/networkinfo/NetworkInfoClient.h: Added.

(WebCore):
(NetworkInfoClient):
(WebCore::NetworkInfoClient::~NetworkInfoClient):

Modules/networkinfo/NetworkInfoConnection.cpp: Added.

(WebCore):
(WebCore::NetworkInfoConnection::create):
(WebCore::NetworkInfoConnection::NetworkInfoConnection):
(WebCore::NetworkInfoConnection::~NetworkInfoConnection):
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):
(WebCore::NetworkInfoConnection::didChangeNetworkInformation):
(WebCore::NetworkInfoConnection::addEventListener):
(WebCore::NetworkInfoConnection::removeEventListener):
(WebCore::NetworkInfoConnection::eventTargetData):
(WebCore::NetworkInfoConnection::ensureEventTargetData):
(WebCore::NetworkInfoConnection::interfaceName):
(WebCore::NetworkInfoConnection::suspend):
(WebCore::NetworkInfoConnection::resume):
(WebCore::NetworkInfoConnection::stop):

Modules/networkinfo/NetworkInfoConnection.h: Added.

(WebCore):
(NetworkInfoConnection):
(WebCore::NetworkInfoConnection::scriptExecutionContext):
(WebCore::NetworkInfoConnection::canSuspend):
(WebCore::NetworkInfoConnection::refEventTarget):
(WebCore::NetworkInfoConnection::derefEventTarget):

Modules/networkinfo/NetworkInfoConnection.idl: Added.
Modules/networkinfo/NetworkInfoController.cpp: Added.

(WebCore):
(WebCore::NetworkInfoController::NetworkInfoController):
(WebCore::NetworkInfoController::~NetworkInfoController):
(WebCore::NetworkInfoController::create):
(WebCore::NetworkInfoController::addListener):
(WebCore::NetworkInfoController::removeListener):
(WebCore::NetworkInfoController::didChangeNetworkInformation):
(WebCore::NetworkInfoController::isActive):
(WebCore::NetworkInfoController::supplementName):
(WebCore::provideNetworkInfoTo):

Modules/networkinfo/NetworkInfoController.h: Added.

(WebCore):
(NetworkInfoController):
(WebCore::NetworkInfoController::client):
(WebCore::NetworkInfoController::from):

dom/EventNames.h:

(WebCore):

dom/EventTargetFactory.in:
testing/Internals.cpp:

(WebCore::Internals::setNetworkInformation):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit:

PlatformEfl.cmake: Add dummy NetworkInfoClientEfl.cpp files in order to support network information API.

Source/WebKit/efl:

Add NetworkInfoClientEfl to support network information API. However,
functions are not implemented yet.

WebCoreSupport/NetworkInfoClientEfl.cpp: Added.

(WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
(WebCore):
(WebCore::NetworkInfoClientEfl::~NetworkInfoClientEfl):
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):

WebCoreSupport/NetworkInfoClientEfl.h: Added.

(NetworkInfoClientEfl):

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools:

Add network information API feature to build script.

Scripts/build-webkit:

LayoutTests:

Add new test cases for network information API specification.
And also, skip this test cases for other ports.

networkinformation/add-listener-from-callback-expected.txt: Added.
networkinformation/add-listener-from-callback.html: Added.
networkinformation/basic-all-types-of-events-expected.txt: Added.
networkinformation/basic-all-types-of-events.html: Added.
networkinformation/basic-operation-expected.txt: Added.
networkinformation/basic-operation.html: Added.
networkinformation/event-after-navigation-expected.txt: Added.
networkinformation/event-after-navigation.html: Added.
networkinformation/multiple-frames-expected.txt: Added.
networkinformation/multiple-frames.html: Added.
networkinformation/resources/event-after-navigation-new.html: Added.
networkinformation/script-tests/add-listener-from-callback.js: Added.

(checkNetworkInformation):
(firstListener):
(secondListener):
(maybeFinishTest):

networkinformation/script-tests/basic-all-types-of-events.js: Added.

(checkNetworkInformation):

networkinformation/script-tests/basic-operation.js: Added.
networkinformation/script-tests/event-after-navigation.js: Added.
networkinformation/script-tests/multiple-frames.js: Added.

(checkNetworkInformation):
(checkChildNetworkInformation):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):

networkinformation/script-tests/updates.js: Added.

(checkNetworkInformation):
(setNetworkInformation):
(firstListener):
(updateListener):

networkinformation/script-tests/window-property.js: Added.

(hasOnConnectionProperty):

networkinformation/updates-expected.txt: Added.
networkinformation/updates.html: Added.
networkinformation/window-property-expected.txt: Added.
networkinformation/window-property.html: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/wincairo/Skipped:

6:40 AM Changeset in webkit [112814] by leo.yang@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] Use GraphicsContext::fillPath() and strokePath instead of drawPath() in RenderThemeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=81486

Reviewed by Rob Buis.

RenderThemeBlackBerry was using GraphicsContext::drawPath() that's added for BlackBerry internally.
But we already have fillPath() and strokePath() in GraphicsContext. So just substitute drawPath()
by them. Also fix a build issue by adding a #include line.

No functionalities changed, no new tests.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):
(WebCore::RenderThemeBlackBerry::paintButton):

5:09 AM Changeset in webkit [112813] by Nikolas Zimmermann

44 edits
49 adds in trunk

Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459

Reviewed by Dirk Schulze.

Source/WebCore:

Enable animVal support for the last missing SVG DOM primitive: SVGAnimatedEnumeration.
It's a bit more involved than the others as we have to differentiate between the various
enumerations to use the correct SVGPropertyTraits<MyEnum>::fromString() code-path.

One SVGAnimatedEnumeration property in the SVG DOM is special: SVGAnimatedEnumeration orientType
from SVGMarkerElement. SVGMarkerElement exposes both the orientType and SVGAnimatedAngle orientAngle
SVG DOM properties and both get mapped to the same SVGNames::orientAttr ("orient" XML attribute).
That means that any animation of the orientAttr has to update both orientType & orientAngle.

This is a not a new requirement, we already support attributes like 'stdDeviation' from
SVGFEGaussianBlurElement, which get mapped to multiple SVG DOM objects: SVGAnimatedInteger stdDeviationX/Y.
The difference is that <integer-optional-integer> or <number-optional-number> animations use the
same type in the pair<xxx, xxx> (eg. both int, or both float). The 'orient' attribute needs to be
mapped to pair<xxx, yyy> types. Generalize the templates in SVGAnimatedTypeAnimator to support that.

Example:
<marker id="someMarkerElement" orient="45deg"/>
<animate fill="remove" begin="1s" dur="2s" from="90deg" to="auto" attributeName="orient" xlink:href="#someMarkerElement"/>

at 0s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 1s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 90

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 2s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO

someMarkerElement.orientAngle.animVal.value = 0

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

3s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

We need to map the 'orient' attribute to a pair<SVGAngle, unsigned short> type, in order
to track both orientAngle & orientType at the same type. Fortunately SVGAnimatedAngle
is only used in the SVG DOM for SVGMarkerElements orientAngle property. We can directly
switch SVGAnimatedAngleAnimator to the new pair<SVGAngle, unsigned short> type instead
of having to introduce a special SVGAnimatedAngleAndEnumerationAnimator.

Added tests for all SVGAnimatedEnumeration properties in the SVG DOM, including an extensive set of tests
for the synchronization of the orientType / orientAngle properties, when they get animated.

Tests: svg/animations/animate-marker-orient-from-angle-to-angle.html

svg/animations/animate-marker-orient-from-angle-to-auto.html
svg/animations/animate-marker-orient-to-angle.html
svg/animations/svgenum-animation-1.html
svg/animations/svgenum-animation-10.html
svg/animations/svgenum-animation-11.html
svg/animations/svgenum-animation-12.html
svg/animations/svgenum-animation-13.html
svg/animations/svgenum-animation-2.html
svg/animations/svgenum-animation-3.html
svg/animations/svgenum-animation-4.html
svg/animations/svgenum-animation-5.html
svg/animations/svgenum-animation-6.html
svg/animations/svgenum-animation-7.html
svg/animations/svgenum-animation-8.html
svg/animations/svgenum-animation-9.html

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
svg/SVGAllInOne.cpp:
svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):

svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

svg/SVGAnimatedAngle.h:

(WebCore):

svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedEnumeration.cpp: Added.

(WebCore):
(WebCore::enumerationValueForTargetAttribute):
(WebCore::SVGAnimatedEnumerationAnimator::SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::constructFromString):
(WebCore::SVGAnimatedEnumerationAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedEnumerationAnimator::animValWillChange):
(WebCore::SVGAnimatedEnumerationAnimator::animValDidChange):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedEnumerationAnimator::calculateDistance):

svg/SVGAnimatedEnumeration.h:

(SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::~SVGAnimatedEnumerationAnimator):
(WebCore):

svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):

svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngleAndEnumeration):
(WebCore::SVGAnimatedType::createEnumeration):
(WebCore):
(WebCore::SVGAnimatedType::angleAndEnumeration):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

svg/SVGAnimatedType.h:

(SVGAnimatedType):

svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::executeAction):

svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

svg/SVGMarkerElement.cpp:

(WebCore):

svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):

svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):

svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new tests for all SVGAnimatedEnumeration in the SVG DOM to proof they animate and update animVal correctly.

svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Added.
svg/animations/animate-marker-orient-from-angle-to-angle.html: Added.
svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Added.
svg/animations/animate-marker-orient-from-angle-to-auto.html: Added.
svg/animations/animate-marker-orient-to-angle-expected.txt: Added.
svg/animations/animate-marker-orient-to-angle.html: Added.
svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/animate-marker-orient-to-angle.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

svg/animations/script-tests/svgangle-animation-deg-to-grad.js: