Timeline

Apr 2, 2012:

11:52 PM Changeset in webkit [112987] by abarth@webkit.org

• 10 edits
  29 adds in trunk

Implement <iframe srcdoc>
​https://bugs.webkit.org/show_bug.cgi?id=82991

Reviewed by Sam Weinig.

Source/WebCore:

This patch implements the <iframe srcdoc> feature. This feature allows
authors to easily supply the contents of an iframe without needing to
round-trip to the server. Using srcdoc is more convenient than using
data URLs because we set a bunch of properties of the child document
sensibly. For example, the child inherits the base URL of the parent
and the child uses standards mode by default.

This feature is specified in
<​http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-srcdoc>.
Although the feature has been in the spec for a while, I'm not aware of
any other implementations in major browsers. The srcdoc feature works
especially well with the sandbox and seamless attributes. We already
implement sandbox and will likely implement seamless soon.

The srcdoc feature was announced on the webkit-dev mailing list on March 30:
​https://lists.webkit.org/pipermail/webkit-dev/2012-March/020161.html

This patch approaches the implementation using SubstituteData, which is
a mechanism previously used for error messages and the like. Using
SubstituteData has the advantage of not needing to modify the loading
or history pipelines at all, making the integration of srcdoc with the
rest of WebCore quite smooth.

This patch encodes the contents of the srcdoc attribute to and from
UTF-8 when round-tripping the contents through the loader. In a future
patch, I plan to experiment with whether using UTF-16 (or perhaps
another encoding) can improve performance. There might also be a way to
avoid the memcpy entirely, but these optimizations are best left to
followup patches as this patch focuses on the observable behavior of
the feature.

Tests: fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html

fast/frames/srcdoc/setting-src-does-nothing.html
fast/frames/srcdoc/setting-srcdoc-reloads-document.html
fast/frames/srcdoc/srcdoc-beats-src-dom.html
fast/frames/srcdoc/srcdoc-beats-src.html
fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html
fast/frames/srcdoc/srcdoc-can-navigate.html
fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html
fast/frames/srcdoc/srcdoc-loads-content.html
fast/frames/srcdoc/srcdoc-urls.html
http/tests/security/srcdoc-can-access-parent.html
http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html
http/tests/security/srcdoc-inherits-referrer-for-forms.html
http/tests/security/srcdoc-inherits-referrer.html

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::initSecurityContext):

• srcdoc documents need to inherit their security contexts from their parents. We pick this initialization point to inherit the base URL and to set the "srcdoc Document" bit so that everything gets initialized atomically and from precisely the same owner frame.

• dom/Document.h:

(Document):
(WebCore::Document::isSrcdocDocument):

• This bit of state is present in the HTML5 spec and is referred to by a number of different requirements in the spec.

• html/HTMLAttributeNames.in:
• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::location):

• These functions implement the requirement that the srcdoc attribute takes precedence over the src attribute and triggers a load of a document with the URL about:srcdoc.

• html/HTMLIFrameElement.idl:
  • Expose the srcdoc property as a reflection of the DOM attribute.
• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::defaultForInitial):

• This tweak allows srcdoc documents to use standards mode by default, saving authors from having to include a doctype in each srcdoc document.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL):

• This function transfers the contents of the srcdoc attribute into the loading pipeline. If the client supplies other SubstituteData, that takes precendence over our "default" SubstituteData.

(WebCore::FrameLoader::outgoingReferrer):

• This function implements the requirement from the HTML5 spec that srcdoc documents inherit their referrer from their parent document. A recursive implementation might have been more aesthetic but the iterative implementation seemed like a better choice.

(WebCore::FrameLoader::shouldTreatURLAsSrcdocDocument):

• An about:srcdoc URL only has special meaning when loaded in an iframe with a srcdoc attribute. Otherwise, it's just a normal "about" URL, meaning a blank page.

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadResourceSynchronously):

• Update these call sites to call defaultSubstituteDataForURL and outgoingReferrer consistently.

• loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

Add a number of tests for <iframe srcdoc>. These tests cover all the
requirements I could find in the HTML5 specification by grepping for
the term "srcdoc".

• fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again-expected.txt: Added.
• fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html: Added.
• fast/frames/srcdoc/setting-src-does-nothing-expected.txt: Added.
• fast/frames/srcdoc/setting-src-does-nothing.html: Added.
• fast/frames/srcdoc/setting-srcdoc-reloads-document-expected.txt: Added.
• fast/frames/srcdoc/setting-srcdoc-reloads-document.html: Added.
• fast/frames/srcdoc/srcdoc-beats-src-dom-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-beats-src-dom.html: Added.
• fast/frames/srcdoc/srcdoc-beats-src-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-beats-src.html: Added.
• fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html: Added.
• fast/frames/srcdoc/srcdoc-can-navigate-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-can-navigate.html: Added.
• fast/frames/srcdoc/srcdoc-defaults-to-standards-mode-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html: Added.
• fast/frames/srcdoc/srcdoc-loads-content-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-loads-content.html: Added.
• fast/frames/srcdoc/srcdoc-urls-expected.txt: Added.
• fast/frames/srcdoc/srcdoc-urls.html: Added.
• http/tests/security/srcdoc-can-access-parent-expected.txt: Added.
• http/tests/security/srcdoc-can-access-parent.html: Added.
• http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Added.
• http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html: Added.
• http/tests/security/srcdoc-inherits-referrer-expected.txt: Added.
• http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt: Added.
• http/tests/security/srcdoc-inherits-referrer-for-forms.html: Added.
• http/tests/security/srcdoc-inherits-referrer.html: Added.

10:10 PM Changeset in webkit [112986] by commit-queue@webkit.org

• 5 edits in trunk

EFL's LayoutTestController disableImageLoading implementation.
​https://bugs.webkit.org/show_bug.cgi?id=82848

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

Tools:

• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

• DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::disableImageLoading):

LayoutTests:

• platform/efl/Skipped:

10:05 PM Changeset in webkit [112985] by commit-queue@webkit.org

• 7 edits in trunk

[EFL] LayoutTestController needs implementation of isPageBoxVisible
​https://bugs.webkit.org/show_bug.cgi?id=82591

Source/WebKit/efl:

Add missing implementation for isPageBoxVisible to EFL's
DumpRenderTreeSupport.

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::isPageBoxVisible):

• WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
in order to unskip printing/page-format-data.html

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

• DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::isPageBoxVisible):

LayoutTests:

Unskip printing/page-format-data.html

Patch by Alexander Shalamov <​alexander.shalamov@intel.com> on 2012-04-02
Reviewed by Hajime Morita.

• platform/efl/Skipped:

9:24 PM Changeset in webkit [112984] by tkent@chromium.org

• 7 edits
  3 adds in trunk/Source/WebKit/chromium

[Chromium] Add WebKit API for WebCore::TextFieldDecorator
​https://bugs.webkit.org/show_bug.cgi?id=82143

Reviewed by Dimitri Glazkov.

Expose WebCore::TextFieldDecorator as
WebKit::WebTextFieldDecoratorClient. This change add capability to add
decoration buttons to text field <input> elements.

• WebKit.gyp: Add new files.
• public/WebTextFieldDecoratorClient.h: Added.
• public/WebView.h:

(WebKit): Add addTextFieldDecoratorClient().

• src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::willAddTextFieldDecorationsTo):
Calls willAddDecorationTo() of TextFieldDecorator objects owned by WebViewImpl.
(WebKit::ChromeClientImpl::addTextFieldDecorationsTo):
Apply TextFieldDecorationElement::decorate() for the specified input element.

• src/ChromeClientImpl.h:

(ChromeClientImpl): Add new function declarations.

• src/TextFieldDecoratorImpl.cpp:

Added. This is a bridge of WebCore::TextFieldDecorator and
WebKit::WebTextFieldDecoratorClient. This owns CachedImage objects
specfied by WebTextFieldDecoratorClient.
(WebKit::TextFieldDecoratorImpl::TextFieldDecoratorImpl):
(WebKit::TextFieldDecoratorImpl::create):
(WebKit::TextFieldDecoratorImpl::~TextFieldDecoratorImpl):
(WebKit::TextFieldDecoratorImpl::willAddDecorationTo):
(WebKit::TextFieldDecoratorImpl::imageForNormalState):
(WebKit::TextFieldDecoratorImpl::imageForDisabledState):
(WebKit::TextFieldDecoratorImpl::imageForReadonlyState):
(WebKit::TextFieldDecoratorImpl::handleClick):
(WebKit::TextFieldDecoratorImpl::willDetach):

• src/TextFieldDecoratorImpl.h: Added.

(TextFieldDecoratorImpl):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::addTextFieldDecoratorClient):
Add implementation of WebView::addTextFieldDecoratorClient().

• src/WebViewImpl.h:

WebViewImpl owns a vector of TextFieldDecoratorImpl.
(WebViewImpl):
(WebKit::WebViewImpl::textFieldDecorators):

9:14 PM Changeset in webkit [112983] by rakuco@freebsd.org

• 17 edits in trunk/LayoutTests

[EFL] Gardening; update expectations in fast/dom.

Mostly size changes after the recent jhbuild and font commits.

• platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
• platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
• platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
• platform/efl/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
• platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
• platform/efl/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
• platform/efl/fast/dom/HTMLTableElement/colSpan-expected.png:
• platform/efl/fast/dom/HTMLTableElement/colSpan-expected.txt:
• platform/efl/fast/dom/HTMLTableElement/createCaption-expected.png:
• platform/efl/fast/dom/HTMLTableElement/createCaption-expected.txt:
• platform/efl/fast/dom/clone-node-dynamic-style-expected.png:
• platform/efl/fast/dom/clone-node-dynamic-style-expected.txt:
• platform/efl/fast/dom/dom-parse-serialize-display-expected.png:
• platform/efl/fast/dom/dom-parse-serialize-display-expected.txt:
• platform/efl/fast/dom/dom-parse-serialize-expected.png:
• platform/efl/fast/dom/dom-parse-serialize-expected.txt:

9:01 PM Changeset in webkit [112982] by rakuco@freebsd.org

• 3 edits in trunk/LayoutTests

[EFL] Gardening; update text expectation for test in fast/layers.

• platform/efl/fast/layers/video-layer-expected.png:
• platform/efl/fast/layers/video-layer-expected.txt:

8:52 PM Changeset in webkit [112981] by Simon Fraser

• 6 edits in trunk/Tools

run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
​https://bugs.webkit.org/show_bug.cgi?id=82962

Reviewed by Dirk Pranke.

Ensure that _build_path() returns an absolute path.

Eric Seidel also had to deploy MockConfig in a bunch of places
in order to correct previous testing errors where we were
pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
was a real path. The real Config object calls run_command("webkit-build-directory")
to read the WebKit build directory from the webkitdirs.pm perl code.
MockConfig abstracts this away and always returns "/mock-build" during
testing. This change is much larger than one would think necessary
because of needing to deploy this MockConfig class.

• Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_path):

8:31 PM Changeset in webkit [112980] by commit-queue@webkit.org

• 10 edits in trunk/Source

[chromium] Remove SkCanvas::LayerIter use from OpaqueRegionSkia
​https://bugs.webkit.org/show_bug.cgi?id=82564

Patch by Dana Jansens <​danakj@chromium.org> on 2012-04-02
Reviewed by Stephen White.

Source/WebCore:

Per-tile-painting uses an SkPictureRecord in place of an SkCanvas
as the painting target for the GraphicsContext. This class only does
a simple recording and does not create layers in the canvas during
record, only playback. This is preventing us from correctly tracking
opaque regions under per-tile-painting.

We currently use the SkCanvas LayerIter to look at the layers in the
canvas backing the GraphicsContext, and check the SkPaints, clips,
and transforms to see how they impact the current draw once it reaches
the final device.

The clips and transforms can be retreived without using the LayerIter
through the "getTotal*" methods. A cumulative SkPaint is not available
so we store this ourselves.

PlatformContextSkia becomes aware of when saveLayer() is being called
on the underlying canvas, and passes this information to the
OpaqueRegionSkia class. Since we no longer watch layers in the canvas,
we must explicitly handle image clipping for the opaque tracker, as
it is implemented in the PlatformContextSkia, not via constructs in
the SkCanvas/SkPaint. We save the opaque area of the image mask for
the canvas layer in the stack along with the SkPaint for the layer.

Unit test: PlatformContextSkiaTest.PreserveOpaqueOnlyMattersForFirstLayer

• platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:

(WebCore::FEGaussianBlur::platformApplySkia):

• platform/graphics/filters/skia/FEMorphologySkia.cpp:

(WebCore::FEMorphology::platformApplySkia):

• platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):

• platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::setImageMask):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):

• platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::CanvasLayerState::CanvasLayerState):
(CanvasLayerState):

• platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::saveLayer):
(WebCore):
(WebCore::PlatformContextSkia::restoreLayer):
(WebCore::PlatformContextSkia::beginLayerClippedToImage):

• platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

Source/WebKit/chromium:

• tests/PlatformContextSkiaTest.cpp:

(WebCore):
(WebCore::TEST):

8:21 PM Changeset in webkit [112979] by morrita@google.com

• 2 edits in branches/chromium/1025/Source/WebCore/html

Disable content element.

BUG=114667
TBR=Dimitri Glazkov
Review URL: ​https://chromiumcodereview.appspot.com/9959089

8:00 PM Changeset in webkit [112978] by shinyak@chromium.org

• 5 edits in trunk/Source/WebCore

Remove TreeScope::isShadowRoot.
​https://bugs.webkit.org/show_bug.cgi?id=82879

Reviewed by Dimitri Glazkov.

This patch removes TreeScope::isShadowRoot(). To make code fast, TreeScope::isShadowRoot
is implemented in ShadowRoot.h. So when using TreeScope::isShadowRoot(), ShadowRoot.h is
always required. In some case, this might bring unnecessary dependency.

Since TreeScope::rootNode() is inlined, the overall performance won't change.

No new tests, simple refactoring.

• dom/ShadowRoot.h:
• dom/TreeScope.h:
• html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::doesSelectFromHostChildren):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::assignedFrom):
(WebCore::InsertionPoint::isShadowBoundary):

7:44 PM Changeset in webkit [112977] by eae@chromium.org

• 3 edits in trunk/Source/WebCore

Fix usage of LayoutUnits and pixel snapping in RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=82498

Reviewed by Julien Chaffraix.

Fix usage of subpixel types and snapping/rounding in RenderLayer in
preparation for turning on subpixel layout.

No new tests, no change in functionality.

• rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntSize):
Add no-op implementation of pixelSnappedIntSize, will be replaced with a
real implementation once we make the switch.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
Snap RenderBox size when updating the size of the layer.

(WebCore::RenderLayer::resize):
Round position when setting the inline style during resize operation.

(WebCore::RenderLayer::scrollCornerRect):
Remove unnecessary pixelSnappedIntRect call.

(WebCore::RenderLayer::positionOverflowControls):
Remove unnecessary pixelSnappedIntRect call.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Fix implementation of scrollWidth and Height to pixel snap the values.

(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):
Remove unnecessary pixelSnappedIntRect calls.

(WebCore::RenderLayer::paintLayerContents):
Pixel snap values just before painting (instead of earlier on).

(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestContents):
Change to use subpixel types.

7:39 PM Changeset in webkit [112976] by dpranke@chromium.org

• 3 edits
  1 delete in trunk/LayoutTests

Mark compositing/reflections/backface-hidden-reflection.html as crashing

Unreviewed, expectations and baselines update.

• platform/chromium/test_expectations.txt:
• platform/chromium-linux-x86/svg/custom/text-ctm-expected.png: Removed
• platform/chromium-linux/svg/custom/text-ctm-expected.png: Added.

7:16 PM Changeset in webkit [112975] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[Qt][WK2] Set viewport size back, when WebProcess is relaunched.
​https://bugs.webkit.org/show_bug.cgi?id=82936

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-04-02
Reviewed by Andreas Kling.

Fixed layout requires viewport size set properly on the WebProcess side.
Make sure it is set, when WebProcess is relaunched.

• UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):

7:12 PM Changeset in webkit [112974] by dpranke@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed, expectations update.

• platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:

6:41 PM Changeset in webkit [112973] by inferno@chromium.org

• 3 edits
  2 adds in trunk

<select> shouldn't intrude as a run-in.
​https://bugs.webkit.org/show_bug.cgi?id=82829

Reviewed by Tony Chang.

Source/WebCore:

Matches Opera's behavior which also does not allow <select>
to intrude as a run-in into the neighbouring block.
IE and Firefox doesn't support run-ins, so can't compare behavior
with them.

Test: fast/runin/select-runin.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

• fast/runin/select-runin-expected.txt: Added.
• fast/runin/select-runin.html: Added.

6:39 PM Changeset in webkit [112972] by ojan@chromium.org

• 2 edits in trunk/Tools

Fix snafu in r112971. We were never calling parseParameter for builder.

• TestResultServer/static-dashboards/dashboard_base.js:

6:25 PM Changeset in webkit [112971] by ojan@chromium.org

• 8 edits in trunk/Tools

Generate the lists of all layout test builders from the buildbot json
​https://bugs.webkit.org/show_bug.cgi?id=82924

Reviewed by Mihai Parparita.

In order to make this work, cleaned up a lot of existing technical debt.
-Got rid of expectations builder. This concept is outdated and just dead code.
-Split hash parameter parsing into two functions. One for dashboard_base
(crossDashboardParameters) and one for the specific dashboard html file
(dashboardSpecificParameters). In the old world, parseParameters needed to
be called twice and depended on it's own output the first time through.
Now we only need to parse crossDashboardParameters first and crossDashboardParameters
doesn't depend on the output of crossDashboardParameters.
-Lots of variable/method renames due to the above.
-g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
for that dashboard.

• TestResultServer/static-dashboards/aggregate_results.html:
• TestResultServer/static-dashboards/builders.js:

(BuilderGroup):
(BuilderGroup.prototype.setup):
(jsonRequest.xhr.onload):
(jsonRequest.xhr.onerror):
(isWebkitTestRunner):
(isChromiumWebkitTipOfTreeTestRunner):
(isChromiumWebkitDepsTestRunner):
(generateBuildersFromBuilderList):
(onLayoutTestBuilderListLoad):
(onErrorLoadingBuilderList):
(loadBuildersList):

• TestResultServer/static-dashboards/dashboard_base.js:

(handleValidHashParameterWrapper):
(queryHashAsMap):
(parseParameter):
(parseCrossDashboardParameters):
(parseDashboardSpecificParameters):
(parseParameters):
(diffStates):
(defaultValue):
(isLayoutTestResults):
(isGPUTestResults):
(currentBuilderGroupCategory):
(currentBuilderGroup):
(initBuilders):
Now that we've split parameter parseing, these methods no longer need
to take an optional state. They can always just use the global cross-dashboard state.

(pathToBuilderResultsFile):
(appendJSONScriptElementFor):
(appendJSONScriptElements):
(handleResourceLoadError):
(haveJsonFilesLoaded):
(combinedDashboardState):
(setQueryParameter):
(permaLinkURLHash):
(toggleQueryParameter):
(queryParameterValue):
(selectHTML):
(htmlForTestTypeSwitcher):
(g_handleBuildersListLoaded):

• TestResultServer/static-dashboards/flakiness_dashboard.html:
• TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testSubstringList):
(testHtmlForTestTypeSwitcherGroup):
(testLookupVirtualTestSuite):
(testBaseTest):
(generateBuildersFromBuilderListHelper):
(testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
(testGenerateChromiumWebkitDepsBuildersFromBuilderList):
(assertObjectsDeepEqual):
(testQueryHashAsMap):
(testDiffStates):

• TestResultServer/static-dashboards/timeline_explorer.html:
• TestResultServer/static-dashboards/treemap.html:

6:18 PM UsingGitWithWebKit edited by srikumar.b@gmail.com

git-svn package also need to be installed to use git with svn (diff)

6:16 PM Changeset in webkit [112970] by commit-queue@webkit.org

• 5 edits in trunk/Source

Call decrementStatsCounter directly
​https://bugs.webkit.org/show_bug.cgi?id=82950

Patch by Mark Pilgrim <​pilgrim@chromium.org> on 2012-04-02
Reviewed by Adam Barth.

Source/WebCore:

• platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

• src/PlatformSupport.cpp:

(WebCore):

• src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::~WebFrameImpl):

5:25 PM Changeset in webkit [112969] by dcheng@chromium.org

• 3 edits in trunk/LayoutTests

fast/events/drop-handler-should-not-stop-navigate.html fails on Lion
​https://bugs.webkit.org/show_bug.cgi?id=82984

Reviewed by Enrica Casucci.

• fast/events/drop-handler-should-not-stop-navigate.html:
• platform/mac/Skipped:

5:24 PM Changeset in webkit [112968] by tony@chromium.org

• 28 edits
  2 adds in trunk

add css parsing of -webkit-flex
​https://bugs.webkit.org/show_bug.cgi?id=82927

Reviewed by Ojan Vafai.

Source/WebCore:

This is the new syntax for CSS3 flexbox:
​http://dev.w3.org/csswg/css3-flexbox/#flexibility

Not hooked up to anything in the render tree yet so the old syntax is
still valid.

Test: css3/flexbox/flex-property-parsing.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

• css/CSSParser.h:

(WebCore):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in:
• css/CSSStyleApplyProperty.cpp:

(ApplyPropertyFlex):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::ApplyPropertyFlex::createHandler):
(WebCore::ApplyPropertyFlex::getFlexValue):
(WebCore):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

• css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

• rendering/style/RenderStyle.h:
• rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

• rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

LayoutTests:

• css3/flexbox/flex-property-parsing-expected.txt: Added.
• css3/flexbox/flex-property-parsing.html: Added.
• css3/flexbox/script-tests/css-properties.js:
• css3/flexbox/script-tests/flex-parsing.js:
• css3/flexbox/script-tests/flex-property-parsing.js: Added.
• fast/css/getComputedStyle/computed-style-expected.txt:
• fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
• platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
• platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
• platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/qt/svg/css/getComputedStyle-basic-expected.txt:
• svg/css/getComputedStyle-basic-expected.txt:

5:22 PM Changeset in webkit [112967] by crogers@google.com

• 1 edit
  18 adds in trunk/LayoutTests

Rebaseline oscillator results
​https://bugs.webkit.org/show_bug.cgi?id=82987

Unreviewed rebaseline.

• platform/chromium-linux-x86/webaudio/oscillator-custom-expected.wav: Added.
• platform/chromium-linux-x86/webaudio/oscillator-sawtooth-expected.wav: Added.
• platform/chromium-linux-x86/webaudio/oscillator-sine-expected.wav: Added.
• platform/chromium-linux-x86/webaudio/oscillator-square-expected.wav: Added.
• platform/chromium-linux-x86/webaudio/oscillator-triangle-expected.wav: Added.
• platform/chromium-linux/webaudio/oscillator-custom-expected.wav: Added.
• platform/chromium-linux/webaudio/oscillator-sawtooth-expected.wav: Added.
• platform/chromium-linux/webaudio/oscillator-sine-expected.wav: Added.
• platform/chromium-linux/webaudio/oscillator-square-expected.wav: Added.
• platform/chromium-linux/webaudio/oscillator-triangle-expected.wav: Added.
• platform/chromium-win/webaudio/oscillator-custom-expected.wav: Added.
• platform/chromium-win/webaudio/oscillator-sawtooth-expected.wav: Added.
• platform/chromium-win/webaudio/oscillator-sine-expected.wav: Added.
• platform/chromium-win/webaudio/oscillator-square-expected.wav: Added.
• platform/chromium-win/webaudio/oscillator-triangle-expected.wav: Added.

5:11 PM Changeset in webkit [112966] by oliver@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Incorrect liveness information when inlining
​https://bugs.webkit.org/show_bug.cgi?id=82985

Reviewed by Filip Pizlo.

Don't remap register numbers that have already been remapped.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

5:07 PM Changeset in webkit [112965] by enrica@apple.com

• 2 edits in trunk/LayoutTests

One more flakey canvas test

• platform/mac/Skipped:

5:02 PM Changeset in webkit [112964] by enrica@apple.com

• 2 edits in trunk/LayoutTests

fast/events/drop-handler-should-not-stop-navigate.html fails on Lion
after ​http://trac.webkit.org/changeset/112954

• platform/mac/Skipped:

4:54 PM Changeset in webkit [112963] by tony@chromium.org

• 3 edits in trunk/Tools

check-webkit-style errors when removing .png files
​https://bugs.webkit.org/show_bug.cgi?id=82933

Reviewed by David Levin.

• Scripts/webkitpy/style/patchreader.py:

(PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).

• Scripts/webkitpy/style/patchreader_unittest.py:

(test_check_patch_with_png_deletion):

4:53 PM Changeset in webkit [112962] by enrica@apple.com

• 2 edits in trunk/LayoutTests

Skipping a bunch of flakey tests on Lion.

• platform/mac/Skipped:

4:41 PM Changeset in webkit [112961] by crogers@google.com

• 2 edits in trunk/LayoutTests

Fix layout test failure with window-properties-expected.txt
​https://bugs.webkit.org/show_bug.cgi?id=82969

Unreviewed build fix.

• platform/mac/fast/dom/Window/window-properties-expected.txt:

Fix expectations caused by addition of Oscillator and WaveTable:
​http://trac.webkit.org/changeset/112938

4:24 PM Changeset in webkit [112960] by beidson@apple.com

• 2 edits in trunk/LayoutTests

Skip new test webarchive/css-page-rule-crash.html for WK2.
WK2 tests can't dump as WebArchives yet.

No review.

• platform/wk2/Skipped:

4:15 PM Changeset in webkit [112959] by mrowe@apple.com

• 2 edits in branches/safari-534.56-branch/Source/WebKit2

Merge r112801.

4:04 PM Changeset in webkit [112958] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r112948.
​http://trac.webkit.org/changeset/112948
​https://bugs.webkit.org/show_bug.cgi?id=82961

Someone else already checked in a similar change (Requested by
sundiamonde on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

• Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._start):

4:01 PM Changeset in webkit [112957] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adapt WebPagePrivate::webContext to the API change of r109570
​https://bugs.webkit.org/show_bug.cgi?id=82945

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-04-02
Reviewed by Rob Buis.

RIM PR: 147163
Adapt WebPagePrivate::webContext to the API change of the security
cherry-pick of r109570 and r112023.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

3:56 PM Changeset in webkit [112956] by tomz@codeaurora.org

• 1 edit
  1 delete in trunk/LayoutTests

Removing ahem.ttf that was checked in with wrong-case name.

Reviewed by Adam Barth.

This file is not referenced yet. The correctly named one will be added with
the next ietestcenter css test import.

• ietestcenter/css3/support/ahem.ttf: Removed.

3:35 PM Changeset in webkit [112955] by abarth@webkit.org

• 3 edits in trunk/Tools

garden-o-matic isn't able to rebaseline audio failures
​https://bugs.webkit.org/show_bug.cgi?id=82957

Reviewed by Chris Rogers.

This patch just adds "wav" to the list of test suffixes and updates the
unit tests to show that we're rebaselining audio tests results now too.

• Scripts/webkitpy/tool/commands/rebaseline.py:
• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_updates_expectations_file):

3:33 PM Changeset in webkit [112954] by dcheng@chromium.org

• 5 edits
  2 adds in trunk

Having a drop handler prevents navigation on drop even if event is not cancelled
​https://bugs.webkit.org/show_bug.cgi?id=79172

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only early return if the drop handler prevents the default action.

Test: fast/events/drop-handler-should-not-stop-navigate.html

• page/DragController.cpp:

(WebCore::DragController::performDrag):

LayoutTests:

• fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
• fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
• fast/events/drop-handler-should-not-stop-navigate.html: Added.
• http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler

to prevent bubbled events from causing navigation.

3:31 PM Changeset in webkit [112953] by schenney@chromium.org

• 2 edits
  1 delete in trunk/LayoutTests

[Chromium] Flaky SVG tests on MacOS 10.6
​https://bugs.webkit.org/show_bug.cgi?id=82954

Unreviewed Chromium test_expectations update

Removign one empty expectations file that somehow made it in
previously. And marking several tests as flaky on Snow Leopard.

• platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
• platform/chromium/test_expectations.txt:

3:30 PM Changeset in webkit [112952] by alexis.menard@openbossa.org

• 14 edits in trunk/Source

We should use CSSPropertyID rather than integers when manipulating CSS property ids.
​https://bugs.webkit.org/show_bug.cgi?id=82941

Reviewed by Andreas Kling.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. It will also feel more correct after this patch that CSSProperty::id()
return a value of the enum rather than an integer. As this modification is quite big this
is the first part only so it will be easier to review.

Source/WebCore:

No new tests : There should be no behavior change in this patch.

• css/CSSParser.cpp:

(WebCore::cssPropertyID):

• css/CSSParser.h:

(WebCore):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::cssText):

• css/CSSProperty.h:

(WebCore::CSSProperty::id):
(WebCore::CSSProperty::shorthandID):

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):

• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::asText):

• css/StylePropertySet.h:

(StylePropertySet):

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::removePropertiesInStyle):
(WebCore::setTextDecorationProperty):
(WebCore::diffTextDecorations):

• editing/Editor.cpp:

(WebCore::Editor::selectionStartCSSPropertyValue):

• editing/Editor.h:

(Editor):

• editing/EditorCommand.cpp:

(WebCore::valueStyle):

Source/WebKit/qt:

• Api/qwebelement.cpp:

(QWebElement::styleProperty): Adapt to the API change and also remove an unecessary name->id
conversion.

3:19 PM Changeset in webkit [112951] by abarth@webkit.org

• 4 edits in trunk/Tools

garden-o-matic should let you listen to audio failures
​https://bugs.webkit.org/show_bug.cgi?id=82953

Reviewed by Chris Rogers.

Now that we've actually got an audio failure on the bots, we can clean
up the last stray bugs. This patch doesn't have any tests because I'm
lame.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

3:11 PM Changeset in webkit [112950] by andersca@apple.com

• 7 edits in trunk/Source/WebKit2

Call NPP_SetValue with WKNVCALayerRenderServerPort when a WKView is moved from a buffered to an unbuffered window, or vice versa
​https://bugs.webkit.org/show_bug.cgi?id=82951
<rdar://problem/10589308>

Reviewed by Sam Weinig.

• PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setLayerHostingMode):
Call Plugin::setLayerHostingMode).

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:

Move WKNVCALayerRenderServerPort to the header file.

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_layerHostingMode.

(WebKit::NetscapePlugin::initialize):
Set m_layerHostingMode from the parameters struct.

• WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::compositingRenderServerPort):
Return MACH_PORT_NULL when hosted in the window server.

(WebKit::NetscapePlugin::platformPostInitialize):
Move the code that gets the layer out into a separate function, updatePluginLayer.

(WebKit::NetscapePlugin::setLayerHostingMode):
Let the plug-in know that the layer hosting mode changed and update the plug-in layer if
setting the new compositing port was successful.

3:08 PM Changeset in webkit [112949] by Nate Chapin

• 6 edits in trunk/Source/WebCore

Simplify main resource load start/end in FrameLoader
and DocumentLoader.
​https://bugs.webkit.org/show_bug.cgi?id=82935

1. Have FrameLoader call prepareForLoadStart() on itself directly, rather

than through DocumentLoader.

2. Remove DocumentLoader::m_primaryLoadComplete, since this is basically equivalent

to m_mainResourceLoader.

3. Rename setPrimaryLoadComplete() to clearMainResourceLoader(), and only call it at

the end of the main resource load.

4. Move clearing DocumentLoader::m_mainResourceError into startLoadingMainResource(),

which leaves DocumentLoader::prepareForLoadStart() empty.

Reviewed by Adam Barth.

No new tests, refactor only.

• WebCore.exp.in:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentLoader.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

• loader/FrameLoader.h: prepareForLoadStart() is now called directly,

so make it private.

3:05 PM Changeset in webkit [112948] by Stephanie Lewis

• 2 edits in trunk/Tools

2012-04-02 Stephanie Lewis <Stephanie Lewis>

run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
​https://bugs.webkit.org/show_bug.cgi?id=82552

Reviewed by Dirk Pranke.

Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.

• Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitDriver._start):

2:53 PM Changeset in webkit [112947] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Activation tear-off neglects to copy the callee and scope chain, leading to crashes if we
try to create an arguments object from the activation
​https://bugs.webkit.org/show_bug.cgi?id=82947
<rdar://problem/11058598>

Reviewed by Gavin Barraclough.

We now copy the entire call frame header just to be sure. This is mostly perf-netural,
except for a 3.7% slow-down in V8/earley.

• runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

• runtime/JSActivation.h:

(JSC::JSActivation::tearOff):

2:44 PM Changeset in webkit [112946] by schenney@chromium.org

• 34 edits
  13 adds
  8 deletes in trunk/LayoutTests

[Chromium] Expectations updated needed after 75091
​https://bugs.webkit.org/show_bug.cgi?id=81217

Unreviewed Chromium test_expectations update.

Leaving tests as flaky because some builders seem to be flaky,
although it's not clear why.

• platform/chromium-linux-x86/svg/carto.net: Added.
• platform/chromium-linux-x86/svg/carto.net/tabgroup-expected.txt: Added.
• platform/chromium-linux-x86/svg/custom/text-ctm-expected.png: Added.
• platform/chromium-linux-x86/svg/hixie/perf/003-expected.png: Added.
• platform/chromium-linux/svg/carto.net/tabgroup-expected.png:
• platform/chromium-linux/svg/carto.net/tabgroup-expected.txt: Added.
• platform/chromium-linux/svg/carto.net/window-expected.png:
• platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.png:
• platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
• platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
• platform/chromium-linux/svg/custom/use-detach-expected.png:
• platform/chromium-linux/svg/hixie/perf/003-expected.png:
• platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
• platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png:
• platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
• platform/chromium-mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
• platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
• platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
• platform/chromium-mac-leopard/svg/custom/use-detach-expected.png:
• platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
• platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png:
• platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
• platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
• platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
• platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.png: Removed.
• platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Removed.
• platform/chromium-mac/svg/carto.net/tabgroup-expected.png: Added.
• platform/chromium-mac/svg/carto.net/window-expected.png: Added.
• platform/chromium-mac/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
• platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
• platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
• platform/chromium-mac/svg/custom/use-detach-expected.png: Added.
• platform/chromium-mac/svg/hixie/perf/003-expected.png: Added.
• platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png:
• platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
• platform/chromium-win-xp/svg/carto.net: Removed.
• platform/chromium-win/svg/carto.net/tabgroup-expected.png:
• platform/chromium-win/svg/carto.net/tabgroup-expected.txt:
• platform/chromium-win/svg/carto.net/window-expected.png:
• platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.png:
• platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
• platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
• platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
• platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
• platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
• platform/chromium-win/svg/custom/text-ctm-expected.png:
• platform/chromium-win/svg/custom/text-ctm-expected.txt:
• platform/chromium-win/svg/custom/use-detach-expected.png:
• platform/chromium-win/svg/custom/use-detach-expected.txt:
• platform/chromium-win/svg/hixie/perf/003-expected.png:
• platform/chromium-win/svg/hixie/perf/003-expected.txt:
• platform/chromium/test_expectations.txt:
• platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.

2:34 PM Changeset in webkit [112945] by commit-queue@webkit.org

• 10 edits
  4 deletes in trunk/LayoutTests

Rebaseline more tests from 79568
​https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations udpate.

Patch by Philip Rogers <​pdr@google.com> on 2012-04-02

• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
• platform/chromium-win/svg/clip-path/clip-path-text-and-shape-expected.txt:
• platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.txt:
• platform/chromium/test_expectations.txt:

2:33 PM Changeset in webkit [112944] by dpranke@chromium.org

• 3 edits in trunk/Tools

NRWT is not printing out the builder it's uploading JSON files for
​https://bugs.webkit.org/show_bug.cgi?id=82834

Reviewed by Ojan Vafai.

Handle log messages of the form log.info("%s", arg) properly ...
I didn't even know you could do that :).

• Scripts/webkitpy/layout_tests/views/metered_stream.py:

(_LogHandler.emit):

• Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(RegularTest.test_log_args):
(VerboseTest.test_log_args):

2:23 PM Changeset in webkit [112943] by timothy_horton@apple.com

• 2 edits in trunk/Tools

[mac] LayoutTestHelper crashes if there is no main display
​https://bugs.webkit.org/show_bug.cgi?id=82944
<rdar://problem/11162954>

Reviewed by Simon Fraser.

If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
a null dictionary, so we shouldn't go ahead and try to read from it.

• DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):

2:19 PM Changeset in webkit [112942] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: m_purgePreventCount in FontCache::getCachedFontData running svg/custom/animate-disallowed-use-element.svg
​https://bugs.webkit.org/show_bug.cgi?id=81002
<rdar://problem/11168969>

Reviewed by Simon Fraser.

Don't spend time rebuilding SVG text layout attributes if the document is being torn down, as
they won't be used, and can cause assertion failures in the font cache.

No new tests, as it fixes an intermittent assertion failure during document destruction.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::willBeDestroyed):

2:16 PM Changeset in webkit [112941] by schenney@chromium.org

• 2 edits in trunk/LayoutTests

svg/W3C-SVG-1.1/animate-elem-80-t.svg is flaky on mac
​https://bugs.webkit.org/show_bug.cgi?id=82911

Unreviewed test_expectations update.

Fixing Mac 10.7 buildbot redness by marking animate-elem-80-t.svg as flaky.

• platform/chromium/test_expectations.txt:

2:15 PM Changeset in webkit [112940] by commit-queue@webkit.org

• 4 edits in trunk/Source

[BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
​https://bugs.webkit.org/show_bug.cgi?id=80519

Source/WebCore:

Stop asserting in platformCachePolicyForRequest() as now it is expected
that the ResourceRequest might not have the right TargetType setup at
this time for main loads.

Patch by Lianghui Chen <​liachen@rim.com> on 2012-04-02
Reviewed by Rob Buis.

No new tests as no change in behaviour.

• platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::platformCachePolicyForRequest):

Source/WebKit/blackberry:

Set the right TargetType for main loads if they are not already set in
dispatchWillSendRequest().

Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
and dispatchDecidePolicyForNavigationAction() as they are called before
dispatchWillSendRequest() is called. Patch to change ResourceRequest
TargetType earlier has been rejected as in WebKit bug
​https://bugs.webkit.org/show_bug.cgi?id=80713

Patch by Lianghui Chen <​liachen@rim.com> on 2012-04-02
Reviewed by Rob Buis.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

2:10 PM Changeset in webkit [112939] by Simon Fraser

• 4 edits in trunk

Fix issue with reflections and composited layers
​https://bugs.webkit.org/show_bug.cgi?id=82636

Source/WebCore:

Reviewed by Alexey Proskuryakov

When tearing down GraphicsLayers which referene eachother via m_replicatedLayer/m_replicaLayer,
we need to clean up the replica layer pointers.

No new tests; tested by existing compositing and repaint tests.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::setReplicatedByLayer):

LayoutTests:

Reviewed by Alexey Proskuryakov

Unskip some compositing tests that should pass now.

• platform/mac-wk2/Skipped:

2:07 PM Changeset in webkit [112938] by crogers@google.com

• 10 edits
  17 adds in trunk

Source/WebCore: Add Oscillator/WaveTable implementation and tests
​https://bugs.webkit.org/show_bug.cgi?id=82414

Oscillator represents an audio source generating a periodic waveform. It can be set to
a few commonly used waveforms. Additionally, it can be set to an arbitrary periodic
waveform through the use of a WaveTable object.

Reviewed by Kenneth Russell.

Tests: webaudio/oscillator-custom.html

webaudio/oscillator-sawtooth.html
webaudio/oscillator-sine.html
webaudio/oscillator-square.html
webaudio/oscillator-triangle.html

• DerivedSources.make:
• GNUmakefile.list.am:

Add Oscillator and WaveTable to build files.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createOscillator):
(WebCore):
(WebCore::AudioContext::createWaveTable):

• Modules/webaudio/AudioContext.h:

Add create methods for Oscillator and WaveTable.
(WebCore):
(AudioContext):

• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioNode.h:
• Modules/webaudio/Oscillator.cpp: Added.

(WebCore):
(WebCore::Oscillator::create):
(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::~Oscillator):
(WebCore::Oscillator::setType):
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):
(WebCore::Oscillator::reset):
(WebCore::Oscillator::setWaveTable):

• Modules/webaudio/Oscillator.h: Added.

(WebCore):
(Oscillator):
(WebCore::Oscillator::type):
(WebCore::Oscillator::frequency):
(WebCore::Oscillator::detune):
Implement Oscillator as AudioSourceNode.

• Modules/webaudio/Oscillator.idl: Added.
• Modules/webaudio/WaveTable.cpp: Added.

(WebCore):
(WebCore::WaveTable::create):
(WebCore::WaveTable::createSine):
(WebCore::WaveTable::createSquare):
(WebCore::WaveTable::createSawtooth):
(WebCore::WaveTable::createTriangle):
(WebCore::WaveTable::WaveTable):
(WebCore::WaveTable::waveDataForFundamentalFrequency):
(WebCore::WaveTable::maxNumberOfPartials):
(WebCore::WaveTable::numberOfPartialsForRange):
(WebCore::WaveTable::createBandLimitedTables):
(WebCore::WaveTable::generateBasicWaveform):

• Modules/webaudio/WaveTable.h: Added.

(WebCore):
(WaveTable):
(WebCore::WaveTable::rateScale):
(WebCore::WaveTable::waveTableSize):
(WebCore::WaveTable::sampleRate):
(WebCore::WaveTable::numberOfRanges):
Implement WaveTable which is constructed given a set of Fourier coefficients.

• Modules/webaudio/WaveTable.idl: Added.
• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:

Add Oscillator and WaveTable files to build files.

LayoutTests: Add Oscillator/WaveTable implementation and tests
​https://bugs.webkit.org/show_bug.cgi?id=82414

Reviewed by Kenneth Russell.

• webaudio/oscillator-custom-expected.wav: Added.
• webaudio/oscillator-custom.html: Added.
• webaudio/oscillator-sawtooth-expected.wav: Added.
• webaudio/oscillator-sawtooth.html: Added.
• webaudio/oscillator-sine-expected.wav: Added.
• webaudio/oscillator-sine.html: Added.
• webaudio/oscillator-square-expected.wav: Added.
• webaudio/oscillator-square.html: Added.
• webaudio/oscillator-triangle-expected.wav: Added.
• webaudio/oscillator-triangle.html: Added.
• webaudio/resources/oscillator-testing.js: Added.

(generateExponentialOscillatorSweep):

2:05 PM Changeset in webkit [112937] by scherkus@chromium.org

• 2 edits
  7 adds in trunk/LayoutTests

2012-04-02 David Dorwin <​ddorwin@chromium.org>

Add layout test expectations for Chromium to exhibit support WebM types
​https://bugs.webkit.org/show_bug.cgi?id=82925

Unreviewed.

• platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
• platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
• platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
• platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
• platform/chromium/test_expectations.txt:

2:00 PM Changeset in webkit [112936] by leviw@chromium.org

• 3 edits in trunk/Source/WebCore

Correct remaining LayoutUnit misuse in RenderReplaced and RenderFlexibleBox
​https://bugs.webkit.org/show_bug.cgi?id=82899

Reviewed by Darin Adler.

Removing remaining LayoutUnit misuse and compiler errors that exist in RenderReplaced
and RenderFlexibleBox once LayoutUnit becomes sub-pixel.

No new tests. No change in behavior.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Switching
a raw zero in a ternary operation to zeroLayoutUnit.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Ditto for std::max.

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint): Adding missing pixel snapping before painting.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Like above, switching
a raw zero to zeroLayoutUnit.
(WebCore::RenderReplaced::computePreferredLogicalWidths): Ditto.

1:58 PM Changeset in webkit [112935] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Crash due to floating object lists not properly being cleared
​https://bugs.webkit.org/show_bug.cgi?id=74056

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-04-02
Reviewed by David Hyatt.

Source/WebCore:

Add a check to clearFloats() that determines when intruding floats
are being cleared and not re-added. In this condition, ensure
children with floats are also getting layout because they might
need to have the same intruding floats cleared from their floating
object lists also.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

LayoutTests:

This test creates a condition where an intruding float is changed so
that it no longer intrudes. The child of a sibling was not getting
properly updated during the next layout.

• fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt: Added
• fast/block/float/intruding-float-not-removed-from-descendant-crash.html: Added

1:53 PM Changeset in webkit [112934] by schenney@chromium.org

• 2 edits
  4 adds
  3 deletes in trunk/LayoutTests

[chromium] Layout Test svg/text/text-rescale.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=79454

Unreviewed Chromium test_expectations update.

Some the of results for svg/text/text-rescale.svg and svg/text/text-viewbox-rescale.svg
are just in need of rebaselining, while others are flakey. Clarifying
the situation in test_expectations.

• platform/chromium-linux/svg/text/text-rescale-expected.txt: Removed.
• platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Removed.
• platform/chromium-mac/svg/text/text-rescale-expected.png: Added.
• platform/chromium-win/svg/text/text-rescale-expected.png: Added.
• platform/chromium-win/svg/text/text-rescale-expected.txt: Added.
• platform/chromium-win/svg/text/text-viewbox-rescale-expected.png: Added.
• platform/chromium/test_expectations.txt:
• platform/mac/svg/text/text-viewbox-rescale-expected.txt: Removed.

1:46 PM Changeset in webkit [112933] by commit-queue@webkit.org

• 10 edits in trunk/Source/WebCore

Align IDL to Typed Array Specification
​https://bugs.webkit.org/show_bug.cgi?id=82919

Patch by Seo Sanghyeon <​sh4.seo@samsung.com> on 2012-04-02
Reviewed by Darin Adler.

No tests. No change in behavior.

• html/canvas/Float32Array.idl:
• html/canvas/Float64Array.idl:
• html/canvas/Int16Array.idl:
• html/canvas/Int32Array.idl:
• html/canvas/Int8Array.idl:
• html/canvas/Uint16Array.idl:
• html/canvas/Uint32Array.idl:
• html/canvas/Uint8Array.idl:
• html/canvas/Uint8ClampedArray.idl:

1:45 PM Changeset in webkit [112932] by enrica@apple.com

• 2 edits in trunk/LayoutTests

Skipping ASSERTING inspector/debugging tests.

• platform/mac/Skipped:

1:38 PM Changeset in webkit [112931] by enrica@apple.com

• 2 edits in trunk/LayoutTests

Skipping 2 Unicode tests that are crashing intermittently.

• platform/mac-wk2/Skipped:

1:34 PM Changeset in webkit [112930] by msaboff@apple.com

• 2 edits in trunk/Source/WebCore

WebKit should throttle memory pressure notifications in proportion to handler time
​https://bugs.webkit.org/show_bug.cgi?id=82674

Rubber-stamped by Darin Adler.

Updated r112910: <​http://trac.webkit.org/changeset/112910> to address
post checkin concerns raised in original bug.

No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.

• platform/mac/MemoryPressureHandlerMac.mm:

(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

1:34 PM Changeset in webkit [112929] by schenney@chromium.org

• 2 edits in trunk/LayoutTests

[chromium] Layout Test svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG
​https://bugs.webkit.org/show_bug.cgi?id=79455

Unreviewed Chromium test_expectations clean-up.

Closing another bug that is an instance of WK82232.

• platform/chromium/test_expectations.txt:

1:28 PM Changeset in webkit [112928] by dbates@webkit.org

• 1 edit
  1 delete in trunk/Source/JavaScriptCore

Remove Source/JavaScriptCore/wtf and its empty subdirectories

Rubber-stamped by Eric Seidel.

Following the move of WTF from Source/JavaScriptCore/wtf to Source/WTF
(​https://bugs.webkit.org/show_bug.cgi?id=75673), remove directory
Source/JavaScriptCore/wtf and its empty subdirectories.

• wtf: Removed.
• wtf/android: Removed.
• wtf/blackberry: Removed.
• wtf/chromium: Removed.
• wtf/dtoa: Removed.
• wtf/efl: Removed.
• wtf/gobject: Removed.
• wtf/gtk: Removed.
• wtf/mac: Removed.
• wtf/qt: Removed.
• wtf/qt/compat: Removed.
• wtf/tests: Removed.
• wtf/text: Removed.
• wtf/threads: Removed.
• wtf/threads/win: Removed.
• wtf/unicode: Removed.
• wtf/unicode/glib: Removed.
• wtf/unicode/icu: Removed.
• wtf/unicode/qt4: Removed.
• wtf/unicode/wince: Removed.
• wtf/url: Removed.
• wtf/url/api: Removed.
• wtf/url/src: Removed.
• wtf/win: Removed.
• wtf/wince: Removed.
• wtf/wx: Removed.

1:25 PM Changeset in webkit [112927] by enrica@apple.com

• 2 edits in trunk/LayoutTests

Skipping flakey test on Mac.

• platform/mac/Skipped:

1:21 PM Changeset in webkit [112926] by schenney@chromium.org

• 2 edits in trunk/LayoutTests

REGRESSION(r110469): Some SVG Image related test is crashing on cr-mac
​https://bugs.webkit.org/show_bug.cgi?id=80976

Unreviewed Chromium test_expectations clean-up

The tests reported in this bug are either no longer crashing or
crashing due to the same problem as Bug 82232. So they are being
consolidated in the test_expectations file.

• platform/chromium/test_expectations.txt:

1:17 PM Changeset in webkit [112925] by enrica@apple.com

• 2 edits in trunk/LayoutTests

Skipping inspector/profiler/cpu-profiler-profiling.html
since it produces intermittent crashes.

• platform/mac/Skipped:

1:14 PM Changeset in webkit [112924] by darin@chromium.org

• 3 edits
  6 adds in trunk

HistoryItem not updated properly when a form submission begins before a
previous form submission has finished.
​https://bugs.webkit.org/show_bug.cgi?id=76686

Reviewed by Nate Chapin.

Source/WebCore:

Test: LayoutTests/fast/loader/form-submission-before-load-{get,post}.html

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadPostRequest):

LayoutTests:

• fast/loader/form-submission-before-load-get-expected.txt: Added.
• fast/loader/form-submission-before-load-get.html: Added.
• fast/loader/form-submission-before-load-post-expected.txt: Added.
• fast/loader/form-submission-before-load-post.html: Added.
• fast/loader/resources/form-submission-before-load-page2.html: Added.
• fast/loader/resources/form-submission-before-load-page3.html: Added.

12:50 PM Changeset in webkit [112923] by Antti Koivisto

• 35 edits in trunk/Source/WebCore

Split remaining CSSRules into internal and CSSOM types
​https://bugs.webkit.org/show_bug.cgi?id=82728

Reviewed by Andreas Kling.

This will complete the move to internal types for CSS rules. The only remaining unsplit type is
the CSSStyleSheet itself.

By separating internal types from the CSSOM we save memory immediately and enable future performance
optimizations as we are no longer tied to the structure of the API.

CSSOM type Internal type

CSSStyleRule StyleRule -> StyleRuleBase
CSSPageRule StyleRulePage -> StyleRuleBase
CSSFontFaceRule StyleRuleFontFace -> StyleRuleBase
CSSMediaRule StyleRuleMedia -> StyleRuleBlock -> StyleRuleBase
CSSImportRule StyleRuleImport -> StyleRuleBase
CSSCharsetRule String (owned by CSSStyleSheet)
CSSUnknownRule Never instantiated
WebKitCSSRegionRule StyleRuleRegion -> StyleRuleBlock -> StyleRuleBase
WebKitKeyframesRule StyleRuleKeyframes -> StyleRuleBase
WebKitKeyframeRule StyleKeyframe (owned by StyleRuleKeyframes)

StyleRuleBase is refcounted.

The CSSOM objects contain the public API functions and their implementations (almost) nothing else. Unlike the
CSSOM types they don't have parent pointers, saving memory.

The CSSOM tree is constructed on demand only. The CSSOM wrapper instances are constructed and owned by
the parent wrapper in the tree. Wrappers ref the corresponding internal type. The trees are kept in sync
when mutating.

All rules shrink by a pointer (from the parent pointer removal). The immediate memory savings from this patch are
larger as some earlier patches temporarily increased the memory use to allow incremental refactoring.

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMBinding.h:

(WebCore):

• css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::cssText):
(WebCore):

• css/CSSFontFaceRule.h:

(WebCore):
(WebCore::CSSFontFaceRule::create):
(CSSFontFaceRule):

• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

• css/CSSFontSelector.h:

(WebCore):

• css/CSSGrammar.y:
• css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::~StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::isLoading):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::media):
(WebCore::CSSImportRule::cssText):

• css/CSSImportRule.h:

(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::clearParentStyleSheet):
(WebCore::StyleRuleImport::href):
(WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient):
(ImportedStyleSheetClient):
(CSSImportRule):
(WebCore::CSSImportRule::create):
(WebCore::CSSImportRule::href):
(WebCore::CSSImportRule::styleSheet):
(WebCore):

• css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::cssText):
(WebCore::CSSMediaRule::media):
(WebCore):
(WebCore::CSSMediaRule::length):
(WebCore::CSSMediaRule::item):
(WebCore::CSSMediaRule::cssRules):

• css/CSSMediaRule.h:

(WebCore):
(WebCore::CSSMediaRule::create):
(CSSMediaRule):

• css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):

• css/CSSPageRule.h:

(WebCore):
(WebCore::CSSPageRule::create):
(CSSPageRule):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::createMarginAtRule):

• css/CSSParser.h:

(WebCore):
(CSSParser):

• css/CSSPropertySourceData.h:

(WebCore):

• css/CSSStyleRule.cpp:

(WebCore):
(WebCore::selectorTextCache):
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::setSelectorText):

• css/CSSStyleRule.h:

(WebCore):
(WebCore::CSSStyleRule::create):
(CSSStyleRule):

• css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore::RuleSet::pageRules):
(WebCore::CSSStyleSelector::addKeyframeStyle):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

• css/CSSStyleSelector.h:

(CSSStyleSelector):

• css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::createChildRuleCSSOMWrapper):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
(WebCore::CSSStyleSheet::ensureCSSOMWrapper):
(WebCore):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::parentStyleSheet):

• css/CSSStyleSheet.h:

(WebCore):
(WebCore::CSSStyleSheet::create):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::childRules):
(WebCore::CSSStyleSheet::importRules):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::hasCharsetRule):

• css/StyleRule.cpp:

(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::setProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::~StyleRulePage):
(WebCore::StyleRulePage::setProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::~StyleRuleFontFace):
(WebCore::StyleRuleFontFace::setProperties):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleBlock::wrapperInsertRule):
(WebCore::StyleRuleBlock::wrapperRemoveRule):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):

• css/StyleRule.h:

(WebCore):
(WebCore::StyleRuleBase::type):
(StyleRuleBase):
(WebCore::StyleRuleBase::isCharsetRule):
(WebCore::StyleRuleBase::isFontFaceRule):
(WebCore::StyleRuleBase::isKeyframesRule):
(WebCore::StyleRuleBase::isMediaRule):
(WebCore::StyleRuleBase::isPageRule):
(WebCore::StyleRuleBase::isStyleRule):
(WebCore::StyleRuleBase::isRegionRule):
(WebCore::StyleRuleBase::isImportRule):
(WebCore::StyleRuleBase::sourceLine):
(WebCore::StyleRuleBase::deref):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRuleBase::~StyleRuleBase):
(StyleRule):
(WebCore::StyleRule::create):
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRule::wrapperAdoptSelectorList):
(StyleRuleFontFace):
(WebCore::StyleRuleFontFace::create):
(WebCore::StyleRuleFontFace::properties):
(StyleRulePage):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::selector):
(WebCore::StyleRulePage::properties):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRulePage::wrapperAdoptSelectorList):
(StyleRuleBlock):
(WebCore::StyleRuleBlock::childRules):
(StyleRuleMedia):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleMedia::mediaQueries):
(StyleRuleRegion):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleRegion::selectorList):

• css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore):

• css/StyleSheet.h:

(WebCore):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::parentStyleSheet):
(StyleSheet):

• css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
(WebCore):
(WebCore::StyleRuleKeyframes::~StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::parserAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex):
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):

• css/WebKitCSSKeyframesRule.h:

(WebCore):
(StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::create):
(WebCore::StyleRuleKeyframes::keyframes):
(WebCore::StyleRuleKeyframes::name):
(WebCore::StyleRuleKeyframes::setName):
(WebCore::WebKitCSSKeyframesRule::create):
(WebCore::WebKitCSSKeyframesRule::name):
(WebKitCSSKeyframesRule):

• css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
(WebCore::WebKitCSSRegionRule::length):
(WebCore):
(WebCore::WebKitCSSRegionRule::item):
(WebCore::WebKitCSSRegionRule::cssRules):

• css/WebKitCSSRegionRule.h:

(WebCore):
(WebCore::WebKitCSSRegionRule::create):
(WebKitCSSRegionRule):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ensureSourceData):

• inspector/InspectorStyleSheet.h:

(WebCore):

• svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):

• svg/SVGFontFaceElement.h:

(WebCore):
(WebCore::SVGFontFaceElement::fontFaceRule):
(SVGFontFaceElement):

12:48 PM Changeset in webkit [112922] by commit-queue@webkit.org

• 20 edits
  9 deletes in trunk/LayoutTests

Rebaseline svg/W3C-SVG-1.1/animate-elem-XX-t.svg
​https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <​pdr@google.com> on 2012-04-02

• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
• platform/chromium/test_expectations.txt:

12:46 PM Changeset in webkit [112921] by jesus@webkit.org

• 2 edits in trunk/Source/WebKit2

[Qt][WK2] ResourceError::isCancellation() is always returning false
​https://bugs.webkit.org/show_bug.cgi?id=82917

Reviewed by Noam Rosenthal.

We were missing the encoding of a boolean in ArgumentCoder<ResourceError>
and, therefore, we were getting always "false" for ResourceError::isCancellation()
for errors being sent through the IPC.

• Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:41 PM Changeset in webkit [112920] by scherkus@chromium.org

• 1 edit
  4 adds in trunk/LayoutTests

2012-04-02 Andrew Scherkus <​scherkus@chromium.org>

Add a layout test for videos that change resolutions during decoding.
​https://bugs.webkit.org/show_bug.cgi?id=82686

Chromium has been bitten by these types of clips in the past hence the introduction
of a layout test. Test clips is only in VP8 as not all codecs support resolution
changes.

Reviewed by Eric Carlson.

• platform/chromium/media/resources/frame_size_change.webm: Added.
• platform/chromium/media/video-frame-size-change-expected.txt: Added.
• platform/chromium/media/video-frame-size-change.html: Added.

12:37 PM Changeset in webkit [112919] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Scroll position is lost after hide/show element
​https://bugs.webkit.org/show_bug.cgi?id=72852

Source/WebCore:

Maintain the scroll position of an overflowing element in the ElementRareData when the scrollable
RenderLayer is destroyed, which can be used to restore the scroll position if the same element gets
back a RenderLayer.

WebKit behaviour will be the same as Firefox and IE. It differs from Opera as it does not reset the
scroll position when an element is moved to another location in the same document. However Opera resets
the scroll position for elements moved to another document, which matches other browsers.

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2012-04-02
Reviewed by Julien Chaffraix.

Test: fast/overflow/scroll-div-hide-show.html

• dom/Element.cpp:

(WebCore::Element::removedFromDocument):
Reset the saved scroll offset if the node is moved to another location in the same document or another one.

(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):

• dom/Element.h:

Add helper functions to access the layer scroll offset from the element's rare data.

• dom/ElementRareData.h:

(ElementRareData):
Add the scroll offset book-keeping.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Restore the scroll offset.
(WebCore::RenderLayer::~RenderLayer):
Store the scroll offset if document is not being destroyed.

LayoutTests:

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2012-04-02
Reviewed by Julien Chaffraix.

• fast/overflow/scroll-div-hide-show-expected.txt: Added.
• fast/overflow/scroll-div-hide-show.html: Added.

12:33 PM Changeset in webkit [112918] by schenney@chromium.org

• 30 edits
  11 adds
  3 deletes in trunk/LayoutTests

[Chromium] Update expectations for SVG Lion results
​https://bugs.webkit.org/show_bug.cgi?id=82926

Unreviewed Chromium SVG Lion expectations update.

• platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Added.
• platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Removed.
• platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
• platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Removed.
• platform/chromium-mac-snowleopard/svg/custom/massive-coordinates-expected.png: Removed.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
• platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
• platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
• platform/chromium-mac/svg/batik/filters/feTile-expected.png:
• platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
• platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
• platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
• platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
• platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
• platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
• platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
• platform/chromium-mac/svg/batik/text/longTextOnPath-expected.txt:
• platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
• platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
• platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
• platform/chromium-mac/svg/batik/text/textEffect-expected.png:
• platform/chromium-mac/svg/batik/text/textEffect2-expected.png: Modified property svn:mime-type.
• platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
• platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
• platform/chromium-mac/svg/batik/text/textLayout-expected.png:
• platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
• platform/chromium-mac/svg/batik/text/textLength-expected.png:
• platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
• platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png: Modified property svn:mime-type.
• platform/chromium-mac/svg/batik/text/textPosition-expected.png: Modified property svn:mime-type.
• platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
• platform/chromium-mac/svg/batik/text/textProperties-expected.png:
• platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
• platform/chromium-mac/svg/batik/text/textStyles-expected.png:
• platform/chromium-mac/svg/batik/text/verticalText-expected.png:
• platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
• platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
• platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Added.
• platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
• platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
• platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
• platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
• platform/chromium/test_expectations.txt:

12:10 PM Changeset in webkit [112917] by eae@chromium.org

• 1075 edits
  228 copies
  38 deletes in branches/subpixellayout

Merge trunk changes up until 112900 into subpixel branch.

12:06 PM Changeset in webkit [112916] by enrica@apple.com

• 2 edits in trunk/LayoutTests

Skipping inspector/styles/override-screen-size.html on Mac.

• platform/mac/Skipped:

11:53 AM Changeset in webkit [112915] by commit-queue@webkit.org

• 3 edits
  2 adds
  1 delete in trunk/LayoutTests

Updating test expectations
​https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <​pdr@google.com> on 2012-04-02

• platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
• platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
• platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
• platform/chromium/test_expectations.txt:

11:47 AM Changeset in webkit [112914] by alexis.menard@openbossa.org

• 13 edits
  2 moves in trunk/Source/WebCore

Rename CSSPropertyLonghand files to StylePropertyShorthand.
​https://bugs.webkit.org/show_bug.cgi?id=82905

Reviewed by Antti Koivisto.

r112880 renamed CSSPropertyLonghand class to StylePropertyShorthand, so the
files need to reflect this new name now.

No new tests : Just a renaming, No behaviour change intended.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSAllInOne.cpp:
• css/CSSComputedStyleDeclaration.cpp:
• css/CSSParser.cpp:
• css/CSSProperty.cpp:
• css/StylePropertySet.cpp:
• css/StylePropertyShorthand.cpp: Renamed from Source/WebCore/css/CSSPropertyLonghand.cpp.

(WebCore):
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):

• css/StylePropertyShorthand.h: Renamed from Source/WebCore/css/CSSPropertyLonghand.h.

(WebCore):
(StylePropertyShorthand):
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(WebCore::StylePropertyShorthand::length):

• page/animation/AnimationBase.cpp:

11:23 AM Changeset in webkit [112913] by beidson@apple.com

• 3 edits
  2 adds in trunk

<rdar://problem/11020155> and ​https://bugs.webkit.org/show_bug.cgi?id=82910
REGRESSION (98963 and 109091): Crash when creating a WebArchive of a page with @page style rules

Reviewed by Antti Koivisto.

Source/WebCore:

Test: webarchive/css-page-rule-crash.html

• css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Page rules do not (currently) have subresource urls to get,

and are not CSSStyleRules.

LayoutTests:

• webarchive/css-page-rule-crash-expected.webarchive: Added.
• webarchive/css-page-rule-crash.html: Added.

11:21 AM Changeset in webkit [112912] by schenney@chromium.org

• 2 edits
  2 adds
  3 deletes in trunk/LayoutTests

Expectations update for svg/css/stars-with-shadow.html
​https://bugs.webkit.org/show_bug.cgi?id=82916

Unreviewed expectations change.

This rationalizes expectations for several platforms.

• platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Removed.
• platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Removed.
• platform/chromium/test_expectations.txt:
• platform/efl/svg/css/stars-with-shadow-expected.txt: Removed.
• platform/gtk/svg/css/stars-with-shadow-expected.txt: Added.
• svg/css/stars-with-shadow-expected.txt: Replaced.

11:15 AM Changeset in webkit [112911] by commit-queue@webkit.org

• 6 edits
  3 deletes in trunk

Unreviewed, rolling out r112851.
​http://trac.webkit.org/changeset/112851
​https://bugs.webkit.org/show_bug.cgi?id=82915

Broke 3 Mac accessibility tests (Requested by enrica on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

Source/WebCore:

• accessibility/AXObjectCache.cpp:
• accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):

• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):

LayoutTests:

• accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
• accessibility/anchor-link-selection-and-focus.html: Removed.
• platform/chromium/test_expectations.txt:
• platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.

11:13 AM Changeset in webkit [112910] by msaboff@apple.com

• 2 edits in trunk/Source/WebCore

WebKit should throttle memory pressure notifications in proportion to handler time
​https://bugs.webkit.org/show_bug.cgi?id=82674

Reviewed by Geoffrey Garen.

Changed the MemoryPressureHandler hold off timer to start timing after
respondToMemoryPressure runs. The delay time is now 20 times longer than the
time it took for respondToMemoryPressure to run with a minimum of 5 seconds.
This throttles the response to low memory events in the extreme case where
we are spending most of our time paging / swapping.
This is a Mac only change.

No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.

• platform/mac/MemoryPressureHandlerMac.mm:

(WebCore):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

11:08 AM Changeset in webkit [112909] by cevans@google.com

• 1 edit in branches/chromium/1025/Source/WebCore/rendering/RenderFullScreen.cpp

Merge 112596
BUG=118853
Review URL: ​https://chromiumcodereview.appspot.com/9950061

11:06 AM Changeset in webkit [112908] by commit-queue@webkit.org

• 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r112163.
​http://trac.webkit.org/changeset/112163
​https://bugs.webkit.org/show_bug.cgi?id=82914

Possible OOM issues (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

• bindings/v8/V8DOMWrapper.cpp:

(WebCore):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):

• bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

• bindings/v8/V8Proxy.h:

(WebCore::toV8):

• bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

• bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

• bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):

• bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

• bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

10:57 AM Changeset in webkit [112907] by cevans@google.com

• 2 edits
  2 copies in branches/chromium/1025

Merge 112051
BUG=120037
Review URL: ​https://chromiumcodereview.appspot.com/9963064

10:56 AM Changeset in webkit [112906] by commit-queue@webkit.org

• 14 edits in trunk/Source/WebCore

Unreviewed, rolling out r112318.
​http://trac.webkit.org/changeset/112318
​https://bugs.webkit.org/show_bug.cgi?id=82912

Possible OOM issues (Requested by aklein on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

• bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):

• bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):

10:52 AM Changeset in webkit [112905] by cevans@google.com

• 4 edits in branches/chromium/1025/Source/WebCore

Merge 112623
BUG=119281
Review URL: ​https://chromiumcodereview.appspot.com/9968049

10:52 AM Changeset in webkit [112904] by schenney@chromium.org

• 20 edits
  3 adds
  3 deletes in trunk/LayoutTests

<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
​https://bugs.webkit.org/show_bug.cgi?id=81631

Unreviewed Chromium expectations update.

• platform/chromium-linux-x86/tables: Removed.
• platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
• platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
• platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
• platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
• platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
• platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
• platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
• platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
• platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
• platform/chromium-win-vista/tables: Removed.
• platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
• platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
• platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
• platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt:
• platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
• platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
• platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
• platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
• platform/chromium/test_expectations.txt:
• platform/efl/fast/writing-mode/block-level-images-expected.txt: Removed.

10:46 AM Changeset in webkit [112903] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skip failing inspector test on GTK.

• platform/gtk/Skipped: Skip inspector/styles/override-screen-size.html

10:38 AM Changeset in webkit [112902] by cevans@google.com

• 5 edits
  2 copies in branches/chromium/1025

Merge 112200
BUG=118784
Review URL: ​https://chromiumcodereview.appspot.com/9968048

10:32 AM Changeset in webkit [112901] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Missing NULL check for vendor string from glGetString()
​https://bugs.webkit.org/show_bug.cgi?id=82859

Patch by Srikumar Bonda <​srikumar.b@gmail.com> on 2012-04-02
Reviewed by Kentaro Hara.

glGetString() possible to return NULL value.
Refer to ​http://www.opengl.org/sdk/docs/man/xhtml/glGetString.xml
for more information. The missing null check crashes webkit when
vendor name is not set (null) by glGetString().

No new tests because this is missing NULL check for
for openGL API response.

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateAttributes):

10:16 AM Changeset in webkit [112900] by fischman@chromium.org

• 2 edits in trunk/Source/WebCore

Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
​https://bugs.webkit.org/show_bug.cgi?id=82906

Reviewed by Eric Carlson.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleLoad):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):

10:13 AM Changeset in webkit [112899] by caseq@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: CPU time bar missing on top-level events in timeline panel
​https://bugs.webkit.org/show_bug.cgi?id=82909

Reviewed by Pavel Feldman.

• inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.addRecord):

10:10 AM Changeset in webkit [112898] by eric.carlson@apple.com

• 43 edits in trunk

Renaming parameters for positioning a track cue
​https://bugs.webkit.org/show_bug.cgi?id=78706

Source/WebCore:

Change WebVTT settings identifiers for spec change: D: -> vertical:, L: -> line:,
T: -> position:, S: -> size:, A: -> align:

Reviewed by Sam Weinig.

No new tests, existing tests updated for spec changes.

• html/track/TextTrackCue.cpp:

(WebCore::verticalGrowingLeftKeyword): Drive-by change to improve readability.
(WebCore::TextTrackCue::settingName): New, parse the settings keyword.
(WebCore::TextTrackCue::parseSettings): Update to match the current spec.

• html/track/TextTrackCue.h:

• html/track/WebVTTParser.h:

(WebCore::WebVTTParser::isValidSettingDelimiter): New.

LayoutTests:

Reviewed by Sam Weinig.

• media/track/captions-webvtt/missed-cues.vtt:
• media/track/captions-webvtt/sorted-dispatch.vtt:
• media/track/captions-webvtt/tc005-default-styles.vtt:
• media/track/captions-webvtt/tc014-alignment-bad.vtt:
• media/track/captions-webvtt/tc014-alignment-ltr.vtt:
• media/track/captions-webvtt/tc014-alignment.vtt:
• media/track/captions-webvtt/tc015-positioning-bad.vtt:
• media/track/captions-webvtt/tc015-positioning-ltr.vtt:
• media/track/captions-webvtt/tc015-positioning.vtt:
• media/track/captions-webvtt/tc016-align-positioning-bad.vtt:
• media/track/captions-webvtt/tc016-align-positioning.vtt:
• media/track/captions-webvtt/tc017-line-position-bad.vtt:
• media/track/captions-webvtt/tc017-line-position.vtt:
• media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt:
• media/track/captions-webvtt/tc018-align-text-line-position.vtt:
• media/track/captions-webvtt/tc019-cue-size-bad.vtt:
• media/track/captions-webvtt/tc019-cue-size.vtt:
• media/track/captions-webvtt/tc020-cue-size-align-bad.vtt:
• media/track/captions-webvtt/tc020-cue-size-align.vtt:
• media/track/captions-webvtt/tc021-valign-bad.vtt:
• media/track/captions-webvtt/tc021-valign-ltr.vtt:
• media/track/captions-webvtt/tc021-valign.vtt:
• media/track/captions-webvtt/tc022-entities-wrong.vtt:
• media/track/captions-webvtt/tc022-entities.vtt:
• media/track/captions-webvtt/tc023-markup-bad.vtt:
• media/track/captions-webvtt/tc023-markup.vtt:
• media/track/captions-webvtt/tc024-timestamp-bad.vtt:
• media/track/captions-webvtt/tc024-timestamp.vtt:
• media/track/captions-webvtt/tc025-class-bad.vtt:
• media/track/captions-webvtt/tc025-class.vtt:
• media/track/captions-webvtt/tc026-voice-bad.vtt:
• media/track/captions-webvtt/tc026-voice.vtt:
• media/track/captions-webvtt/tc027-empty-cue.vtt:
• media/track/captions-webvtt/tc028-unsupported-markup.vtt:

Update settings for spec change.

• media/track/captions-webvtt/tc013-settings-bad-separation.vtt:
• media/track/captions-webvtt/tc013-settings.vtt:
• media/track/track-webvtt-tc013-settings-expected.txt:
• media/track/track-webvtt-tc013-settings.html:

Update test and results to skip illegal settings delimiters.

9:42 AM Changeset in webkit [112897] by cevans@google.com

• 17 edits
  4 copies in branches/chromium/1025

Merge 112184
BUG=117583
Review URL: ​https://chromiumcodereview.appspot.com/9963061

9:39 AM Changeset in webkit [112896] by apavlov@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed, CCLayerTreeHost runMultiThread is flaky.
Related bug: ​https://bugs.webkit.org/show_bug.cgi?id=80811

Disabled CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread.

• tests/CCLayerTreeHostTest.cpp:

(WTF::TEST_F):

9:23 AM Changeset in webkit [112895] by apavlov@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, mark http/tests/xmlhttprequest/upload-progress-events.html as crashy on Linux Debug

• platform/chromium/test_expectations.txt:

9:22 AM Changeset in webkit [112894] by weinig@apple.com

• 12 edits in trunk/Source

Add setting to disable Java for local files even if it is otherwise enabled
​https://bugs.webkit.org/show_bug.cgi?id=82685

Reviewed by Anders Carlsson.

Source/WebCore:

• WebCore.exp.in:

Export setting setter.

• html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::canEmbedJava):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin):

• page/Navigator.cpp:

(WebCore::Navigator::javaEnabled):
Check for both isJavaEnabled and isJavaEnabledForLocalFiles.

• page/Settings.cpp:

(WebCore::Settings::setJavaEnabledForLocalFiles):

• page/Settings.h:

(WebCore::Settings::isJavaEnabledForLocalFiles):
Add new setting.

Source/WebKit2:

• Shared/WebPreferencesStore.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaEnabledForLocalFiles):
(WKPreferencesGetJavaEnabledForLocalFiles):

• UIProcess/API/C/WKPreferencesPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add pref as SPI and forward to WebCore.

9:13 AM Changeset in webkit [112893] by schenney@chromium.org

• 2 edits in trunk/LayoutTests

Some SVG tests are crashing
​https://bugs.webkit.org/show_bug.cgi?id=82232

Unreviewed Chromium test expectations update.

• platform/chromium/test_expectations.txt:

9:07 AM Changeset in webkit [112892] by apavlov@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Web Inspector: Device metrics emulation should turn off when zero width and height are passed in
​https://bugs.webkit.org/show_bug.cgi?id=82907

Currently this also requires the fontScaleFactor of 1 to be passed in, too. However, it results in
downsizing the FrameView to (0x0) on navigation with the open Inspector when the emulation is disabled.

Reviewed by Yury Semikhatsky.

• src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):

8:56 AM Changeset in webkit [112891] by leviw@chromium.org

• 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp

Fixing baseline position data types in RenderTableSection.

8:41 AM Changeset in webkit [112890] by schenney@chromium.org

• 9 edits in trunk/LayoutTests

LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
​https://bugs.webkit.org/show_bug.cgi?id=82469

Unreviewed Chromium test_expectations update.

These tests are skipped on Mac and the Mac baselines are hence wrong.
Comments on Bug 82469 indicate that our results are correct.

• platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
• platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
• platform/chromium/test_expectations.txt:

8:35 AM Changeset in webkit [112889] by kbalazs@webkit.org

• 21 edits
  2 copies
  3 adds in trunk

[Qt][WK2] Set up plugin process on Unix
​https://bugs.webkit.org/show_bug.cgi?id=72121

Reviewed by Simon Hausmann.

.:

• Source/QtWebKit.pro: Add PluginProcess subproject.

Source/WebKit2:

Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.

• GNUmakefile.am:
• PluginProcess.pro: Added.

• PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::PluginProcessMainGtk):

• PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.

• Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.

• Shared/Plugins/Netscape/NetscapePluginModule.h:

(WebKit):
(NetscapePluginModule):

• Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.

(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.

• Shared/ProcessExecutablePath.h: Added.

(WebKit):

• Shared/gtk/ProcessExecutablePathGtk.cpp: Added.

(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):

• Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.

(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.

• Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.

• Target.pri:
• UIProcess/Launcher/ProcessLauncher.h:

(ProcessLauncher):

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.

• UIProcess/Plugins/PluginProcessProxy.h:

(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):

• UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):

• UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.

• qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.

(WebKit):
(main):

Tools:

• qmake/mkspecs/features/features.prf: Reenable plugins

and turn on plugin process.

8:27 AM Changeset in webkit [112888] by apavlov@chromium.org

• 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

• platform/chromium/test_expectations.txt:

8:17 AM Changeset in webkit [112887] by kbalazs@webkit.org

• 21 edits
  5 deletes in trunk

Unreviewed, rolling out r112868, r112879, and r112881.
​http://trac.webkit.org/changeset/112868
​http://trac.webkit.org/changeset/112879
​http://trac.webkit.org/changeset/112881
​https://bugs.webkit.org/show_bug.cgi?id=82901

"Build fail on bots." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

.:

• Source/QtWebKit.pro:

Source/WebKit2:

• GNUmakefile.am:
• PluginProcess.pro: Removed.
• PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::PluginProcessMainGtk):

• PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::PluginProcessMain):

• Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

• Shared/Plugins/Netscape/NetscapePluginModule.h:

(NetscapePluginModule):

• Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::initializeGTK):
(WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad):
(WebKit::NetscapePluginModule::setMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::determineQuirks):

• Shared/ProcessExecutablePath.h: Removed.
• Shared/gtk/ProcessExecutablePathGtk.cpp: Removed.
• Shared/qt/ProcessExecutablePathQt.cpp: Removed.
• Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):

• Target.pri:
• UIProcess/Launcher/ProcessLauncher.h:

(ProcessLauncher):

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit):
(WebKit::findWebKitProcess):
(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Plugins/PluginProcessProxy.h:

(WebKit):
(PluginProcessProxy):

• UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

• UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

• qt/PluginMainQt.cpp: Removed.

Tools:

• MiniBrowser/gtk/GNUmakefile.am:
• qmake/mkspecs/features/features.prf:

8:06 AM Changeset in webkit [112886] by Philippe Normand

• 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r112882.

• platform/gtk/fast/dom/Window/window-properties-expected.txt:
• platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
• platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
• platform/gtk/fast/js/global-constructors-expected.txt:

7:48 AM Changeset in webkit [112885] by yurys@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed. Skip inspector/profiler/heap-snapshot-inspect-dom-wrapper.html in
debug mode as it crashes.

• platform/chromium/test_expectations.txt:

7:45 AM Changeset in webkit [112884] by apavlov@chromium.org

• 12 edits
  1 add in trunk/Source/WebCore

Web Inspector: Implement frontend for device metrics emulation
​https://bugs.webkit.org/show_bug.cgi?id=82891

This change implements the backend-based device metrics emulation capability discovery,
UI (enablement checkbox + input controls), and a persistence setting
for the user-specified device metrics (screen width/height and an auxiliary font scale factor).

Reviewed by Pavel Feldman.

• English.lproj/localizedStrings.js:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/compile-front-end.py:
• inspector/front-end/Settings.js:
• inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):
(WebInspector.SettingsScreen.prototype.set _applyDeviceMetricsUserInput):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride.set if):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.createInput):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

• inspector/front-end/UserAgentSupport.js: Added.

(WebInspector.UserAgentSupport.DeviceMetrics):
(WebInspector.UserAgentSupport.DeviceMetrics.parseSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.parseUserInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isWidthValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isHeightValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isFontScaleFactorValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.toSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.widthToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.heightToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.fontScaleFactorToInput):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/helpScreen.css:

(.help-table > tr > th):
(.help-table > tr > td):
(#resolution-override-section):

• inspector/front-end/inspector.css:

(.hidden):
(.error-input):

• inspector/front-end/inspector.html:
• inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

7:32 AM Changeset in webkit [112883] by leviw@chromium.org

• 2 edits in branches/subpixellayout/Source/WebCore/rendering

Switching an explicit wrapping in RenderTable.h to use a static_cast to mirror trunk. Removing an unnecessary pixelSnappedIntRect in RenderReplaced.

7:29 AM Changeset in webkit [112882] by Philippe Normand

• 2 edits in trunk/Tools

[GTK] Enable shadow-dom in build-webkit.

Rubber-stamped by Gustavo Noronha Silva.

• Scripts/build-webkit: Enable shadow-dom build, this is need to

have a working build currently.

7:28 AM Changeset in webkit [112881] by kbalazs@webkit.org

• 2 edits in trunk/Source/WebKit2

One more try to fix Qt build after r112868.

It's a misery why I don't have these build failures
locally.

• PluginProcess.pro:

7:19 AM Changeset in webkit [112880] by alexis.menard@openbossa.org

• 13 edits in trunk/Source/WebCore

Rename CSSPropertyLonghand class to StylePropertyShorthand.
​https://bugs.webkit.org/show_bug.cgi?id=82624

Reviewed by Antti Koivisto.

Rename CSSPropertyLonghand to StylePropertyShorthand as what CSSPropertyLonghand
is representing is not a longhand but the list of longhands for a given shorthand.
Also in the same time switch all shorthand declarations to use CSSPropertyID enum
rather than a int so it is clear on what kind of data we are dealing with.

In a following patch I will rename CSSPropertyLonghand file.

No new tests : This is a refactoring, no behaviour change intended

• css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

• css/CSSComputedStyleDeclaration.h:

(WebCore):
(CSSComputedStyleDeclaration):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):

• css/CSSParser.h:

(WebCore):
(CSSParser):

• css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

• css/CSSPropertyLonghand.cpp:

(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):

• css/CSSPropertyLonghand.h:

(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(StylePropertyShorthand):
(WebCore):

• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):

• css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

• editing/EditingStyle.cpp:

(WebCore):
(WebCore::removePropertiesInStyle):

• page/animation/AnimationBase.cpp:

(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::addShorthandProperties):

• page/animation/CompositeAnimation.cpp:

7:15 AM Changeset in webkit [112879] by kbalazs@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix Qt build after r112868.

• PluginProcess.pro: Add WTF into includepath.

7:12 AM Changeset in webkit [112878] by leviw@chromium.org

• 11 edits in branches/subpixellayout/Source/WebCore

Reverting remaining RenderTheme methods to operate on integers. Reverting absoluteContentBox to an IntRect. This has the affect of no longer requiring us to round in RenderWidget, which is for the best.

7:02 AM Changeset in webkit [112877] by apavlov@chromium.org

• 1 edit
  2 adds in trunk/LayoutTests

[Chromium] Unreviewed, baseline for fast/dom/shadow/form-in-shadow.html

• platform/chromium/fast/dom/shadow/form-in-shadow-expected.txt: Added.

6:58 AM Changeset in webkit [112876] by kling@webkit.org

• 2 edits in trunk/Tools

Adding Zalan Bujtas to committers list.

• Scripts/webkitpy/common/config/committers.py:

6:55 AM Changeset in webkit [112875] by podivilov@chromium.org

• 12 edits in trunk

Web Inspector: refactor UI breakpoint listeners.
​https://bugs.webkit.org/show_bug.cgi?id=82481

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Breakpoint-added and breakpoint-removed events are currently dispatched on UISourceCode.
That allows us to move handlers that manage SourceFrame's breakpoint decorations from ScriptsPanel to SourceFrame.
SourceFrame's "Loaded" event is removed as it was only used by ScriptsPanel to restore SourceFrame's breakpoints.

• inspector/front-end/DebuggerPresentationModel.js:
• inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointRemoved):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

• inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextViewerContentLoaded):

LayoutTests:

• http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

• http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):

• inspector/debugger/live-edit.html:
• inspector/debugger/set-breakpoint.html:
• inspector/debugger/source-frame.html:

6:44 AM Changeset in webkit [112874] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Web Inspector: Implement support for InspectorClient::overrideDeviceMetrics() in platforms other than Chromium
​https://bugs.webkit.org/show_bug.cgi?id=82886

Patch by János Badics <János Badics> on 2012-04-02

• platform/qt/Skipped: Skip inspector/styles/override-screen-size.html.

6:42 AM Changeset in webkit [112873] by kinuko@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling chromium DEPS.

• DEPS:

6:41 AM Changeset in webkit [112872] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/qt

Qt: Doc: Fix typo which marks document to be printed in console font.
​https://bugs.webkit.org/show_bug.cgi?id=82893

Patch by Casper van Donderen <​casper.vandonderen@nokia.com> on 2012-04-02
Reviewed by Simon Hausmann.

The qtwebkit-bridge.qdoc file contained a typo where a \c {} was
missing its closing curly bracket, this marked the rest of the page as
text to be printed using the code/console font.

• docs/qtwebkit-bridge.qdoc:

6:37 AM Changeset in webkit [112871] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[Qt][WK2] Call resize on frameview in WebPage::resizeToContentsIfNeeded only when the size changes.
​https://bugs.webkit.org/show_bug.cgi?id=82892

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-04-02
Reviewed by Kenneth Rohde Christiansen.

Check against the expanded size before calling resize on frameview.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedVisibleContentRect):
(WebKit::WebPage::resizeToContentsIfNeeded):

6:36 AM Changeset in webkit [112870] by rwlbuis@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Take into account policy checks in ClipboardBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=82651

Reviewed by George Staikos.

Add policy checks in the methods we implemented.

Covered by existing tests.

• platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):

• platform/blackberry/ClipboardBlackBerry.h:

(WebCore::ClipboardBlackBerry::create):

6:12 AM Changeset in webkit [112869] by yurys@chromium.org

• 3 edits in trunk

2012-04-02 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html as
slow.

• platform/chromium/test_expectations.txt:

6:08 AM Changeset in webkit [112868] by kbalazs@webkit.org

• 21 edits
  2 copies
  3 adds in trunk

[Qt][WK2] Set up plugin process on Unix
​https://bugs.webkit.org/show_bug.cgi?id=72121

Reviewed by Simon Hausmann.

.:

• Source/QtWebKit.pro: Add PluginProcess subproject.

Source/WebKit2:

Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.

• GNUmakefile.am:
• PluginProcess.pro: Added.

• PluginProcess/gtk/PluginProcessMainGtk.cpp:

(WebKit::PluginProcessMainGtk):

• PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.

• Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.

• Shared/Plugins/Netscape/NetscapePluginModule.h:

(WebKit):
(NetscapePluginModule):

• Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.

(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.

• Shared/ProcessExecutablePath.h: Added.

(WebKit):

• Shared/gtk/ProcessExecutablePathGtk.cpp: Added.

(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):

• Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.

(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.

• Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.

• Target.pri:
• UIProcess/Launcher/ProcessLauncher.h:

(ProcessLauncher):

• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.

• UIProcess/Plugins/PluginProcessProxy.h:

(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):

• UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):

• UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.

• qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.

(WebKit):
(main):

Tools:

• qmake/mkspecs/features/features.prf: Reenable plugins

and turn on plugin process.

6:06 AM Changeset in webkit [112867] by Philippe Normand

• 5 edits in trunk/Source/WebKit2

[GTK][WK2] Initial FullScreen support
​https://bugs.webkit.org/show_bug.cgi?id=75553

Reviewed by Martin Robinson.

Full screen display support in WebKitWebViewBase. Two functions
have been added to handle this. They're called by the
WebFullScreenManagerProxy when full screen display needs to be
managed for an HTML element.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate):
(webkitWebViewBaseCreateWebPage):
(onFullscreenGtkKeyPressEvent):
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

• UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

6:01 AM Changeset in webkit [112866] by yurys@chromium.org

• 2 edits in trunk

2012-04-02 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Mark newly added test as slow.

• platform/chromium/test_expectations.txt:

5:49 AM Changeset in webkit [112865] by caseq@chromium.org

• 9 edits
  1 add in trunk/Source/WebCore

Web Inspector: [refactoring] factor our frame aggregation logic to TimelineFrameController
​https://bugs.webkit.org/show_bug.cgi?id=82735

Reviewed by Pavel Feldman.

• factor out frame aggregation logic from TimelineVerticalOverview into TimelineFrameController;
• if we don't have frames, pretend each top-level event is a frame (this preserves behavior of vertical overview);
• factor out time-by-category stats aggregation into class methods of TimelineModel for reuse accross timeline modules;
• do not filter top-level events by type in vertical overview mode;

• WebCore.gypi: Added TimelineFrameController.js
• WebCore.vcproj/WebCore.vcproj: ditto.
• inspector/compile-front-end.py: ditto.
• inspector/front-end/TimelineFrameController.js: Added.

(WebInspector.TimelineFrameController):
(WebInspector.TimelineFrameController.prototype._onRecordAdded):
(WebInspector.TimelineFrameController.prototype._onRecordsCleared):
(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): create a "frame" based on a single top-level record.
(WebInspector.TimelineFrameController.prototype.dispose): Remove listeners that we added in constructor.
(WebInspector.TimelineFrame):

• inspector/front-end/TimelineModel.js: Added utilities for aggregating times by categories.

(WebInspector.TimelineModel.aggregateTimeByCategories):
(WebInspector.TimelineModel.aggregateTimeForRecord):

• inspector/front-end/TimelineOverviewPane.js: Use frame information supplied by TimelineFrameController.

(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype.reset): Clear stored frames upon reset()
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):

• inspector/front-end/TimelinePanel.js: Create/dispose TimelineFrameController when switching to/from vertical overview mode.
• inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats): Factored out statistics aggregation to utilities method in the model.

• inspector/front-end/WebKit.qrc: Added TimelineFrameController.js
• inspector/front-end/inspector.html: ditto.

5:20 AM Changeset in webkit [112864] by apavlov@chromium.org

• 10 edits in trunk

Web Inspector: Implement backend for device metrics emulation
​https://bugs.webkit.org/show_bug.cgi?id=82827

Source/WebCore:

This change implements the inspector backend for the device metrics override feature,
as well as the respective InspectorClient capability detection.
When a navigation occurs in the override mode, the page auto-zooming ("fit width")
is initiated upon the first layout after the DOMContentLoaded event.

Reviewed by Pavel Feldman.

• inspector/Inspector.json:
• inspector/InspectorClient.h:

(WebCore::InspectorClient::canOverrideDeviceMetrics):
(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):
(InspectorClient):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLayoutImpl):

• inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::updateViewMetrics):

• inspector/InspectorPageAgent.h:
• inspector/InspectorState.cpp:

(WebCore::InspectorState::getDouble):
(WebCore):

• inspector/InspectorState.h:

(InspectorState):
(WebCore::InspectorState::setDouble):

LayoutTests:

Follow the Web Inspector Protocol change.

Reviewed by Pavel Feldman.

• inspector/styles/override-screen-size.html:

5:16 AM Changeset in webkit [112863] by commit-queue@webkit.org

• 44 edits
  49 deletes in trunk

Unreviewed, rolling out r112813 and r112837.
​http://trac.webkit.org/changeset/112813
​http://trac.webkit.org/changeset/112837
​https://bugs.webkit.org/show_bug.cgi?id=82885

It made two tests crash on WK2 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

Source/WebCore:

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:
• svg/SVGAllInOne.cpp:
• svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):

• svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

• svg/SVGAnimatedAngle.h:

(WebCore):

• svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedEnumeration.cpp: Removed.
• svg/SVGAnimatedEnumeration.h:

(WebCore):

• svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):

• svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

• svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngle):
(WebCore::SVGAnimatedType::angle):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
(WebCore):
(WebCore::SVGAnimatedType::supportsAnimVal):

• svg/SVGAnimatedType.h:

(SVGAnimatedType):

• svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):

• svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

• svg/SVGMarkerElement.cpp:

(WebCore):

• svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):

• svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):

• svg/properties/SVGAnimatedStaticPropertyTearOff.h:

LayoutTests:

• svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Removed.
• svg/animations/animate-marker-orient-from-angle-to-angle.html: Removed.
• svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Removed.
• svg/animations/animate-marker-orient-from-angle-to-auto.html: Removed.
• svg/animations/animate-marker-orient-to-angle-expected.txt: Removed.
• svg/animations/animate-marker-orient-to-angle.html: Removed.
• svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Removed.
• svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Removed.
• svg/animations/script-tests/animate-marker-orient-to-angle.js: Removed.
• svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgenum-animation-1.js: Removed.
• svg/animations/script-tests/svgenum-animation-10.js: Removed.
• svg/animations/script-tests/svgenum-animation-11.js: Removed.
• svg/animations/script-tests/svgenum-animation-12.js: Removed.
• svg/animations/script-tests/svgenum-animation-13.js: Removed.
• svg/animations/script-tests/svgenum-animation-2.js: Removed.
• svg/animations/script-tests/svgenum-animation-3.js: Removed.
• svg/animations/script-tests/svgenum-animation-4.js: Removed.
• svg/animations/script-tests/svgenum-animation-5.js: Removed.
• svg/animations/script-tests/svgenum-animation-6.js: Removed.
• svg/animations/script-tests/svgenum-animation-7.js: Removed.
• svg/animations/script-tests/svgenum-animation-8.js: Removed.
• svg/animations/script-tests/svgenum-animation-9.js: Removed.
• svg/animations/svgangle-animation-deg-to-grad-expected.txt:
• svg/animations/svgangle-animation-deg-to-rad-expected.txt:
• svg/animations/svgangle-animation-grad-to-deg-expected.txt:
• svg/animations/svgangle-animation-grad-to-rad-expected.txt:
• svg/animations/svgangle-animation-rad-to-deg-expected.txt:
• svg/animations/svgangle-animation-rad-to-grad-expected.txt:
• svg/animations/svgenum-animation-1-expected.txt: Removed.
• svg/animations/svgenum-animation-1.html: Removed.
• svg/animations/svgenum-animation-10-expected.txt: Removed.
• svg/animations/svgenum-animation-10.html: Removed.
• svg/animations/svgenum-animation-11-expected.txt: Removed.
• svg/animations/svgenum-animation-11.html: Removed.
• svg/animations/svgenum-animation-12-expected.txt: Removed.
• svg/animations/svgenum-animation-12.html: Removed.
• svg/animations/svgenum-animation-13-expected.txt: Removed.
• svg/animations/svgenum-animation-13.html: Removed.
• svg/animations/svgenum-animation-2-expected.txt: Removed.
• svg/animations/svgenum-animation-2.html: Removed.
• svg/animations/svgenum-animation-3-expected.txt: Removed.
• svg/animations/svgenum-animation-3.html: Removed.
• svg/animations/svgenum-animation-4-expected.txt: Removed.
• svg/animations/svgenum-animation-4.html: Removed.
• svg/animations/svgenum-animation-5-expected.txt: Removed.
• svg/animations/svgenum-animation-5.html: Removed.
• svg/animations/svgenum-animation-6-expected.txt: Removed.
• svg/animations/svgenum-animation-6.html: Removed.
• svg/animations/svgenum-animation-7-expected.txt: Removed.
• svg/animations/svgenum-animation-7.html: Removed.
• svg/animations/svgenum-animation-8-expected.txt: Removed.
• svg/animations/svgenum-animation-8.html: Removed.
• svg/animations/svgenum-animation-9-expected.txt: Removed.
• svg/animations/svgenum-animation-9.html: Removed.

5:13 AM Changeset in webkit [112862] by Csaba Osztrogonác

• 21 edits in trunk

Unreviewed, rolling out r112651.
​http://trac.webkit.org/changeset/112651
​https://bugs.webkit.org/show_bug.cgi?id=82887

It doesn't work with older Qt5 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

Source/WebKit/qt:

• declarative/experimental/plugin.cpp:
• declarative/plugin.cpp:

(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

• UIProcess/API/qt/qquicknetworkreply_p.h:
• UIProcess/API/qt/qquicknetworkrequest_p.h:
• UIProcess/API/qt/qquickwebview.cpp:
• UIProcess/API/qt/qquickwebview_p.h:
• UIProcess/API/qt/qwebiconimageprovider_p.h:
• UIProcess/API/qt/qwebnavigationhistory.cpp:
• UIProcess/API/qt/qwebnavigationhistory_p.h:
• UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
• UIProcess/qt/QtDialogRunner.cpp:

(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):

• UIProcess/qt/QtFlickProvider.cpp:
• UIProcess/qt/QtFlickProvider.h:

(QtFlickProvider):

• UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

• MiniBrowser/qt/main.cpp:
• WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

• qmake/mkspecs/features/unix/default_post.prf:

5:13 AM Changeset in webkit [112861] by yurys@chromium.org

• 9 edits
  2 adds in trunk

[V8] Web Inspector: don't crash when resolving DOM wrapper heap snapshot node to JS object
​https://bugs.webkit.org/show_bug.cgi?id=82872

Reviewed by Pavel Feldman.

Source/WebCore:

Don't resolve heap object to a JS object if it is a wrapper boilerplate.

Test: inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

• bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):

• inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

LayoutTests:

• inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt: Added.
• inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: Added.
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/win/Skipped:
• platform/wincairo/Skipped:

5:06 AM Changeset in webkit [112860] by shinyak@chromium.org

• 1 edit
  1 add in trunk/LayoutTests

Write a test to confirm form elements work in Shadow DOM.
​https://bugs.webkit.org/show_bug.cgi?id=82431

Reviewed by Dimitri Glazkov.

The Shadow DOM spec says form should work even if it is in a shadow tree.
This test confirms it.

• fast/dom/shadow/form-in-shadow.html:

4:57 AM Changeset in webkit [112859] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r112659.
​http://trac.webkit.org/changeset/112659
​https://bugs.webkit.org/show_bug.cgi?id=82884

Undo the rollout of 112489 since this was not the cause of
failures (Requested by apavlov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-02

• css/CSSSegmentedFontFace.cpp:

(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore):
(WebCore::CSSSegmentedFontFace::getFontData):

4:50 AM Changeset in webkit [112858] by Antti Koivisto

• 5 edits in trunk/Source/WebCore

Add mechanism for mapping from StyleRules back to fully constructed CSSStyleRules
​https://bugs.webkit.org/show_bug.cgi?id=82847

Reviewed by Andreas Kling.

Inspector is using CSSStyleSelector to calculate the CSS rules matched by a given element and
expects to be able to walk the parent chain. After 82728 the stylesheet object tree won't have
parent pointers and we are going to need another mechanism to support this.

The new code does not actually run without 82728.

• css/CSSStyleSelector.cpp:

(WebCore):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::loadFullDefaultStyle):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

• css/CSSStyleSelector.h:

(CSSStyleSelector):

Add ensureFullCSSOMWrapperForStyleRule() method which traverses through all style
sheets that apply to the document and constucts wrappers for the rules. These wrappers
are cached to a map. The map can then be used for StyleRule -> CSSStyleRule lookups.

This uses quite a bit of memory so should not be used for any normal engine functions.

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):

Use the new mechanism to get fully functional wrappers for rule objects without parent pointer.

• inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

4:45 AM Changeset in webkit [112857] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test because
ENABLE(SHADOW_DOM) is disabled.

Patch by János Badics <János Badics> on 2012-04-02

• platform/qt/Skipped:

4:22 AM Changeset in webkit [112856] by apavlov@chromium.org

• 1 edit
  9 adds in trunk/LayoutTests

[Chromium] Add baselines for fast/text/international/text-spliced-font.html

• platform/chromium-linux/fast/text/international/text-spliced-font-expected.png: Added.
• platform/chromium-linux/fast/text/international/text-spliced-font-expected.txt: Added.
• platform/chromium-mac-leopard/fast/text/international/text-spliced-font-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png: Added.
• platform/chromium-mac/fast/text/international/text-spliced-font-expected.png: Added.
• platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt: Added.
• platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png: Added.
• platform/chromium-win/fast/text/international/text-spliced-font-expected.png: Added.
• platform/chromium-win/fast/text/international/text-spliced-font-expected.txt: Added.

4:16 AM Changeset in webkit [112855] by Carlos Garcia Campos

• 4 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

• GNUmakefile.list.am: Add missing file.

Source/WebCore:

• GNUmakefile.list.am: Remove duplicated files and add missing

header.

4:15 AM Changeset in webkit [112854] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skipping one more crashing svg test in GTK because of
bug 82876.

• platform/gtk/Skipped:

4:06 AM Changeset in webkit [112853] by Carlos Garcia Campos

• 2 edits in trunk/Tools

[GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
​https://bugs.webkit.org/show_bug.cgi?id=82877

Reviewed by Philippe Normand.

• Scripts/run-gtk-tests:

(TestRunner.run_tests): Use replace instead of lstrip to remove
the programs_path from the full path of unit tests.

3:47 AM Changeset in webkit [112852] by leviw@chromium.org

• 2 edits in trunk/Source/WebCore

Add rounding to Plugin creation in SubframeLoader
​https://bugs.webkit.org/show_bug.cgi?id=82221

Reviewed by Eric Seidel.

Adding rounding to the LayoutSize used to construct Plugins in SubframeLoader. Plugins, which
are widgets, are always placed on integer boundaries, which means their sizes can be rounded
without considering their location. See ​https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::createJavaAppletWidget):
(WebCore::SubframeLoader::loadPlugin):

3:28 AM Changeset in webkit [112851] by mario@webkit.org

• 6 edits
  3 adds in trunk

in page anchor and keyboard navigation
​https://bugs.webkit.org/show_bug.cgi?id=17450

Reviewed by Chris Fleizach.

Source/WebCore:

Ensure that the position of the caret and the focused element
get updated when following an anchor link.

The implementation is moved from platform specific files out to
AXObjectCache.cpp since it should be a cross-platform valid
solution. However, the new code is currently activated for the Mac
and GTK ports only, since the windows and chromium ports provide
their own specific code, and removing it now might break things.

Test: accessibility/anchor-link-selection-and-focus.html

• accessibility/AXObjectCache.cpp:

(WebCore):
(WebCore::AXObjectCache::handleScrolledToAnchor): Cross-platform
implementation of the fix, only activated for Mac and GTK for now.

• accessibility/gtk/AXObjectCacheAtk.cpp: Removed the GTK-specific

implementation of WebCore::AXObjectCache::handleScrolledToAnchor.

• accessibility/mac/AXObjectCacheMac.mm: Removed the Mac-specific

implementation of WebCore::AXObjectCache::handleScrolledToAnchor.

LayoutTests:

Added new test and expectations.

• accessibility/anchor-link-selection-and-focus-expected.txt: Added.
• accessibility/anchor-link-selection-and-focus.html: Added.
• platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Added.
• platform/chromium/test_expectations.txt: Skipped test for chromium.

3:20 AM Changeset in webkit [112850] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, skipping 2 crashing svg tests in GTK.

• platform/gtk/Skipped:

3:20 AM Changeset in webkit [112849] by keishi@webkit.org

• 2 edits in trunk/Source/WebKit/chromium

[chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
​https://bugs.webkit.org/show_bug.cgi?id=82863

Reviewed by Kent Tamura.

• features.gypi:

3:12 AM Changeset in webkit [112848] by apavlov@chromium.org

• 1 edit
  9 adds in trunk/LayoutTests

[Chromium] Unreviewed, add baselines for fast/forms/date/date-appearance.html

• platform/chromium-linux/fast/forms/date/date-appearance-expected.png: Added.
• platform/chromium-linux/fast/forms/date/date-appearance-expected.txt: Added.
• platform/chromium-mac/fast/forms/date/date-appearance-expected.png: Added.
• platform/chromium-mac/fast/forms/date/date-appearance-expected.txt: Added.
• platform/chromium-win/fast/forms/date/date-appearance-expected.png: Added.
• platform/chromium-win/fast/forms/date/date-appearance-expected.txt: Added.

3:03 AM Changeset in webkit [112847] by pfeldman@chromium.org

• 1 edit
  5 copies in branches/chromium/1084

Merge 112549 - Web Inspector: subtree disapears from <iframe> after loading
​https://bugs.webkit.org/show_bug.cgi?id=76552

Reviewed by Yury Semikhatsky.

Source/WebCore:

The problem was that content document subtree was not unbound upon iframe re-push.
Upon owner element refresh content document was not sent to the frontend
since backend assumed that front-end has already had the up-to-date version.

Test: inspector/elements/iframe-load-event.html

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::loadEventFired):

LayoutTests:

• inspector/elements/iframe-load-event-expected.txt: Added.
• inspector/elements/iframe-load-event.html: Added.
• inspector/elements/resources/iframe-load-event-iframe-1.html: Added.
• inspector/elements/resources/iframe-load-event-iframe-2.html: Added.
• inspector/elements/resources/iframe-load-event-iframe.js: Added.

(loadSecondIFrame):
(test.step1.nodeInserted):
(test.step1):
(test.step2):
(test):

TBR=​pfeldman@chromium.org
BUG=121116
Review URL: ​https://chromiumcodereview.appspot.com/9968037

3:02 AM Changeset in webkit [112846] by abarth@webkit.org

• 4 edits in trunk/Source

[Chromium] Move a number of virtual functions from WebKitPlatformSupport.h into Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=82865

Reviewed by Kent Tamura.

Source/Platform:

Moving these functions into Platform.h allows them to be called from
Platform (aka WebCore/platform), as discussed in
​https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

• chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::mimeRegistry):
(WebKit::Platform::audioHardwareSampleRate):
(WebKit::Platform::audioHardwareBufferSize):
(WebKit::Platform::createAudioDevice):
(WebKit::Platform::sampleGamepads):
(WebKit::Platform::visitedLinkHash):
(WebKit::Platform::isLinkVisited):
(WebKit::Platform::signedPublicKeyAndChallengeString):
(WebKit::Platform::memoryUsageMB):
(WebKit::Platform::actualMemoryUsageMB):
(WebKit::Platform::lowMemoryUsageMB):
(WebKit::Platform::highMemoryUsageMB):
(WebKit::Platform::highUsageDeltaMB):
(WebKit::Platform::prefetchHostName):
(WebKit::Platform::createSocketStreamHandle):
(WebKit::Platform::userAgent):
(WebKit::Platform::cacheMetadata):
(WebKit::Platform::createThread):
(WebKit::Platform::currentThread):
(WebKit::Platform::decrementStatsCounter):
(WebKit::Platform::incrementStatsCounter):
(WebKit::Platform::loadResource):
(WebKit::Platform::loadAudioResource):
(WebKit::Platform::sandboxEnabled):
(WebKit::Platform::suddenTerminationChanged):
(WebKit::Platform::defaultLocale):
(WebKit::Platform::currentTime):
(WebKit::Platform::monotonicallyIncreasingTime):
(WebKit::Platform::setSharedTimerFiredFunction):
(WebKit::Platform::setSharedTimerFireInterval):
(WebKit::Platform::stopSharedTimer):
(WebKit::Platform::callOnMainThread):
(WebKit::Platform::getTraceCategoryEnabledFlag):
(WebKit::Platform::addTraceEvent):
(WebKit::Platform::histogramCustomCounts):
(WebKit::Platform::histogramEnumeration):

Source/WebKit/chromium:

• public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

2:54 AM Changeset in webkit [112845] by hayato@chromium.org

• 17 edits
  4 adds in trunk

[Shadow DOM] Introduce ComposedShadowTreeWalker as a successor of ReifiedTreeTraversal APIs
​https://bugs.webkit.org/show_bug.cgi?id=82009

Reviewed by Dimitri Glazkov.

.:

• Source/autotools/symbols.filter:

Source/WebCore:

ComposedShadowTreeWalker is intended to be a successor of current ReifiedTreeTraversal APIs.
ComposedShadowTreeWalker uses a cursor pattern and takes a starting node in its constructor.

A typical usage is:

for (ComposedShadowTreeWalker walker(node); walker.get(); walker.next()) {

...

}

Follow-up patches will update clients which use current ReifiedTreeTraversal APIs so that they use the Walker.
More tests will come along with these actual use cases in follow-up patches.
After that, I'll get rid of ReifiedTreeTraversal APIs in favor of the Walker.

Note that 'ComposedShadowTree' and 'ReifiedTree' has the same meaning.
Because ReifiedTree is not intuitive name, we are starting to use 'ComposedShadowTree' from now.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.exp.in:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• dom/ComposedShadowTreeWalker.cpp: Added.

(WebCore):
(WebCore::isShadowHost):
(WebCore::shadowTreeFor):
(WebCore::shadowTreeOfParent):
(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::fromFirstChild):
(WebCore::ComposedShadowTreeWalker::firstChild):
(WebCore::ComposedShadowTreeWalker::traverseFirstChild):
(WebCore::ComposedShadowTreeWalker::lastChild):
(WebCore::ComposedShadowTreeWalker::traverseLastChild):
(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::nextSibling):
(WebCore::ComposedShadowTreeWalker::previousSibling):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToYoungerShadowRoot):
(WebCore::ComposedShadowTreeWalker::escapeFallbackContentElement):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::parent):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
(WebCore::ComposedShadowTreeWalker::traverseNextSibling):
(WebCore::ComposedShadowTreeWalker::traversePreviousSibling):
(WebCore::ComposedShadowTreeWalker::next):
(WebCore::ComposedShadowTreeWalker::previous):

• dom/ComposedShadowTreeWalker.h: Added.

(WebCore):
(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::get):
(WebCore::ComposedShadowTreeWalker::canCrossUpperBoundary):
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(WebCore::ComposedShadowTreeWalker::assertPostcondition):

• testing/Internals.cpp:

(WebCore::Internals::nextSiblingByWalker):
(WebCore):
(WebCore::Internals::firstChildByWalker):
(WebCore::Internals::lastChildByWalker):
(WebCore::Internals::nextNodeByWalker):
(WebCore::Internals::previousNodeByWalker):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

Source/WebKit2:

• win/WebKit2.def:
• win/WebKit2CFLite.def:

LayoutTests:

• fast/dom/shadow/composed-shadow-tree-walker-expected.txt: Added.
• fast/dom/shadow/composed-shadow-tree-walker.html: Added.

2:47 AM Changeset in webkit [112844] by pfeldman@chromium.org

• 5 edits in branches/chromium/1084/Source/WebCore/inspector/front-end

Merge 112539 - Web Inspector: "go to the previous panel" shortcut is painful to maintain
​https://bugs.webkit.org/show_bug.cgi?id=82602

Reviewed by Vsevolod Vlasov.

Present go to previous panel shortcut "Cmd - Left" is painful to support since we have
more and more free flow editing capabilities (where Cmd - Left is handled by the editor).
Remaping it to Cmd - Option - [ (]) / (Ctrl - Alt - [ (]) ).

Drive-by: de-capitalize captions from the settings panel.

• English.lproj/localizedStrings.js:
• inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerShortcuts):

• inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyDown):

• inspector/front-end/ScriptsPanel.js:
• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._contextMenu):

• inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

TBR=​pfeldman@chromium.org
BUGS=112539
Review URL: ​https://chromiumcodereview.appspot.com/9965056

2:40 AM Changeset in webkit [112843] by pfeldman@chromium.org

• 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/TextEditorModel.js

Merge 112381 - Web Inspector: REGRESSION: Stack overflow on the page with > 100kloc
​https://bugs.webkit.org/show_bug.cgi?id=82436

Reviewed by Yury Semikhatsky.

This change migrates to manual splice implementation that uses additional
information about the range being inserted to make it work faster / allocate
less memory.

• inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

TBR=​pfeldman@chromium.org
BUGS=121113
Review URL: ​https://chromiumcodereview.appspot.com/9969048

2:37 AM Changeset in webkit [112842] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Skip flaky unit tests.

• Scripts/run-gtk-tests:

(TestRunner):

2:29 AM Changeset in webkit [112841] by podivilov@chromium.org

• 5 edits in trunk

Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
​https://bugs.webkit.org/show_bug.cgi?id=82768

Reviewed by Yury Semikhatsky.

Source/WebCore:

When UISourceCode is replaced with another in ScriptsPanel, newly added
UISourceCode could already have breakpoints. We should iterate over existing
breakpoints and add them to sidebar pane.

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

• inspector/debugger/script-formatter-breakpoints-expected.txt:
• inspector/debugger/script-formatter-breakpoints.html:

2:18 AM Changeset in webkit [112840] by eric@webkit.org

• 2 edits in trunk/Source/WebCore

Teach RuleSet about modern memory management
​https://bugs.webkit.org/show_bug.cgi?id=82856

Reviewed by Adam Barth.

No change in behavior, thus no tests.

• css/CSSStyleSelector.cpp:

(WebCore::RuleSet::create):
(RuleSet):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

2:05 AM Changeset in webkit [112839] by tkent@chromium.org

• 12 edits
  2 copies
  4 adds in trunk

Add a calendar picker indicator to date-type input fields
​https://bugs.webkit.org/show_bug.cgi?id=80478

Reviewed by Hajime Morita.

Source/WebCore:

Add an indicator to date-type controls. The bahevior change is enclosed
with ENABLE_CALENDAR_PICKER.

• Remove spin buttons from date-type controls.

It's not so helpful if we have a calendar picker. We introduce
TextFieldInputType::shouldHaveSpinButton().

• Add CalendarPickerElement.

This is added into a shadow tree of a date-type control. It uses
RenderDetailsMarker.

We're going to add click handler and so on to CalendarPickerElement.

Test: fast/forms/date/date-appearance.html

• WebCore.gypi: Add CalendarPickerElement.{cpp,h}
• css/html.css:

(input::-webkit-calendar-picker-indicator):

• html/DateInputType.cpp:

(WebCore::DateInputType::createShadowSubtree): Insert CalendarPickerElement.
(WebCore::DateInputType::needsContainer):
Alwyas return true because we have an extra decoration element.
(WebCore::DateInputType::shouldHaveSpinButton):
Always return false to disable spin button.

• html/DateInputType.h:

(DateInputType): Add declarations.

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldHaveSpinButton):
(WebCore::TextFieldInputType::createShadowSubtree): Move some code to shouldHaveSpinButton().

• html/TextFieldInputType.h:

(TextFieldInputType): Add a declartion.

• html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::create):
(WebCore::CalendarPickerElement::createRenderer): Creates RenderDetailsMarker.

• html/shadow/CalendarPickerElement.h: Added.
• rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen): Always show a down arrow if this is in <input>.

• rendering/RenderDetailsMarker.h:

Source/WebKit/chromium:

• features.gypi: Enable CALENDAR_PICKER for non-Android platforms. This

doesn't affect any bahevior because INPUT_TYPE_DATE is disabled.

LayoutTests:

• fast/forms/date/date-appearance.html: Added.
• platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Added.
• platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Added.

1:46 AM Changeset in webkit [112838] by caseq@chromium.org

• 3 edits in trunk/Source/WebCore

Web Inspector: make timeline overview a view
​https://bugs.webkit.org/show_bug.cgi?id=82861

Reviewed by Yury Semikhatsky.

• make TimelineOverviewPane a view;
• only update it if it's visible or upon wasShown().

• inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.wasShown): forced update.
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh): skip refresh if not showing;

• inspector/front-end/TimelinePanel.js: timelineOverviewPane.show() instead of appendChild();

(WebInspector.TimelinePanel):

1:24 AM Changeset in webkit [112837] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r112813.

• svg/SVGAnimatedEnumeration.cpp:

(WebCore::enumerationValueForTargetAttribute):

1:12 AM Changeset in webkit [112836] by rniwa@webkit.org

• 2 edits in trunk/Tools

webkitpy rebaseline.

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

12:43 AM Changeset in webkit [112835] by Philippe Normand

• 2 edits
  1 copy in trunk/LayoutTests

Unreviewed, rebaseline after r112825.

The test baseline updated in r112825 is specific to GURL's way of
printing URLs so it belongs to the chromium platform directory.

• http/tests/security/no-popup-from-sandbox-top-expected.txt:
• platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt: Copied from LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt.

12:31 AM Changeset in webkit [112834] by abarth@webkit.org

• 6 edits
  7 copies
  1 move
  7 adds in trunk/Source

[Chromium] Move another block of headers from WebKit/chromium/public/platform to Platform/chromium/public
​https://bugs.webkit.org/show_bug.cgi?id=82862

Rubber-stamped by Eric Seidel.

Source/Platform:

• Platform.gypi:
• chromium/public/WebAudioBus.h: Copied from Source/WebKit/chromium/public/platform/WebAudioBus.h.
• chromium/public/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/platform/WebAudioDevice.h.
• chromium/public/WebGamepad.h: Copied from Source/WebKit/chromium/public/platform/WebGamepad.h.
• chromium/public/WebGamepads.h: Copied from Source/WebKit/chromium/public/platform/WebGamepads.h.
• chromium/public/WebSocketStreamError.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamError.h.
• chromium/public/WebSocketStreamHandle.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamHandle.h.
• chromium/public/WebSocketStreamHandleClient.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamHandleClient.h.

Source/WebCore:

This is part of the change discussed in
​https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

• WebCore.gypi:
• platform/chromium/support/WebAudioBus.cpp: Copied from Source/WebKit/chromium/src/WebAudioBus.cpp.

Source/WebKit/chromium:

• WebKit.gyp:
• public/platform/WebAudioBus.h: Replaced.
• public/platform/WebAudioDevice.h: Replaced.
• public/platform/WebGamepad.h: Replaced.
• public/platform/WebGamepads.h: Replaced.
• public/platform/WebSocketStreamError.h: Replaced.
• public/platform/WebSocketStreamHandle.h: Replaced.
• public/platform/WebSocketStreamHandleClient.h: Replaced.
• src/WebAudioBus.cpp: Removed.

12:00 AM Changeset in webkit [112833] by Philippe Normand

• 179 edits
  1 add in trunk/LayoutTests

Unreviewed, GTK svg rebaseline after r112806.

• platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
• platform/gtk/svg/[...]

Apr 1, 2012:

11:54 PM Changeset in webkit [112832] by abarth@webkit.org

• 6 edits
  2 copies
  1 move
  2 adds in trunk/Source

[Chromium] Move thread-related APIs from WebKit into Platform
​https://bugs.webkit.org/show_bug.cgi?id=82858

Reviewed by Eric Seidel.

Source/Platform:

• Platform.gypi:
• chromium/public/WebThread.h: Copied from Source/WebKit/chromium/public/platform/WebThread.h.
• chromium/public/WebThreadSafeData.h: Copied from Source/WebKit/chromium/public/platform/WebThreadSafeData.h.

Source/WebCore:

This is part of the change discussed in
​https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

• WebCore.gypi:
• platform/chromium/support/WebThreadSafeData.cpp: Copied from Source/WebKit/chromium/src/WebThreadSafeData.cpp.

Source/WebKit/chromium:

• WebKit.gyp:
• public/platform/WebThread.h: Replaced.
• public/platform/WebThreadSafeData.h: Replaced.
• src/WebThreadSafeData.cpp: Removed.

10:21 PM Changeset in webkit [112831] by rniwa@webkit.org

• 2 edits in trunk

Perf-o-matic build fix after 112829 for Chromium-style tests.

• Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

10:07 PM Changeset in webkit [112830] by tkent@chromium.org

• 5 edits in trunk/Source/WebCore

Fix some problems of text field decoration
​https://bugs.webkit.org/show_bug.cgi?id=82693

Reviewed by Dimitri Glazkov.

• Fix a problem that decorations are not removed when the input type is

changed.

• Add a comment to the 'willDetach' callback.

No new tests because the behavior changes are not visible yet.

• GNUMakefile.list.am: Add HTMLShadowElement.*.
• html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):
Remove all of ShadowRoot contents, and add a <shadow> element to each of
them. We don't remove ShadowRoots from the tree because it's not
supported well.

• html/shadow/TextFieldDecorationElement.cpp:

(getDecorationRootAndDecoratedRoot): A helper function for decorate().
If the input element has a ShadowRoot with single <shadow> child, we
don't create new ShadowRoot and reuse it.
(WebCore::TextFieldDecorationElement::decorate):
Use getDecorationRootAndDecoratedRoot().

• html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorator): Add a comment to willDetach().

9:48 PM Changeset in webkit [112829] by rniwa@webkit.org

• 7 edits in trunk

perf-o-matic should store test results' units
​https://bugs.webkit.org/show_bug.cgi?id=82852

Reviewed by Kentaro Hara.

.:

• Websites/webkit-perf.appspot.com/models.py:

(Test):
(Test.update_or_insert): Added "unit" to the argument list.
(Test.update_or_insert.execute): Store the unit.
(ReportLog.results_are_well_formed): Moved from ReportHandler.
(ReportLog.results_are_well_formed._is_float_convertible): Ditto.

• Websites/webkit-perf.appspot.com/models_unittest.py:

(TestModelTests.test_update_or_insert): Added a test case for "unit" argument.
(TestModelTests.test_update_or_insert_to_update): Ditto.
(ReportLogTests.test_results_are_well_formed): Added.
(ReportLogTests.test_results_are_well_formed.assert_results_are_well_formed): Added.

• Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post): Calls ReportLog.results_are_well_formed.

• Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post): Passes resultsunit to Test.update_or_insert.

Tools:

Include units in the results JSON.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

9:36 PM Changeset in webkit [112828] by Darin Adler

• 2 edits in trunk/Source/JavaScriptCore

Fix incorrect path for libWTF.a in Mac project file.

• JavaScriptCore.xcodeproj/project.pbxproj: Removed the "../Release" prefix that

would cause other configurations to try to link with the "Release" version of
libWTF.a instead of the correct version.

9:17 PM FeatureFlags edited by tkent@chromium.org

Rename INPUT_COLOR to INPUT_TYPE_COLOR (diff)

8:51 PM Changeset in webkit [112827] by abarth@webkit.org

• 2 edits in trunk/Websites/bugs.webkit.org

Code review tool no longer needs to work around position:fixed handling on iPad
​https://bugs.webkit.org/show_bug.cgi?id=82850

Reviewed by Eric Seidel.

We no longer need to avoid position:fixed on iPad because Mobile Safari
now does something reasonable with position:fixed elements.

• code-review.js:

7:53 PM Changeset in webkit [112826] by commit-queue@webkit.org

• 5 edits in trunk

[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
​https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <​li.yin@intel.com> on 2012-04-01
Reviewed by Kent Tamura.

Source/WebCore:

When it had no negotiated deflate-frame extension, if browser received the frame with
setting compressed bit, it should fail the connection, and it should cover both
enabling ZLIB port and disabling ZLIB port.

Test: http/tests/websocket/tests/hybi/reserved-bits.html

• Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketDeflateFramer::inflate):

LayoutTests:

Solve the problem that Qt Webkit failed when runing the reserved-bits.html
Support both enabled ZLIB and disabled ZLIB scenarios.

• http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
• http/tests/websocket/tests/hybi/reserved-bits_wsh.py:

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):

7:43 PM Changeset in webkit [112825] by abarth@webkit.org

• 11 edits in trunk

Clean up Document::canNavigate
​https://bugs.webkit.org/show_bug.cgi?id=82282

Reviewed by Eric Seidel.

Source/WebCore:

This patch is just a minor clean up to Document::canNavigate. Eric
asked me to clean up the function when I moved it from FrameLoader. I'm
not sure this patch is much of a win, but at least the comments say
things that are more sensible now.

• dom/Document.cpp:

(WebCore::printNavigationErrorMessage):
(WebCore):
(WebCore::Document::canNavigate):

LayoutTests:

Update these test results to show that we're better at printing error
messages now.

• http/tests/security/no-popup-from-sandbox-top-expected.txt:
• http/tests/security/sandboxed-iframe-form-top-expected.txt:

7:12 PM Changeset in webkit [112824] by rniwa@webkit.org

• 3 edits in trunk

Admin page should lexicologically sort tests
​https://bugs.webkit.org/show_bug.cgi?id=82849

Rubber-stamped by Hajime Morita.

• Websites/webkit-perf.appspot.com/js/admin.js:
• Websites/webkit-perf.appspot.com/js/config.js:

(sortProperties):
(fetchDashboardManifest):

6:55 PM Changeset in webkit [112823] by rniwa@webkit.org

• 2 edits in trunk

Revert an inadvertently committed change.

• Websites/webkit-perf.appspot.com/app.yaml:

6:46 PM Changeset in webkit [112822] by rniwa@webkit.org

• 11 edits in trunk

perf-o-matic should have a way to hide some platforms and tests
​https://bugs.webkit.org/show_bug.cgi?id=82842

Reviewed by Hajime Morita.

• Websites/webkit-perf.appspot.com/admin.html:
• Websites/webkit-perf.appspot.com/admin_handlers.py:

(AdminDashboardHandler.get_branches): Change the json format to allow platforms and tests to have
"hidden" boolean states.
(AdminDashboardHandler.get_platforms): Ditto.
(AdminDashboardHandler.get_builders): Just a cleanup. There is no clean for it to have a limit.
(AdminDashboardHandler.get_tests): Change the json format to add "hidden" boolean states.
(ChangeVisibilityHandler): Added.
(ChangeVisibilityHandler.post): Added. Changes the hidden-state (visibility) of a platform and a test.

• Websites/webkit-perf.appspot.com/app.yaml: Make sure everything under /admin/ requires admin privilege.
• Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post): Don't emit LF after 'OK'.

• Websites/webkit-perf.appspot.com/css/admin.css: Added a bunch of rules for hide/show button.
• Websites/webkit-perf.appspot.com/js/admin.js:

(submitXHR): Extracted.
(createKeyNameReloader): Added hide/show button on each item and the corresponding ajax request.

• Websites/webkit-perf.appspot.com/json_generators.py:

(DashboardJSONGenerator.init): Skip hidden tests and platforms.
(ManifestJSONGenerator.init): Ditto.

• Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added tests to ensure perf-o-matic

doesn't include hidden tests and platforms in dashboard and manifest json responses.
(DashboardJSONGeneratorTest.test_value_with_hidden_platform_and_tesst):
(ManifestJSONGeneratorTest.test_value_two_tests):
(ManifestJSONGeneratorTest.test_value_with_hidden_platform_and_test):

• Websites/webkit-perf.appspot.com/main.py:
• Websites/webkit-perf.appspot.com/models.py:

(Platform): Added the "hidden" property.
(Test): Ditto. Also removed the comment about this class only exists for efficiency purposes since that's
no longer true.

5:27 PM April 2012 Meeting edited by rniwa@webkit.org

(diff)

5:26 PM April 2012 Meeting edited by rniwa@webkit.org

Add more hackathon ideas (diff)

4:15 PM Changeset in webkit [112821] by jonlee@apple.com

• 21 edits in trunk/Source

Rename notification properties and functions
​https://bugs.webkit.org/show_bug.cgi?id=80482
<rdar://problem/10912432>

Reviewed by Kentaro Hara.

Source/WebCore:

Change method name to close(), and set tag property on Notifications, based on discussions in WG:
​http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
​http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

• notifications/Notification.cpp:

(WebCore::Notification::~Notification): Use close().
(WebCore::Notification::close):

• notifications/Notification.h:

(Notification):
(WebCore::Notification::cancel): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use close().
(WebCore::Notification::replaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use tag().
(WebCore::Notification::setReplaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use setTag().
(WebCore::Notification::tag):
(WebCore::Notification::setTag):

• notifications/Notification.idl: Preserve cancel() and replaceID in ENABLE(LEGACY_NOTIFICATIONS), and

close() and tag in ENABLE(NOTIFICATIONS).

Source/WebKit/chromium:

• src/WebNotification.cpp:

(WebKit::WebNotification::replaceId): Refactor to call tag().

Source/WebKit/mac:

• WebView/WebNotification.h: Rename replaceID to tag.
• WebView/WebNotification.mm:

(-[WebNotification tag]):

Source/WebKit/qt:

• WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::show): Refactor to call tag().
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): Refactor to call tag().

Source/WebKit2:

Rename APIs to use tag.

• UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyTag):

• UIProcess/API/C/WKNotification.h:
• UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

• UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::tag):
(WebNotification):

• UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

• UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

• UIProcess/WebPageProxy.h:

(WebPageProxy):

• UIProcess/WebPageProxy.messages.in:
• WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

4:12 PM Changeset in webkit [112820] by eric@webkit.org

• 4 edits
  11 deletes in trunk

Unreviewed, rolling out r112760.
​http://trac.webkit.org/changeset/112760
​https://bugs.webkit.org/show_bug.cgi?id=82795

Revert addition of webkitseamless. I'll do this work on
GitHub instead to avoid any half-implemented feature concerns.

Source/WebCore:

• html/HTMLAttributeNames.in:
• html/HTMLIFrameElement.idl:

LayoutTests:

• fast/frames/seamless/resources/css-cascade-child.html: Removed.
• fast/frames/seamless/resources/nested-seamless.html: Removed.
• fast/frames/seamless/resources/square.html: Removed.
• fast/frames/seamless/seamless-basic-expected.txt: Removed.
• fast/frames/seamless/seamless-basic.html: Removed.
• fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
• fast/frames/seamless/seamless-css-cascade.html: Removed.
• fast/frames/seamless/seamless-nested-expected.txt: Removed.
• fast/frames/seamless/seamless-nested.html: Removed.
• fast/frames/seamless/seamless-sandbox-flag-expected.txt: Removed.
• fast/frames/seamless/seamless-sandbox-flag.html: Removed.

2:22 PM Changeset in webkit [112819] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Simplify the code that gets accelerated compositing output onto the screen
​https://bugs.webkit.org/show_bug.cgi?id=82845

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-04-01
Reviewed by Rob Buis.

RIM PR: 136381
The code accounted for a now obsolete setup where we used one OpenGL
window for accelerated compositing and one native window for backing
store output, and let the windowing system composite those two. In that
setup an optimization to try and only update the window that had
changed was viable.

Nowadays, we either use an offscreen surface for accelerated
compositing output, which we blend onto the window containing the
backing store output, or render both backing store and accelerated
compositing output directly to one OpenGL window. We always have to
blit the backingstore contents and draw the accelerated compositing
output every frame with these code paths, so don't try to be clever
about it.

Even when we use an OpenGL window, the compositing surface can be non-
null, so don't try to glFinish() and swap the compositing surface when
the GLES2Context is tied to a window.

• Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(WebKit):

• Api/BackingStore_p.h:

(BackingStorePrivate):

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):

• WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::swapBuffers):

1:23 PM Changeset in webkit [112818] by timothy@apple.com

• 2 edits in trunk/Source/WebCore

Fix a crash when closing a tab/window while the Web Inspector is stopped in the debugger.

​https://webkit.org/b/82846
rdar://problem/8133494

Reviewed by Yury Semikhatsky.

• bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::didPause): Added assert for page and early return. Also assert that
m_pausedPage is null.
(WebCore::PageScriptDebugServer::didContinue): Page can be null if we are continuing because the Page closed.
So add a null check before using it. Added an assert that the page is null or m_pausedPage.
(WebCore::PageScriptDebugServer::didRemoveLastListener): Added assert for page.

11:40 AM Changeset in webkit [112817] by mitz@apple.com

• 3 edits in trunk/LayoutTests

Corrected the expected results for this test.

• platform/mac/fast/text/international/text-spliced-font-expected.png:
• platform/mac/fast/text/international/text-spliced-font-expected.txt:

11:21 AM Changeset in webkit [112816] by mitz@apple.com

• 18 edits
  5 copies in trunk

Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
​https://bugs.webkit.org/show_bug.cgi?id=82810

CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).

When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.

To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.

Patch by Tony Tseung <​tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

Added test LayoutTests/fast/text/international/text-spliced-font.html

• WebCore.exp.in:

Replaced obsolete FontPlatformData constructor entry.

• platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.

(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.

• platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.

(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.

(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.

(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.

• platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.

• platform/graphics/SimpleFontData.h:

(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.

(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.

• platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.

(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.

• platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.

• platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.

(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.

• platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.

Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
​https://bugs.webkit.org/show_bug.cgi?id=82810

A new test font of this kind as been added to the test tools for running the webkit-tests

Patch by Tony Tseung <​tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

• DumpRenderTree/fonts/SampleFont.sfont: Added.

• DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
• DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(activateTestingFonts):
Added the registration of the Composite Font Referene sample font

• WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

• WebKitTestRunner/fonts/SampleFont.sfont: Added.

LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
​https://bugs.webkit.org/show_bug.cgi?id=82810

Added new LayoutTests/fast/text/international/text-spliced-font.html

Patch by Tony Tseung <​tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

• fast/text/international/text-spliced-font.html: Added.
• platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
• platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.

8:09 AM Changeset in webkit [112815] by gyuyoung.kim@samsung.com

• 22 edits
  39 adds in trunk

Support the Network Information API
​https://bugs.webkit.org/show_bug.cgi?id=73528

Reviewed by Adam Barth.

.:

Add network information API feature.

• Source/cmake/OptionsEfl.cmake: Add NETWORK_INFO feature.
• Source/cmakeconfig.h.cmake: Add NETWORK_INFO feature.

Source/WebCore:

Network Information APIs is to provide an interface for Web Applications to access
the underlying network information of device. In Web Application case, they need to know
what current network interface it uses. Because, it is important to know current network
information(bandwidth, metered) in mobile domain. Thus, Web Application can let user know
whether current network information via this new functionality. In addition, in streaming
service case, Web Application can control content resolution according to kind of network.

​http://dvcs.w3.org/hg/dap/raw-file/tip/network-api/index.html

Tests: networkinformation/add-listener-from-callback.html

networkinformation/basic-all-types-of-events.html
networkinformation/basic-operation.html
networkinformation/event-after-navigation.html
networkinformation/multiple-frames.html
networkinformation/updates.html
networkinformation/window-property.html

• CMakeLists.txt:
• Modules/networkinfo/NavigatorNetworkInfoConnection.cpp: Added.

(WebCore):
(WebCore::NavigatorNetworkInfoConnection::NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::~NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::from):
(WebCore::NavigatorNetworkInfoConnection::webkitConnection):

• Modules/networkinfo/NavigatorNetworkInfoConnection.h: Added.

(WebCore):
(NavigatorNetworkInfoConnection):

• Modules/networkinfo/NavigatorNetworkInfoConnection.idl: Added.
• Modules/networkinfo/NetworkInfo.cpp: Added.

(WebCore):
(WebCore::NetworkInfo::NetworkInfo):

• Modules/networkinfo/NetworkInfo.h: Added.

(WebCore):
(NetworkInfo):
(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(WebCore::NetworkInfo::metered):

• Modules/networkinfo/NetworkInfoClient.h: Added.

(WebCore):
(NetworkInfoClient):
(WebCore::NetworkInfoClient::~NetworkInfoClient):

• Modules/networkinfo/NetworkInfoConnection.cpp: Added.

(WebCore):
(WebCore::NetworkInfoConnection::create):
(WebCore::NetworkInfoConnection::NetworkInfoConnection):
(WebCore::NetworkInfoConnection::~NetworkInfoConnection):
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):
(WebCore::NetworkInfoConnection::didChangeNetworkInformation):
(WebCore::NetworkInfoConnection::addEventListener):
(WebCore::NetworkInfoConnection::removeEventListener):
(WebCore::NetworkInfoConnection::eventTargetData):
(WebCore::NetworkInfoConnection::ensureEventTargetData):
(WebCore::NetworkInfoConnection::interfaceName):
(WebCore::NetworkInfoConnection::suspend):
(WebCore::NetworkInfoConnection::resume):
(WebCore::NetworkInfoConnection::stop):

• Modules/networkinfo/NetworkInfoConnection.h: Added.

(WebCore):
(NetworkInfoConnection):
(WebCore::NetworkInfoConnection::scriptExecutionContext):
(WebCore::NetworkInfoConnection::canSuspend):
(WebCore::NetworkInfoConnection::refEventTarget):
(WebCore::NetworkInfoConnection::derefEventTarget):

• Modules/networkinfo/NetworkInfoConnection.idl: Added.
• Modules/networkinfo/NetworkInfoController.cpp: Added.

(WebCore):
(WebCore::NetworkInfoController::NetworkInfoController):
(WebCore::NetworkInfoController::~NetworkInfoController):
(WebCore::NetworkInfoController::create):
(WebCore::NetworkInfoController::addListener):
(WebCore::NetworkInfoController::removeListener):
(WebCore::NetworkInfoController::didChangeNetworkInformation):
(WebCore::NetworkInfoController::isActive):
(WebCore::NetworkInfoController::supplementName):
(WebCore::provideNetworkInfoTo):

• Modules/networkinfo/NetworkInfoController.h: Added.

(WebCore):
(NetworkInfoController):
(WebCore::NetworkInfoController::client):
(WebCore::NetworkInfoController::from):

• dom/EventNames.h:

(WebCore):

• dom/EventTargetFactory.in:
• testing/Internals.cpp:

(WebCore::Internals::setNetworkInformation):
(WebCore):

• testing/Internals.h:

(Internals):

• testing/Internals.idl:

Source/WebKit:

• PlatformEfl.cmake: Add dummy NetworkInfoClientEfl.cpp files in order to support network information API.

Source/WebKit/efl:

Add NetworkInfoClientEfl to support network information API. However,
functions are not implemented yet.

• WebCoreSupport/NetworkInfoClientEfl.cpp: Added.

(WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
(WebCore):
(WebCore::NetworkInfoClientEfl::~NetworkInfoClientEfl):
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):

• WebCoreSupport/NetworkInfoClientEfl.h: Added.

(NetworkInfoClientEfl):

• ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools:

Add network information API feature to build script.

• Scripts/build-webkit:

LayoutTests:

Add new test cases for network information API specification.
And also, skip this test cases for other ports.

• networkinformation/add-listener-from-callback-expected.txt: Added.
• networkinformation/add-listener-from-callback.html: Added.
• networkinformation/basic-all-types-of-events-expected.txt: Added.
• networkinformation/basic-all-types-of-events.html: Added.
• networkinformation/basic-operation-expected.txt: Added.
• networkinformation/basic-operation.html: Added.
• networkinformation/event-after-navigation-expected.txt: Added.
• networkinformation/event-after-navigation.html: Added.
• networkinformation/multiple-frames-expected.txt: Added.
• networkinformation/multiple-frames.html: Added.
• networkinformation/resources/event-after-navigation-new.html: Added.
• networkinformation/script-tests/add-listener-from-callback.js: Added.

(checkNetworkInformation):
(firstListener):
(secondListener):
(maybeFinishTest):

• networkinformation/script-tests/basic-all-types-of-events.js: Added.

(checkNetworkInformation):

• networkinformation/script-tests/basic-operation.js: Added.
• networkinformation/script-tests/event-after-navigation.js: Added.
• networkinformation/script-tests/multiple-frames.js: Added.

(checkNetworkInformation):
(checkChildNetworkInformation):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):

• networkinformation/script-tests/updates.js: Added.

(checkNetworkInformation):
(setNetworkInformation):
(firstListener):
(updateListener):

• networkinformation/script-tests/window-property.js: Added.

(hasOnConnectionProperty):

• networkinformation/updates-expected.txt: Added.
• networkinformation/updates.html: Added.
• networkinformation/window-property-expected.txt: Added.
• networkinformation/window-property.html: Added.
• platform/gtk/Skipped:
• platform/mac/Skipped:
• platform/qt/Skipped:
• platform/wincairo/Skipped:

6:40 AM Changeset in webkit [112814] by leo.yang@torchmobile.com.cn

• 2 edits in trunk/Source/WebCore

[BlackBerry] Use GraphicsContext::fillPath() and strokePath instead of drawPath() in RenderThemeBlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=81486

Reviewed by Rob Buis.

RenderThemeBlackBerry was using GraphicsContext::drawPath() that's added for BlackBerry internally.
But we already have fillPath() and strokePath() in GraphicsContext. So just substitute drawPath()
by them. Also fix a build issue by adding a #include line.

No functionalities changed, no new tests.

• platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):
(WebCore::RenderThemeBlackBerry::paintButton):

5:09 AM Changeset in webkit [112813] by Nikolas Zimmermann

• 44 edits
  49 adds in trunk

Enable animVal support for SVGAnimatedEnumeration
​https://bugs.webkit.org/show_bug.cgi?id=82459

Reviewed by Dirk Schulze.

Source/WebCore:

Enable animVal support for the last missing SVG DOM primitive: SVGAnimatedEnumeration.
It's a bit more involved than the others as we have to differentiate between the various
enumerations to use the correct SVGPropertyTraits<MyEnum>::fromString() code-path.

One SVGAnimatedEnumeration property in the SVG DOM is special: SVGAnimatedEnumeration orientType
from SVGMarkerElement. SVGMarkerElement exposes both the orientType and SVGAnimatedAngle orientAngle
SVG DOM properties and both get mapped to the same SVGNames::orientAttr ("orient" XML attribute).
That means that any animation of the orientAttr has to update both orientType & orientAngle.

This is a not a new requirement, we already support attributes like 'stdDeviation' from
SVGFEGaussianBlurElement, which get mapped to multiple SVG DOM objects: SVGAnimatedInteger stdDeviationX/Y.
The difference is that <integer-optional-integer> or <number-optional-number> animations use the
same type in the pair<xxx, xxx> (eg. both int, or both float). The 'orient' attribute needs to be
mapped to pair<xxx, yyy> types. Generalize the templates in SVGAnimatedTypeAnimator to support that.

Example:
<marker id="someMarkerElement" orient="45deg"/>
<animate fill="remove" begin="1s" dur="2s" from="90deg" to="auto" attributeName="orient" xlink:href="#someMarkerElement"/>

at 0s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 1s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 90

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 2s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO

someMarkerElement.orientAngle.animVal.value = 0

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

3s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

We need to map the 'orient' attribute to a pair<SVGAngle, unsigned short> type, in order
to track both orientAngle & orientType at the same type. Fortunately SVGAnimatedAngle
is only used in the SVG DOM for SVGMarkerElements orientAngle property. We can directly
switch SVGAnimatedAngleAnimator to the new pair<SVGAngle, unsigned short> type instead
of having to introduce a special SVGAnimatedAngleAndEnumerationAnimator.

Added tests for all SVGAnimatedEnumeration properties in the SVG DOM, including an extensive set of tests
for the synchronization of the orientType / orientAngle properties, when they get animated.

Tests: svg/animations/animate-marker-orient-from-angle-to-angle.html

svg/animations/animate-marker-orient-from-angle-to-auto.html
svg/animations/animate-marker-orient-to-angle.html
svg/animations/svgenum-animation-1.html
svg/animations/svgenum-animation-10.html
svg/animations/svgenum-animation-11.html
svg/animations/svgenum-animation-12.html
svg/animations/svgenum-animation-13.html
svg/animations/svgenum-animation-2.html
svg/animations/svgenum-animation-3.html
svg/animations/svgenum-animation-4.html
svg/animations/svgenum-animation-5.html
svg/animations/svgenum-animation-6.html
svg/animations/svgenum-animation-7.html
svg/animations/svgenum-animation-8.html
svg/animations/svgenum-animation-9.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.xcodeproj/project.pbxproj:
• svg/SVGAllInOne.cpp:
• svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):

• svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

• svg/SVGAnimatedAngle.h:

(WebCore):

• svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedEnumeration.cpp: Added.

(WebCore):
(WebCore::enumerationValueForTargetAttribute):
(WebCore::SVGAnimatedEnumerationAnimator::SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::constructFromString):
(WebCore::SVGAnimatedEnumerationAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedEnumerationAnimator::animValWillChange):
(WebCore::SVGAnimatedEnumerationAnimator::animValDidChange):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedEnumerationAnimator::calculateDistance):

• svg/SVGAnimatedEnumeration.h:

(SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::~SVGAnimatedEnumerationAnimator):
(WebCore):

• svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):

• svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

• svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):

• svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngleAndEnumeration):
(WebCore::SVGAnimatedType::createEnumeration):
(WebCore):
(WebCore::SVGAnimatedType::angleAndEnumeration):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

• svg/SVGAnimatedType.h:

(SVGAnimatedType):

• svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::executeAction):

• svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

• svg/SVGMarkerElement.cpp:

(WebCore):

• svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):

• svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):

• svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new tests for all SVGAnimatedEnumeration in the SVG DOM to proof they animate and update animVal correctly.

• svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Added.
• svg/animations/animate-marker-orient-from-angle-to-angle.html: Added.
• svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Added.
• svg/animations/animate-marker-orient-from-angle-to-auto.html: Added.
• svg/animations/animate-marker-orient-to-angle-expected.txt: Added.
• svg/animations/animate-marker-orient-to-angle.html: Added.
• svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

• svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

• svg/animations/script-tests/animate-marker-orient-to-angle.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

• svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(sample3):

• svg/animations/script-tests/svgenum-animation-1.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/script-tests/svgenum-animation-10.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/script-tests/svgenum-animation-11.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

• svg/animations/script-tests/svgenum-animation-12.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

• svg/animations/script-tests/svgenum-animation-13.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

• svg/animations/script-tests/svgenum-animation-2.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

• svg/animations/script-tests/svgenum-animation-3.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/script-tests/svgenum-animation-4.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

• svg/animations/script-tests/svgenum-animation-5.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/script-tests/svgenum-animation-6.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

• svg/animations/script-tests/svgenum-animation-7.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/script-tests/svgenum-animation-8.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

• svg/animations/script-tests/svgenum-animation-9.js: Added.

(sample1):
(sample2):
(executeTest):

• svg/animations/svgangle-animation-deg-to-grad-expected.txt:
• svg/animations/svgangle-animation-deg-to-rad-expected.txt:
• svg/animations/svgangle-animation-grad-to-deg-expected.txt:
• svg/animations/svgangle-animation-grad-to-rad-expected.txt:
• svg/animations/svgangle-animation-rad-to-deg-expected.txt:
• svg/animations/svgangle-animation-rad-to-grad-expected.txt:
• svg/animations/svgenum-animation-1-expected.txt: Added.
• svg/animations/svgenum-animation-1.html: Added.
• svg/animations/svgenum-animation-10-expected.txt: Added.
• svg/animations/svgenum-animation-10.html: Added.
• svg/animations/svgenum-animation-11-expected.txt: Added.
• svg/animations/svgenum-animation-11.html: Added.
• svg/animations/svgenum-animation-12-expected.txt: Added.
• svg/animations/svgenum-animation-12.html: Added.
• svg/animations/svgenum-animation-13-expected.txt: Added.
• svg/animations/svgenum-animation-13.html: Added.
• svg/animations/svgenum-animation-2-expected.txt: Added.
• svg/animations/svgenum-animation-2.html: Added.
• svg/animations/svgenum-animation-3-expected.txt: Added.
• svg/animations/svgenum-animation-3.html: Added.
• svg/animations/svgenum-animation-4-expected.txt: Added.
• svg/animations/svgenum-animation-4.html: Added.
• svg/animations/svgenum-animation-5-expected.txt: Added.
• svg/animations/svgenum-animation-5.html: Added.
• svg/animations/svgenum-animation-6-expected.txt: Added.
• svg/animations/svgenum-animation-6.html: Added.
• svg/animations/svgenum-animation-7-expected.txt: Added.
• svg/animations/svgenum-animation-7.html: Added.
• svg/animations/svgenum-animation-8-expected.txt: Added.
• svg/animations/svgenum-animation-8.html: Added.
• svg/animations/svgenum-animation-9-expected.txt: Added.
• svg/animations/svgenum-animation-9.html: Added.

1:25 AM Changeset in webkit [112812] by Csaba Osztrogonác

• 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r112799.

• platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
• platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:

1:23 AM Changeset in webkit [112811] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[chromium] Do not generate custom signature for static methods.
​https://bugs.webkit.org/show_bug.cgi?id=79222

Patch by Hao Zheng <​zhenghao@chromium.org> on 2012-04-01
Reviewed by Kentaro Hara.

No new tests. Covered by existing tests when MEDIA_STREAM is disabled.

• bindings/scripts/CodeGeneratorV8.pm:

(RequiresCustomSignature):