Context Navigation

← Previous Period
Next Period →

Timeline

Apr 4, 2012:

11:40 PM Changeset in webkit [113295] by Patrick Gansterer

10 edits in trunk/Source

Add WTF::getCurrentLocalTime()
https://bugs.webkit.org/show_bug.cgi?id=83164

Reviewed by Alexey Proskuryakov.

Replace the calls to WTF::getLocalTime() with time(0) with the new function.
This allows us to use Win32 API on windows to get the same result in a next step.

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/DateConstructor.cpp:

(JSC::callDate):

Source/WebCore:

html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

Source/WTF:

Also remove the inline keyword from WTF::getLocalTime(), since there is no need for
it and it will make the later Win32 API changes easier.

WTF.gyp/WTF.gyp:
wtf/CurrentTime.cpp:

(WTF::getLocalTime):
(WTF::getCurrentLocalTime):

wtf/CurrentTime.h:

10:29 PM Changeset in webkit [113294] by hayato@chromium.org

22 edits
4 deletes in trunk

Remove ReifiedTreeTraversal.
https://bugs.webkit.org/show_bug.cgi?id=83110

Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore:

We can now remove ReifiedTreeTraversal. All clients have switched to use ComposedShadowTreeWalker.

No new tests. No change in functionality.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/ReifiedTreeTraversal.cpp: Removed.
dom/ReifiedTreeTraversal.h: Removed.
testing/Internals.cpp:
testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

fast/dom/shadow/reified-tree-traversal-expected.txt: Removed.
fast/dom/shadow/reified-tree-traversal.html: Removed.
platform/efl/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

10:29 PM Changeset in webkit [113293] by rakuco@webkit.org

2 edits in trunk/Source/WebKit/efl

Another unreviewed attempt at getting the EFL build bot to a
healthy state by forcing a rebuild.

ewk/ewk_cookies.h:

10:17 PM Changeset in webkit [113292] by yutak@chromium.org

3 edits in trunk/LayoutTests

Layout Test http/tests/websocket/tests/hybi/workers/worker-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83173

Reviewed by David Levin.

Try to deflake the test by

decreasing the number of reloads in the test, and
changing the URL of WebSocket to silence random console messages.

http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html:

Reloading 100 times seemed too much, as Chromium debug bots frequently time out.

http/tests/websocket/tests/hybi/workers/resources/worker-reload.js:

Use a real URL to avoid random console messages.

10:15 PM Changeset in webkit [113291] by dslomov@google.com

2 edits in trunk/Source/WebCore

WorkerEventQueue::close might access deleted WorkerEventQueue::EventDispatcherTask.
https://bugs.webkit.org/show_bug.cgi?id=83202

On closing the event queue, WorkerEventQueue cancels all the tasks associated with events.
The tasks in their turn delete themselves from the map whenever task gets executed.
However if shutdown occurs when task is in queue but before task gets executed, the task will be deleted without execution.
This patch makes sure that no deleted tasks stay in WorkerEventQueue, by task removing itself in destructor.

Reviewed by David Levin.

Covered by existing tests.

workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::EventDispatcherTask::~EventDispatcherTask):
(WorkerEventQueue::EventDispatcherTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):

10:13 PM Changeset in webkit [113290] by rakuco@webkit.org

2 edits in trunk/Source/WebKit/efl

Unreviewed; touch a file to check if the EFL build bot is back to
normal.

ewk/ewk_cookies.h:

9:30 PM Changeset in webkit [113289] by jchaffraix@webkit.org

3 edits in trunk/Source/WebCore

RenderLayer scrollbars' updates should be split between layout induced and style change induced
https://bugs.webkit.org/show_bug.cgi?id=83213

Reviewed by Simon Fraser.

Refactoring only, no change in behavior.

This patches splits up the 2 reasons for modifying the scrollbars:

style updates, handled in updateScrollbarsAfterStyleChange.
layout time, handled in updateScrollbarsAfterLayout.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsSize):
Removed now unneeded const-casts.

(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
Updated to use hasHorizontalScrollbar / hasVerticalScrollbar.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Made those functions |const|.

(WebCore::RenderLayer::computeScrollDimensions):
Removed the unneeded booleans and move the do-we-have-overflow-logic
into hasHorizontalOverflow and hasVerticalOverflow.

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):
Added those new helper functions.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Updated the latter to call the former.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
(WebCore::RenderLayer::styleChanged):
Ditto.

(WebCore::overflowCanHaveAScrollbar):
Add this helper function for updateScrollbarsAfterStyleChange.

rendering/RenderLayer.h:

(WebCore::RenderLayer::hasHorizontalScrollbar):
(WebCore::RenderLayer::hasVerticalScrollbar):
Added those 2 new helper functions.

9:28 PM Changeset in webkit [113288] by timothy_horton@apple.com

2 edits in trunk/Tools

[mac] WKTR should always keep its windows offscreen
https://bugs.webkit.org/show_bug.cgi?id=83244
<rdar://problem/11188764>

Reviewed by Simon Fraser.

We don't want to allow windows onto the main display; intercept attempts to
change WebKitTestRunnerWindow's frame origin and prevent it from happening.

Also keep around and respond with a new "fake" origin, in case someone is
expecting it to change (I couldn't find any tests that expected this, however).

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow setFrameOrigin:]):
(-[WebKitTestRunnerWindow setFrame:display:animate:]):
(-[WebKitTestRunnerWindow setFrame:display:]):
(-[WebKitTestRunnerWindow frame]):

9:22 PM Changeset in webkit [113287] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.

No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.

dom/Document.cpp:

(WebCore::Document::implicitClose):

page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

9:18 PM Changeset in webkit [113286] by abarth@webkit.org

4 edits
2 adds in trunk

XSSAuditor doesn't catch injected srcdoc attributes
https://bugs.webkit.org/show_bug.cgi?id=83238

Reviewed by Daniel Bates.

Source/WebCore:

Test: http/tests/security/xssAuditor/iframe-srcdoc.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

html/parser/XSSAuditor.h:

LayoutTests:

http/tests/security/xssAuditor/iframe-srcdoc-expected.txt: Added.
http/tests/security/xssAuditor/iframe-srcdoc.html: Added.

9:06 PM Changeset in webkit [113285] by leo.yang@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] Add local: protocol support in KURL for blackberry
https://bugs.webkit.org/show_bug.cgi?id=82695

Reviewed by Rob Buis.

BlackBerry porting is using local: protocol just as file: protocol
with the exception that it sandboxes the path to the application private space.

platform/KURL.cpp:

(WebCore::KURL::parse):
(WebCore::portAllowed):

8:44 PM Changeset in webkit [113284] by Simon Fraser

3 edits
2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Fix an issue when removing elements with reflections from the document.

Test: compositing/reflections/remove-reflection.html

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::willBeDestroyed):

LayoutTests: REGRESSION(112939): compositing/reflections/backface-hidden-reflection.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Test that removes reflected elements.

compositing/reflections/remove-reflection-expected.txt: Added.
compositing/reflections/remove-reflection.html: Added.

8:43 PM Changeset in webkit [113283] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebCore

Need using namespace std for system calls in MIMESniffing.cpp
https://bugs.webkit.org/show_bug.cgi?id=82706

Reviewed by Antonio Gomes.

No new tests, just fix the compile error for BlackBerry porting.

platform/network/MIMESniffing.cpp:

8:36 PM Changeset in webkit [113282] by commit-queue@webkit.org

12 edits in trunk

Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Patch by Greg Billock <gbillock@google.com> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

Modules/intents/DOMWindowIntents.idl:
Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity):

Modules/intents/NavigatorIntents.h:

(NavigatorIntents):

Modules/intents/NavigatorIntents.idl:

LayoutTests:

webintents/resources/web-intents-reload-orig.html:
webintents/resources/web-intents-testing.js:

(startIntentWithCallbacks):

webintents/web-intents-api-expected.txt:
webintents/web-intents-api.html:
webintents/web-intents-invoke.html:

8:08 PM Changeset in webkit [113281] by alexis.menard@openbossa.org

11 edits in trunk/Source/WebCore

[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83224

Reviewed by Tony Chang.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

page/animation/AnimationBase.h:

(WebCore::AnimationBase::affectsProperty):
(WebCore::AnimationBase::isAnimatingProperty):

page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):

page/animation/CompositeAnimation.h:

(CompositeAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::affectsProperty):

page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::transitionProperty):
(WebCore::ImplicitAnimation::animatingProperty):
(ImplicitAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::affectsProperty):

page/animation/KeyframeAnimation.h:

(KeyframeAnimation):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::transitionPaused):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

7:50 PM Changeset in webkit [113280] by tkent@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Calendar Picker: Add localization functions
https://bugs.webkit.org/show_bug.cgi?id=83235

Reviewed by Adam Barth.

Implement calendarTodayText() and calendarClearText(), which are
introduced in http://trac.webkit.org/changeset/113166

public/platform/WebLocalizedString.h:

Add CalendarClear and CalendarToday.

src/LocalizedStrings.cpp:

(WebCore::calendarTodayText): Added.
(WebCore::calendarClearText): Added.

7:50 PM Changeset in webkit [113279] by rafaelw@chromium.org

5 edits
2 adds in trunk

[MutationObservers] implement takeRecords()
https://bugs.webkit.org/show_bug.cgi?id=83218

Reviewed by Ojan Vafai.

Source/WebCore:

This patch implements MutationObserver.takeRecords per the DOM4 spec.
takeRecords retrieves and clears any pending mutation records for
the observer.

Test: fast/mutation/takeRecords.html

dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::takeRecords):
(WebCore):
(WebCore::WebKitMutationObserver::deliver):

dom/WebKitMutationObserver.h:
dom/WebKitMutationObserver.idl:

LayoutTests:

fast/mutation/takeRecords-expected.txt: Added.
fast/mutation/takeRecords.html: Added.

7:42 PM Changeset in webkit [113278] by inferno@chromium.org

2 edits in trunk/LayoutTests

Rebaseline for r113252.

Unreviewed.

platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:

7:35 PM Changeset in webkit [113277] by dpranke@chromium.org

2 edits in trunk/Tools

Fix typo introduced in r113271.

Unreviewed, build fix.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader._upload_data.callback):
(FileUploader):

7:28 PM Changeset in webkit [113276] by shinyak@chromium.org

12 edits
2 adds in trunk

Shadow DOM is exposed in JS.
https://bugs.webkit.org/show_bug.cgi?id=82607

Reviewed by Hajime Morita.

Source/autotools/symbols.filter:

Source/WebCore:

DOMSelection didn't consider nested shadow trees. This patch makes DOMSelection
take nested shadow trees into account.

To test that the element is not in a shadow tree, Internals has a treeScopeRootNode method
which returns the root node of the belonging tree scope.

Test: fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html

WebCore.exp.in:
page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor):
(WebCore):

testing/Internals.cpp:

(WebCore::Internals::treeScopeRootNode):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt: Added.
fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html: Added.

7:07 PM Changeset in webkit [113275] by hayato@chromium.org

3 edits in trunk/LayoutTests

Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
https://bugs.webkit.org/show_bug.cgi?id=82593

Reviewed by Dimitri Glazkov.

Prior to r113125, if we traverse a ShadowRoot which does not have any children,
it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
Adds a test case for that to catch a future regression.

fast/dom/shadow/focus-navigation-expected.html:
fast/dom/shadow/focus-navigation.html:

6:57 PM Changeset in webkit [113274] by commit-queue@webkit.org

2 edits in trunk/Tools

[Chromium, DRT] Bounds check indices on gamepadController
https://bugs.webkit.org/show_bug.cgi?id=83192

Invalid test data would cause bad array accesses. Add simple checks to
ignore such invalid data.

Patch by Scott Graham <scottmg@google.com> on 2012-04-04
Reviewed by Kent Tamura.

DumpRenderTree/chromium/GamepadController.cpp:

(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

6:42 PM Changeset in webkit [113273] by macpherson@chromium.org

9 edits in trunk/Source/WebCore

Replace further usage of int with CSSPropertyID.
https://bugs.webkit.org/show_bug.cgi?id=83119

Reviewed by Simon Fraser.

No new tests / no functionality changed.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSGrammar.y:
css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):

css/CSSParser.h:

(CSSParser):
(WebCore::ShorthandScope::~ShorthandScope):

css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

css/StylePropertySet.h:

(StylePropertySet):

css/makeprop.pl:
dom/StyledElement.h:

(StyledElement):

editing/EditingStyle.h:

(EditingStyle):

html/HTMLElement.h:

(HTMLElement):

6:38 PM Changeset in webkit [113272] by adamk@chromium.org

11 edits in trunk/Source/WebCore

Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

Relanding r112163 without modification, as it still seems valid.
Will watch Chrome Canaries closely for any memory issues.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.

bindings/v8/V8Proxy.h:

(WebCore::toV8): Remove explicit ref.

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.

bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): ditto.

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

6:17 PM Changeset in webkit [113271] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

More debugging info and a possible fix - stop messing with the
default network timeout, and don't swallow URLErrors.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader._upload_data):

Scripts/webkitpy/common/net/networktransaction.py:

(NetworkTransaction.run):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

5:56 PM Changeset in webkit [113270] by oliver@apple.com

5 edits in trunk

Parser fails to revert some state after parsing expression and object literals.
https://bugs.webkit.org/show_bug.cgi?id=83236

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Reset left hand side counter after parsing the literals.

parser/Parser.cpp:

(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):

LayoutTests:

Add more parser test cases.

fast/js/parser-syntax-check-expected.txt:
fast/js/script-tests/parser-syntax-check.js:

5:48 PM Changeset in webkit [113269] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG InstanceOf should not uselessly speculate cell
https://bugs.webkit.org/show_bug.cgi?id=83234

Reviewed by Oliver Hunt.

If InstanceOf is the only user of its child then don't speculate cell, since
the not-cell case is super easy to handle.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOf):

5:14 PM Changeset in webkit [113268] by crogers@google.com

2 edits in trunk/Source/WebCore

WaveTable::waveDataForFundamentalFrequency() should properly interpret negative frequency
https://bugs.webkit.org/show_bug.cgi?id=83228

Reviewed by Kenneth Russell.

Modules/webaudio/WaveTable.cpp:

(WebCore::WaveTable::waveDataForFundamentalFrequency):

5:05 PM Changeset in webkit [113267] by adamk@chromium.org

5 edits
2 adds in trunk

Delay post-insertion notifications until new DOM tree is complete
https://bugs.webkit.org/show_bug.cgi?id=82631

Reviewed by Ojan Vafai.

Source/WebCore:

When inserting a DocumentFragment, WebKit previously would update both
internal WebCore state and mutation event listeners after each node
was inserted. This is inconsistent not only with DOM4, but also
with (at least) Firefox and IE. Given the many bugs over the years in
WebKit due to this behavior, it seems better to delay notification
until the fragment is completely inserted.

The changes to the three core mutation methods below are similar:
the only logic remaining in the loop is checking that insertion is
possible and taking care of that insertion. The entire loop is then
wrapped in forbidEventDispatch/allowEventDispatch, effectively
asserting that none of the code inside will have side effects.

The one bit of logic added to the loop is resizing the targets
vector down to the set of nodes actually inserted as part of the
loop. This makes it possible to simply pass the vector on to
notifyChildrenInserted without having to also pass along a count of
actually-inserted nodes.

As for the code that used to live inside the loop that could have
side-effects, or depended on those side-effects, it has been moved
out, either above (the check that the refChild is still valid in
insertBefore) or after (the calls to notifyChildrenInserted).

Finally, it was necessary to retrofit ChildListMutationScope to take a
vector of added nodes instead of a single node at a time, due to the
assertions in isAddedNodeInOrder (now renamed to be plural). Note that
there is now a single call to ChildListMutationScope::childrenAdded,
inside notifyChildrenInserted.

Test: fast/events/domnodeinserted-entire-fragment.html

dom/ChildListMutationScope.cpp:

(ChildListMutationScope::MutationAccumulator): Renamed method to be plural.
(WebCore::ChildListMutationScope::MutationAccumulator::areAddedNodesInOrder): Handle a NodeVector instead of a Node.
(WebCore::ChildListMutationScope::MutationAccumulator::childrenAdded): Handle adding a NodeVector instead of a Node.
(WebCore::ChildListMutationScope::MutationAccumulationRouter::childrenAdded): Renamed to be plural, pass NodeVector through.

dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::childrenAdded): ditto.
(MutationAccumulationRouter):

dom/ContainerNode.cpp:

(WebCore): Renamed updateTreeAfterInsertion to notifyChildrenInserted.
(WebCore::ContainerNode::insertBefore): See main ChangeLog explanation.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.
(WebCore::dispatchChildInsertionEvents): Remove MutationObserver handling.
(WebCore::notifyChildrenInserted): Handle a NodeVector of all inserted children,
and take on responsiblity for MutationObserver handling as well as dispatchSubtreeModifiedEvent.

LayoutTests:

fast/events/domnodeinserted-entire-fragment-expected.txt: Added.
fast/events/domnodeinserted-entire-fragment.html: Added.

5:03 PM Changeset in webkit [113266] by crogers@google.com

5 edits in trunk

RealtimeAnalyserNode should support smaller analysis sizes
https://bugs.webkit.org/show_bug.cgi?id=83215

Source/WebCore:

Reviewed by Kenneth Russell.

RealtimeAnalyserNode analysis size currently goes no lower than 128.
It is useful to support lower power-of-two sizes.
Decrease this limit to 32.

Updated webaudio/realtimeanalyser-fft-sizing-expected.txt

Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore):

LayoutTests:

Reviewed by Kenneth Russell.

webaudio/realtimeanalyser-fft-sizing-expected.txt:
webaudio/realtimeanalyser-fft-sizing.html:

5:00 PM Changeset in webkit [113265] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Unify and modernize fast/css/{outline,background}-currentcolor.html
https://bugs.webkit.org/show_bug.cgi?id=75523

Patch by David Barr <davidbarr@chromium.org> on 2012-04-04
Reviewed by Daniel Bates.

Use js-test-pre utility functions instead of hardcoded testing logic
to simplify the test code and make the test more closely conform to
the visual appearance of other PASS/FAIL tests.

fast/css/background-currentcolor-expected.txt:
fast/css/background-currentcolor.html:
fast/css/outline-currentcolor-expected.txt:
fast/css/outline-currentcolor.html:

4:57 PM Changeset in webkit [113264] by tony@chromium.org

3 edits
2 adds in trunk

CSS transitions should work on the flex property
https://bugs.webkit.org/show_bug.cgi?id=75915

Reviewed by Dean Jackson.

Source/WebCore:

Test: transitions/flex-transitions.html

page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperGetter::equals): Fix indention.
(PropertyWrapperFlex): Add a wrapper for -webkit-flex which has 3 values (two floats and
a length), but is not a shorthand.
(WebCore::PropertyWrapperFlex::PropertyWrapperFlex):
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):
(WebCore):
(WebCore::AnimationBase::ensurePropertyMap):

LayoutTests:

transitions/flex-transitions-expected.txt: Added.
transitions/flex-transitions.html: Added.

4:54 PM Changeset in webkit [113263] by tsepez@chromium.org

3 edits
2 adds in trunk

XSSAuditor bypass through HTTP Parameter Pollution.
https://bugs.webkit.org/show_bug.cgi?id=81283

Reviewed by Adam Barth.

Source/WebCore:

Deal with concatenation of multiple parameters via comma-splicing that
is common to some webservers. We can no longer trust that all of the
attributes of a reflected script tag, nor the reflected script itself,
came from the same single URL parameter. The fix is to take commas into
account when trucating the snippet used for matching.

Test: http/tests/security/xssAuditor/script-tag-with-comma.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-comma.html: Added.

4:50 PM Changeset in webkit [113262] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Fixed minor error: "& 3" should be "& 2".

Rubber-stamped by Oliver Hunt.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

4:28 PM Changeset in webkit [113261] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Text input doesn't work for some Flash forms
https://bugs.webkit.org/show_bug.cgi?id=83232
<rdar://problem/11186162>

Reviewed by Alexey Proskuryakov.

If a plug-in is instantiated when the WKView is not focused, text input wouldn't work. The reason for this
is that WebPage::windowIsFocused() would only return true if the window and the WKView are both focused. Rename
this member function to windowAndWebPageAreFocused, add a new windowIsFocused member function that does the right thing
and change WebPage::focusedWebPage to use windowAndWebPageAreFocused.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowIsFocused):
(WebKit):
(WebKit::WebPage::windowAndWebPageAreFocused):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::focusedWebPage):

4:23 PM Changeset in webkit [113260] by mitz@apple.com

2 edits in trunk/Source/WebCore

Paginated webviews render nothing in their gutters
https://bugs.webkit.org/show_bug.cgi?id=83231

Reviewed by Adele Peterson.

When the RenderView has columns, nothing draws in the gutters.

page/FrameView.cpp:

(WebCore::FrameView::paintContents): Paint the background color behind everything when
paginated.

4:17 PM Changeset in webkit [113259] by Dimitri Glazkov

1 edit
59 adds in trunk/LayoutTests

[Chromium] Update expectations for Leopard.

platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds: Added.
platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Added.

4:10 PM Changeset in webkit [113258] by tony@chromium.org

3 edits
3 deletes in trunk/LayoutTests

inline script for flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=83220

Reviewed by Ojan Vafai.

Inline the .js test files into the .html files. These tests don't need
to be in a separate file.

css3/flexbox/css-properties.html:
css3/flexbox/display-flexbox-set-get.html:
css3/flexbox/resources/display-flexbox-set-get.js: Removed.
css3/flexbox/script-tests/TEMPLATE.html: Removed.
css3/flexbox/script-tests/css-properties.js: Removed.

4:06 PM Changeset in webkit [113257] by inferno@chromium.org

2 edits in trunk/LayoutTests

Rebaseline for r113252.

Unreviewed.

platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:

4:01 PM Changeset in webkit [113256] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

3:55 PM Changeset in webkit [113255] by commit-queue@webkit.org

7 edits in trunk/Source

Call histogramEnumeration directly
https://bugs.webkit.org/show_bug.cgi?id=83106

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Part of a refactoring project to remove the PlatformSupport
abstraction from some functions. See bug 82948.

Source/WebCore:

bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):

platform/chromium/HistogramSupportChromium.cpp:

(WebCore::HistogramSupport::histogramEnumeration):

platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

src/PlatformSupport.cpp:

(WebCore):

3:53 PM Changeset in webkit [113254] by zmo@google.com

2 edits in trunk/Source/WebCore

2012-04-04 Zhenyao Mo <zmo@google.com>

Unreviewed, GPU bots build fix.

Commited on behalf of sievers@chromium.org.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::canDraw):

3:42 PM Changeset in webkit [113253] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Constant Blinding for add/sub immediate crashes in ArmV7 when dest is SP
https://bugs.webkit.org/show_bug.cgi?id=83191

Reviewed by Oliver Hunt.

Make are that blinded constant pairs are similarly aligned to the
original immediate values so that instructions that expect that
alignment work correctly. One example is ARMv7 add/sub imm to SP.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::add): Added ASSERT that immediate is word aligned.
(JSC::ARMv7Assembler::sub): Added ASSERT that immediate is word aligned.
(JSC::ARMv7Assembler::sub_S): Added ASSERT that immediate is word aligned.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

3:41 PM Changeset in webkit [113252] by inferno@chromium.org

17 edits in trunk

Add helpers to create anonymous table parts.
https://bugs.webkit.org/show_bug.cgi?id=83116

Reviewed by Julien Chaffraix.

Source/WebCore:

The patch introduces helpers to create anonymous table parts by
introducing a new static function createAnonymousWithParentRenderer.
The function builds a new anonymous wrapper of the same type as the class,
inheriting style properties from parent and sets a display based on
argument/default values. Also we streamline the RenderBlock functions
to match this naming convention.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousBlockWithSameTypeAs):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRendererAndDisplay):

rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::createAnonymousBlock):
(WebCore::RenderBlock::createAnonymousColumnsBlock):
(WebCore::RenderBlock::createAnonymousColumnSpanBlock):

rendering/RenderButton.cpp:

(WebCore::RenderButton::addChild):

rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):
(WebCore::RenderTable::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTable.h:

(RenderTable):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTableCell.h:

(RenderTableCell):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):
(WebCore::RenderTableRow::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTableRow.h:

(RenderTableRow):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Rebaselining tests because we now correctly inherit the bidi override.

platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:

3:36 PM Changeset in webkit [113251] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for fast/text/international/spaces-combined-in-vertical-text.html

platform/chromium/test_expectations.txt: Tweaked some more.

3:30 PM Changeset in webkit [113250] by arv@chromium.org

14 edits
6 adds in trunk

[V8] Add a per context data store and use that for caching boiler plates as well as constructor functions
https://bugs.webkit.org/show_bug.cgi?id=83093

Reviewed by Adam Barth.

Source/WebCore:

This introduces a V8BindingPerContextData class. After creating a new v8::Context we also create a new
per context data instance. This instance maintains the boiler plate and constructor caches. V8DOMWrapper
now delegates the caching to this new class. Previously the caching was only done in V8DOMWindowShell which
made workers and isolated worlds behave slightly different.

Tests: fast/dom/constructor-proto.html

fast/workers/constructor-proto.html

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorGetter): Renamed getConstructor to constructorForType.

bindings/v8/V8BindingPerContextData.cpp: Added.

(WebCore):
(WebCore::V8BindingPerContextData::dispose): This clears the persistent handles stored in the maps.
(WebCore::V8BindingPerContextData::init): This installs the hidden prototype which is used as the
Prototype for the constructor functions (for HotMail compat).
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase): Instantiates a new object and
stores it in the boilerplate map, and returns a clone.
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): Creates the function for the constructor
and stores it in the constructor map.

bindings/v8/V8BindingPerContextData.h: Added.

(WebCore):
(V8BindingPerContextData):
(WebCore::V8BindingPerContextData::create):
(WebCore::V8BindingPerContextData::~V8BindingPerContextData):
(WebCore::V8BindingPerContextData::createWrapperFromCache): Checks the cache and clones the wrapper in
the cache. If no boiler plate exists one is created and cached.
(WebCore::V8BindingPerContextData::constructorForType): If the constructor already exists the cached
constructor function is returned, otherwise a new constructor function is created and cached.
(WebCore::V8BindingPerContextData::V8BindingPerContextData):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles): Clear the per context data when disposing the handles.
(WebCore::V8DOMWindowShell::initContextIfNeeded): Create and initialize the per context data.
(WebCore::V8DOMWindowShell::installDOMWindow):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::perContextData):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::constructorForType): Static method to get the constructor. The per context data
is determined based on the type of the parameters.
(WebCore):
(WebCore::V8DOMWrapper::perContextData):
(WebCore::V8DOMWrapper::instantiateV8Object): Use the per context data to unify the code paths.

bindings/v8/V8DOMWrapper.h:

(WebCore):
(V8DOMWrapper):

bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext): Create and initialize the per context data.
(WebCore::V8IsolatedContext::destroy): Clear the per context data.

bindings/v8/V8IsolatedContext.h:

(WebCore):
(WebCore::V8IsolatedContext::perContextData):
(V8IsolatedContext):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrievePerContextData):
(WebCore):

bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::dispose): Clear the per context data
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Create and initialize the per context data.

bindings/v8/WorkerContextExecutionProxy.h:

(WebCore):
(WebCore::WorkerContextExecutionProxy::perContextData):
(WorkerContextExecutionProxy):

LayoutTests:

fast/dom/constructor-proto-expected.txt: Added.
fast/dom/constructor-proto.html: Added.
fast/workers/constructor-proto-expected.txt: Added.
fast/workers/constructor-proto.html: Added.

3:28 PM Changeset in webkit [113249] by jsbell@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, updating expected test output for a test already marked FAIL.
Replace dummy output with real expected output to unblock Chromium-side test.

storage/indexeddb/dont-commit-on-blocked-expected.txt:

3:23 PM Changeset in webkit [113248] by shawnsingh@chromium.org

7 edits in trunk/Source

[chromium] Move recursive renderSurface clearing to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=82091

Reviewed by James Robinson.

Source/WebCore:

No new tests needed, minor refactoring covered by existing tests.

This patch is just a minor cleanup, moving clearRenderSurfacesOnCCLayerImplRecursive()
from LayerRendererChromium to CCLayerTreeHostImpl. It makes more sense to place the code
there, so that LayerRendererChromium is more like a blind utility for drawing things
while CCLayerTreeHostImpl actually manages the state of the resources.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::sendDidLoseContextRecursive):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::rootLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):

3:23 PM Changeset in webkit [113247] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for accessibility/aria-checkbox-sends-notification.html.

platform/chromium/test_expectations.txt: Tweaked expectations.

3:19 PM Changeset in webkit [113246] by eae@chromium.org

1038 edits
503 copies
31 deletes in branches/subpixellayout

Merge trunk changes up until 113241 into subpixel branch.

3:13 PM Changeset in webkit [113245] by crogers@google.com

9 edits in trunk/Source

Web Audio should use MutexTryLocker class
https://bugs.webkit.org/show_bug.cgi?id=83194

Reviewed by Kenneth Russell.

Source/WebCore:

Switch existing Web Audio code from directly calling tryLock() on a Mutex to use a MutexTryLocker.
No new tests since it is a low-level threading primitive and is difficult to test.
Existing Web Audio tests continue to test the process() methods affected.

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRange):

Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::process):

Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::process):

Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::process):

Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::process):

Source/WTF:

Add MutexTryLocker class which can be used as a stack-based object wrapping a Mutex.
It will automatically unlock the Mutex in its destructor if the tryLock() succeeded.

wtf/ThreadingPrimitives.h:

(MutexTryLocker):
(WTF::MutexTryLocker::MutexTryLocker):
(WTF::MutexTryLocker::~MutexTryLocker):
(WTF::MutexTryLocker::locked):
Check if the tryLock() on the Mutex succeeded.
(WTF):

3:06 PM Changeset in webkit [113244] by rakuco@webkit.org

3 edits in trunk/Source/WebCore

[CSS] Make makevalues.pl and makeprop.pl ignore '#'s.
https://bugs.webkit.org/show_bug.cgi?id=83212

Reviewed by Tony Chang.

This patch is a side-effect of my intentions to make the
CMake-based ports work with GCC 4.7 without changing the
parameters currently passed to the preprocessor. "-P" is always
being passed to the preprocessor, but this breaks
dom/make_names.pl due to GCC not outputting empty lines with "-P"
anymore; if I switch to never passing "-P" (my aim), the CSS
scripts currently break because of the additional lines output by
the preprocessor. InFilesParser.pm and make-css-file-array.pl
already skip lines which start with '#', for example.

No new tests, tools plumbing.

css/makeprop.pl:
css/makevalues.pl:

2:48 PM Changeset in webkit [113243] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Disable fancy upsampling and dithering for decoding jpeg on android
https://bugs.webkit.org/show_bug.cgi?id=83196

Patch by Min Qin <qinmin@google.com> on 2012-04-04
Reviewed by Kenneth Russell.

Dithering and fancy upsampling are currently disabled for chrome on android.
This gives us about 20% performance improvement.
Since the screen of mobile devices is small, impact on image quality is limited.
This change does not introduce any changes on other platforms.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(ditherMode):
(doFancyUpsampling):
(WebCore::JPEGImageReader::decode):

2:40 PM WebKit Team edited by Antti Koivisto

(diff)

2:36 PM Changeset in webkit [113242] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark fonts/cursive.html as flaky on LION.

platform/chromium/test_expectations.txt: Marked as flaky.

2:33 PM WebKit Team edited by kling@webkit.org

(diff)

2:27 PM Changeset in webkit [113241] by commit-queue@webkit.org

7 edits in trunk/Source

[Chromium] Always skip draw and readback if there is nothing
to draw.
https://bugs.webkit.org/show_bug.cgi?id=82680

This avoids corruption from pushing frames that have no valid
content drawn into them.
Also in addition to checking for non-existing root layers, check
for root layers with no content bounds. It's possible to see those
with kForceCompositing mode for empty documents.

Patch by Daniel Sievers <sievers@chromium.org> on 2012-04-04
Reviewed by James Robinson.

Added CCLayerTreeHostTestEmptyContentsShouldNotDraw.

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF):
(CCLayerTreeHostTestEmptyContentsShouldNotDraw):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::CCLayerTreeHostTestEmptyContentsShouldNotDraw):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::beginTest):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::afterTest):
(WTF::TEST_F):

2:14 PM Changeset in webkit [113240] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG should short-circuit Branch(LogicalNot(...))
https://bugs.webkit.org/show_bug.cgi?id=83181

Reviewed by Geoff Garen.

Slight (sub 1%) speed-up on V8.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

2:12 PM Changeset in webkit [113239] by Beth Dakin

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=83207
platform/mac/fast/forms/input-list-button-size.html fails on the Mac bots after
r11317

This test is expected to fail now that datalist is disabled.

platform/mac/Skipped:

2:11 PM Changeset in webkit [113238] by jer.noble@apple.com

15 edits in trunk/Source

Full Screen mode should cancel before navigation.
https://bugs.webkit.org/show_bug.cgi?id=81295

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; protect against speculative crasher when a bad client calls the below
functions at inopportune times.

Check that the document is not either detached or in the page cache, and if so, bail out
early:

dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

Source/WebKit/mac:

When a provisional load is started, if the page is currently in full screen mode, instruct
the full screen controller to close the full screen window immediately.

WebView/WebFullScreenController.h:
WebView/WebFullScreenController.mm:

(-[WebFullScreenController isFullScreen]): Added.

WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if

present and in full screen mode.

Source/WebKit2:

When a provisional load is started, if the page is currently in full screen mode, instruct
the full screen controller to close the full screen window immediately.

Close the full screen window controller, if present and in full screen mode:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add boilerplate to support passing through isFullScreen() and close() methods from the WebPageProxy
to the WKFullScreenWindowController:

UIProcess/WebFullScreenManagerProxy.h:
UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController isFullScreen]): Added simple accessor.

UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::close): Pass through to the WKFullScreenWindowController.
(WebKit::WebFullScreenManagerProxy::isFullScreen): Ditto.

2:06 PM Changeset in webkit [113237] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for fast/text/international/spaces-combined-in-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=82669

platform/chromium/test_expectations.txt: Tweaked expectations.

2:06 PM Changeset in webkit [113236] by eae@chromium.org

2 edits in trunk/Source/WebCore

Fix getFilterOutsets parameter types in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=83041

Reviewed by Julien Chaffraix.

The getFilterOutsets method was changed to take integers in r112475, update
RenderLayer to use the right data type for the outset arguments.

No new tests, no change in functionality.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::calculateLayerBounds):

1:51 PM Changeset in webkit [113235] by commit-queue@webkit.org

14 edits in trunk

WKTR needs to implement layoutTestController.setPageVisibility()
https://bugs.webkit.org/show_bug.cgi?id=69554

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Simon Fraser.

Source/WebKit2:

This patch implements the setPageVisibilityState through InjectedBundle
so WKTR supports the Page Visibility API and can set the visibility state
directly to Page.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPageVisibilityState):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit):
(WebKit::InjectedBundle::setPageVisibilityState):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

This patch implements the layoutTestController.setPageVisibility
so WKTR supports the Page Visibility API implementation by using InjectedBundle
to set the visibility state directly to Page.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):
(WTR):
(WTR::LayoutTestController::resetPageVisibility):

WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

platform/wk2/Skipped: Unskipping compositing/video-page-visibility.html

1:47 PM Changeset in webkit [113234] by arv@chromium.org

5 edits in trunk/Source/WebCore

Rebaseline binding tests.

Unreviewed.

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

1:43 PM Changeset in webkit [113233] by dslomov@google.com

5 edits in trunk

Source/WebCore: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090
The implementation of structured cloning algorithm (http://www.w3.org/TR/html5/common-dom-interfaces.html#internal-structured-cloning-algorithm)
in SerializedScriptValue.cpp assigns numerical identifiers to encontered objects as it traverses
the cloned object during serialization.
When the cloning encounters an already seen object, it transfers the assigned numerical id
instead of cloning the object again. Deserialization process then repeats the process in
the mirror fashion, i.e. on deserializing the object it assigns deserialized object a numeric id and if it
deserializes the id it substitutes the perviously deserialized objects. It is critical that serialization and deserialization
assigns numeric ids in the same order.

The bug (discovered by Yong Li) is that when serializing ArrayBufferView, the ids were assigned first to
the ArrayBufferView and then to underlying ArrayBuffer; however on deserialization the ids were assigned another way round.

This patch fixes that by assigning the id first to ArrayBuffer and then to ArrayBufferView, and adds corresponding test cases.

Reviewed by Kenneth Russell.

New test cases added to fast/canvas/web-gl/array-message-passing.html.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(CloneSerializer):
(WebCore::CloneSerializer::recordObject):
(WebCore::CloneSerializer::startObjectInternal):
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090
Adds tests that cover more than one view of the same ArrayBuffer being cloned.

Reviewed by Kenneth Russell.

fast/canvas/webgl/array-message-passing-expected.txt:
fast/canvas/webgl/script-tests/array-message-passing.js:

(typedArrayCompare):
(dataViewCompare):
(dataViewCompare2):
(dataViewCompare3):

1:31 PM Changeset in webkit [113232] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] When setting animation started events, should check the root layer
https://bugs.webkit.org/show_bug.cgi?id=83060

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-04
Reviewed by Adrienne Walker.

No new tests.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::animateLayers):
(WebCore::CCLayerTreeHost::animateLayersRecursive):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

1:27 PM Changeset in webkit [113231] by abarth@webkit.org

3 edits in trunk

[Chromium] TestWebKitAPI links in WebCore twice
https://bugs.webkit.org/show_bug.cgi?id=83177

Reviewed by Dimitri Glazkov.

This is causing link errors in the Windows component build. This patch
moves the dependencies a bit lower down in the dependency diagram in
the hopes of removing the duplicate symbols.

TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

1:10 PM Changeset in webkit [113230] by adamk@chromium.org

9 edits in trunk

Web Inspector: break on DOM node insertion only once per operation, not once per inserted node
https://bugs.webkit.org/show_bug.cgi?id=82967

Reviewed by Ojan Vafai.

Source/WebCore:

This change affects the case where a DocumentFragment is inserted,
rather than a single node. This is most common when using innerHTML:
the effect of the change is that inserting, e.g., '<input><input>',
the SubtreeModified breakpoint will be hit once, rather than twice
(once for each input element). Given that the particular node being
inserted wasn't exposed as part of the breakpoint, this seems strictly
better.

Now that the call to willInsertDOMNode is outside the loop, there's
not an obvious node to pass in as the new child. Luckily, InspectorDOMDebuggerAgent
already ignored that argument, so it's simply been removed from the signature.

This changes paves the way to do only tree-modification work, and no
external notifications, inside the loops in appendChild/insertBefore/replaceChild.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore): Hoisted call to willInsertDOMNode out of loop.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.

inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode): Removed first argument (now takes only the parent).

inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): Removed second argument.

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willInsertDOMNode): Removed second argument.

LayoutTests:

Added test for setting inner HTML and ensuring that only a single
breakpoint is hit.

inspector/debugger/dom-breakpoints.html:
platform/chromium/inspector/debugger/dom-breakpoints-expected.txt:

1:06 PM Changeset in webkit [113229] by jpfau@apple.com

3 edits
2 adds in trunk

Source/WebCore: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

Test: fast/html/pending-stylesheet-crash.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::removedFromDocument):

LayoutTests: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

fast/html/pending-stylesheet-crash-expected.txt: Added.
fast/html/pending-stylesheet-crash.html: Added.

12:50 PM Changeset in webkit [113228] by jonlee@apple.com

21 edits
4 adds in trunk/LayoutTests

Unskip Mac filter pixel tests which changed because of color space adjustment
https://bugs.webkit.org/show_bug.cgi?id=80630

Unreviewed.

platform/mac/test_expectations.txt: Unskip tests now that patch for b80571 landed.
platform/wk2/Skipped: Unskip same tests.

These were rebaselined with color correction. Between WK1 and WK2, however, they still fail
the pixel hash, and completely fail if tolerance is set to 0. https://bugs.webkit.org/show_bug.cgi?id=83187

css3/filters/add-filter-rendering-expected.png:
css3/filters/crash-filter-change-expected.png:
css3/filters/effect-blur-expected.png:
css3/filters/effect-brightness-expected.png:
css3/filters/effect-combined-expected.png:
css3/filters/effect-contrast-expected.png:
css3/filters/effect-drop-shadow-expected.png:
css3/filters/effect-grayscale-expected.png:
css3/filters/effect-hue-rotate-expected.png:
css3/filters/effect-invert-expected.png:
css3/filters/effect-opacity-expected.png:
css3/filters/effect-saturate-expected.png:
css3/filters/effect-sepia-expected.png:
css3/filters/filter-repaint-expected.png:
css3/filters/filter-with-transform-expected.png:
css3/filters/nested-filter-expected.png:
css3/filters/regions-expanding-expected.png:
css3/filters/simple-filter-rendering-expected.png:

These tests fail between WK1 and WK2 because of a difference in the blur. https://bugs.webkit.org/show_bug.cgi?id=83188

platform/mac-wk2/css3/filters/effect-blur-expected.png: Added.
platform/mac-wk2/css3/filters/effect-combined-expected.png: Added.
platform/mac-wk2/css3/filters/effect-opacity-expected.png: Added.
platform/mac-wk2/css3/filters/regions-expanding-expected.png: Added.

12:46 PM Changeset in webkit [113227] by commit-queue@webkit.org

7 edits in trunk/Source

Call histogramCustomCounts directly
https://bugs.webkit.org/show_bug.cgi?id=83112

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

platform/chromium/PlatformSupport.h:

(PlatformSupport):

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::recordMetricsInternal):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

src/painting/PaintAggregator.cpp:

12:35 PM Changeset in webkit [113226] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark fast/writing-mode/relative-positioning-percentages.html as crashing on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=83185

platform/chromium/test_expectations.txt: Marked as crashing.

12:33 PM Changeset in webkit [113225] by alexis.menard@openbossa.org

19 edits in trunk/Source

Source/WebCore: Animation related classes should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Reviewed by Simon Fraser.

Split the concept of animate none and animate all into a separate function rather than using the property member
with some magic value set on it. Make also sure that we use CSSPropertyID all over the place rather than integers.
We still have some place where convert from int to CSSPropertyID (mostly due to the fact that we need to make Hash*
related classes to handle CSSPropertyID). While refactoring I also removed some dead code.

No new tests : not behaviour changes intented.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

page/animation/AnimationBase.cpp:

(WebCore):
(WebCore::PropertyWrapperBase::PropertyWrapperBase):
(WebCore::PropertyWrapperBase::property):
(PropertyWrapperBase):
(WebCore::PropertyWrapperGetter::PropertyWrapperGetter):
(WebCore::PropertyWrapper::PropertyWrapper):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::wrapperForProperty):
(WebCore::AnimationBase::propertiesEqual):
The code removed here could never be reached. propertiesEqual is used only in CompositeAnimation::updateTransitions and through
ImplicitAnimation::isTargetPropertyEqual which is also called in CompositeAnimation. Both calls are protected by an ASSERT in
CompositeAnimation:116 where we make sure the property id we're dealing with is a valid property id, therefore prop can't be equal to
the old value cAnimateAll or even the new mode concept introduced in that patch can't be AnimateAll.
(WebCore::AnimationBase::getPropertyAtIndex):
(WebCore::AnimationBase::blendProperties):
(WebCore::AnimationBase::animationOfPropertyIsAccelerated):
(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):

page/animation/AnimationBase.h:

(AnimationBase):

page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):

page/animation/CompositeAnimation.h:

(CompositeAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
The check removed is useless as ImplicitAnimation constructor ensure via an ASSERT that the animatingProperty value is a correct and valid
property id. Even the old code was ensuring the value of animatingProperty was different from cAnimateAll at construction time. As stated also
in CompositeAnimation::updateTransitions and cover by the same ASSERT explained earlier, ImplicitAnimation are constructed for valid property ids.
(WebCore::ImplicitAnimation::isTargetPropertyEqual):
(WebCore::ImplicitAnimation::blendPropertyValueInStyle):

page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):
(ImplicitAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::timeToNextService):

platform/animation/Animation.cpp:

(WebCore::Animation::Animation):
(WebCore::Animation::operator=):
(WebCore::Animation::animationsMatch):

platform/animation/Animation.h:

(WebCore::Animation::property):
(WebCore::Animation::animationMode):
(WebCore::Animation::setProperty):
(WebCore::Animation::setAnimationMode):
(Animation):
(WebCore::Animation::initialAnimationProperty):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startTransition):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::transitionForProperty):

rendering/style/RenderStyle.h:

Source/WebKit2: Animation related classes should use CSSPropertyId rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Reviewed by Simon Fraser.

The property of the Animation is a CSSPropertyID. It's ok to cast it here as an int for IPC transmission.

Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:11 PM Changeset in webkit [113224] by rakuco@webkit.org

9 edits in trunk

[EFL][DRT] Catch the "resource,request,willsend" signal
https://bugs.webkit.org/show_bug.cgi?id=82192

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-04
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

EFL's FrameLoaderClient now emits the "resource,request,willsend"
signal on the view for all resources about to be loaded, not just the
main frame. Also adds a boolean flag to Ewk_Frame_Resource_Request to
distinguish the request for the main frame from those for
sub-resources.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

ewk/ewk_frame.h:
ewk/ewk_view.h:

Tools:

EFL's DumpRenderTree now catches the "resource,request,willsend"
signal in order to implement the "Blocked access to external URL"
behavior and avoid potential network-related timeouts in the tests.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip related test cases now that EFL's DumpRenderTree
catches the "resource,request,willsend" signal and implements the
"Blocked access to external URL" behavior.

platform/efl/Skipped:

12:10 PM Changeset in webkit [113223] by eae@chromium.org

3 edits in trunk/Source/WebCore

Fix usage of LayoutUnits and snapping for scrolling in RenderBox
https://bugs.webkit.org/show_bug.cgi?id=83073

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and snapping/rounding logic in RenderBox.

No new tests, no change in functionality.

rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
Change scrollWidth to properly pixel snap values.

(WebCore::RenderBox::scrollHeight):
Change scrollHeight to properly pixel snap values.

(WebCore::RenderBox::scrolledContentOffset):
Change to return IntSize to match function definition.

(WebCore::RenderBox::cachedSizeForOverflowClip):
Changed cachedSizeForOverflowClip to LayoutSize as the overflow and clip
rects all have subpixel precision.

rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
Removed FIXME comment as the implementation

(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
Added static_cast for border values.

(WebCore::RenderBox::hasVisualOverflow):
Changed to compare two pixel snapped values as we don't want to indicate
overflow in cases where the the size is rounded down resulting in no
visual overflow.

12:04 PM Changeset in webkit [113222] by eae@chromium.org

11 edits in trunk/Source/WebCore

Fix types for location, size and rect calculations for render objects
https://bugs.webkit.org/show_bug.cgi?id=83089

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and rounding for a couple of different render
object classes.

No new tests, no change in functionality.

rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::getPath):
Change getPath to take a LayoutPoint as the transform has subpixel
precision already.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):
Change logicalHeight to LayoutUnit as it is computed from subpixel
values.

rendering/RenderInputSpeech.cpp:

(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
Change button rect computation to LayoutRect and pixel snap just before
painting to preserve precision.

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
Change range calculations to LayoutUnits to preserve precision.

rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Change width calculations to LayoutUnits to preserve precision.

rendering/RenderTable.cpp:

(WebCore::RenderTable::layoutCaption):
Change table captions to LayoutUnits as the values are computed from
subpixel componenets.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor):
Snap border rect as RoundedRects use ints for crisp rendering.

rendering/style/ShadowData.cpp:

(WebCore::ShadowData::adjustRectForShadow):
Change adjustRectForShadow to take a LayoutRect as it already uses
LayoutUnits.

11:54 AM Changeset in webkit [113221] by eae@chromium.org

3 edits in trunk/Source/WebCore

Convert RootInlineBox to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=83054

Reviewed by Eric Seidel.

Convert RootInlineBox over to LayoutUnits, this mostly involves updating
the alignment and adjustment code to be subpixel aware.

No new tests, no change in functionality.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Change beforeAnnotationsAdjustment to LayoutUnit.

(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
Change method to return LayoutUnit as it is computed from values with
subpixel precision.

(WebCore::RootInlineBox::lineSnapAdjustment):
Round values before computing remainder.

(WebCore::RootInlineBox::ascentAndDescentForBox):
Change ascent and decent calculation to use LayoutUnits as they are
computed from values with subpixel precision.

(WebCore::RootInlineBox::verticalPositionForBox):
Change verticalPosition to LayoutUnit.

rendering/RootInlineBox.h:

(RootInlineBox):

11:42 AM Changeset in webkit [113220] by Joseph Pecoraro

6 edits in trunk

<http://webkit.org/b/83108> Web Inspector: JSC Crash inspecting node with object event listener

Reviewed by Geoff Garen.

Source/WebCore:

bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):
Use jsDynamicCast to bail when the JSObject is not a JSFunction.

LayoutTests:

inspector/elements/event-listener-sidebar.html:
inspector/elements/event-listener-sidebar-expected.txt:
platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:

Add an EventListener that uses an object listener instead of a function.

11:18 AM Changeset in webkit [113219] by commit-queue@webkit.org

5 edits in trunk/Source

Call suddenTerminationChanged directly
https://bugs.webkit.org/show_bug.cgi?id=83114

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

platform/chromium/PlatformSupport.h:

(PlatformSupport):

platform/chromium/SuddenTerminationChromium.cpp:

(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

11:14 AM Changeset in webkit [113218] by abarth@webkit.org

8 edits in trunk/Source

figure out how to export webcore symbols from webkit.dll properly
https://bugs.webkit.org/show_bug.cgi?id=83105

Reviewed by Dimitri Glazkov.

Source/Platform:

Unwind our ugly, ugly hack to make the Windows component build work.

chromium/public/WebMediaStreamSourcesRequest.h:

(WebMediaStreamSourcesRequest):

Source/WebCore:

WebCore.gypi:
- Separate the platform support files into a new GYP variable so that they can be build as part of webkit.dll rather than in webcore_platform.lib. Building them as part of webkit.dll ensure that the symbols marked for export will actually be in webkit.dll (and hence exported), even if nothing else in webkit.dll references the obj file that contains the symbol.
platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
- Unwind our ugly, ugly hack to make the Windows component build work.

Source/WebKit/chromium:

WebKit.gyp:
- We now compile the platform support files as part of webkit.dll to make sure the lib contains the obj files and therefore exports the necessary symbols. In principle, we could use a defs file to achieve the same thing, but those files are a pain to maintain.
src/WebKit.cpp:

(WebKit::shutdown):

Unwind our ugly, ugly hack to make the Windows component build work.

11:12 AM Changeset in webkit [113217] by commit-queue@webkit.org

4 edits in trunk/Source

Call sandboxEnabled directly
https://bugs.webkit.org/show_bug.cgi?id=83113

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

11:07 AM Changeset in webkit [113216] by Patrick Gansterer

2 edits in trunk/Tools

[EFL][DRT] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=83168

Reviewed by Eric Seidel.

Modify the #include declarations so that the
wtf types are included using the full path.

DumpRenderTree/efl/DumpRenderTree.cpp:

11:07 AM Changeset in webkit [113215] by kareng@chromium.org

1 edit
2 copies in branches/chromium/1084

Merge 113139 - Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115

Reviewed by Adam Barth.

No new tests.

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

TBR=macpherson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9981010

10:50 AM Changeset in webkit [113214] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=83183

platform/chromium/test_expectations.txt: Registered flakes.

10:43 AM Changeset in webkit [113213] by caseq@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch IndexedDB, DOMStorage, ApplicationCache domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=83039

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-04
Reviewed by Pavel Feldman.

Client code is switched to typed API (all InspectorObject and InspectorArray types are
replaced with generated types from TypeBuilder according to Inspector.json).

Missing array of array specialization is added. Inspector.json is fixed to comform
with actual behavior of InspectorDOMStorageAgent.

Output parameter initialization is assured.

inspector/CodeGeneratorInspector.py:
inspector/Inspector.json:
inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):

inspector/InspectorApplicationCacheAgent.h:

(InspectorApplicationCacheAgent):

inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):

inspector/InspectorDOMStorageAgent.h:

(InspectorDOMStorageAgent):

inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::bind):

10:38 AM Changeset in webkit [113212] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Add another kind of flaky to fast/replaced/border-radius-clip.html

platform/chromium/test_expectations.txt: Flakes registered.

10:31 AM Changeset in webkit [113211] by fischman@chromium.org

3 edits in trunk/LayoutTests

Layout Test media/video-beforeload-remove-source.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=82260

Reviewed by Eric Carlson.

Moved the beforeload listener to <head> to ensure it is registered before the
load actually happens. Before this change, the test failed (timed out) 2/1000 runs,
after the change it had no failures in 5000 runs.

media/video-beforeload-remove-source.html:
platform/chromium/test_expectations.txt:

10:29 AM Changeset in webkit [113210] by Philippe Normand

2 edits in trunk/Tools

gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Reviewed by Tony Chang.

Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(test_get_crash_log): Skip the test on non-linux platforms.

10:17 AM Changeset in webkit [113209] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r113141): All tests assert on 32 bit debug mode
https://bugs.webkit.org/show_bug.cgi?id=83139

Reviewed by Sam Weinig.

heap/PassWeak.h:

(JSC::::get): 32-bit JSValue treats JSValue(nullptr).asCell() as an error,
so work around that here. (Long-term, we should make 32-bit and 64-bit
agree on the right behavior.)

10:13 AM Changeset in webkit [113208] by tony@chromium.org

17 edits
5 deletes in trunk

Remove flex function css parsing
https://bugs.webkit.org/show_bug.cgi?id=83083

Reviewed by Ojan Vafai.

Source/WebCore:

The flexbox spec switched from using a flex() function on the width
and height to a css property. Now that the -webkit-flex: has been
implemented, we can remove the flex() function code.

No new tests. Removing an old test that used to test the flex() function.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:
css/CSSFlexValue.cpp: Removed.
css/CSSFlexValue.h: Removed.
css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

css/CSSParser.h:

(WebCore):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:
rendering/style/RenderStyle.h:
rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Remove test of -webkit-flex() function.

css3/flexbox/flex-parsing-expected.txt: Removed.
css3/flexbox/flex-parsing.html: Removed.
css3/flexbox/script-tests/flex-parsing.js: Removed.

10:09 AM Changeset in webkit [113207] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/Skipped:
platform/gtk/test_expectations.txt:

10:06 AM Changeset in webkit [113206] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for fast/canvas/canvas-overloads-strokeText.html

platform/chromium/test_expectations.txt: Tweaked.

10:03 AM Changeset in webkit [113205] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Marked http/tests/websocket/tests/hybi/workers/worker-reload.html as flaky fail.
https://bugs.webkit.org/show_bug.cgi?id=83173

platform/chromium/test_expectations.txt: Added expectations.

10:03 AM Changeset in webkit [113204] by commit-queue@webkit.org

14 edits in trunk/Source

[Coverity] Address some uninit constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82424

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-04-04
Reviewed by Stephen White.

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

Source/WebCore:

Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::Gamepad):

accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):

dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

html/canvas/WebGLContextObject.h:

(WebGLContextObject):

platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:

(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

Source/WebKit/chromium:

src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):

src/LocalFileSystemChromium.cpp:

(WebCore):

Source/WTF:

wtf/ArrayBufferView.cpp:

(WTF::ArrayBufferView::ArrayBufferView):

9:59 AM Changeset in webkit [113203] by rwlbuis@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger
https://bugs.webkit.org/show_bug.cgi?id=83085

Reviewed by Antonio Gomes.

PR 121109

This way when we add something to the enum and forget to add to the switch we'll get a compile error.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):

9:38 AM Changeset in webkit [113202] by loislo@chromium.org

1 edit
3 moves in trunk/PerformanceTests

Web Inspector: Unreviewed. temporary disable broken inspector tests.

inspector/first-open-scripts.html.broken: Renamed from PerformanceTests/inspector/first-open-scripts.html.
inspector/network-append-30-requests.html.broken: Renamed from PerformanceTests/inspector/network-append-30-requests.html.
inspector/show-panel.html.broken: Renamed from PerformanceTests/inspector/show-panel.html.

9:31 AM Changeset in webkit [113201] by Dimitri Glazkov

2 edits in trunk/Source/WebKit/chromium

Unreviewed, temporary dirty hack to make Win Debug work again.

All.gyp: Temporarily removed TestWebKitAPI target.

9:16 AM Changeset in webkit [113200] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/test_expectations.txt:

9:10 AM Changeset in webkit [113199] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: expose savedURL, setToolbarColors and toggleSearchingForNode in InspectorFrontendAPI
https://bugs.webkit.org/show_bug.cgi?id=83170

Reviewed by Yury Semikhatsky.

Chromium port is calling these from the embedder layer and they all are perfect candidates
for the InspectorFrontendAPI. Adding them there.

inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):
(InspectorFrontendAPI.savedURL):
(InspectorFrontendAPI.setToolbarColors):

9:03 AM Changeset in webkit [113198] by rakuco@webkit.org

7 edits in trunk

[EFL] DRT support for computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=82190

Source/WebKit/efl:

Add missing implementation computedStyleIncludingVisitedInfo to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::computedStyleIncludingVisitedInfo):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
LayoutTestController so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip tests connected with computedStyleIncludingVisitedInfo().

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

platform/efl/Skipped:

9:01 AM Changeset in webkit [113197] by bbudge@chromium.org

1 edit in branches/chromium/1084/Source/WebKit/chromium/src/AssociatedURLLoader.cpp

Merge 112485 - AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9981003

8:54 AM Changeset in webkit [113196] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

A couple more cleanups to LayoutUnits in RenderInputSpeech::paintInputFieldSpeechButton.

8:52 AM Changeset in webkit [113195] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Entire page highlighted on panning.
https://bugs.webkit.org/show_bug.cgi?id=83158

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

8:49 AM Changeset in webkit [113194] by loislo@chromium.org

4 edits in trunk

Web Inspector: linearise aggregate's retaining size calculation.
https://bugs.webkit.org/show_bug.cgi?id=83125

This version is twice as fast as the original and it is non-recursive.

Reviewed by Yury Semikhatsky.

PerformanceTests:

inspector/detailed-heapshots-smoke-test.html:

Source/WebCore:

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._getDominatedIndex): was moved closer to it's usage
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize): it was _buildAggregates' inner function forDominatedNodes.
it was:
a) extracted from _buildAggregates;
b) made non-recursive;
c) many getters were inlined;
d) subarray of dominating nodes were inlined too.
(WebInspector.HeapSnapshot.prototype._buildAggregates): many getters were inlined.
(WebInspector.HeapSnapshot.prototype.aggregates):

8:42 AM Changeset in webkit [113193] by commit-queue@webkit.org

5 edits in trunk

Source/WebCore: Best clickable node might return non "clickable" node.
https://bugs.webkit.org/show_bug.cgi?id=83153

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Do not return non-clickable nodes as a best clickable node.

page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):

LayoutTests: Best clickable node might return non "clickable" node.
https://bugs.webkit.org/show_bug.cgi?id=83153

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

touchadjustment/touch-inlines-expected.txt:
touchadjustment/touch-inlines.html:

8:40 AM Changeset in webkit [113192] by pfeldman@chromium.org

22 edits in trunk

Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontendHost.save.
https://bugs.webkit.org/show_bug.cgi?id=83162

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change adds Save item into the context menus for inspector. It also makes
saveAs parameter optional in the InspectorFrontendHost.save so that we could
skip the dialog for the paths that were already saved. Embedder tells the front-end
what urls were successfully saved so that front-end could issue subsequent save commands
for those files.

English.lproj/localizedStrings.js:
inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSave):
(WebCore::InspectorFrontendClientLocal::save):

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSave):
(WebCore::InspectorFrontendHost::save):

inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:
inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.canSave):

inspector/front-end/JavaScriptSourceFrame.js:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

inspector/front-end/ResourceView.js:
inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.save):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):

inspector/front-end/Settings.js:
inspector/front-end/SourceFrame.js:

(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewer.prototype._commitEditing):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):

inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.saveToFile):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._contextMenu):

inspector/front-end/inspector.js:

Source/WebKit/chromium:

public/WebDevToolsFrontendClient.h:
src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canSave):
(WebKit::InspectorFrontendClientImpl::save):

src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

8:35 AM Changeset in webkit [113191] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

Cleaning up LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton. This method is only called from RenderTheme, so it arrives with an IntRect. We have to be careful to do proper pixel snapping within this method.

8:23 AM Changeset in webkit [113190] by caseq@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: time dividers are incorrectly rendered on empty timeline grid
https://bugs.webkit.org/show_bug.cgi?id=83165

Reviewed by Pavel Feldman.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkBaseCalculator.prototype.setDisplayWindow):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

8:15 AM Changeset in webkit [113189] by sergio@webkit.org

2 edits in trunk/Source/WebCore

[GTK] ASSERT in SocketStreamHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=83123

Reviewed by Martin Robinson.

Do not try to reuse a GOwnPtr as calling outPtr() causes an
assertion if the pointer is already valid. Also do not try to
close the IOStream if it was not created.

This patch fixes
http/tests/websocket/tests/hybi/workers/worker-reload.html but I
am leaving it skipped until webkit.org/b/83124 is fixed.

platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::connectedCallback):

8:05 AM Changeset in webkit [113188] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests to try to paint ARM and Mac bots green.

platform/qt-arm/Skipped:
platform/qt-mac/Skipped:

7:26 AM Changeset in webkit [113187] by alexis.menard@openbossa.org

7 edits in trunk/Source/WebCore

Re-add variable names in CSS related headers to help understanding the meaning of them.
https://bugs.webkit.org/show_bug.cgi?id=83151

Reviewed by Andreas Kling.

r112952, r113031, r113042 removed variable names in some places but at the end it
was better before as it helps understanding what the variables represent. This patch
address this issue and add back the names where it makes sense.

No new tests : cosmetic changes, no behavior change here.

css/CSSParser.h:

(CSSParser):

css/StylePropertySet.h:

(StylePropertySet):

dom/StyledElement.h:

(StyledElement):

editing/EditingStyle.h:

(EditingStyle):

editing/Editor.h:

(Editor):

html/HTMLElement.h:

(HTMLElement):

7:11 AM Changeset in webkit [113186] by rakuco@webkit.org

3 edits in trunk/Tools

Unreviewed; update my email address once again in the committers
and watch list.

Scripts/webkitpy/common/config/committers.py: Prefer my

webkit.org email over my FreeBSD.org one.

Scripts/webkitpy/common/config/watchlist: Ditto.

7:06 AM Changeset in webkit [113185] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

Unreviewed. Layout Test fast/canvas/canvas-toDataURL-webp.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=81735

Test expectations update. Fixed in http://crrev.com/129144.

platform/chromium/test_expectations.txt:

6:52 AM Changeset in webkit [113184] by Nikolas Zimmermann

33 edits in trunk

Implement animatedPathSegList support for SVGPathElement
https://bugs.webkit.org/show_bug.cgi?id=83140

Reviewed by Zoltan Herczeg.

Source/WebCore:

Add the last missing piece of animVal support: animations of the SVGPathElement's 'd' attribute
should be reflected in the 'animatedPathSegList' not the 'pathSegList'.

The SVGAnimatedPathAnimator is special as it doesn't operate on the SVGPathSegList types
directly, but on the SVGPathByteStreams for performance reasons. The SVGPathSegLists
are refcounted and exposed to JS, thus require lots of memory, compared to a simple
byte stream, which SVGPathByteStream is. Only build an 'animatedPathSegList' while
animating if its actually observed by the bindings, as this operation is heavy.

This marks the finish of the animVal patch series: no more string round trips during
animation. Previously paths were animated as byte streams, then converted to a String
passed to pathElement->setAttribute("d", "newString"), parsed again to a byte stream, etc.

A follow-up patch will remove the last crufts of direct setAttribute() animation.

Extend all existing animated SVGPathElement tests to cover animatedPathSegList.

svg/SVGAnimatedColor.h:

(WebCore::SVGAnimatedColorAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedColorAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedColorAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedColorAnimator::animValWillChange):
(WebCore::SVGAnimatedColorAnimator::animValDidChange):
(SVGAnimatedColorAnimator):

svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedPathAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPathAnimator::animValWillChange):
(WebCore::SVGAnimatedPathAnimator::animValDidChange):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

svg/SVGAnimatedPath.h:

(SVGAnimatedPathAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):

svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegList):
(WebCore::SVGPathElement::animatedPathSegList):
(WebCore::SVGPathElement::pathSegListChanged):

svg/SVGPathElement.h:

(WebCore):
(SVGPathElement):
(WebCore::SVGPathElement::isAnimValObserved):

svg/SVGPathParserFactory.cpp:

(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
(WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):

svg/SVGPathParserFactory.h:

(SVGPathParserFactory):

svg/SVGPathSegWithContext.h:
svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):

svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animatedPathByteStream):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

svg/properties/SVGAnimatedTransformListPropertyTearOff.h:

(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):

svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::SVGListProperty):
(WebCore::SVGListProperty::~SVGListProperty):
(SVGListProperty):

LayoutTests:

Update all tests animating the SVGPathElement's 'd' attribute to verify 'animatedPathSegList' now gets animated, not 'pathSegList'.

svg/animations/animate-path-animation-Cc-Ss-expected.txt:
svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
svg/animations/animate-path-animation-Qq-Tt-expected.txt:
svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt:
svg/animations/animate-path-to-animation-expected.txt:
svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):
(sample4):

svg/animations/script-tests/animate-path-to-animation.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):

svg/animations/script-tests/svgpath-animation-1.js:

(checkBaseVal):
(sample1):
(sample2):
(sample3):

svg/animations/script-tests/svgtransform-animation-1.js:
svg/animations/svgpath-animation-1-expected.txt:

6:35 AM Changeset in webkit [113183] by commit-queue@webkit.org

4 edits in trunk

[Qt][WK2] QtWebKit2 should support Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=81164

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Implementing the last bits needed for getting the expected
behavior for Page Visibility API, according to its spec.
The only missing part in Qt was a way to check whether
the view was exposed or not.

UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewVisible):

Tools:

Enabling Page Visiblity API for Qt WebKit2.

qmake/mkspecs/features/features.prf:

6:20 AM Changeset in webkit [113182] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/test_expectations.txt:

6:10 AM Changeset in webkit [113181] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit2

[WK2] Add Page Visibility API support
https://bugs.webkit.org/show_bug.cgi?id=81154

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Use WebPageProxy::viewStateDidChange to correctly define the page's
visibilityState and then set it to the WebProcess. The WebKit2's based
ports just need to implement the related PageClient functions in order
to get this API enabled and working properly.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::viewStateDidChange):

WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::setVisibilityState):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebPage/WebPage.messages.in:

6:04 AM Changeset in webkit [113180] by leviw@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Cleaning jp RenderView changes. Reverting the print rect to an IntRect, and cleaning up a FIXME with hardcoded offsets.

5:47 AM Changeset in webkit [113179] by commit-queue@webkit.org

3 edits
2 adds in trunk

Best zoomable area does not balance intersection with target area.
https://bugs.webkit.org/show_bug.cgi?id=83148

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Change the two step sort to simply picking the best quotient of touch intersection with target area.

Test: touchadjustment/zoom-fatfinger.html

page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::distanceSquaredToTargetCenterLine):
(TouchAdjustment):
(WebCore::TouchAdjustment::zoomableIntersectionQuotient):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
(WebCore::findBestClickableCandidate):
(WebCore::findBestZoomableArea):

LayoutTests:

touchadjustment/zoom-fatfinger-expected.txt: Added.
touchadjustment/zoom-fatfinger.html: Added.

5:43 AM Changeset in webkit [113178] by commit-queue@webkit.org

4 edits in trunk

[EFL][DRT] FrameloaderClientEfl needs to handle media content correctly
https://bugs.webkit.org/show_bug.cgi?id=83020

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-04
Reviewed by Hajime Morita.

Source/WebKit/efl:

Implementing handling of media content type and media documents
in the respective FrameLoaderClientEfl callbacks.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::committedLoad): Cancel loading for media documents.
(WebCore::FrameLoaderClientEfl::canShowMIMEType): Let media content types through.
(WebCore):
(WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError): Returning appropriate error type.
(WebCore::FrameLoaderClientEfl::shouldFallBack): Falling back as well for media handled by media player.

LayoutTests:

platform/efl/Skipped: Unskipping those MediaDocument related cases which now pass.

5:41 AM Changeset in webkit [113177] by caseq@chromium.org

8 edits in trunk

Web Inspector: make padding and client window width part of timeline calculator's state
https://bugs.webkit.org/show_bug.cgi?id=83122

Reviewed by Pavel Feldman.

Source/WebCore:

preserve window width and padding within TimelineCalculator
rely on calculator to add expansion arrow padding
add TimelineCalculator::computePosition() for computing single position (not entire bar dimensions)

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshDividers):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkBaseCalculator.prototype.computePosition):
(WebInspector.NetworkBaseCalculator.prototype.formatTime):
(WebInspector.NetworkBaseCalculator.prototype.setDisplayWindow):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.prototype.addEventDividers):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewCalculator.prototype.computePosition):
(WebInspector.TimelineOverviewCalculator.prototype.setDisplayWindow):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement.prototype._update):

LayoutTests:

re-enable 4 injspector tests skipped after previous landing attempt.

platform/gtk/Skipped:

5:34 AM Changeset in webkit [113176] by hans@chromium.org

2 edits in trunk/Source/WebKit/chromium

WebSpeechRecognizer.h: add missing forward declaration
https://bugs.webkit.org/show_bug.cgi?id=83150

Reviewed by Tony Gentilcore.

Add missing forward declaration of WebSpeechRecognitionParams.

public/WebSpeechRecognizer.h:

(WebKit):

5:32 AM Changeset in webkit [113175] by kenneth@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] Further improvements of the tap gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=83149

Reviewed by Zoltan Herczeg.

Ignore single tap while finger is still pressed.
Some renaming to make the states more clear.
A pan further than the maxPanDistance can now invalidate
double-taps as well.

UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

UIProcess/qt/QtTapGestureRecognizer.h:

5:31 AM Changeset in webkit [113174] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[FileSystem] Forward declare File in FileCallback.h
https://bugs.webkit.org/show_bug.cgi?id=83128

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

Modules/filesystem/FileCallback.h: forward declare File class to make

#include of "File.h" redundant.
(WebCore):

5:24 AM Changeset in webkit [113173] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.
https://bugs.webkit.org/show_bug.cgi?id=82438

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-04-04
Reviewed by Andreas Kling.

The purpose of ewk_settings_icon_database_icon_object_add is to get icon
for the given URL. This function doesn't add anything to database.
Documentation and API name are adjusted.

ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_object_get):

ewk/ewk_settings.h:

5:21 AM Changeset in webkit [113172] by abecsi@webkit.org

20 edits
2 deletes in trunk

[Qt][WK2] Make the WebView a subclass of Flickable
https://bugs.webkit.org/show_bug.cgi?id=83033

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Add needed dependency to quick-private for projects that include the WebView header.

declarative/experimental/experimental.pri:
declarative/public.pri:

Source/WebKit2:

Hitherto, the experiment of a QML WebView with an internal Flickable
instance showed that the approach of hiding the Flickable raises more
problems than it solves.

One set of problems arose because the internal Flickable was a separate
item which received and reacted on automatically synthesized mouse events
send by the canvas, this interfered with the gesture recognizers of the
WebView.

Other issues were related to orientation and the integration of the
WebView item with other QML items and components (like scroll indicators)
which require a larger set of the Flickable API or the Flickable object
itself (e.g. ScrollDecorator).

These disadvantages of an internal Flickable instance outweigh the
benefits of controlling the exposed API, therefore the experiment had
the conclusion that there is no way around the public inheritance from
QQuickFlickable.

This patch removes the QtFlickProvider class, inherits QQuickWebView
from QQuickFlickable and adjusts the viewport interaction engine and
the gesture recognizers to use the Flickable API of the WebView to
keep the same behaviour as before.

Target.pri:
UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::useDefaultContentItemSize):
(QQuickWebViewExperimental::setUseDefaultContentItemSize):
(QQuickWebView::QQuickWebView):
(QQuickWebView::inputMethodQuery):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):
(QQuickWebView::event):
(QQuickWebView::contentPos):
(QQuickWebView::setContentPos):
(QQuickWebView::handlePress):
(QQuickWebView::handleMove):
(QQuickWebView::handleRelease):

UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

UIProcess/API/qt/tests/tests.pri:
UIProcess/qt/QtFlickProvider.cpp: Removed.
UIProcess/qt/QtFlickProvider.h: Removed.
UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::flickableMoveStarted):
(WebKit::QtViewportInteractionEngine::flickableMoveEnded):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::scaleContent):

UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::doneWithTouchEvent):

Tools:

Remove workaround in MiniBrowser and the ScrollIndicator
now that the WebView is a Flickable.

MiniBrowser/qt/MiniBrowser.pro:
MiniBrowser/qt/qml/BrowserWindow.qml:
MiniBrowser/qt/qml/ScrollIndicator.qml:
WebKitTestRunner/Target.pri:

5:19 AM Changeset in webkit [113171] by Csaba Osztrogonác

2 edits in trunk/Tools

REGRESSION(r113144): It made run-webkit-tests always fail
https://bugs.webkit.org/show_bug.cgi?id=83142

Unreviewed trivial fix after r113144.

Scripts/run-webkit-tests:

5:01 AM Changeset in webkit [113170] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Unable to zoom to some areas.
https://bugs.webkit.org/show_bug.cgi?id=83144

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Remember to convert touch-area to touch-point radius.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

4:52 AM Changeset in webkit [113169] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Unreviewed, rolling out r113156.
http://trac.webkit.org/changeset/113156
https://bugs.webkit.org/show_bug.cgi?id=83146

Breaks inspector layout tests (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-04

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshDividers):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.prototype.addEventDividers):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._reset):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.get timelinePaddingLeft):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement.prototype._update):

4:37 AM Changeset in webkit [113168] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=83057
New test flakey on Qt Linux Release introduced in r113086

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-04

platform/qt/Skipped: fast/dom/inline-event-attributes-release.html

4:19 AM Changeset in webkit [113167] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: front-end should accept raw web socket address for the remote connection.
https://bugs.webkit.org/show_bug.cgi?id=83134

Reviewed by Yury Semikhatsky.

Migrated from the /devtools/page web socket schema to the generic one where remote target address
can be specified as index.html?ws=localhost:9222/page1. Left the old host/page way for backwards
compatibility.

inspector/front-end/inspector.js:

4:06 AM Changeset in webkit [113166] by tkent@chromium.org

3 edits
2 adds in trunk/Source/WebCore

Add localization functions for the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=83129

Reviewed by Hajime Morita.

No behavior changes yet.

WebCore.gypi: Add LocalizedCalendar.h and LocalizedCalendarICU.cpp.
platform/LocalizedStrings.h: Add calendarTodayText() and calendarClearText().
platform/text/LocalizedCalendar.h:

Added. This provides monthLabels(), weekDayShortLabels(), and firstDayOfWeek().

platform/text/LocalizedCalendarICU.cpp: Added. ICU implementations of the above functions.

(WebCore::ScopedDateFormat): A wrapper for UDateFormat*.
(WebCore::ScopedDateFormat::ScopedDateFormat):
(WebCore::ScopedDateFormat::~ScopedDateFormat):
(WebCore::ScopedDateFormat::get):
(createFallbackMonthLabels): Creates fallback month labels in English.
(createLabelVector):
A helper for createMonthLabels() and createWeekDayShortLabels().
(createMonthLabels):
Creates month labels using createLabelVector() or createFallbackMonthLabels().
(WebCore::monthLabels):
(createFallbackWeekDayShortLabels): Creates fallback week labels in English.
(createWeekDayShortLabels):
Creates month labels using createLabelVector() or createFallbackWeekDayShortLabels().
(WebCore::weekDayShortLabels):
(getFirstDayOfWeek):
(WebCore::firstDayOfWeek):

4:00 AM Changeset in webkit [113165] by kenneth@webkit.org

3 edits in trunk/Source/WebKit2

[Qt] Improve the tap gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=83135

Reviewed by Simon Hausmann.

Clean up the code and make sure that the first single tap
event, as part of a double tap gesture, is ignored.

UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

3:56 AM Changeset in webkit [113164] by hans@chromium.org

11 edits
7 copies
4 adds in trunk/Source

Speech JavaScript API: Plumbing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=81667

Reviewed by Darin Fisher.

Source/WebCore:

SpeechGrammar::src() is called with a ScriptExecutionContext, because
the attribute setter needs it. Provide a src() method that doesn't
take a ScriptExecutionContext that can be used internally.

Rename SpeechRecognition::audioStartCallback(), etc. to use event style
names, i.e. didStartAudio(), etc.

Remove SpeechRecognitionClient::notifyVisibilityHidden(). The embedder
can keep track of the visibility.

Remove SpeechRecognitionClient::unregisterSpeechRecognition,
it is not needed.

No new tests, just minor tweaks.

Modules/speech/SpeechGrammar.h:

(WebCore::SpeechGrammar::src):

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::didStartAudio):
(WebCore::SpeechRecognition::didStartSound):
(WebCore::SpeechRecognition::didStartSpeech):
(WebCore::SpeechRecognition::didEndSpeech):
(WebCore::SpeechRecognition::didEndSound):
(WebCore):
(WebCore::SpeechRecognition::didEndAudio):
(WebCore::SpeechRecognition::didReceiveResult):
(WebCore::SpeechRecognition::didReceiveNoMatch):
(WebCore::SpeechRecognition::didDeleteResult):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didStart):
(WebCore::SpeechRecognition::didEnd):

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

Modules/speech/SpeechRecognitionController.h:

Source/WebKit/chromium:

Add plumbing for speech recognition.

The implementer is expected to implement the WebSpeechRecognizer interface.
The start(), stop(), and abort() functions of that interface take a
WebSpeechRecognitionHandle argument, which identifies the object which has
requested the action, and a pointer to a WebSpeechRecognitionClient interface,
through which it should send back notifications on progress, errors, etc.

SpeechRecognitionClientProxy passes data between the WebCore and WebKit layers,
implementing the WebCore::SpeechRecognitionClient and WebKit::WebSpeechRecognizerClient
interfaces.

WebKit.gyp:
public/WebSpeechGrammar.h:

(WebCore):
(WebKit):
(WebSpeechGrammar):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::~WebSpeechGrammar):

public/WebSpeechRecognitionHandle.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::~WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::operator=):
(WebKit::operator==):
(WebKit::operator!=):
(WebKit::operator<):

public/WebSpeechRecognitionParams.h:

(WebKit):
(WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::grammars):
(WebKit::WebSpeechRecognitionParams::language):
(WebKit::WebSpeechRecognitionParams::continuous):

public/WebSpeechRecognitionResult.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::~WebSpeechRecognitionResult):

public/WebSpeechRecognizer.h:

(WebKit):
(WebSpeechRecognizer):
(WebKit::WebSpeechRecognizer::start):
(WebKit::WebSpeechRecognizer::stop):
(WebKit::WebSpeechRecognizer::abort):
(WebKit::WebSpeechRecognizer::~WebSpeechRecognizer):

public/WebSpeechRecognizerClient.h: Added.

(WebKit):
(WebSpeechRecognizerClient):

public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::speechRecognizer):

src/SpeechRecognitionClientProxy.cpp: Added.

(WebKit):
(WebKit::SpeechRecognitionClientProxy::~SpeechRecognitionClientProxy):
(WebKit::SpeechRecognitionClientProxy::create):
(WebKit::SpeechRecognitionClientProxy::start):
(WebKit::SpeechRecognitionClientProxy::stop):
(WebKit::SpeechRecognitionClientProxy::abort):
(WebKit::SpeechRecognitionClientProxy::didStartAudio):
(WebKit::SpeechRecognitionClientProxy::didStartSound):
(WebKit::SpeechRecognitionClientProxy::didStartSpeech):
(WebKit::SpeechRecognitionClientProxy::didEndSpeech):
(WebKit::SpeechRecognitionClientProxy::didEndSound):
(WebKit::SpeechRecognitionClientProxy::didEndAudio):
(WebKit::SpeechRecognitionClientProxy::didReceiveResult):
(WebKit::SpeechRecognitionClientProxy::didReceiveNoMatch):
(WebKit::SpeechRecognitionClientProxy::didDeleteResult):
(WebKit::SpeechRecognitionClientProxy::didReceiveError):
(WebKit::SpeechRecognitionClientProxy::didStart):
(WebKit::SpeechRecognitionClientProxy::didEnd):
(WebKit::SpeechRecognitionClientProxy::SpeechRecognitionClientProxy):

src/SpeechRecognitionClientProxy.h: Added.

(WebKit):
(SpeechRecognitionClientProxy):

src/WebSpeechGrammar.cpp: Added.

(WebKit):
(WebKit::WebSpeechGrammar::reset):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::operator=):
(WebKit::WebSpeechGrammar::src):
(WebKit::WebSpeechGrammar::weight):

src/WebSpeechRecognitionHandle.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionHandle::reset):
(WebKit::WebSpeechRecognitionHandle::assign):
(WebKit::WebSpeechRecognitionHandle::equals):
(WebKit::WebSpeechRecognitionHandle::lessThan):
(WebKit::WebSpeechRecognitionHandle::WebSpeechRecognitionHandle):
(WebKit::WebSpeechRecognitionHandle::operator=):
(WebKit::WebSpeechRecognitionHandle::operator PassRefPtr<SpeechRecognition>):

src/WebSpeechRecognitionParams.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):

src/WebSpeechRecognitionResult.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionResult::assign):
(WebKit::WebSpeechRecognitionResult::reset):
(WebKit::WebSpeechRecognitionResult::operator PassRefPtr<WebCore::SpeechRecognitionResult>):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

src/WebViewImpl.h:

(WebKit):

3:47 AM Changeset in webkit [113163] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/test_expectations.txt:

3:37 AM Changeset in webkit [113162] by leviw@chromium.org

3 edits in trunk/Source/WebCore

Switch baseline values to LayoutUnits in RenderTableSection.
https://bugs.webkit.org/show_bug.cgi?id=83017

Reviewed by Julien Chaffraix.

We initially intend to keep table layout on integers post switching the render tree to primarily
use sub-pixel precision. Baseline positions switch to sub-pixel units, and in table layout code are
combined with padding (also sub-pixel), which means we ideally won't truncate their values until
after they're added together. Converting baseline values in RenderTableSection to LayoutUnits.

No new tests. No change in behavior.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

rendering/RenderTableSection.h:

(RowStruct):

3:29 AM Changeset in webkit [113161] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK] Scrolling doesn't work in WebKit2 since r110185
https://bugs.webkit.org/show_bug.cgi?id=81779

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-04
Reviewed by James Robinson.

Bring back functionality of the ScrollAnimatorNone for ports that
use a fallback timer for animation frames.

No new tests - only restoring previous functionality.

platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::startNextTimer):
(WebCore::ScrollAnimatorNone::animationTimerActive):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

3:27 AM Changeset in webkit [113160] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/Skipped:
platform/gtk/test_expectations.txt:

3:26 AM Changeset in webkit [113159] by leviw@chromium.org

4 edits in branches/subpixellayout/Source/WebCore

Coalesce extra pixel snapping in getRoundedBorderFor into a local variable, remove LayoutUnit flavors of adjustForAsboluteZoom, and use pixel snapped values throughout Element's DOM accessors.

3:13 AM Changeset in webkit [113158] by Csaba Osztrogonác

2 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a new _crashing_ test and unskip a non-existing test.

platform/qt/Skipped:
platform/qt/fast/forms/label/labelable-elements-expected.txt: Added after r113148 and r113137.

2:36 AM Changeset in webkit [113157] by yurys@chromium.org

10 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch Inspector, Memory and Database domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=82958

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-02
Reviewed by Yury Semikhatsky.

Client code is switched to typed API (all InspectorObject and InspectorArray types are replaced with
generated types from TypeBuilder according to Inspector.json).

Missing array of InspectorValues specialization is added.

inspector/CodeGeneratorInspector.py:
inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::inspectImpl):

inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::inspect):

inspector/InspectorAgent.h:

(InspectorAgent):

inspector/InspectorDatabaseAgent.cpp:

(WebCore):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

inspector/InspectorDatabaseAgent.h:

(InspectorDatabaseAgent):

inspector/InspectorDatabaseResource.cpp:

(WebCore::InspectorDatabaseResource::bind):

inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMNodeCount):

inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

2:27 AM Changeset in webkit [113156] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: make padding and client window width part of timeline calculator's state
https://bugs.webkit.org/show_bug.cgi?id=83122

Reviewed by Pavel Feldman.

preserve window width and padding within TimelineCalculator
rely on calculator to add expansion arrow padding
add TimelineCalculator::computePosition() for computing single position (not entire bar dimensions)

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshDividers):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

inspector/front-end/TimelineOverviewPane.js:

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelineExpandableElement.prototype._update):

2:18 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Add ShowModalDialog (diff)

2:15 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Add console message (diff)

2:13 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Add Cookies (diff)

2:12 AM Changeset in webkit [113155] by Philippe Normand

1 edit
1 add in trunk/LayoutTests

Unreviewed, GTK baseline for test added in r112816.

platform/gtk/fast/text/international/text-spliced-font-expected.txt: Added.

2:10 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

2:09 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Add target version coloumn (diff)

2:05 AM Changeset in webkit [113154] by pfeldman@chromium.org

21 edits in branches/chromium/1084/Source/WebCore/inspector/front-end

Merge 112992 - Web Inspector: "Pause on start" doesn't change checked state in workers panel
https://bugs.webkit.org/show_bug.cgi?id=82908

Reviewed by Yury Semikhatsky.

This change partially reverts logic that was introduced with r111551:
preventDefault was called beside each stopPropagation. As a result, default checkbox handler was not working.
Event.prototype.consume now receives preventDefault parameter that controls whether default action
should be prevented.

inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype._onKeyDown):

inspector/front-end/CSSSelectorProfileView.js:
inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._enterKeyPressed):
(WebInspector.ConsoleGroup.prototype._titleClicked):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):

inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):

inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):

inspector/front-end/Dialog.js:

(WebInspector.Dialog.prototype._onKeyDown):

inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype._statusBarDragging):

inspector/front-end/Object.js:

(WebInspector.Event.prototype.consume):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):

inspector/front-end/ProfileView.js:
inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype._onKeyDown):

inspector/front-end/SoftContextMenu.js:

(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._discardMenu):

inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.draggable.consume):
(WebInspector.Spectrum.prototype._onKeyDown):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.muteEventListener):
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElement.prototype):

inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._handleKeyDown):

inspector/front-end/UIUtils.js:

(WebInspector.startEditing):

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype._searchInputKeyDown):
(TreeElement.prototype.selectOnMouseDown):

inspector/front-end/utilities.js:

(Event.prototype.consume):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9968120

2:01 AM Changeset in webkit [113153] by commit-queue@webkit.org

11 edits
11 deletes in trunk/Source

Unreviewed, rolling out r113149.
http://trac.webkit.org/changeset/113149
https://bugs.webkit.org/show_bug.cgi?id=83126

for breaking Chromium builders (Requested by pfeldman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-04

Source/WebCore:

Modules/speech/SpeechGrammar.h:
Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::audioStartCallback):
(WebCore::SpeechRecognition::soundStartCallback):
(WebCore::SpeechRecognition::speechStartCallback):
(WebCore::SpeechRecognition::speechEndCallback):
(WebCore::SpeechRecognition::audioEndCallback):
(WebCore::SpeechRecognition::resultCallback):
(WebCore::SpeechRecognition::noMatchCallback):
(WebCore::SpeechRecognition::resultDeletedCallback):
(WebCore::SpeechRecognition::errorCallback):
(WebCore::SpeechRecognition::startCallback):
(WebCore::SpeechRecognition::endCallback):

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

Modules/speech/SpeechRecognitionController.h:

(WebCore::SpeechRecognitionController::visibilityHidden):
(WebCore::SpeechRecognitionController::unregisterSpeechRecognition):

Source/WebKit/chromium:

WebKit.gyp:
public/WebSpeechGrammar.h: Removed.
public/WebSpeechRecognitionHandle.h: Removed.
public/WebSpeechRecognitionParams.h: Removed.
public/WebSpeechRecognitionResult.h: Removed.
public/WebSpeechRecognizer.h: Removed.
public/WebSpeechRecognizerClient.h: Removed.
public/WebViewClient.h:

(WebKit):

src/SpeechRecognitionClientProxy.cpp: Removed.
src/SpeechRecognitionClientProxy.h: Removed.
src/WebSpeechGrammar.cpp: Removed.
src/WebSpeechRecognitionHandle.cpp: Removed.
src/WebSpeechRecognitionResult.cpp: Removed.
src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

src/WebViewImpl.h:

(WebKit):

1:56 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Update (diff)

1:52 AM Changeset in webkit [113152] by pfeldman@chromium.org

1 edit
15 adds in trunk/LayoutTests

Not reviewed: expectations updated for chromium.

platform/chromium-linux/fast/forms/datalist/input-list-expected.png: Added.
platform/chromium-linux/fast/forms/datalist/input-selectedoption-expected.png: Added.
platform/chromium-mac-leopard/fast/forms/datalist/input-selectedoption-expected.png: Added.
platform/chromium-mac/fast/forms/datalist/input-list-expected.png: Added.
platform/chromium-mac/fast/forms/datalist/input-list-expected.txt: Added.
platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.png: Added.
platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.txt: Added.
platform/chromium-win/fast/forms/datalist/input-list-expected.png: Added.
platform/chromium-win/fast/forms/datalist/input-list-expected.txt: Added.
platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.png: Added.
platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.txt: Added.

1:47 AM Changeset in webkit [113151] by caseq@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: event marks are missing in the timeline overview
https://bugs.webkit.org/show_bug.cgi?id=83043

Reviewed by Pavel Feldman.

invoke overview event dividers update as part of overview update, not lower pane update;
store raw records for event dividers within overview;
moved createEventDividers to a class method of TimelinePresentationModel for reuse.
ditto for forAllRecords

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype._updateEventDividers):
(WebInspector.TimelineOverviewPane.prototype._onRecordAdded):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.HeapGraph.prototype.update):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.isEventDivider):
(WebInspector.TimelinePresentationModel.forAllRecords):
(WebInspector.TimelinePresentationModel.createEventDivider):

1:39 AM Changeset in webkit [113150] by yutak@chromium.org

3 edits in trunk/LayoutTests

Unreviewed, update platform test expectations for worker-reload.html.

platform/gtk/test_expectations.txt:
platform/mac/test_expectations.txt:

1:34 AM Changeset in webkit [113149] by hans@chromium.org

11 edits
7 copies
4 adds in trunk/Source

Speech JavaScript API: Plumbing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=81667

Reviewed by Darin Fisher.

Source/WebCore:

SpeechGrammar::src() is called with a ScriptExecutionContext, because
the attribute setter needs it. Provide a src() method that doesn't
take a ScriptExecutionContext that can be used internally.

Rename SpeechRecognition::audioStartCallback(), etc. to use event style
names, i.e. didStartAudio(), etc.

Remove SpeechRecognitionClient::notifyVisibilityHidden(). The embedder
can keep track of the visibility.

Remove SpeechRecognitionClient::unregisterSpeechRecognition,
it is not needed.

No new tests, just minor tweaks.

Modules/speech/SpeechGrammar.h:

(WebCore::SpeechGrammar::src):

Modules/speech/SpeechRecognition.cpp:

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognitionClient.h:

(SpeechRecognitionClient):

Modules/speech/SpeechRecognitionController.h:

Source/WebKit/chromium:

Add plumbing for speech recognition.

SpeechRecognitionClientProxy passes data between the WebCore and WebKit layers,
implementing the WebCore::SpeechRecognitionClient and WebKit::WebSpeechRecognizerClient
interfaces.

WebKit.gyp:
public/WebSpeechGrammar.h:

(WebCore):
(WebKit):
(WebSpeechGrammar):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::~WebSpeechGrammar):

public/WebSpeechRecognitionHandle.h: Added.

public/WebSpeechRecognitionParams.h:

(WebKit):
(WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::grammars):
(WebKit::WebSpeechRecognitionParams::language):
(WebKit::WebSpeechRecognitionParams::continuous):

public/WebSpeechRecognitionResult.h: Added.

(WebCore):
(WebKit):
(WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebKit::WebSpeechRecognitionResult::~WebSpeechRecognitionResult):

public/WebSpeechRecognizer.h:

(WebKit):
(WebSpeechRecognizer):
(WebKit::WebSpeechRecognizer::start):
(WebKit::WebSpeechRecognizer::stop):
(WebKit::WebSpeechRecognizer::abort):
(WebKit::WebSpeechRecognizer::~WebSpeechRecognizer):

public/WebSpeechRecognizerClient.h: Added.

(WebKit):
(WebSpeechRecognizerClient):

public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::speechRecognizer):

src/SpeechRecognitionClientProxy.cpp: Added.

src/SpeechRecognitionClientProxy.h: Added.

(WebKit):
(SpeechRecognitionClientProxy):

src/WebSpeechGrammar.cpp: Added.

(WebKit):
(WebKit::WebSpeechGrammar::reset):
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebKit::WebSpeechGrammar::operator=):
(WebKit::WebSpeechGrammar::src):
(WebKit::WebSpeechGrammar::weight):

src/WebSpeechRecognitionHandle.cpp: Added.

src/WebSpeechRecognitionParams.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):

src/WebSpeechRecognitionResult.cpp: Added.

(WebKit):
(WebKit::WebSpeechRecognitionResult::assign):
(WebKit::WebSpeechRecognitionResult::reset):
(WebKit::WebSpeechRecognitionResult::operator PassRefPtr<WebCore::SpeechRecognitionResult>):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

src/WebViewImpl.h:

(WebKit):

1:03 AM Changeset in webkit [113148] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, rebaseline after r113137 and skip some more flaky
inspector tests on GTK.

fast/forms/label/labelable-elements-expected.txt:
platform/gtk/test_expectations.txt:

12:37 AM WebKit Team edited by sergio@webkit.org

(diff)

12:30 AM Changeset in webkit [113147] by commit-queue@webkit.org

18 edits in trunk/Source

Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=82342

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-04
Reviewed by Andreas Kling.

Fixes build break in WebKit-Gtk, and WebKit-EFL ports when CONTEXT_MENUS macro is disabled.

Source/WebCore:

page/ContextMenuClient.h:
page/ContextMenuController.h:
page/Page.cpp:

(WebCore::Page::PageClients::PageClients):

page/Page.h:

(WebCore):
(PageClients):

platform/ContextMenu.cpp:
platform/ContextMenu.h:
platform/ContextMenuItem.cpp:
platform/ContextMenuItem.h:
platform/efl/ContextMenuEfl.cpp:
platform/efl/ContextMenuItemEfl.cpp:
platform/gtk/ContextMenuGtk.cpp:
platform/gtk/ContextMenuItemGtk.cpp:

Source/WebKit/gtk:

WebCoreSupport/ContextMenuClientGtk.cpp:
WebCoreSupport/ContextMenuClientGtk.h:
webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action):

webkit/webkitwebview.cpp:

(webkit_web_view_button_press_event):
(webkit_web_view_class_init):
(webkit_web_view_init):

12:17 AM Changeset in webkit [113146] by ggaren@apple.com

2 edits in trunk/Source/WebKit2

Fixed some WebKit2 crashes seen on the buildbot after my last patch.

Reviewed by Beth Dakin.

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize): Don't try to get our value
out of the map, since Weak<T> returns NULL during finalization. Instead,
use the handle we've been passed for finalization.

12:11 AM Changeset in webkit [113145] by abarth@webkit.org

1 edit
1 copy
1 add in trunk/LayoutTests

The baseline for this test is V8-specific. This patch moves the
baseline to the chromium directory and places the JSC result in the
cross-platform directory.

http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Replaced.
platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Copied from LayoutTests/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt.

Apr 3, 2012:

11:24 PM Changeset in webkit [113144] by rniwa@webkit.org

2 edits in trunk/Tools

I really hope this is the last build fix. Apparently exec doesn't quite arguments with
double quotations on Windows. Use system instead.

Hopefully, this won't break anything.

Scripts/run-webkit-tests:

10:54 PM Changeset in webkit [113143] by abarth@webkit.org

11 edits
28 adds in trunk

Implement <iframe srcdoc>
https://bugs.webkit.org/show_bug.cgi?id=82991

Reviewed by Sam Weinig.

Source/WebCore:

This patch implements the <iframe srcdoc> feature. This feature allows
authors to easily supply the contents of an iframe without needing to
round-trip to the server. Using srcdoc is more convenient than using
data URLs because we set a bunch of properties of the child document
sensibly. For example, the child inherits the base URL of the parent
and the child uses standards mode by default.

This feature is specified in
<http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-srcdoc>.
Although the feature has been in the spec for a while, I'm not aware of
any other implementations in major browsers. The srcdoc feature works
especially well with the sandbox and seamless attributes. We already
implement sandbox and will likely implement seamless soon.

The srcdoc feature was announced on the webkit-dev mailing list on March 30:
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020161.html

This patch approaches the implementation using SubstituteData, which is
a mechanism previously used for error messages and the like. Using
SubstituteData has the advantage of not needing to modify the loading
or history pipelines at all, making the integration of srcdoc with the
rest of WebCore quite smooth.

This patch encodes the contents of the srcdoc attribute to and from
UTF-8 when round-tripping the contents through the loader. In a future
patch, I plan to experiment with whether using UTF-16 (or perhaps
another encoding) can improve performance. There might also be a way to
avoid the memcpy entirely, but these optimizations are best left to
followup patches as this patch focuses on the observable behavior of
the feature.

Tests: fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html

fast/frames/srcdoc/setting-src-does-nothing.html
fast/frames/srcdoc/setting-srcdoc-reloads-document.html
fast/frames/srcdoc/srcdoc-beats-src-dom.html
fast/frames/srcdoc/srcdoc-beats-src.html
fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html
fast/frames/srcdoc/srcdoc-can-navigate.html
fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html
fast/frames/srcdoc/srcdoc-loads-content.html
fast/frames/srcdoc/srcdoc-urls.html
http/tests/security/srcdoc-can-access-parent.html
http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html
http/tests/security/srcdoc-inherits-referrer-for-forms.html
http/tests/security/srcdoc-inherits-referrer.html

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::initSecurityContext):

srcdoc documents need to inherit their security contexts from their parents. We pick this initialization point to inherit the base URL and to set the "srcdoc Document" bit so that everything gets initialized atomically and from precisely the same owner frame.

dom/Document.h:

(Document):
(WebCore::Document::isSrcdocDocument):

This bit of state is present in the HTML5 spec and is referred to by a number of different requirements in the spec.

html/HTMLAttributeNames.in:
html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::location):

These functions implement the requirement that the srcdoc attribute takes precedence over the src attribute and triggers a load of a document with the URL about:srcdoc.

html/HTMLIFrameElement.idl:
- Expose the srcdoc property as a reflection of the DOM attribute.
html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::defaultForInitial):

This tweak allows srcdoc documents to use standards mode by default, saving authors from having to include a doctype in each srcdoc document.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL):

This function transfers the contents of the srcdoc attribute into the loading pipeline. If the client supplies other SubstituteData, that takes precendence over our "default" SubstituteData.

(WebCore::FrameLoader::outgoingReferrer):

This function implements the requirement from the HTML5 spec that srcdoc documents inherit their referrer from their parent document. A recursive implementation might have been more aesthetic but the iterative implementation seemed like a better choice.

(WebCore::FrameLoader::shouldTreatURLAsSrcdocDocument):

An about:srcdoc URL only has special meaning when loaded in an iframe with a srcdoc attribute. Otherwise, it's just a normal "about" URL, meaning a blank page.

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadResourceSynchronously):

Update these call sites to call defaultSubstituteDataForURL and outgoingReferrer consistently.

loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

Add a number of tests for <iframe srcdoc>. These tests cover all the
requirements I could find in the HTML5 specification by grepping for
the term "srcdoc".

fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again-expected.txt: Added.
fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html: Added.
fast/frames/srcdoc/setting-src-does-nothing-expected.txt: Added.
fast/frames/srcdoc/setting-src-does-nothing.html: Added.
fast/frames/srcdoc/setting-srcdoc-reloads-document-expected.txt: Added.
fast/frames/srcdoc/setting-srcdoc-reloads-document.html: Added.
fast/frames/srcdoc/srcdoc-beats-src-dom-expected.txt: Added.
fast/frames/srcdoc/srcdoc-beats-src-dom.html: Added.
fast/frames/srcdoc/srcdoc-beats-src-expected.txt: Added.
fast/frames/srcdoc/srcdoc-beats-src.html: Added.
fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: Added.
fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html: Added.
fast/frames/srcdoc/srcdoc-can-navigate-expected.txt: Added.
fast/frames/srcdoc/srcdoc-can-navigate.html: Added.
fast/frames/srcdoc/srcdoc-defaults-to-standards-mode-expected.txt: Added.
fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html: Added.
fast/frames/srcdoc/srcdoc-loads-content-expected.txt: Added.
fast/frames/srcdoc/srcdoc-loads-content.html: Added.
fast/frames/srcdoc/srcdoc-urls-expected.txt: Added.
fast/frames/srcdoc/srcdoc-urls.html: Added.
http/tests/security/srcdoc-can-access-parent-expected.txt: Added.
http/tests/security/srcdoc-can-access-parent.html: Added.
http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Added.
http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html: Added.
http/tests/security/srcdoc-inherits-referrer-expected.txt: Added.
http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt: Added.
http/tests/security/srcdoc-inherits-referrer-for-forms.html: Added.
http/tests/security/srcdoc-inherits-referrer.html: Added.

10:37 PM Changeset in webkit [113142] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Updated JSC expected test results to reflect recent bug fixes <disapproving look>.

Reviewed by Sam Weinig.

tests/mozilla/expected.html:

10:28 PM Changeset in webkit [113141] by ggaren@apple.com

35 edits
7 adds in trunk/Source

First step toward incremental Weak<T> finalization
https://bugs.webkit.org/show_bug.cgi?id=82670

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch implements a Weak<T> heap that is compatible with incremental
finalization, while making as few behavior changes as possible. The behavior
changes it makes are:

(*) Weak<T>'s raw JSValue no longer reverts to JSValue() automatically --
instead, a separate flag indicates that the JSValue is no longer valid.
(This is required so that the JSValue can be preserved for later finalization.)
Objects dealing with WeakImpls directly must change to check the flag.

(*) Weak<T> is no longer a subclass of Handle<T>.

(*) DOM GC performance is different -- 9% faster in the geometric mean,
but 15% slower in one specific case:

gc-dom1.html: 6% faster
gc-dom2.html: 23% faster
gc-dom3.html: 17% faster
gc-dom4.html: 15% *slower*

The key features of this new heap are:

(*) Each block knows its own state, independent of any other blocks.

(*) Each block caches its own sweep result.

(*) The heap visits dead Weak<T>s at the end of GC. (It doesn't
mark them yet, since that would be a behavior change.)

API/JSCallbackObject.cpp:

(JSC::JSCallbackObjectData::finalize):

API/JSCallbackObjectFunctions.h:

(JSC::::init): Updated to use the new WeakHeap API.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri: Paid the build system tax since I added some new files.

heap/Handle.h: Made WeakBlock a friend and exposed slot() as public,

so we can keep passing a Handle<T> to finalizers, to avoid more surface
area change in this patch. A follow-up patch should change the type we
pass to finalizers.

heap/HandleHeap.cpp:

(JSC):
(JSC::HandleHeap::writeBarrier):
(JSC::HandleHeap::isLiveNode):

heap/HandleHeap.h:

(JSC):
(HandleHeap):
(Node):
(JSC::HandleHeap::Node::Node): Removed all code related to Weak<T>, since
we have a separate WeakHeap now.

heap/Heap.cpp:

(JSC::Heap::Heap): Removed m_extraCost because extra cost is accounted
for through our watermark now. Removed m_waterMark because it was unused.

(JSC::Heap::destroy): Updated for addition of WeakHeap.

(JSC::Heap::reportExtraMemoryCostSlowCase): Changed from using its own
variable to participating in the watermark strategy. I wanted to standardize
WeakHeap and all other Heap clients on this strategy, to make sure it's
accurate.

(JSC::Heap::markRoots): Updated for addition of WeakHeap. Added WeakHeap
dead visit pass, as explained above.

(JSC::Heap::collect):
(JSC::Heap::resetAllocators): Updated for addition of WeakHeap.

(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize): Updated for new Weak<T> API.

heap/Heap.h:

(JSC::Heap::weakHeap):
(Heap):
(JSC::Heap::addToWaterMark): Added a way to participate in the watermarking
strategy, since this is the best way for WeakHeap to report its memory
cost. (I plan to update this in a follow-up patch to make it more accurate,
but for now it is not less accurate than it used to be.)

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):

heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::addToWaterMark):
(JSC::MarkedSpace::didConsumeFreeList): Removed m_nurseryWaterMark because
it was unused, and I didn't want to update WeakHeap to keep an usused
variable working. Added API for above.

heap/PassWeak.h:

(JSC):
(WeakImplAccessor):
(PassWeak):
(JSC::::operator):
(JSC::::get):
(JSC::::was):
(JSC::::PassWeak):
(JSC::::~PassWeak):
(JSC::UnspecifiedBoolType):
(JSC::::leakImpl):
(JSC::adoptWeak):

heap/Strong.h:

(JSC::Strong::operator!):
(Strong):
(JSC::Strong::operator UnspecifiedBoolType*):
(JSC::Strong::get):

heap/Weak.h:

(Weak):
(JSC::::Weak):
(JSC):
(JSC::::isHashTableDeletedValue):
(JSC::::~Weak):
(JSC::::swap):
(JSC::=):
(JSC::::operator):
(JSC::UnspecifiedBoolType):
(JSC::::release):
(JSC::::clear):
(JSC::::hashTableDeletedValue): Lots of code changes here, but they boil
down to two things:

(*) Allocate WeakImpls from the WeakHeap instead of Handles from the HandleHeap.

(*) Explicitly check WeakImpl::state() for non-liveness before returning
a value (explained above).

These files implement the new Weak<T> heap behavior described above:

heap/WeakBlock.cpp: Added.
heap/WeakBlock.h: Added.
heap/WeakHandleOwner.cpp: Added.
heap/WeakHandleOwner.h: Added.
heap/WeakHeap.cpp: Added.
heap/WeakHeap.h: Added.
heap/WeakImpl.h: Added.

One interesting difference from the old heap is that we don't allow
clients to overwrite a WeakImpl after allocating it, and we don't recycle
WeakImpls prior to garbage collection. This is required for lazy finalization,
but it will also help us esablish a useful invariant in the future: allocating
a WeakImpl will be a binding contract to run a finalizer at some point in the
future, even if the WeakImpl is later deallocated.

jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub): Check the Weak<T> for ! instead of
its JSValue, since that's our API contract now, and the JSValue might
be stale.

runtime/JSCell.h:

(JSC::jsCast): Allow casting NULL pointers because it's useful and harmless.

runtime/Structure.cpp:

(JSC::StructureTransitionTable::add): I can't remember why I did this.

runtime/StructureTransitionTable.h:
runtime/WeakGCMap.h: I had to update these classes because they allocate

and deallocate weak pointers manually. They should probably stop doing that.

Source/WebCore:

Updated WebCore for Weak<T> API changes.

bindings/js/DOMWrapperWorld.cpp:

(WebCore::JSStringOwner::finalize): We're not allowed to get() a dead Weak<T>
anymore, so use the debug-only was() helper function instead.

bindings/js/JSDOMBinding.h:

(WebCore::uncacheWrapper): Ditto.

bindings/js/JSNodeCustom.h:

(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper): We're not allowed to get() a dead
Weak<T>, so I had to push down these ASSERTs into ScriptWrappable.

bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode): Updated for non-Handle-ness
of Weak<T>.

bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper): Use was(), as above.

Source/WebKit2:

Updated for API change.

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize):

10:18 PM Changeset in webkit [113140] by tony@chromium.org

2 edits in trunk

remove WebKit files from .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=82966

Reviewed by Adam Barth.

.gitattributes: These entries were never updated from the move to

Source/WebKit so they're probably not needed.

10:05 PM Changeset in webkit [113139] by macpherson@chromium.org

2 edits
2 adds in trunk

Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115

Reviewed by Adam Barth.

No new tests.

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

10:00 PM Changeset in webkit [113138] by yutak@chromium.org

15 edits
4 adds in trunk

Crash in WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=82873

Reviewed by David Levin.

Source/WebCore:

WorkerThreadableWebSocketChannel::Bridge should properly handle the cases where inter-thread
callback is not called due to the termination of the worker run loop. Specifically, the bridge
should not send its "this" pointer to the main thread, because the bridge object may be freed
in the worker thread before the main thread starts to process.

Test: http/tests/websocket/tests/hybi/workers/worker-reload.html

Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::peer):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCreateWebSocketChannel):
Renamed from setUseHixie76Protocol, as this funtion now also sets m_peer.
Sets m_syncMethodDone to true, because this function is called in the end of
synchronous wait of Bridge::initialize().
(WebCore::ThreadableWebSocketChannelClientWrapper::clearPeer):
(WebCore::ThreadableWebSocketChannelClientWrapper::useHixie76Protocol):

Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

Add WorkerThreadableWebSocketChannel::Peer which is initialized after the creation of
WebSocketChannel in the main thread.
(ThreadableWebSocketChannelClientWrapper):

Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
Don't do synchronous wait in the constructor, as a member function may be called
during the wait before the constructor finishes. The meat of the constructor has
moved to initialize() function.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::~Bridge):
(WorkerContextDidInitializeTask):
(WebCore::WorkerContextDidInitializeTask::create):
(WebCore::WorkerContextDidInitializeTask::~WorkerContextDidInitializeTask):
(WebCore::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
Don't pass "this" object to the main thread. Receive the pointer to the peer object
via ThreadableWebSocketChannelClientWrapper which is ThreadSafeRefCounted<>.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
m_peer may be NULL, and we should not do anything in that case.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):

Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::derefThreadableWebSocketChannel):
(Bridge):

workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):

workers/WorkerLoaderProxy.h:

(WorkerLoaderProxy::postTaskForModeToWorkerContext):
Return bool to indicate whether postTask was successful or not. This is necessary
to avoid memory leaks of Peer object in Bridge::initialize() function.

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):

workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

Source/WebKit/chromium:

Change the function signature of WorkerLoaderProxy::postTaskForModeToWorkerContext().

src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):

src/WebSharedWorkerImpl.h:

(WebSharedWorkerImpl):

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):

src/WebWorkerClientImpl.h:

(WebWorkerClientImpl):

LayoutTests:

http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html: Added.
http/tests/websocket/tests/hybi/workers/resources/worker-reload.js: Added.
http/tests/websocket/tests/hybi/workers/worker-reload-expected.txt: Added.
http/tests/websocket/tests/hybi/workers/worker-reload.html: Added.

9:43 PM Changeset in webkit [113137] by keishi@webkit.org

21 edits
8 moves
1 add in trunk

Disable ENABLE_DATALIST for now
https://bugs.webkit.org/show_bug.cgi?id=82871

Reviewed by Kent Tamura.

We should disable ENABLE_DATALIST because

We need platform-dependent implementation, and non-BlackBerry platforms don't have it.
We need to hide the content of <datalist>, but it is shown for now.

Source/cmake/OptionsEfl.cmake: Disabled ENABLE_DATALIST.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebCore:

Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.

Tools:

Scripts/build-webkit: Disabled ENABLE_DATALIST.

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops: Disabled ENABLE_DATALIST.

LayoutTests:

Moved datalist tests into directory fast/forms/datalist and added it to Skipped files.

fast/forms/datalist/datalist-expected.txt: Moved from LayoutTests/fast/forms/datalist-expected.txt.
fast/forms/datalist/datalist-nonoption-child-expected.txt: Moved from LayoutTests/fast/forms/datalist-nonoption-child-expected.txt.
fast/forms/datalist/datalist-nonoption-child.html: Moved from LayoutTests/fast/forms/datalist-nonoption-child.html.
fast/forms/datalist/datalist.html: Moved from LayoutTests/fast/forms/datalist.html.
fast/forms/datalist/input-list-expected.txt: Moved from LayoutTests/fast/forms/input-list-expected.txt.
fast/forms/datalist/input-list.html: Moved from LayoutTests/fast/forms/input-list.html.
fast/forms/datalist/input-selectedoption-expected.txt: Moved from LayoutTests/fast/forms/input-selectedoption-expected.txt.
fast/forms/datalist/input-selectedoption.html: Moved from LayoutTests/fast/forms/input-selectedoption.html.
platform/chromium/test_expectations.txt:
platform/efl/Skipped:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

9:25 PM Changeset in webkit [113136] by fpizlo@apple.com

13 edits in trunk/Source/JavaScriptCore

jsr/sret should be removed
https://bugs.webkit.org/show_bug.cgi?id=82986
<rdar://problem/11017015>

Reviewed by Sam Weinig and Geoff Garen.

Replaces jsr/sret with finally block inlining.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::emitComplexJumpScopes):
(JSC):

bytecompiler/BytecodeGenerator.h:

(FinallyContext):
(BytecodeGenerator):

bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

jit/JIT.h:

(JIT):

jit/JITOpcodes.cpp:

(JSC):

jit/JITOpcodes32_64.cpp:

(JSC):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

9:21 PM Changeset in webkit [113135] by yael.aharon@nokia.com

6 edits in trunk/Source

[Qt][WK2] Assert on startup after r113090
https://bugs.webkit.org/show_bug.cgi?id=83111

Reviewed by Noam Rosenthal.

Source/WebCore:

Add willBeDestroyed to to GraphicsLayerTextureMapper.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

Source/WebKit2:

Add willBeDestroyed to to WebGraphicsLayer.

WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::willBeDestroyed):

WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

8:52 PM Changeset in webkit [113134] by rniwa@webkit.org

2 edits in trunk/Tools

Sigh... this isn't going well. I can't even reproduce this issue locally.
Another speculative fix.

Scripts/run-webkit-tests:

8:35 PM Changeset in webkit [113133] by weinig@apple.com

10 edits in trunk/Source/WebKit2

Allow the old WebKit2 drawing model to host layers in the window server
<rdar://problem/11170525>
https://bugs.webkit.org/show_bug.cgi?id=83101

Reviewed by Anders Carlsson.

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):

UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setLayerHostingMode):

WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):
(WebKit::LayerTreeHost::setLayerHostingMode):

WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

(LayerTreeHostCAMac):

WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::setLayerHostingMode):
Pipe layer hosting mode to the old drawing area.

8:15 PM Changeset in webkit [113132] by bashi@chromium.org

4 edits in trunk/Source/WebCore

[Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

7:56 PM Changeset in webkit [113131] by jamesr@google.com

5 edits in branches/chromium/1084/Source

Merge 113095 - [chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
https://bugs.webkit.org/show_bug.cgi?id=83061

Reviewed by James Robinson.

Source/WebCore:

Revised existing unit tests.

Use an absolute curve for touchpad fling. Here we identify the location on the curve corresponding
to the initial fling velocity, and "jump in" at that point. Avoids issues around time/magnitude
scaling present in previous implementation, and gives better feel to fling animation.

platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):

platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

tests/PlatformGestureCurveTest.cpp:

TBR=wjmaclean@chromium.org
BUG=121824
Review URL: https://chromiumcodereview.appspot.com/9969140

7:53 PM Changeset in webkit [113130] by dpranke@chromium.org

2 edits
1 delete in trunk/LayoutTests

Update another baseline for a failing chromium SL svg test (and mark it flaky).

Unreviewed, expectations change.

platform/chromium-mac-snowleopard/svg/text/ems-display-none-expected.txt: Removed.
platform/chromium/test_expectations.txt:

7:28 PM Changeset in webkit [113129] by dpranke@chromium.org

2 edits
3 deletes in trunk/LayoutTests

Update baselines for failing svg tests ...

Reviewed by NOBODY (OOPS!).

platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
platform/chromium/test_expectations.txt:

7:19 PM Changeset in webkit [113128] by rniwa@webkit.org

2 edits in trunk/Tools

I don't know why I'm so sloppy today. Another build fix.

Scripts/run-webkit-tests:

7:18 PM Changeset in webkit [113127] by hbono@chromium.org

13 edits
2 adds in trunk

Prevent spellchecking text pasted to an element having spellchecking disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Reviewed by Hajime Morita.

This change prevent calling SpellChecker::requestCheckingFor when pasting text
to an element whose spellcheck attribute is false or a password input.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-disabled.html

editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Disabled spellchecking on password inputs.

editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable): Return false when spellchecking is disabled.

LayoutTests:

editing/spelling/spellcheck-paste-disabled-expected.txt: Added.
editing/spelling/spellcheck-paste-disabled.html: Added.
platform/efl/Skipped: Skipped due to the lack of requestCheckingOfString().
platform/gtk/Skipped: ditto.
platform/mac-leopard/Skipped: ditto.
platform/mac-lion/Skipped: ditto.
platform/mac-wk2/Skipped: ditto.
platform/qt/Skipped: ditto.
platform/win-wk2/Skipped: ditto.
platform/win/Skipped: ditto.
platform/wincairo/Skipped: ditto.

7:12 PM Changeset in webkit [113126] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

Make it possible to install the JavaScriptCore test tools.

Part of <rdar://problem/11158607>.

Reviewed by Filip Pizlo.

JavaScriptCore.xcodeproj/project.pbxproj: Introduce an aggregate target named

Test Tools that builds testapi, minidom and testRegExp. Switch All from depending on
those targets individually to depending on the new aggregate target.

7:11 PM Changeset in webkit [113125] by hayato@chromium.org

2 edits in trunk/Source/WebCore

Make FocusController use a ComposedShadowTreeWalker, instead of ReifiedTreeTraversal APIs.
https://bugs.webkit.org/show_bug.cgi?id=82694

Reviewed by Dimitri Glazkov.

Rewrite a focus controller so that it uses ComposedShadowTreeWalker
since that is a preferred way to traverse composed shadow tree.
I'll get rid of ReifiedTreeTraversal in follow-up patches, which is now deprecated.

No new tests. No change in functionality.

page/FocusController.cpp:

(WebCore::walkerFrom):
(WebCore):
(WebCore::walkerFromNext):
(WebCore::walkerFromPrevious):
(WebCore::nextNode):
(WebCore::previousNode):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

6:49 PM Changeset in webkit [113124] by rniwa@webkit.org

2 edits in trunk/Tools

Hopefully the last build fix for Chromium Windows.

Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.

Scripts/run-webkit-tests:

6:44 PM Changeset in webkit [113123] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Crash in ~GraphicsContext3D() when init failed
https://bugs.webkit.org/show_bug.cgi?id=82992

Patch by Srikumar Bonda <srikumar.b@gmail.com> on 2012-04-03
Reviewed by Luiz Agostini.

WebKit crashes in ~GraphicsContext3D() while freeing the variables which are
not even allocated because of the init failure in GraphicsContext3D() for Qt.
In addition, Added a safety check in makeContextCurrent() before accessing
GraphicsContext3DPrivate object.

No new tests because the change is about adding null check
before accessing the variables.

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):

6:40 PM Changeset in webkit [113122] by dpranke@chromium.org

3 edits in trunk/Tools

[Chromium] Lots of timeouts causing Mac10.6 to exit early.
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).

Add logic to the apple mac and chromium mac code to not use
too many workers; it looks like the xserves (and possibly mac
pros) count hyperthreaded cores when they really shouldn't and
we end up using too many workers at a time; this leads to tests
thrashing and timing out.

This change is a temporary fix to make the bots happy while I
look into more profiling and other fixes.

Scripts/webkitpy/layout_tests/port/mac.py:

(ChromiumMacPort.default_child_processes):

Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.default_child_processes):

6:38 PM Changeset in webkit [113121] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Offlineasm ARM backend has a very convoluted way of saying it wants to emit a
three-operand multiply instruction
https://bugs.webkit.org/show_bug.cgi?id=83100

Reviewed by Darin Adler.

Changed the "muli"/"mulp" case to call emitArmV7() since that helper method was
already smart enough to do the Right Thing for multiply.

offlineasm/armv7.rb:

6:30 PM Changeset in webkit [113120] by Michael Nordman

1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[chromium] Unreviewed gardening: skip LayoutTest/storage/domstorage/quota.html

6:28 PM Changeset in webkit [113119] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Add audit token to PHCheckInWithPluginHost
https://bugs.webkit.org/show_bug.cgi?id=83102

Reviewed by Sam Weinig.

Plugins/Hosted/WebKitPluginHost.defs:

6:26 PM Changeset in webkit [113118] by fischman@chromium.org

2 edits in trunk/LayoutTests

Layout Test media/video-source-error.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=80068

Unreviewed; test is no longer showing up on flakiness dashboard.

platform/chromium/test_expectations.txt:

6:06 PM Changeset in webkit [113117] by Simon Fraser

2 edits in trunk/Tools

WebKitTestRunner's EventSender is leaky
https://bugs.webkit.org/show_bug.cgi?id=83099

Reviewed by Beth Dakin.

Fix leaks of WKNumbers by using the adoptWK idiom, and make
all the code consistent.

WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):

6:03 PM Changeset in webkit [113116] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Include Image.h in TextFieldDecoratorImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=83066

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-03
Reviewed by James Robinson.

src/TextFieldDecoratorImpl.cpp:

6:02 PM Changeset in webkit [113115] by rniwa@webkit.org

2 edits in trunk/Tools

Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.

Scripts/run-webkit-tests:

(useNewRunWebKitTests):

5:57 PM Changeset in webkit [113114] by rniwa@webkit.org

2 edits in trunk/Tools

kill-old-processes should kill apache2 and httpd
https://bugs.webkit.org/show_bug.cgi?id=83065

Reviewed by Tony Chang.

Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.

BuildSlaveSupport/kill-old-processes:

5:50 PM Changeset in webkit [113113] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Offlineasm ARM backend uses the wrong mnemonic for multiply
https://bugs.webkit.org/show_bug.cgi?id=83098
<rdar://problem/11168744>

Reviewed by Gavin Barraclough.

Use "mul" instead of "muls" since we're passing three operands, not two.

offlineasm/armv7.rb:

5:29 PM Changeset in webkit [113112] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Linux crashes during boot
https://bugs.webkit.org/show_bug.cgi?id=83096

Reviewed by Filip Pizlo.

The bug here is that we add empty JSValues to the sparse map, and then set them

but a GC may occur before doing so (due to a call to reportExtraMemory cost).

We may want to consider making it safe to mark empty JSValues, but the simple &
contained fix to this specific bug is to just initialize these values to
something other than JSValue().

runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::add):

Initialize sparse map entries.

5:28 PM Changeset in webkit [113111] by rafaelw@chromium.org

28 edits
2 copies
1 add in trunk/Source

Use V8 completion callback API to assert that V8RecursionScope is on the stack whenever invoking script
https://bugs.webkit.org/show_bug.cgi?id=79131

Reviewed by Adam Barth.

Source/WebCore:

End-of-microtask work (cancelling outstanding IDB transactions,
delivering DOM mutations) depend on V8RecursionScope being on the
stack whenever a call is made into script. V8 provides a completion
callback API that could be used to hook these "end-of-microtask"
events, but it turns out that WebKit calls into script for various
reasons besides running script from the page. For example, constructing
wrapper objects from function templates counts as "running script",
yet it's not appropriate to run this callback every time a JS wrapper
is constructed.

Instead, this patch makes use of the V8 completion callback mechanism
only in debug mode, to assert that either a V8RecursionScope (when
calling author script) or a V8RecursionScope::MicrotaskSuppression
(when calling non-author script) is on the stack when V8 thinks it's
finished executing script. This requires dropping MicrotaskSuppression
objects in a bunch of places, most notably the Inspector.
Note that in release mode, this class does nothing and thus should be
optimized away.

No new tests. Existing tests have appropriate coverage.

Target.pri:
WebCore.gypi:
bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::setAllowSleep):

bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::callFunctionEvenIfScriptDisabled):
(WebCore):
(WebCore::ScriptController::collectGarbage):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::callDebuggerMethod):
(WebCore):
(WebCore::ScriptDebugServer::pauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::currentCallFrame):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):

bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::internalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::incrementInternalScriptRecursionLevel):
(WebCore::V8BindingPerIsolateData::decrementInternalScriptRecursionLevel):

bindings/v8/V8DOMWindowShell.cpp:
bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

bindings/v8/V8NPObject.cpp:
bindings/v8/V8RecursionScope.h:

(WebCore):
(WebCore::V8RecursionScope::recursionLevel):
(V8RecursionScope):
(WebCore::V8RecursionScope::properlyUsed):
(MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::MicrotaskSuppression):
(WebCore::V8RecursionScope::MicrotaskSuppression::~MicrotaskSuppression):

bindings/v8/WorkerContextExecutionProxy.cpp:
bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::WrapInShadowObject):

bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

bindings/v8/custom/V8ScriptProfileCustom.cpp:
bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

Source/WebKit/chromium:

WebKit.gyp:
public/WebFrame.h:

(v8):
(WebFrame):

src/WebFrameImpl.cpp:

(WebKit):
(WebKit::WebFrameImpl::callFunctionEvenIfScriptDisabled):

src/WebFrameImpl.h:

(WebFrameImpl):

src/WebKit.cpp:

(WebKit):
(WebKit::assertV8RecursionScope):
(WebKit::initialize):
(WebKit::shutdown):

5:04 PM Changeset in webkit [113110] by annacc@chromium.org

3 edits
2 adds in trunk

Makes sure m_showingByDefault is set to false when TextTrack.mode is set from JS.
https://bugs.webkit.org/show_bug.cgi?id=79791

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-mode.html

html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode): setMode should always setShowingByDefault to false.

LayoutTests:

media/track/track-mode-expected.txt: Added.
media/track/track-mode.html: Added.

4:38 PM Changeset in webkit [113109] by jpu@apple.com

35 edits
2 moves in trunk/Source

Manual submission for bug 82942.

4:37 PM Changeset in webkit [113108] by mrowe@apple.com

5 edits in branches/safari-534.56-branch/Source

Versioning.

4:35 PM Changeset in webkit [113107] by mrowe@apple.com

1 copy in tags/Safari-534.56.5

New tag.

4:32 PM Changeset in webkit [113106] by eae@chromium.org

3 edits in branches/subpixellayout/Source/WebCore/rendering

RenderBox cleanup on branch.

4:26 PM Changeset in webkit [113105] by abarth@webkit.org

6 edits in trunk/Source

Unreviewed. This patch adds an ugly, ugly hack to bandaid over the
Windows component build. See comments in the code for details.

Source/Platform:

chromium/public/WebMediaStreamSourcesRequest.h:

(WebMediaStreamSourcesRequest):

Source/WebCore:

platform/chromium/support/WebMediaStreamSourcesRequest.cpp:

(WebKit::WebMediaStreamSourcesRequest::dummy):
(WebKit):

Source/WebKit/chromium:

src/WebKit.cpp:

(WebKit::shutdown):

4:25 PM Changeset in webkit [113104] by tony@chromium.org

2 edits in trunk/Tools

run the same test steps on test only bots as on build-and-test bots
https://bugs.webkit.org/show_bug.cgi?id=83090

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestFactory.init):

4:04 PM Changeset in webkit [113103] by Dimitri Glazkov

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r113087.
http://trac.webkit.org/changeset/113087
https://bugs.webkit.org/show_bug.cgi?id=83068

Breaks Windows builds in other unpredictable ways.

WebKit.gyp: Removed the hack.

4:04 PM Changeset in webkit [113102] by fischman@chromium.org

2 edits in trunk/Tools

Add a Media watchlist.
https://bugs.webkit.org/show_bug.cgi?id=83071

Reviewed by David Levin.

Scripts/webkitpy/common/config/watchlist:

3:58 PM Changeset in webkit [113101] by Simon Fraser

2 edits in trunk/Tools

Fix large leak in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83084

Reviewed by Beth Dakin.

Fix a leak of the bimap backing store created when doing pixel and
ref tests. This leak was causing serious thrash on the test bots.

We don't need to allocate memory for CGBitmapContextCreate(); if we
pass NULL, it will allocate and manage its own backing store.

WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):

3:54 PM Changeset in webkit [113100] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Remove #if !USE(TILED_BACKING_STORE) from WebFrameLoaderClient::transitionToCommittedForNewPage()
https://bugs.webkit.org/show_bug.cgi?id=83070

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Andreas Kling.

It is preventing m_frameHasCustomRepresentation to be set properly and not in sync with
WebFrameLoaderClient::transitionToCommittedFromCachedFrame()

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

3:51 PM Changeset in webkit [113099] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=83040

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/css-set-selector-text-crash.html

Removing the early bail when we detect that our selector text
hasn't changed, and we don't notify the styleSelectorChanged.
In fact, when we adopt the new selector list, the old one will
get destroyed and the styleSelectorChanged call needs to be made.

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

LayoutTests:

fast/css/css-set-selector-text-crash-expected.txt: Added.
fast/css/css-set-selector-text-crash.html: Added.

3:39 PM Changeset in webkit [113098] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

presentationAttributeCacheMaximumSize is set too low
https://bugs.webkit.org/show_bug.cgi?id=82816

Reviewed by Antti Koivisto.

Performance change, no side effects anticipated.

Prior to r106740, the presentation attribute style cache used to grow unbounded. As part of r110316,
a different version of the cache was introduced with a maximum size of 128. This size gave a 75% hit rate.

However this is bad as the previous cache had a 85% hit rate and each miss propagate down to the matched
properties cache as we use pointer comparisons.

This change bumps the size to 4096. This size was chosen to bring us back to the previous hit rate while
being a power of 2 (it is the HashMap maximum size). The steep increase is due to the combinational compexity
of the new cache model: we need to match all our attributes' name, value and tag name to get a hit vs
one attribute name, value and a category in the previous cache. To avoid blowing up the memory, we introduced
a timer to clear the cache if the hit rate is too low.

The measured hit rate is actually better now - in the 90% range on most page cyclers. This ups the matched
properties hit rate by 1 percent point on presentation attributes.

This is not a true apple-to-apple comparison as the cache model was changed.

dom/StyledElement.cpp:

(PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::didHitPresentationAttributeCache):
(WebCore::PresentationAttributeCacheCleaner::cleanCache):
(WebCore):
(WebCore::presentationAttributeCacheCleaner):
(WebCore::StyledElement::updateAttributeStyle):
Added the logic to clean the presentation attribute cache if we drop below 100 hits per minutes.

3:34 PM Changeset in webkit [113097] by tony@chromium.org

38 edits in trunk

Implement new flex property and deprecate flex function
https://bugs.webkit.org/show_bug.cgi?id=82128

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests. Tests were updated to use the new syntax and they should
all pass.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredFlexLengthForChild): Grab the
preferred size and if it's auto, fall back to width or height.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

rendering/RenderFlexibleBox.h:

LayoutTests:

Update tests to use the -webkit-flex: propery instead of the function.
In most cases this was just a simple find & replace, but in a few cases
we had to clear the flex value.

css3/flexbox/auto-height-dynamic.html:
css3/flexbox/child-overflow.html:
css3/flexbox/columns-auto-size.html:
css3/flexbox/cross-axis-scrollbar.html:
css3/flexbox/flex-algorithm-min-max.html:
css3/flexbox/flex-algorithm-with-margins.html:
css3/flexbox/flex-algorithm.html:
css3/flexbox/flex-align-column.html:
css3/flexbox/flex-align-max.html:
css3/flexbox/flex-align-percent-height.html:
css3/flexbox/flex-align-stretch.html:
css3/flexbox/flex-align-vertical-writing-mode.html:
css3/flexbox/flex-align.html:
css3/flexbox/flex-flow-border.html:
css3/flexbox/flex-flow-margins-auto-size-expected.txt: This test had expected failures that needed to be updated.
css3/flexbox/flex-flow-margins-auto-size.html:
css3/flexbox/flex-flow-margins.html:
css3/flexbox/flex-flow-overflow.html:
css3/flexbox/flex-flow-padding.html:
css3/flexbox/flex-flow.html:
css3/flexbox/flex-no-flex.html:
css3/flexbox/flex-order.html:
css3/flexbox/flex-pack.html:
css3/flexbox/line-wrapping.html:
css3/flexbox/multiline-align.html:
css3/flexbox/multiline-line-pack-horizontal-column.html:
css3/flexbox/multiline-reverse-wrap-baseline.html:
css3/flexbox/multiline-reverse-wrap-overflow.html:
css3/flexbox/multiline.html:
css3/flexbox/orthogonal-flex-directions.html:
css3/flexbox/position-absolute-child.html:
css3/flexbox/repaint-rtl-column.html:
css3/flexbox/repaint.html:
css3/flexbox/writing-modes.html:

3:26 PM Changeset in webkit [113096] by andersca@apple.com

5 edits in trunk/Source/WebCore

Search result page scrolls up before the correct page opens from google search
https://bugs.webkit.org/show_bug.cgi?id=81280
<rdar://problem/10973263>

Reviewed by Sam Weinig.

Make the requested scroll position part of the ScrollingTreeState so any changes being made
are in sync with other important changes such as the scroll layer or contents size.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Use coordinatesScrollingForFrameView instead of checking if the frame is the main frame.

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
Call ScrollingTreeState::setRequestedScrollPosition.

(WebCore::ScrollingCoordinator::setScrollLayer):
Reset the requested scroll position.

page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::setRequestedScrollPosition):
Keep track of the scroll position.

page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Update the scroll position if it's changed.

3:26 PM UsingGitWithWebKit edited by dpranke@chromium.org

(diff)

3:02 PM Changeset in webkit [113095] by wjmaclean@chromium.org

5 edits in trunk/Source

[chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
https://bugs.webkit.org/show_bug.cgi?id=83061

Reviewed by James Robinson.

Source/WebCore:

Revised existing unit tests.

platform/TouchpadFlingPlatformGestureCurve.cpp:

platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

tests/PlatformGestureCurveTest.cpp:

3:01 PM Changeset in webkit [113094] by rniwa@webkit.org

2 edits in trunk/Tools

Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.

BuildSlaveSupport/built-product-archive:

(unzipArchive):

2:52 PM Changeset in webkit [113093] by fischman@chromium.org

2 edits in trunk/LayoutTests

http/tests/media/video-cancel-load.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=82508

Unreviewed, removing no-longer-needed expectation.

platform/chromium/test_expectations.txt:

2:48 PM Changeset in webkit [113092] by zmo@google.com

30 edits
5 adds in trunk

Implement WebGLShaderPrecisionFormat
https://bugs.webkit.org/show_bug.cgi?id=75925

Reviewed by Kenneth Russell.

Source/Platform:

chromium/public/WebGraphicsContext3D.h: Add getShaderPrecisionFormat().

(WebGraphicsContext3D):

Source/WebCore:

Test: fast/canvas/webgl/shader-precision-format.html

CMakeLists.txt: Add new source files webglshaderprecisionformat.h/idl
DerivedSources.make: Ditto.
DerivedSources.pri: Ditto.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
html/canvas/WebGLRenderingContext.cpp: Add getShaderPrecisionFormat.

(WebCore):
(WebCore::WebGLRenderingContext::getShaderPrecisionFormat):

html/canvas/WebGLRenderingContext.h: Ditto.

(WebCore):
(WebGLRenderingContext):

html/canvas/WebGLRenderingContext.idl: Ditto.
html/canvas/WebGLShaderPrecisionFormat.h: Added.

(WebCore):
(WebGLShaderPrecisionFormat):
(WebCore::WebGLShaderPrecisionFormat::create):
(WebCore::WebGLShaderPrecisionFormat::rangeMin):
(WebCore::WebGLShaderPrecisionFormat::rangeMax):
(WebCore::WebGLShaderPrecisionFormat::precision):
(WebCore::WebGLShaderPrecisionFormat::WebGLShaderPrecisionFormat):

html/canvas/WebGLShaderPrecisionFormat.idl: Added.
page/DOMWindow.idl: Expose new type WebGLShaderPrecisionFormat for instanceof.
platform/graphics/GraphicsContext3D.h: Add getShaderPrecisionFormat().
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):

Source/WebKit/chromium:

src/GraphicsContext3DChromium.cpp: Add getShaderPrecisionFormat().

(WebCore):

src/GraphicsContext3DPrivate.h: Ditto.

(GraphicsContext3DPrivate):

tests/FakeWebGraphicsContext3D.h: Ditto.

(FakeWebGraphicsContext3D):

LayoutTests:

fast/canvas/webgl/instanceof-test-expected.txt: Add new WebGLShaderPrecisionFormat failure.
fast/canvas/webgl/instanceof-test.html:
fast/canvas/webgl/shader-precision-format-expected.txt: Added.
fast/canvas/webgl/shader-precision-format.html: Added.
fast/dom/Window/script-tests/window-property-descriptors.js: Add new type WebGLShaderPrecisionFormat.
fast/dom/Window/window-properties.html: Ditto.
fast/dom/script-tests/prototype-inheritance-2.js: Ditto.

(constructorNamesForWindow):

fast/dom/script-tests/prototype-inheritance.js: Ditto.
fast/js/script-tests/global-constructors.js: Ditto.

2:35 PM Changeset in webkit [113091] by commit-queue@webkit.org

5 edits
4 adds in trunk

Source/WebCore: Frame flattening: Do not restart layout from parent frame, when the parent is clean.
https://bugs.webkit.org/show_bug.cgi?id=81114

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.

When frame flattening is on, child frames try to mark the ancestors dirty
to be able to restart layout from the main frame. Child frames mark the
anchestors in FrameView::scheduleRelayout(). Marking fails when scheduling is disabled,
for example when the iframe's <head> has blocking resource and the <body> has not
been injected into the document.
When marking ancestor fails, child frame layout needs to continue normally.
It is expected to have layouts, when scheduling is enabled.

Test: http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html

page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::doLayoutWithFrameFlattening):

page/FrameView.h:

(FrameView):

LayoutTests: Add test case for 3 level nested iframes with frame flattening on.
https://bugs.webkit.org/show_bug.cgi?id=81114

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.

http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource-expected.txt: Added.
http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html: Added.
http/tests/misc/resources/3rd-level-iframe-with-blocking-resource.php: Added.
http/tests/misc/resources/nested-iframe-loading-another-iframe.html: Added.
platform/chromium/test_expectations.txt:

2:30 PM Changeset in webkit [113090] by Simon Fraser

13 edits in trunk/Source/WebCore

Avoid virtual method calls in the GraphicsLayer destructor
https://bugs.webkit.org/show_bug.cgi?id=83067

Reviewed by James Robinson.

Code cleanup to avoid calling virtual methods in the GraphicsLayer
destructor. Factor teardown code into a willBeDestroyed() method
that is called from the most dervied class. willBeDestroyed()
calls have to be chained. Fix the various ports' GraphicsLayer
implementations.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore):
(WebCore::GraphicsLayer::willBeDestroyed):

platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):

platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore):
(WebCore::GraphicsLayerCA::willBeDestroyed):

platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore):
(WebCore::GraphicsLayerChromium::willBeDestroyed):

platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):

platform/graphics/efl/GraphicsLayerEfl.cpp:

(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):

platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQt::~GraphicsLayerQt):
(WebCore):
(WebCore::GraphicsLayerQt::willBeDestroyed):

platform/graphics/qt/GraphicsLayerQt.h:

(GraphicsLayerQt):

2:29 PM Changeset in webkit [113089] by commit-queue@webkit.org

4 edits
1 add
1 delete in trunk/LayoutTests

[skia] Switch to Skia's implementation of the feMorphology filter.
https://bugs.webkit.org/show_bug.cgi?id=82085

Unreviewed Chromium expectations rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-04-03

platform/chromium-linux/svg/filters/filterRes-expected.png:
platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
platform/chromium-win/svg/filters/filterRes-expected.png:
platform/chromium/test_expectations.txt:

2:21 PM Changeset in webkit [113088] by dcheng@chromium.org

5 edits
2 adds in trunk

Having a drop handler prevents navigation on drop even if event is not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only early return if the drop handler prevents the default action.
http://trac.webkit.org/changeset/105396 introduced this issue when fixing some other aspects
of DnD handling.

Test: fast/events/drop-handler-should-not-stop-navigate.html

page/DragController.cpp:

(WebCore::DragController::performDrag):
(WebCore::DragController::concludeEditDrag): Remove the assert. By definition, we want to

allow default actions to run now if they weren't explicitly canceled.

LayoutTests:

fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
fast/events/drop-handler-should-not-stop-navigate.html: Added.
http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler

to prevent bubbled events from causing navigation.

2:17 PM Changeset in webkit [113087] by dpranke@chromium.org

2 edits in trunk/Source/WebKit/chromium

disable incremental linking for debug of webkit
https://bugs.webkit.org/show_bug.cgi?id=83068

Reviewed by Adam Barth.

Now that we need to export symbols from webkit.dll that are
defined in webcore_platform, we have to enable ULDI in order for
incremental linking to work (which is used in debug mode).

WebKit.gyp:

1:59 PM Changeset in webkit [113086] by arv@chromium.org

4 edits
4 adds in trunk

[v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057

Reviewed by Ojan Vafai.

Source/WebCore:

This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).

This also clears the strings once the code has been parsed and the function created.

Tests: fast/dom/inline-event-attributes-moved.html

fast/dom/inline-event-attributes-release.html

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):

bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

fast/dom/inline-event-attributes-moved-expected.txt: Added.
fast/dom/inline-event-attributes-moved.html: Added.
fast/dom/inline-event-attributes-release-expected.txt: Added.
fast/dom/inline-event-attributes-release.html: Added.

1:56 PM Changeset in webkit [113085] by commit-queue@webkit.org

11 edits
1 copy
3 adds
9 deletes in trunk/LayoutTests

More rebaselines after WK79568
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-03

platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
platform/chromium-linux/svg/css/group-with-shadow-expected.png: Removed.
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Removed.
platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
platform/chromium-win/svg/css/group-with-shadow-expected.png: Removed.
platform/chromium/test_expectations.txt:

1:53 PM Changeset in webkit [113084] by ojan@chromium.org

3 edits in trunk/Tools

Give more human friendly error message when builders fail to load or have stale data.
https://bugs.webkit.org/show_bug.cgi?id=83058

Reviewed by Eric Seidel.

TestResultServer/static-dashboards/dashboard_base.js:

(addError):
(addBuilderLoadErrors):
(handleLocationChange):

TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

1:50 PM Changeset in webkit [113083] by tomz@codeaurora.org

2 edits
350 adds in trunk/LayoutTests

Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734

Unreviewed test expectation updates

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03

platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
platform/chromium/test_expectations.txt:

1:40 PM Changeset in webkit [113082] by msaboff@apple.com

4 edits in trunk

Frequent crashes in JSC::parse in a worker thread when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660

Reviewed by Geoffrey Garen.

Source/WebCore:

Initialize m_script to empty string. Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.

Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.

workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::WorkerScriptLoader):

LayoutTests:

Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.

platform/mac/Skipped:

1:36 PM Changeset in webkit [113081] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[chromium] Enable sparkline FPS counter in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82959

Patch by James Robinson <jamesr@chromium.org> on 2012-04-03
Reviewed by Adrienne Walker.

This enables rendering the FPS counter sparkline when in threaded compositing mode. We don't currently have a
way to draw text from the thread (since we can't interact with WebCore::Font objects from a non-main thread),
but having a sparkline is still useful for judging framerate stability.

There are no tests for the HUD since it's a developer-facing feature and not user-facing.

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):

platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(CCHeadsUpDisplay):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

1:34 PM Changeset in webkit [113080] by kareng@chromium.org

14 edits
6 deletes in branches/chromium/1084

Revert 111028 - Support W3C Full Screen API proposal
https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html

fullscreen/full-screen-enabled.html
fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately. As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:

dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):

dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):

dom/Element.h:
dom/Element.idl:

dom/Document.cpp:

(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being

added to the event and error queue by swapping out empty queues before starting.

(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.

dom/Element.cpp:

(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

fullscreen/full-screen-element-stack-expected.txt: Added.
fullscreen/full-screen-element-stack.html: Added.
fullscreen/full-screen-enabled-expected.txt: Added.
fullscreen/full-screen-enabled.html: Added.
fullscreen/full-screen-request-rejected.html:
fullscreen/full-screen-request-removed.html:
fullscreen/full-screen-restrictions-expected.txt: Added.
fullscreen/full-screen-restrictions.html: Added.
fullscreen/full-screen-test.js:

TBR=jer.noble@apple.com
Review URL: https://chromiumcodereview.appspot.com/9950115

1:32 PM Changeset in webkit [113079] by rniwa@webkit.org

2 edits in trunk/Tools

Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.

BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):

1:16 PM Changeset in webkit [113078] by shawnsingh@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect comment in CCDamageTrackerTest
https://bugs.webkit.org/show_bug.cgi?id=82118

Reviewed by Adrienne Walker.

tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

1:15 PM Changeset in webkit [113077] by rniwa@webkit.org

2 edits in trunk/Tools

Yet another build fix after r113067. Don't trigger Chromium testers right away
since they're now triggered by builders.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:14 PM Changeset in webkit [113076] by robert@webkit.org

3 edits
28 adds in trunk

CSS 2.1 failure: at-import-009.htm fails
https://bugs.webkit.org/show_bug.cgi?id=82921

Source/WebCore:

Reviewed by Antti Koivisto.

This fixes at-import-009.htm only, the other tests already passed.

Tests: css2.1/20110323/at-import-001.htm

css2.1/20110323/at-import-002.htm
css2.1/20110323/at-import-003.htm
css2.1/20110323/at-import-004.htm
css2.1/20110323/at-import-005.htm
css2.1/20110323/at-import-006.htm
css2.1/20110323/at-import-007.htm
css2.1/20110323/at-import-009.htm
css2.1/20110323/at-import-010.htm
css2.1/20110323/at-import-011.htm

css/CSSGrammar.y: ignore empty '@media;' and '@charset;' declarations

LayoutTests:

Add the at-import-* tests from the CSS 2.1 suite. Skip at-import-008.htm
as it relies on a print media type to work.

Reviewed by Antti Koivisto.

css2.1/20110323/at-import-001-expected.html: Added.
css2.1/20110323/at-import-001.htm: Added.
css2.1/20110323/at-import-002-expected.html: Added.
css2.1/20110323/at-import-002.htm: Added.
css2.1/20110323/at-import-003-expected.html: Added.
css2.1/20110323/at-import-003.htm: Added.
css2.1/20110323/at-import-004-expected.html: Added.
css2.1/20110323/at-import-004.htm: Added.
css2.1/20110323/at-import-005-expected.html: Added.
css2.1/20110323/at-import-005.htm: Added.
css2.1/20110323/at-import-006-expected.html: Added.
css2.1/20110323/at-import-006.htm: Added.
css2.1/20110323/at-import-007-expected.html: Added.
css2.1/20110323/at-import-007.htm: Added.
css2.1/20110323/at-import-009-expected.html: Added.
css2.1/20110323/at-import-009.htm: Added.
css2.1/20110323/at-import-010-expected.html: Added.
css2.1/20110323/at-import-010.htm: Added.
css2.1/20110323/at-import-011-expected.html: Added.
css2.1/20110323/at-import-011.htm: Added.
css2.1/20110323/support/at-import-001.css: Added.
css2.1/20110323/support/at-import-002.css: Added.
css2.1/20110323/support/at-import-004.css: Added.
css2.1/20110323/support/at-import-005.css: Added.
css2.1/20110323/support/at-import-006.css: Added.
css2.1/20110323/support/at-import-007.css: Added.
css2.1/20110323/support/import-green.css: Added.
css2.1/20110323/support/import-red.css: Added.

1:14 PM Changeset in webkit [113075] by eae@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Convert RootInlineBox to LayoutUnits on branch.

1:05 PM Changeset in webkit [113074] by rniwa@webkit.org

2 edits in trunk/Tools

Another build fix after r113067 for Mac port.
It turned out that archiving the entire build directory doesn't work.

BuildSlaveSupport/built-product-archive:

(createZipManually):
(createZip):
(archiveBuiltProduct):

1:02 PM Changeset in webkit [113073] by commit-queue@webkit.org

10 edits in trunk

[BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
https://bugs.webkit.org/show_bug.cgi?id=82643

Source/WebKit/blackberry:

Enhance BlackBerry::WebKit::WebPage::findNextString()

This patch adds support for toggling case sensitivity,
search wrapping, and whether or not to highlight all matches
in addition to the next found match.

I refactored and renamed the new setActiveMatchAndMarker() method
to move the active match from one range to another. This was
required because in the case of a non wrapped search we do not
want to adjust the m_activeMatch if another match is not found.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::findNextString):

Api/WebPage.h:
WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):

WebKitSupport/InPageSearchManager.h:

(InPageSearchManager):

Tools:

Update LayoutTestController to accomodate the new find API.
It now provides caseSensitive functionality to DRT.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::findString):

LayoutTests:

Update findString-markers to also test caseSensitive.
All findString tests used to be case insensitive before.

Internal Review by Andy Chen.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.

platform/blackberry/editing/text-iterator/findString-markers-expected.txt:
platform/blackberry/editing/text-iterator/findString-markers.html:

12:31 PM Changeset in webkit [113072] by rniwa@webkit.org

2 edits in trunk/Tools

Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
because download-built-product creates the build directory as needed.

This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestFactory.init):

12:26 PM Changeset in webkit [113071] by rniwa@webkit.org

2 edits in trunk/Tools

Build fix after r113067. Don't delete the build directory.

BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):

12:24 PM Changeset in webkit [113070] by shawnsingh@chromium.org

2 edits in trunk/Source/WebCore

[chromium] remove dead function declarations in RenderSurfacechromium
https://bugs.webkit.org/show_bug.cgi?id=82086

Reviewed by James Robinson.

No tests needed, no change in behavior.

platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

12:21 PM Changeset in webkit [113069] by ojan@chromium.org

2 edits in trunk/LayoutTests

Update fast/regions expectations to match what's happening on
the chromium bots.

platform/chromium/test_expectations.txt:

12:08 PM Changeset in webkit [113068] by ojan@chromium.org

6 edits in trunk/Tools

Load all builder lists from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=82998

Reviewed by Adam Barth.

Also, remove an unnecessary list of test types. Now we don't hard-code
builder names anywhere and we only have a single hard-coded list of
test types.

TestResultServer/static-dashboards/builders.js:

(BuilderMaster.prototype.logPath):
(BuilderMaster.prototype.builderJsonPath):
(requestBuilderList.xhr.onload):
(requestBuilderList.xhr.onerror):
(isChromiumDepsFyiGpuTestRunner):
(isChromiumTipOfTreeGpuTestRunner):
(isChromiumDepsGTestRunner):
(isChromiumDepsCrosGTestRunner):
(isChromiumTipOfTreeGTestRunner):
(onBuilderListLoad):
(loadBuildersList):

TestResultServer/static-dashboards/dashboard_base.js:

(parseCrossDashboardParameters):
(currentBuilderGroupCategory):

TestResultServer/static-dashboards/flakiness_dashboard.html:
TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForTestsWithExpectationsButNoFailures):
(testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
(testGenerateChromiumDepsGTestBuildersFromBuilderList):
(testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
(testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):

TestResultServer/static-dashboards/timeline_explorer.html:

11:58 AM Changeset in webkit [113067] by rniwa@webkit.org

4 edits
1 add in trunk/Tools

Chromium testers should extract builds instead of building on their own
https://bugs.webkit.org/show_bug.cgi?id=82996

Reviewed by Tony Chang.

Make Chromium builders triggger Chromium testers and make testers download and extract builds
from the buildbot master instead of building binaries on their own.

Add download-built-product to wrap curl used in the download-built-product step since Windows
does not provide "curl" natively.

BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make

Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadBuiltProduct): Call download-built-product instead of curl.

BuildSlaveSupport/built-product-archive:

(createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
(archiveBuiltProduct): Zip the configuration build directory on Mac port.
(unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
(extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.

BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.

11:54 AM Changeset in webkit [113066] by Martin Robinson

2 edits in trunk/Tools

[GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82473

Reviewed by Philippe Normand.

Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.

gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first

check if the user has ever run update-gtk-libs and, if so, then use jhbuild.

11:26 AM Changeset in webkit [113065] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Another attempt to fix the Windows build. This uses WebSecurityOrigin
has a value type but doesn't include the header.

public/WebUserMediaRequest.h:

(WebKit):

11:09 AM Changeset in webkit [113064] by abarth@webkit.org

2 edits in trunk/Source/Platform

Attempt to fix the Windows component build by including these headers
rather than forward declaring these objects.

chromium/public/WebMediaStreamSourcesRequest.h:

(WebKit):

11:08 AM Changeset in webkit [113063] by eae@chromium.org

2 edits in branches/subpixellayout/Source/WebCore/rendering

Revert unneeded changes in RenderView and RenderDeprecatedFlexibleBox on branch.

10:57 AM Changeset in webkit [113062] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

Not reviewed. Follow up to inspector's r113032: change provisional method signature a bit.

public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::save):

10:50 AM Changeset in webkit [113061] by bbudge@chromium.org

4 edits in branches/chromium/1084

Merge 112997 - REGRESSION (r112217): H&R Block tax site won't load
https://bugs.webkit.org/show_bug.cgi?id=82964

Source/WebCore:

Modifies the redirect checking code to first check if the security origin can
request the redirect URL before invoking the CORS check.

Reviewed by Adam Barth.

http/tests/xmlhttprequest/access-control-and-redirects-async.html

loader/DocumentThreadableLoader.cpp:
loader/DocumentThreadableLoader.h:

LayoutTests:

Add a test case for a same origin request with a custom header that receives a
same origin redirect, and therefore should pass the redirect check.

Reviewed by Adam Barth.

http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
http/tests/xmlhttprequest/access-control-and-redirects-async.html:

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9956108

10:43 AM Changeset in webkit [113060] by bbudge@chromium.org

2 edits in branches/chromium/1084/Source/WebKit/chromium/src

Merge 112991 - WebViewImpl doesn't notify the page that the user has canceled fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=82760

Reviewed by Darin Fisher.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::willExitFullScreen):
(WebKit::WebViewImpl::exitFullScreenForElement):

src/WebViewImpl.h:

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9969112

10:42 AM Changeset in webkit [113059] by jpu@apple.com

11 edits in trunk/Source/WebCore

Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=82946

Reviewed by Enrica Casucci.

On OS X, we draw similar underline on dictated text that has alternative text. We rename
this function, so that we can reuse it for dictation underline.

No new tests, since there's no change of functionality.

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: