Context Navigation

← Previous Period
Next Period →

Timeline

Apr 5, 2012:

10:23 PM Changeset in webkit [113415] by adele@apple.com

4 edits in trunk/Source/WebCore

<rdar://problem/11133179> and https://bugs.webkit.org/show_bug.cgi?id=74129
REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken

Patch by Dan Bernstein, Reviewed by Beth Dakin.

This code assumed that the current CTM wouldn't have extraneous operations built into it,
but this bug is evidence that that assumption was wrong. We should just get the base CTM instead
and apply the device scale factor to it.

No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):

platform/graphics/GraphicsContext.h: (GraphicsContext):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

10:16 PM Changeset in webkit [113414] by yutak@chromium.org

3 edits in trunk/Source/WebCore

Leak in WebSocketChannel with workers/worker-reload.html
https://bugs.webkit.org/show_bug.cgi?id=83345

Reviewed by David Levin.

A speculative fix of memory leaks caused by worker-reload.html.

No new tests, as this change imposes no functional change.

Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
Receive the peer as PassOwnPtr<> so the destructor of the task object can
delete the peer even if the task didn't run before main thread's cleanup period.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):

Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):

9:57 PM Changeset in webkit [113413] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
https://bugs.webkit.org/show_bug.cgi?id=83141

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-05
Reviewed by Adam Barth.

No new tests required.

dom/DOMCoreException.cpp:

(CoreException):
(WebCore):
(WebCore::DOMCoreException::initializeDescription):

9:49 PM Changeset in webkit [113412] by Martin Robinson

3 edits in trunk/LayoutTests

Rebaseline a couple tests for GTK+.

platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:

9:26 PM Changeset in webkit [113411] by rakuco@webkit.org

12 edits in trunk/LayoutTests

[EFL] Gardening; update expctations in fast/css-generated-content.

Mostly adapt to the size changes after the jhbuild and font
commits.

platform/efl/fast/css-generated-content/003-expected.txt:
platform/efl/fast/css-generated-content/009-expected.png:
platform/efl/fast/css-generated-content/009-expected.txt:
platform/efl/fast/css-generated-content/013-expected.png:
platform/efl/fast/css-generated-content/013-expected.txt:
platform/efl/fast/css-generated-content/014-expected.png:
platform/efl/fast/css-generated-content/014-expected.txt:
platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
platform/efl/fast/css-generated-content/inline-display-types-expected.png:
platform/efl/fast/css-generated-content/inline-display-types-expected.txt:

9:26 PM Changeset in webkit [113410] by rakuco@webkit.org

7 edits in trunk/LayoutTests

[EFL] Gardening after r110072.

platform/efl/fast/clip/008-expected.png:
platform/efl/fast/clip/008-expected.txt:
platform/efl/fast/clip/011-expected.png:
platform/efl/fast/clip/011-expected.txt:
platform/efl/fast/clip/012-expected.png:
platform/efl/fast/clip/012-expected.txt:

9:26 PM Changeset in webkit [113409] by rakuco@webkit.org

1 edit
1 add in trunk/LayoutTests

[EFL] Gardening after r112112.

platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.

9:08 PM Changeset in webkit [113408] by rakuco@webkit.org

55 edits
1 copy
1 add in trunk/LayoutTests

[EFL] Gardening. Update baselines and expectations in fast/backgrounds, fast/block, fast/box-shadow and fast/box-sizing.

platform/efl/fast/backgrounds/001-expected.png:
platform/efl/fast/backgrounds/001-expected.txt:
platform/efl/fast/backgrounds/animated-svg-as-mask-expected.png:
platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
platform/efl/fast/backgrounds/background-clip-text-expected.png:
platform/efl/fast/backgrounds/background-clip-text-expected.txt:
platform/efl/fast/backgrounds/background-inherit-color-bug-expected.png:
platform/efl/fast/backgrounds/background-inherit-color-bug-expected.txt:
platform/efl/fast/backgrounds/background-leakage-expected.png:
platform/efl/fast/backgrounds/background-leakage-expected.txt:
platform/efl/fast/backgrounds/background-leakage-transforms-expected.png:
platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
platform/efl/fast/backgrounds/background-origin-root-element-expected.png:
platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
platform/efl/fast/backgrounds/background-position-parsing-expected.png:
platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.png:
platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
platform/efl/fast/backgrounds/opacity-on-document-element-expected.png:
platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
platform/efl/fast/backgrounds/size/backgroundSize15-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
platform/efl/fast/backgrounds/size/backgroundSize16-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
platform/efl/fast/backgrounds/size/zero-expected.png:
platform/efl/fast/backgrounds/size/zero-expected.txt:
platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
platform/efl/fast/backgrounds/svg-as-mask-expected.png: Added.
platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Copied from LayoutTests/platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt.
platform/efl/fast/block/float/015-expected.png:
platform/efl/fast/block/float/015-expected.txt:
platform/efl/fast/box-shadow/basic-shadows-expected.png:
platform/efl/fast/box-shadow/basic-shadows-expected.txt:
platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/efl/fast/box-shadow/box-shadow-transformed-expected.png:
platform/efl/fast/box-shadow/inset-box-shadows-expected.png:
platform/efl/fast/box-shadow/inset-expected.png:
platform/efl/fast/box-shadow/no-blur-multiple-offsets-expected.png:
platform/efl/fast/box-shadow/transform-fringing-expected.png:
platform/efl/fast/box-sizing/box-sizing-expected.png:
platform/efl/fast/box-sizing/box-sizing-expected.txt:

8:04 PM Changeset in webkit [113407] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Remove intrinsic padding from contentBoxRect(), etc.
https://bugs.webkit.org/show_bug.cgi?id=83092

Patch by David Barton <Dave Barton> on 2012-04-05
Reviewed by Julien Chaffraix.

"Intrinsic padding" does not count as CSS padding, but is treated as padding by basic
layout and rendering code, e.g. RenderBlock::layout(). A lot of code relies on the
equation border-box = content-box + padding + border (+ scrollbars). To keep this valid,
change 5 functions in RenderBox.h to not include intrinsic padding in the content box,
thus reverting to their behavior before the patch for bug 33593. Instead, have
sizingBox(renderer) in CSSComputedStyleDeclaration.cpp explicitly put the intrinsic
padding in computed CSS content-box values [for javascript getComputedStyle()], so the
above equation still also holds for CSS computed values. This seems more consistent with
how the padding...() functions behave since the patch for bug 23487, and will work
better for MathML. For instance, a block's contentLogicalWidth() will be the
availableLogicalWidth() for use by child elements.

No new tests. The only real observable changes are illustrated in the bug 83092 attached
test case and discussion. These are minor and hard to automate.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::sizingBox):

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode):

rendering/RenderBox.h:

(WebCore::RenderBox::contentBoxRect):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):

Change these 5 functions to omit intrinsic padding from the content box.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::cellBaselinePosition):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline):

7:51 PM Changeset in webkit [113406] by commit-queue@webkit.org

2 edits
2 adds in trunk

[BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
https://bugs.webkit.org/show_bug.cgi?id=83252

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-05
Reviewed by George Staikos.

Test: http/tests/misc/resources/referrer-main-resource.php

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):

7:48 PM Changeset in webkit [113405] by hbono@chromium.org

5 edits
2 adds in trunk

[Chromium] moving a cursor on a misspelled word should not remove a misspelled underline
https://bugs.webkit.org/show_bug.cgi?id=83214

Reviewed by Ryosuke Niwa.

When Chrome enables asynchronous spellchecking, it adds Spelling markers in the
background. For this case, moving a cursor should not remove these markers
because it requires Chrome to spellcheck text again. This change prevents
removing Spelling markers added by spellcheckers asynchronously.

Source/WebCore:

Test: platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html

editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection):

Source/WebKit/chromium:

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): use marker descriptions instead of spellchecking text when Chrome enables asynchronous spellchecking.

LayoutTests:

platform/chromium/editing/spelling/move-cursor-to-misspelled-word-expected.txt: Added.
platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Added.

7:27 PM Changeset in webkit [113404] by staikos@webkit.org

6 edits
2 adds in trunk

.: Compile the vibration module for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit: Add the vibration client for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

PlatformBlackBerry.cmake:

Source/WebKit/blackberry: Add a vibration client for BlackBerry and enable it.
https://bugs.webkit.org/show_bug.cgi?id=83340

Reviewed by Rob Buis.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): enable the client

WebCoreSupport/VibrationClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::VibrationClientBlackBerry::VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::vibrate):
(WebCore::VibrationClientBlackBerry::cancelVibration):
(WebCore::VibrationClientBlackBerry::vibrationDestroyed):

WebCoreSupport/VibrationClientBlackBerry.h: Added.

(WebCore):
(VibrationClientBlackBerry):
(WebCore::VibrationClientBlackBerry::~VibrationClientBlackBerry):

6:29 PM Changeset in webkit [113403] by eae@chromium.org

6 edits in branches/subpixellayout/Source/WebCore

Removed abs(LayoutUnit) on branch as it confused the chromium linux and gtk builds.

6:25 PM Changeset in webkit [113402] by Martin Robinson

2 edits in trunk/LayoutTests

Unskip a test that should now be passing after r113004

platform/gtk/Skipped: Unskip a test that should now be passing.

6:22 PM Changeset in webkit [113401] by Martin Robinson

2 edits in trunk/LayoutTests

Unskip some tests on GTK+ that should now be passing.

platform/gtk/Skipped:

6:18 PM Changeset in webkit [113400] by commit-queue@webkit.org

8 edits in trunk

CSS Exclusions polygon shape arguments should be comma separated
https://bugs.webkit.org/show_bug.cgi?id=82368

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Source/WebCore:

Changed the CSS Parser to accept a conventional comma separated argument list for the
polygon exclusion shape. The syntax had used spaces to separate x,y coordinates, like:
polygon(10px,20px 30px,40px). Now commas separate points: polygon(10px 20px, 30px 40px).
This change is per the draft exclusions spec, http://dev.w3.org/csswg/css3-exclusions.
Additional relevant information about CSS argument list syntax can be found
here: http://dev.w3.org/csswg/css3-values/#component-whitespace.

Factored comma recognition idiom in CSSParser.cpp into isComma() utility function.

The existing tests have been updated.

css/CSSParser.cpp:

(WebCore::isComma)
(WebCore::CSSParser::parseFillPosition)
(WebCore::CSSParser::parseFillRepeat)
(WebCore::CSSParser::parseFillProperty)
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue)
(WebCore::CSSParser::parseAnimationTimingFunction)
(WebCore::CSSParser::parseAnimationProperty)
(WebCore::CSSParser::parseExclusionShapePolygon)
(WebCore::CSSParser::parseDeprecatedGradient)
(WebCore::CSSParser::parseRadialGradient)
(WebCore::CSSParser::parseGradientColorStops)
(WebCore::CSSParser::parseImageSet)
(WebCore::filterInfoForName)
(WebCore::CSSParser::parseCustomFilter)
(WebCore::CSSParser::parseFontFeatureSettings)

css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapePolygon::cssText):

LayoutTests:

Updated the tests to match the polygon syntax defined by the draft exclusions
spec - http://dev.w3.org/csswg/css3-exclusions.

fast/exclusions/parsing-wrap-shape-inside-expected.txt:
fast/exclusions/parsing-wrap-shape-outside-expected.txt:
fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

6:14 PM Changeset in webkit [113399] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

This should fix things properly; FileUploader() was setting the
socket default timeout value, and apparently that doesn't work
properly with urllib. Also, the class had a bad try/finally
block that was causing the exceptions to be swallowed :(.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):

Scripts/webkitpy/common/net/networktransaction.py:

(NetworkTimeout.str):
(NetworkTransaction.run):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

6:06 PM Changeset in webkit [113398] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Crash when switching to a tab with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=83339
<rdar://problem/11183338>

Reviewed by Oliver Hunt.

Add an additional check so we don't try to call into plug-ins that haven't yet been initialized.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setLayerHostingMode):

5:56 PM Changeset in webkit [113397] by fischman@chromium.org

3 edits
2 moves in trunk/LayoutTests

http/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test, and is racy
https://bugs.webkit.org/show_bug.cgi?id=83296

Reviewed by Eric Carlson.

media/media-can-load-when-hidden-expected.txt: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt.
media/media-can-load-when-hidden.html: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden.html.
platform/chromium/test_expectations.txt:
platform/efl/Skipped:

5:12 PM Changeset in webkit [113396] by benjamin@webkit.org

7 edits in trunk/Source/JavaScriptCore

Speed up the conversion from JSValue to String for bulk operations
https://bugs.webkit.org/show_bug.cgi?id=83243

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Geoffrey Garen.

When making operations on primitive types, we loose some time converting
values to JSString in order to extract the string.

This patch speeds up some basic Array operations by avoiding the creation
of intermediary JSString when possible.

For the cases where we need to convert a lot of JSValue in a tight loop,
an inline conversion is used.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncSort):

runtime/CommonIdentifiers.h:
runtime/JSArray.cpp:

(JSC::JSArray::sort):

runtime/JSString.h:

(JSC::JSValue::toUString):
(JSC):
(JSC::inlineJSValueNotStringtoUString):
(JSC::JSValue::toUStringInline):

runtime/JSValue.cpp:

(JSC::JSValue::toUStringSlowCase):
(JSC):

runtime/JSValue.h:

(JSValue):

4:54 PM Changeset in webkit [113395] by jsbell@chromium.org

3 edits
3 adds in trunk

IndexedDB: Support string.length in keyPaths
https://bugs.webkit.org/show_bug.cgi?id=83221

Source/WebCore:

Special case in the IDB spec - keyPaths can reference the |length| property
of string values. Other instrinsic properties (|length| of Array, etc) are
handled automagically. Relevant section of the updated spec is:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct

Reviewed by Kentaro Hara.

Test: storage/indexeddb/keypath-intrinsic-properties.html

bindings/v8/IDBBindingUtilities.cpp:

(WebCore):

LayoutTests:

Reviewed by Kentaro Hara.

storage/indexeddb/keypath-intrinsic-properties-expected.txt: Added.
storage/indexeddb/keypath-intrinsic-properties.html: Added.
storage/indexeddb/resources/keypath-intrinsic-properties.js: Added.

(test.request.onsuccess):
(test):
(openSuccess.request.onsuccess):
(openSuccess):
(testKeyPaths.checkStringLengths.request.onsuccess):
(testKeyPaths.checkStringLengths):
(testKeyPaths.checkArrayLengths.request.onsuccess):
(testKeyPaths.checkArrayLengths):
(testKeyPaths):

4:40 PM Changeset in webkit [113394] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove some tests that are passing consistently.

platform/chromium/test_expectations.txt:

4:28 PM Changeset in webkit [113393] by arv@chromium.org

3 edits
4 copies in branches/chromium/1084

Merge 113086 - [v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057

Reviewed by Ojan Vafai.

Source/WebCore:

This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).

This also clears the strings once the code has been parsed and the function created.

Tests: fast/dom/inline-event-attributes-moved.html

fast/dom/inline-event-attributes-release.html

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):

bindings/v8/V8LazyEventListener.h:

(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

fast/dom/inline-event-attributes-moved-expected.txt: Added.
fast/dom/inline-event-attributes-moved.html: Added.
fast/dom/inline-event-attributes-release-expected.txt: Added.
fast/dom/inline-event-attributes-release.html: Added.

TBR=arv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10007027

4:20 PM Changeset in webkit [113392] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.
fast/js/cross-global-object-inline-global-var.html is flakey on win debug and
fast/forms/select-style.html is consistently passing.

platform/chromium/test_expectations.txt:

4:08 PM Changeset in webkit [113391] by benjamin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Use QuickSort when sorting primitive values by string representation
https://bugs.webkit.org/show_bug.cgi?id=83312

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Gavin Barraclough.

When the value we are sorting are all primitive values, we do not need to
ensure a stable sort as two values with equal string representation are
indistinguishable from JavaScript.

This gives about 16% performance increase when sorting primitive values.

runtime/JSArray.cpp:

(JSC::JSArray::sort):

4:00 PM Changeset in webkit [113390] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
https://bugs.webkit.org/show_bug.cgi?id=83314

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by George Staikos.

RIM PR: 143771
One new virtual method was added to the SkCanvas, to draw a nine piece
image. Override it and mark output as not being a solid color anymore.

platform/graphics/blackberry/InstrumentedPlatformCanvas.h:

(WebCore::InstrumentedPlatformCanvas::drawBitmapNine):
(InstrumentedPlatformCanvas):

3:57 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

3:51 PM Changeset in webkit [113389] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496

Reviewed by Gavin Barraclough.

Don't attempt to use the DFG when SSE2 is not available.

dfg/DFGCapabilities.cpp:

(JSC::DFG::canCompileOpcodes):

3:42 PM Changeset in webkit [113388] by dino@apple.com

2 edits in trunk/Source/WebKit2

[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
https://bugs.webkit.org/show_bug.cgi?id=76105

Unreviewed build fix for Windows. windowIsVisible() is PLATFORM(MAC) only.
This means a Page might start requestAnimationFrame-based animations
even when it isn't visible. This should only happen when a Page is
opened in the background though. The regular hide and show should still
pause animations.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::resumePainting):

3:33 PM Changeset in webkit [113387] by oliver@apple.com

79 edits in trunk/Source/WebCore

Make WebCore use jsCast rather than static_cast for casting JSC objects
https://bugs.webkit.org/show_bug.cgi?id=83320

Reviewed by Stephanie Lewis.

Mechanically replace static_cast with jsCast where ever we can.

WebCore.exp.in:
bindings/js/DOMWrapperWorld.cpp:

(WebCore::JSStringOwner::finalize):

bindings/js/DOMWrapperWorld.h:

(WebCore::currentWorld):

bindings/js/JSArrayBufferCustom.cpp:

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

bindings/js/JSDOMBinding.h:

(WebCore::deprecatedGlobalObjectForPrototype):
(WebCore::getDOMPrototype):

bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElement):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData):

bindings/js/JSDOMMimeTypeArrayCustom.cpp:

(WebCore::JSDOMMimeTypeArray::nameGetter):

bindings/js/JSDOMPluginArrayCustom.cpp:

(WebCore::JSDOMPluginArray::nameGetter):

bindings/js/JSDOMPluginCustom.cpp:

(WebCore::JSDOMPlugin::nameGetter):

bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::nameGetter):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::toJSDOMWindow):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):
(WebCore::toDOMWindow):

bindings/js/JSDOMWindowCustom.h:

(WebCore::asJSDOMWindow):

bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::window):

bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::globalObject):

bindings/js/JSDataViewCustom.cpp:

(WebCore::JSDataViewConstructor::constructJSDataView):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

bindings/js/JSEventTarget.cpp:

(WebCore):
(WebCore::toEventTarget):

bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

bindings/js/JSFloat64ArrayCustom.cpp:

(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):

bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::remove):

bindings/js/JSImageConstructor.cpp:

(WebCore::constructImage):

bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::nameGetter):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeOwner::finalize):

bindings/js/JSNodeCustom.h:

(WebCore::toJS):

bindings/js/JSNodeFilterCustom.cpp:

(WebCore::toNodeFilter):

bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeList::nameGetter):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectPropertyGetter):
(WebCore::callPlugin):

bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::state):

bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::nameGetter):

bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):

bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots):

bindings/js/JSTextTrackListCustom.cpp:

(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

bindings/js/JSTrackCustom.cpp:

(WebCore::toTrack):

bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

bindings/js/JSUint8ClampedArrayCustom.cpp:

(WebCore::JSUint8ClampedArrayConstructor::constructJSUint8ClampedArray):

bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):

bindings/js/JSWebKitPointCustom.cpp:

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

bindings/js/JSWorkerContextBase.cpp:

(WebCore::toJSDedicatedWorkerContext):
(WebCore::toJSSharedWorkerContext):

bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):

bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackForInspector):

bindings/js/ScriptControllerMac.mm:

(WebCore::updateStyleIfNeededForBindings):

bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidPause):

bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):

bindings/js/ScriptState.cpp:

(WebCore::domWindowFromScriptState):
(WebCore::scriptExecutionContextFromScriptState):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::fillTransferMap):
(WebCore::CloneSerializer::dumpArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject _isSafeScript]):
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
(GenerateCallWith):
(NativeToJSValue):
(GenerateConstructorDefinition):

bridge/jni/jni_jsobject.h:
bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertJObjectToValue):

bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):

bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeConstructor):

testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

3:21 PM WebKitGTK/1.8.x edited by Martin Robinson

(diff)

3:18 PM Changeset in webkit [113386] by commit-queue@webkit.org

5 edits
5 adds in trunk

[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html

The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.

platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.

Source/WebKit/gtk:

Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.

LayoutTests:

Added a pixel test for this issue.

platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.

3:07 PM Changeset in webkit [113385] by commit-queue@webkit.org

19 edits in trunk

Unreviewed, rolling out r113299.
http://trac.webkit.org/changeset/113299
https://bugs.webkit.org/show_bug.cgi?id=83297

The patch broke 11 tests on Lion. (Requested by jonlee on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):

LayoutTests:

platform/mac-lion/Skipped:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
platform/mac/svg/custom/viewbox-syntax-expected.png:
platform/mac/svg/custom/viewbox-syntax-expected.txt:
platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

3:01 PM Changeset in webkit [113384] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Correct misleading trace event names in Canvas2DLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=83310

Patch by Justin Novosad <junov@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

2:51 PM Changeset in webkit [113383] by eae@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

Cleanyp RenderInputSpeech on branch.

2:32 PM Changeset in webkit [113382] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, fast/js/keywords-and-reserved_words.html is
passing again after r113352.

platform/chromium/test_expectations.txt:

2:29 PM Changeset in webkit [113381] by dino@apple.com

9 edits in trunk

[mac] requestAnimationFrame sometimes stuck when page loads in a background tab https://bugs.webkit.org/show_bug.cgi?id=76105

Reviewed by Simon Fraser.

Source/WebCore:

Fix three issues with requestAnimationFrame:

It's possible for the call to rAF to come to the document before there is a page associated. Added a guard for this.
A page may try to suspend the scripted animations before the ScriptedAnimationController exists, in which case we need to suspend it immediately after it is created. Do this by keeping track of the state in Page. Otherwise rAF would be busy looping on hidden pages until they are brought to the front and hidden again.
A page created in the background (from WebKit1) does not get informed it is not visible. This can mean that resume() is called more times than suspend() and we get into a state where the number of suspensions becomes -1, and thus fails truthiness tests. Clamp it to values >= 0.

No new tests, since this is not automatically testable. The most reliable test
is to open a page with rAF in a background tab within Safari.

dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::resume):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):

page/Page.h:

(WebCore::Page::scriptedAnimationsSuspended):
(Page):

Source/WebKit2:

When we are resuming painting only start the scripted animations
if we're a visible window. This can happen when tabs are opened
in the background.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::resumePainting):

LayoutTests:

Add fast/animation/request-animation-frame-during-modal.html
to the skipped list. This patch will ensure that non-visible windows
do not get a requestAnimationFrame callback, so the test will timeout.
See https://bugs.webkit.org/show_bug.cgi?id=83239 to re-enable.

platform/mac/Skipped:

2:18 PM Changeset in webkit [113380] by tony@chromium.org

1 edit
1 copy
1 delete in trunk/LayoutTests

[chromium] Unreviewed, moving linux result from 32-bit directory to 64 and 32 bit directory.

platform/chromium-linux/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/svg/clip-path/clip-path-tspan-and-stroke-expected.png.

2:15 PM Changeset in webkit [113379] by beidson@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/9359029> and https://bugs.webkit.org/show_bug.cgi?id=83311 Crashes in WebProcess at WebCore::HistoryController::recursiveSetProvisionalItem when restoring previous session

Reviewed by Sam Weinig.

It's possible to hit a race condition between the UIProcess and the WebProcess where the UIProcess records for a
page have been cleared out but the WebProcess is still trying to perform a history navigation within that page.

In this situation HistoryController code that expects there to always be a current history item in the back/forward
controller is wrong.

No new tests. (The race conditions involved have proven making a test impractical)

loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveSetProvisionalItem): Don't ASSERT the fromItem. We now know there might not be one.
(WebCore::HistoryController::recursiveGoToItem): Ditto
(WebCore::HistoryController::itemsAreClones): Always return false if either item is null, as a null item and a non-null

item cannot possible be clones of each other.

2:11 PM Changeset in webkit [113378] by adamk@chromium.org

6 edits
4 adds in trunk

Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html

fast/mutation/transient-gc-crash.html

dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.

dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.

dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.

dom/WebKitMutationObserver.h:

LayoutTests:

fast/mutation/clear-transient-without-delivery-expected.txt: Added.
fast/mutation/clear-transient-without-delivery.html: Added.
fast/mutation/transient-gc-crash-expected.txt: Added.
fast/mutation/transient-gc-crash.html: Added.

2:04 PM Changeset in webkit [113377] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, update expectation for
media/nodesFromRect-shadowContent.html since it moved in r113371.

platform/chromium/test_expectations.txt:

1:53 PM Changeset in webkit [113376] by rafaelw@chromium.org

2 edits in trunk/LayoutTests

Added takeRecords to WebKitMutationObserver properties list, to fix mac.

platform/mac/fast/dom/Window/window-properties-expected.txt:

1:52 PM Changeset in webkit [113375] by tony@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, fix lint errors in GTK+ test_expectations.txt file.

platform/gtk/test_expectations.txt:

http/tests/security/cross-origin-xsl-redirect-BLOCKED.html had 2 entries
and css3/flexbox/inline-flexbox.html doesn't exist anymore.

1:45 PM Changeset in webkit [113374] by adamk@chromium.org

5 edits in trunk/Source/WebCore

Rebaseline binding tests after r113272.

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

1:44 PM Changeset in webkit [113373] by senorblanco@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Drawing an accelerated canvas onto itself is slow.
https://bugs.webkit.org/show_bug.cgi?id=83295

Fixed by using a GPU-side deepCopy() in skia, so we don't trigger a
readback and re-upload.

Reviewed by James Robinson.

Correctness is covered by existing tests. Performance is covered
by the test case attached to the bug.

platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::create):

1:35 PM Changeset in webkit [113372] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] Record the number of tiles paint-culled instead of the incorrect number of pixels
https://bugs.webkit.org/show_bug.cgi?id=82423

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

Source/WebCore:

We currently attempt to record the number of pixels we save from uploading,
however the number is wrong in two ways.
1) An early-out if everything is culled results in nothing being reported.
2) With threaded-compositor, the number of pixels uploaded in one tile can be
changed by culling in another tile, making the number far too difficult to
compute to be worthwhile. If a tile was going to be partial-updated, but is
culled, now a new tile gets to be partial-updated instead, which affects the
numbers.

This patch breaks up CCOverdrawMetrics to make the methods/variables less
overloaded and more clear. This way they don't have to mirror each other
so closely on paint/draw sides.

Then we record the number of tiles for which we prevented upload via paint
culling. This will still over-report (a dirty culled tile stays dirty and
will be culled again each commit), but it seems more reasonable as it
clearly does not try to mimic a performance metric in the way that a pixel
count does, but still gives a rough estimation of the amount of paint
culling going on in a page.

Covered by existing tests, modified where needed.

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCullTileForUpload):
(WebCore):
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsCulledForDrawing):
(WebCore::CCOverdrawMetrics::pixelsUploadedOpaque):
(WebCore::CCOverdrawMetrics::pixelsUploadedTranslucent):
(WebCore::CCOverdrawMetrics::tilesCulledForUpload):

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::append):

Source/WebKit/chromium:

tests/CCQuadCullerTest.cpp:

(WebCore::TEST):

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

1:34 PM Changeset in webkit [113371] by tonikitoo@webkit.org

2 moves in trunk/LayoutTests/media

2012-04-05 Antonio Gomes <agomes@rim.com>

Move nodesFromRect-shadowContent test from fast/dom to media, where the
helper .js files are able to work properly.
https://bugs.webkit.org/show_bug.cgi?id=80847 (PART III)

Reviewed by Eric Carlson.

media/nodesFromRect-shadowContent-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-shadowContent-expected.txt.
media/nodesFromRect-shadowContent.html: Renamed from LayoutTests/fast/dom/nodesFromRect-shadowContent.html.

1:32 PM Changeset in webkit [113370] by tony@chromium.org

3 edits in trunk/LayoutTests

[chromium] Unreviewed, update baselines for tests with 'let' after r113352.

platform/chromium/fast/js/reserved-words-as-property-expected.txt:
platform/chromium/fast/js/reserved-words-strict-expected.txt:

1:31 PM Changeset in webkit [113369] by enrica@apple.com

10 edits
2 adds in trunk/Source/WebCore

Provide a separate editing command to cleanup of redundant markup.
https://bugs.webkit.org/show_bug.cgi?id=83240

Reviewed by Ryosuke Niwa.

This patch moves the logic originally performed by the private
method removeRedundantMarkup inside ReplaceSelectionCommand into
a separate command. This way the markup cleanup can be exposed as
a separate command, independent from ReplaceSelectionCommand.

No new tests. No change in functionality.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added new file to project files.

editing/EditorAllInOne.cpp: Added SimplifyMarkupCommand.
editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Now uses SimplifyMarkupCommand.

editing/ReplaceSelectionCommand.h:

(ReplaceSelectionCommand): Removed removeRedundantMarkup.

editing/SimplifyMarkupCommand.cpp: Added.

(WebCore::SimplifyMarkupCommand::SimplifyMarkupCommand):
(WebCore::SimplifyMarkupCommand::doApply):

editing/SimplifyMarkupCommand.h: Added.

(WebCore::SimplifyMarkupCommand::create):

1:28 PM Changeset in webkit [113368] by schenney@chromium.org

18 edits
1 add
4 deletes in trunk/LayoutTests

Rebaseline text results
https://bugs.webkit.org/show_bug.cgi?id=74928

Unreviewed text expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-05

platform/chromium-mac-leopard/svg/text/textPathBoundsBug-expected.png: Removed.
platform/chromium-mac-leopard/svg/text/textPathBoundsBug-expected.txt: Removed.
platform/chromium-mac-snowleopard/svg/text/textPathBoundsBug-expected.txt: Removed.
platform/chromium-win-xp/svg/zoom/page: Removed.
platform/chromium-win/fast/repaint/reflection-redraw-expected.png:
platform/chromium-win/printing/width-overflow-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/text-align-04-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
platform/chromium-win/svg/carto.net/textbox-expected.png:
platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.png:
platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.png:
platform/chromium-win/svg/text/text-align-05-b-expected.png:
platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
platform/chromium/test_expectations.txt:
platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
svg/as-background-image/svg-as-background-4-expected.txt: Added.

1:26 PM Changeset in webkit [113367] by eae@chromium.org

3 edits in branches/subpixellayout/Source/WebCore

Remove unused ValueToString function on branch.

1:24 PM Changeset in webkit [113366] by schenney@chromium.org

2 edits
4 adds in trunk/LayoutTests

[Chromium] Layout test failure svg/clip-path/clip-path-tspan-and-stroke.xhtml
https://bugs.webkit.org/show_bug.cgi?id=83308

Unreviewed Chromium test expectations update.

Also removing some expectations that are no longer needed.

platform/chromium-linux-x86/svg/clip-path: Added.
platform/chromium-linux-x86/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
platform/chromium-win/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
platform/chromium-win/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
platform/chromium/test_expectations.txt:

1:21 PM Changeset in webkit [113365] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix 32-bit build.

1:14 PM Changeset in webkit [113364] by shawnsingh@chromium.org

7 edits
2 adds in trunk/Source

[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
https://bugs.webkit.org/show_bug.cgi?id=80806

Reviewed by Adrienne Walker.

Source/WebCore:

Unit tests added to CCLayerTreeHostCommon. This change is also
covered by other existing unit tests and layout tests.

WebCore TransformationMatrix mapRect / mapQuad / projectQuad do
not properly handle the case where a surface is oriented partially
behind the camera, with a perspective projection. In this case,
projected points may appear to be valid in cartesian coordinates,
but they are indeed not valid, and this problem can only be
detected in homogeneous coordinates after applying the transform,
before the divide-by-w step.

The correct solution is to clip geometry where w < 0. This patch
makes this change local to chromium only, to fix rendering bugs
that arise from this problem. The primary fix is to correct
calculateVisibleLayerRect(), but other ancillary locations are
also fixed, in particular, the antialiasing code path is simply
skipped when this case arises.

Eventually this math needs to be merged into TransformationMatrix,
to fix hit-testing bugs that occur in both Chromium and Safari.

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

platform/graphics/chromium/cc/CCMathUtil.cpp: Added.

(WebCore):
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::computeClippedPointForEdge):
(WebCore::expandBoundsToIncludePoint):
(WebCore::computeEnclosingRectOfClippedQuad):
(WebCore::computeEnclosingRect):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):

platform/graphics/chromium/cc/CCMathUtil.h: Added.

(WebCore):
(CCMathUtil):

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

1:09 PM Changeset in webkit [113363] by oliver@apple.com

28 edits in trunk/Source/JavaScriptCore

Replace static_cast with jsCast when casting JSCell subclasses in JSC
https://bugs.webkit.org/show_bug.cgi?id=83307

Reviewed by Gavin Barraclough.

Replace all usage of static_cast<JSCell subtype*> with jsCast<> in JavaScriptCore.
This results in assertions when unsafe casts are performed, but simply leaves
a static_cast<> in release builds.

API/APICast.h:

(toJS):

API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

API/JSCallbackObjectFunctions.h:

(JSC::::asCallbackObject):
(JSC::::finishCreation):
(JSC::::construct):
(JSC::::call):

API/JSObjectRef.cpp:

(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):

API/JSValueRef.cpp:

(JSValueIsObjectOfClass):

API/JSWeakObjectMapRefPrivate.cpp:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):

debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::finishCreation):

dfg/DFGOperations.cpp:
interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Executable.h:

(JSC::isHostFunction):

runtime/JSActivation.h:

(JSC::asActivation):

runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

runtime/JSArray.h:

(JSC::asArray):

runtime/JSBoundFunction.cpp:

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):

runtime/JSByteArray.h:

(JSC::asByteArray):

runtime/JSCell.cpp:

(JSC::JSCell::toObject):

runtime/JSCell.h:

(JSC::jsCast):

runtime/JSGlobalObject.h:

(JSC::asGlobalObject):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

runtime/JSObject.cpp:

(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::toThisObject):
(JSC::JSObject::unwrappedObject):

runtime/JSObject.h:

(JSC::asObject):

runtime/JSPropertyNameIterator.h:

(JSC::Register::propertyNameIterator):

runtime/JSString.h:

(JSC::asString):
(JSC::JSValue::toString):

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSubstr):

1:03 PM Changeset in webkit [113362] by schenney@chromium.org

6 edits
1 add
3 deletes in trunk/LayoutTests

[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Unreviewed Chromium test expectations update.

Somehow this test slipped thorugh the crack of rebaselining.

platform/chromium-linux-x86/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
platform/chromium-linux/svg/as-object/nested-embedded-svg-size-changes-expected.png:
platform/chromium-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
platform/chromium-mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Modified property svn:mime-type.
platform/chromium-win-vista/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
platform/chromium-win-xp/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
platform/chromium-win/svg/as-object/nested-embedded-svg-size-changes-expected.png:
platform/chromium/test_expectations.txt:

1:01 PM Changeset in webkit [113361] by Patrick Gansterer

18 edits in trunk

[Qt] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=83270

Reviewed by Eric Seidel.

Modify the #include declerations so that the
wtf types are included using the full path.

Source/WebCore:

platform/graphics/TiledBackingStoreBackend.h:

Source/WebKit/qt:

Api/qwebpage.cpp:
WebCoreSupport/ContextMenuClientQt.h:
WebCoreSupport/EditorClientQt.h:
WebCoreSupport/FrameLoaderClientQt.h:
WebCoreSupport/InspectorServerQt.cpp:

Source/WebKit2:

Shared/qt/QtNetworkReplyData.cpp:
UIProcess/WebLayerTreeRenderer.cpp:
UIProcess/qt/LayerBackingStore.h:
UIProcess/qt/QtViewportInteractionEngine.cpp:
UIProcess/qt/QtViewportInteractionEngine.h:
UIProcess/qt/QtWebPageSGNode.h:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

Tools:

WebKitTestRunner/qt/TestInvocationQt.cpp:

12:49 PM Changeset in webkit [113360] by schenney@chromium.org

3 edits
1 delete in trunk/LayoutTests

Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Unreviewed Chromium expectations update.

Somehow this file was not correctly rebaselined when the original change was made.

platform/chromium-linux/svg/custom/repaint-on-constant-size-change-expected.png: Removed.
platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Modified property svn:mime-type.
platform/chromium/test_expectations.txt:

12:41 PM Changeset in webkit [113359] by eae@chromium.org

729 edits
124 copies
10 deletes in branches/subpixellayout

Merge trunk changes up until 113337 into subpixel branch.

12:38 PM Changeset in webkit [113358] by tonikitoo@webkit.org

2 edits in trunk/Source/WebCore

2012-04-05 Antonio Gomes <agomes@rim.com>

Unreviewed bit left over from rebasing the origin patch before landing it.

Complementary to r113329.

rendering/HitTestResult.cpp: (WebCore::HitTestResult::operator=):

12:32 PM Changeset in webkit [113357] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Cleanup test, redundant code in CCSchedulerTest.NoBeginFrameWhenDrawFails
https://bugs.webkit.org/show_bug.cgi?id=83300

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

12:32 PM Changeset in webkit [113356] by rniwa@webkit.org

4 edits in trunk

perf-o-matic should include unit in runs JSON responses
https://bugs.webkit.org/show_bug.cgi?id=83294

Reviewed by Tony Chang.

This is a follow up to r112829. Report the unit in /api/test/runs so that the frontend can show it.
Fixed a bug in Test.update_or_insert that it didn't store the unit when it first created the Test object.

Also increment perf-o-matic's version to 18.

Websites/webkit-perf.appspot.com/app.yaml: Incremented the version.
Websites/webkit-perf.appspot.com/models.py:

(Test.update_or_insert.execute): Store unit when creating a test.
(Runs.to_json): Include unit.

Websites/webkit-perf.appspot.com/models_unittest.py: Added tests.

(TestModelTests.test_update_or_insert_with_unit):
(RunsTest.test_to_json_without_results):
(RunsTest.test_to_json_with_results):
(RunsTest.test_to_json_with_unit):

12:30 PM Changeset in webkit [113355] by benjamin@webkit.org

8 edits
2 adds in trunk/Source/JavaScriptCore

Make something faster than JSStringBuilder for joining an array of JSValue
https://bugs.webkit.org/show_bug.cgi?id=83180

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Geoffrey Garen.

This patch add the class JSStringJoiner optimized for join() operations.

This class makes stricter constraints than JSStringBuilder in order avoid
memory allocations.

In the best case, the class allocate memory only twice:
-Allocate an array to keep a list of UString to join.
-Allocate the final string.

We also avoid the conversion from 8bits strings to 16bits strings since
they are costly and unlikly to help for subsequent calls.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

runtime/JSStringJoiner.cpp: Added.

(JSC):
(JSC::appendStringToData):
(JSC::joinStrings):
(JSC::JSStringJoiner::build):

runtime/JSStringJoiner.h: Added.

(JSC):
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

12:25 PM Changeset in webkit [113354] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, widen the suppression for
http/tests/multipart/policy-ignore-crash.php-- it is flakey on win debug too.

platform/chromium/test_expectations.txt:

12:23 PM Changeset in webkit [113353] by schenney@chromium.org

4 edits
2 adds
3 deletes in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test expectations rationalization.

Apparently the efl port results match Chromium.

platform/chromium-win-vista/svg/as-background-image: Removed.
platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Removed.
platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Removed.
platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
platform/chromium/test_expectations.txt:
platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
svg/as-background-image/svg-as-background-1-expected.txt: Added.
svg/as-background-image/svg-as-background-3-expected.txt: Added.

12:09 PM Changeset in webkit [113352] by barraclough@apple.com

9 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=77293
[Un]Reserve 'let'

Rubber stamped by Oliver Hunt.

Revert r106198.
This does break the web - e.g. https://bvi.bnc.ca/index/bnc/indexen.html
If we're going to reserve let, we're going to have to do so in a more
circumspect fashion.

Source/JavaScriptCore:

parser/Keywords.table:

LayoutTests:

fast/js/keywords-and-reserved_words-expected.txt:
fast/js/reserved-words-as-property-expected.txt:
fast/js/reserved-words-strict-expected.txt:
fast/js/script-tests/keywords-and-reserved_words.js:
fast/js/script-tests/reserved-words-as-property.js:
fast/js/script-tests/reserved-words-strict.js:

12:08 PM Changeset in webkit [113351] by arv@chromium.org

3 edits
2 deletes in trunk/LayoutTests

HTMLSelectElement does not have a getter for namedItem. This fixes the invalid test
https://bugs.webkit.org/show_bug.cgi?id=83289

Reviewed by Ryosuke Niwa.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-select-element

fast/dom/HTMLSelectElement/named-options-expected.txt:
fast/dom/HTMLSelectElement/script-tests/named-options.js:
platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.

12:07 PM Changeset in webkit [113350] by zmo@google.com

7 edits in trunk/Source

Unreviewed, rolling out r113241.
http://trac.webkit.org/changeset/113241
https://bugs.webkit.org/show_bug.cgi?id=83293

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):

12:05 PM Changeset in webkit [113349] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Fixed incorrect expectations for fonts/cursive.html.

platform/chromium/test_expectations.txt: Fixed.

12:04 PM Changeset in webkit [113348] by jpu@apple.com

1 edit in trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp

Fixing build failure on SnowLeopard caused by changeset 113340.

12:00 PM Changeset in webkit [113347] by shawnsingh@chromium.org

7 edits
2 deletes in trunk/Source

Unreviewed, rolling out r113341.
http://trac.webkit.org/changeset/113341
https://bugs.webkit.org/show_bug.cgi?id=83299

bots caught some build errors (Requested by shawnsingh on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

platform/graphics/chromium/cc/CCMathUtil.cpp: Removed.
platform/graphics/chromium/cc/CCMathUtil.h: Removed.
platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

11:57 AM Changeset in webkit [113346] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Race condition in CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=83179

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-05
Reviewed by James Robinson.

tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::willAnimateLayers):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::willAnimateLayers):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::notifyAnimationStarted):

11:49 AM Changeset in webkit [113345] by commit-queue@webkit.org

8 edits in trunk/Source

[Chromium] With the skia port, setting LCD text filtering is causing
texture cache invalidations of gpu canvas backing store
https://bugs.webkit.org/show_bug.cgi?id=74183

Patch by Justin Novosad <junov@chromium.org> on 2012-04-05
Reviewed by Stephen White.

Source/WebCore:

Replacing unnecessary usage of SkCanvas::LayerIter with calls to
SkCanvas::isDrawingToLayer(). Same results, lower overhead, and no
GPU texture invalidation.

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore):
(WebCore::TransparencyAwareFontPainter::initializeForGDI):

platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore):
(WebCore::adjustTextRenderMode):

platform/graphics/skia/FontSkia.cpp:

(WebCore):
(WebCore::adjustTextRenderMode):

platform/graphics/skia/SkiaFontWin.cpp:

(WebCore):
(WebCore::disableTextLCD):

rendering/RenderThemeChromiumWin.cpp:

(WebCore):

Source/WebKit/chromium:

Replacing unnecessary usage of SkCanvas::LayerIter with call to
SkCanvas::isDrawingToLayer(). Same results, lower overhead, and no
GPU texture invalidation.

src/WebFontImpl.cpp:

(WebKit::WebFontImpl::drawText):

11:47 AM Changeset in webkit [113344] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Properly align members in WebInputEvent and subclasses to make Valgrind happy.
https://bugs.webkit.org/show_bug.cgi?id=81570

Patch by Lei Zhang <thestig@chromium.org> on 2012-04-05
Reviewed by Darin Fisher.

public/WebInputEvent.h:

(WebKit):
(WebKit::WebInputEvent::WebInputEvent):
(WebKeyboardEvent):
(WebKit::WebTouchEvent::WebTouchEvent):

11:32 AM Changeset in webkit [113343] by commit-queue@webkit.org

7 edits in trunk

media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

Source/WebCore:

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-05
Reviewed by Eric Carlson.

Move all the checking for the WebVTT file identifier from TextTrackLoader
to WebVTTParser, notifying the parser clients of parsing failures through
a new method. Remove the WebVTTParser::fileIdentifierMaximumLength method
and make WebVTTParser::hasRequiredFileIdentifier private. The latter now
operates on a vector holding the identifier data to which data is added
until there's enough of it to possibly hold the optional BOM character
and the required WEBVTT character sequence.

No new tests. Fixes an existing test.

html/track/WebVTTParser.cpp: Fix a typo throughout the file:

fileIdentiferLength -> fileIdentifierLength
(WebCore):
(WebCore::WebVTTParser::parseBytes): Only continue with searcing for
the WEBVTT identifier if there's enough data to possibly contain the
identifier. Report that the file failed to parse if the identifier
was then not found.
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Refactor to operate
on the vector containing identifier data and merge with the
hasLongWebVTTIdentifier function.

html/track/WebVTTParser.h:

(WebVTTParserClient): Add a new method.
(WebVTTParser):

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::processNewCueData): Parser is now created
immediately regardless of the mime type the response holds.
(WebCore::TextTrackLoader::fileFailedToParse): Log the error, set the
state to failed, start the cue load timer and cancel the load if the file
was not parsed successfully.
(WebCore):

loader/TextTrackLoader.h:

(TextTrackLoader):

LayoutTests:

Remove the test from test expectations file as it should now pass.

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-05
Reviewed by Eric Carlson.

platform/chromium/test_expectations.txt:

11:28 AM Changeset in webkit [113342] by darin@chromium.org

12 edits in branches/chromium/1084

Merge 113282 - Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Patch by Greg Billock <gbillock@google.com> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

Modules/intents/DOMWindowIntents.idl:
Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity):

Modules/intents/NavigatorIntents.h:

(NavigatorIntents):

Modules/intents/NavigatorIntents.idl:

LayoutTests:

webintents/resources/web-intents-reload-orig.html:
webintents/resources/web-intents-testing.js:

(startIntentWithCallbacks):

webintents/web-intents-api-expected.txt:
webintents/web-intents-api.html:
webintents/web-intents-invoke.html:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9949021

11:24 AM Changeset in webkit [113341] by shawnsingh@chromium.org

7 edits
2 adds in trunk/Source

[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
https://bugs.webkit.org/show_bug.cgi?id=80806

Reviewed by Adrienne Walker.

Source/WebCore:

Unit tests added to CCLayerTreeHostCommon. This change is also
covered by other existing unit tests and layout tests.

Eventually this math needs to be merged into TransformationMatrix,
to fix hit-testing bugs that occur in both Chromium and Safari.

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

platform/graphics/chromium/cc/CCMathUtil.cpp: Added.

platform/graphics/chromium/cc/CCMathUtil.h: Added.

(WebCore):
(CCMathUtil):

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

11:16 AM Changeset in webkit [113340] by jpu@apple.com

31 edits
5 adds in trunk/Source

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
See WebCore/ChangeLog for details.

UIProcess/API/gtk/PageClientImpl.cpp:
UIProcess/API/mac/PageClientImpl.h: (PageClientImpl):
UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::recordAutocorrectionResponse):
UIProcess/API/qt/qquickwebview.cpp:
UIProcess/PageClient.h: (PageClient):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::recordAutocorrectionResponse):
UIProcess/mac/CorrectionPanel.h:
UIProcess/mac/CorrectionPanel.mm:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp: Added. (WebKit): (WebKit::WebAlternativeTextClient::WebAlternativeTextClient): (WebKit::WebAlternativeTextClient::~WebAlternativeTextClient): (WebKit::WebAlternativeTextClient::showCorrectionAlternative): (WebKit::WebAlternativeTextClient::dismissAlternative): (WebKit::WebAlternativeTextClient::dismissAlternativeSoon): (WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Added. (WebKit): (WebAlternativeTextClient):
WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
See WebCore/ChangeLog for details.

WebCoreSupport/CorrectionPanel.h:
WebCoreSupport/CorrectionPanel.mm:
WebCoreSupport/WebAlternativeTextClient.h: Added. (WebAlternativeTextClient):
WebCoreSupport/WebAlternativeTextClient.mm: Added. (WebAlternativeTextClient::WebAlternativeTextClient): (WebAlternativeTextClient::~WebAlternativeTextClient): (WebAlternativeTextClient::showCorrectionAlternative): (WebAlternativeTextClient::dismissAlternative): (WebAlternativeTextClient::dismissAlternativeSoon): (WebAlternativeTextClient::recordAutocorrectionResponse):
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::~WebEditorClient):
WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

See WebCore/ChangeLog for details.

WebKit.xcodeproj/project.pbxproj:

2012-04-05 Jia Pu <jpu@apple.com>

Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Reviewed by Enrica Casucci.

No new tests, since there's no change of functionality.

The existing correction panel related functions in EditorClient are currently used only by OS X.
We'd like to move them into separate AlternativeTextClient class to avoid using #ifdef's. This
new client class will also hold dictation alternative related interface that we will add soon for
bug 82503.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
editing/AlternativeTextController.cpp: Changes in this file are all for calling functions in AlternativeTextClient instead of those in EditoClient. (WebCore::AlternativeTextController::show): (WebCore::AlternativeTextController::dismiss): (WebCore::AlternativeTextController::dismissSoon): (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection): (WebCore::AlternativeTextController::timerFired): (WebCore::AlternativeTextController::isAutomaticSpellingCorrectionEnabled): (WebCore::AlternativeTextController::alternativeTextClient): (WebCore): (WebCore::AlternativeTextController::editorClient): (WebCore::AlternativeTextController::textChecker): (WebCore::AlternativeTextController::recordAutocorrectionResponseReversed): (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
editing/AlternativeTextController.h: (WebCore): (AlternativeTextController):
editing/TextCheckingHelper.h: (WebCore):
loader/EmptyClients.h: (EmptyEditorClient):
page/AlternativeTextClient.h: Added. (WebCore): (AlternativeTextClient): (WebCore::AlternativeTextClient::~AlternativeTextClient):
page/EditorClient.h: (EditorClient):
page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
page/Page.h: (WebCore): (PageClients): (Page): (WebCore::Page::alternativeTextClient):

11:15 AM Changeset in webkit [113339] by commit-queue@webkit.org

2 edits in trunk/Tools

gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-05
Reviewed by Tony Chang.

Refactored the test to use os.path.join() to specify the
core_pattern value of the empty crash log mock.

Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest):
(GtkPortTest.assertLinesEqual):
(GtkPortTest.test_get_crash_log):
(_mock_gdb_output):

11:01 AM Changeset in webkit [113338] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Marked storage/indexeddb/basics-workers.html as flaky across all platforms in DEBUG

platform/chromium/test_expectations.txt: Marked.

10:54 AM Changeset in webkit [113337] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix fullscreen video button for android
https://bugs.webkit.org/show_bug.cgi?id=83087

Patch by Min Qin <qinmin@google.com> on 2012-04-05
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=70437 changed css keyword for fullscreen video button.
It is changed from media-fullscreen-button to media-enter-fullscreen-button.
However, it does not change the value in mediaControlChromiumAndroid.css.
No behavior change.

css/mediaControlsChromiumAndroid.css:

(video::-webkit-media-controls-fullscreen-button):

10:46 AM Changeset in webkit [113336] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: CSS file revisions are not restored upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=83292

Reviewed by Yury Semikhatsky.

Populating suggestions before the panel creation now.

inspector/front-end/inspector.js:

(WebInspector._doLoadedDoneWithCapabilities.get if):

10:44 AM Changeset in webkit [113335] by Simon Fraser

5 edits in trunk/Source/WebCore

Add assertions to check for mutation of RenderLayer z-order lists during enumeration
https://bugs.webkit.org/show_bug.cgi?id=83242

Reviewed by James Robinson.

Add debug-only code that detects whether RenderLayer's z-order and
normal flow lists are being cleared or otherwise mutated while we're
enumerating over them.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::calculateLayerBounds):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateZOrderListsSlowCase):
(WebCore::RenderLayer::updateNormalFlowList):

rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::layerListMutationAllowed):
(WebCore::RenderLayer::setLayerListMutationAllowed):
(WebCore):
(LayerListMutationDetector):
(WebCore::LayerListMutationDetector::LayerListMutationDetector):
(WebCore::LayerListMutationDetector::~LayerListMutationDetector):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::layerHas3DContent):

10:38 AM April 2012 Meeting edited by rniwa@webkit.org

(diff)

10:27 AM Changeset in webkit [113334] by zmo@google.com

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r113254.
http://trac.webkit.org/changeset/113254
https://bugs.webkit.org/show_bug.cgi?id=83291

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

10:18 AM Changeset in webkit [113333] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Rolling out http://trac.webkit.org/changeset/113262.
Original code was fine.

Rubber-stamped by Oliver Hunt.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

10:11 AM Changeset in webkit [113332] by zmo@google.com

4 edits in trunk/Source

Unreviewed, rolling out r113307.
http://trac.webkit.org/changeset/113307
https://bugs.webkit.org/show_bug.cgi?id=83288

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::TEST_F):

9:56 AM Changeset in webkit [113331] by tony@chromium.org

3 edits
1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening.
fast/events/click-focus-anchor.html is flakey in debug
fast/filesystem/file-writer-abort-continue.html is hitting an assert.

platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Removed.
platform/chromium/test_expectations.txt:

9:50 AM Changeset in webkit [113330] by Csaba Osztrogonác

19 edits in trunk

[Qt] Fix includes after QtDeclarative -> QtQML renaming
https://bugs.webkit.org/show_bug.cgi?id=82195

Relanding r112651, because Qt5 is updated everywhere.

Source/WebKit/qt:

declarative/experimental/plugin.cpp:
declarative/plugin.cpp:

(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

UIProcess/API/qt/qquicknetworkreply_p.h:
UIProcess/API/qt/qquicknetworkrequest_p.h:
UIProcess/API/qt/qquickwebview.cpp:
UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qwebiconimageprovider_p.h:
UIProcess/API/qt/qwebnavigationhistory.cpp:
UIProcess/API/qt/qwebnavigationhistory_p.h:
UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
UIProcess/qt/QtDialogRunner.cpp:

(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):

UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

MiniBrowser/qt/main.cpp:
WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

qmake/mkspecs/features/unix/default_post.prf:

9:46 AM Changeset in webkit [113329] by tonikitoo@webkit.org

19 edits
2 adds in trunk

Extend HitTestResult to support not "discarding" shadow content in favor of its DOM ancestor
https://bugs.webkit.org/show_bug.cgi?id=80847

Reviewed by David Hyatt.
Patch by Antonio Gomes <agomes@rim.com>

Exporting Internals::nodesFromRect symbols for the Gtk build.

Source/autotools/symbols.filter:

Source/WebCore:

In order to improve touch precision on shadow tree content, patch
extends the rect-hittest'ing system to allow shadow content
to be stored as the rect-hittest result node list.

Primary use cases are for this extension is making it easier to
improve the clickability of default controls of <video> and <audio>
elements.

For the callee site, the use is simple: if shadow content in the rect-hittest
result is desired, just add an extra 'AllowShadowContent' parameter at the creation
of the HitTestResult object.

Test: fast/dom/nodesFromRect-shadowContent.html

dom/Document.cpp:

(WebCore::Document::nodesFromRect):

dom/Document.h:

(Document):

page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):

rendering/HitTestResult.h:

(HitTestResult):
(WebCore::HitTestResult::shadowContentFilterPolicy):

rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

testing/Internals.h:

(Internals):

testing/Internals.idl:

LayoutTests:

Adds a test that rect-hittest's a element known to have a shadow
tree (<video> with built-in controls), and check if its return type
contains its clickable shadow nodes.

fast/dom/nodesFromRect-shadowContent-expected.txt: Added.
fast/dom/nodesFromRect-shadowContent.html: Added.
fast/dom/resources/nodesFromRect.js:

(check):
(checkShadowContent):

Conflicts:

Source/WebCore/page/FrameView.cpp

9:41 AM Changeset in webkit [113328] by commit-queue@webkit.org

10 edits in trunk

Rename CSS Exclusions "rect" value to "rectangle"
https://bugs.webkit.org/show_bug.cgi?id=82367

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Changed the CSS exclusion shape called "rect" to "rectangle" to match
the current draft spec - http://dev.w3.org/csswg/css3-exclusions.

Source/WebCore:

The meeting minutes where the decision to rename the exclusion "rect" function
to "rectangle" are: http://lists.w3.org/Archives/Public/www-style/2012Feb/0325.html

No new tests were created; just updated the existing ones.

css/CSSParser.cpp:

(WebCore::CSSParser::parseWrapShapeRectangle):
(WebCore::CSSParser::parseWrapShape):

css/CSSParser.h:
css/CSSWrapShapes.cpp:

(WebCore::CSSWrapShapeRectangle::cssText):

css/CSSWrapShapes.h:

(WebCore::CSSWrapShapeRectangle::create):
(WebCore::CSSWrapShapeRectangle::type):
(WebCore::CSSWrapShapeRectangle::CSSWrapShapeRectangle):

LayoutTests:

fast/exclusions/parsing-wrap-shape-inside-expected.txt:
fast/exclusions/parsing-wrap-shape-outside-expected.txt:
fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

9:39 AM Changeset in webkit [113327] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Marked fast/filesystem/file-writer-abort-continue.html as flaky crash
https://bugs.webkit.org/show_bug.cgi?id=83286

platform/chromium/test_expectations.txt: Marked.

9:10 AM Changeset in webkit [113326] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] Disable paintingGoesToWindow() for the root layer when forced compositing mode is active
https://bugs.webkit.org/show_bug.cgi?id=83127

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by Rob Buis.

RIM PR: 136381
The BlackBerry port will use accelerated compositing code path to
render the root layer in some situations.

The plan is to do this by activating the "force compositing mode"
setting, but that in itself doesn't get us all the way, since painting
will still go to window for the root layer.

Fixed by adding a special clause in
RenderLayerBacking::paintingGoesToWindow() for PLATFORM(BLACKBERRY).

No new tests, this is currently not testable with the BlackBerry WebKit
testing infrastructure.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintingGoesToWindow):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):
(WebCore::RenderLayerCompositor::inForcedCompositingMode): Added.

8:57 AM Changeset in webkit [113325] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Force compositing mode when backing store is not active
https://bugs.webkit.org/show_bug.cgi?id=83131

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by George Staikos.

RIM PR: 136381
Normally, the BlackBerry WebKit port resorts to direct rendering when
the backing store is not active. However, direct rendering is broken
with the OpenGL code path. This prevented multiple web pages from being
displayed at once with the new WebPageCompositor API.

Fixed by using accelerated compositing layer to render the root layer
instead of backing store. This will give us a tiled layer backing the
root layer, which for some use cases is even better than direct
rendering.

Reviewed internally by Filip Spacek.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::setNeedsOneShotDrawingSynchronization):

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::rootLayer):
(WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setDrawsRootLayer):

Api/WebPage_p.h:

(WebPagePrivate):

8:51 AM Changeset in webkit [113324] by rakuco@webkit.org

2 edits
19 adds in trunk/LayoutTests

[EFL][DRT] Gardening 30 missing expectations
https://bugs.webkit.org/show_bug.cgi?id=83266

Unreviewed EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-05

platform/efl/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
platform/efl/svg/as-background-image/svg-as-background-1-expected.png: Added.
platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Added.
platform/efl/svg/as-background-image/svg-as-background-3-expected.png: Added.
platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Added.
platform/efl/svg/as-background-image/svg-as-background-4-expected.png: Added.
platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Added.
platform/efl/svg/foreignObject/fO-display-none-expected.txt: Added.
platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
platform/efl/test_expectations.txt:

8:51 AM Changeset in webkit [113323] by schenney@chromium.org

2 edits in trunk/Source/WebCore

REGRESSION(99539): Infinite repaint loop with SVGImage and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315

Reviewed by Dimitri Glazkov.

The existing fix for this issue was failing to check if the frameView object
was currently _in_ layout, in addition to whether it needs layout. Calling the
redraw method while in layout leads to a debug assertion and potential infinite
layout loops. Now we check whether we need layout or are in layout. We also add
a check when the repaint timer fires to ensure we do not call redraw during layout
at that point.

This patch was tested with tens of thousands of runs on layout test cases that
previously crashed at a rate of about 1 in 25. Now we see no crashes and no test
failures.

No new tests, as this exists to fix flaky existing tests.

svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

8:35 AM Changeset in webkit [113322] by schenney@chromium.org

13 edits
8 adds
5 deletes in trunk/LayoutTests

Rebaseline after 73643
https://bugs.webkit.org/show_bug.cgi?id=73643

Unreviewed update of test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-05

platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Removed.
platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Modified property svn:mime-type.
platform/chromium-mac/svg/clip-path/clipper-placement-issue-expected.png: Added.
platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
platform/chromium-mac/svg/filters/feDropShadow-expected.png: Modified property svn:mime-type.
platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
platform/chromium-win/svg/clip-path/clipper-placement-issue-expected.png: Added.
platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
platform/chromium-win/svg/filters/feDropShadow-expected.png: Modified property svn:mime-type.
platform/chromium/test_expectations.txt:

8:32 AM Changeset in webkit [113321] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] WK1/WK2 layout test results are diverging
https://bugs.webkit.org/show_bug.cgi?id=82720

The resolving of default font families was altered in Qt5.
This directly affects the font picked by DRT for layout
tests. Since we want to keep the Qt4 and Qt5 results in line,
we can trick DRT in picking the same font as before for now.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2012-04-05
Reviewed by Csaba Osztrogonác.

DumpRenderTree/qt/QtInitializeTestFonts.cpp:

(WebKit::initializeTestFonts):

7:44 AM Changeset in webkit [113320] by keishi@webkit.org

3 edits
2 adds in trunk

Hide datalist element
https://bugs.webkit.org/show_bug.cgi?id=82874

Source/WebCore:

The datalist element should be hidden when ENABLE_DATALIST is on.

Reviewed by Kent Tamura.

Tests: fast/forms/datalist/datalist-fallback-content-expected.html

fast/forms/datalist/datalist-fallback-content.html

css/html.css:

(datalist): Added display:none.

LayoutTests:

Reviewed by Kent Tamura.

fast/forms/datalist/datalist-fallback-content-expected.html: Added.
fast/forms/datalist/datalist-fallback-content.html: Added. Tests that fallback content is hidden.

6:49 AM Changeset in webkit [113319] by wjmaclean@chromium.org

2 edits in trunk/Source/WebCore

Adjust max bisection search iterations for TouchpadFlingGestureCurve.
https://bugs.webkit.org/show_bug.cgi?id=83166

Reviewed by James Robinson.

Covered by existing tests.

platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore):

6:25 AM Changeset in webkit [113318] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch FileSystem, Profiler and Worker domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=83069

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-05
Reviewed by Yury Semikhatsky.

Domains are switched to 'strict' mode. However, hardly any changes were needed in C++ code because
only basic types are currently used in Inspector.json.

inspector/CodeGeneratorInspector.py:
inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

5:49 AM Changeset in webkit [113317] by leviw@chromium.org

3 edits in trunk/Source/WebCore

DOM measurement APIs should operate on pixel snapped values.
https://bugs.webkit.org/show_bug.cgi?id=83138

Reviewed by Julien Chaffraix.

DOM measurement APIs return unscaled integers. In an effort to return the best possible values (and
most consistent with current behavior) when we use sub-pixel values for Layout, we want to adjust
the actual on-screen position and size values for scaling, not the sub-pixel values.

No new tests. No change in behavior.

dom/Element.cpp:

(WebCore::adjustForLocalZoom): Needs to return an integer, since this is what the DOM API calls for.
(WebCore::Element::offsetWidth): Using pixel snapped values for all the following functions.
(WebCore::Element::offsetHeight):
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):

5:32 AM Changeset in webkit [113316] by pfeldman@chromium.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] clean up WDTFC::saveAs after migration to save()
https://bugs.webkit.org/show_bug.cgi?id=83271

Reviewed by Yury Semikhatsky.

public/WebDevToolsFrontendClient.h:

5:22 AM Changeset in webkit [113315] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: add ability to copy resource URL from web inspector's resources page.
https://bugs.webkit.org/show_bug.cgi?id=83175

Reviewed by Yury Semikhatsky.

Added requested context menu item.

inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

5:19 AM Changeset in webkit [113314] by caseq@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: display frame duration instead of time ruler in Timeline panel's frame mode
https://bugs.webkit.org/show_bug.cgi?id=83184

Reviewed by Pavel Feldman.

inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController): Maintain reference to TimelinePresentationModel
(WebInspector.TimelineFrameController.prototype._flushFrame): Report frames to TimelinePresentationModel (only real ones)

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.removeDividers): remove time marks/labels from upper time ruler

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._updateEventDividers): Updated call site of createEventDivider

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelinePanel.prototype._updateFrames): Frame bars rendering logic.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords): Do not keep frames in the panel any more.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh): Moved updateDividers() call here...
(WebInspector.TimelinePanel.prototype._refreshRecords): ... from here.

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.createEventDivider): Use type & title, not entire record.
(WebInspector.TimelinePresentationModel.prototype.frames): Maintain frames in the TimelinePresentationModel.
(WebInspector.TimelinePresentationModel.prototype.reset): ditto.
(WebInspector.TimelinePresentationModel.prototype.addFrame): ditto.
(WebInspector.TimelinePresentationModel.Record): Fix title for timestamp events (drive by).

inspector/front-end/timelinePanel.css:

(.timeline-frame-strip):

4:56 AM Changeset in webkit [113313] by Patrick Gansterer

5 edits in trunk/Source

[WinCE] Remove unnecessary function decleration
https://bugs.webkit.org/show_bug.cgi?id=83155

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

runtime/JSDateMath.cpp:

Source/WTF:

wtf/DateMath.cpp:
wtf/Platform.h:

4:50 AM Changeset in webkit [113312] by morrita@google.com

5 edits in trunk/Source/WebCore

IsCommentNode flags is a waste.
https://bugs.webkit.org/show_bug.cgi?id=83251

Reviewed by Ryosuke Niwa.

Effectively nobody uses it. To save a precious NodeFlags bit, this
change removes NodeFlags::IsCommentFlag and its companion mehtod
Node::isCommentNode().

No new tests. No behaviour change.

dom/CharacterData.h:

(WebCore::CharacterData::CharacterData):

dom/Comment.cpp:

(WebCore::Comment::Comment):

dom/Node.h:
rendering/RenderTreeAsText.cpp:

(WebCore::getTagName):
This was the only client of Node::isCommentNode(). Replaced it with nodeType() call.

4:45 AM Changeset in webkit [113311] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt][WK2] Skip tests that still failing after implementing layoutTestController.setPageVisibility()
https://bugs.webkit.org/show_bug.cgi?id=83263
[Qt] Moving already skipped test to right place and skip new SHADOW_DOM test.
https://bugs.webkit.org/show_bug.cgi?id=82607

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-05
Reviewed by Csaba Osztrogonác.

platform/qt-5.0-wk2/Skipped:
platform/qt/Skipped:

3:58 AM Changeset in webkit [113310] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][DRT] Remove layer-related passing tests from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83262

Unreviewed gardening

Fixing test expectations file - some of these cases already pass.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-05

platform/efl/test_expectations.txt:

3:52 AM Changeset in webkit [113309] by commit-queue@webkit.org

5 edits
1 add in trunk

[BlackBerry] Clear local storage won't take effect until browser exit and relaunch
https://bugs.webkit.org/show_bug.cgi?id=83253

Patch by Jonathan Dong <Jonathan Dong> on 2012-04-05
Reviewed by Rob Buis.

RIM PR: #146871
Added a manual test case to test the behavior when press
button "Clear Local Storage" from browser settings.
It has to be a manual test as it requires user interaction.

ManualTests/blackberry/clear-localstorage.html: Added.

Source/WebKit/blackberry:

RIM PR: #146871
Cleared the local storage namespace of a WebPage's PageGroup
when WebPage::clearLocalStorage() get called.
Also deleted unused global function clearLocalStorage().

Api/BlackBerryGlobal.cpp:
Api/BlackBerryGlobal.h:

(WebKit):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::clearLocalStorage):

3:41 AM Changeset in webkit [113308] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Layout Test fast/text/international/font-fallback-to-common-script.html has flaky image results on all Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=81544

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-04-05
Reviewed by Kent Tamura.

Skip embed-bidi-style-in-isolate-crash.html, which seems to cause the
subsequent layout test to fail (bug https://bugs.webkit.org/show_bug.cgi?id=83260).

platform/chromium/test_expectations.txt:

3:14 AM Changeset in webkit [113307] by hans@chromium.org

4 edits in trunk/Source

webkit_unit_tests build fix.
https://bugs.webkit.org/show_bug.cgi?id=83261

Unreviewed, webkit_unit_tests buildfix.

The CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread test
stopped working after r113254.

Disable it for now.

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF):
(WTF::TEST_F):

3:10 AM Changeset in webkit [113306] by tkent@chromium.org

1 edit
2 deletes in trunk/LayoutTests

[Chromium] Remove a wrong expectation file for hebrew-vowels.html.
https://bugs.webkit.org/show_bug.cgi?id=81544

platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.txt: Removed.
platform/chromium-mac/fast/text/international/hebrew-vowels-expected.txt: Removed.

2:30 AM WebKitEFLLayoutTest edited by dominik.rottsches@intel.com

changing deprecated flags, removing process count (done automatically) (diff)

2:25 AM Changeset in webkit [113305] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
https://bugs.webkit.org/show_bug.cgi?id=83137

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-04-05
Reviewed by Kentaro Hara.

fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
function object like this, "this[testsList[testCounter++]]();". I'm not familiar
with JavaScript and V8, but in my understanding, it looks a bit strange.
'this' in the statement means runNextTest function object which doesn't have
testList array object. (It's a global scope variable.) This test might be able to
pass on V8 JS engine, but not on JSC at least my try.
'testsList' is changed from a function name array to a function array.

fast/filesystem/script-tests/flags-passing.js:

(runNextTest):

2:13 AM Changeset in webkit [113304] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update after r113292.

platform/gtk/test_expectations.txt:

2:08 AM Changeset in webkit [113303] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r113279

platform/qt/Skipped: Skip a new failing test because ENABLE(MUTATION_OBSERVERS) is disabled.

1:58 AM Changeset in webkit [113302] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=82607
Skip V8 specific test that currently not supported on Qt bots

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-05

platform/qt/Skipped: fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html

1:53 AM Changeset in webkit [113301] by jochen@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Only shut down V8 if we actually initialized it
https://bugs.webkit.org/show_bug.cgi?id=83159

Reviewed by Pavel Feldman.

src/WebKit.cpp:

(WebKit::initialize):
(WebKit::shutdown):

1:47 AM Changeset in webkit [113300] by commit-queue@webkit.org

4 edits in trunk

[EFL] keycode translation is wrong for function keys
https://bugs.webkit.org/show_bug.cgi?id=82738

Source/WebCore:

This patch fixes keycode translation for function keys.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-05
Reviewed by Philippe Normand.

Test: fast/events/keydown-function-keys.html

platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createWindowsKeyMap):

LayoutTests:

Unskip fast/events/keydown-function-keys.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-05
Reviewed by Philippe Normand.

platform/efl/Skipped:

1:19 AM FeatureFlags edited by tkent@chromium.org

Add CALENDAR_PICKER (diff)

1:18 AM Changeset in webkit [113299] by Nikolas Zimmermann

19 edits in trunk

Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Source/WebCore:

Work-around entity expansion bug that affects several SVG tests on Lion.

Sample test document which is currently broken:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-W3CDTD SVG 1.1 BasicEN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd" [
<!ENTITY Smile "<rect x='.5' y='.5' width='29' height='39' fill='black' stroke='red'/>">
]>

The expanded rect carries no namespace, thus an Element will be created for it, instead of a SVGRectElement.
libxml2 2.7.4 fixed this bug (https://bugzilla.gnome.org/show_bug.cgi?id=502960) in 2009 already, but Lion
still ships with 2.7.3, so we need to find a work-around for the problem. It works like this:

When an entity is requested (getEntityHandler) determine whether the entity is being declared (while the <!ENTITY.. parses) or wheter its references (when the &Smile; is parsed). If its referenced, record the current depth of the libxml2 parser.
When startElementNs is called while we're expanding entities, be sure to transfer the namespace of the parent node to the new node, but only do this if the current depth() is greater than the depth() at the time where entity expansion started. This way we only apply our workaround for elements inside entities, that get expanded at the insertion point.
When endElementNs is called, and our current depth() is less than our equal to the depth() where entity expansion started, clear the recorded detph(), and stop executing the workaround.

It requires storing an extra integer & boolean in XMLDocumentParser, which is only used for this work-around.

xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):
(WebCore::XMLDocumentParser::isParsingEntityDeclaration):
(WebCore::XMLDocumentParser::setIsParsingEntityDeclaration):
(WebCore::XMLDocumentParser::depthTriggeringEntityExpansion):
(WebCore::XMLDocumentParser::setDepthTriggeringEntityExpansion):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::hackAroundLibXMLEntityParsingBug):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::entityDeclarationHandler):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):

LayoutTests:

Unskip several test on Lion, now that the libxml2 bug doesn't affect us anymore.

platform/mac-lion/Skipped:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
platform/mac/svg/custom/viewbox-syntax-expected.png:
platform/mac/svg/custom/viewbox-syntax-expected.txt:
platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

12:30 AM Changeset in webkit [113298] by tkent@chromium.org

3 edits
4 adds in trunk

Add JavaScript and CSS code for the calendar picker implementation
https://bugs.webkit.org/show_bug.cgi?id=83011

Reviewed by Hajime Morita.

ManualTests/forms/calendar-picker.html: Added.

Source/WebCore:

Add calendarPicker.js and calendarPicker.css, and add a build rule to
generate a C++ file. This change doesn't make any behavior change
because the code is wrapped by ENABLE(CALENDAR_PICKER).

Tests: ManualTests/forms/calendar-picker.html

Resources/calendarPicker.css: Added.
Resources/calendarPicker.js: Added.
WebCore.gyp/WebCore.gyp: Generate CalendarPicker.{cpp,h} from calendarPicker.{css,js}.

12:29 AM Changeset in webkit [113297] by kinuko@chromium.org

16 edits
10 adds in trunk

Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
https://bugs.webkit.org/show_bug.cgi?id=82592

Reviewed by David Levin.

Source/WebCore:

For now the method is prefixed thus it is to be exposed as 'webkitGetAsEntry'.

The API is proposed and discussed in the following whatwg thread:
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html

Add DataTransferItemFilesystem under Modules/filesystem and implemented the bridging part for chromium.

Test: editing/pasteboard/data-transfer-items-drag-drop-entry.html

Modules/filesystem/DataTransferItemFileSystem.h: Added.

(DataTransferItemFileSystem):

Modules/filesystem/DataTransferItemFileSystem.idl: Added for DataTransferItem.getAsEntry which is only exposed if filesystem is enabled.
Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Added for chromium implementation.
Modules/filesystem/chromium/DataTransferItemFileSystemChromium.h: Added.
Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp: Added.
Modules/filesystem/chromium/DraggedIsolatedFileSystem.h: Added.
WebCore.gypi:
platform/chromium/ChromiumDataObject.cpp:
platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::filesystemId): Added.
(WebCore::ChromiumDataObject::setFilesystemId): Added.

platform/chromium/ClipboardChromium.cpp:

Source/WebKit/chromium:

src/WebDragData.cpp:

(WebKit::WebDragData::filesystemId): Added implementation.
(WebKit::WebDragData::setFilesystemId): Added implementation.

Tools:

Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.

DumpRenderTree/chromium/EventSender.cpp:

(EventSender::beginDragWithFiles):

LayoutTests:

editing/pasteboard/data-transfer-items-drag-drop-entry-expected.txt: Added.
editing/pasteboard/data-transfer-items-drag-drop-entry.html: Added.
editing/pasteboard/resources/test_directory/test.txt: Added.
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

12:21 AM Changeset in webkit [113296] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113279.

platform/gtk/fast/dom/Window/window-properties-expected.txt:

Apr 4, 2012:

11:40 PM Changeset in webkit [113295] by Patrick Gansterer

10 edits in trunk/Source

Add WTF::getCurrentLocalTime()
https://bugs.webkit.org/show_bug.cgi?id=83164

Reviewed by Alexey Proskuryakov.

Replace the calls to WTF::getLocalTime() with time(0) with the new function.
This allows us to use Win32 API on windows to get the same result in a next step.

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/DateConstructor.cpp:

(JSC::callDate):

Source/WebCore:

html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString):

loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

Source/WTF:

Also remove the inline keyword from WTF::getLocalTime(), since there is no need for
it and it will make the later Win32 API changes easier.

WTF.gyp/WTF.gyp:
wtf/CurrentTime.cpp:

(WTF::getLocalTime):
(WTF::getCurrentLocalTime):

wtf/CurrentTime.h:

10:29 PM Changeset in webkit [113294] by hayato@chromium.org

22 edits
4 deletes in trunk

Remove ReifiedTreeTraversal.
https://bugs.webkit.org/show_bug.cgi?id=83110

Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore:

We can now remove ReifiedTreeTraversal. All clients have switched to use ComposedShadowTreeWalker.

No new tests. No change in functionality.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/ReifiedTreeTraversal.cpp: Removed.
dom/ReifiedTreeTraversal.h: Removed.
testing/Internals.cpp:
testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

fast/dom/shadow/reified-tree-traversal-expected.txt: Removed.
fast/dom/shadow/reified-tree-traversal.html: Removed.
platform/efl/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

10:29 PM Changeset in webkit [113293] by rakuco@webkit.org

2 edits in trunk/Source/WebKit/efl

Another unreviewed attempt at getting the EFL build bot to a
healthy state by forcing a rebuild.

ewk/ewk_cookies.h:

10:17 PM Changeset in webkit [113292] by yutak@chromium.org

3 edits in trunk/LayoutTests

Layout Test http/tests/websocket/tests/hybi/workers/worker-reload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83173

Reviewed by David Levin.

Try to deflake the test by

decreasing the number of reloads in the test, and
changing the URL of WebSocket to silence random console messages.

http/tests/websocket/tests/hybi/workers/resources/worker-reload-iframe.html:

Reloading 100 times seemed too much, as Chromium debug bots frequently time out.

http/tests/websocket/tests/hybi/workers/resources/worker-reload.js:

Use a real URL to avoid random console messages.

10:15 PM Changeset in webkit [113291] by dslomov@google.com

2 edits in trunk/Source/WebCore

WorkerEventQueue::close might access deleted WorkerEventQueue::EventDispatcherTask.
https://bugs.webkit.org/show_bug.cgi?id=83202

On closing the event queue, WorkerEventQueue cancels all the tasks associated with events.
The tasks in their turn delete themselves from the map whenever task gets executed.
However if shutdown occurs when task is in queue but before task gets executed, the task will be deleted without execution.
This patch makes sure that no deleted tasks stay in WorkerEventQueue, by task removing itself in destructor.

Reviewed by David Levin.

Covered by existing tests.

workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::EventDispatcherTask::~EventDispatcherTask):
(WorkerEventQueue::EventDispatcherTask):
(WebCore::WorkerEventQueue::EventDispatcherTask::performTask):

10:13 PM Changeset in webkit [113290] by rakuco@webkit.org

2 edits in trunk/Source/WebKit/efl

Unreviewed; touch a file to check if the EFL build bot is back to
normal.

ewk/ewk_cookies.h:

9:30 PM Changeset in webkit [113289] by jchaffraix@webkit.org

3 edits in trunk/Source/WebCore

RenderLayer scrollbars' updates should be split between layout induced and style change induced
https://bugs.webkit.org/show_bug.cgi?id=83213

Reviewed by Simon Fraser.

Refactoring only, no change in behavior.

This patches splits up the 2 reasons for modifying the scrollbars:

style updates, handled in updateScrollbarsAfterStyleChange.
layout time, handled in updateScrollbarsAfterLayout.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsSize):
Removed now unneeded const-casts.

(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
Updated to use hasHorizontalScrollbar / hasVerticalScrollbar.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Made those functions |const|.

(WebCore::RenderLayer::computeScrollDimensions):
Removed the unneeded booleans and move the do-we-have-overflow-logic
into hasHorizontalOverflow and hasVerticalOverflow.

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):
Added those new helper functions.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Updated the latter to call the former.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
(WebCore::RenderLayer::styleChanged):
Ditto.

(WebCore::overflowCanHaveAScrollbar):
Add this helper function for updateScrollbarsAfterStyleChange.

rendering/RenderLayer.h:

(WebCore::RenderLayer::hasHorizontalScrollbar):
(WebCore::RenderLayer::hasVerticalScrollbar):
Added those 2 new helper functions.

9:28 PM Changeset in webkit [113288] by timothy_horton@apple.com

2 edits in trunk/Tools

[mac] WKTR should always keep its windows offscreen
https://bugs.webkit.org/show_bug.cgi?id=83244
<rdar://problem/11188764>

Reviewed by Simon Fraser.

We don't want to allow windows onto the main display; intercept attempts to
change WebKitTestRunnerWindow's frame origin and prevent it from happening.

Also keep around and respond with a new "fake" origin, in case someone is
expecting it to change (I couldn't find any tests that expected this, however).

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow setFrameOrigin:]):
(-[WebKitTestRunnerWindow setFrame:display:animate:]):
(-[WebKitTestRunnerWindow setFrame:display:]):
(-[WebKitTestRunnerWindow frame]):

9:22 PM Changeset in webkit [113287] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.

No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.

dom/Document.cpp:

(WebCore::Document::implicitClose):

page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

9:18 PM Changeset in webkit [113286] by abarth@webkit.org

4 edits
2 adds in trunk

XSSAuditor doesn't catch injected srcdoc attributes
https://bugs.webkit.org/show_bug.cgi?id=83238

Reviewed by Daniel Bates.

Source/WebCore:

Test: http/tests/security/xssAuditor/iframe-srcdoc.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

html/parser/XSSAuditor.h:

LayoutTests:

http/tests/security/xssAuditor/iframe-srcdoc-expected.txt: Added.
http/tests/security/xssAuditor/iframe-srcdoc.html: Added.

9:06 PM Changeset in webkit [113285] by leo.yang@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] Add local: protocol support in KURL for blackberry
https://bugs.webkit.org/show_bug.cgi?id=82695

Reviewed by Rob Buis.

BlackBerry porting is using local: protocol just as file: protocol
with the exception that it sandboxes the path to the application private space.

platform/KURL.cpp:

(WebCore::KURL::parse):
(WebCore::portAllowed):

8:44 PM Changeset in webkit [113284] by Simon Fraser

3 edits
2 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Fix an issue when removing elements with reflections from the document.

Test: compositing/reflections/remove-reflection.html

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::willBeDestroyed):

LayoutTests: REGRESSION(112939): compositing/reflections/backface-hidden-reflection.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=82994

Reviewed by James Robinson.

Test that removes reflected elements.

compositing/reflections/remove-reflection-expected.txt: Added.
compositing/reflections/remove-reflection.html: Added.

8:43 PM Changeset in webkit [113283] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebCore

Need using namespace std for system calls in MIMESniffing.cpp
https://bugs.webkit.org/show_bug.cgi?id=82706

Reviewed by Antonio Gomes.

No new tests, just fix the compile error for BlackBerry porting.

platform/network/MIMESniffing.cpp:

8:36 PM Changeset in webkit [113282] by commit-queue@webkit.org

12 edits in trunk

Switch web intents API to be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=83172

Patch by Greg Billock <gbillock@google.com> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

Modules/intents/DOMWindowIntents.idl:
Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity):

Modules/intents/NavigatorIntents.h:

(NavigatorIntents):

Modules/intents/NavigatorIntents.idl:

LayoutTests:

webintents/resources/web-intents-reload-orig.html:
webintents/resources/web-intents-testing.js:

(startIntentWithCallbacks):

webintents/web-intents-api-expected.txt:
webintents/web-intents-api.html:
webintents/web-intents-invoke.html:

8:08 PM Changeset in webkit [113281] by alexis.menard@openbossa.org

11 edits in trunk/Source/WebCore

[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83224

Reviewed by Tony Chang.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

page/animation/AnimationBase.h:

(WebCore::AnimationBase::affectsProperty):
(WebCore::AnimationBase::isAnimatingProperty):

page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):

page/animation/CompositeAnimation.h:

(CompositeAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::affectsProperty):

page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::transitionProperty):
(WebCore::ImplicitAnimation::animatingProperty):
(ImplicitAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::affectsProperty):

page/animation/KeyframeAnimation.h:

(KeyframeAnimation):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::transitionPaused):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

7:50 PM Changeset in webkit [113280] by tkent@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Calendar Picker: Add localization functions
https://bugs.webkit.org/show_bug.cgi?id=83235

Reviewed by Adam Barth.

Implement calendarTodayText() and calendarClearText(), which are
introduced in http://trac.webkit.org/changeset/113166

public/platform/WebLocalizedString.h:

Add CalendarClear and CalendarToday.

src/LocalizedStrings.cpp:

(WebCore::calendarTodayText): Added.
(WebCore::calendarClearText): Added.

7:50 PM Changeset in webkit [113279] by rafaelw@chromium.org

5 edits
2 adds in trunk

[MutationObservers] implement takeRecords()
https://bugs.webkit.org/show_bug.cgi?id=83218

Reviewed by Ojan Vafai.

Source/WebCore:

This patch implements MutationObserver.takeRecords per the DOM4 spec.
takeRecords retrieves and clears any pending mutation records for
the observer.

Test: fast/mutation/takeRecords.html

dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::takeRecords):
(WebCore):
(WebCore::WebKitMutationObserver::deliver):

dom/WebKitMutationObserver.h:
dom/WebKitMutationObserver.idl:

LayoutTests:

fast/mutation/takeRecords-expected.txt: Added.
fast/mutation/takeRecords.html: Added.

7:42 PM Changeset in webkit [113278] by inferno@chromium.org

2 edits in trunk/LayoutTests

Rebaseline for r113252.

Unreviewed.

platform/qt/fast/css/bidi-override-in-anonymous-block-expected.txt:

7:35 PM Changeset in webkit [113277] by dpranke@chromium.org

2 edits in trunk/Tools

Fix typo introduced in r113271.

Unreviewed, build fix.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader._upload_data.callback):
(FileUploader):

7:28 PM Changeset in webkit [113276] by shinyak@chromium.org

12 edits
2 adds in trunk

Shadow DOM is exposed in JS.
https://bugs.webkit.org/show_bug.cgi?id=82607

Reviewed by Hajime Morita.

Source/autotools/symbols.filter:

Source/WebCore:

DOMSelection didn't consider nested shadow trees. This patch makes DOMSelection
take nested shadow trees into account.

To test that the element is not in a shadow tree, Internals has a treeScopeRootNode method
which returns the root node of the belonging tree scope.

Test: fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html

WebCore.exp.in:
page/DOMSelection.cpp:

(WebCore::selectionShadowAncestor):
(WebCore):

testing/Internals.cpp:

(WebCore::Internals::treeScopeRootNode):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit2:

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests:

fast/dom/shadow/selection-shouldnt-expose-shadow-dom-expected.txt: Added.
fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html: Added.

7:07 PM Changeset in webkit [113275] by hayato@chromium.org

3 edits in trunk/LayoutTests

Update a layout test, adding a case for traversing a ShadowRoot which does not have any children.
https://bugs.webkit.org/show_bug.cgi?id=82593

Reviewed by Dimitri Glazkov.

Prior to r113125, if we traverse a ShadowRoot which does not have any children,
it caused an assertion failure on debug build. r113125 fixed this issue implicitly.
Adds a test case for that to catch a future regression.

fast/dom/shadow/focus-navigation-expected.html:
fast/dom/shadow/focus-navigation.html:

6:57 PM Changeset in webkit [113274] by commit-queue@webkit.org

2 edits in trunk/Tools

[Chromium, DRT] Bounds check indices on gamepadController
https://bugs.webkit.org/show_bug.cgi?id=83192

Invalid test data would cause bad array accesses. Add simple checks to
ignore such invalid data.

Patch by Scott Graham <scottmg@google.com> on 2012-04-04
Reviewed by Kent Tamura.

DumpRenderTree/chromium/GamepadController.cpp:

(GamepadController::connect):
(GamepadController::disconnect):
(GamepadController::setId):
(GamepadController::setButtonCount):
(GamepadController::setButtonData):
(GamepadController::setAxisCount):
(GamepadController::setAxisData):

6:42 PM Changeset in webkit [113273] by macpherson@chromium.org

9 edits in trunk/Source/WebCore

Replace further usage of int with CSSPropertyID.
https://bugs.webkit.org/show_bug.cgi?id=83119

Reviewed by Simon Fraser.

No new tests / no functionality changed.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSGrammar.y:
css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):

css/CSSParser.h:

(CSSParser):
(WebCore::ShorthandScope::~ShorthandScope):

css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

css/StylePropertySet.h:

(StylePropertySet):

css/makeprop.pl:
dom/StyledElement.h:

(StyledElement):

editing/EditingStyle.h:

(EditingStyle):

html/HTMLElement.h:

(HTMLElement):

6:38 PM Changeset in webkit [113272] by adamk@chromium.org

11 edits in trunk/Source/WebCore

Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

Relanding r112163 without modification, as it still seems valid.
Will watch Chrome Canaries closely for any memory issues.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.

bindings/v8/V8Proxy.h:

(WebCore::toV8): Remove explicit ref.

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.

bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): ditto.

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

6:17 PM Changeset in webkit [113271] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

More debugging info and a possible fix - stop messing with the
default network timeout, and don't swallow URLErrors.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader._upload_data):

Scripts/webkitpy/common/net/networktransaction.py:

(NetworkTransaction.run):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

5:56 PM Changeset in webkit [113270] by oliver@apple.com

5 edits in trunk

Parser fails to revert some state after parsing expression and object literals.
https://bugs.webkit.org/show_bug.cgi?id=83236

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Reset left hand side counter after parsing the literals.

parser/Parser.cpp:

(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):

LayoutTests:

Add more parser test cases.

fast/js/parser-syntax-check-expected.txt:
fast/js/script-tests/parser-syntax-check.js:

5:48 PM Changeset in webkit [113269] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG InstanceOf should not uselessly speculate cell
https://bugs.webkit.org/show_bug.cgi?id=83234

Reviewed by Oliver Hunt.

If InstanceOf is the only user of its child then don't speculate cell, since
the not-cell case is super easy to handle.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInstanceOf):

5:14 PM Changeset in webkit [113268] by crogers@google.com

2 edits in trunk/Source/WebCore

WaveTable::waveDataForFundamentalFrequency() should properly interpret negative frequency
https://bugs.webkit.org/show_bug.cgi?id=83228

Reviewed by Kenneth Russell.

Modules/webaudio/WaveTable.cpp:

(WebCore::WaveTable::waveDataForFundamentalFrequency):

5:05 PM Changeset in webkit [113267] by adamk@chromium.org

5 edits
2 adds in trunk

Delay post-insertion notifications until new DOM tree is complete
https://bugs.webkit.org/show_bug.cgi?id=82631

Reviewed by Ojan Vafai.

Source/WebCore:

When inserting a DocumentFragment, WebKit previously would update both
internal WebCore state and mutation event listeners after each node
was inserted. This is inconsistent not only with DOM4, but also
with (at least) Firefox and IE. Given the many bugs over the years in
WebKit due to this behavior, it seems better to delay notification
until the fragment is completely inserted.

The changes to the three core mutation methods below are similar:
the only logic remaining in the loop is checking that insertion is
possible and taking care of that insertion. The entire loop is then
wrapped in forbidEventDispatch/allowEventDispatch, effectively
asserting that none of the code inside will have side effects.

The one bit of logic added to the loop is resizing the targets
vector down to the set of nodes actually inserted as part of the
loop. This makes it possible to simply pass the vector on to
notifyChildrenInserted without having to also pass along a count of
actually-inserted nodes.

As for the code that used to live inside the loop that could have
side-effects, or depended on those side-effects, it has been moved
out, either above (the check that the refChild is still valid in
insertBefore) or after (the calls to notifyChildrenInserted).

Finally, it was necessary to retrofit ChildListMutationScope to take a
vector of added nodes instead of a single node at a time, due to the
assertions in isAddedNodeInOrder (now renamed to be plural). Note that
there is now a single call to ChildListMutationScope::childrenAdded,
inside notifyChildrenInserted.

Test: fast/events/domnodeinserted-entire-fragment.html

dom/ChildListMutationScope.cpp:

(ChildListMutationScope::MutationAccumulator): Renamed method to be plural.
(WebCore::ChildListMutationScope::MutationAccumulator::areAddedNodesInOrder): Handle a NodeVector instead of a Node.
(WebCore::ChildListMutationScope::MutationAccumulator::childrenAdded): Handle adding a NodeVector instead of a Node.
(WebCore::ChildListMutationScope::MutationAccumulationRouter::childrenAdded): Renamed to be plural, pass NodeVector through.

dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::childrenAdded): ditto.
(MutationAccumulationRouter):

dom/ContainerNode.cpp:

(WebCore): Renamed updateTreeAfterInsertion to notifyChildrenInserted.
(WebCore::ContainerNode::insertBefore): See main ChangeLog explanation.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.
(WebCore::dispatchChildInsertionEvents): Remove MutationObserver handling.
(WebCore::notifyChildrenInserted): Handle a NodeVector of all inserted children,
and take on responsiblity for MutationObserver handling as well as dispatchSubtreeModifiedEvent.

LayoutTests:

fast/events/domnodeinserted-entire-fragment-expected.txt: Added.
fast/events/domnodeinserted-entire-fragment.html: Added.

5:03 PM Changeset in webkit [113266] by crogers@google.com

5 edits in trunk

RealtimeAnalyserNode should support smaller analysis sizes
https://bugs.webkit.org/show_bug.cgi?id=83215

Source/WebCore:

Reviewed by Kenneth Russell.

RealtimeAnalyserNode analysis size currently goes no lower than 128.
It is useful to support lower power-of-two sizes.
Decrease this limit to 32.

Updated webaudio/realtimeanalyser-fft-sizing-expected.txt

Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore):

LayoutTests:

Reviewed by Kenneth Russell.

webaudio/realtimeanalyser-fft-sizing-expected.txt:
webaudio/realtimeanalyser-fft-sizing.html:

5:00 PM Changeset in webkit [113265] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Unify and modernize fast/css/{outline,background}-currentcolor.html
https://bugs.webkit.org/show_bug.cgi?id=75523

Patch by David Barr <davidbarr@chromium.org> on 2012-04-04
Reviewed by Daniel Bates.

Use js-test-pre utility functions instead of hardcoded testing logic
to simplify the test code and make the test more closely conform to
the visual appearance of other PASS/FAIL tests.

fast/css/background-currentcolor-expected.txt:
fast/css/background-currentcolor.html:
fast/css/outline-currentcolor-expected.txt:
fast/css/outline-currentcolor.html:

4:57 PM Changeset in webkit [113264] by tony@chromium.org

3 edits
2 adds in trunk

CSS transitions should work on the flex property
https://bugs.webkit.org/show_bug.cgi?id=75915

Reviewed by Dean Jackson.

Source/WebCore:

Test: transitions/flex-transitions.html

page/animation/AnimationBase.cpp:

(WebCore::PropertyWrapperGetter::equals): Fix indention.
(PropertyWrapperFlex): Add a wrapper for -webkit-flex which has 3 values (two floats and
a length), but is not a shorthand.
(WebCore::PropertyWrapperFlex::PropertyWrapperFlex):
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):
(WebCore):
(WebCore::AnimationBase::ensurePropertyMap):

LayoutTests:

transitions/flex-transitions-expected.txt: Added.
transitions/flex-transitions.html: Added.

4:54 PM Changeset in webkit [113263] by tsepez@chromium.org

3 edits
2 adds in trunk

XSSAuditor bypass through HTTP Parameter Pollution.
https://bugs.webkit.org/show_bug.cgi?id=81283

Reviewed by Adam Barth.

Source/WebCore:

Deal with concatenation of multiple parameters via comma-splicing that
is common to some webservers. We can no longer trust that all of the
attributes of a reflected script tag, nor the reflected script itself,
came from the same single URL parameter. The fix is to take commas into
account when trucating the snippet used for matching.

Test: http/tests/security/xssAuditor/script-tag-with-comma.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterScriptToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-comma.html: Added.

4:50 PM Changeset in webkit [113262] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Fixed minor error: "& 3" should be "& 2".

Rubber-stamped by Oliver Hunt.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

4:28 PM Changeset in webkit [113261] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Text input doesn't work for some Flash forms
https://bugs.webkit.org/show_bug.cgi?id=83232
<rdar://problem/11186162>

Reviewed by Alexey Proskuryakov.

If a plug-in is instantiated when the WKView is not focused, text input wouldn't work. The reason for this
is that WebPage::windowIsFocused() would only return true if the window and the WKView are both focused. Rename
this member function to windowAndWebPageAreFocused, add a new windowIsFocused member function that does the right thing
and change WebPage::focusedWebPage to use windowAndWebPageAreFocused.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowIsFocused):
(WebKit):
(WebKit::WebPage::windowAndWebPageAreFocused):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::focusedWebPage):

4:23 PM Changeset in webkit [113260] by mitz@apple.com

2 edits in trunk/Source/WebCore

Paginated webviews render nothing in their gutters
https://bugs.webkit.org/show_bug.cgi?id=83231

Reviewed by Adele Peterson.

When the RenderView has columns, nothing draws in the gutters.

page/FrameView.cpp:

(WebCore::FrameView::paintContents): Paint the background color behind everything when
paginated.

4:17 PM Changeset in webkit [113259] by Dimitri Glazkov

1 edit
59 adds in trunk/LayoutTests

[Chromium] Update expectations for Leopard.

platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds: Added.
platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Added.

4:10 PM Changeset in webkit [113258] by tony@chromium.org

3 edits
3 deletes in trunk/LayoutTests

inline script for flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=83220

Reviewed by Ojan Vafai.

Inline the .js test files into the .html files. These tests don't need
to be in a separate file.

css3/flexbox/css-properties.html:
css3/flexbox/display-flexbox-set-get.html:
css3/flexbox/resources/display-flexbox-set-get.js: Removed.
css3/flexbox/script-tests/TEMPLATE.html: Removed.
css3/flexbox/script-tests/css-properties.js: Removed.

4:06 PM Changeset in webkit [113257] by inferno@chromium.org

2 edits in trunk/LayoutTests

Rebaseline for r113252.

Unreviewed.

platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt:

4:01 PM Changeset in webkit [113256] by dpranke@chromium.org

4 edits in trunk/Tools

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.upload_json_files):

3:55 PM Changeset in webkit [113255] by commit-queue@webkit.org

7 edits in trunk/Source

Call histogramEnumeration directly
https://bugs.webkit.org/show_bug.cgi?id=83106

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Part of a refactoring project to remove the PlatformSupport
abstraction from some functions. See bug 82948.

Source/WebCore:

bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::histogramEnumeration):

platform/chromium/HistogramSupportChromium.cpp:

(WebCore::HistogramSupport::histogramEnumeration):

platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

src/PlatformSupport.cpp:

(WebCore):

3:53 PM Changeset in webkit [113254] by zmo@google.com

2 edits in trunk/Source/WebCore

2012-04-04 Zhenyao Mo <zmo@google.com>

Unreviewed, GPU bots build fix.

Commited on behalf of sievers@chromium.org.

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::canDraw):

3:42 PM Changeset in webkit [113253] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Constant Blinding for add/sub immediate crashes in ArmV7 when dest is SP
https://bugs.webkit.org/show_bug.cgi?id=83191

Reviewed by Oliver Hunt.

Make are that blinded constant pairs are similarly aligned to the
original immediate values so that instructions that expect that
alignment work correctly. One example is ARMv7 add/sub imm to SP.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::add): Added ASSERT that immediate is word aligned.
(JSC::ARMv7Assembler::sub): Added ASSERT that immediate is word aligned.
(JSC::ARMv7Assembler::sub_S): Added ASSERT that immediate is word aligned.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::additionBlindedConstant):

3:41 PM Changeset in webkit [113252] by inferno@chromium.org

17 edits in trunk

Add helpers to create anonymous table parts.
https://bugs.webkit.org/show_bug.cgi?id=83116

Reviewed by Julien Chaffraix.

Source/WebCore:

The patch introduces helpers to create anonymous table parts by
introducing a new static function createAnonymousWithParentRenderer.
The function builds a new anonymous wrapper of the same type as the class,
inheriting style properties from parent and sets a display based on
argument/default values. Also we streamline the RenderBlock functions
to match this naming convention.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousBlockWithSameTypeAs):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRendererAndDisplay):

rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::createAnonymousBlock):
(WebCore::RenderBlock::createAnonymousColumnsBlock):
(WebCore::RenderBlock::createAnonymousColumnSpanBlock):

rendering/RenderButton.cpp:

(WebCore::RenderButton::addChild):

rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):
(WebCore::RenderTable::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTable.h:

(RenderTable):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTableCell.h:

(RenderTableCell):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild):
(WebCore::RenderTableRow::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTableRow.h:

(RenderTableRow):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::createAnonymousWithParentRendererAndDisplay):
(WebCore):

rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Rebaselining tests because we now correctly inherit the bidi override.

platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:

3:36 PM Changeset in webkit [113251] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for fast/text/international/spaces-combined-in-vertical-text.html

platform/chromium/test_expectations.txt: Tweaked some more.

3:30 PM Changeset in webkit [113250] by arv@chromium.org

14 edits
6 adds in trunk

[V8] Add a per context data store and use that for caching boiler plates as well as constructor functions
https://bugs.webkit.org/show_bug.cgi?id=83093

Reviewed by Adam Barth.

Source/WebCore:

This introduces a V8BindingPerContextData class. After creating a new v8::Context we also create a new
per context data instance. This instance maintains the boiler plate and constructor caches. V8DOMWrapper
now delegates the caching to this new class. Previously the caching was only done in V8DOMWindowShell which
made workers and isolated worlds behave slightly different.

Tests: fast/dom/constructor-proto.html

fast/workers/constructor-proto.html

WebCore.gypi:
bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorGetter): Renamed getConstructor to constructorForType.

bindings/v8/V8BindingPerContextData.cpp: Added.

(WebCore):
(WebCore::V8BindingPerContextData::dispose): This clears the persistent handles stored in the maps.
(WebCore::V8BindingPerContextData::init): This installs the hidden prototype which is used as the
Prototype for the constructor functions (for HotMail compat).
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase): Instantiates a new object and
stores it in the boilerplate map, and returns a clone.
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): Creates the function for the constructor
and stores it in the constructor map.

bindings/v8/V8BindingPerContextData.h: Added.

(WebCore):
(V8BindingPerContextData):
(WebCore::V8BindingPerContextData::create):
(WebCore::V8BindingPerContextData::~V8BindingPerContextData):
(WebCore::V8BindingPerContextData::createWrapperFromCache): Checks the cache and clones the wrapper in
the cache. If no boiler plate exists one is created and cached.
(WebCore::V8BindingPerContextData::constructorForType): If the constructor already exists the cached
constructor function is returned, otherwise a new constructor function is created and cached.
(WebCore::V8BindingPerContextData::V8BindingPerContextData):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::disposeContextHandles): Clear the per context data when disposing the handles.
(WebCore::V8DOMWindowShell::initContextIfNeeded): Create and initialize the per context data.
(WebCore::V8DOMWindowShell::installDOMWindow):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::perContextData):

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::constructorForType): Static method to get the constructor. The per context data
is determined based on the type of the parameters.
(WebCore):
(WebCore::V8DOMWrapper::perContextData):
(WebCore::V8DOMWrapper::instantiateV8Object): Use the per context data to unify the code paths.

bindings/v8/V8DOMWrapper.h:

(WebCore):
(V8DOMWrapper):

bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext): Create and initialize the per context data.
(WebCore::V8IsolatedContext::destroy): Clear the per context data.

bindings/v8/V8IsolatedContext.h:

(WebCore):
(WebCore::V8IsolatedContext::perContextData):
(V8IsolatedContext):

bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrievePerContextData):
(WebCore):

bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::dispose): Clear the per context data
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Create and initialize the per context data.

bindings/v8/WorkerContextExecutionProxy.h:

(WebCore):
(WebCore::WorkerContextExecutionProxy::perContextData):
(WorkerContextExecutionProxy):

LayoutTests:

fast/dom/constructor-proto-expected.txt: Added.
fast/dom/constructor-proto.html: Added.
fast/workers/constructor-proto-expected.txt: Added.
fast/workers/constructor-proto.html: Added.

3:28 PM Changeset in webkit [113249] by jsbell@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, updating expected test output for a test already marked FAIL.
Replace dummy output with real expected output to unblock Chromium-side test.

storage/indexeddb/dont-commit-on-blocked-expected.txt:

3:23 PM Changeset in webkit [113248] by shawnsingh@chromium.org

7 edits in trunk/Source

[chromium] Move recursive renderSurface clearing to CCLayerTreeHostImpl
https://bugs.webkit.org/show_bug.cgi?id=82091

Reviewed by James Robinson.

Source/WebCore:

No new tests needed, minor refactoring covered by existing tests.

This patch is just a minor cleanup, moving clearRenderSurfacesOnCCLayerImplRecursive()
from LayerRendererChromium to CCLayerTreeHostImpl. It makes more sense to place the code
there, so that LayerRendererChromium is more like a blind utility for drawing things
while CCLayerTreeHostImpl actually manages the state of the resources.

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::sendDidLoseContextRecursive):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::rootLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):

3:23 PM Changeset in webkit [113247] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for accessibility/aria-checkbox-sends-notification.html.

platform/chromium/test_expectations.txt: Tweaked expectations.

3:19 PM Changeset in webkit [113246] by eae@chromium.org

1038 edits
503 copies
31 deletes in branches/subpixellayout

Merge trunk changes up until 113241 into subpixel branch.

3:13 PM Changeset in webkit [113245] by crogers@google.com

9 edits in trunk/Source

Web Audio should use MutexTryLocker class
https://bugs.webkit.org/show_bug.cgi?id=83194

Reviewed by Kenneth Russell.

Source/WebCore:

Switch existing Web Audio code from directly calling tryLock() on a Mutex to use a MutexTryLocker.
No new tests since it is a low-level threading primitive and is difficult to test.
Existing Web Audio tests continue to test the process() methods affected.

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRange):

Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::process):

Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::process):

Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::process):

Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::process):

Source/WTF:

Add MutexTryLocker class which can be used as a stack-based object wrapping a Mutex.
It will automatically unlock the Mutex in its destructor if the tryLock() succeeded.

wtf/ThreadingPrimitives.h:

(MutexTryLocker):
(WTF::MutexTryLocker::MutexTryLocker):
(WTF::MutexTryLocker::~MutexTryLocker):
(WTF::MutexTryLocker::locked):
Check if the tryLock() on the Mutex succeeded.
(WTF):

3:06 PM Changeset in webkit [113244] by rakuco@webkit.org

3 edits in trunk/Source/WebCore

[CSS] Make makevalues.pl and makeprop.pl ignore '#'s.
https://bugs.webkit.org/show_bug.cgi?id=83212

Reviewed by Tony Chang.

This patch is a side-effect of my intentions to make the
CMake-based ports work with GCC 4.7 without changing the
parameters currently passed to the preprocessor. "-P" is always
being passed to the preprocessor, but this breaks
dom/make_names.pl due to GCC not outputting empty lines with "-P"
anymore; if I switch to never passing "-P" (my aim), the CSS
scripts currently break because of the additional lines output by
the preprocessor. InFilesParser.pm and make-css-file-array.pl
already skip lines which start with '#', for example.

No new tests, tools plumbing.

css/makeprop.pl:
css/makevalues.pl:

2:48 PM Changeset in webkit [113243] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Disable fancy upsampling and dithering for decoding jpeg on android
https://bugs.webkit.org/show_bug.cgi?id=83196

Patch by Min Qin <qinmin@google.com> on 2012-04-04
Reviewed by Kenneth Russell.

Dithering and fancy upsampling are currently disabled for chrome on android.
This gives us about 20% performance improvement.
Since the screen of mobile devices is small, impact on image quality is limited.
This change does not introduce any changes on other platforms.

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(ditherMode):
(doFancyUpsampling):
(WebCore::JPEGImageReader::decode):

2:40 PM WebKit Team edited by Antti Koivisto

(diff)

2:36 PM Changeset in webkit [113242] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark fonts/cursive.html as flaky on LION.

platform/chromium/test_expectations.txt: Marked as flaky.

2:33 PM WebKit Team edited by kling@webkit.org

(diff)

2:27 PM Changeset in webkit [113241] by commit-queue@webkit.org

7 edits in trunk/Source

[Chromium] Always skip draw and readback if there is nothing
to draw.
https://bugs.webkit.org/show_bug.cgi?id=82680

This avoids corruption from pushing frames that have no valid
content drawn into them.
Also in addition to checking for non-existing root layers, check
for root layers with no content bounds. It's possible to see those
with kForceCompositing mode for empty documents.

Patch by Daniel Sievers <sievers@chromium.org> on 2012-04-04
Reviewed by James Robinson.

Added CCLayerTreeHostTestEmptyContentsShouldNotDraw.

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF):
(CCLayerTreeHostTestEmptyContentsShouldNotDraw):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::CCLayerTreeHostTestEmptyContentsShouldNotDraw):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::beginTest):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestEmptyContentsShouldNotDraw::afterTest):
(WTF::TEST_F):

2:14 PM Changeset in webkit [113240] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG should short-circuit Branch(LogicalNot(...))
https://bugs.webkit.org/show_bug.cgi?id=83181

Reviewed by Geoff Garen.

Slight (sub 1%) speed-up on V8.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

2:12 PM Changeset in webkit [113239] by Beth Dakin

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=83207
platform/mac/fast/forms/input-list-button-size.html fails on the Mac bots after
r11317

This test is expected to fail now that datalist is disabled.

platform/mac/Skipped:

2:11 PM Changeset in webkit [113238] by jer.noble@apple.com

15 edits in trunk/Source

Full Screen mode should cancel before navigation.
https://bugs.webkit.org/show_bug.cgi?id=81295

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; protect against speculative crasher when a bad client calls the below
functions at inopportune times.

Check that the document is not either detached or in the page cache, and if so, bail out
early:

dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

Source/WebKit/mac:

When a provisional load is started, if the page is currently in full screen mode, instruct
the full screen controller to close the full screen window immediately.

WebView/WebFullScreenController.h:
WebView/WebFullScreenController.mm:

(-[WebFullScreenController isFullScreen]): Added.

WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if

present and in full screen mode.

Source/WebKit2:

When a provisional load is started, if the page is currently in full screen mode, instruct
the full screen controller to close the full screen window immediately.

Close the full screen window controller, if present and in full screen mode:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add boilerplate to support passing through isFullScreen() and close() methods from the WebPageProxy
to the WKFullScreenWindowController:

UIProcess/WebFullScreenManagerProxy.h:
UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController isFullScreen]): Added simple accessor.

UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::close): Pass through to the WKFullScreenWindowController.
(WebKit::WebFullScreenManagerProxy::isFullScreen): Ditto.

2:06 PM Changeset in webkit [113237] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Adjust expectations for fast/text/international/spaces-combined-in-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=82669

platform/chromium/test_expectations.txt: Tweaked expectations.

2:06 PM Changeset in webkit [113236] by eae@chromium.org

2 edits in trunk/Source/WebCore

Fix getFilterOutsets parameter types in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=83041

Reviewed by Julien Chaffraix.

The getFilterOutsets method was changed to take integers in r112475, update
RenderLayer to use the right data type for the outset arguments.

No new tests, no change in functionality.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::calculateLayerBounds):

1:51 PM Changeset in webkit [113235] by commit-queue@webkit.org

14 edits in trunk

WKTR needs to implement layoutTestController.setPageVisibility()
https://bugs.webkit.org/show_bug.cgi?id=69554

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-04-04
Reviewed by Simon Fraser.

Source/WebKit2:

This patch implements the setPageVisibilityState through InjectedBundle
so WKTR supports the Page Visibility API and can set the visibility state
directly to Page.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPageVisibilityState):

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit):
(WebKit::InjectedBundle::setPageVisibilityState):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

This patch implements the layoutTestController.setPageVisibility
so WKTR supports the Page Visibility API implementation by using InjectedBundle
to set the visibility state directly to Page.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):
(WTR):
(WTR::LayoutTestController::resetPageVisibility):

WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

platform/wk2/Skipped: Unskipping compositing/video-page-visibility.html

1:47 PM Changeset in webkit [113234] by arv@chromium.org

5 edits in trunk/Source/WebCore

Rebaseline binding tests.

Unreviewed.

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

1:43 PM Changeset in webkit [113233] by dslomov@google.com

5 edits in trunk

Source/WebCore: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090
The implementation of structured cloning algorithm (http://www.w3.org/TR/html5/common-dom-interfaces.html#internal-structured-cloning-algorithm)
in SerializedScriptValue.cpp assigns numerical identifiers to encontered objects as it traverses
the cloned object during serialization.
When the cloning encounters an already seen object, it transfers the assigned numerical id
instead of cloning the object again. Deserialization process then repeats the process in
the mirror fashion, i.e. on deserializing the object it assigns deserialized object a numeric id and if it
deserializes the id it substitutes the perviously deserialized objects. It is critical that serialization and deserialization
assigns numeric ids in the same order.

The bug (discovered by Yong Li) is that when serializing ArrayBufferView, the ids were assigned first to
the ArrayBufferView and then to underlying ArrayBuffer; however on deserialization the ids were assigned another way round.

This patch fixes that by assigning the id first to ArrayBuffer and then to ArrayBufferView, and adds corresponding test cases.

Reviewed by Kenneth Russell.

New test cases added to fast/canvas/web-gl/array-message-passing.html.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(CloneSerializer):
(WebCore::CloneSerializer::recordObject):
(WebCore::CloneSerializer::startObjectInternal):
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests: [JSC] ArrayBufferView and its ArrayBuffer are appended to object pool in wrong order
https://bugs.webkit.org/show_bug.cgi?id=82090
Adds tests that cover more than one view of the same ArrayBuffer being cloned.

Reviewed by Kenneth Russell.

fast/canvas/webgl/array-message-passing-expected.txt:
fast/canvas/webgl/script-tests/array-message-passing.js:

(typedArrayCompare):
(dataViewCompare):
(dataViewCompare2):
(dataViewCompare3):

1:31 PM Changeset in webkit [113232] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] When setting animation started events, should check the root layer
https://bugs.webkit.org/show_bug.cgi?id=83060

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-04
Reviewed by Adrienne Walker.

No new tests.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::animateLayers):
(WebCore::CCLayerTreeHost::animateLayersRecursive):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

1:27 PM Changeset in webkit [113231] by abarth@webkit.org

3 edits in trunk

[Chromium] TestWebKitAPI links in WebCore twice
https://bugs.webkit.org/show_bug.cgi?id=83177

Reviewed by Dimitri Glazkov.

This is causing link errors in the Windows component build. This patch
moves the dependencies a bit lower down in the dependency diagram in
the hopes of removing the duplicate symbols.

TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

1:10 PM Changeset in webkit [113230] by adamk@chromium.org

9 edits in trunk

Web Inspector: break on DOM node insertion only once per operation, not once per inserted node
https://bugs.webkit.org/show_bug.cgi?id=82967

Reviewed by Ojan Vafai.

Source/WebCore:

This change affects the case where a DocumentFragment is inserted,
rather than a single node. This is most common when using innerHTML:
the effect of the change is that inserting, e.g., '<input><input>',
the SubtreeModified breakpoint will be hit once, rather than twice
(once for each input element). Given that the particular node being
inserted wasn't exposed as part of the breakpoint, this seems strictly
better.

Now that the call to willInsertDOMNode is outside the loop, there's
not an obvious node to pass in as the new child. Luckily, InspectorDOMDebuggerAgent
already ignored that argument, so it's simply been removed from the signature.

This changes paves the way to do only tree-modification work, and no
external notifications, inside the loops in appendChild/insertBefore/replaceChild.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore): Hoisted call to willInsertDOMNode out of loop.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.

inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode): Removed first argument (now takes only the parent).

inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): Removed second argument.

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willInsertDOMNode): Removed second argument.

LayoutTests:

Added test for setting inner HTML and ensuring that only a single
breakpoint is hit.

inspector/debugger/dom-breakpoints.html:
platform/chromium/inspector/debugger/dom-breakpoints-expected.txt:

1:06 PM Changeset in webkit [113229] by jpfau@apple.com

3 edits
2 adds in trunk

Source/WebCore: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

Test: fast/html/pending-stylesheet-crash.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::removedFromDocument):

LayoutTests: Move pending sheet removal from ~HTMLLinkElement to removal from document.
https://bugs.webkit.org/show_bug.cgi?id=69184

Reviewed by Adam Barth.

fast/html/pending-stylesheet-crash-expected.txt: Added.
fast/html/pending-stylesheet-crash.html: Added.

12:50 PM Changeset in webkit [113228] by jonlee@apple.com

21 edits
4 adds in trunk/LayoutTests

Unskip Mac filter pixel tests which changed because of color space adjustment
https://bugs.webkit.org/show_bug.cgi?id=80630

Unreviewed.

platform/mac/test_expectations.txt: Unskip tests now that patch for b80571 landed.
platform/wk2/Skipped: Unskip same tests.

These were rebaselined with color correction. Between WK1 and WK2, however, they still fail
the pixel hash, and completely fail if tolerance is set to 0. https://bugs.webkit.org/show_bug.cgi?id=83187

css3/filters/add-filter-rendering-expected.png:
css3/filters/crash-filter-change-expected.png:
css3/filters/effect-blur-expected.png:
css3/filters/effect-brightness-expected.png:
css3/filters/effect-combined-expected.png:
css3/filters/effect-contrast-expected.png:
css3/filters/effect-drop-shadow-expected.png:
css3/filters/effect-grayscale-expected.png:
css3/filters/effect-hue-rotate-expected.png:
css3/filters/effect-invert-expected.png:
css3/filters/effect-opacity-expected.png:
css3/filters/effect-saturate-expected.png:
css3/filters/effect-sepia-expected.png:
css3/filters/filter-repaint-expected.png:
css3/filters/filter-with-transform-expected.png:
css3/filters/nested-filter-expected.png:
css3/filters/regions-expanding-expected.png:
css3/filters/simple-filter-rendering-expected.png:

These tests fail between WK1 and WK2 because of a difference in the blur. https://bugs.webkit.org/show_bug.cgi?id=83188

platform/mac-wk2/css3/filters/effect-blur-expected.png: Added.
platform/mac-wk2/css3/filters/effect-combined-expected.png: Added.
platform/mac-wk2/css3/filters/effect-opacity-expected.png: Added.
platform/mac-wk2/css3/filters/regions-expanding-expected.png: Added.

12:46 PM Changeset in webkit [113227] by commit-queue@webkit.org

7 edits in trunk/Source

Call histogramCustomCounts directly
https://bugs.webkit.org/show_bug.cgi?id=83112

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

platform/chromium/PlatformSupport.h:

(PlatformSupport):

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::recordMetricsInternal):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

src/painting/PaintAggregator.cpp:

12:35 PM Changeset in webkit [113226] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark fast/writing-mode/relative-positioning-percentages.html as crashing on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=83185

platform/chromium/test_expectations.txt: Marked as crashing.

12:33 PM Changeset in webkit [113225] by alexis.menard@openbossa.org

19 edits in trunk/Source

Source/WebCore: Animation related classes should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Reviewed by Simon Fraser.

Split the concept of animate none and animate all into a separate function rather than using the property member
with some magic value set on it. Make also sure that we use CSSPropertyID all over the place rather than integers.
We still have some place where convert from int to CSSPropertyID (mostly due to the fact that we need to make Hash*
related classes to handle CSSPropertyID). While refactoring I also removed some dead code.

No new tests : not behaviour changes intented.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

page/animation/AnimationBase.cpp:

(WebCore):
(WebCore::PropertyWrapperBase::PropertyWrapperBase):
(WebCore::PropertyWrapperBase::property):
(PropertyWrapperBase):
(WebCore::PropertyWrapperGetter::PropertyWrapperGetter):
(WebCore::PropertyWrapper::PropertyWrapper):
(WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::wrapperForProperty):
(WebCore::AnimationBase::propertiesEqual):
The code removed here could never be reached. propertiesEqual is used only in CompositeAnimation::updateTransitions and through
ImplicitAnimation::isTargetPropertyEqual which is also called in CompositeAnimation. Both calls are protected by an ASSERT in
CompositeAnimation:116 where we make sure the property id we're dealing with is a valid property id, therefore prop can't be equal to
the old value cAnimateAll or even the new mode concept introduced in that patch can't be AnimateAll.
(WebCore::AnimationBase::getPropertyAtIndex):
(WebCore::AnimationBase::blendProperties):
(WebCore::AnimationBase::animationOfPropertyIsAccelerated):
(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):

page/animation/AnimationBase.h:

(AnimationBase):

page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):

page/animation/CompositeAnimation.h:

(CompositeAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
The check removed is useless as ImplicitAnimation constructor ensure via an ASSERT that the animatingProperty value is a correct and valid
property id. Even the old code was ensuring the value of animatingProperty was different from cAnimateAll at construction time. As stated also
in CompositeAnimation::updateTransitions and cover by the same ASSERT explained earlier, ImplicitAnimation are constructed for valid property ids.
(WebCore::ImplicitAnimation::isTargetPropertyEqual):
(WebCore::ImplicitAnimation::blendPropertyValueInStyle):

page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):
(ImplicitAnimation):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::timeToNextService):

platform/animation/Animation.cpp:

(WebCore::Animation::Animation):
(WebCore::Animation::operator=):
(WebCore::Animation::animationsMatch):

platform/animation/Animation.h:

(WebCore::Animation::property):
(WebCore::Animation::animationMode):
(WebCore::Animation::setProperty):
(WebCore::Animation::setAnimationMode):
(Animation):
(WebCore::Animation::initialAnimationProperty):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startTransition):

rendering/RenderLayerBacking.h:

(RenderLayerBacking):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::transitionForProperty):

rendering/style/RenderStyle.h:

Source/WebKit2: Animation related classes should use CSSPropertyId rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83050

Reviewed by Simon Fraser.

The property of the Animation is a CSSPropertyID. It's ok to cast it here as an int for IPC transmission.

Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:11 PM Changeset in webkit [113224] by rakuco@webkit.org

9 edits in trunk

[EFL][DRT] Catch the "resource,request,willsend" signal
https://bugs.webkit.org/show_bug.cgi?id=82192

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-04
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

EFL's FrameLoaderClient now emits the "resource,request,willsend"
signal on the view for all resources about to be loaded, not just the
main frame. Also adds a boolean flag to Ewk_Frame_Resource_Request to
distinguish the request for the main frame from those for
sub-resources.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

ewk/ewk_frame.h:
ewk/ewk_view.h:

Tools:

EFL's DumpRenderTree now catches the "resource,request,willsend"
signal in order to implement the "Blocked access to external URL"
behavior and avoid potential network-related timeouts in the tests.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip related test cases now that EFL's DumpRenderTree
catches the "resource,request,willsend" signal and implements the
"Blocked access to external URL" behavior.

platform/efl/Skipped:

12:10 PM Changeset in webkit [113223] by eae@chromium.org

3 edits in trunk/Source/WebCore

Fix usage of LayoutUnits and snapping for scrolling in RenderBox
https://bugs.webkit.org/show_bug.cgi?id=83073

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and snapping/rounding logic in RenderBox.

No new tests, no change in functionality.

rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
Change scrollWidth to properly pixel snap values.

(WebCore::RenderBox::scrollHeight):
Change scrollHeight to properly pixel snap values.

(WebCore::RenderBox::scrolledContentOffset):
Change to return IntSize to match function definition.

(WebCore::RenderBox::cachedSizeForOverflowClip):
Changed cachedSizeForOverflowClip to LayoutSize as the overflow and clip
rects all have subpixel precision.

rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
Removed FIXME comment as the implementation

(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
Added static_cast for border values.

(WebCore::RenderBox::hasVisualOverflow):
Changed to compare two pixel snapped values as we don't want to indicate
overflow in cases where the the size is rounded down resulting in no
visual overflow.

12:04 PM Changeset in webkit [113222] by eae@chromium.org

11 edits in trunk/Source/WebCore

Fix types for location, size and rect calculations for render objects
https://bugs.webkit.org/show_bug.cgi?id=83089

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and rounding for a couple of different render
object classes.

No new tests, no change in functionality.

rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::getPath):
Change getPath to take a LayoutPoint as the transform has subpixel
precision already.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):
Change logicalHeight to LayoutUnit as it is computed from subpixel
values.

rendering/RenderInputSpeech.cpp:

(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
Change button rect computation to LayoutRect and pixel snap just before
painting to preserve precision.

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
Change range calculations to LayoutUnits to preserve precision.

rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Change width calculations to LayoutUnits to preserve precision.

rendering/RenderTable.cpp:

(WebCore::RenderTable::layoutCaption):
Change table captions to LayoutUnits as the values are computed from
subpixel componenets.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor):
Snap border rect as RoundedRects use ints for crisp rendering.

rendering/style/ShadowData.cpp:

(WebCore::ShadowData::adjustRectForShadow):
Change adjustRectForShadow to take a LayoutRect as it already uses
LayoutUnits.

11:54 AM Changeset in webkit [113221] by eae@chromium.org

3 edits in trunk/Source/WebCore

Convert RootInlineBox to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=83054

Reviewed by Eric Seidel.

Convert RootInlineBox over to LayoutUnits, this mostly involves updating
the alignment and adjustment code to be subpixel aware.

No new tests, no change in functionality.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Change beforeAnnotationsAdjustment to LayoutUnit.

(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
Change method to return LayoutUnit as it is computed from values with
subpixel precision.

(WebCore::RootInlineBox::lineSnapAdjustment):
Round values before computing remainder.

(WebCore::RootInlineBox::ascentAndDescentForBox):
Change ascent and decent calculation to use LayoutUnits as they are
computed from values with subpixel precision.

(WebCore::RootInlineBox::verticalPositionForBox):
Change verticalPosition to LayoutUnit.

rendering/RootInlineBox.h:

(RootInlineBox):

11:42 AM Changeset in webkit [113220] by Joseph Pecoraro

6 edits in trunk

<http://webkit.org/b/83108> Web Inspector: JSC Crash inspecting node with object event listener

Reviewed by Geoff Garen.

Source/WebCore:

bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerLocation):
Use jsDynamicCast to bail when the JSObject is not a JSFunction.

LayoutTests:

inspector/elements/event-listener-sidebar.html:
inspector/elements/event-listener-sidebar-expected.txt:
platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:

Add an EventListener that uses an object listener instead of a function.

11:18 AM Changeset in webkit [113219] by commit-queue@webkit.org

5 edits in trunk/Source

Call suddenTerminationChanged directly
https://bugs.webkit.org/show_bug.cgi?id=83114

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

platform/chromium/PlatformSupport.h:

(PlatformSupport):

platform/chromium/SuddenTerminationChromium.cpp:

(WebCore::disableSuddenTermination):
(WebCore::enableSuddenTermination):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

11:14 AM Changeset in webkit [113218] by abarth@webkit.org

8 edits in trunk/Source

figure out how to export webcore symbols from webkit.dll properly
https://bugs.webkit.org/show_bug.cgi?id=83105

Reviewed by Dimitri Glazkov.

Source/Platform:

Unwind our ugly, ugly hack to make the Windows component build work.

chromium/public/WebMediaStreamSourcesRequest.h:

(WebMediaStreamSourcesRequest):

Source/WebCore:

WebCore.gypi:
- Separate the platform support files into a new GYP variable so that they can be build as part of webkit.dll rather than in webcore_platform.lib. Building them as part of webkit.dll ensure that the symbols marked for export will actually be in webkit.dll (and hence exported), even if nothing else in webkit.dll references the obj file that contains the symbol.
platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
- Unwind our ugly, ugly hack to make the Windows component build work.

Source/WebKit/chromium:

WebKit.gyp:
- We now compile the platform support files as part of webkit.dll to make sure the lib contains the obj files and therefore exports the necessary symbols. In principle, we could use a defs file to achieve the same thing, but those files are a pain to maintain.
src/WebKit.cpp:

(WebKit::shutdown):

Unwind our ugly, ugly hack to make the Windows component build work.

11:12 AM Changeset in webkit [113217] by commit-queue@webkit.org

4 edits in trunk/Source

Call sandboxEnabled directly
https://bugs.webkit.org/show_bug.cgi?id=83113

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-04
Reviewed by Adam Barth.

Source/WebCore:

platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

11:07 AM Changeset in webkit [113216] by Patrick Gansterer

2 edits in trunk/Tools

[EFL][DRT] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=83168

Reviewed by Eric Seidel.

Modify the #include declarations so that the
wtf types are included using the full path.

DumpRenderTree/efl/DumpRenderTree.cpp:

11:07 AM Changeset in webkit [113215] by kareng@chromium.org

1 edit
2 copies in branches/chromium/1084

Merge 113139 - Don't parse "show" and "hide" as valid values for display property.
https://bugs.webkit.org/show_bug.cgi?id=83115

Reviewed by Adam Barth.

No new tests.

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

TBR=macpherson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9981010

10:50 AM Changeset in webkit [113214] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=83183

platform/chromium/test_expectations.txt: Registered flakes.

10:43 AM Changeset in webkit [113213] by caseq@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch IndexedDB, DOMStorage, ApplicationCache domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=83039

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-04
Reviewed by Pavel Feldman.

Client code is switched to typed API (all InspectorObject and InspectorArray types are
replaced with generated types from TypeBuilder according to Inspector.json).

Missing array of array specialization is added. Inspector.json is fixed to comform
with actual behavior of InspectorDOMStorageAgent.

Output parameter initialization is assured.

inspector/CodeGeneratorInspector.py:
inspector/Inspector.json:
inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):

inspector/InspectorApplicationCacheAgent.h:

(InspectorApplicationCacheAgent):

inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):

inspector/InspectorDOMStorageAgent.h:

(InspectorDOMStorageAgent):

inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::bind):

10:38 AM Changeset in webkit [113212] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Add another kind of flaky to fast/replaced/border-radius-clip.html

platform/chromium/test_expectations.txt: Flakes registered.

10:31 AM Changeset in webkit [113211] by fischman@chromium.org

3 edits in trunk/LayoutTests

Layout Test media/video-beforeload-remove-source.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=82260

Reviewed by Eric Carlson.

Moved the beforeload listener to <head> to ensure it is registered before the
load actually happens. Before this change, the test failed (timed out) 2/1000 runs,
after the change it had no failures in 5000 runs.

media/video-beforeload-remove-source.html:
platform/chromium/test_expectations.txt:

10:29 AM Changeset in webkit [113210] by Philippe Normand

2 edits in trunk/Tools

gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Reviewed by Tony Chang.

Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(test_get_crash_log): Skip the test on non-linux platforms.

10:17 AM Changeset in webkit [113209] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

[Qt] REGRESSION(r113141): All tests assert on 32 bit debug mode
https://bugs.webkit.org/show_bug.cgi?id=83139

Reviewed by Sam Weinig.

heap/PassWeak.h:

(JSC::::get): 32-bit JSValue treats JSValue(nullptr).asCell() as an error,
so work around that here. (Long-term, we should make 32-bit and 64-bit
agree on the right behavior.)

10:13 AM Changeset in webkit [113208] by tony@chromium.org

17 edits
5 deletes in trunk

Remove flex function css parsing
https://bugs.webkit.org/show_bug.cgi?id=83083

Reviewed by Ojan Vafai.

Source/WebCore:

The flexbox spec switched from using a flex() function on the width
and height to a css property. Now that the -webkit-flex: has been
implemented, we can remove the flex() function code.

No new tests. Removing an old test that used to test the flex() function.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:
css/CSSFlexValue.cpp: Removed.
css/CSSFlexValue.h: Removed.
css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

css/CSSParser.h:

(WebCore):

css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:
rendering/style/RenderStyle.h:
rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Remove test of -webkit-flex() function.

css3/flexbox/flex-parsing-expected.txt: Removed.
css3/flexbox/flex-parsing.html: Removed.
css3/flexbox/script-tests/flex-parsing.js: Removed.

10:09 AM Changeset in webkit [113207] by Philippe Normand

3 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/Skipped:
platform/gtk/test_expectations.txt:

10:06 AM Changeset in webkit [113206] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for fast/canvas/canvas-overloads-strokeText.html

platform/chromium/test_expectations.txt: Tweaked.

10:03 AM Changeset in webkit [113205] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Marked http/tests/websocket/tests/hybi/workers/worker-reload.html as flaky fail.
https://bugs.webkit.org/show_bug.cgi?id=83173

platform/chromium/test_expectations.txt: Added expectations.

10:03 AM Changeset in webkit [113204] by commit-queue@webkit.org

14 edits in trunk/Source

[Coverity] Address some uninit constructor values.
https://bugs.webkit.org/show_bug.cgi?id=82424

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-04-04
Reviewed by Stephen White.

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

Source/WebCore:

Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::Gamepad):

accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButtonPart::AccessibilitySpinButtonPart):

dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

html/canvas/WebGLContextObject.h:

(WebGLContextObject):

platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:

(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

Source/WebKit/chromium:

src/DatabaseObserver.cpp:

(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):

src/LocalFileSystemChromium.cpp:

(WebCore):

Source/WTF:

wtf/ArrayBufferView.cpp:

(WTF::ArrayBufferView::ArrayBufferView):

9:59 AM Changeset in webkit [113203] by rwlbuis@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger
https://bugs.webkit.org/show_bug.cgi?id=83085

Reviewed by Antonio Gomes.

PR 121109

This way when we add something to the enum and forget to add to the switch we'll get a compile error.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):

9:38 AM Changeset in webkit [113202] by loislo@chromium.org

1 edit
3 moves in trunk/PerformanceTests

Web Inspector: Unreviewed. temporary disable broken inspector tests.

inspector/first-open-scripts.html.broken: Renamed from PerformanceTests/inspector/first-open-scripts.html.
inspector/network-append-30-requests.html.broken: Renamed from PerformanceTests/inspector/network-append-30-requests.html.
inspector/show-panel.html.broken: Renamed from PerformanceTests/inspector/show-panel.html.

9:31 AM Changeset in webkit [113201] by Dimitri Glazkov

2 edits in trunk/Source/WebKit/chromium

Unreviewed, temporary dirty hack to make Win Debug work again.

All.gyp: Temporarily removed TestWebKitAPI target.

9:16 AM Changeset in webkit [113200] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK inspector gardening.

platform/gtk/test_expectations.txt:

9:10 AM Changeset in webkit [113199] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: expose savedURL, setToolbarColors and toggleSearchingForNode in InspectorFrontendAPI
https://bugs.webkit.org/show_bug.cgi?id=83170

Reviewed by Yury Semikhatsky.

Chromium port is calling these from the embedder layer and they all are perfect candidates
for the InspectorFrontendAPI. Adding them there.

inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):
(InspectorFrontendAPI.savedURL):
(InspectorFrontendAPI.setToolbarColors):

9:03 AM Changeset in webkit [113198] by rakuco@webkit.org

7 edits in trunk

[EFL] DRT support for computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=82190

Source/WebKit/efl:

Add missing implementation computedStyleIncludingVisitedInfo to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::computedStyleIncludingVisitedInfo):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
LayoutTestController so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip tests connected with computedStyleIncludingVisitedInfo().

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-04
Reviewed by Antonio Gomes.

platform/efl/Skipped:

9:01 AM Changeset in webkit [113197] by bbudge@chromium.org

1 edit in branches/chromium/1084/Source/WebKit/chromium/src/AssociatedURLLoader.cpp

Merge 112485 - AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9981003

8:54 AM Changeset in webkit [113196] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

A couple more cleanups to LayoutUnits in RenderInputSpeech::paintInputFieldSpeechButton.

8:52 AM Changeset in webkit [113195] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] Entire page highlighted on panning.
https://bugs.webkit.org/show_bug.cgi?id=83158

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

8:49 AM Changeset in webkit [113194] by loislo@chromium.org

4 edits in trunk

Web Inspector: linearise aggregate's retaining size calculation.
https://bugs.webkit.org/show_bug.cgi?id=83125

This version is twice as fast as the original and it is non-recursive.

Reviewed by Yury Semikhatsky.

PerformanceTests:

inspector/detailed-heapshots-smoke-test.html:

Source/WebCore:

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._getDominatedIndex): was moved closer to it's usage
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize): it was _buildAggregates' inner function forDominatedNodes.
it was:
a) extracted from _buildAggregates;
b) made non-recursive;
c) many getters were inlined;
d) subarray of dominating nodes were inlined too.
(WebInspector.HeapSnapshot.prototype._buildAggregates): many getters were inlined.
(WebInspector.HeapSnapshot.prototype.aggregates):

8:42 AM Changeset in webkit [113193] by commit-queue@webkit.org

5 edits in trunk

Source/WebCore: Best clickable node might return non "clickable" node.
https://bugs.webkit.org/show_bug.cgi?id=83153

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

Do not return non-clickable nodes as a best clickable node.

page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):

LayoutTests: Best clickable node might return non "clickable" node.
https://bugs.webkit.org/show_bug.cgi?id=83153

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-04
Reviewed by Kenneth Rohde Christiansen.

touchadjustment/touch-inlines-expected.txt:
touchadjustment/touch-inlines.html:

8:40 AM Changeset in webkit [113192] by pfeldman@chromium.org

22 edits in trunk

Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontendHost.save.
https://bugs.webkit.org/show_bug.cgi?id=83162

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change adds Save item into the context menus for inspector. It also makes
saveAs parameter optional in the InspectorFrontendHost.save so that we could
skip the dialog for the paths that were already saved. Embedder tells the front-end
what urls were successfully saved so that front-end could issue subsequent save commands
for those files.

English.lproj/localizedStrings.js:
inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSave):
(WebCore::InspectorFrontendClientLocal::save):

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSave):
(WebCore::InspectorFrontendHost::save):

inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:
inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.canSave):

inspector/front-end/JavaScriptSourceFrame.js:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

inspector/front-end/ResourceView.js:
inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.save):
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.save):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):

inspector/front-end/Settings.js:
inspector/front-end/SourceFrame.js:

(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewer.prototype._commitEditing):
(WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):

inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.saveToFile):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._contextMenu):

inspector/front-end/inspector.js:

Source/WebKit/chromium:

public/WebDevToolsFrontendClient.h:
src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::canSave):
(WebKit::InspectorFrontendClientImpl::save):

src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

8:35 AM Changeset in webkit [113191] by leviw@chromium.org

1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderInputSpeech.cpp

Cleaning up LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton. This method is only called from RenderTheme, so it arrives with an IntRect. We have to be careful to do proper pixel snapping within this method.

8:23 AM Changeset in webkit [113190] by caseq@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: time dividers are incorrectly rendered on empty timeline grid
https://bugs.webkit.org/show_bug.cgi?id=83165

Reviewed by Pavel Feldman.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkBaseCalculator.prototype.setDisplayWindow):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

8:15 AM Changeset in webkit [113189] by sergio@webkit.org

2 edits in trunk/Source/WebCore

[GTK] ASSERT in SocketStreamHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=83123

Reviewed by Martin Robinson.

Do not try to reuse a GOwnPtr as calling outPtr() causes an
assertion if the pointer is already valid. Also do not try to
close the IOStream if it was not created.

This patch fixes
http/tests/websocket/tests/hybi/workers/worker-reload.html but I
am leaving it skipped until webkit.org/b/83124 is fixed.

platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::connectedCallback):

8:05 AM Changeset in webkit [113188] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests to try to paint ARM and Mac bots green.

platform/qt-arm/Skipped:
platform/qt-mac/Skipped:

7:26 AM Changeset in webkit [113187] by alexis.menard@openbossa.org

7 edits in trunk/Source/WebCore

Re-add variable names in CSS related headers to help understanding the meaning of them.
https://bugs.webkit.org/show_bug.cgi?id=83151

Reviewed by Andreas Kling.

r112952, r113031, r113042 removed variable names in some places but at the end it
was better before as it helps understanding what the variables represent. This patch
address this issue and add back the names where it makes sense.

No new tests : cosmetic changes, no behavior change here.

css/CSSParser.h:

(CSSParser):

css/StylePropertySet.h:

(StylePropertySet):

dom/StyledElement.h:

(StyledElement):

editing/EditingStyle.h:

(EditingStyle):

editing/Editor.h:

(Editor):

html/HTMLElement.h:

(HTMLElement):

7:11 AM Changeset in webkit [113186] by rakuco@webkit.org

3 edits in trunk/Tools

Unreviewed; update my email address once again in the committers
and watch list.

Scripts/webkitpy/common/config/committers.py: Prefer my

webkit.org email over my FreeBSD.org one.

Scripts/webkitpy/common/config/watchlist: Ditto.

7:06 AM Changeset in webkit [113185] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

Unreviewed. Layout Test fast/canvas/canvas-toDataURL-webp.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=81735

Test expectations update. Fixed in http://crrev.com/129144.

platform/chromium/test_expectations.txt:

6:52 AM Changeset in webkit [113184] by Nikolas Zimmermann

33 edits in trunk

Implement animatedPathSegList support for SVGPathElement
https://bugs.webkit.org/show_bug.cgi?id=83140

Reviewed by Zoltan Herczeg.

Source/WebCore:

Add the last missing piece of animVal support: animations of the SVGPathElement's 'd' attribute
should be reflected in the 'animatedPathSegList' not the 'pathSegList'.

The SVGAnimatedPathAnimator is special as it doesn't operate on the SVGPathSegList types
directly, but on the SVGPathByteStreams for performance reasons. The SVGPathSegLists
are refcounted and exposed to JS, thus require lots of memory, compared to a simple
byte stream, which SVGPathByteStream is. Only build an 'animatedPathSegList' while
animating if its actually observed by the bindings, as this operation is heavy.

This marks the finish of the animVal patch series: no more string round trips during
animation. Previously paths were animated as byte streams, then converted to a String
passed to pathElement->setAttribute("d", "newString"), parsed again to a byte stream, etc.

A follow-up patch will remove the last crufts of direct setAttribute() animation.

Extend all existing animated SVGPathElement tests to cover animatedPathSegList.

svg/SVGAnimatedColor.h:

(WebCore::SVGAnimatedColorAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedColorAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedColorAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedColorAnimator::animValWillChange):
(WebCore::SVGAnimatedColorAnimator::animValDidChange):
(SVGAnimatedColorAnimator):

svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedPathAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPathAnimator::animValWillChange):
(WebCore::SVGAnimatedPathAnimator::animValDidChange):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

svg/SVGAnimatedPath.h:

(SVGAnimatedPathAnimator):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):

svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegList):
(WebCore::SVGPathElement::animatedPathSegList):
(WebCore::SVGPathElement::pathSegListChanged):

svg/SVGPathElement.h:

(WebCore):
(SVGPathElement):
(WebCore::SVGPathElement::isAnimValObserved):

svg/SVGPathParserFactory.cpp:

(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
(WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):

svg/SVGPathParserFactory.h:

(SVGPathParserFactory):

svg/SVGPathSegWithContext.h:
svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):

svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animatedPathByteStream):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

svg/properties/SVGAnimatedTransformListPropertyTearOff.h:

(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):

svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::SVGListProperty):
(WebCore::SVGListProperty::~SVGListProperty):
(SVGListProperty):

LayoutTests:

Update all tests animating the SVGPathElement's 'd' attribute to verify 'animatedPathSegList' now gets animated, not 'pathSegList'.

svg/animations/animate-path-animation-Cc-Ss-expected.txt:
svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
svg/animations/animate-path-animation-Qq-Tt-expected.txt:
svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt:
svg/animations/animate-path-to-animation-expected.txt:
svg/animations/script-tests/animate-path-animation-Cc-Ss.js: