Timeline



Apr 14, 2012:

8:51 PM Changeset in webkit [114211] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
​https://bugs.webkit.org/show_bug.cgi?id=83929

Reviewed by Eric Seidel.

Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.

No new tests, no change in functionality.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

  • html/shadow/MediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

8:31 PM Changeset in webkit [114210] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
​https://bugs.webkit.org/show_bug.cgi?id=83990

Reviewed by Kentaro Hara.

We passed the "weekStartDay" property value as a
string. CalendarPickerElement::writeDocument() created:

weekStartDay: "1",

and the JavaScript code used it in the following code:

dayLabels[(weekStartDay + i) % 7]

If weekStartDay was "1", the expression (weekStartDay + i)
produced "10", "11", "12", ... We expected "1", "2", "3", ...

We need to pass the "weekStartDay" property as a number.

No new tests because we have no ways to test this for now. We'll
introduce tests for the calendar picker later.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::addProperty): Add addProperty() function for a number.
(WebCore::CalendarPickerElement::writeDocument):
Pass a number, not a serialized number.

5:43 PM Changeset in webkit [114209] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Harden WTF::ByteArray::create()
​https://bugs.webkit.org/show_bug.cgi?id=83318

Reviewed by Maciej Stachowiak.

  • wtf/ByteArray.cpp:

(WTF::ByteArray::create):
Add overflow check. I don't believe there is anyway to trigger this currently,
hence no tests, so this should be considered hardening.

2:29 PM Changeset in webkit [114208] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Viewport-percentage Length units does not work for Replaced elements size
​https://bugs.webkit.org/show_bug.cgi?id=83425

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added the support for viewport-percentage length units while calculating the width/height of replaced elements.

Source/WebCore:

Tests: css3/viewport-percentage-lengths/viewport-percentage-image-size.html

  • platform/Length.h:

(WebCore::Length::isSpecified):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

LayoutTests:

  • css3/viewport-percentage-lengths/resources: Added.
  • css3/viewport-percentage-lengths/resources/colorsquare.png: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-image-size-expected.html: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-image-size.html: Added.
2:05 PM Changeset in webkit [114207] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
​https://bugs.webkit.org/show_bug.cgi?id=80736

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added support for fetching the value of 'border-radius' CSS property which was missing.

Source/WebCore:

Test: fast/css/border-radius-property-value.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

  • fast/css/border-radius-property-value-expected.txt: Added.
  • fast/css/border-radius-property-value.html: Added.
11:29 AM Changeset in webkit [114206] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=81945

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.

Tools:

WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.

  • platform/mac-wk2/Skipped:
11:15 AM Changeset in webkit [114205] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=83826

Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.

Reviewed by Dan Bernstein.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):

3:30 AM WebKitGTK edited by sh4.seo@samsung.com
Use internal link (diff)
2:34 AM Changeset in webkit [114204] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
​https://bugs.webkit.org/show_bug.cgi?id=83569

Reviewed by Eric Seidel.

No new tests. Covered by exiting fast/canvas/*toDataURL* tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per ​http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.

Apr 13, 2012:

11:02 PM Changeset in webkit [114203] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
​https://bugs.webkit.org/show_bug.cgi?id=83804

Patch by David Reveman <​reveman@chromium.org> on 2012-04-13
Reviewed by James Robinson.

Source/WebCore:

Cleanup code that determines if we need to use a buffered update and
avoid buffering of tiles that are not in use by the impl thread.

Tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread

TiledLayerChromiumTest.partialUpdates

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::bufferedUpdates):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::setLayerPropertiesForTesting):
(WTF):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

8:32 PM Changeset in webkit [114202] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
​https://bugs.webkit.org/show_bug.cgi?id=83899

Reviewed by Adrienne Walker.

When a LTH becomes invisible, the texture eviction is spread out across
two different functions and is not entirely clear. We move all the logic
together into a single place in didBecomeInvisibleOnImplThread() and
make the consequences of the current code more clear.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

8:07 PM Changeset in webkit [114201] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it.
​https://bugs.webkit.org/show_bug.cgi?id=83920

Reviewed by James Robinson.

Found by clang:

third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion]
EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f)));

  • tests/LayerChromiumTest.cpp:
8:06 PM Changeset in webkit [114200] by commit-queue@webkit.org
  • 39 edits
    6 deletes in trunk

Unreviewed, rolling out r114036.
​http://trac.webkit.org/changeset/114036
​https://bugs.webkit.org/show_bug.cgi?id=83969

Breaks gmail.com causing it to never finish loading (Requested
by danakj on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
  • fast/dom/NodeList/node-list-array-class.html: Removed.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • fast/dom/everything-to-string-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/recursion-limit-equal-expected.txt:
  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • jquery/traversing-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
  • platform/chromium/fast/dom/everything-to-string-expected.txt: Removed.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/jquery/traversing-expected.txt: Removed.
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
8:02 PM Changeset in webkit [114199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Add null pointer check to animatePageScale
​https://bugs.webkit.org/show_bug.cgi?id=83940

Patch by Alexandre Elias <​aelias@google.com> on 2012-04-13
Reviewed by James Robinson.

Add null pointer check to startPageScaleAnimation.

If the root scroll layer goes away in the middle of a page scale
animation, there can be a null pointer access here.

No new tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animatePageScale):

7:33 PM Changeset in webkit [114198] by jchaffraix@webkit.org
  • 5 edits in trunk/LayoutTests

Two lineboxcontain tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=82742

Reviewed by Ojan Vafai.

  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:

Rebaselined.

  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:

Unskip some tests that are either rebaselined or now passing due to
r112582 re-adding some of the RenderLayers removed by r110072.

6:58 PM Changeset in webkit [114197] by danakj@chromium.org
  • 6 edits in trunk/Source

[chromium] Replicas should be included in the computed occlusion
​https://bugs.webkit.org/show_bug.cgi?id=82262

Reviewed by Adrienne Walker.

Source/WebCore:

When merging a surface's occlusion up to its target, make a copy of it
where the replica will be as well, and make sure that occlusion from a
RenderSurface does not leave its clipRect.

Unit test: CCOcclusionTrackerTestReplicaDoesOcclude

CCOcclusionTrackerTestReplicaWithClipping
CCOcclusionTrackerTestSurfaceChildOfSurface

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::hasReplica):
(WebCore):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestReplicaDoesOcclude):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaWithClipping):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):

6:30 PM Changeset in webkit [114196] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout test case for JavaScriptAudioNode.
​https://bugs.webkit.org/show_bug.cgi?id=83747

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.

  • webaudio/javascriptaudionode-expected.txt: Added.
  • webaudio/javascriptaudionode.html: Added.
6:29 PM Changeset in webkit [114195] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r114185.
​http://trac.webkit.org/changeset/114185
​https://bugs.webkit.org/show_bug.cgi?id=83967

Broke a bunch of JavaScript related tests (Requested by
andersca on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

  • runtime/CommonIdentifiers.h:
  • tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases):

6:27 PM Changeset in webkit [114194] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

convolution-mono-mono test passes now
​https://bugs.webkit.org/show_bug.cgi?id=83793

Patch by Raymond Toy <Raymond Toy> on 2012-04-13
Reviewed by Eric Seidel.

  • platform/chromium/test_expectations.txt: Delete entry.
6:25 PM Changeset in webkit [114193] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

AudioContext createChannelMerger() method should have optional argument for number of inputs.
​https://bugs.webkit.org/show_bug.cgi?id=83759

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.

Check ​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.

Source/WebCore:

Test: webaudio/audiochannelmerger-basic.html

  • Modules/webaudio/AudioChannelMerger.cpp:

(WebCore):
(WebCore::AudioChannelMerger::create):
(WebCore::AudioChannelMerger::AudioChannelMerger):

  • Modules/webaudio/AudioChannelMerger.h:

(AudioChannelMerger):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createChannelMerger):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:

LayoutTests:

  • webaudio/audiochannelmerger-basic-expected.txt: Added.
  • webaudio/audiochannelmerger-basic.html: Added.
6:20 PM Changeset in webkit [114192] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch calls
​https://bugs.webkit.org/show_bug.cgi?id=83966

Rubber stamped by Oliver Hunt.

These aren't being used anywhere!

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

5:42 PM Changeset in webkit [114191] by danakj@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Remove viewport memory restrictions
​https://bugs.webkit.org/show_bug.cgi?id=83316

Reviewed by Adrienne Walker.

We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.

We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.

Covered by existing tests.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):

5:38 PM Changeset in webkit [114190] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize tracking of intruding floats being removed from RenderBlock during layout
​https://bugs.webkit.org/show_bug.cgi?id=82928

Patch by Ken Buchanan <​kenrb@chromium.org> on 2012-04-13
Reviewed by David Hyatt.

Performance tweaks in RenderBlock layout as a follow up to r112935.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

5:36 PM Changeset in webkit [114189] by mihnea@adobe.com
  • 14 edits
    2 adds in trunk

[CSSRegions]Implement NamedFlow::contentNodes attribute
​https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

Source/WebCore:

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).

Test: fast/regions/webkit-named-flow-content-nodes.html

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::detach):

  • dom/Node.h:

(WebCore::Node::inNamedFlow):
(WebCore::Node::setInNamedFlow):
(WebCore::Node::clearInNamedFlow):
(Node):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/FlowThreadController.h:

(FlowThreadController):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):

  • rendering/RenderNamedFlowThread.h:

(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::hasContentNode):

LayoutTests:

  • fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
  • fast/regions/webkit-named-flow-content-nodes.html: Added.
5:34 PM Changeset in webkit [114188] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the calls to CRASH() from ResourceLoader.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=83962

Reviewed by Alexey Proskuryakov.

They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

5:33 PM Changeset in webkit [114187] by xji@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
when using certain fonts
​https://bugs.webkit.org/show_bug.cgi?id=83523

Reviewed by Kent Tamura.

Revert r102190.
Convert characters being treatAsSpace to white space.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::fillRuns):
(WebCore::UniscribeHelper::adjustSpaceAdvances):

5:27 PM Changeset in webkit [114186] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove fallback code for "Missing plug-in" string.
​https://bugs.webkit.org/show_bug.cgi?id=81907

Patch by Bernhard Bauer <​bauerb@google.com> on 2012-04-13
Reviewed by Adam Barth.

  • src/LocalizedStrings.cpp:

(WebCore::missingPluginText):

5:26 PM Changeset in webkit [114185] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Array.prototype.toString and Array.prototype.toLocaleString should be generic
​https://bugs.webkit.org/show_bug.cgi?id=81588

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-04-13
Reviewed by Gavin Barraclough.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

  • runtime/CommonIdentifiers.h:
  • tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases.array.item.new.TestCase):
(getTestCases):

5:11 PM Changeset in webkit [114184] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Change how the Web Insector is installed on Mac builds.

<rdar://problem/10857918>

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources

and Streamline Inspector Source build phases.

4:44 PM Changeset in webkit [114183] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch method checks
​https://bugs.webkit.org/show_bug.cgi?id=83958

Reviewed by Oliver Hunt.

  • bytecode/StructureStubInfo.h:
    • Add fields for the method check info.
  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • Store the offsets on the stub info, instead of asserting.
  • jit/JIT.h:
    • Delete all the method check related offsets.
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • Use the offset from the stubInfo.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Pass the stubInfo to patchMethodCallProto.
4:44 PM Changeset in webkit [114182] by Simon Fraser
  • 7 edits in trunk/LayoutTests

Rebaseline some compositing tests. Some were affected by the colorspace of
the sample image changing.

  • compositing/images/direct-pdf-image-expected.png:
  • compositing/repaint/newly-composited-repaint-rect-expected.png:
  • compositing/visibility/visibility-image-layers-expected.png:
  • compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
4:43 PM Changeset in webkit [114181] by abarth@webkit.org
  • 1 edit
    11 deletes in trunk/LayoutTests

fast/dom/Window/window-property-descriptors.html is too much work to maintain
​https://bugs.webkit.org/show_bug.cgi?id=83915

Reviewed by Alexey Proskuryakov.

The goal of this test is to remind us whenever we add something to the
global scope. In practice, however, this test is a lot of work to
maintain because every port has different features enabled, which means
every port has a different list of things in the global scope. It's
very difficult to make changes without causing this test to go red on a
number of bots.

Rather than use this test to monitor the global scope, we're better off
paying attention to the IDL files. If folks are interested in changes
to what is exposed to JavaScript, they can subscribe to IDL changes
using a watchlist. (That's what I do, and it works pretty well.)

  • fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
  • fast/dom/Window/window-property-descriptors.html: Removed.
  • platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
4:31 PM Changeset in webkit [114180] by jer.noble@apple.com
  • 5 edits in trunk/Source

Video at apple.com gets standard controls in addition to custom controls after returning from full screen
​https://bugs.webkit.org/show_bug.cgi?id=83939

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; DRT and WKTR don't have the infrastructure to test full-screen animation related bugs.

Instead of asking the media element whether it is in full screen or not, rely on when the media root element
was told that it enteredFullscreen() or exitedFullscreen(), which may occur at a different time than the
media element due to animations.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):

  • html/shadow/MediaControlRootElement.h:

(MediaControlRootElement): Added m_isFullscreen;

Source/WebKit2:

So that the media controls don't show up momentarily during full screen animations, call setAnimatingFullScreen(true)
before calling will{Enter,Exit}FullScreen(), so that the CSS rule for full screen animation will be in effect
immediately.

Similarly, call setAnimatingFullScreen(false) after calling did{Enter,Exit}FullScreen, so that the full screen media
controls don't momentarily appear at the end of an animation.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

4:27 PM Changeset in webkit [114179] by jer.noble@apple.com
  • 5 edits
    1 delete in trunk

fullscreen/video-controls-drag.html failing on Mac
​https://bugs.webkit.org/show_bug.cgi?id=81176

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Fixes fullscreen/video-controls-drag.html.

Regressed in r110409. When the -webkit-media-controls-panel were changed
from position:absolute to position:relative, this broke dragging of the
controls in fullscreen, which relies on the panel being absolutely positioned
to do its drag positioning. Change the way drag positioning is calculated to
accommodate position:relative.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel): Instead of bottom:50px,

use margin-bottom:50px to push panel up from the bottom of the screen.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag): Do not ask for the current renderer location.
(WebCore::MediaControlPanelElement::continueDrag): Use the delta between the event locations

only to calculate the new panel position.

  • html/shadow/MediaControlElements.h:

LayoutTests:

Removed expected failing results from platform/mac.

  • platform/mac/fullscreen/video-controls-drag-expected.txt: Removed.
4:25 PM Changeset in webkit [114178] by Simon Fraser
  • 5 edits in trunk/LayoutTests

Fix two compositing animation tests to not have flakey pixel results
​https://bugs.webkit.org/show_bug.cgi?id=83957

Reviewed by Dean Jackson.

Fix these tests to use the pause animation API by providing an animation
name in the expected data. There's no need to start the animations by hand.

  • compositing/reflections/animation-inside-reflection.html:
  • compositing/reflections/nested-reflection-animated.html:
  • platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
4:16 PM Changeset in webkit [114177] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline this since svg/custom/resources/green-checker.png changed.

  • svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
3:51 PM Changeset in webkit [114176] by Simon Fraser
  • 13 edits in trunk/LayoutTests

Avoid use of ::webkit-scrollbar to hide scrollbars, since it doesn't work in WK1
​https://bugs.webkit.org/show_bug.cgi?id=83950

Reviewed by James Robinson.

Remove use of ::webkit-scrollbar from compositing tests, since this doesn't
affect WebKit1 scrollbars.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
3:26 PM Changeset in webkit [114175] by Simon Fraser
  • 5 edits
    1 delete in trunk

Compositing layers not updated after scroll in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=83945

Source/WebCore:

Reviewed by James Robinson.

Fix the WebKit1 code path to correctly update compositing layers
after a scroll, by calling updateFixedElementsAfterScrolling() from
scrollPositionChangedViaPlatformWidget().

Covered by existing tests.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):

LayoutTests:

Reviewed by James Robinson.

Replace an incorrect Mac baseline with the correct result which was
already in place for WebKit2.

Remove a passing test from test-expectations.

  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
  • platform/mac/test_expectations.txt:
3:09 PM Changeset in webkit [114174] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
3:05 PM Changeset in webkit [114173] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Fix skipped list.

  • Skipped:
3:02 PM Changeset in webkit [114172] by dino@apple.com
  • 6 edits
    4 adds in trunk

Don't process filters if the input region is exceptionally large.
​https://bugs.webkit.org/show_bug.cgi?id=83317

Reviewed by Simon Fraser.

Source/WebCore:

An extremely large element causes problems with filters, either by
taking too long to compute the output or using too much memory. The
filter engine already has some constants for maximum expected size.
Make sure the render tree checks them before deciding to apply
effects.

Tests: css3/filters/huge-region-composited.html

css3/filters/huge-region.html

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):

  • rendering/FilterEffectRenderer.cpp:

(WebCore):
(WebCore::isFilterSizeValid):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::updateBackingStore):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):

LayoutTests:

  • css3/filters/huge-region-composited-expected.txt: Added.
  • css3/filters/huge-region-composited.html: Added.
  • css3/filters/huge-region-expected.txt: Added.
  • css3/filters/huge-region.html: Added.
2:45 PM Changeset in webkit [114171] by annacc@chromium.org
  • 11 edits in trunk

Queue the cuechange event on HTMLTrackElement for proper sorting.
​https://bugs.webkit.org/show_bug.cgi?id=83858

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updates to media/track/track-cues-cuechange.html and
media/track/track-mode.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Add HTMLTrackElement's cuechange event to the event queue rather than
firing it synchronously.

  • html/track/LoadableTextTrack.cpp:

Remove fireCueChangeEvent() as it is no longer used.

  • html/track/LoadableTextTrack.h:

Ditto.

  • html/track/TextTrack.h:

(TextTrack):

Ditto.

LayoutTests:

  • media/track/captions-webvtt/captions-fast.vtt:

Captions were a wee bit too fast: they need to be at least 250ms apart
for accurate testing as timeupdate events are only fired every 250ms.

  • media/track/track-cues-cuechange-expected.txt:

Changes the order that cuechange events are fired.

  • media/track/track-cues-cuechange.html:

Ditto.

  • media/track/track-mode-expected.txt:

cuechange events are now fired at the proper times.
Test now checks for all cuechange events (both enter and exit of cues).

  • media/track/track-mode.html:

Ditto.

2:32 PM Changeset in webkit [114170] by tonikitoo@webkit.org
  • 9 edits
    48 adds in trunk

Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map
​https://bugs.webkit.org/show_bug.cgi?id=79611

Reviewed by James Robinson.
Patch by Antonio Gomes <​agomes@rim.com>

Source/WebCore:

As of today, any FrameView attached to the Widget-tree or any
RenderLayer whose corresponding RenderBox's style has a 'overflow'
property set to 'auto' is cached in its containing scrollable areas set.
We could be more restrictive about what we in fact want to
cache as scrollable areas, by checking if the element as an overflow
(i.e. more content than its viewport).

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

Whenever the viewport changes, check if we have an scrollable/overflowed
content, and update the cache accordingly.

(WebCore::FrameView::setContentsSize):

Whenever the contents size changes, check if we have a scrollable/overflowed
content, and update the cache accordingly.

(WebCore::FrameView::calculateScrollbarModesForLayout):

Introduces a way to query for the scrollbars by only
taking into account the "rules" set by the web author.
For that, a new enum was added called SrollbarModesCalculationStrategy,
which allows callers to discard for example client-side scrollbar policies
in order to verify if a given frameview is scrollable or not.

(WebCore::FrameView::updateScrollableAreaSet):

Take into account various factors before considering a FrameView as
scrollable. If in the end it is, it gets added to its parent FrameView
scrollable areas map, otherwise removed.

(WebCore):
(WebCore::FrameView::addScrollableArea):

Became unneeded, thus removed.

(WebCore::FrameView::removeScrollableArea):

Whenever a FrameView is removed from the Widget-tree,
remove it from the cache.

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):

Update scrollable area set after layout.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

Update scrollable area set after style changes.

(WebCore::RenderLayer::styleChanged):

Removed the scrollable areas logic detection from it.

(WebCore::RenderLayer::updateScrollableAreaSet):

Updates the containing FrameView scrollable areas cache
only when needed (i.e. an overflow exists).

(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • testing/Internals.cpp:

(WebCore::Internals::numberOfScrollableAreas):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Tests: fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html

fast/scrolling/scrollable-area-frame-overflow-hidden.html
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-scrolling-no.html
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html
fast/scrolling/scrollable-area-frame-scrolling-yes.html
fast/scrolling/scrollable-area-frame-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-zero-size-and-border.html
fast/scrolling/scrollable-area-frame.html
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-display-none.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html
fast/scrolling/scrollable-area-overflow-auto-visibility-override.html
fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html
fast/scrolling/scrollable-area-overflow-auto.html
fast/scrolling/scrollable-area-overflow-not-set.html
fast/scrolling/scrollable-area-overflow-visible.html

LayoutTests:

Reviewed by NOBODY (OOPS!).

Added scrollable area set count tests to many situations observed
in real world sites.

  • fast/scrolling/resources/generic-scrollable-content.html: Added.
  • fast/scrolling/resources/hidden-generic-scrollable-content.html: Added.
  • fast/scrolling/resources/scrollable-area.js: Added.

(runTest):
(end):

  • fast/scrolling/resources/scrollable-style.css: Added.

(.inner):
(.offscreen):

  • fast/scrolling/scrollable-area-frame-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-inherited-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-overflow-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes-display-none-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes.html: Added.
  • fast/scrolling/scrollable-area-frame-visibility-hidden-child-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-visibility-hidden-child.html: Added.
  • fast/scrolling/scrollable-area-frame-zero-size-and-border-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-zero-size-and-border.html: Added.
  • fast/scrolling/scrollable-area-frame.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-override-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-override.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-visible-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto.html: Added.
  • fast/scrolling/scrollable-area-overflow-not-set-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-not-set.html: Added.
  • fast/scrolling/scrollable-area-overflow-visible-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-visible.html: Added.
2:32 PM April 2012 Meeting edited by jacobg@adobe.com
(diff)
2:29 PM Changeset in webkit [114169] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Make sure that we're using the right compiler for generating derived sources.

Rubber-stamped by Dan Bernstein.

  • WebKit2.xcodeproj/project.pbxproj:
2:23 PM Changeset in webkit [114168] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Track rem unit usage in StyleSheetInternal
​https://bugs.webkit.org/show_bug.cgi?id=83923

Reviewed by Andreas Kling.

Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to
the stylesheet instead so parser does not need to know about the document. This also
avoids setting the flag unnecessarily when the stylesheet is not used.

  • css/CSSGrammar.y:
  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):

  • css/CSSStyleSheet.h:

(WebCore::StyleSheetInternal::parserSetUsesRemUnits):
(WebCore::StyleSheetInternal::usesRemUnits):
(StyleSheetInternal):

  • dom/Document.cpp:

(WebCore):
(WebCore::checkUsesRemUnits):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

(WebCore::Document::usesRemUnits):

2:19 PM Changeset in webkit [114167] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations TIMOUT mask for fast/canvas/2d.imageDataHD.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [114166] by jamesr@google.com
  • 18 edits in trunk

[chromium] Remove unused compositeToTexture / compositeOffscreen setting
​https://bugs.webkit.org/show_bug.cgi?id=83733

Reviewed by Adrienne Walker.

Source/Platform:

Remove compositeOffscreen setting. This was an experiment that is no longer needed.

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

Source/WebKit/chromium:

Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Tools:

Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

1:57 PM Changeset in webkit [114165] by ap@apple.com
  • 5 edits in trunk

REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached
​https://bugs.webkit.org/show_bug.cgi?id=83925
<rdar://problem/11231790>

Reviewed by Antti Koivisto.

Added subtests to http/tests/cache/subresource-expiration-2.html.

  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::parseCacheControlDirectives): Honor first max-age instead of the last. New behavior matches both Firefox and IE.
1:43 PM Changeset in webkit [114164] by jamesr@google.com
  • 18 edits
    2 moves
    2 deletes in trunk/Source

[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
​https://bugs.webkit.org/show_bug.cgi?id=83851

Reviewed by Adam Barth.

Source/Platform:

Move WebVideoFrame API into Platform.

  • Platform.gypi:
  • chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

  • chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.

(WebKit):

Source/WebCore:

Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).

Covered by existing media/ and compositing/ layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebKit):

Source/WebKit/chromium:

Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.

  • WebKit.gyp:
  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp: Removed.
  • src/VideoFrameChromiumImpl.h: Removed.
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

12:43 PM Changeset in webkit [114163] by scheib@chromium.org
  • 6 edits
    1 add in trunk

Chromium: Should enable -webkit-image-set
​https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <​flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:39 PM Changeset in webkit [114162] by tomz@codeaurora.org
  • 6 edits
    12 adds in trunk/LayoutTests

Integrate IETC CSS : grid layout tests
​https://bugs.webkit.org/show_bug.cgi?id=83830

Patch by Dave Tharp < ​dtharp@codeaurora.org> on 2012-04-13
Reviewed by Adam Barth

  • ietestcenter/css3/grid/display-grid-001.htm: Added.
  • ietestcenter/css3/grid/display-grid-002.htm: Added.
  • ietestcenter/css3/grid/grid-column-001.htm: Added.
  • ietestcenter/css3/grid/grid-column-002.htm: Added.
  • ietestcenter/css3/grid/grid-column-003.htm: Added.
  • ietestcenter/css3/grid/grid-columns-001.htm: Added.
  • ietestcenter/css3/grid/grid-items-001.htm: Added.
  • ietestcenter/css3/grid/grid-items-002.htm: Added.
  • ietestcenter/css3/grid/grid-items-003.htm: Added.
  • ietestcenter/css3/grid/grid-items-004.htm: Added.
  • ietestcenter/css3/grid/grid-items-005.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
12:34 PM Changeset in webkit [114161] by Lucas Forschler
  • 3 edits
    3 copies in tags/Safari-536.6.2

Merged r113941.

12:33 PM Changeset in webkit [114160] by Michael Nordman
  • 12 edits
    5 deletes in trunk/Source

[chromium] Now that the chromium port is using a different dom_storage backend
library in its main browser process, there are a handful of files that should no
longer be included in the build, and a few files than should be deleted
outright, and the webkit api should be modified to reflect the new (and smaller)
contract between the embedder and webkit/webcore.
​https://bugs.webkit.org/show_bug.cgi?id=83807

Reviewed by Adam Barth.

Source/WebCore:

No new tests, existing tests apply.

  • WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
  • storage/StorageEventDispatcher.h: Delete a stale comment.

Source/WebKit/chromium:

  • WebKit.gyp: Delete a few files.
  • public/WebStorageNamespace.h: Remove some unused data members and methods, and annotate close() as deprecated.
  • public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
  • src/StorageAreaProxy.cpp: Remove the include of a deleted file.
  • src/StorageEventDispatcherChromium.cpp: Removed.
  • src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
  • src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
  • src/StorageNamespaceProxy.h: Moved some blank lines around.
  • src/WebStorageAreaImpl.cpp: Removed.
  • src/WebStorageAreaImpl.h: Removed.
  • src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
  • src/WebStorageNamespaceImpl.cpp: Removed.
  • src/WebStorageNamespaceImpl.h: Removed.
12:32 PM Changeset in webkit [114159] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaselining after r114150.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
12:26 PM Changeset in webkit [114158] by rniwa@webkit.org
  • 3 edits in trunk/Tools

webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
and also rebaseline the test results since we ignore the first run now.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.run):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPageLoadingPerfTest.test_run):

12:24 PM Changeset in webkit [114157] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch get_by_id/put_by_id
​https://bugs.webkit.org/show_bug.cgi?id=83924

Reviewed by Oliver Hunt.

Store offsets in the structure stub info, as we do for the DFG JIT.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::differenceBetween):

  • this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)
  • bytecode/StructureStubInfo.h:
    • added new fields for baseline JIT offsets.
  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • moved out from JIT::privateCompile.

(JSC::JIT::privateCompile):

  • moved out code to PropertyStubCompilationInfo::copyToStubInfo.
  • jit/JIT.h:

(PropertyStubCompilationInfo):

  • added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
  • removed many offsets.
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • changed code generation to use new interface to store info on PropertyStubCompilationInfo.
  • changed repatch functions to read offsets from the structure stub info.
  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • changed code generation to use new interface to store info on PropertyStubCompilationInfo.
  • changed repatch functions to read offsets from the structure stub info.
12:21 PM Changeset in webkit [114156] by Lucas Forschler
  • 4 edits in tags/Safari-536.6.2/Source

Versioning.

12:20 PM Changeset in webkit [114155] by Lucas Forschler
  • 1 copy in tags/Safari-536.6.2

New Tag.

12:19 PM Changeset in webkit [114154] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

More rebaselining.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
12:02 PM Changeset in webkit [114153] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix some compiler warnings (miscellaneous)
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

Fix signed/unsigned comparison warning.

  • parser/Lexer.cpp:

(JSC::::record16):

11:49 AM Changeset in webkit [114152] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Include the error if we fail to initialize the web process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=83927

Reviewed by Alexey Proskuryakov.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

11:26 AM Changeset in webkit [114151] by scheib@chromium.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r114140.
​http://trac.webkit.org/changeset/114140
​https://bugs.webkit.org/show_bug.cgi?id=83921

Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:25 AM PrefixedAPIs edited by mitz@apple.com
Added CanvasRenderingContext2D extensions for high-resolution backing … (diff)
11:20 AM Changeset in webkit [114150] by mitz@apple.com
  • 13 edits
    4 adds in trunk

<rdar://problem/10912680> Pixel access canvas APIs do not operate at backing store resolution
​https://bugs.webkit.org/show_bug.cgi?id=83836

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/2d.imageDataHD.html

Added getImageDataHD and putImageDataHD functions to CanvasRenderingContext2D, as proposed in
<​http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The functions
are prefixed with “webkit” for now.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData): Added this cover function that calls
through to getImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Added. Calls through to
getImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::getImageData): Added a CoordinateSystem parameter to this
now-private function. It is passed through to ImageBuffer::getUnmultipliedImageData().
(WebCore::CanvasRenderingContext2D::putImageData): Added this cover function that calls
through to putImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Added. Calls through to
putImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::putImageData): Added a CoordinateSystem parameter to this
function. It is passed through to ImageBuffer::putByteArray, and used to compute the rect to
invalidate after the drawing operation.

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Added webkitPutImageDataHD() and

webkitGetImageDataHD().

  • platform/graphics/ImageBuffer.h: Added a CoordinateSystem enum with the values

LogicalCoordinateSystem and BackingStoreCoordinateSystem. Added a CoordinateSystem parameter,
which defaults to LogicalCoordinateSystem, to getUnmultipliedImageData,
getPremultipliedImageData, and putByteArray.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData): Now uses the CoordinateSystem parameter to
decide whether to ask ImageBufferDaya::getData() to apply the resolution scale or not.
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Now uses the CoordinateSystem parameter to decide
whether to maintain the resolution scale while drawing or not.
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

LayoutTests:

  • fast/canvas/2d.imageDataHD-expected.txt: Added.
  • fast/canvas/2d.imageDataHD.html: Added.
11:16 AM Changeset in webkit [114149] by rniwa@webkit.org
  • 6 edits
    1 add in trunk

Enable SVG page loading performance tests
​https://bugs.webkit.org/show_bug.cgi?id=83861

Reviewed by Adam Barth.

PerformanceTests:

Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
and the ones that take too long to load (more than 20s).

  • Skipped:

Tools:

Add support for page loading tests. These are tests without any test running harnesses, and we use
DriverOutput's test_timeout to measure the loading time.

Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.run):
(PerfTest):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest): Added.
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.

(MockPrinter):
(MockPrinter.init):
(MockPrinter.write):
(MainTest):
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.assertWritten):
(TestPageLoadingPerfTest.MockDriver):
(TestPageLoadingPerfTest.MockDriver.init):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests_with_page_load_svg):
(test_collect_tests_with_page_load_svg.add_file):

11:15 AM Changeset in webkit [114148] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline a test.

  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
11:06 AM Changeset in webkit [114147] by shawnsingh@chromium.org
  • 12 edits
    2 adds in trunk/Source/WebCore

[chromium] Support CCHeadsUpDisplay in threaded compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=67499

Reviewed by James Robinson.

No new tests because this code is debugging code itself.

The last item that was needed to make the CCHeadsUpDisplay work in
threaded compositing mode was to remove the font rendering code
used on the impl-side thread. To solve this, this patch adds a
CCFontAtlas that is initialized on the main thread (where the font
rendering takes place). Then, when the HUD draws text on the impl
thread, it uses the font atlas directly.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCFontAtlas.cpp: Added.

(WebCore):
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::wrapPositionIfNeeded):
(WebCore::CCFontAtlas::generateAtlasForFont):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):

  • platform/graphics/chromium/cc/CCFontAtlas.h: Added.

(WebCore):
(CCFontAtlas):
(WebCore::CCFontAtlas::create):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(WebCore::CCLayerTreeHost::headsUpDisplayFontAtlas):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

11:06 AM Changeset in webkit [114146] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed - remove duplicate entries for two failing sputnik tests
from the test_expectations.txt file.

  • platform/gtk/test_expectations.txt:
11:03 AM Changeset in webkit [114145] by jchaffraix@webkit.org
  • 11 edits
    8 copies in branches/chromium/1084

Merge 112582 - REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
​https://bugs.webkit.org/show_bug.cgi?id=82129

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html

fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html

This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.

LayoutTests:

  • fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
  • fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
  • fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
  • fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
  • fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
  • fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
  • fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
  • fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.

Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.

  • platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:

Rebaselined those tests on Chromium linux (new layers).

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:

Skipped the previous tests on the other platforms.

TBR=​jchaffraix@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10090001

10:47 AM Changeset in webkit [114144] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
​https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Previous clean up in r114137 dropped a WIN IMAGE failure suppression.

  • platform/chromium/test_expectations.txt:
10:46 AM Changeset in webkit [114143] by beidson@apple.com
  • 18 edits
    2 adds in trunk

<rdar://problem/11176921> and ​https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache

Source/WebKit2:

  • Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified of back/forward navigations (and deny them if it chooses)
  • Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.

Reviewed by Darin Adler.

Add the new WKBundleBackForwardListItem API:

  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemIsInPageCache):

  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::isInPageCache):

Update the UI page loader client to allow for a user data object to be passed from the bundle:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willGoToBackForwardListItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Add the new callback to the bundle loader client:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient):

Call the bundle client before doing anything else, possibly canceling the navigation:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.

Tools:

Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.

Reviewed by Darin Adler.

  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.

(ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::shouldGoToBackForwardListItemCallback):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.

10:43 AM Changeset in webkit [114142] by harrison@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

<rdar://problem/10552398> Meringue: 11A390: CrashTracer: 56,187 crashes in WebProcess at com.apple.WebCore: WebCore::DocumentWriter::deprecatedFrameEncoding const + 12 (71828)

Reviewed by Darin Adler.

No new tests because this change is going only on the Safari Nectarine branch, not TOT.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
Nil check the activeDocumentLoader().

10:40 AM Changeset in webkit [114141] by abarth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Update baselines to make this test run again.

  • platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Replaced.
  • platform/chromium/test_expectations.txt:
10:20 AM Changeset in webkit [114140] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

Chromium: Should enable -webkit-image-set
​https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <​flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt:
9:16 AM Changeset in webkit [114139] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as even flakier: it can timeout.

Unreviewed.

  • platform/chromium/test_expectations.txt:
9:05 AM Changeset in webkit [114138] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag fast/regions

again. Only parts of it were passing, sigh.

8:49 AM Changeset in webkit [114137] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
​https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Consolidating common-cause flaky tests.

  • platform/chromium/test_expectations.txt:
8:42 AM Changeset in webkit [114136] by eae@chromium.org
  • 1794 edits
    1801 copies
    80 deletes in branches/subpixellayout

Merge trunk changes up until 114126 into subpixel branch.

8:41 AM Changeset in webkit [114135] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: do not attempt to load content from resource until request finished loading.
​https://bugs.webkit.org/show_bug.cgi?id=83896

Reviewed by Yury Semikhatsky.

Source/WebCore:

When we stop in the inline script on reload, we should only show concatenated script content.
When we resume, we should replace UI source code with the actual HTML content. We should not attempt to
fetch resource content until request finished loading. I regressed it in the Request extraction
and now am bringing it back.

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
8:40 AM Changeset in webkit [114134] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Unskip fast/regions and

svg/hixie/perf that seem to pass fine on GTK bots.

7:33 AM Changeset in webkit [114133] by pfeldman@chromium.org
  • 4 edits in trunk

Web Inspector: follow up to r114116 - fixing QT test
​https://bugs.webkit.org/show_bug.cgi?id=83892

Reviewed by Yury Semikhatsky.

Source/WebCore:

Requesting content for the scripts exclusively via the page agent now.

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.requestContent):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
7:30 AM Changeset in webkit [114132] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Group EFL bots into a category on the buildbot master
​https://bugs.webkit.org/show_bug.cgi?id=82712

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-04-13
Reviewed by Adam Roben.

Creating a new category definition on the buildbot frontend.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig): Determine category for EFL bots

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
7:28 AM Changeset in webkit [114131] by yi.4.shen@nokia.com
  • 5 edits in trunk

InsertHTML fails to insert h6 if the insertion point is before some text.
​https://bugs.webkit.org/show_bug.cgi?id=82689

Reviewed by Ryosuke Niwa.

Added the missing h6 tag for the isHeaderElement.

Source/WebCore:

No new tests: updated existing test (editing/execCommand/4128080-1.html)

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isHeaderElement):

LayoutTests:

  • editing/execCommand/4128080-1-expected.txt:
  • editing/execCommand/4128080-1.html:
7:25 AM Changeset in webkit [114130] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2012-04-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Build fix after r114126.

  • WebKit.gyp:
7:23 AM Changeset in webkit [114129] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
​https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-04-13
Reviewed by Noam Rosenthal.

This fixes API tests broken by r113715.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
7:18 AM Changeset in webkit [114128] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Marking some css2.1 tests flaky.
7:16 AM Changeset in webkit [114127] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
6:50 AM Changeset in webkit [114126] by yurys@chromium.org
  • 19 edits
    1 add
    2 deletes in trunk

Web Inspector: exception in heap profiler when expanding a class in summary view
​https://bugs.webkit.org/show_bug.cgi?id=83883

Moved all DOM-specific inspector utilities into DOMExtension.js

Merged BinarySearch.js and PartialQuickSort.js into utilities.js, HeapSnapshotWorker.js now
imports utilities.js which contains all required routines.

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/BinarySearch.js: Removed.
  • inspector/front-end/DOMExtension.js: Copied from Source/WebCore/inspector/front-end/utilities.js.

(Node.prototype.rangeOfWord):
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
(Element.prototype.removeStyleClass):
(Element.prototype.removeMatchingStyleClasses):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
(Element.prototype.positionAt):
(Element.prototype.pruneEmptyTextNodes):
(Element.prototype.isScrolledToBottom):
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray):
(Node.prototype.enclosingNodeOrSelfWithNodeName):
(Node.prototype.enclosingNodeOrSelfWithClass):
(Node.prototype.enclosingNodeWithClass):
(Element.prototype.query):
(Element.prototype.removeChildren):
(Element.prototype.isInsertionCaretInside):
(Element.prototype.createChild):
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):
(Element.prototype.boxInWindow):
(Element.prototype.setTextAndTitle):
(Event.prototype.consume):
(Text.prototype.select):
(Element.prototype.selectionLeftOffset):
(Node.prototype.isAncestor):
(Node.prototype.isDescendant):
(Node.prototype.isSelfOrAncestor):
(Node.prototype.isSelfOrDescendant):
(Node.prototype.traverseNextNode):
(Node.prototype.traversePreviousNode):
(HTMLTextAreaElement.prototype.moveCursorToEnd):
(isEnterKey):
(consumeEvent):
(highlightSearchResult):
(highlightSearchResults):
(highlightRangesWithStyleClass):
(applyDomChanges):
(revertDomChanges):

  • inspector/front-end/HeapSnapshot.js: Fixed a couple of js compiler warnings

by describing structure of heap snapshot header in the protocol.
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

  • inspector/front-end/HeapSnapshotWorker.js:
  • inspector/front-end/PartialQuickSort.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js:

(.):

6:45 AM Changeset in webkit [114125] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
6:26 AM Changeset in webkit [114124] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r113714.
​http://trac.webkit.org/changeset/113714
​https://bugs.webkit.org/show_bug.cgi?id=83887

It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

Source/WebKit2:

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

6:16 AM Changeset in webkit [114123] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r114103.
​http://trac.webkit.org/changeset/114103
​https://bugs.webkit.org/show_bug.cgi?id=83884

New breakpoint UI looks bad / needs polish. (Requested by
pfeldman_ on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/textViewer.css:

(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

6:14 AM Changeset in webkit [114122] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
​https://bugs.webkit.org/show_bug.cgi?id=83760

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-04-13
Reviewed by George Staikos.

.:

  • ManualTests/blackberry/http-cookie-database-set.php: Added.
  • ManualTests/blackberry/http-cookie-database-update.php: Added.

Source/WebCore:

When we update cookies' database, protocol shouldn't be checked since it is not a cookie's key.
ESPN.com's https cookies should replace old http cookies if they have the same keys(name, path, domain).

We must restart the browser to test, so have to write a manual test case.

Test: ManualTests/blackberry/http-cookie-database-set.php

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::invokeOpen):

6:06 AM Changeset in webkit [114121] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
6:01 AM Changeset in webkit [114120] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Tools

webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
​https://bugs.webkit.org/show_bug.cgi?id=83690

Reviewed by Tor Arne Vestbø.

Typing part of an email and pressing <TAB> will bash-complete it using the list in
Tools/Scripts/webkitpy/common/config/committers.py

  • Scripts/webkit-tools-completion.sh:
5:57 AM Changeset in webkit [114119] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.

Patch by Balazs Ankes <​bank@inf.u-szeged.hu> on 2012-04-13
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
5:56 AM Changeset in webkit [114118] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Source

[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
​https://bugs.webkit.org/show_bug.cgi?id=83770

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Revert the previous way of dealing with things. The problem is that different layers
would end up rounding in different directions, and would cause jittering between
layers or with the QQuickWebPage's background.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

Source/WebKit2:

  • Do the alignment on the highest level as possible: the QQuickFlickable content item position. It already supports this with setPixelAligned which rounds the content item's position.
  • Also move the setClip(true) to the common constructor as this constructor is currently only used by WTR.
  • Remove setFlags(QQuickItem::ItemClipsChildrenToShape) as it is redundant with setClip(true).
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

5:25 AM Changeset in webkit [114117] by pfeldman@chromium.org
  • 15 edits in trunk

Web Inspector: introduce ParsedURL type, clean up url and displayName mess in Resource and NetworkRequest.
​https://bugs.webkit.org/show_bug.cgi?id=83871

Reviewed by Yury Semikhatsky.

Source/WebCore:

There is a number of random properties created on Resource and NetworkRequest that represent various url
fragments. Display name is being based on them and sometimes requires fake Resource instance to be created.
This change (officially) introduces WebInspector.ParsedURL as a type that encapsulates this complexity.

This change also moves documentURL property into the Resource and NetworkRequest constructors and brushes up
factory methods used to create the objects.

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):

  • inspector/front-end/Database.js:

(WebInspector.Database.prototype.get displayDomain):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.get documentURL):
(WebInspector.NetworkRequest.prototype.get parsedURL):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):

  • inspector/front-end/RequestHeadersView.js:

(WebInspector.RequestHeadersView.prototype._refreshUrlFragment):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get parsedURL):
(WebInspector.Resource.prototype.get frameId):
(WebInspector.Resource.prototype.get loaderId):
(WebInspector.Resource.prototype.get displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeFrame.prototype._addRequest):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
(WebInspector.displayDomain):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/debugger/raw-source-code.html:
5:15 AM Changeset in webkit [114116] by pfeldman@chromium.org
  • 11 edits in trunk

Web Inspector: extracting NetworkRequest from Resource (step 3)
​https://bugs.webkit.org/show_bug.cgi?id=83802

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change extracts NetworkRequest from the Resource. It is now clear that these two
should have super class that would be responsible for parsing URL and would define the
requestContent signature. Corresponding patch will follow.

  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.get requestId):
(WebInspector.NetworkRequest.prototype.set requestId):
(WebInspector.NetworkRequest.prototype.get url):
(WebInspector.NetworkRequest.prototype.get frameId):
(WebInspector.NetworkRequest.prototype.get loaderId):
(WebInspector.NetworkRequest.prototype.get startTime):
(WebInspector.NetworkRequest.prototype.set startTime):
(WebInspector.NetworkRequest.prototype.get responseReceivedTime):
(WebInspector.NetworkRequest.prototype.set responseReceivedTime):
(WebInspector.NetworkRequest.prototype.get endTime):
(WebInspector.NetworkRequest.prototype.set endTime):
(WebInspector.NetworkRequest.prototype.get duration):
(WebInspector.NetworkRequest.prototype.get latency):
(WebInspector.NetworkRequest.prototype.get receiveDuration):
(WebInspector.NetworkRequest.prototype.get resourceSize):
(WebInspector.NetworkRequest.prototype.set resourceSize):
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.increaseTransferSize):
(WebInspector.NetworkRequest.prototype.get finished):
(WebInspector.NetworkRequest.prototype.set finished):
(WebInspector.NetworkRequest.prototype.get failed):
(WebInspector.NetworkRequest.prototype.set failed):
(WebInspector.NetworkRequest.prototype.get canceled):
(WebInspector.NetworkRequest.prototype.set canceled):
(WebInspector.NetworkRequest.prototype.get cached):
(WebInspector.NetworkRequest.prototype.set cached):
(WebInspector.NetworkRequest.prototype.get timing):
(WebInspector.NetworkRequest.prototype.set timing):
(WebInspector.NetworkRequest.prototype.get mimeType):
(WebInspector.NetworkRequest.prototype.set mimeType):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
(WebInspector.NetworkRequest.prototype.get displayDomain):
(WebInspector.NetworkRequest.prototype.get type):
(WebInspector.NetworkRequest.prototype.set type):
(WebInspector.NetworkRequest.prototype.get redirectSource):
(WebInspector.NetworkRequest.prototype.set redirectSource):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.set requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.set requestHeadersText):
(WebInspector.NetworkRequest.prototype.get requestHeadersSize):
(WebInspector.NetworkRequest.prototype.requestHeaderValue):
(WebInspector.NetworkRequest.prototype.get requestCookies):
(WebInspector.NetworkRequest.prototype.get requestFormData):
(WebInspector.NetworkRequest.prototype.set requestFormData):
(WebInspector.NetworkRequest.prototype.get requestHttpVersion):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.set responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype.set responseHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersSize):
(WebInspector.NetworkRequest.prototype.responseHeaderValue):
(WebInspector.NetworkRequest.prototype.get responseCookies):
(WebInspector.NetworkRequest.prototype.get queryParameters):
(WebInspector.NetworkRequest.prototype.get formParameters):
(WebInspector.NetworkRequest.prototype.get responseHttpVersion):
(WebInspector.NetworkRequest.prototype._parseParameters):
(WebInspector.NetworkRequest.prototype._headerValue):
(WebInspector.NetworkRequest.prototype.get content):
(WebInspector.NetworkRequest.prototype.get contentEncoded):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.isHttpFamily):
(WebInspector.NetworkRequest.prototype.requestContentType):
(WebInspector.NetworkRequest.prototype.isPingRequest):
(WebInspector.NetworkRequest.prototype.hasErrorStatusCode):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._contentURL):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
(WebInspector.NetworkRequest.prototype.setResource):
(WebInspector.NetworkRequest.prototype.resource):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._resourceAdded):
(WebInspector.RawSourceCode.prototype.forceUpdateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get type):
(WebInspector.Resource.prototype.get mimeType):
(WebInspector.Resource.prototype.set mimeType):
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/set-breakpoint.html:
  • inspector/debugger/source-frame.html:
5:12 AM Changeset in webkit [114115] by reed@google.com
  • 2 edits in trunk/Source/WebCore

use getClipDeviceBounds, rather than (deprecated) getTotalClip
​https://bugs.webkit.org/show_bug.cgi?id=83808

Reviewed by Stephen White.

Equivalent functionality, existing tests apply.

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::didDraw):

5:02 AM Changeset in webkit [114114] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
4:44 AM Changeset in webkit [114113] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

[EFL] Add API for color chooser
​https://bugs.webkit.org/show_bug.cgi?id=83692

.:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • PlatformEfl.cmake:
  • platform/efl/ColorChooserEfl.cpp: Added.

(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):

  • platform/efl/ColorChooserEfl.h: Added.

(WebCore):
(ColorChooserEfl):

Source/WebKit/efl:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):
(WebCore::ChromeClientEfl::createColorChooser):
(WebCore::ChromeClientEfl::removeColorChooser):
(WebCore::ChromeClientEfl::updateColorChooser):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • ewk/ewk_private.h:

(WebCore):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):

  • ewk/ewk_view.h:

Tools:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit:
4:25 AM Changeset in webkit [114112] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt:
4:19 AM Changeset in webkit [114111] by antonm@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Linux rebaselines.

Unreviewed.

  • platform/chromium-linux/platform/chromium/compositing/filters: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
4:16 AM Changeset in webkit [114110] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Build fix with QT_NO_BEARERMANAGEMENT

Reviewed by Jocelyn Turcotte.

4:11 AM Changeset in webkit [114109] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
​https://bugs.webkit.org/show_bug.cgi?id=83860

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.

Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html

  • page/FrameView.cpp:

(WebCore::FrameView::delegatesScrollingDidChange):

LayoutTests:

  • fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
  • fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.
4:09 AM Changeset in webkit [114108] by keishi@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add WebKit API to access <datalist> options
​https://bugs.webkit.org/show_bug.cgi?id=83762

Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.

Reviewed by Kent Tamura.

  • public/WebInputElement.h:

(WebKit):
(WebInputElement):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.

4:00 AM April 2012 Meeting edited by zherczeg@inf.u-szeged.hu
(diff)
3:39 AM Changeset in webkit [114107] by Philippe Normand
  • 2 edits
    64 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.

  • platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
  • platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/gtk/fast/dom/gc-10-expected.txt: Added.
  • platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
  • platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
  • platform/gtk/fast/images/exif-orientation-expected.txt: Added.
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
  • platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
  • platform/gtk/fast/text/hyphens-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
  • platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Mark a media/track test flaky.
3:37 AM Changeset in webkit [114106] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix build on OS X

We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.

Reviewed by Simon Hausmann.

3:29 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
3:23 AM Changeset in webkit [114105] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

New suppression.

Unreviewed.

  • platform/chromium/test_expectations.txt:
3:11 AM Changeset in webkit [114104] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.
3:10 AM Changeset in webkit [114103] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Line number is not displayed while debugging javascript
​https://bugs.webkit.org/show_bug.cgi?id=83786

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.

Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view

No additional test cases required for the above fix.

  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/textViewer.css:

(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

2:37 AM Changeset in webkit [114102] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Now test sometimes crashes in Debug on XP too.

Unreviewed.

  • platform/chromium/test_expectations.txt:
2:15 AM Changeset in webkit [114101] by tkent@chromium.org
  • 7 edits in trunk/Source

Add a runtime flag for <input type=date>
​https://bugs.webkit.org/show_bug.cgi?id=83853

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled): Added.

  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):
Don't register type=date if !RuntimeEnabledFeatures::inputTypeDateEnabled()

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures): Add enableInputTypeDate() and isInputTypeDateEnabled().

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDate): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateEnabled): Added.

2:12 AM Changeset in webkit [114100] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Skip failing new

encrypted-media test.

1:58 AM Changeset in webkit [114099] by antonm@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • platform/chromium-mac/fast/ruby/nested-ruby-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/002-expected.png: Added.
  • platform/chromium-mac/fast/text/international/002-expected.txt: Added.
1:57 AM Changeset in webkit [114098] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

JSDocument::setLocation does too much bare-handed lifting
​https://bugs.webkit.org/show_bug.cgi?id=83850

Reviewed by Sam Weinig.

As part of auditing all the ways of kicking off a navigation, I
happened to read JSDocument::setLocation, which uses very old patterns.
This patch updates it to do things the "modern" way. There shouldn't
be any behavior change.

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

1:55 AM Changeset in webkit [114097] by antonm@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • platform/chromium-win/platform/chromium/compositing/filters: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
1:44 AM Changeset in webkit [114096] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
1:39 AM Changeset in webkit [114095] by shinyak@chromium.org
  • 5 edits
    4 adds in trunk

Background width (or height) is wrong if width (or height) * zoom < 1.
​https://bugs.webkit.org/show_bug.cgi?id=83350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.

Since CachedImage has already similar code, we moved it to IntSize and shared it.

Tests: fast/css/zoom-background-repeat-x-expected.html

fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/IntSize.h:

(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

LayoutTests:

  • fast/css/zoom-background-repeat-x-expected.html: Added.
  • fast/css/zoom-background-repeat-x.html: Added.
  • fast/css/zoom-background-repeat-y-expected.html: Added.
  • fast/css/zoom-background-repeat-y.html: Added.
12:56 AM Changeset in webkit [114094] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-13

  • DEPS:
12:53 AM Changeset in webkit [114093] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Prepare submitForm for seamless navigation
​https://bugs.webkit.org/show_bug.cgi?id=83838

Reviewed by Ryosuke Niwa.

Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately. This patch refactors this function
to call findFrameForNavigation, which does both checks.

This doesn't change any behavior today, but it prepares us to implement
seamless navigation. Once the seamless branch lands, this change will
be tested by seamless-form-* in ​https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless

For context, see:
​https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):

12:35 AM Changeset in webkit [114092] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Should clear an invalid string in a date field on blur
​https://bugs.webkit.org/show_bug.cgi?id=83863

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/forms/date/input-date-commit-valid-only.html

  • html/DateInputType.cpp:

(WebCore::DateInputType::handleBlurEvent):
Reset the visible value. The code is same as NumberInputType::handleBlurEvent().

LayoutTests:

  • fast/forms/date/input-date-commit-valid-only-expected.txt: Added.
  • fast/forms/date/input-date-commit-valid-only.html: Added.
12:30 AM Changeset in webkit [114091] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] <input type=date> tests should pass.

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.