Timeline
Apr 21, 2012:
- 6:36 PM Acronyms edited by
- Add DFG, NRWT, ORWT and WTF (diff)
- 6:26 PM Porting Macros plan edited by
- Remove obsolete ENABLE flag names (diff)
- 5:18 PM Changeset in webkit [114856] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/GraphicsLayer.cpp
Merge 112939
BUG=121524
Review URL: https://chromiumcodereview.appspot.com/10169026
- 5:18 PM Changeset in webkit [114855] by
-
- 22 edits in trunk/Source
Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477
<rdar://problem/10912431>
Reviewed by Jian Li.
Source/WebCore:
Tests will be added once there is support for web notifications on the Mac ports.
- WebCore.exp.in: Export finalize() function.
Modify Dictionary to support creation of event listeners.
- bindings/js/Dictionary.h:
(WebCore::Dictionary::isObject): Return true if the JSDictionary is valid.
(WebCore::Dictionary::isUndefinedOrNull): Return true if the JSDictionary is not valid.
(WebCore::Dictionary::get): Add convenience function to take const char* for
property name, to prevent having to do implicit conversion to WTF::String.
(WebCore::Dictionary::getEventListener): Add function to create event listener
from the dictionary.
(WebCore::Dictionary::asJSObject): Helper to convert WebCore objects to JS wrapper.
- bindings/js/Dictionary.cpp:
(WebCore::Notification): Implement asJSObject() for Notification.
- bindings/js/JSDictionary.h:
(WebCore::JSDictionary::execState): Expose the exec state so that the Dictionary
can obtain its world for creating the event listener.
- bindings/v8/Dictionary.h:
(WebCore::Dictionary::getEventListener): Stub implementation.
Add new constructor to idl definitions.
- notifications/DOMWindowNotifications.idl: Add Notification constructor, if
ENABLE(NOTIFICATIONS) is on.
- notifications/Notification.idl: If ENABLE(NOTIFICATIONS) is turned on, define
the constructor. Otherwise, use OmitConstructor.
- notifications/NotificationCenter.idl: Wrap creation functions in
ENABLE(LEGACY_NOTIFICATIONS).
- notifications/NotificationCenter.h: Ditto.
(NotificationCenter):
- notifications/Notification.h:
(Notification): Wrap legacy constructors in ENABLE(LEGACY_NOTIFICATIONS).
(WebCore::Notification::create): New creation function based on discussions in WG.
- notifications/Notification.cpp:
(WebCore::getAndAddEventListener): Helper function to get the listener from the
dictionary, and attach to the notification.
(WebCore::Notification::create): Create the notification, then apply whatever
properties can be found in the dictionary to the notification. In order to
attach the event listeners, the notification has to have been created, which is
why this all happens in the factory method and not in the constructor.
(WebCore::Notification::setBody): Added so that it can be set if we find it in the
dictionary.
The new constructor queues a task to show when it is created. To support this, we
use a one-shot timer that calls show() in the next iteration of the run loop.
(WebCore::Notification::Notification): Start the timer.
(WebCore::Notification::showTaskTimerFired): Call show().
Notifications, not being attached to the DOM, could be GC'ed by the JS engine
before its life cycle has completed. We add calls to setPendingActivity() when the
notification has been shown, and when it is closed, we unsetPendingActivity().
To guarantee that we only call this once, we add a new state to the Notification
state machine, called NotificationState::Closed.
(WebCore::Notification::show): Call setPendingActivity() for all ports. Remove conditional on Mac.
(WebCore::Notification::close): Include Closed state to machine; do nothing.
(WebCore::Notification::dispatchCloseEvent): Call finalize().
(WebCore::Notification::finalize): If the state is not Closed, we unsetPendingActivity()
to make it available for GC.
(WebCore::Notification::finishLoading): Remove the unsetPendingActivity(). That call
was to balance the setPendingActivity() called for loading the icon. Instead of wrapping
around the icon load, we wrap around the show() -> finalize() loop.
In Notification, rename some of the stages and functions to more clearly communicate
that they mostly deal with the icon of the notification, instead of general loading.
(WebCore::Notification::show): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::close): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::~Notification): Refactor to use LoadingIcon.
(WebCore::Notification::startLoadingIcon): Renamed from startLoading().
(WebCore::Notification::stopLoadingIcon): Renamed from stopLoading().
(WebCore::Notification::finishLoadingIcon): Renamed from finishLoading().
(WebCore::Notification::didFinishLoading):
(WebCore::Notification::didFail):
(WebCore::Notification::didFailRedirectCheck):
(WebCore::Notification::didReceiveResponse):
(WebCore::Notification::finishLoading):
Add Dictionary.cpp.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
Fix bug in V8 bindings generation code. If the constructor doesn't raise an exception,
don't use an exception code.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestObj.cpp: Reset results.
(WebCore::TestObjV8Internal::optionsObjectCallback):
Source/WebKit/mac:
- WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::clearNotifications): When clearing notifications, finalize
them so that they can be cleaned up by the GC.
Source/WebKit2:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): If the notification doesn't get shown,
we should return false, since it will not go through a setPendingActivity cycle.
(WebKit::WebNotificationManager::clearNotifications): When clearing notifications,
finalize them so that they can be cleaned up by the GC.
- 5:01 PM Changeset in webkit [114854] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10170019
- 4:59 PM Changeset in webkit [114853] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10164022
- 4:56 PM Changeset in webkit [114852] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 113229
BUG=99229
Review URL: https://chromiumcodereview.appspot.com/10165023
- 4:54 PM Changeset in webkit [114851] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 113670
BUG=117110
Review URL: https://chromiumcodereview.appspot.com/10170018
- 4:52 PM Changeset in webkit [114850] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 113670
BUG=117110
Review URL: https://chromiumcodereview.appspot.com/10166026
- 4:19 PM Changeset in webkit [114849] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Don't hard code the plugins that blackberry supports.
https://bugs.webkit.org/show_bug.cgi?id=84535
Use the existing PluginDatabase to query for the plugins we can handle.
The original implemention of FrameLoaderClientBlackBerry::createPlugin
was a partial copy from another port. In the Qt port there is some
workarounds for flash which is why this exists there. Sadly the bits
that were copied made it so only flash worked, but as flash was the only
plugin on the system this issue was not noticed until QNX tried to get
jnext working. Tracing it down to this bit of code rather then
correcting it they hardcoded the jnext into the same block as flash was.
The blackberry port isn't specifically suppose to only allow jnext and
flash, but was an accident due to the way this code was developed.
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createPlugin):
- 3:40 PM Changeset in webkit [114848] by
-
- 2 edits in trunk/Source/WebCore
Support loading the same plugin in multiple locations in the Blackberry port.
https://bugs.webkit.org/show_bug.cgi?id=84537
The hash for the plugin is only based upon the plugin meta information
which will be the same for the same plugin in the system and user's
plugin folders.
It looks like this code was copied/based on the windows port
which doesn't allow the same plugin to be loaded more than once.
Because we want to support multiple copies of the same plugin
in the blackberry port we want to incorperate the path of the plugin
into the hash.
PR 150404
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.
- plugins/blackberry/PluginPackageBlackBerry.cpp:
(WebCore::PluginPackage::hash):
- 3:02 PM Changeset in webkit [114847] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium roll attempt from r133173 to r133348.
- DEPS:
- 1:11 PM Changeset in webkit [114846] by
-
- 2 edits in trunk/Source/WebCore
System plugins are preferred over application plugins
https://bugs.webkit.org/show_bug.cgi?id=84538
Set the preferred paths for plugins so that plugins that reside
inside of the bar will be preferred over plugins that are in the
system folder.
PR 150404
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::isPreferredPluginDirectory):
- 1:03 PM Changeset in webkit [114845] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523
Reviewed by Oliver Hunt.
Profiles showed that checks against -1 were costly, and I saw they could be eliminated.
Streamlined this code to use standard character types and 0 rather than -1. One benefit
of this is that there's no widening and narrowing. Another is that there are many cases
where we already have the correct behavior for 0, so can eliminate a branch that was
used to test for -1 before. Also eliminates typecasts in the code.
- parser/Lexer.cpp:
(JSC::Lexer::invalidCharacterMessage): Updated use of String::format since m_current is now a
character type, not an int.
(JSC::Lexer::setCode): Use 0 rather than -1 when past the end.
(JSC::Lexer::shift): Ditto. Also spruced up the comment a bit.
(JSC::Lexer::atEnd): Added. New function that distinguishes an actual 0 character from the end
of the code. This can be used places we used to cheeck for -1.
(JSC::Lexer::peek): Updated to use -1 instead of 0. Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Changed to use character types instead of int.
(JSC::Lexer::shiftLineTerminator): Removed now-unneeded type casts. Changed local variable that
had a data-member-style name.
(JSC::Lexer::parseIdentifier): Removed now-unneeded explicit checks for -1, since the isIdentPart
function already returns false for the 0 character. Updated types in a couple other places. Used
the atEnd function where needed.
(JSC::Lexer::parseIdentifierSlowCase): More of the same.
(JSC::characterRequiresParseStringSlowCase): Added overloaded helper function for parseString.
(JSC::Lexer::parseString): Ditto.
(JSC::Lexer::parseStringSlowCase): Ditto.
(JSC::Lexer::parseMultilineComment): Ditto.
(JSC::Lexer::lex): More of the same. Also changed code to set the startOffset directly in
the tokenInfo instead of putting it in a local variable first, saving some memory access.
(JSC::Lexer::scanRegExp): Ditto.
(JSC::Lexer::skipRegExp): Ditto.
- parser/Lexer.h: Changed return type of the peek function and type of m_current from int to
the character type. Added atEnd function.
(JSC::Lexer::setOffset): Used 0 instead of -1 and removed an overzealous attempt to optimize.
(JSC::Lexer::lexExpectIdentifier): Used 0 instead of -1.
- 12:46 PM Changeset in webkit [114844] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523
Reviewed by Oliver Hunt.
Separate preparation step of copyright dates, renaming, and other small tweaks.
- parser/Lexer.cpp:
(JSC::Lexer::invalidCharacterMessage): Removed "get" from name to match WebKit naming conventions.
(JSC::Lexer::peek): Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Renamed from getUnicodeCharacter to be more precise about
what this function does.
(JSC::Lexer::shiftLineTerminator): Renamed local variable that had a data-member-style name.
(JSC::Lexer::parseStringSlowCase): Updated for new name of parseFourDigitUnicodeHex.
(JSC::Lexer::lex): Updated for new name of invalidCharacterMessage.
- parser/Lexer.h: Removed an unneeded forward declaration of the RegExp class.
Renamed getInvalidCharMessage to invalidCharacterMessage and made it const. Renamed
getUnicodeCharacter to parseFourDigitUnicodeHex.
- 9:43 AM Changeset in webkit [114843] by
-
- 2 edits in trunk/Source/WebCore
Improve performance of removing user and password from URLs
https://bugs.webkit.org/show_bug.cgi?id=84525
Reviewed by Dan Bernstein.
Performance improvement only. Correctness covered by existing regression tests.
The most common use of KURL::setUser and KURL::setPass, by far, is to remove
the user and password from a URL that already has neither. Optimize this by
not re-parsing the URL in that case.
- platform/KURL.cpp:
(WebCore::KURL::setUser): Restructure code so that the code path that removes
the user does no work when there is nothing to remove. Otherwise, leave the
logic of the function untouched.
(WebCore::KURL::setPass): Same thing, only for password rather than user.
- 3:46 AM Changeset in webkit [114842] by
-
- 1 edit5 moves in trunk/LayoutTests
Unreviewed - move some expectations added in r114839 to their proper location.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt.
- platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt: Removed.
- platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt: Removed.
- platform/gtk/tables/bug137388-2-expected.txt: Removed.
- platform/gtk/tables/bug29314-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug137388-2-expected.txt.
- platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug29314-expected.txt.
- 1:49 AM Changeset in webkit [114841] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing reftests.
- platform/qt/Skipped:
- 1:37 AM Changeset in webkit [114840] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening after r114766.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- 12:21 AM Changeset in webkit [114839] by
-
- 23 edits32 adds in trunk/LayoutTests
Rebaseline the last set of GTK+ tests after font metrics and mock scrollbar changes.
- platform/gtk: Rebaseline tests.
Apr 20, 2012:
- 11:24 PM Changeset in webkit [114838] by
-
- 47 edits12 adds in trunk/LayoutTests
Unreviewed, GTK svg rebaseline after r114799.
- 10:14 PM Changeset in webkit [114837] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114768.
http://trac.webkit.org/changeset/114768
https://bugs.webkit.org/show_bug.cgi?id=84521
Original patch was not the problem, re-applying (Requested by
pfeldman_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 8:22 PM April 2012 Meeting edited by
- (diff)
- 8:19 PM ShadowDOMDesignathon created by
- 8:07 PM Changeset in webkit [114836] by
-
- 4088 edits in trunk/LayoutTests
Rebaseline more GTK tests after <http://trac.webkit.org/changeset/114799>.
- 7:51 PM Changeset in webkit [114835] by
-
- 4 edits in trunk/Source
Make the Web Inspector be the first responder when opening docked.
<rdar://problem/11294217>
Reviewed by Brian Weinstein.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
the window and pass the Inspector's WebView.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Call makeFirstResponder: on
the window and pass the Inspector's WKView.
- 7:27 PM Changeset in webkit [114834] by
-
- 12 edits in trunk/LayoutTests
Undoing undesired changes.
- fast/block/float/008-expected.txt:
- fast/block/float/019-expected.txt:
- fast/block/float/035-expected.txt:
- fast/block/float/relative-painted-twice-expected.txt:
- fast/block/positioning/negative-rel-position-expected.txt:
- fast/canvas/canvas-bg-expected.txt:
- fast/css-generated-content/table-parts-before-and-after-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/flexbox/flex-hang-expected.txt:
- fast/forms/file/get-file-upload-expected.txt:
- fast/forms/select/listbox-in-multi-column-expected.txt:
- 7:21 PM Changeset in webkit [114833] by
-
- 240 edits in trunk/LayoutTests
Rebaseline more GTK fast tests after <http://trac.webkit.org/changeset/114799>.
- 7:19 PM Changeset in webkit [114832] by
-
- 125 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 and editing tests after <http://trac.webkit.org/changeset/114799>.
- 7:10 PM Changeset in webkit [114831] by
-
- 55 edits in trunk/LayoutTests
Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 7:05 PM Changeset in webkit [114830] by
-
- 299 edits in trunk/LayoutTests
Rebaseline more GTK editing, fast tests after <http://trac.webkit.org/changeset/114799>.
- 7:01 PM Changeset in webkit [114829] by
-
- 143 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 and animation tests after <http://trac.webkit.org/changeset/114799>.
- 6:50 PM Changeset in webkit [114828] by
-
- 35 edits in trunk/LayoutTests
Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:48 PM Changeset in webkit [114827] by
-
- 20 edits in trunk/Source
[chromium] Refactor opaque content transform out of Skia context
https://bugs.webkit.org/show_bug.cgi?id=83608
Reviewed by James Robinson.
Source/WebCore:
Having PlatformContextSkia know about the transform into content space
for a layer is a layering violation. This change lets the
PlatformContextSkia deal with opaque rects in its own space and lets
the caller handle transforming it into its own space. This also
prevents a matrix multiply per draw into the Skia canvas and does it
just once at the end to transform the final rect.
This is an incremental refactoring so that additional tracking for
text rects can be added and use the same space as opaque rects.
Tests: LayerTextureUpdaterTest.testPartialOpaqueRectNoTransform
LayerTextureUpdaterTest.testPartialOpaqueRectTranslation
LayerTextureUpdaterTest.testPartialOpaqueRectScale
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(BitmapSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
- platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(CanvasLayerTextureUpdater):
- platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
(SkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
Source/WebKit/chromium:
Add tests for opaque tracking in LayerTextureUpdater, since the
transform logic has moved there.
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
- tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
- tests/LayerTextureUpdaterTest.cpp:
(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(WebCore):
(WebCore::TEST):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- 6:45 PM Changeset in webkit [114826] by
-
- 70 edits in trunk/LayoutTests
Rebaseline more GTK editing, dom, fast tests after <http://trac.webkit.org/changeset/114799>.
- 6:43 PM Changeset in webkit [114825] by
-
- 190 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 tests after <http://trac.webkit.org/changeset/114799>.
- 6:43 PM Acronyms edited by
- (diff)
- 6:36 PM Changeset in webkit [114824] by
-
- 104 edits in trunk/LayoutTests
Rebaseline more GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
- 6:34 PM Changeset in webkit [114823] by
-
- 13 edits in trunk/LayoutTests
Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:30 PM Changeset in webkit [114822] by
-
- 86 edits in trunk/LayoutTests
Rebaseline more GTK css2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:25 PM Changeset in webkit [114821] by
-
- 291 edits in trunk/LayoutTests
Rebaseline more GTK css3 and editing tests after <http://trac.webkit.org/changeset/114799>.
- 6:22 PM Changeset in webkit [114820] by
-
- 27 edits in trunk/LayoutTests
Rebaseline GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/fast/block/float/001-expected.txt:
- platform/gtk/fast/block/float/002-expected.txt:
- platform/gtk/fast/block/float/003-expected.txt:
- platform/gtk/fast/block/float/004-expected.txt:
- platform/gtk/fast/block/float/005-expected.txt:
- platform/gtk/fast/block/float/006-expected.txt:
- platform/gtk/fast/block/float/007-expected.txt:
- platform/gtk/fast/block/float/010-expected.txt:
- platform/gtk/fast/block/float/011-expected.txt:
- platform/gtk/fast/block/float/012-expected.txt:
- platform/gtk/fast/block/float/013-expected.txt:
- platform/gtk/fast/block/float/014-expected.txt:
- platform/gtk/fast/block/float/015-expected.txt:
- platform/gtk/fast/block/float/016-expected.txt:
- platform/gtk/fast/block/float/017-expected.txt:
- platform/gtk/fast/block/float/018-expected.txt:
- platform/gtk/fast/block/margin-collapse/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/002-expected.txt:
- platform/gtk/fast/block/margin-collapse/003-expected.txt:
- platform/gtk/fast/block/margin-collapse/004-expected.txt:
- platform/gtk/fast/block/margin-collapse/005-expected.txt:
- platform/gtk/fast/block/margin-collapse/006-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
- 6:19 PM Acronyms edited by
- Add JNI, NP, XC (diff)
- 6:17 PM Changeset in webkit [114819] by
-
- 27 edits in trunk/LayoutTests
Rebasing fast/background results after r114799.
- 6:12 PM Changeset in webkit [114818] by
-
- 18 edits in trunk/LayoutTests
Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/css1/box_properties/border_width_inline-expected.txt:
- platform/gtk/css1/box_properties/clear-expected.txt:
- platform/gtk/css1/box_properties/clear_float-expected.txt:
- platform/gtk/css1/box_properties/float-expected.txt:
- platform/gtk/css1/box_properties/float_margin-expected.txt:
- platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
- platform/gtk/css1/box_properties/height-expected.txt:
- platform/gtk/css1/box_properties/margin-expected.txt:
- platform/gtk/css1/box_properties/margin_bottom-expected.txt:
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_left-expected.txt:
- platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_right-expected.txt:
- platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_top-expected.txt:
- platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
- 6:08 PM Changeset in webkit [114817] by
-
- 4 edits4 adds in trunk
CRASH at WebCore::ReplaceSelectionCommand::removeRedundantMarkup
https://bugs.webkit.org/show_bug.cgi?id=84518
<rdar://problem/10714790>
Reviewed by Simon Fraser.
Source/WebCore:
There are cases where the m_lastNodeInserted is NULL to begin with or
gets deleted by removeRedundantStylesAndKeepStyleSpanInline.
This change handles those cases properly.
Tests: editing/pasteboard/paste-sanitize-crash-1.html
editing/pasteboard/paste-sanitize-crash-2.html
- editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
LayoutTests:
- editing/pasteboard/paste-sanitize-crash-1-expected.txt: Added.
- editing/pasteboard/paste-sanitize-crash-1.html: Added.
- editing/pasteboard/paste-sanitize-crash-2-expected.txt: Added.
- editing/pasteboard/paste-sanitize-crash-2.html: Added.
- 6:06 PM Changeset in webkit [114816] by
-
- 105 edits in trunk/LayoutTests
Rebasing editing results after r114799.
Baselines for more of css2.1 and dom.
- 6:03 PM Acronyms edited by
- Update CF and add UUID (diff)
- 6:03 PM Changeset in webkit [114815] by
-
- 6 edits in trunk/LayoutTests
Rebaseline GTK animations tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/animations/cross-fade-background-image-expected.txt:
- platform/gtk/animations/cross-fade-border-image-source-expected.txt:
- platform/gtk/animations/cross-fade-list-style-image-expected.txt:
- platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt:
- platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt:
- 6:02 PM Changeset in webkit [114814] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
https://bugs.webkit.org/show_bug.cgi?id=84500
Reviewed by Kentaro Hara.
No new tests, no new functionality.
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):
- 5:59 PM Acronyms edited by
- (diff)
- 5:58 PM Changeset in webkit [114813] by
-
- 4 edits in trunk
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Reviewed by Anders Carlsson.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Changed to not assume that boxes only
have boxes as siblings.
LayoutTests:
- platform/mac/test_expectations.txt:
- 5:56 PM Changeset in webkit [114812] by
-
- 293 edits in trunk/LayoutTests
Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
Patch by Daniel Bates <dbates@webkit.org> on 2012-04-20
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/basic/comments-expected.txt:
- platform/gtk/css1/basic/containment-expected.txt:
- platform/gtk/css1/basic/contextual_selectors-expected.txt:
- platform/gtk/css1/basic/grouping-expected.txt:
- platform/gtk/css1/basic/id_as_selector-expected.txt:
- platform/gtk/css1/basic/inheritance-expected.txt:
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css1/box_properties/border-expected.txt:
- platform/gtk/css1/box_properties/border_bottom-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_color-expected.txt:
- platform/gtk/css1/box_properties/border_color_inline-expected.txt:
- platform/gtk/css1/box_properties/border_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left-expected.txt:
- platform/gtk/css1/box_properties/border_left_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left_width-expected.txt:
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right-expected.txt:
- platform/gtk/css1/box_properties/border_right_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right_width-expected.txt:
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_style-expected.txt:
- platform/gtk/css1/box_properties/border_style_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top-expected.txt:
- platform/gtk/css1/box_properties/border_top_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top_width-expected.txt:
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_width-expected.txt:
- platform/gtk/css1/cascade/cascade_order-expected.txt:
- platform/gtk/css1/cascade/important-expected.txt:
- platform/gtk/css1/classification/display-expected.txt:
- platform/gtk/css1/classification/list_style-expected.txt:
- platform/gtk/css1/classification/list_style_image-expected.txt:
- platform/gtk/css1/classification/list_style_position-expected.txt:
- platform/gtk/css1/classification/list_style_type-expected.txt:
- platform/gtk/css1/classification/white_space-expected.txt:
- platform/gtk/css1/color_and_background/background-expected.txt:
- platform/gtk/css1/color_and_background/background_attachment-expected.txt:
- platform/gtk/css1/color_and_background/background_color-expected.txt:
- platform/gtk/css1/color_and_background/background_image-expected.txt:
- platform/gtk/css1/color_and_background/background_position-expected.txt:
- platform/gtk/css1/color_and_background/background_repeat-expected.txt:
- platform/gtk/css1/color_and_background/color-expected.txt:
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/gtk/css1/font_properties/font-expected.txt:
- platform/gtk/css1/font_properties/font_family-expected.txt:
- platform/gtk/css1/font_properties/font_size-expected.txt:
- platform/gtk/css1/font_properties/font_style-expected.txt:
- platform/gtk/css1/font_properties/font_variant-expected.txt:
- platform/gtk/css1/font_properties/font_weight-expected.txt:
- platform/gtk/css1/formatting_model/canvas-expected.txt:
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/gtk/css1/formatting_model/inline_elements-expected.txt:
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css1/pseudo/anchor-expected.txt:
- platform/gtk/css1/pseudo/firstletter-expected.txt:
- platform/gtk/css1/pseudo/firstline-expected.txt:
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/line_height-expected.txt:
- platform/gtk/css1/text_properties/text_align-expected.txt:
- platform/gtk/css1/text_properties/text_decoration-expected.txt:
- platform/gtk/css1/text_properties/text_indent-expected.txt:
- platform/gtk/css1/text_properties/text_transform-expected.txt:
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css1/units/color_units-expected.txt:
- platform/gtk/css1/units/length_units-expected.txt:
- platform/gtk/css1/units/percentage_units-expected.txt:
- platform/gtk/css1/units/urls-expected.txt:
- 5:50 PM Changeset in webkit [114811] by
-
- 79 edits in trunk/LayoutTests
Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/basic/comments-expected.txt:
- platform/gtk/css1/basic/containment-expected.txt:
- platform/gtk/css1/basic/contextual_selectors-expected.txt:
- platform/gtk/css1/basic/grouping-expected.txt:
- platform/gtk/css1/basic/id_as_selector-expected.txt:
- platform/gtk/css1/basic/inheritance-expected.txt:
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css1/box_properties/border-expected.txt:
- platform/gtk/css1/box_properties/border_bottom-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_color-expected.txt:
- platform/gtk/css1/box_properties/border_color_inline-expected.txt:
- platform/gtk/css1/box_properties/border_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left-expected.txt:
- platform/gtk/css1/box_properties/border_left_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left_width-expected.txt:
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right-expected.txt:
- platform/gtk/css1/box_properties/border_right_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right_width-expected.txt:
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_style-expected.txt:
- platform/gtk/css1/box_properties/border_style_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top-expected.txt:
- platform/gtk/css1/box_properties/border_top_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top_width-expected.txt:
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_width-expected.txt:
- platform/gtk/css1/cascade/cascade_order-expected.txt:
- platform/gtk/css1/cascade/important-expected.txt:
- platform/gtk/css1/classification/display-expected.txt:
- platform/gtk/css1/classification/list_style-expected.txt:
- platform/gtk/css1/classification/list_style_image-expected.txt:
- platform/gtk/css1/classification/list_style_position-expected.txt:
- platform/gtk/css1/classification/list_style_type-expected.txt:
- platform/gtk/css1/classification/white_space-expected.txt:
- platform/gtk/css1/color_and_background/background-expected.txt:
- platform/gtk/css1/color_and_background/background_attachment-expected.txt:
- platform/gtk/css1/color_and_background/background_color-expected.txt:
- platform/gtk/css1/color_and_background/background_image-expected.txt:
- platform/gtk/css1/color_and_background/background_position-expected.txt:
- platform/gtk/css1/color_and_background/background_repeat-expected.txt:
- platform/gtk/css1/color_and_background/color-expected.txt:
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/gtk/css1/font_properties/font-expected.txt:
- platform/gtk/css1/font_properties/font_family-expected.txt:
- platform/gtk/css1/font_properties/font_size-expected.txt:
- platform/gtk/css1/font_properties/font_style-expected.txt:
- platform/gtk/css1/font_properties/font_variant-expected.txt:
- platform/gtk/css1/font_properties/font_weight-expected.txt:
- platform/gtk/css1/formatting_model/canvas-expected.txt:
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/gtk/css1/formatting_model/inline_elements-expected.txt:
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css1/pseudo/anchor-expected.txt:
- platform/gtk/css1/pseudo/firstletter-expected.txt:
- platform/gtk/css1/pseudo/firstline-expected.txt:
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/line_height-expected.txt:
- platform/gtk/css1/text_properties/text_align-expected.txt:
- platform/gtk/css1/text_properties/text_decoration-expected.txt:
- platform/gtk/css1/text_properties/text_indent-expected.txt:
- platform/gtk/css1/text_properties/text_transform-expected.txt:
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css1/units/color_units-expected.txt:
- platform/gtk/css1/units/length_units-expected.txt:
- platform/gtk/css1/units/percentage_units-expected.txt:
- platform/gtk/css1/units/urls-expected.txt:
- 5:38 PM Acronyms created by
- 5:33 PM Changeset in webkit [114810] by
-
- 147 edits in trunk/LayoutTests
Rebasing editing results after r114799.
- platform/gtk/editing/deleting/4922367-expected.txt:
- platform/gtk/editing/deleting/5099303-expected.txt:
- platform/gtk/editing/deleting/5126166-expected.txt:
- platform/gtk/editing/deleting/5144139-2-expected.txt:
- platform/gtk/editing/deleting/5206311-1-expected.txt:
- platform/gtk/editing/deleting/5272440-expected.txt:
- platform/gtk/editing/deleting/5369009-expected.txt:
- platform/gtk/editing/deleting/5433862-2-expected.txt:
- platform/gtk/editing/deleting/5483370-expected.txt:
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
- platform/gtk/editing/deleting/delete-4083333-fix-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/gtk/editing/deleting/delete-and-undo-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/gtk/editing/execCommand/4580583-1-expected.txt:
- platform/gtk/editing/execCommand/4580583-2-expected.txt:
- platform/gtk/editing/execCommand/4641880-1-expected.txt:
- platform/gtk/editing/execCommand/4641880-2-expected.txt:
- platform/gtk/editing/execCommand/4747450-expected.txt:
- platform/gtk/editing/execCommand/4916402-expected.txt:
- platform/gtk/editing/execCommand/4916541-expected.txt:
- platform/gtk/editing/execCommand/4924441-expected.txt:
- platform/gtk/editing/execCommand/5080333-1-expected.txt:
- platform/gtk/editing/execCommand/5080333-2-expected.txt:
- platform/gtk/editing/execCommand/5136770-expected.txt:
- platform/gtk/editing/execCommand/5138441-expected.txt:
- platform/gtk/editing/execCommand/5142012-1-expected.txt:
- platform/gtk/editing/execCommand/5142012-2-expected.txt:
- platform/gtk/editing/execCommand/5190926-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/execCommand/5482023-expected.txt:
- platform/gtk/editing/execCommand/5569741-expected.txt:
- platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
- platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
- platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/gtk/editing/inserting/12882-expected.txt:
- platform/gtk/editing/inserting/4278698-expected.txt:
- platform/gtk/editing/inserting/4840662-expected.txt:
- platform/gtk/editing/inserting/4875189-1-expected.txt:
- platform/gtk/editing/inserting/4875189-2-expected.txt:
- platform/gtk/editing/inserting/4959067-expected.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/inserting/4960120-2-expected.txt:
- platform/gtk/editing/inserting/5002441-expected.txt:
- platform/gtk/editing/inserting/5058163-1-expected.txt:
- platform/gtk/editing/inserting/5058163-2-expected.txt:
- platform/gtk/editing/inserting/5156401-2-expected.txt:
- platform/gtk/editing/inserting/5418891-expected.txt:
- platform/gtk/editing/inserting/5510537-expected.txt:
- platform/gtk/editing/inserting/5549929-2-expected.txt:
- platform/gtk/editing/inserting/5549929-3-expected.txt:
- platform/gtk/editing/inserting/6703873-expected.txt:
- platform/gtk/editing/inserting/before-after-input-element-expected.txt:
- platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/gtk/editing/inserting/editable-html-element-expected.txt:
- platform/gtk/editing/inserting/editable-inline-element-expected.txt:
- platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
- platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- platform/gtk/editing/pasteboard/3976872-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/4242293-expected.txt:
- platform/gtk/editing/pasteboard/4631972-expected.txt:
- platform/gtk/editing/pasteboard/4641033-expected.txt:
- platform/gtk/editing/pasteboard/4806874-expected.txt:
- platform/gtk/editing/pasteboard/4944770-1-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/pasteboard/4947130-expected.txt:
- platform/gtk/editing/pasteboard/7955-expected.txt:
- platform/gtk/editing/pasteboard/8145-1-expected.txt:
- platform/gtk/editing/pasteboard/8145-2-expected.txt:
- platform/gtk/editing/pasteboard/8145-3-expected.txt:
- platform/gtk/editing/selection/13804-expected.txt:
- platform/gtk/editing/selection/14971-expected.txt:
- platform/gtk/editing/selection/3690703-2-expected.txt:
- platform/gtk/editing/selection/3690703-expected.txt:
- platform/gtk/editing/selection/3690719-expected.txt:
- platform/gtk/editing/selection/4397952-expected.txt:
- platform/gtk/editing/selection/4402375-expected.txt:
- platform/gtk/editing/selection/4776665-expected.txt:
- platform/gtk/editing/selection/4818145-expected.txt:
- platform/gtk/editing/selection/4866671-expected.txt:
- platform/gtk/editing/selection/4889598-expected.txt:
- platform/gtk/editing/selection/6476-expected.txt:
- platform/gtk/editing/selection/7152-1-expected.txt:
- platform/gtk/editing/selection/7152-2-expected.txt:
- platform/gtk/editing/style/4916887-expected.txt:
- platform/gtk/editing/style/5017613-1-expected.txt:
- platform/gtk/editing/style/5017613-2-expected.txt:
- platform/gtk/editing/style/5046875-1-expected.txt:
- platform/gtk/editing/style/5046875-2-expected.txt:
- platform/gtk/editing/style/5065910-expected.txt:
- platform/gtk/editing/style/5084241-expected.txt:
- platform/gtk/editing/style/5228141-expected.txt:
- platform/gtk/editing/style/5279521-expected.txt:
- platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
- platform/gtk/editing/style/block-style-001-expected.txt:
- platform/gtk/editing/style/block-style-002-expected.txt:
- platform/gtk/editing/style/block-style-003-expected.txt:
- platform/gtk/editing/style/block-styles-007-expected.txt:
- platform/gtk/editing/style/create-block-for-style-001-expected.txt:
- platform/gtk/editing/style/create-block-for-style-002-expected.txt:
- platform/gtk/editing/style/create-block-for-style-003-expected.txt:
- platform/gtk/editing/style/create-block-for-style-004-expected.txt:
- platform/gtk/editing/undo/4063751-expected.txt:
- platform/gtk/editing/undo/redo-typing-001-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-expected.txt:
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-delete-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
- 5:31 PM Changeset in webkit [114809] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG should optimize int8 and int16 arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84503
Reviewed by Oliver Hunt.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrsb):
(JSC::ARMv7Assembler::ldrsh):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):
- bytecode/PredictedType.h:
(JSC::isActionableIntMutableArrayPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
- 5:27 PM Changeset in webkit [114808] by
-
- 4 edits in trunk/Source
[chromium] Remove special case for recreating layers during sync
https://bugs.webkit.org/show_bug.cgi?id=84458
Reviewed by James Robinson.
Source/WebCore:
We no longer delete layers on the impl side, unless it is due to
deleting the layer on webkit side. So we will no longer have a
situation where we need to push properties from an old
LayerChromium to a new CCLayerImpl.
- platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
Source/WebKit/chromium:
- tests/TreeSynchronizerTest.cpp:
- 5:25 PM WikiStart edited by
- Add link to "Acronyms" page in "Documentation" section (diff)
- 5:22 PM Changeset in webkit [114807] by
-
- 4 edits in trunk/Source
[chromium] WebFilterOperations API does not compile or dynamically link
https://bugs.webkit.org/show_bug.cgi?id=84506
Reviewed by James Robinson.
Non-inline functions need WEBKIT_EXPORT in their declarations,
and the type used in the WebPrivateOwnPtr needs to be forward-
declared even when WEBKIT_IMPLEMENTATION is not defined.
Source/Platform:
- chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):
(WebFilterOperations):
Source/WebCore:
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::initialize):
- 5:18 PM Changeset in webkit [114806] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114333.
http://trac.webkit.org/changeset/114333
https://bugs.webkit.org/show_bug.cgi?id=84511
perf regression (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- dom/Node.cpp:
- dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::isElementNode):
(WebCore::Node::isContainerNode):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isStyledElement):
(WebCore::Node::isShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
- 5:16 PM Changeset in webkit [114805] by
-
- 21 edits3 adds in trunk
IndexedDB: Support get/getKey(keyRange)
https://bugs.webkit.org/show_bug.cgi?id=83638
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-20
Reviewed by Ojan Vafai.
Source/WebCore:
Support IDBKeyRange as a parameter to all the various get/getKey
combinations. Switches the existing get/getKey versions that use
IDBKey directly to start using IDBKeyRange.only().
Test: storage/indexeddb/get-keyrange.html
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::get):
(WebCore):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBIndex.h:
(IDBIndex):
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore):
- Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(IDBObjectStoreBackendInterface):
Source/WebKit/chromium:
Hook up WebKit API to the new get/getKey implementations.
- src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::get):
(WebKit):
(WebKit::IDBIndexBackendProxy::getKey):
- src/IDBIndexBackendProxy.h:
(IDBIndexBackendProxy):
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
LayoutTests:
Tests for all the get/getKey combinations when using a range.
- storage/indexeddb/get-keyrange-expected.txt: Added.
- storage/indexeddb/get-keyrange.html: Added.
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/resources/get-keyrange.js: Added.
(test):
(openDatabase):
(setVersion):
(deleteExisting):
(addData):
(getRangeOnlyTest.request.onsuccess):
(getRangeOnlyTest):
(getRangeLowerTest.request.onsuccess):
(getRangeLowerTest):
(getRangeLowerOpenTest.request.onsuccess):
(getRangeLowerOpenTest):
(getRangeUpperTest.request.onsuccess):
(getRangeUpperTest):
(getRangeLowerFractionTest.request.onsuccess):
(getRangeLowerFractionTest):
(getOutOfRangeTest.request.onsuccess):
(getOutOfRangeTest):
(getBadOnlyTest.request.onsuccess):
(getBadOnlyTest):
(getNullTest):
- 5:12 PM Changeset in webkit [114804] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r114789.
http://trac.webkit.org/changeset/114789
https://bugs.webkit.org/show_bug.cgi?id=84515
Caused 5 tests to fail on mac/ (Requested by jernoble on
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- 5:12 PM Changeset in webkit [114803] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add an ability to find the extent of a callframe
https://bugs.webkit.org/show_bug.cgi?id=84513
Reviewed by Filip Pizlo.
Add a function to get the extent of a callframe and
use that function for a new assertion to make sure the
RegisterFile makes sense using that information.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
(JSC):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- 5:07 PM Changeset in webkit [114802] by
-
- 11 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. (Refactor, no behavior change)
Rename WillShowDialog to WillDeferLoading:
- dom/ActiveDOMObject.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend):
Don't take a ReasonForSuspension argument anymore, just use WillDeferLoading:
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
Don't pass a Reason anymore as WillDeferLoading is used by default:
- page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.
- Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runOpenPanel):
Source/WebKit/chromium:
PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.
- src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop):
- 5:01 PM Changeset in webkit [114801] by
-
- 133 edits in trunk/LayoutTests
Unreviewed, GTK css2.1 rebaseline after r114796 and r114799.
- platform/gtk/css2.1: Massive Update.
- 4:49 PM Changeset in webkit [114800] by
-
- 20 edits in trunk/Source
[chromium] Plumb a compositor surface ready notification through to the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=84305
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Adrienne Walker.
Source/Platform:
Add a notification for when the compositor surface associated with a given view is ready to use.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Plumb setSurfaceReady through to the scheduler.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setSurfaceReady):
(WebCore):
(WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race
condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the
native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing
deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or
it will fail.
- public/WebWidget.h:
(WebWidget):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:47 PM Changeset in webkit [114799] by
-
- 2 edits in trunk/Source/WebKit/gtk
[Gtk][WK1] Use mock scrollbars when testing
https://bugs.webkit.org/show_bug.cgi?id=79577
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-20
Reviewed by Daniel Bates.
Enable mock scrollbars if running DumpRenderTree.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
- 4:32 PM Changeset in webkit [114798] by
-
- 2 edits1 add in trunk/LayoutTests
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Reviewed by Simon Fraser.
Add -webkit-filter results to the platforms on which it is enabled.
This required a new platform result for WebKit mac.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt.
- platform/mac/test_expectations.txt:
- 4:31 PM Changeset in webkit [114797] by
-
- 11 edits3 adds in trunk/Source
[Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376
Reviewed by Kentaro Hara.
Source/WebCore:
Now that memoryUsageMB has been moved from PlatformSupport.h to
Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/V8GCController.cpp.
That means we need a new MemoryUsageSupport class in
WebCore/platform/ and an implementation in
WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
Other ports are welcome to implement their memory usage
functions if they wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.
Part of a refactoring series. See tracking bug 82948.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8GCController.cpp:
(WebCore):
- platform/MemoryUsageSupport.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
- platform/MemoryUsageSupport.h: Added.
(WebCore):
(MemoryUsageSupport):
- platform/chromium/MemoryUsageSupportChromium.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
Part of a refactoring series. See tracking bug 82948.
- src/PlatformSupport.cpp:
(WebCore):
- 4:18 PM Changeset in webkit [114796] by
-
- 3 edits in trunk/Tools
[GTK] Revert changes that disabled Cairo fonts metrics hinting
https://bugs.webkit.org/show_bug.cgi?id=84502
Reviewed by Daniel Bates.
Re-enable Cairo metrics hinting, which seems to ensure consistent results in
reference and pixel test results. This makes our font metrics a bit different
than the Mac port's, but it's a decent price to pay for consistent results.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):
- 4:18 PM Internals_Hackathon edited by
- (diff)
- 4:05 PM BuildingGtk edited by
- (diff)
- 4:04 PM Changeset in webkit [114795] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Unreviewed; add new crashing test result to test_expectations.txt.
- platform/mac/test_expectations.txt:
- 4:03 PM Changeset in webkit [114794] by
-
- 2 edits3 adds in trunk/LayoutTests
[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84440
Unreviewed, added EFL baselines for passing tests and also skipped two tests
which are failing due to missing implementation.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
- platform/efl/Skipped:
- platform/efl/fast/block/float/avoiding-float-centered-expected.png: Added.
- platform/efl/fast/block/float/avoiding-float-centered-expected.txt: Added.
- platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Added.
- 3:52 PM Changeset in webkit [114793] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inline the JSArray constructor
https://bugs.webkit.org/show_bug.cgi?id=84416
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-20
Reviewed by Geoffrey Garen.
The constructor is trivial, no reason to jump for it.
This makes the creation of array ~5% faster (on non-trivial cases, no empty arrays).
- runtime/JSArray.cpp:
(JSC):
- runtime/JSArray.h:
(JSC::JSArray::JSArray):
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:46 PM April 2012 Meeting edited by
- (diff)
- 3:45 PM April 2012 Meeting edited by
- Adding notes for the keeping the bots green session (diff)
- 3:44 PM April 2012 Keeping the bots green created by
- Notes for the keeping the bots green session
- 3:38 PM Changeset in webkit [114792] by
-
- 2 edits in trunk/Source/WebCore
Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
- 3:35 PM Changeset in webkit [114791] by
-
- 4 edits in trunk/Source
[chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
https://bugs.webkit.org/show_bug.cgi?id=84289
Reviewed by James Robinson.
Source/WebCore:
TransparencyWin will create a Skia canvas of whatever size is passed
in, even if the result will ultimately be clipped. Handle the clip
implicitly and try (in some cases) to create a smaller canvas. This
can happen due to RenderBox::paintBoxDecorations passing a paint rect
down of the entire element's size.
Modes with more complicated transforms (ScaleTransform, UnTransform)
are not handled yet.
Tests: TransparencyWin.ClippedKeepTransformNoLayer
TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer
- platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::computeLayerSize):
Source/WebKit/chromium:
Add a test that would OOM if the layer wasn't clipped. Also, verify
that clipping the canvas doesn't shift pixels around incorrectly.
- tests/TransparencyWinTest.cpp:
(WebCore::testClippedLayerKeepTransform):
(WebCore):
(WebCore::TEST):
- 3:33 PM Changeset in webkit [114790] by
-
- 22 edits in trunk
apple.com top navigation bar appears inside video during full screen exit animation
https://bugs.webkit.org/show_bug.cgi?id=83095
Reviewed by Eric Carlson.
Source/WebCore:
Test: fullscreen/full-screen-exit-animation-stacking-context.html
Only tell ancestors of the full screen element that they are no longer ancestors once
the full screen animation is complete:
- dom/Document.cpp:
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen
from the Internals object, so scripts can call them explicitly:
- testing/Internals.cpp:
(WebCore::Internals::webkitWillEnterFullScreenForElement): Call the Document equivalent.
(WebCore::Internals::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Internals::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Internals::webkitDidExitFullScreenForElement): Ditto.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
Add new WebCore symbols needed by DumpRenderTree to exported symbol list.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Tools:
Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
Document methods from within the script. This allows subtle timing bugs to be consistently reproduced
from within LayoutTests.
Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
- DumpRenderTree/LayoutTestController.cpp:
(setHasCustomFullScreenBehaviorCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::setHasCustomFullScreenBehavior):
(WTR::LayoutTestController::hasCustomFullScreenBehavior):
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
Query the new methods before calling will/did/Enter/ExitFullScreen:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::enterFullScreenNow):
(WebViewHost::exitFullScreenNow):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:enterFullScreenForElement:listener:]):
(-[UIDelegate webView:exitFullScreenForElement:listener:]):
LayoutTests:
- fullscreen/full-screen-exit-animation-stacking-context-expected.txt: Added.
- fullscreen/full-screen-exit-animation-stacking-context.html: Added.
- platform/mac/fullscreen/full-screen-exit-animation-stacking-context-expected.png: Added.
- 3:33 PM Changeset in webkit [114789] by
-
- 5 edits in trunk/Source/WebCore
media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=84162
Reviewed by Eric Carlson.
No new tests; no change in functionality so covered by existing tests.
Remove the media-exit-fullscreen-button keyword, and rename media-enter-fullscreen-button to
media-fullscreen-button.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- 3:32 PM Changeset in webkit [114788] by
-
- 14 edits in trunk/Tools
NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-20
Reviewed by Dirk Pranke
This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
and 'reference_files' fields to the TestInput objects, and use those flags
to select the right driver to use in the DriverProxy.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init):
(SingleTestRunner._driver_input):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
(Worker._update_test_input):
- Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput):
(TestInput.init):
(TestInput.repr):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
(ChromiumDriver.run_test):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverInput.init):
(Driver.init):
(DriverProxy.init):
(DriverProxy.run_test):
(DriverProxy.start):
(DriverProxy.cmd_line):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRT.run):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.write_test_output):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.write_test_output):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
(WebKitDriver.run_test):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
- WebKitTestRunner/TestInvocation.h:
(TestInvocation):
- 3:18 PM Changeset in webkit [114787] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Fix compile errors when DEBUG_GL_CALLS is enabled
https://bugs.webkit.org/show_bug.cgi?id=84491
Patch by Alexandre Elias <aelias@google.com> on 2012-04-20
Reviewed by Ojan Vafai.
DEBUG_GL_CALLS had not been used in a while and the mode no longer
compiled when I tried it. I improved the GLC macro to support either
raw pointers or RefPtrs, and to be a single expression in order to
interact properly with if/else blocks. I fixed the cases where we
were passing in the "context" method pointer by mistake, and removed the
now-unnecessary "get()" calls for the RefPtrs.
No new tests. (No-op change in release builds.)
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::doNoOp):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
- 3:15 PM Changeset in webkit [114786] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
- 3:15 PM April 2012 Meeting edited by
- (diff)
- 2:54 PM Changeset in webkit [114785] by
-
- 6 edits in trunk/Source/WebCore
Set m_compositingDependsOnGeometry to false if possible
https://bugs.webkit.org/show_bug.cgi?id=84391
Reviewed by James Robinson.
For some kinds of elements, RenderLayerCompositor has to delay decisions about
compositing until the element's size and/or position are known. This was previsouly
based on the confusingly named m_compositingDependsOnGeometry flag, but another
variant of the same technique, with an additional flag m_compositingNeedsUpdate,
was added in r98627.
Also, once the m_compositingDependsOnGeometry flag was set to true, nothing
set it to false, so every compositing layer update resulted in a computeCompositingRequirements()
pass over the layers.
Rename the m_compositingDependsOnGeometry flag to m_reevaluateCompositingAfterLayout,
and clear the flag when we do a layout-related compositing layer update.
Use the same flag for position:fixed compositing.
This requires RenderLayerCompositor to distinguish between style- and layout-
related updates, requiring some minor refactoring in FrameView.
Should not change behavior.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layout):
- page/FrameView.h:
(FrameView):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 2:45 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:41 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:40 PM Changeset in webkit [114784] by
-
- 8 edits2 adds in trunk
Source/WebCore: <rdar://problem/10786000> Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
Test: fast/block/line-layout/selection-highlight-overlap.html
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::selectionRect): Changed to use
selection{Top,Height}AdjustedForPrecedingBlock().
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::inlineSelectionGaps): Ditto.
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Added. Returns the block which is
likely to contain the selected line just before the first line in this block, if it is
within the same selection root.
- rendering/RenderBlock.h:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock): Added. If the selection
starts before our block, finds the last line in the preceding block and adjusts the selection
top to avoid overlap with that line’s selection bottom.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock): Added. Like
selectionHeight(), but uses selectionTopAdjustedForPrecedingBlock().
LayoutTests: Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
- fast/block/line-layout/selection-highlight-overlap-expected.html: Added.
- fast/block/line-layout/selection-highlight-overlap.html: Added.
- 2:37 PM Changeset in webkit [114783] by
-
- 2 edits in trunk/Source/WebCore
Crash in getOrDrawNodeHighlight after r114659
https://bugs.webkit.org/show_bug.cgi?id=84486
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-04-20
Reviewed by Daniel Bates.
No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
- inspector/DOMNodeHighlighter.cpp:
- 2:33 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:29 PM Changeset in webkit [114782] by
-
- 11 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=84490
PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. (Refactor, no change in behavior)
- Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
- Change suspendScheduledTasks to take a ReasonForSuspension.
- As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some ASSERTs to catch what would be epically wrong behavior in the future.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
- dom/Document.h:
- Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used to be the default behavior
- page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
- Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
which used to be the default
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
(WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop): Pass along ActiveDOMObject::WillShowDialog, which used
to be the default.
- 2:25 PM Changeset in webkit [114781] by
-
- 2 edits in trunk/Source/WebCore
Scrolling after going to a find-in-page result jumps to the top of the page
https://bugs.webkit.org/show_bug.cgi?id=84485
<rdar://problem/11273734>
Reviewed by Beth Dakin.
If we're both updating the requested scroll position and entering slow mode in the same commit, the
probable main thread scroll position should be the requested scroll position.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
- 2:23 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:22 PM Changeset in webkit [114780] by
-
- 479 edits4 copies in branches/subpixellayout
Merge trunk changes up until 114777 into subpixel branch.
- 2:22 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:19 PM Changeset in webkit [114779] by
-
- 6 edits2 adds in trunk/Source/WebKit
[BlackBerry] Expose WebViewportArguments to WebPageClient
https://bugs.webkit.org/show_bug.cgi?id=84471
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-20
Reviewed by Antonio Gomes.
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Implement the ability for the WebPageClient to specify a fallback
virtual viewport to be used whenever a meta viewport tag is not
present in the HTML. This can drastically impact apparent layout.
This patch is designed to provide a classic "Column View" style of
layout without breaking the web by simply exposing meta viewport
arguments to WebPageClients.
Note: As a side effect of this change. the WebPagePrivate::
recomputeVirtualViewportFromViewportArguments method no longer
modifies the targetDensityDpi property of the m_viewportArguments.
However this does not affect the class because that property itself
means nothing to us. Only the computeViewportArguments method from
WebCore uses it, and the currentViewportArguments object we pass
into that method has the adjusted targetDensityDpi value as before.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserViewportArguments):
(WebKit):
(BlackBerry::WebKit::WebPage::resetUserViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- Api/WebPage.h:
(WebKit):
- Api/WebPage_p.h:
(WebPagePrivate):
- Api/WebViewportArguments.cpp: Added.
(WebKit):
(BlackBerry::WebKit:::d):
(BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
(BlackBerry::WebKit::WebViewportArguments::initialScale):
(BlackBerry::WebKit::WebViewportArguments::setInitialScale):
(BlackBerry::WebKit::WebViewportArguments::minimumScale):
(BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
(BlackBerry::WebKit::WebViewportArguments::maximumScale):
(BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
(BlackBerry::WebKit::WebViewportArguments::width):
(BlackBerry::WebKit::WebViewportArguments::setWidth):
(BlackBerry::WebKit::WebViewportArguments::height):
(BlackBerry::WebKit::WebViewportArguments::setHeight):
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::userScalable):
(BlackBerry::WebKit::WebViewportArguments::setUserScalable):
(BlackBerry::WebKit::WebViewportArguments::operator==):
(BlackBerry::WebKit::WebViewportArguments::operator!=):
- Api/WebViewportArguments.h: Added.
(WebCore):
(WebKit):
- 2:17 PM Changeset in webkit [114778] by
-
- 6 edits in trunk/Source
Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes
https://bugs.webkit.org/show_bug.cgi?id=84470
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Anders Carlsson.
Source/WebCore:
When a scrollable area is added or removed, we shouldn't recalculate the nonFastScrollableRegion synchronously
since this is slow, the RenderObject tree might not be in an up-to-date state, and we'll typically do layout
soon anyway.
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Source/WebKit/chromium:
Trigger a layout when a plugin becomes or stops being scrollable so the nonFastScrollableRegion
can be updated.
- src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
- 2:09 PM April 2012 Write Your Own Render Object created by
- 2:02 PM Changeset in webkit [114777] by
-
- 5 edits4 copies in trunk/LayoutTests
Rebaselining svg/css/getComputedStyle-basic.html after
http://trac.webkit.org/changeset/114766
Not reviewed.
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 1:48 PM April 2012 Meeting edited by
- (diff)
- 1:47 PM April 2012 Meeting edited by
- (diff)
- 1:46 PM EFLWebKit edited by
- Update libsoup version (diff)
- 1:28 PM Changeset in webkit [114776] by
-
- 4 edits in trunk/Tools
[EFL] Make it possible to define offline storage quota per origin
https://bugs.webkit.org/show_bug.cgi?id=84170
Improved LayoutTestController::setDatabaseQuota to set quota based on
origin which was causing some tests to fail. Also align the default
quota for testing (5MB) with others ports.
When dumpDatabaseCallbacks is set to true by, also dump some database
information when quota is exceed, which is also required by some tests.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
(drtViewAdd):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDatabaseQuota):
- 1:22 PM Changeset in webkit [114775] by
-
- 2 edits in trunk/Source/WebCore
Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472
Reviewed by Eric Seidel.
Fix use of subpixel units and rounding in new code introduced in r114659.
No new tests, no change in functionality.
- inspector/DOMNodeHighlighter.cpp:
- 1:07 PM Changeset in webkit [114774] by
-
- 2 edits in trunk/LayoutTests
Enable Encrypted Media tests on Chromium now that Chromium side is committed
https://bugs.webkit.org/show_bug.cgi?id=84474
Unreviewed enabling of layout tests.
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-20
- platform/chromium/test_expectations.txt:
- 1:03 PM Changeset in webkit [114773] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Unreviewed; add new failing test to expected results.
- platform/mac/test_expectations.txt:
- 12:55 PM Changeset in webkit [114772] by
-
- 6 edits in trunk/Source/JavaScriptCore
Heap should cancel GC timer at the start of the collection
https://bugs.webkit.org/show_bug.cgi?id=84477
Reviewed by Geoffrey Garen.
Currently the Heap cancels the GC timer at the conclusion of a collection.
We should change this to be at the beginning because something (e.g. a finalizer)
could call didAbandonObjectGraph(), which will schedule the timer, but then
we'll immediately unschedule the timer at the conclusion of the collection,
thus potentially preventing large swaths of memory from being reclaimed in a timely manner.
- API/JSBase.cpp:
(JSGarbageCollect): Remove outdated fix-me and remove check for whether the Heap is
busy or not, since we're just scheduling a timer to run a GC in the future.
- heap/Heap.cpp:
(JSC::Heap::collect): Rename didCollect to willCollect and move the call to the
top of Heap::collect.
- runtime/GCActivityCallback.cpp: Renamed didCollect to willCollect.
(JSC::DefaultGCActivityCallback::willCollect):
- runtime/GCActivityCallback.h: Ditto.
(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp: Ditto.
(JSC::DefaultGCActivityCallback::willCollect):
- 12:36 PM Changeset in webkit [114771] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSGarbageCollect should not call collectAllGarbage()
https://bugs.webkit.org/show_bug.cgi?id=84476
Reviewed by Geoffrey Garen.
- API/JSBase.cpp:
(JSGarbageCollect): Notify the Heap's GCActivityCallback using didAbandonObjectGraph.
- 12:11 PM Changeset in webkit [114770] by
-
- 2 edits in trunk/Source/WebCore
Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
https://bugs.webkit.org/show_bug.cgi?id=84178
Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>
No new tests since it is not easily testable.
When a port has both delegatesScrolling and constrainsScrollingToContentEdge set to FALSE
(i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled
position still gets the position clamped to the content size edges.
Patch relaxes ::adjustScrollPositionWithinRange in that sense in order to track the actual scroll
position.
Note: ScrollView::setScrollOffset already does something similar.
- platform/ScrollView.cpp:
(WebCore::ScrollView::adjustScrollPositionWithinRange):
- 12:09 PM Changeset in webkit [114769] by
-
- 495 edits23 copies in branches/subpixellayout
Merge trunk changes up until 114767 into subpixel branch.
- 12:07 PM April 2012 Meeting edited by
- (diff)
- 12:04 PM Changeset in webkit [114768] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114535.
http://trac.webkit.org/changeset/114535
https://bugs.webkit.org/show_bug.cgi?id=84475
It might have caused V8 crashes. (Requested by pfeldman_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 11:51 AM April 2012 Reducing build systems edited by
- Add clarifying sentence to section "Another approach: scripts; … (diff)
- 11:46 AM Changeset in webkit [114767] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Misc platform fixes on branch.
- 11:42 AM April 2012 Reducing build systems edited by
- Fix formatting; spelling/grammer corrections (diff)
- 11:41 AM Changeset in webkit [114766] by
-
- 9 edits in trunk
-webkit-filter missing from computed style enumeration
https://bugs.webkit.org/show_bug.cgi?id=84468
Source/WebCore:
Reviewed by Timothy Hatcher.
CSSComputedStyleDeclaration has a list of properties that it exposes.
While the computed style for filter was available, the property wasn't
listed and hence missing in clients like the Web Inspector.
Covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore): add CSSPropertyWebkitFilter
LayoutTests:
Reviewed by Timothy Hatcher.
Added new results for platforms that have filters enabled. Hopefully
I got them all. Luckily there were already platform results for this
test in each case.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 11:35 AM April 2012 Meeting edited by
- (diff)
- 11:34 AM April 2012 JavaScriptCore Roundup created by
- 11:29 AM April 2012 Meeting edited by
- (diff)
- 11:29 AM April 2012 Meeting edited by
- (diff)
- 11:28 AM April 2012 Reducing build systems created by
- First pass at notes.
- 11:27 AM April 2012 Canvas Canvass created by
- 11:13 AM Changeset in webkit [114765] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Move bot to Lion Debug to help catch up.
- 11:12 AM Changeset in webkit [114764] by
-
- 5 edits in trunk/Source
[win] Update windows platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=84283
Reviewed by Eric Seidel.
Source/WebCore:
No new tests, no change in functionality.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::pixelSnappedElementRect):
Use pixel snapped values when computing screenRect.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
Cast client padding to ints as they are guaranteed to align with device pixels.
Source/WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::accLocation):
- 11:03 AM April 2012 Meeting edited by
- (diff)
- 11:02 AM April 2012 Meeting edited by
- (diff)
- 11:01 AM April 2012 Meeting edited by
- (diff)
- 11:00 AM Scrolling Session Meeting 2012 created by
- 10:57 AM Changeset in webkit [114763] by
-
- 6 edits in trunk/Source
[chromium] Some filters require inflating damage rect in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=84373
Reviewed by James Robinson.
Source/WebCore:
When a layer is blurred, damaged pixels are blurred out into a radius
and their damage should be expanded to include total blurred region.
Unit test: CCDamageTrackerTest.verifyDamageForBlurredSurface
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::expandDamageRectWithForegroundFilters):
(WebCore):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore):
(CCDamageTracker):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):
- 10:56 AM April 2012 Meeting edited by
- Add hyperlink to discussion notes for session "Reducing build systems" (diff)
- 10:54 AM Changeset in webkit [114762] by
-
- 978 edits65 copies30 deletes in branches/subpixellayout
Merge trunk changes up until 114758 into subpixel branch.
- 10:53 AM Changeset in webkit [114761] by
-
- 4 edits in trunk/Source
[chromium] Don't crash when scrolling empty layer tree
https://bugs.webkit.org/show_bug.cgi?id=84455
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-20
Reviewed by James Robinson.
Source/WebCore:
Do not try to calculate render passes when there are no layers in the
layer tree.
Added new unit test.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
Source/WebKit/chromium:
Try to scroll an empty layer tree.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 10:46 AM Changeset in webkit [114760] by
-
- 5 edits in trunk
Ensure text is centered for default captions
https://bugs.webkit.org/show_bug.cgi?id=84450
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-20
Reviewed by Eric Carlson.
Source/WebCore:
Updated existing test.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getDisplayTree): Added default width.
LayoutTests:
Updated test to cover default positioning of captions.
- media/track/track-cue-rendering-expected.txt: Updated.
- media/track/track-cue-rendering.html: Updated.
- 10:31 AM Changeset in webkit [114759] by
-
- 21 edits23 adds in trunk/LayoutTests
[EFL][DRT] Gardening SVG tests and timeouts
https://bugs.webkit.org/show_bug.cgi?id=84462
Unreviewed, EFL gardening.
A number of SVG Batik text tests needed rebaselining likely due to bug 83264.
Also, moving some tests that fail to call notifyDone to test_expectations with appropriate bugs filed.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-20
- platform/efl/svg/batik/text/longTextOnPath-expected.png: Added.
- platform/efl/svg/batik/text/longTextOnPath-expected.txt:
- platform/efl/svg/batik/text/smallFonts-expected.png: Added.
- platform/efl/svg/batik/text/smallFonts-expected.txt:
- platform/efl/svg/batik/text/textAnchor2-expected.png: Added.
- platform/efl/svg/batik/text/textAnchor3-expected.png: Added.
- platform/efl/svg/batik/text/textDecoration-expected.png: Added.
- platform/efl/svg/batik/text/textDecoration-expected.txt:
- platform/efl/svg/batik/text/textDecoration2-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.txt:
- platform/efl/svg/batik/text/textEffect2-expected.png: Added.
- platform/efl/svg/batik/text/textEffect2-expected.txt:
- platform/efl/svg/batik/text/textEffect3-expected.png: Added.
- platform/efl/svg/batik/text/textEffect3-expected.txt:
- platform/efl/svg/batik/text/textFeatures-expected.png: Added.
- platform/efl/svg/batik/text/textFeatures-expected.txt:
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/efl/svg/batik/text/textLayout-expected.png: Added.
- platform/efl/svg/batik/text/textLayout-expected.txt:
- platform/efl/svg/batik/text/textLayout2-expected.png: Added.
- platform/efl/svg/batik/text/textLayout2-expected.txt:
- platform/efl/svg/batik/text/textLength-expected.png: Added.
- platform/efl/svg/batik/text/textLength-expected.txt:
- platform/efl/svg/batik/text/textOnPath2-expected.png: Added.
- platform/efl/svg/batik/text/textOnPath2-expected.txt:
- platform/efl/svg/batik/text/textOnPathSpaces-expected.png: Added.
- platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/efl/svg/batik/text/textPCDATA-expected.png: Added.
- platform/efl/svg/batik/text/textPosition-expected.png: Added.
- platform/efl/svg/batik/text/textPosition-expected.txt:
- platform/efl/svg/batik/text/textPosition2-expected.png: Added.
- platform/efl/svg/batik/text/textPosition2-expected.txt:
- platform/efl/svg/batik/text/textProperties-expected.png: Added.
- platform/efl/svg/batik/text/textProperties-expected.txt:
- platform/efl/svg/batik/text/textStyles-expected.png: Added.
- platform/efl/svg/batik/text/textStyles-expected.txt:
- platform/efl/svg/batik/text/verticalText-expected.png: Added.
- platform/efl/svg/batik/text/verticalText-expected.txt:
- platform/efl/svg/batik/text/xmlSpace-expected.png: Added.
- platform/efl/svg/batik/text/xmlSpace-expected.txt:
- platform/efl/test_expectations.txt:
- 10:23 AM April 2012 HTML5 Media Element & WebAudio created by
- Initial Commit
- 10:23 AM April 2012 Meeting edited by
- (diff)
- 10:13 AM Changeset in webkit [114758] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: open file dialog is not centered.
https://bugs.webkit.org/show_bug.cgi?id=84464
Reviewed by Yury Semikhatsky.
There was an error in the positioning logic.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
- 10:11 AM Importing Thirdparty tests edited by
- (diff)
- 10:11 AM April 2012 Meeting edited by
- (diff)
- 10:10 AM Importing Thirdparty tests created by
- 10:09 AM April 2012 Meeting edited by
- (diff)
- 10:09 AM Changeset in webkit [114757] by
-
- 28 edits in branches/chromium/1084/Source
Merge 113677 - [chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.
We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.
In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.
Unit test: CCLayerTreeHostImplTest.viewportCovered
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):
- tests/CCTiledLayerImplTest.cpp:
- tests/LayerChromiumTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10146014
- 10:08 AM Instrumentation and Metrics created by
- 10:07 AM Changeset in webkit [114756] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as TIMEOUT since it's too slow for even SLOW at the moment.
- platform/chromium/test_expectations.txt:
- 10:05 AM Changeset in webkit [114755] by
-
- 1 edit1 delete in trunk/Source/WebCore
[Qt] PlatformMouseEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84437
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-20
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/PlatformMouseEventQt.cpp: Removed.
- 9:39 AM UpdatingBugzilla edited by
- (diff)
- 9:28 AM Changeset in webkit [114754] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: follow up to r114729: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447
Reviewed by Yury Semikhatsky.
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.ResourceRevision.prototype.get content):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame.prototype._addRequest):
- inspector/front-end/ResourceUtils.js:
(String.prototype.asParsedURL):
- 9:24 AM Changeset in webkit [114753] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: migrate from ScriptsNavigator to NavigatorView in the Styles panel
https://bugs.webkit.org/show_bug.cgi?id=84459
Reviewed by Yury Semikhatsky.
Now that NavigatorView has all the functionality we need, we can use it.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._itemSelected):
(WebInspector.StylesPanel.prototype._showFile):
- inspector/front-end/navigatorView.css:
(.navigator-tabbed-pane .tabbed-pane-content):
(.navigator-tabbed-pane .navigator-container):
(.navigator-tabbed-pane .navigator):
(.navigator-tabbed-pane .tabbed-pane-header):
(.navigator-tabbed-pane .tabbed-pane-header-contents):
- inspector/front-end/scriptsPanel.css:
- 9:15 AM Changeset in webkit [114752] by
-
- 3 edits in trunk/LayoutTests
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203
Reviewed by Simon Fraser.
This test compares CSS div's n a ref-test with a single spec for transform-origin
to SVG rects with multipe specs for transform-origin that are supposed
to all be equivalent, such as [50%,50%] and [center, center]. It fails
due to one-pixel differences on Chromium.
This change renders as many divs in the ref-test as SVG rects in the
test, and ends up with the same result. It seems likely that one of
the several specs that are used is computed slightly differently
(maybe 50% is not the same as center).
- platform/chromium/test_expectations.txt:
- svg/transforms/transform-origin-css-property-expected.xhtml:
- 9:13 AM Changeset in webkit [114751] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove empty svg/misc directory
https://bugs.webkit.org/show_bug.cgi?id=79917
Unreviewed test directory cleanup.
- svg/misc: Removed.
- svg/misc/resources: Removed.
- 9:11 AM Changeset in webkit [114750] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG anchor on use fails
https://bugs.webkit.org/show_bug.cgi?id=81122
Reviewed by Rob Buis.
Adding a ref test for this bug. This seems to have been fixed, but a
regression test is in order.
- svg/custom/anchor-on-use-expected.svg: Added.
- svg/custom/anchor-on-use.svg: Added.
- 9:08 AM Changeset in webkit [114749] by
-
- 7 edits2 adds in trunk/Source/WebKit
[EFL] Add Security Origin API
https://bugs.webkit.org/show_bug.cgi?id=84023
Source/WebKit:
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- PlatformEfl.cmake:
Source/WebKit/efl:
Added an API to get a Security Origin handle from a Ewk_Frame. This is
needed for fine grained security policy. This new API will also allow
to define quota and get usage information of a Web Storage based on its
Security Origin.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- ewk/EWebKit.h:
- ewk/ewk_frame.cpp:
(ewk_frame_security_origin_get):
- ewk/ewk_frame.h:
- ewk/ewk_security_origin.cpp: Added.
(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_free):
(ewk_security_origin_new):
- ewk/ewk_security_origin.h: Added.
- 8:45 AM Changeset in webkit [114748] by
-
- 7 edits2 adds in trunk/Source/WebCore
Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)
https://bugs.webkit.org/show_bug.cgi?id=84235
Added buttons for navigating on seiarch matches in inspector panel
through button clicks as well.
Patch by Sam D <dsam2912@gmail.com> on 2012-04-20
Reviewed by Pavel Feldman.
No new tests / ux enhanced for search functionality
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- inspector/front-end/Images/searchNext.png: Added.
- inspector/front-end/Images/searchPrev.png: Added.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
(WebInspector.SearchController.prototype._populateSearchNavigationButtons):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
(.toolbar-search-item):
(#search):
(#toolbar-search-navigation-control):
(.toolbar-search-navigation-label):
(.toolbar-search-navigation-label:hover):
(.toolbar-search-navigation-icon-prev , .toolbar-search-navigation-icon-next):
(.toolbar-search-navigation-icon-prev):
(.toolbar-search-navigation-icon-next):
- inspector/front-end/inspector.html:
- 8:38 AM Changeset in webkit [114747] by
-
- 2 edits in trunk/LayoutTests
2012-04-20 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as slow in release mode.
- platform/chromium/test_expectations.txt:
- 8:22 AM BuildBot edited by
- Pulseaudio troubleshooting (diff)
- 8:17 AM Deprecating features and vendor prefixes edited by
- (diff)
- 7:54 AM Changeset in webkit [114746] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=73991
Unmark passing tests (Vista & Win7):
fast/text/international/complex-character-based-fallback.html
fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
fast/text/international/chromium-complex-text-non-printable.html
platform/win/fast/text/uniscribe-missing-glyph.html
fast/text/international/bidi-neutral-run.html
fast/text/international/thai-line-breaks.html
- platform/chromium/test_expectations.txt:
- 7:36 AM Changeset in webkit [114745] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- DEPS:
- 6:33 AM Changeset in webkit [114744] by
-
- 10 edits3 adds in trunk
Web Inspector: extract NavigatorView and NavigatorOverlayController from ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=84441
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Moves NavigatorOverlayController out of ScriptsNavigator
- Extracts NavigatorView from ScriptsNavigator and makes ScriptsNavigator contain 3 NavigatorView instances (one per tab)
- Subclasses SnippetsNavigatorView and leaves it within ScriptsNavigator.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/NavigatorOverlayController.js: Added.
(WebInspector.NavigatorOverlayController.prototype.wasShown):
(WebInspector.NavigatorOverlayController.prototype._createNavigatorControlButton):
(WebInspector.NavigatorOverlayController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
- inspector/front-end/NavigatorView.js: Added.
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._updateScriptTitle.get if):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._scriptSelected):
(WebInspector.NavigatorView.prototype._removeUISourceCode.get while):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._showScriptFoldersSettingChanged):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.get titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.get folderIdentifier):
(WebInspector.NavigatorFolderTreeElement.prototype.get isDomain):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement):
(WebInspector.NavigatorScriptTreeElement.prototype.get uiSourceCode):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onspace):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView):
(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
(WebInspector.SnippetsNavigatorView.prototype._fileRenamed):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/navigatorView.css: Added.
(.navigator-domain-tree-item .icon):
(.navigator-folder-tree-item .icon):
(.navigator-script-tree-item .icon):
(.navigator li):
(.navigator :focus li.selected):
(.navigator li.selected .selection):
(.navigator :focus li.selected .selection):
(.navigator .search-match-found li.selected .selection):
(.navigator .search-match-not-found li.selected .selection):
(.navigator .searching li.selected .selection):
(.navigator .icon):
(.navigator .base-navigator-tree-element-title):
(.navigator .base-navigator-tree-element-title.editing):
(.navigator-tree-search-box):
(.navigator-tree-search-box.visible):
(.navigator-tree-search-box > input):
- inspector/front-end/scriptsPanel.css:
LayoutTests:
- http/tests/inspector/debugger-test.js:
- 5:59 AM Changeset in webkit [114743] by
-
- 56 edits3 deletes in trunk/LayoutTests
[Chromium] Unreviewed test results update
http://code.google.com/p/chromium/issues/detail?id=123809
Rebaseline tests after Skia roll. There was a comment saying
"Rebaseline after Skia rev. 3695 lands", while Skia is
already at r3729.
- platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
- platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.png:
- platform/chromium-linux/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-mac/fast/borders/border-styles-split-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Removed.
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Removed.
- platform/chromium-mac/svg/hixie/perf/001-expected.png:
- platform/chromium-mac/svg/hixie/perf/002-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
- platform/chromium-win/fast/borders/border-styles-split-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/borders/border-radius-complex-inner-expected.txt: Removed.
- 5:30 AM Changeset in webkit [114742] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=29359
Unmark passing fast/forms/date/date-appearance.html
- platform/chromium/test_expectations.txt:
- 5:07 AM Changeset in webkit [114741] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=83826
Remove now passing test from expectations:
fast/text/drawBidiText.html
fast/text/international/bidi-listbox-atsui.html
- platform/chromium/test_expectations.txt:
- 4:58 AM Changeset in webkit [114740] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: make ScriptNavigatorController use views only, rename to NavigatorOverlayController.
https://bugs.webkit.org/show_bug.cgi?id=84352
Reviewed by Vsevolod Vlasov.
This change makes navigator controller use view interfaces only. Focus machinery has been refactored in order
to make it possible: now all view ancestors can either override "focus" or "defaultFocusedElement" method
with latter method being preferred.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.defaultFocusedElement):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.defaultFocusedElement):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
- inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.get view):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.defaultFocusedElement):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.defaultFocusedElement):
(WebInspector.TextEditorMainPanel.prototype.defaultFocusedElement):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.defaultFocusedElement):
- inspector/front-end/View.js:
(WebInspector.View.prototype._collectViewHierarchy):
(WebInspector.View.prototype.defaultFocusedElement):
(WebInspector.View.prototype.setDefaultFocusedElement):
(WebInspector.View.prototype.focus):
- 4:57 AM Changeset in webkit [114739] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
http://code.google.com/p/chromium/issues/detail?id=124313
Mark fast/css/font-face-opentype.html and fast/css/font-face-woff.html
as crashing on Debug XP.
- platform/chromium/test_expectations.txt:
- 4:48 AM Changeset in webkit [114738] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84432
Mark several fast/filesystem tests as failing on Windows.
- platform/chromium/test_expectations.txt:
- 3:56 AM Changeset in webkit [114737] by
-
- 4 edits in trunk
[EFL] [DRT] Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=82867
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
Reviewed by Daniel Bates.
Tools:
Add support for EFL DumpRenderTree EventSender to send
double click events.
- DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
LayoutTests:
Unskip tests connected with double click simulation.
- platform/efl/Skipped:
- 3:54 AM Changeset in webkit [114736] by
-
- 8 edits in trunk
[GTK] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=42432
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Added WebTiming support to the GTK+ port. WebTiming allows
developers to collect detailed network timing information per
resource. It requires the new SoupMessage's "network-event"
signal.
- GNUmakefile.am:
- bindings/gobject/GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::wroteBodyCallback):
(WebCore::requestStartedCallback):
(WebCore::networkEventCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::defaultSession):
Tools:
Build web timing by default whenever build-webkit is used.
- Scripts/build-webkit:
LayoutTests:
Removed some tests that are working fine now after adding Web
Timing support.
- platform/gtk/test_expectations.txt:
- 3:28 AM Changeset in webkit [114735] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
PASS/TIMEOUT on Mac and Win debug.
- platform/chromium/test_expectations.txt:
- 3:02 AM Changeset in webkit [114734] by
-
- 6 edits in trunk
Not reviewed: fixed chromium sanity tests for inspector via assigning last path component
to entire url for parsed urls with invalid specs.
Source/WebCore:
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype._scriptsAreParsed):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- 2:44 AM Changeset in webkit [114733] by
-
- 2 edits in trunk/Tools
[EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
https://bugs.webkit.org/show_bug.cgi?id=84430
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- 2:30 AM Changeset in webkit [114732] by
-
- 51 edits in trunk/Source/WebCore
Unreviewed, rolling out r114401.
http://trac.webkit.org/changeset/114401
https://bugs.webkit.org/show_bug.cgi?id=84161
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(NativeToJSValue):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
- 2:29 AM Changeset in webkit [114731] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114440.
http://trac.webkit.org/changeset/114440
https://bugs.webkit.org/show_bug.cgi?id=84173
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 2:28 AM Changeset in webkit [114730] by
-
- 18 edits in trunk/Source/WebCore
Unreviewed, rolling out r114519.
http://trac.webkit.org/changeset/114519
https://bugs.webkit.org/show_bug.cgi?id=84202
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- 2:15 AM Changeset in webkit [114729] by
-
- 13 edits in trunk/Source/WebCore
Web Inspector: replace @type annotation with @return annotation for getters
https://bugs.webkit.org/show_bug.cgi?id=84362
Reviewed by Yury Semikhatsky.
Otherwise, compiler does not check for errors.
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get searchConfig):
- inspector/front-end/BreakpointManager.js:
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.requestContent):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/ScriptsNavigator.js:
- inspector/front-end/Settings.js:
- inspector/front-end/SnippetsModel.js:
- inspector/front-end/SplitView.js:
- inspector/front-end/TabbedEditorContainer.js:
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab):
- inspector/front-end/TextEditorModel.js:
- inspector/front-end/TimelinePresentationModel.js:
- 1:49 AM Changeset in webkit [114728] by
-
- 5 edits in trunk/Source
[Chromium] Call cacheMetadata directly
https://bugs.webkit.org/show_bug.cgi?id=84415
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 1:41 AM Changeset in webkit [114727] by
-
- 5 edits in trunk/Source
[Chromium] Call stopSharedTimer directly
https://bugs.webkit.org/show_bug.cgi?id=84418
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/SharedTimerChromium.cpp:
(WebCore::stopSharedTimer):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 12:50 AM Changeset in webkit [114726] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Chromium] Unreviewed test results update.
Remove unneeded test results.
- platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- 12:42 AM Changeset in webkit [114725] by
-
- 2 edits in trunk/Tools
REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
https://bugs.webkit.org/show_bug.cgi?id=84424
Reviewed by Mark Rowe.
Let Windows and Chromium have their own list of files to copy.
- BuildSlaveSupport/built-product-archive:
(removeDirectoryIfExists):
(copyBuildFiles):
(archiveBuiltProduct):
- 12:40 AM Changeset in webkit [114724] by
-
- 3 edits2 adds in trunk
DOMFileSystem::scheduleCallback() crashes on file() call after reload.
https://bugs.webkit.org/show_bug.cgi?id=76461
DOMFileSystem::scheduleCallback() is unavailable when the page in unloading, so we should
avoid using it in callback.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-04-20
Reviewed by David Levin.
Source/WebCore:
Test: fast/filesystem/file-after-reload-crash.html
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore):
LayoutTests:
- fast/filesystem/file-after-reload-crash-expected.txt: Added.
- fast/filesystem/file-after-reload-crash.html: Added.
- 12:37 AM April 2012 Meeting edited by
- (diff)
- 12:33 AM Changeset in webkit [114723] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
timing out on Linux debug.
- platform/chromium/test_expectations.txt:
- 12:27 AM Changeset in webkit [114722] by
-
- 7 edits1 add in trunk
[EFL] Add setting API for author and user styles.
https://bugs.webkit.org/show_bug.cgi?id=82860
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
Source/WebKit/efl:
Add missing implementation setAuthorAndUserStylesEnabled to EFL's
DumpRenderTreeSupport.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
Tools:
Implementation of setAuthorAndUserStylesEnabled.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled):
LayoutTests:
Enable test connected with setAuthorAndUserStylesEnabled.
- platform/efl/Skipped:
- platform/efl/fast/css/disabled-author-styles-expected.txt: Added.
