⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 5, 2012:

10:27 PM Changeset in webkit [116233] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove TrustedImm32::m_isPointer
https://bugs.webkit.org/show_bug.cgi?id=85726

Rubber stamped by Sam Weinig.

We used to rely on being able to generate code with known, fixed offsets – to do so we
would inhibit more optimal code generation for pointers. This is no longer necessary.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::move):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::move):

4:04 PM Changeset in webkit [116232] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r116221.
http://trac.webkit.org/changeset/116221
https://bugs.webkit.org/show_bug.cgi?id=85722

broke builds that use -Wshorten-64-to-32 (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html:
2:41 PM Changeset in webkit [116231] by kov@webkit.org
  • 5 edits in trunk/Source

[GTK] WebKit should properly set the input method context window location
https://bugs.webkit.org/show_bug.cgi?id=84981

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect): Add this method to plumb the
cursor rect through to the input method.

  • platform/gtk/GtkInputMethodFilter.h: Add the new method declaration.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::paint): During painting, update the cursor rectangle
if possible.

2:38 PM Changeset in webkit [116230] by dino@apple.com
  • 27 edits
    3 adds in trunk

Add new Setting/Preference to disable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=85693

Reviewed by Simon Fraser.

Source/WebCore:

Hook up the new WebPreference for disabling requestAnimationFrame
to Settings. This isn't disabling the feature in the typical
WebKit ENABLE() way - it's still available in the DOM, it's
just that the animations will never be serviced. This allows a client
to disable the machinery without breaking content (other than the
animations).

The new test is currently skipped on all platforms because toggling
the preference interferes with the other tests that are running
at the same time (and expect a working requestAnimationFrame).
https://bugs.webkit.org/show_bug.cgi?id=85689

Test: fast/animation/request-animation-frame-disabled.html

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
Check the setting before deciding to act.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setRequestAnimationFrameEnabled):
(WebCore::Settings::requestAnimationFrameEnabled):
(Settings):

Source/WebKit/mac:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences requestAnimationFrameEnabled]):
(-[WebPreferences setRequestAnimationFrameEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRequestAnimationFrameEnabled):
(WKPreferencesGetRequestAnimationFrameEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

A new test that exercises turning the requestAnimationFrame
preference off. Unfortunately this conflicts with the parallel
tests that expect the preference to be on (as it should by default),
so the test is skipped on all platforms. It can be run in isolation.
https://bugs.webkit.org/show_bug.cgi?id=85689

  • fast/animation/request-animation-frame-disabled-expected.txt: Added.
  • fast/animation/request-animation-frame-disabled.html: Added.
  • fast/animation/script-tests/request-animation-frame-disabled.js: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
  • platform/win/test_expectations.txt:
2:08 PM Changeset in webkit [116229] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697

Reviewed by Eric Seidel.

  • Scripts/new-run-webkit-tests: Instead of manually detecting whether

the path separator should be ':' or ';' by checking sys.platform, rely
on os.pathsep which has exactly the same information (os.pathsep is
':' for Cygwin, from what I could check in Python's sources).

2:00 PM Changeset in webkit [116228] by kov@webkit.org
  • 4 edits in trunk

Unreviewed preparation for 1.9.2.

  • configure.ac: bump version to 1.9.2 and bump libtool version.

Source/WebKit/gtk:

  • NEWS: changes from 1.9.1.
1:59 PM Changeset in webkit [116227] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, make distcheck fix.

Source/WebCore:

  • GNUmakefile.list.am: Add missing headers to the sources list.
12:38 PM Changeset in webkit [116226] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Incoming events may be processed out-of-order
https://bugs.webkit.org/show_bug.cgi?id=85696
<rdar://problem/11386129>

Reviewed by Maciej Stachowiak.

All messages go to a single queue that gets iterated over by dispatchMessages(). If an input
event arrives in the middle of a flood of messages, all of them will be dispatched before the
input event is dispatched.

In other words, the first dispatchMessages() call will process all of the messages in the queue,
and all subsequent dispatchMessages() calls will act as no-ops, since there is nothing in the queue.

To fix this, we rename dispatchMessages to dispatchOneMessage, and only process one message at a
time.

  • Platform/CoreIPC/Connection.h: Rename dispatchMessages() to dispatchOneMessage().
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::enqueueIncomingMessage): Dispatch a call to dispatchOneMessage() on the
run loop.
(CoreIPC::Connection::dispatchOneMessage): Remove the while(true) loop.

10:05 AM Changeset in webkit [116225] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: unreviewed followup fix for the performance test after r116218.

  • inspector/heap-snapshot.html:
9:54 AM Changeset in webkit [116224] by rakuco@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r116223.
http://trac.webkit.org/changeset/116223
https://bugs.webkit.org/show_bug.cgi?id=85718

The bots need to set XDG_DATA_DIRS (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
9:34 AM Changeset in webkit [116223] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=85717

Reviewed by Martin Robinson.

After r116209, the XDG_DATA_DIRS environment variable is now
passed by webkitpy's layout_tests code to run-with-jhbuild, so
instead of setting a few defaults in jhbuildrc we can now rely on
the values set and really used by each system.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
8:33 AM Changeset in webkit [116222] by loislo@chromium.org
  • 15 edits
    1 add in trunk/Source/WebCore

Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object.
https://bugs.webkit.org/show_bug.cgi?id=85710

The idea is to have an object and be able to add/remove event listeners from it.

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileManager.js: Copied from Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js.

(WebInspector.FileManager):
(WebInspector.FileManager.prototype.canSave):
(WebInspector.FileManager.prototype.canAppend):
(WebInspector.FileManager.prototype.append):
(WebInspector.FileManager.prototype.appendedToURL):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
7:51 AM Changeset in webkit [116221] by zmo@google.com
  • 7 edits in trunk

vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h: Ditto

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.
5:24 AM Changeset in webkit [116220] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: add separate timeline overview item for the frame mode
https://bugs.webkit.org/show_bug.cgi?id=85706

  • remove two-buttons horizontal/vertical mode switch from Timelines item of the timeline overview menu;
  • rename "Timeline" into "Events";
  • add "Frames" item;
  • replace overview sidebar icons with smaller, monochrome ones.
  • English.lproj/localizedStrings.js: Added "Frames" and "Events".
  • inspector/front-end/Images/statusbarButtonGlyphs.png: Added icon for "Memory".
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setMode):

  • inspector/front-end/timelinePanel.css:

(#timeline-overview-sidebar .sidebar-tree-item):
(#timeline-overview-sidebar .sidebar-tree-item .titles.no-subtitle):
(#timeline-overview-sidebar .icon):
(.timeline-overview-sidebar-events .icon):
(.timeline-overview-sidebar-frames .icon):
(.timeline-overview-sidebar-memory .icon):

3:25 AM Changeset in webkit [116219] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

Not reviewed: follow up to r116216, fixing the inspector test.

  • inspector/debugger/script-extract-outline.html:
  • inspector/debugger/script-extract-outline-expected.txt:
3:23 AM Changeset in webkit [116218] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: save HeapSnapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=85595

HeapSnapshot specific implementation for loading was moved
from ProfilesPanel to HeapProfileHeader class.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load.setProfileWait):
(WebInspector.HeapProfileHeader.prototype.load.done):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.appendedToURL):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

  • inspector/front-end/inspector.js:

(WebInspector.append):
(WebInspector.appendedToURL):

LayoutTests:

  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

3:07 AM Changeset in webkit [116217] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: allow overriding the script mapping on the UI level
https://bugs.webkit.org/show_bug.cgi?id=85702

Reviewed by Yury Semikhatsky.

Source/WebCore:

This allows formatting update live locations all over the place automatically.

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.update):
(WebInspector.Script.Location.prototype.dispose):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.removeLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
(WebInspector.UISourceCode.prototype.overrideLocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
2:46 AM Changeset in webkit [116216] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: simplify the JavaScriptOutline dialog interaction.
https://bugs.webkit.org/show_bug.cgi?id=85701

Reviewed by Yury Semikhatsky.

Removed bidirectional dependency between scripts panel and outline dialog.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.show):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):

  • inspector/front-end/ScriptFormatterWorker.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.addToWatch):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):

2:38 AM Changeset in webkit [116215] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Buildfix for --minimal build after r116107.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-05
Reviewed by Csaba Osztrogonác.

  • qmake/mkspecs/features/features.prf:
12:46 AM Changeset in webkit [116214] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed Gtk gardening, mark fullscreen/non-ancestor-iframe.html as
failing after it was added in r116165.

  • platform/gtk/test_expectations.txt:
12:43 AM Changeset in webkit [116213] by caseq@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline fast/events/attribute-listener-deletion-crash.html (added in r116191).

  • platform/chromium/fast/events/attribute-listener-deletion-crash-expected.txt: Added.
12:34 AM Changeset in webkit [116212] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] GtkDriver is not required anymore after r116134
https://bugs.webkit.org/show_bug.cgi?id=85699

Reviewed by Csaba Osztrogonác.

Remove GtkDriver as it was replaced by the XvfbDriver and is
no longer needed.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
12:25 AM Changeset in webkit [116211] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Increase the display ID for the Xvfb process to use if pixel_tests argument
is true rather than if pixel_tests option is present. This fixes the
XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.

Rubber-stamped by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

May 4, 2012:

11:52 PM Changeset in webkit [116210] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: annotate ProfilerAgent.
https://bugs.webkit.org/show_bug.cgi?id=85630

Reviewed by Pavel Feldman.

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createProfileHeader):
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createProfile):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilerDispatcher.prototype.resetProfiles):

10:48 PM Changeset in webkit [116209] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
https://bugs.webkit.org/show_bug.cgi?id=85694

Reviewed by Martin Robinson.

This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
preserved, as it is particularly useful for Linux/Unix
environments. As a real use case, if shared-mime-info is
installed into a non-trivial prefix, Glib and other libraries will
have trouble to properly identify mimetypes (in ResourceResponses,
for example) as the base freedesktop.org mimetype file will not be
found.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

9:26 PM Changeset in webkit [116208] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r116097.

The test was unskipped from Skipped, but some other commit added it to
test_expectations.txt as well...

  • platform/efl/test_expectations.txt:
9:26 PM Changeset in webkit [116207] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip tests that depend on beginDragWithFiles.

  • platform/efl/Skipped:
8:56 PM Changeset in webkit [116206] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, rebaseline after r116009.

  • platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
8:35 PM Changeset in webkit [116205] by kov@webkit.org
  • 8 edits in trunk

[GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=85691

Source/WebCore:

  • GNUmakefile.am: link libWebCoreModules into libWebCore.

Source/WebKit/gtk:

  • GNUmakefile.am: no longer link libwebkitgtk to libWebCoreModules.

Source/WebKit2:

  • GNUmakefile.am: no longer link libWebCoreModules, and remove -no-

fast-install and -no-install from link flags, since we want those
programs installed.

Tools:

  • GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
7:54 PM Changeset in webkit [116204] by tkent@chromium.org
  • 6 edits
    2 moves in trunk/Source

Rename ICULocale to LocaleICU, part 1
https://bugs.webkit.org/show_bug.cgi?id=85688

Reviewed by Kentaro Hara.

Source/WebCore:

Rename it for consistency. Our convention is Foo<Platform>.{cpp,h}.
This patch changes only file names. We'll rename ICULocale class
by a following patch.

No behavior changes.

  • WebCore.gypi:
  • platform/text/LocaleICU.cpp: Renamed from Source/WebCore/platform/text/ICULocale.cpp.
  • platform/text/LocaleICU.h: Renamed from Source/WebCore/platform/text/ICULocale.h.
  • platform/text/LocalizedDateICU.cpp: Rename ICULocale.h to LocaleICU.h.
  • platform/text/LocalizedNumberICU.cpp: ditto.

Source/WebKit/chromium:

  • tests/LocalizedNumberICUTest.cpp: Rename ICULocale.h to LocaleICU.h.
7:17 PM Changeset in webkit [116203] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Leaf non self-painting layers should bail out early in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=85678

Reviewed by Darin Adler.

Performance optimization, no expected change in behavior.

The gist of the change is that leaf non self-painting layers don't need to be painted as their
associated RenderBoxModelObject should properly paint itself without any help.

For RenderLayer trees that have a large number of leafs nodes (like a table with a leaf RenderLayer for
each cells), not bailing out is a big overhead as it ends up doing a lot of computation for no real
painting. See http://dglazkov.github.com/performance-tests/biggrid.html for a benchmark for that. On
my machine, it reduces the paint time when scrolling to 70ms from 120ms (45% speedup).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

6:43 PM Changeset in webkit [116202] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove InlineBox::next()
https://bugs.webkit.org/show_bug.cgi?id=85668

Reviewed by Nikolas Zimmermann.

InlineBox::next() not needed since nextOnLine() does the same.

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setConstructed):

6:28 PM Changeset in webkit [116201] by crogers@google.com
  • 10 edits
    1 add in trunk

Oscillator must implement noteOn() and noteOff()
https://bugs.webkit.org/show_bug.cgi?id=85236

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/oscillator-scheduling.html
to be landed separately to get proper platform baselines

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
Simplify/remove zeroing-out silence at end of buffer, since it's now handled in the base-class AudioScheduledSourceNode::updateSchedulingInfo().

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createBufferSource):
Improve comment about ownership and dynamic-lifetime of AudioBufferSourceNode.

(WebCore::AudioContext::createOscillator):
AudioContext keeps a reference to the Oscillator and that reference is released in AudioScheduledSourceNode,
when it has finished playing.

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
updateSchedulingInfo() is now responsible for zeroing out the very start (before a note starts)
and the very end (after note ends) of the output AudioBus. We've also simplified the number
of arguments passed to this method, because of this. It now handles playbackState transition to FINISHED_STATE.

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
The frequency value needs to snap immediately to its correct value the very first time.
This bug needs to be fixed here so that the Oscillator layout scheduling test works correctly.

(WebCore::Oscillator::process):
Since Oscillator in now changing to be a AudioScheduledSourceNode, we need to call AudioScheduledSourceNode::updateSchedulingInfo()
to handle playbackState for us.

(WebCore::Oscillator::propagatesSilence):
Add scheduling logic for propagatesSilence().

(Oscillator):

  • Modules/webaudio/Oscillator.idl:

Add noteOn(), noteOff() methods and playbackState according to specification.

LayoutTests:

  • webaudio/oscillator-scheduling-expected.wav: Added.
  • webaudio/resources/oscillator-testing.js:

(generateExponentialOscillatorSweep):

6:17 PM Changeset in webkit [116200] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a leak in WebProcess when it is used to launch the UI process.

Rubber-stamped by Anders Carlsson.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Destory the attributes and file actions after
spawning the subprocess.

6:12 PM Changeset in webkit [116199] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[Blackberry] Implement over-scroll background image
https://bugs.webkit.org/show_bug.cgi?id=85538

Patch by Andrew Lo <anlo@rim.com> on 2012-05-04
Reviewed by Rob Buis.

Use over-scroll image when set instead of the solid colour.
Internal PR146652

  • Api/BackingStore.cpp:

(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::overScrollImagePath):
(BlackBerry::WebKit::WebSettings::setOverScrollImagePath):

  • Api/WebSettings.h:
5:54 PM Changeset in webkit [116198] by aestes@apple.com
  • 8 edits in trunk/Source/WebCore

Remove uses of ASSERT(false)
https://bugs.webkit.org/show_bug.cgi?id=85686

Reviewed by Dean Jackson.

Replace uses of ASSERT(false) with ASSERT_NOT_REACHED(). Also, in two places, there was code structured like:

if (expr) {

do something

} else {

ASSERT(false);

}

Replace this with:

ASSERT(expr);
if (!expr)

return;

do something

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deleteDatabase):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

  • dom/Node.cpp:

(WebCore::Node::createRenderer):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase):
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::doPacking):

  • platform/text/BidiResolver.h:

(WebCore::::createBidiRunsForLine):

5:54 PM Changeset in webkit [116197] by commit-queue@webkit.org
  • 7 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Rebaseline chromium after r116069 (bug 85031)
https://bugs.webkit.org/show_bug.cgi?id=85626

Patch by David Barr <davidbarr@chromium.org> on 2012-05-04
Reviewed by Ojan Vafai.

  • fast/block/float/016-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/016-expected.txt.
  • platform/chromium-linux/fast/block/float/016-expected.png:
  • platform/chromium-linux/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/016-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/016-expected.png:
  • platform/chromium-mac/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/016-expected.txt: Removed.
5:49 PM Changeset in webkit [116196] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
https://bugs.webkit.org/show_bug.cgi?id=85280

Reviewed by Kenneth Russell.

This patch means to simplify the diff of an upcoming patch. Refactoring
here in preparation for that patch.

No new tests. No behavioral change. Covered by canvas 2d and 3d tests:

canvas/philip/tests/*toDataURL*.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageToDataURL): Move the invalid image (!image) test here.
The comments are about JPEG images; say that. Rename out to base64Data.
(WebCore::ImageBuffer::toDataURL): Remove the !image test.
(WebCore::ImageDataToDataURL): Move and define variables where used and
make the code flow read similarly to toDataURL. Remove the !image test.

5:38 PM Changeset in webkit [116195] by shawnsingh@chromium.org
  • 7 edits in trunk/Source

[chromium] Changes to layer tree structure need to be tracked properly
https://bugs.webkit.org/show_bug.cgi?id=85421

Reviewed by Adrienne Walker.

Unit test added: TreeSynchronizerTest.syncSimpleTreeAndTrackStackingOrderChange

Source/WebCore:

Earlier, we were relying on WebCore behavior that always called
setNeedsDisplay whenever the layer tree structure changed.
However, in general it is more correct to consider layer tree
changes even when things don't need repainting; for example Aura
code is encountring this bug now. This patch corrects the
compositor so that layer tree structural changes are considered
property changes, without requiring that layers needed to be
repainted.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::insertChild):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setStackingOrderChanged):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

Source/WebKit/chromium:

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests):
(WebKitTests::TEST):

5:10 PM Changeset in webkit [116194] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; build fix after r116191.

  • bindings/js/JSEventListener.h:
5:04 PM Changeset in webkit [116193] by eric@webkit.org
  • 2 edits in trunk/Tools

Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85583

Reviewed by Daniel Bates.

  • Scripts/webkitperl/FeatureList.pm:
4:55 PM Changeset in webkit [116192] by enrica@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION: Cursor jumps to the first line after deleting the last word.
https://bugs.webkit.org/show_bug.cgi?id=85334
<rdar://problem/11210059>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This regression was introduced with the work to remove redundant divs.
When we decide to remove a DIV, we need to adjust the selection, if it is
expressed in terms of the node being removed. The new position was computed
using updatePositionForNodeRemoval that was not designed for the case where we
remove preserving children.
This patch adds a new method to CompositeEditCommand to do this properly.

Test: editing/deleting/delete-word-from-unstyled-div.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::isRemovableBlock): Code clenup.
(WebCore::CompositeEditCommand::updatePositionForNodeRemovalPreservingChildren): Added.

  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Uses updatePositionForNodeRemovalPreservingChildren.

LayoutTests:

  • editing/deleting/delete-word-from-unstyled-div-expected.txt: Added.
  • editing/deleting/delete-word-from-unstyled-div.html: Added.
4:42 PM Changeset in webkit [116191] by jpfau@apple.com
  • 3 edits
    2 adds in trunk

Prevent early EventListener deletion
https://bugs.webkit.org/show_bug.cgi?id=73970

Reviewed by Oliver Hunt.

Source/WebCore:

Test: fast/events/attribute-listener-deletion-crash.html

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

LayoutTests:

  • fast/events/attribute-listener-deletion-crash-expected.txt: Added.
  • fast/events/attribute-listener-deletion-crash.html: Added.
4:42 PM Changeset in webkit [116190] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] enable msvs_error_on_missing_sources at gyp time
https://bugs.webkit.org/show_bug.cgi?id=85683

Reviewed by Adam Barth.

This flag checks for missing files, which cause compile times to be
slow on Windows. Since this flag is on by default for the
build.chromium.org bots, we should add it here too so everyone can fix
these errors.

  • DEPS: Roll to a chromium version that has no missing files.
  • gyp_webkit: Add the flag.
4:34 PM Changeset in webkit [116189] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Add "combining short stroke overlay character (u0335)" to lookalike characters blacklist.
https://bugs.webkit.org/show_bug.cgi?id=85440

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-05-04
Reviewed by David Kilzer.

We should add u0335 to the characters blacklist.

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::isLookalikeCharacter):

4:31 PM Changeset in webkit [116188] by jer.noble@apple.com
  • 3 edits
    1 add in trunk

Flash of white when exiting full screen HTML5 video
https://bugs.webkit.org/show_bug.cgi?id=85438

.:

Reviewed by Sam Weinig.

  • ManualTests/fullscreen/full-screen-flash.html: Added.

Source/WebKit2:

Reviewed by Maciej Stachowiak.

Force a repaint before displaying the newly exited WebView window. This gives the window
a chance to seamlessly repaint before enabling screen updates.

Also, send the WebProcess the didExitFullScreen and setAnimatingFullScreen(false) messages
after swapping the WebView back into its original window. Doing otherwise seems to cause
forceRepaint to paint a white frame.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(completeFinishExitFullScreenAnimationAfterRepaint):

4:11 PM Changeset in webkit [116187] by eric@webkit.org
  • 2 edits in trunk/Tools

Sort entries in FeaturesList.pm to make them easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85584

Reviewed by Daniel Bates.

No functional changes, only sorting.

  • Scripts/webkitperl/FeatureList.pm:
3:59 PM Changeset in webkit [116186] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Add plumbing for file display names for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=85673

Patch by Satoru Takabayashi <satorux@chromium.org> on 2012-05-04
Reviewed by Darin Fisher.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

Source/WebKit/chromium:

  • public/platform/WebDragData.h:
  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):

3:55 PM Changeset in webkit [116185] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct pixel snapping in RenderSVGRoot::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=85671

Reviewed by Eric Seidel.

SVG root elements are still painted on pixel boundaries, so their children should
apply transforms based on their actual painted location, not their sub-pixel
one. This corrects a clipping and painting issue where these sub-pixel units are
incorrectly applied to the graphics context.

Covered by existing tests when sub-pixel layout is enabled.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

3:54 PM Changeset in webkit [116184] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

3:44 PM Changeset in webkit [116183] by Lucas Forschler
  • 4 edits in tags/Safari-536.10.1/Source

Versioning.

3:38 PM Changeset in webkit [116182] by Lucas Forschler
  • 1 copy in tags/Safari-536.10.1

New Tag.

3:25 PM Changeset in webkit [116181] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated Spanish translation
https://bugs.webkit.org/show_bug.cgi?id=83995

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

  • es.po:
3:19 PM Changeset in webkit [116180] by aestes@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
https://bugs.webkit.org/show_bug.cgi?id=85675

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::TEST): Disable the test.

3:08 PM Changeset in webkit [116179] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=85674

Reviewed by Oliver Hunt.

Null check the results of core([frame DOMDocument]).

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]):

3:01 PM Changeset in webkit [116178] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Set the right device scale factor when creating the web page
https://bugs.webkit.org/show_bug.cgi?id=85667
<rdar://problem/11376611>

Reviewed by Oliver Hunt.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
Set the scale factor before initializing the page, to ensure that the WebPageCreationParameters struct gets the right scale factor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
This can now be called with a null drawing area. Also, remove the isValid() check since we still want to update the scale factor even if the web process has crashed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Set the device scale factor from the creation parameters.

2:40 PM Changeset in webkit [116177] by abarth@webkit.org
  • 8 edits in trunk/Source

Refactor CSP state to prepare for having both a ReportOnly and an Enforced policy
https://bugs.webkit.org/show_bug.cgi?id=85662

Reviewed by Eric Seidel.

Source/WebCore:

This patch refactors the ContentSecurityPolicy state into a separate
DirectiveList class to prepare for
https://bugs.webkit.org/show_bug.cgi?id=85561, which will cause us to
need two directive lists: one for enforcement and one for monitoring.

This patch shouldn't cause any change in behavior.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::header):
(WebCore::CSPDirectiveList::headerType):
(WebCore::CSPDirectiveList::denyIfEnforcingPolicy):
(WebCore):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::create):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::logUnrecognizedDirective):
(WebCore::CSPDirectiveList::checkEval):
(WebCore::CSPDirectiveList::operativeDirective):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectFromSource):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseDirective):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::createCSPDirective):
(WebCore::CSPDirectiveList::applySandboxPolicy):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::~ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore::ContentSecurityPolicy::header):
(WebCore::ContentSecurityPolicy::headerType):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):

  • page/ContentSecurityPolicy.h:

(WebCore):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Update callers to the new function name.

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

2:38 PM Changeset in webkit [116176] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations.

  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
2:34 PM Changeset in webkit [116175] by fpizlo@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, checking in new expectation file.

  • platform/mac/fast/images/png-suite/test-expected.txt: Added.
2:33 PM Changeset in webkit [116174] by inferno@chromium.org
  • 16 edits
    2 adds in trunk

ASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=84606

Reviewed by Julien Chaffraix.

Source/WebCore:

RenderBlock::removeChild forgot to set display on the anonymous block, causing it
to display as INLINE. To prevent this kind of failure in future, we replace
createAnonymousStyle with createAnonymousStyleWithDisplay to make everyone explictly
pass display as the argument.

Test: fast/block/block-add-child-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):

  • rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::addChildIgnoringContinuation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderRuby.cpp:

(WebCore::createAnonymousRubyInlineBlock):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRenderer):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::createAnonymousWithParentRenderer):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createAnonymousStyleWithDisplay):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/block/block-add-child-crash-expected.txt: Added.
  • fast/block/block-add-child-crash.html: Added.
2:30 PM Changeset in webkit [116173] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

Taking a visibility:hidden element full screen causes full screen window to disappear.
https://bugs.webkit.org/show_bug.cgi?id=85432

Reviewed by Maciej Stachowiak.

.:

  • ManualTests/fullscreen/full-screen-zero-width.html: Added.

Source/WebKit/mac:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

  • WebView/WebFullScreenController.mm:

(windowFrameFromApparentFrames):

Source/WebKit2:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(windowFrameFromApparentFrames):

2:23 PM Changeset in webkit [116172] by arv@chromium.org
  • 13 edits
    1 copy
    12 adds in trunk/Source/WebCore

WebKit IDL does not use exception syntax
https://bugs.webkit.org/show_bug.cgi?id=85100

Reviewed by Dimitri Glazkov.

This adds support for exception ExceptionName { ... } which currently sets a flag
on the domClass.

Binding tests updated.

  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/webdatabase/SQLException.idl:
  • bindings/scripts/IDLParser.pm:

(ParseInterface):
(DetermineParseMode):
(ProcessSection):

  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp: Added.

(WebDOMTestException::WebDOMTestExceptionPrivate::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestException):
(WebDOMTestException::operator=):
(WebDOMTestException::impl):
(WebDOMTestException::~WebDOMTestException):
(WebDOMTestException::name):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestException.h: Added.

(WebCore):
(WebDOMTestException):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp: Added.

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_set_property):
(webkit_dom_test_exception_get_property):
(webkit_dom_test_exception_constructed):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):
(webkit_dom_test_exception_get_name):

  • bindings/scripts/test/GObject/WebKitDOMTestException.h: Added.

(_WebKitDOMTestException):
(_WebKitDOMTestExceptionClass):

  • bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h: Added.

(WebKit):

  • bindings/scripts/test/JS/JSTestException.cpp: Added.

(WebCore):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestExceptionConstructor::getOwnPropertySlot):
(WebCore::JSTestExceptionConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestExceptionPrototype::self):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::finishCreation):
(WebCore::JSTestException::createPrototype):
(WebCore::JSTestException::destroy):
(WebCore::JSTestException::~JSTestException):
(WebCore::JSTestException::getOwnPropertySlot):
(WebCore::JSTestException::getOwnPropertyDescriptor):
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
(WebCore::JSTestException::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestExceptionOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestExceptionOwner::finalize):
(WebCore::toJS):
(WebCore::toTestException):

  • bindings/scripts/test/JS/JSTestException.h: Added.

(WebCore):
(JSTestException):
(WebCore::JSTestException::create):
(WebCore::JSTestException::createStructure):
(WebCore::JSTestException::impl):
(WebCore::JSTestException::releaseImpl):
(WebCore::JSTestException::releaseImplIfNotNull):
(JSTestExceptionOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestExceptionPrototype):
(WebCore::JSTestExceptionPrototype::create):
(WebCore::JSTestExceptionPrototype::createStructure):
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestException.h: Added.
  • bindings/scripts/test/ObjC/DOMTestException.mm: Added.

(-[DOMTestException dealloc]):
(-[DOMTestException finalize]):
(-[DOMTestException name]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: Added.

(WebCore):

  • bindings/scripts/test/TestException.idl: Copied from Source/WebCore/xml/XPathException.idl.
  • bindings/scripts/test/V8/V8TestException.cpp: Added.

(WebCore):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::V8_USE):
(WebCore::TestExceptionV8Internal::nameAttrGetter):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore::V8TestException::wrapSlow):
(WebCore::V8TestException::derefObject):

  • bindings/scripts/test/V8/V8TestException.h: Added.

(WebCore):
(V8TestException):
(WebCore::V8TestException::toNative):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

  • dom/DOMCoreException.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • svg/SVGException.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
2:21 PM Changeset in webkit [116171] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebCore

V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
https://bugs.webkit.org/show_bug.cgi?id=85659

Reviewed by Ojan Vafai.

Added a stack-allocted V8RecursionScope to the newInstance call.

No new tests. No change in observable behavior.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::newInstance):

2:20 PM Changeset in webkit [116170] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Remove all index metadata records when deleting an index
https://bugs.webkit.org/show_bug.cgi?id=85557

Reviewed by Tony Chang.

An assert is hit when re-loading database from backing store due to stale index
metadata entry. Do a range delete to clear all metadata entries when deleting an
index. Define metadata entries as enum and limits as consts instead of hardcoded ints.

No new tests - issue does not repro as layout test. Will land test in Chromium.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::getBool): Helper functions; replaces pattern of putInt()/read only lead byte.
(WebCore):
(WebCore::putBool):
(WebCore::IDBLevelDBBackingStore::getObjectStores): Skip stale data. Use enums, helpers.
(WebCore::IDBLevelDBBackingStore::createObjectStore): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteObjectStore): Use enums.
(WebCore::getNewVersionNumber): Use enums.
(WebCore::IDBLevelDBBackingStore::getIndexes): Skip stale data. Use enums, helpers.
(WebCore::getNewIndexId): Use enums.
(WebCore::IDBLevelDBBackingStore::createIndex): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteIndex): Delete metadata by range.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding): Add constants for metadata maximum values.
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): Use consts.
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): Use consts.

  • Modules/indexeddb/IDBLevelDBCoding.h:

(IDBLevelDBCoding): Expose enums for metadata types.

2:19 PM Changeset in webkit [116169] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] IETC flexbox reference tests have pixel differences (due to embedded color profiles?)
https://bugs.webkit.org/show_bug.cgi?id=85666

  • platform/mac/Skipped: Skip the tests.
2:18 PM Changeset in webkit [116168] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG should not Flush GetLocal's
https://bugs.webkit.org/show_bug.cgi?id=85663
<rdar://problem/11373600>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

  • fast/js/dfg-flush-get-local-expected.txt: Added.
  • fast/js/dfg-flush-get-local.html: Added.
  • fast/js/script-tests/dfg-flush-get-local.js: Added.

(foo):
(fuzz):
(bar):

2:16 PM Changeset in webkit [116167] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Move markPagesForFullStyleRecalc to PageCache
https://bugs.webkit.org/show_bug.cgi?id=85664

Reviewed by Dan Bernstein.

Instead of going through all the history items in the back/forward list looking for cached pages, just iterate over the cached pages in the page.

  • history/BackForwardController.cpp:
  • history/BackForwardController.h:
  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore):

  • history/PageCache.h:

(PageCache):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):

2:15 PM Changeset in webkit [116166] by tony@chromium.org
  • 5 edits in trunk

The computed style of flex-item-align should never be auto.
https://bugs.webkit.org/show_bug.cgi?id=85656

Reviewed by Ojan Vafai.

Source/WebCore:

If the node lacks a parent and flex-item-align is auto, we should
return stretch. This was recently clarified in the spec.

New testcase in css3/flexbox/css-properties.html.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
2:00 PM Changeset in webkit [116165] by jer.noble@apple.com
  • 16 edits
    3 adds in trunk

Full screen will exit during a provisional load of a non-ancestor iframe.
https://bugs.webkit.org/show_bug.cgi?id=85230

Reviewed by Maciej Stachowiak .

Source/WebKit/mac:

Only exit full screen mode if the frame being loaded contains the full
screen element.

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the
request to close the full screen window when a provisional load occurs.

Source/WebKit2:

Only exit full screen mode if the frame being loaded contains the full
screen element:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

Move the full screen exiting logic up into WebFrameLoaderClient in the
WebProcess:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add a WebFullScreenManager "close" method & message:

  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::close):

  • WebProcess/FullScreen/WebFullScreenManager.h:

Add support for this new message to the WKBundlePage and client:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:

(WebKit::InjectedBundlePageFullScreenClient::closeFullScreen):

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Tools:

Add support for the new UIDelegate webView:closeFullScreenWithListener: method:

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:closeFullScreenWithListener:]):

Add support for the new closeFullScreen injected bundle method:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::closeFullScreen):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

  • fullscreen/non-ancestor-iframe-expected.txt: Added.
  • fullscreen/non-ancestor-iframe.html: Added.
  • fullscreen/resources/empty.html: Added.
1:59 PM Changeset in webkit [116164] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit

Move WebKitFullScreenListener into its own file.
https://bugs.webkit.org/show_bug.cgi?id=85640

Source/WebKit:

Reviewed by Maciej Stachowiak .

Pull WebKitFullScreenListener into its own file.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

Move WebKitFullScreenListener into its own file, so it can be used by multiple classes.

  • WebCoreSupport/WebKitFullScreenListener.h: Added.
  • WebCoreSupport/WebKitFullScreenListener.mm: Added.

(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitDidEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
(-[WebKitFullScreenListener webkitDidExitFullScreen]):

  • WebCoreSupport/WebChromeClient.mm:
1:54 PM Changeset in webkit [116163] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix test naming to be camel-case like the methods they are testing.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

1:50 PM Changeset in webkit [116162] by ojan@chromium.org
  • 3 edits in trunk/Tools

Show the results links in the embedded flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85660

Reviewed by Adam Barth.

Turns out these links don't add much visual noise and it's annoying
to have to go to the dashboard from garden-o-matic just to view the
results for a test.

This is useful for cases where garden-o-matic doesn't properly show the
results (e.g. missing tests). If we address all those cases, then
we could easily hide the results links again if we wanted to.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(showUpdateInfoForTest):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

1:46 PM Changeset in webkit [116161] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Revert to using chromium --test-shell mode on SL in NRWT

https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix.

We seem to be seeing a lot more flakiness on the bot since
I switched NRWT to "DRT" mode. We'll try reverting back and
see if this helps things.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):

1:33 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
1:28 PM Changeset in webkit [116160] by commit-queue@webkit.org
  • 4 edits in trunk

[soup] URL of the ResourceResponse passed to willSendRequest is incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Store the response message by catching the "got-headers" signal so
that it can be passed later to willSendRequest() in case of
redirection. This is required because the SoupMessage headers and URL
have already been updated once restartedCallback() is called.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
and http/tests/loading/307-after-303-after-post.html now that the
response passed to willSendRequest is correct and now that the right
redirect URL is being printed in EFL port.

Unfortunately, http/tests/loading/redirect-methods.html cannot be
unskipped yet due to bug 66873.

  • platform/efl/test_expectations.txt:
1:20 PM Changeset in webkit [116159] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(r116134): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=85654

Unreviewed gardening, skip failing tests until proper fix.

  • platform/qt/Skipped:
1:14 PM Changeset in webkit [116158] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=84941

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/efl:

Extend Ewk_Frame_Resource_Response structure to pass resource MIME type
information.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

  • ewk/ewk_frame.h:

Tools:

Print MIME type detection messages in EFL's DumpRenderTree if
LayoutTestController's dumpResourceResponseMIMETypes() returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onResponseReceived):

LayoutTests:

  • platform/efl/Skipped: Unskip test cases which require MIME type

detection messages now that is is implemented in EFL port.

  • platform/efl/fast/preloader/script-expected.txt: Added. Use same

EFL expectation as in chromium and mac ports (MIME type is
"application/javascript" instead of "application/x-javascript").

1:13 PM Changeset in webkit [116157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Implement numberOfProcessorCores() for QNX
https://bugs.webkit.org/show_bug.cgi?id=85638

Patch by Jeff Rogers <jrogers@rim.com> on 2012-05-04
Reviewed by Antonio Gomes.

  • wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

1:12 PM Changeset in webkit [116156] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectation for test after http://trac.webkit.org/changeset/116143.

  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [116155] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

All the inspector tests are skipped on chromium-mac. We should
skip the new ones in platform/chromium as well.

  • platform/chromium/test_expectations.txt:
1:08 PM Changeset in webkit [116154] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress yet more Chromium Mac SL timeouts; hopefully close to end
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
1:07 PM Changeset in webkit [116153] by inferno@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/rendering/RenderBox.cpp

Merge 115668 - Source/WebCore: Remove positioned float code.
BUG=124919
Review URL: https://chromiumcodereview.appspot.com/10368021

1:06 PM Changeset in webkit [116152] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] CCProxy's shouldn't try to draw if there is no layer renderer
https://bugs.webkit.org/show_bug.cgi?id=85218

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-04
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

1:01 PM Changeset in webkit [116151] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test_expectations update.
Remove media/W3C/video/events/event_order_canplay_canplaythrough.html.
The crash is not happening anymore.

Patch by Shadi Khalek <shadi@chromium.org> on 2012-05-04

  • platform/chromium/test_expectations.txt:
12:58 PM Changeset in webkit [116150] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress more Chromium Mac SL timeouts ...
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:57 PM Changeset in webkit [116149] by rwlbuis@webkit.org
  • 3 edits
    35 deletes in trunk/LayoutTests

Rebaseline some SVG Snow Leopard results
https://bugs.webkit.org/show_bug.cgi?id=85637

Reviewed by Nikolas Zimmermann.

Remove batik expected pngs for Snow Leopard since the generic mac ones match.
Fix types-dom-01-b-expected.txt to expect RenderSVGEllipse.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac-snowleopard/svg/batik/filters/feTile-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegionA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/longTextOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textDecoration-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textDecoration2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLayout-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLayout2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLength-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPCDATA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPosition-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPosition2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textProperties-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textProperties2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textStyles-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/verticalText-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Removed.
12:53 PM Changeset in webkit [116148] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Layout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug builds
https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-04
Reviewed by Eric Carlson.

Trying a different approach, blocking on waitForEvent for the video element.

  • media/track/track-cues-pause-on-exit-expected.txt: Updated.
  • media/track/track-cues-pause-on-exit.html: Changed to use

waitForEvent and listen to exit events right after.

  • media/video-test.js: Updated waitForEvent to enable listening for

events on other elements as well.
(waitForEvent._eventCallback):
(waitForEvent):

12:46 PM Changeset in webkit [116147] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1084

Merge 115343
BUG=108958
Review URL: https://chromiumcodereview.appspot.com/10368019

12:45 PM Changeset in webkit [116146] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
https://bugs.webkit.org/show_bug.cgi?id=85134

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for setDefersLoading in DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setDefersLoading):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Add missing implementation setDefersLoading and goBack to GTK's
LayoutTestController so that the test case rely on these methods
can be enabled.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::goBack):
(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads.html and disable
loader/load-defer-resume-crash.html as it triggers an assertion
failure.

  • platform/gtk/test_expectations.txt:
12:44 PM Changeset in webkit [116145] by rwlbuis@webkit.org
  • 7 edits in trunk/Source

[BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from apache web server.
https://bugs.webkit.org/show_bug.cgi?id=85036

Reviewed by Antonio Gomes.

Source/WebCore:

Move getNormalizedMIMEType from WebKit into MIMETypeRegistry. This way we support uncommon mime types like image/pjpeg
and image/x-ms-bmp out of the box since we map to the more common image/jpeg and image/bmp respectively.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
(WebCore):
(WebCore::mimeTypeAssociationMap):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry):

Source/WebKit/blackberry:

Move getNormalizedMIMEType into WebCore::MIMETypeRegistry.

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):

  • Api/WebSettings.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createPlugin):
(WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
(WebCore::FrameLoaderClientBlackBerry::objectContentType):

12:38 PM Changeset in webkit [116144] by cevans@google.com
  • 3 edits in branches/chromium/1084

Merge 115763
BUG=125494
Review URL: https://chromiumcodereview.appspot.com/10377014

12:35 PM Changeset in webkit [116143] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r116009): image no longer visible on fast/block/float/float-not-removed-from-next-sibling4.html
https://bugs.webkit.org/show_bug.cgi?id=85651

Check in failing results for platform/mac/.

  • platform/mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
12:25 PM Changeset in webkit [116142] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[chromium] Revert compositor layer scrolling
https://bugs.webkit.org/show_bug.cgi?id=85644

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-05-04
Reviewed by Steve Block.

Source/WebCore:

This patch reverts the following commits because they were found to
trigger crashes. See discussion at http://code.google.com/p/chromium/issues/detail?id=124393.

[chromium] Allow scrolling non-root layers in the compositor thread
http://trac.webkit.org/changeset/114651

[chromium] Don't crash when scrolling empty layer tree
http://trac.webkit.org/changeset/114761

[chromium] Don't keep pointers to released layer tree
http://trac.webkit.org/changeset/115080

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:
  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockContentLayerDelegate::paintContents):

12:25 PM Changeset in webkit [116141] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 115398
BUG=124893
Review URL: https://chromiumcodereview.appspot.com/10368018

12:25 PM Changeset in webkit [116140] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark editing tests as slow.
https://bugs.webkit.org/show_bug.cgi?id=85649

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:15 PM Changeset in webkit [116139] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1084

Merge 115646
BUG=124895

12:10 PM Changeset in webkit [116138] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a few more tests as flaky across all macs.

Unreviewed, expectations change.

fast/loader/javascript-url-in-embed.html = TEXT PASS (Release only)
http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
media/video-poster-blocked-by-willsendrequest.html = TEXT PASS
userscripts/user-style-all-frames.html = TEXT PASS

  • platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [116137] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix path to external JS file that was not updated when the file
was moved in http://trac.webkit.org/changeset/116128/.

  • platform/chromium/inspector/styles/device-metrics-fit-window.html:
12:00 PM Changeset in webkit [116136] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark tests as flaky timeouts on chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [116135] by Martin Robinson
  • 2 edits in trunk/Source/WebKit/gtk

Fix the GTK+ debug build after the r116114.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::handleInputMethodKeyboardEvent): Update an
assertion to reflect a real method name in PlatformKeyboardEvent
and remove an unnecessary call to preventDefault() which triggered
an assertion failure higher in the call stack.

11:44 AM Changeset in webkit [116134] by Csaba Osztrogonác
  • 3 edits
    1 add in trunk/Tools

[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-05-04
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.

(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

11:42 AM Changeset in webkit [116133] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking a test added in r116127 as failing.

  • platform/gtk/test_expectations.txt:
11:38 AM Changeset in webkit [116132] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

CSP: Eval isn't blocked in about:blank subframes
https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

This patch fixes a race condition in this test. We need to wait for
the load event to ensure that the iframe has finished loading.

  • http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:
11:31 AM Changeset in webkit [116131] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove file that was deleted in http://trac.webkit.org/changeset/116085/.
For some reason, this was breaking the chromium build (probably a gyp bug
since chromium shouldn't be pulling in this file).

  • WebCore.gypi:
11:30 AM Changeset in webkit [116130] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

TiledCoreAnimationDrawingArea should handle visibility changes
https://bugs.webkit.org/show_bug.cgi?id=85645
<rdar://problem/11247192>

Reviewed by Oliver Hunt.

Replicate the visibility handling logic from DrawingAreaImpl and LayerTreeHostCAMac.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::visibilityDidChange):
(WebKit):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

11:28 AM Changeset in webkit [116129] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

fix bit packing in FillLayer on Windows
https://bugs.webkit.org/show_bug.cgi?id=85636

Reviewed by Ryosuke Niwa.

Use unsigned for all bit packed types. I manually verified that
the current uses of these member variables always assign true or false.

No new tests, adding a compile assert to verify bit packing.

  • rendering/style/FillLayer.cpp:

(SameSizeAsFillLayer): Added compile assert.
(WebCore):
(WebCore::FillLayer::FillLayer): Reorder m_sizeLength so bit packed fields are adjacent.
(WebCore::FillLayer::operator=): Ditto.

  • rendering/style/FillLayer.h:

(FillLayer): Convert bools to unsigned to match other bit packed fields.

10:57 AM Changeset in webkit [116128] by apavlov@chromium.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

Unreviewed, build fix.
Move Chromium-specific test into platform/chromium.

  • platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window-expected.txt.
  • platform/chromium/inspector/styles/device-metrics-fit-window.html: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window.html.
10:55 AM Changeset in webkit [116127] by tommyw@google.com
  • 11 edits
    2 adds in trunk

MediaStream API: Make PeerConnection00's API fully compliant with the draft
https://bugs.webkit.org/show_bug.cgi?id=85491

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebPeerConnection00HandlerClient.h:

Source/WebCore:

Mainly making the relevant API's use objects (aka Dictionaries) instead of the temporary strings,
but also making a few API's exception aware and changing the name of a flag.

Test: fast/mediastream/peerconnection-iceoptions.html

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::createMediaHints):
(WebCore::PeerConnection00::createOffer):
(WebCore):
(WebCore::PeerConnection00::createAnswer):
(WebCore::PeerConnection00::createIceOptions):
(WebCore::PeerConnection00::createDefaultIceOptions):
(WebCore::PeerConnection00::startIce):
(WebCore::PeerConnection00::addStream):
(WebCore::PeerConnection00::changeReadyState):

  • Modules/mediastream/PeerConnection00.h:

(WebCore):
(PeerConnection00):

  • Modules/mediastream/PeerConnection00.idl:
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp:

(WebCore::PeerConnection00HandlerInternal::startIce):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

LayoutTests:

  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/peerconnection-iceoptions-expected.txt: Added.
  • fast/mediastream/peerconnection-iceoptions.html: Added.
10:52 AM Changeset in webkit [116126] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Use destructuring assingment for the return values of the
port.diff_image() method call.

Rubber-stamped by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

10:47 AM Changeset in webkit [116125] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Chromium should include MenuListPopups' and MenuListOptions' within the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=85541

Patch by David Tseng <dtseng@google.com> on 2012-05-04
Reviewed by Chris Fleizach.

Covered by existing tests.
LayoutTests/accessibility/menu-list-sends-change-notification.html

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::accessibilityIsIgnored):

  • accessibility/chromium/AccessibilityObjectChromium.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

10:44 AM Changeset in webkit [116124] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635 Exception in [WebFrame loadRequest:] breaks some WebKit apps

Reviewed by Alexey Proskuryakov.

Some API clients pass in nil requests or requests with nil URLs.
In r112571 we started rewriting these URLs resulting in an exception.
Since we've supported nil requests until now, we should not try to rewrite these URLs.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null.

10:44 AM Changeset in webkit [116123] by ojan@chromium.org
  • 2 edits in trunk/Tools

Store fewer runs by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85568

Reviewed by Dirk Pranke.

This will greatly shrink the size of the json files we load,
resulting in a much faster initial load. People rarely care
about more than 100 runs. For the cases they do, they can still click
the show all runs checkbox to show 500 runs.

  • TestResultServer/model/jsonresults.py:
10:41 AM Changeset in webkit [116122] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Martin Robinson.

Remove incorrect test expectations for tests that are lately consistently
passing on all the Gtk builders but only turned out to be passing after
the Gtk port moved from using Skipped list to test_expectations.txt.
Their proper bug entries will be handled later, after all the tests are
confirmed to still pass. If any test backfires the correct test expectation
will be renewed and bug entries refreshed with latest information.

  • platform/gtk/test_expectations.txt:
10:31 AM Changeset in webkit [116121] by Nate Chapin
  • 25 edits in trunk/Source

Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
https://bugs.webkit.org/show_bug.cgi?id=85533

Reviewed by Alexey Proskuryakov.

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl):
(WebKit):
(WebKit::FrameLoaderClientImpl::finishedLoading):

  • src/FrameLoaderClientImpl.h:

(WebKit::FrameLoaderClientImpl::makeRepresentation):
(WebKit::FrameLoaderClientImpl::revertToProvisionalState):
(FrameLoaderClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl):
(WebCore):
(WebCore::FrameLoaderClientEfl::finishedLoading):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(WebCore::FrameLoaderClientEfl::makeRepresentation):
(WebCore::FrameLoaderClientEfl::revertToProvisionalState):
(FrameLoaderClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::FrameLoaderClient):
(WebKit):
(WebKit::FrameLoaderClient::finishedLoading):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(WebKit::FrameLoaderClient::makeRepresentation):
(WebKit::FrameLoaderClient::revertToProvisionalState):
(FrameLoaderClient):

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary,

as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case.

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
(WebCore):
(WebCore::FrameLoaderClientQt::finishedLoading):

  • WebCoreSupport/FrameLoaderClientQt.h:

(WebCore::FrameLoaderClientQt::makeRepresentation):
(WebCore::FrameLoaderClientQt::revertToProvisionalState):
(FrameLoaderClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::finishedLoading):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::finishedLoading):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::finishedLoading):
(WebCore::FrameLoaderClientWx::setMainDocumentError):
(WebCore::FrameLoaderClientWx::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientWx::dispatchDidFailLoading):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::finishedLoading):

10:23 AM Changeset in webkit [116120] by leviw@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed. Fixing ChangeLog conflict markers after 116009.

10:22 AM Changeset in webkit [116119] by commit-queue@webkit.org
  • 11 edits in trunk

[EFL] Frame load callbacks output is missing for redirections
https://bugs.webkit.org/show_bug.cgi?id=85173

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add a few redirection-related signals on the ewk_frame so that EFL's
DumpRenderTree can print the expected output when
LayoutTestController's dumpFrameLoadCallbacks() returns true.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchWillPerformClientRedirect):

  • ewk/ewk_frame.cpp:

(ewk_frame_redirect_provisional_load):
(ewk_frame_redirect_requested):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:

Tools:

Catch the new ewk_frame signals to print the expected output in case
of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onResponseReceived):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Update test_expectations.txt now that EFL's DumpRenderTree is
correctly printing frame load callbacks information in case of
redirections.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:19 AM Changeset in webkit [116118] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL] [DRT] Gardening some failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85605

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

  • platform/efl/fast/canvas/fillText-shadow-expected.txt: Added.
  • platform/efl/fast/dom/Window/window-lookup-precedence-expected.txt: Added.
  • platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Added.
  • platform/efl/test_expectations.txt:
10:12 AM Changeset in webkit [116117] by danw@gnome.org
  • 2 edits in trunk/Source/WebCore
[GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url())

!defersLoading() in MainResourceLoader.cpp:382

Remove a soup_session_pause_message() call that got left behind,
update the defersLoading stuff to handle this case.

https://bugs.webkit.org/show_bug.cgi?id=85159

Reviewed by Martin Robinson.

No new tests. Now passes loader/load-defer-resume-crash.html under
debug build.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):

10:05 AM Changeset in webkit [116116] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Device Metrics] With "Fit window" option on, page contents are downscaled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85510

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

Use the RenderView width rather than FrameView contents width whenever possible.
Drive-by: add protection from division-by-zero (for some weird rendering states).

Test: inspector/styles/device-metrics-fit-window.html

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):

LayoutTests:

  • inspector/styles/device-metrics-fit-window-expected.txt: Added.
  • inspector/styles/device-metrics-fit-window.html: Added.
9:57 AM Changeset in webkit [116115] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix up warning about missing GLib/Gio/GStreamer

We don't actually fall back.

Rubber-stamped by Csaba Osztrogonác.

9:49 AM Changeset in webkit [116114] by Martin Robinson
  • 11 edits
    5 adds in trunk/Source

[GTK] Rework IME handling to fix bugs and prepare for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84556

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. This change is already covered by a suite of keyboard
handling unit tests in WebKitGTK+. There are some changes in behavior,
but they are difficult to test without mocking out an entire GtkIMContext.

Add a struct, CompositionResults, which is used by PlatformKeyboardEvent
to package composition information with a keyboard event. Also add some logic
to PlatformKeyboardEvent to give the right information when it has composition
results.

  • GNUmakefile.list.am: Added new sources to the list.
  • platform/PlatformKeyboardEvent.h: Added a new CompositionResults member,

getter, and argument to the constructor.

  • platform/gtk/CompositionResults.h: Added.
  • platform/gtk/GtkInputMethodFilter.cpp: Added.
  • platform/gtk/GtkInputMethodFilter.h: Added.
  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): When
the key value is void return the VK_PROCESS keycode, which is the keycode
that web content expects with keystrokes that trigger composition events.
(WebCore::eventTypeForGdkKeyEvent): Abstract out this helper.
(WebCore::modifiersForGdkKeyEvent): Abstract out this helper.
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): When a PlatformKeyEvent
has composition results, use VK_PROCESS as the keycode for this event.
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): When this event is
transformed into a Char event, the PlatformKeyboardEvent used for DOM keypress
events, and it has composition results clear the text members. This forces the
EventHandler code to drop the keypress event. Platform events that change the
composition states do not have corresponding keypress DOM events (only keydown
and keyup events), so this is necessary to ensure web compatibility.

Source/WebKit/gtk:

Rework input method handling logic into a class called GtkInputMethodFilter.
This filter now runs before WebCore event handling, allowing the code to more
easily fake simple compositions that should be seen as keystrokes. We can also
filter keypresses that should not go to web content at all, such as key up events
related to key down events that were filtered.

Also added is a WebViewInputMethodFilter which is a concrete implementation of
GtkInputMethodFilter. This class contains logic for actually sending events to
WebCore. In WebKit2 an implementation of GtkInputMethodFilter will send events
across the IPC channel.

  • GNUmakefile.am: Add new files to the source list.
  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::inputMethodsMenuItem): Access the input method context via the filter.

  • WebCoreSupport/EditorClientGtk.cpp: Remove the tricky logic of input method

events from this class, because it's now in the GtkInputMethodFilter.
(WebKit::EditorClient::setInputMethodState): Call into the filter.
(WebKit::EditorClient::shouldBeginEditing): We no longer need to update the composition here.
This is handled by the focus in and focus out logic in the filter.
(WebKit::EditorClient::shouldEndEditing): Ditto.
(WebKit::EditorClient::respondToChangedSelection): Call into the filter now.
(WebKit::EditorClient::handleInputMethodKeyboardEvent): Added this helper which executes
any pending composition confirmation or preedit update actions as the default action of
the keydown event.
(WebKit::EditorClient::handleKeyboardEvent): Call handleInputMethodKeyboardEvent to do
any pending composition action.
(WebKit::EditorClient::handleInputMethodKeydown): Remove all the logic from this method.
Keys are filtered before they are sent to WebCore now and the actual action of input method
events happens in the keydown default action to increase compatibility with other browsers.
(WebKit::EditorClient::EditorClient): Remove context signal management.
(WebKit::EditorClient::~EditorClient): Ditto.

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient): No longer has some members that tracked IME status.

  • WebCoreSupport/WebViewInputMethodFilter.cpp: Added.
  • WebCoreSupport/WebViewInputMethodFilter.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_property): Get the context from the filter now.
(webkit_web_view_key_press_event): Just send events straight to the filter.
The filter will decide whether or not to send them to WebCore.
(webkit_web_view_key_release_event): Ditto.
(webkit_web_view_button_press_event): Use the filter to handle button press
events related to IME.
(webkit_web_view_focus_in_event): Notify the filter now.
(webkit_web_view_focus_out_event): Ditto.
(webkit_web_view_realize): The filter takes care of listening for realize now.
(webkit_web_view_init): Set the WebView widget on the filter.

  • webkit/webkitwebviewprivate.h: Change the GtkIMContext member to be a GtkInputMethodFilter member.
9:43 AM Changeset in webkit [116113] by jochen@chromium.org
  • 3 edits
    3 adds in trunk

Correctly update the outgoing referrer when navigating back from an history item created by pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=85374

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/history/history-navigations-set-referrer.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):

LayoutTests:

  • http/tests/history/history-navigations-set-referrer-expected.txt: Added.
  • http/tests/history/history-navigations-set-referrer.html: Added.
  • http/tests/history/resources/check-referrer.html: Added.
9:35 AM Changeset in webkit [116112] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Web Timing tests gardening
https://bugs.webkit.org/show_bug.cgi?id=85619

Unreviewed, EFL gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-04

  • platform/efl/test_expectations.txt:
9:32 AM Changeset in webkit [116111] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85632

Unreviewed gardening, skip the new _crashing_ test to paint the bot green.

  • platform/qt-5.0-wk1/Skipped:
9:32 AM Changeset in webkit [116110] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Clarify warning about missing GLib/Gio/GStreamer for media support

And only print it once.

Reviewed by Csaba Osztrogonác.

9:25 AM Changeset in webkit [116109] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: 350 tests started to fail with newer Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=85631

Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk1/Skipped:
9:17 AM Changeset in webkit [116108] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed fix after r116106.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
9:09 AM Changeset in webkit [116107] by vestbo@webkit.org
  • 6 edits
    1 add in trunk

[Qt] Clean up and split features.prf into a static list of defaults

The static list of feature defaults is used as a fallback for any
feature that's not dynamically detected or overriden on the command
line (though build-webkit or passing DEFINES+= to qmake).

The static list is complete, which allows for auto-generation based
on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)

https://bugs.webkit.org/show_bug.cgi?id=85611

Reviewed by Simon Hausmann.

8:43 AM Changeset in webkit [116106] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk2/Skipped:
8:27 AM Changeset in webkit [116105] by zoltan@webkit.org
  • 13 edits
    1 add in trunk

Unreviewed, rolling out r116085, r116091, and r116095.
http://trac.webkit.org/changeset/116085
http://trac.webkit.org/changeset/116091
http://trac.webkit.org/changeset/116095
https://bugs.webkit.org/show_bug.cgi?id=85628

We are not ready with dependencies on all platform yet (mac) +
problems with debug builds. (Requested by Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-04

Source/WebCore:

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):
(WebCore):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::clearPointers):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Added.

(WebCore):
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::setPixmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

  • qmake/mkspecs/features/features.prf:
8:24 AM Changeset in webkit [116104] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: eliminate temporaryProfile property from ProfilesPanel.
https://bugs.webkit.org/show_bug.cgi?id=85623

We can run different profilers at the same time therefore we have to keep temorary profile per profiler type.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.createView):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createView):
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.ProfileType.prototype.createTemporaryProfile):
(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfileHeader):
(WebInspector.HeapProfileHeader):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

8:14 AM Changeset in webkit [116103] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [chromium] ScriptGCEvent should not be static.
https://bugs.webkit.org/show_bug.cgi?id=80788

The static members of ScriptGCEvent were moved into per isolate data structure.
Drive by fix: Sometimes the used heap size after a GC is slightly more than it was before.

Reviewed by Yury Semikhatsky.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/V8Binding.h:

(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(GCEventData):
(WebCore):
(WebCore::V8BindingPerIsolateData::gcEventData):
(V8BindingPerIsolateData):

7:52 AM Changeset in webkit [116102] by Csaba Osztrogonác
  • 8 edits
    1 copy in trunk/Source

[Qt] Update Qt bridge after changes to QMetaMethod
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Kent Hansen <kent.hansen@nokia.com> on 2012-05-04
Reviewed by Tor Arne Vestbø.

QMetaMethod::signature() has been renamed to methodSignature() and
returns a QByteArray.

The new function QMetaMethod::name() gives direct access to a
method's name. returnType(), parameterCount(), and parameterType()
give direct access to type information.

Ported the custom QtConnectionObject meta-object to revision 7;
revision 6 and below aren't supported (and don't compile) with Qt5.

Source/WebCore:

  • Target.pri:
  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getPropertyNames):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::findMethodIndex):
(Bindings):
(qt_meta_stringdata_QtConnectionObject_t):
(JSC::Bindings::QtConnectionObject::qt_static_metacall):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::QtConnectionObject::execute):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

  • bridge/qt/qt_runtime_qt4.cpp: Copied from Source/WebCore/bridge/qt/qt_runtime.cpp.

(Bindings):
(QWKNoDebug):
(JSC::Bindings::QWKNoDebug::QWKNoDebug):
(JSC::Bindings::QWKNoDebug::~QWKNoDebug):
(JSC::Bindings::QWKNoDebug::operator<<):
(JSC::Bindings::operator<<):
(RuntimeConversion):
(JSC::Bindings::registerCustomType):
(JSC::Bindings::isJSUint8ClampedArray):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariantMap):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::destroy):
(JSC::Bindings::QtRuntimeMethodData::~QtRuntimeMethodData):
(JSC::Bindings::QtRuntimeMethodData::finalize):
(JSC::Bindings::QtRuntimeMetaMethodData::~QtRuntimeMetaMethodData):
(JSC::Bindings::QtRuntimeConnectionMethodData::~QtRuntimeConnectionMethodData):
(QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::kind):
(JSC::Bindings::QtMethodMatchType::isValid):
(JSC::Bindings::QtMethodMatchType::isVariant):
(JSC::Bindings::QtMethodMatchType::isMetaType):
(JSC::Bindings::QtMethodMatchType::isUnresolved):
(JSC::Bindings::QtMethodMatchType::isMetaEnum):
(JSC::Bindings::QtMethodMatchType::enumeratorIndex):
(JSC::Bindings::QtMethodMatchType::variant):
(JSC::Bindings::QtMethodMatchType::metaType):
(JSC::Bindings::QtMethodMatchType::metaEnum):
(JSC::Bindings::QtMethodMatchType::unresolved):
(JSC::Bindings::QtMethodMatchType::typeId):
(JSC::Bindings::QtMethodMatchType::name):
(QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::isValid):
(JSC::Bindings::QtMethodMatchData::firstUnresolvedIndex):
(JSC::Bindings::indexOfMetaEnum):
(JSC::Bindings::findMethodIndex):
(JSC::Bindings::findSignalIndex):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeMetaMethod::getCallData):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallData):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::metaObject):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::isJavaScriptFunction):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
(JSC::Bindings::::QtArray):
(JSC::Bindings::::~QtArray):
(JSC::Bindings::::rootObject):
(JSC::Bindings::::setValueAt):
(JSC::Bindings::::valueAt):

Source/WebKit2:

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

(gatherAPI):

7:50 AM Changeset in webkit [116101] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't pass viewport-create function to quick_test_main.
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-04
Reviewed by Csaba Osztrogonác.

  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

7:49 AM Changeset in webkit [116100] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85478

Reviewed by Tor Arne Vestbø.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

  • UIProcess/API/qt/qwebiconimageprovider_p.h:
7:36 AM Changeset in webkit [116099] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: use single method for retrieving evaluation context in the runtime agent
https://bugs.webkit.org/show_bug.cgi?id=85621

Reviewed by Pavel Feldman.

Merged two script state retrieval methods into one. Moved Page specific logic
into PageRuntimeAgent.

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::scriptStateForEval):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::scriptStateForEval):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

7:33 AM Changeset in webkit [116098] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r115549.
http://trac.webkit.org/changeset/115549
https://bugs.webkit.org/show_bug.cgi?id=83894

The newly added CRASH() statements are triggered too often

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

7:32 AM Changeset in webkit [116097] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
https://bugs.webkit.org/show_bug.cgi?id=85171

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add a helper function to DumpRenderTreeSupportEfl to override the
"WebKitLoadSiteIconsKey" setting on the view page.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement support for overriding "WebKitLoadSiteIconsKey" setting in
EFL's LayoutTestController.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

Unskip http/tests/misc/favicon-loads-with-icon-loading-override.html
now that EFL's LayoutTestController support overriding
WebKitLoadSiteIconsKey.

  • platform/efl/Skipped:
7:29 AM Changeset in webkit [116096] by commit-queue@webkit.org
  • 16 edits
    13 adds in trunk/LayoutTests

[EFL][DRT] Gardening away remaining SVG failures
https://bugs.webkit.org/show_bug.cgi?id=85600

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-04

  • platform/efl/svg/batik/filters/feTile-expected.png: Added.
  • platform/efl/svg/batik/filters/feTile-expected.txt:
  • platform/efl/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/efl/svg/batik/filters/filterRegions-expected.txt:
  • platform/efl/svg/carto.net/button-expected.txt:
  • platform/efl/svg/carto.net/colourpicker-expected.txt:
  • platform/efl/svg/carto.net/slider-expected.txt:
  • platform/efl/svg/carto.net/window-expected.txt:
  • platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-expected.png: Added.
  • platform/efl/svg/hixie/error/014-expected.txt:
  • platform/efl/svg/hixie/perf/003-expected.png: Added.
  • platform/efl/svg/hixie/perf/003-expected.txt:
  • platform/efl/svg/hixie/shapes/path/001-expected.png: Added.
  • platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-expected.png: Added.
  • platform/efl/svg/hixie/use/002-expected.txt:
  • platform/efl/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/efl/svg/repaint/filter-child-repaint-expected.txt:
  • platform/efl/svg/repaint/filter-repaint-expected.png: Added.
  • platform/efl/svg/repaint/filter-repaint-expected.txt:
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/efl/test_expectations.txt:
7:24 AM Changeset in webkit [116095] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Error message fix after r116091
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Alexis Menard.

No new tests : error message fix.

  • WebCore.pri:
7:16 AM Changeset in webkit [116094] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, removing incorrect test expectations for tests that turned
to be passing on all the Gtk builders after moving from using Skipped
to test_expectations.txt and have the generic BUGWKGTK modifier.

  • platform/gtk/test_expectations.txt:
7:01 AM Changeset in webkit [116093] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, refined specifiers for unexpectedly passing tests.

  • platform/chromium/test_expectations.txt:
7:00 AM BuildingQtOnLinux edited by zoltan@webkit.org
(diff)
6:57 AM Changeset in webkit [116092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Gavin Barraclough.

  • bytecode/Operands.h:
6:50 AM Changeset in webkit [116091] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix when using libpng version > 1.2.
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Tor Arne Vestbø.

Don't enforce the version of libpng when passing the option to the linker.

No new tests : build fix.

  • WebCore.pri:
6:36 AM Changeset in webkit [116090] by rakuco@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

[EFL] Unreviewed, fix r116067 and r116068.

Fix the names of the expectations I added in those revisions.

  • platform/efl/fast/html/details-marker-style-expected.txt: Renamed from LayoutTests/platform/efl/fast/html/details-marker-style-actual.txt.
  • platform/efl/media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-actual.txt.
  • platform/efl/svg/as-image/image-respects-pageScaleFactor-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-image/image-respects-pageScaleFactor-actual.txt.
6:32 AM Changeset in webkit [116089] by alexis.menard@openbossa.org
  • 13 edits in trunk

[Qt] Enable fullscreen API for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85498

Reviewed by Simon Hausmann.

Source/WebKit2:

Enable the fullscreen API for Qt port. It is only
supported on WebKit2. It adds experimental settings
to enable it and also add two experimental signals so
the API user can react when the fullscreen is requested
(e.g hide the urlbar of a browser and change the state
of the window to be fullscreen).

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::fullScreenEnabled):
(QWebPreferences::setFullScreenEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

Tools:

Enable the fullscreen API on the MiniBrowser and turn
it default on WebKit2, disable it on WK1.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.prf:
6:16 AM Changeset in webkit [116088] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r116008) old-run-webkit-tests broken
https://bugs.webkit.org/show_bug.cgi?id=85597

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Simon Hausmann.

Reinstate libraryContainsSymbol.

  • Scripts/webkitperl/features.pm:

(libraryContainsSymbol):

5:53 AM Changeset in webkit [116087] by Simon Hausmann
  • 4 edits in trunk/Source

[Qt] Images are scaled badly in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=85610

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Enable smooth pixmap transforms when rendering into the GraphicsSurface image.
This class is only used in WK2.

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

Enable smooth pixmap transforms for WK2 bitmaps.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

5:19 AM Changeset in webkit [116086] by zoltan@webkit.org
  • 9 edits in trunk/Source/WebCore

[Qt] Remove unnecessary executeable bits after r116085

No new tests.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:
  • platform/graphics/qt/ImageDecoderQt.cpp:
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
5:10 AM Changeset in webkit [116085] by zoltan@webkit.org
  • 14 edits
    1 delete in trunk

[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Source/WebCore:

This change modifies the default ImageDecoder for Qt-port from QImageDecoder to WebCore ImageDecoder.
The new behavior is to use QImageDecoder only if WebCoreImageDecoder doesn't support the requested
image type.
The WTF_USE_QT_IMAGE_DECODER macro has been removed, since it is no longer needed.

This change adds build depedency for libpng-dev and libjpeg-dev packages, becuase PNG and JPEG imagedecoders
need not only these libraries, but their headers also. Qmake-config tests for these libraries were
introduced in r110045.

Reviewed by Simon Hausmann.

No new tests needed.

  • Target.pri: Move WebCore ImageDecoder files out of guards. Remove ImageFrameQt.cpp from sources.
  • WebCore.pri: Move WebCore ImageDecoder include paths out of guards.
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Add WebCore supported and Qt supported MIME types.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Use Qt supported MIME types.

  • platform/graphics/ImageSource.cpp: Remove unnecessary includes.
  • platform/graphics/ImageSource.h: Remove unnecessary typedefs.

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::filenameExtension): Remove unnecessary semicolon.
(WebCore::ImageDecoderQt::internalHandleCurrentImage): Use QImage and ImageFrame instead of QPixmap.
(WebCore):
(WebCore::ImageFrame::asNewNativeImage): Moved here from removed ImageFrameQt.cpp.

  • platform/image-decoders/ImageDecoder.cpp: Reorganize the includes of the header.

(WebCore::ImageDecoder::create): Add platform macro guarded fallback case for QImageDecoder.

  • platform/image-decoders/ImageDecoder.h: Remove Qt-specific codes.

(WebCore::ImageFrame::getAddr): Remove Qt-specific case, since it is no longer needed.
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Removed. Dead code, other code has been moved to

ImageDecoderQt.cpp.

Source/WebKit/blackberry:

Get rid off QT_IMAGE_DECODER flag.

Reviewed by Simon Hausmann.

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

Remove WTF_USE_QT_IMAGE_DECODER macro.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
5:00 AM Changeset in webkit [116084] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, eval-blocked-in-about-blank-iframe.html: SLOW -> TIMEOUT

  • platform/chromium/test_expectations.txt:
3:59 AM Changeset in webkit [116083] by Csaba Osztrogonác
  • 6 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt/Skipped: Typo fix.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-device-orientation-expected.txt:
3:46 AM Changeset in webkit [116082] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
3:37 AM Changeset in webkit [116081] by noel.gordon@gmail.com
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed test expectations update after r116074

  • platform/chromium-mac/fast/images/png-suite/test-expected.png: Added.
  • platform/chromium-win/fast/images/png-suite/test-expected.png: Added.
  • platform/chromium/fast/images/png-suite/test-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:21 AM Changeset in webkit [116080] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, changed expectations for fast/images/png-suite/test.html from IMAGE to MISSING.

  • platform/chromium/test_expectations.txt:
3:08 AM Changeset in webkit [116079] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html as slow.

  • platform/chromium/test_expectations.txt:
2:39 AM Changeset in webkit [116078] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed, rolling out r116075.
http://trac.webkit.org/changeset/116075

WebKit2 build was broken while WebKit2 build was disabled in bots,
so nobody noticed it. Disable the WebKit2 build for now to keep
the bots green again until we find the actual commit that
broke the WebKit2 build.

  • configure.ac:
2:10 AM Changeset in webkit [116077] by loislo@chromium.org
  • 6 edits in trunk

Web Inspector: createRawLocationByURL is too slow if a big number of evals happen.
https://bugs.webkit.org/show_bug.cgi?id=85477

It iterates through all the _scripts even they have no url.
We can keep a separate map of scripts with url.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._resetScriptsMap):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/raw-source-code.html:
2:07 AM Changeset in webkit [116076] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] [DRT] fast/table/quote-text-around-iframe.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85487

Unreviewed, EFL rebaseline after r115218.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

  • platform/efl/fast/table/quote-text-around-iframe-expected.png:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
1:20 AM Changeset in webkit [116075] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Enable WebKit2 by default in configure.

This was removed in r115624 to make sure release 1.9.1 didn't have
WebKit2 enabled by default, because we are using the same library
versions for WebKit1 and WebKit2.

  • configure.ac: Enable WebKit2 by default.
12:25 AM Changeset in webkit [116074] by noel.gordon@gmail.com
  • 6 edits
    180 adds in trunk/LayoutTests

Add PNG image pngsuite test
https://bugs.webkit.org/show_bug.cgi?id=85567

Reviewed by Eric Seidel.

From http://www.schaik.com/pngsuite, add images from this suite and license
details. Add a layout test. Add platform exceptions (since all ports have a
different broken image).

  • fast/images/png-suite/PngSuite.LICENSE: Added.
  • fast/images/png-suite/samples/basi0g01.png: Added.
  • fast/images/png-suite/samples/basi0g02.png: Added.
  • fast/images/png-suite/samples/basi0g04.png: Added.
  • fast/images/png-suite/samples/basi0g08.png: Added.
  • fast/images/png-suite/samples/basi0g16.png: Added.
  • fast/images/png-suite/samples/basi2c08.png: Added.
  • fast/images/png-suite/samples/basi2c16.png: Added.
  • fast/images/png-suite/samples/basi3p01.png: Added.
  • fast/images/png-suite/samples/basi3p02.png: Added.
  • fast/images/png-suite/samples/basi3p04.png: Added.
  • fast/images/png-suite/samples/basi3p08.png: Added.
  • fast/images/png-suite/samples/basi4a08.png: Added.
  • fast/images/png-suite/samples/basi4a16.png: Added.
  • fast/images/png-suite/samples/basi6a08.png: Added.
  • fast/images/png-suite/samples/basi6a16.png: Added.
  • fast/images/png-suite/samples/basn0g01.png: Added.
  • fast/images/png-suite/samples/basn0g02.png: Added.
  • fast/images/png-suite/samples/basn0g04.png: Added.
  • fast/images/png-suite/samples/basn0g08.png: Added.
  • fast/images/png-suite/samples/basn0g16.png: Added.
  • fast/images/png-suite/samples/basn2c08.png: Added.
  • fast/images/png-suite/samples/basn2c16.png: Added.
  • fast/images/png-suite/samples/basn3p01.png: Added.
  • fast/images/png-suite/samples/basn3p02.png: Added.
  • fast/images/png-suite/samples/basn3p04.png: Added.
  • fast/images/png-suite/samples/basn3p08.png: Added.
  • fast/images/png-suite/samples/basn4a08.png: Added.
  • fast/images/png-suite/samples/basn4a16.png: Added.
  • fast/images/png-suite/samples/basn6a08.png: Added.
  • fast/images/png-suite/samples/basn6a16.png: Added.
  • fast/images/png-suite/samples/bgai4a08.png: Added.
  • fast/images/png-suite/samples/bgai4a16.png: Added.
  • fast/images/png-suite/samples/bgan6a08.png: Added.
  • fast/images/png-suite/samples/bgan6a16.png: Added.
  • fast/images/png-suite/samples/bgbn4a08.png: Added.
  • fast/images/png-suite/samples/bggn4a16.png: Added.
  • fast/images/png-suite/samples/bgwn6a08.png: Added.
  • fast/images/png-suite/samples/bgyn6a16.png: Added.
  • fast/images/png-suite/samples/ccwn2c08.png: Added.
  • fast/images/png-suite/samples/ccwn3p08.png: Added.
  • fast/images/png-suite/samples/cdfn2c08.png: Added.
  • fast/images/png-suite/samples/cdhn2c08.png: Added.
  • fast/images/png-suite/samples/cdsn2c08.png: Added.
  • fast/images/png-suite/samples/cdun2c08.png: Added.
  • fast/images/png-suite/samples/ch1n3p04.png: Added.
  • fast/images/png-suite/samples/ch2n3p08.png: Added.
  • fast/images/png-suite/samples/cm0n0g04.png: Added.
  • fast/images/png-suite/samples/cm7n0g04.png: Added.
  • fast/images/png-suite/samples/cm9n0g04.png: Added.
  • fast/images/png-suite/samples/cs3n2c16.png: Added.
  • fast/images/png-suite/samples/cs3n3p08.png: Added.
  • fast/images/png-suite/samples/cs5n2c08.png: Added.
  • fast/images/png-suite/samples/cs5n3p08.png: Added.
  • fast/images/png-suite/samples/cs8n2c08.png: Added.
  • fast/images/png-suite/samples/cs8n3p08.png: Added.
  • fast/images/png-suite/samples/ct0n0g04.png: Added.
  • fast/images/png-suite/samples/ct1n0g04.png: Added.
  • fast/images/png-suite/samples/cten0g04.png: Added.
  • fast/images/png-suite/samples/ctfn0g04.png: Added.
  • fast/images/png-suite/samples/ctgn0g04.png: Added.
  • fast/images/png-suite/samples/cthn0g04.png: Added.
  • fast/images/png-suite/samples/ctjn0g04.png: Added.
  • fast/images/png-suite/samples/ctzn0g04.png: Added.
  • fast/images/png-suite/samples/f00n0g08.png: Added.
  • fast/images/png-suite/samples/f00n2c08.png: Added.
  • fast/images/png-suite/samples/f01n0g08.png: Added.
  • fast/images/png-suite/samples/f01n2c08.png: Added.
  • fast/images/png-suite/samples/f02n0g08.png: Added.
  • fast/images/png-suite/samples/f02n2c08.png: Added.
  • fast/images/png-suite/samples/f03n0g08.png: Added.
  • fast/images/png-suite/samples/f03n2c08.png: Added.
  • fast/images/png-suite/samples/f04n0g08.png: Added.
  • fast/images/png-suite/samples/f04n2c08.png: Added.
  • fast/images/png-suite/samples/f99n0g04.png: Added.
  • fast/images/png-suite/samples/g03n0g16.png: Added.
  • fast/images/png-suite/samples/g03n2c08.png: Added.
  • fast/images/png-suite/samples/g03n3p04.png: Added.
  • fast/images/png-suite/samples/g04n0g16.png: Added.
  • fast/images/png-suite/samples/g04n2c08.png: Added.
  • fast/images/png-suite/samples/g04n3p04.png: Added.
  • fast/images/png-suite/samples/g05n0g16.png: Added.
  • fast/images/png-suite/samples/g05n2c08.png: Added.
  • fast/images/png-suite/samples/g05n3p04.png: Added.
  • fast/images/png-suite/samples/g07n0g16.png: Added.
  • fast/images/png-suite/samples/g07n2c08.png: Added.
  • fast/images/png-suite/samples/g07n3p04.png: Added.
  • fast/images/png-suite/samples/g10n0g16.png: Added.
  • fast/images/png-suite/samples/g10n2c08.png: Added.
  • fast/images/png-suite/samples/g10n3p04.png: Added.
  • fast/images/png-suite/samples/g25n0g16.png: Added.
  • fast/images/png-suite/samples/g25n2c08.png: Added.
  • fast/images/png-suite/samples/g25n3p04.png: Added.
  • fast/images/png-suite/samples/oi1n0g16.png: Added.
  • fast/images/png-suite/samples/oi1n2c16.png: Added.
  • fast/images/png-suite/samples/oi2n0g16.png: Added.
  • fast/images/png-suite/samples/oi2n2c16.png: Added.
  • fast/images/png-suite/samples/oi4n0g16.png: Added.
  • fast/images/png-suite/samples/oi4n2c16.png: Added.
  • fast/images/png-suite/samples/oi9n0g16.png: Added.
  • fast/images/png-suite/samples/oi9n2c16.png: Added.
  • fast/images/png-suite/samples/pp0n2c16.png: Added.
  • fast/images/png-suite/samples/pp0n6a08.png: Added.
  • fast/images/png-suite/samples/ps1n0g08.png: Added.
  • fast/images/png-suite/samples/ps1n2c16.png: Added.
  • fast/images/png-suite/samples/ps2n0g08.png: Added.
  • fast/images/png-suite/samples/ps2n2c16.png: Added.
  • fast/images/png-suite/samples/s01i3p01.png: Added.
  • fast/images/png-suite/samples/s01n3p01.png: Added.
  • fast/images/png-suite/samples/s02i3p01.png: Added.
  • fast/images/png-suite/samples/s02n3p01.png: Added.
  • fast/images/png-suite/samples/s03i3p01.png: Added.
  • fast/images/png-suite/samples/s03n3p01.png: Added.
  • fast/images/png-suite/samples/s04i3p01.png: Added.
  • fast/images/png-suite/samples/s04n3p01.png: Added.
  • fast/images/png-suite/samples/s05i3p02.png: Added.
  • fast/images/png-suite/samples/s05n3p02.png: Added.
  • fast/images/png-suite/samples/s06i3p02.png: Added.
  • fast/images/png-suite/samples/s06n3p02.png: Added.
  • fast/images/png-suite/samples/s07i3p02.png: Added.
  • fast/images/png-suite/samples/s07n3p02.png: Added.
  • fast/images/png-suite/samples/s08i3p02.png: Added.
  • fast/images/png-suite/samples/s08n3p02.png: Added.
  • fast/images/png-suite/samples/s09i3p02.png: Added.
  • fast/images/png-suite/samples/s09n3p02.png: Added.
  • fast/images/png-suite/samples/s32i3p04.png: Added.
  • fast/images/png-suite/samples/s32n3p04.png: Added.
  • fast/images/png-suite/samples/s33i3p04.png: Added.
  • fast/images/png-suite/samples/s33n3p04.png: Added.
  • fast/images/png-suite/samples/s34i3p04.png: Added.
  • fast/images/png-suite/samples/s34n3p04.png: Added.
  • fast/images/png-suite/samples/s35i3p04.png: Added.
  • fast/images/png-suite/samples/s35n3p04.png: Added.
  • fast/images/png-suite/samples/s36i3p04.png: Added.
  • fast/images/png-suite/samples/s36n3p04.png: Added.
  • fast/images/png-suite/samples/s37i3p04.png: Added.
  • fast/images/png-suite/samples/s37n3p04.png: Added.
  • fast/images/png-suite/samples/s38i3p04.png: Added.
  • fast/images/png-suite/samples/s38n3p04.png: Added.
  • fast/images/png-suite/samples/s39i3p04.png: Added.
  • fast/images/png-suite/samples/s39n3p04.png: Added.
  • fast/images/png-suite/samples/s40i3p04.png: Added.
  • fast/images/png-suite/samples/s40n3p04.png: Added.
  • fast/images/png-suite/samples/tbbn0g04.png: Added.
  • fast/images/png-suite/samples/tbbn2c16.png: Added.
  • fast/images/png-suite/samples/tbbn3p08.png: Added.
  • fast/images/png-suite/samples/tbgn2c16.png: Added.
  • fast/images/png-suite/samples/tbgn3p08.png: Added.
  • fast/images/png-suite/samples/tbrn2c08.png: Added.
  • fast/images/png-suite/samples/tbwn0g16.png: Added.
  • fast/images/png-suite/samples/tbwn3p08.png: Added.
  • fast/images/png-suite/samples/tbyn3p08.png: Added.
  • fast/images/png-suite/samples/tp0n0g08.png: Added.
  • fast/images/png-suite/samples/tp0n2c08.png: Added.
  • fast/images/png-suite/samples/tp0n3p08.png: Added.
  • fast/images/png-suite/samples/tp1n3p08.png: Added.
  • fast/images/png-suite/samples/xc1n0g08.png: Added.
  • fast/images/png-suite/samples/xc9n2c08.png: Added.
  • fast/images/png-suite/samples/xcrn0g04.png: Added.
  • fast/images/png-suite/samples/xcsn0g01.png: Added.
  • fast/images/png-suite/samples/xd0n2c08.png: Added.
  • fast/images/png-suite/samples/xd3n2c08.png: Added.
  • fast/images/png-suite/samples/xd9n2c08.png: Added.
  • fast/images/png-suite/samples/xdtn0g01.png: Added.
  • fast/images/png-suite/samples/xhdn0g08.png: Added.
  • fast/images/png-suite/samples/xlfn0g04.png: Added.
  • fast/images/png-suite/samples/xs1n0g01.png: Added.
  • fast/images/png-suite/samples/xs2n0g01.png: Added.
  • fast/images/png-suite/samples/xs4n0g01.png: Added.
  • fast/images/png-suite/samples/xs7n0g01.png: Added.
  • fast/images/png-suite/samples/z00n2c08.png: Added.
  • fast/images/png-suite/samples/z03n2c08.png: Added.
  • fast/images/png-suite/samples/z06n2c08.png: Added.
  • fast/images/png-suite/samples/z09n2c08.png: Added.
  • fast/images/png-suite/test-expected.png: Added.
  • fast/images/png-suite/test.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/images/png-suite/test-expected.png: Added.
  • platform/qt/test_expectations.txt:
  • platform/wincairo/Skipped:
Note: See TracTimeline for information about the timeline view.