Context Navigation

← Previous Period
Next Period →

Timeline

May 6, 2012:

11:52 PM Changeset in webkit [116279] by hayato@chromium.org

2 edits in trunk/Tools

[prepare-ChangeLog] Excludes a reference file used by reftests from test files.
https://bugs.webkit.org/show_bug.cgi?id=74268

Reviewed by Ryosuke Niwa.

Scripts/prepare-ChangeLog:

(generateFileList):

11:45 PM Changeset in webkit [116278] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] New test introduced in r116255 is failing
https://bugs.webkit.org/show_bug.cgi?id=85777

Unreviewed gardening.

platform/qt/Skipped: Skip the failing test

11:36 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

Update target version after 1.9.2 (diff)

11:05 PM Changeset in webkit [116277] by morrita@google.com

48 edits
2 moves in trunk

https://bugs.webkit.org/show_bug.cgi?id=85265
[Shadow DOM] ShadowTree needs a better name

Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter: Updated exported symbol names according to the rename.

Source/WebCore:

Renamed ShadowTree to ElementShadow, The ElementShadow class is
going to be a facade of Shadow related APIs.

Following renames follow:

Element::shadowTree() to Element::shadow()
ShadowRoot::tree() to ShadowRoot::owner()
ShadowTree::recalcShadowTreeStyle() to ElementShadow::recalcStyle()

No new tests. Just renames.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/ComposedShadowTreeWalker.cpp:

(WebCore::shadowFor):
(WebCore::shadowOfParent):
(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):

dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):

dom/DOMAllInOne.cpp:
dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::willRemove):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::hasShadowRoot):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):

dom/Element.h:

(WebCore):
(Element):

dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):

dom/ElementShadow.cpp: Renamed from Source/WebCore/dom/ShadowTree.cpp.

(WebCore):
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::~ElementShadow):
(WebCore::validateShadowRoot):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::willRemove):
(WebCore::ElementShadow::setParentTreeScope):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::attachHost):
(WebCore::ElementShadow::detach):
(WebCore::ElementShadow::detachHost):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::selectionFor):
(WebCore::ElementShadow::reattach):
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::reattachHostChildrenAndShadow):

dom/ElementShadow.h: Renamed from Source/WebCore/dom/ShadowTree.h.

(WebCore):
(ElementShadow):
(WebCore::ElementShadow::hasShadowRoot):
(WebCore::ElementShadow::youngestShadowRoot):
(WebCore::ElementShadow::oldestShadowRoot):
(WebCore::ElementShadow::selector):
(WebCore::ElementShadow::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::host):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):

dom/Node.cpp:

(WebCore::oldestShadowRootFor):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):

dom/NodeRenderingContext.h:

(WebCore):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::owner):

dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

dom/TreeScopeAdopter.cpp:

(WebCore::shadowFor):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveShadowToNewDocument):

dom/TreeScopeAdopter.h:

(TreeScopeAdopter):

html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::shadowColorSwatch):

html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::findMainSummary):

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):

html/HTMLSummaryElement.cpp:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

html/ValidationMessage.cpp:

(WebCore::ValidationMessage::deleteBubbleTree):

html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):

html/shadow/InsertionPoint.h:
html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::getDecorationRootAndDecoratedRoot):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):

page/FocusController.cpp:

(WebCore::FocusScope::focusScopeOf):
(WebCore::FocusScope::focusScopeOwnedByShadowHost):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildShadowTree):

testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
(WebCore::Internals::removeShadowRoot):

Source/WebKit2:

win/WebKit2.def: Updated exported symbol names according to the rename.
win/WebKit2CFLite.def: Updated exported symbol names according to the rename.

11:02 PM Changeset in webkit [116276] by caseq@chromium.org

27 edits
6 deletes in trunk

Unreviewed, rolling out r116235.
http://trac.webkit.org/changeset/116235
https://bugs.webkit.org/show_bug.cgi?id=85773

broke a lot of tests on all chromium debug bots (Requested by
caseq_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-06

Source/WebCore:

bindings/objc/DOMCSS.mm:
css/CSSFontFaceRule.cpp:
css/CSSFontFaceRule.h:

(CSSFontFaceRule):

css/CSSImportRule.cpp:
css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):

css/CSSMediaRule.h:

(CSSMediaRule):

css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

css/CSSPageRule.h:

(CSSPageRule):

css/CSSRule.cpp:
css/CSSRule.h:

(CSSRule):
(WebCore::CSSRule::parserContext):

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

css/CSSStyleRule.h:
css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasCharsetRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(CSSStyleSheet):

css/MediaList.cpp:

(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::notifyChanged):

css/MediaList.h:

(MediaList):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):

css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):
(StyleRuleCSSStyleDeclaration):

css/StylePropertySet.cpp:
css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):

css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

css/WebKitCSSRegionRule.cpp:
css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

http/tests/css/resources/shared-stylesheet-mutation.js: Removed.
http/tests/css/resources/shared.css: Removed.
http/tests/css/shared-stylesheet-mutation-expected.txt: Removed.
http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Removed.
http/tests/css/shared-stylesheet-mutation-preconstruct.html: Removed.
http/tests/css/shared-stylesheet-mutation.html: Removed.

10:54 PM Changeset in webkit [116275] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Attempt to fix the !ENABLE(INSPECTOR) build by making InspectorValues
available unconditionally. We should probably rename these classes to
JSONValues and move them into WebCore/platform.

inspector/InspectorValues.cpp:
inspector/InspectorValues.h:

10:38 PM Changeset in webkit [116274] by abarth@webkit.org

8 edits
4 adds in trunk

CSP violation reports should have all the fields required by the spec
https://bugs.webkit.org/show_bug.cgi?id=85682

Reviewed by Darin Adler.

Source/WebCore:

This patch updates our CSP violation reports to include all the fields
in the spec. We've discussed all these fields in the working group,
and we have fairly high confidence that these are safe to expose.

Tests: http/tests/security/contentSecurityPolicy/report-and-enforce.html

http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-only-from-header.html
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri.html

page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

LayoutTests:

Update test results to show the new fields in the violation reports.
This patch also adds tests that exercise both the same-origin and the
cross-origin case for blocked-uri.

http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html: Added.
http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-blocked-uri.html: Added.
http/tests/security/contentSecurityPolicy/report-only-expected.txt:
http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:

10:33 PM Changeset in webkit [116273] by kinuko@chromium.org

11 edits in trunk/Source

Cleanup: FileSystem API's Entry.toURL() impl should return KURL instead of String
https://bugs.webkit.org/show_bug.cgi?id=85736

Change the return type of Entry::toURL() from String to KURL.

Reviewed by David Levin.

No new tests as this change should not have any visible impact in the javascript layer.

Source/WebCore:

Modules/filesystem/EntryBase.cpp:

(WebCore::EntryBase::toURL):

Modules/filesystem/EntryBase.h:
platform/AsyncFileSystem.h:
platform/blackberry/AsyncFileSystemBlackberry.cpp:

(AsyncFileSystemBlackberry::toURL):

platform/blackberry/AsyncFileSystemBlackberry.h:
platform/gtk/AsyncFileSystemGtk.cpp:

(AsyncFileSystemGtk::toURL):

platform/gtk/AsyncFileSystemGtk.h:

Souce/We/chromium:

src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::toURL):
String to KURL.

src/AsyncFileSystemChromium.h:

(AsyncFileSystemChromium):

10:24 PM Changeset in webkit [116272] by caseq@chromium.org

2 edits in trunk/LayoutTests

Unreviewed expectations update for overflow-positioning.html.

platform/chromium/test_expectations.txt:

10:05 PM Changeset in webkit [116271] by hbono@chromium.org

3 edits
4 copies in branches/chromium/1084

Merge 114095 - Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.

Since CachedImage has already similar code, we moved it to IntSize and shared it.

Tests: fast/css/zoom-background-repeat-x-expected.html

fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

platform/graphics/IntSize.h:

(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

LayoutTests:

fast/css/zoom-background-repeat-x-expected.html: Added.
fast/css/zoom-background-repeat-x.html: Added.
fast/css/zoom-background-repeat-y-expected.html: Added.
fast/css/zoom-background-repeat-y.html: Added.

TBR=shinyak@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10379031

9:41 PM Changeset in webkit [116270] by pilgrim@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Call currentThread through Platform.h directly
https://bugs.webkit.org/show_bug.cgi?id=85769

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):

9:39 PM Changeset in webkit [116269] by haraken@chromium.org

16 edits in trunk/Source/WebCore

[V8][Performance] Remove Isolate lookup from the call path
to get a cached JS wrapper object by getDOMXXXXMap().
https://bugs.webkit.org/show_bug.cgi?id=85205

Reviewed by Adam Barth.

The patch improves the performance of getting a cached JS wrapper
by getDOMXXXXMap(). For example, it improves the performance
of toV8(NodeList*) in getElementsByTagName(), getElementsByName(),
getElementsByClassName() by 7 ~ 9%.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=139468

The performance test results in my Linux desktop:

getElementsByTagName : 40.76 ms => 37.52ms (+8.6%)
getElementsByName : 41.02 ms => 37.42ms (+9.6%)
getElementsByClassName : 40.32 ms => 37.68ms (+7.0%)

Unfortunately we cannot observe performance improvement in
Dromaeo/dom-query.html, which are testing getElementsByTagName(),
getElementsByName(), getElementsByClassName(). This is because
the bottleneck of these Dromaeo tests is not toV8(NodeList*) but
.length and .nodeType accesses. The patch for optimizing them
will be coming soon.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateHeader):
(GenerateNormalAttrGetter):
(GetDomMapFunction):
(NativeToJSValue):

bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.

(WebCore::V8Float64Array::wrap):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::wrap):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::wrap):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::wrap):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):

bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::wrap):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):

bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::wrap):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::wrap):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::wrap):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):

bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::wrap):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::wrap):

9:34 PM Changeset in webkit [116268] by abarth@webkit.org

10 edits in trunk

Content Security Policy reports should be reported with content-type application/json, should contain all required fields
https://bugs.webkit.org/show_bug.cgi?id=61360

Reviewed by Eric Seidel.

Source/WebCore:

This patch changes ContentSecurityPolicy to use JSON format for sending
violation reports rather than wwwform-encoding. This patch aligns our
behavior with the specification and with Mozilla. A follow up patch
will update the list of fields in the report to match the spec.

loader/PingLoader.cpp:

(WebCore::PingLoader::reportContentSecurityPolicyViolation):

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::reportViolation):

LayoutTests:

Update results to show JSON format.

http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
http/tests/security/contentSecurityPolicy/report-only-expected.txt:
http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
http/tests/security/contentSecurityPolicy/resources/save-report.php:

9:15 PM Changeset in webkit [116267] by pilgrim@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Call cryptographicallyRandomValues through Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85763

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

src/ChromiumOSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

9:11 PM Changeset in webkit [116266] by mary.wu@torchmobile.com.cn

2 edits in trunk/Tools

Add a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85761

Reviewed by Unreviewed.

Add myself to committers.py contributor.

Scripts/webkitpy/common/config/committers.py:

9:09 PM Changeset in webkit [116265] by mary.wu@torchmobile.com.cn

8 edits in trunk/Source

[BlackBerry] Support html5 download attribute.
https://bugs.webkit.org/show_bug.cgi?id=85044

Reviewed by Antonio Gomes.

Source/WebCore:

Pass download attribute filename to networkJob and it could be
overridden by the Content-Disposition HTTP header's filename parameter.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::initialize):

platform/network/blackberry/ResourceRequest.h:

(WebCore::ResourceRequest::setSuggestSaveName):
(WebCore::ResourceRequest::suggestSaveName):
(ResourceRequest):

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

If a link has download attribute, we should pass that value and be able to
save file with the name according to HTML5:
http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::download):

Api/WebPage_p.h:

(WebPagePrivate):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:43 PM Changeset in webkit [116264] by fpizlo@apple.com

6 edits in branches/dfgopt/Source/JavaScriptCore

Truncating multiplication on integers should not OSR exit every time
https://bugs.webkit.org/show_bug.cgi?id=85752

Reviewed by Gavin Barraclough.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.h:

(JSC::DFG::Graph::mulShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMul):

8:13 PM Changeset in webkit [116263] by bashi@chromium.org

5 edits in trunk

Disallow unquoted -webkit-font-feature-settings tags
https://bugs.webkit.org/show_bug.cgi?id=85362

Reviewed by Kent Tamura.

Source/WebCore:

Disallow unquoted tags to follow the current draft.
http://dev.w3.org/csswg/css3-fonts/#font-feature-settings-prop

No new tests. css3/font-feature-settings-parsing.html was updated.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag): Accepts only 4-characters string.

LayoutTests:

css3/font-feature-settings-parsing-expected.txt: Updated to follow the current draft specification.
css3/font-feature-settings-parsing.html: Ditto.

7:53 PM Changeset in webkit [116262] by rakuco@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix for r116260.

COMPILE_ASSERT() does not expect a string in its second parameter.

platform/graphics/TextRun.cpp:

(WebCore):

7:24 PM Changeset in webkit [116261] by rakuco@webkit.org

3 edits in trunk/LayoutTests

[EFL] Gardening. Skip more failing tests.

platform/efl/Skipped:
platform/efl/test_expectations.txt:

7:19 PM Changeset in webkit [116260] by rwlbuis@webkit.org

3 edits in trunk/Source/WebCore

Shrink TextRun object size
https://bugs.webkit.org/show_bug.cgi?id=85751

Reviewed by Darin Adler.

Reorder the member variables in TextRun so it shrinks from 56 to 40 bytes on my 64-bit build. This is important
for SVG, since RenderSVGText shrinks because of this.

Also add a compile assert for the expected object size.

platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):
(WebCore):

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::direction):
(TextRun):

7:10 PM Changeset in webkit [116259] by keishi@webkit.org

3 edits in trunk/Source/WebKit/chromium

[chromium] Add WebKit API to access multiple attribute of input element
https://bugs.webkit.org/show_bug.cgi?id=85355

Reviewed by Kent Tamura.

We need this to implement the datalist UI for <input type=email multiple>.

public/WebInputElement.h:

(WebInputElement):

src/WebInputElement.cpp:

(WebKit::WebInputElement::isMultiple):
(WebKit):

6:50 PM Changeset in webkit [116258] by commit-queue@webkit.org

7 edits
2 adds in trunk/Source

[BlackBerry] Autofill backing store implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85575

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-06
Reviewed by Rob Buis.

Source/WebCore:

Implemented class AutofillBackingStore which is responsible
for handling interaction with autofill database.

Replaced static function
CredentialBackingStore* CredentialBackingStore::instance()
with a helper function
CredentialBackingStore& credentialBackingStore(),
and used DEFINE_STATIC_LOCAL to construct the singleton
object.
Also removed unnecessary function close() and combined with
the destructor of class CredentialBackingStore.

Initial upstream, No new tests.

PlatformBlackBerry.cmake:
platform/network/blackberry/AutofillBackingStore.cpp: Added.

(WebCore):
(WebCore::autofillBackingStore):
(WebCore::AutofillBackingStore::AutofillBackingStore):
(WebCore::AutofillBackingStore::~AutofillBackingStore):
(WebCore::AutofillBackingStore::open):
(WebCore::AutofillBackingStore::add):
(WebCore::AutofillBackingStore::update):
(WebCore::AutofillBackingStore::contains):
(WebCore::AutofillBackingStore::get):
(WebCore::AutofillBackingStore::clear):

platform/network/blackberry/AutofillBackingStore.h: Added.

(WebCore):
(AutofillBackingStore):

platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::credentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):

platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):
(WebCore):

platform/network/blackberry/CredentialStorageBlackBerry.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage):

Source/WebKit/blackberry:

Replaced calling static function CredentialBackingStore::instance()
with calling the helper function credentialBackingStore().

WebCoreSupport/CredentialManager.cpp:

(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
(WebCore::CredentialManager::clearCredentials):
(WebCore::CredentialManager::clearNeverRememberSites):

6:41 PM Changeset in webkit [116257] by mitz@apple.com

3 edits
9 adds in trunk

.: Part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739

Reviewed by Daniel Bates.

WebKit.xcworkspace: Added.
WebKit.xcworkspace/contents.xcworkspacedata: Added.
WebKit.xcworkspace/xcshareddata: Added.
WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Added.
WebKit.xcworkspace/xcshareddata/xcschemes: Added.
WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Added

this scheme, which builds all source projects and runs WebProcess with
Safari as the client executable.

WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Added

this scheme, which builds all source projects and runs Safari.

WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Added

this scheme, which builds all tools projects and runs DumpRenderTree.

Tools: Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739

Reviewed by Daniel Bates.

Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory

from here...

Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.

6:31 PM Changeset in webkit [116256] by kov@webkit.org

2 edits in trunk

[GTK] Enable WebKit2 build by default (again)
https://bugs.webkit.org/show_bug.cgi?id=85750

configure.ac: enable wk2 build by default.

6:11 PM Changeset in webkit [116255] by morrita@google.com

3 edits
2 adds in trunk

[Shadow DOM] Node distribution should be refreshed before style recalc.
https://bugs.webkit.org/show_bug.cgi?id=85259

Reviewed by Dimitri Glazkov.

Source/WebCore:

Element::recalcStyle() calls child element's recalcStyle()
recursively, following ShadowTree::recalcShadowTreeStyle(). But
recalcShadowTreeStyle() should be called before such recursion if
necessary.

This is because style calculation and following renderer attachment
of each child element depends on up-to-date node distribution result
which is computed during the recalcShadowTreeStyle().

Test: fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector.html

dom/Element.cpp: Moved recalcShadowTreeStyle() before child traversals.

(WebCore::Element::recalcStyle):

LayoutTests:

fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt: Added.
fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector.html: Added.

5:53 PM Changeset in webkit [116254] by abarth@webkit.org

9 edits
4 adds in trunk

CSP should let sites both enforce one policy and monitor another
https://bugs.webkit.org/show_bug.cgi?id=85561

Reviewed by Eric Seidel.

Source/WebCore:

This patch lets us enforce and/or monitor multiple CSP policies.
Rather than having a single directive list, we now have a vector of
directive lists.

Tests: http/tests/security/contentSecurityPolicy/combine-multiple-policies.html

http/tests/security/contentSecurityPolicy/report-and-enforce.html

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::deprecatedHeader):
(WebCore::ContentSecurityPolicy::deprecatedHeaderType):

Even after this patch, workers aren't smart enough to enforce multiple policies. They just use the first header, like they did before. We'll need to teach workers how to enforce multiple policies in a future patch.

(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):

page/ContentSecurityPolicy.h:
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests:

Test that we can enforce multiple policies and that we can enforce one
policy while monitoring another.

http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt: Added.
http/tests/security/contentSecurityPolicy/combine-multiple-policies.html: Added.
http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-and-enforce.html: Added.

5:45 PM Changeset in webkit [116253] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

InlineBox::setHasBadParent should be debug only
https://bugs.webkit.org/show_bug.cgi?id=85748

Patch by Rob Buis <rbuis@rim.com> on 2012-05-06
Reviewed by Eric Seidel.

Do not provide InlineBox::setHasBadParent in release builds.

rendering/InlineBox.h:

(InlineBox):
(WebCore):
(WebCore::InlineBox::setHasBadParent):

5:26 PM Changeset in webkit [116252] by aestes@apple.com

2 edits in trunk/Tools

Fix the build after r116246.

DumpRenderTree/LayoutTestController.cpp: Remove an unused function.

5:14 PM Changeset in webkit [116251] by eric@webkit.org

2 edits in trunk/Tools

Update several build-webkit options to match the #defines they toggle
https://bugs.webkit.org/show_bug.cgi?id=85744

Reviewed by Adam Barth.

Most notable here is fixing --3d-canvas to be --webgl these days --
the define was renamed 15 months ago!

Scripts/webkitperl/FeatureList.pm:

4:28 PM Changeset in webkit [116250] by commit-queue@webkit.org

7 edits in trunk

[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
https://bugs.webkit.org/show_bug.cgi?id=83687

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-06
Reviewed by Antonio Gomes.

Source/WebKit/efl:

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_access_clipboard_get):
(ewk_view_setting_scripts_can_access_clipboard_set):

ewk/ewk_view.h:

Tools:

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setJavaScriptCanAccessClipboard):

LayoutTests:

platform/efl/Skipped:

4:26 PM Changeset in webkit [116249] by eric@webkit.org

3 edits in trunk/WebKitLibraries

Remove 3D_CANVAS define from vsprops files (it was renamed WEBGL many months ago)
https://bugs.webkit.org/show_bug.cgi?id=85743

Reviewed by Adam Barth.

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

3:57 PM Changeset in webkit [116248] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

KURL::isBlankURL would be a nicer idiom than KURL::protocolIs("about")
https://bugs.webkit.org/show_bug.cgi?id=85641

Patch by Mike West <mkwst@chromium.org> on 2012-05-06
Reviewed by Adam Barth.

dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):

page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
(WebCore::PageSerializer::serializeFrame):

platform/KURL.cpp:

(WebCore::KURL::isBlankURL):
(WebCore):

platform/KURL.h:

(KURL):
(WebCore):

3:46 PM Changeset in webkit [116247] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[TextureMapper] Layer images is uploaded to the GPU for each sync
https://bugs.webkit.org/show_bug.cgi?id=85727

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-06
Reviewed by Noam Rosenthal.

No new tests. This does not change functionality,
it only improves performance.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Reset the needsDisplay
and needsDisplayRect variables after uploading the layer image.

3:43 PM Changeset in webkit [116246] by gyuyoung.kim@samsung.com

33 edits in trunk

Convert isPageBoxVisible to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85692

Reviewed by Darin Adler.

Source/autotools/symbols.filter: Add isPageBoxVisible symbol filter.

Source/WebCore:

Add isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

testing/Internals.cpp:

(WebCore):
(WebCore::Internals::isPageBoxVisible):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit/efl:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

win/WebKit2.def: Add isPageBoxVisible symbol filter.

Tools:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
DumpRenderTree/mac/LayoutTestControllerMac.mm:
DumpRenderTree/qt/LayoutTestControllerQt.cpp:
DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

DumpRenderTree/win/LayoutTestControllerWin.cpp:
DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Call isPageBoxVisible functions from internals, because it is able to work in the
cross-port way through the Internals interface.

printing/page-format-data-expected.txt:
printing/page-format-data.html:

3:33 PM Changeset in webkit [116245] by tomz@codeaurora.org

3 edits in trunk/Tools

sheriffbot isn't reopening patches after it lands rollouts
https://bugs.webkit.org/show_bug.cgi?id=64418

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

3:19 PM Changeset in webkit [116244] by commit-queue@webkit.org

2 edits
2 adds in trunk

Web Inspector: "Goto Function" filtering should be less restrictive.
https://bugs.webkit.org/show_bug.cgi?id=85586

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-06
Reviewed by Pavel Feldman.

Added tests for generated regex.

Changes:
1) Avoid asterisks in filtering queue.
2) Optimization: do not create regexp for each item.

inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
Applied new filtering workflow.
(WebInspector.FilteredItemSelectionDialog.prototype._checkItemAt):
Removed.
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
Removed unused "suffix" logic; changed the way regexp is composed from query.
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
Applied new filtering workflow.
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
Removed unused var.

3:12 PM Changeset in webkit [116243] by tkent@chromium.org

7 edits in trunk/Source

Rename ICULocale to LocaleICU, part 2
https://bugs.webkit.org/show_bug.cgi?id=85695

Reviewed by Kentaro Hara.

Source/WebCore:

No behavior change

platform/text/LocaleICU.cpp: Rename ICULocale to LocaleICU.
platform/text/LocaleICU.h: ditto.

Also, update obsolete comments.

platform/text/LocalizedDateICU.cpp: Rename ICULocale to LocaleICU.

(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):

platform/text/LocalizedNumberICU.cpp: ditto.

(WebCore::convertToLocalizedNumber):
(WebCore::convertFromLocalizedNumber):

Source/WebKit/chromium:

tests/LocalizedNumberICUTest.cpp:

(testNumberIsReversible): Rename ICULocale to LocaleICU.

3:06 PM Changeset in webkit [116242] by enne@google.com

4 edits
1 add in trunk/Source/WebKit/chromium

[chromium] Allow WebMediaPlayerClientImpl to switch clients
https://bugs.webkit.org/show_bug.cgi?id=85093

Reviewed by James Robinson.

WebVideoFrameProviderClient has a 1:1 relationship with a
WebVideoFrameProvider. The client here is CCVideoLayerImpl and the
provider is WebMediaPlayerClientImpl. If the provider gets a new
client, then the old client needs to be informed to stop using the
provider.

If this doesn't happen, then the old client will have an unsafe
pointer to the provider, will not get informed if the provider gets
deleted, and the client will crash when it dereferences the provider
pointer trying to tell the provider that its client is going away.

Test: WebMediaPlayerClientImplTest.InitialNullVideoClient

WebMediaPlayerClientImplTest.SetAndUnsetVideoClient
WebMediaPlayerClientImplTest.DestroyProvider
WebMediaPlayerClientImplTest.SetMultipleVideoClients

WebKit.gypi:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

3:05 PM Changeset in webkit [116241] by commit-queue@webkit.org

4 edits in trunk

[BlackBerry] Enable credential persistance and auto fill
https://bugs.webkit.org/show_bug.cgi?id=85572

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-06
Reviewed by Rob Buis.

Enable credential persistance and auto fill feature by adding
ENABLE_BLACKBERRY_CREDENTIAL_PERSIST=1.

Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

Set autofilled status of credential input fields when credential
information is auto filled by CredentialManager.
By doing this the input element will get painted with yellow background
which can notify user this input field is auto filled by the browser.

No behavior changes, so no new test.

WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::setCredential):

3:05 PM Changeset in webkit [116240] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.9.2

Tagging the WebKitGTK+ 1.9.2 release.

2:19 PM Changeset in webkit [116239] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-06

DEPS:

1:20 PM Changeset in webkit [116238] by kevino@webkit.org

6 edits in trunk/Source/WebCore

[wx] Unreviewed. Build fixes for recent trunk changes.

7:54 AM Changeset in webkit [116237] by caseq@chromium.org

13 edits in trunk/Source

Web Inspector: take timeline frame mode out of experimental
https://bugs.webkit.org/show_bug.cgi?id=85707

Reviewed by Pavel Feldman.

Source/WebCore:

remove "Vertical timeline overview" experiment;
add supportsFrameInstrumentation capability to InspectorTimelineAgent;
show frame mode selector conditionally on supportsFrameInstrumentation capability.

inspector/Inspector.json: Add Timeline.supportsFrameInstrumentation capability;
inspector/InspectorClient.h: Add supportsFrameInstrumentation();

(InspectorClient):
(WebCore::InspectorClient::supportsFrameInstrumentation):

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
(WebCore):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent): Added FrameInstrumentationSupport parameter.

inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create): ditto.
(InspectorTimelineAgent):

inspector/WorkerInspectorController.cpp: Updated call site for InspectorTimelineAgent::create() to indicate frame instrumentation not supported.

(WebCore::WorkerInspectorController::WorkerInspectorController):

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings): Removed "Vertical Overview" experiment.

inspector/front-end/TimelineOverviewPane.js: Expose frame mode conditionally on capability, not the experiment.

(WebInspector.TimelineOverviewPane):

inspector/front-end/inspector.js: Added initialization for Capabilities.timelineSupportsFrameInstrumentation;

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

exposed supportFrameInstrumentation method to InspectorClient. Client must return true iff the platform will call InspectorInstrumentation::instrumentBeginFrame() upon beginning of frame rendering;

src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::supportsFrameInstrumentation):
(WebKit):

src/InspectorClientImpl.h:

(InspectorClientImpl):

3:51 AM Changeset in webkit [116236] by Antti Koivisto

2 edits in trunk/Source/WebCore

Build fix.

Not reviewed.

css/PropertySetCSSStyleDeclaration.cpp:

3:29 AM Changeset in webkit [116235] by Antti Koivisto

27 edits
6 adds in trunk

Share stylesheet data structures between documents
https://bugs.webkit.org/show_bug.cgi?id=85598

Source/WebCore:

Reviewed by Darin Adler.

We currently make a copy of the data structures when restoring a cached stylesheet. This patch lets us share
the data until someone uses CSSOM to modify the sheet.

The patch implements copy-on-write for the internal style sheet data structures. If any mutation CSSOM API is
invoked, we check if the stylesheet can be safely mutated (we are the only client, it is not cached). If not
then the internal structures are copied and any existing CSSOM objects are re-attached to the new tree.

Sharing can save significant amount of memory on sites with large stylesheets. For example if you have
multiple articles open on wsj.com this saves ~2.6MB per tab.

Test: http/tests/css/shared-stylesheet-mutation.html

http/tests/css/shared-stylesheet-mutation-preconstruct.html

css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):
(WebCore):

css/CSSFontFaceRule.h:

(CSSFontFaceRule):

css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::reattach):
(WebCore):

css/CSSMediaRule.h:

(CSSMediaRule):

css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::reattach):
(WebCore):

css/CSSPageRule.h:

(CSSPageRule):

css/CSSRule.cpp:

(WebCore::CSSRule::reattach):

After the internal stylerule tree has been copied, the existing wrappers are re-attached using recursive reattach() function.

css/CSSRule.h:

(WebCore):
(CSSRule):

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::reattach):
(WebCore):

css/CSSStyleRule.h:

(CSSStyleRule):

css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::ruleAt):

Add ruleAt(), use it for both wrapper creation and reattaching. Remove createChildRuleCSSOMWrapper .

(WebCore):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):

Invalidation moves to the calling wrapper.

(WebCore::StyleSheetInternal::addedToMemoryCache):
(WebCore::StyleSheetInternal::removedFromMemoryCache):
(WebCore::CSSStyleSheet::willMutateRules):

This is called whenever StyleSheetInternal is going to be mutated. It will do copy-on-write if needed.

Usually invoked by CSSStyleSheet::RuleMutation RAII type.

(WebCore::CSSStyleSheet::didMutateRules):

This is called after the mutation is complete and will trigger the style recalc in the document.

(WebCore::CSSStyleSheet::didMutate):

This is called directly after mutations that don't change StyleSheetInternal so don't require copy-on-write.

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasOneClient):
(WebCore::StyleSheetInternal::isMutable):
(WebCore::StyleSheetInternal::setMutable):

Track mutability. Mutation is allowed only after willMutate call.

(WebCore::StyleSheetInternal::isInMemoryCache):

Track if the object is in memory cache.

(WebCore::CSSStyleSheet::clearOwnerRule):
(CSSStyleSheet):

css/MediaList.cpp:

(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::didMutate):
(WebCore):
(WebCore::MediaList::reattach):

css/MediaList.h:

(MediaList):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
(WebCore::InlineCSSStyleDeclaration::didMutate):

css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::willMutate):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(StyleRuleCSSStyleDeclaration):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore):

css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reattach):

css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

Don't copy when restoring. It is no longer necessary.
Set the cache bit on the stylesheet.

(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

Reviewed by Darin Adler.

Test that mutations of a shared stylesheet work as expected.

This is an http test due to cross-document security restrictions with file urls
(they can be overriden in DRT but I'd like this to work in browser too).

http/tests/css/resources/shared.css: Added.
http/tests/css/resources/shared-stylesheet-mutation.js: Added.
http/tests/css/shared-stylesheet-mutation-expected.txt: Added.
http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Added.
http/tests/css/shared-stylesheet-mutation-preconstruct.html: Added.
http/tests/css/shared-stylesheet-mutation.html: Added.

12:17 AM Changeset in webkit [116234] by Martin Robinson

2 edits in trunk/Source/WebKit/gtk

Fix the GTK+ TextureMapper accelerated compositing build.

webkit/webkitwebview.cpp:

(webkit_web_view_realize): Properly access the private data
structure of the WebKitWebView.

May 5, 2012:

10:27 PM Changeset in webkit [116233] by barraclough@apple.com

5 edits in trunk/Source/JavaScriptCore

Remove TrustedImm32::m_isPointer
https://bugs.webkit.org/show_bug.cgi?id=85726

Rubber stamped by Sam Weinig.

We used to rely on being able to generate code with known, fixed offsets – to do so we
would inhibit more optimal code generation for pointers. This is no longer necessary.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch32):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::move):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::move):

4:04 PM Changeset in webkit [116232] by commit-queue@webkit.org

7 edits in trunk

Unreviewed, rolling out r116221.
http://trac.webkit.org/changeset/116221
https://bugs.webkit.org/show_bug.cgi?id=85722

broke builds that use -Wshorten-64-to-32 (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

Source/WebCore:

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

html/canvas/WebGLRenderingContext.idl:

LayoutTests:

fast/canvas/webgl/index-validation-expected.txt:
fast/canvas/webgl/index-validation.html:

2:41 PM Changeset in webkit [116231] by kov@webkit.org

5 edits in trunk/Source

[GTK] WebKit should properly set the input method context window location
https://bugs.webkit.org/show_bug.cgi?id=84981

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect): Add this method to plumb the
cursor rect through to the input method.

platform/gtk/GtkInputMethodFilter.h: Add the new method declaration.

Source/WebKit/gtk:

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::paint): During painting, update the cursor rectangle
if possible.

2:38 PM Changeset in webkit [116230] by dino@apple.com

27 edits
3 adds in trunk

Add new Setting/Preference to disable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=85693

Reviewed by Simon Fraser.

Source/WebCore:

Hook up the new WebPreference for disabling requestAnimationFrame
to Settings. This isn't disabling the feature in the typical
WebKit ENABLE() way - it's still available in the DOM, it's
just that the animations will never be serviced. This allows a client
to disable the machinery without breaking content (other than the
animations).

The new test is currently skipped on all platforms because toggling
the preference interferes with the other tests that are running
at the same time (and expect a working requestAnimationFrame).
https://bugs.webkit.org/show_bug.cgi?id=85689

Test: fast/animation/request-animation-frame-disabled.html

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
Check the setting before deciding to act.

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setRequestAnimationFrameEnabled):
(WebCore::Settings::requestAnimationFrameEnabled):
(Settings):

Source/WebKit/mac:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences requestAnimationFrameEnabled]):
(-[WebPreferences setRequestAnimationFrameEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):

WebPreferences.h:

(WebPreferences):

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

Shared/WebPreferencesStore.h:

(WebKit):

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRequestAnimationFrameEnabled):
(WKPreferencesGetRequestAnimationFrameEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

A new test that exercises turning the requestAnimationFrame
preference off. Unfortunately this conflicts with the parallel
tests that expect the preference to be on (as it should by default),
so the test is skipped on all platforms. It can be run in isolation.
https://bugs.webkit.org/show_bug.cgi?id=85689

fast/animation/request-animation-frame-disabled-expected.txt: Added.
fast/animation/request-animation-frame-disabled.html: Added.
fast/animation/script-tests/request-animation-frame-disabled.js: Added.
platform/chromium/test_expectations.txt:
platform/efl/test_expectations.txt:
platform/gtk/test_expectations.txt:
platform/mac/Skipped:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:
platform/win/Skipped:
platform/win/test_expectations.txt:

2:08 PM Changeset in webkit [116229] by rakuco@webkit.org

2 edits in trunk/Tools

webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697

Reviewed by Eric Seidel.

Scripts/new-run-webkit-tests: Instead of manually detecting whether

the path separator should be ':' or ';' by checking sys.platform, rely
on os.pathsep which has exactly the same information (os.pathsep is
':' for Cygwin, from what I could check in Python's sources).

2:00 PM Changeset in webkit [116228] by kov@webkit.org

4 edits in trunk

Unreviewed preparation for 1.9.2.

configure.ac: bump version to 1.9.2 and bump libtool version.

Source/WebKit/gtk:

NEWS: changes from 1.9.1.

1:59 PM Changeset in webkit [116227] by kov@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, make distcheck fix.

Source/WebCore:

GNUmakefile.list.am: Add missing headers to the sources list.

12:38 PM Changeset in webkit [116226] by jonlee@apple.com

3 edits in trunk/Source/WebKit2

[WK2] Incoming events may be processed out-of-order
https://bugs.webkit.org/show_bug.cgi?id=85696
<rdar://problem/11386129>

Reviewed by Maciej Stachowiak.

All messages go to a single queue that gets iterated over by dispatchMessages(). If an input
event arrives in the middle of a flood of messages, all of them will be dispatched before the
input event is dispatched.

In other words, the first dispatchMessages() call will process all of the messages in the queue,
and all subsequent dispatchMessages() calls will act as no-ops, since there is nothing in the queue.

To fix this, we rename dispatchMessages to dispatchOneMessage, and only process one message at a
time.

Platform/CoreIPC/Connection.h: Rename dispatchMessages() to dispatchOneMessage().
Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::enqueueIncomingMessage): Dispatch a call to dispatchOneMessage() on the
run loop.
(CoreIPC::Connection::dispatchOneMessage): Remove the while(true) loop.

10:05 AM Changeset in webkit [116225] by loislo@chromium.org

2 edits in trunk/PerformanceTests

Web Inspector: unreviewed followup fix for the performance test after r116218.

inspector/heap-snapshot.html:

9:54 AM Changeset in webkit [116224] by rakuco@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r116223.
http://trac.webkit.org/changeset/116223
https://bugs.webkit.org/show_bug.cgi?id=85718

The bots need to set XDG_DATA_DIRS (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

efl/jhbuildrc:
gtk/jhbuildrc:

9:34 AM Changeset in webkit [116223] by rakuco@webkit.org

3 edits in trunk/Tools

[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=85717

Reviewed by Martin Robinson.

After r116209, the XDG_DATA_DIRS environment variable is now
passed by webkitpy's layout_tests code to run-with-jhbuild, so
instead of setting a few defaults in jhbuildrc we can now rely on
the values set and really used by each system.

efl/jhbuildrc:
gtk/jhbuildrc:

8:33 AM Changeset in webkit [116222] by loislo@chromium.org

15 edits
1 add in trunk/Source/WebCore

Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object.
https://bugs.webkit.org/show_bug.cgi?id=85710

The idea is to have an object and be able to add/remove event listeners from it.

Reviewed by Yury Semikhatsky.

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/FileManager.js: Copied from Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js.

(WebInspector.FileManager):
(WebInspector.FileManager.prototype.canSave):
(WebInspector.FileManager.prototype.canAppend):
(WebInspector.FileManager.prototype.append):
(WebInspector.FileManager.prototype.appendedToURL):

inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

inspector/front-end/InspectorFrontendHostStub.js:
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

7:51 AM Changeset in webkit [116221] by zmo@google.com

7 edits in trunk

vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr

html/canvas/WebGLRenderingContext.h: Ditto

(WebGLRenderingContext):

html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

fast/canvas/webgl/index-validation-expected.txt:
fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.

5:24 AM Changeset in webkit [116220] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: add separate timeline overview item for the frame mode
https://bugs.webkit.org/show_bug.cgi?id=85706

remove two-buttons horizontal/vertical mode switch from Timelines item of the timeline overview menu;
rename "Timeline" into "Events";
add "Frames" item;
replace overview sidebar icons with smaller, monochrome ones.

English.lproj/localizedStrings.js: Added "Frames" and "Events".
inspector/front-end/Images/statusbarButtonGlyphs.png: Added icon for "Memory".
inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setMode):

inspector/front-end/timelinePanel.css:

(#timeline-overview-sidebar .sidebar-tree-item):
(#timeline-overview-sidebar .sidebar-tree-item .titles.no-subtitle):
(#timeline-overview-sidebar .icon):
(.timeline-overview-sidebar-events .icon):
(.timeline-overview-sidebar-frames .icon):
(.timeline-overview-sidebar-memory .icon):

3:25 AM Changeset in webkit [116219] by pfeldman@chromium.org

3 edits in trunk/LayoutTests

Not reviewed: follow up to r116216, fixing the inspector test.

inspector/debugger/script-extract-outline.html:
inspector/debugger/script-extract-outline-expected.txt:

3:23 AM Changeset in webkit [116218] by loislo@chromium.org

8 edits in trunk

Web Inspector: save HeapSnapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=85595

HeapSnapshot specific implementation for loading was moved
from ProfilesPanel to HeapProfileHeader class.

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load.setProfileWait):
(WebInspector.HeapProfileHeader.prototype.load.done):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.appendedToURL):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

inspector/front-end/inspector.js:

(WebInspector.append):
(WebInspector.appendedToURL):

LayoutTests:

inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

3:07 AM Changeset in webkit [116217] by pfeldman@chromium.org

5 edits in trunk

Web Inspector: allow overriding the script mapping on the UI level
https://bugs.webkit.org/show_bug.cgi?id=85702

Reviewed by Yury Semikhatsky.

Source/WebCore:

This allows formatting update live locations all over the place automatically.

inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.update):
(WebInspector.Script.Location.prototype.dispose):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.removeLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
(WebInspector.UISourceCode.prototype.overrideLocation):

LayoutTests:

inspector/debugger/breakpoint-manager.html:

2:46 AM Changeset in webkit [116216] by pfeldman@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: simplify the JavaScriptOutline dialog interaction.
https://bugs.webkit.org/show_bug.cgi?id=85701

Reviewed by Yury Semikhatsky.

Removed bidirectional dependency between scripts panel and outline dialog.

inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.show):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):

inspector/front-end/ScriptFormatterWorker.js:
inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.addToWatch):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):

2:38 AM Changeset in webkit [116215] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Buildfix for --minimal build after r116107.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-05
Reviewed by Csaba Osztrogonác.

qmake/mkspecs/features/features.prf:

12:46 AM Changeset in webkit [116214] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed Gtk gardening, mark fullscreen/non-ancestor-iframe.html as
failing after it was added in r116165.

platform/gtk/test_expectations.txt:

12:43 AM Changeset in webkit [116213] by caseq@chromium.org

1 edit
1 add in trunk/LayoutTests

Unreviewed. Rebaseline fast/events/attribute-listener-deletion-crash.html (added in r116191).

platform/chromium/fast/events/attribute-listener-deletion-crash-expected.txt: Added.

12:34 AM Changeset in webkit [116212] by zandobersek@gmail.com

2 edits in trunk/Tools

[Gtk] GtkDriver is not required anymore after r116134
https://bugs.webkit.org/show_bug.cgi?id=85699

Reviewed by Csaba Osztrogonác.

Remove GtkDriver as it was replaced by the XvfbDriver and is
no longer needed.

Scripts/webkitpy/layout_tests/port/gtk.py:

12:25 AM Changeset in webkit [116211] by zandobersek@gmail.com

2 edits in trunk/Tools

Increase the display ID for the Xvfb process to use if pixel_tests argument
is true rather than if pixel_tests option is present. This fixes the
XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.

Rubber-stamped by Csaba Osztrogonác.

Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed