Context Navigation

← Previous Period
Next Period →

Timeline

May 8, 2012:

11:59 PM TraversingShadowDOMTree edited by hayato@chromium.org

(diff)

11:16 PM Changeset in webkit [116497] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

NavigatorRegisterProtocolHandler can call ChromeClient directly.
https://bugs.webkit.org/show_bug.cgi?id=85944

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-08
Reviewed by Adam Barth.

Covered by fast/dom/register-protocol-handler.html

page/Chrome.cpp: Remove registerProtocolHandler function.
page/Chrome.h: Remove registerProtocolHandler prototype.

(Chrome):

page/NavigatorRegisterProtocolHandler.cpp: Call ChromeClient::registerProtocolHandler directly.

(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):

11:14 PM Changeset in webkit [116496] by mario@webkit.org

2 edits in trunk/Source/WebCore

Coding style issues present in RenderFrameSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=85955

Reviewed by Eric Seidel.

Just fixed those coding style issues.

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::GridAxis::resize):
(WebCore::RenderFrameSet::layOutAxis):
(WebCore::RenderFrameSet::continueResizing):

10:52 PM Changeset in webkit [116495] by jochen@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

9:45 PM Changeset in webkit [116494] by barraclough@apple.com

7 edits in trunk/Source/JavaScriptCore

ROLLING OUT r114255

GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by nobody.

This breaks the world, with COLLECT_ON_EVERY_ALLOCATION enabled.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

runtime/JSObject.h:

(JSObject):
(JSC::JSObject::isUsingInlineStorage):
(JSC):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):

runtime/Structure.cpp:

(JSC):

runtime/Structure.h:

(JSC::Structure::didTransition):

9:43 PM TraversingShadowDOMTree edited by hayato@chromium.org

(diff)

9:33 PM Changeset in webkit [116493] by jonlee@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

platform/mac/WebCoreSystemInterface.h:

9:20 PM Changeset in webkit [116492] by jonlee@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

(LayerTreeHostCAWin):

9:10 PM Changeset in webkit [116491] by tkent@chromium.org

3 edits in trunk/LayoutTests

Unreviewed, a trivial test fix to remove a platform-dependency.
https://bugs.webkit.org/show_bug.cgi?id=81854

fast/forms/form-collection-radio-node-list-expected.txt:
fast/forms/form-collection-radio-node-list.html:

Remove form controls from the document before completing the test.

8:49 PM Changeset in webkit [116490] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update
Skip post-in-iframe-with-back-navigation.html because it might cause a
failure of the next test, preload-append-scan.php

platform/chromium/test_expectations.txt:

8:39 PM Changeset in webkit [116489] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Update test expectations.

platform/chromium/test_expectations.txt:

8:35 PM Changeset in webkit [116488] by commit-queue@webkit.org

5 edits
2 adds in trunk

[BlackBerry] Auth credentials set in private mode are reused in public mode.
https://bugs.webkit.org/show_bug.cgi?id=84697

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-08
Reviewed by Rob Buis.

Add setPrivateMode function for CredentialStorage.

Source/WebCore:

Now, we only save credentials in memory and CredentialBackingStore isn't enabled.
When we set private mode from on to off, we clear all these temporary credentials.

We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html

network/CredentialStorage.cpp:

(WebCore::CredentialStorage::setPrivateMode):
(WebCore):

platform/network/CredentialStorage.h:

(CredentialStorage):

Source/WebKit/blackberry:

We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

8:23 PM Changeset in webkit [116487] by commit-queue@webkit.org

20 edits
5 adds in trunk

RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Implement RadioNodeList support spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#radionodelist

Test: fast/forms/form-collection-radio-node-list.html

CMakeLists.txt:

Added entries for new files.

DerivedSources.cpp: Ditto.
DerivedSources.make: Ditto.
DerivedSources.pri: Ditto.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Added code to include Node.h and JSNode.h in JSRadioNodeElement.cpp.

bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.

dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
Invalidate lists even for change in id, type, checked attributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
Invalidate radioNodeList cache.
(WebCore::NodeListsNodeData::isEmpty):
Changes for radioNodeList.
(WebCore::Node::radioNodeList):
Creates if needed a RadioNodeList and adds it to the cache.
(WebCore::Node::removeCachedRadioNodeList):
Removes a cached radioNodeList.

dom/Node.h: Ditto
dom/NodeRareData.h:

(WebCore):
(NodeListsNodeData):
Added radioNodeList list.

html/CollectionType.h:

Added new FormControls type.

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
Handle FormControls collection type.

html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
Contruct collection of FormControls type.

html/RadioNodeList.cpp: Added.

(WebCore):
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::~RadioNodeList):
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
(WebCore::RadioNodeList::nodeMatches):

html/RadioNodeList.h: Added.

(WebCore):
(RadioNodeList):
(WebCore::RadioNodeList::create):
RadioNodeList implementation.

html/RadioNodeList.idl: Added.

Idl for generating RadioNodeList JS/V8 bindings.

LayoutTests:

fast/forms/form-collection-radio-node-list-expected.txt: Added.
fast/forms/form-collection-radio-node-list.html: Added.

8:20 PM Changeset in webkit [116486] by benjamin@webkit.org

3 edits
6 adds in trunk

[JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args
https://bugs.webkit.org/show_bug.cgi?id=85928

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-08
Reviewed by Geoffrey Garen.

Source/WebCore:

The functions addEventListener() and removeEventListener() raise an exception if there are missin arguments.
This behavior breaks existing content.

This patch change the code generator of JavaScript core to have an exception for addEventListener() and removeEventListener().
For those function, we do not raise an exception on missin argument.

This patch does not modify the V8 code generator because such exceptions are already in place there.

Tests: fast/dom/Window/window-legacy-event-listener.html

fast/dom/XMLHttpRequest-legacy-event-listener.html
fast/dom/node-legacy-event-listener.html

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

LayoutTests:

fast/dom/Window/window-legacy-event-listener-expected.txt: Added.
fast/dom/Window/window-legacy-event-listener.html: Added.
fast/dom/XMLHttpRequest-legacy-event-listener-expected.txt: Added.
fast/dom/XMLHttpRequest-legacy-event-listener.html: Added.
fast/dom/node-legacy-event-listener-expected.txt: Added.
fast/dom/node-legacy-event-listener.html: Added.

7:48 PM Changeset in webkit [116485] by crogers@google.com

14 edits in trunk/Source/WebCore

AudioParam should directly be given context in create() method
https://bugs.webkit.org/show_bug.cgi?id=85905

Reviewed by James Robinson.

No new tests. This is a low-level re-factoring and is covered by existing tests.

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

Modules/webaudio/AudioGain.h:

(WebCore::AudioGain::create):
(WebCore::AudioGain::AudioGain):

Modules/webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::AudioGainNode):

Modules/webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::AudioPannerNode):

Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::create):
(AudioParam):
(WebCore::AudioParam::AudioParam):

Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

Modules/webaudio/BiquadProcessor.h:
Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

Modules/webaudio/DelayProcessor.h:

(DelayProcessor):

Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):

7:44 PM Changeset in webkit [116484] by mhahnenberg@apple.com

4 edits in trunk/Source/JavaScriptCore

Heap should not continually allocate new pages in steady state
https://bugs.webkit.org/show_bug.cgi?id=85936

Reviewed by Geoff Garen.

Currently, in steady state (i.e. a constant amount of live GC
memory with a constant rate of allocation) assuming we've just
finished a collection with X live blocks in CopiedSpace, we
increase our working set by X blocks in CopiedSpace with each
collection we perform. This is due to the fact that we allocate
until we run out of free blocks to use in the Heap before we
consider whether we should run a collection.

In the longer term, this issue will be mostly resolved by
implementing quick release for the CopiedSpace. In the shorter
term, we should change our policy to check whether we should
allocate before trying to use a free block from the Heap. We
can change our policy to something more appropriate once we
have implemented quick release.

This change should also have the convenient side effect of
reducing the variance in GC-heavy tests (e.g. v8-splay) due
to fact that we are doing less VM allocation during copying
collection. Overall, this patch is performance neutral across
the benchmarks we track.

heap/CopiedSpace.cpp:

(JSC::CopiedSpace::getFreshBlock): Shuffle the request from the BlockAllocator
around so that we only do it if the block request must succeed
i.e. after we've already checked whether we should do a collection.

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase): Ditto.
(JSC::MarkedAllocator::allocateBlock): We no longer have a failure mode in this
function because by the time we've called it, we've already checked whether we
should run a collection so there's no point in returning null.

heap/MarkedAllocator.h: Removing old arguments from function declaration.

(MarkedAllocator):

7:37 PM Changeset in webkit [116483] by ojan@chromium.org

5 edits in trunk/Tools

Show the chromium non-layout test bots in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=85903

Reviewed by Eric Seidel.

This is just a single-line high-level overview of the chromium non-layout test bots.
This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
order to do their job.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#chromium-gtests iframe):
(#chromium-gtests):
(#gtest-label):

7:34 PM Changeset in webkit [116482] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r116475.

platform/efl/test_expectations.txt:

7:26 PM Changeset in webkit [116481] by danakj@chromium.org

8 edits in trunk/Source

[chromium] Show borders for partial-draw-culled quads to visualize culling behaviour
https://bugs.webkit.org/show_bug.cgi?id=85414

Reviewed by Adrienne Walker.

Source/WebCore:

The borders are brown, and are only shown when the quad's visible rect
is non-empty and is different from the quad's original rect.

Adds a flag to CCQuadCuller constructor, to enable showing debug borders
around what it leaves after culling (when it culls anything in a quad
at all).

platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::isDebugQuad):
(WebCore::CCDrawQuad::sharedQuadState):
(CCDrawQuad):

platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore):
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::appendQuadInternal):
(WebCore::CCQuadCuller::append):
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):

platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

Source/WebKit/chromium:

tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):

tests/MockCCQuadCuller.h:

(WebCore::MockCCQuadCuller::MockCCQuadCuller):

7:18 PM Changeset in webkit [116480] by jchaffraix@webkit.org

4 edits in trunk/Source/WebCore

Move RenderLayers z-index lists dirtying to post style change
https://bugs.webkit.org/show_bug.cgi?id=85437

Reviewed by Darin Adler.

No expected change in behavior.

This change moves the z-order lists to RenderLayer::styleChanged. As part of this
change, also added proper handling of stacking context transition. This enabled
us to tighten more of the dirtyZOrderLists / clearZOrderLists code.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):
Removed this code, moved to updateStackingContextsAfterStyleChange.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Only stacking contexts start with dirty z-order lists.

(WebCore::RenderLayer::dirtyZOrderLists):
Added an ASSERT.

(WebCore::RenderLayer::updateStackingContextsAfterStyleChange):
Refactored the code to handle the transition between stacking context status.

(WebCore::RenderLayer::styleChanged):
Added a call to updateStackingContextsAfterStyleChange.

rendering/RenderLayer.h:

(WebCore::RenderLayer::isStackingContext):
Added a call to the next function.

(WebCore::RenderLayer::layerWithStyleIsStackingContext):
Factored the isStackingContext logic here so that we can reuse it inside
updateStackingContextsAfterStyleChange.

(WebCore::RenderLayer::clearZOrderLists):
Added an ASSERT.

7:11 PM Changeset in webkit [116479] by tkent@chromium.org

2 edits in trunk/Source/WebKit/mac

Fixe Chromium build, and add a FIXME comment about a layering violation.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:03 PM Changeset in webkit [116478] by andersca@apple.com

9 edits in trunk/Source/WebKit2

DrawingAreaProxyImpl doesn't work with window server hosting
https://bugs.webkit.org/show_bug.cgi?id=85947
<rdar://problem/11213718>

Reviewed by Andreas Kling.

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::updateAcceleratedCompositingMode):
Update the layer tree context and call WebPage::updateAcceleratedCompositingMode.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setLayerHostingMode):
If setting the layer hosting mode changed the layer tree context, send back an UpdateAcceleratedCompositingMode message
with the new context.

WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize):
platformInitialize no longer takes a context.

WebProcess/WebPage/ca/LayerTreeHostCA.h:

(LayerTreeHostCA):
Make m_layerTreeContext protected instead.

WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize):
Assign to m_layerTreeContext directly.

(WebKit::LayerTreeHostCAMac::setLayerHostingMode):
Set m_layerTreeContext.contextID.

WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::platformInitialize):
Assign to m_layerTreeContext directly.

6:47 PM Changeset in webkit [116477] by ojan@chromium.org

2 edits in trunk/LayoutTests

Suppress failing test while the fix is being worked out.

platform/chromium/test_expectations.txt:

6:45 PM Changeset in webkit [116476] by inferno@chromium.org

11 edits
2 adds in trunk

Crash due to owning renderer not removed from custom scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=80610

Reviewed by Eric Seidel.

Source/WebCore:

Test: scrollbars/scrollbar-owning-renderer-crash.html

Changed RenderScrollbar to keep pointer to owning node, instead of the
renderer. Renderer can get destroyed without informing the scrollbar, causing
crashes later. Remove code from r94107 since it is not needed anymore and saves
times when RenderBox is getting destroyed.

page/FrameView.cpp:

(WebCore::FrameView::createScrollbar): pass renderer's node.

page/FrameView.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed): no longer need this. came originally from r94107.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar): pass renderer's node.
(WebCore::RenderLayer::destroyScrollbar): no longer need to clear owning renderer.

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::createScrollbar): pass renderer's node.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::createScrollbar): pass renderer's node.

rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::createCustomScrollbar): Store owner node instead of renderer.
(WebCore::RenderScrollbar::RenderScrollbar): Store owner node instead of renderer.
(WebCore::RenderScrollbar::owningRenderer): calculate owning renderer from owner node.

rendering/RenderScrollbar.h:

(RenderScrollbar):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createScrollbar): pass renderer's node.

LayoutTests:

scrollbars/scrollbar-owning-renderer-crash-expected.txt: Added.
scrollbars/scrollbar-owning-renderer-crash.html: Added.

6:44 PM TraversingShadowDOMTree edited by hayato@chromium.org

(diff)

6:32 PM Changeset in webkit [116475] by commit-queue@webkit.org

8 edits
2 adds in trunk

[EFL][DRT] Implement TextInputController.
https://bugs.webkit.org/show_bug.cgi?id=78559

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-08
Reviewed by Martin Robinson.

TextInputController has been created for an input emulation purpose in DRT.
However, not like other ports, EFL doesn't have it.
Therefore, this patch will enable EFL port to have an input emulation in DRT.

Source/WebKit/efl:

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

DumpRenderTree/efl/CMakeLists.txt:
DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

DumpRenderTree/efl/TextInputController.cpp: Added.

(setMarkedTextCallback):
(hasMarkedTextCallback):
(markedRangeCallback):
(insertTextCallback):
(unmarkTextCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
(makeTextInputController):

DumpRenderTree/efl/TextInputController.h: Added.

LayoutTests:

platform/efl/Skipped:

6:05 PM TraversingShadowDOMTree created by hayato@chromium.org

5:58 PM Changeset in webkit [116474] by tony@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] force ENABLE_REGISTER_PROTOCOL_HANDLER=1 in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=85924

Reviewed by Adam Barth.

This has been enabled for a few months on Chromium trunk so remove the
ability to turn it off via a gyp flag. This simplifies features.gypi.

features.gypi:

5:57 PM Changeset in webkit [116473] by jonlee@apple.com

16 edits
7 adds in trunk

Safari warns that it needs to resend the form in an iFrame when going back
https://bugs.webkit.org/show_bug.cgi?id=82658
<rdar://problem/11292558>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/loading/post-in-iframe-with-back-navigation.html

WebCore.exp.in: Add _wkCFURLRequestAllowAllPostCaching.
platform/mac/WebCoreSystemInterface.h: Add wkCFURLRequestAllowAllPostCaching.
platform/mac/WebCoreSystemInterface.mm: Add wkCFURLRequestAllowAllPostCaching.
platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.

WebKitLibraries:

WebKitSystemInterface.h:
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceSnowLeopard.a:

LayoutTests:

Add new test which navigates a series of pages in an iframe. Each navigation is a POST.
At the third page we click on a back link, and expect to see stale POST data.

http/tests/loading/post-in-iframe-with-back-navigation-expected.txt: Added.
http/tests/loading/post-in-iframe-with-back-navigation.html: Added.
http/tests/loading/resources/post-in-iframe-with-back-navigation-page-1.php: Added.
http/tests/loading/resources/post-in-iframe-with-back-navigation-page-2.php: Added.
http/tests/loading/resources/post-in-iframe-with-back-navigation-page-3.php: Added.
http/tests/resources/js-test-post.js: Added. Copied from fast/js/resources since it is

inaccessible to the test server.

http/tests/resources/js-test-pre.js: Added. Copied from fast/js/resources since it is

inaccessible to the test server.

5:54 PM Changeset in webkit [116472] by danakj@chromium.org

8 edits in trunk/Source

[chromium] Reflections with masks should not occlude
https://bugs.webkit.org/show_bug.cgi?id=85927

Reviewed by James Robinson.

Source/WebCore:

When a surface does not have a mask, we make both it and its reflection
occlude the things below them. However, if the reflection has a mask
applied to it, then we should not consider it as occluding.

Adds replicaHasMask() to the render surface classes so we can test if
the mask is present.

Unit Tests: CCOcclusionTrackerTestReplicaWithMask

platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::RenderSurfaceChromium::replicaHasMask):

platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToTargetRenderSurface):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::CCRenderSurface::replicaHasMask):

platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setMask):
(CCOcclusionTrackerTestReplicaWithMask):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests):

5:52 PM Changeset in webkit [116471] by eric@webkit.org

7 edits in trunk

Add stylesheet inheritance support to IFRAME_SEAMLESS
https://bugs.webkit.org/show_bug.cgi?id=85914

Reviewed by Ojan Vafai.

Source/WebCore:

This work is already guarded by IFRAME_SEAMLESS, as
Document::shouldDisplaySeamlesslyWithParent always returns false
when IFRAME_SEAMLESS is off.

This makes the child document use all author stylesheets from all parent documents,
per the seamless spec:
http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-seamless

This support is slightly inefficient as every time a sheet is added
to a parent document, the child document must do a full style selector recalc.
Normally author sheet additions have a fast-path which avoids the full selector recalc,
but such is not possible in the seamless case as we're inserting the parents sheets
earlier in the child's cascade (instead of just appending them to the end of the list).

The test covers both the static inheritance as well as addition of a stylesheet
to the parent and testing that it caused a recalc of the child.

Covered by fast/frames/seamless/seamless-css-cascade.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore):

css/StyleResolver.h:

(StyleResolver):

dom/Document.cpp:

(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore):
(WebCore::Document::notifySeamlessChildDocumentsOfStylesheetUpdate):
(WebCore::Document::updateActiveStylesheets):

dom/Document.h:

(Document):

LayoutTests:

Update the results (for both static and dynamic inheritance)
now that this support is landed.

fast/frames/seamless/seamless-css-cascade-expected.txt:

5:42 PM Changeset in webkit [116470] by rakuco@webkit.org

5 edits in trunk

[EFL] Pass a WTF::String directly from DRT to ewebkit when possible
https://bugs.webkit.org/show_bug.cgi?id=84634

Reviewed by Gustavo Noronha Silva.

Drop unnecessary const char* -> WTF::String conversions by
creating String objects directly in LayoutTestController out of
JSStringRef's and passing them to DumpRenderTreeSupportEfl.

Source/WebKit/efl:

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::findString):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):
(LayoutTestController::setValueForUser):
(LayoutTestController::findString):
(LayoutTestController::addUserStyleSheet):

5:41 PM WikiStart edited by hayato@chromium.org

(diff)

5:40 PM WikiStart edited by hayato@chromium.org

(diff)

5:24 PM Changeset in webkit [116469] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Can't scroll PDF in subframe
https://bugs.webkit.org/show_bug.cgi?id=85932
<rdar://problem/11405527>

Reviewed by Sam Weinig.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::updateScrollbars):
Trigger a layout when scrollbars come and go so the non fast scrollable region gets recomputed.

(WebKit::BuiltInPDFView::scrollableAreaBoundingBox):
Implement this by calling out to the PluginView.

5:02 PM Changeset in webkit [116468] by rakuco@webkit.org

4 edits in trunk

[CMake] FindGStreamer: Fix the build with static WebCore.
https://bugs.webkit.org/show_bug.cgi?id=85930

Reviewed by Daniel Bates.

Building WebCore statically was failing because files in
WebCore/platform/gstreamer when ENABLE_VIDEO was set required
gstreamer-base, which was not being linked to after r116453.

Fix that by looking for gstreamer-base, requiring and linking
against it if GStreamer is used.

Source/cmake/FindGStreamer.cmake:

Source/WebCore:

No new tests, build fix.

Building WebCore statically was failing because files in
WebCore/platform/gstreamer when ENABLE_VIDEO was set required
gstreamer-base, which was not being linked to after r116453.

Fix that by looking for gstreamer-base, requiring and linking
against it if GStreamer is used.

PlatformEfl.cmake: Link to GSTREAMER_LIBRARIES and

GSTREAMER_BASE_LIBRARIES, and include GSTREAMER_INCLUDE_DIRS and
GSTREAMER_BASE_INCLUDE_DIRS.

4:55 PM Changeset in webkit [116467] by fpizlo@apple.com

17 edits in branches/dfgopt/Source/JavaScriptCore

DFG should support op_get_argument_by_val and op_get_arguments_length
https://bugs.webkit.org/show_bug.cgi?id=85911

Reviewed by Oliver Hunt.

This adds a simple and relatively conservative implementation of op_get_argument_by_val
and op_get_arguments_length. We can optimize these later. For now it's great to have
the additional coverage.

This patch appears to be perf-neutral.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

4:50 PM Changeset in webkit [116466] by jonlee@apple.com

3 edits in trunk/Source/WebKit2

[WK2] Push wheel events if there are too many in queue
https://bugs.webkit.org/show_bug.cgi?id=85747
<rdar://problem/11390790>

Reviewed by Anders Carlsson.

It is possible that a whole bunch of messages added to the message queue, or a series
of long-running messages, cause unresponsiveness. The reason for this is that we have
a scroll event waiting for acknowledgment from the web process before it sends the next
event. And in the time between the user has scrolled, causing a large backlog of scroll
events to be held in the UI process.

We should push new scroll events if the queue accumulates too many of them.

UIProcess/WebPageProxy.h: The vector m_currentlyProcessedWheelEvents used to hold the

series of wheel events that were coalesced and sent as a single wheel event to the web
process. When the web process acknowledges this with didReceiveEvent, the UI process
cleared that vector, then tried to coalesce the next wheel event to send. Now we might have
multiple sets of coalesced wheel events that we are sending to the web process. To keep
track of these sets, m_currentlyProcessedWheelEvents now is a queue of Vectors.
(WebPageProxy):

UIProcess/WebPageProxy.cpp: Add new constant wheelEventQueueSizeThreshold representing

the threshold of scroll events to look for before we start pushing events.
(WebKit::canCoalesce): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::coalesce): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::coalescedWheelEvent): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::WebPageProxy::handleWheelEvent): If we are currently waiting for acknowledgment
from the web process that a wheel event has been handled, we add it to the queue. We
check to see that the queue size is within our threshold before we return early. Otherwise
we will start pushing events in the queue. Refactor the rest of the function into
processNextQueuedWheelEvent() and sendWheelEvent(). If we are not currently waiting for
acknowledgment, nor have events in the queue, then we send the current wheel event.
(WebKit::WebPageProxy::processNextQueuedWheelEvent): Try to coalesce events based on the
wheel event at the head of the queue, and send that event to the web process.
(WebKit::WebPageProxy::sendWheelEvent): Refactored from handleWheelEvent().
(WebKit::WebPageProxy::didReceiveEvent): Instead of clearing m_currentlyProcessedWheelEvents,
which contained the set of one coalesced wheel event, we pull the head Vector, which
contains the same set of events. Refactor to use processNextQueuedWheelEvent().

4:24 PM Changeset in webkit [116465] by commit-queue@webkit.org

3 edits
2 adds in trunk

JavaScriptAudioNode should not ASSERT if number of input channels is 0
https://bugs.webkit.org/show_bug.cgi?id=85818

Patch by Raymond Toy <Raymond Toy> on 2012-05-08
Reviewed by Eric Seidel.

Source/WebCore:

Test: webaudio/javascriptaudionode-zero-input-channels.html

Modules/webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::process): Update buffersAreGood.
(WebCore::JavaScriptAudioNode::fireProcessEvent): Remove ASSERT.

LayoutTests:

webaudio/javascriptaudionode-zero-input-channels-expected.txt: Added.
webaudio/javascriptaudionode-zero-input-channels.html: Added.

4:21 PM Changeset in webkit [116464] by commit-queue@webkit.org

4 edits
1 add in trunk

[EFL][DRT] EventSender needs implementation of leapForward function
https://bugs.webkit.org/show_bug.cgi?id=83486

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08
Reviewed by Eric Seidel.

Tools:

Implemented leapForward function in Efl's DRT. This function is required
to delay and queue event execution and simulate real user behavior.

DumpRenderTree/efl/EventSender.cpp:

(DelayedEvent):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(sendClick):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):
(leapForwardCallback):
(mouseScrollByCallback):
(feedOrQueueMouseEvent):
(feedMouseEvent):
(feedQueuedMouseEvents):

LayoutTests:

Unskipping few tests that were failing due to the missing leapForward function
Added EFL specific test result, since EFL doesnt support 2D wheel events

platform/efl/Skipped:
platform/efl/fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.

4:01 PM Changeset in webkit [116463] by danakj@chromium.org

4 edits in trunk/Source

Region reads past end of spans
https://bugs.webkit.org/show_bug.cgi?id=85909

Reviewed by Anders Carlsson.

Source/WebCore:

Region currently checks aSpan == aSpanEnd as the indicator that
we passed all the spans. When aSpan < aSpanEnd, it uses aSpan+1
to find the height of the span.

If aSpan == aSpanEnd - 1, then aSpan+1 == aSpanEnd. This does not
represent a valid span, since aSpanEnd is past the end of the
array, not the last element in the array. The loop should terminate
in this case.

Checking aSegment != aSegmentEnd is acceptable in the inner loop since
it increments by two each time (segments come in pairs, while spans
come in singles).

Test: RegionTest.ReadPastFullSpanVectorInIntersectsTest

platform/graphics/Region.cpp:

(WebCore::Region::Shape::compareShapes):

Source/WebKit/chromium:

tests/RegionTest.cpp:

(WebCore::TEST):
(WebCore):

4:01 PM Changeset in webkit [116462] by commit-queue@webkit.org

3 edits
2 adds in trunk/Source/WebKit

Source/WebKit: [BlackBerry] Implement a popup client for HTML controls
https://bugs.webkit.org/show_bug.cgi?id=85670

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08
Reviewed by Rob Buis.

Add popup client file to build system.

PlatformBlackBerry.cmake:

Source/WebKit/blackberry: [BlackBerry] Implement a popup client for HTML controls

https://bugs.webkit.org/show_bug.cgi?id=85670

Reviewed by Rob Buis.

Implement a popup client for HTML controls, which would be used to load
different popups according to popup type.

WebCoreSupport/PagePopupBlackBerry.cpp: Added. (WebCore): (PagePopupChromeClient): (WebCore::PagePopupChromeClient::PagePopupChromeClient): (WebCore::PagePopupChromeClient::closeWindowSoon): (WebCore::PagePopupChromeClient::webPage): (WebCore::PagePopupBlackBerry::PagePopupBlackBerry): (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry): (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest): (WebCore::PagePopupBlackBerry::init): (WebCore::setValueAndClosePopupCallback): (WebCore::popUpExtensionInitialize): (WebCore::popUpExtensionFinalize): (WebCore::PagePopupBlackBerry::installDomFunction): (WebCore::PagePopupBlackBerry::handleMouseEvent): (WebCore::PagePopupBlackBerry::closePopup): (WebCore::PagePopupBlackBerry::closeWebPage):
WebCoreSupport/PagePopupBlackBerry.h: Added. (WebKit): (WebCore): (PagePopupBlackBerry):

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08

3:50 PM Changeset in webkit [116461] by ryuan.choi@samsung.com

2 edits in trunk/Tools

[EFL][DRT] WebKit/DRT should not paint webview for the pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=79853

Reviewed by Eric Seidel.

Screen buffer can be different from rendered results.
For example, WebKit/Efl just moves tiles for ewk_view_tiled when scrolling
contents.
It means that pixel tests can't check regression of ewk_view_tiled.

This patch changes a way to provide bitmap from painting webview to capturing
evas.

DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

3:45 PM Changeset in webkit [116460] by tony@chromium.org

3 edits
3 adds in trunk/Source/WebKit/chromium

move listener_leak_test to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85922

Reviewed by Ojan Vafai.

Porting the test from src/webkit/tools/test_shell/listener_leak_test.cc.
All I did was change the style and use the FrameTestHelper to load the file.

WebKit.gyp: Exclude file in components build.
WebKit.gypi: Add new file.
tests/ListenerLeakTest.cpp: Added.

(WebKit):
(WebKit::GetProperty):
(WebKit::GetNumObjects):
(ListenerLeakTest):
(WebKit::ListenerLeakTest::ListenerLeakTest):
(WebKit::ListenerLeakTest::RunTest):
(WebKit::TEST_F):

tests/data/listener/listener_leak1.html: Added.
tests/data/listener/listener_leak2.html: Added.

3:31 PM Changeset in webkit [116459] by oliver@apple.com

1 edit
22 adds in trunk/LayoutTests

Add mac results for new tests following http://trac.webkit.org/changeset/116438.

3:29 PM Changeset in webkit [116458] by pdr@google.com

5 edits
8 adds in trunk

Prevent crash in animated lists
https://bugs.webkit.org/show_bug.cgi?id=85382

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Animated lists blindly assign the last list value to m_toAtEndOfDurationType
in SVGAnimationElement::startedActiveInterval. If the last list value's length
is larger or smaller than the animated "to" length, we crash.

This change prevents accessing values off the end of toAtEndOfDuration by adding
a check for this case. It may seem inefficient to perform this check on every
animation update but the "to" value can change (in cardinality) while animating.

I checked each of the other animation types (e.g., SVGAnimatedAngle,
SVGAnimatedBoolean, etc.) and was only able to hit this style of crash
in the three types modified in this change:
SVGAnimatedLengthList, SVGAnimatedNumberList, and SVGAnimatedPointList.

Tests: svg/animations/animate-linear-discrete-additive-b-expected.svg

svg/animations/animate-linear-discrete-additive-b.svg
svg/animations/animate-linear-discrete-additive-c-expected.svg
svg/animations/animate-linear-discrete-additive-c.svg
svg/animations/animate-linear-discrete-additive-expected.svg
svg/animations/animate-linear-discrete-additive.svg
svg/animations/animate-list-crash.svg

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):

LayoutTests:

svg/animations/animate-linear-discrete-additive-b-expected.svg: Added.
svg/animations/animate-linear-discrete-additive-b.svg: Added.
svg/animations/animate-linear-discrete-additive-c-expected.svg: Added.
svg/animations/animate-linear-discrete-additive-c.svg: Added.
svg/animations/animate-linear-discrete-additive-expected.svg: Added.
svg/animations/animate-linear-discrete-additive.svg: Added.
svg/animations/animate-list-crash-expected.txt: Added.
svg/animations/animate-list-crash.svg: Added.

3:04 PM Changeset in webkit [116457] by rafaelw@chromium.org

3 edits in trunk/Source/WebCore

HTMLElementStack::hasOnlyHTMLElementsInScope is no longer called
https://bugs.webkit.org/show_bug.cgi?id=85908

Reviewed by Eric Seidel.

This patch just removes the dead code.

No tests needed. Cleanup only.

html/parser/HTMLElementStack.cpp:
html/parser/HTMLElementStack.h:

(HTMLElementStack):

2:57 PM Changeset in webkit [116456] by wjmaclean@chromium.org

6 edits
5 adds in trunk/Source

[chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=85084

Reviewed by James Robinson.

Source/WebCore:

Unit test provided.

Creates a layer delegate class to provide link highlight animations for link-preview feature.
These are added to a GraphicsLayerChromium via provided methods. Moves dispensing of animation
ids into a separate class.

WebCore.gypi:
platform/graphics/chromium/AnimationIdVendor.cpp: Added.

(WebCore):
(WebCore::AnimationIdVendor::getNextAnimationId):
(WebCore::AnimationIdVendor::getNextGroupId):

platform/graphics/chromium/AnimationIdVendor.h: Added.

(WebCore):
(AnimationIdVendor):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

platform/graphics/chromium/LinkHighlight.cpp: Added.

(WebCore):
(WebCore::LinkHighlight::create):
(WebCore::LinkHighlight::LinkHighlight):
(WebCore::LinkHighlight::~LinkHighlight):
(WebCore::LinkHighlight::contentLayer):
(WebCore::LinkHighlight::paintContents):
(WebCore::LinkHighlight::notifyAnimationStarted):
(WebCore::LinkHighlight::notifyAnimationFinished):

platform/graphics/chromium/LinkHighlight.h: Added.

(WebCore):
(LinkHighlight):

Source/WebKit/chromium:

WebKit.gypi:
tests/LinkHighlightTest.cpp: Added.

(WebCore):
(MockGraphicsLayerClient):
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TEST):

2:52 PM Changeset in webkit [116455] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

SIGFPE on divide in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=85917

Rubber stamped by Oliver Hunt.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

check for divisor of -1.

2:22 PM Changeset in webkit [116454] by ojan@chromium.org

1 edit
20 copies
44 moves
74 adds in trunk/LayoutTests

Chromium rebaselines after http://trac.webkit.org/changeset/116438.

platform/chromium-linux/css2.1/20110323/first-letter-000-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-dynamic-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003a-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-inherit-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-nested-007-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-quote-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-quote-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-quote-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-quote-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-quote-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png.
platform/chromium-linux/css2.1/20110323/first-letter-quote-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png.
platform/chromium-linux/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png.
platform/chromium-linux/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-000-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
platform/chromium-mac-leopard/fast/css/first-letter-nested-positioned-expected.png: Added.
platform/chromium-mac-leopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-000-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/first-letter-nested-positioned-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-000-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-000-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-001-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-001-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.png: Added.
platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.png: Added.
platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.txt: Added.
platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
platform/chromium-win/css2.1/20110323/first-letter-000-expected.png: Added.
platform/chromium-win/css2.1/20110323/first-letter-000-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt.
platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt.
platform/chromium-win/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
platform/chromium-win/fast/css/first-letter-nested-positioned-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt.
platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt.

1:32 PM Changeset in webkit [116453] by rakuco@webkit.org

7 edits
8 deletes in trunk

[CMake] Rewrite FindGStreamer.cmake.
https://bugs.webkit.org/show_bug.cgi?id=85857

Reviewed by Daniel Bates.

We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.

FindGStreamer.cmake has then been rewritten to take all that into
account:

The LibFindMacros.cmake package is not used anymore.
Version check is performed in the CMake file itself by parsing

the gstversion.h header.

All GStreamer plugins are searched and the COMPONENTS keyword

used in the FIND_PACKAGE() call is used to check which plugins are
required.

The plugins-base and base GStreamer plugins are not searched, as

they were not used anywhere in the build system.

Source/cmake/FindGStreamer-App.cmake: Removed.
Source/cmake/FindGStreamer-Audio.cmake: Removed.
Source/cmake/FindGStreamer-Base.cmake: Removed.
Source/cmake/FindGStreamer-FFT.cmake: Removed.
Source/cmake/FindGStreamer-Interfaces.cmake: Removed.
Source/cmake/FindGStreamer-Pbutils.cmake: Removed.
Source/cmake/FindGStreamer-Plugins-Base.cmake: Removed.
Source/cmake/FindGStreamer-Video.cmake: Removed.
Source/cmake/FindGStreamer.cmake: Rewrite as described above.
Source/cmake/OptionsEfl.cmake: Use COMPONENTS to specify which

GStreamer plugins to look for.

Source/WebCore:

No new tests, build system change.

FindGStreamer.cmake has then been rewritten to take all that into
account:

The LibFindMacros.cmake package is not used anymore.
Version check is performed in the CMake file itself by parsing

the gstversion.h header.

All GStreamer plugins are searched and the COMPONENTS keyword

used in the FIND_PACKAGE() call is used to check which plugins are
required.

The plugins-base and base GStreamer plugins are not searched, as

they were not used anywhere in the build system.

PlatformEfl.cmake: Update GStreamer-related variable names.

Source/WebKit:

FindGStreamer.cmake has then been rewritten to take all that into
account:

The LibFindMacros.cmake package is not used anymore.
Version check is performed in the CMake file itself by parsing

the gstversion.h header.

All GStreamer plugins are searched and the COMPONENTS keyword

used in the FIND_PACKAGE() call is used to check which plugins are
required.

The plugins-base and base GStreamer plugins are not searched, as

they were not used anywhere in the build system.

PlatformEfl.cmake: Update GStreamer-related variable names.

1:24 PM Changeset in webkit [116452] by commit-queue@webkit.org

5 edits in trunk

[EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=85479

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

EFL's PlatformKeyboardEvent::isKeypad() now returns meaningful value.
Added numeric-pad keys to the Key Map and Windows Key Map.

No new tests.

platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):

platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

LayoutTests:

Unskipped fast/events/keydown-numpad-keys.html.

platform/efl/Skipped:

12:44 PM Changeset in webkit [116451] by Nikolas Zimmermann

19 edits
2 adds in trunk

Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation
https://bugs.webkit.org/show_bug.cgi?id=85627

Reviewed by Antti Koivisto.

Source/WebCore:

Example:
<rect width="10" height="100">

<animate attributeName="width" from="10" to="100" begin="2s" dur="4s" fill="remove"/>

</rect>

At t=0s the <animate> element receives its first interval: begin=2s, end=6s.
At this point we've created the 'OwnPtr<SVGAnimatedType> m_animatedType' in
SVGAnimateElement, which holds the current animated value of the target type.
In this example it contains a SVGLength with '10' as value at t=0s.

Calling "rect.width.animVal.value" will return the value currently contained in the
m_animatedType from the SVGAnimateElement, even though the animation didn't begin
yet. This is fine, as the animVal equals to the baseVal, as long as no animation is
running.

At t=6s you'd expect that the whole 'animVal' object is destructed again, as it's no
longer needed, as animVal will be equal to baseVal again, but the current code keeps
the animVal alive, and just resets it to the baseVal. The animVals will be destructed
once the animate element leaves the tree.

CSS animations suffer from the same problem, we never remove the animated SMIL properties
but we only reset them to the base value. This makes integration with CSS Animations and
CSS Transitions harder, so this needs to be changed.

This patch starts tracking the start/end of an animation chain properly, to destruct
the animation effect for non-frozen animations at the end of their duration. This has to
work properly together with seeking (SVGSVGElement.setCurrentTime), as our testing relies
on the ability to drive the SMIL timeline from script.

Tests: svg/animations/list-wrapper-assertion-expected.svg

svg/animations/list-wrapper-assertion.svg

svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::resetAnimatedType):
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
(WebCore::applyCSSPropertyToTargetAndInstances):
(WebCore::removeCSSPropertyFromTargetAndInstances):
(WebCore::notifyTargetAboutAnimValChange):
(WebCore::notifyTargetAndInstancesAboutAnimValChange):
(WebCore::SVGAnimateElement::clearAnimatedType):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::targetElementWillChange):

svg/SVGAnimateElement.h:

(SVGAnimateElement):

svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::resetAnimatedType):
(WebCore::SVGAnimateMotionElement::clearAnimatedType):

svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

svg/SVGAnimationElement.cpp:
svg/SVGAnimationElement.h:
svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::reset):
(WebCore::SVGSMILElement::targetElementWillChange):
(WebCore::SVGSMILElement::determineActiveState):
(WebCore::SVGSMILElement::progress):

svg/animation/SVGSMILElement.h:

(SVGSMILElement):

svg/properties/SVGAnimatedListPropertyTearOff.h:

Remove svgAttributeChanged() calls from animationEnded/animValDidChange.
Callers are now required to notify the target about changes. There are cases
where we want to call animValDidChange without invoking svgAttributeChanged().
That is supported now.

(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):

svg/properties/SVGAnimatedProperty.h: Ditto.

(WebCore::SVGAnimatedProperty::commitChange): Add safety guard.

svg/properties/SVGAnimatedPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animValDidChange):

svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):

LayoutTests:

Update animate-target-id-changed.svg test to match Firefox behavior.
When an animation element with fill="freeze" is changed to a new target
eg, via animate.href = "#someOtherID", the animation effect should be removed.

Add tests for assertions I ran into while developing this patch.

platform/chromium/test_expectations.txt: Require new results for animate-target-id-changed-expected.txt.
platform/mac/svg/custom/animate-target-id-changed-expected.png:
svg/animations/list-wrapper-assertion-expected.svg: Added.
svg/animations/list-wrapper-assertion.svg: Added.
svg/custom/animate-target-id-changed-expected.txt:
svg/custom/animate-target-id-changed.svg:

12:36 PM Changeset in webkit [116450] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebCore

[EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled.
https://bugs.webkit.org/show_bug.cgi?id=81315

Reviewed by Chang Shu.

ScrollbarEfl creates custom scrollbars as separated layer and they are
not related to ScrollbarTheme.
So, DRT/Efl creates custom scrollbars on webview which paints mockScrollbar.

This patch prevents creating custom scrollbars when mockScrollbar is enabled.

Because DRT/Efl only renders the webview now, expected results are same
until Bug 79853 is landed.

platform/efl/ScrollbarEfl.cpp:

(Scrollbar::createNativeScrollbar):

12:33 PM Changeset in webkit [116449] by timothy@apple.com

7 edits in trunk/Source

Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen.

dyld only considers libraries in the versioned framework path if their install name
matches the library that it is attempting to load. The path we were passing to
dlopen lacked the Versions/A component of the path so dyld did not recognize that
we wanted it to use the staged version if it is newer.

<rdar://problem/11406517>

Reviewed by Mark Rowe.

Source/WebCore:

platform/mac/SoftLinking.h: Have SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL take the

framework version as an argument and use it when constructing the path to dlopen.

Source/WebKit/mac:

WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.

Source/WebKit2:

UIProcess/mac/WebInspectorProxyMac.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.

12:26 PM Changeset in webkit [116448] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Unreviewed, rolling out r116440.
http://trac.webkit.org/changeset/116440
https://bugs.webkit.org/show_bug.cgi?id=85904

Broke the Chromium Android bot (Requested by beverloo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08

WTF.gyp/WTF.gyp:

12:16 PM Changeset in webkit [116447] by rafael.lobo@openbossa.org

2 edits in trunk/Source/WebCore

Build fix for Qt Snowleopard Release
https://bugs.webkit.org/show_bug.cgi?id=85895

Reviewed by Alexis Menard.

The enum value JSUint8ClampedArray conflicted with the JSUint8ClampedArray class.
I've added the 'Type' suffix to the enum value to make their names different.

No new tests needed.

bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

12:11 PM Changeset in webkit [116446] by commit-queue@webkit.org

8 edits
2 adds in trunk

offsetLeft broken within CSS3 columns
https://bugs.webkit.org/show_bug.cgi?id=34875

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-08
Reviewed by Julien Chaffraix.

Source/WebCore:

Reimplement offsetLeft and offsetTop in terms of a new method called
'offsetTopLeft'. The new method starts from a reference point (the
top-left coordinate of a box or inline) and adjusts this reference
point for columns as we traverse each parent. Note that the reference
point needs to be adjusted in both dimensions, even though offsetLeft
and offsetTop return only one of them.

A new method called 'offsetForColumns' was added to RenderObject. This
method is similar to adjustForColumns, except that it returns the
offset instead of modifying a reference. This method is necessary to
simplify the implementation of offsetTopLeft.

Tests: fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt

fast/block/positioning/offsetLeft-offsetTop-multicolumn.html

rendering/RenderBox.h:

(RenderBox):
Override offsetLeft and offsetTop.

rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetLeft):
Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
topLeftLocation as startPoint.
(WebCore::RenderBox::offsetTop):
Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
topLeftLocation as startPoint.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::offsetTopLeft):
New method to compute offsetLeft and offsetTop simultaneously, and
adjusting for columns at each parent.
(WebCore::RenderBoxModelObject::offsetLeft):
Reimplemented in terms of offsetTopLeft.
(WebCore::RenderBoxModelObject::offsetTop):
Reimplemented in terms of offsetTopLeft.

rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Declare new offsetTopLeft method.

rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetLeft):
Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.
(WebCore::RenderInline::offsetTop):
Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.

rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::offsetForColumns):
New helper method to simplify implementation of offsetTopLeft.

LayoutTests:

Add test for offsetLeft and offsetTop within multi-columns.

fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Added.
fast/block/positioning/offsetLeft-offsetTop-multicolumn.html: Added.

12:09 PM Changeset in webkit [116445] by rakuco@webkit.org

3 edits in trunk/LayoutTests

[EFL] media/video-play-require-user-gesture.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=85900

Unreviewed gardening.

Move media/video-play-require-user-gesture.html to test_expectations.txt since
it requires Full Screen API support. Also move fullscreen tests from Skipped
list to test_expectations.txt

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08

platform/efl/Skipped:
platform/efl/test_expectations.txt:

12:07 PM Changeset in webkit [116444] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Layout test fast/overflow/lots-of-sibling-inline-boxes.html is flaky in debug builds
https://bugs.webkit.org/show_bug.cgi?id=85896

Unreviewed gardening.

Marking test as slow, since it times-out when executed using debug builds under
heavy processor loads.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08

platform/efl/test_expectations.txt:

12:04 PM Changeset in webkit [116443] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Update Web Timing tests expectations
https://bugs.webkit.org/show_bug.cgi?id=85622

Unreviewed Gardening.

Removed http/tests/misc/webtiming-origins.html and
http/tests/misc/webtiming-ssl from test expectations.
They started to pass after r116160.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08

platform/efl/test_expectations.txt:

11:57 AM Changeset in webkit [116442] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] http/tests/security/cross-frame-access-* tests are failing
https://bugs.webkit.org/show_bug.cgi?id=85899

Unreviewed, move failing tests to test expectations.

http/tests/security/cross-frame-access-* tests are failing because EFL port
does not support showModalDialog. We need to move the test cases to test
expectations while the feature is implemented.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08

platform/efl/test_expectations.txt:

11:51 AM Changeset in webkit [116441] by jchaffraix@webkit.org

1 edit
2 copies in branches/chromium/1084

Merge 115458 - NULL-deref in RenderBox::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=84774

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/inline/crash-new-continuation-with-outline.html

The bug comes from trying to repaint the :after content as part of updateBeforeAfterContent.
The repainting logic would query the yet-to-be-inserted continuation(). Then we would crash in
RenderBox::clippedOverflowRectForRepaint as we didn't have an enclosingLayer() (which any
RenderObject in the tree will have).

The fix is to check in RenderInline::clippedOverflowRectForRepaint that our continuation()
is properly inserted in the tree. We could check that it isRooted() but it's an overkill here.

rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

LayoutTests:

fast/inline/crash-new-continuation-with-outline-expected.txt: Added.
fast/inline/crash-new-continuation-with-outline.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10375053

11:45 AM Changeset in webkit [116440] by abarth@webkit.org

2 edits in trunk/Source/WTF

[Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
https://bugs.webkit.org/show_bug.cgi?id=85897

Reviewed by Tony Chang.

WTF.gyp/WTF.gyp:

11:41 AM UsingGitWithWebKit edited by robert@roberthogan.net

(diff)

11:33 AM Changeset in webkit [116439] by rniwa@webkit.org

3 edits in trunk

perf-o-matic fix attempt for dashboard images.

Rubber-stamped by Antti Koivisto.

Also stop generating images for 30, 90, and 365 days since they have been timing out.

Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):

Websites/webkit-perf.appspot.com/models.py:

(Runs.chart_params):

11:25 AM Changeset in webkit [116438] by robert@webkit.org

5 edits
67 adds in trunk

CSS 2.1 failure: first-letter-nested-004.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72987

Reviewed by Eric Seidel.

Source/WebCore:

When styling first-letter check each sibling and drill into its inlines until we find either (i) a text node
that is not all whitespace, or (ii) a line break.

This makes our rendering of the following tests compatible with FF and Opera. Our current behaviour is also conformant
since the spec allows UAs to style just one element:

css2.1/20110323/first-letter-quote-002.htm
css2.1/20110323/first-letter-quote-003.htm
css2.1/20110323/first-letter-quote-004.htm
css2.1/20110323/first-letter-quote-005.htm

This fixes the following two tests. We now drill into the descendants of an element styled with :first-letter looking
for text to style:

css2.1/20110323/first-letter-nested-004.htm
css2.1/20110323/first-letter-nested-006.htm

This patch changes our rendering of first-letter-dynamic-001.htm as we now render adjacent quotes in the second line as
green. This is consistent with the spec, which allows this behaviour but does not require it. It's the 'right' behaviour
since it is consistent with the rendering of such quotes in a single element with :first-letter style.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::findLastObjectWithFirstLetterText): Iterate through the child's siblings looking for the last

object to be styled :first-letter.

(WebCore::RenderBlock::findLastObjectAfterFirstLetterPunctuation): Style any leading punctuation as first-letter, drill

down into the child's descendants looking for text if necessary.

(WebCore::RenderBlock::updateFirstLetter): Refactor to drill into sibling's children looking for inlines

that should be styled as first-letter.

(WebCore::RenderBlock::addFirstLetter): Split out from updateFirstLetter so that it can be used when a

descendant node inside a sibling is found in findLastObjectWithFirstLetterText() needs to be styled as first-letter.

rendering/RenderBlock.h:

LayoutTests:

css2.1/20110323/first-letter-000.htm: Added.
css2.1/20110323/first-letter-001.htm: Added.
css2.1/20110323/first-letter-dynamic-001.htm: Added.
css2.1/20110323/first-letter-dynamic-002.htm: Added.
css2.1/20110323/first-letter-dynamic-003a.htm: Added.
css2.1/20110323/first-letter-dynamic-003b.htm: Added.
css2.1/20110323/first-letter-inherit-001.htm: Added.
css2.1/20110323/first-letter-nested-001.htm: Added.
css2.1/20110323/first-letter-nested-002.htm: Added.
css2.1/20110323/first-letter-nested-003.htm: Added.
css2.1/20110323/first-letter-nested-004.htm: Added.
css2.1/20110323/first-letter-nested-005.htm: Added.
css2.1/20110323/first-letter-nested-006.htm: Added.
css2.1/20110323/first-letter-nested-007.htm: Added.
css2.1/20110323/first-letter-quote-001.htm: Added.
css2.1/20110323/first-letter-quote-002.htm: Added.
css2.1/20110323/first-letter-quote-003.htm: Added.
css2.1/20110323/first-letter-quote-004.htm: Added.
css2.1/20110323/first-letter-quote-005.htm: Added.
css2.1/20110323/first-letter-quote-006.htm: Added.
fast/css/first-letter-capitalized-edit-select-crash-expected.txt: Rebaselined.
fast/css/first-letter-nested-positioned.htm: Added.

Tests that text nested inside a positioned object is styled.

fast/css/first-letter-quotes-no-content-before-after.html: Added.

Tests that two consecutive quotes, each in a :before and :after pseudo element surrounding
an empty main element, get styled with first letter.

Behold! Pixel Results!

platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png: Added.
platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png: Added.
platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt: Added.
platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.

11:09 AM Changeset in webkit [116437] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Unreviewed, rolling out r116402.
http://trac.webkit.org/changeset/116402
https://bugs.webkit.org/show_bug.cgi?id=85898

Caused a 3% regression on Chromium's bloat-http test on Linux
(Requested by ojan_gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08

WebCore.exp.in:
bindings/v8/RetainedDOMInfo.cpp:
dom/ContainerNode.h:
dom/Node.cpp:

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

dom/Node.h:

(Node):

10:58 AM Changeset in webkit [116436] by commit-queue@webkit.org

3 edits in trunk

[CMake] Add ENABLE_IFRAME_SEAMLESS flag
https://bugs.webkit.org/show_bug.cgi?id=85838

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
Reviewed by Eric Seidel.

Add ENABLE_IFRAME_SEAMLESS flag to CMake and enable it by default.
This flag was introduced by r116356.

Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

10:51 AM Changeset in webkit [116435] by hbono@chromium.org

3 edits
4 adds in trunk

[Chromium] Fix the position of an RTL resizer
https://bugs.webkit.org/show_bug.cgi?id=80640

Reviewed by Tony Chang.

When rendering an RTL resizer, my r110073 renders it at the same position as the
one used for rendering a LTR resizer. Unfortunately, this code renders the RTL
resizer image at an incorrect position on Mac and Linux. This change uses the
correct formula to calculate the position of an RTL resizer.

Source/WebCore:

Test: platform/chromium/scrollbars/rtl-resizer-position.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

LayoutTests:

platform/chromium/platform/chromium/scrollbars: Added.
platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.png: Added.
platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.txt: Added.
platform/chromium/scrollbars/rtl-resizer-position.html: Added.

10:14 AM Changeset in webkit [116434] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Memory leak in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=85886

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-08
Reviewed by Martin Robinson.

Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
JSString created with JSStringCreateWithUTF8CString.

DumpRenderTree/gtk/EventSender.cpp:

(gdkModifersFromJSValue):

10:06 AM Changeset in webkit [116433] by tony@chromium.org

3 edits
2 adds in trunk/Source/WebKit/chromium

[chromium] move event_listener_unittest to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85836

Reviewed by James Robinson.

Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
All I did was change the style and use the FrameTestHelper to load the file.

WebKit.gyp: Exclude file in components build.
WebKit.gypi: Add new file.
tests/EventListenerTest.cpp: Added.

(WebKit):
(TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::~TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::eventCount):
(WebKit::TestWebDOMEventListener::eventAt):
(WebKit::TestWebDOMEventListener::clearEvents):
(WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::SetUp):
(WebKit::WebDOMEventListenerTest::TearDown):
(WebKit::WebDOMEventListenerTest::mainFrame):
(WebKit::WebDOMEventListenerTest::document):
(WebKit::WebDOMEventListenerTest::executeScript):
(WebKit::WebDOMEventListenerTest::GetNodeID):
(WebKit::TEST_F):

tests/data/listener/mutation_event_listener.html: Added.

10:01 AM Changeset in webkit [116432] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] glib dependency needs to be updated in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=85878

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
Reviewed by Martin Robinson.

Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
addresses flakiness in media tests due to possible deadlock with the
following output on stderr:
GStreamer-WARNING : wrong STREAM_LOCK count 0

The bug was fixed upstream by:
http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f

efl/jhbuild.modules:

9:57 AM Changeset in webkit [116431] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests.

platform/qt-5.0/Skipped:

9:27 AM Changeset in webkit [116430] by kling@webkit.org

53 edits in trunk/Source/WebCore

Element: isURLAttribute() should take a const Attribute&.
<http://webkit.org/b/85890>

Reviewed by Anders Carlsson.

Change isURLAttribute(Attribute*) to isURLAttribute(const Attribute&) to enforce
the fact that the Attribute can't be null, and shouldn't be mutated, at compile-time.
Also sprinkle OVERRIDE while we're at it.

dom/Element.cpp:

(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):

dom/Element.h:

(WebCore::Element::isURLAttribute):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendAttribute):

editing/markup.cpp:

(WebCore::completeURLs):

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isURLAttribute):

html/HTMLAnchorElement.h:
html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::isURLAttribute):

html/HTMLBaseElement.h:
html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isURLAttribute):

html/HTMLBodyElement.h:
html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

html/HTMLButtonElement.h:
html/HTMLElement.cpp:

(WebCore::HTMLElement::isURLAttribute):

html/HTMLElement.h:
html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isURLAttribute):

html/HTMLEmbedElement.h:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::isURLAttribute):

html/HTMLFormElement.h:
html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAttribute):

html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::isURLAttribute):

html/HTMLHtmlElement.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isURLAttribute):

html/HTMLImageElement.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

html/HTMLInputElement.h:
html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isURLAttribute):

html/HTMLLinkElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isURLAttribute):

html/HTMLMediaElement.h:
html/HTMLModElement.cpp:

(WebCore::HTMLModElement::isURLAttribute):

html/HTMLModElement.h:
html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isURLAttribute):

html/HTMLObjectElement.h:
html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

html/HTMLParamElement.h:
html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::isURLAttribute):

html/HTMLQuoteElement.h:
html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute):

html/HTMLScriptElement.h:
html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::isURLAttribute):

html/HTMLSourceElement.h:
html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isURLAttribute):

html/HTMLTableCellElement.h:
html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isURLAttribute):

html/HTMLTableElement.h:
html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::isURLAttribute):

html/HTMLTrackElement.h:
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::isURLAttribute):

html/HTMLVideoElement.h:
svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isURLAttribute):

svg/SVGScriptElement.h:

9:21 AM Changeset in webkit [116429] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Over-scroll image should be tiled
https://bugs.webkit.org/show_bug.cgi?id=85860

Patch by Andrew Lo <anlo@rim.com> on 2012-05-08
Reviewed by Rob Buis.

Implement tiling for over-scroll image if image dimension don't match
the surface dimensions.

Api/BackingStore.cpp:

(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):

Api/BackingStore_p.h:

(BackingStorePrivate):

8:53 AM Changeset in webkit [116428] by Csaba Osztrogonác

41 edits
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests, update platform specific expected files.

platform/mac/Skipped:
platform/qt/Skipped:
platform/qt/fast/block/float/016-expected.png:
platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Added.
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
platform/qt/fast/js/constructor-length-expected.txt: Added.
platform/qt/fast/repaint/scale-page-shrink-expected.png: Added.
platform/qt/fast/repaint/scale-page-shrink-expected.txt: Added.
platform/qt/fast/table/027-expected.png:
platform/qt/fast/table/027-expected.txt:
platform/qt/fast/table/027-vertical-expected.png:
platform/qt/fast/table/027-vertical-expected.txt:
platform/qt/tables/mozilla/bugs/bug14929-expected.png:
platform/qt/tables/mozilla/bugs/bug14929-expected.txt:
platform/qt/tables/mozilla/bugs/bug2123-expected.png:
platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
platform/qt/tables/mozilla/bugs/bug2509-expected.png:
platform/qt/tables/mozilla/bugs/bug2509-expected.txt:
platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
platform/qt/tables/mozilla/bugs/bug2947-expected.png:
platform/qt/tables/mozilla/bugs/bug2947-expected.txt:
platform/qt/tables/mozilla/bugs/bug34176-expected.png:
platform/qt/tables/mozilla/bugs/bug34176-expected.txt:
platform/qt/tables/mozilla/bugs/bug44505-expected.png:
platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
platform/qt/test_expectations.txt:

8:46 AM Changeset in webkit [116427] by schenney@chromium.org

2 edits in trunk/Source/WebCore

Shrink ElementAttributeData by factoring out Attr object count.
https://bugs.webkit.org/show_bug.cgi?id=85825

Unreviewed build fix.

dom/ElementAttributeData.cpp:

(WebCore::attrListForElement): Was returning false instead of 0 for a pointer value. Now returns 0.

8:27 AM Changeset in webkit [116426] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][DRT] fast/layers/video-layer.html needs rebaseline after bug85602 landed
https://bugs.webkit.org/show_bug.cgi?id=85873

Unreviewed, EFL gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08

platform/efl/fast/layers/video-layer-expected.txt:

8:24 AM Changeset in webkit [116425] by kareng@chromium.org

1 add in branches/chromium/1130/codereview.settings

adding codereview.settings for easy drovering

8:23 AM Changeset in webkit [116424] by kareng@chromium.org

1 copy in branches/chromium/1130

creating chromium m20 branch

8:20 AM Changeset in webkit [116423] by kling@webkit.org

3 edits in trunk/Source/WebCore

Element: Merge idAttributeChanged() into attributeChanged().
<http://webkit.org/b/85885>

Reviewed by Antti Koivisto.

No new tests, code churn only.

dom/Element.h:
dom/Element.cpp:

(WebCore::Element::attributeChanged): There's no need for this to be a standalone function anymore.

7:59 AM Changeset in webkit [116422] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WK2] Integrate Page Visibility state change and WK2 Suspend/Resume API
https://bugs.webkit.org/show_bug.cgi?id=85650

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.

This patch uses state changes of the Page Visibility API to trigger the
automatic suspension/resume of animations on the WebPage and its main frame,
in the same fashion of what is used by the Suspend/Resume API of WebKit2.
By telling the WebPage it will move off/on the screen and the FrameView to
hide/show, this patch is suspending/resuming animations (animated painting)
but not timers and other active DOM objects.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setVisibilityState):

7:42 AM Changeset in webkit [116421] by commit-queue@webkit.org

2 edits
7 adds in trunk/LayoutTests

[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=85875

Unreviewed, add EFL baselines for the tests which are missing expected
results.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-08

platform/efl/fast/css/first-line-text-decoration-expected.png: Added.
platform/efl/fast/css/first-line-text-decoration-expected.txt: Added.
platform/efl/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/efl/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
platform/efl/fast/images/png-suite/test-expected.png: Added.
platform/efl/fast/images/png-suite/test-expected.txt: Added.
platform/efl/test_expectations.txt:

7:12 AM Changeset in webkit [116420] by kenneth@webkit.org

3 edits
1 add in trunk/Source/WebKit2

[Qt] Add QML/WK2 evaluateJavaScript experimental API
https://bugs.webkit.org/show_bug.cgi?id=85496

Reviewed by Simon Hausmann.

This is an initial patch adding support for strings,
numbers and bools as return values.

Test: qmltests/WebView/tst_evaluateJavaScript.qml

UIProcess/API/qt/qquickwebview.cpp:

(JSCallbackClosure):
(toQString):
(toQJSValue):
(buildQJSValue):
(javaScriptCallback):
(QQuickWebViewExperimental::evaluateJavaScript):
(QQuickWebView::runJavaScriptInMainFrame):

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Added.

7:09 AM Changeset in webkit [116419] by kling@webkit.org

4 edits in trunk/Source/WebCore

Shrink ElementAttributeData by factoring out Attr object count.
<http://webkit.org/b/85825>

Reviewed by Antti Koivisto.

Stop tracking the number of Attr objects that point to a given Element on the
Element itself and manage this by having a global hashmap of Element => AttrList,
where AttrList is a vector of (pointers to) the associated Attr objects.

This shrinks ElementAttributeData by one integer, effectively reducing memory
consumption by ~530kB when viewing the full HTML5 spec at <http://whatwg.org/c>.

dom/ElementAttributeData.h:

(ElementAttributeData):

Remove m_attrCount...

dom/Node.h:

(WebCore::Node::hasAttrList):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):

...replacing it with a Node flag that tells us whether there's an Attr
object map for this Node (only applies to Elements.)

dom/ElementAttributeData.cpp:

(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttributesFromElement):

Map Element => per-Element AttrList in a global hash.

7:02 AM Changeset in webkit [116418] by commit-queue@webkit.org

5 edits in trunk/Source

[Blackberry] remove m_isRequestedByPlugin in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=84559

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-08
Reviewed by Antonio Gomes.

Source/WebCore:

ResourceRequest is a network level abstraction, and it should
not know anything about web concepts such as plug-ins, and Blackberry
does not need m_isRequestedByPlugin any longer, So clean up all related
code.

Tested on a website of http://edition.cnn.com, a new window should be
opened only when user has a singe tap gesture on a plugin element.

platform/network/blackberry/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(ResourceRequest):
(CrossThreadResourceRequestData):

platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

Source/WebKit/blackberry:

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):

7:00 AM Changeset in webkit [116417] by alexis.menard@openbossa.org

4 edits in trunk

[Qt] Unbreak debugging of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85839

Reviewed by Simon Hausmann.

Source/WebKit2:

When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (<7.0) but not with newer
versions where the behavior of pause() is correct.

qt/MainQt.cpp:

(sigcontHandler):
(main):

Tools:

WebKitTestRunner/qt/main.cpp:

(sigcontHandler):
(main):

6:57 AM Changeset in webkit [116416] by commit-queue@webkit.org

6 edits in trunk

[EFL][DRT] EFL's DRT does not fully support page visibility
https://bugs.webkit.org/show_bug.cgi?id=85032

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
Reviewed by Antonio Gomes.

Tools:

DumpRenderTree/LayoutTestController.cpp:

(resetPageVisibilityCallback): Fix incorrect argumentCount check.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
reset page visibility setting between tests.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setPageVisibility): Add support for "preview"
visibility state.

LayoutTests:

Unskip remaining page visibility test cases now that the functionality
is fully implemented in EFL port.

platform/efl/Skipped:

6:39 AM Changeset in webkit [116415] by gavinp@chromium.org

2 edits in trunk/Tools

[webkit-patch] Return meaningful results from single-result queries.
https://bugs.webkit.org/show_bug.cgi?id=85367

Reviewed by Dirk Pranke.

Sometimes a quicksearch returns a single result by just redirecting to the page for that single
bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
a result list consisting of that one bug.

Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._fetch_bugs_from_advanced_query):

6:37 AM Changeset in webkit [116414] by gavinp@chromium.org

5 edits
4 adds in trunk/Tools

[webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
https://bugs.webkit.org/show_bug.cgi?id=85368

Reviewed by Eric Seidel.

Scripts/webkitpy/common/config/urls.py:
Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzillaQueries.fetch_bugs_matching_quicksearch):

Scripts/webkitpy/common/net/omahaproxy.py: Added.

(OmahaProxy):
(OmahaProxy.init):
(OmahaProxy.set_url):
(OmahaProxy._json_url):
(OmahaProxy._get_json):
(OmahaProxy.get_revisions):

Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.

(MockOmahaProxy):
(MockOmahaProxy.init):
(OmahaProxyTest):
(OmahaProxyTest.test_get_revisions):

Scripts/webkitpy/tool/commands/init.py:
Scripts/webkitpy/tool/commands/bugsearch.py:

(BugSearch):

Scripts/webkitpy/tool/commands/chromechannels.py: Added.

(ChromeChannels):
(init):
(execute):

Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.

(MockOmahaProxy):
(MockOmahaProxy.get_revisions):
(TestableChromeChannels):
(TestableChromeChannels.init):
(ChromeChannelsTest):
(ChromeChannelsTest.test_single_bug):
(ChromeChannelsTest.test_with_query):

6:32 AM Changeset in webkit [116413] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
https://bugs.webkit.org/show_bug.cgi?id=84588

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-08
Reviewed by Eric Seidel.

In ewk_frame_contents_alternate_set, param unreachableUri is required, must not be 0.
In ewk_view_zoom_range_set, function returns EINA_FALSE only on failure,
not when zoom range is changed.

ewk/ewk_frame.h:
ewk/ewk_view.h:

6:29 AM Changeset in webkit [116412] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix GTK+ unit tests.

gtk/common.py:

(pkg_config_file_variable):

3:04 AM Changeset in webkit [116411] by Csaba Osztrogonác

1 edit
1 delete in trunk/LayoutTests

Unreviewed. Remove an accidentally committed file.

platform/qt/Skipped.orig: Removed.

2:55 AM Changeset in webkit [116410] by Carlos Garcia Campos

3 edits
1 copy in trunk/Tools

[GTK] Google tests that time out are leaked
https://bugs.webkit.org/show_bug.cgi?id=84973

Reviewed by Philippe Normand.

Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
leaving run-gtk-tests as simple wrapper that runs run-api-tests in
a jhbuild environment when jhbuild is available.

Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or

with jhbuild if present.

gtk/common.py:

(pkg_config_file_variable): Generic function to get a variable
from a pkg-config file.
(prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.

gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.

(TestRunner.init): Use common.build_path() to get the programs path.
(TestRunner._lookup_atspi2_binary): Use
common.pkg_config_file_variable() to get the 'exec_prefix'.
(TestRunner._start_accessibility_daemons): Use subprocess.Popen()
directly instead of helper _create_process that has been removed.
(TestRunner._setup_testing_environment): Use subprocess.Popen()
directly instead of helper _create_process that has been
removed. Use common.top_level_path() and common.build_path()
instead of custom methods that have been removed too.
(TestRunner._run_test_command): Use subprocess.Popen() directly
instead of helper _create_process that has been removed.

2:50 AM Changeset in webkit [116409] by Csaba Osztrogonác

49 edits
4 copies
115 adds in trunk/LayoutTests

[Qt] Unskip now passing tests and update platform specific expected files.

Patch by János Badics <János Badics> on 2012-05-08
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:
platform/qt/Skipped.orig: Copied from LayoutTests/platform/qt/Skipped.
platform/qt/editing/pasteboard/paste-text-014-expected.png: Added.
platform/qt/fast/block/float/editable-text-overlapping-float-expected.png: Added.
platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
platform/qt/fast/block/float/multiple-float-positioning-expected.png: Added.
platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
platform/qt/fast/block/margin-collapse/103-expected.png: Added.
platform/qt/fast/block/margin-collapse/103-expected.txt: Added.
platform/qt/fast/block/positioning/absolute-in-inline-ltr-2-expected.png: Added.
platform/qt/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
platform/qt/fast/block/positioning/absolute-in-inline-rtl-2-expected.png: Added.
platform/qt/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
platform/qt/fast/block/positioning/absolute-in-inline-rtl-3-expected.png: Added.
platform/qt/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
platform/qt/fast/block/positioning/auto/006-expected.png: Added.
platform/qt/fast/block/positioning/auto/006-expected.txt:
platform/qt/fast/css/apple-prefix-expected.png: Added.
platform/qt/fast/css/apple-prefix-expected.txt:
platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
platform/qt/fast/css/color-correction-backgrounds-and-text-expected.txt: Added.
platform/qt/fast/css/ex-after-font-variant-expected.png: Added.
platform/qt/fast/css/ex-after-font-variant-expected.txt:
platform/qt/fast/css/percentage-non-integer-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
platform/qt/fast/css/percentage-non-integer-expected.txt:
platform/qt/fast/css/positioned-overflow-scroll-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Added.
platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
platform/qt/fast/dynamic/008-expected.png: Added.
platform/qt/fast/dynamic/008-expected.txt:
platform/qt/fast/forms/box-shadow-override-expected.png: Added.
platform/qt/fast/forms/box-shadow-override-expected.txt:
platform/qt/fast/forms/disabled-select-change-index-expected.png: Added.
platform/qt/fast/forms/disabled-select-change-index-expected.txt:
platform/qt/fast/forms/file/file-input-direction-expected.png: Added.
platform/qt/fast/forms/file/file-input-direction-expected.txt:
platform/qt/fast/forms/file/file-input-disabled-expected.png: Added.
platform/qt/fast/forms/file/file-input-disabled-expected.txt:
platform/qt/fast/forms/form-element-geometry-expected.png: Added.
platform/qt/fast/forms/form-element-geometry-expected.txt:
platform/qt/fast/forms/input-disabled-color-expected.png: Added.
platform/qt/fast/forms/input-disabled-color-expected.txt:
platform/qt/fast/forms/input-text-click-outside-expected.png: Added.
platform/qt/fast/forms/input-text-click-outside-expected.txt: Added.
platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
platform/qt/fast/forms/negativeLineHeight-expected.png: Added.
platform/qt/fast/forms/negativeLineHeight-expected.txt:
platform/qt/fast/forms/placeholder-pseudo-style-expected.png: Added.
platform/qt/fast/forms/placeholder-pseudo-style-expected.txt: Added.
platform/qt/fast/forms/range/slider-padding-expected.png: Added.
platform/qt/fast/forms/range/slider-padding-expected.txt: Added.
platform/qt/fast/forms/tabbing-input-iframe-expected.png: Added.
platform/qt/fast/forms/tabbing-input-iframe-expected.txt: Added.
platform/qt/fast/forms/textAreaLineHeight-expected.png: Added.
platform/qt/fast/forms/textAreaLineHeight-expected.txt: Added.
platform/qt/fast/forms/textarea-align-expected.png: Added.
platform/qt/fast/forms/textarea-align-expected.txt:
platform/qt/fast/forms/textarea-scrollbar-expected.png: Added.
platform/qt/fast/forms/textarea-scrollbar-expected.txt: Added.
platform/qt/fast/forms/textarea-scrolled-type-expected.png: Added.
platform/qt/fast/forms/textarea-scrolled-type-expected.txt: Added.
platform/qt/fast/forms/textarea-setinnerhtml-expected.png: Added.
platform/qt/fast/forms/textarea-setinnerhtml-expected.txt:
platform/qt/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
platform/qt/fast/inline/inline-borders-with-bidi-override-expected.txt:
platform/qt/fast/invalid/016-expected.png: Added.
platform/qt/fast/invalid/016-expected.txt:
platform/qt/fast/invalid/missing-end-tag-expected.png: Added.
platform/qt/fast/invalid/missing-end-tag-expected.txt: Added.
platform/qt/fast/layers/scroll-rect-to-visible-expected.png: Added.
platform/qt/fast/layers/scroll-rect-to-visible-expected.txt:
platform/qt/fast/overflow/003-expected.png: Added.
platform/qt/fast/overflow/003-expected.txt:
platform/qt/fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
platform/qt/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
platform/qt/fast/overflow/image-selection-highlight-expected.png: Added.
platform/qt/fast/overflow/image-selection-highlight-expected.txt:
platform/qt/fast/overflow/overflow-rtl-expected.png: Added.
platform/qt/fast/overflow/overflow-rtl-expected.txt: Added.
platform/qt/fast/overflow/overflow-x-y-expected.png: Added.
platform/qt/fast/overflow/overflow-x-y-expected.txt: Added.
platform/qt/fast/overflow/scrollRevealButton-expected.png: Added.
platform/qt/fast/overflow/scrollRevealButton-expected.txt: Added.
platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
platform/qt/fast/parser/entity-comment-in-textarea-expected.png: Added.
platform/qt/fast/parser/entity-comment-in-textarea-expected.txt: Added.
platform/qt/fast/parser/open-comment-in-textarea-expected.png: Added.
platform/qt/fast/parser/open-comment-in-textarea-expected.txt: Added.
platform/qt/fast/repaint/button-spurious-layout-hint-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt: Added.
platform/qt/fast/repaint/control-clip-expected.png: Added.
platform/qt/fast/repaint/control-clip-expected.txt:
platform/qt/fast/repaint/flexible-box-overflow-expected.png: Added.
platform/qt/fast/repaint/flexible-box-overflow-expected.txt: Added.
platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.txt: Added.
platform/qt/fast/repaint/focus-ring-expected.png: Added.
platform/qt/fast/repaint/focus-ring-expected.txt: Added.
platform/qt/fast/repaint/inline-block-overflow-expected.png: Added.
platform/qt/fast/repaint/inline-block-overflow-expected.txt: Added.
platform/qt/fast/repaint/inline-outline-repaint-expected.png: Added.
platform/qt/fast/repaint/inline-outline-repaint-expected.txt:
platform/qt/fast/repaint/layer-child-outline-expected.png: Added.
platform/qt/fast/repaint/layer-child-outline-expected.txt: Added.
platform/qt/fast/repaint/layer-outline-expected.png: Added.
platform/qt/fast/repaint/layer-outline-expected.txt: Added.
platform/qt/fast/repaint/layer-outline-horizontal-expected.png: Added.
platform/qt/fast/repaint/layer-outline-horizontal-expected.txt: Added.
platform/qt/fast/repaint/list-marker-expected.png: Added.
platform/qt/fast/repaint/list-marker-expected.txt: Added.
platform/qt/fast/repaint/selection-after-delete-expected.png: Added.
platform/qt/fast/repaint/selection-after-delete-expected.txt:
platform/qt/fast/repaint/selection-after-remove-expected.png: Added.
platform/qt/fast/repaint/selection-after-remove-expected.txt:
platform/qt/fast/repaint/selection-clear-expected.png:
platform/qt/fast/repaint/selection-clear-expected.txt:
platform/qt/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
platform/qt/fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
platform/qt/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
platform/qt/fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
platform/qt/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
platform/qt/fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
platform/qt/fast/repaint/text-shadow-expected.png: Added.
platform/qt/fast/repaint/text-shadow-expected.txt: Added.
platform/qt/fast/repaint/text-shadow-horizontal-expected.png: Added.
platform/qt/fast/repaint/text-shadow-horizontal-expected.txt: Added.
platform/qt/fast/replaced/border-radius-clip-expected.png: Added.
platform/qt/fast/replaced/border-radius-clip-expected.txt: Added.
platform/qt/fast/replaced/width100percent-textarea-expected.png: Added.
platform/qt/fast/replaced/width100percent-textarea-expected.txt: Added.
platform/qt/fast/table/003-expected.png: Added.
platform/qt/fast/table/003-expected.txt:
platform/qt/fast/table/cell-pref-width-invalidation-expected.png: Added.
platform/qt/fast/table/cell-pref-width-invalidation-expected.txt:
platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
platform/qt/fast/text/basic/003-expected.png: Added.
platform/qt/fast/text/basic/003-expected.txt:
platform/qt/fast/text/cg-vs-atsui-expected.png: Added.
platform/qt/fast/text/cg-vs-atsui-expected.txt:
platform/qt/fast/text/complex-text-opacity-expected.png: Added.
platform/qt/fast/text/complex-text-opacity-expected.txt: Added.
platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.
platform/qt/fast/text/large-text-composed-char-expected.png: Added.
platform/qt/fast/text/large-text-composed-char-expected.txt:
platform/qt/fast/text/letter-spacing-negative-opacity-expected.png: Added.
platform/qt/fast/text/letter-spacing-negative-opacity-expected.txt:
platform/qt/fast/text/line-breaks-after-white-space-expected.png: Added.
platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
platform/qt/fast/text/whitespace/pre-break-word-expected.png: Added.
platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png: Added.
platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
platform/qt/fast/text/word-break-expected.png: Added.
platform/qt/fast/text/word-break-expected.txt:
platform/qt/fast/xsl/xslt-entity-expected.png: Added.
platform/qt/fast/xsl/xslt-entity-expected.txt:

2:43 AM Changeset in webkit [116408] by apavlov@chromium.org

4 edits
2 adds in trunk

Extra line-breaks added when copying from source.
https://bugs.webkit.org/show_bug.cgi?id=85282

Reviewed by Ryosuke Niwa.

Source/WebCore:

The code used to replace any \n by \r\n, even the one that had a preceding \r, resulting in \r\r\n.
This change introduces a check for the preceding \r when replacing \n's.

Test: platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html

platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::replaceNewlinesWithWindowsStyleNewlines):

platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::replaceNewlinesWithWindowsStyleNewlines):

LayoutTests:

platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win-expected.txt: Added.
platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html: Added.

2:28 AM Changeset in webkit [116407] by commit-queue@webkit.org

4 edits in trunk/Tools

[EFL] [DRT] Clear extra views before setting a blank page
https://bugs.webkit.org/show_bug.cgi?id=85608

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.

We need to clear the extra views before setting a blank page,
otherwise it will cause more events interactions and sometimes
trigger a unload(). This was causing frame-crash-with-page-cache.html
to leak events to the next test causing any subsequent test to
fail.

DumpRenderTree/efl/DumpRenderTree.cpp:

(runTest):

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::clearExtraViews):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

2:04 AM Changeset in webkit [116406] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Gardening after 116361. Updated expected result.

Patch by János Badics <János Badics> on 2012-05-08
Reviewed by Csaba Osztrogonác.

platform/qt/fast/js/switch-behaviour-expected.txt:

2:00 AM Changeset in webkit [116405] by abarth@webkit.org

2 edits in trunk/Source/WebCore

OS(ANDROID) JNI AttachCurrentThread take JNIEnv as a parameter, not void
https://bugs.webkit.org/show_bug.cgi?id=85869

Reviewed by Eric Seidel.

According to
http://docs.oracle.com/javase/1.5.0/docs/guide/jni/spec/invocation.html,
AttachCurrentThread takes a JNIEnv rather than a void. Apparently,
most implementations actually take a void. The OS(ANDROID)
implementation, however, actually takes an JNIEnv. This patch
introduces a typedef to give each implementation what it desires.

bridge/jni/JNIUtility.cpp:

(JSC::Bindings::getJNIEnv):

1:59 AM Changeset in webkit [116404] by Csaba Osztrogonác

5 edits in trunk/LayoutTests

Unreviewed gardening. Remove tests from test expectations and
from a Skipped list, because they were disabled by r94327.

platform/efl/Skipped:
platform/gtk/test_expectations.txt:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:

1:42 AM Changeset in webkit [116403] by kbalazs@webkit.org

15 edits in trunk

[Qt] X11 plugins need to be reworked for Qt5+WK1
https://bugs.webkit.org/show_bug.cgi?id=80691

Reviewed by Simon Hausmann.

Implement basic windowless plugin support with Qt5.

Source/api.pri: Need private API's to be able

to use QApplicationPrivate::windowForWidget.

Source/WebCore:

Implement basic windowless plugin support with Qt5.
The solution is the same that has been chosen for
WebKit2. We get the content drawed by the plugin
from the X server as an image, create a QImage
from it and paint it to the window surface with QPainter.
Performance is sufficient for basic video playback.

No new tests, covered by existing plugin tests.

Target.pri:
WebCore.pri:
platform/qt/QWebPageClient.h:

(QWebPageClient):

plugins/PluginView.h:

(PluginView):

plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::isPluginBlacklisted):
Blacklist plugins that are incompatible with Qt5.
The only one I know about currently is skypebuttons
but the list can be extended in the future.
(WebCore):
(WebCore::PluginPackage::load):

plugins/qt/PluginViewQt.cpp:

(X11Environment):
(WebCore):
(WebCore::x11Display):
(WebCore::x11Screen):
(WebCore::rootWindowID):
(WebCore::displayDepth):
(WebCore::syncX):
(WebCore::PluginView::platformPageClient): Added a safe
convenience getter for the QWebpageClient.
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::setFocus):
(WebCore::setupGraphicsExposeEvent):
(WebCore::PluginView::paintUsingXPixmap):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::initXEvent):
(WebCore::PluginView::setXKeyEventSpecificFields):
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::getVisualAndColormap):
Refactored this function to make it more clear
what does it actually do.
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):

Source/WebKit/qt:

Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):
Build fix for Qt5.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin):
Inject the wmode parameter for flash so it will
work in windowless, non-transparent mode which
is the only one we support currently.

WebCoreSupport/PageClientQt.cpp:

(WebCore):
(WebCore::QWebPageClient::ownerWindow):
Added a getter for the top level window so the PluginView
can get it without calling into QtWidgets code.

Tools:

Implement basic windowless plugin support with Qt5.

qmake/mkspecs/features/features.prf:

Enable NPAPI plugins if X11 libraries are available.

qmake/mkspecs/features/functions.prf:

Added a convenience function to determine availability
of X11 libraries.

1:31 AM Changeset in webkit [116402] by Antti Koivisto

6 edits in trunk/Source/WebCore

Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops. Also added separate versions of stayWithin and unscoped cases (the function is
so simple that this seemed like the cleanest way to do it, the most reliable too) and used UNLIKELY for the
end-of-traversal conditions.

The traversal function can show up to ~1% in normal page loading profiles.

run-perf-tests seems to think this is a progression in some subtests though bots will tell for certain.

WebCore.exp.in:
dom/ContainerNode.h:

Following the existing pattern, function bodies go to ContainerNode.h so they can call parentNode().
(which returns ContainerNode, not Node).

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

dom/Node.cpp:

(WebCore):

dom/Node.h:

(Node):

12:34 AM Changeset in webkit [116401] by abarth@webkit.org

2 edits in trunk/Source/WTF

[Chromium] Assertions.cpp should work on OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=85867

Reviewed by Eric Seidel.

Some minor ifdefs for OS(ANDROID) on PLATFORM(CHROMIUM).

wtf/Assertions.cpp:

12:05 AM Changeset in webkit [116400] by commit-queue@webkit.org

3 edits
2 adds in trunk/Source/WebKit

[BlackBerry] AutofillManager implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85576

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-08
Reviewed by Rob Buis.

Source/WebKit:

Added WebKit/blackberry/WebCoreSupport/AutofillManager.cpp
into building system of BlackBerry porting.

PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

RIM PR: 136405
Implemented class AutofillManager to handle the form autofill
interactions.
It listens to text changed notification from text input, searches
autofill database for the suggested autofill candidate value,
and notifies WebPageClient to pop up a context dialog for user;
it also responds to user's choice by autofilling the text input.

WebCoreSupport/AutofillManager.cpp: Added.

(WebCore):
(WebCore::AutofillManager::create):
(WebCore::AutofillManager::didChangeInTextField):
(WebCore::AutofillManager::autofillTextField):
(WebCore::AutofillManager::saveTextFields):
(WebCore::AutofillManager::clear):

WebCoreSupport/AutofillManager.h: Added.

(WTF):
(WebKit):
(WebCore):
(AutofillManager):
(WebCore::AutofillManager::m_element):

May 7, 2012:

11:59 PM Changeset in webkit [116399] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chormium] Test expectatino update

platform/chromium/test_expectations.txt:
- multiline-pack.html is failing on all DEBUG bots.
- filter-repaint-custom-rotated.html fails on Mac.

11:56 PM Changeset in webkit [116398] by pfeldman@chromium.org

5 edits in trunk

Web Inspector: make JavaScriptSourceFrame use breakpoint manager's breakpoints store.
https://bugs.webkit.org/show_bug.cgi?id=85714

Reviewed by Yury Semikhatsky.

It is currently using its own copy of breakpoints which is not necessary.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._innerSetBreakpoint):
(WebInspector.BreakpointManager.prototype.findBreakpoint):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._restoreBreakpoints):
(set WebInspector.BreakpointManager.Storage.Item):

inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
(WebInspector.JavaScriptSourceFrame.prototype._updateBreakpointsAfterLiveEdit):

11:30 PM Changeset in webkit [116397] by pfeldman@chromium.org

5 edits in trunk

Web Inspector: do not create locations for resolved provisional breakpoints
https://bugs.webkit.org/show_bug.cgi?id=85716

Reviewed by Yury Semikhatsky.

Source/WebCore:

Marked provisional breakpoints as such.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):

LayoutTests:

inspector/debugger/breakpoint-manager-expected.txt:
inspector/debugger/breakpoint-manager.html:

10:59 PM Changeset in webkit [116396] by commit-queue@webkit.org

3 edits in trunk

Adjust flakiness dashboard gpu_tests image diff URLs.
https://bugs.webkit.org/show_bug.cgi?id=85423

Patch by Dave Tu <dtu@chromium.org> on 2012-05-07
Reviewed by Ojan Vafai.

Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:

10:45 PM Changeset in webkit [116395] by Simon Fraser

3 edits
3 adds in trunk

Compositing layers with transformed children not large enough to show contents
https://bugs.webkit.org/show_bug.cgi?id=85855

Source/WebCore:

Reviewed by Dan Bernstein.

r114518 added a code path to RenderLayer::calculateLayerBounds() which
does an early return if the layer has clipping. However, this code
path omitted to take local transforms into account.

Fix is to handle transforms as we do in the non-clipped case.

Test: compositing/geometry/bounds-clipped-composited-child.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds):

LayoutTests:

Reviewed by Dan Bernstein.

Test having composited element with clipped, transformed children.

compositing/geometry/bounds-clipped-composited-child-expected.png: Added.
compositing/geometry/bounds-clipped-composited-child-expected.txt: Added.
compositing/geometry/bounds-clipped-composited-child.html: Added.

10:14 PM Changeset in webkit [116394] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix signed/unsigned mismatch
https://bugs.webkit.org/show_bug.cgi?id=85845

Make literal in assert be unsigned to match comparison on LHS. Avoids
warning on Windows.

Patch by Scott Graham <scottmg@chromium.org> on 2012-05-07
Reviewed by Eric Seidel.

No new tests. No intended functionality change.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):

10:00 PM Changeset in webkit [116393] by kinuko@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed build fix: didOpenFileSystem hides overloaded virtual function

src/WorkerAsyncFileSystemChromium.cpp:

9:12 PM Changeset in webkit [116392] by eae@chromium.org

6 edits in trunk/Source/WebCore

Fix performance regression for floats caused by LayoutUnit change
https://bugs.webkit.org/show_bug.cgi?id=85834

Reviewed by Eric Seidel.

Fix performance regression caused by r116009 by disabling the use of
64bit math in FractionalLayoutUnit, simplifying the pixelSnappedMaxX/Y
math, inlining a couple of methods and replacing the literal 0 (zero)
with ZERO_LAYOUT_UNIT.

No new tests, no change in functionality.

platform/FractionalLayoutUnit.h:

(WebCore::boundedMultiply):
(WebCore::operator*):
(WebCore::operator/):
Disable the use of 64bit (long long) math in the case where the fraction
is set to 1.

platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::pixelSnappedMaxX):
(WebCore::FractionalLayoutRect::pixelSnappedMaxY):
Simplify the pixel snapping logic for maxX/maxY.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
(WebCore::RenderBlock::addFocusRingRects):
(WebCore::RenderBlock::adjustLinePositionForPagination):

rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::width):
(WebCore::RenderBlock::FloatingObject::height):
(FloatingObject):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):

rendering/RenderBoxModelObject.cpp:

(WebCore::accumulateRelativePositionOffsets):
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):

9:11 PM Changeset in webkit [116391] by kinuko@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed build fix: adding missing include.

src/AsyncFileSystemChromium.cpp:

9:10 PM Changeset in webkit [116390] by tkent@chromium.org

1 edit
6 adds in trunk/LayoutTests

[Chromium] Add expectations for first-line-text-decoration.html.

platform/chromium-linux/fast/css/first-line-text-decoration-expected.png: Added.
platform/chromium-mac-leopard/fast/css/first-line-text-decoration-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/first-line-text-decoration-expected.png: Added.
platform/chromium-mac/fast/css/first-line-text-decoration-expected.png: Added.
platform/chromium-win/fast/css/first-line-text-decoration-expected.png: Added.
platform/chromium-win/fast/css/first-line-text-decoration-expected.txt: Added.

8:49 PM Changeset in webkit [116389] by commit-queue@webkit.org

9 edits
10 adds in trunk

width/height attributes of input element cannot be accessed by JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=70304

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-07
Reviewed by Darin Adler.

If the type of input element is image button, width/height attributes should be supported.
These attributes are defined in HTML5 spec.
http://www.w3.org/TR/html5/the-map-element.html#attr-dim-width

Source/WebCore:

Tests: fast/forms/input-width-height-attributes-without-renderer-loaded-image.html

fast/forms/input-width-height-attributes-without-renderer-not-loaded-image.html
fast/forms/input-width-height-attributes-without-renderer.html
fast/forms/input-width-height-attributes.html

html/HTMLInputElement.cpp: Add setter/getter functions to query/set width/height of input element.

(WebCore):
(WebCore::HTMLInputElement::height): Gets height of input element.
(WebCore::HTMLInputElement::width): Gets width of input element.
(WebCore::HTMLInputElement::setHeight): Sets height of input element.
(WebCore::HTMLInputElement::setWidth): Sets width of input element.

html/HTMLInputElement.h: Add public prototype.

(HTMLInputElement):

html/HTMLInputElement.idl: Add width/height attributes.
html/ImageInputType.cpp: Add getter functions if the element is an image button.

(WebCore):
(WebCore::ImageInputType::height): Gets height of input element.
(WebCore::ImageInputType::width): Gets width of input element.

html/ImageInputType.h: Add prototype.

(ImageInputType):

html/InputType.cpp: Add getter functions.

(WebCore::InputType::height): Returns zero.
(WebCore):
(WebCore::InputType::width): Returns zero.

html/InputType.h: Add prototype.

(InputType):

LayoutTests:

fast/forms/input-width-height-attributes-expected.txt: Added.
fast/forms/input-width-height-attributes-without-renderer-expected.txt: Added.
fast/forms/input-width-height-attributes-without-renderer-loaded-image-expected.txt: Added.
fast/forms/input-width-height-attributes-without-renderer-loaded-image.html: Added.
fast/forms/input-width-height-attributes-without-renderer-not-loaded-image-expected.txt: Added.
fast/forms/input-width-height-attributes-without-renderer-not-loaded-image.html: Added.
fast/forms/input-width-height-attributes-without-renderer.html: Added.
fast/forms/input-width-height-attributes.html: Added.
fast/forms/resources/green.jpg: Added.
fast/forms/resources/image-slow.pl: Added.

8:34 PM Changeset in webkit [116388] by kinuko@chromium.org

39 edits
1 copy
1 move
3 adds in trunk

Support cross-filesystem operations in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=84135

Reviewed by David Levin.

Source/WebCore:

Currently we pass Entry's fullPath to AsyncFileSystem layer where
we convert the given path to filesystem URL which includes origin and
filesystem type information, but in that way we cannot handle
cross-filesystem operations (e.g. cross-filesystem copy and move)
well since we end up with always attaching the source filesystem's
origin and type information for argument paths.

This patch does:

change AsyncFileSystem's operation methods not to take entry paths but complete filesystem URLs.
move type and rootURL information from AsyncFileSystem instance into DOMFileSystemBase instance (platform layer to Modules/filesystem layer)
move filesystem-type related code in AsyncFileSystemChromium.cpp into DOMFileSystemChromium.cpp, which implements chromioum-specific DOMFileSystem code.
move platform/FileSystemType.h into Modules/filesystem/FileSystemType.h.
adding FileSystemType.h entry to build files (e.g. WebCore.gypi, WebCore.xcodeproj etc)

Test: fast/filesystem/cross-filesystem-op.html

Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):
(WebCore::DOMFileSystem::DOMFileSystem):
(WebCore::DOMFileSystem::createWriter):
(WebCore::DOMFileSystem::createFile):

Modules/filesystem/DOMFileSystem.h:
Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::DOMFileSystemBase):
(WebCore::DOMFileSystemBase::createFileSystemURL): Added as an internal
implementation of Entry.toURL().
(WebCore::DOMFileSystemBase::getMetadata):
(WebCore::verifyAndGetDestinationPathForCopyOrMove):
(WebCore::DOMFileSystemBase::move):
(WebCore::DOMFileSystemBase::copy):
(WebCore::DOMFileSystemBase::remove):
(WebCore::DOMFileSystemBase::removeRecursively):
(WebCore::DOMFileSystemBase::getParent):
(WebCore::DOMFileSystemBase::getFile):
(WebCore::DOMFileSystemBase::getDirectory):
(WebCore::DOMFileSystemBase::readDirectory):

Modules/filesystem/DOMFileSystemBase.h: Changed to make each

DOMFileSystemBase instance have filesystem type and rootURL (they were
held by AsyncFileSystem previously)
(WebCore::DOMFileSystemBase::create): Changed to take additional parameters.
(WebCore::DOMFileSystemBase::type): Added.(Moved from AsyncFileSystem::type)
(WebCore::DOMFileSystemBase::rootURL): Added.(Moved from AsyncFileSystem::rootURL).

Modules/filesystem/DOMFileSystemSync.cpp:

(WebCore::DOMFileSystemSync::create):
(WebCore::DOMFileSystemSync::DOMFileSystemSync):
(WebCore::DOMFileSystemSync::createFile):
(WebCore::DOMFileSystemSync::createWriter):

Modules/filesystem/DOMFileSystemSync.h:

(WebCore::DOMFileSystemSync::create):

Modules/filesystem/DOMWindowFileSystem.cpp:

(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):

Modules/filesystem/EntryBase.cpp:

(WebCore::EntryBase::toURL):

Modules/filesystem/FileSystemCallbacks.cpp:

(WebCore::FileSystemCallbacks::create):
(WebCore::FileSystemCallbacks::FileSystemCallbacks):
(WebCore::FileSystemCallbacks::didOpenFileSystem):
(WebCore::ResolveURICallbacks::create):
(WebCore::ResolveURICallbacks::ResolveURICallbacks):
(WebCore::ResolveURICallbacks::didOpenFileSystem):

Modules/filesystem/FileSystemCallbacks.h:

(FileSystemCallbacks):
(ResolveURICallbacks):

Modules/filesystem/FileSystemType.h: Renamed from Source/WebCore/platform/FileSystemType.h.
Modules/filesystem/LocalFileSystem.cpp:

(WebCore::openFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

Modules/filesystem/LocalFileSystem.h:
Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

Modules/filesystem/chromium/DOMFileSystemChromium.cpp: Added for chromium-specific

implementation. Almost all of the code is moved from AsyncFileSystemChromium.
(WebCore::DOMFileSystemBase::isValidType):
(WebCore::DOMFileSystemBase::crackFileSystemURL):
(WebCore::DOMFileSystemBase::supportsToURL):
(WebCore::DOMFileSystemBase::createFileSystemURL):
(WebCore::DOMFileSystemChromium::createIsolatedFileSystem):

Modules/filesystem/chromium/DOMFileSystemChromium.h: Added.
Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp:

(WebCore::DataTransferItemFileSystem::webkitGetAsEntry):

Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:

(WebCore::DraggedIsolatedFileSystem::getDOMFileSystem):

WebCore.gypi:
platform/AsyncFileSystem.cpp:

(WebCore::AsyncFileSystem::openFileSystem):

platform/AsyncFileSystem.h:

(AsyncFileSystem):
(WebCore::AsyncFileSystem::AsyncFileSystem):

platform/AsyncFileSystemCallbacks.h:

(WebCore::AsyncFileSystemCallbacks::didOpenFileSystem):

platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):

platform/blackberry/AsyncFileSystemBlackBerry.h:
platform/chromium/PlatformSupport.h:
platform/gtk/AsyncFileSystemGtk.cpp:

(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::move):
(WebCore::AsyncFileSystemGtk::copy):
(WebCore::AsyncFileSystemGtk::remove):
(WebCore::AsyncFileSystemGtk::removeRecursively):
(WebCore::AsyncFileSystemGtk::readMetadata):
(WebCore::AsyncFileSystemGtk::createFile):
(WebCore::AsyncFileSystemGtk::createDirectory):
(WebCore::AsyncFileSystemGtk::fileExists):
(WebCore::AsyncFileSystemGtk::directoryExists):
(WebCore::AsyncFileSystemGtk::readDirectory):
(WebCore::AsyncFileSystemGtk::createWriter):

platform/gtk/AsyncFileSystemGtk.h:

GNUmakefile.list.am: Added FileSystemType.h.
WebCore.gypi: Added FileSystemType.h.
WebCore.vcproj/WebCore.vcproj: Added FileSystemType.h.
WebCore.xcodeproj/project.pbxproj: Added FileSystemType.h.

Source/WebKit/chromium:

This patch does:

move filesystem-type related code out of AsyncFileSystemChromium.cpp (moving into DOMFileSystemChromium.cpp)
change AsyncFileSystemChromium's methods implementation not to take entry paths but complete filesystem URLs.

src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
(WebCore::AsyncFileSystemChromium::move):
(WebCore::AsyncFileSystemChromium::copy):
(WebCore::AsyncFileSystemChromium::remove):
(WebCore::AsyncFileSystemChromium::removeRecursively):
(WebCore::AsyncFileSystemChromium::readMetadata):
(WebCore::AsyncFileSystemChromium::createFile):
(WebCore::AsyncFileSystemChromium::createDirectory):
(WebCore::AsyncFileSystemChromium::fileExists):
(WebCore::AsyncFileSystemChromium::directoryExists):
(WebCore::AsyncFileSystemChromium::readDirectory):
(WebCore::AsyncFileSystemChromium::createWriter):
(WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata):

src/AsyncFileSystemChromium.h:

(WebCore::AsyncFileSystemChromium::create):
(AsyncFileSystemChromium):

src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::createAsyncFileSystem):

src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):

src/WebFileSystemCallbacksImpl.h:

(WebFileSystemCallbacksImpl):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
(WebCore::WorkerAsyncFileSystemChromium::move):
(WebCore::WorkerAsyncFileSystemChromium::copy):
(WebCore::WorkerAsyncFileSystemChromium::remove):
(WebCore::WorkerAsyncFileSystemChromium::removeRecursively):
(WebCore::WorkerAsyncFileSystemChromium::readMetadata):
(WebCore::WorkerAsyncFileSystemChromium::createFile):
(WebCore::WorkerAsyncFileSystemChromium::createDirectory):
(WebCore::WorkerAsyncFileSystemChromium::fileExists):
(WebCore::WorkerAsyncFileSystemChromium::directoryExists):
(WebCore::WorkerAsyncFileSystemChromium::readDirectory):
(WebCore::WorkerAsyncFileSystemChromium::createWriter):
(WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata):

src/WorkerAsyncFileSystemChromium.h:

(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

LayoutTests:

fast/filesystem/cross-filesystem-op-expected.txt: Added.
fast/filesystem/cross-filesystem-op.html: Added.

8:05 PM Changeset in webkit [116387] by rakuco@webkit.org

2 edits in trunk/Tools

[webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
https://bugs.webkit.org/show_bug.cgi?id=85852

Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase._is_server_running_on_all_ports): Revert the part
of r89412 which was a workaround for an issue with Python 2.5 on
Mac 10.5.

7:52 PM Changeset in webkit [116386] by ojan@chromium.org

1 edit
6 adds in trunk/LayoutTests

Chromium rebaselines after http://trac.webkit.org/changeset/116373.
Differences look to just be in platform-specific text rendering.

platform/chromium-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/chromium-mac-leopard/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/chromium-mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/chromium-win/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/chromium-win/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.

7:47 PM Changeset in webkit [116385] by abarth@webkit.org

5 edits in trunk/Source

[Chromium] Android wishes to use an empty implementation if AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=85842

Reviewed by Eric Seidel.

Source/WebCore:

Add proper HAVE(ACCESSIBILITY) ifdefs so that Chromium builds without
accessibility.

accessibility/chromium/AXObjectCacheChromium.cpp:
accessibility/chromium/AccessibilityObjectChromium.cpp:

Source/WTF:

Disable accessibility on OS(ANDROID) for PLATFORM(CHROMIUM).

wtf/Platform.h:

7:22 PM Changeset in webkit [116384] by commit-queue@webkit.org

14 edits
5 adds in trunk

[Web Intents] Flagged-off implementation of an intent tag for registration.
https://bugs.webkit.org/show_bug.cgi?id=73039

Patch by Greg Billock <gbillock@google.com> on 2012-05-07
Reviewed by Adam Barth.

Source/WebCore:

The intent tag is a declarative way for pages to register that they
accept delivery of web intent invocations of particular types. See the
spec at http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html

After discussion on the WhatWG list (see thread at
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-April/035301.html)
the current plan is to combine declarative registration of Web
Intents and protocol/content handlers with this tag. Alternatives
considered were the meta and link tags.

WebCore.gypi:
html/HTMLAttributeNames.in:
html/HTMLElementsAllInOne.cpp:
html/HTMLIntentElement.cpp: Added.

(WebCore::HTMLIntentElement::HTMLIntentElement):
(WebCore::HTMLIntentElement::create):
(WebCore::HTMLIntentElement::insertedIntoDocument):

html/HTMLIntentElement.h: Added.
html/HTMLIntentElement.idl: Added.
html/HTMLTagNames.in:
loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::registerIntentService):

page/DOMWindow.idl:

Source/WebKit/chromium:

The intent tag allows web pages to mark themselves declaratively as accepting
web intent delivery of particular characteristics (action/type).
See the spec at:
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html

WebKit.gyp:
src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::registerIntentService):

src/FrameLoaderClientImpl.h:

6:53 PM Changeset in webkit [116383] by tkent@chromium.org

3 edits
2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r116375.
http://trac.webkit.org/changeset/116375
https://bugs.webkit.org/show_bug.cgi?id=85850

Build break on Chromium-win and Chromium-mac. (Requested by
tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

WebKit.gyp:
WebKit.gypi:
tests/EventListenerTest.cpp: Removed.
tests/data/listener/mutation_event_listener.html: Removed.

6:32 PM Changeset in webkit [116382] by aestes@apple.com

1 edit
2 adds in trunk/LayoutTests

Add platform/mac/ results for new tests added by r116373.

platform/mac/fast/css/first-line-text-decoration-expected.txt: Added.
platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.

6:14 PM Changeset in webkit [116381] by Lucas Forschler

12 edits in tags/Safari-534.57.4

Merge fixes for radars: 11331161, 11331164, 11331169.

6:11 PM Changeset in webkit [116380] by Lucas Forschler

1 copy in tags/Safari-534.57.4

New tag.

6:09 PM Changeset in webkit [116379] by Lucas Forschler

5 edits in branches/safari-534.57-branch/Source

Versioning.

6:08 PM FeatureFlags edited by tkent@chromium.org

Add IFRAME_SEAMLESS (diff)

5:34 PM Changeset in webkit [116378] by fpizlo@apple.com

11 edits in branches/dfgopt/Source/JavaScriptCore

DFG should support op_tear_off_arguments
https://bugs.webkit.org/show_bug.cgi?id=85847

Reviewed by Michael Saboff.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:11 PM Changeset in webkit [116377] by danakj@chromium.org

5 edits in trunk/Source

Region::intersects() and Region::contains() are slow due to copy overhead
https://bugs.webkit.org/show_bug.cgi?id=81076

Reviewed by Anders Carlsson.

Source/WebCore:

Testing contains() and intersects() requires a copy which ends up
invoking a malloc on sufficiently complicated web pages, and slows down
the test unnecessarily. These methods can be done by iterating over the
Region::Shape values rather than making a copy of the entire region and
manipulating it.

This uses Region::Shape::compareShapes() to walk the query regions and
compute the result of the intersects or contains tests without making a
copy.

This change improves the performance of the Region overlap testing for
composited layers, and allows for testing contains() before unite() to
avoid unnecessary copies of the Region when inserting into complex
Regions. With a layout test that has 225 composited layers, and tests
Region.intersects() for 1000 layers above them, this change decreases
the running time of the test by 1.2% by avoiding a copy of the 225
rects each time.

Unit test: RegionTest.intersectsRegion

RegionTest.containsRegion

platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore::Region::intersects):
(WebCore):
(WebCore::Region::Shape::compareShapes):
(Region::Shape::CompareContainsOperation):
(WebCore::Region::Shape::CompareContainsOperation::aOutsideB):
(WebCore::Region::Shape::CompareContainsOperation::bOutsideA):
(WebCore::Region::Shape::CompareContainsOperation::aOverlapsB):
(Region::Shape::CompareIntersectsOperation):
(WebCore::Region::Shape::CompareIntersectsOperation::aOutsideB):
(WebCore::Region::Shape::CompareIntersectsOperation::bOutsideA):
(WebCore::Region::Shape::CompareIntersectsOperation::aOverlapsB):

platform/graphics/Region.h:

(Shape):

Source/WebKit/chromium:

tests/RegionTest.cpp:

(WebCore):
(WebCore::TEST):

5:09 PM Changeset in webkit [116376] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Correct logical error in accessibilityIsIgnored.
https://bugs.webkit.org/show_bug.cgi?id=85828

Patch by David Tseng <dtseng@google.com> on 2012-05-07
Reviewed by Chris Fleizach.

Covered by existing tests.

accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::accessibilityIsIgnored):

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::accessibilityIsIgnored):

5:05 PM Changeset in webkit [116375] by tony@chromium.org

3 edits
3 adds in trunk/Source/WebKit/chromium

[chromium] move event_listener_unittest to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85836

Reviewed by James Robinson.

Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
All I did was change the style and use the FrameTestHelper to load the file.

WebKit.gyp: Exclude file in components build.
WebKit.gypi: Add new file.
tests/EventListenerTest.cpp: Added.

tests/data/listener/mutation_event_listener.html: Added.

4:56 PM Changeset in webkit [116374] by zmo@google.com

7 edits in trunk

vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

html/canvas/WebGLRenderingContext.h: Ditto

(WebGLRenderingContext):

html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

fast/canvas/webgl/index-validation-expected.txt:
fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.

4:39 PM Changeset in webkit [116373] by commit-queue@webkit.org

5 edits
6 adds in trunk

:first-line text-decorations are not rendered
https://bugs.webkit.org/show_bug.cgi?id=6047

Source/WebCore:

Text-decorations are applied during paint phase. The style was not being properly selected in case of
first line box. The patch fixes this.

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-07
Reviewed by Eric Seidel.

Tests: fast/css/first-line-text-decoration-inherited-from-parent.html

fast/css/first-line-text-decoration.html

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Inform the decoration color retriever if this box is part of the first line box or not.

rendering/RenderObject.cpp:

(WebCore::decorationColor):
Changed the argument from RenderObject* to RenderStyle*. As this function is just a helper to getTextDecorationColors
as used RenderObject solely to retrieve the corresponding RenderStyle, which(RenderStyle*) was already available with the latter function.

(WebCore::RenderObject::getTextDecorationColors):
Take a new variable to check if first line style or the regular style has to be used.
Sends RenderStyle* as an argument to decorationColor().

rendering/RenderObject.h:

(RenderObject):

LayoutTests:

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-07
Reviewed by Eric Seidel.

fast/css/first-line-text-decoration.html: Added.
platform/qt-linux/fast/css/first-line-text-decoration-expected.png: Added.
platform/qt-linux/fast/css/first-line-text-decoration-expected.txt: Added. This test checks if text-decoration present in the tags first-line style is applied properly.

fast/css/first-line-text-decoration-inherited-from-parent.html: Added.
platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added. This test checks if the text-decoration and text color is chosen properly in the case where the first-line style is inherited from a parent and contains such text-decorations.

4:35 PM Changeset in webkit [116372] by oliver@apple.com

11 edits in trunk/Source/JavaScriptCore

2012-05-07 Oliver Hunt <oliver@apple.com>

Rolling out r110287

RS=Filip Pizlo

r110287 was meant to be refactoring only, but changed behavior
enough to break some websites, including qq.com.

4:33 PM Changeset in webkit [116371] by jchaffraix@webkit.org

14 edits in trunk/Source

Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
https://bugs.webkit.org/show_bug.cgi?id=84090

Reviewed by David Hyatt.

Source/WebCore:

No observable change in behavior.

The function name was ambiguous as it was not a general purpose function but was
working directly on HTMLFrameOwnerElement. The rename makes this more obvious as
well as removes the explicit dependency on RenderLayer.

One of the slight change of this refactoring is that we now always null-check the
HTMLFrameOwnerElement's renderer as part windowClipRectForFrameOwner as I don't see
any evidence for the other code paths not to hit that. Also we may recur more on our
frame tree if we have no layer as we now call windowClipRect() in this case.

page/FrameView.h:

(FrameView):

plugins/PluginView.cpp:

(WebCore::PluginView::windowClipRect):

WebCore.exp.in:
WebCore.order:
page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):
Updated after windowClipRectForLayer name and signature change.

(WebCore::FrameView::windowClipRectForFrameOwner):
This function now takes the HTMLFrameOwnerElement directly.

plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):
(WebCore::PluginView::create):

plugins/PluginView.h:

(PluginView):
Updated |m_element| to be an HTMLPlugInElement as this was what was
passed by every caller. This makes the conversion to HTMLFrameOwnerElement
possible.

Source/WebKit/chromium:

src/WebPluginContainerImpl.cpp:

Updated after windowClipRectForLayer name and signature change.

Source/WebKit/win:

WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::windowClipRect):
Updated after windowClipRectForLayer name and signature change.

WebCoreSupport/EmbeddedWidget.h:

(EmbeddedWidget):
(EmbeddedWidget::EmbeddedWidget):
Updated the internal DOM pointer to be an HTMLPlugInElement
as it was what was passed in anyway. Also fixed some style
issues detected by our tools.

Source/WebKit2:

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::clipRectInWindowCoordinates):
Updated after windowClipRectForLayer name and signature change.

4:32 PM Changeset in webkit [116370] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/test_expectations.txt: Mark seamless frames as

failing until we enable the feature.

4:32 PM Changeset in webkit [116369] by Lucas Forschler

4 edits in trunk/Source

Versioning.

4:30 PM Changeset in webkit [116368] by enrica@apple.com

6 edits in trunk/Source/WebCore

REGRESSION (r101575): Chinese input is broken when composing mail in iCloud using Safari.
https://bugs.webkit.org/show_bug.cgi?id=85840
<rdar://problem/11115520>

Reviewed by Alexey Proskuryakov.

The revision that broke this, introduced a way to sanitize the markup when deleting a range selection.
iCloud listens for DOM modification events and clears the selection, altering the input method state.
The fix consists in adding a paramenter to DeleteSelectionCommand to control when we sanitize the
markup.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteSelection):

editing/CompositeEditCommand.h:
editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
(WebCore::DeleteSelectionCommand::doApply):

editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

4:22 PM Changeset in webkit [116367] by aestes@apple.com

8 edits in trunk/Source

ENABLE_IFRAME_SEAMLESS should be part of FEATURE_DEFINES.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

4:15 PM Changeset in webkit [116366] by commit-queue@webkit.org

2 edits in trunk/Tools

webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81481

Patch by Raphael Kubo da Costa <rakuco@FreeBSD.org> on 2012-05-07
Reviewed by Dirk Pranke.

FreeBSD has the same sysctl interface present in Darwin to query
the number of CPUs available, so use that too.

Scripts/webkitdirs.pm:

(determineNumberOfCPUs): Share the sysctl call with Darwin.
(isFreeBSD): Added.

4:07 PM Changeset in webkit [116365] by Martin Robinson

3 edits in trunk/Source/WebCore

[Cairo] Implement ImageBuffer::copyImage for BackingStoreCopy == DontCopyBackingStore
https://bugs.webkit.org/show_bug.cgi?id=85728

Reviewed by Alejandro G. Castro.

No new tests. This should not change functionality, only increase performance.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::copyImage): Add an implementation that knows how to avoid copying the backing store.
(WebCore::ImageBuffer::draw): Use the copyImage constructor now that it knows how to
avoid copying the backing store.
(WebCore::ImageBuffer::drawPattern): Ditto.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Use DontCopyBackingStore for Cairo
as well.

4:06 PM Changeset in webkit [116364] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[CG] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=85782

Reviewed by Kenneth Russell.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests. No behavioral change. Covered by canvas 2d and 3d tests:

canvas/philip/tests/*toDataURL*.html
fast/canvas/webgl/premultiplyalpha-test.html

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageEncodeToData): Image encoding helper: encode the image using the
uti-defined encoder (PNG/JPEG/etc) and output to the given CFMutableDataRef data.
(WebCore):
(WebCore::CGImageToDataURL): Refactor to use CGImageEncodeToData().

4:02 PM Changeset in webkit [116363] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix release build.

4:00 PM Changeset in webkit [116362] by danakj@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
https://bugs.webkit.org/show_bug.cgi?id=85390

Reviewed by Adrienne Walker.

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):

3:52 PM Changeset in webkit [116361] by oliver@apple.com

7 edits in trunk

LLInt doesn't check for Ropes when performing a character switch
https://bugs.webkit.org/show_bug.cgi?id=85837

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Make LLint check if the scrutinee of a char switch is a rope, and if
so fall back to a slow case.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

LayoutTests:

Add a few tests to force the use of ropes on switch statements.

fast/js/script-tests/switch-behaviour.js:
fast/js/switch-behaviour-expected.txt:

3:29 PM Changeset in webkit [116360] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Chromium] Suppress switch-without-cases warning
https://bugs.webkit.org/show_bug.cgi?id=85830

Warnings like
...\webkit\CSSGrammar.cpp(2075) : warning C4065: switch statement contains 'default' but no 'case' labels
are generated. These are bogus, so just suppress them in the build
settings.

Patch by Scott Graham <scottmg@chromium.org> on 2012-05-07
Reviewed by Dirk Pranke

No new tests, no intended functionlity change. Just changing compiler
settings.

WebCore.gyp/WebCore.gyp:

3:21 PM Changeset in webkit [116359] by enne@google.com

9 edits in trunk/Source

[chromium] Allow for asymmetric tile sizes on composited tiled layers
https://bugs.webkit.org/show_bug.cgi?id=85687

Reviewed by James Robinson.

Source/WebCore:

Update TiledLayerChromium/CCLayerTilingData/TilingData to allow for a
the width and height of tile sizes to differ. Modify TilingData to use
IntSize everywhere for these width/height pairs.

Also, remove some unused functions from TilingData.

Test: TilingDataTest.*

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::CCLayerTilingData):
(WebCore::CCLayerTilingData::setTileSize):
(WebCore):
(WebCore::CCLayerTilingData::tileSize):
(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::tileRect):
(WebCore::CCLayerTilingData::setBounds):
(WebCore::CCLayerTilingData::bounds):

platform/graphics/chromium/cc/CCLayerTilingData.h:

(CCLayerTilingData):

platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::create):
(WebCore::Texture::load):
(WebCore::Texture::updateSubRect):

platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::TilingData):
(WebCore::TilingData::setTotalSize):
(WebCore::TilingData::setMaxTextureSize):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::recomputeNumTiles):

platform/graphics/gpu/TilingData.h:

(TilingData):
(WebCore::TilingData::totalSize):
(WebCore::TilingData::maxTextureSize):
(WebCore::TilingData::TilingData):

Source/WebKit/chromium:

Update tests for new constructor and function args. Add a few more
tests that use non-square tile sizes.

tests/TilingDataTest.cpp:

(WebCore::TestTiling::TestTiling):
(WebCore::TEST):
(WebCore):

3:15 PM Changeset in webkit [116358] by commit-queue@webkit.org

3 edits
2 adds in trunk

ConvolverNode setBuffer() should not ASSERT on null buffer
https://bugs.webkit.org/show_bug.cgi?id=85653

Patch by Raymond Toy <Raymond Toy> on 2012-05-07
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/convolver-setBuffer-null.html

Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer): Don't ASSERT on null buffer.

LayoutTests:

webaudio/convolver-setBuffer-null-expected.txt: Added.
webaudio/convolver-setBuffer-null.html: Added.

3:07 PM Changeset in webkit [116357] by commit-queue@webkit.org

3 edits
2 adds in trunk

Crash due to positioned object list not being cleared during block flow split
https://bugs.webkit.org/show_bug.cgi?id=85074

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-07
Reviewed by Abhishek Arya.

Source/WebCore:

When an element is being split due to a column span element being
inserted, any of its ancestors that are underneath the column
containing block also get split. If an ancestor has an object in
its positioned object list from a previous layout, then the list
will have to be cleared because the positioned object could have moved
to be under the continuation. This patch causes the list to be
cleared.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

Test exercises crashing condition in bug 85074. It creates a column
span that requires multiple layers of splitting blocks from the
element that contains the columns, puts a positioned element underneath
one of the split blocks, and then causes a reattach of the column span
element.

fast/block/positioning/positioned-object-under-split-block-parent-crash-expected.txt: Added
fast/block/positioning/positioned-object-under-split-block-parent-crash.html: Added

3:02 PM Changeset in webkit [116356] by eric@webkit.org

13 edits in trunk

Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
https://bugs.webkit.org/show_bug.cgi?id=85822

Reviewed by Adam Barth.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
dom/Document.cpp:

(WebCore::Document::shouldDisplaySeamlesslyWithParent):

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:

2:57 PM Changeset in webkit [116355] by aestes@apple.com

10 edits in trunk/LayoutTests

Update media/ pixel test results after r115749.

platform/mac/media/audio-controls-rendering-expected.png:
platform/mac/media/controls-after-reload-expected.png:
platform/mac/media/controls-layout-direction-expected.png:
platform/mac/media/controls-strict-expected.png:
platform/mac/media/media-controls-clone-expected.png:
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-layer-crash-expected.png:
platform/mac/media/video-playing-and-pause-expected.png:

2:40 PM Changeset in webkit [116354] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Fix compositing expectations to not include leopard.

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

2:30 PM Changeset in webkit [116353] by commit-queue@webkit.org

4 edits
2 adds in trunk

Selection Background Color Error
https://bugs.webkit.org/show_bug.cgi?id=80382

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-07
Reviewed by David Hyatt.

Source/WebCore:

Determine the text colors and selection colors before painting the
background behind the text. This is because when determining whether
to invert the selection background, the selection text color should be
used instead of the regular text color. With this patch, the selection
text color is passed to 'paintSelection' so that the selection
background can be compared against it, instead of comparing against the
CSSPropertyColor value.

Test: fast/backgrounds/selection-background-color.html

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

Pass selection text color to paintSelection

(WebCore::InlineTextBox::paintSelection):

Use the selection text color instead of CSSPropertyColor

rendering/InlineTextBox.h:

(InlineTextBox):

Adjust signature of paintSelection to accept text color

LayoutTests:

Added new test case for selection background color.

fast/backgrounds/selection-background-color.html: Added.
fast/backgrounds/selection-background-color-expected.html: Added.

1:41 PM Changeset in webkit [116352] by alexis.menard@openbossa.org

4 edits in trunk

Unreviewed Qt build fix in Debug.

We need some system includes here for getpid() to be recognized.

Source/WebKit2:

qt/MainQt.cpp:

Tools:

WebKitTestRunner/qt/main.cpp:

1:40 PM Changeset in webkit [116351] by commit-queue@webkit.org

18 edits
1 copy
2 adds
1 delete in trunk/Source

[Chromium] Use GL_CHROMIUM_command_buffer_query to throttle texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=81004

Patch by David Reveman <reveman@chromium.org> on 2012-05-07
Reviewed by Adrienne Walker.

Source/WebCore:

Add ThrottledTextureUploader class that uses GL_CHROMIUM_command_buffer_query
to throttle texture uploads based on number of currently pending queries.

Unit test: ThrottledTextureUploaderTest.IsBusy

WebCore.gypi:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/TextureUploader.cpp: Removed.
platform/graphics/chromium/TextureUploader.h:

(TextureUploader):

platform/graphics/chromium/ThrottledTextureUploader.cpp: Added.

(WebCore):
(WebCore::ThrottledTextureUploader::Query::Query):
(WebCore::ThrottledTextureUploader::Query::~Query):
(WebCore::ThrottledTextureUploader::Query::begin):
(WebCore::ThrottledTextureUploader::Query::end):
(WebCore::ThrottledTextureUploader::Query::isPending):
(WebCore::ThrottledTextureUploader::Query::wait):
(WebCore::ThrottledTextureUploader::ThrottledTextureUploader):
(WebCore::ThrottledTextureUploader::~ThrottledTextureUploader):
(WebCore::ThrottledTextureUploader::isBusy):
(WebCore::ThrottledTextureUploader::beginUploads):
(WebCore::ThrottledTextureUploader::endUploads):
(WebCore::ThrottledTextureUploader::uploadTexture):
(WebCore::ThrottledTextureUploader::processQueries):

platform/graphics/chromium/ThrottledTextureUploader.h: Copied from Source/WebCore/platform/graphics/chromium/TextureUploader.h.

(WebCore):
(ThrottledTextureUploader):
(WebCore::ThrottledTextureUploader::create):
(Query):
(WebCore::ThrottledTextureUploader::Query::create):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::doCommit):

platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore):
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

tests/CCTiledLayerTestCommon.h:

(WebKitTests::FakeTextureUploader::isBusy):
(WebKitTests::FakeTextureUploader::beginUploads):
(WebKitTests::FakeTextureUploader::endUploads):

tests/Canvas2DLayerChromiumTest.cpp:
tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

tests/ThrottledTextureUploaderTest.cpp: Added.

(WebKit):
(FakeWebGraphicsContext3DWithQueryTesting):
(WebKit::FakeWebGraphicsContext3DWithQueryTesting::FakeWebGraphicsContext3DWithQueryTesting):
(WebKit::FakeWebGraphicsContext3DWithQueryTesting::getQueryObjectuivEXT):
(WebKit::FakeWebGraphicsContext3DWithQueryTesting::setResultAvailable):
(WebKit::TEST):

tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

1:37 PM Changeset in webkit [116350] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Delete previous buffer when new over-scroll image path is set
https://bugs.webkit.org/show_bug.cgi?id=85812

Patch by Andrew Lo <anlo@rim.com> on 2012-05-07
Reviewed by Rob Buis.

When a new over-scroll image path is set, delete old buffer before creating
a new one.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):

1:37 PM Changeset in webkit [116349] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed. Rebaseline fast/layers/video-layer.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-07

platform/efl/fast/layers/video-layer-expected.txt:

1:23 PM Changeset in webkit [116348] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Over-scroll image path property should be relative to local application directory
https://bugs.webkit.org/show_bug.cgi?id=85814

Patch by Andrew Lo <anlo@rim.com> on 2012-05-07
Reviewed by Rob Buis.

Over-scroll image path web setting should be relative to the local directory.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):

1:23 PM Changeset in webkit [116347] by ojan@chromium.org

4 edits
2 adds in trunk/Tools

When embedding the flakiness dashboard, hide popups when the frame is blurred.
https://bugs.webkit.org/show_bug.cgi?id=85684

Reviewed by Dirk Pranke.

If you show a popup, then click elsewhere in garden-o-matic, it will now
properly hide it.

TestResultServer/static-dashboards/dashboard_base.js:

(showPopup):

TestResultServer/static-dashboards/flakiness_dashboard.js:

(showPopupForBuild):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):

TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
TestResultServer/static-dashboards/run-embedded-unittests.html: Added.

1:21 PM Changeset in webkit [116346] by dpranke@chromium.org

2 edits in trunk/LayoutTests

Mark more tests as flaky, including some compositing tests
https://bugs.webkit.org/show_bug.cgi?id=85771

Unreviewed, expectations change.

platform/chromium/test_expectations.txt:

1:19 PM Changeset in webkit [116345] by fpizlo@apple.com

20 edits in branches/dfgopt/Source/JavaScriptCore

DFG should support reflective arguments access
https://bugs.webkit.org/show_bug.cgi?id=85721

Reviewed by Oliver Hunt.

This adds support for op_create_arguments to the DFG. No other arguments-related
opcodes are added by this change, though it does add a lot of the scaffolding
necessary for the other ops.

This also adds GetByVal/PutByVal optimizations for Arguments.

Finally, this rationalizes slowPathCall with no return. Previously, that would
work via callOperation() overloads that took InvalidGPRReg as the return GPR.
But that creates awful ambiguity, since we had template functions that were
polymorphic over all parameters except the second, which was a GPRReg, and a
bunch of non-template overloads that also potentially had GPRReg as the second
argument. I finally started to hit this ambiguity and was getting absolutely
bizarre compiler errors, that made me feel like I was programming in SML. So,
I changed the no-argument overloads to take NoResultTag instead, which made
everything sensible again by eliminating the overload ambiguity.

This is a ~7% speed-up on V8/earley and neutral elsewhere.

bytecode/PredictedType.h:

(JSC::isArgumentsPrediction):
(JSC):
(JSC::isActionableMutableArrayPrediction):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

dfg/DFGCommon.h:
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::unmodifiedArgumentsRegister):
(Node):
(JSC::DFG::Node::shouldSpeculateArguments):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(DFG):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

runtime/Arguments.h:

(ArgumentsData):
(Arguments):
(JSC::Arguments::offsetOfData):

1:17 PM Changeset in webkit [116344] by commit-queue@webkit.org

2 edits in trunk/Tools

[chromium] WebViewHost should setCompositorSurfaceReady
https://bugs.webkit.org/show_bug.cgi?id=85418

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-07
Reviewed by James Robinson.

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setWebWidget):

1:16 PM Changeset in webkit [116343] by rwlbuis@webkit.org

4 edits in trunk/Source/WebCore

Shrink SVGInlineTextBox object size
https://bugs.webkit.org/show_bug.cgi?id=85805

Reviewed by Darin Adler.

Reduce the object size of SVGInlineTextBox by using bitfields. This
should be 4 bytes on 32-bits and 8 bytes on 64-bits systems.

rendering/svg/RenderSVGResource.h:
rendering/svg/SVGInlineTextBox.cpp:

(ExpectedSVGInlineTextBoxSize):
(WebCore):

rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

1:14 PM Changeset in webkit [116342] by commit-queue@webkit.org

6 edits
5 deletes in trunk/Source

Unreviewed, rolling out r116334.
http://trac.webkit.org/changeset/116334
https://bugs.webkit.org/show_bug.cgi?id=85816

Broke the Chromium Win/Mac compile (Requested by
ojan_gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

Source/WebCore:

WebCore.gypi:
platform/graphics/chromium/AnimationIdVendor.cpp: Removed.
platform/graphics/chromium/AnimationIdVendor.h: Removed.
platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

platform/graphics/chromium/LinkHighlightLayerDelegate.cpp: Removed.
platform/graphics/chromium/LinkHighlightLayerDelegate.h: Removed.

Source/WebKit/chromium:

WebKit.gypi:
tests/LinkHighlightLayerDelegateTest.cpp: Removed.

1:10 PM Changeset in webkit [116341] by commit-queue@webkit.org

4 edits in trunk

[EFL] Page caching permission from EFL's FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=85620

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-07
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

FrameLoaderClientEfl::canCachePage() returns true.

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::canCachePage):

LayoutTests:

Unskip bug-related testcases.

platform/efl/Skipped:

1:06 PM Changeset in webkit [116340] by aestes@apple.com

2 edits
2 deletes in trunk/LayoutTests

Update mac-wk2 baselines.

platform/mac-wk2/Skipped: Skip a test that times out due to WKTR's

EventSender implementation not supporting drag and drop.

Remove mac-wk2 platform-specific results for two tests that now match the baseline result.

platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Removed.

12:35 PM Changeset in webkit [116339] by enne@google.com

2 edits in trunk/Source/WebCore

Fix containerForRepaint() assumption about non-null enclosingLayer()
https://bugs.webkit.org/show_bug.cgi?id=85807

Reviewed by Simon Fraser.

rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

12:22 PM Changeset in webkit [116338] by jonlee@apple.com

8 edits in trunk/Tools

WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42331
<rdar://problem/8193641>

Reviewed by Darin Adler.

This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
outputting some of the required strings. As tests become unskipped the other callbacks
can be supported.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
dump callbacks for the layoutTestController.
(WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
Output some warning if we are trying to extract a value that is not a boolean.
(WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
We cannot set the bits on the layoutTestController until it has been created in beginTesting().

WebKitTestRunner/InjectedBundle/InjectedBundle.h:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR):
(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR):
(WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
-[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
(WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
(WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
(WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
"willPerformClientRedirectToURL" so we will have to use that value here.
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.

WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.

WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
(WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
(WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
(LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.

WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldLogFrameLoadDelegates): Similar to DRT.
(WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
to the injected bundle.

12:12 PM Changeset in webkit [116337] by commit-queue@webkit.org

148 edits
3 adds in trunk

IndexedDB: Replace numeric constants with strings
https://bugs.webkit.org/show_bug.cgi?id=84894

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-07
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/legacy-constants.html

Update IDBObjectStore.openCursor, IDBIndex.openCursor,
IDBIndex.openKeyCursor, IDBDatabase.transaction,
IDBCursor.direction, IDBTransaction.mode, and
IDBRequest.readyState to meet the latest spec. All of these APIs
now support string-based values in addition to the
legacy/deprecated enum-based values.

Modules/indexeddb/IDBCursor.cpp:

(WebCore):
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):
(WebCore):

Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

Modules/indexeddb/IDBDatabase.idl:
Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):

Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):

Modules/indexeddb/IDBIndex.idl:
Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):
(WebCore):

Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

Modules/indexeddb/IDBObjectStore.idl:
Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):

Modules/indexeddb/IDBRequest.h:
Modules/indexeddb/IDBRequest.idl:
Modules/indexeddb/IDBTransaction.cpp:

(WebCore):
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

New test for legacy constants (legacy-constants) and update all
other tests to use the new string-based constants.

storage/indexeddb/basics-expected.txt:
storage/indexeddb/basics-workers-expected.txt:
storage/indexeddb/constants-expected.txt:
storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/cursor-added-bug-expected.txt:
storage/indexeddb/cursor-advance-expected.txt:
storage/indexeddb/cursor-continue-expected.txt:
storage/indexeddb/cursor-continue-validity-expected.txt:
storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-inconsistency-expected.txt:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-key-order-expected.txt:
storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
storage/indexeddb/cursor-primary-key-order-expected.txt:
storage/indexeddb/cursor-reverse-bug-expected.txt:
storage/indexeddb/cursor-skip-deleted-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/data-corruption-expected.txt:
storage/indexeddb/database-quota-expected.txt:
storage/indexeddb/delete-range-expected.txt:
storage/indexeddb/error-causes-abort-by-default-expected.txt:
storage/indexeddb/exception-in-event-aborts-expected.txt:
storage/indexeddb/factory-deletedatabase-expected.txt:
storage/indexeddb/index-count-expected.txt:
storage/indexeddb/index-multientry-expected.txt:
storage/indexeddb/index-unique-expected.txt:
storage/indexeddb/key-generator-expected.txt:
storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/keypath-edges-expected.txt:
storage/indexeddb/keypath-intrinsic-properties-expected.txt:
storage/indexeddb/legacy-constants-expected.txt: Added.
storage/indexeddb/legacy-constants.html: Added.
storage/indexeddb/mozilla/clear-expected.txt:
storage/indexeddb/mozilla/create-index-unique-expected.txt:
storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
storage/indexeddb/mozilla/cursors-expected.txt:
storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
storage/indexeddb/mozilla/index-prev-no-duplicate.html:
storage/indexeddb/mozilla/indexes-expected.txt:
storage/indexeddb/mozilla/odd-result-order-expected.txt:
storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
storage/indexeddb/mozilla/readyState-expected.txt:
storage/indexeddb/mozilla/resources/clear.js:

(clear):

storage/indexeddb/mozilla/resources/create-index-unique.js:

(createAndVerifyIndex):

storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(cleanDatabase):

storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:

(checkCursorResultsAndSetupMutatingCursor):

storage/indexeddb/mozilla/resources/cursor-mutation.js:

(setupMutatingCursor):

storage/indexeddb/mozilla/resources/cursors.js:
storage/indexeddb/mozilla/resources/indexes.js:
storage/indexeddb/mozilla/resources/odd-result-order.js:

(addRecord):
(deleteRecord):

storage/indexeddb/mozilla/resources/readwrite-transactions.js:

(setVersionComplete):
(postAdd):
(postAdd2):
(postPut):
(postPut2):
(postPut3):
(postPut4):
(postDelete):
(postDelete2):

storage/indexeddb/mozilla/resources/readyState.js:

(test):
(openSuccess):
(setupObjectStore):
(getRecord):
(finalCheck):

storage/indexeddb/mozilla/resources/versionchange.js:

(postSetVersion):
(postSetVersion2):

storage/indexeddb/mozilla/versionchange-expected.txt:
storage/indexeddb/mutating-cursor-expected.txt:
storage/indexeddb/noblobs-expected.txt:
storage/indexeddb/noblobs.html:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/objectstore-count-expected.txt:
storage/indexeddb/open-cursor-expected.txt:
storage/indexeddb/open-during-transaction-expected.txt:
storage/indexeddb/opencursor-key-expected.txt:
storage/indexeddb/prefetch-bugfix-108071-expected.txt:
storage/indexeddb/readonly-expected.txt:
storage/indexeddb/request-event-propagation-expected.txt:
storage/indexeddb/resources/basics.js:

(test):
(openCallback):

storage/indexeddb/resources/constants.js:

(test):

storage/indexeddb/resources/create-object-store-options.js:

(setVersionComplete):

storage/indexeddb/resources/cursor-added-bug.js:

(openCursor):

storage/indexeddb/resources/cursor-advance.js:

(runTest):
(testAdvanceIndexNoDupe):
(testAdvanceIndexPrev):
(testAdvanceIndexPrevNoDupe):

storage/indexeddb/resources/cursor-continue-validity.js:

(continueTest):
(continueIndexTest):
(testModifyContinueOrder):

storage/indexeddb/resources/cursor-continue.js:

(ascendingTest):
(descendingTest):

storage/indexeddb/resources/cursor-delete.js:

(openCursor):
(addObject):

storage/indexeddb/resources/cursor-inconsistency.js:

(openBasicCursor):

storage/indexeddb/resources/cursor-index-delete.js:

(openCursor):
(addObject):

storage/indexeddb/resources/cursor-key-order.js:
storage/indexeddb/resources/cursor-prev-no-duplicate.js:

(populateStore):
(testFarRangeCursor_closed):
(testFarRangeCursor_open):
(testFarRangeCursor_indexClosed):
(testFarRangeCursor_indexOpen):
(testFarRangeCursor_indexKeyOpen):
(testFarRangeCursor_indexKeyClosed):
(testBoundaryCursor_closed):
(testBoundaryCursor_open):
(testBoundaryCursor_indexClosed):
(testBoundaryCursor_indexOpen):
(testBoundaryCursor_indexKeyClosed):
(testBoundaryCursor_indexKeyOpen):
(testNoDuplicate_closed):
(testNoDuplicate_open):
(testNoDuplicate_indexKeyClosed):

storage/indexeddb/resources/cursor-primary-key-order.js:

(populateStore):

storage/indexeddb/resources/cursor-reverse-bug.js:

(populateStore):
(testCursor):

storage/indexeddb/resources/cursor-skip-deleted.js:

(basicCursorTest):
(reverseCursorTest):

storage/indexeddb/resources/cursor-update.js:

(openBasicCursor):

storage/indexeddb/resources/data-corruption.js:

(addData):
(getData):

storage/indexeddb/resources/database-quota.js:

(checkQuotaEnforcing):

storage/indexeddb/resources/delete-range.js:

(runTests.nextTest):
(runTests):

storage/indexeddb/resources/error-causes-abort-by-default.js:

(addData):
(transactionCompleted):
(transactionAborted1):

storage/indexeddb/resources/exception-in-event-aborts.js:

(startTest):
(transactionAborted1):
(transactionAborted2):

storage/indexeddb/resources/factory-deletedatabase.js:

(getValue):

storage/indexeddb/resources/index-count.js:
storage/indexeddb/resources/index-cursor.js:

(runNextTest):
(testNullKeyRange):

storage/indexeddb/resources/index-multientry.js:
storage/indexeddb/resources/index-unique.js:

(setVersionCompleted):

storage/indexeddb/resources/key-generator.js:

(.):

storage/indexeddb/resources/key-type-array.js:
storage/indexeddb/resources/keypath-edges.js:
storage/indexeddb/resources/keypath-intrinsic-properties.js:
storage/indexeddb/resources/legacy-constants.js: Added.

(test):
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(checkNext.request.onsuccess):
(checkNext):
(checkNextNoDuplicate.request.onsuccess):
(checkNextNoDuplicate):
(checkPrev.request.onsuccess):
(checkPrev):
(checkPrevNoDuplicate.request.onsuccess):
(checkPrevNoDuplicate):

storage/indexeddb/resources/mutating-cursor.js:

(openForwardCursor):
(openReverseCursor):

storage/indexeddb/resources/objectstore-autoincrement.js:

(setVersionCompleted):

storage/indexeddb/resources/objectstore-basics.js:

(addData):
(addAgainFailure):

storage/indexeddb/resources/objectstore-count.js:
storage/indexeddb/resources/objectstore-cursor.js:

(runNextTest):
(testNullKeyRange):

storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

storage/indexeddb/resources/open-during-transaction.js:
storage/indexeddb/resources/opencursor-key.js:
storage/indexeddb/resources/prefetch-bugfix-108071.js:
storage/indexeddb/resources/request-event-propagation.js:

(startTest):
(transactionAborted):
(transactionAborted2):

storage/indexeddb/resources/set_version_blocked.js:

(blocked):

storage/indexeddb/resources/transaction-abort.js:

(startTest):

storage/indexeddb/resources/transaction-after-close.js:

(runFirstRegularTransaction):
(firstTransactionComplete):
(onSecondOpen):

storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):

storage/indexeddb/resources/transaction-event-propagation.js:

(startTest):
(dbAbortBubbleCallback):

storage/indexeddb/resources/transaction-rollback.js:

(setVersionComplete):
(abortCallback):

storage/indexeddb/set_version_blocked-expected.txt:
storage/indexeddb/structured-clone-expected.txt:
storage/indexeddb/structured-clone.html:
storage/indexeddb/transaction-abort-expected.txt:
storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
storage/indexeddb/transaction-abort-with-js-recursion.html:
storage/indexeddb/transaction-after-close-expected.txt:
storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-event-propagation-expected.txt:
storage/indexeddb/transaction-rollback-expected.txt:
storage/indexeddb/tutorial.html:

12:11 PM Changeset in webkit [116336] by pilgrim@chromium.org

18 edits
1 copy in trunk/Source

[Chromium] Move fileSystem to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85760

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::fileSystem):

chromium/public/WebFileSystem.h: Added.

(WebKit):
(WebFileSystem):
(WebKit::WebFileSystem::move):
(WebKit::WebFileSystem::copy):
(WebKit::WebFileSystem::remove):
(WebKit::WebFileSystem::removeRecursively):
(WebKit::WebFileSystem::readMetadata):
(WebKit::WebFileSystem::createFile):
(WebKit::WebFileSystem::createDirectory):
(WebKit::WebFileSystem::fileExists):
(WebKit::WebFileSystem::directoryExists):
(WebKit::WebFileSystem::readDirectory):
(WebKit::WebFileSystem::createFileWriter):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):
(WebKit::WebFileSystem::~WebFileSystem):

Source/WebKit/chromium:

WebKit.gyp:
public/platform/WebFileSystem.h:
public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

src/AssertMatchingEnums.cpp:
src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):

src/LocalFileSystemChromium.cpp:
src/WebFileSystemCallbacksImpl.cpp:
src/WebFileSystemCallbacksImpl.h:
src/WebFrameImpl.cpp:
src/WebWorkerClientImpl.h:
src/WorkerAsyncFileSystemChromium.cpp:
src/WorkerAsyncFileWriterChromium.cpp:
src/WorkerFileSystemCallbacksBridge.h:
src/WorkerFileWriterCallbacksBridge.cpp:

(WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):

12:01 PM Changeset in webkit [116335] by abarth@webkit.org

1 edit
2 adds in trunk/LayoutTests

Test the combination of CSP and srcdoc
https://bugs.webkit.org/show_bug.cgi?id=85778

Reviewed by Eric Seidel.

This test ensure that <iframe srcdoc> can't be used to bypass
Content-Security-Policy restrictions on script-src. We already have the
correct behavior. This test just verifies it.

http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt: Added.
http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src.html: Added.

11:57 AM Changeset in webkit [116334] by wjmaclean@chromium.org

6 edits
5 adds in trunk/Source

[chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=85084

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test provided.

WebCore.gypi:
platform/graphics/chromium/AnimationIdVendor.cpp: Added.

(WebCore):
(WebCore::AnimationIdVendor::getNextAnimationId):
(WebCore::AnimationIdVendor::getNextGroupId):

platform/graphics/chromium/AnimationIdVendor.h: Added.

(WebCore):
(AnimationIdVendor):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::addLinkHighlightLayer):
(WebCore):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlightLayer):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

platform/graphics/chromium/LinkHighlightLayerDelegate.cpp: Added.

(WebCore):
(WebCore::LinkHighlightLayerDelegate::create):
(WebCore::LinkHighlightLayerDelegate::LinkHighlightLayerDelegate):
(WebCore::LinkHighlightLayerDelegate::~LinkHighlightLayerDelegate):
(WebCore::LinkHighlightLayerDelegate::getContentLayer):
(WebCore::LinkHighlightLayerDelegate::paintContents):
(WebCore::LinkHighlightLayerDelegate::didScroll):
(WebCore::LinkHighlightLayerDelegate::notifyAnimationStarted):
(WebCore::LinkHighlightLayerDelegate::notifyAnimationFinished):

platform/graphics/chromium/LinkHighlightLayerDelegate.h: Added.

(WebCore):
(LinkHighlightLayerDelegate):

Source/WebKit/chromium:

WebKit.gypi:
tests/LinkHighlightLayerDelegateTest.cpp: Added.

11:54 AM Changeset in webkit [116333] by jsbell@chromium.org

4 edits in trunk/Source

IndexedDB: LevelDB coding for bools is broken
https://bugs.webkit.org/show_bug.cgi?id=85810

Reviewed by Tony Chang.

Source/WebCore:

Code was appending to a pre-sized Vector, rather than using an
index setter. This caused uninitialized data to be written out.
Issue was detected on the Chromium side in http://crbug.com/126388

Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'

Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeBool):

Source/WebKit/chromium:

Added tests for encodeBool/decodeBool.

tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):

11:48 AM Changeset in webkit [116332] by shawnsingh@chromium.org

5 edits in trunk/Source

[chromium] CCMathUtil projectPoint needs to avoid divide-by-zero
https://bugs.webkit.org/show_bug.cgi?id=85560

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added: CCMathUtilTest.cpp - verifyProjectionOfPerpendicularPlane
Unit test updated/renamed: CCLayerTreeHostCommonTest.cpp - verifyVisibleRectFor3dPerspectiveWhenClippedByW

The divide-by-zero occurs in an innocuous case where the layers
are probably invisible anyway. However, producing Infs and NaNs
could cause values to be used when un-intended, so its appropriate
to handle the divide-by-zero correctly.

platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::projectPoint):

Source/WebKit/chromium:

tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

tests/CCMathUtilTest.cpp:

(WebCore::TEST):
(WebCore):

11:41 AM Changeset in webkit [116331] by commit-queue@webkit.org

3 edits
2 adds in trunk

Wrong positioning due to wrong width calculation wrt width:0
https://bugs.webkit.org/show_bug.cgi?id=50135

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-07
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/block-parent-with-zero-width-child.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
When width is fixed, the specified width must be taken, provided the value is positive.
Width=0 case was being ignored.

LayoutTests:

fast/block/block-parent-with-zero-width-child-expected.txt: Added.
fast/block/block-parent-with-zero-width-child.html: Added.

11:34 AM Changeset in webkit [116330] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[CG] ImageBuffer::ImageDataToDataURL: Remove alpha stuffing when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=85779

Reviewed by Eric Seidel.

No change in behavior. Covered by fast/canvas/webgl/premultiplyalpha-test.html

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageDataToDataURL): Remove the need to stuff the alpha channel with 255.
Rename dataVector to premultipliedData and verify that its resize() worked. Rewrite
the premultiplication loop without the alpha channel = 255 part and ask the CG JPEG
encoder to ignore the alpha channel (kCGImageAlphaNoneSkipLast) instead.

11:34 AM Changeset in webkit [116329] by Lucas Forschler

4 edits in tags/Safari-536.10.2/Source

Versioning.

11:32 AM Changeset in webkit [116328] by commit-queue@webkit.org

5 edits in trunk

[GTK] media/video-seek-past-end-playing.html times out
https://bugs.webkit.org/show_bug.cgi?id=84858

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-07
Reviewed by Philippe Normand.

Source/WebCore:

Removing the intentional state change to PAUSED on didEnd().
My understanding is that the fix works because the additional
state transition to PAUSED was resetting the internal m_seeking state to early,
so that updatePlayState() in HTMLMediaElement was not able to
correctly figure out/recover playstate after seeking.

No new tests, covered by existing media tests, and fixing
video-seek-past-end-playing.html flakiness on GTK, failure on EFL.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

video-seek-past-end-playing.html should work reliably after fix, removing.

platform/gtk/test_expectations.txt:

11:30 AM Changeset in webkit [116327] by Lucas Forschler

1 copy in tags/Safari-536.10.2

New Tag.

11:30 AM Changeset in webkit [116326] by Lucas Forschler

4 edits in tags/Safari-536.10.1/Source

Fix versioning for 536.10.1.

11:27 AM Changeset in webkit [116325] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in RenderBlock::updateFirstLetterStyle.
https://bugs.webkit.org/show_bug.cgi?id=85759

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/first-letter-next-sibling-crash.html

RenderBlock::removeChild can bring up the children from last single anonymous block,
causing |nextSibling| in RenderBlock::updateFirstLetterStyle to go stale. We prevent
this by removing the child safely using removeChildNode before destroying it.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

LayoutTests:

fast/css-generated-content/first-letter-next-sibling-crash-expected.txt: Added.
fast/css-generated-content/first-letter-next-sibling-crash.html: Added.

11:24 AM Changeset in webkit [116324] by Lucas Forschler

4 edits in tags/Safari-536.10.1/Source

Versioning.

11:24 AM Changeset in webkit [116323] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/test_expectations.txt: Mark

fast/events/message-port-close.html as crashing in debug builds.

11:16 AM Changeset in webkit [116322] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/test_expectations.txt: Mark new mediastream test as

expected failure.

10:56 AM Changeset in webkit [116321] by tommyw@google.com

9 edits in trunk/Source

MediaStream API: Rename MediaStreamCenter::didConstructMediaStream
https://bugs.webkit.org/show_bug.cgi?id=85796

Reviewed by Adam Barth.

Source/Platform:

Renamed WebMediaStreamCenter::didConstructMediaStream to didCreateMediaStream,
and change so that it is only called for MediaStreams created from JS.
Also send out the WebMediaStreamDescriptor non-const instead.

chromium/public/WebMediaStreamCenter.h:

(WebKit::WebMediaStreamCenter::didCreateMediaStream):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::didConstructMediaStream):

Source/WebCore:

Renamed MediaStreamCenter::didConstructMediaStream to didCreateMediaStream,
and change so that it is only called for MediaStreams created from JS.

Not really testable.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):

platform/mediastream/MediaStreamCenter.h:

(MediaStreamCenter):

platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

platform/mediastream/chromium/MediaStreamCenterChromium.h:

(MediaStreamCenterChromium):

platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterGStreamer::didCreateMediaStream):

platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(MediaStreamCenterGStreamer):

10:42 AM Changeset in webkit [116320] by mitz@apple.com

3 edits in trunk/Websites/webkit.org

webkit.org instructions for debugging WebProcess are unnecessarily complex
https://bugs.webkit.org/show_bug.cgi?id=85756

Reviewed by Darin Adler.

building/debug.html: Added instructions for setting up and using the WebKit workspace for

debugging the Web process, as well as instructions for debugging the Web process from the
command line using debug-safari and debug-minibrowser.

building/tools.html: Updated links and tweaked the language.

10:37 AM Changeset in webkit [116319] by nduca@chromium.org

18 edits in trunk/Source

Unreviewed, rolling out r115525.
http://trac.webkit.org/changeset/115525
https://bugs.webkit.org/show_bug.cgi?id=66683

Too many pages rely on DOMTimeStamp as first argument.
Reverting while we consider next steps.

Source/WebCore:

WebCore.exp.in:
bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations):

dom/Document.h:

(Document):

dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

dom/RequestAnimationFrameCallback.idl:
dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):

dom/ScriptedAnimationController.h:

(ScriptedAnimationController):
(WebCore::ScriptedAnimationController::displayRefreshFired):

page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

page/FrameView.h:

(FrameView):

platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):

platform/graphics/DisplayRefreshMonitor.h:

(DisplayRefreshMonitor):

platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/chromium:

src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::animate):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

10:32 AM Changeset in webkit [116318] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add methods need by client side
https://bugs.webkit.org/show_bug.cgi?id=85661

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-07
Reviewed by Antonio Gomes.

Add methods needed by client side when create and close HTML popup dialogs.
PR 154360

Api/WebPageClient.h:

10:32 AM Changeset in webkit [116317] by tommyw@google.com

9 edits in trunk/Source

MediaStream API: Allow UserMediaRequest::succeed to take an MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=85798

Reviewed by Adam Barth.

Source/Platform:

Adding another UserMediaRequest::succeed function that takes an MediaStreamDescriptor
instead of the two MediaStreamSource arrays.

chromium/public/WebMediaStreamCenter.h:

(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::constructSDP):

Source/WebCore:

Adding another UserMediaRequest::succeed function that takes an MediaStreamDescriptor
instead of the two MediaStreamSource arrays.

Not currently testable.

Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore):
(WebCore::LocalMediaStream::LocalMediaStream):

Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::succeed):
(WebCore):

Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

Source/WebKit/chromium:

Adding another WebUserMediaRequest::requestSucceed function that takes an
WebMediaStreamDescriptor instead of the two WebMediaStreamSource arrays.

public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::requestSucceeded):

10:25 AM Changeset in webkit [116316] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit.
https://bugs.webkit.org/show_bug.cgi?id=85801

Patch by Michal Mocny <mmocny@google.com> on 2012-05-07
Reviewed by Adrienne Walker.

CCLayerTreeHost::setContentsMemoryAllocationLimitBytes needs to call setNeedsCommit after adjusting memory
limits, so that we push a new frame. In particular, when returning from non visibile state, we adjust
memory allocation from 0 to non 0, and we need to push a non blank frame.

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):

10:21 AM Changeset in webkit [116315] by tommyw@google.com

6 edits
2 adds in trunk

[chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
https://bugs.webkit.org/show_bug.cgi?id=85618

Reviewed by Adam Barth.

Adding the capability to control which MediaStreamTracks actually get created,
and adding a test that exercises the JS api using that capability.

Tools:

DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(WebKit::WebUserMediaClientMock::requestUserMedia):

DumpRenderTree/chromium/WebUserMediaClientMock.h:
DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::testMediaStreamClient):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

LayoutTests:

fast/mediastream/getusermedia-expected.txt: Added.
fast/mediastream/getusermedia.html: Added.

10:20 AM Changeset in webkit [116314] by Lucas Forschler

1 copy in branches/safari-536-branch

New branch.

9:26 AM Changeset in webkit [116313] by commit-queue@webkit.org

6 edits in trunk

[EFL] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=85602

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-07
Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS.

css/mediaControlsEfl.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

Update expected result for several media tests now that the
positioning of the controls panel is relative.

platform/efl/media/media-controls-clone-expected.txt:
platform/efl/media/video-empty-source-expected.txt:
platform/efl/media/video-zoom-controls-expected.txt:

8:05 AM Changeset in webkit [116312] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening, fix failure expectation for test.

platform/efl/test_expectations.txt:

8:02 AM Changeset in webkit [116311] by adam.bergkvist@ericsson.com

6 edits in trunk/Source/WebCore

MediaStream should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=85191

Reviewed by Adam Barth.

The model with MediaStreamDescriptor and MediaStream (and LocalMediaStream)
allows the JavaScript objects (MediaStream and LocalMediaStream) to be
cleaned up while the MediaStreamDescriptor lives on to manage the stream in
the platform. This happens for example when a URL is created to represent
a MediaStream (using createObjectURL()). In that case, the MediaStreamDescriptor
is put into the MediaStreamRegistry and even though the MediaStream object is
lost, the URL still works since the descriptor is kept in the registry.

The changes introduced in r113460 (http://webkit.org/b/83143) turned
MediaStream and LocalMediaStream into ActiveDOMObjects. For example on page
reload, LocalMediaStream calls MediaStreamCenter::didStopLocalMediaStream()
via its ActiveDOMObject::stop() method. However, when a page reload occurs,
the LocalMediaStream object may have been cleaned up already and
MediaStreamCenter::didStopLocalMediaStream() will not be called.

One way to make the behavior consistent would be to call
MediaStreamCenter::didStopLocalMediaStream() when the descriptor is cleaned up,
cause then we wouldn't be dependent on the LocalMediaStream object being alive.
However, calling MediaStreamCenter::didStopLocalMediaStream() might not be the
correct thing to do when all references to the descriptor are lost since there
can be MediaStream objects constructed from the tracks of the LocalMediaStream
that should continue to work. MediaStreamCenter::didStopLocalMediaStream() was
intended for LocalMediaStream.stop() which is used to revoke access to devices;
that should not necessarily happen when the descriptor of a LocalMediaStream is
cleaned up. If it's necessary for some ports to signal to the platform that a
MediaStreamDescriptor is cleaned up, then I would suggest adding a new function,
willDestroyMediaStreamDescriptor(), to the MediaStreamCenter interface.

The current resolution is to make MediaStream a ContextDestructionObserver
instead of an ActiveDOMObject.

Currently not testable.

Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):

Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

Modules/mediastream/LocalMediaStream.idl:
Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scriptExecutionContext):

Modules/mediastream/MediaStream.h:

8:01 AM Changeset in webkit [116310] by zandobersek@gmail.com

2 edits in trunk/Tools

[Gtk] WebGL feature is not built anymore through build-webkit after r116251
https://bugs.webkit.org/show_bug.cgi?id=85788

Reviewed by Martin Robinson.

Enable WebGL by default for the Gtk port. The feature is already enabled by
default in configure.ac, so there's no reason it shouldn't be enabled when
building through build-webkit.

Scripts/webkitperl/FeatureList.pm:

7:46 AM Changeset in webkit [116309] by mihnea@adobe.com

3 edits
2 adds
18 deletes in trunk/LayoutTests

[CSSRegions]Convert (some) region style tests to ref tests
https://bugs.webkit.org/show_bug.cgi?id=85783

Reviewed by Andreas Kling.

fast/regions/region-style-image-background-color-expected.html: Added.
fast/regions/region-style-image-background-color.html:
fast/regions/region-style-inline-background-color-expected.html: Added.
fast/regions/region-style-inline-background-color.html:
platform/chromium-linux/fast/regions/region-style-image-background-color-expected.png: Removed.
platform/chromium-linux/fast/regions/region-style-inline-background-color-expected.png: Removed.
platform/chromium-mac-leopard/fast/regions/region-style-image-background-color-expected.png: Removed.
platform/chromium-mac-leopard/fast/regions/region-style-inline-background-color-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Removed.
platform/chromium-mac/fast/regions/region-style-image-background-color-expected.png: Removed.
platform/chromium-mac/fast/regions/region-style-inline-background-color-expected.png: Removed.
platform/chromium-win/fast/regions/region-style-image-background-color-expected.png: Removed.
platform/chromium-win/fast/regions/region-style-image-background-color-expected.txt: Removed.
platform/chromium-win/fast/regions/region-style-inline-background-color-expected.png: Removed.
platform/chromium-win/fast/regions/region-style-inline-background-color-expected.txt: Removed.
platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Removed.
platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Removed.
platform/mac/fast/regions/region-style-image-background-color-expected.png: Removed.
platform/mac/fast/regions/region-style-image-background-color-expected.txt: Removed.
platform/mac/fast/regions/region-style-inline-background-color-expected.png: Removed.
platform/mac/fast/regions/region-style-inline-background-color-expected.txt: Removed.

7:32 AM Changeset in webkit [116308] by commit-queue@webkit.org

3 edits
1 add in trunk

[BlackBerry] WWW-Authenticate header on 200 response pops up authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=85643

Patch by Liam Quinn <lquinn@rim.com> on 2012-05-07
Reviewed by George Staikos.

RIM PR: 151992
Added manual test for WWW-Authenticate header on a 200 response.

ManualTests/blackberry/http-auth-on-200.php: Added.

Source/WebCore:

RIM PR: 151992
Ignore WWW-Authenticate header if the response code is not 401.
Ignore Proxy-Authenticate header if the response code is not 407.

Manual test added to observe whether the authentication dialog appears on a 200 response with WWW-Authenticate.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

7:10 AM Changeset in webkit [116307] by alexis.menard@openbossa.org

2 edits
4 adds in trunk/LayoutTests

Unreviewed gardening for Qt port. Updating expectation files and skipped tests which are
timing out.

platform/qt-5.0-wk2/Skipped:
platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt: Added.
platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt: Added.
platform/qt-5.0-wk2/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.

7:06 AM Changeset in webkit [116306] by Csaba Osztrogonác

2 edits in trunk/Tools

Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.

Reviewed by Tor Arne Vestbø.

Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois):

6:38 AM Changeset in webkit [116305] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
https://bugs.webkit.org/show_bug.cgi?id=85789

Reviewed by Yury Semikhatsky.

inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):

5:58 AM Changeset in webkit [116304] by Csaba Osztrogonác

8 edits
8 deletes in trunk

Unreviewed, rolling out r116299, r116301, and r116303.
http://trac.webkit.org/changeset/116299
http://trac.webkit.org/changeset/116301
http://trac.webkit.org/changeset/116303
https://bugs.webkit.org/show_bug.cgi?id=85795

Build is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

Source/WebKit2:

qt/MainQt.cpp:

(main):

Tools:

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/main.cpp:

(main):

QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
QtTestPlatformPlugin/TestIntegration.cpp: Removed.
QtTestPlatformPlugin/TestIntegration.h: Removed.
QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
QtTestPlatformPlugin/main.cpp: Removed.
QtTestPlatformPlugin/testplatform.json: Removed.
Tools.pro:
WebKitTestRunner/Target.pri:
WebKitTestRunner/qt/main.cpp:

(main):

5:30 AM Changeset in webkit [116303] by kbalazs@webkit.org

2 edits in trunk/Tools

Unreviewed Qt build fix.

One more try to learn how to use
const with a pointer array.

DumpRenderTree/qt/main.cpp:

(initializeTestPlatformPlugin):

5:30 AM Changeset in webkit [116302] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Icon database path may be NULL when a new path was set.
https://bugs.webkit.org/show_bug.cgi?id=82456

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-05-07
Reviewed by Andreas Kling.

ewk_settings_icon_database_path_set calls asynchronous method WebCore::iconDatabase().open().
There is no notification when the new path is set by WebCore.
Moreover ewk_settings_icon_database_path_set keeps the new path in a local variable.

To retrieve path to icon database ewk_settings_icon_database_path_get can be called.
It first checks flags whether icon databse is opened and enabled. There is possibility
that icon database has been set through API but it hasn't been opened by WebCore yet.
So as a result ewk_settings_icon_database_path_get returns NULL because WebCore hasn't
set an appropriate flag yet.

It may happen while icon database set/get sequences.
Information whether icon database is opened/enabled should be exposed by separate API.

ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_get): Skip checking whether icon database is opened, enabled.

ewk/ewk_settings.h:

5:15 AM Changeset in webkit [116301] by kbalazs@webkit.org

2 edits in trunk/Tools

Unreviewed build fix after r116299.

DumpRenderTree/qt/main.cpp:

(initializeTestPlatformPlugin):

4:59 AM Changeset in webkit [116300] by alexis.menard@openbossa.org

5 edits in trunk/LayoutTests

[Qt] Enable fullscreen api layout tests on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85616

Reviewed by Csaba Osztrogonác.

http://trac.webkit.org/changeset/116089 implements the fullscreen API for WebKit2,
we can now unskip the related tests.

platform/qt-4.8/Skipped:
platform/qt-5.0-wk1/Skipped:
platform/qt-5.0-wk2/Skipped:
platform/qt/Skipped:

4:49 AM Changeset in webkit [116299] by kbalazs@webkit.org

8 edits
10 adds in trunk

[Qt] Add test specific platform plugin to achieve unified layout test results
https://bugs.webkit.org/show_bug.cgi?id=80996

Reviewed by Simon Hausmann.

Source/WebKit2:

Initialize the test platform plugin before initializing
the web process if we are in a WTR run.
It is necessary to place this initialization here as we
cannot control wich platform plugin will be used after
the instantiation of the QApplication.

qt/MainQt.cpp:

(initializeTestPlatformPluginForWTRIfRequired):
(main):

Tools:

Added QtTestPlatformPlugin as a new project under Tools.
This is a Qt5-ish platform plugin that can be used to tweak the
platform support interfaces in order to unify layout test results.
For now it only overrides the font database on Mac and redirects
everything else to the real platform plugin. The font database it
provides mimics the way how we set up test fonts with fontconfig on Linux.
Make DumpRenderTree and WebKitTestRunner use this platform plugin.

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/main.cpp:

(initializeTestPlatformPlugin):
(main):

QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
QtTestPlatformPlugin/TestIntegration.cpp: Added.

(TestIntegration::TestIntegration):
(TestIntegration::fontDatabase):

QtTestPlatformPlugin/TestIntegration.h: Added.

(TestIntegration):
(TestIntegration::hasCapability):
(TestIntegration::createPlatformPixmap):
(TestIntegration::createPlatformWindow):
(TestIntegration::createPlatformBackingStore):
(TestIntegration::createPlatformOpenGLContext):
(TestIntegration::createPlatformSharedGraphicsCache):
(TestIntegration::guiThreadEventDispatcher):
(TestIntegration::clipboard):
(TestIntegration::drag):
(TestIntegration::inputContext):
(TestIntegration::accessibility):
(TestIntegration::nativeInterface):
(TestIntegration::services):
(TestIntegration::styleHint):
(TestIntegration::platformTheme):

QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.

(TestFontDatabase):

QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.

(TestFontDatabase::populateFontDatabase):

QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.

(TestIntegration::fontDatabase):

QtTestPlatformPlugin/main.cpp: Added.

(TestIntegrationPlugin::keys):
(TestIntegrationPlugin::create):
(TestIntegrationPlugin::initialize):

QtTestPlatformPlugin/testplatform.json: Added.
Tools.pro:
WebKitTestRunner/Target.pri:
WebKitTestRunner/qt/main.cpp:

(main):

4:43 AM Changeset in webkit [116298] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Buildfix for buggy GCC
https://bugs.webkit.org/show_bug.cgi?id=85781

Reviewed by Zoltan Herczeg.

rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginInfo::clearMargin):

4:34 AM Changeset in webkit [116297] by commit-queue@webkit.org

2 edits
4 deletes in trunk/LayoutTests

[EFL][DRT] Gardening current IMAGE failures
https://bugs.webkit.org/show_bug.cgi?id=85604

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-07

platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Removed.
platform/efl/fast/forms/isindex-placeholder-expected.png: Removed.
platform/efl/fast/forms/placeholder-with-positioned-element-expected.png: Removed.
platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
platform/efl/test_expectations.txt:

4:26 AM Changeset in webkit [116296] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85609

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-07
Reviewed by Simon Hausmann.

Flakiness was caused by the fact that
media/crash-closing-page-with-media-as-plugin-fallback.html and
media/video-poster-blocked-by-willsendrequest.html use the same PNG
file as poster attribute in the video tag. The PNG file gets cached
when the first test is executed and this somehow causes the second
test to fail.

The flakiness was addressed by clearing the memory and page caches
between tests.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

4:21 AM Changeset in webkit [116295] by caseq@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening, refined expectations for compositing failures + more suppressions.

platform/chromium/test_expectations.txt:

4:13 AM Changeset in webkit [116294] by eric@webkit.org

2 edits in trunk/Tools

Add values for all features to Qt's features.pri
https://bugs.webkit.org/show_bug.cgi?id=85746

Reviewed by Tor Arne Vestbø.

When generate-feature-files generates features.pri it provides a value
for every possible ENABLE_. In prepration for landing generate-feature-files
it seems appropriate to add a value for all possible ENABLEs to the existing
features.pri. This lets me make sure that I'm getting them all right!

qmake/mkspecs/features/features.pri:

3:30 AM Changeset in webkit [116293] by apavlov@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Context menu for the left Script view gutter is broken
https://bugs.webkit.org/show_bug.cgi?id=85785

Reviewed by Pavel Feldman.

Fixed remaining usages of WebInspector.save to be WebInspector.fileManager.save.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):

inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):

inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):

3:07 AM Changeset in webkit [116292] by caseq@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening, more compositing test timeouts.

platform/chromium/test_expectations.txt:

2:56 AM Changeset in webkit [116291] by Antti Koivisto

29 edits
6 adds in trunk

Share stylesheet data structures between documents
https://bugs.webkit.org/show_bug.cgi?id=85598

Source/WebCore:

Reviewed by Darin Adler.

We currently make a copy of the data structures when restoring a cached stylesheet. This patch lets us share
the data until someone uses a mutating CSSOM API to modify the sheet.

The patch implements copy-on-write for the internal style sheet data structures. If any mutating CSSOM API is
invoked, we check if the mutation is safe (there is only one client, the sheet is not cached). If not then the
internal structures are copied and any existing CSSOM objects are re-attached to the new style tree. The copied
tree is mutated while the other clients stay attached to the original tree.

Sharing can save significant amount of memory on sites with large stylesheets. For example if you have
multiple articles open on wsj.com this saves ~2.6MB per tab.

Test: http/tests/css/shared-stylesheet-mutation.html

http/tests/css/shared-stylesheet-mutation-preconstruct.html

css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):
(WebCore):

css/CSSFontFaceRule.h:

(CSSFontFaceRule):

css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::reattach):
(WebCore):

css/CSSMediaRule.h:

(CSSMediaRule):

css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::reattach):
(WebCore):

css/CSSPageRule.h:

(CSSPageRule):

css/CSSRule.cpp:

(WebCore::CSSRule::reattach):

After the internal stylerule tree has been copied, the existing wrappers are re-attached using recursive reattach() function.

css/CSSRule.h:

(WebCore):
(CSSRule):

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::reattach):
(WebCore):

css/CSSStyleRule.h:

(CSSStyleRule):

css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::ruleAt):

Add ruleAt(), use it for both wrapper creation and reattaching. Remove createChildRuleCSSOMWrapper .

(WebCore):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):

Invalidation moves to the calling wrapper.

(WebCore::StyleSheetInternal::addedToMemoryCache):
(WebCore::StyleSheetInternal::removedFromMemoryCache):
(WebCore::CSSStyleSheet::willMutateRules):

This is called whenever StyleSheetInternal is going to be mutated. It will do copy-on-write if needed.

Usually invoked by CSSStyleSheet::RuleMutation RAII type.

(WebCore::CSSStyleSheet::didMutateRules):

This is called after the mutation is complete and will trigger the style recalc in the document.

(WebCore::CSSStyleSheet::didMutate):

This is called directly after mutations that don't change StyleSheetInternal so don't require copy-on-write.

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasOneClient):
(WebCore::StyleSheetInternal::isMutable):
(WebCore::StyleSheetInternal::setMutable):

Track mutability. Mutation is allowed only after willMutate call.

(WebCore::StyleSheetInternal::isInMemoryCache):

Track if the object is in memory cache.

(WebCore::CSSStyleSheet::clearOwnerRule):
(CSSStyleSheet):

css/MediaList.cpp:

(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::didMutate):
(WebCore):
(WebCore::MediaList::reattach):

css/MediaList.h:

(MediaList):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
(WebCore::InlineCSSStyleDeclaration::didMutate):

css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::willMutate):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(StyleRuleCSSStyleDeclaration):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore):

css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reattach):

css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

Don't copy when restoring. It is no longer necessary.
Set the cache bit on the stylesheet.

(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

Reviewed by Darin Adler.

Test that mutations of a shared stylesheet work as expected.

This is an http test due to cross-document security restrictions with file urls
(they can be overriden in DRT but I'd like this to work in browser too).

http/tests/css/resources/shared.css: Added.
http/tests/css/resources/shared-stylesheet-mutation.js: Added.
http/tests/css/shared-stylesheet-mutation-expected.txt: Added.
http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Added.
http/tests/css/shared-stylesheet-mutation-preconstruct.html: Added.
http/tests/css/shared-stylesheet-mutation.html: Added.

2:47 AM Changeset in webkit [116290] by kinuko@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed: the same fix in another file for chromium win build. Adding WebCore namespace to FileSystemTypes.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

2:46 AM Changeset in webkit [116289] by caseq@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening, fast/text/international/thai-{baht-space,line-breaks}.html now fail in release, too.

platform/chromium/test_expectations.txt:

2:31 AM Changeset in webkit [116288] by adam.bergkvist@ericsson.com

2 edits in trunk/Tools

Added myself as a committer.

Not reviewed.

Scripts/webkitpy/common/config/committers.py:

2:29 AM Changeset in webkit [116287] by kinuko@chromium.org

2 edits in trunk/Source/WebKit/chromium

Not reviewed: chromium win build fix attempt; adding WebCore namespace to ambiguous type name.

src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):

2:21 AM Changeset in webkit [116286] by Simon Hausmann

2 edits in trunk

[Qt] Unreviewed trivial build fix: Don't include bytearraytestdata.h in the QtWebKit
module header.

Source/sync.profile:

2:20 AM Changeset in webkit [116285] by commit-queue@webkit.org

8 edits in trunk

[EFL][DRT] Implement LayoutTestController::execCommand
https://bugs.webkit.org/show_bug.cgi?id=82286

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-07
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add missing implementation execCommand and isCommandEnabled to EFL's
DumpRenderTreeSupport to execute an internal command and check if the
command is enabled.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::isCommandEnabled):

WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation execCommand and isCommandEnabled to EFL's
LayoutTestController.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):

LayoutTests:

Unskipped test cases which rely on execCommand and
updated test expectations for failure test cases.

platform/efl/Skipped:
platform/efl/test_expectations.txt:

2:17 AM Changeset in webkit [116284] by caseq@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening, compositing/overflow/scrollbar-painting.html times out on mac & linux.

platform/chromium/test_expectations.txt:

1:57 AM Changeset in webkit [116283] by kinuko@chromium.org

13 edits in trunk/Source

Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code
https://bugs.webkit.org/show_bug.cgi?id=85741

Reviewed by David Levin.

Source/WebCore:

No new tests as this change has no functional effects.

Modules/filesystem/DOMWindowFileSystem.cpp:

(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):

Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::requestFileSystem):

Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

platform/FileSystemType.h: Added FileSystemSynchronousType enum.

Source/WebKit/chromium:

src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):

src/WebFileSystemCallbacksImpl.h:

(WebFileSystemCallbacksImpl):

src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

src/WorkerAsyncFileSystemChromium.h:

(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

1:42 AM Changeset in webkit [116282] by Antti Koivisto

2 edits in trunk/Source/WebCore

Revert the previous.

Not reviewed.

Apparently r116235 was already rolled out.

css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

1:13 AM Changeset in webkit [116281] by Antti Koivisto

2 edits in trunk/Source/WebCore

REGRESSION(r116235): broke a lot of tests on all chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=85773

Not reviewed.

Try to fix assert when scoped stylesheets are enabled.

css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

12:39 AM Changeset in webkit [116280] by kinuko@chromium.org

23 edits
1 copy in trunk/Source

Cleanup: Move FileSystem API type definitions into a separate header file
https://bugs.webkit.org/show_bug.cgi?id=85738

Reviewed by David Levin.

Move FileSystem API type definitions from AsyncFileSystem.h and
AsyncFileSystemChromium.cpp for chromium port into a single separate
header file: FileSystemType.h

By doing this we make it clearer that every filesystem type can be
found in the header file and also can save including entire
AsyncFileSystem definition just for referring type enum value.

Source/WebCore:

No new tests as this change has no visible or functional changes.

Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::pathToAbsolutePath):

Modules/filesystem/DOMWindowFileSystem.cpp:

(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):
(WebCore):

Modules/filesystem/DOMWindowFileSystem.h:
Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

Modules/filesystem/WorkerContextFileSystem.cpp:

Modules/filesystem/WorkerContextFileSystem.h:
platform/AsyncFileSystem.cpp:

(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):

platform/AsyncFileSystem.h:

(AsyncFileSystem):
(WebCore::AsyncFileSystem::type):
(WebCore::AsyncFileSystem::AsyncFileSystem):

platform/FileSystemType.h: Added.

(WebCore):

platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):

platform/blackberry/AsyncFileSystemBlackBerry.h:

(AsyncFileSystemBlackBerry):

platform/gtk/AsyncFileSystemGtk.cpp:

platform/gtk/AsyncFileSystemGtk.h:

(AsyncFileSystemGtk):

Source/WebKit/chromium:

src/AssertMatchingEnums.cpp:
src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
(WebCore::AsyncFileSystemChromium::createIsolatedFileSystem):
(WebCore::AsyncFileSystemChromium::toURL):

src/AsyncFileSystemChromium.h:

(WebCore::AsyncFileSystemChromium::create):
(AsyncFileSystemChromium):

src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):

src/WebFileSystemCallbacksImpl.h:

(WebFileSystemCallbacksImpl):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):

src/WorkerAsyncFileSystemChromium.h:

(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed