Timeline
May 9, 2012:
- 11:42 PM Changeset in webkit [116612] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-05-09
Reviewed by Adam Barth.
Adds a method that can be used to override the normal user agent in
chromium. Also adds a unit test to check if the override is taking effect.
- WebKit.gypi:
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::userAgent):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp: Added.
(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):
- 11:13 PM Changeset in webkit [116611] by
-
- 4 edits1 add in trunk
Calendar Picker: Fix a crash by changing input type.
https://bugs.webkit.org/show_bug.cgi?id=86007
Reviewed by Hajime Morita.
.:
- ManualTests/forms/calendar-picker-crash-by-type-change.html: Added.
Source/WebCore:
Manual test: forms/calendar-picker-crash-by-type-change.html
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::~CalendarPickerElement):
Added. Make sure the popup is closed.
- html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Add declaration of the destructor.
- 11:11 PM Changeset in webkit [116610] by
-
- 45 edits in trunk
Move suspendAnimations to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85986
Reviewed by Ryosuke Niwa.
.:
- Source/autotools/symbols.filter: Add a symbol filter for suspendAnimations.
Source/WebCore:
Add suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
No new tests, since we are improving here the infra-structure for testing
a specific method.
- testing/Internals.cpp:
(WebCore::Internals::suspendAnimations):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebKit.order:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Source/WebKit/qt:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp:
- WebFrame.h:
Source/WebKit2:
- win/WebKit2.def: Add a symbol filter for suspendAnimations.
Tools:
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
Call suspendAnimations functions from internals, because it is able to work in the
cross-port way through the Internals interface.
- animations/play-state-suspend.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation-events.html:
- animations/suspend-resume-animation.html:
- animations/suspend-transform-animation.html:
- transitions/suspend-transform-transition.html:
- 10:47 PM Changeset in webkit [116609] by
-
- 2 edits in trunk/Tools
[Chromium] Attempt to fix an Android build error.
https://bugs.webkit.org/show_bug.cgi?id=86045
- DumpRenderTree/DumpRenderTree.gypi:
- 10:31 PM Changeset in webkit [116608] by
-
- 9 edits1 add in trunk/Source
Source/WebCore: Add dispatchMessageEventWithOriginCheck to DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=85815
Reviewed by Adam Barth.
Useful for ports that support cross-process postMessage.
No new tests, since covered by existing postMessage tests.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
- page/DOMWindow.h:
(WebCore):
(DOMWindow):
Source/WebKit/chromium: Add dispatchMessageEventWithOriginCheck to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=85815
Reviewed by Adam Barth.
Tested by WebFrameTest.DispatchMessageEventWithOriginCheck.
Also fixes source frame bug in willCheckAndDispatchMessageEvent.
- public/WebFrame.h:
(WebFrame):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::checkAndDispatchMessageEvent):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 10:08 PM Changeset in webkit [116607] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix a crash in ContextMenuClientImpl::getCustomMenuFromDefaultItems
https://bugs.webkit.org/show_bug.cgi?id=85866
Reviewed by Ryosuke Niwa.
DocumentMarkerController::markersInRange crashes if the input range is NULL.
This change adds a NULL check before getCustomMenuFromDefaultItems() calls this
function to avoid this crash.
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a NULL check.
- 9:34 PM Changeset in webkit [116606] by
-
- 4 edits in trunk/Tools
Don't show partytime if there are non-layout test failures.
https://bugs.webkit.org/show_bug.cgi?id=86056
Reviewed by Dimitri Glazkov.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- 9:14 PM Changeset in webkit [116605] by
-
- 4 edits1 delete in trunk/Source/WebKit/chromium
Unreviewed, rolling out r116602.
http://trac.webkit.org/changeset/116602
https://bugs.webkit.org/show_bug.cgi?id=86057
Build error on Windows (Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09
- WebKit.gypi:
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp: Removed.
- 9:03 PM Changeset in webkit [116604] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix compilation warning on Android.
https://bugs.webkit.org/show_bug.cgi?id=85958
- features.gypi: Move ENABLE_MEDIA_CAPTURE=0 to non-Android block.
- 8:58 PM Changeset in webkit [116603] by
-
- 8 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Autofill feature implementation for BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=85577
Patch by Jonathan Dong <Jonathan Dong> on 2012-05-09
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::autofillTextField): Added this interface
function to auto fill the inputting text field when user selects
a autofill candidate value from autofill context dialog.
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog): Added
this interface function to notify WebPageClient to pop up the autofill
context dialog with the suggested input items.
(BlackBerry::WebKit::WebPage::clearAutofillData):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- WebCoreSupport/AutofillManager.cpp:
(WebCore::AutofillManager::didChangeInTextField):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::textDidChangeInTextField): Implemented
this function to listen to the notification of text field change, and
notify AutofillManager to handle the autofill.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
Save the name and value pair of every autofillable input text field when
user submitting a form.
- 8:44 PM Changeset in webkit [116602] by
-
- 4 edits1 add in trunk/Source/WebKit/chromium
[chromium] Add ability to override user agent string per-WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=83959
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-05-09
Reviewed by Adam Barth.
Adds a method that can be used to override the normal user agent in
chromium. Also adds a unit test to check if the override is taking effect.
- WebKit.gypi:
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::userAgent):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp: Added.
(WebKit):
(TestWebFrameClient):
(WebKit::TestWebFrameClient::setUserAgentOverride):
(FrameLoaderClientImplTest):
(WebKit::FrameLoaderClientImplTest::SetUp):
(WebKit::FrameLoaderClientImplTest::TearDown):
(WebKit::FrameLoaderClientImplTest::setUserAgentOverride):
(WebKit::FrameLoaderClientImplTest::userAgent):
(WebKit::TEST_F):
- 8:30 PM Changeset in webkit [116601] by
-
- 3 edits3 adds in trunk
[BlackBerry] Cookie parsing issue. If the cookie value provided was (") then the browser creates a session cookie instead.
https://bugs.webkit.org/show_bug.cgi?id=85775
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-09
Reviewed by Rob Buis.
Source/WebCore:
Make CookieParser::parseOneCookie handle (cookiename="cookievalue;expires=xxxx) correctly.
This cookie's value is "cookievalue not "cookievalue;expires=xxxx.
Test: http/tests/cookies/single-quoted-value.html
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
LayoutTests:
- http/tests/cookies/script-tests/single-quoted-value.js: Added.
- http/tests/cookies/single-quoted-value-expected.txt: Added.
- http/tests/cookies/single-quoted-value.html: Added.
- 8:24 PM Changeset in webkit [116600] by
-
- 2 edits in trunk/Tools
Improve a warning message for a reftest having an unused expectation file.
https://bugs.webkit.org/show_bug.cgi?id=85975
Reviewed by Adam Barth.
The current warning message is not intuitive. It might be better to update the message
so that it encourage users to remove unused expectation files.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init):
- 8:08 PM Changeset in webkit [116599] by
-
- 12 edits in trunk/Tools
Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=86043
Reviewed by Adam Barth.
-Get rid of the gtest iframe.
-Cover all non-layout test problems. Before we wouldn't catch compile failures
or gtest failures since they were not on the webkit testing bots.
-Include the list of failing steps next to the builder name. This is a lot less
cluttered than you'd expect and already helped me find a compile failure early.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
Delete unused map.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- 7:49 PM WebKit Team edited by
- Adding Charles Reis as committer. (diff)
- 7:48 PM Changeset in webkit [116598] by
-
- 1 edit4 deletes in trunk/LayoutTests
Remove unused test expectation files.
https://bugs.webkit.org/show_bug.cgi?id=85973
Reviewed by Ojan Vafai.
Since cell-shrinkback.html is a reftest, these txt and png
expectations files are not used by test runner and cause warning messages when running tests.
- platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Removed.
- platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Removed.
- platform/qt/fast/multicol/cell-shrinkback-expected.png: Removed.
- platform/qt/fast/multicol/cell-shrinkback-expected.txt: Removed.
- 7:45 PM Changeset in webkit [116597] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Added myself as a committer.
- 7:32 PM Changeset in webkit [116596] by
-
- 3 edits in trunk/Source/WebCore
Add multi-channels support for CopyWithGainFrom in AudioBus
https://bugs.webkit.org/show_bug.cgi?id=80675
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-05-09
Reviewed by Chris Rogers.
- platform/audio/AudioBus.cpp:
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::copyWithGainFrom):
- platform/audio/AudioBus.h:
(AudioBus):
- 7:00 PM Changeset in webkit [116595] by
-
- 24 edits1 copy3 adds in trunk
Crash using the new WKBundleDOMWindowExtensions APIs.
https://bugs.webkit.org/show_bug.cgi?id=85888
Reviewed by Brady Eidson.
Source/WebCore:
WKBundlePageWillDestroyGlobalObjectForDOMWindowExtensionCallback was only being invoked when
the WKPage was destroyed, and then only for the child frames. In addition, the
DOMWindowExtension was holding onto a destroyed DOMWindow and attempting to unregister from
when the WK2 wrapper object was attempting to destroy the DOMWindowExtension.
The underlying issue here was that the DOMWindowProperties were getting disconnectFrame
and willDetachPage called on them at the wrong times.
Rename DOMWindowProperty::disconnectFrame and reconnectFrame to disconnectFrameForPageCache
and reconnectFrameFromPageCache for clarity.
Only invoke DOMWindowProperty::disconnectFrameForPageCache when the frame is going into the
page cache.
In the cases where the DOMWindow is getting destroyed, the frame is being destroyed, or the
DOMWindow is getting cleared because the frame is being navigated, invoke
DOMWindowProperty::willDestroyGlobalObjectInFrame instead of disconnectFrame.
Invoke DOMWindowProperty::willDetachGlobalObjectFromFrame when a document is being detached
because the frame has been detached (e.g. fast/storage/storage-detached-iframe.html) and
won't be immediately destroyed.
Invoke DOMWindowProperty::willDestroyGlobalObjectInCachedFrame when a cached frame is
being destroyed.
New WK2 API Test: DOMWindowExtensionNoCache.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::disconnectFrameForPageCache):
Updated for disconnectFrame rename.
(WebCore::DOMWindowIndexedDatabase::reconnectFrameFromPageCache):
Updated for reconnectFrame rename.
(WebCore::DOMWindowIndexedDatabase::willDestroyGlobalObjectInCachedFrame):
Get rid of the suspended IDBFactory.
(WebCore::DOMWindowIndexedDatabase::willDestroyGlobalObjectInFrame):
Get rid of the IDBFactory.
(WebCore::DOMWindowIndexedDatabase::willDetachGlobalObjectFromFrame):
Ditto.
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
Tell the DOMWindow before detaching the Document.
- dom/Document.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrame::destroy):
Tell the DOMWindow.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
Use Document::prepareForDestruction so that the DOMWindow is told about the main frame
navigation before detaching the Document.
- loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::disconnectFrameForPageCache):
Updated for the disconnectFrame rename.
(WebCore::DOMApplicationCache::reconnectFrameFromPageCache):
Updated for the reconnectFrame rename.
(WebCore::DOMApplicationCache::willDestroyGlobalObjectInFrame):
Cover the cases formerly covered by disconnectFrame (which was sometimes being called when
called when the frame was destroyed).
- loader/appcache/DOMApplicationCache.h:
- notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrameForPageCache):
Updated for the disconnectFrame rename.
(WebCore::DOMWindowNotifications::reconnectFrameFromPageCache):
Updated for the reconnectFrame rename.
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInCachedFrame):
Get rid of the suspended notification center.
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInFrame):
Get rid of the notification center.
(WebCore::DOMWindowNotifications::willDetachGlobalObjectFromFrame):
Do not allow use of the notification center by detached frames.
- notifications/DOMWindowNotifications.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::clearDOMWindowProperties):
Do not call disconnectDOMWindowProperties. It is now the responsibility of the callers to
tell the DOMWindowProperties the correct cause of being cleared.
(WebCore::DOMWindow::~DOMWindow):
Make sure the DOMWindowProperties still know that the DOMWindow is going away.
(WebCore::DOMWindow::frameDestroyed):
Invoke willDestroyGlobalObjectInFrame on the DOMWindowProperties.
(WebCore::DOMWindow::willDetachPage):
It is no longer necessary to tell the DOMWindowProperties anything here.
(WebCore::DOMWindow::willDestroyCachedFrame):
Tell the DOMWindowProperties.
(WebCore::DOMWindow::willDestroyDocumentInFrame):
Ditto.
(WebCore::DOMWindow::willDetachDocumentFromFrame):
Ditto.
(WebCore::DOMWindow::clear):
Ditto.
(WebCore::DOMWindow::disconnectDOMWindowProperties):
Updated for the disconnectFrame rename.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
Ditto.
- page/DOMWindow.h:
- page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
Move the responsibility for tracking the disconnected DOMWindow to DOMWindowProperty, since
DOMWindowProperty will need it to unregister the property when a cached frame is destroyed.
(WebCore::DOMWindowExtension::disconnectFrameForPageCache):
Remove the code to check for disconnectFrame being called twice - it is now only called when
a frame goes into the page cache.
Let the DOMWindowProperty keep track of the disconnected DOMWindow.
(WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
Let the DOMWindowProperty keep track of the disconnected DOMWindow.
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
Dispatch the willDestroyGlobalObjectForDOMWindowExtension callback.
(WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
Ditto, but only if the callback hasn't already been sent because the frame has been detached.
(WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
Send the callback because nothing interesting can be done in the frame once it has been
detached.
- page/DOMWindowExtension.h:
- page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::DOMWindowProperty):
Keep track of the disconnected DOMWindow so it can be used to unregister the property when a
cached frame is destroyed.
(WebCore::DOMWindowProperty::~DOMWindowProperty):
Also unregister the property when a DOMWindowProperty for a cached frame is destroyed.
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
Keep track of the disconnected DOMWindow.
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
Unregister the property from the disconnected DOMWindow.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
Unregister the property from the DOMWindow and stop keeping track of the frame.
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):
Do not set m_frame to 0 because detached frames still have access to the DOMWindow, even if
they can't do anything meaningful with it.
- page/DOMWindowProperty.h:
- page/Frame.cpp:
(WebCore::Frame::setView):
Tell the DOMWindow that the Document is being detached so it can tell the
DOMWindowProperties.
- page/PointerLock.cpp:
(WebCore::PointerLock::disconnectFrameForPageCache):
Updated for disconnectFrame rename.
(WebCore::PointerLock::willDestroyGlobalObjectInFrame):
Cover the cases formerly covered by disconnectFrame (which was sometimes being called when
called when the frame was destroyed).
- page/PointerLock.h:
Tools:
Cached frames can live slightly longer than the page, but most clients unregister themselves
and do other cleanup in the willDestroyPage callback, making them miss the
willDestroyGlobalObjectForDOMWindowExtension callbacks.
The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
pages that don't go into the page cache.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
and simple-iframe-unload.html
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
(TestWebKitAPI):
Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Do not bother to keep track of the live extension count - all of them are expected to be
live until the test completes.
(TestWebKitAPI::TEST):
Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
message failures will be clearer.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
Clean up the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
Add an ASSERT_NOT_REACHED.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Keep track of the messages received so they can be checked at the end of the test.
(TestWebKitAPI::TEST):
Navigate to uncacheable pages and back.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
(DOMWindowExtensionNoCache):
(TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
Set up all the states for each BundleDOMWindowExtension.
(TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
Tell the UI Process about the states of the BundleDOMWindowExtensions.
(TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
(TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
(TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
(TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
ASSERT that these pages not going into the page cache are not getting disconnected to go into
the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
Ditto about getting reconnected when coming out of the page cache.
(TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
- TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
- TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
- 6:52 PM Changeset in webkit [116594] by
-
- 12 edits in trunk/Source
[chromium] Ensure animations get ticked at least once when added.
https://bugs.webkit.org/show_bug.cgi?id=86013
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.
Source/WebCore:
Tested in
CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didAddAnimation):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(CCSingleThreadProxyAnimationTimer):
(WebCore::CCSingleThreadProxyAnimationTimer::create):
(WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer):
(WebCore):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):
- 6:31 PM Changeset in webkit [116593] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT memory allocator is not returning memory to the OS on Darwin
https://bugs.webkit.org/show_bug.cgi?id=86047
<rdar://problem/11414948>
Reviewed by Geoff Garen.
Work around the problem by using a different madvise() flag, but only for the JIT memory
allocator. Also put in ASSERTs that the call is actually working.
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyNeedPage):
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
- 6:21 PM Changeset in webkit [116592] by
-
- 18 edits2 adds in trunk
Implement HTML Media Capture
https://bugs.webkit.org/show_bug.cgi?id=85958
Reviewed by Eric Seidel.
Source/WebCore:
This patch begins the implementation of
http://www.w3.org/TR/html-media-capture/ by adding the capture
attribute to HTMLInputElement.
Test: fast/forms/file/file-input-capture.html
- html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
- html/HTMLAttributeNames.in:
- html/HTMLInputElement.cpp:
(WebCore):
(WebCore::HTMLInputElement::capture):
(WebCore::HTMLInputElement::setCapture):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLInputElement.idl:
- platform/FileChooser.h:
(FileChooserSettings):
Source/WebKit/chromium:
- features.gypi:
- public/WebFileChooserParams.h:
(WebFileChooserParams):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):
LayoutTests:
- fast/forms/file/file-input-capture-expected.txt: Added.
- fast/forms/file/file-input-capture.html: Added.
- Test that the capture attribute works properly.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- Skip the test on all platforms. The feature is enabled only on Android, which isn't yet able to run LayoutTests upstream.
- 6:13 PM Changeset in webkit [116591] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Refactor data scheme support
https://bugs.webkit.org/show_bug.cgi?id=85938
Reviewed by Rob Buis.
We will create a DataStream in our platform repository,
so that can be wrapped up by NetworkJob for webkit rendering,
and by DownloadStream for downloading.
Refactor, no new tests.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::cancelJob):
(WebCore::NetworkJob::sendResponseIfNeeded):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 6:01 PM Changeset in webkit [116590] by
-
- 2 edits in trunk/Tools
[Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
https://bugs.webkit.org/show_bug.cgi?id=86045
Reviewed by Eric Seidel.
- DumpRenderTree/DumpRenderTree.gypi:
- 5:56 PM Changeset in webkit [116589] by
-
- 2 edits in trunk/Tools
[Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
https://bugs.webkit.org/show_bug.cgi?id=86041
Reviewed by Eric Seidel.
- DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
- 5:51 PM Changeset in webkit [116588] by
-
- 2 edits in trunk/Tools
[Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
https://bugs.webkit.org/show_bug.cgi?id=86040
Reviewed by Kent Tamura.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage):
- 5:41 PM Changeset in webkit [116587] by
-
- 7 edits in trunk/Source
[chromium] Don't draw when canDraw() is false
https://bugs.webkit.org/show_bug.cgi?id=85829
Reviewed by Adrienne Walker.
Source/WebCore:
This is based on the work of Daniel Sievers in bug
https://bugs.webkit.org/show_bug.cgi?id=82680. When canDraw() is false,
we should not call drawLayers() or prepareToDraw() in both Single- and
Multi-Threaded mode.
drawLayers() is crashing in single threaded mode, and this attempts to
prevent it from being called with invalid state. While making it behave
properly in single-threaded mode, it seems appropriate to unrevert the
parts of 82680 that made threaded mode behave similarly appropriately.
A single-threaded test is not included since LTHTests is unable to run
in single-threaded mode at this time (pending work from Ian Vollick). So
we test in threaded mode only with a note to include a single thread
version.
Tests: CCLayerTreeHostTestCanDrawBlocksDrawing.runMultiThread
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
(WTF::TEST_F):
- 5:35 PM Changeset in webkit [116586] by
-
- 2 edits in trunk/Tools
[EFL] Build fix after r116464.
`ulong' is a type defined by glibc, so it is not very
portable. Use `unsigned long' instead.
- DumpRenderTree/efl/EventSender.cpp:
(DelayedEvent::DelayedEvent):
(DelayedEvent):
(leapForwardCallback):
- 5:34 PM Changeset in webkit [116585] by
-
- 3 edits in trunk/Source/WebCore
[Cairo] GLContextGLX releases the context with an uninitialized display
https://bugs.webkit.org/show_bug.cgi?id=86039
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-09
Reviewed by Philippe Normand.
No new tests. This does not change behavior on most machines, but has
the potential to prevent a pretty nasty crash on others.
Use the shared display to release GLX contexts instead of the uninitialized
m_display member.
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::~GLContextGLX): Release the display with the shared
display.
- platform/graphics/glx/GLContextGLX.h:
(GLContextGLX): Remove the m_display member.
- 5:32 PM Changeset in webkit [116584] by
-
- 3 edits6 adds in trunk
Subresources loaded after a reload completes shouldn't be revalidated.
https://bugs.webkit.org/show_bug.cgi?id=84614
Source/WebCore:
Based on patch by Darin Fisher.
Reviewed by Darin Fisher.
Tests: http/tests/cache/loaded-from-cache-after-reload-within-iframe.html
http/tests/cache/loaded-from-cache-after-reload.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Reset m_loadType after the load completes.
LayoutTests:
Tests by Darin Fisher.
Reviewed by Darin Fisher.
- http/tests/cache/loaded-from-cache-after-reload-expected.txt: Added.
- http/tests/cache/loaded-from-cache-after-reload-within-iframe-expected.txt: Added.
- http/tests/cache/loaded-from-cache-after-reload-within-iframe.html: Added.
- http/tests/cache/loaded-from-cache-after-reload.html: Added.
- http/tests/cache/resources/loaded-from-cache-after-reload-within-iframe-subframe.html: Added.
- http/tests/cache/resources/random-cached.cgi: Added.
- 5:19 PM Changeset in webkit [116583] by
-
- 4 edits in trunk/Source
It should be possible to get useful debug logging from the JIT memory allocator
https://bugs.webkit.org/show_bug.cgi?id=86042
Reviewed by Geoff Garen.
Source/JavaScriptCore:
- jit/ExecutableAllocator.h:
Source/WTF:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::dumpProfile):
- 5:18 PM Changeset in webkit [116582] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r116573.
http://trac.webkit.org/changeset/116573
https://bugs.webkit.org/show_bug.cgi?id=86038
Broke the Chromium Mac compile (Requested by ojan_gardening on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09
- public/WebPlugin.h:
(WebPlugin):
- 5:15 PM Changeset in webkit [116581] by
-
- 4 edits in trunk/Tools
[Chromium] LayoutTestController should use ENABLE guards for some features
https://bugs.webkit.org/show_bug.cgi?id=86030
Reviewed by Eric Seidel.
These features are disabled on OS(ANDROID) and so shouldn't be compiled
when the feature is off.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- 5:14 PM Changeset in webkit [116580] by
-
- 2 edits in trunk/Source/WebCore
[V8] Fix issue where V8BindingPerContextData could keep the context object alive
https://bugs.webkit.org/show_bug.cgi?id=86036
Reviewed by Kentaro Hara.
This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
the layout tests that were introduced since it turns out that
http://trac.webkit.org/changeset/114989 fixes the tests too.
Covered by: http/tests/security/isolatedWorld/context-destroy.html
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
- 5:12 PM Changeset in webkit [116579] by
-
- 2 edits in trunk/Source/WebCore
Speed up some parts of TileCache drawing
https://bugs.webkit.org/show_bug.cgi?id=86033
<rdar://problem/10919373>
Reviewed by Sam Weinig.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileCoverageRect):
If we can't have scrollbars, there's not much need to extend the tile coverage rect outside of the visible rect, since it's
unlikely that we'll do any form of scrolling here.
(WebCore::TileCache::revalidateTiles):
Don't update the tile layer frame if it's big enough to contain the tile size. Also, if there are no new tiles created,
don't call platformCALayerDidCreateTiles since that will trigger an extra layer flush.
- 5:11 PM WebKitGTK/1.8.x edited by
- (diff)
- 5:04 PM Changeset in webkit [116578] by
-
- 2 edits in trunk/Source/JavaScriptCore
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034
Build fix.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- Eeeep, landed bad version of patch!
- 5:01 PM Changeset in webkit [116577] by
-
- 1 edit in branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp
Merge 116339 - Fix containerForRepaint() assumption about non-null enclosingLayer()
https://bugs.webkit.org/show_bug.cgi?id=85807
Reviewed by Simon Fraser.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10378082
- 4:57 PM Changeset in webkit [116576] by
-
- 1 edit2 deletes in branches/chromium/1132
Revert 114320 - [V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831
Reviewed by Nate Chapin.
Source/WebCore:
Test: http/tests/security/isolatedWorld/context-destroy.html
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):
LayoutTests:
- http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
- http/tests/security/isolatedWorld/context-destroy.html: Added.
TBR=arv@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386064
- 4:56 PM Changeset in webkit [116575] by
-
- 2 edits in trunk/Source/JavaScriptCore
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034
Reviewed by Filip Pizlo.
The bug here is basically:
if (weakref) weakref->method()
where a GC may occur between the if & the method call.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- 4:44 PM Changeset in webkit [116574] by
-
- 4 edits in trunk
setPageScaleFactor should setScrollPosition if scale is unchanged
https://bugs.webkit.org/show_bug.cgi?id=84400
Patch by Alexandre Elias <aelias@google.com> on 2012-05-09
Reviewed by Adam Barth.
Previously, setPageScaleFactor forgot about its "origin" argument if
the page scale factor is unchanged. This has proven undesirable in
practice because, for example, a single pinch gesture may zoom in and
back out to the original page scale factor, but at a different scroll
offset.
New test case added to scale-and-scroll-body-expected.txt
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- 4:33 PM Changeset in webkit [116573] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916
Reviewed by Darin Fisher.
The browser plugin needs to access its current guest's WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.
- public/WebPlugin.h:
(WebPlugin):
(WebKit::WebPlugin::container):
- 4:22 PM Changeset in webkit [116572] by
-
- 7 edits in trunk/Tools
Fix overzealous re-opened since blocked by... message
https://bugs.webkit.org/show_bug.cgi?id=86020
Reviewed by Adam Barth.
Changed CreateBug behavior to only re-open a blocked bug if it
was RESOLVED. Also had to update the test infrastructure slightly
to allow for distinct mock commit revisions, so one could point
to a RESOLVED bug for testing while another pointed to an OPEN bug.
Also moved default created mock bug to be 60001 instead of 50004
which already exists as a reference mock bug.
- Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.init):
(MockCheckout.commit_info_for_revision):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.create_bug):
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
(test_create_rollout_resolved):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
- Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run):
- 4:10 PM Changeset in webkit [116571] by
-
- 10 edits6 adds in trunk
Use suitable viewport values on XHTML-MP pages.
https://bugs.webkit.org/show_bug.cgi?id=85425
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.
.:
Add LEGACY_VIEWPORT_ADAPTION use feature to cmake build system,
this feature will enable the use of a suitable viewport size
on legacy XHTML-MP pages.
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
Tests: fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html
fast/viewport/viewport-legacy-xhtmlmp-ordering.html
fast/viewport/viewport-legacy-xhtmlmp.html
Use device-width and device-height as viewport size on
XHTML-MP pages if the use feature LEGACY_VIEWPORT_ADAPTION
is set according as the non normative section of
http://www.w3.org/TR/css-device-adapt/
- dom/Document.cpp:
(WebCore::Document::setDocType):
Tools:
Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
- qmake/mkspecs/features/features.prf:
LayoutTests:
Add tests for legacy viewport adaption and skip them
on all ports but the Qt one.
- fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
- fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt: Added.
- fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html: Added.
- fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt: Added.
- fast/viewport/viewport-legacy-xhtmlmp-ordering.html: Added.
- fast/viewport/viewport-legacy-xhtmlmp.html: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- 4:06 PM Changeset in webkit [116570] by
-
- 10 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86025
RTL and vertical text documents do no scroll properly with the new
tiled scrolling model
-and corresponding-
<rdar://problem/11077589>
Reviewed by Dan Bernstein.
Most of the fix here is just to teach the scrolling tree about the
scroll origin.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
- page/scrolling/ScrollingCoordinator.h:
(ScrollParameters):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::scrollOrigin):
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setScrollOrigin):
(WebCore):
- page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::scrollOrigin):
(ScrollingTreeState):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
Teaching the scrolling tree about the scroll origin revealed this pre-
existing bug. layoutOverflowRect() is not the right rect to use since
it is not writing-mode savvy. unscaledDocumentRect() is the right rect
for the view's bounds.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
- 3:53 PM Changeset in webkit [116569] by
-
- 2 edits in trunk/Source/WebCore
Cleanup SVGElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=86004
Reviewed by Eric Seidel.
Remove unneeded includes. We do not need to check attr in SVGElement::attributeChanged,
lower layers assume it is non-null and we do not call attributeChanged in SVG.
- svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::isAnimatableAttribute):
- 3:52 PM Changeset in webkit [116568] by
-
- 1 add in branches/chromium/1132/codereview.settings
adding for easy drovering
- 3:51 PM Changeset in webkit [116567] by
-
- 1 copy in branches/chromium/1132
chromium branch for M20
- 3:50 PM Changeset in webkit [116566] by
-
- 18 edits3 copies in trunk/Source
[Chromium] Move clipboard to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85758
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::clipboard):
- chromium/public/WebClipboard.h: Added.
(WebKit):
(WebClipboard):
(WebKit::WebClipboard::sequenceNumber):
(WebKit::WebClipboard::isFormatAvailable):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::readPlainText):
(WebKit::WebClipboard::readHTML):
(WebKit::WebClipboard::readImage):
(WebKit::WebClipboard::readCustomData):
(WebKit::WebClipboard::writePlainText):
(WebKit::WebClipboard::writeHTML):
(WebKit::WebClipboard::writeURL):
(WebKit::WebClipboard::writeImage):
(WebKit::WebClipboard::writeDataObject):
(WebKit::WebClipboard::~WebClipboard):
- chromium/public/WebDragData.h: Added.
(WebKit):
(WebDragData):
(WebKit::WebDragData::~WebDragData):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
(WebKit::WebDragData::isNull):
- chromium/public/WebImage.h: Added.
(WebKit):
(WebImage):
(WebKit::WebImage::~WebImage):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
(WebKit::WebImage::getSkBitmap):
(WebKit::WebImage::init):
(WebKit::WebImage::getCGImageRef):
Source/WebKit/chromium:
- WebKit.gyp:
- public/platform/WebClipboard.h:
- public/platform/WebDragData.h:
- public/platform/WebImage.h:
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
- src/AssertMatchingEnums.cpp:
- src/DragClientImpl.cpp:
- src/PlatformSupport.cpp:
- src/WebDragData.cpp:
- src/WebImageCG.cpp:
- src/WebImageDecoder.cpp:
- src/WebImageSkia.cpp:
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::copy):
- src/WebViewImpl.cpp:
- 3:50 PM Changeset in webkit [116565] by
-
- 2 edits in trunk/Source/JavaScriptCore
CopiedSpace does not add pinned blocks back to the to-space filter
https://bugs.webkit.org/show_bug.cgi?id=86011
Reviewed by Geoffrey Garen.
After a collection has finished, we go through the blocks in from-space
and move any of them that are pinned into to-space. At the beginning of
collection, we reset the to-space block filter that is used during
conservative scanning and add back the blocks that are filled during the
collection. However, we neglect to add back those blocks that are moved
from from-space to to-space, which can cause the conservative scan to
think that some pinned items are not actually in CopiedSpace.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::doneCopying): Add the pinned blocks back to the
to-space filter. Also added a comment and assert for future readers that
indicates that it's okay that we don't also add the block to the
to-space block set since it was never removed.
- 3:45 PM Changeset in webkit [116564] by
-
- 1 edit4 adds in trunk/PerformanceTests
add some basic perf-o-matic tests for flexbox
https://bugs.webkit.org/show_bug.cgi?id=86017
Reviewed by Ryosuke Niwa.
Each of these tests take < 3s on my machine.
- Layout/flexbox-column-nowrap.html: Added.
- Layout/flexbox-column-wrap.html: Added.
- Layout/flexbox-row-nowrap.html: Added.
- Layout/flexbox-row-wrap.html: Added.
- 3:13 PM Changeset in webkit [116563] by
-
- 12 edits4 adds in trunk
When creating a new page during a navigation, prime the initial document with the correct referrer policy
https://bugs.webkit.org/show_bug.cgi?id=86001
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/referrer-policy-redirect-link.html
- dom/Document.h:
(WebCore::Document::setReferrerPolicy):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
Tools:
Store the referrer policy in the request, so the network stack can comply with it.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest):
LayoutTests:
Skip the test on all but chromium, see https://bugs.webkit.org/show_bug.cgi?id=86000
- http/tests/security/referrer-policy-redirect-link-expected.txt: Added.
- http/tests/security/referrer-policy-redirect-link.html: Added.
- http/tests/security/resources/referrer-policy-postmessage.php: Added.
- http/tests/security/resources/referrer-policy-redirect-link.html: Added.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 3:09 PM Changeset in webkit [116562] by
-
- 5 edits in trunk/Source/WebCore
IndexedDB: call abort handler when there are problems committing
https://bugs.webkit.org/show_bug.cgi?id=85841
Patch by Alec Flett <alecflett@chromium.org> on 2012-05-09
Reviewed by Ojan Vafai.
No new tests. Every existing test that calls commit() is testing
the success side of this, and this only throws when there are
LevelDB errors, which is exactly what we're trying to diagnose
with this patch.
- Modules/indexeddb/IDBBackingStore.h:
(Transaction):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
- Modules/indexeddb/IDBLevelDBBackingStore.h:
(Transaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::commit):
- 3:06 PM Changeset in webkit [116561] by
-
- 7 edits1 delete in trunk/Source
[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
https://bugs.webkit.org/show_bug.cgi?id=84417
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
- platform/graphics/chromium/ImageChromiumMac.mm: Removed.
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 3:01 PM Changeset in webkit [116560] by
-
- 25 edits in trunk/LayoutTests
Update compositing/RTL tests to fail if the root layer is shifted incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85820
Reviewed by James Robinson.
For the Chromium port, if the root layer was shifted incorrectly, the
non-composited red indicator layers would get drawn outside the root
layers bounds, making it impossible to see if the test was failing.
Also turn off overflow:hidden because compositing/ tests have mock
scrollbars. This makes it much easier to debug these tests locally.
- compositing/rtl/rtl-absolute-expected.png:
- compositing/rtl/rtl-absolute-overflow-expected.png:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled.html:
- compositing/rtl/rtl-absolute-overflow.html:
- compositing/rtl/rtl-absolute.html:
- compositing/rtl/rtl-fixed-expected.png:
- compositing/rtl/rtl-fixed-overflow-expected.png:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled.html:
- compositing/rtl/rtl-fixed-overflow.html:
- compositing/rtl/rtl-fixed.html:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- 2:56 PM Changeset in webkit [116559] by
-
- 2 edits in trunk/Tools
Remove CYGWIN=tty from environment variable as its no longer supported
https://bugs.webkit.org/show_bug.cgi?id=85791
The CYGWIN=tty environment variable is no longer supported from Cygwin
version 1.7.10. This fix avoids addition of this environment variable
for Cygwin versions greater than 1.7.9. For supporting older versions
i.e. 1.7.9 or older, the script takes care of retaining the environment
variable.
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-09
Reviewed by Adam Roben.
- Scripts/webkitdirs.pm:
(setupAppleWinEnv):
- 2:27 PM Changeset in webkit [116558] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] remove the obsolete WebFrame::referrerPolicy method
https://bugs.webkit.org/show_bug.cgi?id=86003
Reviewed by Adam Barth.
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
- 2:20 PM Changeset in webkit [116557] by
-
- 5 edits in trunk/Source/WebCore
Remove some isSVGFoo methods
https://bugs.webkit.org/show_bug.cgi?id=86009
Patch by Rob Buis <rbuis@rim.com> on 2012-05-09
Reviewed by Eric Seidel.
These are not used at the moment and were probably just copy and pasted from
isSVGFoo methods in RenderObject.h.
- rendering/RenderObject.h:
- rendering/svg/RenderSVGEllipse.h:
(RenderSVGEllipse):
- rendering/svg/RenderSVGRect.h:
(RenderSVGRect):
- rendering/svg/RenderSVGShape.h:
- 2:17 PM Changeset in webkit [116556] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Check whether an active document loader exists before accessing it
https://bugs.webkit.org/show_bug.cgi?id=85892
Reviewed by Eric Seidel.
Although FrameLoader::loadInSameDocument which invokes this
method does not have a provisional document loader, we're seeing crashes
where the FrameLoader is in provisional state, and thus
activeDocumentLoader returns 0. Lacking any understanding of how this
can happen, we do this check here to avoid crashing.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
- 2:06 PM Changeset in webkit [116555] by
-
- 15 edits in branches/dfgopt/Source/JavaScriptCore
DFG variable capture analysis should work even if the variables arose through inlining
https://bugs.webkit.org/show_bug.cgi?id=85945
Reviewed by Oliver Hunt.
This just changes how the DFG queries whether a variable is captured. It does not
change any user-visible behavior.
As part of this change, I further solidified the policy that the CFA behaves in an
undefined way for captured locals and queries about their values will not yield
reliable results. This will likely be changed in the future, but for now it makes
sense.
One fun part about this change is that it recognizes that the same variable may
be both captured and not, at the same time, because their live interval spans
inlining boundaries. This only happens in the case of arguments to functions that
capture their arguments, and this change treats them with just the right touch of
conservatism: they will be treated as if captured by the caller as well as the
callee.
Finally, this also adds captured variable reasoning to the InlineCallFrame, which
I thought might be useful for later tooling.
This is perf-neutral, since it does it does not make the DFG take advantage of this
new functionality in any way. In particular, it is still the case that the DFG will
not inline functions that use arguments reflectively or that create activations.
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::needsActivation):
(JSC::CodeBlock::argumentIsCaptured):
(JSC::CodeBlock::localIsCaptured):
(JSC::CodeBlock::isCaptured):
- bytecode/CodeOrigin.h:
(InlineCallFrame):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCFGSimplificationPhase.cpp:
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
- dfg/DFGCommon.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::nameOfVariableAccessData):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::needsActivation):
(JSC::DFG::Graph::usesArguments):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isCaptured):
- 1:27 PM Changeset in webkit [116554] by
-
- 7 edits in trunk/Source
[chromium] Add impl-thread support for fill-mode and direction css animation properties
https://bugs.webkit.org/show_bug.cgi?id=77662
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.
Source/WebCore:
Adds support for accelerating css animations with -webkit-animation-fill-mode,
and -webkit-animation-direction properties.
Tested in:
CCActiveAnimationTest.TrimTimeAlternating
CCLayerAnimationControllerTest.createReversedAnimation
CCLayerAnimationControllerTest.createAlternatingAnimation
CCLayerAnimationControllerTest.createReversedAlternatingAnimation
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::alternatesDirection):
(WebCore::CCActiveAnimation::setAlternatesDirection):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
Source/WebKit/chromium:
- tests/CCActiveAnimationTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- 1:25 PM Changeset in webkit [116553] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Reviewed by Philippe Normand.
Remove all the test expectations for tests that seem to consistently
pass on the Gtk bots but are expected to crash. Any tests that backfire
will have their bug entries updated or closed otherwise.
- platform/gtk/test_expectations.txt:
- 12:59 PM Changeset in webkit [116552] by
-
- 4 edits in trunk/Tools
nrwt: --skip-failing-tests should also skip flaky tests
https://bugs.webkit.org/show_bug.cgi?id=85941
Reviewed by Ojan Vafai.
This changes --skip-failing-tests so that we skip tests that
are believed to pass sometimes as well as tests that are
believed to always fail.
In addition, in testing this I discovered that we had lousy
test coverage of the details of retrying test failures and
--clobber-old-results, so I wrote some more tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
- Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list):
(TestPort.init):
(TestDriver.run_test):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_failing_tests):
(MainTest.test_retrying_and_flaky_tests):
- 12:48 PM Changeset in webkit [116551] by
-
- 3 edits2 adds in trunk
Crash from removal of a line break object
https://bugs.webkit.org/show_bug.cgi?id=85997
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-09
Reviewed by David Hyatt.
Source/WebCore:
Regression from r115343. That replaced a call to setNeedsLayout()
with a separate call that used a different bit during linebox
invalidation after renderer child removal. There are special cases
where layout isn't marked on parent nodes just from the removal, so
line dirtying needs to explicitly mark ancestors for layout.
- rendering/RenderObject.h:
(WebCore::RenderObject::setAncestorLineBoxDirty):
LayoutTests:
Test case to exercise crashing condition in bug 85997.
- fast/block/line-layout/line-break-removal-near-textarea-crash-expected.txt: Added
- fast/block/line-layout/line-break-removal-near-textarea-crash.html: Added
- 12:37 PM Changeset in webkit [116550] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
https://bugs.webkit.org/show_bug.cgi?id=83582
Unreviewed gardening : I don't observe crashes anymore.
- platform/qt-5.0-wk2/Skipped:
- 12:36 PM Changeset in webkit [116549] by
-
- 13 edits1 delete in trunk/Source/WebCore
Fix performance regression for floats caused by LayoutUnit change
https://bugs.webkit.org/show_bug.cgi?id=85834
Reviewed by Ojan Vafai.
Refactoring FractionalLayout types to alleviate performance issues. Explicitly
inlining constructor and operator functions in FractionalLayoutUnit, as well as
pixelSnappedIntSize and pixelSnappedIntRect (particularly hot code paths). Also
further simplifying round and ceil functions when sub-pixel layout is not enabled.
pixelSnappedIntSize was the only function defined in FractionalLayoutSize.cpp,
so it is removed.
No new tests. No change in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::toInt):
(WebCore::FractionalLayoutUnit::toFloat):
(WebCore::FractionalLayoutUnit::toDouble):
(WebCore::FractionalLayoutUnit::toUnsigned):
(WebCore::FractionalLayoutUnit::operator int):
(WebCore::FractionalLayoutUnit::operator unsigned):
(WebCore::FractionalLayoutUnit::operator float):
(WebCore::FractionalLayoutUnit::operator double):
(WebCore::FractionalLayoutUnit::operator bool):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
- platform/graphics/FractionalLayoutRect.cpp:
(WebCore):
- platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::pixelSnappedSize):
(WebCore::pixelSnappedIntRect):
(WebCore):
- platform/graphics/FractionalLayoutSize.cpp: Removed.
- platform/graphics/FractionalLayoutSize.h:
(WebCore):
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntSize):
(WebCore):
- 12:01 PM Changeset in webkit [116548] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 11:41 AM BuildingGtk edited by
- (diff)
- 11:40 AM Changeset in webkit [116547] by
-
- 10 edits in trunk
[EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit a "icon,changed" signal on the frame when its favion changed.
Clarify that the "icon,loaded" signal is only emitted for the main
frame.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
- ewk/ewk_frame.cpp:
(ewk_frame_icon_changed):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
Tools:
Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
to support LayoutTestController's dumpIconChanges().
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameIconChanged):
(DumpRenderTreeChrome::onFrameCreated):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
Unskip the test checking for DumpRenderTree's support for
LayoutTestController's dumpIconChanges() in EFL port.
- platform/efl/Skipped:
- 11:30 AM Changeset in webkit [116546] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0/fast/text/international/text-spliced-font-expected.png: Added.
- platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt: Added.
- platform/qt/Skipped:
- 11:28 AM Changeset in webkit [116545] by
-
- 3 edits2 adds in trunk
Crash in ReplaceSelectionCommand::performTrivialReplace
https://bugs.webkit.org/show_bug.cgi?id=85943
Reviewed by Ryosuke Niwa.
Source/WebCore:
RefPtr nodeAfterInsertionPos to guard against mutation events.
Test: editing/inserting/insert-html-crash.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::performTrivialReplace):
LayoutTests:
- editing/inserting/insert-html-crash-expected.txt: Added.
- editing/inserting/insert-html-crash.html: Added.
- 10:58 AM Changeset in webkit [116544] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Exposes OrientationChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=85976
Reviewed by Adam Barth.
This is used by the android port, we need to expose the existing
WebCore API.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::sendOrientationChangeEvent):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 10:57 AM Changeset in webkit [116543] by
-
- 3 edits4 adds in trunk
Hit testing is incorrect in some cases with perspective transforms
https://bugs.webkit.org/show_bug.cgi?id=79136
Reviewed by Simon Fraser.
Source/WebCore:
Tests: transforms/3d/hit-testing/coplanar-with-camera.html
transforms/3d/hit-testing/perspective-clipped.html
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint): Fix a
divide-by-zero error so that values do not become Inf or Nan. Also
fix an overflow error by using a large, but not-too-large constant
to represent infinity.
(WebCore::TransformationMatrix::projectQuad): Fix an error where
incorrect quads were being returned. Incorrect quads can occur
when projectPoint clamped==true after returning.
LayoutTests:
- transforms/3d/hit-testing/coplanar-with-camera-expected.txt: Added.
- transforms/3d/hit-testing/coplanar-with-camera.html: Added.
- transforms/3d/hit-testing/perspective-clipped-expected.txt: Added.
- transforms/3d/hit-testing/perspective-clipped.html: Added.
- 10:47 AM Changeset in webkit [116542] by
-
- 3 edits in trunk/LayoutTests
Textarea-placeholder-wrapping.html may fail because of scrollbars
https://bugs.webkit.org/show_bug.cgi?id=85989
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Ryosuke Niwa.
Increasing rows to avoid scrollbar single pixel differences
to cause failures of this test.
- fast/forms/textarea-placeholder-wrapping-expected.html:
- fast/forms/textarea-placeholder-wrapping.html:
- 10:23 AM Changeset in webkit [116541] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] Missing WebPreferences for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85194
Patch by Simon Pena <Simon Pena> on 2012-05-09
Reviewed by Martin Robinson.
Expose WebPreferences for media playback requires user gesture and
media playback allows inline to GTK side.
This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline) to GTK WebKit WebSettings, and connects
them to the WebKit WebView, so clients can programmatically modify
them.
- webkit/webkitwebsettings.cpp: install new properties and update
setter and getter
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h: add media playback related
properties
- webkit/webkitwebview.cpp: connect newly added properties
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 10:06 AM Changeset in webkit [116540] by
-
- 2 edits in trunk/Source/WebCore
Simplify CSSParser::parseSimpleLengthValue()
https://bugs.webkit.org/show_bug.cgi?id=85910
Reviewed by Alexis Menard.
Various small improvements to this function, mainly:
- Move the check if the property ID accepts a simple length as early as possible;
- Remove the check for the characters{8,16} pointers since they'll be valid (we ASSERT that);
- Use a template to avoid duplicate code for 8 and 16 bit characters.
- css/CSSParser.cpp:
(WebCore):
(WebCore::parseSimpleLength):
(WebCore::parseSimpleLengthValue):
- 10:02 AM Changeset in webkit [116539] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Support multiple buffered time ranges
https://bugs.webkit.org/show_bug.cgi?id=85926
Reviewed by Eric Carlson.
Preserve existing rendering of a single rect even in the presence of multiple buffered regions.
No new tests as this change has no functional effects.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider):
- 10:01 AM Changeset in webkit [116538] by
-
- 5 edits in trunk/Source
Early-out and avoid any copying when possible for Region operations
https://bugs.webkit.org/show_bug.cgi?id=85260
Reviewed by Anders Carlsson.
Source/WebCore:
For an empty region, any intersection or subtraction will not modify
the region, so we can simply return instead of creating a new Shape
and replacing the current empty Shape.
When a region is united with a region it contains, the orignal
containing region is the result. So, if A.unite(B) and A.contains(B)
then A does not need to change at all and we can return without making
a copy of A's shape. When A is a rect, we can do this test even more
simply.
We also remove redundant checks from trySimpleOperation() methods, where
the test is already done in the Region calling site.
This change improves the performance of the Region overlap testing for
composited layers, and allows us to avoid unnecessary copies of the
Region during unite. With a layout test (attached to bug #81087), that
creates a Region from the union of 225 composited layers, as well as
600 overlapping layers above them, this change decreases the running
time of the test by 3.2% by avoiding a copy of the entire Region for
each insertion that does not change the resulting Region.
Unit tests: RegionTest.unite
- platform/graphics/Region.cpp:
(WebCore::Region::Shape::UnionOperation::trySimpleOperation):
(WebCore::Region::Shape::IntersectOperation::trySimpleOperation):
(WebCore::Region::Shape::SubtractOperation::trySimpleOperation):
(WebCore::Region::intersect):
(WebCore::Region::unite):
(WebCore::Region::subtract):
- platform/graphics/Region.h:
(WebCore::Region::isRect):
(WebCore::Region::Shape::isRect):
Source/WebKit/chromium:
- tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):
- 9:32 AM Changeset in webkit [116537] by
-
- 2 edits in trunk/Tools
webkit-patch upload Fails Behind Load-balancing Proxies
https://bugs.webkit.org/show_bug.cgi?id=85980
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Adam Barth.
Unchecking the login restriction to IP to allow the tool
to function behind load-balancing proxies that use multiple
outgoing IPs.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.authenticate):
- 9:31 AM Changeset in webkit [116536] by
-
- 9 edits in trunk
[BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
https://bugs.webkit.org/show_bug.cgi?id=85907
.:
Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.
Enable PAGE_POPUP option in make files.
Internal reviewed by Yong Li.
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit/blackberry:
Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.
Internal reviewed by Yong Li.
Enable PAGE_POPUP so we can use WebCore::PagePopup and WebCore::PagePopupClient interface.
Implement virtual methods in WebCore::ChromeClientBlackBerry that required for the
implementation and add methods in WebKit::WebPage that needed for PagePopupClient.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::initPopupWebView):
(WebKit):
(BlackBerry::WebKit::WebPage::popupOpened):
(BlackBerry::WebKit::WebPage::popupClosed):
(BlackBerry::WebKit::WebPage::hasOpenedPopup):
(BlackBerry::WebKit::WebPage::popup):
(BlackBerry::WebKit::WebPagePrivate::setParentPopup):
- Api/WebPage.h:
(WebCore):
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::closePagePopup):
- WebCoreSupport/ChromeClientBlackBerry.h:
(WebCore):
(ChromeClientBlackBerry):
- 9:21 AM Changeset in webkit [116535] by
-
- 2 edits in trunk/LayoutTests
[EFL] shared-stylesheet-mutation tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=85901
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-09
Reviewed by Antti Koivisto.
This test is flaky on EFL because the timeout for applying
the style is too short for a Debug build.
- http/tests/css/resources/shared-stylesheet-mutation.js:
(executeTests):
- 9:08 AM Changeset in webkit [116534] by
-
- 4 edits1 copy in trunk
[GTK] Split WebKit2 Makefile moving source code listings to GNUmakefile.list.am
https://bugs.webkit.org/show_bug.cgi?id=85985
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am:
Source/WebKit2:
- GNUmakefile.am:
- GNUmakefile.list.am: Copied from Source/WebKit2/GNUmakefile.am.
- 9:05 AM Changeset in webkit [116533] by
-
- 6 edits in trunk
[GTK] Use independent version numbers for public libraries
https://bugs.webkit.org/show_bug.cgi?id=85984
Reviewed by Gustavo Noronha Silva.
.:
- configure.ac: Define LIBJAVASCRIPTCOREGTK_VERSION and
LIBWEBKIT2GTK_VERSION using the same version as
LIBWEBKITGTK_VERSION for backwards compatibility.
Source/JavaScriptCore:
- GNUmakefile.am: Use LIBJAVASCRIPTCOREGTK_VERSION for library
version.
Source/WebKit2:
- GNUmakefile.am: Use LIBWEBKIT2GTK_VERSION for library version.
- 9:02 AM Changeset in webkit [116532] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GTK] Do not install JavaScriptCore platform-specific headers
https://bugs.webkit.org/show_bug.cgi?id=85983
Reviewed by Gustavo Noronha Silva.
JavaScriptCore.h includes JSStringRefCF.h unconditionally. It was
renamed to JavaScript.h in r29234 and it still exists for
compatibility with mac and windows users.
- GNUmakefile.list.am: Remove JavaScriptCore.h, JSStringRefCF.h
and JSStringRefBSTR.h from the sources and headers list.
- 8:57 AM Changeset in webkit [116531] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] Gardening failures and crashes
https://bugs.webkit.org/show_bug.cgi?id=85996
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
- platform/efl/test_expectations.txt:
- 8:55 AM Changeset in webkit [116530] by
-
- 5 edits2 adds in trunk
MediaStream API: SessionDescription::addCandidate should not crash for malformed input
https://bugs.webkit.org/show_bug.cgi?id=85988
Reviewed by Adam Barth.
Source/WebCore:
Sending null would crash the browser. Added safeguards in both the bindings and the native code.
Test: fast/mediastream/SessionDescription.html
- Modules/mediastream/SessionDescription.cpp:
(WebCore::SessionDescription::addCandidate):
- Modules/mediastream/SessionDescription.h:
(SessionDescription):
- Modules/mediastream/SessionDescription.idl:
LayoutTests:
- fast/mediastream/SessionDescription-expected.txt: Added.
- fast/mediastream/SessionDescription.html: Added.
- 8:49 AM Changeset in webkit [116529] by
-
- 5 edits in trunk/Source
MediaStream API: Adding the possibility of port specific information in MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=85794
Reviewed by Adam Barth.
To facilitate for ports I have added an ExtraData field that can be used for whatever purpose is needed.
Source/Platform:
- chromium/public/WebMediaStreamDescriptor.h:
(ExtraData):
(WebKit::WebMediaStreamDescriptor::ExtraData::~ExtraData):
(WebMediaStreamDescriptor):
Source/WebCore:
No behavioral changes.
- platform/chromium/support/WebMediaStreamDescriptor.cpp:
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit):
(WebKit::WebMediaStreamDescriptor::extraData):
(WebKit::WebMediaStreamDescriptor::setExtraData):
- platform/mediastream/MediaStreamDescriptor.h:
(ExtraData):
(WebCore::MediaStreamDescriptor::ExtraData::~ExtraData):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::extraData):
(WebCore::MediaStreamDescriptor::setExtraData):
- 8:45 AM Changeset in webkit [116528] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] MediaStream API: Fixing a memory leak in WebUserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=85992
Reviewed by Adam Barth.
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::assign):
- 8:37 AM Changeset in webkit [116527] by
-
- 4 edits2 adds in trunk
Crash in WebCore::RenderBoxModelObject::paddingLeft
https://bugs.webkit.org/show_bug.cgi?id=83889
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Abhishek Arya.
Source/WebCore:
RenderScrollbar creates RenderScrollbarPart without any parent
renderers. However, if the scrollbar has percent padding styles,
non-null parent renderer is required. So after creating/destroying
RenderScrollbarPart instances, set owningRenderer(creating)/0
(destroying) as its parent renderer.
Test: scrollbars/scrollbar-percent-padding-crash.html
scrollbars/scrollbar-percent-padding-crash-expected.txt
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
Added setParent after creating/destroying RenderScrollbarPart.
- rendering/RenderScrollbarPart.cpp:
Made RenderScollbar friend, because setParent is protected and
RenderScrollbar is not inherited from class RenderObject.
LayoutTests:
As just invoking layoutTestController.display() invokes scrollbar's
WebCore::RenderScrollbarPart::paintIntoRect(), adding display() after
invoking layoutTestController.dumpAsText().
- scrollbars/scrollbar-percent-padding-crash.html: Added.
- scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
- 8:28 AM Changeset in webkit [116526] by
-
- 3 edits in trunk/Tools
[Chromium-android] Add unit test for Android layout test script (chromium_android.py)
https://bugs.webkit.org/show_bug.cgi?id=80852
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-09
Reviewed by Adam Barth.
Add some tests to ensure that chromium android port works to some
extent. Some methods is hard to test, as they rely on the actual
behavior on device, e.g. pushing files to device.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_get_drt_return_value):
(ChromiumAndroidDriverTest.test_has_crash_hint):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_test_shell_command):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):
- 8:23 AM Changeset in webkit [116525] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] don't use soup_session_pause_message in webkitdownload
https://bugs.webkit.org/show_bug.cgi?id=85931
Reviewed by Martin Robinson.
- webkit/webkitdownload.cpp:
(webkit_download_new_with_handle):
(webkit_download_start):
- 8:14 AM Changeset in webkit [116524] by
-
- 2 edits in trunk/LayoutTests
Skip failing test http/tests/loading/post-in-iframe-with-back-navigation.html.
Not reviewed.
- platform/mac/Skipped:
- 7:40 AM Changeset in webkit [116523] by
-
- 2 edits in trunk/LayoutTests
Test from bug 34875 should specify font-size
https://bugs.webkit.org/show_bug.cgi?id=85913
Not reviewed.
Skip fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
- platform/mac/Skipped:
- 6:19 AM Changeset in webkit [116522] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening a timeout failure
https://bugs.webkit.org/show_bug.cgi?id=85979
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
- platform/efl/test_expectations.txt: Adding font-face-download-error.html.
- 5:53 AM Changeset in webkit [116521] by
-
- 8 edits2 adds in trunk
ShadowRoot needs applyAuthorStyles
https://bugs.webkit.org/show_bug.cgi?id=78472
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Hajime Morita.
Source/WebCore:
Implemented applyAuthorStyles attribute defined in the following spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
Since applyAuthorSheets attribute has been already implemented,
renamed all applyAuthorSheets to applyAuthorStyles and
added applyAuthorStyles to ShadowRoot.idl.
Currently, changing dynamically applyAuthorStyles doesn't work. I will fix this isse in bugs:84215: https://bugs.webkit.org/show_bug.cgi?id=84251
Test: fast/dom/shadow/shadow-root-applyAuthorStyles.html
fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::applyAuthorStyles):
(WebCore::ShadowRoot::setApplyAuthorStyles):
- dom/ShadowRoot.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::applyAuthorStyles):
- dom/TreeScope.h:
(TreeScope):
Changed all applyAuthorSheets to applyAuthorSytles.
(ShadowRoot):
- dom/ShadowRoot.idl:
Added a new attribute, boolean applyAuthorStyles.
LayoutTests:
- fast/dom/shadow/shadow-root-applyAuthorStyles.html:
- fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html:
Tested four cases:
case 1: applyAuthorStyles is false,
case 2: applyAuthorStyles is true with <script>..</script>,
case 3: applyAuthorStyles is true with inline script declaration, and
case 4: applyAuthorStyles is true with important UA property.
The case 1, 2 and 3 specify "span { ... }" with author styles and
verify rendering results.
The case 4 specifies '<input type="file" />' with an author style,
text-align: end, and verify rendering result.
- 5:39 AM Changeset in webkit [116520] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Tap-to-zoom zooms to wrong area.
https://bugs.webkit.org/show_bug.cgi?id=85982
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.
Fix computation and take more care when to use CSS scale and when to use Item scale.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 5:34 AM Changeset in webkit [116519] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/overflow/scroll-div-hide-show.html testcase does not pass
https://bugs.webkit.org/show_bug.cgi?id=85960
Unreviewed. Gardening.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09
- platform/efl/Skipped: Skipping fast/overflow/scroll-div-hide-show.html.
- 5:22 AM Changeset in webkit [116518] by
-
- 2 edits in trunk/Tools
[Qt] ORWT fails with Qt 5 and WK2.
https://bugs.webkit.org/show_bug.cgi?id=85968
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Csaba Osztrogonác.
The Qt5 binary does not have a -style argument, so avoid using it.
- Scripts/old-run-webkit-tests:
- 5:19 AM Changeset in webkit [116517] by
-
- 1 edit44 adds in trunk/LayoutTests
[EFL][DRT] Add baselines for new CSS cases after r116438
https://bugs.webkit.org/show_bug.cgi?id=85967
Unreviewed, add EFL baselines for new tests after r116438.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-09
- platform/efl/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-000-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-002-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-003-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-004-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-005-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-006-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-nested-007-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
- platform/efl/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/efl/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
- platform/efl/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/efl/fast/css/first-letter-nested-positioned-expected.txt: Added.
- platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
- 5:11 AM Changeset in webkit [116516] by
-
- 7 edits in trunk/Source/WebKit2
[Qt][WK2] Define clear split between QtWebPageLoadClient and QQuickWebViewPrivate for loading tasks.
https://bugs.webkit.org/show_bug.cgi?id=84527#c3
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Simon Hausmann.
Moving loading related code and signal emission from QtWebPageLoadClient to QQuickWebViewPrivate.
It puts the loading code that implements an API right where the API is defined, including
signal emission as well as translation of WebPageProxy internals to public Qt API with correct types.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::provisionalLoadDidStart):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didSameDocumentNavigation):
(QQuickWebViewPrivate::titleDidChange):
(QQuickWebViewPrivate::loadProgressDidChange):
(QQuickWebViewPrivate::backForwardListDidChange):
(QQuickWebViewPrivate::loadDidFail):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebView::loadProgress):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::loadProgress):
(QQuickWebViewFlickablePrivate):
- UIProcess/qt/QtWebError.cpp:
(WebKit::QtWebError::isCancellation):
(WebKit):
- UIProcess/qt/QtWebError.h:
- UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit::QtWebPageLoadClient::QtWebPageLoadClient):
(WebKit):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoad):
(WebKit::QtWebPageLoadClient::didCommitLoad):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigation):
(WebKit::QtWebPageLoadClient::didReceiveTitle):
(WebKit::QtWebPageLoadClient::didChangeProgress):
(WebKit::QtWebPageLoadClient::didChangeBackForwardList):
(WebKit::QtWebPageLoadClient::dispatchLoadFailed):
(WebKit::QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didStartProgress):
(WebKit::QtWebPageLoadClient::didFinishProgress):
- UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
(QtWebPageLoadClient):
- 4:38 AM Changeset in webkit [116515] by
-
- 1 edit56 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, add platform specific expected files for new tests.
- platform/qt/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-000-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-002-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-003-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-004-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-005-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-006-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-nested-007-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
- platform/qt/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/qt/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
- platform/qt/fast/block/float/avoiding-float-centered-expected.png: Added.
- platform/qt/fast/block/float/avoiding-float-centered-expected.txt: Added.
- platform/qt/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/qt/fast/css/first-letter-nested-positioned-expected.txt: Added.
- platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
- platform/qt/fast/html/details-marker-style-expected.png: Added.
- platform/qt/fast/html/details-marker-style-expected.txt: Added.
- platform/qt/fast/images/png-suite/test-expected.txt: Added.
- platform/qt/fast/text/international/text-spliced-font-expected.png: Added.
- platform/qt/fast/text/international/text-spliced-font-expected.txt: Added.
- platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
- platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
- platform/qt/svg/custom/path-zero-strokewidth-expected.png: Added.
- platform/qt/svg/custom/path-zero-strokewidth-expected.txt: Added.
- 4:13 AM Changeset in webkit [116514] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Unreviewed gardening, add a platform specific expected file for a passing test.
- platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Added.
- 4:10 AM Changeset in webkit [116513] by
-
- 4 edits2 adds in trunk
[Chromium][Forms] HTMLOptionsCollection doesn't have indexed properties on property enumeration
https://bugs.webkit.org/show_bug.cgi?id=85937
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-09
Reviewed by Kentaro Hara.
Source/WebCore:
This patch adds numeric indices to properties in enumeration to HTMLOptionsCollection V8 binding
to changes Objects.keys in ECMAScript5 and for-in statement behavior for compatibility with
Firefox 12, IE9, Opera 11, and Safari 5.
Test: fast/forms/select/options-indexed-properties.html
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer): Set $hasEnumerator true for interface HTMLOptionsCollection
LayoutTests:
- fast/forms/select/options-indexed-properties-expected.txt: Added.
- fast/forms/select/options-indexed-properties.html: Added.
- platform/chromium/inspector/console/console-format-collections-expected.txt: Changed for HTMLOptionCollection printed output
- 4:02 AM Changeset in webkit [116512] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/loading/post-in-iframe-with-back-navigation.html fails
https://bugs.webkit.org/show_bug.cgi?id=85974
Unreviewed EFL gardening.
Move http/tests/loading/post-in-iframe-with-back-navigation.html to
test_expectations.txt. This test was added in r116473 but fails on all
the bots.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
- platform/efl/test_expectations.txt:
- 3:49 AM Changeset in webkit [116511] by
-
- 6 edits2 adds in trunk/LayoutTests
MediaStream API: Adding a test for constructed from JS MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=85883
Reviewed by Kent Tamura.
Also moved shouldNotThrow to js-test-pre, and removed it from all mediastream tests.
- fast/js/resources/js-test-pre.js:
(shouldNotThrow):
- fast/mediastream/MediaStreamConstructor-expected.txt: Added.
- fast/mediastream/MediaStreamConstructor.html: Added.
- fast/mediastream/peerconnection-argument-types-expected.txt:
- fast/mediastream/peerconnection-iceoptions.html:
- fast/mediastream/script-tests/argument-types.js:
- fast/mediastream/script-tests/peerconnection-argument-types.js:
- 3:01 AM Changeset in webkit [116510] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update for media-stream tests
https://bugs.webkit.org/show_bug.cgi?id=85952
- platform/chromium/test_expectations.txt:
- 2:37 AM Changeset in webkit [116509] by
-
- 2 edits1 delete in trunk/LayoutTests
[Qt] Gardening. Skip a failing test, remove an unnecessary platform specific expected file.
https://bugs.webkit.org/show_bug.cgi?id=85969
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-09
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- platform/qt/fast/forms/form-collection-radio-node-list-expected.txt: Removed after r116491.
- 2:26 AM Changeset in webkit [116508] by
-
- 11 edits7 adds in trunk
Position should be able to have ShadowRoot as a container.
https://bugs.webkit.org/show_bug.cgi?id=82021
Reviewed by Ryosuke Niwa.
Source/WebCore:
Since Position could not take a shadow root as a container node, pointing the direct children
of a shadow root was difficult.
This patch makes it enabled, and fixes a lot of crashes caused by that limitation.
Also, we confirm that ShadowRoot is not exposed to JavaScript layer.
Currently this change is only enabled if shadow dom flag is enabled, since we cannot
prove this change does not destroy the existing behavior. However, this change is really required
to fix other editing bugs in Shadow DOM. A bunch of patches and tests will be added to
fix other editing bugs and they will check this patch does not break editing.
We will also add a fuzzer to check the stability of editing in Shadow DOM later, and it will
also help to confirm the patch will not break the editing.
Tests: editing/shadow/doubleclick-on-meter-in-shadow-crash.html
editing/shadow/rightclick-on-meter-in-shadow-crash.html
editing/shadow/shadow-selection-not-exported.html
- dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
(WebCore::Position::findParent):
- dom/Position.h:
(WebCore):
(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):
LayoutTests:
Skipped non-chromium port since SHADOW_DOM flag is not enabled in those platforms.
We will add bunch of tests for editing in Shadow DOM into editing/shadow later,
so I added the whole directory name to the skipped list.
- editing/shadow/doubleclick-on-meter-in-shadow-crash-expected.txt: Added.
- editing/shadow/doubleclick-on-meter-in-shadow-crash.html: Added.
- editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt: Added.
- editing/shadow/rightclick-on-meter-in-shadow-crash.html: Added.
- editing/shadow/shadow-selection-not-exported-expected.txt: Added.
- editing/shadow/shadow-selection-not-exported.html: Added.
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 2:07 AM Changeset in webkit [116507] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Build fix when using libpng version != 1.2
https://bugs.webkit.org/show_bug.cgi?id=85614
Reviewed by Eric Seidel.
Don't enforce the version of libpng when passing the option to the linker.
No new tests, no intended functionality change.
- WebCore.pri:
- 2:04 AM Changeset in webkit [116506] by
-
- 8 edits in trunk
[EFL][DRT] LayoutTestController addUserScript implementation
https://bugs.webkit.org/show_bug.cgi?id=84718
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Added helper functions for adding/clearing of user scripts.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Added implementation of addUserScript() to LayoutTestController.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addUserScript): added implementation
LayoutTests:
Unskipped corresponding testcases.
- platform/efl/Skipped:
- 1:42 AM Changeset in webkit [116505] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=85906
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.
Deferred loading activies were introduced to work around the delayed Flickable construction
at onComponentComplete(). QQuickWebView inherits from QQuickFlickable now,
so no need for the workaround anymore.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::setUrl):
(QQuickWebView::componentComplete):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
- 1:34 AM Changeset in webkit [116504] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update.
- platform/chromium/test_expectations.txt:
video-media-source-seek.html is also SLOW?
- 12:54 AM Changeset in webkit [116503] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disable WebViewTest.TextInputType because the test is incomplete.
- tests/WebViewTest.cpp:
- 12:51 AM Changeset in webkit [116502] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/loading/pdf-commit-load-callbacks.html is failing
https://bugs.webkit.org/show_bug.cgi?id=85957
Unreviewed gardening.
Move http/tests/loading/pdf-commit-load-callbacks.html to
test_expectations.txt while Bug 85956 is fixed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-09
- platform/efl/test_expectations.txt:
- 12:46 AM Changeset in webkit [116501] by
-
- 3 edits in trunk/Tools
Made build-webkit copy WebKitLibraries to the right location again after r116257
Reviewed by Mark Rowe.
- Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
- Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
product directory.
- 12:42 AM Changeset in webkit [116500] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Some of *.runMultiThread tests intermittently crash.
Mark them flaky.
- tests/CCLayerTreeHostTest.cpp:
- 12:19 AM Changeset in webkit [116499] by
-
- 21 edits13 adds in trunk/Source
Source/WebCore: Add identifying methods for date/time input types.
This patch adds methods isDateField(), isDateTimeField(), isDateTimeLocalField(),
isMonthField(), isTimeField() and isWeekField() to InputType and the appropriate
HTMLInputElement classes, to allow date/time input types to be identified.
The new methods match the existing methods for types such as email, search and number.
https://bugs.webkit.org/show_bug.cgi?id=78746
Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.
A new test WebViewTest.TextInputType has been added in WebKit/chromium/tests that calls
through to these methods via WebViewImpl.textInputType().
- html/DateInputType.cpp:
(WebCore::DateInputType::isDateField):
(WebCore):
- html/DateInputType.h:
(DateInputType):
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::isDateTimeField):
(WebCore):
- html/DateTimeInputType.h:
(DateTimeInputType):
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::isDateTimeLocalField):
(WebCore):
- html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isDateField):
(WebCore):
(WebCore::HTMLInputElement::isDateTimeField):
(WebCore::HTMLInputElement::isDateTimeLocalField):
(WebCore::HTMLInputElement::isMonthField):
(WebCore::HTMLInputElement::isTimeField):
(WebCore::HTMLInputElement::isWeekField):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::isDateField):
(WebCore):
(WebCore::InputType::isDateTimeField):
(WebCore::InputType::isDateTimeLocalField):
(WebCore::InputType::isMonthField):
(WebCore::InputType::isTimeField):
(WebCore::InputType::isWeekField):
- html/InputType.h:
(InputType):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::isMonthField):
(WebCore):
- html/MonthInputType.h:
(MonthInputType):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::isTimeField):
(WebCore):
- html/TimeInputType.h:
(TimeInputType):
- html/WeekInputType.cpp:
(WebCore::WeekInputType::isWeekField):
(WebCore):
- html/WeekInputType.h:
(WeekInputType):
Source/WebKit/chromium: Adds date/time input types to WebTextInputType, and adds support for these
to WebViewImpl.textInputType().
Adds a new test WebViewTest.TextInputType to test WebViewImpl.textInputType(),
including the new types.
https://bugs.webkit.org/show_bug.cgi?id=78746
Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.
- public/WebTextInputType.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
- tests/WebViewTest.cpp:
(WebViewTest):
(WebKit::WebViewTest::testTextInputType):
(WebKit):
(WebKit::TEST_F):
- tests/data/input_field_date.html: Added.
- tests/data/input_field_datetime.html: Added.
- tests/data/input_field_default.html: Added.
- tests/data/input_field_email.html: Added.
- tests/data/input_field_number.html: Added.
- tests/data/input_field_search.html: Added.
- tests/data/input_field_time.html: Added.
- tests/data/input_field_week.html: Added.
- 12:17 AM Changeset in webkit [116498] by
-
- 8 edits4 adds in trunk
REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405
Reviewed by Darin Adler.
Source/WebCore:
Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the managment of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.
Tests: svg/text/add-tspan-position-bug.html
svg/text/modify-tspan-position-bug.html
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
- rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateMetrics):
(WebCore::RenderSVGText::subtreeChildAdded):
(WebCore::RenderSVGText::subtreeChildWillBeDestroyed):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::subtreeChildWasDestroyed):
(WebCore::RenderSVGText::subtreeStyleChanged):
(WebCore::RenderSVGText::subtreeTextChanged):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::rebuildAllLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
- rendering/svg/RenderSVGText.h:
(WebCore::RenderSVGText::layoutAttributes):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
LayoutTests:
Add two new testcases covering the problem.
- svg/text/add-tspan-position-bug-expected.html: Added.
- svg/text/add-tspan-position-bug.html: Added.
- svg/text/modify-tspan-position-bug-expected.html: Added.
- svg/text/modify-tspan-position-bug.html: Added.
- 12:07 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
May 8, 2012:
- 11:59 PM TraversingShadowDOMTree edited by
- (diff)
- 11:16 PM Changeset in webkit [116497] by
-
- 4 edits in trunk/Source/WebCore
NavigatorRegisterProtocolHandler can call ChromeClient directly.
https://bugs.webkit.org/show_bug.cgi?id=85944
Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-08
Reviewed by Adam Barth.
Covered by fast/dom/register-protocol-handler.html
- page/Chrome.cpp: Remove registerProtocolHandler function.
- page/Chrome.h: Remove registerProtocolHandler prototype.
(Chrome):
- page/NavigatorRegisterProtocolHandler.cpp: Call ChromeClient::registerProtocolHandler directly.
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
- 11:14 PM Changeset in webkit [116496] by
-
- 2 edits in trunk/Source/WebCore
Coding style issues present in RenderFrameSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=85955
Reviewed by Eric Seidel.
Just fixed those coding style issues.
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::GridAxis::resize):
(WebCore::RenderFrameSet::layOutAxis):
(WebCore::RenderFrameSet::continueResizing):
- 10:52 PM Changeset in webkit [116495] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 9:45 PM Changeset in webkit [116494] by
-
- 7 edits in trunk/Source/JavaScriptCore
ROLLING OUT r114255
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839
Reviewed by nobody.
This breaks the world, with COLLECT_ON_EVERY_ALLOCATION enabled.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::isUsingInlineStorage):
(JSC):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
- runtime/Structure.cpp:
(JSC):
- runtime/Structure.h:
(JSC::Structure::didTransition):
- 9:43 PM TraversingShadowDOMTree edited by
- (diff)
- 9:33 PM Changeset in webkit [116493] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- platform/mac/WebCoreSystemInterface.h:
- 9:20 PM Changeset in webkit [116492] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix.
- WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
(LayerTreeHostCAWin):
- 9:10 PM Changeset in webkit [116491] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, a trivial test fix to remove a platform-dependency.
https://bugs.webkit.org/show_bug.cgi?id=81854
- fast/forms/form-collection-radio-node-list-expected.txt:
- fast/forms/form-collection-radio-node-list.html:
Remove form controls from the document before completing the test.
- 8:49 PM Changeset in webkit [116490] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update
Skip post-in-iframe-with-back-navigation.html because it might cause a
failure of the next test, preload-append-scan.php
- platform/chromium/test_expectations.txt:
- 8:39 PM Changeset in webkit [116489] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 8:35 PM Changeset in webkit [116488] by
-
- 5 edits2 adds in trunk
[BlackBerry] Auth credentials set in private mode are reused in public mode.
https://bugs.webkit.org/show_bug.cgi?id=84697
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-08
Reviewed by Rob Buis.
Add setPrivateMode function for CredentialStorage.
Source/WebCore:
Now, we only save credentials in memory and CredentialBackingStore isn't enabled.
When we set private mode from on to off, we clear all these temporary credentials.
We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html
- network/CredentialStorage.cpp:
(WebCore::CredentialStorage::setPrivateMode):
(WebCore):
- platform/network/CredentialStorage.h:
(CredentialStorage):
Source/WebKit/blackberry:
We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 8:23 PM Changeset in webkit [116487] by
-
- 20 edits5 adds in trunk
RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-08
Reviewed by Ryosuke Niwa.
Source/WebCore:
Implement RadioNodeList support spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#radionodelist
Test: fast/forms/form-collection-radio-node-list.html
- CMakeLists.txt:
Added entries for new files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- DerivedSources.pri: Ditto.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Added code to include Node.h and JSNode.h in JSRadioNodeElement.cpp.
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
Invalidate lists even for change in id, type, checked attributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
Invalidate radioNodeList cache.
(WebCore::NodeListsNodeData::isEmpty):
Changes for radioNodeList.
(WebCore::Node::radioNodeList):
Creates if needed a RadioNodeList and adds it to the cache.
(WebCore::Node::removeCachedRadioNodeList):
Removes a cached radioNodeList.
- dom/Node.h: Ditto
- dom/NodeRareData.h:
(WebCore):
(NodeListsNodeData):
Added radioNodeList list.
- html/CollectionType.h:
Added new FormControls type.
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
Handle FormControls collection type.
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
Contruct collection of FormControls type.
- html/RadioNodeList.cpp: Added.
(WebCore):
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::~RadioNodeList):
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
(WebCore::RadioNodeList::nodeMatches):
- html/RadioNodeList.h: Added.
(WebCore):
(RadioNodeList):
(WebCore::RadioNodeList::create):
RadioNodeList implementation.
- html/RadioNodeList.idl: Added.
Idl for generating RadioNodeList JS/V8 bindings.
LayoutTests:
- fast/forms/form-collection-radio-node-list-expected.txt: Added.
- fast/forms/form-collection-radio-node-list.html: Added.
- 8:20 PM Changeset in webkit [116486] by
-
- 3 edits6 adds in trunk
[JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args
https://bugs.webkit.org/show_bug.cgi?id=85928
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-08
Reviewed by Geoffrey Garen.
Source/WebCore:
The functions addEventListener() and removeEventListener() raise an exception if there are missin arguments.
This behavior breaks existing content.
This patch change the code generator of JavaScript core to have an exception for addEventListener() and removeEventListener().
For those function, we do not raise an exception on missin argument.
This patch does not modify the V8 code generator because such exceptions are already in place there.
Tests: fast/dom/Window/window-legacy-event-listener.html
fast/dom/XMLHttpRequest-legacy-event-listener.html
fast/dom/node-legacy-event-listener.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
LayoutTests:
- fast/dom/Window/window-legacy-event-listener-expected.txt: Added.
- fast/dom/Window/window-legacy-event-listener.html: Added.
- fast/dom/XMLHttpRequest-legacy-event-listener-expected.txt: Added.
- fast/dom/XMLHttpRequest-legacy-event-listener.html: Added.
- fast/dom/node-legacy-event-listener-expected.txt: Added.
- fast/dom/node-legacy-event-listener.html: Added.
- 7:48 PM Changeset in webkit [116485] by
-
- 14 edits in trunk/Source/WebCore
AudioParam should directly be given context in create() method
https://bugs.webkit.org/show_bug.cgi?id=85905
Reviewed by James Robinson.
No new tests. This is a low-level re-factoring and is covered by existing tests.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- Modules/webaudio/AudioGain.h:
(WebCore::AudioGain::create):
(WebCore::AudioGain::AudioGain):
- Modules/webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::AudioGainNode):
- Modules/webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::AudioPannerNode):
- Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::create):
(AudioParam):
(WebCore::AudioParam::AudioParam):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
- Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
- Modules/webaudio/DelayProcessor.h:
(DelayProcessor):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
- Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::Oscillator):
- 7:44 PM Changeset in webkit [116484] by
-
- 4 edits in trunk/Source/JavaScriptCore
Heap should not continually allocate new pages in steady state
https://bugs.webkit.org/show_bug.cgi?id=85936
Reviewed by Geoff Garen.
Currently, in steady state (i.e. a constant amount of live GC
memory with a constant rate of allocation) assuming we've just
finished a collection with X live blocks in CopiedSpace, we
increase our working set by X blocks in CopiedSpace with each
collection we perform. This is due to the fact that we allocate
until we run out of free blocks to use in the Heap before we
consider whether we should run a collection.
In the longer term, this issue will be mostly resolved by
implementing quick release for the CopiedSpace. In the shorter
term, we should change our policy to check whether we should
allocate before trying to use a free block from the Heap. We
can change our policy to something more appropriate once we
have implemented quick release.
This change should also have the convenient side effect of
reducing the variance in GC-heavy tests (e.g. v8-splay) due
to fact that we are doing less VM allocation during copying
collection. Overall, this patch is performance neutral across
the benchmarks we track.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::getFreshBlock): Shuffle the request from the BlockAllocator
around so that we only do it if the block request must succeed
i.e. after we've already checked whether we should do a collection.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase): Ditto.
(JSC::MarkedAllocator::allocateBlock): We no longer have a failure mode in this
function because by the time we've called it, we've already checked whether we
should run a collection so there's no point in returning null.
- heap/MarkedAllocator.h: Removing old arguments from function declaration.
(MarkedAllocator):
- 7:37 PM Changeset in webkit [116483] by
-
- 5 edits in trunk/Tools
Show the chromium non-layout test bots in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=85903
Reviewed by Eric Seidel.
This is just a single-line high-level overview of the chromium non-layout test bots.
This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
order to do their job.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#chromium-gtests iframe):
(#chromium-gtests):
(#gtest-label):
- 7:34 PM Changeset in webkit [116482] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening, unskip test after r116475.
- platform/efl/test_expectations.txt:
- 7:26 PM Changeset in webkit [116481] by
-
- 8 edits in trunk/Source
[chromium] Show borders for partial-draw-culled quads to visualize culling behaviour
https://bugs.webkit.org/show_bug.cgi?id=85414
Reviewed by Adrienne Walker.
Source/WebCore:
The borders are brown, and are only shown when the quad's visible rect
is non-empty and is different from the quad's original rect.
Adds a flag to CCQuadCuller constructor, to enable showing debug borders
around what it leaves after culling (when it culls anything in a quad
at all).
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::isDebugQuad):
(WebCore::CCDrawQuad::sharedQuadState):
(CCDrawQuad):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore):
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::appendQuadInternal):
(WebCore::CCQuadCuller::append):
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):
- platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
Source/WebKit/chromium:
- tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
- tests/MockCCQuadCuller.h:
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
- 7:18 PM Changeset in webkit [116480] by
-
- 4 edits in trunk/Source/WebCore
Move RenderLayers z-index lists dirtying to post style change
https://bugs.webkit.org/show_bug.cgi?id=85437
Reviewed by Darin Adler.
No expected change in behavior.
This change moves the z-order lists to RenderLayer::styleChanged. As part of this
change, also added proper handling of stacking context transition. This enabled
us to tighten more of the dirtyZOrderLists / clearZOrderLists code.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleWillChange):
Removed this code, moved to updateStackingContextsAfterStyleChange.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
Only stacking contexts start with dirty z-order lists.
(WebCore::RenderLayer::dirtyZOrderLists):
Added an ASSERT.
(WebCore::RenderLayer::updateStackingContextsAfterStyleChange):
Refactored the code to handle the transition between stacking context status.
(WebCore::RenderLayer::styleChanged):
Added a call to updateStackingContextsAfterStyleChange.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::isStackingContext):
Added a call to the next function.
(WebCore::RenderLayer::layerWithStyleIsStackingContext):
Factored the isStackingContext logic here so that we can reuse it inside
updateStackingContextsAfterStyleChange.
(WebCore::RenderLayer::clearZOrderLists):
Added an ASSERT.
- 7:11 PM Changeset in webkit [116479] by
-
- 2 edits in trunk/Source/WebKit/mac
Fixe Chromium build, and add a FIXME comment about a layering violation.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 7:03 PM Changeset in webkit [116478] by
-
- 9 edits in trunk/Source/WebKit2
DrawingAreaProxyImpl doesn't work with window server hosting
https://bugs.webkit.org/show_bug.cgi?id=85947
<rdar://problem/11213718>
Reviewed by Andreas Kling.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::updateAcceleratedCompositingMode):
Update the layer tree context and call WebPage::updateAcceleratedCompositingMode.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setLayerHostingMode):
If setting the layer hosting mode changed the layer tree context, send back an UpdateAcceleratedCompositingMode message
with the new context.
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize):
platformInitialize no longer takes a context.
- WebProcess/WebPage/ca/LayerTreeHostCA.h:
(LayerTreeHostCA):
Make m_layerTreeContext protected instead.
- WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
- WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::platformInitialize):
Assign to m_layerTreeContext directly.
(WebKit::LayerTreeHostCAMac::setLayerHostingMode):
Set m_layerTreeContext.contextID.
- WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::platformInitialize):
Assign to m_layerTreeContext directly.
- 6:47 PM Changeset in webkit [116477] by
-
- 2 edits in trunk/LayoutTests
Suppress failing test while the fix is being worked out.
- platform/chromium/test_expectations.txt:
- 6:45 PM Changeset in webkit [116476] by
-
- 11 edits2 adds in trunk
Crash due to owning renderer not removed from custom scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=80610
Reviewed by Eric Seidel.
Source/WebCore:
Test: scrollbars/scrollbar-owning-renderer-crash.html
Changed RenderScrollbar to keep pointer to owning node, instead of the
renderer. Renderer can get destroyed without informing the scrollbar, causing
crashes later. Remove code from r94107 since it is not needed anymore and saves
times when RenderBox is getting destroyed.
- page/FrameView.cpp:
(WebCore::FrameView::createScrollbar): pass renderer's node.
- page/FrameView.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): no longer need this. came originally from r94107.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar): pass renderer's node.
(WebCore::RenderLayer::destroyScrollbar): no longer need to clear owning renderer.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar): pass renderer's node.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar): pass renderer's node.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar): Store owner node instead of renderer.
(WebCore::RenderScrollbar::RenderScrollbar): Store owner node instead of renderer.
(WebCore::RenderScrollbar::owningRenderer): calculate owning renderer from owner node.
- rendering/RenderScrollbar.h:
(RenderScrollbar):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createScrollbar): pass renderer's node.
LayoutTests:
- scrollbars/scrollbar-owning-renderer-crash-expected.txt: Added.
- scrollbars/scrollbar-owning-renderer-crash.html: Added.
- 6:44 PM TraversingShadowDOMTree edited by
- (diff)
- 6:32 PM Changeset in webkit [116475] by
-
- 8 edits2 adds in trunk
[EFL][DRT] Implement TextInputController.
https://bugs.webkit.org/show_bug.cgi?id=78559
Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-08
Reviewed by Martin Robinson.
TextInputController has been created for an input emulation purpose in DRT.
However, not like other ports, EFL doesn't have it.
Therefore, this patch will enable EFL port to have an input emulation in DRT.
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
- DumpRenderTree/efl/TextInputController.cpp: Added.
(setMarkedTextCallback):
(hasMarkedTextCallback):
(markedRangeCallback):
(insertTextCallback):
(unmarkTextCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
(makeTextInputController):
- DumpRenderTree/efl/TextInputController.h: Added.
LayoutTests:
- platform/efl/Skipped:
- 6:05 PM TraversingShadowDOMTree created by
- 5:58 PM Changeset in webkit [116474] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] force ENABLE_REGISTER_PROTOCOL_HANDLER=1 in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=85924
Reviewed by Adam Barth.
This has been enabled for a few months on Chromium trunk so remove the
ability to turn it off via a gyp flag. This simplifies features.gypi.
- features.gypi:
- 5:57 PM Changeset in webkit [116473] by
-
- 16 edits7 adds in trunk
Safari warns that it needs to resend the form in an iFrame when going back
https://bugs.webkit.org/show_bug.cgi?id=82658
<rdar://problem/11292558>
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/loading/post-in-iframe-with-back-navigation.html
- WebCore.exp.in: Add _wkCFURLRequestAllowAllPostCaching.
- platform/mac/WebCoreSystemInterface.h: Add wkCFURLRequestAllowAllPostCaching.
- platform/mac/WebCoreSystemInterface.mm: Add wkCFURLRequestAllowAllPostCaching.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
LayoutTests:
Add new test which navigates a series of pages in an iframe. Each navigation is a POST.
At the third page we click on a back link, and expect to see stale POST data.
- http/tests/loading/post-in-iframe-with-back-navigation-expected.txt: Added.
- http/tests/loading/post-in-iframe-with-back-navigation.html: Added.
- http/tests/loading/resources/post-in-iframe-with-back-navigation-page-1.php: Added.
- http/tests/loading/resources/post-in-iframe-with-back-navigation-page-2.php: Added.
- http/tests/loading/resources/post-in-iframe-with-back-navigation-page-3.php: Added.
- http/tests/resources/js-test-post.js: Added. Copied from fast/js/resources since it is
inaccessible to the test server.
- http/tests/resources/js-test-pre.js: Added. Copied from fast/js/resources since it is
inaccessible to the test server.
- 5:54 PM Changeset in webkit [116472] by
-
- 8 edits in trunk/Source
[chromium] Reflections with masks should not occlude
https://bugs.webkit.org/show_bug.cgi?id=85927
Reviewed by James Robinson.
Source/WebCore:
When a surface does not have a mask, we make both it and its reflection
occlude the things below them. However, if the reflection has a mask
applied to it, then we should not consider it as occluding.
Adds replicaHasMask() to the render surface classes so we can test if
the mask is present.
Unit Tests: CCOcclusionTrackerTestReplicaWithMask
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::RenderSurfaceChromium::replicaHasMask):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToTargetRenderSurface):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::CCRenderSurface::replicaHasMask):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setMask):
(CCOcclusionTrackerTestReplicaWithMask):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests):
- 5:52 PM Changeset in webkit [116471] by
-
- 7 edits in trunk
Add stylesheet inheritance support to IFRAME_SEAMLESS
https://bugs.webkit.org/show_bug.cgi?id=85914
Reviewed by Ojan Vafai.
Source/WebCore:
This work is already guarded by IFRAME_SEAMLESS, as
Document::shouldDisplaySeamlesslyWithParent always returns false
when IFRAME_SEAMLESS is off.
This makes the child document use all author stylesheets from all parent documents,
per the seamless spec:
http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-seamless
This support is slightly inefficient as every time a sheet is added
to a parent document, the child document must do a full style selector recalc.
Normally author sheet additions have a fast-path which avoids the full selector recalc,
but such is not possible in the seamless case as we're inserting the parents sheets
earlier in the child's cascade (instead of just appending them to the end of the list).
The test covers both the static inheritance as well as addition of a stylesheet
to the parent and testing that it caused a recalc of the child.
Covered by fast/frames/seamless/seamless-css-cascade.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore):
- css/StyleResolver.h:
(StyleResolver):
- dom/Document.cpp:
(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore):
(WebCore::Document::notifySeamlessChildDocumentsOfStylesheetUpdate):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
(Document):
LayoutTests:
Update the results (for both static and dynamic inheritance)
now that this support is landed.
- fast/frames/seamless/seamless-css-cascade-expected.txt:
- 5:42 PM Changeset in webkit [116470] by
-
- 5 edits in trunk
[EFL] Pass a WTF::String directly from DRT to ewebkit when possible
https://bugs.webkit.org/show_bug.cgi?id=84634
Reviewed by Gustavo Noronha Silva.
Drop unnecessary const char* -> WTF::String conversions by
creating String objects directly in LayoutTestController out of
JSStringRef's and passing them to DumpRenderTreeSupportEfl.
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::findString):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::queueLoad):
(LayoutTestController::setValueForUser):
(LayoutTestController::findString):
(LayoutTestController::addUserStyleSheet):
- 5:41 PM WikiStart edited by
- (diff)
- 5:40 PM WikiStart edited by
- (diff)
- 5:24 PM Changeset in webkit [116469] by
-
- 3 edits in trunk/Source/WebKit2
Can't scroll PDF in subframe
https://bugs.webkit.org/show_bug.cgi?id=85932
<rdar://problem/11405527>
Reviewed by Sam Weinig.
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
- WebProcess/Plugins/PDF/BuiltInPDFView.mm:
(WebKit::BuiltInPDFView::updateScrollbars):
Trigger a layout when scrollbars come and go so the non fast scrollable region gets recomputed.
(WebKit::BuiltInPDFView::scrollableAreaBoundingBox):
Implement this by calling out to the PluginView.
- 5:02 PM Changeset in webkit [116468] by
-
- 4 edits in trunk
[CMake] FindGStreamer: Fix the build with static WebCore.
https://bugs.webkit.org/show_bug.cgi?id=85930
Reviewed by Daniel Bates.
.:
Building WebCore statically was failing because files in
WebCore/platform/gstreamer when ENABLE_VIDEO was set required
gstreamer-base, which was not being linked to after r116453.
Fix that by looking for gstreamer-base, requiring and linking
against it if GStreamer is used.
- Source/cmake/FindGStreamer.cmake:
Source/WebCore:
No new tests, build fix.
Building WebCore statically was failing because files in
WebCore/platform/gstreamer when ENABLE_VIDEO was set required
gstreamer-base, which was not being linked to after r116453.
Fix that by looking for gstreamer-base, requiring and linking
against it if GStreamer is used.
- PlatformEfl.cmake: Link to GSTREAMER_LIBRARIES and
GSTREAMER_BASE_LIBRARIES, and include GSTREAMER_INCLUDE_DIRS and
GSTREAMER_BASE_INCLUDE_DIRS.
- 4:55 PM Changeset in webkit [116467] by
-
- 17 edits in branches/dfgopt/Source/JavaScriptCore
DFG should support op_get_argument_by_val and op_get_arguments_length
https://bugs.webkit.org/show_bug.cgi?id=85911
Reviewed by Oliver Hunt.
This adds a simple and relatively conservative implementation of op_get_argument_by_val
and op_get_arguments_length. We can optimize these later. For now it's great to have
the additional coverage.
This patch appears to be perf-neutral.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 4:50 PM Changeset in webkit [116466] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Push wheel events if there are too many in queue
https://bugs.webkit.org/show_bug.cgi?id=85747
<rdar://problem/11390790>
Reviewed by Anders Carlsson.
It is possible that a whole bunch of messages added to the message queue, or a series
of long-running messages, cause unresponsiveness. The reason for this is that we have
a scroll event waiting for acknowledgment from the web process before it sends the next
event. And in the time between the user has scrolled, causing a large backlog of scroll
events to be held in the UI process.
We should push new scroll events if the queue accumulates too many of them.
- UIProcess/WebPageProxy.h: The vector m_currentlyProcessedWheelEvents used to hold the
series of wheel events that were coalesced and sent as a single wheel event to the web
process. When the web process acknowledges this with didReceiveEvent, the UI process
cleared that vector, then tried to coalesce the next wheel event to send. Now we might have
multiple sets of coalesced wheel events that we are sending to the web process. To keep
track of these sets, m_currentlyProcessedWheelEvents now is a queue of Vectors.
(WebPageProxy):
- UIProcess/WebPageProxy.cpp: Add new constant wheelEventQueueSizeThreshold representing
the threshold of scroll events to look for before we start pushing events.
(WebKit::canCoalesce): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::coalesce): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::coalescedWheelEvent): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::WebPageProxy::handleWheelEvent): If we are currently waiting for acknowledgment
from the web process that a wheel event has been handled, we add it to the queue. We
check to see that the queue size is within our threshold before we return early. Otherwise
we will start pushing events in the queue. Refactor the rest of the function into
processNextQueuedWheelEvent() and sendWheelEvent(). If we are not currently waiting for
acknowledgment, nor have events in the queue, then we send the current wheel event.
(WebKit::WebPageProxy::processNextQueuedWheelEvent): Try to coalesce events based on the
wheel event at the head of the queue, and send that event to the web process.
(WebKit::WebPageProxy::sendWheelEvent): Refactored from handleWheelEvent().
(WebKit::WebPageProxy::didReceiveEvent): Instead of clearing m_currentlyProcessedWheelEvents,
which contained the set of one coalesced wheel event, we pull the head Vector, which
contains the same set of events. Refactor to use processNextQueuedWheelEvent().
- 4:24 PM Changeset in webkit [116465] by
-
- 3 edits2 adds in trunk
JavaScriptAudioNode should not ASSERT if number of input channels is 0
https://bugs.webkit.org/show_bug.cgi?id=85818
Patch by Raymond Toy <Raymond Toy> on 2012-05-08
Reviewed by Eric Seidel.
Source/WebCore:
Test: webaudio/javascriptaudionode-zero-input-channels.html
- Modules/webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::process): Update buffersAreGood.
(WebCore::JavaScriptAudioNode::fireProcessEvent): Remove ASSERT.
LayoutTests:
- webaudio/javascriptaudionode-zero-input-channels-expected.txt: Added.
- webaudio/javascriptaudionode-zero-input-channels.html: Added.
- 4:21 PM Changeset in webkit [116464] by
-
- 4 edits1 add in trunk
[EFL][DRT] EventSender needs implementation of leapForward function
https://bugs.webkit.org/show_bug.cgi?id=83486
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08
Reviewed by Eric Seidel.
Tools:
Implemented leapForward function in Efl's DRT. This function is required
to delay and queue event execution and simulate real user behavior.
- DumpRenderTree/efl/EventSender.cpp:
(DelayedEvent):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(sendClick):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):
(leapForwardCallback):
(mouseScrollByCallback):
(feedOrQueueMouseEvent):
(feedMouseEvent):
(feedQueuedMouseEvents):
LayoutTests:
Unskipping few tests that were failing due to the missing leapForward function
Added EFL specific test result, since EFL doesnt support 2D wheel events
- platform/efl/Skipped:
- platform/efl/fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
- 4:01 PM Changeset in webkit [116463] by
-
- 4 edits in trunk/Source
Region reads past end of spans
https://bugs.webkit.org/show_bug.cgi?id=85909
Reviewed by Anders Carlsson.
Source/WebCore:
Region currently checks aSpan == aSpanEnd as the indicator that
we passed all the spans. When aSpan < aSpanEnd, it uses aSpan+1
to find the height of the span.
If aSpan == aSpanEnd - 1, then aSpan+1 == aSpanEnd. This does not
represent a valid span, since aSpanEnd is past the end of the
array, not the last element in the array. The loop should terminate
in this case.
Checking aSegment != aSegmentEnd is acceptable in the inner loop since
it increments by two each time (segments come in pairs, while spans
come in singles).
Test: RegionTest.ReadPastFullSpanVectorInIntersectsTest
- platform/graphics/Region.cpp:
(WebCore::Region::Shape::compareShapes):
Source/WebKit/chromium:
- tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):
- 4:01 PM Changeset in webkit [116462] by
-
- 3 edits2 adds in trunk/Source/WebKit
Source/WebKit: [BlackBerry] Implement a popup client for HTML controls
https://bugs.webkit.org/show_bug.cgi?id=85670
Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08
Reviewed by Rob Buis.
Add popup client file to build system.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry: [BlackBerry] Implement a popup client for HTML controls
Reviewed by Rob Buis.
Implement a popup client for HTML controls, which would be used to load
different popups according to popup type.
- WebCoreSupport/PagePopupBlackBerry.cpp: Added. (WebCore): (PagePopupChromeClient): (WebCore::PagePopupChromeClient::PagePopupChromeClient): (WebCore::PagePopupChromeClient::closeWindowSoon): (WebCore::PagePopupChromeClient::webPage): (WebCore::PagePopupBlackBerry::PagePopupBlackBerry): (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry): (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest): (WebCore::PagePopupBlackBerry::init): (WebCore::setValueAndClosePopupCallback): (WebCore::popUpExtensionInitialize): (WebCore::popUpExtensionFinalize): (WebCore::PagePopupBlackBerry::installDomFunction): (WebCore::PagePopupBlackBerry::handleMouseEvent): (WebCore::PagePopupBlackBerry::closePopup): (WebCore::PagePopupBlackBerry::closeWebPage):
- WebCoreSupport/PagePopupBlackBerry.h: Added. (WebKit): (WebCore): (PagePopupBlackBerry):
Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08
- 3:50 PM Changeset in webkit [116461] by
-
- 2 edits in trunk/Tools
[EFL][DRT] WebKit/DRT should not paint webview for the pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=79853
Reviewed by Eric Seidel.
Screen buffer can be different from rendered results.
For example, WebKit/Efl just moves tiles for ewk_view_tiled when scrolling
contents.
It means that pixel tests can't check regression of ewk_view_tiled.
This patch changes a way to provide bitmap from painting webview to capturing
evas.
- DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
(createBitmapContextFromWebView):
- 3:45 PM Changeset in webkit [116460] by
-
- 3 edits3 adds in trunk/Source/WebKit/chromium
move listener_leak_test to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85922
Reviewed by Ojan Vafai.
Porting the test from src/webkit/tools/test_shell/listener_leak_test.cc.
All I did was change the style and use the FrameTestHelper to load the file.
- WebKit.gyp: Exclude file in components build.
- WebKit.gypi: Add new file.
- tests/ListenerLeakTest.cpp: Added.
(WebKit):
(WebKit::GetProperty):
(WebKit::GetNumObjects):
(ListenerLeakTest):
(WebKit::ListenerLeakTest::ListenerLeakTest):
(WebKit::ListenerLeakTest::RunTest):
(WebKit::TEST_F):
- tests/data/listener/listener_leak1.html: Added.
- tests/data/listener/listener_leak2.html: Added.
- 3:31 PM Changeset in webkit [116459] by
-
- 1 edit22 adds in trunk/LayoutTests
Add mac results for new tests following http://trac.webkit.org/changeset/116438.
- 3:29 PM Changeset in webkit [116458] by
-
- 5 edits8 adds in trunk
Prevent crash in animated lists
https://bugs.webkit.org/show_bug.cgi?id=85382
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Animated lists blindly assign the last list value to m_toAtEndOfDurationType
in SVGAnimationElement::startedActiveInterval. If the last list value's length
is larger or smaller than the animated "to" length, we crash.
This change prevents accessing values off the end of toAtEndOfDuration by adding
a check for this case. It may seem inefficient to perform this check on every
animation update but the "to" value can change (in cardinality) while animating.
I checked each of the other animation types (e.g., SVGAnimatedAngle,
SVGAnimatedBoolean, etc.) and was only able to hit this style of crash
in the three types modified in this change:
SVGAnimatedLengthList, SVGAnimatedNumberList, and SVGAnimatedPointList.
Tests: svg/animations/animate-linear-discrete-additive-b-expected.svg
svg/animations/animate-linear-discrete-additive-b.svg
svg/animations/animate-linear-discrete-additive-c-expected.svg
svg/animations/animate-linear-discrete-additive-c.svg
svg/animations/animate-linear-discrete-additive-expected.svg
svg/animations/animate-linear-discrete-additive.svg
svg/animations/animate-list-crash.svg
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
- svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
LayoutTests:
- svg/animations/animate-linear-discrete-additive-b-expected.svg: Added.
- svg/animations/animate-linear-discrete-additive-b.svg: Added.
- svg/animations/animate-linear-discrete-additive-c-expected.svg: Added.
- svg/animations/animate-linear-discrete-additive-c.svg: Added.
- svg/animations/animate-linear-discrete-additive-expected.svg: Added.
- svg/animations/animate-linear-discrete-additive.svg: Added.
- svg/animations/animate-list-crash-expected.txt: Added.
- svg/animations/animate-list-crash.svg: Added.
- 3:04 PM Changeset in webkit [116457] by
-
- 3 edits in trunk/Source/WebCore
HTMLElementStack::hasOnlyHTMLElementsInScope is no longer called
https://bugs.webkit.org/show_bug.cgi?id=85908
Reviewed by Eric Seidel.
This patch just removes the dead code.
No tests needed. Cleanup only.
- html/parser/HTMLElementStack.cpp:
- html/parser/HTMLElementStack.h:
(HTMLElementStack):
- 2:57 PM Changeset in webkit [116456] by
-
- 6 edits5 adds in trunk/Source
[chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=85084
Reviewed by James Robinson.
Source/WebCore:
Unit test provided.
Creates a layer delegate class to provide link highlight animations for link-preview feature.
These are added to a GraphicsLayerChromium via provided methods. Moves dispensing of animation
ids into a separate class.
- WebCore.gypi:
- platform/graphics/chromium/AnimationIdVendor.cpp: Added.
(WebCore):
(WebCore::AnimationIdVendor::getNextAnimationId):
(WebCore::AnimationIdVendor::getNextGroupId):
- platform/graphics/chromium/AnimationIdVendor.h: Added.
(WebCore):
(AnimationIdVendor):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore):
(GraphicsLayerChromium):
- platform/graphics/chromium/LinkHighlight.cpp: Added.
(WebCore):
(WebCore::LinkHighlight::create):
(WebCore::LinkHighlight::LinkHighlight):
(WebCore::LinkHighlight::~LinkHighlight):
(WebCore::LinkHighlight::contentLayer):
(WebCore::LinkHighlight::paintContents):
(WebCore::LinkHighlight::notifyAnimationStarted):
(WebCore::LinkHighlight::notifyAnimationFinished):
- platform/graphics/chromium/LinkHighlight.h: Added.
(WebCore):
(LinkHighlight):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/LinkHighlightTest.cpp: Added.
(WebCore):
(MockGraphicsLayerClient):
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TEST):
- 2:52 PM Changeset in webkit [116455] by
-
- 2 edits in trunk/Source/JavaScriptCore
SIGFPE on divide in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=85917
Rubber stamped by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- check for divisor of -1.
- 2:22 PM Changeset in webkit [116454] by
-
- 1 edit20 copies44 moves74 adds in trunk/LayoutTests
Chromium rebaselines after http://trac.webkit.org/changeset/116438.
- platform/chromium-linux/css2.1/20110323/first-letter-000-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003a-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-inherit-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-007-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png.
- platform/chromium-linux/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png.
- platform/chromium-linux/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/chromium-mac-leopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-000-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-001-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
- platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.txt: Added.
- platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/chromium-win/css2.1/20110323/first-letter-000-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt.
- platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt.
- platform/chromium-win/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
- platform/chromium-win/fast/css/first-letter-nested-positioned-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt.
- platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
- platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt.
- 1:32 PM Changeset in webkit [116453] by
-
- 7 edits8 deletes in trunk
[CMake] Rewrite FindGStreamer.cmake.
https://bugs.webkit.org/show_bug.cgi?id=85857
Reviewed by Daniel Bates.
.:
We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.
FindGStreamer.cmake has then been rewritten to take all that into
account:
- The LibFindMacros.cmake package is not used anymore.
- Version check is performed in the CMake file itself by parsing
the gstversion.h header.
- All GStreamer plugins are searched and the COMPONENTS keyword
used in the FIND_PACKAGE() call is used to check which plugins are
required.
- The plugins-base and base GStreamer plugins are not searched, as
they were not used anywhere in the build system.
- Source/cmake/FindGStreamer-App.cmake: Removed.
- Source/cmake/FindGStreamer-Audio.cmake: Removed.
- Source/cmake/FindGStreamer-Base.cmake: Removed.
- Source/cmake/FindGStreamer-FFT.cmake: Removed.
- Source/cmake/FindGStreamer-Interfaces.cmake: Removed.
- Source/cmake/FindGStreamer-Pbutils.cmake: Removed.
- Source/cmake/FindGStreamer-Plugins-Base.cmake: Removed.
- Source/cmake/FindGStreamer-Video.cmake: Removed.
- Source/cmake/FindGStreamer.cmake: Rewrite as described above.
- Source/cmake/OptionsEfl.cmake: Use COMPONENTS to specify which
GStreamer plugins to look for.
Source/WebCore:
No new tests, build system change.
We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.
FindGStreamer.cmake has then been rewritten to take all that into
account:
- The LibFindMacros.cmake package is not used anymore.
- Version check is performed in the CMake file itself by parsing
the gstversion.h header.
- All GStreamer plugins are searched and the COMPONENTS keyword
used in the FIND_PACKAGE() call is used to check which plugins are
required.
- The plugins-base and base GStreamer plugins are not searched, as
they were not used anywhere in the build system.
- PlatformEfl.cmake: Update GStreamer-related variable names.
Source/WebKit:
We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.
FindGStreamer.cmake has then been rewritten to take all that into
account:
- The LibFindMacros.cmake package is not used anymore.
- Version check is performed in the CMake file itself by parsing
the gstversion.h header.
- All GStreamer plugins are searched and the COMPONENTS keyword
used in the FIND_PACKAGE() call is used to check which plugins are
required.
- The plugins-base and base GStreamer plugins are not searched, as
they were not used anywhere in the build system.
- PlatformEfl.cmake: Update GStreamer-related variable names.
- 1:24 PM Changeset in webkit [116452] by
-
- 5 edits in trunk
[EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=85479
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
EFL's PlatformKeyboardEvent::isKeypad() now returns meaningful value.
Added numeric-pad keys to the Key Map and Windows Key Map.
No new tests.
- platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):
- platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
LayoutTests:
Unskipped fast/events/keydown-numpad-keys.html.
- platform/efl/Skipped:
- 12:44 PM Changeset in webkit [116451] by
-
- 19 edits2 adds in trunk
Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation
https://bugs.webkit.org/show_bug.cgi?id=85627
Reviewed by Antti Koivisto.
Source/WebCore:
Example:
<rect width="10" height="100">
<animate attributeName="width" from="10" to="100" begin="2s" dur="4s" fill="remove"/>
</rect>
At t=0s the <animate> element receives its first interval: begin=2s, end=6s.
At this point we've created the 'OwnPtr<SVGAnimatedType> m_animatedType' in
SVGAnimateElement, which holds the current animated value of the target type.
In this example it contains a SVGLength with '10' as value at t=0s.
Calling "rect.width.animVal.value" will return the value currently contained in the
m_animatedType from the SVGAnimateElement, even though the animation didn't begin
yet. This is fine, as the animVal equals to the baseVal, as long as no animation is
running.
At t=6s you'd expect that the whole 'animVal' object is destructed again, as it's no
longer needed, as animVal will be equal to baseVal again, but the current code keeps
the animVal alive, and just resets it to the baseVal. The animVals will be destructed
once the animate element leaves the tree.
CSS animations suffer from the same problem, we never remove the animated SMIL properties
but we only reset them to the base value. This makes integration with CSS Animations and
CSS Transitions harder, so this needs to be changed.
This patch starts tracking the start/end of an animation chain properly, to destruct
the animation effect for non-frozen animations at the end of their duration. This has to
work properly together with seeking (SVGSVGElement.setCurrentTime), as our testing relies
on the ability to drive the SMIL timeline from script.
Tests: svg/animations/list-wrapper-assertion-expected.svg
svg/animations/list-wrapper-assertion.svg
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::resetAnimatedType):
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
(WebCore::applyCSSPropertyToTargetAndInstances):
(WebCore::removeCSSPropertyFromTargetAndInstances):
(WebCore::notifyTargetAboutAnimValChange):
(WebCore::notifyTargetAndInstancesAboutAnimValChange):
(WebCore::SVGAnimateElement::clearAnimatedType):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::targetElementWillChange):
- svg/SVGAnimateElement.h:
(SVGAnimateElement):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::resetAnimatedType):
(WebCore::SVGAnimateMotionElement::clearAnimatedType):
- svg/SVGAnimateMotionElement.h:
(SVGAnimateMotionElement):
- svg/SVGAnimationElement.cpp:
- svg/SVGAnimationElement.h:
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::reset):
(WebCore::SVGSMILElement::targetElementWillChange):
(WebCore::SVGSMILElement::determineActiveState):
(WebCore::SVGSMILElement::progress):
- svg/animation/SVGSMILElement.h:
(SVGSMILElement):
- svg/properties/SVGAnimatedListPropertyTearOff.h:
Remove svgAttributeChanged() calls from animationEnded/animValDidChange.
Callers are now required to notify the target about changes. There are cases
where we want to call animValDidChange without invoking svgAttributeChanged().
That is supported now.
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):
- svg/properties/SVGAnimatedProperty.h: Ditto.
(WebCore::SVGAnimatedProperty::commitChange): Add safety guard.
- svg/properties/SVGAnimatedPropertyTearOff.h: Ditto.
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animValDidChange):
- svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):
LayoutTests:
Update animate-target-id-changed.svg test to match Firefox behavior.
When an animation element with fill="freeze" is changed to a new target
eg, via animate.href = "#someOtherID", the animation effect should be removed.
Add tests for assertions I ran into while developing this patch.
- platform/chromium/test_expectations.txt: Require new results for animate-target-id-changed-expected.txt.
- platform/mac/svg/custom/animate-target-id-changed-expected.png:
- svg/animations/list-wrapper-assertion-expected.svg: Added.
- svg/animations/list-wrapper-assertion.svg: Added.
- svg/custom/animate-target-id-changed-expected.txt:
- svg/custom/animate-target-id-changed.svg:
- 12:36 PM Changeset in webkit [116450] by
-
- 2 edits in trunk/Source/WebCore
[EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled.
https://bugs.webkit.org/show_bug.cgi?id=81315
Reviewed by Chang Shu.
ScrollbarEfl creates custom scrollbars as separated layer and they are
not related to ScrollbarTheme.
So, DRT/Efl creates custom scrollbars on webview which paints mockScrollbar.
This patch prevents creating custom scrollbars when mockScrollbar is enabled.
Because DRT/Efl only renders the webview now, expected results are same
until Bug 79853 is landed.
- platform/efl/ScrollbarEfl.cpp:
(Scrollbar::createNativeScrollbar):
- 12:33 PM Changeset in webkit [116449] by
-
- 7 edits in trunk/Source
Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen.
dyld only considers libraries in the versioned framework path if their install name
matches the library that it is attempting to load. The path we were passing to
dlopen lacked the Versions/A component of the path so dyld did not recognize that
we wanted it to use the staged version if it is newer.
<rdar://problem/11406517>
Reviewed by Mark Rowe.
Source/WebCore:
- platform/mac/SoftLinking.h: Have SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL take the
framework version as an argument and use it when constructing the path to dlopen.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
- WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.
- 12:26 PM Changeset in webkit [116448] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r116440.
http://trac.webkit.org/changeset/116440
https://bugs.webkit.org/show_bug.cgi?id=85904
Broke the Chromium Android bot (Requested by beverloo on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08
- WTF.gyp/WTF.gyp:
- 12:16 PM Changeset in webkit [116447] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Qt Snowleopard Release
https://bugs.webkit.org/show_bug.cgi?id=85895
Reviewed by Alexis Menard.
The enum value JSUint8ClampedArray conflicted with the JSUint8ClampedArray class.
I've added the 'Type' suffix to the enum value to make their names different.
No new tests needed.
- bridge/qt/qt_runtime_qt4.cpp:
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):
- 12:11 PM Changeset in webkit [116446] by
-
- 8 edits2 adds in trunk
offsetLeft broken within CSS3 columns
https://bugs.webkit.org/show_bug.cgi?id=34875
Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-08
Reviewed by Julien Chaffraix.
Source/WebCore:
Reimplement offsetLeft and offsetTop in terms of a new method called
'offsetTopLeft'. The new method starts from a reference point (the
top-left coordinate of a box or inline) and adjusts this reference
point for columns as we traverse each parent. Note that the reference
point needs to be adjusted in both dimensions, even though offsetLeft
and offsetTop return only one of them.
A new method called 'offsetForColumns' was added to RenderObject. This
method is similar to adjustForColumns, except that it returns the
offset instead of modifying a reference. This method is necessary to
simplify the implementation of offsetTopLeft.
Tests: fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt
fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
- rendering/RenderBox.h:
(RenderBox):
Override offsetLeft and offsetTop.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetLeft):
Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
topLeftLocation as startPoint.
(WebCore::RenderBox::offsetTop):
Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
topLeftLocation as startPoint.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::offsetTopLeft):
New method to compute offsetLeft and offsetTop simultaneously, and
adjusting for columns at each parent.
(WebCore::RenderBoxModelObject::offsetLeft):
Reimplemented in terms of offsetTopLeft.
(WebCore::RenderBoxModelObject::offsetTop):
Reimplemented in terms of offsetTopLeft.
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
Declare new offsetTopLeft method.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::offsetLeft):
Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.
(WebCore::RenderInline::offsetTop):
Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::offsetForColumns):
New helper method to simplify implementation of offsetTopLeft.
LayoutTests:
Add test for offsetLeft and offsetTop within multi-columns.
- fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Added.
- fast/block/positioning/offsetLeft-offsetTop-multicolumn.html: Added.
- 12:09 PM Changeset in webkit [116445] by
-
- 3 edits in trunk/LayoutTests
[EFL] media/video-play-require-user-gesture.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=85900
Unreviewed gardening.
Move media/video-play-require-user-gesture.html to test_expectations.txt since
it requires Full Screen API support. Also move fullscreen tests from Skipped
list to test_expectations.txt
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 12:07 PM Changeset in webkit [116444] by
-
- 2 edits in trunk/LayoutTests
[EFL] Layout test fast/overflow/lots-of-sibling-inline-boxes.html is flaky in debug builds
https://bugs.webkit.org/show_bug.cgi?id=85896
Unreviewed gardening.
Marking test as slow, since it times-out when executed using debug builds under
heavy processor loads.
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08
- platform/efl/test_expectations.txt:
- 12:04 PM Changeset in webkit [116443] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update Web Timing tests expectations
https://bugs.webkit.org/show_bug.cgi?id=85622
Unreviewed Gardening.
Removed http/tests/misc/webtiming-origins.html and
http/tests/misc/webtiming-ssl from test expectations.
They started to pass after r116160.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
- platform/efl/test_expectations.txt:
- 11:57 AM Changeset in webkit [116442] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/security/cross-frame-access-* tests are failing
https://bugs.webkit.org/show_bug.cgi?id=85899
Unreviewed, move failing tests to test expectations.
http/tests/security/cross-frame-access-* tests are failing because EFL port
does not support showModalDialog. We need to move the test cases to test
expectations while the feature is implemented.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
- platform/efl/test_expectations.txt:
- 11:51 AM Changeset in webkit [116441] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 115458 - NULL-deref in RenderBox::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=84774
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/inline/crash-new-continuation-with-outline.html
The bug comes from trying to repaint the :after content as part of updateBeforeAfterContent.
The repainting logic would query the yet-to-be-inserted continuation(). Then we would crash in
RenderBox::clippedOverflowRectForRepaint as we didn't have an enclosingLayer() (which any
RenderObject in the tree will have).
The fix is to check in RenderInline::clippedOverflowRectForRepaint that our continuation()
is properly inserted in the tree. We could check that it isRooted() but it's an overkill here.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
LayoutTests:
- fast/inline/crash-new-continuation-with-outline-expected.txt: Added.
- fast/inline/crash-new-continuation-with-outline.html: Added.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10375053
- 11:45 AM Changeset in webkit [116440] by
-
- 2 edits in trunk/Source/WTF
[Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
https://bugs.webkit.org/show_bug.cgi?id=85897
Reviewed by Tony Chang.
- WTF.gyp/WTF.gyp:
- 11:41 AM UsingGitWithWebKit edited by
- (diff)
- 11:33 AM Changeset in webkit [116439] by
-
- 3 edits in trunk
perf-o-matic fix attempt for dashboard images.
Rubber-stamped by Antti Koivisto.
Also stop generating images for 30, 90, and 365 days since they have been timing out.
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
- Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):
- 11:25 AM Changeset in webkit [116438] by
-
- 5 edits67 adds in trunk
CSS 2.1 failure: first-letter-nested-004.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72987
Reviewed by Eric Seidel.
Source/WebCore:
When styling first-letter check each sibling and drill into its inlines until we find either (i) a text node
that is not all whitespace, or (ii) a line break.
This makes our rendering of the following tests compatible with FF and Opera. Our current behaviour is also conformant
since the spec allows UAs to style just one element:
css2.1/20110323/first-letter-quote-002.htm
css2.1/20110323/first-letter-quote-003.htm
css2.1/20110323/first-letter-quote-004.htm
css2.1/20110323/first-letter-quote-005.htm
This fixes the following two tests. We now drill into the descendants of an element styled with :first-letter looking
for text to style:
css2.1/20110323/first-letter-nested-004.htm
css2.1/20110323/first-letter-nested-006.htm
This patch changes our rendering of first-letter-dynamic-001.htm as we now render adjacent quotes in the second line as
green. This is consistent with the spec, which allows this behaviour but does not require it. It's the 'right' behaviour
since it is consistent with the rendering of such quotes in a single element with :first-letter style.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::findLastObjectWithFirstLetterText): Iterate through the child's siblings looking for the last
object to be styled :first-letter.
(WebCore::RenderBlock::findLastObjectAfterFirstLetterPunctuation): Style any leading punctuation as first-letter, drill
down into the child's descendants looking for text if necessary.
(WebCore::RenderBlock::updateFirstLetter): Refactor to drill into sibling's children looking for inlines
that should be styled as first-letter.
(WebCore::RenderBlock::addFirstLetter): Split out from updateFirstLetter so that it can be used when a
descendant node inside a sibling is found in findLastObjectWithFirstLetterText() needs to be styled as first-letter.
- rendering/RenderBlock.h:
LayoutTests:
- css2.1/20110323/first-letter-000.htm: Added.
- css2.1/20110323/first-letter-001.htm: Added.
- css2.1/20110323/first-letter-dynamic-001.htm: Added.
- css2.1/20110323/first-letter-dynamic-002.htm: Added.
- css2.1/20110323/first-letter-dynamic-003a.htm: Added.
- css2.1/20110323/first-letter-dynamic-003b.htm: Added.
- css2.1/20110323/first-letter-inherit-001.htm: Added.
- css2.1/20110323/first-letter-nested-001.htm: Added.
- css2.1/20110323/first-letter-nested-002.htm: Added.
- css2.1/20110323/first-letter-nested-003.htm: Added.
- css2.1/20110323/first-letter-nested-004.htm: Added.
- css2.1/20110323/first-letter-nested-005.htm: Added.
- css2.1/20110323/first-letter-nested-006.htm: Added.
- css2.1/20110323/first-letter-nested-007.htm: Added.
- css2.1/20110323/first-letter-quote-001.htm: Added.
- css2.1/20110323/first-letter-quote-002.htm: Added.
- css2.1/20110323/first-letter-quote-003.htm: Added.
- css2.1/20110323/first-letter-quote-004.htm: Added.
- css2.1/20110323/first-letter-quote-005.htm: Added.
- css2.1/20110323/first-letter-quote-006.htm: Added.
- fast/css/first-letter-capitalized-edit-select-crash-expected.txt: Rebaselined.
- fast/css/first-letter-nested-positioned.htm: Added.
Tests that text nested inside a positioned object is styled.
- fast/css/first-letter-quotes-no-content-before-after.html: Added.
Tests that two consecutive quotes, each in a :before and :after pseudo element surrounding
an empty main element, get styled with first letter.
Behold! Pixel Results!
- platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png: Added.
- platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
- platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
- 11:09 AM Changeset in webkit [116437] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r116402.
http://trac.webkit.org/changeset/116402
https://bugs.webkit.org/show_bug.cgi?id=85898
Caused a 3% regression on Chromium's bloat-http test on Linux
(Requested by ojan_gardening on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08
- WebCore.exp.in:
- bindings/v8/RetainedDOMInfo.cpp:
- dom/ContainerNode.h:
- dom/Node.cpp:
(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):
- dom/Node.h:
(Node):
- 10:58 AM Changeset in webkit [116436] by
-
- 3 edits in trunk
[CMake] Add ENABLE_IFRAME_SEAMLESS flag
https://bugs.webkit.org/show_bug.cgi?id=85838
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
Reviewed by Eric Seidel.
Add ENABLE_IFRAME_SEAMLESS flag to CMake and enable it by default.
This flag was introduced by r116356.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 10:51 AM Changeset in webkit [116435] by
-
- 3 edits4 adds in trunk
[Chromium] Fix the position of an RTL resizer
https://bugs.webkit.org/show_bug.cgi?id=80640
Reviewed by Tony Chang.
When rendering an RTL resizer, my r110073 renders it at the same position as the
one used for rendering a LTR resizer. Unfortunately, this code renders the RTL
resizer image at an incorrect position on Mac and Linux. This change uses the
correct formula to calculate the position of an RTL resizer.
Source/WebCore:
Test: platform/chromium/scrollbars/rtl-resizer-position.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
LayoutTests:
- platform/chromium/platform/chromium/scrollbars: Added.
- platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.png: Added.
- platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.txt: Added.
- platform/chromium/scrollbars/rtl-resizer-position.html: Added.
- 10:14 AM Changeset in webkit [116434] by
-
- 2 edits in trunk/Tools
[GTK] Memory leak in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=85886
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-08
Reviewed by Martin Robinson.
Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
JSString created with JSStringCreateWithUTF8CString.
- DumpRenderTree/gtk/EventSender.cpp:
(gdkModifersFromJSValue):
- 10:06 AM Changeset in webkit [116433] by
-
- 3 edits2 adds in trunk/Source/WebKit/chromium
[chromium] move event_listener_unittest to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85836
Reviewed by James Robinson.
Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
All I did was change the style and use the FrameTestHelper to load the file.
- WebKit.gyp: Exclude file in components build.
- WebKit.gypi: Add new file.
- tests/EventListenerTest.cpp: Added.
(WebKit):
(TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::~TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::eventCount):
(WebKit::TestWebDOMEventListener::eventAt):
(WebKit::TestWebDOMEventListener::clearEvents):
(WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::SetUp):
(WebKit::WebDOMEventListenerTest::TearDown):
(WebKit::WebDOMEventListenerTest::mainFrame):
(WebKit::WebDOMEventListenerTest::document):
(WebKit::WebDOMEventListenerTest::executeScript):
(WebKit::WebDOMEventListenerTest::GetNodeID):
(WebKit::TEST_F):
- tests/data/listener/mutation_event_listener.html: Added.
- 10:01 AM Changeset in webkit [116432] by
-
- 2 edits in trunk/Tools
[EFL] glib dependency needs to be updated in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=85878
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
Reviewed by Martin Robinson.
Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
addresses flakiness in media tests due to possible deadlock with the
following output on stderr:
GStreamer-WARNING : wrong STREAM_LOCK count 0
The bug was fixed upstream by:
http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f
- efl/jhbuild.modules:
- 9:57 AM Changeset in webkit [116431] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip failing tests.
- platform/qt-5.0/Skipped:
- 9:27 AM Changeset in webkit [116430] by
-
- 53 edits in trunk/Source/WebCore
Element: isURLAttribute() should take a const Attribute&.
<http://webkit.org/b/85890>
Reviewed by Anders Carlsson.
Change isURLAttribute(Attribute*) to isURLAttribute(const Attribute&) to enforce
the fact that the Attribute can't be null, and shouldn't be mutated, at compile-time.
Also sprinkle OVERRIDE while we're at it.
- dom/Element.cpp:
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
- dom/Element.h:
(WebCore::Element::isURLAttribute):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendAttribute):
- editing/markup.cpp:
(WebCore::completeURLs):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isURLAttribute):
- html/HTMLAnchorElement.h:
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::isURLAttribute):
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::isURLAttribute):
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::isURLAttribute):
- html/HTMLButtonElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::isURLAttribute):
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isURLAttribute):
- html/HTMLEmbedElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::isURLAttribute):
- html/HTMLFormElement.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAttribute):
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
- html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::isURLAttribute):
- html/HTMLHtmlElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isURLAttribute):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isURLAttribute):
- html/HTMLInputElement.h:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::isURLAttribute):
- html/HTMLLinkElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isURLAttribute):
- html/HTMLMediaElement.h:
- html/HTMLModElement.cpp:
(WebCore::HTMLModElement::isURLAttribute):
- html/HTMLModElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isURLAttribute):
- html/HTMLObjectElement.h:
- html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLAttribute):
- html/HTMLParamElement.h:
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::isURLAttribute):
- html/HTMLQuoteElement.h:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::isURLAttribute):
- html/HTMLScriptElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::isURLAttribute):
- html/HTMLSourceElement.h:
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::isURLAttribute):
- html/HTMLTableCellElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isURLAttribute):
- html/HTMLTableElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::isURLAttribute):
- html/HTMLTrackElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::isURLAttribute):
- html/HTMLVideoElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isURLAttribute):
- svg/SVGScriptElement.h:
- 9:21 AM Changeset in webkit [116429] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Over-scroll image should be tiled
https://bugs.webkit.org/show_bug.cgi?id=85860
Patch by Andrew Lo <anlo@rim.com> on 2012-05-08
Reviewed by Rob Buis.
Implement tiling for over-scroll image if image dimension don't match
the surface dimensions.
- Api/BackingStore.cpp:
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- 8:53 AM Changeset in webkit [116428] by
-
- 41 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip now passing tests, update platform specific expected files.
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/qt/fast/block/float/016-expected.png:
- platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Added.
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
- platform/qt/fast/js/constructor-length-expected.txt: Added.
- platform/qt/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/qt/fast/repaint/scale-page-shrink-expected.txt: Added.
- platform/qt/fast/table/027-expected.png:
- platform/qt/fast/table/027-expected.txt:
- platform/qt/fast/table/027-vertical-expected.png:
- platform/qt/fast/table/027-vertical-expected.txt:
- platform/qt/tables/mozilla/bugs/bug14929-expected.png:
- platform/qt/tables/mozilla/bugs/bug14929-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2123-expected.png:
- platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2509-expected.png:
- platform/qt/tables/mozilla/bugs/bug2509-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug2947-expected.png:
- platform/qt/tables/mozilla/bugs/bug2947-expected.txt:
- platform/qt/tables/mozilla/bugs/bug34176-expected.png:
- platform/qt/tables/mozilla/bugs/bug34176-expected.txt:
- platform/qt/tables/mozilla/bugs/bug44505-expected.png:
- platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/qt/test_expectations.txt:
- 8:46 AM Changeset in webkit [116427] by
-
- 2 edits in trunk/Source/WebCore
Shrink ElementAttributeData by factoring out Attr object count.
https://bugs.webkit.org/show_bug.cgi?id=85825
Unreviewed build fix.
- dom/ElementAttributeData.cpp:
(WebCore::attrListForElement): Was returning false instead of 0 for a pointer value. Now returns 0.
- 8:27 AM Changeset in webkit [116426] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] fast/layers/video-layer.html needs rebaseline after bug85602 landed
https://bugs.webkit.org/show_bug.cgi?id=85873
Unreviewed, EFL gardening.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08
- platform/efl/fast/layers/video-layer-expected.txt:
- 8:24 AM Changeset in webkit [116425] by
-
- 1 add in branches/chromium/1130/codereview.settings
adding codereview.settings for easy drovering
- 8:23 AM Changeset in webkit [116424] by
-
- 1 copy in branches/chromium/1130
creating chromium m20 branch
- 8:20 AM Changeset in webkit [116423] by
-
- 3 edits in trunk/Source/WebCore
Element: Merge idAttributeChanged() into attributeChanged().
<http://webkit.org/b/85885>
Reviewed by Antti Koivisto.
No new tests, code churn only.
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::attributeChanged): There's no need for this to be a standalone function anymore.
- 7:59 AM Changeset in webkit [116422] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Integrate Page Visibility state change and WK2 Suspend/Resume API
https://bugs.webkit.org/show_bug.cgi?id=85650
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.
This patch uses state changes of the Page Visibility API to trigger the
automatic suspension/resume of animations on the WebPage and its main frame,
in the same fashion of what is used by the Suspend/Resume API of WebKit2.
By telling the WebPage it will move off/on the screen and the FrameView to
hide/show, this patch is suspending/resuming animations (animated painting)
but not timers and other active DOM objects.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setVisibilityState):
- 7:42 AM Changeset in webkit [116421] by
-
- 2 edits7 adds in trunk/LayoutTests
[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=85875
Unreviewed, add EFL baselines for the tests which are missing expected
results.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-08
- platform/efl/fast/css/first-line-text-decoration-expected.png: Added.
- platform/efl/fast/css/first-line-text-decoration-expected.txt: Added.
- platform/efl/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
- platform/efl/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
- platform/efl/fast/images/png-suite/test-expected.png: Added.
- platform/efl/fast/images/png-suite/test-expected.txt: Added.
- platform/efl/test_expectations.txt:
- 7:12 AM Changeset in webkit [116420] by
-
- 3 edits1 add in trunk/Source/WebKit2
[Qt] Add QML/WK2 evaluateJavaScript experimental API
https://bugs.webkit.org/show_bug.cgi?id=85496
Reviewed by Simon Hausmann.
This is an initial patch adding support for strings,
numbers and bools as return values.
Test: qmltests/WebView/tst_evaluateJavaScript.qml
- UIProcess/API/qt/qquickwebview.cpp:
(JSCallbackClosure):
(toQString):
(toQJSValue):
(buildQJSValue):
(javaScriptCallback):
(QQuickWebViewExperimental::evaluateJavaScript):
(QQuickWebView::runJavaScriptInMainFrame):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Added.
- 7:09 AM Changeset in webkit [116419] by
-
- 4 edits in trunk/Source/WebCore
Shrink ElementAttributeData by factoring out Attr object count.
<http://webkit.org/b/85825>
Reviewed by Antti Koivisto.
Stop tracking the number of Attr objects that point to a given Element on the
Element itself and manage this by having a global hashmap of Element => AttrList,
where AttrList is a vector of (pointers to) the associated Attr objects.
This shrinks ElementAttributeData by one integer, effectively reducing memory
consumption by ~530kB when viewing the full HTML5 spec at <http://whatwg.org/c>.
- dom/ElementAttributeData.h:
(ElementAttributeData):
Remove m_attrCount...
- dom/Node.h:
(WebCore::Node::hasAttrList):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):
...replacing it with a Node flag that tells us whether there's an Attr
object map for this Node (only applies to Elements.)
- dom/ElementAttributeData.cpp:
(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttributesFromElement):
Map Element => per-Element AttrList in a global hash.
- 7:02 AM Changeset in webkit [116418] by
-
- 5 edits in trunk/Source
[Blackberry] remove m_isRequestedByPlugin in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=84559
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-08
Reviewed by Antonio Gomes.
Source/WebCore:
ResourceRequest is a network level abstraction, and it should
not know anything about web concepts such as plug-ins, and Blackberry
does not need m_isRequestedByPlugin any longer, So clean up all related
code.
Tested on a website of http://edition.cnn.com, a new window should be
opened only when user has a singe tap gesture on a plugin element.
- platform/network/blackberry/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(ResourceRequest):
(CrossThreadResourceRequestData):
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
Source/WebKit/blackberry:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
- 7:00 AM Changeset in webkit [116417] by
-
- 4 edits in trunk
[Qt] Unbreak debugging of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85839
Reviewed by Simon Hausmann.
Source/WebKit2:
When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (<7.0) but not with newer
versions where the behavior of pause() is correct.
- qt/MainQt.cpp:
(sigcontHandler):
(main):
Tools:
When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (<7.0) but not with newer
versions where the behavior of pause() is correct.
- WebKitTestRunner/qt/main.cpp:
(sigcontHandler):
(main):
- 6:57 AM Changeset in webkit [116416] by
-
- 6 edits in trunk
[EFL][DRT] EFL's DRT does not fully support page visibility
https://bugs.webkit.org/show_bug.cgi?id=85032
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-08
Reviewed by Antonio Gomes.
Tools:
- DumpRenderTree/LayoutTestController.cpp:
(resetPageVisibilityCallback): Fix incorrect argumentCount check.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
reset page visibility setting between tests.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setPageVisibility): Add support for "preview"
visibility state.
LayoutTests:
Unskip remaining page visibility test cases now that the functionality
is fully implemented in EFL port.
- platform/efl/Skipped:
- 6:39 AM Changeset in webkit [116415] by
-
- 2 edits in trunk/Tools
[webkit-patch] Return meaningful results from single-result queries.
https://bugs.webkit.org/show_bug.cgi?id=85367
Reviewed by Dirk Pranke.
Sometimes a quicksearch returns a single result by just redirecting to the page for that single
bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
a result list consisting of that one bug.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries._fetch_bugs_from_advanced_query):
- 6:37 AM Changeset in webkit [116414] by
-
- 5 edits4 adds in trunk/Tools
[webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
https://bugs.webkit.org/show_bug.cgi?id=85368
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/urls.py:
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_matching_quicksearch):
- Scripts/webkitpy/common/net/omahaproxy.py: Added.
(OmahaProxy):
(OmahaProxy.init):
(OmahaProxy.set_url):
(OmahaProxy._json_url):
(OmahaProxy._get_json):
(OmahaProxy.get_revisions):
- Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.
(MockOmahaProxy):
(MockOmahaProxy.init):
(OmahaProxyTest):
(OmahaProxyTest.test_get_revisions):
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/bugsearch.py:
(BugSearch):
- Scripts/webkitpy/tool/commands/chromechannels.py: Added.
(ChromeChannels):
(init):
(execute):
- Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.
(MockOmahaProxy):
(MockOmahaProxy.get_revisions):
(TestableChromeChannels):
(TestableChromeChannels.init):
(ChromeChannelsTest):
(ChromeChannelsTest.test_single_bug):
(ChromeChannelsTest.test_with_query):
- 6:32 AM Changeset in webkit [116413] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
https://bugs.webkit.org/show_bug.cgi?id=84588
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-08
Reviewed by Eric Seidel.
In ewk_frame_contents_alternate_set, param unreachableUri is required, must not be 0.
In ewk_view_zoom_range_set, function returns EINA_FALSE only on failure,
not when zoom range is changed.
- ewk/ewk_frame.h:
- ewk/ewk_view.h:
- 6:29 AM Changeset in webkit [116412] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix GTK+ unit tests.
- gtk/common.py:
(pkg_config_file_variable):
- 3:04 AM Changeset in webkit [116411] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed. Remove an accidentally committed file.
- platform/qt/Skipped.orig: Removed.
- 2:55 AM Changeset in webkit [116410] by
-
- 3 edits1 copy in trunk/Tools
[GTK] Google tests that time out are leaked
https://bugs.webkit.org/show_bug.cgi?id=84973
Reviewed by Philippe Normand.
Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
leaving run-gtk-tests as simple wrapper that runs run-api-tests in
a jhbuild environment when jhbuild is available.
- Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or
with jhbuild if present.
- gtk/common.py:
(pkg_config_file_variable): Generic function to get a variable
from a pkg-config file.
(prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.
- gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.
(TestRunner.init): Use common.build_path() to get the programs path.
(TestRunner._lookup_atspi2_binary): Use
common.pkg_config_file_variable() to get the 'exec_prefix'.
(TestRunner._start_accessibility_daemons): Use subprocess.Popen()
directly instead of helper _create_process that has been removed.
(TestRunner._setup_testing_environment): Use subprocess.Popen()
directly instead of helper _create_process that has been
removed. Use common.top_level_path() and common.build_path()
instead of custom methods that have been removed too.
(TestRunner._run_test_command): Use subprocess.Popen() directly
instead of helper _create_process that has been removed.
- 2:50 AM Changeset in webkit [116409] by
-
- 49 edits4 copies115 adds in trunk/LayoutTests
[Qt] Unskip now passing tests and update platform specific expected files.
Patch by János Badics <János Badics> on 2012-05-08
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- platform/qt/Skipped.orig: Copied from LayoutTests/platform/qt/Skipped.
- platform/qt/editing/pasteboard/paste-text-014-expected.png: Added.
- platform/qt/fast/block/float/editable-text-overlapping-float-expected.png: Added.
- platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
- platform/qt/fast/block/float/multiple-float-positioning-expected.png: Added.
- platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
- platform/qt/fast/block/margin-collapse/103-expected.png: Added.
- platform/qt/fast/block/margin-collapse/103-expected.txt: Added.
- platform/qt/fast/block/positioning/absolute-in-inline-ltr-2-expected.png: Added.
- platform/qt/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
- platform/qt/fast/block/positioning/absolute-in-inline-rtl-2-expected.png: Added.
- platform/qt/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
- platform/qt/fast/block/positioning/absolute-in-inline-rtl-3-expected.png: Added.
- platform/qt/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
- platform/qt/fast/block/positioning/auto/006-expected.png: Added.
- platform/qt/fast/block/positioning/auto/006-expected.txt:
- platform/qt/fast/css/apple-prefix-expected.png: Added.
- platform/qt/fast/css/apple-prefix-expected.txt:
- platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
- platform/qt/fast/css/color-correction-backgrounds-and-text-expected.txt: Added.
- platform/qt/fast/css/ex-after-font-variant-expected.png: Added.
- platform/qt/fast/css/ex-after-font-variant-expected.txt:
- platform/qt/fast/css/percentage-non-integer-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
- platform/qt/fast/css/percentage-non-integer-expected.txt:
- platform/qt/fast/css/positioned-overflow-scroll-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
- platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Added.
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
- platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/qt/fast/dynamic/008-expected.png: Added.
- platform/qt/fast/dynamic/008-expected.txt:
- platform/qt/fast/forms/box-shadow-override-expected.png: Added.
- platform/qt/fast/forms/box-shadow-override-expected.txt:
- platform/qt/fast/forms/disabled-select-change-index-expected.png: Added.
- platform/qt/fast/forms/disabled-select-change-index-expected.txt:
- platform/qt/fast/forms/file/file-input-direction-expected.png: Added.
- platform/qt/fast/forms/file/file-input-direction-expected.txt:
- platform/qt/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/qt/fast/forms/file/file-input-disabled-expected.txt:
- platform/qt/fast/forms/form-element-geometry-expected.png: Added.
- platform/qt/fast/forms/form-element-geometry-expected.txt:
- platform/qt/fast/forms/input-disabled-color-expected.png: Added.
- platform/qt/fast/forms/input-disabled-color-expected.txt:
- platform/qt/fast/forms/input-text-click-outside-expected.png: Added.
- platform/qt/fast/forms/input-text-click-outside-expected.txt: Added.
- platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
- platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
- platform/qt/fast/forms/negativeLineHeight-expected.png: Added.
- platform/qt/fast/forms/negativeLineHeight-expected.txt:
- platform/qt/fast/forms/placeholder-pseudo-style-expected.png: Added.
- platform/qt/fast/forms/placeholder-pseudo-style-expected.txt: Added.
- platform/qt/fast/forms/range/slider-padding-expected.png: Added.
- platform/qt/fast/forms/range/slider-padding-expected.txt: Added.
- platform/qt/fast/forms/tabbing-input-iframe-expected.png: Added.
- platform/qt/fast/forms/tabbing-input-iframe-expected.txt: Added.
- platform/qt/fast/forms/textAreaLineHeight-expected.png: Added.
- platform/qt/fast/forms/textAreaLineHeight-expected.txt: Added.
- platform/qt/fast/forms/textarea-align-expected.png: Added.
- platform/qt/fast/forms/textarea-align-expected.txt:
- platform/qt/fast/forms/textarea-scrollbar-expected.png: Added.
- platform/qt/fast/forms/textarea-scrollbar-expected.txt: Added.
- platform/qt/fast/forms/textarea-scrolled-type-expected.png: Added.
- platform/qt/fast/forms/textarea-scrolled-type-expected.txt: Added.
- platform/qt/fast/forms/textarea-setinnerhtml-expected.png: Added.
- platform/qt/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/qt/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
- platform/qt/fast/inline/inline-borders-with-bidi-override-expected.txt:
- platform/qt/fast/invalid/016-expected.png: Added.
- platform/qt/fast/invalid/016-expected.txt:
- platform/qt/fast/invalid/missing-end-tag-expected.png: Added.
- platform/qt/fast/invalid/missing-end-tag-expected.txt: Added.
- platform/qt/fast/layers/scroll-rect-to-visible-expected.png: Added.
- platform/qt/fast/layers/scroll-rect-to-visible-expected.txt:
- platform/qt/fast/overflow/003-expected.png: Added.
- platform/qt/fast/overflow/003-expected.txt:
- platform/qt/fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
- platform/qt/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
- platform/qt/fast/overflow/image-selection-highlight-expected.png: Added.
- platform/qt/fast/overflow/image-selection-highlight-expected.txt:
- platform/qt/fast/overflow/overflow-rtl-expected.png: Added.
- platform/qt/fast/overflow/overflow-rtl-expected.txt: Added.
- platform/qt/fast/overflow/overflow-x-y-expected.png: Added.
- platform/qt/fast/overflow/overflow-x-y-expected.txt: Added.
- platform/qt/fast/overflow/scrollRevealButton-expected.png: Added.
- platform/qt/fast/overflow/scrollRevealButton-expected.txt: Added.
- platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- platform/qt/fast/parser/entity-comment-in-textarea-expected.png: Added.
- platform/qt/fast/parser/entity-comment-in-textarea-expected.txt: Added.
- platform/qt/fast/parser/open-comment-in-textarea-expected.png: Added.
- platform/qt/fast/parser/open-comment-in-textarea-expected.txt: Added.
- platform/qt/fast/repaint/button-spurious-layout-hint-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
- platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt: Added.
- platform/qt/fast/repaint/control-clip-expected.png: Added.
- platform/qt/fast/repaint/control-clip-expected.txt:
- platform/qt/fast/repaint/flexible-box-overflow-expected.png: Added.
- platform/qt/fast/repaint/flexible-box-overflow-expected.txt: Added.
- platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
- platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.txt: Added.
- platform/qt/fast/repaint/focus-ring-expected.png: Added.
- platform/qt/fast/repaint/focus-ring-expected.txt: Added.
- platform/qt/fast/repaint/inline-block-overflow-expected.png: Added.
- platform/qt/fast/repaint/inline-block-overflow-expected.txt: Added.
- platform/qt/fast/repaint/inline-outline-repaint-expected.png: Added.
- platform/qt/fast/repaint/inline-outline-repaint-expected.txt:
- platform/qt/fast/repaint/layer-child-outline-expected.png: Added.
- platform/qt/fast/repaint/layer-child-outline-expected.txt: Added.
- platform/qt/fast/repaint/layer-outline-expected.png: Added.
- platform/qt/fast/repaint/layer-outline-expected.txt: Added.
- platform/qt/fast/repaint/layer-outline-horizontal-expected.png: Added.
- platform/qt/fast/repaint/layer-outline-horizontal-expected.txt: Added.
- platform/qt/fast/repaint/list-marker-expected.png: Added.
- platform/qt/fast/repaint/list-marker-expected.txt: Added.
- platform/qt/fast/repaint/selection-after-delete-expected.png: Added.
- platform/qt/fast/repaint/selection-after-delete-expected.txt:
- platform/qt/fast/repaint/selection-after-remove-expected.png: Added.
- platform/qt/fast/repaint/selection-after-remove-expected.txt:
- platform/qt/fast/repaint/selection-clear-expected.png:
- platform/qt/fast/repaint/selection-clear-expected.txt:
- platform/qt/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
- platform/qt/fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
- platform/qt/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
- platform/qt/fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
- platform/qt/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
- platform/qt/fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
- platform/qt/fast/repaint/text-shadow-expected.png: Added.
- platform/qt/fast/repaint/text-shadow-expected.txt: Added.
- platform/qt/fast/repaint/text-shadow-horizontal-expected.png: Added.
- platform/qt/fast/repaint/text-shadow-horizontal-expected.txt: Added.
- platform/qt/fast/replaced/border-radius-clip-expected.png: Added.
- platform/qt/fast/replaced/border-radius-clip-expected.txt: Added.
- platform/qt/fast/replaced/width100percent-textarea-expected.png: Added.
- platform/qt/fast/replaced/width100percent-textarea-expected.txt: Added.
- platform/qt/fast/table/003-expected.png: Added.
- platform/qt/fast/table/003-expected.txt:
- platform/qt/fast/table/cell-pref-width-invalidation-expected.png: Added.
- platform/qt/fast/table/cell-pref-width-invalidation-expected.txt:
- platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
- platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
- platform/qt/fast/text/basic/003-expected.png: Added.
- platform/qt/fast/text/basic/003-expected.txt:
- platform/qt/fast/text/cg-vs-atsui-expected.png: Added.
- platform/qt/fast/text/cg-vs-atsui-expected.txt:
- platform/qt/fast/text/complex-text-opacity-expected.png: Added.
- platform/qt/fast/text/complex-text-opacity-expected.txt: Added.
- platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
- platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.
- platform/qt/fast/text/large-text-composed-char-expected.png: Added.
- platform/qt/fast/text/large-text-composed-char-expected.txt:
- platform/qt/fast/text/letter-spacing-negative-opacity-expected.png: Added.
- platform/qt/fast/text/letter-spacing-negative-opacity-expected.txt:
- platform/qt/fast/text/line-breaks-after-white-space-expected.png: Added.
- platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
- platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
- platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/qt/fast/text/whitespace/pre-break-word-expected.png: Added.
- platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
- platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png: Added.
- platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
- platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
- platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
- platform/qt/fast/text/word-break-expected.png: Added.
- platform/qt/fast/text/word-break-expected.txt:
- platform/qt/fast/xsl/xslt-entity-expected.png: Added.
- platform/qt/fast/xsl/xslt-entity-expected.txt:
- 2:43 AM Changeset in webkit [116408] by
-
- 4 edits2 adds in trunk
Extra line-breaks added when copying from source.
https://bugs.webkit.org/show_bug.cgi?id=85282
Reviewed by Ryosuke Niwa.
Source/WebCore:
The code used to replace any \n by \r\n, even the one that had a preceding \r, resulting in \r\r\n.
This change introduces a check for the preceding \r when replacing \n's.
Test: platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html
- platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines):
LayoutTests:
- platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win-expected.txt: Added.
- platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html: Added.
- 2:28 AM Changeset in webkit [116407] by
-
- 4 edits in trunk/Tools
[EFL] [DRT] Clear extra views before setting a blank page
https://bugs.webkit.org/show_bug.cgi?id=85608
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.
We need to clear the extra views before setting a blank page,
otherwise it will cause more events interactions and sometimes
trigger a unload(). This was causing frame-crash-with-page-cache.html
to leak events to the next test causing any subsequent test to
fail.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(runTest):
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::clearExtraViews):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- 2:04 AM Changeset in webkit [116406] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening after 116361. Updated expected result.
Patch by János Badics <János Badics> on 2012-05-08
Reviewed by Csaba Osztrogonác.
- platform/qt/fast/js/switch-behaviour-expected.txt:
- 2:00 AM Changeset in webkit [116405] by
-
- 2 edits in trunk/Source/WebCore
OS(ANDROID) JNI AttachCurrentThread take JNIEnv as a parameter, not void
https://bugs.webkit.org/show_bug.cgi?id=85869
Reviewed by Eric Seidel.
According to
http://docs.oracle.com/javase/1.5.0/docs/guide/jni/spec/invocation.html,
AttachCurrentThread takes a JNIEnv rather than a void. Apparently,
most implementations actually take a void. The OS(ANDROID)
implementation, however, actually takes an JNIEnv. This patch
introduces a typedef to give each implementation what it desires.
- bridge/jni/JNIUtility.cpp:
(JSC::Bindings::getJNIEnv):
- 1:59 AM Changeset in webkit [116404] by
-
- 5 edits in trunk/LayoutTests
Unreviewed gardening. Remove tests from test expectations and
from a Skipped list, because they were disabled by r94327.
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 1:42 AM Changeset in webkit [116403] by
-
- 15 edits in trunk
[Qt] X11 plugins need to be reworked for Qt5+WK1
https://bugs.webkit.org/show_bug.cgi?id=80691
Reviewed by Simon Hausmann.
.:
Implement basic windowless plugin support with Qt5.
- Source/api.pri: Need private API's to be able
to use QApplicationPrivate::windowForWidget.
Source/WebCore:
Implement basic windowless plugin support with Qt5.
The solution is the same that has been chosen for
WebKit2. We get the content drawed by the plugin
from the X server as an image, create a QImage
from it and paint it to the window surface with QPainter.
Performance is sufficient for basic video playback.
No new tests, covered by existing plugin tests.
- Target.pri:
- WebCore.pri:
- platform/qt/QWebPageClient.h:
(QWebPageClient):
- plugins/PluginView.h:
(PluginView):
- plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::isPluginBlacklisted):
Blacklist plugins that are incompatible with Qt5.
The only one I know about currently is skypebuttons
but the list can be extended in the future.
(WebCore):
(WebCore::PluginPackage::load):
- plugins/qt/PluginViewQt.cpp:
(X11Environment):
(WebCore):
(WebCore::x11Display):
(WebCore::x11Screen):
(WebCore::rootWindowID):
(WebCore::displayDepth):
(WebCore::syncX):
(WebCore::PluginView::platformPageClient): Added a safe
convenience getter for the QWebpageClient.
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::setFocus):
(WebCore::setupGraphicsExposeEvent):
(WebCore::PluginView::paintUsingXPixmap):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::initXEvent):
(WebCore::PluginView::setXKeyEventSpecificFields):
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::getVisualAndColormap):
Refactored this function to make it more clear
what does it actually do.
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
Source/WebKit/qt:
- Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):
Build fix for Qt5.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
Inject the wmode parameter for flash so it will
work in windowless, non-transparent mode which
is the only one we support currently.
- WebCoreSupport/PageClientQt.cpp:
(WebCore):
(WebCore::QWebPageClient::ownerWindow):
Added a getter for the top level window so the PluginView
can get it without calling into QtWidgets code.
Tools:
Implement basic windowless plugin support with Qt5.
- qmake/mkspecs/features/features.prf:
Enable NPAPI plugins if X11 libraries are available.
- qmake/mkspecs/features/functions.prf:
Added a convenience function to determine availability
of X11 libraries.
- 1:31 AM Changeset in webkit [116402] by
-
- 6 edits in trunk/Source/WebCore
Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844
Reviewed by Ryosuke Niwa.
Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops. Also added separate versions of stayWithin and unscoped cases (the function is
so simple that this seemed like the cleanest way to do it, the most reliable too) and used UNLIKELY for the
end-of-traversal conditions.
The traversal function can show up to ~1% in normal page loading profiles.
run-perf-tests seems to think this is a progression in some subtests though bots will tell for certain.
- WebCore.exp.in:
- dom/ContainerNode.h:
Following the existing pattern, function bodies go to ContainerNode.h so they can call parentNode().
(which returns ContainerNode, not Node).
(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):
- dom/Node.cpp:
(WebCore):
- dom/Node.h:
(Node):
- 12:34 AM Changeset in webkit [116401] by
-
- 2 edits in trunk/Source/WTF
[Chromium] Assertions.cpp should work on OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=85867
Reviewed by Eric Seidel.
Some minor ifdefs for OS(ANDROID) on PLATFORM(CHROMIUM).
- wtf/Assertions.cpp:
- 12:05 AM Changeset in webkit [116400] by
-
- 3 edits2 adds in trunk/Source/WebKit
[BlackBerry] AutofillManager implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85576
Patch by Jonathan Dong <Jonathan Dong> on 2012-05-08
Reviewed by Rob Buis.
Source/WebKit:
Added WebKit/blackberry/WebCoreSupport/AutofillManager.cpp
into building system of BlackBerry porting.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
RIM PR: 136405
Implemented class AutofillManager to handle the form autofill
interactions.
It listens to text changed notification from text input, searches
autofill database for the suggested autofill candidate value,
and notifies WebPageClient to pop up a context dialog for user;
it also responds to user's choice by autofilling the text input.
- WebCoreSupport/AutofillManager.cpp: Added.
(WebCore):
(WebCore::AutofillManager::create):
(WebCore::AutofillManager::didChangeInTextField):
(WebCore::AutofillManager::autofillTextField):
(WebCore::AutofillManager::saveTextFields):
(WebCore::AutofillManager::clear):
- WebCoreSupport/AutofillManager.h: Added.
(WTF):
(WebKit):
(WebCore):
(AutofillManager):
(WebCore::AutofillManager::m_element):
