Timeline
May 14, 2012:
- 11:36 PM Changeset in webkit [117034] by
-
- 3 edits in trunk/Source/WebCore
Make StyleResolver::applyMatchedProperties and ::applyProperties use enum template parameter instead of bool.
https://bugs.webkit.org/show_bug.cgi?id=86424
Reviewed by Dimitri Glazkov.
This patch changes from using a boolean template parameter for StyleResolver::applyMatchedProperties and
StyleResolver::applyProperties functions. The motivation for this change is that it paves the way for
CSS Variables to make the value tri-state, which is a requirement because variable definitions must occur
before high priority CSS properties such that they can be referenced by the latter. This change affects
only the type signatures of those functions, and not their behavior.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
- 11:30 PM Changeset in webkit [117033] by
-
- 9 edits in trunk/Source/WebCore
[Refactoring] Get rid of ContentDistribution::Item
https://bugs.webkit.org/show_bug.cgi?id=86350
This change replaces the linked list on ContentDistribution with a Vector.
We no longer link item class ContentDistribution::Item.
This simplification also allows ContentDistribution to go.
ContentDistribution is now just a typedef of Vector<RefPtr<Node> >.
Reviewed by Dimitri Glazkov.
No new tests. Covered by existing tests.
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
- dom/ElementShadow.cpp:
- dom/ElementShadow.h:
(ElementShadow):
- dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findInsertionPointFor):
- html/shadow/ContentDistributor.h:
(WebCore):
(ContentDistributor):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::nextTo):
(WebCore):
(WebCore::InsertionPoint::previousTo):
- html/shadow/InsertionPoint.h: Added a set of delegate method to m_distribution.
(WebCore::InsertionPoint::hasDistribution):
(WebCore::InsertionPoint::indexOf):
(WebCore::InsertionPoint::size):
(WebCore::InsertionPoint::at):
(WebCore::InsertionPoint::first):
(WebCore::InsertionPoint::last):
(InsertionPoint):
- 11:12 PM Changeset in webkit [117032] by
-
- 4 edits in trunk/Source/WebCore
RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of composited descendants
https://bugs.webkit.org/show_bug.cgi?id=86429
<rdar://problem/11445132>
Reviewed by Simon Fraser.
Change repaintRectIncludingDescendants to not include repaint rects for composited child layers,
and rename the function to make it more clear that that's what it does now.
No new tests, scrolling performance optimization.
- page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
- rendering/RenderLayer.h:
(RenderLayer):
- 10:55 PM Changeset in webkit [117031] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening to paint the Qt bots green.
- 10:21 PM FeatureFlags edited by
- Add CSS_VARIABLES (diff)
- 10:08 PM Changeset in webkit [117030] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update test expectations.
- platform/chromium/test_expectations.txt:
- 9:42 PM Changeset in webkit [117029] by
-
- 36 edits10 copies2 adds2 deletes in trunk
Add Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
https://bugs.webkit.org/show_bug.cgi?id=85005
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebPrerender.h:
(WebKit::WebPrerender::referrer):
(WebCore):
(WebPrerender):
- chromium/public/WebPrerenderingSupport.h:
(WebKit):
(WebPrerenderingSupport):
- chromium/public/WebURLRequest.h:
- chromium/src/WebPrerenderingSupport.cpp: Added.
(WebKit):
(WebKit::WebPrerenderingSupport::initialize):
(WebKit::WebPrerenderingSupport::shutdown):
(WebKit::WebPrerenderingSupport::current):
Source/WebCore:
The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.
The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.
No new tests, as this interface requires a full platform to work, and doesn't affect layout. Test
it with your platform when implemented for it.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::prerenderer):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::removedFrom):
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
- html/LinkRelAttribute.h:
(LinkRelAttribute):
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
(WebCore::LinkLoader::released):
- loader/LinkLoader.h:
(WebCore):
(LinkLoader):
- loader/Prerenderer.cpp: Added.
(WebCore):
(WebCore::Prerenderer::create):
(WebCore::Prerenderer::Prerenderer):
(WebCore::Prerenderer::~Prerenderer):
(WebCore::Prerenderer::render):
(WebCore::Prerenderer::stop):
(WebCore::Prerenderer::suspend):
(WebCore::Prerenderer::resume):
(WebCore::Prerenderer::document):
(WebCore::Prerenderer::client):
- loader/Prerenderer.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(Prerenderer):
- loader/PrerendererClient.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(WebCore::PrerendererClient::supplementName):
(WebCore::PrerendererClient::from):
(WebCore::providePrerendererClientTo):
- loader/PrerendererClient.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(PrerendererClient):
(WebCore::PrerendererClient::~PrerendererClient):
(WebCore::PrerendererClient::PrerendererClient):
- loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
- platform/PrerenderHandle.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(PrerenderHandle):
- platform/chromium/Prerender.cpp: Added.
(WebCore):
(WebCore::Prerender::Prerender):
(WebCore::Prerender::~Prerender):
(WebCore::Prerender::setState):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::suspend):
(WebCore::Prerender::resume):
- platform/chromium/Prerender.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(Prerender):
(ExtraData):
(WebCore::Prerender::ExtraData::~ExtraData):
(WebCore::Prerender::url):
(WebCore::Prerender::referrer):
(WebCore::Prerender::referrerPolicy):
(WebCore::Prerender::setExtraData):
(WebCore::Prerender::extraData):
- platform/chromium/PrerenderHandle.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::prerender):
(WebCore::PrerenderHandle::add):
(WebCore::PrerenderHandle::cancel):
(WebCore::PrerenderHandle::abandon):
(WebCore::PrerenderHandle::suspend):
(WebCore::PrerenderHandle::resume):
(WebCore::PrerenderHandle::url):
(WebCore::PrerenderHandle::referrer):
(WebCore::PrerenderHandle::referrerPolicy):
- platform/chromium/support/WebPrerender.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebKit::WebPrerender::WebPrerender):
(WebKit):
(WebKit::WebPrerender::~WebPrerender):
(WebKit::WebPrerender::url):
(WebKit::WebPrerender::referrer):
(WebKit::WebPrerender::referrerPolicy):
(WebKit::WebPrerender::setExtraData):
(WebKit::WebPrerender::extraData):
- platform/network/blackberry/ResourceRequest.h:
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::platformTargetTypeForRequest):
- platform/network/chromium/ResourceRequest.h:
Source/WebKit/chromium:
The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.
The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.
- WebKit.gyp:
- public/WebView.h:
- src/PrerendererClientImpl.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebKit):
(WebKit::PrerendererClientImpl::PrerendererClientImpl):
(WebKit::PrerendererClientImpl::willAddPrerender):
- src/PrerendererClientImpl.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(WebKit):
(PrerendererClientImpl):
- src/WebKit.cpp:
(WebKit::shutdown):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPrerendererClient):
(WebKit):
- src/WebViewImpl.h:
(WebKit):
(WebViewImpl):
LayoutTests:
The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.
The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.
These tests are being removed, and expectations updated, because the old phantom-load
prerendering interface was susceptible to layout testing, and the new interface requires
a full platform to test, so it can't really be a layout test.
- fast/dom/HTMLLinkElement/prerender-expected.txt: Removed.
- fast/dom/HTMLLinkElement/prerender.html: Removed.
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 9:39 PM Changeset in webkit [117028] by
-
- 16 edits in trunk
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338
Reviewed by Dimitri Glazkov.
Add a configuration option for CSS Variables support, disabling it by default.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests. This patch only introduces an unused build flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._missing_symbol_to_skipped_tests):
- qmake/mkspecs/features/features.pri:
- 9:36 PM Changeset in webkit [117027] by
-
- 2 edits in trunk/Source/WTF
Add WTF_USE_APPKIT to differentiate platforms that use AppKit.framework from other Darwin platforms
https://bugs.webkit.org/show_bug.cgi?id=86432
Reviewed by Maciej Stachowiak.
- wtf/Platform.h:
- 9:36 PM Changeset in webkit [117026] by
-
- 5 edits in trunk
Styles are not recalculated when the seamless attribute is dynamically added/removed
https://bugs.webkit.org/show_bug.cgi?id=86315
Reviewed by Andreas Kling.
Source/WebCore:
Covered by fast/frames/seamless/seamless-css-cascade.html.
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute):
- Make seamless a presentational attribute, which means style on the <iframe> will be forced to recalculate when it changes. This is correct, but not observable until the layout changes are landed (as then the iframe should correctly revert to not being sized to fit its content if seamless is removed).
(WebCore::HTMLIFrameElement::parseAttribute):
- When the seamless attribute is added or remove, force the content document to recalc its style resolver, which will refresh the list of inherited stylesheets from the parent. This doesn't need to happen synchronously. When the layout changes land the content document will actually cause that recalc to redirect to the parent document in the seamless case anyway, but it's more correct to ask the content document directly.
LayoutTests:
Add a subtest to cover this case.
- fast/frames/seamless/seamless-css-cascade-expected.txt:
- fast/frames/seamless/seamless-css-cascade.html:
- 8:43 PM Changeset in webkit [117025] by
-
- 2 edits in trunk/Source/JavaScriptCore
Cannot login to iCloud
https://bugs.webkit.org/show_bug.cgi?id=86321
Reviewed by Filip Pizlo.
This is a bug introduced by bug#85853, we shouldn't allow assignment to
the prototype property of functions to be cached, since we need to clear
the cached inheritorID.
- runtime/JSFunction.cpp:
(JSC::JSFunction::put):
- 8:42 PM Changeset in webkit [117024] by
-
- 4 edits1 move3 deletes in trunk/LayoutTests
[Chromium] Update text expectations.
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
- platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Removed.
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- 8:26 PM Changeset in webkit [117023] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] remove skia/third_party/glu from DEPS
https://bugs.webkit.org/show_bug.cgi?id=86431
Chromium rev 136872 removed skia/third_party/glu, but nobody updated it in WebKit. This
patch fixes that.
Unreviewed, remove bad Chromium repo.
- DEPS:
- 6:10 PM Changeset in webkit [117022] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
https://bugs.webkit.org/show_bug.cgi?id=86415
Patch by Alexandre Elias <aelias@google.com> on 2012-05-14
Reviewed by Adam Barth.
The new enum values added in this file have been added in recent
versions of the NDK, so this file will fail to compile with duplicate
enum error when we roll NDK to r7c or higher. A workaround is
to move our enum values to the WebCore namespace. When the NDK
upgrade is complete, we can delete them.
No new tests. (No-op change.)
- platform/chromium/KeyCodeConversionAndroid.cpp:
(WebCore):
- 6:06 PM Changeset in webkit [117021] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86420
ScrollbarPainter should support expansionTransitionProgress
Reviewed by Sam Weinig.
expansionTransitionProgress works the same as
uiStateTransitionProgress. This code just echoes that code, but for
expansion instead of uiState.
- platform/mac/NSScrollerImpDetails.h:
- platform/mac/ScrollAnimatorMac.mm:
(supportsExpansionTransitionProgress):
(-[WebScrollbarPartAnimation setCurrentProgress:]):
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate invalidate]):
- 5:22 PM Changeset in webkit [117020] by
-
- 4 edits in trunk
Source/WebKit/chromium: Unreviewed, roll Chromium DEPS to r136942.
LayoutTests: fast/loader/javascript-url-in-embed.html is failing after r115646
https://bugs.webkit.org/show_bug.cgi?id=86414
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 5:11 PM Changeset in webkit [117019] by
-
- 2 edits in trunk/Source/WebCore
Fix RunLoopCF.cpp's copyright string.
- platform/cf/RunLoopCF.cpp:
- 5:05 PM Changeset in webkit [117018] by
-
- 3 edits1 copy in trunk/Source/WebCore
Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=86411
Reviewed by Anders Carlsson.
Most of RunLoopMac.mm was written in terms of CF API. Move these bits
to a new file called RunLoopCF.cpp, leaving only the bits dealing with
NSApplication.
- WebCore.xcodeproj/project.pbxproj: Xcode decided to give
VisitedLinks.* new UUIDs. I'll allow it.
- platform/cf/RunLoopCF.cpp: Copied from Source/WebCore/platform/mac/RunLoopMac.mm.
- platform/mac/RunLoopMac.mm:
- 4:55 PM Changeset in webkit [117017] by
-
- 16 edits2 adds in branches/dfgopt/Source/JavaScriptCore
DFG should optimize inlined uses of arguments.length and arguments[i]
https://bugs.webkit.org/show_bug.cgi?id=86327
Reviewed by Gavin Barraclough.
Turns inlined uses of arguments.length into a constant.
Turns inlined uses of arguments[constant] into a direct reference to the
argument.
Big win on micro-benchmarks. Not yet a win on V8 because the hot uses of
arguments.length and arguments[i] are aliased. I'll leave the aliasing
optimizations to a later patch.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/DFGExitProfile.h:
(FrequentExitSite):
(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::QueryableExitProfile::hasExitSite):
(QueryableExitProfile):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGArgumentsSimplificationPhase.cpp: Added.
(DFG):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::performArgumentsSimplification):
- dfg/DFGArgumentsSimplificationPhase.h: Added.
(DFG):
- dfg/DFGAssemblyHelpers.cpp:
(JSC::DFG::AssemblyHelpers::executableFor):
(DFG):
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::executableFor):
(Graph):
(JSC::DFG::Graph::clobbersWorld):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(Node):
(JSC::DFG::Node::unlinkedLocal):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:54 PM Changeset in webkit [117016] by
-
- 3 edits3 adds in trunk
[V8] Add "stack" property to DOMException
https://bugs.webkit.org/show_bug.cgi?id=85057
Reviewed by Kentaro Hara.
When we create a DOM exception we define a V8 accessor for the stack property. This
accessor uses a new Error object to get the underlying stack string.
Source/WebCore:
Test: fast/dom/DOMException/stack-trace.html
- bindings/v8/V8Proxy.cpp:
(WebCore::DOMExceptionStackGetter):
(WebCore):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8Proxy::setDOMException):
LayoutTests:
- fast/dom/DOMException/stack-trace-expected.txt: Added.
- fast/dom/DOMException/stack-trace.html: Added.
- platform/chromium/fast/dom/DOMException/stack-trace-expected.txt: Added.
- 4:47 PM Changeset in webkit [117015] by
-
- 21 edits in trunk/Source
Enh: Add the Ability to Disable / Enable JavaScript GC Timer
https://bugs.webkit.org/show_bug.cgi?id=86382
Reviewed by Darin Adler.
Source/JavaScriptCore:
Add flag to GCActivityCallback to enable / disable activity timer.
Add api via Heap to set the flag's value.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Windows export
- heap/Heap.cpp:
(JSC::Heap::setGarbageCollectionTimerEnabled):
- heap/Heap.h:
- runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::isEnabled):
(JSC::GCActivityCallback::setEnabled):
(JSC::GCActivityCallback::GCActivityCallback):
- runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
Source/WebCore:
Plumbing to set / clear JS GC activity timer enable flag.
- WebCore.exp.in:
- bindings/js/GCController.cpp:
(WebCore::GCController::setJavaScriptGarbageCollectorTimerEnabled):
- bindings/js/GCController.h:
Source/WebKit/mac:
Plumbing to set / clear JS GC activity timer enable flag.
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):
Source/WebKit2:
Plumbing to set / clear JS GC activity timer enable flag.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetJavaScriptGarbageCollectorTimerEnabled):
- UIProcess/API/C/WKContext.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setJavaScriptGarbageCollectorTimerEnabled):
- UIProcess/WebContext.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setJavaScriptGarbageCollectorTimerEnabled):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 4:47 PM Changeset in webkit [117014] by
-
- 2 edits in trunk/LayoutTests
fast/replaced/width100percent-searchfield is still failing on chromium leopard/snowleopard
https://bugs.webkit.org/show_bug.cgi?id=86412
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 4:45 PM Changeset in webkit [117013] by
-
- 2 edits in trunk/Source/JavaScriptCore
Increase Debug Logging in MarkStack::validate()
https://bugs.webkit.org/show_bug.cgi?id=86408
Rubber-stamped by Filip Pizlo.
Added some descriptive debug messages for the conditions and
values when a cell validation fails.
- heap/MarkStack.cpp:
(JSC::MarkStack::validate):
- 4:37 PM Changeset in webkit [117012] by
-
- 6 edits10 adds in trunk
Source/WebCore: [V8] Crash in npObjectGetProperty() in V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=86131
Reviewed by Adam Barth.
Tests: plugins/npruntime/delete-plugin-within-getProperty.html
plugins/npruntime/delete-plugin-within-hasProperty-return-false.html
plugins/npruntime/delete-plugin-within-hasProperty-return-true.html
plugins/npruntime/delete-plugin-within-invoke.html
plugins/npruntime/delete-plugin-within-setProperty.html
- bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
- bindings/v8/V8NPObject.cpp: Check NPN_IsAlive in a bunch of places we're not currently.
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
Tools: Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.
Reviewed by Adam Barth.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(callDeletePlugin):
(pluginHasProperty):
(pluginHasMethod):
(pluginGetProperty):
(pluginSetProperty):
(pluginInvoke):
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=86131.
Reviewed by Adam Barth.
- plugins/npruntime/delete-plugin-within-getProperty-expected.txt: Added.
- plugins/npruntime/delete-plugin-within-getProperty.html: Added.
- plugins/npruntime/delete-plugin-within-hasProperty-return-false-expected.txt: Added.
- plugins/npruntime/delete-plugin-within-hasProperty-return-false.html: Added.
- plugins/npruntime/delete-plugin-within-hasProperty-return-true-expected.txt: Added.
- plugins/npruntime/delete-plugin-within-hasProperty-return-true.html: Added.
- plugins/npruntime/delete-plugin-within-invoke-expected.txt: Added.
- plugins/npruntime/delete-plugin-within-invoke.html: Added.
- plugins/npruntime/delete-plugin-within-setProperty-expected.txt: Added.
- plugins/npruntime/delete-plugin-within-setProperty.html: Added.
- 4:19 PM Changeset in webkit [117011] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build correction.
- platform/win/DragImageCairoWin.cpp: Add missing include for
new NativeImageCairo.h type.
- 4:19 PM Changeset in webkit [117010] by
-
- 2 edits in trunk/Tools
Re-enable "drt mode" on chromium-mac-leopard
https://bugs.webkit.org/show_bug.cgi?id=83076
Unreviewed, build fix (change?).
This change is another attempt to gather data on
the flakiness and timeouts we're seeing on Mac SL
now that we have another bot.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.init):
- 4:11 PM Changeset in webkit [117009] by
-
- 2 edits1 add in trunk/LayoutTests
Rebaseline http/tests/misc/will-send-request-returns-null-on-redirect on chromium.
https://bugs.webkit.org/show_bug.cgi?id=60121
Unreviewed, baselines change.
- platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:02 PM Changeset in webkit [117008] by
-
- 2 edits in trunk/Source/WTF
<http://webkit.org/b/86320> WTF.xcodeproj builds with -O3 in debug builds
Reviewed by Simon Fraser.
- WTF.xcodeproj/project.pbxproj: Ensure that the debug configuration uses the
same settings as the debug variant would.
- 3:36 PM Changeset in webkit [117007] by
-
- 6 edits4 adds in trunk
Crash in WebCore::RenderObject::repaint
https://bugs.webkit.org/show_bug.cgi?id=86162
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-14
Reviewed by Abhishek Arya.
Source/WebCore:
As RenderScrollbarPart has no parent renderer, we crash in
WebCore::RenderBoxModelObject::paddingLeft when paddingLeft has
percent value, e.g. 5%. However if we set the scrollbar's parent
renderer to a renderer owning the scrollbar by using setParent method,
RenderScrollbarPart::styleWillChange will invoke parent renderer's
repaint. This causes crash in WebCore::RenderObject::repaint if the
owning renderer is already destroyed.
To fix the first crash without the second crash, modify
RenderObject::containingBlock() to check isRenderScrollbarPart or not,
if parent() is 0.
If so, use scrollbar's owningRenderer from RenderScrollbarPart.
Test: scrollbars/scrollbar-percent-padding-crash.html
scrollbars/scrollbar-scrollbarparts-repaint-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
Modifying containingBlock. If parent() is 0 and isRenderScrollbarPart()
is true, use RenderScrollbarPart's m_scrollbar->owningRenderer()
instead of parent().
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderScrollbarPart):
(RenderObject):
Adding a new method, isRenderScrollbarPart.
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
(WebCore):
Adding a new method, scrollbarOwningRenderer to obtain m_scrollar's
owningRenderer.
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
Removing "friend class RenderScrollbar".
(WebCore::RenderScrollbarPart::isRenderScrollbarPart):
(WebCore::toRenderScrollbarPart):
(WebCore):
Implementing isRenderScrollbarPart and toRenderScrollbarPart.
LayoutTests:
- scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt: Added.
- scrollbars/scrollbar-scrollbarparts-repaint-crash.html: Added.
- scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
- scrollbars/scrollbar-percent-padding-crash.html: Added.
- 2:53 PM Changeset in webkit [117006] by
-
- 47 edits9 adds2 deletes in trunk
Content Security Policy console errors include violated directive.
https://bugs.webkit.org/show_bug.cgi?id=86323
Source/WebCore:
Patch by Mike West <mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.
Console errors generated when resources, inline script/style, or eval
are blocked by Content Security Policy directives should include the
text of the directive that's been violated. This gives developers more
of the information they need to resolve the issue.
Test: http/tests/security/contentSecurityPolicy/*
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
LayoutTests:
Sharded http/tests/security/contentSecurityPolicy/source-list-parsing.html
into four tests, and reworked it to have a well-defined order.
Patch by Mike West <mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.
- http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
- http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
- http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
- http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Removed
- http/tests/security/contentSecurityPolicy/source-list-parsing.html: Removed
- http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-01.html: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-02.html: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-03.html: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-04-expected.txt: Added
- http/tests/security/contentSecurityPolicy/source-list-parsing-04.html: Added
- http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:
- http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
- http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
- media/csp-blocks-video-expected.txt:
- platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
- 2:50 PM Changeset in webkit [117005] by
-
- 2 edits in trunk/Source/WebCore
Crash in FrameView::windowClipRectForFrameOwner after r116371
https://bugs.webkit.org/show_bug.cgi?id=86035
Reviewed by David Hyatt.
Added a NULL-check for |parentView| as nothing guarantees it to be
non-NULL. Unfortunately no test as this is a crasher I couldn't
reproduce on my machine and the user logs were not helpful.
- page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
- 2:47 PM Changeset in webkit [117004] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86403
ASSERTION FAILED: m_verticalScrollbarPainterDelegate on recent builds
-and corresponding-
<rdar://problem/11448841>
Reviewed by Simon Fraser.
http://trac.webkit.org/changeset/116476 accidentally started calling
these functions for custom scrollbars. This change replaces that
guard.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::destroyScrollbar):
- 2:28 PM Changeset in webkit [117003] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r116981.
http://trac.webkit.org/changeset/116981
https://bugs.webkit.org/show_bug.cgi?id=86402
Caused compositing and mathml tests to fail. (Requested by
rakuco on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):
- 2:25 PM Changeset in webkit [117002] by
-
- 3 edits in trunk/Tools
Fix regressions in garden-o-matic after r116988.
Unreviewed, build fix.
I had a typo in a field name in checkout.js, and unfortunately
the unittests had the same typo :(.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
- 2:19 PM Changeset in webkit [117001] by
-
- 8 edits in trunk/PerformanceTests
Convert CSS and Parser tests to runs/s tests
https://bugs.webkit.org/show_bug.cgi?id=86399
Reviewed by Ojan Vafai.
Use runPerSecond instead of run to measure results in function calls per second (run/s) instead of time (ms).
This allows us to continue measuring performance reliably even when WebKit's performance improves and results
become too small for Date.now()'s precision (around 15 ms).
It should also reduce perf. bots cycle time for slower tests because we limit the number of function calls by time.
- CSS/CSSPropertySetterGetter.html:
- CSS/CSSPropertyUpdateValue.html:
- Parser/css-parser-yui.html:
- Parser/simple-url.html:
- Parser/tiny-innerHTML.html:
- Parser/url-parser.html:
- Parser/xml-parser.html:
- 2:17 PM Changeset in webkit [117000] by
-
- 5 edits in branches/chromium/1132/Source
Merge 116554 - [chromium] Add impl-thread support for fill-mode and direction css animation properties
https://bugs.webkit.org/show_bug.cgi?id=77662
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.
Source/WebCore:
Adds support for accelerating css animations with -webkit-animation-fill-mode,
and -webkit-animation-direction properties.
Tested in:
CCActiveAnimationTest.TrimTimeAlternating
CCLayerAnimationControllerTest.createReversedAnimation
CCLayerAnimationControllerTest.createAlternatingAnimation
CCLayerAnimationControllerTest.createReversedAlternatingAnimation
- platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):
- platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::alternatesDirection):
(WebCore::CCActiveAnimation::setAlternatesDirection):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
Source/WebKit/chromium:
- tests/CCActiveAnimationTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10384167
- 2:12 PM Changeset in webkit [116999] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant pixel snapping in calculateCompositedBounds()
https://bugs.webkit.org/show_bug.cgi?id=86400
Reviewed by Sam Weinig.
RenderLayer::calculateLayerBounds() returns a pixel-snapped rect,
so we don't need to pixel-snap it again.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
- 2:12 PM Changeset in webkit [116998] by
-
- 6 edits4 copies in branches/chromium/1132
Merge 116786 - [chromium] Ensure that animations continue to run when transform-style is changed
https://bugs.webkit.org/show_bug.cgi?id=83283
Source/WebCore:
Make sure that we transfer animations when changing layers due to a transform-style change.
Unit tested in GraphicsLayerChromiumTest.updateLayerPreserves3DWithAnimations
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.
Test: animations/change-transform-style-during-animation.html
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::releaseLayerAnimationController):
(WebCore):
(WebCore::LayerChromium::notifyAnimationStarted):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::notifyAnimationStarted):
(WebCore::CCLayerAnimationController::setClient):
(WebCore):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::setForceSync):
Source/WebKit/chromium:
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.
- WebKit.gypi:
- tests/GraphicsLayerChromiumTest.cpp: Added.
(WebKitTests):
(MockGraphicsLayerClient):
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):
LayoutTests:
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-11
Reviewed by James Robinson.
- animations/change-transform-style-during-animation-expected.png: Added.
- animations/change-transform-style-during-animation-expected.txt: Added.
- animations/change-transform-style-during-animation.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10310152
- 2:10 PM Changeset in webkit [116997] by
-
- 8 edits1 add2 deletes in trunk/LayoutTests
[chromium] Layout Test svg/carto.net/window.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=84810
Unreviewed Chromium test expectations update.
- platform/chromium-linux/svg/carto.net/window-expected.png:
- platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
- platform/chromium-mac/svg/carto.net/window-expected.png:
- platform/chromium-win/svg/carto.net/window-expected.png:
- platform/chromium-win/svg/carto.net/window-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/efl/svg/carto.net/window-expected.txt: Removed.
- platform/gtk/svg/carto.net/window-expected.txt: Removed.
- svg/carto.net/window-expected.txt: Added.
- 2:04 PM Changeset in webkit [116996] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
https://bugs.webkit.org/show_bug.cgi?id=86270
Reviewed by Eric Seidel.
- public/android/WebInputEventFactory.h:
- src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
(WebKit::WebInputEventFactory::mouseEvent):
(WebKit):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):
- 1:58 PM Changeset in webkit [116995] by
-
- 2 edits in trunk/Source/WebCore
Avoid logging related to setting shadow-related properties on a transform-only layer
https://bugs.webkit.org/show_bug.cgi?id=86398
Reviewed by Dan Bernstein.
When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
to set filters on the transform layer. We should never have this combination,
because filters force flattening to occur.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
- 1:52 PM Changeset in webkit [116994] by
-
- 8 edits in trunk
Unreviewed, rolling out r116983.
http://trac.webkit.org/changeset/116983
https://bugs.webkit.org/show_bug.cgi?id=86397
Does not compile on chromium-win (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14
Source/WebCore:
- WebCore.gypi:
- page/TouchAdjustment.cpp:
Source/WebKit/chromium:
- features.gypi:
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:49 PM Changeset in webkit [116993] by
-
- 5 edits in trunk/Source/WebKit2
The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
https://bugs.webkit.org/show_bug.cgi?id=86395
<rdar://problem/11447652>
Reviewed by John Sullivan.
Add the plug-in identifier and version string to the didFail client callback.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
Pass a null plug-in identifier and version here since we don't have the plug-in information here.
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- 1:48 PM Changeset in webkit [116992] by
-
- 7 edits in trunk/LayoutTests
[SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568
Unreviewed Chromium test expectations update.
- platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png:
- platform/chromium-mac/svg/custom/js-update-style-expected.png:
- platform/chromium-mac/svg/custom/path-zero-strokewidth-expected.png: Modified property svn:mime-type.
- platform/chromium-win/svg/custom/js-update-style-expected.png:
- platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png:
- platform/chromium/test_expectations.txt:
- 1:39 PM Changeset in webkit [116991] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Added more detail to marked test failure for chromium.
- platform/chromium/test_expectations.txt:
- 1:20 PM Changeset in webkit [116990] by
-
- 2 edits in trunk/LayoutTests
Fix typo in expectations file causing lint to fail.
Unreviewed, build fix.
- platform/chromium/test_expectations.txt:
- 1:16 PM Changeset in webkit [116989] by
-
- 1 edit1 add in trunk/PerformanceTests
Add a line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=86216
Reviewed by Ryosuke Niwa.
- Layout/line-layout.html: Added.
- 1:11 PM Changeset in webkit [116988] by
-
- 6 edits in trunk/Tools
garden-o-matic should specify which types of baselines to rebaseline
https://bugs.webkit.org/show_bug.cgi?id=86242
Reviewed by Adam Barth.
This change modifies garden-o-matic so that we are explicit
about whether to rebaseline the text file, the image file, or
both. This should prevent us from pulling incorrect or
unexpected baselines off the bots.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
(.):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.init):
(RebaselineTest):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(OptimizeBaselines):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
(RebaselineExpectations._rebaseline_port):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
(GardeningServerTest.test_rebaseline_new_port):
(GardeningServerTest.test_optimizebaselines):
- 1:09 PM Changeset in webkit [116987] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar.com/iphone
https://bugs.webkit.org/show_bug.cgi?id=86391
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-14
Reviewed by Adam Treat.
PR 156992
Request layout first if needed before painting contents.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
- 1:04 PM Changeset in webkit [116986] by
-
- 3 edits2 adds in trunk
Pagination splits lines that could fit on a single page if it were not for their top leading
https://bugs.webkit.org/show_bug.cgi?id=86388
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/multicol/split-in-top-margin.html
When a line’s visible content fits on a page, but adding the top leading makes it taller than
a page, instead of giving up and splitting the line in an arbitrary position, add a strut
to push it downwards so that the split occurs in the top leading, and the visible content is
fully contained on a single page.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):
LayoutTests:
- fast/multicol/split-in-top-margin-expected.html: Added.
- fast/multicol/split-in-top-margin.html: Added.
- 12:52 PM Changeset in webkit [116985] by
-
- 2 edits in trunk/LayoutTests
Unreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
the specific test (storage/indexeddb/noblobs.html) was fixed in r116337.
- platform/chromium/test_expectations.txt:
- 12:28 PM Changeset in webkit [116984] by
-
- 2 edits in trunk/PerformanceTests
Don't append log lines while perf tests are running.
https://bugs.webkit.org/show_bug.cgi?id=86028
Reviewed by Ryosuke Niwa.
In some tests, the extra DOM nodes can cause the test timing to change.
Avoid adding DOM nodes until the test is over. When running in a browser,
we append nodes as we run so the user can have some feedback.
- resources/runner.js:
(PerfTestRunner.log): Store the log lines in an array until the test is finished.
- 12:24 PM Changeset in webkit [116983] by
-
- 8 edits in trunk
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-14
Reviewed by Adam Barth.
Source/WebCore:
Using tests in the touchadjustment/ directory.
- WebCore.gypi:
Include TouchAdjustment.* files.
- page/TouchAdjustment.cpp:
Included math.h because of an 'Undeclared identifier: INFINITY' when
this patch was landed before.
Source/WebKit/chromium:
- features.gypi:
Enable the touch adjustment code by default.
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.
LayoutTests:
- platform/chromium/test_expectations.txt:
The flaky tests in touchadjustment/ have been addressed in WK86218.
- 12:19 PM Changeset in webkit [116982] by
-
- 4 edits1 copy in branches/chromium/1132/Source
Merge 116722 - Sync with impl thread when removing references to external textures
https://bugs.webkit.org/show_bug.cgi?id=86054
We want to ensure the client side is safe to release textures, so we
sync with the impl thread when:
- we change the texture (and we had one)
- the layer is removed from the tree (and we had a texture)
- the layer is destroyed (and we had a texture)
Reviewed by James Robinson.
Test: TextureLayerChromiumTest.
- platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setLayerTreeHost):
(WebCore):
- platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromium):
TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10384160
- 12:14 PM Changeset in webkit [116981] by
-
- 2 edits in trunk/Tools
[EFL][DRT] Fix WebCore library path
https://bugs.webkit.org/show_bug.cgi?id=86355
Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-14
Reviewed by Dirk Pranke.
Currently EFL DRT uses wrong WebCore library path when running DRT.
This patch simply adjusted it.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):
- 12:12 PM Changeset in webkit [116980] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark one test as failed on chromium.
- platform/chromium/test_expectations.txt:
- 12:10 PM Changeset in webkit [116979] by
-
- 8 edits in trunk/Source
[chromium] Add compositor debug asserts for blocked main thread
https://bugs.webkit.org/show_bug.cgi?id=86384
Reviewed by James Robinson.
Source/WebCore:
Where we depend for thread-safety that the main thread is blocked,
assert that this is actually the case.
- platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore):
(WebCore::CCProxy::isMainThreadBlocked):
(WebCore::CCProxy::setMainThreadBlocked):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
(WebCore):
(DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::DebugScopedSetMainThreadBlocked):
(WebCore::DebugScopedSetMainThreadBlocked::~DebugScopedSetMainThreadBlocked):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::stop):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrame):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
Source/WebKit/chromium:
For tests that are just on the impl tree, pretend that the main thread
is always blocked.
- tests/CCLayerTreeHostImplTest.cpp:
(CCLayerTreeHostImplTest):
- 12:06 PM Changeset in webkit [116978] by
-
- 3 edits2 adds in trunk
Patch by Swapna P <spottabathini@innominds.com> on 2012-05-14
Reviewed by Eric Seidel.
Bug: Cannot resize frames because frameborder=0
https://bugs.webkit.org/show_bug.cgi?id=23750
Source/WebCore:
Removed check for frameborder, in order to allow resize of frames even in case of frameborder=0.
Test: fast/frames/frames-with-frameborder-zero-can-be-resized.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::startResizing):
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):
LayoutTests:
Added test case to test whether the frame can be resized when frameborder=0.
- fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
- fast/frames/frames-with-frameborder-zero-can-be-resized.html: Added.
- 12:03 PM Changeset in webkit [116977] by
-
- 6 edits2 adds4 deletes in trunk/LayoutTests
More gardening after r115846.
The rebaselining was partially done. Removed the expected TEXT failures from our Mac bots
and rebaselined more platforms.
- platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Removed.
- platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Removed.
- platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
- platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Removed.
- platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
- platform/chromium-linux/fast/forms/input-value-expected.txt:
- platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Added.
- platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium/test_expectations.txt:
- 11:59 AM Changeset in webkit [116976] by
-
- 2 edits in trunk/PerformanceTests
Build fix. Don't adjust calls per iteration in the second run.
- resources/runner.js:
(PerfTestRunner._perSecondRunner):
- 11:57 AM Changeset in webkit [116975] by
-
- 6 edits3 adds in trunk
Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=86319
Patch by David Barton <Dave Barton> on 2012-05-14
Reviewed by Darin Adler.
Source/WebCore:
Most of RenderMathMLSquareRoot.cpp is duplicated in RenderMathMLRoot.cpp and can be
eliminated. We also define RenderMathMLRoot::computePreferredLogicalWidths().
Test: mathml/presentation/mroot-pref-width.html
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLRoot::layout):
(WebCore::RenderMathMLRoot::paint):
- rendering/mathml/RenderMathMLRoot.h:
- rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
(WebCore::RenderMathMLSquareRoot::addChild):
- rendering/mathml/RenderMathMLSquareRoot.h:
LayoutTests:
- mathml/presentation/mroot-pref-width.html: Added.
- platform/mac/mathml/presentation/mroot-pref-width-expected.png: Added.
- platform/mac/mathml/presentation/mroot-pref-width-expected.txt: Added.
- 11:54 AM Changeset in webkit [116974] by
-
- 16 edits1 move1 add1 delete in trunk/Source/WebCore
[Shadow DOM][Refactoring] HTMLContentSelector family should have better name
https://bugs.webkit.org/show_bug.cgi?id=86064
Reviewed by Dimitri Glazkov.
This change renames classes around shadow content distribution.
- Renamed HTMLContentSelector to ContentDistributor
- Renamed HTMLContentSelectionList to ContentDistribution
- Renamed HTMLContentSelection to ContentDistribution::Item
- Inlined HTMLContentSelectionSet into ContentDistributor
Associated rename and inlining are also happening for method names.
No new tests. No behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::distributionItemFor):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsRedistributing):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsRedistributing):
- dom/ElementShadow.h:
(WebCore):
(ElementShadow):
(WebCore::ElementShadow::distributor):
(WebCore::ElementShadow::clearNeedsRedistributing):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
- dom/ShadowRoot.cpp:
- dom/ShadowRoot.h:
(WebCore):
- html/shadow/ContentDistributor.cpp: Renamed from Source/WebCore/html/shadow/HTMLContentSelector.cpp.
(WebCore):
(WebCore::ContentDistribution::ContentDistribution):
(WebCore::ContentDistribution::~ContentDistribution):
(WebCore::ContentDistribution::find):
(WebCore::ContentDistribution::clear):
(WebCore::ContentDistribution::append):
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findFor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::willDistribute):
(WebCore::ContentDistributor::didDistribute):
(WebCore::ContentDistributor::preparePoolFor):
- html/shadow/ContentDistributor.h: Added.
(WebCore):
(ContentDistribution):
(Item):
(WebCore::ContentDistribution::Item::insertionPoint):
(WebCore::ContentDistribution::Item::node):
(WebCore::ContentDistribution::Item::next):
(WebCore::ContentDistribution::Item::previous):
(WebCore::ContentDistribution::Item::create):
(WebCore::ContentDistribution::Item::Item):
(WebCore::ContentDistribution::first):
(WebCore::ContentDistribution::last):
(WebCore::ContentDistribution::firstNode):
(WebCore::ContentDistribution::lastNode):
(WebCore::ContentDistribution::isEmpty):
(ContentDistributor):
(Translator):
(WebCore::ContentDistributor::Translator::hash):
(WebCore::ContentDistributor::Translator::equal):
(WebCore::ContentDistributor::Hash::hash):
(WebCore::ContentDistributor::Hash::equal):
(Hash):
(WebCore::ContentDistributor::inDistribution):
(WebCore::ContentDistributor::poolIsReady):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
- html/shadow/HTMLContentSelector.h: Removed.
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):
- html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::distribution):
(WebCore::InsertionPoint::hasDistribution):
- 11:26 AM Changeset in webkit [116973] by
-
- 4 edits in trunk
[Chromium] ImageDiff should be build for host on Android
https://bugs.webkit.org/show_bug.cgi?id=82039
Patch by Wei James <james.wei@intel.com> on 2012-05-14
Reviewed by Adam Barth.
Source/WTF:
- WTF.gyp/WTF.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 11:18 AM Changeset in webkit [116972] by
-
- 2 edits in trunk/LayoutTests
Fixup: Two of the touch-adjustment tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86218
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-14
Reviewed by Darin Adler.
One test cases was still not working all platforms.
Change used font to Ahem to have stable layout across platforms.
- touchadjustment/touch-inlines.html:
- 11:17 AM Changeset in webkit [116971] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r116796): Assertion failure in API tests
<http://webkit.org/b/86378>
<rdar://problem/10777218>
Reviewed by Anders Carlsson.
Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
- 11:14 AM Changeset in webkit [116970] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r116969.
http://trac.webkit.org/changeset/116969
https://bugs.webkit.org/show_bug.cgi?id=86386
i accidentally the icondatabase (Requested by kling on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14
Source/WebCore:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
- loader/icon/IconDatabase.h:
(IconDatabase):
Source/WebKit2:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
- 11:04 AM Changeset in webkit [116969] by
-
- 4 edits in trunk/Source
REGRESSION(r116796): Assertion failure in API tests
<http://webkit.org/b/86378>
<rdar://problem/10777218>
Reviewed by Anders Carlsson.
Invalidate the plugin work queue in ~WebContext to avoid hitting
the !m_isValid assertion in ~WorkQueue later on.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::~WebContext):
- 11:02 AM Changeset in webkit [116968] by
-
- 1 edit4 copies in branches/chromium/1132
Merge 116693 - Crash in computedCSSPadding* functions due to RenderImage::imageDimensionsChanged called during attachment
https://bugs.webkit.org/show_bug.cgi?id=85912
Reviewed by Eric Seidel.
Source/WebCore:
Tests: fast/images/link-body-content-imageDimensionChanged-crash.html
fast/images/script-counter-imageDimensionChanged-crash.html
The bug comes from CSS generated images that could end up calling imageDimensionsChanged during attachment. As the
rest of the code (e.g. computedCSSPadding*) would assumes that we are already inserted in the tree, we would crash.
The solution is to bail out in this case as newly inserted RenderObject will trigger layout later on and properly
handle what we would be doing as part of imageDimensionChanged (the only exception being updating our intrinsic
size which should be done as part of imageDimensionsChanged).
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
LayoutTests:
- fast/images/link-body-content-imageDimensionChanged-crash-expected.txt: Added.
- fast/images/link-body-content-imageDimensionChanged-crash.html: Added.
- fast/images/script-counter-imageDimensionChanged-crash-expected.txt: Added.
- fast/images/script-counter-imageDimensionChanged-crash.html: Added.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10383163
- 10:54 AM Changeset in webkit [116967] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed trivial buildfix after r116958.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
- 10:48 AM Changeset in webkit [116966] by
-
- 2 edits in trunk/Tools
Unreviewed. Updating email for committers.py script.
Patch by Joone Hur <Joone Hur> on 2012-05-14
- Scripts/webkitpy/common/config/committers.py:
- 10:46 AM Changeset in webkit [116965] by
-
- 16 edits15 adds39 deletes in trunk/LayoutTests
Unreviewed rebaseline after r115846.
Those are layers additions & baselines churns due to sharing or splitting
between ports.
- fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
- fast/repaint/lines-with-layout-delta-expected.txt: Added.
- fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
- fast/repaint/repaint-resized-overflow-expected.txt: Added.
- fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
- fast/repaint/subtree-root-clip-2-expected.png: Added.
- fast/repaint/subtree-root-clip-expected.png: Added.
- platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.txt: Added.
- platform/chromium-linux-x86/fast/forms/input-value-expected.txt: Added.
- platform/chromium-linux-x86/fast/layers: Removed.
- platform/chromium-linux-x86/fast/repaint/inline-relative-positioned-expected.txt: Added.
- platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Added.
- platform/chromium-linux-x86/fast/table/colspanMinWidth-vertical-expected.txt: Added.
- platform/chromium-linux-x86/fast/text/textIteratorNilRenderer-expected.txt: Added.
- platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium-mac/fast/repaint/inline-relative-positioned-expected.txt:
- platform/chromium-mac/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
- platform/chromium-mac/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
- platform/chromium-mac/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
- platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.txt: Removed.
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.txt: Removed.
- platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Removed.
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt: Removed.
- platform/chromium-win-vista/fast/layers: Removed.
- platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Added.
- platform/chromium-win-xp/fast/layers: Removed.
- platform/chromium-win-xp/fast/repaint/inline-relative-positioned-expected.txt: Added.
- platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
- platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
- platform/chromium-win/fast/forms/input-value-expected.txt:
- platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
- platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
- platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
- platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
- platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
- platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
- platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
- platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
- platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
- platform/chromium/fast/layers: Removed.
- platform/chromium/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
- platform/chromium/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/chromium/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
- platform/efl/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
- platform/efl/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
- platform/efl/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/efl/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
- platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
- 10:45 AM Changeset in webkit [116964] by
-
- 5 edits in trunk/Source/WebKit/efl
[EFL] Remove ewk_view_core_page_get().
https://bugs.webkit.org/show_bug.cgi?id=86326
Reviewed by Antonio Gomes.
Right now, we have both ewk_view_core_page_get() and
EWKPrivate::corePage() doing the same thing, but the latter is
better encapsulated.
Remove the former then.
- WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::syncLayersNow): Add
missing ewk_private.h and use EWKPrivate::corePage().
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow): Use
EWKPrivate::corePage().
- ewk/ewk_private.h: Remove ewk_view_core_page_get() declaration.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(EWKPrivate::corePage): Fix coding style while here.
- 10:32 AM Changeset in webkit [116963] by
-
- 8 edits in branches/chromium/1132/Source
Merge 116472 - [chromium] Reflections with masks should not occlude
https://bugs.webkit.org/show_bug.cgi?id=85927
Reviewed by James Robinson.
Source/WebCore:
When a surface does not have a mask, we make both it and its reflection
occlude the things below them. However, if the reflection has a mask
applied to it, then we should not consider it as occluding.
Adds replicaHasMask() to the render surface classes so we can test if
the mask is present.
Unit Tests: CCOcclusionTrackerTestReplicaWithMask
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::RenderSurfaceChromium::replicaHasMask):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToTargetRenderSurface):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::CCRenderSurface::replicaHasMask):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setMask):
(CCOcclusionTrackerTestReplicaWithMask):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests):
- 10:30 AM Changeset in webkit [116962] by
-
- 4 edits in trunk
[wx] Unreviewed build fixes for wxMSW build.
- 10:27 AM Changeset in webkit [116961] by
-
- 2 edits in trunk/Source/WebCore
[wx] Unreviewed build fix. Fix for wxMSW windows.h load order bug.
- 10:17 AM Changeset in webkit [116960] by
-
- 4 edits3 adds in trunk
<video> won't load when URL ends with .php
https://bugs.webkit.org/show_bug.cgi?id=86308
Source/WebCore:
Reviewed by NOBODY (OOPS!).
Test: http/tests/media/video-query-url.html
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer): Initialize m_typeInferredFromExtension.
(WebCore::MediaPlayer::load): Set m_typeInferredFromExtension appropriately.
(WebCore::MediaPlayer::loadWithNextMediaEngine): If we don't find a media engine registered
for a MIME type, and the type was inferred from the extension, give the first registered
media engine a chance anwyay just as we do when there is no MIME type at all.
- platform/graphics/MediaPlayer.h: Add m_typeInferredFromExtension.
LayoutTests:
Reviewed by Darin Adler.
- http/tests/media/resources/load-video.php: Added.
- http/tests/media/video-query-url-expected.txt: Added.
- http/tests/media/video-query-url.html: Added.
- 10:12 AM Changeset in webkit [116959] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=86371
When the user selects an object in HeapSnapshot we are updating $0 variable in console API.
But if the snapshot was loaded from file then we can't map object id for the selected obect
from the snapshot to the live objects in the inspected page.
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
- 9:44 AM Changeset in webkit [116958] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Simplify OTHER_FILES for QML tests project files
Reviewed by Jocelyn Turcotte.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
- UIProcess/API/qt/tests/qmltests/WebView.pro:
- 9:34 AM Changeset in webkit [116957] by
-
- 12 edits2 adds in trunk
Web Inspector: [Extensions API] allow extensions to evaluate in the context of their content scripts
https://bugs.webkit.org/show_bug.cgi?id=86361
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/extensions/extensions-eval-content-script.html
- inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression): Added evaluateOptions optional parameter.
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument): A helper to extract callback function from last argument.
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane.prototype.setExpression): Added evaluateOptions optional parameter.
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarContent): Use ExtensionServer.evaluate() wrapper.
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): Ditto.
(WebInspector.ExtensionServer.prototype._normalizePath):
(WebInspector.ExtensionServer.prototype.evaluate): A wrapper for PageAgent.evaluate() that handles evaluateOptions.
- inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin): Expose interface to locate context id by frame and content script security origin.
(WebInspector.FrameEvaluationContext.prototype._addExecutionContext): Maintain contexts sorted by name.
(WebInspector.FrameEvaluationContext.prototype.isolatedContexts): ditto (skip sorting when returning contexts)
(WebInspector.FrameEvaluationContext.prototype.contextBySecurityOrigin):
- inspector/front-end/inspector.js: Hold/expose javaScriptContextManager.
LayoutTests:
- inspector/extensions/extensions-eval-content-script-expected.txt: Added.
- inspector/extensions/extensions-eval-content-script.html: Added.
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 9:10 AM Changeset in webkit [116956] by
-
- 8 edits in trunk
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header file.
Source/WebKit2:
- GNUmakefile.am: Explicitly link WebProcess to
libjavascriptcoregtk to make sure it uses the non installed
library.
- GNUmakefile.list.am: Add missing header file.
Tools:
- GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
- gtk/run-api-tests:
(TestRunner._lookup_atspi2_binary): Handle the case when
pkg_config_file_variable() return None.
- 9:06 AM Changeset in webkit [116955] by
-
- 2 edits1 add11 deletes in trunk/LayoutTests
[CSSRegions]Convert render-region-custom-style-mark to ref test
https://bugs.webkit.org/show_bug.cgi?id=86289
Reviewed by Andreas Kling.
This test verifies that:
- If an element is displayed in a region with a region styling rule, that rule is applied.
- If an element is collected into a named flow and we add a region (with a region style rule) to display the named flow,
that region styling rule is applied.
- If an element is displayed in a region with a region styling rule, and the region element is changed into a non-region,
the region styling rule is not applied.
- fast/regions/render-region-custom-style-mark-expected.html: Added.
- fast/regions/render-region-custom-style-mark.html:
- platform/chromium-linux/fast/regions/render-region-custom-style-mark-expected.png: Removed.
- platform/chromium-mac-leopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
- platform/chromium-mac/fast/regions/render-region-custom-style-mark-expected.png: Removed.
- platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.png: Removed.
- platform/chromium-win/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
- platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
- platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Removed.
- platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
- platform/mac/fast/regions/render-region-custom-style-mark-expected.txt: Removed.
- 8:53 AM Changeset in webkit [116954] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: preserve tab index while widening / shrinking tabbed pane area.
https://bugs.webkit.org/show_bug.cgi?id=86359
Reviewed by Vsevolod Vlasov.
After the drag'n'drop reorder, we should preserve tab index while widening /
shrinking the tabbed pane area.
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._innerCloseTab):
(WebInspector.TabbedPane.prototype._showTabElement):
(WebInspector.TabbedPane.prototype._hideTabElement):
(WebInspector.TabbedPane.prototype._updateTabsDropDown):
(WebInspector.TabbedPane.prototype.elementsToRestoreScrollPositionsFor):
(WebInspector.TabbedPane.prototype._insertBefore):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabDragging):
- 8:48 AM Changeset in webkit [116953] by
-
- 8 edits in trunk/LayoutTests
[Chromium] Update expectations after fix for 84846
https://bugs.webkit.org/show_bug.cgi?id=86374
Unreviewed Chromium test expectations update.
- platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- platform/chromium/test_expectations.txt:
- 8:44 AM Changeset in webkit [116952] by
-
- 11 edits in trunk
Web Inspector: Request / response headers should be stored in name-value pairs array, not a map on front-end.
https://bugs.webkit.org/show_bug.cgi?id=86357
Reviewed by Pavel Feldman.
Source/WebCore:
Storing headers as name-value pairs array information more accurate and allows
to treat Set-Cookie headers (which become not parseable when joined by comma) correctly.
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
- inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._headersMapToHeadersArray):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype._headerValue):
- inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):
- platform/chromium/support/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):
LayoutTests:
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-har-headers-expected.txt:
- http/tests/inspector/resource-har-headers.html:
- 8:35 AM Changeset in webkit [116951] by
-
- 6 edits in trunk/Source
Source/JavaScriptCore: DFG JIT didn't work with ARM EABI.
https://bugs.webkit.org/show_bug.cgi?id=84449
Patch by Yong Li <yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.
Add a 32-bit dummy argument for some callOperation()
methods to make it work for ARM EABI.
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):
Source/WTF: DFG JIT is not ARM EABI compatible
https://bugs.webkit.org/show_bug.cgi?id=84449
Patch by Yong Li <yoli@rim.com> on 2012-05-14
Reviewed by Filip Pizlo.
Add COMPILER_SUPPORTS(EABI) when ARM_EABI
or EABI is defined.
- wtf/Compiler.h:
- 8:33 AM Changeset in webkit [116950] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Memory leaks in WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=86365
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-14
Reviewed by Martin Robinson.
Fix memory leaks in WebKitWebSettings by adopting allocations
using adoptWK.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_init):
(webkit_settings_set_serif_font_family):
- 8:28 AM Changeset in webkit [116949] by
-
- 8 edits in trunk/Source/WebCore
[Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be under condition guards
https://bugs.webkit.org/show_bug.cgi?id=86060
Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-05-14
Reviewed by Martin Robinson.
Property set/get functions generated was referencing WebCore::interface without any condition guard.
This issue was triggered usually when an interface gets disabled; For instance; --disable-video, disables WebCore::HTMLMediaElement.
Also updated the GObject binding reference tests
No new tests - covered by existing bindings tests
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperties):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(webkit_dom_test_active_dom_object_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(webkit_dom_test_event_constructor_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(webkit_dom_test_exception_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
- 8:23 AM Changeset in webkit [116948] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Wrong documentation for Web Database
https://bugs.webkit.org/show_bug.cgi?id=86362
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-14
Reviewed by Martin Robinson.
Fixed docs for webkit_set_default_web_database_quota().
- webkit/webkitwebdatabase.cpp:
- 8:17 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:15 AM Changeset in webkit [116947] by
-
- 4 edits3 deletes in trunk/Tools
Unreviewed, rolling out r116935.
http://trac.webkit.org/changeset/116935
https://bugs.webkit.org/show_bug.cgi?id=86373
Something is still broken (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14
- Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
- Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
(PNGChecker):
(PNGChecker._config_file_path):
- Scripts/webkitpy/tool/commands/download.py:
(Land):
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
- Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
- 7:49 AM Changeset in webkit [116946] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Styles] css properties copied into clipboard contain extra line breaks before color values
https://bugs.webkit.org/show_bug.cgi?id=86372
Reviewed by Vsevolod Vlasov.
The "display: block" property found in the ".swatch-inner" CSS class was causing the issue
(an additional \n was rendered in the plain text value).
- inspector/front-end/inspector.css:
(.swatch-inner):
- 7:05 AM Changeset in webkit [116945] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/loader/null-request-after-willSendRequest.html and fast/loader/recursive-before-unload-crash.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86368
Unreviewed EFL gardening.
Remove fast/loader/null-request-after-willSendRequest.html and
fast/loader/recursive-before-unload-crash.html from skip list now that
EFL port has proper support for LayoutTestController's
dumpFrameLoadCallbacks.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-14
- platform/efl/Skipped:
- 7:01 AM Changeset in webkit [116944] by
-
- 7 edits in trunk
[Qt] Doesn't build with ENABLE_INSPECTOR=0
https://bugs.webkit.org/show_bug.cgi?id=85056
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-14
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
- Target.pri:
- UIProcess/qt/QtWebContext.cpp:
(WebKit::initInspectorServer):
Tools:
- WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/features.pri:
- 6:58 AM Changeset in webkit [116943] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening, unskip now passing tests.
- platform/qt-5.0-wk2/Skipped:
- 6:39 AM Changeset in webkit [116942] by
-
- 17 edits16 adds in trunk/LayoutTests
[EFL][DRT] Unskipping a set of remaining media failures
https://bugs.webkit.org/show_bug.cgi?id=86104
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-14
- platform/efl/Skipped:
- platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
- platform/efl/media/audio-controls-rendering-expected.png:
- platform/efl/media/audio-controls-rendering-expected.txt:
- platform/efl/media/audio-repaint-expected.png:
- platform/efl/media/audio-repaint-expected.txt:
- platform/efl/media/controls-after-reload-expected.png:
- platform/efl/media/controls-after-reload-expected.txt:
- platform/efl/media/controls-strict-expected.png:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-without-preload-expected.png:
- platform/efl/media/controls-without-preload-expected.txt:
- platform/efl/media/media-document-audio-repaint-expected.png: Added.
- platform/efl/media/media-document-audio-repaint-expected.txt: Added.
- platform/efl/media/video-controls-rendering-expected.png:
- platform/efl/media/video-controls-rendering-expected.txt:
- platform/efl/media/video-display-toggle-expected.png:
- platform/efl/media/video-display-toggle-expected.txt:
- platform/efl/test_expectations.txt:
- 6:36 AM Changeset in webkit [116941] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening; unskip tests fixed in r116929.
- platform/efl/test_expectations.txt:
- 6:25 AM Changeset in webkit [116940] by
-
- 5 edits in trunk
[Qt] REGRESSION (r116789): inspector/debugger/script-formatter-console.html fails
https://bugs.webkit.org/show_bug.cgi?id=86336
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.location):
LayoutTests:
- inspector/debugger/script-formatter-breakpoints.html:
- platform/qt/Skipped:
- 6:10 AM Changeset in webkit [116939] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r116932.
http://trac.webkit.org/changeset/116932
https://bugs.webkit.org/show_bug.cgi?id=86364
It still fails on 32 bit platforms (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14
- platform/qt/Skipped:
- 6:07 AM Changeset in webkit [116938] by
-
- 2 edits in trunk/Source/WebCore
TiledBackingStore: Prevent partial tile updates when they intersect the keep rect.
https://bugs.webkit.org/show_bug.cgi?id=85488
Reviewed by Kenneth Rohde Christiansen.
Right now an invalidate can cause problems for tiles on the boundary of the keep
rect. Intersecting the dirty rect causes only part of the tile to be updated,
and the glitch becomes visible if the user scrolls this tile back into the viewport.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):
- 5:45 AM Changeset in webkit [116937] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] fast/viewport testcases are skipped
https://bugs.webkit.org/show_bug.cgi?id=86360
Unreviewed, unskipping now passing fast/viewport tests after
bug https://bugs.webkit.org/show_bug.cgi?id=70609 got fixed.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-14
- platform/efl/Skipped:
- 5:38 AM Changeset in webkit [116936] by
-
- 10 edits in trunk
[Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted
https://bugs.webkit.org/show_bug.cgi?id=86222
The WebView QML api for dialogs is based on delegates for each dialog, which
are implemented as components. Since there's no explicit API to show the dialog,
the natural place to allow the dialog to choose how to display itself is in
Component.onCompleted.
The issue was that we were using QQmlComponent::create() when instantiating the
component, at which point the component did not have a parent or it's attached
WebView property set. That meant that we had to do some ugly workaround in our
test, using a 1ms timer, to get a callback once the parent was there.
We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
pair, which allows us to set the relevant properties before triggering the
Component.onCompleted callback. We were already doing this for the context
menus (except for setting the parent, which we did afterwards).
Reviewed by Simon Hausmann.
- 5:31 AM Changeset in webkit [116935] by
-
- 4 edits3 adds in trunk/Tools
webkit-patch land should automatically add svn:mime-type for .png files
https://bugs.webkit.org/show_bug.cgi?id=75825
I refactored the png.py to avoid code duplication.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-05-14
Reviewed by Dirk Pranke.
- Scripts/webkitpy/common/checksvnconfigfile.py: Added.
(check):
(_config_file_path):
(errorstr_autoprop):
(errorstr_png):
- Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.check):
- Scripts/webkitpy/tool/commands/download.py:
(Land):
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
(AddSvnMimetypeForPng):
(AddSvnMimetypeForPng.init):
(AddSvnMimetypeForPng.run):
(AddSvnMimetypeForPng._check_pngs):
- Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
(MockSCMDetector):
(MockSCMDetector.init):
(MockSCMDetector.display_name):
(AddSvnMimetypeForPngTest):
(AddSvnMimetypeForPngTest.test_run):
- 5:17 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 5:08 AM Changeset in webkit [116934] by
-
- 5 edits in trunk/Tools
webkit-patch apply-attachment is very slow for big patches
https://bugs.webkit.org/show_bug.cgi?id=74929
Add "excludefield=attachmentdata" to the URL everywhere
"ctype=xml" is used to exclude this field from the XML.
Reviewed by Adam Barth.
- Scripts/prepare-ChangeLog:
(fetchBugDescriptionFromURL):
- Scripts/webkitpy/common/config/urls.py:
- Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.bug_url_for_bug_id):
- 4:42 AM Changeset in webkit [116933] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Esc should revert the colorpicker-modifed color to the original
https://bugs.webkit.org/show_bug.cgi?id=86349
Reviewed by Vsevolod Vlasov.
A boolean parameter has been added to the Spectrum's hide() method to denote the picker cancellation,
which gets passed into the "Hidden" event listeners. StylesSidebarPane is made to remember the original property value
when the picker is opened, and restore it if the color picker is cancelled.
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
(WebInspector.Spectrum.prototype.hide):
(WebInspector.Spectrum.prototype._onKeyDown):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype.willHide):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- 4:08 AM Changeset in webkit [116932] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip a now passing test.
- platform/qt/Skipped:
- 4:03 AM Changeset in webkit [116931] by
-
- 2 edits in trunk/Source/WebCore
[Qt] TextureMapperGL::drawTexture marked OVERRIDE but does not override any member function.
https://bugs.webkit.org/show_bug.cgi?id=86347
This bug was introduced by r116834.
TextureMapperGL implements two drawTexture functions.
The first one takes a BitmapTexture as an argument and does override TextureMapper::drawTexture().
The second one takes a texture id as an argument and does not override any member function.
- platform/graphics/texmap/TextureMapperGL.h:
- 2:46 AM Changeset in webkit [116930] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: implement tabs reordering via drag'n'drop.
https://bugs.webkit.org/show_bug.cgi?id=86294
Reviewed by Yury Semikhatsky.
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabMouseMove):
(WebInspector.TabbedPaneTab.prototype._tabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):
- 2:12 AM Acronyms edited by
- Add WIP (diff)
- 1:56 AM Changeset in webkit [116929] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip now passing tests after r116926.
- platform/qt/Skipped:
- 1:13 AM Changeset in webkit [116928] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, removing test expectations for two tests that were
fixed in r116926.
- platform/gtk/test_expectations.txt:
- 12:49 AM Changeset in webkit [116927] by
-
- 4 edits in trunk/Source/WebCore
Should have Node::inDetach() for assertion purposes.
https://bugs.webkit.org/show_bug.cgi?id=86157
Reviewed by Darin Adler.
Implemented Node::inDetach() and added an assertio in Document::setFocusedNode().
This is a follow up of r116644 which removes inDetach() checking.
No new tests. Just adding an asssertion.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- dom/Node.cpp:
(WebCore):
(WebCore::Node::inDetach):
(WebCore::Node::detach):
- dom/Node.h:
(Node):
- 12:26 AM Changeset in webkit [116926] by
-
- 2 edits in trunk/Source/JavaScriptCore
Introduce PropertyName class
https://bugs.webkit.org/show_bug.cgi?id=86241
Reviewed by Darin Adler.
This patch introduced a couple of small bugs.
- runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
- Returning wrong value for "" - should not convert to 0.
(JSC::PropertyName::PropertyName):
- Remove the ASSERT, it was a little too aspirational.
May 13, 2012:
- 11:47 PM Changeset in webkit [116925] by
-
- 3 edits3 adds in trunk
DFG performs incorrect constant folding on double-to-uint32 conversion in
Uint32Array PutByVal
https://bugs.webkit.org/show_bug.cgi?id=86330
Source/JavaScriptCore:
Reviewed by Darin Adler.
static_cast<int>(d) is wrong, since JS semantics require us to use toInt32(d).
In particular, C++ casts on typical hardware (like x86 and similar) will
return 0x80000000 for double values that are out of range of the int32 domain
(i.e. less than -231 or greater than or equal to 231). But JS semantics call
for wrap-around; for example the double value 4294967297 ought to become the
int32 value 1, not 0x80000000.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
LayoutTests:
Rubber stamped by Darin Adler.
- fast/js/dfg-uint32array-overflow-constant-expected.txt: Added.
- fast/js/dfg-uint32array-overflow-constant.html: Added.
- fast/js/script-tests/dfg-uint32array-overflow-constant.js: Added.
(foo):
- 11:44 PM Changeset in webkit [116924] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove platform/image-decoders/xbm from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=86333
Reviewed by Adam Barth.
No new tests. No change in behavior.
- WebCore.gyp/WebCore.gyp: Remove reference to platform/image-decoders/xbm
since that directory was removed from the repository long ago.
- 11:42 PM Changeset in webkit [116923] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new asserting and failing test to paint the bots green.
- platform/qt/Skipped:
- 11:27 PM Changeset in webkit [116922] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test fix: these calc() tests are dumpAsText().
- css3/calc/transition-crash.html:
- css3/calc/transition-crash2.html:
- 11:23 PM Changeset in webkit [116921] by
-
- 2 edits in trunk/LayoutTests
[EFL] Several dom tests are failing after r116828
https://bugs.webkit.org/show_bug.cgi?id=86334
Unreviewed EFL gardening.
Move fast/dom/CSSStyleDeclaration/empty-string-property.html and
fast/dom/collection-null-like-arguments.html to test_expectations.txt.
Those tests are failing due to a regression introduced in r116828.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-13
- platform/efl/test_expectations.txt:
- 10:58 PM Changeset in webkit [116920] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Unreviewed, remove test expectations for plenty of sputnik tests that
were specific for debug builds. These tests are now consistently
passing on all the builders but that was only noticed when migration to
using test_expectations.txt was complete, meaning their test expectations
were out of date and moreover erroneous.
- platform/gtk/test_expectations.txt:
- 10:34 PM Changeset in webkit [116919] by
-
- 2 edits in trunk/Source/WebCore
[CG] Unneeded CFRetain/Release of CGImageRef in BitmapImage::draw
https://bugs.webkit.org/show_bug.cgi?id=86332
Reviewed by Dan Bernstein.
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Don't use RetainPtr since the result of
the function is used before anything could call CFRelease on it.
- 10:32 PM Changeset in webkit [116918] by
-
- 2 edits in trunk/LayoutTests
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591
Unreviewed, remove test expectations for another test which
consistently passess on all the Gtk builders.
- platform/gtk/test_expectations.txt:
- 10:26 PM Changeset in webkit [116917] by
-
- 5 edits in trunk/Source/WebCore
Listeners map uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86298
Reviewed by Dan Bernstein.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::~PageScriptDebugServer): Removed call
to deleteAllValues since the destructor now takes care of this
(WebCore::PageScriptDebugServer::addListener): Changed idiom of the add
function call here to use adoptPtr.
(WebCore::PageScriptDebugServer::removeListener): Added a now-needed
call to get and removed a now-uneeeded call to delete.
- bindings/js/PageScriptDebugServer.h: Changed the key type of
PageListenersMap to OwnPtr.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::~ScriptDebugServer): Removed code to delete
the values in m_pageListenersMap. This map was never used and so I have
removed it.
- bindings/js/ScriptDebugServer.h: Removed the type PageListenersMap
and the unused data member, m_pageListenersMap.
- 10:23 PM Changeset in webkit [116916] by
-
- 9 edits4 adds in trunk
performance tests should be able to measure runs/sec rather than time
https://bugs.webkit.org/show_bug.cgi?id=86021
Reviewed by Ojan Vafai.
PerformanceTests:
Add PerfTestRunner.runPerSecond. It uses _runLoop but replaces _runner by _perSecondRunner
to compute runs/s of runFunction.
When _perSecondRunner is called for the first time, i.e. _completedRuns is 0 (notice this is -1
in regular run/_runner), it slowly increases the number of function calls to runFunction between
time measurements in order to discount the time used by new Date() calls themselves until the
total time spent reaches 100 milliseconds.
By default, runPerSecond runs the test for at least 750 milliseconds in each run, and executes
21 runs, yielding the total run time of roughly 18 seconds. This is significantly faster than
most of existing performance tests. Also see http://ejohn.org/blog/accuracy-of-javascript-time/.
Finally, refactored the existing methods of PerfTestRunner to allow "runs/s" unit and share code.
- Layout/flexbox-column-nowrap.html:
- Layout/flexbox-column-wrap.html:
- Layout/flexbox-row-nowrap.html:
- Layout/flexbox-row-wrap.html:
- resources/runner.js:
(PerfTestRunner.computeStatistics): Takes unit.
(PerfTestRunner.logStatistics): Ditto.
(PerfTestRunner._runLoop):
(PerfTestRunner._runner):
(PerfTestRunner.runPerSecond): Added.
(PerfTestRunner._perSecondRunner): Added. Called by _runLoop.
(PerfTestRunner._perSecondRunnerIterator): Added.
Tools:
Allow " runs/s" or " ms" to appear after numerical values in tests.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
LayoutTests:
Add tests for PerfTestRunner.runPerSecond.
- fast/harness/perftests/runs-per-second-iterations-expected.txt: Added.
- fast/harness/perftests/runs-per-second-iterations.html: Added.
- fast/harness/perftests/runs-per-second-log-expected.txt: Added.
- fast/harness/perftests/runs-per-second-log.html: Added.
- 9:22 PM Changeset in webkit [116915] by
-
- 16 edits in trunk/Source/WebCore
[Forms] Move ValidityState methods implementation to another place
https://bugs.webkit.org/show_bug.cgi?id=86058
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-13
Reviewed by Kent Tamura.
This patch changes ValidityState class for limiting scope of
number/range input type related methods for introducing decimal
arithmetic.
Methods related to validation are moved from ValidateState to
input, select and textarea elements with virtual method based
dispatching via FormAssociateElement instead of tag name
dispatching so far for code simplification.
No new tests. This patch doesn't change behavior.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::customError): Added. Called from ValidateState. Returns custom error mssage in member variable.
(WebCore::FormAssociatedElement::patternMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeOverflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::rangeUnderflow): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::stepMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::tooLong): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::typeMismatch): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valid): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::valueMissing): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::customValidationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::validationMessage): Added. Called from ValidateState. This is default implementation.
(WebCore::FormAssociatedElement::setCustomValidity): Added. set custom error message.
- html/FormAssociatedElement.h:
(FormAssociatedElement): Added new instance value m_customValidationMessage.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::validationMessage): Removed. Note: HTMLInputElement, HTMLSelectElement, and HTMLTextAreaElement implement this method.
(WebCore::HTMLFormControlElement::setCustomValidity): Changed. Calls base class setCustomValidity.
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isValidValue): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::tooLong): Call m_inputType methods instead of HTMLInputElement's.
(WebCore):
(WebCore::HTMLInputElement::typeMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::valueMissing): Move implementation to InputType.
(WebCore::HTMLInputElement::patternMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeUnderflow): Move implementation to InputType.
(WebCore::HTMLInputElement::rangeOverflow): Move implementation to InputType.
(WebCore::HTMLInputElement::validationMessage): Move implementation to InputType.
(WebCore::HTMLInputElement::stepMismatch): Move implementation to InputType.
(WebCore::HTMLInputElement::isInRange): Call m_inputType methods instead of HTMLInputElement's.
(WebCore::HTMLInputElement::isOutOfRange): Call m_inputType methods instead of HTMLInputElement's.
- html/HTMLInputElement.h:
(HTMLInputElement): Make tooLong method private.
- html/HTMLObjectElement.h: Add "virtual" and "OVERRIDE".
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::validationMessage): Added. Implementation for HTMLSelectElement.
(WebCore::HTMLSelectElement::valueMissing): Added. Implementation for HTMLSelectElement.
- html/HTMLSelectElement.h:
(HTMLSelectElement): Added entries for newly added methods.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::validationMessage): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::valueMissing): Added. Implementation for HTMLTextAreaElement.
(WebCore::HTMLTextAreaElement::tooLong): Added. Implementation for HTMLTextAreaElement.
- html/HTMLTextAreaElement.h:
(HTMLTextAreaElement): Added entries for newly added methods. Change tooLong and valueMissing private.
- html/InputType.cpp:
(WebCore::InputType::stepMismatch): Change method signature.
(WebCore::InputType::alignValueForStep): Changed for calling InputClass instead of HTMLINputElement.
(WebCore::InputType::stepUpFromRenderer): Added. Moved from HTMLInputElement.
(WebCore::InputType::validationMessage): Added. Moved from HTMLInputElement.
- html/InputType.h:
(InputType): Added entries for newly added methods and update methods signature.
- html/ValidityState.cpp: Move actual implementation to FormAssociatedElement and derived classes for localizing implementation change of elements and input types.
(WebCore::ValidityState::validationMessage): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valueMissing): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::typeMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::patternMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::tooLong): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeUnderflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::rangeOverflow): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::stepMismatch): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::customError): Changed to call FormAssociatedElement's method.
(WebCore::ValidityState::valid):
- html/ValidityState.h:
(ValidityState): Remove custom validation message related things.
- 8:30 PM Changeset in webkit [116914] by
-
- 5 edits4 adds in trunk
Heap-use-after-free in WTF::HashMap<int, WTF::RefPtr<WebCore::CalculationValue>, WTF::IntHash<unsigned int>, WTF::HashTrait
https://bugs.webkit.org/show_bug.cgi?id=85195
Source/WebCore:
This bug was caused by Length not understanding that calc expressions shouldn't be
blended - a Length with a calc expression handle was created without incrementing
the ref count of the expression. Length no longer attempts to blend calc expressions,
http://webkit.org/b/86160 has been filed to track expression blending. Fixing this fixed
the crash.
Once this was fixed, the RenderStyle diff checker thought the style was changing,
as Length didn't know how to compare calc expressions, resulting in an infinite
loop of style recalcs. Expressions can now compare themselves.
Reviewed by Darin Adler.
Tests: css3/calc/transition-crash.html
css3/calc/transition-crash2.html
- platform/CalculationValue.h:
(WebCore::CalcExpressionNode::CalcExpressionNode):
(CalcExpressionNode):
(WebCore::CalcExpressionNode::type):
(CalculationValue):
(WebCore::CalculationValue::operator==):
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::CalcExpressionNumber::operator==):
(CalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::operator==):
(CalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation):
(WebCore::CalcExpressionBinaryOperation::operator==):
(CalcExpressionBinaryOperation):
- platform/Length.cpp:
(WebCore::Length::isCalculatedEqual):
(WebCore):
- platform/Length.h:
(WebCore::Length::operator==):
(Length):
(WebCore::Length::blend):
LayoutTests:
Reviewed by Darin Adler.
- css3/calc/transition-crash-expected.txt: Added.
- css3/calc/transition-crash.html: Added.
- css3/calc/transition-crash2-expected.txt: Added.
- css3/calc/transition-crash2.html: Added.
- 8:23 PM Changeset in webkit [116913] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK test_expectations update.
- platform/gtk/test_expectations.txt: Mark
media/video-controls-toggling.html as failing and move 2 other
media failures to the correct section.
- 7:17 PM WebKitGTK/1.8.x edited by
- (diff)
- 7:16 PM Changeset in webkit [116912] by
-
- 22 edits in branches/dfgopt/Source/JavaScriptCore
DFG should be able to optimize foo.apply(bar, arguments)
https://bugs.webkit.org/show_bug.cgi?id=86306
Reviewed by Gavin Barraclough.
Enables compilation of op_jneq_ptr and some forms of op_call_varargs.
Also includes a bunch of bug fixes that were made necessary by the increased
pressure on the CFG simplifier.
This is a 1-2% win on V8.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::canCompileWithDFGInternal):
(JSC::EvalCodeBlock::canCompileWithDFGInternal):
(JSC::FunctionCodeBlock::canCompileWithDFGInternal):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::canCompileWithDFG):
(JSC::CodeBlock::canCompileWithDFGState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
(DFG):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):
- dfg/DFGCommon.h:
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):
- jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
- 7:10 PM WebKitGTK/1.8.x edited by
- (diff)
- 6:48 PM Changeset in webkit [116911] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK test_expectations update.
- platform/gtk/test_expectations.txt: Flag another 2 media failures.
- 6:40 PM Changeset in webkit [116910] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK test_expectations update.
- platform/gtk/test_expectations.txt: Flag failing media test.
- 4:48 PM Changeset in webkit [116909] by
-
- 4 edits in trunk/Source/WebCore
Roll out local changes accidentally landed in r116905.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/cg/ImageCG.cpp:
- 4:47 PM Changeset in webkit [116908] by
-
- 10 edits in trunk/Source/WebCore
Use emptyString instead of String("")
https://bugs.webkit.org/show_bug.cgi?id=86305
Reviewed by Darin Adler.
Use emptyString() instead of String("") because it is better style and faster.
No new tests. No change in behavior.
- Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::performOpenAndVerify):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValueFromRenderer):
- platform/SharedBufferChunkReader.cpp:
(WebCore::SharedBufferChunkReader::nextChunkAsUTF8StringWithLatin1Fallback):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setProxyInfo):
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeLocalizedDateFormatText):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
- svg/SVGStringList.cpp:
(WebCore::SVGStringList::reset):
- 4:42 PM Changeset in webkit [116907] by
-
- 13 edits in trunk/Source/WebCore
Image::initPlatformData is always an empty function so we can remove it
https://bugs.webkit.org/show_bug.cgi?id=86297
Reviewed by Dan Bernstein.
- platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage): Ditto.
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Ditto.
- platform/graphics/chromium/ImageChromiumMac.mm: Removed empty
initPlatformData function.
- platform/graphics/efl/ImageEfl.cpp: Ditto.
- platform/graphics/gtk/ImageGtk.cpp:
- platform/graphics/mac/ImageMac.mm:
- platform/graphics/openvg/ImageOpenVG.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.
- platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.
- platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
- platform/graphics/win/ImageWin.cpp: Ditto.
- platform/graphics/wx/ImageWx.cpp: Ditto.
(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
- 4:39 PM Changeset in webkit [116906] by
-
- 2 edits in trunk/Source/WebCore
RenderView::selectionBounds and RenderView::setSelection use maps with raw pointers that should be OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86300
Reviewed by Eric Seidel.
- rendering/RenderView.cpp:
(WebCore::RenderView::selectionBounds): Changed SelectionMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.
(WebCore::RenderView::setSelection): Changed SelectedBlockMap type to use OwnPtr.
Added code to do adoptPtr as needed and removed explicit delete code.
- 4:36 PM Changeset in webkit [116905] by
-
- 5 edits in trunk/Source/WebCore
FractionalLayoutUnit class has unneeded redundant uses of "inline" keyword
https://bugs.webkit.org/show_bug.cgi?id=86301
Reviewed by Andreas Kling.
- platform/FractionalLayoutUnit.h: Removed uses of inline for functions
defined inside a class definition. The C++ language defines that all such
functions are treated as if specified with inline, and explicitly stating
inline in addition does not add anything or change behavior.
- 4:25 PM Changeset in webkit [116904] by
-
- 3 edits in trunk/Source/WebCore
Dangling node to ID maps vector uses raw pointers, but should use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86299
Reviewed by Pavel Feldman.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::releaseDanglingNodes): Removed now-unneeded call
to deleteAllValues since the clear function now takes care of that.
(WebCore::InspectorDOMAgent::pushNodePathToFrontend): Added code that uses
adoptPtr and release as neeed to deal with a Vector<OwnPtr>.
- inspector/InspectorDOMAgent.h: Changed m_danglingNodeToIdMaps to be
Vector<OwnPtr> instead of a vector of raw pointers.
- 2:45 PM Changeset in webkit [116903] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed, fix test skipped in the previous commit.
- platform/efl/test_expectations.txt:
- 2:43 PM Changeset in webkit [116902] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening; skip tests after r116900.
The patch only updated the chromium and mac expectations...
- platform/efl/test_expectations.txt:
- 2:09 PM Changeset in webkit [116901] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening; skip test added in r116858.
- platform/efl/test_expectations.txt:
- 12:11 PM Changeset in webkit [116900] by
-
- 15 edits2 adds in trunk
Volume slider needs to be displayed below the mute button
https://bugs.webkit.org/show_bug.cgi?id=85990
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-13
Reviewed by Dimitri Glazkov.
Source/WebCore:
Added back code for rendering offset, but used only when the volume slider
needs to be displayed below the controls.
Test: media/media-volume-slider-rendered-below.html
- css/mediaControlsChromium.css:
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Changed positioning of the slider to absolute, otherwise it is not possible to position it from the layout() method.
- css/mediaControlsQuickTime.css:
Added back the double mute-button and changed the z-index of the original button. When the slider is displayed
the second mute button is actually there.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
Added copy.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::makeTransparent): Disabled the possible of hiding controls. WebVTT rendering
in the place of controls when these are visible is not possible with the current code.
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
Checked if the absolute coordinates of the corner of the slider would be rendered outside the page. This part of the
code is faulty if display:none is toggled on the controls.
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):
- html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create):
LayoutTests:
Updated tests expectation and marked failing tests accordingly.
- media/media-volume-slider-rendered-below.html: Added.
- media/media-volume-slider-rendered-expected.txt: Added.
- platform/chromium/test_expectations.txt: Updated.
- platform/mac/media/audio-controls-rendering-expected.txt: Updated (z-index change).
- platform/mac/media/controls-after-reload-expected.txt: Same.
- platform/mac/media/controls-strict-expected.txt: Same.
- platform/mac/media/video-controls-rendering-expected.txt: Same.
- platform/mac/media/video-display-toggle-expected.txt: Same.
- platform/mac/media/video-playing-and-pause-expected.txt: Same.
- platform/mac/test_expectations.txt: Updated.
- 10:00 AM Changeset in webkit [116899] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] TextureMapperAnimations does not support keyframe with multiple animations
https://bugs.webkit.org/show_bug.cgi?id=86303
Qt and GTK, in WebKit1, use TextureMapper to store AC animations using
TextureMapperAnimations::add(keyframeName, TextureMapperAnimation). And when a
CSS animation animates several CSS properties, TextureMapperAnimations::add is
called more than once with the same keyframeName value. However, currently,
TextureMapperAnimations can not store more than one animated property in the keyframe
because it is using HashMap<String, TextureMapperAnimation>, and WebKit HashMap
does not support add the same key twice.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperAnimation.cpp:
(WebCore::TextureMapperAnimations::hasActiveAnimationsOfType):
(WebCore::TextureMapperAnimations::hasRunningAnimations):
(WebCore::TextureMapperAnimations::add):
(WebCore):
(WebCore::TextureMapperAnimations::pause):
(WebCore::TextureMapperAnimations::apply):
- platform/graphics/texmap/TextureMapperAnimation.h:
(TextureMapperAnimations): Use HashMap<String, Vector<TextureMapperAnimation> >,
so we can support an keyframe with multiple animations.
- 6:46 AM Changeset in webkit [116898] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/LayoutTests
Merge 113995 - Unreviewed, GTK test_expectations post-Skipped-migration update #2.
- platform/gtk/test_expectations.txt:
- 6:46 AM Changeset in webkit [116897] by
-
- 14 edits2 adds in releases/WebKitGTK/webkit-1.8/LayoutTests
Merge 113986 - Unreviewed, GTK test_expectations post-Skipped-migration update.
- platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
- platform/gtk/http/tests/misc/acid2-expected.txt:
- platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
- platform/gtk/svg/hixie/perf/001-expected.txt: Added.
- platform/gtk/svg/hixie/perf/002-expected.txt: Added.
- platform/gtk/svg/hixie/perf/003-expected.txt:
- platform/gtk/svg/hixie/perf/004-expected.txt:
- platform/gtk/svg/hixie/perf/005-expected.txt:
- platform/gtk/svg/hixie/perf/006-expected.txt:
- platform/gtk/svg/hixie/perf/007-expected.txt:
- platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
- platform/gtk/svg/text/text-deco-01-b-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/gtk/test_expectations.txt:
- svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
Conflicts:
LayoutTests/platform/gtk/svg/hixie/perf/001-expected.txt
LayoutTests/platform/gtk/svg/hixie/perf/002-expected.txt
LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt
- 6:46 AM Changeset in webkit [116896] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-1.8
Merge 110563 - Crash in WebCore::GraphicsContext::paintingDisabled
https://bugs.webkit.org/show_bug.cgi?id=80669
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.
So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.
Tests: svg/custom/circular-clip-path-references-crash-expected.svg
svg/custom/circular-clip-path-references-crash.svg
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::clipToTextMask):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::clipToImageBuffer):
- rendering/svg/SVGImageBufferTools.h:
(SVGImageBufferTools):
LayoutTests:
- svg/custom/circular-clip-path-references-crash-expected.svg: Added.
- svg/custom/circular-clip-path-references-crash.svg: Added.
- 6:45 AM Changeset in webkit [116895] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-1.8
Merge 110332 - Crash due to inserting letter into div with first-letter
https://bugs.webkit.org/show_bug.cgi?id=78534
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.
Source/WebCore:
This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)
- rendering/RenderTextFragment.h:
(WebCore::RenderTextFragment)
LayoutTests:
Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.
- editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
- editing/inserting/insert-character-in-first-letter-crash.html: Added
Conflicts:
Source/WebCore/rendering/RenderTextFragment.cpp
- 6:45 AM Changeset in webkit [116894] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 115978 - Unreviewed, fix another call to join(), similar to the ones landed
in r115975.
- Scripts/webkitdirs.pm:
(jhbuildConfigurationChanged):
- 6:45 AM Changeset in webkit [116893] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 115975 - [GTK] join() is wrongly used in webkitdirs.pm since r115532
https://bugs.webkit.org/show_bug.cgi?id=85501
Patch by Philippe Normand <pnormand@igalia.com> on 2012-05-03
Reviewed by Martin Robinson.
- Scripts/webkitdirs.pm:
(getJhbuildPath):
(buildAutotoolsProject):
- 6:45 AM Changeset in webkit [116892] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112408 - [GTK] generate-gtk-doc doesn't cope with custom build directory
https://bugs.webkit.org/show_bug.cgi?id=82448
Reviewed by Martin Robinson.
Pass the product directory in generate-gtkdoc arguments from
build-webkit.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- gtk/common.py:
(get_build_path):
- 6:44 AM Changeset in webkit [116891] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 115904 - Unreviewed. Fix mistake I committed when applying review comments.
- jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
appended to its path, so jhbuild itself was being cloned and
installed in the wrong place when using WEBKITOUTPUTDIR.
- 6:44 AM Changeset in webkit [116890] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 115659 - [GTK] Add glib as a dependency to build glib-networking
https://bugs.webkit.org/show_bug.cgi?id=85181
Reviewed by Martin Robinson.
- gtk/jhbuild.modules:
- 6:44 AM Changeset in webkit [116889] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 115532 - [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
https://bugs.webkit.org/show_bug.cgi?id=76161
Reviewed by Martin Robinson.
- Scripts/webkitdirs.pm:
(getJhbuildPath): New method to obtain the jhbuild base directory,
using the product base directory
(jhbuildConfigurationChanged): Use the new method
(buildAutotoolsProject): Ditto.
- efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
- gtk/jhbuildrc: Ditto.
- jhbuild/jhbuild-wrapper: Ditto.
- 6:44 AM Changeset in webkit [116888] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112372 - [GTK] jhbuild wrongly tricked into clean-up
https://bugs.webkit.org/show_bug.cgi?id=82216
Reviewed by Gustavo Noronha Silva.
Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
build tree. Also when checking if the jhbuild configuration
changed use absolute md5sum paths.
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary):
(jhbuildConfigurationChanged):
(buildAutotoolsProject):
- 6:43 AM Changeset in webkit [116887] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8
Merge 114653 - [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
https://bugs.webkit.org/show_bug.cgi?id=82484
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.
Tools:
Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
LayoutTests:
Unskipping tests that were previously failing due to a bug in libsoup.
- platform/gtk/test_expectations.txt:
Conflicts:
LayoutTests/platform/gtk/test_expectations.txt
Tools/efl/jhbuild.modules
- 6:43 AM Changeset in webkit [116886] by
-
- 2 edits1 delete in releases/WebKitGTK/webkit-1.8/LayoutTests
Merge 113981 - [GTK] Migrate Skipped tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83768
Reviewed by Martin Robinson.
This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.
- platform/gtk/Skipped: Removed.
- platform/gtk/test_expectations.txt:
Conflicts:
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/gtk/test_expectations.txt
- 6:43 AM Changeset in webkit [116885] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 114332 - [GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112
Rubber-stamped by Martin Robinson.
- gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball
- 6:43 AM Changeset in webkit [116884] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 114312 - [GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086
Unreviewed build fix.
- gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.
- 6:42 AM Changeset in webkit [116883] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 114308 - [GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085
Rubber-stamped by Martin Robinson.
- gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
includes a phony clean target that should make warnings and errors go
away.
- 6:42 AM Changeset in webkit [116882] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8
Merge 114297 - [GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060
Rubber-stamped by Martin Robinson.
.:
- configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we
already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.
Tools:
- gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
to their GNOME 3.4 versions.
- gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
is applied upstream.
Conflicts:
Tools/gtk/jhbuild.modules
- 6:42 AM Changeset in webkit [116881] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 113066 - [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82473
Reviewed by Philippe Normand.
Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.
- gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
- 6:42 AM Changeset in webkit [116880] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112309 - [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
https://bugs.webkit.org/show_bug.cgi?id=82252
Reviewed by Gustavo Noronha Silva.
Appending the directory containing common.py may be problematic if
another path in sys.path also contains either a common.py or a
common/ module, so prepend to select our version instead. This is
the case with fail2ban, which has a common/ directory which may
end up being in Python's default path.
- efl/jhbuildrc:
- gtk/jhbuildrc:
- 6:41 AM Changeset in webkit [116879] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112294 - [GTK] Build gnutls without p11-kit support
https://bugs.webkit.org/show_bug.cgi?id=82212
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
configure, to avoid requiring that dependency, which is not used
by libsoup and WebKit anyway
- 6:41 AM Changeset in webkit [116878] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112153 - [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
https://bugs.webkit.org/show_bug.cgi?id=82209
Reviewed by Martin Robinson.
Respecting the $MAKE environment variable when it is defined makes
building jhbuild more portable, as some platforms may have GNU
make as gmake, for example.
- jhbuild/jhbuild-wrapper:
(install_jhbuild):
- 6:41 AM Changeset in webkit [116877] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112139 - [jhbuild] Revert $MAKE environment hack introduced in r101929.
https://bugs.webkit.org/show_bug.cgi?id=82234
Reviewed by Martin Robinson.
The problem it was supposedly fixing was fixed in jhbuild itself
in git revision da8944d8ca987ca48c91b350257a530050406092, so we
can remove the workaround added to the script.
- jhbuild/jhbuild-wrapper:
(install_jhbuild):
- 6:41 AM Changeset in webkit [116876] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112101 - [jhbuild] Explicitly disable DTrace when building glib.
https://bugs.webkit.org/show_bug.cgi?id=82145
Reviewed by Gustavo Noronha Silva.
DTrace support is not really needed by WebKit, so disabling it
helps avoid some build errors on more exotic platforms (such as
FreeBSD).
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
- 6:40 AM Changeset in webkit [116875] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 111929 - [GTK] libgcrypt and p11-kit should not be in jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82073
Reviewed by Martin Robinson.
- Scripts/webkitdirs.pm:
(jhbuildConfigurationChanged): new function that isolates the
jhbuild configuration change checking from the autogen logic.
(mustReRunAutogen): code for the new function lived here.
(buildAutotoolsProject): now calls jhbuildConfigurationChanged
itself, and cleans up the jhbuild root if configuration has
changed; it also forces autogen to be run in that case, to
make sure the new libraries are used.
- gtk/jhbuild.modules: removed libgcrypt and p11-kit.
- jhbuild/jhbuild-wrapper:
(ensure_jhbuild): this might be run inside a jhbuild environment,
in which case aclocal fails when trying to use the now deleted
aclocal directory in the jhbuild prefix, so work around that.
- 6:40 AM Changeset in webkit [116874] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 111668 - [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
https://bugs.webkit.org/show_bug.cgi?id=81888
Reviewed by Philippe Normand.
- Scripts/update-webkit-libs-jhbuild:
(runJhbuild): Helper function to run jhbuild with a given command.
Instead of running jhbuild directly, use the jhbuild-wrapper, so
that we don't need to run it first to check whether jhbuild is
installed or not.
- efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
- gtk/run-with-jhbuild: Ditto.
- jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
not only run.
- 6:40 AM Changeset in webkit [116873] by
-
- 2 edits6 adds in releases/WebKitGTK/webkit-1.8/Tools
Merge 111115 - [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
https://bugs.webkit.org/show_bug.cgi?id=79904
build-webkit --efl will use jhbuild for fetching and building dependencies.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.
- Scripts/update-webkitefl-libs: Added.
- Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
- efl/common.py: Added.
(script_path):
(top_level_path):
(number_of_cpus):
- efl/jhbuild.modules: Added.
- efl/jhbuildrc: Added.
- efl/run-with-jhbuild: Added.
- 6:40 AM Changeset in webkit [116872] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 111175 - jhbuild: Call jhbuild's autogen.sh via bash.
https://bugs.webkit.org/show_bug.cgi?id=81485
Reviewed by Philippe Normand.
jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.
- jhbuild/jhbuild-wrapper:
(install_jhbuild):
- 6:39 AM Changeset in webkit [116871] by
-
- 3 edits2 copies1 add in releases/WebKitGTK/webkit-1.8/Tools
Merge 110846 - Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
https://bugs.webkit.org/show_bug.cgi?id=79673
Preparatory work for bringing jhbuild enabled build to EFL port.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.
- Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
- Scripts/update-webkitgtk-libs:
- gtk/run-with-jhbuild:
- jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):
- 6:39 AM Changeset in webkit [116870] by
-
- 2 edits3 adds in releases/WebKitGTK/webkit-1.8/Tools
Merge 111749 - [GTK] Add make to the jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=81769
Reviewed by Martin Robinson.
Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
Add GNU make with custom patches to fix several issues:
- make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to fix the argument list limit of GNU make when running make distcheck.
- make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski and Jeremy Devenport to fix parallel build issues present in GNU make 3.82
- gtk/jhbuild.modules: Added make with patches.
- gtk/patches/make-3.82-arg-list-length.patch: Added.
- gtk/patches/make-3.82-parallel-build.patch: Added.
- 6:39 AM Changeset in webkit [116869] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112672 - [GTK] Disable introspection build in the at-spi2-core module.
https://bugs.webkit.org/show_bug.cgi?id=82729
Patch by Vineet Chaudhary <Vineet> on 2012-03-30
Reviewed by Philippe Normand.
This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
- gtk/jhbuild.modules: Disable introspection.
- 6:39 AM Changeset in webkit [116868] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Tools
Merge 112392 - [GTK] Disable introspection for jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82395
Reviewed by Philippe Normand.
- efl/jhbuild.modules: add --disable-introspection to all modules
that support it
- gtk/jhbuild.modules: ditto.
Conflicts:
Tools/efl/jhbuild.modules
- 6:38 AM Changeset in webkit [116867] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/ChangeLog
Merge 111607 - Unreviewed, GTK gardening after r111601.
- platform/gtk/svg/custom/delete-text-crash-expected.txt: Removed.
- 6:38 AM Changeset in webkit [116866] by
-
- 5 edits3 adds in releases/WebKitGTK/webkit-1.8
Merge 110593 - Fix the use of stale text fragments
https://bugs.webkit.org/show_bug.cgi?id=80729
Patch by Philip Rogers <pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.
Test: svg/custom/delete-text-crash.html
- rendering/InlineBox.h:
(InlineBox):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):
- rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):
LayoutTests:
- svg/custom/delete-text-crash-expected.png: Added.
- svg/custom/delete-text-crash-expected.txt: Added.
- svg/custom/delete-text-crash.html: Added.
