Timeline
May 16, 2012:
- 11:54 PM Changeset in webkit [117405] by
-
- 2 edits in trunk/LayoutTests
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
- platform/qt/Skipped: Skip failing tests after r117288.
- 11:53 PM Changeset in webkit [117404] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r117372.
http://trac.webkit.org/changeset/117372
https://bugs.webkit.org/show_bug.cgi?id=86710
"triggerring crashes" (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
Source/WebCore:
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
- Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::context):
(WebCore::AudioParam::hasSampleAccurateValues):
(WebCore::AudioParam::AudioParam):
(AudioParam):
LayoutTests:
- webaudio/audioparam-connect-audioratesignal.html:
- webaudio/audioparam-summingjunction-expected.txt: Removed.
- webaudio/audioparam-summingjunction.html: Removed.
- 11:40 PM Changeset in webkit [117403] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening after r117373.
- platform/gtk/fast/forms/input-align-image-expected.txt:
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- 11:36 PM Changeset in webkit [117402] by
-
- 6 edits2 deletes in trunk/Source/WebKit/chromium
Unreviewed, rolling out r117396.
http://trac.webkit.org/changeset/117396
https://bugs.webkit.org/show_bug.cgi?id=86709
"breaks chromium tree" (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
- WebKit.gyp:
- public/WebTextInputInfo.h: Removed.
- public/WebTextInputType.h:
- public/WebWidget.h:
(WebKit::WebWidget::textInputType):
- src/WebTextInputInfo.cpp: Removed.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
- src/WebViewImpl.h:
(WebViewImpl):
- 11:22 PM Changeset in webkit [117401] by
-
- 2 edits in trunk/LayoutTests
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
- platform/qt/Skipped: Skip failing tests after r117288.
- 11:20 PM Changeset in webkit [117400] by
-
- 2 edits6 moves3 adds2 deletes in trunk/LayoutTests
Unreviewed expectations update.
- fast/repaint/float-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.png.
- fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
- fast/repaint/float-overflow-right-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.png.
- fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
- platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Added.
- platform/chromium-mac/fast/repaint/float-overflow-expected.png: Added.
- platform/chromium-mac/fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-expected.txt.
- platform/chromium-mac/fast/repaint/float-overflow-right-expected.png: Added.
- platform/chromium-mac/fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/gtk/fast/repaint/float-overflow-right-expected.txt.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/repaint/float-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/float-overflow-right-expected.png: Removed.
- 11:17 PM Changeset in webkit [117399] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Restore accidentally changed copyrights.
https://bugs.webkit.org/show_bug.cgi?id=86471
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-16
Reviewed by Antonio Gomes.
Restore accidentally changed copyrights.
- ewk/ewk_js_private.h:
- ewk/ewk_security_origin_private.h:
- ewk/ewk_view_private.h:
- 10:18 PM Changeset in webkit [117398] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Get text direction at the start and end of selection.
https://bugs.webkit.org/show_bug.cgi?id=86573
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-16
Reviewed by Adam Barth.
Add an interface to get text direction at the start and end of
selection for Android, as on Android different selection delimiters
are needed for RTL text. Unlike other platforms, the start and end
delimiters of selection are different, so we need determine the shape
of delimiter based on text direction.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::selectionTextDirection):
- src/WebViewImpl.cpp:
(WebKit):
(WebKit::WebViewImpl::selectionTextDirection):
- src/WebViewImpl.h:
(WebViewImpl):
- 10:16 PM Changeset in webkit [117397] by
-
- 4 edits in trunk
[Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
https://bugs.webkit.org/show_bug.cgi?id=86696
Reviewed by Ryosuke Niwa.
We want to add some description for each PerfTestRunner.run and
PerfTestRunner.runPerSecond, so that people can know what each
run is testing.
Output example:
$ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
Running Bindings/first-child.html (1 of 1)
DESCRIPTION: Benchmark for DOM attributes that return a Node object.
RESULT Bindings: first-child= 788.359076534 runs/s
median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s
PerformanceTests:
- resources/runner.js:
(PerfTestRunner.logStatistics):
(PerfTestRunner.printStatistics):
(PerfTestRunner.runPerSecond):
Tools:
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output):
(PerfTest.output_statistics):
- 10:03 PM Changeset in webkit [117396] by
-
- 6 edits1 copy1 add in trunk/Source/WebKit/chromium
[Chromium] Implement WebViewImpl::textInputInfo() for Android
https://bugs.webkit.org/show_bug.cgi?id=86440
Reviewed by Darin Fisher.
This patch adds WebView::textInputInfo(), which describes the text
input that currently has focus. Android is planning to use this to
determine what sort of keyboard or text entry UI to show. This API
subsumes the textInputType() API, which will be removed once the
clients have been updated.
- WebKit.gyp:
- public/WebTextInputInfo.h: Added.
(WebKit):
(WebTextInputInfo):
(WebKit::WebTextInputInfo::WebTextInputInfo):
(WebKit::operator==):
(WebKit::operator!=):
- public/WebTextInputType.h:
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::textInputInfo):
(WebKit::WebWidget::textInputType):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo):
(WebKit):
(WebKit::WebViewImpl::textInputType):
- src/WebViewImpl.h:
(WebViewImpl):
- 9:53 PM Changeset in webkit [117395] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix bug number for video-controls-drag.html in the test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86607
Unreviewed EFL gardening.
Change BUGWK number to point to right patch.
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
- platform/efl/test_expectations.txt:
- 9:37 PM Changeset in webkit [117394] by
-
- 15 edits2 adds in trunk
Implement a Shadow DOM spec's section 6 'Events'.
https://bugs.webkit.org/show_bug.cgi?id=78586
Reviewed by Dimitri Glazkov.
Source/WebCore:
This implements a Shadow DOM spec's section 6 'Events', introducing a new
algorithm so that event dispatching use a composed shadow DOM tree,
instead of normal DOM tree, in dispatching events to each node.
The spec is here: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events
Summary of changes:
- Attaching shadow DOM does not affect an event dispatching
behavior of enclosing DOM tree. This applies even if some nodes
are distributed to insertion points. We keep a compatibility of
existing event dispatching mechanism so that we won't break Web.
- Event ancestors, which are used in dispatching events in capture (or
bubble) phase, are now the result of traversing ancestors in composed
shadow DOM tree order, instead of normal DOM tree order.
- Event's target and related-target are correctly adjusted so that
we don't leak any node which is inaccessible from the event's
current-target node. We enforce both upper and lower boundary
encapsulation of Shadow DOM in event dispatching
Here is an example of event dispatching. Suppose we have the following DOM tree, which
includes some nested shadow hosts and insertion points
A
`--B-----[SR-B]
C `--G--------------[SR-G] | `-D<H select=C>J---------------[SR-J] -E-<I select=E> |-<K select=H>-<N select=K>
`-F |
`--L---------------[SR-L]
-<M select=I>-<O select=M>
Notation: [SR-X]: Shadow Root
<X select=Y>: Insertion Point, called X, which selects Y.
If a mouse moves from node '#F' to node '#D', the following
'mouseover' events are dispatched in each ancestor node:
[currentTarget] [target] [related-target]
#D #D #F
#C #D #F
#H #H #I
#K #K #M
#N #N #M
#SR-J #N #M
#J #K #M
#SR-G #K #M
#G #H #I
#SR-B #H #I
#B #D #F
#A #D #F
Details are:
- Insertion points, such as <content> or <shadow>, are resolved correctly
in calculating event ancestors. That means if a node is distributed to
an insertion point, the insertion point is now an ancestor of the node in
bubbling (or capturing) events.
- Both insertion points and shadow roots now can receive events. We can add
event listeners to insertion points and shadow roots.
- Dispatched event's target is now adjusted correctly using the re-targeting
algorithm. The algorithm is now fully aware of insertion points.
- Dispatched event's related-target can now differ in each tree scope of
event ancestors. We choose the most appropriate related-target using the
related target resolution algorithm for each node.
Performance consideration:
This patch can achieve the competitive performance. The results of
./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html for
before/after this patch are:
Before applying this patch:
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 270.310714286 ms
median= 269.75 ms, stdev= 2.0042397663 ms, min= 267.357142857 ms, max= 276.5 ms
After applying this patch:
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 268.108333333 ms
median= 267.5 ms, stdev= 2.41883157195 ms, min= 263.625 ms, max= 273.142857143 ms
I've also conducted a micro benchmark using both
Shadow-Free-DOM-Tree and DOM-Tree-With-Shadow-Host.
See https://bugs.webkit.org/show_bug.cgi?id=78586#c40 for the results.
It seems that the new implementation has more capabilities, but
doesn't sacrifice a performance of event dispatching in either cases.
Test: fast/dom/shadow/shadow-dom-event-dispatching.html
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):
- dom/ComposedShadowTreeWalker.h:
(ComposedShadowTreeWalker):
- dom/EventContext.cpp:
(WebCore::EventContext::EventContext):
(WebCore::EventContext::handleLocalEvents):
- dom/EventContext.h:
(EventContext):
(WebCore::EventContext::relatedTarget):
(WebCore):
(WebCore::EventContext::setRelatedTarget):
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::EventRelatedTargetAdjuster):
(WebCore):
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventRelatedTargetAdjuster::findRelatedTarget):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::determineDispatchBehavior):
- dom/EventDispatcher.h:
(WebCore):
(EventRelatedTargetAdjuster):
(EventDispatcher):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.h:
(WebCore::toMouseEvent):
(WebCore):
LayoutTests:
- fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching.html: Added.
- platform/efl/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 9:28 PM Changeset in webkit [117393] by
-
- 1 edit3 copies4 adds in branches/chromium/1132/LayoutTests/platform
Merge 116725 - [chromium] Rebaseline compositing/geometry/horizontal-scroll-composited.html after r107389
Unreviewed test expectations update.
- platform/chromium-linux-x86/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-win-xp/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
TBR=noel.gordon@gmail.com
Review URL: https://chromiumcodereview.appspot.com/10388180
- 9:09 PM Changeset in webkit [117392] by
-
- 4 edits2 adds in trunk
Moving caret up or down skips lines when there's a non-editable line
https://bugs.webkit.org/show_bug.cgi?id=81490
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition
skipping leaf nodes that constitute a new line and belong to the same editable region because block elements
that separate lines are not editable so it looked as if all editable lines belong to a single line as far as
those two functions are concerned.
Fixed the bug by using the first leaf node that belongs to the same editable region but does not belong in
the same as the start node.
This patch is based on a patch authored by Yi Shen (Nokia).
Test: editing/selection/move-between-lines-of-different-editabilities.html
- editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
LayoutTests:
Added a regression test.
- editing/selection/move-between-lines-of-different-editabilities.html: Added.
- editing/selection/move-by-word-visually-mac-expected.txt: Rebaselined a test case. It failed
before this change and still fails after this change.
- 8:58 PM Changeset in webkit [117391] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix Mac SL build.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- 8:55 PM Changeset in webkit [117390] by
-
- 6 edits31 adds in trunk/LayoutTests
Add tests for CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=86575
Reviewed by Dimitri Glazkov.
- fast/css/variables/colors-test-expected.html: Added.
- fast/css/variables/colors-test.html: Added.
- fast/css/variables/complex-cycle-expected.html: Added.
- fast/css/variables/complex-cycle.html: Added.
- fast/css/variables/computed-style-expected.html: Added.
- fast/css/variables/computed-style.html: Added.
- fast/css/variables/inherited-values-expected.html: Added.
- fast/css/variables/inherited-values.html: Added.
- fast/css/variables/inline-styles-expected.html: Added.
- fast/css/variables/inline-styles.html: Added.
- fast/css/variables/invalid-shorthand-expected.html: Added.
- fast/css/variables/invalid-shorthand.html: Added.
- fast/css/variables/invalid-variable-value-expected.html: Added.
- fast/css/variables/invalid-variable-value.html: Added.
- fast/css/variables/multi-level-cycle-expected.html: Added.
- fast/css/variables/multi-level-cycle.html: Added.
- fast/css/variables/redefinition-expected.html: Added.
- fast/css/variables/redefinition.html: Added.
- fast/css/variables/shorthand-expected.html: Added.
- fast/css/variables/shorthand.html: Added.
- fast/css/variables/simple-cycle-expected.html: Added.
- fast/css/variables/simple-cycle.html: Added.
- fast/css/variables/undefined-expected.html: Added.
- fast/css/variables/undefined.html: Added.
- fast/css/variables/use-before-defined-expected.html: Added.
- fast/css/variables/use-before-defined.html: Added.
- fast/css/variables/var-inside-shorthand-expected.html: Added.
- fast/css/variables/var-inside-shorthand.html: Added.
- fast/css/variables/variable-chain-expected.html: Added.
- fast/css/variables/variable-chain.html: Added.
- platform/chromium/test_expectations.txt: Skip tests until variables implementation lands.
- platform/efl/test_expectations.txt: Skip tests until variables implementation lands.
- platform/gtk/test_expectations.txt: Skip tests until variables implementation lands.
- platform/mac/test_expectations.txt: Skip tests until variables implementation lands.
- platform/qt/test_expectations.txt: Skip tests until variables implementation lands.
- 8:52 PM Changeset in webkit [117389] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking failing test.
- platform/chromium/test_expectations.txt:
- 8:37 PM Changeset in webkit [117388] by
-
- 3 edits in trunk/Source/WebCore
Use pixelSnappedLogicalHeight for TableSection layout
https://bugs.webkit.org/show_bug.cgi?id=86665
Reviewed by Eric Seidel.
We do table layout using integers to ensure we follow the spec (see
https://trac.webkit.org/wiki/LayoutUnit for details), but were previously
flooring the logical height used in layoutRows. This caused us to mis-
calculate the intrinsic padding and grow cells beyond their proper height.
No new tests. Fully covered by existing tests with sub-pixel enabled.
- rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedLogicalHeight): Added these convenience
methods.
(WebCore::RenderBox::pixelSnappedLogicalWidth):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- 8:35 PM Changeset in webkit [117387] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking failing test.
- platform/chromium/test_expectations.txt:
- 8:24 PM Changeset in webkit [117386] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking cross-fade-background-image.html as failing.
- platform/chromium/test_expectations.txt:
- 8:19 PM Changeset in webkit [117385] by
-
- 65 edits in trunk
rename display:-webkit-flexbox to display:-webkit-flex
https://bugs.webkit.org/show_bug.cgi?id=86529
Reviewed by Eric Seidel.
Source/WebCore:
Also renames -webkit-inline-flexbox to -webkit-inline-flex.
No new tests. Covered by existing tests.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in: Update keyword values.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/RenderObject.h:
(RenderObject):
- rendering/style/RenderStyleConstants.h: Rename const values.
LayoutTests:
- css3/flexbox/anonymous-block-merge-crash.html:
- css3/flexbox/anonymous-block.html:
- css3/flexbox/auto-height-dynamic.html:
- css3/flexbox/child-overflow.html:
- css3/flexbox/columns-auto-size.html:
- css3/flexbox/cross-axis-scrollbar.html:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/flexbox/display-flexbox-set-get-expected.txt:
- css3/flexbox/display-flexbox-set-get.html:
- css3/flexbox/flex-algorithm-min-max.html:
- css3/flexbox/flex-algorithm-with-margins.html:
- css3/flexbox/flex-algorithm.html:
- css3/flexbox/flex-align-baseline.html:
- css3/flexbox/flex-align-column.html:
- css3/flexbox/flex-align-end.html:
- css3/flexbox/flex-align-max.html:
- css3/flexbox/flex-align-percent-height.html:
- css3/flexbox/flex-align-stretch.html:
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- css3/flexbox/flex-flow-border.html:
- css3/flexbox/flex-flow-margins-auto-size.html:
- css3/flexbox/flex-flow-margins.html:
- css3/flexbox/flex-flow-orientations.html:
- css3/flexbox/flex-flow-overflow.html:
- css3/flexbox/flex-flow-padding.html:
- css3/flexbox/flex-flow.html:
- css3/flexbox/flex-item-child-overflow.html:
- css3/flexbox/flex-no-flex.html:
- css3/flexbox/flex-order.html:
- css3/flexbox/flex-pack.html:
- css3/flexbox/flexbox-overflow-auto-expected.html:
- css3/flexbox/flexbox-overflow-auto.html:
- css3/flexbox/floated-flexbox.html:
- css3/flexbox/insert-text-crash.html:
- css3/flexbox/line-wrapping.html:
- css3/flexbox/multiline-align.html:
- css3/flexbox/multiline-column-auto.html:
- css3/flexbox/multiline-line-pack-horizontal-column.html:
- css3/flexbox/multiline-line-pack.html:
- css3/flexbox/multiline-pack.html:
- css3/flexbox/multiline-reverse-wrap-baseline.html:
- css3/flexbox/multiline-reverse-wrap-overflow.html:
- css3/flexbox/multiline-shrink-to-fit.html:
- css3/flexbox/multiline.html:
- css3/flexbox/nested-stretch.html:
- css3/flexbox/orthogonal-flex-directions.html:
- css3/flexbox/position-absolute-child.html:
- css3/flexbox/preferred-widths-orthogonal.html:
- css3/flexbox/preferred-widths.html:
- css3/flexbox/repaint-rtl-column.html:
- css3/flexbox/repaint.html:
- css3/flexbox/true-centering.html:
- css3/flexbox/writing-modes.html:
- 8:17 PM Changeset in webkit [117384] by
-
- 18 edits4 copies8 adds in trunk
IDL and implementation for Web Intents delivery
https://bugs.webkit.org/show_bug.cgi?id=83634
Patch by Greg Billock <gbillock@google.com> on 2012-05-16
Reviewed by Adam Barth.
Source/WebCore:
The delivered intent has some extra fields and methods (extras,
postResult, postFailure) from the invocation intent. It is implemented
as a subclass. Responses from the service JS are passed to an embedder
client object provided when the intent is delivered.
See http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
Test: webintents/web-intents-delivery.html
- Modules/intents/DOMWindowIntents.cpp: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.
(WebCore):
(WebCore::DOMWindowIntents::DOMWindowIntents):
(WebCore::DOMWindowIntents::~DOMWindowIntents):
(WebCore::DOMWindowIntents::from):
(WebCore::DOMWindowIntents::webkitIntent):
(WebCore::DOMWindowIntents::deliver):
- Modules/intents/DOMWindowIntents.h: Copied from Source/WebCore/Modules/intents/DOMWindowIntents.idl.
(WebCore):
(DOMWindowIntents):
- Modules/intents/DOMWindowIntents.idl:
- Modules/intents/DeliveredIntent.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(WebCore::DeliveredIntent::create):
(WebCore::DeliveredIntent::DeliveredIntent):
(WebCore::DeliveredIntent::ports):
(WebCore::DeliveredIntent::getExtra):
(WebCore::DeliveredIntent::postResult):
(WebCore::DeliveredIntent::postFailure):
- Modules/intents/DeliveredIntent.h: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(DeliveredIntent):
(WebCore::DeliveredIntent::~DeliveredIntent):
- Modules/intents/DeliveredIntent.idl: Copied from Source/WebCore/Modules/intents/Intent.h.
- Modules/intents/Intent.h:
(WebCore::Intent::~Intent):
(Intent):
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/v8/custom/V8DeliveredIntentCustom.cpp: Copied from Source/WebCore/Modules/intents/Intent.h.
(WebCore):
(WebCore::V8DeliveredIntent::portsAccessorGetter):
Source/WebKit/chromium:
The embedder will implement the WebDeliveredIntentClient interface, which
will get notifications of postResult/postFailure from the service page.
- public/WebDeliveredIntentClient.h:
- public/WebFrame.h:
(WebKit):
(WebFrame):
- src/WebDeliveredIntentClient.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::deliverIntent):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 8:14 PM Changeset in webkit [117383] by
-
- 13 edits in trunk/Source/WebCore
[V8][Refactoring] Replace throwError("message", XXXError)
with throwError(XXXError, "message")
https://bugs.webkit.org/show_bug.cgi?id=86579
Reviewed by Adam Barth.
This is one of a series of refactoring commented in
https://bugs.webkit.org/show_bug.cgi?id=84074#c5
Currently there are two equivalent throwError()s; i.e. throwError("message", XXXError)
and throwError(XXXError, "message"). In this bug we replace
throwError("message", XXXError) with throwError(XXXError, "message")
(except for the case where XXXError == TypeError. This is because
throwError("message", TypeError) will be replaced with throwTypeError("message")
in a follow-up patch).
No tests. No change in behavior.
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectPropertyEnumerator):
- bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
- bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
- 7:59 PM Changeset in webkit [117382] by
-
- 2 edits in trunk/Tools
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
- 7:21 PM Changeset in webkit [117381] by
-
- 3 edits in trunk/Source/WebCore
[V8] Pass Isolate to remaining toV8()
https://bugs.webkit.org/show_bug.cgi?id=86570
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to toV8(). I've landed a bunch of
patches to pass Isolate to toV8(), and this would be the last
patch for passing Isolate to toV8().
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- 7:18 PM Changeset in webkit [117380] by
-
- 2 edits in trunk/Tools
Add new build slave for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=86567
Reviewed by Ryosuke Niwa.
Add a build slave for EFL 32-bit linux build.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 7:18 PM Changeset in webkit [117379] by
-
- 13 edits in trunk/Source
GraphicsContext3D interface should not be aware of CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=86550
Reviewed by Darin Adler.
Source/WebCore:
GraphicsContext3D is a WebCore/platform API construct. CanvasRenderingContext is a WebCore/html concept. Thus,
the former shouldn't depend on the latter. In turns out that all everyone ever wants from a
CanvasRenderingContext in GraphicsContext3D is its underlying ImageBuffer, which is a WebCore/platform concept,
so this just updates the APIs and implementations to use that instead.
Refactor only, no new tests.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
- platform/graphics/gpu/DrawingBuffer.h:
- platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
Source/WebKit/chromium:
Updates chromium implementation of GraphicsContext3D for API change and removes a bunch of unnecessary
#includes.
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- 7:09 PM Changeset in webkit [117378] by
-
- 9 edits in trunk
[EFL] Support for Battery Status API on the WebKit-Efl
https://bugs.webkit.org/show_bug.cgi?id=83254
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
Reviewed by Chang Shu.
.:
Add dependency check for e_ukit package which is in the e_dbus library.
- Source/cmake/FindEFL.cmake:
Source/WebKit:
Add e_ukit library and include directory to get battery status of device.
- PlatformEfl.cmake:
Source/WebKit/efl:
The set of e_dbus libraries, e_ukit library in particular, enables to support all types of battery status events (e.g., charging, chargingTime, dischargingTime, level).
- WebCoreSupport/BatteryClientEfl.cpp:
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):
- WebCoreSupport/BatteryClientEfl.h:
(WebCore::BatteryClientEfl::batteryStatus):
(BatteryClientEfl):
Tools:
Add e_dbus libraries to jhbuild's modules list.
- efl/jhbuild.modules:
- 6:36 PM Changeset in webkit [117377] by
-
- 7 edits in trunk/Source/WebCore
SerializedScriptValue: lazy initialization of static nullValue not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=70833
Reviewed by Kentaro Hara.
Remove unsafe lazy initialization of static |null| SSV. None of the callers
appeared to be in performance-critical areas - most were preparing an event to
be dispatched to script - so no per-call-site caching was added.
No new tests - no functional changes.
- bindings/js/SerializedScriptValue.cpp: Mint a new one each time.
(WebCore::SerializedScriptValue::nullValue):
- bindings/js/SerializedScriptValue.h: Return via PassRefPtr.
- bindings/v8/SerializedScriptValue.cpp: Mint a new one each time.
(WebCore::SerializedScriptValue::nullValue):
- bindings/v8/SerializedScriptValue.h: Return via PassRefPtr.
(SerializedScriptValue):
- dom/Document.cpp:
(WebCore::Document::statePopped): Change to PassRefPtr to maintain refcount.
- dom/Document.h:
(Document):
- 6:31 PM Changeset in webkit [117376] by
-
- 3 edits in trunk/Source/WebCore
CachedImage does not clear the ImageObserver pointer when dropping its Image ref
https://bugs.webkit.org/show_bug.cgi?id=86689
Reviewed by Eric Seidel.
Image instances keep a weak pointer to their ImageObserver, which may be null. CachedImage is an ImageObserver
and holds a RefPtr<Image> m_image. When CachedImage initializes its m_image to either an SVGImage or BitmapImage,
it sets itself as that Image's ImageObserver. However, CachedImage never clears the ImageObserver pointer, even
when dropping its reference to the Image. This means if other code holds a RefPtr<Image> there is no promise
that calls on that Image will be valid. This patch clears the CachedImage::m_image's ImageObserver pointer
whenever the CachedImage drops its reference. Image already has null checks for its m_imageObserver so this is
always a safe operation.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::~CachedImage):
(WebCore::CachedImage::clear):
- 6:28 PM Changeset in webkit [117375] by
-
- 2 edits in trunk/Source/WebCore
[V8] Fix a broken copyright of V8SVGElementCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=86569
Reviewed by Nate Chapin.
This patch just fixes a broken copyright of V8SVGElementCustom.cpp.
Blame changeset: r54153
No tests. No change in behavior.
- bindings/v8/custom/V8SVGElementCustom.cpp:
- 6:19 PM Changeset in webkit [117374] by
-
- 4 edits in trunk/Source/WebCore
[V8] Pass Isolate to convertEventTargetToV8Object()
https://bugs.webkit.org/show_bug.cgi?id=86566
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to convertEventTargetToV8Object().
I made the 'isolate' argument optional, since
convertEventTargetToV8Object() can be called from the WebCore context.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(NativeToJSValue):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):
- 6:17 PM Changeset in webkit [117373] by
-
- 2 edits in trunk/Source/WebCore
Correctly display malformed GIFs which specify bogus extension block
sizes.
https://bugs.webkit.org/show_bug.cgi?id=86531
Reviewed by James Robinson.
This was broken by r117333, which was an attempt to avoid memory errors
on GIFs that were malformed in a similar way. It turns out some GIFs
in the wild (i.e. "our LayoutTests directory") relied on some of the
effects of the old code. This refixes in a way that doesn't break
these.
No new tests, covered by existing tests.
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
- 6:14 PM Changeset in webkit [117372] by
-
- 5 edits2 adds in trunk
AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/audioparam-summingjunction.html
- Modules/webaudio/AudioParam.cpp:
- Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
Sums intrinsic parameter value with all audio-rate connections.
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
Support multiple connections.
(WebCore::AudioParam::hasSampleAccurateValues):
If we have one or more audio-rate connections.
(WebCore::AudioParam::AudioParam):
AudioParam now sub-classes AudioSummingJunction.
LayoutTests:
- webaudio/audioparam-connect-audioratesignal.html:
- webaudio/audioparam-summingjunction-expected.txt: Added.
- webaudio/audioparam-summingjunction.html: Added.
- 5:46 PM Changeset in webkit [117371] by
-
- 4 edits in trunk/Source/WebCore
[V8] Pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper()
https://bugs.webkit.org/show_bug.cgi?id=86558
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to createV8HTMLWrapper() and createV8SVGWrapper().
Basically 'isolate' has been implemented as the last argument
but before 'forceNewObject' argument, because 'forceNewObject' is an optional
argument and omitted in most cases. Due to the convention,
this patch puts 'isolate' before 'forceNewObject'.
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
- 5:42 PM Changeset in webkit [117370] by
-
- 6 edits in branches/dfgopt/Source/JavaScriptCore
DFG should have sparse conditional constant propagation
https://bugs.webkit.org/show_bug.cgi?id=86580
Reviewed by Oliver Hunt.
This enhances CFA so that if it suspects at any point during the fixpoint that a
branch will only go one way, then it only propagates in that one way.
This vastly increases the opportunities for CFG simplification. For example, it
enables us to evaporate this loop:
for (var i = 0; i < 1; ++i) doThings(i);
As a result, it uncovered loads of bugs in the CFG simplifier. In particular:
- Phi fixup was assuming that all Phis worth fixing up are shouldGenerate(). That's not true; we also fixup Phis that are dead.
- GetLocal fixup was assuming that it's only necessary to rewire links to a GetLocal, and that the GetLocal's own links don't need to be rewired. Untrue, because the GetLocal may not be rewirable (first block has no GetLocal for r42 but second block does have a GetLocal), in which case it will refer to a Phi in the second block. We need it to refer to a Phi from the first block to ensure that subsequent transformations work.
- Tail operand fixup was ignoring the fact that Phis in successors may contain references to the children of our tail variables. Hence, successor Phi child substitution needs to use the original second block variable table as its prior, rather than trying to reconstruct the prior later (since by that point the children of the second block's tail variables will have been fixed up, so we will not know what the prior would have been).
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::branchDirectionToString):
(AbstractState):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::recordPossibleIncomingReference):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::changeEdge):
- 5:30 PM Changeset in webkit [117369] by
-
- 11 edits1 delete in trunk/Source/WebCore
Move showStyle from CSSStyleDeclaration to StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=86675
Reviewed by Andreas Kling.
Moved the function. Also deleted CSSStyleDeclaration.cpp since it's no longer needed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSStyleDeclaration.cpp:
(WebCore):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore):
(WebCore::StylePropertySet::showStyle):
- css/StylePropertySet.h:
(StylePropertySet):
- 5:28 PM Changeset in webkit [117368] by
-
- 4 edits in trunk/Source/WebCore
Fix the indexed database build for GTK+.
- GNUmakefile.list.am: Add missing files to the build.
- bindings/gobject/GNUmakefile.am: Be smarter about filtering out deactivating indexed database.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Always skip attributes that return indexed database types.
- 5:19 PM Changeset in webkit [117367] by
-
- 12 edits32 adds4 deletes in trunk/LayoutTests
Unreviewed gardening after r117339 (table baseline computation change).
- fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323: Removed.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Removed.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Removed.
- platform/chromium-linux/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-mac-leopard/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-mac-leopard/editing/selection/iframe-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/selection/iframe-expected.png:
- platform/chromium-mac/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/inline-table-001-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/inline-table-002a-expected.txt: Added.
- platform/chromium-mac/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-mac/css2.1/20110323/inline-table-003-expected.txt: Added.
- platform/chromium-mac/editing/selection/iframe-expected.png:
- platform/chromium-mac/editing/selection/iframe-expected.txt: Added.
- platform/chromium-mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
- platform/chromium-win-vista/editing/selection: Removed.
- platform/chromium-win-vista/fast/css-generated-content: Added.
- platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Added.
- platform/chromium-win-vista/fast/inline-block: Added.
- platform/chromium-win-vista/fast/inline-block/001-expected.png: Added.
- platform/chromium-win-xp/fast/css-generated-content: Added.
- platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Added.
- platform/chromium-win-xp/fast/inline-block: Added.
- platform/chromium-win-xp/fast/inline-block/001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/inline-table-001-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-win/css2.1/20110323/inline-table-002a-expected.txt: Added.
- platform/chromium-win/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-win/css2.1/20110323/inline-table-003-expected.txt: Added.
- platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.png:
- platform/chromium-win/editing/selection/iframe-expected.png:
- platform/chromium-win/editing/selection/inline-table-expected.png:
- platform/chromium-win/editing/selection/table-caret-3-expected.png:
- platform/chromium-win/fast/css-generated-content/inline-display-types-expected.png:
- platform/chromium-win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
- platform/chromium-win/fast/inline-block/001-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
- platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
- 5:09 PM Changeset in webkit [117366] by
-
- 3 edits6 adds in trunk
Animated GIFs in page cache get updated
https://bugs.webkit.org/show_bug.cgi?id=86668
<rdar://problem/11395549>
Reviewed by Brady Eidson.
Source/WebCore:
Test: fast/loader/image-in-page-cache.html
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): When we are notified by the CachedImage that the image has
changed, we check to see if the document is in the page cache. If so, we should not be updating,
so we bail out early.
LayoutTests:
This test loads pages with subframes that display the same animated gif. When one of
the pages goes into the page cache, we want to make sure that we do not crash as a
side effect of the page's images getting updated.
- fast/loader/image-in-page-cache-expected.txt: Added.
- fast/loader/image-in-page-cache.html: Added.
- fast/loader/resources/animated-image-subframe.html: Added.
- fast/loader/resources/animated-image.html: Added.
- fast/loader/resources/animated-image2.html: Added.
- fast/loader/resources/animated-image3.html: Added.
- 5:07 PM Changeset in webkit [117365] by
-
- 4 edits2 adds in trunk
Crash if SVG gradient stop has display: none set
https://bugs.webkit.org/show_bug.cgi?id=86686
<rdar://problem/10751905>
Reviewed by Dean Jackson.
Source/WebCore:
Create a renderer for SVGStopElement regardless of the "display" property.
This matches the behavior of Opera and the SVG specification.
Test: svg/custom/gradient-stop-display-none-crash.svg
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::rendererIsNeeded):
(WebCore):
- svg/SVGStopElement.h:
(SVGStopElement):
LayoutTests:
Add a test that ensures that we don't crash if "display: none" is set on an SVGStopElement.
- svg/custom/gradient-stop-display-none-crash-expected.txt: Added.
- svg/custom/gradient-stop-display-none-crash.svg: Added.
- 5:00 PM Changeset in webkit [117364] by
-
- 24 edits4 copies in branches/safari-536-branch
Merged r116595.
- 4:42 PM Changeset in webkit [117363] by
-
- 12 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r116069 and r117339.
- platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/inline-table-expected.txt:
- platform/gtk/editing/selection/table-caret-3-expected.txt:
- platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
- platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/gtk/fast/forms/input-align-image-expected.txt:
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/gtk/fast/inline-block/001-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
- 4:35 PM Changeset in webkit [117362] by
-
- 4 edits in trunk/Source
[chromium] Clear the m_private pointer when destroying WebFilterOperations to avoid assert in WebPrivateOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86654
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::~WebFilterOperations):
(WebFilterOperations):
Source/WebCore:
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::reset):
(WebKit::WebFilterOperations::destroy):
(WebKit):
- 4:30 PM Changeset in webkit [117361] by
-
- 2 edits2 adds in trunk
REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
https://bugs.webkit.org/show_bug.cgi?id=86663
Reviewed by Tony Chang.
The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.
Fixed the mismatch.
Test: editing/pasteboard/paste-text-with-style-5.html
- editing/EditingStyle.cpp:
(WebCore::getPropertiesNotIn):
- 4:29 PM Changeset in webkit [117360] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark a test as failing.
https://bugs.webkit.org/show_bug.cgi?id=86683
Unreviewed, expectations update.
- platform/chromium/test_expectations.txt:
- 4:24 PM Changeset in webkit [117359] by
-
- 2 edits in trunk/Source/WebCore
Merge nextRootInlineBox with nextLinePosition
https://bugs.webkit.org/show_bug.cgi?id=81593
Reviewed by Enrica Casucci.
Call previousRootInlineBox and nextRootInlineBox in previousLinePosition and nextLinePosition respectively
to share the code. Moved out the nullity check of startBox and extracted the renderer's node from the former
two, and added editableType to their argument lists to match the interface in both use cases.
Also moved out the code to extract root inline box using RenderedPosition from those two functions and
expanded in call sites since previousLinePosition and nextLinePosition need to return the candidate position
even when the root inline box doesn't exist. To this end, renamed previousRootInlineBox and nextRootInlineBox
to previousRootInlineBoxCandidatePosition and nextRootInlineBoxCandidatePosition respectively.
In addition, got rid of one version of nextLeafWithSameEditability that adjusted node with respect to offset
This variant did:
Node* child = node->childNode(offset);
node = child ? child->nextLeafNode() : node->lastDescendant()->nextLeafNode();
instead of:
node = node->nextLeafNode();
at the beginning of the function. Observe that the former code is logically equivalent to:
Node* child = node->childNode(offset);
node = child ? child : node->lastDescendant();
node = node->nextLeafNode();
Thus, the first two lines of this logically equivalent code is added in nextLinePosition wherein we used to
call the removed variant.
This refactoring with no behavioral change would help us resolving the bug 81490.
- editing/visible_units.cpp:
(WebCore::previousRootInlineBoxCandidatePosition): Renamed from previousRootInlineBox.
(WebCore::nextRootInlineBoxCandidatePosition): Renamed from nextRootInlineBox.
(WebCore::logicallyPreviousBox): Checks the nullity of startBox's renderer and node. Also extracts the root
inline box out of the position per the interface change.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Calls previousRootInlineBoxCandidatePosition.
(WebCore::nextLinePosition): Calls nextRootInlineBoxCandidatePosition.
- 4:06 PM Changeset in webkit [117358] by
-
- 10 edits in branches/chromium/1132
Merge 117335 - layerX/layerY warning should be removed
https://bugs.webkit.org/show_bug.cgi?id=86264
Reviewed by James Robinson.
Source/WebCore:
Covered by: fast/dom/Window/window-xy-properties.html
fast/events/init-events.html
fast/events/mouse-relative-position.html
fast/events/mouseclick-target-and-positioning.html
fast/events/simulated-click-coords.html
jquery/event.html
This change just removes the warning pending proper investigation.
Longer explanation: The layerX/layerY warning was added prematurely
as we didn't assess the web-compatibility potential breakage vs the
maintenance cost. There is also not readily available replacement.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
- dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
- dom/UIEvent.h:
Removed warnDeprecatedLayerXYUsage and all the associated calls.
LayoutTests:
Removed console message about layerX/layerY deprecation.
- fast/dom/Window/window-xy-properties-expected.txt:
- fast/events/init-events-expected.txt:
- fast/events/mouse-relative-position-expected.txt:
- fast/events/mouseclick-target-and-positioning-expected.txt:
- fast/events/simulated-click-coords-expected.txt:
- jquery/event-expected.txt:
- platform/qt/fast/events/mouse-relative-position-expected.txt:
- 3:56 PM Changeset in webkit [117357] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/test_expectations.txt: Unflag tests needing
rebaseline. I'll pull them from the bot ASAP.
- 3:47 PM Changeset in webkit [117356] by
-
- 2 edits4 copies in branches/chromium/1084
Merge 115471 - Infinite backgroundClipRect should not be scrolled.
https://bugs.webkit.org/show_bug.cgi?id=84979
Reviewed by Adrienne Walker.
Source/WebCore:
Test: compositing/iframes/scroll-fixed-transformed-element.html
By accidentally scrolling clipRects that should be considered
"infinite", they were no longer being considered infinite. This
caused a chain of un-intended code paths that caused fixed
position elements to stutter when scrolling in Chromium.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundClipRect):
LayoutTests:
- compositing/iframes/resources/fixed-position-transformed-subframe.html: Added.
- compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
- compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
- compositing/iframes/scroll-fixed-transformed-element.html: Added.
TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392139
- 3:37 PM Changeset in webkit [117355] by
-
- 5 edits1 delete in trunk/Source/WebCore
[chromium] Remove ImageDecoderCG.cpp from platform/image-decoders
https://bugs.webkit.org/show_bug.cgi?id=86346
Reviewed by Adam Barth.
ImageDecoderCG.cpp was added for use in the Chromium port in r70846. Remove the
implementation now that Chromium uses Skia on Mac OSX by default.
No new tests. No change in behavior.
- WebCore.gypi: Remove ImageDecoderCG.cpp from the gyp project.
- platform/graphics/ImageSource.h: Revert the r70846 changes.
- platform/image-decoders/ImageDecoder.cpp: Remove copyReferenceToBitmapData().
(WebCore::ImageFrame::operator=): Return to using copyBitmapData() (as it was)
given the removal of copyReferenceToBitmapData() above.
- platform/image-decoders/ImageDecoder.h:
(ImageFrame): Remove copyReferenceToBitmapData() declaration.
- platform/image-decoders/cg/ImageDecoderCG.cpp: Removed, and it was the only
decoder with a port-specific implementation of copyReferenceToBitmapData().
- 3:27 PM Changeset in webkit [117354] by
-
- 4 edits in trunk/Source/WebCore
Simplify AudioNode ref-counting by removing RefTypeDisabled
https://bugs.webkit.org/show_bug.cgi?id=85681
Patch by Raymond Toy <Raymond Toy> on 2012-05-16
Reviewed by Chris Rogers.
Existing tests should cover these changes.
- Modules/webaudio/AudioNode.cpp: Remove RefTypeDiabled and m_disabledRefCount.
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::enableOutputsIfNecessary): New
(WebCore::AudioNode::ref):
(WebCore::AudioNode::disableOutputsIfNecessary): New
(WebCore::AudioNode::finishDeref):
- Modules/webaudio/AudioNode.h: Remove RefTypeDisabled and m_disabledRefCount.
- Modules/webaudio/AudioNodeInput.cpp: Removed uses of RefTypeDisbled.
(WebCore::AudioNodeInput::disconnect):
(WebCore::AudioNodeInput::disable):
(WebCore::AudioNodeInput::enable):
- 3:25 PM Changeset in webkit [117353] by
-
- 5 edits in trunk/Source/WebCore
Fix perf regression from r116487
https://bugs.webkit.org/show_bug.cgi?id=86680
Reviewed by Ryosuke Niwa.
http://trac.webkit.org/changeset/116487 caused a 6% regression on
Dromaeo's dom-attr test. The issue is that we invalidated NodeList
caches whenever an id/checked/type attribute changed.
First, we don't need to invalidate on checked/type since that only
affects the values return by NodeList items, not the list of items.
Second, we only need to invalidate NodeList caches when an id attribute
changes on a FormControlElement.
Incidentally, we also don't need to invalidate caches for changes
to attributes that don't have an ownerElement.
No new tests. This is strictly a performance improvement.
- dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
- dom/Node.h:
(Node):
- 3:16 PM Changeset in webkit [117352] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] The FCC shows up on an empty input field
https://bugs.webkit.org/show_bug.cgi?id=86657
Patch by Yongxin Dai <yodai@rim.com> on 2012-05-16
Reviewed by Antonio Gomes.
Turn off the caret by sending a caret changed notification with empty caret.
PR #120620
Reviewed Internally by Mike Fenton.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 3:10 PM Changeset in webkit [117351] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r117332.
http://trac.webkit.org/changeset/117332
https://bugs.webkit.org/show_bug.cgi?id=86679
It makes the Qt Linux bot very unhappy (Requested by darktears
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
- platform/qt/Skipped:
- 2:58 PM Changeset in webkit [117350] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r117196.
- 2:58 PM Changeset in webkit [117349] by
-
- 2 edits in trunk/LayoutTests
Make window-property-shadowing-name.html fail faster
https://bugs.webkit.org/show_bug.cgi?id=86664
Reviewed by Ojan Vafai.
This makes test sync instead of async by checking the return value of window.open.
- fast/dom/Window/window-property-shadowing-name.html:
- 2:55 PM Changeset in webkit [117348] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark test as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=82698
Unreviewed, expectations update.
- platform/chromium/test_expectations.txt:
- 2:55 PM Changeset in webkit [117347] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r117165.
- 2:53 PM Changeset in webkit [117346] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r117158.
- 2:51 PM Changeset in webkit [117345] by
-
- 7 edits in branches/safari-536-branch/Source/WebCore
Merged r117147.
- 2:31 PM Changeset in webkit [117344] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed chromium rebaseline for change in r117310.
- platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.png:
- platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt: Removed.
- platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
- 2:21 PM Changeset in webkit [117343] by
-
- 7 edits in trunk/Source/JavaScriptCore
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839
Reviewed by Geoff Garen.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSObject.cpp:
(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.
- runtime/JSObject.h:
(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.
- runtime/Structure.cpp:
(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):
- runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):
- 2:18 PM Changeset in webkit [117342] by
-
- 2 edits in trunk/LayoutTests
Fix bad expectation added in r117249.
https://bugs.webkit.org/show_bug.cgi?id=82698
Unreviewed, test expectation fix.
- editing/shadow/selection-of-orphan-shadowroot-expected.txt:
- 2:14 PM Changeset in webkit [117341] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB: WebKit API for IDBObjectStore.autoIncrement property
https://bugs.webkit.org/show_bug.cgi?id=86661
Reviewed by Dimitri Glazkov.
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::autoIncrement):
- 2:06 PM Changeset in webkit [117340] by
-
- 2 edits in trunk/Source/JavaScriptCore
GC is not thread-safe when moving values between C stacks
https://bugs.webkit.org/show_bug.cgi?id=86672
Reviewed by Phil Pizlo.
GC pauses thread A while marking thread A, and then B while marking B,
which isn't safe against A and B moving values between each others'
stacks.
This is a theoretical bug -- I haven't been able to reproduce it
in the wild.
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots): Pause all C stacks for the
duration of stack marking, to avoid missing values that might be moving
between C stacks.
- 2:06 PM Changeset in webkit [117339] by
-
- 30 edits11 adds in trunk
CSS 2.1 failure: inline-table-001 fails
https://bugs.webkit.org/show_bug.cgi?id=84167
Reviewed by Julien Chaffraix.
Source/WebCore:
Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.
Tests:
css2.1/20110323/inline-table-001.htm
css2.1/20110323/inline-table-002a.htm
css2.1/20110323/inline-table-003.htm
fast/css/empty-cell-baseline.html
- rendering/RenderTable.cpp:
(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a
baseline. Tested by fast/css/empty-cell-baseline.html
LayoutTests:
- css2.1/20110323/inline-table-001.htm: Added.
- css2.1/20110323/inline-table-002a.htm: Added.
- css2.1/20110323/inline-table-003.htm: Added. From the CSS 2.1 test suite.
- fast/css/empty-cell-baseline-expected.html: Added.
- fast/css/empty-cell-baseline.html: Added. This ensures we don't take a baseline from an empty cell.
- fast/inline-block/001.html: Modified to make expected results clearer.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added.
- platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:
Progression, the baseline of the text in each cell has moved up to where it should be.
- platform/chromium-linux/editing/selection/iframe-expected.png:
Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
- platform/chromium-linux/editing/selection/inline-table-expected.png:
Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.
- platform/chromium-linux/editing/selection/table-caret-3-expected.png:
Progression, 'foo' and 'baz' line up with the first row of the inline table.
- platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:
Progression, 'Test' and 'content' now line up.
- platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
Progression, the two boxes now line up.
- platform/chromium-linux/fast/inline-block/001-expected.png:
Progression, the boxes now line up in the same way as FF and Opera.
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
Progression, the baseline of the text in each cell has moved up to where it should be.
- platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
- platform/chromium-win/editing/selection/iframe-expected.txt:
- platform/chromium-win/editing/selection/inline-table-expected.txt:
- platform/chromium-win/editing/selection/table-caret-3-expected.txt:
- platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
- platform/chromium-win/fast/inline-block/001-expected.txt:
- platform/chromium-win/fast/repaint/float-overflow-expected.txt:
- platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/Skipped:
Text rebaselines.
- 2:02 PM Changeset in webkit [117338] by
-
- 8 edits in trunk/Source/WebCore
IndexedDB: Rename valid/finished methods to isValid/isFinished to match coding standard
https://bugs.webkit.org/show_bug.cgi?id=86655
Reviewed by Tony Chang.
No new tests - no functional changes.
- Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::isValid): valid() => isValid()
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::transactionFinished):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::isFinished): finished() => isFinished()
- Modules/indexeddb/IDBTransaction.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
- 1:57 PM Changeset in webkit [117337] by
-
- 3 edits in trunk/LayoutTests
[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Brady Eidson.
Unskip the related test from mac-kw2 and gtk-wk2 as support has been added.
- platform/gtk-wk2/Skipped:
- platform/mac-wk2/Skipped:
- 1:56 PM Changeset in webkit [117336] by
-
- 2 edits in trunk/Source/WebCore
ImageLoader can still dispatch beforeload events for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=86658
<rdar://problem/11465863>
Reviewed by Brady Eidson.
Prevent flags regarding sending beforeload events from being set on ImageDocuments.
No new tests; testing framework doesn't allow for testing ImageDocuments with injected JavaScript.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- 1:50 PM Changeset in webkit [117335] by
-
- 12 edits in trunk
layerX/layerY warning should be removed
https://bugs.webkit.org/show_bug.cgi?id=86264
Reviewed by James Robinson.
Source/WebCore:
Covered by: fast/dom/Window/window-xy-properties.html
fast/events/init-events.html
fast/events/mouse-relative-position.html
fast/events/mouseclick-target-and-positioning.html
fast/events/simulated-click-coords.html
jquery/event.html
This change just removes the warning pending proper investigation.
Longer explanation: The layerX/layerY warning was added prematurely
as we didn't assess the web-compatibility potential breakage vs the
maintenance cost. There is also not readily available replacement.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):
- dom/UIEvent.cpp:
(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
- dom/UIEvent.h:
Removed warnDeprecatedLayerXYUsage and all the associated calls.
LayoutTests:
Removed console message about layerX/layerY deprecation.
- fast/dom/Window/window-xy-properties-expected.txt:
- fast/events/init-events-expected.txt:
- fast/events/mouse-relative-position-expected.txt:
- fast/events/mouseclick-target-and-positioning-expected.txt:
- fast/events/simulated-click-coords-expected.txt:
- jquery/event-expected.txt:
- platform/qt/fast/events/mouse-relative-position-expected.txt:
- 1:41 PM Changeset in webkit [117334] by
-
- 5 edits in trunk/Source/WebCore
IndexedDB: Use accessors for backing store / database id in store/index backends
https://bugs.webkit.org/show_bug.cgi?id=86652
Reviewed by Tony Chang.
Hide the private members m_backingStore and m_databaseId of IDBObjectStoreBackendImpl
and IDBIndexBackendImpl behind accessors. This is preparation for removing these
members and only holding references to the IDBDatabaseBackendImpl: webkit.org/b/83074
No new tests - no functional changes.
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::backingStore): Added.
(WebCore::IDBIndexBackendImpl::databaseId): Added.
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::backingStore): Added.
(WebCore::IDBObjectStoreBackendImpl::databaseId): Added.
(IDBObjectStoreBackendImpl):
- 1:36 PM Changeset in webkit [117333] by
-
- 3 edits3 adds in trunk
Malformed GIF can cause decoder to read off end of heap buffer
https://bugs.webkit.org/show_bug.cgi?id=86531
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/images/read-past-end-of-buffer.html
This test is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
LayoutTests:
The test here is only expected to catch problems if run under Address
Sanitizer or a similar memory-checking utility.
- fast/images/read-past-end-of-buffer-expected.txt: Added.
- fast/images/read-past-end-of-buffer.html: Added.
- fast/images/resources/wrong-block-length.gif: Added.
- 1:31 PM Changeset in webkit [117332] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION?(62951): media tests fail
https://bugs.webkit.org/show_bug.cgi?id=42094
Reviewed by Noam Rosenthal.
Enable some media layout tests so that our coverage is more than inexistant.
- platform/qt/Skipped:
- 1:25 PM Changeset in webkit [117331] by
-
- 15 edits in branches/safari-536-branch/Source
Merged r117129.
- 1:20 PM Changeset in webkit [117330] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Don't reset the default font families in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86660
Reviewed by Rob Buis.
PR 152467
The default families are also set definitively in WebCore/page/blackberry/SettingsBlackBerry.cpp
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- 1:15 PM Changeset in webkit [117329] by
-
- 2 edits in trunk/LayoutTests
[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353
Patch by Keishi Hattori <keishi@webkit.org> on 2012-05-16
Reviewed by Kent Tamura.
- Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue
- 1:07 PM Changeset in webkit [117328] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, rebaselining after r117310.
- platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
- 1:04 PM Changeset in webkit [117327] by
-
- 12 edits1 add in trunk
[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236
Patch by Varun Jain <varunjain@google.com> on 2012-05-16
Reviewed by Tony Chang.
.:
- ManualTests/chromium/modifiers-during-drag-and-drop.html: Added.
Source/WebCore:
ManualTests: ManualTests/chromium/modifiers-during-drag-and-drop.html
- page/DragController.cpp:
(WebCore::createMouseEvent):
- platform/DragData.cpp:
(WebCore):
(WebCore::DragData::modifierKeyState):
- platform/DragData.h:
(DragData):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::modifierKeyState):
(WebCore::ChromiumDataObject::setModifierKeyState):
(ChromiumDataObject):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):
Source/WebKit/chromium:
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
(WebKit::webInputEventKeyStateToPlatformEventKeyState):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
- src/WebViewImpl.h:
(WebViewImpl):
- 12:55 PM Changeset in webkit [117326] by
-
- 7 edits in trunk
<video> elements with no video tracks report false for webkitSupportsFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=86650
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; updated media/media-fullscreen-inline.html.
With the new Full Screen API, the restriction that only video elements with
video tracks can enter full screen seems arbitrary. Some media types will
occasionally determine they have video tracks long after loadedmetadata, which
breaks websites who check for webkitSupportsFullscreen(). Relax the restriction
on webkitSupportsFullscreen() for ports where the Full Screen API is enabled and
supported so as to no longer require hasVideo().
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen):
LayoutTests:
Fix media-fullscreen.js to support the new FULLSCREEN_API events, if present.
Fix the media-fullscreen-inline.html test and unskip on Lion.
- media/media-fullscreen-inline-expected.txt:
- media/media-fullscreen-inline.html:
- media/media-fullscreen.js:
(fullscreenchange):
(loadedmetadata):
(addEventListeners):
- platform/mac-lion/Skipped:
- 12:48 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:48 PM Changeset in webkit [117325] by
-
- 2 edits in trunk/LayoutTests
[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132
Removed test from skipped list, since it now passes on mac.
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-05-16
Reviewed by Alexis Menard.
- platform/qt-mac/Skipped:
- 12:40 PM Changeset in webkit [117324] by
-
- 3 edits in trunk/Source/WebKit2
[WinCairo] Unreviewed build change after exported symbol
updates (r114790) and expansion of CG routines in WebPage
PDF output (r114476).
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToPDF): Exclude CG use on WinCairo.
(WebKit::WebPage::drawPagesToPDF): Exclude CG use on WinCairo.
- win/WebKit2CFLite.def: Don't claim to export symbols we don't
provide (e.g., full screen API calls).
- 12:31 PM Changeset in webkit [117323] by
-
- 16 edits in trunk/Source/WebCore
Avoid reparsing the style attribute when cloning elements.
<http://webkit.org/b/86574>
Reviewed by Antti Koivisto.
Refactor cloning of attributes a bit to dodge the styleAttr reparse previously
caused by ElementAttributeData::setAttributes().
Introduced Element::cloneDataFromElement() which takes care of cloning the
ElementAttributeData as well as "non-attribute properties" (which is currently
specific to HTMLInputElement.)
Also includes some additional dodging of attribute vector traversal to find
old/new 'id' and 'name' attributes.
I'm seeing a ~10% improvement on PerformanceTests/DOM/CloneNodes locally.
- dom/Document.cpp:
(WebCore::Document::importNode):
- dom/Element.cpp:
(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::cloneDataFromElement):
- dom/Element.h:
(WebCore::Element::copyNonAttributePropertiesFromElement):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/Node.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::parseAttribute):
- dom/StyledElement.h:
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- html/HTMLElement.cpp:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
- html/HTMLInputElement.h:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):
- 12:25 PM Changeset in webkit [117322] by
-
- 4 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build change after r115385. Several Cairo
image routines were modified to use new wrapper classes, but the
relevant WinCairo sources were not updated to match.
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
- 12:22 PM Changeset in webkit [117321] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit2
Merged r117124.
- 12:20 PM Changeset in webkit [117320] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r117113.
- 12:18 PM Changeset in webkit [117319] by
-
- 5 edits in branches/safari-536-branch/Source
Merged r117108.
- 12:16 PM Changeset in webkit [117318] by
-
- 4 edits in branches/safari-536-branch/Source/WebCore
Merged r117032.
- 12:13 PM Changeset in webkit [117317] by
-
- 3 edits in branches/safari-536-branch/Source/WebCore
Merged r117021.
- 12:11 PM Changeset in webkit [117316] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit2
Merged r116971.
- 12:10 PM Changeset in webkit [117315] by
-
- 15 edits1 copy1 delete in branches/safari-536-branch/Source/WebKit2
Merged r116796.
- 11:48 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:45 AM Changeset in webkit [117314] by
-
- 2 edits in trunk/Source/WebCore
Scrollbar layers should respect accelerated drawing setting
https://bugs.webkit.org/show_bug.cgi?id=86644
<rdar://problem/11462038>
Reviewed by Simon Fraser.
When creating scrollbar layers, pass through the accelerated drawing setting.
No new tests.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
- 11:41 AM Changeset in webkit [117313] by
-
- 2 edits in trunk/Source/WebCore
FrameView::scrollContentsFastPath should use painted area to determine whether to drop out of the fast path
https://bugs.webkit.org/show_bug.cgi?id=86651
<rdar://problem/11459243>
Reviewed by Simon Fraser.
Previously, we decided to fall out of the fast scrolling path by the number of fixed-position elements
on the page. This was less than ideal if a single fixed position element took up a significant portion
of the page, or if there were many small, cheap-to-paint fixed elements.
Instead, we should use the fast path if less than 50% of the page will be repainted by fixed-position
elements, and otherwise fall back to the slow path.
I've tested a few different thresholds with an internal test; 50% seems to work relatively well,
but the ideal value is hard to determine and likely depends on hardware.
No new tests, performance improvement with few large fixed-position objects or many small ones.
- page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
- 11:31 AM Changeset in webkit [117312] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Use ThrottledTextureUploader with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=85848
Patch by David Reveman <reveman@chromium.org> on 2012-05-16
Reviewed by Adrienne Walker.
Switch to ThrottledUploader in CCThreadProxy.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- 11:31 AM Changeset in webkit [117311] by
-
- 3 edits in trunk/Source/WTF
Make things build with DUMP_HASHTABLE_STATS=1
https://bugs.webkit.org/show_bug.cgi?id=86571
Reviewed by Geoffrey Garen.
DUMP_HASHTABLE_STATS bitrotted after the WTF separation. This patch
makes it build.
Added WTF_EXPORTDATA to the global data, and WTF_EXPORT_PRIVATE to
the static HashTableStats methods. Added a dumpStats() method
that is not yet called anywhere; we can no longer rely on destroying
a global object to dump the stats because global destructors are
disallowed.
- wtf/HashTable.cpp:
(WTF):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):
- wtf/HashTable.h:
(HashTableStats):
- 11:30 AM Changeset in webkit [117310] by
-
- 7 edits in trunk
Change ascents and descent back to ints for now
https://bugs.webkit.org/show_bug.cgi?id=86518
Reviewed by Eric Seidel.
Change ascents and descent calculation back to integers for now as it
looks like we'll need to support both the 1/60 and 1/1 implementations of
FractionalLayoutUnit for the immediate future to ensure that text is
rendered at the same offset and with the height regardless of the
ENABLE_SUBPIXEL_LAYOUT flag.
This ensures that most websites will look the same at 100% zoom
regardless of the flag and also allows us to the same test expectations
for the vast majority of layout tests.
Eventually we want to move those back to FractionalLayoutUnits as that
will result in more correct rendering.
Source/WebCore:
No new tests, no change in functionality.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
- rendering/RootInlineBox.cpp:
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
- rendering/RootInlineBox.h:
(RootInlineBox):
LayoutTests:
- platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
- 11:18 AM Changeset in webkit [117309] by
-
- 3 edits2 adds in trunk
Crash due to first-letter not getting computed on RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=86133
Reviewed by Abhishek Arya.
Source/WebCore:
RenderTableCell overrides RenderBlock::layout() but doesn't call
updateFirstLetter() in it. This is normally not a problem because
updateFirstLetter() gets called during preferred logical width
computation, but there exist rare occasions when layout of the table
cell happens without preferred logical widths being dirty, in which
case the first-letter update can be skipped.
This patch adds a call to updateFirstLetter() to
RenderTableCell::layout(). This ensures that the first-letter is up
to date before commencing block layout.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout)
LayoutTests:
Test to exercise crashing condition in bug 86133.
- fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt: Added
- fast/css-generated-content/first-letter-table-cell-format-block-crash.html: Added
- 10:53 AM Changeset in webkit [117308] by
-
- 12 edits in trunk/LayoutTests
New baselines required after r117187.
https://bugs.webkit.org/show_bug.cgi?id=86486
Unreviewed gardening.
- platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
- platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-win/svg/custom/pointer-events-image-expected.png:
- platform/chromium/test_expectations.txt:
- 10:45 AM Changeset in webkit [117307] by
-
- 5 edits6 adds in trunk
Avoid jumpscroll when entering new text in a multi-line editor.
https://bugs.webkit.org/show_bug.cgi?id=82875
Reviewed by Ryosuke Niwa
Scroll caret to the edge of the viewport in case if a line break or a paragraph
separator is inserted at the end of a multi-line editor. This avoids
undesirable jumpscroll in cases when there is content under the editor.
Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html
- editing/Editor.cpp:
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::revealSelectionAfterEditingOperation):
- editing/Editor.h:
(Editor):
- editing/input/resources/reveal-utilities.js:
(performJumpAtTheEdgeTest):
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added.
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added.
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added.
- editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added.
- editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added.
- 10:36 AM Changeset in webkit [117306] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Pressing esc after requesting snippet creation should remove snippet.
https://bugs.webkit.org/show_bug.cgi?id=86639
Reviewed by Pavel Feldman.
Added committed parameter to NavigatorView.rename() callback.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
- inspector/front-end/ScriptsNavigator.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
- 10:29 AM Changeset in webkit [117305] by
-
- 10 edits2 copies4 adds in trunk/Source/WebKit2
[GTK] Add API to get plugins to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=86356
Reviewed by Martin Robinson.
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitMimeInfo.cpp: Added.
(_WebKitMimeInfo): Boxed type to represent MIME type information.
(webkitMimeInfoCreate): Ceate a new WebKitMimeInfo.
(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type): Return the mime type.
(webkit_mime_info_get_description): Return the mime type
description.
(webkit_mime_info_get_extensions): Return the list of extensions
associated to the mime type.
- UIProcess/API/gtk/WebKitMimeInfo.h: Added.
- UIProcess/API/gtk/WebKitMimeInfoPrivate.h: Added.
- UIProcess/API/gtk/WebKitPlugin.cpp: Added.
(webkitPluginFinalize):
(webkit_plugin_init):
(webkit_plugin_class_init):
(webkitPluginCreate): Create a new WebKitPlugin for the given
PluginModuleInfo.
(webkit_plugin_get_name): Return the plugin name.
(webkit_plugin_get_description): Return the plugin description.
(webkit_plugin_get_path): Return the path where the plugin is
installed.
(webkit_plugin_get_mime_info_list): Return the list of mime types
handled by the plugin.
- UIProcess/API/gtk/WebKitPlugin.h: Added.
- UIProcess/API/gtk/WebKitPluginPrivate.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_additional_plugins_directory): Set an
additional directory to be scanned for plugins.
(GetPluginsAsyncData): Helper struct used to asynchronously get
the list of plugins.
(getPluginsAsyncDataCreate): Create a GetPluginsAsyncData struct.
(getPluginsAsyncDataDestroy): Destroy a GetPluginsAsyncData
struct.
(webkitWebContextGetPluginThread): Thread body to get the list of
plugins installed.
(webkit_web_context_get_plugins): Asynchronously get the list of
plugins installed.
(webkit_web_context_get_plugins_finish): Finish async operation
started by webkit_web_context_get_plugins() returning a list of
WebKitPlugin.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitPlugin.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextGetPlugins):
(beforeAll):
- UIProcess/API/gtk/webkit2.h:
- 10:22 AM Changeset in webkit [117304] by
-
- 3 edits2 adds in trunk
Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
https://bugs.webkit.org/show_bug.cgi?id=86627
Reviewed by Andreas Kling.
Source/WebCore:
Test: java/inline-applet-crash.html
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
LayoutTests:
- java/inline-applet-crash-expected.txt: Added.
- java/inline-applet-crash.html: Added.
- 9:56 AM Changeset in webkit [117303] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=86643
http/tests/security/contentSecurityPolicy/script-src-redirect.html fails on Mac bots
- platform/mac/Skipped: Add to skipped list while Oliver and Michael are exploring it.
- 9:38 AM Changeset in webkit [117302] by
-
- 10 edits in trunk
Web Inspector: extract CompositeUISourceCodeProvider from DebuggerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=86634
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Extract refactoring.
- inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodeProviders):
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UISourceCodeProvider.prototype.addEventListener):
(WebInspector.UISourceCodeProvider.prototype.removeEventListener):
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/linkifier.html:
- inspector/debugger/scripts-panel.html:
- 9:30 AM Changeset in webkit [117301] by
-
- 4 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=86638
Bump the version number on the WKBundlePageLoaderClient
Reviewed by Dan Bernstein.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: s/1/2/
- Shared/APIClientTraits.cpp: Update client traits for the BundlePageLoaderClient
- Shared/APIClientTraits.h: Update client traits for the BundlePageLoaderClient
- ChangeLog: Change a confusing ChangeLog entry to reflect the actual client that was changed.
- 9:22 AM Changeset in webkit [117300] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Double Clicking on "No watch expressions" should add an expression
https://bugs.webkit.org/show_bug.cgi?id=86631
Reviewed by Vsevolod Vlasov.
A double-click listener for the section element adds a new watch expression if the correct element
has been clicked.
Drive-by: do not persist deleted (null) watch expressions.
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._sectionDoubleClick):
(WebInspector.WatchExpressionsSection.prototype.updateExpression):
- 9:11 AM Changeset in webkit [117299] by
-
- 8 edits in trunk
Web Inspector: Support script snippets saving.
https://bugs.webkit.org/show_bug.cgi?id=86632
Reviewed by Pavel Feldman.
Source/WebCore:
Added SnippetJavaScriptSource extending JavaScriptSource and overriding isEditable() and commitWorkingCopy() methods.
ScriptSnippetModel now creates instances of this new class for snippets.
Also maps in ScriptSnippetModel simplified.
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.renameScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.setScriptSnippetContent):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.SnippetJavaScriptSource):
(WebInspector.SnippetJavaScriptSource.prototype.isEditable):
(WebInspector.SnippetJavaScriptSource.prototype.commitWorkingCopy):
(WebInspector.SnippetJavaScriptSource.prototype.get snippetId):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
LayoutTests:
- inspector/debugger/script-snippet-model.html:
- 9:09 AM Changeset in webkit [117298] by
-
- 2 edits in trunk/Tools
[EFL] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=86194
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
Reviewed by Martin Robinson.
Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
point values between 32-bit and 64-bit architectures.
Same flags are already used by Qt and GTK ports.
- Scripts/webkitdirs.pm:
(determineArchitecture):
(generateBuildSystemFromCMakeProject):
- 9:00 AM Changeset in webkit [117297] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Memory leak in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=86609
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16
Reviewed by Martin Robinson.
Fix a memory leak by freeing the cairo surface with
cairo_surface_destroy.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::cacheThemePartFlush):
- 8:49 AM Changeset in webkit [117296] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Speedup heap snapshot postprocessing
https://bugs.webkit.org/show_bug.cgi?id=86635
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-16
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
- 8:48 AM Changeset in webkit [117295] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, followup for r117273 that fixes the Web Inspector's Computed Style pane layout.
- inspector/front-end/elementsPanel.css:
(.styles-section.computed-style.expanded .properties > li):
(.styles-section.computed-style.expanded .properties > li .webkit-css-property):
- 8:42 AM Changeset in webkit [117294] by
-
- 4 edits in trunk/LayoutTests
[Qt] New failing and flakey tests with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=86452
Unreviewed gardening, skip new failing/flakey tests to paint
the bots green. (To be able to catch new and new regressions.)
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- 8:41 AM Changeset in webkit [117293] by
-
- 11 edits2 adds in trunk
Web Inspector: [Extensions API] expose evaluateOptions in audit formatters
https://bugs.webkit.org/show_bug.cgi?id=86617
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/extensions/extensions-audits-content-script.html
- apply extension-specific audit formatters earlier (in ExtensionAduitCategory, not along with the rest in AuditFormatters);
- use ExtensionServer.evaluate() to handle evaluateOptions instead of PageAgent.evaluate();
- inspector/front-end/AuditFormatters.js: Move node and object formatters to ExtensionAuditCategory.
(WebInspector.partiallyApplyFormatters): Added a method to traverse formatters tree and apply formatters that are passed as input.
- inspector/front-end/ExtensionAuditCategory.js:
(WebInspector.ExtensionAuditCategory): Pass extensionOrigin.
(WebInspector.ExtensionAuditCategoryResults.prototype._addNode): Apply extensions formatters before adding the result.
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.evaluate): moved from AuditFormatters.
(WebInspector.ExtensionAuditFormatters.object.onEvaluate):
(WebInspector.ExtensionAuditFormatters.object):
(WebInspector.ExtensionAuditFormatters.node.onNodeAvailable):
(WebInspector.ExtensionAuditFormatters.node.onEvaluate):
(WebInspector.ExtensionAuditFormatters.node):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddAuditCategory): Plumb extensionOrigin through to audit category.
LayoutTests:
- inspector/extensions/extensions-audits-content-script-expected.txt: Added.
- inspector/extensions/extensions-audits-content-script.html: Added.
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 8:27 AM Changeset in webkit [117292] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Add missing include that was causing build errors.
https://bugs.webkit.org/show_bug.cgi?id=86502
Patch by Genevieve Mak <gmak@rim.com> on 2012-05-16
Reviewed by Rob Buis.
Reviewed Internally by Liam Quinn.
- WebKitSupport/InputHandler.cpp:
- 7:56 AM Changeset in webkit [117291] by
-
- 4 edits in trunk/Source/WebCore
Fixes the build with Qt 5 HEAD
Patch by Donald Carr <donald.carr@nokia.com> on 2012-05-16
Reviewed by Csaba Osztrogonác.
- WebCore.pri:
- platform/graphics/texmap/TextureMapperGL.cpp:
- plugins/qt/PluginViewQt.cpp:
- 7:52 AM Changeset in webkit [117290] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Web Inspector: DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh is broken
https://bugs.webkit.org/show_bug.cgi?id=86629
Reviewed by Pavel Feldman.
Listen to DebuggerModel instead of DebuggerPresentationModel which is gone.
- src/js/Tests.js:
(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):
- 7:47 AM Changeset in webkit [117289] by
-
- 3 edits2 adds in trunk
SVGSVGElement checkIntersection and checkEnclosure Mem corruption
https://bugs.webkit.org/show_bug.cgi?id=67923
Patch by Rob Buis <rbuis@rim.com> on 2012-05-16
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Only call checkIntersection/checkEnclosure when we have a valid renderer.
Test: svg/custom/intersection-list-null.svg
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):
LayoutTests:
Add test to check that checkIntersection/checkEnclosure do not
crash when null is used for the element parameter.
- svg/custom/intersection-list-null-expected.txt: Added.
- svg/custom/intersection-list-null.svg: Added.
- 7:23 AM Changeset in webkit [117288] by
-
- 2 edits in trunk/Tools
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620
Reviewed by Csaba Osztrogonác.
Temporary workaround not to fail layout tests.
- Tools.pro: Disable TestNetscapePlugin.
- 7:22 AM Changeset in webkit [117287] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Web Inspector: debugger browser tests are broken
https://bugs.webkit.org/show_bug.cgi?id=86624
Reviewed by Vsevolod Vlasov.
Use WebInspector.panels.scripts._scriptMapping instead of
WebInspector.panels.scripts._presentationModel as the latter
has been deleted.
- src/js/Tests.js:
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
- 7:21 AM WebKitGTK/1.8.x edited by
- (diff)
- 7:21 AM Changeset in webkit [117286] by
-
- 4 edits in trunk
Source/WebCore: Unreviewed, rolling out r110699.
http://trac.webkit.org/changeset/110699
https://bugs.webkit.org/show_bug.cgi?id=80982
Not needed anymore and broke modal event loops
- platform/qt/RunLoopQt.cpp:
(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):
LayoutTests: Unskip fast/animation/request-animation-frame-during-modal.html that was
skipped due to r110699.
- platform/qt-5.0-wk2/Skipped:
- 7:19 AM WebKitGTK/1.8.x edited by
- (diff)
- 7:08 AM Changeset in webkit [117285] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Fix uninitialized struct member added by r117258
https://bugs.webkit.org/show_bug.cgi?id=86611
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
When adding a new member to _Ewk_View_Smart_Class,
EWK_VIEW_SMART_CLASS_VERSION needs to be updated.
- ewk/ewk_view.h:
- 6:58 AM Changeset in webkit [117284] by
-
- 7 edits146 adds in trunk/LayoutTests
Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
- platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Added.
- platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Added.
- platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
- platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Added.
- platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
- platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
- platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Added.
- platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Added.
- platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/textEffect-expected.png: Added.
- platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Added.
- platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Added.
- platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Added.
- platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
- platform/qt-5.0/svg/carto.net/window-expected.png: Added.
- platform/qt-5.0/svg/carto.net/window-expected.txt: Added.
- platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png: Added.
- platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt:
- platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
- platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
- platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
- platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Added.
- platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/qt-5.0/svg/custom/svg-features-expected.txt: Added.
- platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Added.
- platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Added.
- platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Added.
- platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Added.
- platform/qt-5.0/svg/custom/text-linking-expected.png: Added.
- platform/qt-5.0/svg/custom/text-linking-expected.txt: Added.
- platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.png: Added.
- platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Added.
- platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
- platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
- platform/qt-5.0/svg/text/text-align-01-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-align-01-b-expected.txt: Added.
- platform/qt-5.0/svg/text/text-align-02-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-align-02-b-expected.txt: Added.
- platform/qt-5.0/svg/text/text-align-04-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-align-04-b-expected.txt: Added.
- platform/qt-5.0/svg/text/text-align-06-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-align-06-b-expected.txt: Added.
- platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
- platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
- platform/qt-5.0/svg/text/text-text-01-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Added.
- platform/qt-5.0/svg/text/text-text-04-t-expected.png: Added.
- platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Added.
- platform/qt-5.0/svg/text/text-tselect-01-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-tselect-01-b-expected.txt: Added.
- platform/qt-5.0/svg/text/text-tspan-01-b-expected.png: Added.
- platform/qt-5.0/svg/text/text-tspan-01-b-expected.txt: Added.
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
- platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
- platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
- platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Added.
- platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Added.
- 6:57 AM Changeset in webkit [117283] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merge 113099 - Crash in SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=83040
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/css-set-selector-text-crash.html
Removing the early bail when we detect that our selector text
hasn't changed, and we don't notify the styleSelectorChanged.
In fact, when we adopt the new selector list, the old one will
get destroyed and the styleSelectorChanged call needs to be made.
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
LayoutTests:
- fast/css/css-set-selector-text-crash-expected.txt: Added.
- fast/css/css-set-selector-text-crash.html: Added.
- 6:57 AM Changeset in webkit [117282] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-1.8
Merge 113597 - Crash due to floats not cleared before starting SVG <text> layout.
https://bugs.webkit.org/show_bug.cgi?id=83021
Reviewed by Dirk Schulze.
.:
- ManualTests/svg-text-float-not-removed-crash.html: Added.
Source/WebCore:
Manual Test - ManualTests/svg-text-float-not-removed-crash.html.
Can't reproduce the failure in DRT.
forceLayoutInlineChildren is used in SVG <text> layout and overrides
RenderBlock::layoutBlock. However, it missed the 'clearFloats' step,
which will cause a crash when trying to access removed renderers.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::forceLayoutInlineChildren):
- 6:56 AM Changeset in webkit [117281] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merge 112973 - <select> shouldn't intrude as a run-in.
https://bugs.webkit.org/show_bug.cgi?id=82829
Reviewed by Tony Chang.
Source/WebCore:
Matches Opera's behavior which also does not allow <select>
to intrude as a run-in into the neighbouring block.
IE and Firefox doesn't support run-ins, so can't compare behavior
with them.
Test: fast/runin/select-runin.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::handleRunInChild):
LayoutTests:
- fast/runin/select-runin-expected.txt: Added.
- fast/runin/select-runin.html: Added.
Conflicts:
Source/WebCore/rendering/RenderBlock.cpp
- 6:56 AM Changeset in webkit [117280] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merge 113825 - Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html
markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.
For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
LayoutTests:
- fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
- fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
- 6:56 AM Changeset in webkit [117279] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-1.8
Merge 113670 - ASSERTION FAILED: !attached() in Node::attach.
https://bugs.webkit.org/show_bug.cgi?id=80726
Reviewed by Adam Barth.
Source/WebCore:
While parsing XML document, prevent attaching the leaf text node
back to document, if its parent is not attached.
Test: fast/dom/text-node-attach-crash.xhtml
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::exitText):
LayoutTests:
- fast/dom/text-node-attach-crash-expected.txt: Added.
- fast/dom/text-node-attach-crash.xhtml: Added.
- 6:55 AM Changeset in webkit [117278] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8
Merge 112184 - FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
https://bugs.webkit.org/show_bug.cgi?id=81020
Reviewed by Eric Seidel.
Source/WebCore:
The vast majority of security checks in the browser should use a
ScriptExecutionContext (aka a Document) to designate "who" is
attempting to perform a given action. Unfortunately,
shouldAllowNavigation was using a Frame to designate "who" is
attempting the navigation.
In cases when the executing script is "inactive" (i.e., belongs to a
document that is not currently displayed in a Frame), using the Frame
can cause us to grant the script the privileges of the document that's
currently displayed in the Frame rather than the one that contains the
script.
This patch moves shouldAllowNavigation from FrameLoader to Document
(and renames it to canNavigate), effectively change the context object
from a Frame to a Document.
Test: http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html
- bindings/generic/BindingSecurity.h:
(BindingSecurity):
(WebCore):
- bindings/v8/V8Utilities.cpp:
(WebCore):
- bindings/v8/V8Utilities.h:
(WebCore):
- Deletes unused code.
- dom/Document.cpp:
(WebCore::canAccessAncestor):
(WebCore):
(WebCore::Document::canNavigate):
- canNavigate is copied from FrameLoader::shouldAllowNavigation. I've added a null-check bailout if the document is inactive.
- dom/Document.h:
(Document):
- loader/FormState.cpp:
(WebCore::FormState::FormState):
(WebCore::FormState::create):
- loader/FormState.h:
(WebCore):
(FormState):
(WebCore::FormState::sourceDocument):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- Changes the context object from Frame to Document.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore):
(WebCore::FrameLoader::findFrameForNavigation):
- FrameLoader::findFrameForNavigation still incorrectly uses Frame as the context object, but that's a bug for another patch.
(WebCore::createWindow):
- loader/FrameLoader.h:
(FrameLoader):
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledFormSubmission::fire):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::open):
- page/History.cpp:
(WebCore::History::go):
Source/WebKit/mac:
Update call site to new function name.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSubmitForm):
Source/WebKit/win:
Update call site to new function name.
- WebFrame.cpp:
(WebFrame::dispatchWillSubmitForm):
Source/WebKit2:
Update call site to new function name.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
LayoutTests:
Test that a script from an inactive document doesn't inherit the
navigation privileges of the document that currently occupies the
frame.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt: Added.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Added.
- http/tests/security/frameNavigation/resources/fail.html: Added.
- http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html:
- http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html: Added.
- 6:55 AM Changeset in webkit [117277] by
-
- 21 edits1 move in trunk
Web Inspector: split ScriptMapping into UISourceCodeProvider and SourceMapping.
https://bugs.webkit.org/show_bug.cgi?id=86616
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change simply splits the interface.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodes):
(WebInspector.CompilerScriptMapping.prototype.reset):
- inspector/front-end/DebuggerModel.js:
- inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
- inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodes):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodes):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
- inspector/front-end/Script.js:
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
- inspector/front-end/SourceMapping.js: Renamed from Source/WebCore/inspector/front-end/ScriptMapping.js.
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProvider):
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UILocation):
(WebInspector.UILocation.prototype.uiLocationToRawLocation):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- inspector/debugger/scripts-panel.html:
- 6:47 AM Changeset in webkit [117276] by
-
- 14 edits in trunk
Add didFinishProgress BundleUIClient callback
https://bugs.webkit.org/show_bug.cgi?id=86541
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Added didFinishProgress BundleUIClient callback needed by
WebKitTestRunner. This callback is invoked in postProgressFinishedNotification.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
Added support for dumpProgressFinishedCallback.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpProgressFinishedCallback):
(WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
(WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController):
LayoutTests:
Unskip passing test.
- platform/qt-5.0-wk2/Skipped:
- 6:44 AM Changeset in webkit [117275] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Fix my typo.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16
- platform/qt/Skipped: After r117262.
- 6:40 AM Changeset in webkit [117274] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: Implement snippet creation/renaming in ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=82622
Reviewed by Pavel Feldman.
Implemented snippet creation and renaming.
Added TitleChanged event to UISourceCode.
- inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorPinned):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorHidden):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._snippetsNavigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
(WebInspector.ScriptsNavigator.prototype.rename):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype._snippetCreationRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.urlChanged):
- 6:25 AM Changeset in webkit [117273] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: gradient properties are painful to inspect / author.
https://bugs.webkit.org/show_bug.cgi?id=86379
Reviewed by Pavel Feldman.
The CSS styles layout has been changed to allow property values to wrap onto subsequent lines
to let the users see the entire value text.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.): Avoid line breaks between the color swatch and value.
- inspector/front-end/elementsPanel.css:
(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
(.styles-section .properties li):
(.styles-section .properties li .webkit-css-property):
(.styles-section.expanded .properties > li):
(.styles-section .properties > li .webkit-css-property):
(.styles-section .properties > li.child-editing):
(.styles-section .properties > li.child-editing .webkit-css-property):
(.styles-section .properties .enabled-button):
- 6:16 AM Changeset in webkit [117272] by
-
- 7 edits1 move in trunk/Source/WebCore
Web Inspector: rename ProfileView.js to CPUProfileView.js
https://bugs.webkit.org/show_bug.cgi?id=86612
Reviewed by Pavel Feldman.
Renamed ProfileView.js to CPUProfileView.js to match the file content.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype.get statusBarItems):
(WebInspector.CPUProfileView.prototype.get profile):
(WebInspector.CPUProfileView.prototype.set profile):
(WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get currentTree):
(WebInspector.CPUProfileView.prototype.set currentTree):
(WebInspector.CPUProfileView.prototype.willHide):
(WebInspector.CPUProfileView.prototype.refresh):
(WebInspector.CPUProfileView.prototype.refreshVisibleData):
(WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
(WebInspector.CPUProfileView.prototype.searchCanceled):
(WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
(WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
(WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
(WebInspector.CPUProfileView.prototype.showingLastSearchResult):
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
(WebInspector.CPUProfileView.prototype._changeView.set else):
(WebInspector.CPUProfileView.prototype._focusClicked):
(WebInspector.CPUProfileView.prototype._excludeClicked):
(WebInspector.CPUProfileView.prototype._resetClicked):
(WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
(WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
(WebInspector.CPUProfileView.prototype._sortProfile):
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.buttonClicked):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
(WebInspector.CPUProfileType.prototype.setRecordingProfile):
(WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 5:53 AM Changeset in webkit [117271] by
-
- 3 edits2 adds in trunk
"border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
https://bugs.webkit.org/show_bug.cgi?id=67877
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-16
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/table-collapsed-borders.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
When getting the previous row group's after border, pass SkipEmptySections as the second param
to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the
table passing SkipEmptySections to sectionAbove() would return null which should be the expected
behavior.
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
When getting the following row group's before border, pass SkipEmptySections as the second param
to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the
table passing SkipEmptySections to sectionBelow() would return null which should be the expected
behavior.
LayoutTests:
- fast/css/table-collapsed-borders-expected.html: Added.
- fast/css/table-collapsed-borders.html: Added.
Added new reftest for testing table with collapsed borders.
- 5:48 AM Changeset in webkit [117270] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: follow up to r117267 - fixing typo and removing unnecessary dispatch.
https://bugs.webkit.org/show_bug.cgi?id=86613
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
- 5:41 AM Changeset in webkit [117269] by
-
- 14 edits in trunk
Web Inspector: Move edit/save script source logic to JavaScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=86604
Reviewed by Pavel Feldman.
Source/WebCore:
Added working copy notion to UISourceCode.
Moved DebuggerResourceBinding content edit calls to JavaScriptSource.
Added WorkingCopyChanged event to UISourceCode.
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.isEditable):
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeContentChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype.reset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle.get if):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeContentChanged):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.isEditable):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
LayoutTests:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/scripts-panel.html:
- 5:36 AM Changeset in webkit [117268] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595
Unreviewed EFL gardening. Add missing EFL text expectation for
media/video-frame-accurate-seek.html.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
- platform/efl/media/video-frame-accurate-seek-expected.txt: Added.
- 5:22 AM Changeset in webkit [117267] by
-
- 14 edits in trunk
Web Inspector: get rid of UISourceCodeListChanged event.
https://bugs.webkit.org/show_bug.cgi?id=86601
Reviewed by Vsevolod Vlasov.
Source/WebCore:
There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.reset):
- inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
- inspector/front-end/NavigatorView.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype.reset):
- inspector/front-end/ScriptMapping.js:
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
- inspector/front-end/TabbedEditorContainer.js:
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- inspector/debugger/scripts-panel.html:
- 5:07 AM Changeset in webkit [117266] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout tests under inspector/profiler are failing on chromium win
https://bugs.webkit.org/show_bug.cgi?id=86495
Unreviewed. Remove custom expectations for heap profiler tests. They should pass
after r117241.
- platform/chromium/test_expectations.txt:
- 5:00 AM Changeset in webkit [117265] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove full-screen-keyboard-disabled.html from test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86596
Unreviewed EFL gardening.
Remove full-screen-keyboard-disabled.html from test_expectation.txt.
This case is not failed since r117205.
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16
- platform/efl/test_expectations.txt:
- 4:58 AM Changeset in webkit [117264] by
-
- 2 edits in trunk/LayoutTests
[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
https://bugs.webkit.org/show_bug.cgi?id=86473
Unreviewed gardening, partially reverts r117073.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16
- platform/efl/Skipped:
- 4:55 AM Changeset in webkit [117263] by
-
- 16 edits2 adds in trunk
[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353
Reviewed by Kent Tamura.
.:
- Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue
Source/WebCore:
Test: fast/forms/editing-value.html
We need this to implement the datalist UI for <input type=email multiple>.
HTMLInputElement.value gives you the sanitized value so the whitespace between values are trimmed.
We need to append the selected suggestion to the end without modifying the rest of the text.
- WebCore.exp.in: Added HTMLInputElement::setEditingValue
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setEditingValue):
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- testing/Internals.cpp:
(WebCore::Internals::setEditingValue):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/chromium:
- public/WebInputElement.h:
(WebInputElement):
- src/WebInputElement.cpp:
(WebKit::WebInputElement::editingValue):
(WebKit):
(WebKit::WebInputElement::setEditingValue):
Source/WebKit2:
- win/WebKit2.def: Added HTMLInputElement::setEditingValue
- win/WebKit2CFLite.def: Added HTMLInputElement::setEditingValue
LayoutTests:
- fast/forms/editing-value-expected.txt: Added.
- fast/forms/editing-value.html: Added. Tests that setting the editing value takes care of the style and placeholder, and that it fires an input event.
- 4:47 AM Changeset in webkit [117262] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening. Skip failing test after 117246.
https://bugs.webkit.org/show_bug.cgi?id=86606
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16
Reviewed by Csaba Osztrongonác.
- platform/qt/Skipped:
- 4:43 AM Changeset in webkit [117261] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Cookies should be checked during parsing to improve performance.
https://bugs.webkit.org/show_bug.cgi?id=85028
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.
We shouldn't waste time and memery on invalid cookies. It is better to drop them during parsing.
We shouldn't check the default domain since it is set with host. So we only check domains which are parsed
from response headers.
No new tests. No functionality change.
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
- 4:36 AM Changeset in webkit [117260] by
-
- 87 edits1 copy23 adds in trunk/LayoutTests
Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463
- platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
- platform/qt/svg/custom/acid3-test-77-expected.txt: Added.
- platform/qt/svg/custom/altglyph-expected.png:
- platform/qt/svg/custom/altglyph-expected.txt:
- platform/qt/svg/custom/font-face-simple-expected.png:
- platform/qt/svg/custom/font-face-simple-expected.txt:
- platform/qt/svg/custom/global-constructors-expected.txt: Added.
- platform/qt/svg/custom/glyph-selection-lang-attribute-expected.png:
- platform/qt/svg/custom/glyph-selection-lang-attribute-expected.txt:
- platform/qt/svg/custom/glyph-setting-d-attribute-expected.png:
- platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
- platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
- platform/qt/svg/custom/missing-xlink-expected.png: Added.
- platform/qt/svg/custom/missing-xlink-expected.txt: Added.
- platform/qt/svg/custom/path-bad-data-expected.png: Added.
- platform/qt/svg/custom/path-bad-data-expected.txt: Added.
- platform/qt/svg/custom/stroke-width-click-expected.txt: Added.
- platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png:
- platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/qt/svg/custom/svg-fonts-word-spacing-expected.png: Added.
- platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
- platform/qt/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/glyph-setting-d-attribute-expected.png.
- platform/qt/svg/custom/visibility-override-filter-expected.txt: Added.
- platform/qt/svg/dom/altGlyph-dom-expected.txt:
- platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Added.
- platform/qt/svg/dom/font-face-elements-expected.txt: Added.
- platform/qt/svg/text/kerning-expected.png:
- platform/qt/svg/text/kerning-expected.txt:
- platform/qt/svg/text/multichar-glyph-expected.png:
- platform/qt/svg/text/multichar-glyph-expected.txt:
- platform/qt/svg/text/text-altglyph-01-b-expected.png:
- platform/qt/svg/text/text-altglyph-01-b-expected.txt:
- platform/qt/svg/text/text-fonts-01-t-expected.png: Added.
- platform/qt/svg/text/text-fonts-01-t-expected.txt: Added.
- platform/qt/svg/text/text-hkern-expected.png:
- platform/qt/svg/text/text-hkern-expected.txt:
- platform/qt/svg/text/text-hkern-on-vertical-text-expected.png:
- platform/qt/svg/text/text-intro-05-t-expected.png: Added.
- platform/qt/svg/text/text-intro-05-t-expected.txt: Added.
- platform/qt/svg/text/text-text-04-t-expected.png:
- platform/qt/svg/text/text-text-04-t-expected.txt:
- platform/qt/svg/text/text-text-05-t-expected.png:
- platform/qt/svg/text/text-text-05-t-expected.txt:
- platform/qt/svg/text/text-text-06-t-expected.png:
- platform/qt/svg/text/text-text-06-t-expected.txt:
- platform/qt/svg/text/text-tselect-02-f-expected.png: Added.
- platform/qt/svg/text/text-tselect-02-f-expected.txt: Added.
- platform/qt/svg/text/text-vkern-expected.png:
- platform/qt/svg/text/text-vkern-expected.txt:
- platform/qt/svg/text/text-vkern-on-horizontal-text-expected.png:
- 4:29 AM Changeset in webkit [117259] by
-
- 9 edits in trunk
[Qt] Enable SVG Fonts by default
https://bugs.webkit.org/show_bug.cgi?id=86463
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Another feature we can get for free after switching to using
the font fast path with QRawFont.
It will get disabled in features.prf if either SVG support is
disabled or if we are not using QRawFont (e.g. for Qt 4).
Covered by a series of tests that were skipped for the
Qt port up until now.
- platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
Initialize the platform data used as fallback in conjunction with SVG
fonts so it will honor size, weight and oblique-ness.
- rendering/svg/SVGTextMetricsBuilder.cpp: Avoid forcing the complex path.
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache): avoid ambiguity with String(const QString&)
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- platform/qt-4.8/Skipped: Skipped the relevant tests...
- platform/qt/Skipped: ... and unskipped them here.
- 4:26 AM Changeset in webkit [117258] by
-
- 13 edits in trunk
[EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
https://bugs.webkit.org/show_bug.cgi?id=85585
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
Source/WebKit/efl:
Add new function to Ewk_Security_Origin to set the application cache
quota. Implement reachedApplicationCacheOriginQuota in
ChromeClientEfl. Add function to the Ewk_View to report that the
application cache quota was reached.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
- ewk/ewk_security_origin.cpp:
(ewk_security_origin_application_cache_quota_set):
- ewk/ewk_security_origin.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_exceeded_application_cache_quota):
- ewk/ewk_view.h:
- ewk/ewk_view_private.h:
Tools:
Implement setApplicationCacheOriginQuota in EFL's
LayoutTestController.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededApplicationCacheQuota):
(drtViewAdd):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setApplicationCacheOriginQuota):
LayoutTests:
Unskip the test cases that require implementation of
setApplicationCacheOriginQuota in EFL's LayoutTestController.
- platform/efl/Skipped:
- 4:20 AM Changeset in webkit [117257] by
-
- 4 edits in trunk/Source
[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
https://bugs.webkit.org/show_bug.cgi?id=86589
Reviewed by Kent Tamura.
Source/Platform:
- chromium/public/WebTransformationMatrix.h: Added destructor.
(WebTransformationMatrix):
Source/WebCore:
Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.
No new tests. WebTransformationMatrixTest should pass on debug build.
- platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebKit):
- 4:13 AM Changeset in webkit [117256] by
-
- 3 edits4 adds in trunk/LayoutTests
[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595
Unreviewed EFL gardening. Add expected results for a few tests and
unskip them.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
- platform/efl/Skipped:
- platform/efl/fast/forms/input-text-double-click-expected.png: Added.
- platform/efl/fast/forms/input-text-double-click-expected.txt:
- platform/efl/http/tests/misc/slow-loading-mask-expected.png: Added.
- platform/efl/http/tests/misc/slow-loading-mask-expected.txt: Added.
- platform/efl/media/video-frame-accurate-seek-expected.png: Added.
- 4:03 AM Changeset in webkit [117255] by
-
- 7 edits in trunk
[EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
https://bugs.webkit.org/show_bug.cgi?id=83776
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Tor Arne Vestbø.
Source/WebKit/efl:
Added helper new function implementing JS script evaluation in an isolated world.
Worlds are cached by their id.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
LayoutTests:
Unskipped corresponding testcases.
- platform/efl/test_expectations.txt:
- 3:58 AM WebKit Team edited by
- (diff)
- 3:43 AM Changeset in webkit [117254] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Move WebFrameNetworkingContext to WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=86590
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-16
Reviewed by Simon Hausmann.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create):
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::originatingObject):
(WebKit::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::networkAccessManager):
(WebKit::WebFrameNetworkingContext::mimeSniffingEnabled):
(WebKit::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):
- 3:34 AM Changeset in webkit [117253] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/misc/iframe-reparenting-id-collision.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86588
Unreviewed EFL gardening. Unskip
http/tests/misc/iframe-reparenting-id-collision.html which is passing
now that Bug 64085 is closed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
- platform/efl/Skipped:
- 3:27 AM Changeset in webkit [117252] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 3:24 AM Changeset in webkit [117251] by
-
- 3 edits in trunk/Source/WebKit/chromium
Speech JavaScript API: pass WebSecurityOrigin to embedder
https://bugs.webkit.org/show_bug.cgi?id=86348
Reviewed by Adam Barth.
Pass the WebSecurityOrigin of the SpeecReco object to the embedder when calling
start(). The origin will be used to determine whether speech recognition is
allowed or not.
- public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::origin):
(WebSpeechRecognitionParams):
- src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):
- 3:19 AM Changeset in webkit [117250] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening after r117123 and r117225.
- platform/gtk/test_expectations.txt:
- 3:08 AM Changeset in webkit [117249] by
-
- 11 edits5 adds3 deletes in trunk
ShadowRoot.selection should return the seleciton whose range is in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=82698
Reviewed by Ryosuke Niwa.
Source/WebCore:
The selection object returned from shadowRoot.selection should be able to see
the inner object of the shadowRoot.
In the previous code, the node out of the shadow subtree was returned for
anchorNode, focusNode, baseNode, and extentNode. This patch enables us to get
the corresponding shadow ancestor in the specified TreeScope (m_treeScope).
Tests: editing/shadow/selection-of-orphan-shadowroot.html
editing/shadow/selection-of-shadowroot.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection): When shadow DOM feature is not enabled, we want to use the same
instance of DOMSelection among Document and ShadowRoot.
- dom/TreeScopeAdjuster.cpp:
(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope): Since node could be null, I've added a node check code.
- dom/TreeScopeAdjuster.h:
(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::shadowAdjustedNode): Gets the corresponding node in the m_treeScope from the Position.
(WebCore):
(WebCore::DOMSelection::shadowAdjustedOffset): Gets the corresponding node offset in the m_treeScope from the Position.
- page/DOMSelection.h:
(WebCore):
(DOMSelection):
LayoutTests:
This patch contains 2 tests:
- Generates a complex HTML tree having a ShadowRoot, an older ShadowRoot, a nested ShadowRoot,
nested ShadowRoot in an older ShadowRoot, etc., and try to drag from a nested shadow root of
older shadow root to a nested shadow root of younger shadow root. Then checks nodes of Shadowroot.selection
are in the same tree scope or null.
- Generates a ShadowDOM which is not inserted into a document, and confirms nodes taken from
the selection are all null.
Also, this patch deprecates old shadowRoot.selection tests, because they test to check
window.getSelection() and shadowRoot.selection is the same. This behavior is changed by this patch.
- editing/shadow/selection-of-orphan-shadowroot-expected.txt: Added.
- editing/shadow/selection-of-orphan-shadowroot.html: Added.
- editing/shadow/selection-of-shadowroot-expected.txt: Added.
- editing/shadow/selection-of-shadowroot.html: Added.
- fast/dom/resources/event-sender-util.js:
(mouseMoveToElem):
(dragFromTo):
- fast/dom/shadow/resources/shadow-dom-util.js: Added.
(getElementByIdConsideringShadowDOM.iter):
(getElementByIdConsideringShadowDOM):
- fast/dom/shadow/selection-in-shadow.html: Removed.
- platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
- platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
- platform/qt/Skipped:
- 2:58 AM Changeset in webkit [117248] by
-
- 6 edits in trunk
[WTR] Visited link tracking is not disabled properly
https://bugs.webkit.org/show_bug.cgi?id=76699
Reviewed by Jocelyn Turcotte.
Source/WebKit2:
If PLATFORM_STRATEGIES is enabled visited link tracking is done through
VisitedLinkProvider and not through PageGroup.
InjectedBundle sets the shouldTrackVisitedLinks flag on the PageGroup,
thus the shared VisitedLinkTable does get populated with visited links
regardless of the flag.
The WebProcess should only track visited links if tracking is specifically
enabled for a test through WTR's LayoutTestController.
This patch fixes several flacky and failing layout tests on Qt-WK2.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setShouldTrackVisitedLinks): Let the WebProcess
know about visited link tracking.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setShouldTrackVisitedLinks):
(WebKit::WebProcess::addVisitedLink):
- WebProcess/WebProcess.h:
(WebProcess):
LayoutTests:
- platform/qt-5.0-wk2/Skipped: Unskip passing tests.
- 2:54 AM Changeset in webkit [117247] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
Adding further suppressions for flaky tests on cr-linux ews.
- platform/chromium/test_expectations.txt:
- 2:46 AM Changeset in webkit [117246] by
-
- 5 edits1 copy2 adds in trunk
[BlackBerry] xhr request to non existent file response is 0 and not 404.
https://bugs.webkit.org/show_bug.cgi?id=86344
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.
Source/WebCore:
NetworkJob receives 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case should not be treated as a failure.
Add shouldNotifyClientFailed() to treat XMLHttpRequest as a special case.
XMLHttpRequest will fail when status code is smaller than zero.
If we use "GET" and receive 404 without body, NetworkJob won't go through failing code path, too.
So add http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html
to check this case.
Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendResponseIfNeeded):
LayoutTests:
- http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html:
- 2:43 AM Changeset in webkit [117245] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, unskip a fixed test
https://bugs.webkit.org/show_bug.cgi?id=84434
- platform/qt-5.0-wk2/Skipped:
- 2:34 AM Changeset in webkit [117244] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/loader/stateobjects/replacestate-in-iframe.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86586
Unreviewed EFL gardening. Unskip
fast/loader/stateobjects/replacestate-in-iframe.html since the
infinite loop bug has been fixed in r81232.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
- platform/efl/Skipped:
- 2:32 AM Changeset in webkit [117243] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Modified test fails after r117123.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-16
- platform/qt/Skipped:
- 2:32 AM Changeset in webkit [117242] by
-
- 22 edits in trunk/Source/WebCore
HasCustomWillOrDidRecalcStyleFlag and family should live in a bit.
https://bugs.webkit.org/show_bug.cgi?id=86175
Reviewed by Ryosuke Niwa.
This change unifies following flags into one HasCustomCallbacksFlag.
- HasCustomWillOrDidRecalcStyleFlag
- HasCustomStyleForRendererFlag
- IsFrameOwnerElementFlag
By this change, some callbacks can be called even if there are no override.
So all custom callbacks should just pass these invocations.
No new tests. No behavior change.
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectDescendant):
- dom/Element.cpp:
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willRecalcStyle):
(WebCore):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::customStyleForRenderer):
- dom/Element.h:
(Element):
- dom/Node.h:
(WebCore::Node::isFrameOwnerElement):
(WebCore::Node::hasCustomCallbacks):
(WebCore::Node::setHasCustomCallbacks):
- dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
(WebCore::Text::willRecalcTextStyle):
(WebCore):
- dom/Text.h:
(Text):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
- html/HTMLFrameOwnerElement.h:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
(WebCore::HTMLPlugInImageElement::customStyleForRenderer):
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
- html/shadow/TextControlInnerElements.h:
(TextControlInnerElement):
(TextControlInnerTextElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::customStyleForRenderer):
- html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorationElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::customStyleForRenderer):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGTRefElement.cpp:
(WebCore::SVGShadowText::SVGShadowText):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
- 2:26 AM Changeset in webkit [117241] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: exception when switching to heap profiler comparison view
https://bugs.webkit.org/show_bug.cgi?id=86224
Reviewed by Pavel Feldman.
Make sure the messages are dispatched in the same order as they are sent in
case a fake worker is used for heap snapshot processing.
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.AsyncTaskQueue):
(WebInspector.AsyncTaskQueue.prototype.addTask):
(WebInspector.AsyncTaskQueue.prototype._onTimeout):
(WebInspector.AsyncTaskQueue.prototype._scheduleTimer):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
- 2:19 AM Changeset in webkit [117240] by
-
- 14 edits in trunk/LayoutTests
[EFL][DRT] Gardening failures after r117123 and r117205
https://bugs.webkit.org/show_bug.cgi?id=86584
Unreviewed, EFL gardening.
Media expectations updated now that they draw the fullscreen icon.
Moved flaky test to test_expectations, unskipped unexpected pass.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-16
- platform/efl/media/controls-after-reload-expected.png:
- platform/efl/media/controls-after-reload-expected.txt:
- platform/efl/media/controls-strict-expected.png:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-without-preload-expected.png:
- platform/efl/media/controls-without-preload-expected.txt:
- platform/efl/media/video-controls-rendering-expected.png:
- platform/efl/media/video-controls-rendering-expected.txt:
- platform/efl/media/video-display-toggle-expected.png:
- platform/efl/media/video-display-toggle-expected.txt:
- platform/efl/media/video-zoom-controls-expected.png:
- platform/efl/media/video-zoom-controls-expected.txt:
- platform/efl/test_expectations.txt:
- 2:16 AM Changeset in webkit [117239] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Add new commands for Ewk_Editor_Command.
https://bugs.webkit.org/show_bug.cgi?id=74921
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-05-16
Reviewed by Hajime Morita.
Add new commands for Ewk_Editor_Command enum and introduce new table to keep
enum and string values in sync.
- ewk/ewk_view.cpp: Added a table with EditorCommand struct elements.
(EditorCommand): Added structure consisting of enum and string value.
(_Ewk_View_Private_Data):
(_ewk_view_editor_command_string_get): Added.
(ewk_view_editor_command_execute):
- ewk/ewk_view.h: Ewk_Editor_Command enum extended.
- 2:12 AM Changeset in webkit [117238] by
-
- 4 edits in trunk
[EFL] PlatformKeyboardEvent: figures, letters and printscreen key handling
https://bugs.webkit.org/show_bug.cgi?id=85503
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
- platform/efl/EflKeyboardUtilities.cpp:
(WebCore::addCharactersToKeyMap): aux function
(WebCore):
(WebCore::createKeyMap): Figures and letters keys are added to the keyMap
(WebCore::addCharactersToWinKeyMap): aux function
(WebCore::createWindowsKeyMap): Capital letters keys are added to the windowsKeyMap. Corrected value for printscreen key.
(WebCore::singleCharacterString): Return empty text for printscreen key.
LayoutTests:
Bug-related testcases are unskipped.
- platform/efl/Skipped:
- 2:00 AM Changeset in webkit [117237] by
-
- 3 edits in trunk/LayoutTests
[EFL] Tests that require DASHBOARD_SUPPORT should be moved to test expectations
https://bugs.webkit.org/show_bug.cgi?id=86578
Unreviewed EFL gardening. Move tests that require DASHBOARD_SUPPORT
flag to test expectations and skip them since this feature is
Mac-specific.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-16
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 1:57 AM Changeset in webkit [117236] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed. Fix heap profiler performance test after r117234.
- inspector/heap-snapshot.html:
- 1:56 AM Changeset in webkit [117235] by
-
- 20 edits1 move in trunk
Web Inspector: rename DebuggerPresentationModel to DebuggerScriptMapping, make it private to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=86594
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change completes the elimination of the presentation model.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.resourceLink):
- inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
- inspector/front-end/DebuggerScriptMapping.js: Renamed from Source/WebCore/inspector/front-end/DebuggerPresentationModel.js.
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeListChanged):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
- inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProject):
(WebInspector.UISourceCodeProject.prototype.uiSourceCodes):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/linkifier.html:
- inspector/debugger/scripts-panel.html:
- 1:47 AM Changeset in webkit [117234] by
-
- 7 edits in trunk
Web Inspector: use separate fields for storing HeapSnapshotLoaderProxy and HeapSnapshotProxy
https://bugs.webkit.org/show_bug.cgi?id=86488
Reviewed by Pavel Feldman.
Source/WebCore:
Simplified heap profiler snapshot loading code. Introduced dedicated fields for
snapshot loader proxy and for snapshot proxy.
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapProfileHeader): split _proxy field into _loaderProxy and _snapshotProxy
(WebInspector.HeapProfileHeader.prototype.snapshotProxy):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
(WebInspector.HeapProfileHeader.prototype.loadFromFile):
LayoutTests:
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: instead of sniffing a method
call we can use HeapProfileHeader.load directly.
- 1:38 AM Changeset in webkit [117233] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Use CSS columns feature for HelpScreen contents.
https://bugs.webkit.org/show_bug.cgi?id=86367
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-16
Reviewed by Yury Semikhatsky.
Right-docked inspector should show shortcuts/settings in one column.
Bottom-docked inspector should use horizontal space more effectively
(more than 2 columns in shortcuts/settings).
Please see attached screenshots.
UI adjustments, no new tests.
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen): Turned table to div.
(WebInspector.SettingsScreen.prototype._appendSection): Removed.
- inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsScreen.prototype._buildTable): Removed "balancing" algorithm.
(WebInspector.ShortcutsSection.prototype.renderSection): Turned table to div.
(WebInspector.ShortcutsSection.prototype._renderHeader): Ditto.
- inspector/front-end/helpScreen.css: Use CSS columns feature.
(.help-container): Added columns container.
(.help-block): Added "section".
(.help-line): Added key shortcut line.
(.help-key-cell): Added key shortcut cell.
(.help-cell): Ditto
(.help-section-title): Combined title classes
(.help-content p): Adjusted spacing.
- 1:18 AM Changeset in webkit [117232] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update
Removes unnecessary entries and added suppressions
for some flaky tests on cr-linux ews.
- platform/chromium/test_expectations.txt:
- 1:00 AM Changeset in webkit [117231] by
-
- 1 edit in branches/chromium/1132/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
Merge 116556 - [chromium] Check whether an active document loader exists before accessing it
https://bugs.webkit.org/show_bug.cgi?id=85892
Reviewed by Eric Seidel.
Although FrameLoader::loadInSameDocument which invokes this
method does not have a provisional document loader, we're seeing crashes
where the FrameLoader is in provisional state, and thus
activeDocumentLoader returns 0. Lacking any understanding of how this
can happen, we do this check here to avoid crashing.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391159
- 12:47 AM Changeset in webkit [117230] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Adding myself(yosin@chromium.org) to committers list
- 12:44 AM Changeset in webkit [117229] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG TRef/Use NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=78700
Add testcase covering a problem fixed in trunk.
- svg/custom/bug78700-expected.txt: Added.
- svg/custom/bug78700.svg: Added.
- 12:41 AM Changeset in webkit [117228] by
-
- 3 edits in branches/chromium/1132/Source/WebCore/inspector/front-end
Merge 116672 - Web Inspector: search title is shown beside the search field (not under) in the vertical mode.
https://bugs.webkit.org/show_bug.cgi?id=86120
Reviewed by Yury Semikhatsky.
This change makes search title render as placeholder at all times.
It also adjusts the size of the search field when navigation arrows appear.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
- inspector/front-end/inspector.css:
(#toolbar-search-item):
(.with-navigation-buttons #search):
(.toolbar-search-navigation-label):
(.with-navigation-buttons .toolbar-search-navigation-label):
- inspector/front-end/inspector.html:
TBR=pfeldman@chromium.org
BUG=126550
Review URL: https://chromiumcodereview.appspot.com/10377162
- 12:36 AM Changeset in webkit [117227] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r117050.
http://trac.webkit.org/changeset/117050
https://bugs.webkit.org/show_bug.cgi?id=86587
"Some heap profiler tests started timing out" (Requested by
yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
- 12:22 AM Changeset in webkit [117226] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r117206.
http://trac.webkit.org/changeset/117206
https://bugs.webkit.org/show_bug.cgi?id=86583
breaks chromium browser_tests (Requested by bashi1 on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):
- 12:21 AM Changeset in webkit [117225] by
-
- 17 edits6 adds in trunk
REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405
Reviewed by Darin Adler.
Source/WebCore:
Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the management of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.
Tests: svg/text/add-tspan-position-bug.html
svg/text/highcharts-assertion.html
svg/text/modify-tspan-position-bug.html
- rendering/svg/RenderSVGBlock.h:
(RenderSVGBlock):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
(WebCore::RenderSVGInline::removeChild):
- rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::~RenderSVGText):
(WebCore::collectLayoutAttributes):
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::findPreviousAndNextAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::willBeDestroyed):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::subtreeChildWasRemoved):
(WebCore::RenderSVGText::subtreeStyleDidChange):
(WebCore::RenderSVGText::subtreeTextDidChange):
(WebCore::updateFontInAllDescendants):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::removeChild):
- rendering/svg/RenderSVGText.h:
(RenderSVGText):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
- rendering/svg/SVGTextLayoutAttributesBuilder.h:
(SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::numberOfTextPositioningElements):
- svg/SVGAElement.cpp:
- svg/SVGAElement.h:
(SVGAElement):
- svg/SVGTextContentElement.cpp:
- svg/SVGTextContentElement.h:
(SVGTextContentElement):
LayoutTests:
Add three new testcases covering the problem.
- svg/text/add-tspan-position-bug-expected.html: Added.
- svg/text/add-tspan-position-bug.html: Added.
- svg/text/highcharts-assertion-expected.txt: Added.
- svg/text/highcharts-assertion.html: Added.
- svg/text/modify-tspan-position-bug-expected.html: Added.
- svg/text/modify-tspan-position-bug.html: Added.
May 15, 2012:
- 11:45 PM Changeset in webkit [117224] by
-
- 3 edits2 adds in trunk
Crash in Document::nodeChildrenWillBeRemoved.
https://bugs.webkit.org/show_bug.cgi?id=85247
Reviewed by Hajime Morita.
Source/WebCore:
Reverse ordering of commands to ref ptr the children set
first before calling nodeChildrenWillBeRemoved, since it
can fire mutation events.
Test: fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
LayoutTests:
- fast/dom/HTMLObjectElement/beforeload-set-text-crash-expected.txt: Added.
- fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml: Added.
- 11:44 PM Changeset in webkit [117223] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enhance an API of BackingStore::drawContents
https://bugs.webkit.org/show_bug.cgi?id=86447
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-15
Reviewed by George Staikos.
Enhance the current APIs by adding parameters of id and destination
contentSize, because chrome browser may want different contents from
the same webview at different times.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):
- Api/BackingStore.h:
- Api/BackingStore_p.h:
(BackingStorePrivate):
- 11:24 PM Changeset in webkit [117222] by
-
- 4 edits in trunk/Source/WebKit2
Fix Qt5/Mac build after r117212 by adding missing NETSCAPE_PLUGIN_API guards
https://bugs.webkit.org/show_bug.cgi?id=86577
Reviewed by Andy Estes.
- Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
- UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::getPluginInfo):
- WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
- 10:39 PM Changeset in webkit [117221] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 would fail to build on Windows if Netscape plug-ins were disabled.
- UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::getPluginInfo): Return false if ENABLE_NETSCAPE_PLUGIN_API is false.
- 10:36 PM Changeset in webkit [117220] by
-
- 1 edit3 adds in trunk/LayoutTests
[Worker] Web Worker lacks test for posting structured data message.
https://bugs.webkit.org/show_bug.cgi?id=86556
Patch by Li Yin <li.yin@intel.com> on 2012-05-15
Reviewed by David Levin.
From http://www.w3.org/TR/2012/CR-workers-20120501/#communicating-with-a-dedicated-worker
Structured data can be sent over the communication channel.
- fast/workers/resources/worker-structure-message.js: Added.
(self.onmessage):
- fast/workers/worker-structure-message-expected.txt: Added.
- fast/workers/worker-structure-message.html: Added.
- 10:13 PM Changeset in webkit [117219] by
-
- 1 edit in branches/chromium/1132/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
Merge 116636 - [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772
Reviewed by Kent Tamura.
On some JPEG images, vertical and horizontal lines artifacts might appear in image
regions with very high frequency color variation when using DCT_IFAST decodes. Use
DCT_IFAST on small screen devices only (Chromium Android).
No new tests. Covered by existing tests.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(dctMethod): Permit DCT_IFAST decoding for Chromium Android only.
LayoutTests: [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772
Reviewed by Kent Tamura.
- platform/chromium/test_expectations.txt: Add IMAGE expectations.
TBR=noel.gordon@gmail.com
Review URL: https://chromiumcodereview.appspot.com/10388157
- 10:06 PM Changeset in webkit [117218] by
-
- 4 edits in trunk
[EFL][DRT] Fix eventSender key providing
https://bugs.webkit.org/show_bug.cgi?id=84710
Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-15
Reviewed by Andreas Kling.
Currently eventSender doesn't provide key event correctly.
For example, 'Right' will be visible when 'right arrow' key event is fired.
Given circumstance, nothing has to be shown.
Therefore, this patch fixed incorrectly provided key event.
Tools:
- DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):
LayoutTests:
- platform/efl/Skipped:
- 10:02 PM Changeset in webkit [117217] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectation update after r117206
- platform/chromium/test_expectations.txt:
- 9:49 PM Changeset in webkit [117216] by
-
- 4 edits2 adds in trunk
regression(111639): Issue with simultaneous CSS animations
https://bugs.webkit.org/show_bug.cgi?id=85929
Source/WebCore:
Currently, previousTimeToNextService is just saving the previous CompositeAnimation::timeToNextService
for AnimationControllerPrivate::updateAnimationTimerForRenderer, however CompositeAnimation::timeToNextService
is also called and used by updateAnimationTimer. Make sure we save the existing timeToNextService from
both places, updateAnimationTimerForRenderer and updateAnimationTimer.
Reviewed by Dean Jackson.
Test: animations/fill-mode-forwards.html
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
- page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):
LayoutTests:
Reviewed by Dean Jackson.
- animations/fill-mode-forwards-expected.txt: Added.
- animations/fill-mode-forwards.html: Added.
- 9:31 PM Changeset in webkit [117215] by
-
- 2 edits in trunk/Tools
Fixed a typo.
- Scripts/copy-webkitlibraries-to-product-directory:
- 9:07 PM Changeset in webkit [117214] by
-
- 4 edits in trunk/Source
[Chromium] CCTimer::isActive() is incorrect inside tick callback
https://bugs.webkit.org/show_bug.cgi?id=86513
Source/WebCore:
This patch implements CCTimer::isActive() by clearing the task pointer
when the timer fires.
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-05-15
Reviewed by James Robinson.
No new tests. Existing tests updated accordingly.
- platform/graphics/chromium/cc/CCTimer.cpp:
(WebCore::CCTimerTask::performTask):
- rendering/RenderLayerBacking.cpp:
Source/WebKit/chromium:
Update test cases to verify CCTimer::isActive() values.
Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-05-15
Reviewed by James Robinson.
- tests/CCTimerTest.cpp:
(WebKitTests::TEST_F):
- 9:00 PM Changeset in webkit [117213] by
-
- 12 edits2 deletes in trunk/Source
Unreviewed, rolling out r117204.
http://trac.webkit.org/changeset/117204
https://bugs.webkit.org/show_bug.cgi?id=86559
causing win compilation failures (Requested by pilgrim_google_
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15
Source/Platform:
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
- chromium/public/WebMessagePortChannel.h: Removed.
- chromium/public/WebMessagePortChannelClient.h: Removed.
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebMessagePortChannel.h:
(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createMessagePortChannel):
- src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
- src/PlatformMessagePortChannel.h:
- src/SharedWorkerRepository.cpp:
- src/WebSharedWorkerImpl.cpp:
- src/WebWorkerClientImpl.cpp:
- 8:55 PM Changeset in webkit [117212] by
-
- 35 edits in trunk/Source/WebKit2
Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
https://bugs.webkit.org/show_bug.cgi?id=86496
Reviewed by Sam Weinig.
Ensure that WebKit2 can compile with ENABLE_NETSCAPE_PLUGIN_API disabled.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
- Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.h:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.h:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
- WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
- WebProcess/Plugins/PluginController.h:
(PluginController):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::Stream::didFinishLoading):
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::scriptObject):
(WebKit):
- WebProcess/Plugins/PluginView.h:
(PluginView):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):
- 8:49 PM Changeset in webkit [117211] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests results.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertyDescriptor):
- 8:07 PM Changeset in webkit [117210] by
-
- 17 edits in trunk/Source
Rename Node::shadowTreeRootNode() to Node::shadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=86449
Reviewed by Darin Adler.
Source/WebCore:
Since Node::shadowTreeRootNode() returns always a ShadowRoot now, shadowRoot() is
mure suitable than shadowTreeRootNode().
This patch changes the method name.
No new tests, no change in behavior.
- WebCore.order:
- dom/Node.cpp:
(WebCore::Node::rendererIsEditable):
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::shadowRoot):
- dom/Node.h:
(Node):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
- dom/Range.cpp:
(WebCore::Range::shadowRoot):
- dom/Range.h:
(Range):
- editing/Editor.cpp:
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::countMatchesForText):
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleReplacedElement):
- editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::matches):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::detach):
- page/EventHandler.cpp:
(WebCore::instanceAssociatedWithShadowTreeElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::correspondingElement):
(WebCore::collectInstancesForSVGElement):
Source/WebKit/chromium:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
- 8:03 PM Changeset in webkit [117209] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove some unused gyp lines
https://bugs.webkit.org/show_bug.cgi?id=86545
Reviewed by Dirk Pranke.
mac_framework_dirs adds directories to search for frameworks
(similar to -I for includes), it doesn't add any frameworks.
Having something that ends in .framewok in mac_framework_dirs
doesn't make sense.
No intended functionality change.
- WebCore.gyp/WebCore.gyp:
- 7:55 PM Changeset in webkit [117208] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening for Qt.
These tests were unskipped but their expectations were not up-to-date.
- platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt:
- platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
- 7:54 PM Changeset in webkit [117207] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] build a static list of mime-types
https://bugs.webkit.org/show_bug.cgi?id=86331
Reviewed by Martin Robinson.
Don't bother parsing the gstreamer typefind factories and doing
ugly hacks around this. Instead build a static list and let our
::supportsType() method return MediaPlayer::MayBeSupported or
MediaPlayer::IsSupported for them. Playback will still fail if a
demuxer or decoder is missing for one of these mime-types but we
will handle that case more properly soon by fixing bug 34085 and
bug 34318.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- 7:49 PM Changeset in webkit [117206] by
-
- 3 edits in trunk/Source/WebCore
MHTML files should be loadable from all schemes considered local,
not just file:
https://bugs.webkit.org/show_bug.cgi?id=86540
Patch by Greg Spencer <gspencer@chromium.org> on 2012-05-15
Reviewed by Adam Barth.
Current tests should assure that loading is still allowed locally.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):
- 7:34 PM Changeset in webkit [117205] by
-
- 10 edits10 adds in trunk
[EFL] Enable Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=85870
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.
.:
Enable FULLSCREEN_API on the Efl port.
- Source/cmake/OptionsEfl.cmake:
Source/WebKit/efl:
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::supportsFullScreenForElement):
Add check routine if the full screen is enabled by page setting.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
Add full screen setting to be true.
Tools:
Enable full screen api feature on the EFL port.
There are two failed test cases under LayoutTests/fullscreen.
They are going to be fixed with other patch.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/efl/Skipped: Remove fullscreen/video-controls-override.html.
- platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
- platform/efl/fullscreen/full-screen-placeholder-expected.txt: Added.
- platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
- platform/efl/fullscreen/full-screen-render-inline-expected.txt: Added.
- platform/efl/fullscreen/full-screen-stacking-context-expected.png: Added.
- platform/efl/fullscreen/full-screen-zIndex-after-expected.png: Added.
- platform/efl/fullscreen/full-screen-zIndex-expected.png: Added.
- platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
- platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
- platform/efl/test_expectations.txt: Remove fullscreen and media/video-play-require-user-gesture.html
- Add full-screen-keyboard-disabled.html and video-controls-drag.html to the efl's test_expectation.txt
- 7:30 PM Changeset in webkit [117204] by
-
- 12 edits2 copies in trunk/Source
[Chromium] Move createMessagePortChannel to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85764
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createMessagePortChannel):
- chromium/public/WebMessagePortChannel.h: Added.
(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):
- chromium/public/WebMessagePortChannelClient.h: Added.
(WebKit):
(WebMessagePortChannelClient):
(WebKit::WebMessagePortChannelClient::~WebMessagePortChannelClient):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebMessagePortChannel.h:
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
- src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
- src/PlatformMessagePortChannel.h:
- src/SharedWorkerRepository.cpp:
- src/WebSharedWorkerImpl.cpp:
- src/WebWorkerClientImpl.cpp:
- 7:00 PM Changeset in webkit [117203] by
-
- 6 edits in trunk/Source
[Chromium] Reset ScriptInstance in HTMLPlugInElement on WebPluginContainerImpl::setPlugin
https://bugs.webkit.org/show_bug.cgi?id=86535
Source/WebCore:
Reviewed by Darin Fisher.
When we swap out WebPluginImpls for the Browser Plugin, the HTMLPlugInElement continues
to use a now invalid ScriptInstance, so we reset the ScriptInstance on WebPluginContainerImpl::setPlugin
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::resetInstance):
(WebCore):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
Source/WebKit/chromium:
Reviewed by Darin Fisher.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setPlugin):
(WebKit):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 6:46 PM Changeset in webkit [117202] by
-
- 10 edits2 copies in trunk/Source
[Chromium] Move blobRegistry to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85765
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::blobRegistry):
- chromium/public/WebBlobData.h: Added.
(WebKit):
(WebBlobData):
(WebKit::WebBlobData::~WebBlobData):
(WebKit::WebBlobData::WebBlobData):
(WebKit::WebBlobData::isNull):
- chromium/public/WebBlobRegistry.h: Added.
(WebKit):
(WebBlobRegistry):
(WebKit::WebBlobRegistry::~WebBlobRegistry):
Source/WebKit/chromium:
- WebKit.gyp:
- public/platform/WebBlobData.h:
- public/platform/WebBlobRegistry.h:
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::cookieJar):
- src/BlobRegistryProxy.cpp:
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
- src/WebBlobData.cpp:
- 6:44 PM Changeset in webkit [117201] by
-
- 2 edits in trunk/Source/JavaScriptCore
Block freeing thread should not free blocks when we are actively requesting them
https://bugs.webkit.org/show_bug.cgi?id=86519
Reviewed by Geoff Garen.
- heap/BlockAllocator.h:
(JSC::BlockAllocator::allocate): Reordering the setting of the flag so its done
while we hold the lock to ensure proper locking.
- 6:42 PM Changeset in webkit [117200] by
-
- 8 edits1 add in trunk/Source/WebKit/chromium
[chromium] Overloaded printBegin() function to support auto fit to page functionality.
https://bugs.webkit.org/show_bug.cgi?id=84312
Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-05-15
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebFrame.h:
(WebKit):
(WebFrame):
- public/WebPlugin.h:
(WebKit):
(WebPlugin):
(WebKit::WebPlugin::printBegin):
- public/WebPrintParams.h: Added.
(WebKit):
(WebPrintParams):
(WebKit::WebPrintParams::WebPrintParams):
- src/WebFrameImpl.cpp:
(WebKit::ChromePluginPrintContext::ChromePluginPrintContext):
(WebKit::ChromePluginPrintContext::computePageRects):
(ChromePluginPrintContext):
(WebKit):
(WebKit::WebFrameImpl::printBegin):
- src/WebFrameImpl.h:
(WebKit):
(WebFrameImpl):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::printBegin):
- src/WebPluginContainerImpl.h:
(WebKit):
(WebPluginContainerImpl):
- 6:28 PM WebKit Team edited by
- Add yosin to Committers list (diff)
- 6:24 PM Changeset in webkit [117199] by
-
- 2 edits1 add in trunk/Source/WebKit/chromium
[chromium] Add unit testing to WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=86421
Reviewed by Adrienne Walker.
- WebKit.gypi:
- tests/WebTransformationMatrixTest.cpp: Added.
(WebKit):
(WebKit::printTransform):
(WebKit::initializeTestMatrix):
(WebKit::initializeTestMatrix2):
(WebKit::TEST):
- 6:16 PM WebInspector edited by
- (diff)
- 5:56 PM Changeset in webkit [117198] by
-
- 9 edits in trunk/Source
shrinkToFit() is often not called for Vectors in CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=86436
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The vectors in CodeBlock are often appended to during various stages of
compilation, but we neglect to shrink them after compilation finishes. This
patch takes the most brutal possible approach: shrink all the vectors after
the bytecompile phase, and then shrink them again after the appropriate
JITing phase. The two shrinks are necessary because the JIT may append more
stuff, but may also generate code that directly references things in other
vectors; hence some can only be shrunk before JIT and some after. Also,
we may allow a CodeBlock to sit around for a long time - possibly forever -
before invoking the JIT, hence it makes sense to have two shrinks.
This is performance neutral on the major benchmarks we track.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::appendWeakReferenceTransition):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
Source/WTF:
Reviewed by NOBODY (OOPS!).
Gave SegmentedVector a shrinkToFit() method. This only shrinks the segment
lookup table, which is likely to not be hugely profitable, but it is better
than nothing.
- wtf/SegmentedVector.h:
(SegmentedVector):
(WTF::SegmentedVector::shrinkToFit):
- 5:56 PM Changeset in webkit [117197] by
-
- 5 edits292 deletes in trunk
Heap-use-after-free in WebCore::RenderBlock::layoutRunsAndFloats
https://bugs.webkit.org/show_bug.cgi?id=86206
Reviewed by Abhishek Arya.
Source/WebCore:
Revert https://trac.webkit.org/changeset/116438/. It caused three different regressions on
ClusterFuzz.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderBlock.h:
(RenderBlock):
LayoutTests:
Revert https://trac.webkit.org/changeset/116438/ and subsequent pixel results. It caused three different regressions on
ClusterFuzz.
- css2.1/20110323/first-letter-000.htm: Removed.
- css2.1/20110323/first-letter-001.htm: Removed.
- css2.1/20110323/first-letter-dynamic-001.htm: Removed.
- css2.1/20110323/first-letter-dynamic-002.htm: Removed.
- css2.1/20110323/first-letter-dynamic-003a.htm: Removed.
- css2.1/20110323/first-letter-dynamic-003b.htm: Removed.
- css2.1/20110323/first-letter-inherit-001.htm: Removed.
- css2.1/20110323/first-letter-nested-001.htm: Removed.
- css2.1/20110323/first-letter-nested-002.htm: Removed.
- css2.1/20110323/first-letter-nested-003.htm: Removed.
- css2.1/20110323/first-letter-nested-004.htm: Removed.
- css2.1/20110323/first-letter-nested-005.htm: Removed.
- css2.1/20110323/first-letter-nested-006.htm: Removed.
- css2.1/20110323/first-letter-nested-007.htm: Removed.
- css2.1/20110323/first-letter-quote-001.htm: Removed.
- css2.1/20110323/first-letter-quote-002.htm: Removed.
- css2.1/20110323/first-letter-quote-003.htm: Removed.
- css2.1/20110323/first-letter-quote-004.htm: Removed.
- css2.1/20110323/first-letter-quote-005.htm: Removed.
- css2.1/20110323/first-letter-quote-006.htm: Removed.
- fast/css/first-letter-capitalized-edit-select-crash-expected.txt:
- fast/css/first-letter-nested-positioned.htm: Removed.
- fast/css/first-letter-quotes-no-content-before-after.html: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-001-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/chromium-linux/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/chromium-linux/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/chromium-mac-leopard/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/chromium-mac-leopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-000-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-001-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
- platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.txt: Removed.
- platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-000-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-001-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
- platform/chromium-win/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/chromium-win/fast/css/first-letter-nested-positioned-expected.txt: Removed.
- platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-000-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-001-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/efl/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
- platform/efl/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/efl/fast/css/first-letter-nested-positioned-expected.txt: Removed.
- platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-000-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
- platform/gtk/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
- platform/gtk/fast/css/first-letter-nested-positioned-expected.txt: Removed.
- platform/gtk/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-000-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
- platform/mac/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
- platform/mac/fast/css/first-letter-nested-positioned-expected.txt: Removed.
- platform/mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-000-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-000-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-001-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-inherit-001-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-inherit-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-001-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-002-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-002-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-003-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-003-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-004-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-004-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-005-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-005-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-006-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-006-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-007-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-nested-007-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-001-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-001-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-002-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-002-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-003-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-003-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-004-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-004-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-005-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-005-expected.txt: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-006-expected.png: Removed.
- platform/qt/css2.1/20110323/first-letter-quote-006-expected.txt: Removed.
- platform/qt/fast/css/first-letter-nested-positioned-expected.png: Removed.
- platform/qt/fast/css/first-letter-nested-positioned-expected.txt: Removed.
- platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.png: Removed.
- platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Removed.
- 5:37 PM Changeset in webkit [117196] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86549
Page Scale + Tiled Drawing: Twitter sign in page content disappears
after typing into name and enabling password field
-and corresponding-
<rdar://problem/11415352>
Reviewed by Oliver Hunt.
The enormous rect we used to use would overflow in CA and do nothing
when there was any scale > 1 on the context. Instead, just call
setNeedsDisplay on each tile.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplay):
- 5:34 PM Changeset in webkit [117195] by
-
- 257 edits in trunk/Source/WebCore
Pass Attribute by const reference as much as possible.
<http://webkit.org/b/86487>
Reviewed by Darin Adler.
Switch to passing around "const Attribute&" instead of "Attribute*" wherever possible.
This helps enforce the constness and non-nullity of these arguments at compile time.
Also renamed 'attr' to 'attribute' in the touched code. Attr and Attribute are two
different classes, so having "Attribute attr" just looks wrong.
- bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/js/ScriptEventListener.h:
- bindings/v8/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
- bindings/v8/ScriptEventListener.h:
- dom/Attr.cpp:
(WebCore::Attr::setPrefix):
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
(WebCore::Attr::style):
(WebCore::Attr::elementAttribute):
- dom/Attr.h:
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):
- dom/Element.h:
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::setAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::updateAttributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::collectStyleForAttribute):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- html/HTMLAnchorElement.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::parseAttribute):
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseAttribute):
- html/HTMLAreaElement.h:
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
- html/HTMLBRElement.h:
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::parseAttribute):
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForAttribute):
(WebCore::HTMLBodyElement::parseAttribute):
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseAttribute):
- html/HTMLButtonElement.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::parseAttribute):
- html/HTMLCanvasElement.h:
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::parseAttribute):
- html/HTMLDetailsElement.h:
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForAttribute):
- html/HTMLDivElement.h:
- html/HTMLElement.cpp:
(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::dirAttributeChanged):
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectStyleForAttribute):
(WebCore::HTMLEmbedElement::parseAttribute):
- html/HTMLEmbedElement.h:
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
- html/HTMLFontElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseAttribute):
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseAttribute):
- html/HTMLFormElement.h:
- html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::parseAttribute):
- html/HTMLFrameElement.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::collectStyleForAttribute):
(WebCore::HTMLFrameSetElement::parseAttribute):
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
- html/HTMLHRElement.h:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::collectStyleForAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::collectStyleForAttribute):
(WebCore::HTMLImageElement::parseAttribute):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::collectStyleForAttribute):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::parseMaxLengthAttribute):
- html/HTMLInputElement.h:
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::parseAttribute):
- html/HTMLKeygenElement.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForAttribute):
(WebCore::HTMLLIElement::parseAttribute):
- html/HTMLLIElement.h:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
- html/HTMLLinkElement.h:
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseAttribute):
- html/HTMLMapElement.h:
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
- html/HTMLMarqueeElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::parseAttribute):
- html/HTMLMetaElement.h:
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::parseAttribute):
- html/HTMLMeterElement.h:
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForAttribute):
(WebCore::HTMLOListElement::parseAttribute):
- html/HTMLOListElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::collectStyleForAttribute):
(WebCore::HTMLObjectElement::parseAttribute):
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::parseAttribute):
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::parseAttribute):
- html/HTMLOptionElement.h:
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::parseAttribute):
- html/HTMLOutputElement.h:
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForAttribute):
- html/HTMLParagraphElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::collectStyleForAttribute):
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::collectStyleForAttribute):
- html/HTMLPreElement.h:
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::parseAttribute):
- html/HTMLProgressElement.h:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute):
- html/HTMLScriptElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::parseMultipleAttribute):
- html/HTMLSelectElement.h:
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute):
- html/HTMLStyleElement.h:
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
(WebCore::HTMLTableCellElement::parseAttribute):
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::collectStyleForAttribute):
(WebCore::HTMLTableColElement::parseAttribute):
- html/HTMLTableColElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForAttribute):
(WebCore::HTMLTableElement::parseAttribute):
- html/HTMLTableElement.h:
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
- html/HTMLTablePartElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
(WebCore::HTMLTextAreaElement::parseAttribute):
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::parseAttribute):
- html/HTMLTextFormControlElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute):
- html/HTMLTrackElement.h:
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForAttribute):
- html/HTMLUListElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::collectStyleForAttribute):
(WebCore::HTMLVideoElement::parseAttribute):
- html/HTMLVideoElement.h:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
- html/shadow/HTMLContentElement.h:
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::collectStyleForAttribute):
- mathml/MathMLElement.h:
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::parseAttribute):
- svg/SVGAElement.h:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::parseAttribute):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::parseAttribute):
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseAttribute):
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::parseAttribute):
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::parseAttribute):
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::parseAttribute):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::parseAttribute):
- svg/SVGCursorElement.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::reportAttributeParsingError):
(WebCore::SVGElement::parseAttribute):
(WebCore::SVGElement::attributeChanged):
- svg/SVGElement.h:
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::parseAttribute):
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.cpp:
(WebCore::SVGExternalResourcesRequired::parseAttribute):
- svg/SVGExternalResourcesRequired.h:
(SVGExternalResourcesRequired):
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::parseAttribute):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::parseAttribute):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::parseAttribute):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::parseAttribute):
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::parseAttribute):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::parseAttribute):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::parseAttribute):
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::parseAttribute):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseAttribute):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::parseAttribute):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::parseAttribute):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::parseAttribute):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::parseAttribute):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::parseAttribute):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::parseAttribute):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::parseAttribute):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::parseAttribute):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute):
- svg/SVGFilterPrimitiveStandardAttributes.h:
(SVGFilterPrimitiveStandardAttributes):
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseAttribute):
- svg/SVGFitToViewBox.h:
(SVGFitToViewBox):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::parseAttribute):
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::parseAttribute):
- svg/SVGFontFaceUriElement.h:
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::parseAttribute):
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::parseAttribute):
- svg/SVGGElement.h:
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::parseAttribute):
- svg/SVGGlyphElement.h:
- svg/SVGGlyphRefElement.cpp:
(WebCore::SVGGlyphRefElement::parseAttribute):
- svg/SVGGlyphRefElement.h:
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::parseAttribute):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForAttribute):
(WebCore::SVGImageElement::parseAttribute):
- svg/SVGImageElement.h:
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::sourceURI):
- svg/SVGLangSpace.cpp:
(WebCore::SVGLangSpace::parseAttribute):
- svg/SVGLangSpace.h:
(SVGLangSpace):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::parseAttribute):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::parseAttribute):
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::parseAttribute):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::parseAttribute):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::parseAttribute):
- svg/SVGMaskElement.h:
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::parseAttribute):
- svg/SVGPathElement.h:
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::parseAttribute):
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::parseAttribute):
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::parseAttribute):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::parseAttribute):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::parseAttribute):
- svg/SVGScriptElement.h:
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::parseAttribute):
- svg/SVGStopElement.h:
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::parseAttribute):
- svg/SVGStyleElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::parseAttribute):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::parseAttribute):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::parseAttribute):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::parseAttribute):
- svg/SVGTRefElement.h:
- svg/SVGTests.cpp:
(WebCore::SVGTests::parseAttribute):
- svg/SVGTests.h:
(SVGTests):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::parseAttribute):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::parseAttribute):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::parseAttribute):
- svg/SVGTextPositioningElement.h:
- svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::parseAttribute):
- svg/SVGURIReference.h:
(SVGURIReference):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::parseAttribute):
- svg/SVGUseElement.h:
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::parseAttribute):
- svg/SVGViewElement.h:
- svg/SVGZoomAndPan.cpp:
(WebCore::SVGZoomAndPan::parseAttribute):
- svg/SVGZoomAndPan.h:
(SVGZoomAndPan):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseAttribute):
- svg/animation/SVGSMILElement.h:
- 5:32 PM Changeset in webkit [117194] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/test_expectations.txt
Stable gardening - getting a test expectation baseline
- 5:21 PM Changeset in webkit [117193] by
-
- 3 edits in trunk/Source/JavaScriptCore
Make error information available even if all we have is line number information.
https://bugs.webkit.org/show_bug.cgi?id=86547
Reviewed by Filip Pizlo.
We don't need expression information to generate useful line, file, and stack information,
so only require that we have line number info available.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
- runtime/Executable.h:
(JSC):
- 5:01 PM Changeset in webkit [117192] by
-
- 1 edit in branches/safari-536-branch/Source/JavaScriptCore/ChangeLog
Merged r116785.
- 5:00 PM Changeset in webkit [117191] by
-
- 6 edits in trunk/Source/WebCore
Assertion failure running Mozilla's WebGL performance regression tests
https://bugs.webkit.org/show_bug.cgi?id=85942
Reviewed by Stephen White.
Fixed incorrect assumptions about source formats and buffer sizes
when uploading to floating-point textures. Added code paths
supporting the necessary conversions.
Tests have been added to the WebGL conformance suite which cover
these new code paths; they verify uploads of HTMLCanvasElement,
HTMLImageElement, HTMLVideoElement, and ImageData to
floating-point textures. However, because floating-point texture
support is optional, and generally only supported on bots which
run with real GPUs and not in virtual machines, it isn't feasible
to incorporate these tests as layout tests.
Ran the new WebGL conformance tests in Chromium on Linux; all
pass.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData):
Properly compute size of destination buffer.
(WebCore):
Add pack/unpack routines for converting RGBA8/BGRA8 to floating point.
(WebCore::doFloatingPointPacking):
Support RGBA8 and BGRA8 source formats.
(WebCore::isFloatingPointSource):
Factored out logic for assertions.
(WebCore::GraphicsContext3D::packPixels):
Generalized assertions and logic.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.
- platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
Properly compute size of destination buffer.
- 4:58 PM Changeset in webkit [117190] by
-
- 13 edits in trunk
[chromium] Chromium port never sets USE(CG) so code behind it is dead
https://bugs.webkit.org/show_bug.cgi?id=86537
Reviewed by Adrienne Walker.
Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.
Source/WebCore:
- platform/chromium/DragImageRef.h:
(WebCore):
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
- platform/chromium/ThemeChromiumMac.mm:
(WebCore::paintStepper):
- platform/graphics/chromium/PlatformImage.cpp:
(WebCore::PlatformImage::updateFromImage):
Source/WebKit/chromium:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3D::grContext):
- src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- src/PlatformSupport.cpp:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintRect):
- 4:57 PM Changeset in webkit [117189] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r117169.
- platform/efl/test_expectations.txt: Unskip test that now passes.
- 4:54 PM Changeset in webkit [117188] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r117160.
- platform/efl/test_expectations.txt: Skip test that depends on blob
support.
- 4:52 PM Changeset in webkit [117187] by
-
- 5 edits in trunk
Skia does not respect a specified InterpolationQuality
https://bugs.webkit.org/show_bug.cgi?id=86249
Patch by Keyar Hood <keyar@chromium.org> on 2012-05-15
Reviewed by Stephen White.
Source/WebCore:
The added functionality is not exposed to higher layers of webkit.
Tests will be added that will exercise these changes when bug 82804 is
fixed.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
Code to have the useLowQualityScale cause the InterpolationQuality be
be set to low for Chromium but remain as none for other platforms.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::limitResamplingMode): Added
(WebCore):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
We now limit the resampling choice based on what InterpolationQuality
is set as. InterpolationNone restricts resampling to RESAMPLE_NONE,
InterpolationLow and InterpolationMedium restricts resampling to
RESAMPLE_LINEAR. InterpolationHigh and InterpolationDefault do not
change the resampling.
Furthermore, the choice on how to set the filter bitmap flag in
paintSkBitmap was made to be consistent with that in
Image::drawPattern.
LayoutTests:
Now expecting the following to tests to have an IMAGE failure:
svg/custom/pointer-events-image-css-transform.svg
svg/custom/pointer-events-image.svg
- platform/chromium/test_expectations.txt:
- 4:51 PM Changeset in webkit [117186] by
-
- 5 edits in trunk
[chromium] Remove WEBKIT_USING_(SKIA|CG) #defines
https://bugs.webkit.org/show_bug.cgi?id=86536
Reviewed by Adam Barth.
Source/Platform:
The Chromium port always using Skia, so WEBKIT_USING_CG has been dead code for many moons.
- chromium/public/WebCommon.h:
Tools:
Deletes dead WEBKIT_USING_CG code and #ifdefs guarding it.
- DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::paintPagesWithBoundaries):
- 4:48 PM Changeset in webkit [117185] by
-
- 2 edits in trunk/Source/WebCore
ImageDocuments erroneously trigger beforeload events for the main resource
https://bugs.webkit.org/show_bug.cgi?id=86543
<rdar://problem/11309013>
Reviewed by Brady Eidson.
No new tests; testing framework doesn't allow for testing ImageDocuments with injected JavaScript.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- 4:41 PM Changeset in webkit [117184] by
-
- 3 edits in trunk/Tools
[chromium] Unreviewed build fix.
Partial revert of r117166 - it appears making DumpRenderTree depend on webkit_platform causes crashes in the
component build, at least on linux. This restores Tools/DumpRenderTree to its pre-r117166 state.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::initialize):
- 4:38 PM Changeset in webkit [117183] by
-
- 3 edits in trunk/Source/JavaScriptCore
Block freeing thread should not free blocks when we are actively requesting them
https://bugs.webkit.org/show_bug.cgi?id=86519
Reviewed by Geoffrey Garen.
The block freeing thread shoots us in the foot if it decides to run while we're actively
requesting blocks and returning them. This situation can arise when there is a lot of copying
collection going on in steady state. We allocate a large swath of pages to copy into, then we
return all the newly free old pages to the BlockAllocator. In this state, if the block freeing
thread wakes up in between collections (which is more likely than it waking up during a
collection) and frees half of these pages, they will be needed almost immediately during the
next collection, causing a storm of VM allocations which we know are going to be very slow.
What we'd like is for when things have quieted down the block freeing thread can then return
memory to the OS. Usually this will be when a page has fully loaded and has a low allocation
rate. In this situation, our opportunistic collections will only be running at least every few
seconds, thus the extra time spent doing VM allocations won't matter nearly as much as, say,
while a page is loading.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::BlockAllocator): Initialize our new field.
(JSC::BlockAllocator::blockFreeingThreadMain): We check if we've seen any block requests recently.
If so, reset our flag and go back to sleep. We also don't bother with locking here. If we miss out
on an update, we'll see it when we wake up again.
- heap/BlockAllocator.h: Add new field to track whether or not we've received recent block requests.
(BlockAllocator):
(JSC::BlockAllocator::allocate): If we receive a request for a block, set our field that tracks
that to true. We don't bother locking since we assume that writing to a bool is atomic.
- 4:36 PM Changeset in webkit [117182] by
-
- 2 edits in trunk/Source/WebCore
[chromium] ScrollElasticityController.mm doesn't compile with the 10.6 SDK on mac
https://bugs.webkit.org/show_bug.cgi?id=86544
Reviewed by Anders Carlsson.
This is a build fix for now until we can figure out what a
better way to approach this is.
- platform/mac/ScrollElasticityController.mm:
(WebCore):
- 4:31 PM Changeset in webkit [117181] by
-
- 4 edits in trunk/Source/WebCore
MainResourceLoader::load() always returns true, so make it return
void and delete the related dead code.
https://bugs.webkit.org/show_bug.cgi?id=86413
Reviewed by Alexey Proskuryakov.
No new tests, cleanup only.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::load):
- loader/MainResourceLoader.h:
(MainResourceLoader):
- 4:31 PM Changeset in webkit [117180] by
-
- 32 edits1 delete in branches/safari-536-branch
Rollout 116009.
- 4:23 PM Changeset in webkit [117179] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Rollout 116013.
- 4:21 PM Changeset in webkit [117178] by
-
- 6 edits in branches/safari-536-branch/LayoutTests
Rollout 116070.
- 4:21 PM Changeset in webkit [117177] by
-
- 2 edits in trunk/Source/WebKit/chromium
Set the new PlatformWheelEvent member variables to sane defaults
https://bugs.webkit.org/show_bug.cgi?id=86542
Reviewed by Andreas Kling.
- src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
- 4:20 PM Changeset in webkit [117176] by
-
- 2 edits in branches/safari-536-branch/LayoutTests
Rollout 116143.
- 4:16 PM Changeset in webkit [117175] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/test_expectations.txt: Skip the mediastream tests
because the GTK+ implementation is incomplete.
- 4:12 PM Changeset in webkit [117174] by
-
- 32 edits7 copies in branches/safari-536-branch
roll 116009 back in, removed out of order.
- 4:05 PM Changeset in webkit [117173] by
-
- 32 edits1 delete in branches/safari-536-branch
Rollout 116009.
- 3:59 PM Changeset in webkit [117172] by
-
- 2 edits in trunk/LayoutTests
[Qt]3 fast/borders tests assert intermittently
https://bugs.webkit.org/show_bug.cgi?id=67994
Reviewed by Darin Adler.
These tests are now passing even with --iteration 1000.
- platform/qt/Skipped:
- 3:51 PM Changeset in webkit [117171] by
-
- 11 edits in trunk/Source
[chromium] Ensure animations get ticked at least once when added.
https://bugs.webkit.org/show_bug.cgi?id=86013
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-15
Reviewed by James Robinson.
Source/WebCore:
Tested in
CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didAddAnimation):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(CCSingleThreadProxyAnimationTimer):
(WebCore::CCSingleThreadProxyAnimationTimer::create):
(WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer):
(WebCore):
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
- platform/graphics/chromium/cc/CCThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF):
- 3:34 PM Changeset in webkit [117170] by
-
- 6 edits in trunk/Source
[chromium] Fix unsafe viewport tag dispatch
https://bugs.webkit.org/show_bug.cgi?id=80554
Patch by Alexandre Elias <aelias@google.com> on 2012-05-15
Reviewed by Adam Barth.
In some uncommon situations (such as window.open() new tab on
Android), dispatchViewportPropertiesDidChange may early-return without
setting the page scale because the window size is not yet
available from the embedder. At that point, the previous behavior was
to call it again in layoutUpdated(), but this is unsafe since it
leaves a pending needsLayout.
I moved the dispatch call into WebViewImpl::didChangeContentsSize and
WebViewImpl::resize() instead -- these represent more explicitly the
situations where the inputs to the viewport tag calculation change. I
removed the other dispatch call from setFrameRect as it's now
redundant.
Covered by FixedLayoutInitializeAtMinimumPageScale test introduced
in http://webk.it/82949 (an assertion will fire there without
this fix).
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::didChangeContentsSize):
- 3:33 PM Changeset in webkit [117169] by
-
- 6 edits in trunk/LayoutTests
Result of fast/dom/DOMException/stack-trace.html depends on path (test introduced in r117016)
https://bugs.webkit.org/show_bug.cgi?id=86442
Reviewed by Darin Adler.
This fixes the test to not print the invalid value (which includes file paths) for the JSC fail case.
- fast/dom/DOMException/stack-trace-expected.txt:
- fast/dom/DOMException/stack-trace.html:
- platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:
- platform/gtk/test_expectations.txt:
- platform/qt/Skipped:
- 3:14 PM WebKit Team edited by
- Add Jacky Jiang in the committer list. (diff)
- 3:05 PM Changeset in webkit [117168] by
-
- 2 edits in trunk/Tools
add unit test for NRWT's --additional-expectations option
https://bugs.webkit.org/show_bug.cgi?id=86501
Patch by Elliot Poger <epoger@google.com> on 2012-05-15
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_additional_expectations):
- 2:48 PM Changeset in webkit [117167] by
-
- 8 edits in branches/safari-536-branch/Source
Merge fix for radar 11401642.
- 2:48 PM Changeset in webkit [117166] by
-
- 8 edits in trunk
[chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
https://bugs.webkit.org/show_bug.cgi?id=86524
Reviewed by Adam Barth.
Source/Platform:
Moves createOffscreenGraphicsContext3D(), previously on WebKitPlatformSupport, to WebKit::Platform.
- chromium/public/Platform.h:
(Platform):
(WebKit::Platform::createOffscreenGraphicsContext3D):
Source/WebKit/chromium:
Moves createOffscreenGraphicsContext3D() out (to WebKit::Platform) and updates GraphicsContext3DChromium to use
the new location. Also removes a few unnecessary includes from GraphicsContext3DChromium.cpp.
- public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::create):
Tools:
Updates TestWebPlugin to use the Platform headers and updates the build dependencies so it can.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::initialize):
- 2:43 PM Changeset in webkit [117165] by
-
- 2 edits in trunk/Source/WebCore
r117147 causes a null-deref crash in DOMImplementation::createDocument()
https://bugs.webkit.org/show_bug.cgi?id=86532
Reviewed by James Robinson.
No new tests, but fixes many crashing tests.
Protect against the possibility of being passed a NULL frame in
DOMImplementation::createDocument().
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- 2:39 PM Changeset in webkit [117164] by
-
- 6 edits in branches/safari-536-branch/Source
Merge fix for radar 10887709.
- 2:38 PM Changeset in webkit [117163] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=86527
http/tests/media/video-query-url.html fails on Lion bots
Add it to the skipped list until Eric can explore.
- platform/mac-lion/Skipped:
- 2:33 PM Changeset in webkit [117162] by
-
- 5 edits in trunk/Source/WebCore
Use posZOrderList() / negZOrderList() everywhere to avoid querying dirtied lists
https://bugs.webkit.org/show_bug.cgi?id=86416
Reviewed by Simon Fraser.
Covered by existing tests that are not ASSERTing after this change.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::update3DTransformedDescendantStatus):
Added a call to updateZOrderLists() to the previous sites as nothing guarantees
that we have recomputed our z-order lists.
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::needsContentsCompositingLayer):
Converted those functions to use the safe getters.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::hasNegativeZOrderList):
Newly added funtion to return if we have a negative z-order list.
- 2:29 PM Changeset in webkit [117161] by
-
- 3 edits2 adds in trunk
Source/WebCore: Crash due shadow tree parent confusion in SVG.
https://bugs.webkit.org/show_bug.cgi?id=84248
Reviewed by Nikolas Zimmermann.
Test: svg/foreignObject/viewport-foreignobject-crash.html
When we try to make a decision on whether we need an outer
SVGRoot container, we detect if we are in shadow tree or not.
We also need to make sure that our parentOrHostElement is also
an svg element.
- svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement):
LayoutTests: Crash due shadow tree parent confusion in SVG.
https://bugs.webkit.org/show_bug.cgi?id=84248
Reviewed by Nikolas Zimmermann.
- svg/foreignObject/viewport-foreignobject-crash-expected.html: Added.
- svg/foreignObject/viewport-foreignobject-crash.html: Added.
- 2:27 PM Changeset in webkit [117160] by
-
- 4 edits2 adds in trunk
[File API] URL methods handling null arguments
https://bugs.webkit.org/show_bug.cgi?id=69693
Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-05-15
Reviewed by Adam Barth.
Source/WebCore:
Per the latest editor's draft of the File API:
http://dev.w3.org/2006/webapi/FileAPI/#dfn-createObjectURL
Use null instead of undefined as return value when a
null blob is given to URL.createObjectURL.
Test: fast/files/url-null.html
- html/DOMURL.idl:
LayoutTests:
URL.createObjectURL must return null instead of undefined
when a null blob is given as argument. Updated old test that
used undefined explicitly. New test by Mark Pilgrim (rebaselined
after fix).
- fast/files/url-null-expected.txt: Added.
- fast/files/url-null.html: Added.
- http/tests/fileapi/create-blob-url-from-data-url.html:
- 2:21 PM Changeset in webkit [117159] by
-
- 5 edits in branches/safari-536-branch/Source/WebKit2
Merged r116993.
- 2:21 PM Changeset in webkit [117158] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix [Qt].
Protect the definition of DOMImplementationSupportsTypeClient class with
VIDEO disabled.
- dom/DOMImplementation.cpp:
- 2:19 PM Changeset in webkit [117157] by
-
- 4 edits3 copies in branches/safari-536-branch
Merged r116960.
- 2:16 PM Changeset in webkit [117156] by
-
- 3 edits3 copies in branches/safari-536-branch
Merged r116925.
- 2:14 PM Changeset in webkit [117155] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r116831.
- 2:12 PM Changeset in webkit [117154] by
-
- 6 edits in branches/safari-536-branch/Source/WebCore
Merged r116830.
- 2:10 PM Changeset in webkit [117153] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r116824.
- 2:08 PM Changeset in webkit [117152] by
-
- 7 edits3 copies in branches/safari-536-branch
Merged r116821.
- 2:06 PM Changeset in webkit [117151] by
-
- 4 edits in branches/safari-536-branch/Source/WebKit/mac
Merged r116820.
- 2:04 PM Changeset in webkit [117150] by
-
- 2 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116809.
- 2:02 PM Changeset in webkit [117149] by
-
- 3 edits in branches/safari-536-branch/Source/WebCore
Merged r116799.
- 1:55 PM Changeset in webkit [117148] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable the Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=86129
Patch by Max Feil <mfeil@rim.com> on 2012-05-15
Reviewed by Antonio Gomes.
This patch enables the new document-based Fullscreen API.
The ENABLE(FULLSCREEN_API) is already enabled in the
BlackBerry WebKit build. My patch turns fullscreen on
in the page settings by default and implements the missing
ChromeClientBlackBerry::{supports,enter,exit}FullScreenForElement()
member functions. I am also plumbing through the existing
"fullScreenVideoCapable" that QNXStageWebView has always been
sending to allow the presence of a native fullscreen video player
to be checked.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::fullScreenVideoCapable):
(BlackBerry::WebKit::WebSettings::setFullScreenVideoCapable):
- Api/WebSettings.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- 1:54 PM Changeset in webkit [117147] by
-
- 7 edits in trunk/Source/WebCore
Site-specific hack: Disclaim WebM as a supported type on Mac for YouTube.
https://bugs.webkit.org/show_bug.cgi?id=86409
Reviewed by Darin Adler.
No new tests; site specific hack.
Add a Mac-only site-specific hack which disclaims both video/webm and video/x-flv
as supported types when the media element's document has a host of youtube.com.
Add a new, pure-virtual prototype class for use by MediaPlayer::supportsType:
- platform/graphics/MediaPlayer.h:
(MediaPlayerSupportsTypeClient):
(WebCore::MediaPlayerSupportsTypeClient::~MediaPlayerSupportsTypeClient):
(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerNeedsSiteSpecificHacks):
(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerDocumentHost):
Use these new client calls to determine whether to apply the site-specific
hack:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType):
Add this prototype class as a superclass of HTMLMediaElement. Pass in the
HTMLMediaElement's this pointer when calling MediaPlayer::supportsType():
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::mediaPlayerNeedsSiteSpecificHacks):
(WebCore::HTMLMediaElement::mediaPlayerDocumentHost):
- html/HTMLMediaElement.h:
As is HTMLMediaElement, a MediaPlayerSupportsTypeClient class is needed. Add a
new class DOMImplementationSupportsTypeClient, an instance of which will be
passed to MediaPlayer::supportsType():
- dom/DOMImplementation.cpp:
(DOMImplementationSupportsTypeClient):
(WebCore::DOMImplementationSupportsTypeClient::DOMImplementationSupportsTypeClient):
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::mediaPlayerNeedsSiteSpecificHacks):
(WebCore::DOMImplementation::mediaPlayerDocumentHost):
- dom/DOMImplementation.h:
- 1:49 PM Changeset in webkit [117146] by
-
- 3 edits3 copies in branches/safari-536-branch
Merged r116832.
- 1:47 PM Changeset in webkit [117145] by
-
- 2 edits in branches/safari-536-branch/Source
Merged r116720.
- 1:46 PM Changeset in webkit [117144] by
-
- 20 edits in branches/safari-536-branch/Source
Merged r116720.
- 1:44 PM Changeset in webkit [117143] by
-
- 3 edits in branches/safari-536-branch/Source/WebCore
Merged r116711.
- 1:41 PM Changeset in webkit [117142] by
-
- 3 edits in branches/safari-536-branch/Source/WebCore
Merged r116697.
- 1:26 PM Changeset in webkit [117141] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml crashes
https://bugs.webkit.org/show_bug.cgi?id=80209
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-05-15
Reviewed by Kenneth Rohde Christiansen.
This patch adds a method isOpen to WebIconDatabase to
be able to check whether the database has already been opened.
This helps preventing problems when reusing a WebContext
to create another view, as e.g. WebKitTestRunner does it in the
Qt port.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setDatabasePath):
(WebKit::WebIconDatabase::isOpen): Added.
(WebKit):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
- UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):
- 1:22 PM Changeset in webkit [117140] by
-
- 3 edits in branches/safari-536-branch/Source/WebCore
Merged r116794.
- 1:20 PM Changeset in webkit [117139] by
-
- 25 edits in branches/safari-536-branch
Merged r116716.
- 1:18 PM Changeset in webkit [117138] by
-
- 16 edits in branches/safari-536-branch
Merged r116695.
- 1:15 PM Changeset in webkit [117137] by
-
- 22 edits in branches/safari-536-branch/Source
Merged r116687.
- 1:14 PM Changeset in webkit [117136] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
modify my own line
- 1:12 PM Changeset in webkit [117135] by
-
- 8 edits2 copies in branches/safari-536-branch
Merged r116685.
- 1:10 PM Changeset in webkit [117134] by
-
- 2 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116813.
- 1:09 PM Changeset in webkit [117133] by
-
- 2 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116593.
- 1:07 PM Changeset in webkit [117132] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r116579.
- 1:05 PM Changeset in webkit [117131] by
-
- 10 edits in branches/safari-536-branch/Source/WebCore
Merged r116570.
- 1:03 PM Changeset in webkit [117130] by
-
- 2 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116565.
- 1:02 PM Changeset in webkit [117129] by
-
- 15 edits in trunk/Source
Use unaccelerated scrolling deltas when rubber-banding
https://bugs.webkit.org/show_bug.cgi?id=86503
<rdar://problem/11378742>
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):
(WebCore::PlatformWheelEvent::scrollCount):
(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaX):
(WebCore::PlatformWheelEvent::unacceleratedScrollingDeltaY):
Add scroll count and unaccelerated scrolling deltas.
- platform/mac/ScrollElasticityController.mm:
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
Call the new WKSI functions.
(WebCore::ScrollElasticityController::handleWheelEvent):
Use the unaccelerated scrolling deltas when needed.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Add new WKSI functions.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Init new WKSI functions.
Source/WebKit2:
- Shared/WebEvent.h:
(WebWheelEvent):
(WebKit::WebWheelEvent::scrollCount):
(WebKit::WebWheelEvent::unacceleratedScrollingDelta):
Add scroll count and unaccelerated scrolling delta.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
Initialize scroll count and unaccelerated scrolling deltas.
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
Initialize scroll count and unaccelerated scrolling deltas.
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Encode and decode scroll count and unaccelerated scrolling deltas.
- Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent):
Initialize the scroll count and unaccelerated scrolling deltas from the underlying NSEvent.
- UIProcess/WebPageProxy.cpp:
(WebKit::coalesce):
Coalesce unaccelerated scrolling deltas as well.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Init new WKSI functions.
- 12:58 PM Changeset in webkit [117128] by
-
- 8 edits in trunk
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-15
Reviewed by Adam Barth.
Source/WebCore:
Using the tests in the touchadjustment/ directory.
- WebCore.gypi:
Include TouchAdjustment.* files.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::zoomableIntersectionQuotient):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
No longer using the INFINITY constant due to problems with compiling
on chromium win.
Source/WebKit/chromium:
- features.gypi:
Enable the touch adjustment code by default.
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.
LayoutTests:
- platform/chromium/test_expectations.txt:
The flaky tests in touchadjustment/ have been addressed in WK86218.
- 12:58 PM Changeset in webkit [117127] by
-
- 4 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116484.
- 12:56 PM Changeset in webkit [117126] by
-
- 9 edits2 adds in trunk/Source/WebCore
Add AudioSummingJunction class to handle fan-in (abstracted from AudioNodeInput)
https://bugs.webkit.org/show_bug.cgi?id=86396
Reviewed by Kenneth Russell.
No new tests. Existing layout tests already extensively test summing.
- CMakeLists.txt:
- GNUmakefile.list.am:
Add AudioSummingJunction files to makefiles.
- Modules/webaudio/AudioContext.cpp:
- Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::handlePreRenderTasks):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::deleteMarkedNodes):
(WebCore::AudioContext::markSummingJunctionDirty):
(WebCore::AudioContext::removeMarkedSummingJunction):
(WebCore::AudioContext::handleDirtyAudioSummingJunctions):
Simple munge from AudioNodeInput -> AudioSummingJunction
- Modules/webaudio/AudioNodeInput.cpp:
- Modules/webaudio/AudioNodeInput.h:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::didUpdate):
Remove logic from AudioNodeInput which now is being moved to AudioSummingJunction.
- Modules/webaudio/AudioSummingJunction.cpp: Added.
- Modules/webaudio/AudioSummingJunction.h: Added.
(WebCore::AudioSummingJunction::AudioSummingJunction):
(WebCore::AudioSummingJunction::~AudioSummingJunction):
(WebCore::AudioSummingJunction::changedOutputs):
(WebCore::AudioSummingJunction::updateRenderingState):
(WebCore::AudioSummingJunction::context):
(WebCore::AudioSummingJunction::numberOfRenderingConnections):
(WebCore::AudioSummingJunction::renderingOutput):
(WebCore::AudioSummingJunction::isConnected):
(WebCore::AudioSummingJunction::numberOfConnections):
Add AudioSummingJunction which is an abstraction to manage/track the connections from AudioNodeOutputs
representing the fan-in points for unity gain summing junctions.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
Add AudioSummingJunction files to makefiles.
- 12:55 PM Changeset in webkit [117125] by
-
- 30 edits in trunk/Source/WebKit2
Unreviewed, rolling out r117095.
http://trac.webkit.org/changeset/117095
https://bugs.webkit.org/show_bug.cgi?id=86511
broke Qt Mac build (Requested by estes on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
- Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.h:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.h:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
- WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
- 12:52 PM Changeset in webkit [117124] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Crash when dropping a reference to a non-existing file
https://bugs.webkit.org/show_bug.cgi?id=86505
<rdar://problem/11402084>
Reviewed by Darin Adler.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): Check that extension handle actually has a non-null extension. Extensions for non-existent files can not exist, so they are passed as null ones.
- 12:51 PM Changeset in webkit [117123] by
-
- 3 edits in trunk/LayoutTests
Fixing the flaky 'script-src-redirect.html' test.
https://bugs.webkit.org/show_bug.cgi?id=86433
Patch by Mike West <mkwst@chromium.org> on 2012-05-15
Reviewed by Adam Barth.
- http/tests/security/contentSecurityPolicy/resources/source-list-parsing-base.js:
(test):
- http/tests/security/contentSecurityPolicy/script-src-redirect.html:
- 12:50 PM Changeset in webkit [117122] by
-
- 9 edits in branches/safari-536-branch/Source/WebKit2
Merged r116478.
- 12:48 PM Changeset in webkit [117121] by
-
- 16 edits7 copies in branches/safari-536-branch
Merged r116473.
- 12:46 PM Changeset in webkit [117120] by
-
- 3 edits in branches/safari-536-branch/Source/WebKit2
Merged r116469.
- 12:45 PM Changeset in webkit [117119] by
-
- 3 edits in branches/safari-536-branch/Source/WebKit2
Merged r116466.
- 12:43 PM Changeset in webkit [117118] by
-
- 5 edits8 copies in branches/safari-536-branch
Merged r116458.
- 12:41 PM Changeset in webkit [117117] by
-
- 7 edits in branches/safari-536-branch/Source
Merged r116449.
- 12:25 PM Changeset in webkit [117116] by
-
- 3 edits2 adds in trunk
Ruby annotation is incorrectly identified as a paragraph boundary
https://bugs.webkit.org/show_bug.cgi?id=86507
Reviewed by Darin Adler.
Source/WebCore:
Test: editing/selection/paragraph-with-ruby.html
- editing/htmlediting.cpp:
(WebCore::isBlock): Changed to return false for ruby text.
LayoutTests:
- editing/selection/paragraph-with-ruby-expected.txt: Added.
- editing/selection/paragraph-with-ruby.html: Added.
- 12:23 PM Changeset in webkit [117115] by
-
- 13 edits in trunk/Source
Add WTF_USE_SECURITY_FRAMEWORK and use it in place of the less specific PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=86508
Reviewed by Sam Weinig.
Source/WebKit2:
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::typeFromCFTypeRef):
(CoreIPC::encode):
(CoreIPC::decode):
(CoreIPC):
- Shared/cf/ArgumentCodersCF.h:
(CoreIPC):
- Shared/mac/KeychainAttribute.cpp:
- Shared/mac/KeychainAttribute.h:
- Shared/mac/SecKeychainItemRequestData.cpp:
- Shared/mac/SecKeychainItemRequestData.h:
- Shared/mac/SecKeychainItemResponseData.cpp:
- Shared/mac/SecKeychainItemResponseData.h:
- UIProcess/WebProcessProxy.h:
(WebKit):
(WebProcessProxy):
- WebProcess/mac/WebProcessMac.mm:
Source/WTF:
- wtf/Platform.h:
- 12:22 PM Changeset in webkit [117114] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Un-used GStreamer linker options
https://bugs.webkit.org/show_bug.cgi?id=86407
Patch by Philippe Normand <pnormand@igalia.com> on 2012-05-15
Reviewed by Martin Robinson.
- GNUmakefile.am: Remove no-longer used webcore_libadd variable.
- 12:21 PM WebKit Team edited by
- added epoger (diff)
- 12:20 PM Changeset in webkit [117113] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=86506
REGRESSION (tiled drawing): No scrollbar while page is loading
-and corresponding
<rdar://problem/11444589>
Reviewed by Anders Carlsson.
We have always had a mechanism in place to suppress painting overlay
scrollbars while the page is loading. However, that mechaism is
overriden if the page has been scrolled. It should be, anyway. It was
not being overriden when the scrolling was handled as a wheel event by
the scrolling tree. This patch takes advantage of the fact that
ScrollingTree::handleWheelEvent() already calls back to the main
thread for handleWheelEventPhase() and just patches
handleWheelEventPhase to mark m_haveScrolledSincePageLoad as true.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEventPhase):
- 12:05 PM Changeset in webkit [117112] by
-
- 7 edits2 deletes in trunk
WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from
going into the PageCache.
https://bugs.webkit.org/show_bug.cgi?id=85891
Reviewed by Brady Eidson.
Source/WebCore:
Do not claim that it is possible to cache a page when the page cache has a capacity of 0.
Covered by the modified DOMWindowExtensionNoCache WK2 API test.
- history/PageCache.cpp:
(WebCore::PageCache::canCache):
Check m_capacity.
- history/PageCache.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
canCache is no longer static on PageCache.
Tools:
Set the cache model in DOMWindowExtensionNoCache so that the page cache is not used. This is
better than using pages with unload handlers because we may find a way to make pages with
unload handlers cacheable in the future.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Remove simple-iframe-unload.html and simple-unload.html, since they are no longer used.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
(TestWebKitAPI::TEST):
Set the cache model to kWKCacheModelDocumentViewer.
- TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple-unload.html: Removed.
- 12:03 PM Changeset in webkit [117111] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Add self as committer-but-not-reviewer
- 11:54 AM Changeset in webkit [117110] by
-
- 4 edits3 moves in trunk/Source
Unreviewed, rolling out r116811.
http://trac.webkit.org/changeset/116811
https://bugs.webkit.org/show_bug.cgi?id=86257
Introduced layering violation
Source/WebCore:
- WebCore.gypi:
Source/WebKit/chromium:
- WebKit.gyp:
- src/Extensions3DChromium.cpp: Renamed from Source/WebCore/platform/chromium/support/Extensions3DChromium.cpp.
(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):
- src/GraphicsContext3DChromium.cpp: Renamed from Source/WebCore/platform/chromium/support/GraphicsContext3DChromium.cpp.
(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::prepareTexture):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3DPrivate::reshape):
(WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
(WebCore::GraphicsContext3DPrivate::isContextLost):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContextLostCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsErrorMessageCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
- src/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/chromium/support/GraphicsContext3DPrivate.h.
(WebKit):
(WebCore):
(GraphicsContext3DPrivate):
- 11:53 AM Changeset in webkit [117109] by
-
- 2 edits in trunk/Source/WebCore
Font copy constructor unnecessarily recalculates transcoding
https://bugs.webkit.org/show_bug.cgi?id=86490
Reviewed by Dan Bernstein.
- platform/graphics/Font.cpp:
(WebCore::Font::Font): Copy m_needsTranscoding instead of recomputing it.
- 11:51 AM Changeset in webkit [117108] by
-
- 5 edits in trunk/Source
Deep copy PluginModuleInfo before passing across thread boundary.
<http://webkit.org/b/86491>
<rdar://problem/11451178>
Reviewed by Anders Carlsson.
Source/WebCore:
- plugins/PluginData.h:
(MimeClassInfo):
(WebCore::MimeClassInfo::isolatedCopy):
(PluginInfo):
(WebCore::PluginInfo::isolatedCopy):
Source/WebKit2:
Since the vector of PluginModuleInfo objects returned by PluginInfoStore::plugins()
can end up being passed to another thread, we should clone it to make sure it's
safe to do so.
No new tests, speculative use-after-free fix.
- Shared/Plugins/PluginModuleInfo.h:
(PluginModuleInfo):
(WebKit::PluginModuleInfo::isolatedCopy):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::plugins):
- 11:47 AM Changeset in webkit [117107] by
-
- 15 edits2 copies1 add in trunk/Source
Unreviewed, rolling out r116712.
http://trac.webkit.org/changeset/116712
https://bugs.webkit.org/show_bug.cgi?id=86484
This patch is causing crashes in Chromium Canary builds
(Requested by pilgrim_google on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15
Source/WebCore:
- storage/StorageArea.h:
(StorageArea):
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
Source/WebKit/chromium:
- WebKit.gyp:
- public/WebStorageArea.h:
(WebKit):
- public/WebStorageEventDispatcher.h:
(WebStorageEventDispatcher):
(WebKit::WebStorageEventDispatcher::~WebStorageEventDispatcher):
- public/WebStorageNamespace.h:
(WebStorageNamespace):
(WebKit::WebStorageNamespace::close):
- public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::dispatchStorageEvent):
- src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::setItem):
(WebCore::StorageAreaProxy::removeItem):
(WebCore::StorageAreaProxy::clear):
(WebCore):
(WebCore::StorageAreaProxy::storageEvent):
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::findPageWithSessionStorageNamespace):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
- src/StorageAreaProxy.h:
(WebCore):
(StorageAreaProxy):
- src/StorageEventDispatcherImpl.cpp: Added.
(WebCore):
(WebCore::StorageEventDispatcherImpl::StorageEventDispatcherImpl):
(WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
- src/StorageEventDispatcherImpl.h: Copied from Source/WebKit/chromium/public/WebStorageEventDispatcher.h.
(WebCore):
(StorageEventDispatcherImpl):
- src/WebStorageEventDispatcherImpl.cpp:
(WebKit):
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent):
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent):
(WebKit::WebStorageEventDispatcher::create):
(WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
(WebKit::WebStorageEventDispatcherImpl::dispatchStorageEvent):
- src/WebStorageEventDispatcherImpl.h: Copied from Source/WebKit/chromium/public/WebStorageEventDispatcher.h.
(WebKit):
(WebStorageEventDispatcherImpl):
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- 11:43 AM Changeset in webkit [117106] by
-
- 3 edits in trunk/Source/WebCore
Optimize save/restore with no drawing operations between them (shows up on some canvas benchmarks)
https://bugs.webkit.org/show_bug.cgi?id=86448
Reviewed by Simon Fraser.
Since canvas programmers sometimes end up doing extra save/restore pairs with no actual drawing
in between, optimize that case by not realizing saves until we have to. This is doubly important
because saves are costly.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Initialize m_unrealizedSaveCount.
(WebCore::CanvasRenderingContext2D::isAccelerated): Improve performance by calling the
drawingContext function only once.
(WebCore::CanvasRenderingContext2D::reset): Set m_unrealizedSaveCount to 0.
(WebCore::CanvasRenderingContext2D::realizeSavesLoop): Added. Replaces the save function as the
function that actually pushes context onto the state stack.
(WebCore::CanvasRenderingContext2D::restore): Added code to do an early return if we can do the
restore just by decrementing the unrealized save count.
(WebCore::CanvasRenderingContext2D::setStrokeStyle): Added calls to realizeSaves and replaced
calls to state with calls to modifiableState.
(WebCore::CanvasRenderingContext2D::setFillStyle): Ditto.
(WebCore::CanvasRenderingContext2D::setLineWidth): Ditto. Also added an early out for cases where
the line width is not changing.
(WebCore::CanvasRenderingContext2D::setLineCap): Ditto.
(WebCore::CanvasRenderingContext2D::setLineJoin): Ditto.
(WebCore::CanvasRenderingContext2D::setMiterLimit): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowOffsetX): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowOffsetY): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowBlur): Ditto.
(WebCore::CanvasRenderingContext2D::setShadowColor): Ditto.
(WebCore::CanvasRenderingContext2D::setWebkitLineDash): Ditto.
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset): Ditto.
(WebCore::CanvasRenderingContext2D::setGlobalAlpha): Ditto.
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation): Ditto.
(WebCore::CanvasRenderingContext2D::scale): Ditto.
(WebCore::CanvasRenderingContext2D::rotate): Ditto.
(WebCore::CanvasRenderingContext2D::translate): Ditto.
(WebCore::CanvasRenderingContext2D::transform): Ditto.
(WebCore::CanvasRenderingContext2D::setTransform): Ditto.
(WebCore::CanvasRenderingContext2D::setStrokeColor): Ditto.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
(WebCore::CanvasRenderingContext2D::clip): Ditto.
(WebCore::CanvasRenderingContext2D::clearRect): Changed implementation so it does not save
the graphics context in the common case where shadows, global alpha, and global compositing
operators do not interfer with the function's operation. This allowed us to get rid of the
setAllAttributesToDefault function, which was used nowhere else.
(WebCore::CanvasRenderingContext2D::setShadow): Added a new common bottleneck and made all
the setShadow functions call it.
(WebCore::CanvasRenderingContext2D::clearShadow): Changed to call the new setShadow.
(WebCore::CanvasRenderingContext2D::setFont): Renamed tempDecl to the more friendly
parsedStyle. Changed code structure so the CSS parser is deleted right after parsing is
done. Used string concatenation instead of more expensive string append. Added calls to
realizeSaves and modifiableState.
(WebCore::CanvasRenderingContext2D::setTextAlign): Added calls to realizeSaves and replaced
calls to state with calls to modifiableState. Also added an early out for cases where the
alignment is not changing.
(WebCore::CanvasRenderingContext2D::setTextBaseline): Ditto.
- html/canvas/CanvasRenderingContext2D.h: Made save an inline function that bumps
m_unrealizedSaveCount. Removed setAllAttributesToDefault. Added OVERRIDE for all the
virtual function overrides, and made them all private. Moved m_path down with the other data
members. Renamed the non-const state function to modifiableState. Added a realizeSaves
function and the realizeSavesLoop for the unusual case where there is work to do.
Added m_unrealizedSaveCount.
- 11:31 AM Changeset in webkit [117105] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r116427.
- 11:24 AM Changeset in webkit [117104] by
-
- 4 edits in branches/safari-536-branch/Source/WebCore
Merged r116419.
- 11:16 AM Changeset in webkit [117103] by
-
- 3 edits3 copies in branches/safari-536-branch
Merged r116395.
- 11:15 AM Changeset in webkit [117102] by
-
- 3 edits2 adds in trunk
MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8
https://bugs.webkit.org/show_bug.cgi?id=86459
Reviewed by Adam Barth.
Source/WebCore:
LocalMediaStream inherits from MediaStream, but only MediaStream have the
EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue.
Test: fast/mediastream/LocalMediaStream-onended.html
- Modules/mediastream/LocalMediaStream.idl:
LayoutTests:
- fast/mediastream/LocalMediaStream-onended-expected.txt: Added.
- fast/mediastream/LocalMediaStream-onended.html: Added.
- 11:14 AM Changeset in webkit [117101] by
-
- 11 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116372.
- 11:10 AM Changeset in webkit [117100] by
-
- 6 edits in branches/safari-536-branch/Source/WebCore
Merged r116368.
- 11:08 AM Changeset in webkit [117099] by
-
- 2 edits in branches/safari-536-branch/Source/JavaScriptCore
Merged r116363.
- 11:07 AM Changeset in webkit [117098] by
-
- 8 edits in trunk/Source
[chromium] Remove unused code for tap target fuzzing
https://bugs.webkit.org/show_bug.cgi?id=86252
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-15
Reviewed by Adam Barth.
Source/WebCore:
No tests required since this is a cleanup of unused code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):
- page/EventHandler.h:
(EventHandler):
The touch adjustment code will be used to determine the best target
for a GestureTap event instead of passing in a pre-targeted node.
- platform/PlatformGestureEvent.h:
(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
A rectangular touch region is defined by the touch center and the
delta values only, so gammaX and gammaY are not needed.
Source/WebKit/chromium:
- public/WebInputEvent.h:
(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEvent.cpp:
(SameSizeAsWebGestureEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
A rectangular touch region is defined by the touch center and the
delta values only, so gammaX and gammaY are not needed.
- 11:07 AM Changeset in webkit [117097] by
-
- 7 edits in branches/safari-536-branch
Merged r116361.
- 11:05 AM Changeset in webkit [117096] by
-
- 8 edits in branches/safari-536-branch/Source
Merged r116367.
- 11:04 AM Changeset in webkit [117095] by
-
- 30 edits in trunk/Source/WebKit2
Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
https://bugs.webkit.org/show_bug.cgi?id=86496
Reviewed by Dan Bernstein.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
- Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::individualPluginPaths):
(WebKit::PluginInfoStore::getPluginInfo):
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
- WebProcess/Plugins/Netscape/JSNPMethod.h:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.h:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
- WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
- 11:00 AM Changeset in webkit [117094] by
-
- 3 edits in trunk/Source/WebCore
[Qt] WebKit with Qt5 hangs on Mac
https://bugs.webkit.org/show_bug.cgi?id=79785
Reviewed by Tor Arne Vestbø.
Delay the initialization of our QNetworkConfigurationManager used in
NetworkStateNotifierPrivate. On Mac it was causing a race condition because it
spawns a thread that triggers a static initializer in Qt, while in the main
thread NetworkStateNotifier is being static initialized. On Mac the lock for
static initializers is shared between all of them, causing a deadlock.
The issue was also reported in http://openradar.appspot.com/11217150.
- platform/network/qt/NetworkStateNotifierPrivate.h:
(NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::effectivelyOnline):
- platform/network/qt/NetworkStateNotifierQt.cpp:
(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::setNetworkAccessAllowed):
(WebCore::NetworkStateNotifierPrivate::setOnlineState):
(WebCore::NetworkStateNotifierPrivate::initialize):
(WebCore):
(WebCore::NetworkStateNotifierPrivate::~NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):
- 10:56 AM Changeset in webkit [117093] by
-
- 13 edits in branches/safari-536-branch
Merged r116356.
- 10:47 AM Changeset in webkit [117092] by
-
- 3 edits in branches/safari-536-branch/Source/WebKit2
Merged r116226.
- 10:41 AM Changeset in webkit [117091] by
-
- 4 edits in trunk/Source/WebCore
Factor HitTestPoint out of HitTestResult.
https://bugs.webkit.org/show_bug.cgi?id=85965
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-15
Reviewed by Simon Fraser.
In preparation for handling transformations on area-based hit-testing,
we need to factor test-point and test-area out of HitTestResult so that
it can be transformed independently.
To maintain the current API as closely as possible HitTestResult now
inherit from HitTestPoint, representing the original untransformed
hitTestPoint.
No change in functionality. No new tests.
- rendering/HitTestResult.cpp:
(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::~HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestPoint::rectForPoint):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::isSelected):
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::replacedString):
- rendering/HitTestResult.h:
(HitTestPoint):
(WebCore::HitTestPoint::point):
(WebCore::HitTestPoint::roundedPoint):
(WebCore::HitTestPoint::setPoint):
(WebCore::HitTestPoint::isRectBasedTest):
(WebCore::HitTestPoint::topPadding):
(WebCore::HitTestPoint::rightPadding):
(WebCore::HitTestPoint::bottomPadding):
(WebCore::HitTestPoint::leftPadding):
(HitTestResult):
(WebCore::HitTestResult::hitTestPoint):
(WebCore::HitTestPoint::rectForPoint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
- 10:34 AM Changeset in webkit [117090] by
-
- 2 edits in trunk/LayoutTests
Skip a webarchive test I added that fails on WK2.
- platform/wk2/Skipped:
- 10:26 AM Changeset in webkit [117089] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Updated chromium test expectations.
- platform/chromium/test_expectations.txt:
- 10:18 AM Changeset in webkit [117088] by
-
- 2 edits2 adds in trunk/LayoutTests
[Chromium] Unreviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png.
Patch by Florin Malita <fmalita@chromium.org> on 2012-05-15
- platform/chromium-mac/svg/repaint/mask-clip-target-transform-expected.png: Added.
- platform/chromium-win/svg/repaint/mask-clip-target-transform-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:11 AM Changeset in webkit [117087] by
-
- 7 edits in branches/chromium/1132/Source
Merge 116587 - [chromium] Don't draw when canDraw() is false
https://bugs.webkit.org/show_bug.cgi?id=85829
Reviewed by Adrienne Walker.
Source/WebCore:
This is based on the work of Daniel Sievers in bug
https://bugs.webkit.org/show_bug.cgi?id=82680. When canDraw() is false,
we should not call drawLayers() or prepareToDraw() in both Single- and
Multi-Threaded mode.
drawLayers() is crashing in single threaded mode, and this attempts to
prevent it from being called with invalid state. While making it behave
properly in single-threaded mode, it seems appropriate to unrevert the
parts of 82680 that made threaded mode behave similarly appropriately.
A single-threaded test is not included since LTHTests is unable to run
in single-threaded mode at this time (pending work from Ian Vollick). So
we test in threaded mode only with a note to include a single thread
version.
Tests: CCLayerTreeHostTestCanDrawBlocksDrawing.runMultiThread
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
(WTF::TEST_F):
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377150
- 9:59 AM Changeset in webkit [117086] by
-
- 4 edits in trunk/Source/WebCore
Refactor SVG parts of Node::addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=86426
Reviewed by Nikolas Zimmermann.
Move SVG parts of Node::addEventListener/removeEventListener into svg/. Now we do not
have to check in Node::addEventListener/removeEventListener if we are dealing with an SVG
element. Make tryAddEventListener/tryRemoveEventListener protected methods on Node to be able to use
it in SVGElement.
No new tests, since no change in behavior, just refactoring.
- dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::removeEventListener):
- svg/SVGElement.cpp:
(WebCore::collectInstancesForSVGElement):
(WebCore):
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
- svg/SVGElement.h:
(SVGElement):
- 9:38 AM Changeset in webkit [117085] by
-
- 9 edits in trunk/Source/WebKit2
Guard some AppKit-specific code in WebKit2 with USE(APPKIT)
https://bugs.webkit.org/show_bug.cgi?id=86444
Reviewed by Sam Weinig.
- Shared/NativeWebKeyboardEvent.h:
(NativeWebKeyboardEvent):
(WebKit::NativeWebKeyboardEvent::nativeEvent):
- Shared/NativeWebMouseEvent.h:
(NativeWebMouseEvent):
(WebKit::NativeWebMouseEvent::nativeEvent):
- Shared/NativeWebWheelEvent.h:
(NativeWebWheelEvent):
(WebKit::NativeWebWheelEvent::nativeEvent):
- Shared/mac/ArgumentCodersMac.h:
(CoreIPC):
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):
- Shared/mac/WebEventFactory.mm:
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- 9:34 AM Changeset in webkit [117084] by
-
- 2 edits in trunk/Source/WebCore
RuleSet::addToRuleSet wastes a bit of Vector capacity.
<http://webkit.org/b/86434>
Reviewed by Antti Koivisto.
Have makeRuleSet call shrinkToFit() on the vectors before returning them.
This avoids wasting space for the rulesets constructed in collectFeatures().
- css/StyleResolver.cpp:
(WebCore::makeRuleSet):
- 9:22 AM Changeset in webkit [117083] by
-
- 2 edits in trunk/Source/WebCore
[CG] CGImageCreateWithImageInRect is too slow, but for now we still need to use it
https://bugs.webkit.org/show_bug.cgi?id=86340
Reviewed by Geoffrey Garen.
This patch adds a subimage cache to defray the cost of CGImageCreateWithImageInRect.
Later, we will restructure the code so it doesn't use that function, but at the
moment there are CG issues blocking that change.
- platform/graphics/cg/GraphicsContextCG.cpp:
(SubimageCacheEntry): Added. An entry in the cache.
(SubimageCacheEntryTraits): Added. Traits for the cache.
(SubimageCacheHash): Added. Hash function for the cache.
(SubimageCacheTimer): Added. Timer that clears the cache after a second
of inactivity.
(SubimageCacheWithTimer): Added. Cache and its timer.
(WebCore::subimageCache): Added. Function returning the single global timer.
(WebCore::SubimageCacheTimer::restart): Added. Start the timer.
(WebCore::SubimageCacheTimer::fired): Added. Clear the cache when the timer fires.
(SubimageRequest): Added. A key to look up in the cache.
(SubimageCacheAdder): Added. Translator to add to the cache.
(WebCore::subimage): Added. Puts an entry in the cache.
(WebCore::GraphicsContext::drawNativeImage): Changed to call the subimage function.
- 9:18 AM Changeset in webkit [117082] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Move http/tests/cookies/third-party-cookie-relaxing.html from Skipped
list to test_expectations.txt. This test is expected to fail on EFL
port and won't be fixed.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 9:16 AM Changeset in webkit [117081] by
-
- 7 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Remove duplicated entries because of disabled SUBPIXEL_LAYOUT.
- platform/qt-4.8/Skipped:
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt-arm/Skipped:
- platform/qt-mac/Skipped:
- 9:13 AM Changeset in webkit [117080] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: AdvancedSearchController is not stopped then view is hidden.
https://bugs.webkit.org/show_bug.cgi?id=86466
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-15
Reviewed by Vsevolod Vlasov.
AdvancedSearchController overrides "wasHidden" method instead of "willHide".
UI event-flow, not tested.
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.willHide): Renamed function.
- 9:05 AM Changeset in webkit [117079] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening of flaky tests
https://bugs.webkit.org/show_bug.cgi?id=86485
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-15
- platform/efl/test_expectations.txt:
- 8:52 AM Changeset in webkit [117078] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] adding a functionality for web inspector to inspect current selected element
https://bugs.webkit.org/show_bug.cgi?id=86394
Patch by Hanna Ma <Hanma@rim.com> on 2012-05-15
Reviewed by Rob Buis.
Add a way to trigger the remote web inspector on selected element.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::inspectCurrentContextElement):
(WebKit):
- Api/WebPage.h:
- 8:48 AM Changeset in webkit [117077] by
-
- 2 edits in trunk/LayoutTests
[Qt][Wk2] Unskip passing svg/dynamic-updates tests after r95878.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-15
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/Skipped:
- 8:45 AM Changeset in webkit [117076] by
-
- 2 edits in trunk/LayoutTests
[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
https://bugs.webkit.org/show_bug.cgi?id=36954
Unreviewed gardening, unskip it, because it passes on 32/64 bit too now. (Maybe after r112397)
- platform/qt/Skipped: Try to unskip really. :)
- 8:43 AM Changeset in webkit [117075] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] fast/repaint/scroll-in-clipped-layer.html crashes
https://bugs.webkit.org/show_bug.cgi?id=80387
Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2012-05-15
Reviewed by Csaba Osztrogonác.
Unskip tests for bug 80387. They do not crash now.
- platform/qt-5.0-wk2/Skipped:
- 8:40 AM Changeset in webkit [117074] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip test which require USE(ZLIB). It has been enabled for EFL port
since r110896).
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15
- platform/efl/Skipped:
- 8:38 AM Changeset in webkit [117073] by
-
- 2 edits in trunk/LayoutTests
[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
https://bugs.webkit.org/show_bug.cgi?id=86473
Unreviewed gardening, unskip now passing tests.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-15
- platform/efl/Skipped:
- 8:36 AM Changeset in webkit [117072] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
https://bugs.webkit.org/show_bug.cgi?id=36954
Unreviewed gardening, unskip it, because it passes on 32/64 bit too now. (Maybe after r112397)
- platform/qt/css1/box_properties/acid_test-expected.png: Added.
- platform/qt/css1/box_properties/acid_test-expected.txt:
- 8:34 AM Changeset in webkit [117071] by
-
- 4 edits in trunk
[Qt] http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html times out
https://bugs.webkit.org/show_bug.cgi?id=84016
Reviewed by Simon Hausmann.
Source/WebCore:
Calling didFail abort the connection and doesn't activate the HEADERS_RECEIVED state.
Since the goal of HEAD is to test then the request should be marked as finished
also in cases of HTTP errors.
This matches other ports behavior.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::shouldIgnoreHttpError):
LayoutTests:
- platform/qt/Skipped:
- 8:32 AM EFLWebKitBuildBots edited by
- Add myself to the People table (diff)
- 8:15 AM Changeset in webkit [117070] by
-
- 4 edits in trunk
[Qt][WK2] fast/loader/create-frame-in-DOMContentLoaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=83578
Source/WebKit2:
Retrieve and save page ID only for a valid page in WebFrameNetworkingContext.
The page will be null if the frame was detached from the page.
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
LayoutTests:
Unskip passing test.
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.
- platform/qt-5.0-wk2/Skipped:
- 8:07 AM Changeset in webkit [117069] by
-
- 9 edits in trunk/Source
[Qt][WK2] Fix scrolling in touch mode
https://bugs.webkit.org/show_bug.cgi?id=75006
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
On changes to fixedVisibleContentRect update scroll-animators position, and
recalculate page-step sizes in scrollbars.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
Forward scrolling-request to the host window.
(WebCore::ScrollView::updateScrollbars):
Allow ScrollViews to have invisible scrollbars when scrolling is delegated.
- platform/ScrollView.h:
(ScrollView):
Source/WebKit2:
Only handle mouse-wheel events in WebCore to avoid double scrolling, and
scale pixels scrolled by wheel events according to viewport transformation.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleWheelEvent):
- 7:57 AM Changeset in webkit [117068] by
-
- 13 edits3 copies in branches/chromium/1137/Source
Revert 116712 - Source/WebCore: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the StorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.
Reviewed by Adam Barth.
No new tests. Existing tests cover this.
- storage/StorageArea.h: Alter the interface so the mutators no longer return previous values
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): removed an unneeded PLATFORM(CHROMIUM) guard
(WebCore::StorageAreaImpl::setItem): no longer return the old value
(WebCore::StorageAreaImpl::removeItem): no longer return the old value
(WebCore::StorageAreaImpl::clear): no longer return whether something was cleared
- storage/StorageAreaImpl.h: match StorageArea's virtual interface
Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221
Alter the WebStorageArea virtual interface such that the mutators no longer
return old values. This is to allow implementations of the interface to operate
more asynchronously.
Also clean up from the last patch, remove support for the DEPRECATED event
dispatching API.
Reviewed by Adam Barth.
- WebKit.gyp: delete three files indicated below
- public/WebStorageArea.h:
(WebKit::WebStorageArea::setItem): no longer returns the old value
(WebKit::WebStorageArea::removeItem): no longer returns the old value
(WebKit::WebStorageArea::clear): no longer returns a bool indicated if something was cleared
- public/WebStorageEventDispatcher.h: removed the DEPRECATED instance methods
- public/WebStorageNamespace.h: removed the DEPRECATED close() method
- public/platform/WebKitPlatformSupport.h: removed the DEPRECATED dispatchStorageEvent() method
- src/StorageAreaProxy.cpp: removed the DEPREACTED storageEvent() method
(WebCore::StorageAreaProxy::setItem): no return value
(WebCore::StorageAreaProxy::removeItem): no return value
(WebCore::StorageAreaProxy::clear): no return value
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): remove an early return thats no longer needed
(WebCore::findPageWithSessionStorageNamespace): switched to passing pageGroup by ptr value instead of by name
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent): remove an early return thats no longer needed
- src/StorageAreaProxy.h:
(WebCore):
(StorageAreaProxy):
- src/StorageEventDispatcherImpl.cpp: Deleted the file.
- src/StorageEventDispatcherImpl.h: Deleted the file.
- src/WebStorageEventDispatcherImpl.cpp: Deleted the DEPRECATED instance methods.
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): use WebViewImpl::defaultPageGroup
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): use WebViewImpl::defaultPageGroup
- src/WebStorageEventDispatcherImpl.h: Deleted the file.
- src/WebViewImpl.cpp: added a static method to retrieve a ptr to the default page group,
(WebKit::WebViewImpl::defaultPageGroup):
- src/WebViewImpl.h:
TBR=Michael Nordman
Review URL: https://chromiumcodereview.appspot.com/10377148
- 7:51 AM Changeset in webkit [117067] by
-
- 1 add in branches/chromium/1137/codereview.settings
adding for easy drover
- 7:49 AM Changeset in webkit [117066] by
-
- 1 copy in branches/chromium/1137
branching for 1137 canary to fix top crasher
- 7:37 AM Changeset in webkit [117065] by
-
- 9 edits6 adds3 deletes in trunk
Web Inspector: Refactor SnippetsModel: extract SnippetStorage, make SnippetScriptMapping delegate calls to ScriptSnippetModel and provide public interface on ScriptSnippetModel in terms of uiSourceCodes
https://bugs.webkit.org/show_bug.cgi?id=86477
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted SnippetStorage to be reused for other snippet types.
Made SnippetScriptMapping delegate all calls to ScriptSnippetModel and injected it in DebuggerPresentationModel.
ScriptSnippetModel now provides public interface for ScriptsPanel in terms of uiSourceCodes.
Tests: inspector/debugger/script-snippet-model.html
inspector/snippet-storage.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
- inspector/front-end/ScriptSnippetModel.js: Added.
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype.get scriptMapping):
(WebInspector.ScriptSnippetModel.prototype.createScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._rawLocationToUILocation):
(WebInspector.ScriptSnippetModel.prototype._uiLocationToRawLocation.get if):
(WebInspector.ScriptSnippetModel.prototype._uiLocationToRawLocation):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._sourceURLForSnippet):
(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):
(WebInspector.ScriptSnippetModel.prototype._snippetForSourceURL):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping):
(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.SnippetScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetScriptMapping.prototype.snippetIdForSourceURL):
(WebInspector.SnippetScriptMapping.prototype.addScript):
(WebInspector.SnippetScriptMapping.prototype._uiSourceCodesAdded):
(WebInspector.SnippetScriptMapping.prototype._uiSourceCodesRemoved):
(WebInspector.SnippetScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):
- inspector/front-end/SnippetStorage.js: Added.
(WebInspector.SnippetStorage):
(WebInspector.SnippetStorage.prototype.get namePrefix):
(WebInspector.SnippetStorage.prototype._saveSettings):
(WebInspector.SnippetStorage.prototype.set snippets):
(WebInspector.SnippetStorage.prototype.snippetForId):
(WebInspector.SnippetStorage.prototype.deleteSnippet):
(WebInspector.SnippetStorage.prototype._snippetAdded):
(WebInspector.SnippetStorage.prototype.reset.set this):
(WebInspector.Snippet):
(WebInspector.Snippet.fromObject):
(WebInspector.Snippet.prototype.get id):
(WebInspector.Snippet.prototype.get name):
(WebInspector.Snippet.prototype.set name):
(WebInspector.Snippet.prototype.get content):
(WebInspector.Snippet.prototype.set content):
(WebInspector.Snippet.prototype.serializeToObject):
- inspector/front-end/SnippetsModel.js: Removed.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/debugger/script-snippet-model-expected.txt: Added.
- inspector/debugger/script-snippet-model.html: Added.
- inspector/debugger/snippets-model-expected.txt: Removed.
- inspector/debugger/snippets-model.html: Removed.
- inspector/snippet-storage-expected.txt: Added.
- inspector/snippet-storage.html: Added.
- 7:15 AM Changeset in webkit [117064] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: add show/hide debugger sidebar button.
https://bugs.webkit.org/show_bug.cgi?id=86478
Reviewed by Vsevolod Vlasov.
As with the navigator, but with no overlay. See the screenshot.
- English.lproj/localizedStrings.js:
- inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):
(WebInspector.ScriptsPanel.prototype._installDebuggerSidebarController.clickHandler):
(WebInspector.ScriptsPanel.prototype._showDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
- inspector/front-end/scriptsPanel.css:
(#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
(button.status-bar-item.scripts-debugger-show-hide-button):
(.status-bar-item.scripts-debugger-show-hide-button > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button.toggled-shown > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden > .glyph):
- 7:11 AM Changeset in webkit [117063] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=83133
Unreviewed gardening, unskip the now passing test.
- platform/qt/Skipped:
- 6:57 AM Changeset in webkit [117062] by
-
- 2 edits1 add12 deletes in trunk/LayoutTests
Making layout testcase: fast/table/empty-section-crash.html result platform independent
https://bugs.webkit.org/show_bug.cgi?id=86352
After modifying the current handling of collapsed borders for
table (https://bugs.webkit.org/show_bug.cgi?id=67877), the expected output for this testcase
changes. Hence, instead of generating new png images and dumprendertext platform specific
output files, have made the output platform independant by making it dumpAsText() only.
Shall be adding a reftest for this along with https://bugs.webkit.org/show_bug.cgi?id=67877.
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-15
Reviewed by Antti Koivisto.
- fast/table/empty-section-crash-expected.txt: Added.
Added new expected file.
- fast/table/empty-section-crash.html:
Modified testcase to make it dumpAsText().
- platform/chromium-linux/fast/table/empty-section-crash-expected.png: Removed.
- platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Removed.
- platform/chromium-win/fast/table/empty-section-crash-expected.png: Removed.
- platform/chromium-win/fast/table/empty-section-crash-expected.txt: Removed.
- platform/efl/fast/table/empty-section-crash-expected.png: Removed.
- platform/efl/fast/table/empty-section-crash-expected.txt: Removed.
- platform/gtk/fast/table/empty-section-crash-expected.png: Removed.
- platform/gtk/fast/table/empty-section-crash-expected.txt: Removed.
- platform/mac/fast/table/empty-section-crash-expected.png: Removed.
- platform/mac/fast/table/empty-section-crash-expected.txt: Removed.
- platform/qt/fast/table/empty-section-crash-expected.png: Removed.
- platform/qt/fast/table/empty-section-crash-expected.txt: Removed.
Removed the platform specific expected output files for empty-section-crash.html
- 6:55 AM Changeset in webkit [117061] by
-
- 13 edits2 moves1 add in trunk
[Qt] Add infra for testing double-tap to zoom functionality etc
https://bugs.webkit.org/show_bug.cgi?id=86474
Reviewed by Simon Hausmann.
Source/WebKit/qt:
The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.
- declarative/experimental/plugin.cpp:
Source/WebKit2:
Rename the WebViewportInfo class to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.
Modify the API to work better for testing and make sure the
signals are emitted the right places. Also add a method for
simulating a double tap.
Work around issue with animations not running when the item
doesn't have focus.
Create an example test for double-tap to zoom, showing how we can
now create UI tests using QML.
- Target.pri:
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::setContentsSize):
(QQuickWebPage::setContentsScale):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::test):
(QQuickWebView::mouseDoubleClickEvent):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/qwebkittest.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp.
(QWebKitTest::QWebKitTest):
(QWebKitTest::~QWebKitTest):
(QWebKitTest::touchDoubleTap):
(QWebKitTest::contentsSize):
(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):
- UIProcess/API/qt/qwebkittest_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h.
- UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Added.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
Tools:
The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- MiniBrowser/qt/qml/ViewportInfoItem.qml:
- 6:41 AM Changeset in webkit [117060] by
-
- 2 edits in trunk/LayoutTests
Tests added in r117012 (plugins/npruntime/delete-plugin-within-*) failing on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=86480
Not reviewed.
Skipping.
- platform/mac/Skipped:
- 6:23 AM Changeset in webkit [117059] by
-
- 2 edits1 add in trunk/LayoutTests
2012-05-15 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png on Lion.
- platform/mac/svg/repaint/mask-clip-target-transform-expected.png: Added.
- platform/mac/test_expectations.txt:
- 6:18 AM Changeset in webkit [117058] by
-
- 4 edits in trunk/Source
NEONizing forceValidPreMultipliedPixels
https://bugs.webkit.org/show_bug.cgi?id=86468
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Optimize forceValidPreMultipliedPixels with ARM-NEON intrinsics.
Existing tests cover this feature.
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::forceValidPreMultipliedPixels):
Source/WTF:
Allow to disable all intrinsics with a single macro.
- wtf/Platform.h:
- 6:08 AM Changeset in webkit [117057] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: remove unnecessary setTimeout in HeapSnapshotGridNodes.js
https://bugs.webkit.org/show_bug.cgi?id=86464
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved): Posting
a message to worker is already asynchronous, no need to postpone the call via setTimeout.
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
- 5:56 AM Changeset in webkit [117056] by
-
- 5 edits3 adds in trunk
Mask deformations when masked content is rotated
https://bugs.webkit.org/show_bug.cgi?id=76527
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/repaint/mask-clip-target-transform.svg
RenderSVGResource::markForLayoutAndParentResourceInvalidation() needs to also
invalidate parent mask and clip resources, not just filters.
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
LayoutTests:
- platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/test_expectations.txt:
- svg/repaint/mask-clip-target-transform-expected.txt: Added.
- svg/repaint/mask-clip-target-transform.svg: Added.
- 5:50 AM Changeset in webkit [117055] by
-
- 9 edits1 delete in trunk/Source/WebCore
Web Inspector: merge show navigator with pin navigator buttons.
https://bugs.webkit.org/show_bug.cgi?id=86469
Reviewed by Vsevolod Vlasov.
See screenshots attached to the bug.
- English.lproj/localizedStrings.js:
- inspector/front-end/Images/navigatorPinButton.png: Removed.
- inspector/front-end/Images/navigatorShowHideButton.png:
- inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):
- inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):
- inspector/front-end/navigatorView.css:
(.navigator-tabbed-pane .tabbed-pane-header-contents):
- inspector/front-end/scriptsPanel.css:
(.status-bar-item.scripts-navigator-show-hide-button > .glyph):
(.status-bar-item.scripts-navigator-show-hide-button.toggled-shown > .glyph):
(.status-bar-item.scripts-navigator-show-hide-button.toggled-overlay > .glyph):
(button.status-bar-item.scripts-navigator-show-hide-button):
(button.status-bar-item.scripts-navigator-show-hide-button.toggled-overlay):
- 5:47 AM Changeset in webkit [117054] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r117052.
http://trac.webkit.org/changeset/117052
https://bugs.webkit.org/show_bug.cgi?id=86470
Unskipping compositing tests made 500+ other tests fail
(sideeffect bug) (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15
- platform/qt-4.8/Skipped:
- 4:58 AM Changeset in webkit [117053] by
-
- 2 edits in trunk/Tools
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338
Reviewed by Hajime Morita.
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.
(WebKitPortTest.test_skipped_directories_for_symbols):
- 4:33 AM Changeset in webkit [117052] by
-
- 2 edits in trunk/LayoutTests
[Qt][Wk1] Unskip now passig tests.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-15
Reviewed by Csaba Osztrogonác.
- platform/qt-4.8/Skipped:
- 4:18 AM Changeset in webkit [117051] by
-
- 13 edits2 adds in trunk
Web Inspector: implement "Reveal in Dominators view" context menu action
https://bugs.webkit.org/show_bug.cgi?id=86455
Reviewed by Pavel Feldman.
Source/WebCore:
Implemented "Reveal in Dominators view" context menu action for objects
in the console.
Test: inspector/profiler/heap-snapshot-reveal-in-dominators-view.html
- English.lproj/localizedStrings.js:
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetDominators):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.expandNextDominator):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.childForPosition):
(WebInspector.HeapSnapshotGridNode.prototype.expandWithoutPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didGetNodePosition):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didPopulateChildren):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.dominatorIdsForNode):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
LayoutTests:
Test that an object can be revealed in the heap snapshot dominators view
by its heap snapshot object id.
- inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Added.
- inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Added.
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 4:10 AM Changeset in webkit [117050] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: exception when switching to heap profiler comparison view
https://bugs.webkit.org/show_bug.cgi?id=86224
Reviewed by Pavel Feldman.
Make sure the messages are dispatched in the same order as they are sent in
case a fake worker is used for heap snapshot processing.
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.TimerQueue):
(WebInspector.TimerQueue.prototype.addTask):
(WebInspector.TimerQueue.prototype._onTimeout):
(WebInspector.TimerQueue.prototype._scheduleTimer):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
- 4:01 AM EFLWebKitBuildBots created by
- buildbot schedule
- 3:39 AM EFLWebKit edited by
- (diff)
- 3:16 AM Changeset in webkit [117049] by
-
- 2 edits in trunk/Tools
Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout
https://bugs.webkit.org/show_bug.cgi?id=85809
webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
output to stdout, but StreamWriter will by default always encode the object that's
passed to write(). This blows up when the object is a raw string, already encoded
as utf8, and does not match the default behavior of sys.stdout.
To solve this in one place, instead of every single call-site that might write
raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
passing them on to StreamWriter.write(). This has the benefit of also making the
stacktrace easy to read in the case where this assumption does not hold.
The source of this particular bug was that Executive.run_and_throw_if_fail() will
tee the output of the subprocess, and in the case of running prepare-ChangeLog this
might produce non-ascii output, which gets written directly to sys.stdout as raw
utf8-encoded strings.
Reviewed by Dirk Pranke.
- Scripts/webkit-patch:
- 3:09 AM Changeset in webkit [117048] by
-
- 10 edits in trunk/Source/WebCore
The ARM NEON optimized filters does not compile on THUMB2
https://bugs.webkit.org/show_bug.cgi?id=86457
Reviewed by Csaba Osztrogonác.
We should disable the compilation on Thumb2 until we fix the code.
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformArithmeticSoftware):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApply):
- platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp:
- platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
- platform/graphics/filters/arm/FEGaussianBlurNEON.cpp:
- platform/graphics/filters/arm/FEGaussianBlurNEON.h:
- platform/graphics/filters/arm/FELightingNEON.cpp:
- platform/graphics/filters/arm/FELightingNEON.h:
- 3:04 AM Changeset in webkit [117047] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking plugins/npruntime/delete-plugin-within-getProperty.html
as crashing for GTK.
- platform/gtk/test_expectations.txt:
- 2:49 AM Changeset in webkit [117046] by
-
- 26 edits4 copies7 moves2 adds in trunk
Source/WebKit: [EFL] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.
- PlatformEfl.cmake: Removed ewk_logging.h file from EWebKit_HEADERS.
Source/WebKit/efl: [EFL] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.
Split ewk_private file to multiple private files.
Delete ewk_logging.h and ewk_tiled_private.h files and removed tiled_backing_store logging domain.
- WebCoreSupport/ChromeClientEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/EditorClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- ewk/ewk_auth.cpp:
- ewk/ewk_auth_soup.cpp:
(detach):
- ewk/ewk_auth_soup_private.h: Renamed from Source/WebKit/efl/ewk/ewk_auth_soup.h.
- ewk/ewk_contextmenu_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
- ewk/ewk_frame.cpp:
- ewk/ewk_frame_private.h: Added.
(WebCore):
(EWKPrivate):
- ewk/ewk_history.cpp:
- ewk/ewk_history_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
(EWKPrivate):
- ewk/ewk_js.cpp:
- ewk/ewk_js_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(_Ewk_JS_Object):
- ewk/ewk_main.cpp:
- ewk/ewk_network.cpp:
- ewk/ewk_private.h:
(WebCore):
- ewk/ewk_security_origin_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
- ewk/ewk_settings.cpp:
- ewk/ewk_settings_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
- ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(ewk_tiled_backing_store_add):
- ewk/ewk_tiled_backing_store_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.h.
(_Ewk_Tile_Stats):
(_Ewk_Tile):
- ewk/ewk_tiled_matrix.cpp:
- ewk/ewk_tiled_matrix_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.h.
- ewk/ewk_tiled_model.cpp:
(tile_account):
- ewk/ewk_tiled_model_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.h.
- ewk/ewk_util.cpp:
- ewk/ewk_util_private.h: Renamed from Source/WebKit/efl/ewk/ewk_util.h.
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
- ewk/ewk_view_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
(EWKPrivate):
- ewk/ewk_view_single.cpp:
- ewk/ewk_view_tiled.cpp:
- ewk/ewk_window_features.cpp:
- ewk/ewk_window_features_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
Tools: [EFL][DRT] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
- 2:39 AM Changeset in webkit [117045] by
-
- 8 edits in trunk
[Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=83576
Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.
Source/WebKit2:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebView::allowAnyHTTPSCertificateForLocalHost): Added.
(QQuickWebView::setAllowAnyHTTPSCertificateForLocalHost): Added.
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate): Added bool m_allowAnyHTTPSCertificateForLocalHost.
Tools:
Set the PlatformWebView for the Qt port to accept all SSL certificates.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
LayoutTests:
Unskipped http/tests/navgiation/https-in-page-cache.html
- platform/qt-5.0-wk2/Skipped:
- 2:13 AM Changeset in webkit [117044] by
-
- 4 edits in trunk/Source/WebCore
Kill unnecessary RuntimeEnabledFeatures.h inclusion
https://bugs.webkit.org/show_bug.cgi?id=86451
Reviewed by Kentaro Hara.
No new tests. No behavior change.
- dom/Element.cpp:
- dom/ElementShadow.cpp:
- dom/TreeScope.cpp:
- 1:59 AM Changeset in webkit [117043] by
-
- 5 edits in trunk/Source/WebKit/chromium
Speech JavaScript API: Introduce error code enum in Chromium plumbing
https://bugs.webkit.org/show_bug.cgi?id=86353
Reviewed by Adam Barth.
Introduce an enum for receiving error codes from the embedder.
This enum matches the enum in SpeechRecognitionError.
- public/WebSpeechRecognizerClient.h:
- src/AssertMatchingEnums.cpp:
- src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::didReceiveError):
- src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
- 1:51 AM Changeset in webkit [117042] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening after r116986, r117012 and r117016.
- platform/gtk/test_expectations.txt:
- 1:24 AM Changeset in webkit [117041] by
-
- 16 edits2 adds in trunk
document.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=86341
Reviewed by Ryosuke Niwa.
.:
Exports necessary symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
When document.execCommand('Indent') is executed in the direct child of ShadowRoot,
the scope variable of TextIterator becomes ShadowRoot. However, an element is assumed for it,
so a crash happended.
This patch enables TextIterator to have ShadowRoot as a scope variable.
Test: editing/shadow/execcommand-indent-in-shadow.html
- WebCore.exp.in:
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
- editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
- editing/TextIterator.h:
(TextIterator):
- editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
(WebCore::visiblePositionForIndex):
- editing/htmlediting.h:
(WebCore):
Source/WebKit/chromium:
- src/WebRange.cpp:
(WebKit::WebRange::fromDocumentRange):
Source/WebKit2:
Exports necessary symbols.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- editing/shadow/execcommand-indent-in-shadow-expected.txt: Added.
- editing/shadow/execcommand-indent-in-shadow.html: Added.
- 1:15 AM Changeset in webkit [117040] by
-
- 3 edits in trunk/LayoutTests
[Qt] 6 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332
Reviewed by Csaba Osztrogonác.
Unskip these tests because they don't assert now.
- platform/qt/Skipped:
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
- 12:59 AM Changeset in webkit [117039] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip one more crashing/asserting test.
- platform/qt/Skipped:
- 12:42 AM Changeset in webkit [117038] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update test expectations.
Unreviewed EFL gardening, add 2 failing tests to
test_expectations.txt and remove 1 test that no longer exists.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15
- platform/efl/test_expectations.txt:
- 12:13 AM Changeset in webkit [117037] by
-
- 4 edits in trunk/LayoutTests
2012-05-14 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Renegerate three pixel test results on Lion, so that the svg/ pixel tests pass with tolerance 0 again.
- platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/mac/svg/hixie/mixed/003-expected.png:
- 12:11 AM Changeset in webkit [117036] by
-
- 15 edits in trunk/Source
Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=86428
Reviewed by Hajime Morita.
Source/WebCore:
Since Node::shadowTreeRootNode() returns only ShadowRoot or 0 now, its return type should be ShadowRoot.
This patch changes the return type and adds include directive to build.
No new tests, no change in behavior.
- dom/Node.cpp:
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::shadowTreeRootNode):
- dom/Node.h:
(WebCore):
(Node):
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
- dom/Range.cpp:
(WebCore::Range::shadowTreeRootNode):
- dom/Range.h:
(Range):
- editing/Editor.cpp:
- editing/TextIterator.cpp:
- editing/htmlediting.cpp:
- html/shadow/ContentSelectorQuery.cpp:
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::detach):
- page/EventHandler.cpp:
Source/WebKit/chromium:
Adds include directive to build.
- src/WebFrameImpl.cpp:
- 12:04 AM Changeset in webkit [117035] by
-
- 2 edits in trunk/LayoutTests
Content Security Policy console error messages should include the violated directive.
https://bugs.webkit.org/show_bug.cgi?id=86323
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-15
Reviewed by Adam Barth.
Update global expectations for 1 Content Security Policy test after r117006.
- http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
