Timeline



May 18, 2012:

11:36 PM Changeset in webkit [117679] by rniwa@webkit.org
  • 314 edits
    2 adds
    4 deletes in trunk/LayoutTests

Yet another Chromium rebaselines after r117672.

  • fast/forms/textfield-outline-expected.txt: Added.
  • platform/chromium-linux-x86/fast/forms/date: Removed.
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/encoding-test-expected.png:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.png:
  • platform/chromium-linux/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/input-align-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-linux/fast/forms/input-baseline-expected.png:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-linux/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-linux/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-linux/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-linux/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-linux/fast/forms/input-spaces-expected.png:
  • platform/chromium-linux/fast/forms/input-table-expected.png:
  • platform/chromium-linux/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-linux/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-linux/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-linux/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-linux/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-linux/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/forms/input-width-expected.png:
  • platform/chromium-linux/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-linux/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-linux/fast/forms/search-rtl-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-linux/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/chromium-linux/fast/forms/text-style-color-expected.png:
  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.png:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-leopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-leopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-leopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/input-align-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac/fast/forms/input-table-expected.png:
  • platform/chromium-mac/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-width-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-styled-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/chromium-win/fast/forms/basic-inputs-expected.png:
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/encoding-test-expected.png:
  • platform/chromium-win/fast/forms/encoding-test-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.png:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/input-align-expected.png:
  • platform/chromium-win/fast/forms/input-align-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
  • platform/chromium-win/fast/forms/input-baseline-expected.png:
  • platform/chromium-win/fast/forms/input-baseline-expected.txt:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-win/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.png:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-table-expected.png:
  • platform/chromium-win/fast/forms/input-table-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-win/fast/forms/input-text-word-wrap-expected.txt:
  • platform/chromium-win/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-win/fast/forms/input-type-text-min-width-expected.txt:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/forms/input-width-expected.png:
  • platform/chromium-win/fast/forms/input-width-expected.txt:
  • platform/chromium-win/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-win/fast/forms/minWidthPercent-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.png:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/chromium-win/fast/forms/text-style-color-expected.png:
  • platform/chromium-win/fast/forms/text-style-color-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.png:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/efl/fast/forms/textfield-outline-expected.txt: Removed.
  • platform/gtk/fast/forms/textfield-outline-expected.txt: Removed.
11:13 PM Changeset in webkit [117678] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] remove obsolete WebViewClient::startDragging version
​https://bugs.webkit.org/show_bug.cgi?id=86887

Reviewed by Adam Barth.

  • public/WebViewClient.h:

(WebKit::WebViewClient::startDragging):

11:09 PM Changeset in webkit [117677] by rniwa@webkit.org
  • 426 edits
    60 adds
    2 deletes in trunk/LayoutTests

More Chromium rebaselines after r117672.

  • platform/chromium-linux-x86/css3: Added.
  • platform/chromium-linux-x86/css3/selectors3: Added.
  • platform/chromium-linux-x86/css3/selectors3/html: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-23-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-24-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-68-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-69-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/navigation: Added.
  • platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/chromium-linux/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-linux/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-linux/editing/pasteboard/4806874-expected.png:
  • platform/chromium-linux/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-linux/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/editing/selection/4895428-3-expected.png:
  • platform/chromium-linux/editing/selection/4975120-expected.png:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.png:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/css/line-height-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-input-expected.png:
  • platform/chromium-linux/fast/dom/isindex-001-expected.png:
  • platform/chromium-linux/fast/dom/isindex-002-expected.png:
  • platform/chromium-linux/fast/events/autoscroll-expected.png:
  • platform/chromium-linux/fast/events/context-no-deselect-expected.png:
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png:
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png:
  • platform/chromium-linux/fast/html/details-open2-expected.png:
  • platform/chromium-linux/fast/html/details-open4-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-linux/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-linux/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-linux/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-linux/fast/table/text-field-baseline-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-linux/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-linux/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-linux/svg/hixie/mixed/003-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-leopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-leopard/fast/table/003-expected.png:
  • platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac/editing/selection/4975120-expected.png:
  • platform/chromium-mac/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac/fast/css/line-height-expected.png:
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac/fast/events/autoscroll-expected.png:
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac/fast/html/details-open2-expected.png:
  • platform/chromium-mac/fast/html/details-open4-expected.png:
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-mac/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac/fast/table/003-expected.png:
  • platform/chromium-mac/fast/table/colspanMinWidth-expected.png: Added.
  • platform/chromium-mac/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-win-vista/css3: Added.
  • platform/chromium-win-vista/css3/selectors3: Added.
  • platform/chromium-win-vista/css3/selectors3/html: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-23-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-24-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-68-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/html/css3-modsel-69-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-23-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-24-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-69-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xml: Added.
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-23-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-68-expected.png: Added.
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-69-expected.png: Added.
  • platform/chromium-win-vista/http/tests/navigation: Added.
  • platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
  • platform/chromium-win/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-win/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4806874-expected.png:
  • platform/chromium-win/editing/pasteboard/4806874-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.png:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.png:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/drag-select-1-expected.png:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/line-height-expected.png:
  • platform/chromium-win/fast/css/line-height-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.png:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/dom/isindex-001-expected.png:
  • platform/chromium-win/fast/dom/isindex-001-expected.txt:
  • platform/chromium-win/fast/dom/isindex-002-expected.png:
  • platform/chromium-win/fast/dom/isindex-002-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.png:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.png:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.png:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.png:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.png:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.png:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.png:
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
  • platform/chromium-win/fast/table/text-field-baseline-expected.png:
  • platform/chromium-win/fast/table/text-field-baseline-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.png:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/chromium/test_expectations.txt:
10:21 PM Changeset in webkit [117676] by Philippe Normand
  • 134 edits
    14 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r117672.

  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: Added.
  • platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: Added.
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Added.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt: Added.
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/gtk/editing/inserting/before-after-input-element-expected.txt:
  • platform/gtk/editing/pasteboard/4806874-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/input-field-1-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/line-height-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/dom/isindex-001-expected.txt:
  • platform/gtk/fast/dom/isindex-002-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-disabled-color-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/input-width-expected.txt:
  • platform/gtk/fast/forms/minWidthPercent-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
  • platform/gtk/fast/table/003-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-expected.txt:
  • platform/gtk/fast/table/form-with-table-style-expected.txt:
  • platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
  • platform/gtk/fast/table/text-field-baseline-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt:
  • platform/gtk/svg/hixie/mixed/003-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt: Added.
10:20 PM Changeset in webkit [117675] by commit-queue@webkit.org
  • 10 edits in trunk

Source/WebKit/chromium: [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
​https://bugs.webkit.org/show_bug.cgi?id=86684

Patch by Kausalya Madhusudhanan <​kmadhusu@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • public/WebFrame.h:

(WebFrame):

  • public/WebPlugin.h:

(WebPlugin):

  • public/WebPrintParams.h:

(WebKit::WebPrintParams::WebPrintParams):
(WebPrintParams):

  • src/WebFrameImpl.cpp:

(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printBegin):

Tools: [chromium] User overloaded printBegin() webkit API to support auto fit to page functionality.
​https://bugs.webkit.org/show_bug.cgi?id=86684

Patch by Kausalya Madhusudhanan <​kmadhusu@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::numberOfPages):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printPage):

9:36 PM Changeset in webkit [117674] by rniwa@webkit.org
  • 171 edits in trunk/LayoutTests

Chromium Mac rebaseline after r117672.

  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
9:35 PM Changeset in webkit [117673] by rniwa@webkit.org
  • 161 edits
    1 delete in trunk/LayoutTests

Mac rebaseline after r117672.

  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt: Removed.
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
9:29 PM Changeset in webkit [117672] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

WebKit erroneously add 1px padding in input elements
​https://bugs.webkit.org/show_bug.cgi?id=86784

Reviewed by Kent Tamura.

Source/WebCore:

Fixed the bug by removing the code that added left and right paddings in input elements.
The code was added in r13567 to match a very old version of Internet Explorer but this quirk
does not seem to exists in IE9 (both in quirks and standard modes).

A lot of tests need to be rebaselined due to 1px difference inside input elements, and 2px
differences for the width of input elements. (In some extreme cases, line breaking changed
due to the width change).

Test: fast/forms/input-textarea-padding-match.html

  • css/html.css:

(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

LayoutTests:

Add a regression test.

Rebaseline lots of tests per getting rid of extra 1px padding on left and right will be done
in separate commits. Input elements' widths got shrunk by 2px in most cases and the text moved
1px to the start (left for LTR and right for RTL).

  • fast/forms/input-textarea-padding-match-expected.html: Added.
  • fast/forms/input-textarea-padding-match.html: Added.
9:21 PM Changeset in webkit [117671] by Philippe Normand
  • 3 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out r117628.
​http://trac.webkit.org/changeset/117628
​https://bugs.webkit.org/show_bug.cgi?id=86936

triggers 20+ timeouts in the editing test suite (Requested by
philn on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-18

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString):

  • webkit/webkitspellcheckerenchant.cpp:

(checkSpellingOfString):

8:29 PM Changeset in webkit [117670] by pkasting@chromium.org
  • 4 edits
    2 adds
    4 deletes in trunk/LayoutTests

More baseline updates after r117640.
​https://bugs.webkit.org/show_bug.cgi?id=86920

Unreviewed, test expectations update.

  • fast/forms/form-hides-table-expected.txt: Removed.
  • fast/table/form-with-table-style-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Removed.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/form-hides-table-expected.txt:
  • platform/chromium-win/fast/table/form-with-table-style-expected.png:
  • platform/chromium-win/fast/table/form-with-table-style-expected.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt: Added.
  • platform/gtk/fast/table/form-with-table-style-expected.txt: Added.
8:23 PM Changeset in webkit [117669] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Fix expectation for test from r117667 with the bot result.

The diff also happens to match the result for the other ports.

  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
8:18 PM Changeset in webkit [117668] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip a few tests which are actually passing.

  • platform/efl/Skipped:
7:59 PM Changeset in webkit [117667] by rakuco@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

[EFL] Unskip tests and add expectations after r116776.

  • platform/efl/Skipped:
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
7:50 PM Changeset in webkit [117666] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Gardening after r116761 and the jhbuild/font changes.

  • platform/efl/Skipped:
  • platform/efl/fast/forms/select-disabled-appearance-expected.png:
  • platform/efl/fast/forms/select-disabled-appearance-expected.txt:
7:24 PM Changeset in webkit [117665] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix broken expectations in r117651.

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
6:13 PM Changeset in webkit [117664] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Add diagnostic CRASH calls for tiler crashes
​https://bugs.webkit.org/show_bug.cgi?id=86930

Reviewed by James Robinson.

These lines would normally crash on their own due to null pointers,
but having an explicit CRASH call will help us differentiate what the
real problem might be in the crash report.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::updateTiles):

6:11 PM Changeset in webkit [117663] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r136942 to r137976.

  • DEPS:
6:08 PM Changeset in webkit [117662] by commit-queue@webkit.org
  • 20 edits
    6 adds in trunk

Source/WebCore: Update Media Source implementation to reflect changes in 0.5 spec.
​https://bugs.webkit.org/show_bug.cgi?id=83607

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

Tests: http/tests/media/media-source/video-media-source-event-attributes.html

http/tests/media/media-source/webm/video-media-source-abort.html
http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html

  • html/HTMLAttributeNames.in: Add onwebkitsourcexxx event attribute names.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Add code to register event listeners for the onwebkitsourcexxx attributes.
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore):
(WebCore::HTMLMediaElement::webkitSourceAddId): Changed code to pass the parsed type & codecs to m_player instead of the whole MIME-type string. This was done to allow some simple parsing & validation code to be shared in WebKit instead of reimplemented in every port.
(WebCore::HTMLMediaElement::webkitSourceBuffered): New method in the v0.5 spec. It validates the parameters & that it is being called in the correct state. If so it forwards the call to m_player.
(WebCore::HTMLMediaElement::webkitSourceAppend): Adds id parameter to match v0.5 signature. Minor logic changes that avoid calling m_player for 0 byte arrays and fixes exceptions reported for a null array and a parse error so they match the spec text.
(WebCore::HTMLMediaElement::webkitSourceAbort): New method in the v0.5 spec. It validates the parameter & that it is being called in athe correct state. If so it forwards the call to m_player.

  • html/HTMLMediaElement.h:

(HTMLMediaElement): Added new methods, signature updates, and onwebitsourcexxx event listener attributes.

  • html/HTMLMediaElement.idl: Added new methods, signature updates, and onwebitsourcexxx event listener attributes.
  • platform/ContentType.cpp:

(WebCore::ContentType::codecs): A new method that parses the codecs parameter into a vector of codec strings.
(WebCore):

  • platform/ContentType.h:

(ContentType):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebCore::NullMediaPlayerPrivate::sourceBuffered): Add default implementation for this new method.
(WebCore::NullMediaPlayerPrivate::sourceRemoveId): Remove id parameter name to match other methods.
(WebCore::NullMediaPlayerPrivate::sourceAppend): Updated signature to include id parameter.
(WebCore::NullMediaPlayerPrivate::sourceAbort): Add default implementation for this new method.
(WebCore::NullMediaPlayerPrivate::sourceEndOfStream): Remove parameter name to match other methods.
(WebCore::MediaPlayer::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebCore):
(WebCore::MediaPlayer::sourceBuffered): Add implementation for new method that forwards the call to the MediaPlayerPrivate interface.
(WebCore::MediaPlayer::sourceAppend): Update method to forward the new id parameter in the signature.
(WebCore::MediaPlayer::sourceAbort): Add implementation for new method that forwards the call to the MediaPlayerPrivate interface.

  • platform/graphics/MediaPlayer.h: Update interface to include new methods and updated signatures.
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebCore::MediaPlayerPrivateInterface::sourceBuffered): Add default implementation for new method.
(WebCore::MediaPlayerPrivateInterface::sourceAppend): Update method to forward the new id parameter in the signature.
(WebCore::MediaPlayerPrivateInterface::sourceAbort): Add default implementation for new method.

Source/WebKit/chromium: Update Media Source implementation to reflect changes in 0.5 spec.
​https://bugs.webkit.org/show_bug.cgi?id=83607

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebKit::WebMediaPlayer::sourceBuffered): Add default implementation for new method.
(WebKit::WebMediaPlayer::sourceAppend): Update signature to include id parameter.
(WebKit::WebMediaPlayer::sourceAbort): Add default implementation for new method.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceAddId): Update the signature to take the parsed type and codecs vector.
(WebKit::WebMediaPlayerClientImpl::sourceBuffered): Added implementation for new method. Converts WebKit::WebTimeRanges to WebCore::TimeRanges.
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceAppend): Update signature to include id parameter.
(WebKit::WebMediaPlayerClientImpl::sourceAbort): Implementation for new method.

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl): Added declarations for new methods and updated signatures for existing ones.

LayoutTests: Updated Media Source LayoutTests to use v0.5 spec signatures and added
new tests to verify the behavior of the new methods.
​https://bugs.webkit.org/show_bug.cgi?id=83607

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-05-18
Reviewed by Darin Fisher.

  • http/tests/media/media-source/video-media-source-event-attributes-expected.txt: Added.
  • http/tests/media/media-source/video-media-source-event-attributes.html: Added. Tests onwebkitsourcexxx event attributes.
  • http/tests/media/media-source/webm/video-media-source-abort-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-abort.html: Added. Tests basic webkitSourceAbort() functionality.
  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added. Tests webkitSourceAddId() & webkitSourceRemoveId().
  • http/tests/media/media-source/webm/video-media-source-errors.html: Style fixes and add addSourceId() since we need to add an ID before appending data now.
  • http/tests/media/media-source/webm/video-media-source-play.html: Style fixes and add addSourceId().
  • http/tests/media/media-source/webm/video-media-source-seek.html: Style fixes and add addSourceId().
  • http/tests/media/media-source/webm/video-media-source-state-changes.html: Style fixes and add addSourceId().
  • http/tests/media/media-source/webm/webm-media-source.js:

(getData.request.onload): Style fix.
(getData): Style fix.
(loadWebMData): Style fix.
(addSourceId): New helper method that adds SOURCE_ID to the video tag so data can be appended with this ID.
(appendHeaders): Add SOURCE_ID parameter since the webkitSourceAppend() signature changed.
(appendCluster): Add SOURCE_ID parameter since the webkitSourceAppend() signature changed.
(appendUntilEndOfStream): Add SOURCE_ID parameter since the webkitSourceAppend() signature changed.

5:54 PM Changeset in webkit [117661] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(117646): fast/canvas/webgl/glsl-conformance.html is crashing in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=86929

Reviewed by Oliver Hunt.

The problem was that if CFG simplification saw a Branch with identical successors,
it would always perform a basic block merge. But that's wrong if the successor has
other predecessors.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

5:04 PM Changeset in webkit [117660] by rakuco@webkit.org
  • 6 edits in trunk

[EFL][DRT] Make it possible to enable CSS Grid Layout.
​https://bugs.webkit.org/show_bug.cgi?id=86921

Reviewed by Tony Chang.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::overridePreference):

4:58 PM Changeset in webkit [117659] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

Revert to float method of selection rect alignment for line box tree
​https://bugs.webkit.org/show_bug.cgi?id=86904

Reviewed by Eric Seidel.

In r117491, we introduced a new method of alignment for the selection rect in the sub-pixel case.
It turns out there is at least one case on Mac where this leaves a gap when painting selection rects
originating in the line box tree. This patch reverts us to the float method for the line box tree,
but retains the LayoutRect snapping for gap rects.

No new tests. Covered by existing tests with sub-pixel layout enabled.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection): Re-enabling the FloatRect flavor of
alignSelectionRectToDevicePixels for the line box tree.

  • rendering/InlineTextBox.cpp:

(WebCore::alignSelectionRectToDevicePixels): Moving LayoutRect flavor to RenderBlock.
(WebCore::InlineTextBox::paintSelection): Happily clearing up the bifurcation of algorithms for
sub-pixel layout.

  • rendering/InlineTextBox.h: Re-enabling the FloatRect flavor of alignSelectionRectToDevicePixels

for the line box tree.

  • rendering/RenderBlock.cpp:

(WebCore::alignSelectionRectToDevicePixels): Re-seating the LayoutRect version of
alignSelectionRectToDevicePixels for use with GapRects.

4:47 PM Changeset in webkit [117658] by eric@webkit.org
  • 4 edits
    2 adds in trunk
Assertion failure in BidiResolver::commitExplicitEmbedding() (!inIsolate()
m_currentExplicitEmbeddingSequence.isEmpty()) at wikipedia.org

​https://bugs.webkit.org/show_bug.cgi?id=76574

Reviewed by Levi Weintraub.

Source/WebCore:

Consider this example:
<span style="unicode-bidi: embed"><span style="unicode-bidi: isolate">a</span></span>
Before this patch, we would ASSERT when computing the text runs, as we would have encountered
the "embed LTR" directive from the outer span, but not try to "commit" this embedding until
we encountered the first charater (an optimization to avoid creating unnecessary bidi embedding contexts).
The ASSERT we were hitting was to ensure that embedding directives inside an isolated span
did not bleed out and effect the surrounding text.

bidi "isolate" support uses a multi-pass Unicode Bidi Algorithm (UBA), which when encountering
"isolated" sections of text ignores them in the first pass, and then goes back and runs
a separate instance of the UBA on those isolated sections.

Once we scan into an "isolate" section (during an outer UBA application) we should not respect
any embedding directives inside that "isolate" section.

However, in the above example, our "don't commit embeddings until we need them" and
"assert we don't respect embeddings inside isolated spans" were conflicting.
The fix is to make sure we always commit any pending embedding directives *before*
we enter an isolate section.

Luckly there was no functional bug here as we were still respecting
the embedding directives we were belatedly committing. After this change we're commiting
those directives at a more appropriate time, thus avoiding the ASSERT.

Test: fast/text/bidi-isolate-embedding-crash.html

  • platform/text/BidiResolver.h:

(WebCore::::commitExplicitEmbedding):

  • rendering/InlineIterator.h:

(WebCore::notifyObserverEnteredObject):
(WebCore::IsolateTracker::commitExplicitEmbedding):

LayoutTests:

  • fast/text/bidi-isolate-embedding-crash-expected.txt: Added.
  • fast/text/bidi-isolate-embedding-crash.html: Added.
4:44 PM Changeset in webkit [117657] by leviw@chromium.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed. Updating non-mac platform expectations after r117640.

  • fast/forms/form-hides-table-expected.txt: Added.
  • fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/table/form-with-table-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/form-with-table-style-expected.png:
  • platform/chromium-mac/fast/table/form-with-table-style-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt: Removed.
  • platform/gtk/fast/table/form-with-table-style-expected.txt: Removed.
4:34 PM Changeset in webkit [117656] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

BitmapImage::BitmapImage(CGImageRef, ImageObserver*) needs to set m_sizeRespectingOrientation
​https://bugs.webkit.org/show_bug.cgi?id=86915

Reviewed by Oliver Hunt.

Set m_sizeRespectingOrientation to be the same as m_size. Otherwise it stays at 0x0 since
this constructor also sets m_haveSize to true for the BitmapImage.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage):

4:28 PM Changeset in webkit [117655] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r117640) fast/table/form-with-table and fast/forms/form-hides-table fail on Mac
​https://bugs.webkit.org/show_bug.cgi?id=86920

Unreviewed. Updating expectations after r117640.

  • platform/mac/fast/forms/form-hides-table-expected.txt:
  • platform/mac/fast/table/form-with-table-style-expected.txt:
4:20 PM Changeset in webkit [117654] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFG simplification crashes if it's trying to remove an unreachable block
that has an already-killed-off unreachable successor
​https://bugs.webkit.org/show_bug.cgi?id=86918

Reviewed by Oliver Hunt.

This fixes crashes in:
inspector/styles/styles-computed-trace.html
inspector/console/console-big-array.html

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPhis):

4:12 PM Changeset in webkit [117653] by rakuco@webkit.org
  • 5 edits
    3 adds in trunk/LayoutTests

[EFL] More random gardening.

Remove a few tests which do not exist anymore from the skipped
list, and rebaseline and add expectations for a few others.

  • platform/efl/Skipped:
  • platform/efl/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
  • platform/efl/fast/invalid/004-expected.txt:
  • platform/efl/fast/invalid/010-expected.png:
  • platform/efl/fast/invalid/010-expected.txt:
  • platform/efl/fast/text/zero-font-size-expected.png: Added.
  • platform/efl/fast/text/zero-font-size-expected.txt: Added.
4:06 PM Changeset in webkit [117652] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r117607.

  • platform/mac/WebCoreNSCellExtras.m:
3:59 PM Changeset in webkit [117651] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] More expectations updates, mostly for flaky tests.
​http://code.google.com/p/chromium/issues/detail?id=24182
​https://bugs.webkit.org/show_bug.cgi?id=54151
​https://bugs.webkit.org/show_bug.cgi?id=85174
​https://bugs.webkit.org/show_bug.cgi?id=86592
​https://bugs.webkit.org/show_bug.cgi?id=86907
​https://bugs.webkit.org/show_bug.cgi?id=86908
​https://bugs.webkit.org/show_bug.cgi?id=86909

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
3:49 PM Changeset in webkit [117650] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebCore

Fix remaining uses of JSValue::toBoolean()
​https://bugs.webkit.org/show_bug.cgi?id=86912

Reviewed by Filip Pizlo.

And unbreak Qt build.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):

3:48 PM Changeset in webkit [117649] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening; update results after r117640.

  • platform/efl/fast/forms/form-hides-table-expected.txt:
  • platform/efl/fast/table/form-with-table-style-expected.txt:
3:42 PM Changeset in webkit [117648] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Try to add the right expectation for fast/forms/plaintext-mode-2.html
after r117597.

  • platform/efl/test_expectations.txt:
3:35 PM WebInspector edited by wil@marrant.org
(diff)
3:34 PM Changeset in webkit [117647] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; run CSS grid layout tests after r117613.

  • platform/efl/test_expectations.txt:
3:34 PM WebInspector edited by wil@marrant.org
(diff)
3:30 PM Changeset in webkit [117646] by fpizlo@apple.com
  • 79 edits
    4 adds in trunk/Source

DFG should have control flow graph simplification
​https://bugs.webkit.org/show_bug.cgi?id=84553

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

This change gives the DFG the ability to simplify the control flow graph
as part of an optimization fixpoint that includes CSE, CFA, and constant
folding. This required a number of interesting changes including:

  • Solidifying the set of invariants that the DFG obeys. For example, the head and tail of each basic block must advertise the set of live locals and the set of available locals, respectively. It must do so by referring to the first access to the local in the block (for head) and the last one (for tail). This patch introduces the start of a validation step that may be turned on even with asserts disabled. To ensure that these invariants are preserved, I had to remove the redundant phi elimination phase. For now I just remove the call, but in the future we will probably remove it entirely unless we find a use for it.


  • Making it easier to get the boolean version of a JSValue. This is a pure operation, but we previously did not treat it as such.


  • Fixing the merging and filtering of AbstractValues that correspond to concrete JSValues. This was previously broken and was limiting the effect of running constant folding. Fixing this meant that I had to change how constant folding eliminates GetLocal nodes, so as to ensure that the resulting graph still obeys DFG rules.


  • Introducing simplified getters for some of the things that DFG phases want to know about, like the Nth child of a node (now just graph.child(...) if you don't care about performance too much) or getting successors of a basic block.


The current CFG simplifier can handle almost all of the cases that it
ought to handle; the noteworthy one that is not yet handled is removing
basic blocks that just have jumps. To do this right we need to be able
to remove jump-only blocks that also perform keep-alive on some values.
To make this work, we need to be able to hoist the keep-alive into (or
just above) a Branch. This is not fundamentally difficult but I opted to
let this patch omit this optimization. We can handle this later.

This is a big win on programs that include inline functions that are
often called with constant arguments. Of course, SunSpider, V8, and
Kraken don't count. Those benchmarks are completely neutral with this
change.

  • API/JSValueRef.cpp:

(JSValueToBoolean):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.h:

(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):

  • bytecode/Operands.h:

(JSC::Operands::setOperandFirstTime):
(Operands):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::operator!=):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validateIgnoringValue):
(AbstractValue):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(AdjacencyList):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::~BasicBlock):
(BasicBlock):
(JSC::DFG::BasicBlock::numNodes):
(JSC::DFG::BasicBlock::nodeIndex):
(JSC::DFG::BasicBlock::isPhiIndex):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(DFG):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):
(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::performCFA):

  • dfg/DFGCFAPhase.h:

(DFG):

  • dfg/DFGCFGSimplificationPhase.cpp: Added.

(DFG):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::findOperandSource):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::dump):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
(JSC::DFG::performCFGSimplification):

  • dfg/DFGCFGSimplificationPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(CSEPhase):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h:

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGEdge.h:

(Edge):
(JSC::DFG::Edge::operator UnspecifiedBoolType*):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::performFixup):

  • dfg/DFGFixupPhase.h:

(DFG):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::handleSuccessor):
(DFG):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetReachability):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::changeIndex):
(Graph):
(JSC::DFG::Graph::changeEdge):
(JSC::DFG::Graph::numSuccessors):
(JSC::DFG::Graph::successor):
(JSC::DFG::Graph::successorForCondition):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::child):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::numSuccessors):
(Node):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::endPhase):

  • dfg/DFGPhase.h:

(JSC::DFG::runPhase):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::performPredictionPropagation):

  • dfg/DFGPredictionPropagationPhase.h:

(DFG):

  • dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::performRedundantPhiElimination):

  • dfg/DFGRedundantPhiEliminationPhase.h:

(DFG):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):
(ScoreBoard):
(JSC::DFG::ScoreBoard::useIfHasResult):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::nextBlock):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::jump):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp: Added.

(DFG):
(Validate):
(JSC::DFG::Validate::Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::reportValidationContext):
(JSC::DFG::Validate::dumpData):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
(JSC::DFG::validate):

  • dfg/DFGValidate.h: Added.

(DFG):
(JSC::DFG::validate):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):
(JSC::DFG::performVirtualRegisterAllocation):

  • dfg/DFGVirtualRegisterAllocationPhase.h:

(DFG):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncSome):

  • runtime/BooleanConstructor.cpp:

(JSC::constructBoolean):
(JSC::callBooleanConstructor):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::toBoolean):

  • runtime/JSString.h:

(JSString):
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

  • runtime/JSValue.h:
  • runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorMultiline):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

Source/WebCore:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

No new tests, because no new behavior.

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDirectoryEntryCustom.cpp:

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • bindings/js/JSDirectoryEntrySyncCustom.cpp:

(WebCore::getFlags):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(GenerateImplementation):
(JSValueToNative):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

Source/WebKit/mac:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):

Source/WebKit2:

Reviewed by Oliver Hunt.

Merged r115512 from dfgopt.

JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

3:27 PM Changeset in webkit [117645] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] add back-face visibility check for renderSurfaces
​https://bugs.webkit.org/show_bug.cgi?id=86870

Reviewed by Adrienne Walker.

Source/WebCore:

Test added CCLayerTreeHostCommonTest::verifyBackFaceCullingWithPreserves3dForFlatteningSurface

Chromium was not checking back-face visibility for renderSurfaces
that needed it. This patch adds that check and the appropriate
unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerIsInExisting3DRenderingContext):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

3:24 PM Changeset in webkit [117644] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening; unskip a few passing tests.

  • platform/efl/Skipped:
3:22 PM Changeset in webkit [117643] by dpranke@chromium.org
  • 3 edits in trunk/Tools

scm.add() doesn't work properly with svn 1.7
​https://bugs.webkit.org/show_bug.cgi?id=86779

Reviewed by Eric Seidel.

Re-land the change in r117526 with a fix to maintain
compatibility with SVN 1.4.4 (yay Leopard!); turns out
that "svn info foo" works correctly in 1.4.4 but
"svn info" from the directory "foo" doesn't if foo is
not part of a checkout. in_working_directory() and
value_from_svn_info() were using the arguments inconsistently,
leading to weird errors.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN):
(SVN.in_working_directory):

3:15 PM Changeset in webkit [117642] by leviw@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Moving myself from committer to reviewer.

  • Scripts/webkitpy/common/config/committers.py:
3:15 PM Changeset in webkit [117641] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove one-space indentation from LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
​https://bugs.webkit.org/show_bug.cgi?id=86897

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-05-18
Reviewed by Tony Chang.

  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:

2012-05-17 Levi Weintraub <​leviw@chromium.org>

Standalone table-columns should be wrapped in anonymous tables
​https://bugs.webkit.org/show_bug.cgi?id=86671

Reviewed by Julien Chaffraix.

Adding 2 test cases and updating test results for two with changed expectations.

  • fast/table/table-column-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-generates-anonymous-table.html: Added.
  • fast/table/table-column-group-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-group-generates-anonymous-table.html: Added.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Added. An anonymous

table is now generated to enclose the misparented table column.

  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.png: Modified. The

expectations previously were wrong in that the table column occupied height the
equivalent of its line-height. This is correctly no longer the case.

  • platform/chromium/test_expectations.txt: Modified. Skipping modified tests on other

platforms until I can rebaseline.

3:09 PM Changeset in webkit [117640] by leviw@chromium.org
  • 5 edits
    6 adds in trunk

Standalone table-columns should be wrapped in anonymous tables
​https://bugs.webkit.org/show_bug.cgi?id=86671

Reviewed by Julien Chaffraix.

Source/WebCore:

The CSS2 spec specifies that table-columns misparented outside of a table or
table-column-group should be wrapped in an anonymous table. Updating
RenderObject::addChild to follow the spec.
see ​http://www.w3.org/TR/CSS2/tables.html#anonymous-boxes for details.

Tests: fast/table/table-column-generates-anonymous-table.html

fast/table/table-column-group-generates-anonymous-table.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

LayoutTests:

Adding 2 test cases and updating test results for two with changed expectations.

  • fast/table/table-column-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-generates-anonymous-table.html: Added.
  • fast/table/table-column-group-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-group-generates-anonymous-table.html: Added.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Added. An anonymous

table is now generated to enclose the misparented table column.

  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.png: Modified. The

expectations previously were wrong in that the table column occupied height the
equivalent of its line-height. This is correctly no longer the case.

  • platform/chromium/test_expectations.txt: Modified. Skipping modified tests on other

platforms until I can rebaseline.

2:57 PM Changeset in webkit [117639] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip grid layout tests that are failing after r117613.

It looks like apple mac had grid layout enabled prior to r117613?
These tests shouldn't have been passing before.

  • platform/mac/test_expectations.txt:
2:50 PM Changeset in webkit [117638] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Validation of Last Fat Finger result is needed for selection.
​https://bugs.webkit.org/show_bug.cgi?id=86888

Reviewed by Antonio Gomes.

PR 128393.

Cached FatFingersResults must be validatible against
the desired request to ensure the result is both for
the same point and of the same type.

  • WebKitSupport/FatFingers.h:

(WebKit):
(FatFingersResult):
(BlackBerry::WebKit::FatFingersResult::FatFingersResult):
(BlackBerry::WebKit::FatFingersResult::reset):
(BlackBerry::WebKit::FatFingersResult::resultMatches):
(BlackBerry::WebKit::FatFingersResult::originPosition):
(BlackBerry::WebKit::FatFingersResult::adjustedPosition):
(BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
(BlackBerry::WebKit::FatFingersResult::isTextInput):
(BlackBerry::WebKit::FatFingersResult::isValid):
(BlackBerry::WebKit::FatFingersResult::node):
(BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

2:49 PM Changeset in webkit [117637] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):

2:47 PM Changeset in webkit [117636] by fpizlo@apple.com
  • 17 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should have constant propagation
​https://bugs.webkit.org/show_bug.cgi?id=84004

Reviewed by Gavin Barraclough.

Merge r114554 from dfgopt.

Changes AbstractValue to be able to hold a "set" of constants, where
the maximum set size is 1 - so merging a value containing constant A
with another value containing constant B where A != B will result in
the AbstractValue claiming that it does not know any constants (i.e.
it'll just have a predicted type and possible a structure).

Added a constant folding phase that uses this new information to
replace pure operations known to have constant results with
JSConstants. This is OSR-exit-aware, in that it will prepend a Phantom
that refers to all of the kids of the node we replaced.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberValue):
(AbstractValue):
(JSC::DFG::AbstractValue::valueIsTop):
(JSC::DFG::AbstractValue::value):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
(JSC::DFG::AdjacencyList::reset):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::constantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp: Added.

(DFG):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(Node):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(JSValue):

2:46 PM Changeset in webkit [117635] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Support imageSmoothingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=82804

Patch by Keyar Hood <​keyar@chromium.org> on 2012-05-18
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled.html

Added the imageSmoothingEnabled parameter to the
CanvasRenderingContext2D object. When it is set to false, it sets
InterpolationQuality to InterpolationNone. When set to true, it sets
the InterpolationQuality to DefaultInterpolationQuality (as that is the
only other value used).

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):

  • html/canvas/CanvasRenderingContext2D.h:

(CanvasRenderingContext2D):

  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

  • fast/canvas/canvas-imageSmoothingEnabled-expected.txt: Added.
  • fast/canvas/canvas-imageSmoothingEnabled.html: Added.
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled.js: Added.
2:45 PM Changeset in webkit [117634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Missing plugin msg becomes "insecure plugin version" after Real Player page refresh
​https://bugs.webkit.org/show_bug.cgi?id=86903
<rdar://problem/11477163>

Reviewed by Andreas Kling.

Set blocked to false before returning early when the plug-in doesn't exist.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::getPluginPath):

2:42 PM Changeset in webkit [117633] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Percentage height replaced elements sometimes cause overflow of table contents
​https://bugs.webkit.org/show_bug.cgi?id=85581

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-18
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/replaced/table-replaced-element.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This change guarantees that the containing block of a replaced element with percentage
height will be marked as having a percentage height descendant.

LayoutTests:

  • fast/replaced/table-replaced-element-expected.txt: Added.
  • fast/replaced/table-replaced-element.html: Added.

New layout test.

2:39 PM Changeset in webkit [117632] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing mac baselines after r117613.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
2:37 PM Changeset in webkit [117631] by rakuco@webkit.org
  • 7 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Work a bit on the infamous "Needs rebaseline" list by removing a few
tests which are actually passing and updating some expectations.

  • platform/efl/Skipped:
  • platform/efl/fast/forms/caret-rtl-expected.png:
  • platform/efl/fast/forms/caret-rtl-expected.txt:
  • platform/efl/fast/forms/listbox-clip-expected.png:
  • platform/efl/fast/forms/listbox-clip-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.txt:
2:36 PM Changeset in webkit [117630] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Memory leaks in WebKitBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=86872

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-18
Reviewed by Martin Robinson.

Fix memory leaks by adopting WKArray of WebBackForwardListItems
allocations using AdoptWK.

  • UIProcess/API/gtk/WebKitBackForwardList.cpp:

(webkit_back_forward_list_get_back_list):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list):
(webkit_back_forward_list_get_forward_list_with_limit):

2:36 PM Changeset in webkit [117629] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build for Qt by using ASSERT_UNUSED in DFGSpeculativeJIT
​https://bugs.webkit.org/show_bug.cgi?id=86902

Reviewed by Andreas Kling.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):

2:30 PM Changeset in webkit [117628] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

Spell checker doesn't recognize contractions (apostrophes)
​https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-05-18
Reviewed by Gustavo Noronha Silva.

The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. In reality, to know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character. In reality, WebCore has already
ensured that any apostrophes in the string belong to contractions by
using the WordBreakIterator.

Simplify the way the we break strings, by just manually trimming off
all non-graphable characters from the string and then finding the end
of the first word by looking for the next non-graphable character.
This has the side effect of removing the dependency on Pango and
eliminating one copy.

This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.

  • webkit/webkitspellcheckerenchant.cpp:

(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(checkSpellingOfString): Don't split words on apostrophes.

2:24 PM Changeset in webkit [117627] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Fix

ietestcenter/css3/valuesandunits/units-000.htm expectations after
r117609.

2:22 PM Changeset in webkit [117626] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaseline test after r117412.

  • platform/efl/fast/borders/border-antialiasing-expected.png:
  • platform/efl/test_expectations.txt:
2:10 PM Changeset in webkit [117625] by ostapenko.viatcheslav@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r117501): It made almost all tests assert in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=86854

Reviewed by Andreas Kling.

Initialize boolean flag in constructor and recheck the flag which can be
modified by another thread under mutex.

No new tests, fixes regression that caused layout test crash.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::syncThreadMainLoop):

2:01 PM Changeset in webkit [117624] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

[EFL] Web Intents code is not compiling
​https://bugs.webkit.org/show_bug.cgi?id=85364

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Adam Barth.

.:

Remove broken CMake directive for WEB_INTENTS.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add missing implementation for
JSIntentConstructor::constructJSIntent() in JS bindings.

  • CMakeLists.txt:
  • UseJSC.cmake:
  • bindings/js/JSIntentConstructor.cpp: Added.

(WebCore):
(WebCore::JSIntentConstructor::constructJSIntent):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp: Add missing header include.
  • ewk/ewk_intent_private.h: Ditto.
  • ewk/ewk_intent_request.cpp:

(ewk_intent_request_new): Do not PassRefPtr after it becomes 0.

LayoutTests:

Move webintents test cases to test expectations until the needed
features are implemented and Web Intents are enabled by default
for EFL port.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
1:57 PM Changeset in webkit [117623] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

PDF page does not show up when opened in the background
​https://bugs.webkit.org/show_bug.cgi?id=86890
<rdar://problem/11259951>

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateAcceleratedCompositingMode:WebKit::]):
Just set the new render layer if we're already in accelerated compositing mode.

1:52 PM Changeset in webkit [117622] by commit-queue@webkit.org
  • 5 edits in trunk

background-size specified by a single value in background shorthand fails to parse.
​https://bugs.webkit.org/show_bug.cgi?id=86739

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-05-18
Reviewed by Tony Chang.

While parsing the background shorthand property, if the second parsedValue is not a valid unit,
parseFillSize should return the first parsedValue instead of failing.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillSize):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
1:45 PM Changeset in webkit [117621] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Buildbot output does not print result stats anymore
​https://bugs.webkit.org/show_bug.cgi?id=85366

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Make run-webkit-tests pass --verbose to new-run-webkit-tests
on EFL Debug bot.

  • Scripts/run-webkit-tests:

(runningOnBuildBot):

1:42 PM Changeset in webkit [117620] by fpizlo@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should have out-of-line slow paths
​https://bugs.webkit.org/show_bug.cgi?id=83992

Reviewed by Oliver Hunt.

Merge of r114472 and r114553 from dfgopt.

Introduces the notion of slow path code generation closures in the DFG.
These are defined in DFGSlowPathGenerator.h, though they are fairly
extensible so DFGSpeculativeJIT64.cpp and DFGSpeculativeJIT32_64.cpp
define a couple special-purpose ones. A slow path generation closure
(DFG::SlowPathGenerator) is executed after the main speculative path is
generated. This makes them great for scheduling slow path code out of
the way of the hot paths.

This patch also converts most - but not all - of the DFG to use slow
path generators instead of inline slow paths.

The result is a sub-1% improvement on SunSpider and V8, and a miniscule
regression on Kraken.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
(TrustedImmPtr):
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGCommon.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(DFG):
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
(JITCompiler):

  • dfg/DFGSilentRegisterSavePlan.h: Added.

(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):

  • dfg/DFGSlowPathGenerator.h: Added.

(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

1:40 PM Changeset in webkit [117619] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Remove the obsolete AM_PROG_CC_STDC
​https://bugs.webkit.org/show_bug.cgi?id=85250

Patch by Adrian Bunk <​bunk@stusta.de> on 2012-05-18
Reviewed by Martin Robinson.

  • configure.ac:
1:37 PM Changeset in webkit [117618] by rakuco@webkit.org
  • 2 edits in trunk

[CMake] Unreviewed, remove ENABLE_CSS_GRID_LAYOUT option after r117613.

  • Source/cmake/WebKitFeatures.cmake:
1:36 PM Changeset in webkit [117617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Default values for ewk_view video tracks settings should be documented
​https://bugs.webkit.org/show_bug.cgi?id=85169

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Antonio Gomes.

Document default values for video tracks settings in ewk_view.

  • ewk/ewk_view.h:
1:35 PM Changeset in webkit [117616] by rakuco@webkit.org
  • 8 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Update a few text expectations after r116761 and the jhbuild and
font updates. tables/mozilla is still being skipped, but I will
unskip it after all the new expectations are landed.

  • platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55694-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_caption_align_top-expected.txt:
1:33 PM Changeset in webkit [117615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable web intents flag for chromium build
​https://bugs.webkit.org/show_bug.cgi?id=86762

Patch by Greg Billock <​gbillock@google.com> on 2012-05-18
Reviewed by Adam Barth.

This flag is enabled in the Chromium-side build.

  • features.gypi:
1:30 PM Changeset in webkit [117614] by haraken@chromium.org
  • 1 edit
    1 delete in trunk/PerformanceTests

[perf-test] Remove Bindings/dom-attributes.html
​https://bugs.webkit.org/show_bug.cgi?id=86820

Reviewed by Ryosuke Niwa.

Bindings/dom-attributes.html is just a collection of random
DOM attributes and methods. Now we've added more reasonable
micro benchmarks by classifying DOM binding call paths, we
can remove Bindings/dom-attributes.html.

  • Bindings/dom-attributes.html: Removed.
12:41 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
12:23 PM Changeset in webkit [117613] by tony@chromium.org
  • 77 edits
    2 adds in trunk

remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
​https://bugs.webkit.org/show_bug.cgi?id=86767

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Remove ENABLE_CSS_GRID_LAYOUT.

Source/WebCore:

We disable grid by ignoring the display type at CSS parse time.

Test: fast/css-grid-layout/grid-disabled-by-default.html

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp: Remove compile checks.

(WebCore):
(WebCore::valueForGridPosition):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue): Move display into parseValue.
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue): Ignore while parsing if not enabled.
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::cssGridLayoutEnabled):
(WebCore):

  • css/CSSParser.h:
  • css/CSSParserMode.h:

(CSSParserContext):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • dom/Document.cpp:

(WebCore::Document::cssGridLayoutEnabled): Added to keep track of whether grid is enabled or not.
(WebCore):

  • dom/Document.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setCSSGridLayoutEnabled): Added.
(WebCore::Settings::cssGridLayoutEnabled): Added.
(Settings):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleGridData.cpp:
  • rendering/style/StyleGridData.h:
  • rendering/style/StyleGridItemData.cpp:
  • rendering/style/StyleGridItemData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(WebCore):
(StyleRareNonInheritedData):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setExperimentalCSSGridLayoutEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cssGridLayoutEnabled]):
(-[WebPreferences setCSSGridLayoutEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSGridLayoutEnabled):
(WKPreferencesGetCSSGridLayoutEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • fast/css-grid-layout/display-grid-set-get.html: Enable grid layout for the test.
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: Enable grid layout for the test.
  • fast/css-grid-layout/grid-columns-rows-get-set.html: Enable grid layout for the test.
  • fast/css-grid-layout/grid-disabled-by-default-expected.txt: Added.
  • fast/css-grid-layout/grid-disabled-by-default.html: Added.
  • fast/css-grid-layout/grid-item-column-row-get-set.html: Enable grid layout for the test.
  • platform/chromium/test_expectations.txt: Run grid layout tests.
12:16 PM Changeset in webkit [117612] by Martin Robinson
  • 12 edits
    1 delete in trunk/Source

OOM running webgl/sdk/tests/conformance/context/context-creation-and-destruction.html
​https://bugs.webkit.org/show_bug.cgi?id=80509

Reviewed by Alejandro G. Castro.

Source/WebCore:

No new tests. This is covered by by context-creation-and-destruction.html
Khronos conformance test which will be part of the WebKit repository once
bug 44310 is closed.

Rework the ownership of GLContexts. Instead of having them managed by the
state of window mapping or removed by calling a static method, always have
them owned by the callers. This makes all GLContext creators factory methods
that return PassOwnPtr.

This change also switches the sharing context for a WebView from the window
context to a global shared context. This simplifies things greatly, allowing
the removal of GLContextGtk and makes the factory change easier.

  • GNUmakefile.list.am: Remove GLContextGtk.cpp from the source list.
  • platform/graphics/cairo/GLContext.cpp:

(WebCore::GLContext::sharingContext): Added, getter for the global sharing context.
(WebCore::GLContext::createContextForWindow): Added, a factory method for creating
window contexts.
(WebCore::GLContext::createOffscreenContext): Allow passing a sharing context here.
(WebCore::GLContext::makeContextCurrent): Assert that this is the main thread, to
increase the guarantee that we are only using these contexts on the main thread.
(WebCore::GLContext::getCurrent): Ditto.

  • platform/graphics/cairo/GLContext.h: Update the above method signatures and remove

createOffscreenContext, which has just been subsumed into the other factory methods.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: The HostWindow is no longer needed

to get the sharing context, so we can simplify things quite a bit and make a platform
independent implementation here.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Ditto.
  • platform/graphics/glx/GLContextGLX.cpp: Modify all the factory methods to return PassOwnPtr.
  • platform/graphics/glx/GLContextGLX.h: Ditto.
  • platform/graphics/gtk/GLContextGtk.cpp: Removed.

Source/WebKit/gtk:

AcceleratedCompositingContext context now fully owns the GLContext for its
window. This simplifies this quite a bit. We also properly clean it up when
destroying the layer tree, to go more easily on resources.

  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::glContext):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):

12:12 PM Changeset in webkit [117611] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Script elements inserted while fragment parsing should have their "already started" flag set.
​https://bugs.webkit.org/show_bug.cgi?id=86376

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

Step 3 of:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#scriptTag

Test: fast/parser/script-already-started-flag-in-fragment-parsing-mode.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::create):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertScriptElement):

LayoutTests:

  • fast/parser/script-already-started-flag-in-fragment-parsing-mode-expected.txt: Added.
  • fast/parser/script-already-started-flag-in-fragment-parsing-mode.html: Added.
11:42 AM Changeset in webkit [117610] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Expose FrameSelection::absoluteCaretBounds via window.internals
​https://bugs.webkit.org/show_bug.cgi?id=86390

Patch by Shezan Baig <​shezbaig.wk@gmail.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

.:

Exports necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Add 'absoluteCaretBounds' method to Internals, which returns the
FrameSelection::absoluteCaretBounds.

Test: editing/selection/internal-caret-rect.html

  • WebCore.exp.in: Export the necessary symbols.
  • testing/Internals.cpp:

(WebCore::Internals::absoluteCaretBounds): Implementation of new method.
(WebCore):

  • testing/Internals.h: Declare the new method.

(Internals):

  • testing/Internals.idl: Declare the new method.

Source/WebKit2:

Exports necessary symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

A simple test case for the new 'absoluteCaretBounds' method.

  • editing/selection/internal-caret-rect-expected.txt: Added.
  • editing/selection/internal-caret-rect.html: Added.
11:33 AM Changeset in webkit [117609] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding test expectations for a few tests
crashing on the debug builds.

  • platform/gtk/test_expectations.txt:
11:11 AM Changeset in webkit [117608] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Multithreaded compositor unit tests intermittently failing
​https://bugs.webkit.org/show_bug.cgi?id=74623

Patch by Ian Vollick <​vollick@chromium.org> on 2012-05-18
Reviewed by Adrienne Walker.

The flakiness of the CCLayerTreeHost tests stem from processing tasks after the
tests finish. To fix this, I've disabled the dispatch* methods after endTest is
called, effectively preventing any further tasks scheduled by the tests from
being processed. I have also reworked the checks in
CCLayerTreeHostTestWriteLayersRedraw to make the test more robust.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimate):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsAnimateAndCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchAcquireLayerTextures):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::dispatchSetVisible):
(WTF::CCLayerTreeHostTest::dispatchSetInvisible):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::endTest):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestWriteLayersRedraw::afterTest):

11:09 AM Changeset in webkit [117607] by mitz@apple.com
  • 4 edits
    2 adds in trunk/Source/WebCore

<rdar://problem/11467250> No focus ring around popup buttons

Reviewed by Anders Carlsson.

The exact same issue was fixed for buttons drawn in ThemeMac.mm in <rdar://problem/10542095>.
This change extends the fix to also cover buttons drawn in RenderThemeMac.mm.

  • WebCore.xcodeproj/project.pbxproj: Added WebCoreNSCellExtras.{h.m}.
  • platform/mac/ThemeMac.mm: Removed the definitions of BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING

and -[NSCell _web_drawFocusRingWithFrame:inView:] from here. They are now in WebCoreNSCellExtras.

  • platform/mac/WebCoreNSCellExtras.h: Added.
  • platform/mac/WebCoreNSCellExtras.m: Added.

(-[NSCell _web_drawFocusRingWithFrame:inView:]): Moved from ThemeMac.mm here.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuList): Changed to use -_web_drawFocusRingWithFrame:inView:.
(WebCore::RenderThemeMac::setPopupButtonCellState): Removed call to updateFocusedState() when
the focus ring is drawn separately.

11:02 AM Changeset in webkit [117606] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] Fix early return of the mimeTypeCache function after r117207.

Rubber-stamped by Martin Robinson.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Set

typeListInitialized to true after the cache has been filled so
that next call to the function goes through the early return path.

10:50 AM Changeset in webkit [117605] by Martin Robinson
  • 5 edits in trunk

Get IndexedDB closer to building for GTK+.

Reviewed by Philippe Normand.

.:

  • configure.ac: Make out the IndexedDB imply USE_LEVELDB, as LevelDB is the

only IndexedDB backend at the moment. Also mark IndexedDB as incomplete.

Source/WebCore:

No new tests. This is only a build fix.

  • GNUmakefile.am: Add the appropriate option to enable LevelDB support.
  • GNUmakefile.list.am: Add missing indexed database files to the source list.
9:56 AM Changeset in webkit [117604] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Removed stale references in the Xcode project after r117369.

  • WebCore.xcodeproj/project.pbxproj: Removed references to CSSStyleDeclaration.cpp.
9:42 AM Changeset in webkit [117603] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Refactor LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
​https://bugs.webkit.org/show_bug.cgi?id=86782

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-05-18
Reviewed by Tony Chang.

Refactored the testcase to include round-trip testing.

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
9:20 AM Changeset in webkit [117602] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=86859
(r117572) editing/spelling/spellcheck-async-remove-frame.html crashes on Mac

  • platform/mac/Skipped:
9:13 AM Changeset in webkit [117601] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/Script.js

Fixing crbug.com/127741: DevTools: [regression] devtools scripts tree is flooded with internal chromium extension scripts.

  • inspector/front-end/Script.js:

TBR=​vsevik@chromium.org
BUG=127741
Review URL: ​https://chromiumcodereview.appspot.com/10409030

9:10 AM Changeset in webkit [117600] by vsevik@chromium.org
  • 17 edits in trunk

Web Inspector: Add resource to UISourceCode constructor.
​https://bugs.webkit.org/show_bug.cgi?id=86853

Reviewed by Pavel Feldman.

Source/WebCore:

This is a first step of merging resource revision support into UISourceCode.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping.prototype._debuggerReset):

  • inspector/front-end/JavaScriptSource.js:
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createUISourceCode):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isAnonymousScript):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSource):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._contentChanged):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.resource):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code.html:
8:57 AM Changeset in webkit [117599] by yurys@chromium.org
  • 4 edits in trunk

Web Inspector: error when expanding an HTMLAllCollection object in the console
​https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

RuntimeAgent.callFunctionOn should work correcly with arguments of type HTMLAllCollection.

  • inspector/InjectedScriptSource.js:

LayoutTests:

  • inspector/console/inspect-html-all-collection.html:
8:39 AM Changeset in webkit [117598] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: resource revision content is not rendered properly. Resource content is shown instead.
​https://bugs.webkit.org/show_bug.cgi?id=86856

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceRevisionSourceFrame):
(WebInspector.ResourceRevisionSourceFrame.prototype.get resource):

8:38 AM Changeset in webkit [117597] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening failure test cases.
​https://bugs.webkit.org/show_bug.cgi?id=86728

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com>, Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2012-05-18

  • platform/efl/Skipped: removing tests related to editing callbacks functionality.
  • platform/efl/test_expectations.txt: adding new bugs regarding drag'n'drop and spell checking.

Merging tests with particular bugs.

8:34 AM Changeset in webkit [117596] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

fast/events/mouseup-from-button2.html needs a specific expected file for Qt
​https://bugs.webkit.org/show_bug.cgi?id=86783

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-18
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/events/mouseup-from-button2-expected.txt: Added.
8:21 AM Changeset in webkit [117595] by Carlos Garcia Campos
  • 5 edits
    1 move in trunk/Source/WebKit2

[GTK] Allow to attach/detach the inspector in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=86823

Reviewed by Gustavo Noronha Silva.

Also rename WebInspectorGtk.cpp as WebInspectorProxyGtk.cpp since
it implements the platform specific methods of WebInspectorProxy.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerAdd): Allow to add a WebView containing
the inspector as an internal child.
(webkitWebViewBaseContainerRemove): Check whether the widget
removed is the inspector web view.
(webkitWebViewBaseContainerForall): When includeInternals is True,
add also the inspector web view if it's present.
(resizeWebKitWebViewBaseFromAllocation): Allocate space for the
inspector web view if it's present.
(webkitWebViewBaseSetInspectorViewHeight): Private function used
by the inspector proxy to set the height of the inspector web
view.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy): Remove unneeded method windowDestroyed.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp.

(WebKit::inspectorFilesBasePath):
(WebKit::inspectorWindowClosed): Renamed as inspectorWindowClosed
instead of inspectorWindowDestroyed, since this is called when the
window manager requests to close the window, and not when the
widget is destroyed. Also remove the call to windowDestroyed that
has been removed.
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorWindow): Helper
function to create the inspector window and add the inspector
view. Also set the inspector window as transient for the
inspected view toplevel window. And use a weak pointer to make
sure inspector window pointer is NULL when it's destroyed, not
only when the window is closed.
(WebKit::WebInspectorProxy::platformOpen): Call platformAttach if
the inspector is opened attached, or createInspectorWindow
otherwise.
(WebKit::WebInspectorProxy::platformDidClose): Always set the view
inspector pointer to NULL.
(WebKit::WebInspectorProxy::platformBringToFront): Implement it by
showing the toplevel window where the inspector view is contained.
(WebKit::WebInspectorProxy::platformIsFront): Implement it by
checking whether the toplevel window where the inspector view is
contained is active or not.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Return
early if there's no inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Return
the height of the inpected view.
(WebKit::WebInspectorProxy::platformAttach): Remove the view from
the current window if there's one, and insert the inspector view
into the inspected view.
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from the inspected view and create a new window for it if
it's visible.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Call
webkitWebViewBaseSetInspectorViewHeight().

8:19 AM Changeset in webkit [117594] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Return TRUE for events handled to avoid their propagation.

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseButtonPressEvent):
(webkitWebViewBaseButtonReleaseEvent):
(webkitWebViewBaseScrollEvent):
(webkitWebViewBaseMotionNotifyEvent):

7:49 AM Changeset in webkit [117593] by jocelyn.turcotte@nokia.com
  • 2 edits
    17 adds in trunk/LayoutTests

[Qt] Add results for compositing tests dependent on scrollbars thickness.

Reviewed by Csaba Osztrogonác.

Qt's QStyle scrollbar theme has a scrollbar thickness of 16px while
the standard results expect a thickness of 15px.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt: Added.
7:38 AM Changeset in webkit [117592] by commit-queue@webkit.org
  • 9 edits in trunk

[Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
​https://bugs.webkit.org/show_bug.cgi?id=86731

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-18
Reviewed by Simon Hausmann.

Source/WebKit2:

Set the page visibility on a single page instead of on all pages
from the page group.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPageVisibilityState):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPageVisibilityState):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Set the page visibility on a single page instead of on all pages
from the page group.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):
(WTR::LayoutTestController::resetPageVisibility):

LayoutTests:

Unskip fast/events/page-visibility-iframe-move-test.html.

  • platform/qt-5.0-wk2/Skipped:
7:28 AM Changeset in webkit [117591] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip test after r117218.

  • platform/efl/Skipped:
7:26 AM Changeset in webkit [117590] by yi.4.shen@nokia.com
  • 22 edits
    2 adds in trunk

REGRESSION (r102553): Smart links do not work
​https://bugs.webkit.org/show_bug.cgi?id=85463

Source/WebCore:

Reviewed by NOBODY Ryosuke Niwa.

To fix the regression of smart links, we need to check TextCheckingTypeLink option in
Editor::markAndReplaceFor().

Test: editing/inserting/typing-space-to-trigger-smart-link.html

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

Tools:

Reviewed by Ryosuke Niwa.

Add LayoutTestController::setAutomaticLinkDetectionEnabled().

  • DumpRenderTree/LayoutTestController.cpp:

(setAutomaticLinkDetectionEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

LayoutTests:

Reviewed by Ryosuke Niwa.

Add a new test for testing the smart link.

  • editing/inserting/typing-space-to-trigger-smart-link-expected.txt: Added.
  • editing/inserting/typing-space-to-trigger-smart-link.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
7:16 AM Changeset in webkit [117589] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add shortcut to dump Security Origin and Web Database information
​https://bugs.webkit.org/show_bug.cgi?id=86521

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-18
Reviewed by Gustavo Noronha Silva.

Added key combination (CTRL+s) to dump information about the
security origin and databases of the main frame. Useful for API
testing and debugging.

  • EWebLauncher/main.c:

(on_key_down):

7:06 AM Changeset in webkit [117588] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skipped list cleanup.

  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
7:01 AM Changeset in webkit [117587] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: empty CSS Declaration is generated by clicking the left space of 'user agent stylesheet' on Styles sidebar of Elements panel
​https://bugs.webkit.org/show_bug.cgi?id=86850

Reviewed by Yury Semikhatsky.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):

6:59 AM Changeset in webkit [117586] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Remove console.error() call committed by mistake.

  • inspector/front-end/View.js:

(WebInspector.View._assert):

6:55 AM Changeset in webkit [117585] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: live edit resets cursor to 0,0
​https://bugs.webkit.org/show_bug.cgi?id=86851

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):

6:55 AM Changeset in webkit [117584] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Text input events are emitted for nodes that do not allow editing.
​https://bugs.webkit.org/show_bug.cgi?id=86836

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.

Text input events are not anymore emitted for nodes that do not allow editing.
This can be checked with fast/events/key-events-in-input-button.html test output.

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.

6:46 AM Changeset in webkit [117583] by commit-queue@webkit.org
  • 13 edits
    1 move in trunk/LayoutTests

Deflaking http/tests/security/contentSecurityPolicy/script-src-redirect.html
​https://bugs.webkit.org/show_bug.cgi?id=86433

Patch by Mike West <​mkwst@chromium.org> on 2012-05-18
Reviewed by Adam Barth.

As it turns out, this was a straightforward typo on my part. Loading
the wrong JS file is a surefire way to break tests. I've rewritten the
test function to make it more difficult to make such a mistake in the
future, and pushed that change to source-list-parsing-* tests that use
the same methodology.

  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/resources/source-list-parsing-base.js.

(test):
(finishTesting):

  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-01.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-02.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-03.html:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-04.html:
  • platform/chromium/test_expectations.txt: Unskipping.
  • platform/mac-lion/Skipped: Unskipping.
  • platform/gtk/test_expectations.txt: Unskipping.
  • platform/efl/test_expectations.txt: Unskipping.
  • platform/qt/Skipped: Unskipping.
  • platform/mac/Skipped: Unskipping.
6:43 AM Changeset in webkit [117582] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception in console when pressing % button in CPU profile view
​https://bugs.webkit.org/show_bug.cgi?id=86849

Reviewed by Pavel Feldman.

Use root node to get children, not DataGrid object.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype.refreshVisibleData):

6:30 AM Changeset in webkit [117581] by yurys@chromium.org
  • 9 edits in trunk

Web Inspector: remove unnecessary indirection from profile types
​https://bugs.webkit.org/show_bug.cgi?id=86845

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced CSSProfileHeader and CPUProfileHeader, moved view creation from
the type to corresponding profile headers. Removed some inderection and
private fields assigned in random places. Added type annotations.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
(WebInspector.CPUProfileHeader):
(WebInspector.CPUProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CPUProfileHeader.prototype.createView):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):
(WebInspector.CSSProfileHeader):
(WebInspector.CSSProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CSSProfileHeader.prototype.createView):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.HeapProfileHeader.prototype.createView):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype.saveToFile):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._profileTypeChanged):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.profileType):
(WebInspector.ProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.ProfileHeader.prototype.existingView):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype.getProfiles):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._searchableViews):

  • inspector/front-end/View.js:

(WebInspector.View._assert):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

5:42 AM Changeset in webkit [117580] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Cleaning skip list. Unskip passing tests.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-05-18
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/Skipped:
5:32 AM Changeset in webkit [117579] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8][Refactoring] Remove V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0)
​https://bugs.webkit.org/show_bug.cgi?id=86802

Reviewed by Adam Barth.

As commented here (​https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s. This would be
the final patch for the refactoring.

This patch removes V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0).
Also this patch refactors up a couple of throwError()s that I've forgot to
refactor in the previous patches.

No tests. No change in behavior.

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

4:28 AM Changeset in webkit [117578] by morrita@google.com
  • 2 edits in trunk/Source/WebKit2

Yet another unreviewed build fix on r117572, this time for wk2...

  • WebProcess/WebCoreSupport/WebEditorClient.h:
4:20 AM Changeset in webkit [117577] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] [DRT] media/media-document-audio-repaint.html needs rebaselining after r117326
​https://bugs.webkit.org/show_bug.cgi?id=86839

Unreviewed gardening, EFL rebaseline after r117326.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-18

  • platform/efl/media/media-document-audio-repaint-expected.png:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
4:01 AM Changeset in webkit [117576] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html crashes regularly
​https://bugs.webkit.org/show_bug.cgi?id=79656

Unreviewed gardening. Unskip tests, maybe they aren't flakey now.

  • platform/qt-5.0-wk2/Skipped:
3:55 AM Changeset in webkit [117575] by morrita@google.com
  • 10 edits in trunk/Source/WebKit

Another unreviewed attempt to fix build breakage on r117572.

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

3:35 AM Changeset in webkit [117574] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix build breakage on r117572

  • editing/Editor.cpp:

(WebCore::Editor::willDetachPage):

3:30 AM Changeset in webkit [117573] by commit-queue@webkit.org
  • 1 edit
    14 adds in trunk/LayoutTests

[EFL] [DRT] Add baselines for new tests added in r117477 and r117339
​https://bugs.webkit.org/show_bug.cgi?id=86834

Unreviewed, add EFL baselines for new tests added in r117477 and
r117339.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-18

  • platform/efl/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/efl/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/efl/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/efl/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/efl/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/efl/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/efl/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
3:17 AM Changeset in webkit [117572] by morrita@google.com
  • 27 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=85515
Stale frame in WebCore::SpellChecker::didCheckSucceeded

Source/WebCore:

Reviewed by Ryosuke Niwa.

Added EditorClient::frameWillDetachPage() notification to give a
change to invalidate pending spellcheck requests on the client.

Test: editing/spelling/spellcheck-async-remove-frame.html

  • editing/Editor.cpp:

(WebCore::Editor::Editor):

  • editing/Editor.h:

(Editor):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::frameWillDetachPage):

  • page/EditorClient.h:

(EditorClient):

Source/WebKit/blackberry:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientBlackBerry.h:

(WebCore::EditorClientBlackBerry::frameWillDetachPage):

Source/WebKit/chromium:

Added WebTextCheckingCompletionImpl::invalidate() to mark
pending spellcheck request as invalid, and added frameWillDetachPage()
to fire it.

Reviewed by Ryosuke Niwa.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit):
(WebKit::EditorClientImpl::requestCheckingOfString):
(WebKit::EditorClientImpl::didCheckString):

  • src/EditorClientImpl.h:

(WebKit):
(EditorClientImpl):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
(WebKit::WebTextCheckingCompletionImpl::invalidate):
(WebKit):

  • src/WebTextCheckingCompletionImpl.h:

(WebKit):
(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):
(WebKit::WebTextCheckingCompletionImpl::spellChecker):

Source/WebKit/efl:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::frameWillDetachPage):

Source/WebKit/gtk:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::frameWillDetachPage):

Source/WebKit/win:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

Reviewed by Ryosuke Niwa.

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

LayoutTests:

Reviewed by Ryosuke Niwa.

  • editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
  • editing/spelling/spellcheck-async-remove-frame.html: Added.
3:10 AM Changeset in webkit [117571] by pfeldman@chromium.org
  • 18 edits in trunk

Web Inspector: add ContentProvider::contentType and use it when rendering navigator tree.
​https://bugs.webkit.org/show_bug.cgi?id=86833

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Added ContentProvider::contentType, regactored NavigatorView to use the icon defined by the content type.

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/ContentProvider.js:

(WebInspector.ContentProvider.prototype.contentType):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentType):
(WebInspector.CompilerSourceMappingContentProvider):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentType):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.contentType):
(WebInspector.StaticContentProvider.prototype.requestContent):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorSourceTreeElement):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.contentType):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.contentType):
(WebInspector.Resource.prototype.canonicalMimeType):
(WebInspector.ResourceRevision.prototype.contentType):

  • inspector/front-end/ResourceType.js:

(WebInspector.ResourceType.prototype.toString):
(WebInspector.ResourceType.prototype.canonicalMimeType):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.contentType):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetContentProvider):

  • inspector/front-end/StylesPanel.js:
  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.contentType):

  • inspector/front-end/navigatorView.css:

(.navigator-stylesheet-tree-item .icon):
(.navigator-document-tree-item .icon):

LayoutTests:

  • http/tests/inspector/search/search-in-static.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
3:01 AM TestExpectationsProposal edited by zandobersek@gmail.com
(diff)
2:49 AM Changeset in webkit [117570] by rniwa@webkit.org
  • 171 edits in trunk/LayoutTests

Unreviewed, rolling out r117559.
​http://trac.webkit.org/changeset/117559

Wrong rebaseline per rolling out 117556

  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
2:23 AM Changeset in webkit [117569] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for getElementById() for an undefined id
​https://bugs.webkit.org/show_bug.cgi?id=86812

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for document.getElementById() for an undefined id.
This benchmark covers 'getElementById (not in document)' in Dromaeo/dom-query.html,
and other Node-query methods that return a null.'

(Note: This benchmark is slower than document.getElementById() for a defined id.
We will fix the performance issue soon.)

Test results in my Linux desktop:

RESULT Bindings: undefined-get-element-by-id= 271.945751345 runs/s
median= 273.122389532 runs/s, stdev= 6.78219237299 runs/s, min= 257.4002574 runs/s, max= 281.690140845 runs/s

RESULT Bindings: undefined-get-element-by-id= 269.105872408 runs/s
median= 268.948655257 runs/s, stdev= 5.73707323755 runs/s, min= 257.4002574 runs/s, max= 278.128950695 runs/s

RESULT Bindings: undefined-get-element-by-id= 269.987513372 runs/s
median= 272.952853598 runs/s, stdev= 5.30252336078 runs/s, min= 255.754475703 runs/s, max= 273.97260274 runs/s

RESULT Bindings: undefined-get-element-by-id= 270.169625901 runs/s
median= 271.604938272 runs/s, stdev= 5.29502391906 runs/s, min= 258.064516129 runs/s, max= 278.481012658 runs/s

RESULT Bindings: undefined-get-element-by-id= 269.054631422 runs/s
median= 267.966292802 runs/s, stdev= 6.27197240579 runs/s, min= 258.064516129 runs/s, max= 278.481012658 runs/s

  • Bindings/undefined-get-element-by-id.html: Added.
2:20 AM Changeset in webkit [117568] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for getElementsByTagName()
​https://bugs.webkit.org/show_bug.cgi?id=86810

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for document.getElementsByTagName().
This benchmark covers 'getElementsByTagName (not in document)',
'getElementsByTagName', 'getElementsByName (not in document)'
and 'getElementsByName' in Dromaeo/dom-query.html, and other DOM
methods that return a NodeList.

Test results in my Linux desktop:

RESULT Bindings: get-elements-by-tag-name= 364.542328875 runs/s
median= 366.972477064 runs/s, stdev= 5.25387955333 runs/s, min= 351.317440402 runs/s, max= 368.421052632 runs/s

RESULT Bindings: get-elements-by-tag-name= 364.341569369 runs/s
median= 366.492146597 runs/s, stdev= 4.867374197 runs/s, min= 352.644836272 runs/s, max= 367.936925099 runs/s

RESULT Bindings: get-elements-by-tag-name= 363.924242967 runs/s
median= 366.013071895 runs/s, stdev= 5.16768212289 runs/s, min= 351.317440402 runs/s, max= 367.936925099 runs/s

RESULT Bindings: get-elements-by-tag-name= 365.332594438 runs/s
median= 367.454068241 runs/s, stdev= 6.17046918572 runs/s, min= 350.0 runs/s, max= 370.37037037 runs/s

RESULT Bindings: get-elements-by-tag-name= 363.999514324 runs/s
median= 366.492146597 runs/s, stdev= 5.31235674905 runs/s, min= 350.877192982 runs/s, max= 368.421052632 runs/s

  • Bindings/get-elements-by-tag-name.html: Added.
2:08 AM Changeset in webkit [117567] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

Unreviewed, rolling out r117558.
​http://trac.webkit.org/changeset/117558
​https://bugs.webkit.org/show_bug.cgi?id=86827

Wrong rebaseline per rolling out 117556 (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-18

  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
2:03 AM Changeset in webkit [117566] by rniwa@webkit.org
  • 153 edits in trunk/LayoutTests

Unreviewed, rolling out r117557.
​http://trac.webkit.org/changeset/117557
​https://bugs.webkit.org/show_bug.cgi?id=86826

Wrong rebaseline per rolling out 117556 (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-18

  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
2:00 AM Changeset in webkit [117565] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r117556.
​http://trac.webkit.org/changeset/117556
​https://bugs.webkit.org/show_bug.cgi?id=86825

Wrong fix. IE still adds 1px padding. We're missing that in
textarea (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-18

Source/WebCore:

  • css/html.css:

(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

LayoutTests:

  • fast/forms/input-textarea-padding-match-expected.html: Removed.
  • fast/forms/input-textarea-padding-match.html: Removed.
1:53 AM Changeset in webkit [117564] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: remove File abstraction from the AdvancedSearchController, migrate it to UISourceCode.
​https://bugs.webkit.org/show_bug.cgi?id=86809

Reviewed by Yury Semikhatsky.

This change migrates AdvancedSearchController from "Object" to "UISourceCode".
I don't see why we need this abstraction and as a side effect, it makes search
across scripts work for styles.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
(WebInspector.FileBasedSearchResultsPane.SearchResult):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchScope.prototype.createSearchResultsPane):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

1:40 AM Changeset in webkit [117563] by haraken@chromium.org
  • 1 edit
    7 adds in trunk/PerformanceTests

[perf-test] Add 7 micro benchmarks for DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=86816

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds seven micro benchmarks for DOM bindings.

id-getter.html covers 'element.property' in Dromaeo/dom-attr.html,
'innerHTML' in Dromaeo/dom-modify.html, and other DOM attributes that
return a String.

id-setter.html covers 'element.property = value' in Dromaeo/dom-attr.html,
and other DOM attributes that sets a String.

undefined-id-getter.html covers undefined DOM attributes that return an empty String.

append-child.html covers 'appendChild' and 'removeChild' in Dromaeo/dom-modify.html.

insert-before.html covers 'insertBefore' in Dromaeo/dom-modify.html and replaceChild().

create-element.html covers 'createElement', 'createTextNode' and 'cloneNode'
in Dromaeo/dom-modify.html, and other DOM methods that return a new Node object.

node-list-access.html covers 'childNodes' in Dromaeo/dom-traverse.html,
and other DOM attributes that access NodeList.

Test results in my Linux desktop:

[id-getter]
RESULT Bindings: id-getter= 550.517821097 runs/s
median= 550.688360451 runs/s, stdev= 0.970723739106 runs/s, min= 548.628428928 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 550.655839847 runs/s
median= 550.688360451 runs/s, stdev= 1.03312821884 runs/s, min= 549.313358302 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 550.277753355 runs/s
median= 550.344180225 runs/s, stdev= 1.19960683464 runs/s, min= 547.945205479 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 550.072271009 runs/s
median= 550.344180225 runs/s, stdev= 1.38925152131 runs/s, min= 547.263681592 runs/s, max= 552.070263488 runs/s

RESULT Bindings: id-getter= 548.802050235 runs/s
median= 548.628428928 runs/s, stdev= 1.18244513683 runs/s, min= 545.905707196 runs/s, max= 550.688360451 runs/s

[id-setter]
RESULT Bindings: id-setter= 211.370591663 runs/s
median= 210.803689065 runs/s, stdev= 1.4555795889 runs/s, min= 209.973753281 runs/s, max= 214.285714286 runs/s

RESULT Bindings: id-setter= 215.439081352 runs/s
median= 214.797136038 runs/s, stdev= 1.50920388121 runs/s, min= 213.049267643 runs/s, max= 218.446601942 runs/s

RESULT Bindings: id-setter= 216.721698466 runs/s
median= 215.956886352 runs/s, stdev= 1.54090749644 runs/s, min= 214.285714286 runs/s, max= 219.78021978 runs/s

RESULT Bindings: id-setter= 216.343019087 runs/s
median= 215.827338129 runs/s, stdev= 1.46619894553 runs/s, min= 215.053763441 runs/s, max= 218.97810219 runs/s

RESULT Bindings: id-setter= 216.799288017 runs/s
median= 215.956886352 runs/s, stdev= 1.49100776978 runs/s, min= 215.311004785 runs/s, max= 219.78021978 runs/s

[undefined-id-getter]
RESULT Bindings: undefined-id-getter= 494.104255241 runs/s
median= 494.132368875 runs/s, stdev= 1.13092821109 runs/s, min= 490.797546012 runs/s, max= 495.662949195 runs/s

RESULT Bindings: undefined-id-getter= 493.921802916 runs/s
median= 493.827160494 runs/s, stdev= 1.25097443119 runs/s, min= 490.196078431 runs/s, max= 495.662949195 runs/s

RESULT Bindings: undefined-id-getter= 491.976485667 runs/s
median= 492.004920049 runs/s, stdev= 0.947090576896 runs/s, min= 490.196078431 runs/s, max= 493.827160494 runs/s

RESULT Bindings: undefined-id-getter= 491.987710185 runs/s
median= 494.132368875 runs/s, stdev= 8.66602543327 runs/s, min= 454.545454545 runs/s, max= 495.662949195 runs/s

RESULT Bindings: undefined-id-getter= 494.195515847 runs/s
median= 494.437577256 runs/s, stdev= 1.06135681702 runs/s, min= 490.797546012 runs/s, max= 495.662949195 runs/s

[append-child]
RESULT Bindings: append-child= 260.628237026 runs/s
median= 260.926399352 runs/s, stdev= 2.55231060598 runs/s, min= 256.739409499 runs/s, max= 265.604249668 runs/s

RESULT Bindings: append-child= 280.796193436 runs/s
median= 280.791435348 runs/s, stdev= 2.53961321867 runs/s, min= 277.427490542 runs/s, max= 286.085825748 runs/s

RESULT Bindings: append-child= 279.856209714 runs/s
median= 280.25477707 runs/s, stdev= 2.85447647301 runs/s, min= 275.344180225 runs/s, max= 284.237726098 runs/s

RESULT Bindings: append-child= 280.834502714 runs/s
median= 280.25477707 runs/s, stdev= 2.67738046429 runs/s, min= 277.427490542 runs/s, max= 287.206266319 runs/s

RESULT Bindings: append-child= 274.723872106 runs/s
median= 273.291925466 runs/s, stdev= 3.03671746706 runs/s, min= 272.614622057 runs/s, max= 282.413350449 runs/s

[insert-before]
RESULT Bindings: insert-before= 180.986913006 runs/s
median= 180.878552972 runs/s, stdev= 0.758038687299 runs/s, min= 180.18018018 runs/s, max= 183.968462549 runs/s

RESULT Bindings: insert-before= 186.339916144 runs/s
median= 186.170212766 runs/s, stdev= 0.869022097127 runs/s, min= 185.676392573 runs/s, max= 189.798339265 runs/s

RESULT Bindings: insert-before= 189.45344838 runs/s
median= 189.349112426 runs/s, stdev= 0.811854866567 runs/s, min= 187.79342723 runs/s, max= 192.539109507 runs/s

RESULT Bindings: insert-before= 189.363295991 runs/s
median= 189.349112426 runs/s, stdev= 0.75387713097 runs/s, min= 188.014101058 runs/s, max= 192.076830732 runs/s

RESULT Bindings: insert-before= 189.252041642 runs/s
median= 189.349112426 runs/s, stdev= 0.840447225363 runs/s, min= 187.573270809 runs/s, max= 192.076830732 runs/s

[create-element]
RESULT Bindings: create-element= 280.675830077 runs/s
median= 280.701824914 runs/s, stdev= 0.788606343054 runs/s, min= 279.441117764 runs/s, max= 282.542885974 runs/s

RESULT Bindings: create-element= 276.427631436 runs/s
median= 277.227722772 runs/s, stdev= 3.39874667549 runs/s, min= 262.417994377 runs/s, max= 279.162512463 runs/s

RESULT Bindings: create-element= 277.156894411 runs/s
median= 277.227722772 runs/s, stdev= 1.13255119226 runs/s, min= 274.914089347 runs/s, max= 278.884462151 runs/s

RESULT Bindings: create-element= 278.066825356 runs/s
median= 278.191822254 runs/s, stdev= 0.686497782792 runs/s, min= 276.953511375 runs/s, max= 279.162512463 runs/s

RESULT Bindings: create-element= 276.431538109 runs/s
median= 276.406712734 runs/s, stdev= 0.759593662298 runs/s, min= 275.229357798 runs/s, max= 278.053624628 runs/s

[node-list-access]
RESULT Bindings: node-list-access= 222.747504073 runs/s
median= 222.772277228 runs/s, stdev= 0.789027527555 runs/s, min= 221.674876847 runs/s, max= 224.159402242 runs/s

RESULT Bindings: node-list-access= 220.722448287 runs/s
median= 221.266217576 runs/s, stdev= 1.65463497875 runs/s, min= 217.391304348 runs/s, max= 222.222222222 runs/s

RESULT Bindings: node-list-access= 222.195870443 runs/s
median= 222.222222222 runs/s, stdev= 0.489709262091 runs/s, min= 221.13022113 runs/s, max= 223.048327138 runs/s

RESULT Bindings: node-list-access= 221.431121677 runs/s
median= 221.538545435 runs/s, stdev= 0.608292116087 runs/s, min= 220.048899756 runs/s, max= 222.772277228 runs/s

RESULT Bindings: node-list-access= 219.001367135 runs/s
median= 221.538545435 runs/s, stdev= 4.65773933007 runs/s, min= 209.973753281 runs/s, max= 222.496909765 runs/s

  • Bindings/append-child.html: Added.
  • Bindings/create-element.html: Added.
  • Bindings/id-getter.html: Added.
  • Bindings/id-setter.html: Added.
  • Bindings/insert-before.html: Added.
  • Bindings/node-list-access.html: Added.
  • Bindings/undefined-id-getter.html: Added.
1:25 AM Changeset in webkit [117562] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add an option to show last N hidden children of node in heap profiler
​https://bugs.webkit.org/show_bug.cgi?id=86757

Reviewed by Pavel Feldman.

Renamed "Show next N" to "Show N before" and added "Show N after" button. Also
when all 3 buttons would have equal effect there is now only "Show all N" button.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showLastChunk):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.createCells):

1:15 AM Changeset in webkit [117561] by commit-queue@webkit.org
  • 9 edits
    2 adds
    1 delete in trunk

[EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
​https://bugs.webkit.org/show_bug.cgi?id=86101

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

Add missing implementation setSerializeHTTPLoads to EFL's
DumpRenderTreeSupport to allow testing resource load order.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSerializeHTTPLoads):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation setSerializeHTTPLoads to allow
testing resource load order.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setSerializeHTTPLoads):

LayoutTests:

Unskip test cases which rely on LayoutTestController's setSerializeHTTPLoads
implementation and add EFL expectations for tests same as in mac port (MIME
type is "application/javascript" instead of "application/x-javascript").

  • platform/efl/Skipped:
  • platform/efl/fast/loader/file-protocol-fragment-expected.txt: Removed. The current

result matches the base expectation, so removed the platform-specific results.

  • platform/efl/fast/preloader/document-write-2-expected.txt: Added.
  • platform/efl/fast/preloader/document-write-expected.txt: Added.
  • platform/efl/test_expectations.txt:
1:12 AM Changeset in webkit [117560] by jochen@chromium.org
  • 8 edits in trunk

Source/WebKit/chromium: [chromium] plumb the frame for which a drag was initiated to the WebViewClient
​https://bugs.webkit.org/show_bug.cgi?id=86670

Reviewed by Kent Tamura.

  • public/WebViewClient.h:

(WebKit::WebViewClient::startDragging):
(WebViewClient):

  • src/DragClientImpl.cpp:

(WebKit::DragClientImpl::startDrag):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::startDragging):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools: [chromium] plumb the frame for which a drag was initiated to the WebViewClient

​https://bugs.webkit.org/show_bug.cgi?id=86670

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::startDragging):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:04 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:53 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:51 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:50 AM TestExpectationsProposal edited by mjs@apple.com
(diff)
12:49 AM TestExpectationsProposal created by mjs@apple.com
12:48 AM Changeset in webkit [117559] by rniwa@webkit.org
  • 171 edits in trunk/LayoutTests

Chromium Mac rebaseline after r117556.

  • platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/003-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png:
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
12:46 AM Changeset in webkit [117558] by rniwa@webkit.org
  • 10 edits in trunk/LayoutTests

SnowLeopard and SVG rebaselines after r117556.

  • platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
  • platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
12:44 AM Changeset in webkit [117557] by rniwa@webkit.org
  • 153 edits in trunk/LayoutTests

Mac rebaseline after r117556.

  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.png:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-textfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
12:42 AM Changeset in webkit [117556] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

WebKit erroneously add 1px padding in input elements
​https://bugs.webkit.org/show_bug.cgi?id=86784

Reviewed by Kent Tamura.

Source/WebCore:

Fixed the bug by removing the code that added left and right paddings in input elements.
The code was added in r13567 to match a very old version of Internet Explorer but this quirk
does not seem to exists in IE9 (both in quirks and standard modes).

A lot of tests need to be rebaselined due to 1px difference inside input elements, and 2px
differences for the width of input elements. (In some extreme cases, line breaking changed
due to the width change).

Test: fast/forms/input-textarea-padding-match.html

  • css/html.css:

(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerTextStyle):

LayoutTests:

Add a regression.

Also rebaseline tests in separate commits per getting rid of extra 1px padding on left and right.
Input elements' widths got shrunk by 2px in most cases and the text moved 1px to the start
(left for LTR and right for RTL).

  • fast/forms/input-textarea-padding-match-expected.html: Added.
  • fast/forms/input-textarea-padding-match.html: Added.
12:37 AM Changeset in webkit [117555] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[Qt] Gesture tap highlighter needs to take overflow clip into account.
​https://bugs.webkit.org/show_bug.cgi?id=84989

Patch by Zalan Bujtas <​zbujtas@gmail.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.

.:

  • ManualTests/qt/tap-highlighting-overflow-hidden.html: Added.

Source/WebCore:

Apply overflow clip on the focus ring if needed.

Follow up patches are needed to address the following cases.

[Qt] Gesture tap highlighter should take parent iframe's transform into account.
​https://bugs.webkit.org/show_bug.cgi?id=86645

[Qt] Gesture tap highlighter needs to take frame clipping into account.
​https://bugs.webkit.org/show_bug.cgi?id=86646

[Qt] Gesture tap highlighter's overflow clip is not always correct when
nested enclosing containers have transforms.
​https://bugs.webkit.org/show_bug.cgi?id=86641

Manual test: ManualTests/qt/tap-highlighting-overflow-hidden.html

  • page/GestureTapHighlighter.cpp:

(WebCore::GestureTapHighlighter::pathForNodeHighlight):

12:29 AM Changeset in webkit [117554] by rniwa@webkit.org
  • 5 edits
    1 delete in trunk/LayoutTests

Chromium rebaselines.

  • platform/chromium-mac-leopard/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Removed.
  • platform/chromium-mac/fast/lists/003-vertical-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt:
12:20 AM Changeset in webkit [117553] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for div.setAttribute()
​https://bugs.webkit.org/show_bug.cgi?id=86815

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for div.setAttribute(). This benchmark
covers 'setAttribute' in Dromaeo/dom-attr.html and other DOM methods
that return an undefined.

Test results in my Linux desktop:

RESULT Bindings: set-attribute= 793.745073252 runs/s
median= 791.589665765 runs/s, stdev= 6.00467159709 runs/s, min= 785.27607362 runs/s, max= 808.080808081 runs/s

RESULT Bindings: set-attribute= 790.858444164 runs/s
median= 787.918921436 runs/s, stdev= 7.86264953655 runs/s, min= 780.234070221 runs/s, max= 806.04534005 runs/s

RESULT Bindings: set-attribute= 787.277571417 runs/s
median= 784.31372549 runs/s, stdev= 7.45363346657 runs/s, min= 778.588807786 runs/s, max= 804.020100503 runs/s

RESULT Bindings: set-attribute= 782.401393791 runs/s
median= 779.062978802 runs/s, stdev= 6.48250081621 runs/s, min= 777.642770352 runs/s, max= 796.019900498 runs/s

RESULT Bindings: set-attribute= 791.792516608 runs/s
median= 791.556728232 runs/s, stdev= 6.49182980397 runs/s, min= 779.220779221 runs/s, max= 808.080808081 runs/s

  • Bindings/set-attribute.html: Added.
12:06 AM Changeset in webkit [117552] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] appcache tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=86619

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

No longer set the application cache path in ewk_main since the
path can only be set once and this prevents DRT (or apps) to set
it. Update the ewk_settings documentation to reflect these
changes.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_settings.h:

Tools:

Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

12:03 AM Changeset in webkit [117551] by commit-queue@webkit.org
  • 11 edits
    5 adds in trunk

[EFL] Add simple implementation of Web Intents
​https://bugs.webkit.org/show_bug.cgi?id=86354

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Eric Seidel.

.:

Enable WEB_INTENTS flag by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit:

Add new ewk_intent.* and ewk_intent_request.* files to CMake.

  • CMakeLists.txt:
  • PlatformEfl.cmake:

Source/WebKit/efl:

Add new EFL wrappers for WebCore's Intent and IntentRequest.
Implement dispatchIntent() in EFL's FrameLoaderClient and emit a new
"intent,new" signal on the frame to notify clients of new intent
requests.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):
(WebCore::FrameLoaderClientEfl::dispatchIntent):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_new):

  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:
  • ewk/ewk_intent.cpp: Added.

(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_data_get):
(ewk_intent_service_get):
(ewk_intent_extra_get):
(ewk_intent_new):
(ewk_intent_free):

  • ewk/ewk_intent.h: Added.
  • ewk/ewk_intent_private.h: Added.

(WebCore):

  • ewk/ewk_intent_request.cpp: Added.

(_Ewk_Intent_Request):
(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):
(ewk_intent_request_result_post):
(ewk_intent_request_failure_post):
(ewk_intent_request_new):

  • ewk/ewk_intent_request.h: Added.

May 17, 2012:

11:49 PM Changeset in webkit [117550] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for div.getAttribute()
​https://bugs.webkit.org/show_bug.cgi?id=86814

Reviewed by Ryosuke Niwa.

We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for div.getAttribute(). This benchmark
covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods
that return a String.

Test results in my Linux desktop:

RESULT Bindings: get-attribute= 250.088158538 runs/s
median= 250.469728765 runs/s, stdev= 4.66551901315 runs/s, min= 240.673886883 runs/s, max= 256.739409499 runs/s

RESULT Bindings: get-attribute= 250.209764698 runs/s
median= 250.626959986 runs/s, stdev= 4.12030002477 runs/s, min= 241.254523522 runs/s, max= 255.102040816 runs/s

RESULT Bindings: get-attribute= 248.907532887 runs/s
median= 250.312891114 runs/s, stdev= 3.23173125874 runs/s, min= 240.673886883 runs/s, max= 251.572327044 runs/s

RESULT Bindings: get-attribute= 250.243680844 runs/s
median= 250.783797637 runs/s, stdev= 4.19327170024 runs/s, min= 240.963855422 runs/s, max= 255.102040816 runs/s

RESULT Bindings: get-attribute= 245.329046608 runs/s
median= 244.948040416 runs/s, stdev= 2.24314248534 runs/s, min= 240.384615385 runs/s, max= 248.756218905 runs/s

  • Bindings/get-attribute.html: Added.
11:32 PM Changeset in webkit [117549] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] KURL::fileSystemPath() should strip the query of the uri
​https://bugs.webkit.org/show_bug.cgi?id=86721

Reviewed by Martin Robinson.

  • platform/gtk/KURLGtk.cpp:

(WebCore::KURL::fileSystemPath): Use the already parsed path to
create the GFile instead of the whole URL string. The parsed path
doesn't include neither the fragment (#) nor the query (?) parts.

11:29 PM Changeset in webkit [117548] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a binding benchmark for getElementById()
​https://bugs.webkit.org/show_bug.cgi?id=86808

Reviewed by Ryosuke Niwa.

Currently Bindings/dom-attributes.html is just a collection
of random DOM attributes and methods. We should remove it and
instead add more reasonable micro benchmarks by classifying
DOM binding call paths.

This patch adds a benchmark for document.getElementById(),
which covers other DOM methods that return a Node Object.

The reason why we want to add a benchmark for document.getElementById()
in spite of the fact that Dromaeo/dom-query.html is already testing
document.getElementById(), is that Dromaeo/dom-query.html outputs one
result for several benchmarks (i.e. getElementById().nodeType,
getElementsByTagName()[0].nodeType etc), and thus we cannot observe
regression of getElementById() itself. (Catching regression of
getElementById() would be critical.)

Test results in my Linux desktop:

RESULT Bindings: get-element-by-id= 300.933707795 runs/s
median= 302.267002519 runs/s, stdev= 3.04954648504 runs/s, min= 295.930949445 runs/s, max= 305.34351145 runs/s

RESULT Bindings: get-element-by-id= 302.030324483 runs/s
median= 302.267481977 runs/s, stdev= 1.78518068367 runs/s, min= 298.507462687 runs/s, max= 304.568527919 runs/s

RESULT Bindings: get-element-by-id= 301.993483538 runs/s
median= 302.648171501 runs/s, stdev= 1.87604126626 runs/s, min= 296.662546354 runs/s, max= 304.568527919 runs/s

RESULT Bindings: get-element-by-id= 301.936607982 runs/s
median= 302.45758701 runs/s, stdev= 1.88991087072 runs/s, min= 298.879202989 runs/s, max= 304.955527319 runs/s

RESULT Bindings: get-element-by-id= 301.952234563 runs/s
median= 302.648171501 runs/s, stdev= 1.59929752614 runs/s, min= 299.625468165 runs/s, max= 304.568527919 runs/s

  • Bindings/get-element-by-id.html: Added.
11:03 PM Changeset in webkit [117547] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a benchmark for body.scrollTop
​https://bugs.webkit.org/show_bug.cgi?id=86806

Reviewed by Ryosuke Niwa.

Currently Bindings/dom-attributes.html is just a collection of random
DOM attributes and methods. We should remove it and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

This patch adds a benchmark for body.scrollTop, which covers other
DOM attributes that return small integers.

(Note: Performance optimization for the benchmark will be coming soon.)

Test results in my Linux desktop:

RESULT Bindings: scroll-top= 209.410654239 runs/s
median= 211.64021164 runs/s, stdev= 4.09958741195 runs/s, min= 201.005025126 runs/s, max= 212.483399734 runs/s

RESULT Bindings: scroll-top= 195.651111157 runs/s
median= 196.319018405 runs/s, stdev= 1.77011627406 runs/s, min= 191.846522782 runs/s, max= 197.28729963 runs/s
RESULT Bindings: scroll-top= 200.004907612 runs/s
median= 201.511335013 runs/s, stdev= 3.27455403827 runs/s, min= 193.236714976 runs/s, max= 202.53164557 runs/s

RESULT Bindings: scroll-top= 209.582737512 runs/s
median= 210.803689065 runs/s, stdev= 3.16769655464 runs/s, min= 203.045685279 runs/s, max= 211.920529801 runs/s

RESULT Bindings: scroll-top= 199.924607687 runs/s
median= 201.13144338 runs/s, stdev= 3.11080503619 runs/s, min= 193.003618818 runs/s, max= 202.02020202 runs/s

  • Bindings/scroll-top.html: Added.
10:50 PM Changeset in webkit [117546] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
​https://bugs.webkit.org/show_bug.cgi?id=86803

Reviewed by Dimitri Glazkov.

V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
too, and remove V8Proxy::deletionNotHandledByInterceptor().

No tests. No change in behavior.

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageDeleter):

10:44 PM Changeset in webkit [117545] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: speed-up markQueriableHeapObjects function.
​https://bugs.webkit.org/show_bug.cgi?id=86732

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):

10:35 PM Changeset in webkit [117544] by kinuko@chromium.org
  • 5 edits in trunk/Source/WebCore

Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFileSystem.cpp
​https://bugs.webkit.org/show_bug.cgi?id=86103

Reviewed by Rob Buis.

Added build fixes and some (limited) common implementation for non-chromium ports.

No new tests as this should have no functionality changes.

  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::isValidType): Added common implementation for non-chromium ports.
(WebCore::DOMFileSystemBase::crackFileSystemURL): Ditto.
(WebCore::DOMFileSystemBase::supportsToURL): Ditto.
(WebCore::DOMFileSystemBase::createFileSystemURL): Ditto.

  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::readFileSystem): Fixed.
(WebCore::LocalFileSystem::requestFileSystem): Fixed.

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::openFileSystem): Fixed.

  • platform/gtk/AsyncFileSystemGtk.cpp:

(WebCore::AsyncFileSystem::openFileSystem): Fixed.

10:33 PM Changeset in webkit [117543] by fpizlo@apple.com
  • 2 edits in branches/dfgopt/Source/JavaScriptCore

Fix a typo that Geoff noticed but that I forgot to fix in the last commit.
​https://bugs.webkit.org/show_bug.cgi?id=86552

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

10:30 PM Changeset in webkit [117542] by fpizlo@apple.com
  • 28 edits
    18 adds in branches/dfgopt

DFG should optimize aliased uses of the Arguments object of the current call frame
​https://bugs.webkit.org/show_bug.cgi?id=86552

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Performs must-alias and escape analysis on uses of CreateArguments, and if
a variable is must-aliased to CreateArguments and does not escape, then we
turn all uses of that variable into direct arguments accesses.

36% speed-up on V8/earley leading to a 2.3% speed-up overall in V8.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::uncheckedArgumentsRegister):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::argumentsThatWereNotCreated):
(ValueRecovery):
(JSC::ValueRecovery::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAdjacencyList.h:

(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdgeFromBag):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

  • dfg/DFGGPRInfo.h:

(GPRInfo):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::collectGarbage):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::executableFor):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler.h:

(JSC::DFG::OSRExitCompiler::OSRExitCompiler):
(OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isArgumentsAlias):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):

LayoutTests:

Rubber stamped by Geoff Garen.

Added a bunch of tests that check that our optimizations for aliased uses of the
'arguments' object are robust against various forms of JavaScript crazy.

  • fast/js/dfg-arguments-alias-escape-expected.txt: Added.
  • fast/js/dfg-arguments-alias-escape.html: Added.
  • fast/js/dfg-arguments-alias-expected.txt: Added.
  • fast/js/dfg-arguments-alias.html: Added.
  • fast/js/dfg-arguments-cross-code-origin-expected.txt: Added.
  • fast/js/dfg-arguments-cross-code-origin.html: Added.
  • fast/js/dfg-arguments-mixed-alias-expected.txt: Added.
  • fast/js/dfg-arguments-mixed-alias.html: Added.
  • fast/js/dfg-arguments-osr-exit-expected.txt: Added.
  • fast/js/dfg-arguments-osr-exit.html: Added.
  • fast/js/dfg-arguments-unexpected-escape-expected.txt: Added.
  • fast/js/dfg-arguments-unexpected-escape.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arguments-alias-escape.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-alias.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-cross-code-origin.js: Added.

(foo):
(bar):
(baz):

  • fast/js/script-tests/dfg-arguments-mixed-alias.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-osr-exit.js: Added.

(baz):
(foo):
(bar):

  • fast/js/script-tests/dfg-arguments-unexpected-escape.js: Added.

(baz):
(foo):
(bar):

9:57 PM Changeset in webkit [117541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
​https://bugs.webkit.org/show_bug.cgi?id=75119

Patch by Wei James <​james.wei@intel.com> on 2012-05-17
Reviewed by Chris Rogers.

As multiple channel support in AudioBus and other places is already
implemented, the check can be removed here.

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

9:46 PM Changeset in webkit [117540] by rakuco@webkit.org
  • 5 edits in trunk

[EFL][DRT] Call resetInternalsObject() after each test.
​https://bugs.webkit.org/show_bug.cgi?id=86793

Reviewed by Antonio Gomes.

We need to reset the internals object's settings after running
each test so that there are no interferences between each test's
results.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::globalContextRefForFrame):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(runTest):

9:41 PM Changeset in webkit [117539] by Philippe Normand
  • 2 edits in trunk/Source/WebKit2

Unreviewed, WebKit2 GTK/Qt build fix attempt after r117516.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

9:37 PM Changeset in webkit [117538] by pilgrim@chromium.org
  • 8 edits
    1 copy in trunk/Source

[Chromium] Move Web Workers methods to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=86799

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::didStartWorkerRunLoop):
(WebKit::Platform::didStopWorkerRunLoop):

  • chromium/public/WebWorkerRunLoop.h: Added.

(WebCore):
(WebKit):
(WebWorkerRunLoop):
(Task):
(WebKit::WebWorkerRunLoop::Task::~Task):
(WebKit::operator==):
(WebKit::operator<):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebWorkerRunLoop.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::didStartWorkerRunLoop):
(WebCore::PlatformSupport::didStopWorkerRunLoop):

9:35 PM WebKit Team edited by leviw@chromium.org
Moving myself to reviewers. (diff)
9:33 PM Changeset in webkit [117537] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/11419933> Problems with flipped writing modes and compositing
​https://bugs.webkit.org/show_bug.cgi?id=86032

Reviewed by Anders Carlsson.

Source/WebCore:

Test: compositing/bounds-in-flipped-writing-mode.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds): Apply a writing-mode flip to the bounding box
if needed.

LayoutTests:

  • compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
  • compositing/bounds-in-flipped-writing-mode.html: Added.
8:39 PM Changeset in webkit [117536] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

[V8][Refactoring] Remove V8Proxy::throwError(const char*, v8::Isolate* = 0)
​https://bugs.webkit.org/show_bug.cgi?id=86794

Reviewed by Adam Barth.

As commented here (​https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s.
This patch removes V8Proxy::throwError(const char*, v8::Isolate* = 0).

No tests. No change in behavior.

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):
(WebCore::getMessagePortArray):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallback):

8:36 PM Changeset in webkit [117535] by danakj@chromium.org
  • 20 edits in trunk/Source

[chromium] Scale all compositor output by the defaultDeviceScaleFactor
​https://bugs.webkit.org/show_bug.cgi?id=86051

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

On initialization, give the defaultDeviceScaleFactor to the compositor
to have it scale all output from WebCore's layout size to physical
pixels. This allows us to scale up to high-dpi devices without using
fixed-layout, so we can leave the WebCore frame size in layout pixels,
while drawing the frame into a larger physical pixel size.

CCLayerTreeHost becomes aware of the deviceScaleFactor and scales all
output by this factor by scaling the viewport and all drawing
transforms.

Anything that works in physical pixels (content space), uses the
deviceViewportSize() in place of the viewportSize(), since when
deviceScaleFactor != 1 in CCLayerTreeHost, the WebCore viewport
is no longer physical pixels.

Scroll positions are in layout pixels, and must be scaled to/from
content space within the compositor.

Unit tests: CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromiumClient):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deviceViewportSize):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::viewportSize):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Add the applyDefaultDeviceScaleInCompositor setting. When enabled, we
apply the scale factor during compositing instead of applying it through
the pageScaleFactor.

NonCompositedContentHost is the GraphicLayerClient for the GraphicsLayer
containing the document's body. It needs to report the page/device scale
that should be used when scaling the contents of the GraphicsLayer, and
when changes occur to them such that its contentsSize or contentsScale
is affected.

Store the deviceScaleFactor being used in the compositor. The remainder
of the deviceScaleFactor() is being applied to the pageScale.

  • public/WebSettings.h:
  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostTest.cpp:

(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::afterTest):
(WTF):
(WTF::TEST_F):

  • tests/LayerRendererChromiumTest.cpp:
  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

8:24 PM Changeset in webkit [117534] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
​https://bugs.webkit.org/show_bug.cgi?id=86708

Reviewed by Eric Seidel.

Since InsertionPoint now has isActive() member function,
we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
using that function.

No new tests, no change in behavior.

  • dom/ComposedShadowTreeWalker.h:

(WebCore::ComposedShadowTreeWalker::assertPrecondition):

8:16 PM Changeset in webkit [117533] by pkasting@chromium.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r117526.
​http://trac.webkit.org/changeset/117526
​https://bugs.webkit.org/show_bug.cgi?id=86801

broke Chromium Mac 10.5 layout test canaries (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-17

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN):
(SVN.in_working_directory):

8:10 PM Changeset in webkit [117532] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

8:01 PM Changeset in webkit [117531] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Prune unnecessary failure expectations.
​http://code.google.com/p/chromium/issues/detail?id=32670
​https://bugs.webkit.org/show_bug.cgi?id=74694
​https://bugs.webkit.org/show_bug.cgi?id=82129
​https://bugs.webkit.org/show_bug.cgi?id=83503
​https://bugs.webkit.org/show_bug.cgi?id=86439

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
7:45 PM Changeset in webkit [117530] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Prune unnecessary failure expectations.
​http://code.google.com/p/chromium/issues/detail?id=23489
​http://code.google.com/p/chromium/issues/detail?id=67540
​http://code.google.com/p/chromium/issues/detail?id=68436
​http://code.google.com/p/chromium/issues/detail?id=77706
​https://bugs.webkit.org/show_bug.cgi?id=47949
​https://bugs.webkit.org/show_bug.cgi?id=65462
​https://bugs.webkit.org/show_bug.cgi?id=68436
​https://bugs.webkit.org/show_bug.cgi?id=73838
​https://bugs.webkit.org/show_bug.cgi?id=74694
​https://bugs.webkit.org/show_bug.cgi?id=83185

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
7:36 PM Changeset in webkit [117529] by fischman@chromium.org
  • 6 edits in trunk/Source

[Chromium] Store HTTP version in WebURLResponse
​https://bugs.webkit.org/show_bug.cgi?id=86522

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebURLResponse.h:

(WebURLResponse):

Source/WebCore:

No new tests; this isn't exposed to the web platform.

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::httpVersion):
(WebKit):
(WebKit::WebURLResponse::setHTTPVersion):

  • platform/network/chromium/ResourceResponse.h:

(ResourceResponse):
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::httpVersion):
(WebCore::ResourceResponse::setHTTPVersion):

7:14 PM Changeset in webkit [117528] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
​https://bugs.webkit.org/show_bug.cgi?id=86775

Reviewed by Eric Seidel.

Despite operating in floats, we always want to draw lines for text aligned to pixel boundaries.
There are similar functions to do this in other platforms, but to get proper results, we only
need to floor the y value, as we always draw these lines horizontally.

No tests. No change in behavior prior to sub-pixel change.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForText):

7:12 PM Changeset in webkit [117527] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Prune unnecessary failure expectations.
​http://code.google.com/p/chromium/issues/detail?id=11251
​http://code.google.com/p/chromium/issues/detail?id=69181
​http://code.google.com/p/chromium/issues/detail?id=124313
​http://code.google.com/p/chromium/issues/detail?id=124779
​https://bugs.webkit.org/show_bug.cgi?id=80067
​https://bugs.webkit.org/show_bug.cgi?id=84125
​https://bugs.webkit.org/show_bug.cgi?id=85553

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
7:05 PM Changeset in webkit [117526] by dpranke@chromium.org
  • 3 edits in trunk/Tools

scm.add() doesn't work properly with svn 1.7
​https://bugs.webkit.org/show_bug.cgi?id=86779

Reviewed by Ojan Vafai.

The code relied on '.svn' directories being present
in order to tell if a directory had already been added to the
repository; this is no longer true in SVN 1.7.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN):
(SVN.in_working_directory):

6:46 PM Changeset in webkit [117525] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix bad baseline from ​http://trac.webkit.org/changeset/117480/.
​https://bugs.webkit.org/show_bug.cgi?id=84167

Unreviewed, test expectations update.

  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
6:40 PM Changeset in webkit [117524] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Linux amd64 platform reported as i686
​https://bugs.webkit.org/show_bug.cgi?id=86778
​http://code.google.com/p/chromium/issues/detail?id=128167

Remove the old hard-coded gyp define and allow the more recent (but
still quite old) code in Source/WebCore/page/NavigatorBase.cpp to take
precedence and detect this at runtime.

Patch by Michael Moss <​mmoss@chromium.org> on 2012-05-17
Reviewed by Tony Chang.

No new tests because it's hardware dependent.

  • WebCore.gyp/WebCore.gyp:
6:34 PM Changeset in webkit [117523] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Setting array index -1 and looping over array causes bad behavior
​https://bugs.webkit.org/show_bug.cgi?id=86733
<rdar://problem/11477670>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:

LayoutTests:

  • fast/js/dfg-negative-array-index-expected.txt: Added.
  • fast/js/dfg-negative-array-index.html: Added.
  • fast/js/script-tests/dfg-negative-array-index.js: Added.

(foo):

6:28 PM Changeset in webkit [117522] by pkasting@chromium.org
  • 8 edits in trunk/LayoutTests

[chromium] More rebaselines/expectation updates.
​https://bugs.webkit.org/show_bug.cgi?id=86441

Unreviewed, test expectations update.

  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium/test_expectations.txt:
6:20 PM Changeset in webkit [117521] by vangelis@chromium.org
  • 12 edits in trunk/Source

Source/Platform: [chromium] Expose layer tiling size options to WebSettings
​https://bugs.webkit.org/show_bug.cgi?id=86425

Adding entries for tile size and max untiled layer size.

Reviewed by Adrienne Walker.

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore: [chromium] Expose layer tiling size options to WebSettings.
​https://bugs.webkit.org/show_bug.cgi?id=86425

Removing hardcoded tile size and max untiled layer size from TiledLayerChromium
and instead have the values passed in via the LTH CCSettings. This will allow
different compositor instances to adjust tiling parameters as needed and makes
it possible to set the values via command line arguments.

Reviewed by Adrienne Walker.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
Made some additional adjustments to the single-tile heuristic
to make it work better with arbitrary sizes while still avoiding
to create unreasonably large layers.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

Source/WebKit/chromium: Expose layer tiling size options to WebSettings.
​https://bugs.webkit.org/show_bug.cgi?id=86425

This will allow tiling parameters to be set via command line flags
passed to the Renderer.

Reviewed by Adrienne Walker.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDefaultTileSize):
(WebKit):
(WebKit::WebSettingsImpl::setMaxUntiledLayerSize):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::defaultTileSize):
(WebKit::WebSettingsImpl::maxUntiledLayerSize):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

6:12 PM Changeset in webkit [117520] by pilgrim@chromium.org
  • 8 edits
    1 copy in trunk/Source

[Chromium] Move fileUtilities to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=86777

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::fileUtilities):

  • chromium/public/WebFileUtilities.h: Added.

(WebKit):
(WebFileUtilities):
(WebKit::WebFileUtilities::revealFolderInOS):
(WebKit::WebFileUtilities::fileExists):
(WebKit::WebFileUtilities::deleteFile):
(WebKit::WebFileUtilities::deleteEmptyDirectory):
(WebKit::WebFileUtilities::getFileSize):
(WebKit::WebFileUtilities::getFileModificationTime):
(WebKit::WebFileUtilities::directoryName):
(WebKit::WebFileUtilities::pathByAppendingComponent):
(WebKit::WebFileUtilities::makeAllDirectories):
(WebKit::WebFileUtilities::getAbsolutePath):
(WebKit::WebFileUtilities::isDirectory):
(WebKit::WebFileUtilities::filePathToURL):
(WebKit::WebFileUtilities::openFile):
(WebKit::WebFileUtilities::closeFile):
(WebKit::WebFileUtilities::seekFile):
(WebKit::WebFileUtilities::truncateFile):
(WebKit::WebFileUtilities::readFromFile):
(WebKit::WebFileUtilities::writeToFile):
(WebKit::WebFileUtilities::~WebFileUtilities):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebFileUtilities.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::fileExists):
(WebCore::PlatformSupport::deleteFile):
(WebCore::PlatformSupport::deleteEmptyDirectory):
(WebCore::PlatformSupport::getFileSize):
(WebCore::PlatformSupport::revealFolderInOS):
(WebCore::PlatformSupport::getFileModificationTime):
(WebCore::PlatformSupport::directoryName):
(WebCore::PlatformSupport::pathByAppendingComponent):
(WebCore::PlatformSupport::makeAllDirectories):
(WebCore::PlatformSupport::getAbsolutePath):
(WebCore::PlatformSupport::isDirectory):
(WebCore::PlatformSupport::filePathToURL):
(WebCore::PlatformSupport::openFile):
(WebCore::PlatformSupport::closeFile):
(WebCore::PlatformSupport::seekFile):
(WebCore::PlatformSupport::truncateFile):
(WebCore::PlatformSupport::readFromFile):
(WebCore::PlatformSupport::writeToFile):

5:55 PM Changeset in webkit [117519] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Rolled out r117495 because it caused som out of memory crashes.

  • heap/Heap.cpp:

(JSC::Heap::collect):

5:50 PM Changeset in webkit [117518] by Lucas Forschler
  • 1 copy in tags/Safari-536.12

New Tag.

5:40 PM Changeset in webkit [117517] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Refactored the Heap to move more MarkedSpace logic into MarkedSpace
​https://bugs.webkit.org/show_bug.cgi?id=86790

Reviewed by Gavin Barraclough.

  • heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::markRoots):
(JSC):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::collect):

  • heap/Heap.h:

(Heap): Took all the functors from here...

  • heap/MarkedBlock.h:

(CountFunctor):
(JSC::MarkedBlock::CountFunctor::CountFunctor):
(JSC::MarkedBlock::CountFunctor::count):
(JSC::MarkedBlock::CountFunctor::returnValue):
(MarkedBlock):

  • heap/MarkedSpace.h:

(JSC::ClearMarks::operator()):
(JSC):
(JSC::Sweep::operator()):
(JSC::MarkCount::operator()):
(JSC::Size::operator()):
(JSC::Capacity::operator()):
(MarkedSpace):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity): and put them here.

5:12 PM Changeset in webkit [117516] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
​https://bugs.webkit.org/show_bug.cgi?id=86788
<rdar://problem/11479503>

Reviewed by John Sullivan.

Pass along the URL string of the blocked plug-in so we can find the plug-in even if there was no
MIME type specified in the <embed> or <object> tag.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

4:35 PM Changeset in webkit [117515] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Memory leak in NetworkInfoClient
​https://bugs.webkit.org/show_bug.cgi?id=86603

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-05-17
Reviewed by Adam Barth.

Source/WebCore:

Fix a memory leak in NetworkInfoClient by using OwnPtr and
change the class not to inherite from RefCounted.

  • Modules/networkinfo/NetworkInfoClient.h:

Source/WebKit/efl:

Fix a memory leak in NetworkInfoClient by using OwnPtr and making
the client to be owned by the View.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

4:25 PM Changeset in webkit [117514] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=86786
Two mathml/presentation tests fail on Mac

  • platform/mac/Skipped:
4:25 PM Changeset in webkit [117513] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=86785
Two fast/repaint tests fail on mac lion

  • platform/mac-lion/Skipped:
4:20 PM Changeset in webkit [117512] by jsbell@chromium.org
  • 11 edits in trunk/Source

IndexedDB: Remove IDBIndex.storeName
​https://bugs.webkit.org/show_bug.cgi?id=86676

Reviewed by Tony Chang.

Source/WebCore:

Older versions of the IDB spec exposed IDBIndex.storeName. While it's been removed
from the IDL, the additional storage/plumbing are unnecessary clutter. Nuke it!

No new tests - no functional changes.

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): Remove storeName parameter, and
const declaration on object store param. The former was used to get a non-const pointer
via indirection in openCursorInternal.
(WebCore::IDBIndexBackendImpl::openCursorInternal): Use store pointer directly, don't
look it up by name in the transaction.

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create): Remove storeName parameters.
(IDBIndexBackendImpl): Remove storeName() method.

  • Modules/indexeddb/IDBIndexBackendInterface.h:

(IDBIndexBackendInterface): Remove storeName parameter.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove storeName parameter.
(WebCore::IDBObjectStoreBackendImpl::loadIndexes): Remove storeName parameter.

Source/WebKit/chromium:

  • public/WebIDBIndex.h:

(WebIDBIndex): Can't remove from here until Chromium is updated

  • src/IDBIndexBackendProxy.cpp: Removed storeName()
  • src/IDBIndexBackendProxy.h: Removed storeName()

(IDBIndexBackendProxy):

  • src/WebIDBIndexImpl.cpp: Removed storeName()
  • src/WebIDBIndexImpl.h: Removed storeName()

(WebIDBIndexImpl):

4:19 PM Changeset in webkit [117511] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] www.thestar.com/iphone Viewport Weirdness
​https://bugs.webkit.org/show_bug.cgi?id=86756

Reviewed by George Staikos.

PR 156710
On high DPI devices, the virtual viewport size of this page was smaller
than screen size. During the refreshing of the page, we reset the scale
when the state was Committed, then layouted and rendered contents based
on the virtual viewport size and default scale 1, which caused a small
size thumbnail before we restored the previous view state.
Fixed it by keeping the previous scale, user scalable and
m_userViewportArguments during the Committed state of refreshing.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

4:11 PM Changeset in webkit [117510] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Don't let -[CALayer renderInContext:] try to render WebView's root layer
​https://bugs.webkit.org/show_bug.cgi?id=86773
<rdar://problem/10950075>

Reviewed by Dan Bernstein.

-[CALayer renderInContext:] doesn't correctly render our layer tree, so
don't let it try. Calling drawRect: with a bitmap context will already
do the right thing for WebViews.

  • WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer.

(-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP.
(-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer.

4:03 PM Changeset in webkit [117509] by jsbell@chromium.org
  • 14 edits in trunk

IndexedDB: Implement IDBObjectStore.autoIncrement
​https://bugs.webkit.org/show_bug.cgi?id=86662

Reviewed by Dimitri Glazkov.

Source/WebCore:

Simple boolean accessor defined in the IDB spec, which reflects the
object store's internal autoIncrement flag.

Test: storage/indexeddb/objectstore-basics.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::autoIncrement): Forward call to back end.
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h: Expose attribute as method.

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl: Define the attribute.
  • Modules/indexeddb/IDBObjectStoreBackendInterface.h: Expose in interface.

(IDBObjectStoreBackendInterface):

Source/WebKit/chromium:

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::autoIncrement):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::autoIncrement):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):

3:44 PM Changeset in webkit [117508] by jonlee@apple.com
  • 2 edits in trunk/Tools

Update Apple buildbots to prioritize latest changelists
​https://bugs.webkit.org/show_bug.cgi?id=86766

Reviewed by Brady Eidson.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(pickLatestBuild): Function to get the most pick the most recent build request.
(loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
use the pickLatestBuild function when choosing which request to build next.

3:35 PM Changeset in webkit [117507] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[V8][Refactoring] Remove throwError("message", XXXError) from CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=86744

Reviewed by Adam Barth.

As commented in ​https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am refactoring a series of confusing throwError()s.

This patch removes throwError("message", XXXError) in CodeGeneratorV8.pm
and replaces it with throwTypeError("message") or throwError(XXXError, "message").

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::V8TestObj::constructorCallback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

3:27 PM Changeset in webkit [117506] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Add more descriptive warnings for framebuffer incomplete conditions
​https://bugs.webkit.org/show_bug.cgi?id=86774

Patch by Gregg Tavares <​gman@google.com> on 2012-05-17
Reviewed by Kenneth Russell.

No new tests as there is no new functionality

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):

  • html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::printGLWarningToConsole):

  • html/canvas/WebGLRenderingContext.h:
3:26 PM Changeset in webkit [117505] by pkasting@chromium.org
  • 25 edits
    2 adds in trunk/LayoutTests

[chromium] Rebaseline.
​https://bugs.webkit.org/show_bug.cgi?id=86441

Unreviewed, test expecations update.

  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-mac/fast/multicol/column-rules-expected.png:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-mac/fast/multicol/positive-leading-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [117504] by oliver@apple.com
  • 6 edits in trunk/Source

Endeavour to make the windows test bot actually able to run tests.
​https://bugs.webkit.org/show_bug.cgi?id=86772

Reviewed by Sam Weinig.

Source/WebCore:

Use WEBKIT_EXPORT to get correct export behaviour on windows, rather than
relying on the .def files.

  • bindings/js/JSDOMGlobalObject.h:

(JSDOMGlobalObject):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

Source/WebKit2:

Remove the ClassInfo exports from the .def files as we're now using
WEBKIT_EXPORT declarations to get expected behaviour on windows.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
3:04 PM Changeset in webkit [117503] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[perf-test] Add a micro benchmark for div.firstChild getter for an undefined firstChild
​https://bugs.webkit.org/show_bug.cgi?id=86725

Reviewed by Ryosuke Niwa.

We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

In this bug, we add a micro benchmark for div.firstChild getter for an
undefined firstChild. This benchmark covers other undefined DOM attributes
that return a null.

(Note: In V8, div.firstChild for an undefined firstChild is currently slower
than div.firstChild for a defined firstChild.)

Test results in my Linux desktop:

RESULT Bindings: undefined-first-child= 541.408311042 runs/s
median= 541.205412054 runs/s, stdev= 1.29841219187 runs/s, min= 537.897310513 runs/s, max= 543.209876543 runs/s

RESULT Bindings: undefined-first-child= 541.00750695 runs/s
median= 540.540540541 runs/s, stdev= 0.967521230965 runs/s, min= 539.215686275 runs/s, max= 543.209876543 runs/s

RESULT Bindings: undefined-first-child= 523.630714897 runs/s
median= 523.560209424 runs/s, stdev= 1.01570919645 runs/s, min= 522.193211488 runs/s, max= 525.624178712 runs/s

RESULT Bindings: undefined-first-child= 553.077663588 runs/s
median= 553.459119497 runs/s, stdev= 0.805697397863 runs/s, min= 551.378446115 runs/s, max= 554.156171285 runs/s

RESULT Bindings: undefined-first-child= 541.5401432 runs/s
median= 541.538666618 runs/s, stdev= 0.954301364767 runs/s, min= 539.877300613 runs/s, max= 543.209876543 runs/s

  • Bindings/undefined-first-child.html: Added.
2:59 PM Changeset in webkit [117502] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=86266
r112643/r116697 break Webview form input fields
-and corresponding-
<rdar://problem/11400430>

Reviewed by Dan Bernstein.

There is a recent history of changes in this are that seem worth documenting.
First was the change to switch to using NSTextFieldCell to draw text fields:
​http://trac.webkit.org/changeset/104240

That led to problems because of the clear background that I thought at the time
were specific to MountainLion. To fix that, I made this change:
​http://trac.webkit.org/changeset/110480

But that change resulted in styled text fields getting an un-themed border, which
led to this change on the branch: ​http://trac.webkit.org/changeset/112643 and a
change on TOT that was identical for Lion and SnowLeopard but introduced new
behavior for MountainLion: ​http://trac.webkit.org/changeset/116697

And that brings us to this bug, where it turns out the clear background is a
problem on Lion and SnowLeopard too. This patch fixes the bug by using the
original WebCoreSystemInterface function to paint all text fields on Lion and
SnowLeopard that are styled. This is what we used to paint all text fields before
r104240, which is the first change listed above. Un-styled text fields will still
use NSTextFieldCell on these platforms, but with a hardcoded white background.

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

2:49 PM Changeset in webkit [117501] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

IconDatabase: Move icon retain/release off of the main thread.
<​http://webkit.org/b/85799>
<rdar://problem/9507113>

Reviewed by Brady Eidson.

Batch up the retain/release operations and execute them as part of the sync thread loop.
The batch execution is guarded by a new mutex (m_urlsToRetainOrReleaseLock.)
This avoids blocking the main thread on m_urlAndIconLock for basic retain/release.

There is one exception; if there are pending retain/release operations in synchronousIconForPageURL,
it will acquire the lock and flush the operations.

There should be no behavior change, this is only meant to reduce lock contention.

  • loader/icon/PageURLRecord.h:

(WebCore::PageURLRecord::retain):
(WebCore::PageURLRecord::release):

Added a 'count' argument to these so we can batch up the operations in IconDatabase.

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::performScheduleOrDeferSyncTimer):
(WebCore::IconDatabase::performScheduleOrDeferSyncTimerOnMainThread):
(WebCore::IconDatabase::scheduleOrDeferSyncTimer):

Perform the the timer scheduling on the main thread as it can be done on a different
thread by way of retainIconForPageURL or releaseIconForPageURL.

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::performRetainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performReleaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

2:46 PM Changeset in webkit [117500] by enne@google.com
  • 9 edits in branches/chromium/1132/Source

Merge 117171 - [chromium] Ensure animations get ticked at least once when added.

​https://bugs.webkit.org/show_bug.cgi?id=86013

Patch by Ian Vollick < ​vollick@chromium.org> on 2012-05-15
Reviewed by James Robinson.
Merged by hand by Adrienne Walker, because it didn't apply cleanly.

Source/WebCore:

Tested in

CCLayerTreeHostTestTickAnimationWhileBackgrounded.runSingleThreaded
CCLayerTreeHostTestAddAnimationWithTimingFunction.runSingleThreaded
CCLayerTreeHostTestSynchronizeAnimationStartTimes.runSingleThreaded
CCLayerTreeHostTestAnimationFinishedEvents.runSingleThreaded

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::addAnimation):
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::finishCommitOnImplThread): (WebCore::CCLayerTreeHost::didAddAnimation): (WebCore): (WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
  • platform/graphics/chromium/cc/CCLayerTreeHost.h: (CCLayerTreeHost):
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
  • platform/graphics/chromium/cc/CCProxy.h: (CCProxy):
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (CCSingleThreadProxyAnimationTimer): (WebCore::CCSingleThreadProxyAnimationTimer::create): (WebCore::CCSingleThreadProxyAnimationTimer::CCSingleThreadProxyAnimationTimer): (WebCore): (WebCore::CCSingleThreadProxy::CCSingleThreadProxy): (WebCore::CCSingleThreadProxy::didAddAnimation): (WebCore::CCSingleThreadProxy::doComposite):
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h: (WebCore):
  • platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp: (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers): (WTF):
2:41 PM Changeset in webkit [117499] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117361 - REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
​https://bugs.webkit.org/show_bug.cgi?id=86663

Reviewed by Tony Chang.

The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.

Fixed the mismatch.

Test: editing/pasteboard/paste-text-with-style-5.html

  • editing/EditingStyle.cpp:

(WebCore::getPropertiesNotIn):
Review URL: ​https://chromiumcodereview.appspot.com/10391190

2:34 PM Changeset in webkit [117498] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1084

Merge 117361 - REGRESSION(r92823): WebKit strips font-weight: normal from b element when copying
​https://bugs.webkit.org/show_bug.cgi?id=86663

Reviewed by Tony Chang.

The bug was caused by removeStyleFromRulesAndContext incorrectly stripping font-weight property
even when the context had no font-weight property because of a property name mismatch in getPropertiesNotIn.

Fixed the mismatch.

Test: editing/pasteboard/paste-text-with-style-5.html

  • editing/EditingStyle.cpp:

(WebCore::getPropertiesNotIn):

2:31 PM Changeset in webkit [117497] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Kill RenderLayer::relativePositionOffset(LayoutUnit& relX, LayoutUnit& relY) and cleanup RenderInline::clippedOverflowRectForRepaint
​https://bugs.webkit.org/show_bug.cgi?id=86551

Reviewed by Abhishek Arya.

No test since there is no expected change in behavior.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
Changed the function to use LayoutRect arithmetics instead of calculating
top / left manually. While at it, improved the naming, removed some local
variables and removed an unneeded style() NULL-check.

  • rendering/RenderLayer.h: Removed the function.
2:23 PM Changeset in webkit [117496] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Increase the GC allocation trigger
​https://bugs.webkit.org/show_bug.cgi?id=86699

Reviewed by Sam Weinig.

This helps a lot when the heap is growing, and helps to resolve
the regression caused by r116484.

  • heap/Heap.cpp:

(JSC::Heap::collect):

2:21 PM Changeset in webkit [117495] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Make the docked Web Inspector use autoresizing masks so the view doesn't jitter when
resizing the window.

​https://webkit.org/b/86765

Reviewed by John Sullivan.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter close]): Added. Zero out _inspectorProxy.
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Preform the work on a delay to
prevent interfering with Cocoa's resizing.
(WebKit::WebInspectorProxy::createInspectorWindow): Added setAutoresizingMask: call.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Removed setAutoresizingMask: call.
createInspectorWindow and platformAttach do this now.
(WebKit::WebInspectorProxy::platformDidClose): Call close on WKWebInspectorProxyObjCAdapter.
(WebKit::WebInspectorProxy::platformAttach): Added setAutoresizingMask: call.

2:17 PM Changeset in webkit [117494] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Fix linking errors
​https://bugs.webkit.org/show_bug.cgi?id=86768

Reviewed by Antonio Gomes.

Add some missing stubs so we can link again.

  • platform/blackberry/ContextMenuBlackBerry.cpp:

(WebCore::ContextMenu::itemCount):
(WebCore):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenHorizontalDPI):
(WebCore):
(WebCore::screenVerticalDPI):

2:06 PM Changeset in webkit [117493] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, update test number tracking media-continues-playing-after-replace-source.html

  • platform/efl/test_expectations.txt:
2:05 PM Changeset in webkit [117492] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove passing tests, re-number some still-present issues.
​https://bugs.webkit.org/show_bug.cgi?id=86441
​https://bugs.webkit.org/show_bug.cgi?id=86701
​https://bugs.webkit.org/show_bug.cgi?id=86712

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
1:57 PM Changeset in webkit [117491] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix rounding in paintSelection
​https://bugs.webkit.org/show_bug.cgi?id=86693

Reviewed by Eric Seidel.

Break out rounding logic from InlineTextBox::paintSelection into separate
function and use it for all the EllipsisBox paintSelection implementation
and selection gap calculation. This ensures that selections are painted
without gaps and overlaps once we turn on subpixel layout.

No new tests, covered by existing tests in editing/selection and
editing/style.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection):

  • rendering/InlineTextBox.cpp:

(WebCore::alignSelectionRectToDevicePixels):
(WebCore):
(WebCore::InlineTextBox::paintSelection):

  • rendering/InlineTextBox.h:

(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):

1:55 PM Changeset in webkit [117490] by rakuco@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Gardening, update expectations after r117426.

  • platform/efl/editing/unsupported-content/list-type-before-expected.txt:
  • platform/efl/editing/unsupported-content/table-type-after-expected.txt:
  • platform/efl/editing/unsupported-content/table-type-before-expected.txt:
1:46 PM Changeset in webkit [117489] by robert@webkit.org
  • 3 edits
    8 moves
    22 adds in trunk/LayoutTests

Rebaseline Chromium results after r117477

Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/table-height-algorithm-023-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png.
  • platform/chromium-linux/css2.1/20110323/table-height-algorithm-024-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png.
  • platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png.
  • platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png.
  • platform/chromium-mac-leopard/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-023-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/table-height-algorithm-024-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt.
  • platform/chromium/test_expectations.txt:
1:30 PM Changeset in webkit [117488] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] fast/dom/gc-10.html behaves badly
​https://bugs.webkit.org/show_bug.cgi?id=86771

Unreviewed, skipping fast/dom/gc-10.html as it badly affects other tests.

  • platform/gtk/test_expectations.txt:
1:10 PM Changeset in webkit [117487] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cleanup headers in SelectionHandler.cpp
​https://bugs.webkit.org/show_bug.cgi?id=86760

Reviewed by Antonio Gomes.

Clean up includes in SelectionHandler.cpp.

  • WebKitSupport/SelectionHandler.cpp:
1:08 PM Changeset in webkit [117486] by robert@webkit.org
  • 4 edits in trunk/LayoutTests

Rebaseline two tests on Mac and update Mac expectations after r117339

Unreviewed gardening.

  • platform/mac/fast/repaint/float-overflow-expected.txt:
  • platform/mac/fast/repaint/float-overflow-right-expected.txt:
  • platform/mac/test_expectations.txt:
1:04 PM Changeset in webkit [117485] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUseBytes is large.
​https://bugs.webkit.org/show_bug.cgi?id=86764

Patch by Michal Mocny <​mmocny@google.com> on 2012-05-17
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):

1:01 PM Changeset in webkit [117484] by mitz@apple.com
  • 9 edits
    2 adds in trunk

In vertical writing modes, pagination may split a line after a block shifts
​https://bugs.webkit.org/show_bug.cgi?id=86763

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/multicol/pageLogicalOffset-vertical.html

LayoutState::pageLogicalOffset() was returning bogus results in vertical writing modes,
because it was always using physical heights. Changed it to take a RenderBox and use its
writing mode to choose between heights and widths.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

  • fast/multicol/pageLogicalOffset-vertical-expected.html: Added.
  • fast/multicol/pageLogicalOffset-vertical.html: Added.
12:58 PM Changeset in webkit [117483] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range.
​https://bugs.webkit.org/show_bug.cgi?id=86759

Reviewed by Antonio Gomes.

expandSelectionToGranularity unnecesarily converted the
selection to range and back. Using the selection
directly is preferred.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::expandSelectionToGranularity):

12:43 PM Changeset in webkit [117482] by inferno@chromium.org
  • 8 edits
    15 adds in trunk

Move run-in handling to addChild, instead of in layout.
​https://bugs.webkit.org/show_bug.cgi?id=86387

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/insert-before-run-in.html

fast/runin/run-in-after-run-in.html
fast/runin/run-in-parent-add-child.html
fast/runin/run-in-parent-block-child-add-and-intrude.html
fast/runin/run-in-parent-block-child-add.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle run-ins here
instead of layout. We do run-in handling when we see a new child with run-in display
or add a new block whose previous sibling is run-in.
(WebCore::RenderBlock::makeChildrenNonInline): if we will have block children, need
to move run-in back to its original position.
(WebCore::RenderBlock::handleSpecialChild): no longer need to handle run-ins during layout.
(WebCore::destroyRunIn): helper to destroy a block or inline run-in.
(WebCore):
(WebCore::RenderBlock::createReplacementRunIn): helper to create the new replacement run-in.
For moveRunInUnderSiblingBlockIfNeeded, it will be used to create a new inline run-in
that goes into the next sibling block. For moveRunInToOriginalPosition, it creates a new
block run-in that goes back to where it came from.
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded): almost same as previous
handleRunInChild function, but with the return type removed. Also, we don't allow
a run-in to intrude into a block that already has a run-in.
(WebCore::RenderBlock::moveRunInToOriginalPosition): moves run-in back to where it came from.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.cpp: move all moveChild* functions from RenderBox, since

they can now be used to move children of inlines.
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore):
(WebCore::RenderBoxModelObject::moveChildrenTo): same.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore::RenderBoxModelObject::moveAllChildrenTo): same.
(WebCore::RenderBoxModelObject::moveChildrenTo): same.

LayoutTests:

The following tests need the render tree results as they help
to show the positioning of the run-in with respect to the next
sibling block.

  • fast/runin/insert-before-run-in-expected.png: Added.
  • fast/runin/insert-before-run-in-expected.txt: Added.
  • fast/runin/insert-before-run-in.html: Added.
  • fast/runin/run-in-after-run-in-expected.png: Added.
  • fast/runin/run-in-after-run-in-expected.txt: Added.
  • fast/runin/run-in-after-run-in.html: Added.
  • fast/runin/run-in-parent-add-child-expected.png: Added.
  • fast/runin/run-in-parent-add-child-expected.txt: Added.
  • fast/runin/run-in-parent-add-child.html: Added.
  • fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Added.
  • fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt: Added.
  • fast/runin/run-in-parent-block-child-add-and-intrude.html: Added.
  • fast/runin/run-in-parent-block-child-add-expected.png: Added.
  • fast/runin/run-in-parent-block-child-add-expected.txt: Added.
  • fast/runin/run-in-parent-block-child-add.html: Added.
12:38 PM Changeset in webkit [117481] by mnaganov@chromium.org
  • 7 edits in trunk/Source

Support Copy ... actions for the Web Inspector remote debugging mode.
​https://bugs.webkit.org/show_bug.cgi?id=86621

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.documentCopy):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.clipboardAccessDeniedMessage):
(.WebInspector.ClipboardAccessDeniedScreen):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.documentCopy):
(WebInspector.documentCopyEventFired):

Source/WebKit/chromium:

  • src/js/DevTools.js:

(WebInspector.clipboardAccessDeniedMessage):

12:36 PM Changeset in webkit [117480] by robert@webkit.org
  • 24 edits
    1 copy
    6 adds
    6 deletes in trunk/LayoutTests

Rebaseline results after r117339

Unreviewed gardening.

  • fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac-leopard/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-leopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-leopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-leopard/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac-leopard/fast/inline-block/001-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline-block/001-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.txt: Added.
  • platform/chromium-mac/editing/selection/inline-table-expected.png:
  • platform/chromium-mac/editing/selection/inline-table-expected.txt: Added.
  • platform/chromium-mac/editing/selection/table-caret-3-expected.png:
  • platform/chromium-mac/editing/selection/table-caret-3-expected.txt: Added.
  • platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.png:
  • platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.txt: Added.
  • platform/chromium-mac/fast/inline-block/001-expected.png:
  • platform/chromium-mac/fast/inline-block/001-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Removed.
  • platform/chromium-win-vista/fast/inline-block/001-expected.png: Removed.
  • platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Removed.
  • platform/chromium-win-xp/fast/inline-block/001-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt.
  • platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
12:10 PM Changeset in webkit [117479] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r117205.

  • platform/efl/test_expectations.txt:
12:08 PM Changeset in webkit [117478] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

This is not a joke: 3.7X speedup from removing a call to sleep
​https://bugs.webkit.org/show_bug.cgi?id=86702

Reviewed by Eric Seidel.

The speedup was on a GC benchmark, with a custom VM caching layer
not in TOT yet.

Instruments showed most GC threads spending the majority of their
time sleeping instead of doing useful work. Removing the call to
sleep sped up the benchmark.

  • wtf/TCSpinLock.h:

(TCMalloc_SlowLock): Since a spin lock is only ever held for a short
amount of time, don't sleep for a long amount of time waiting for it
to unlock -- yielding to the scheduler is sufficient.

If we find a case where someone is sitting on a spin lock for over 2ms,
we should fix the spin lock holder, not the spin lock.

12:07 PM Changeset in webkit [117477] by robert@webkit.org
  • 9 edits
    13 adds in trunk

CSS 2.1 failure: table-height-algorithm-023 and -024 fail
​https://bugs.webkit.org/show_bug.cgi?id=85405

Reviewed by Eric Seidel.

Source/WebCore:

Treat vertical-align: [length] the same as vertical-align: baseline.

Tests: css2.1/20110323/table-height-algorithm-023.htm

css2.1/20110323/table-height-algorithm-024.htm
fast/table/mozilla-bug10296-vertical-align-1.html
fast/table/mozilla-bug10296-vertical-align-2.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

  • css2.1/20110323/table-height-algorithm-023.htm: Added.
  • css2.1/20110323/table-height-algorithm-024.htm: Added.

Tests from the CSS test suite.

  • fast/table/mozilla-bug10296-vertical-align-1.html: Added.
  • fast/table/mozilla-bug10296-vertical-align-2.html: Added.

I split out the part of bug10296-1.html that gets rebaselined here so that the new results
are visible. I also changed the text so that the expected result is less mysterious.

  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.txt:
12:04 PM Changeset in webkit [117476] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix rounding in RenderFlowThread::paintIntoRegion
​https://bugs.webkit.org/show_bug.cgi?id=86695

Reviewed by Eric Seidel.

Fix rounding of offset in paintIntoRegion to ensure that we paint on
device pixel boundaries.

Covered by existing tests in fast/regions.

  • platform/graphics/FractionalLayoutPoint.h:

(WebCore::roundedIntPoint):
Add roundedIntPoint(FractionalLayoutSize) function.
(WebCore):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):

12:04 PM Changeset in webkit [117475] by rakuco@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Gardening after r116339.

Add platform-specific results for the tests below.

  • platform/efl/fast/repaint/float-overflow-expected.txt: Added.
  • platform/efl/fast/repaint/float-overflow-right-expected.txt: Added.
11:58 AM Changeset in webkit [117474] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

[Qt] Fix MiniBrowser by using correct syntax for qrc URLs
​https://bugs.webkit.org/show_bug.cgi?id=86761

Reviewed by Alexis Menard.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::updateVisualMockTouchPoints):

11:57 AM Changeset in webkit [117473] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Parser: Avoid unnecessary ref count churn in token constructors.
<​http://webkit.org/b/86667>

Reviewed by Antti Koivisto.

Pass AtomicString by const reference to avoid useless ref count churn
in AtomicHTMLToken() and AtomicXMLToken().

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

11:50 AM Changeset in webkit [117472] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip another passing test after r117426.

  • platform/efl/test_expectations.txt:
11:48 AM Changeset in webkit [117471] by kling@webkit.org
  • 5 edits in trunk/Source

Make PluginInfoStore properly thread-safe.
<​http://webkit.org/b/86648>
<rdar://problem/11451178>

Reviewed by Darin Adler.

Source/WebCore:

  • plugins/PluginData.h:

(WebCore::MimeClassInfo::isolatedCopy):
(WebCore::PluginInfo::isolatedCopy):

Source/WebKit2:

Deep copy the internal storage of PluginInfoStore after constructing it, as we can
be doing this from a secondary thread.

  • Shared/Plugins/PluginModuleInfo.h:

(WebKit::PluginModuleInfo::isolatedCopy):

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::deepIsolatedCopyPluginInfoVector):
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):

11:44 AM Changeset in webkit [117470] by hbono@chromium.org
  • 34 edits in trunk/Source

[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
​https://bugs.webkit.org/show_bug.cgi?id=86591

Reviewed by Ryosuke Niwa.

This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
function to remove platform-specific code from Editor::respondToChangedSelection
function.

No new tests, no change in behavior.

Source/WebCore:

  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::shouldEraseMarkersAfterChangeSelection):

  • platform/text/TextCheckerClient.h:

(TextCheckerClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • WebCoreSupport/TextCheckerClientGtk.h:

(TextCheckerClientGtk):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldEraseMarkersAfterChangeSelection):

Source/WebKit/qt:

  • WebCoreSupport/TextCheckerClientQt.cpp:

(WebCore::TextCheckerClientQt::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebCoreSupport/TextCheckerClientQt.h:

(TextCheckerClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldEraseMarkersAfterChangeSelection):

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • WebCoreSupport/EditorClientWinCE.h:

(EditorClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldEraseMarkersAfterChangeSelection):
(WebCore):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebKit):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
11:41 AM Changeset in webkit [117469] by jamesr@google.com
  • 16 edits in trunk/Source

[chromium] Convert GraphicsLayerChromium to use WebLayer types
​https://bugs.webkit.org/show_bug.cgi?id=86269

Reviewed by Adrienne Walker.

Source/Platform:

Adds some new WebLayer / WebContentLayer APIs that WebCore::GraphicsLayerChromium needs.

  • chromium/public/WebContentLayer.h:

(WebCore):
(WebKit):
(WebContentLayer):

  • chromium/public/WebLayer.h:

(WebKit):
(WebKit::WebLayer::isNull):
(WebLayer):

  • chromium/public/WebTransformationMatrix.h:

(WebKit::WebTransformationMatrix::~WebTransformationMatrix):

Fix a memory leak - WebPrivateOwnPtr<>s have to be explicitly cleared.

(WebTransformationMatrix):

Source/WebCore:

This converts GraphicsLayerChromium over to use WebLayer and WebContentLayer. The conversion is not completely
as the Web*Layer APIs are not yet quite complete enough to use everywhere, and the PlatformLayer typedef is not
changed in this patch. The places where we have to punch out through API layer are marked by
unwrap<*LayerChromium>() calls and FIXME's in the Web*Layer.h files. There aren't many.

Refactor only, existing tests apply.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit):
(WebKit::WebTransformationMatrix::reset):
(WebKit::WebTransformationMatrix::projectPoint):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::hostLayerForChildren):
(WebCore::GraphicsLayerChromium::layerForParent):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):
(WebCore::GraphicsLayerChromium::primaryLayer):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebContentLayer.cpp:

(WebKit::WebContentLayer::clearClient):
(WebKit):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):

  • src/WebContentLayerImpl.cpp:
  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebLayer.cpp:

(WebKit::WebLayer::setSublayerTransform):
(WebKit):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::setIsDrawable):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setDoubleSided):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setContentsScale):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TEST):

11:34 AM Changeset in webkit [117468] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

remove bit rotted comment about css properties
​https://bugs.webkit.org/show_bug.cgi?id=86750

Reviewed by Alexis Menard.

It's not clear to me what the first block was even referring to.
Aural doesn't seem to exist anymore. It might be worth keeping,
"All the CSS properties are not supported by the renderer at the
moment.", but it seems obvious to me.

No new tests, just removing a comment.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

11:33 AM Changeset in webkit [117467] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Remove unnecessary expectations for passing tests.
​https://bugs.webkit.org/show_bug.cgi?id=86698

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:22 AM Changeset in webkit [117466] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Insert source file and line number for v8 function calls into tracing
​https://bugs.webkit.org/show_bug.cgi?id=84613

Reviewed by Kentaro Hara.

The trace for v8 function calls doesn't include any information about
what function is being called. Pass this information along so it can
be less opaque.

  • bindings/v8/V8Proxy.cpp:

(WebCore::resourceInfo):
(WebCore):
(WebCore::resourceString):
(WebCore::V8Proxy::instrumentedCallFunction):

  • platform/chromium/TraceEvent.h:

(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):

11:21 AM Changeset in webkit [117465] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip some tests after r117426.

  • platform/efl/test_expectations.txt:
11:09 AM Changeset in webkit [117464] by commit-queue@webkit.org
  • 11 edits
    1 copy
    2 adds in trunk

[EFL] Add API for Web Database handling
​https://bugs.webkit.org/show_bug.cgi?id=85178

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-17
Reviewed by Antonio Gomes.

Source/WebKit:

Added the new Web Database API to the buildsystem.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add API for Web Database. This API will allow a browser
to query information about size, name, filename and remove
databases based on the origin. It will be also possible to
list all databases for a given origin.

  • ewk/EWebKit.h:
  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_web_database_get_all):

  • ewk/ewk_security_origin.h:
  • ewk/ewk_settings.cpp:
  • ewk/ewk_settings.h:
  • ewk/ewk_web_database.cpp: Added.

(_Ewk_Web_Database):
(ewk_web_database_display_name_get):
(ewk_web_database_expected_size_get):
(ewk_web_database_filename_get):
(ewk_web_database_name_get):
(ewk_web_database_security_origin_get):
(ewk_web_database_size_get):
(ewk_web_database_remove):
(ewk_web_database_remove_all):
(ewk_web_database_free):
(ewk_web_database_list_free):
(ewk_web_database_new):

  • ewk/ewk_web_database.h: Added.
  • ewk/ewk_web_database_private.h: Copied from Source/WebKit/efl/ewk/EWebKit.h.

(WebCore):

Tools:

Use the newly introduced Web Database API in EFL's DRT.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearAllDatabases):

10:54 AM Changeset in webkit [117463] by caio.oliveira@openbossa.org
  • 5 edits in trunk

[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
​https://bugs.webkit.org/show_bug.cgi?id=73802

Reviewed by Ryosuke Niwa.

Source/WebCore:

Timeout was caused by an infinite in the outer loop of
pushDownInlineStyleAroundNode(). The outer loop variable 'current' should point at the
node containing 'targetNode'. The inner loop traverse the children of 'current'
and discover the children that contains 'targetNode'.

However, before the inner loop, we call removeInlineStyleFromElement() that can
potentially remove the 'current' node from the tree, moving its children to
'current' former parent. For that reason 'child' and 'lastChild' are collected
before this call.

The tricky part is that changing the 'current' children parent, we might trigger
further side-effects, that can remove either 'child' or 'lastChild' from the tree
too. The infinite loop was due to 'child' being off the document, so it's
nextSibling() is 0, and we go another run of outer loop without changing
'current' because the 'targetNode' wasn't in the first child that inner loop
couldn't reach.

When testing Qt on Mac, there was also a crash in RenderTextControl when the font
family was empty, this patch fixes it as well.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Use NodeVector
instead of relying on first/last child being valid after
removeInlineStyleFromElement() is called. Skip the child if it has no parent,
this is an indication that it was removed from the tree.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hasValidAvgCharWidth): Empty AtomicStrings aren't
supported by HashSet, so we have to early return in this case.

LayoutTests:

  • platform/qt/Skipped: Unskipped. Note that it is still skipped for wk2 because

setEditingBehavior is not implemented for WebKitTestRunner yet.

10:52 AM Changeset in webkit [117462] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: implement Go To selector for stylesheet files.
​https://bugs.webkit.org/show_bug.cgi?id=86751

Reviewed by Yury Semikhatsky.

StyleSheetOutlineDialog is introduced.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/FilteredItemSelectionDialog.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._generateTabId):
(WebInspector.TabbedEditorContainer.prototype.currentFile):

10:50 AM Changeset in webkit [117461] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r117449): Unreviewed, rolling out r117449.
​https://bugs.webkit.org/show_bug.cgi?id=86753

Broke many unskipped tests which lack expectations

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:27 AM Changeset in webkit [117460] by mitz@apple.com
  • 41 edits in trunk

REGRESSION (r117428): WebKit API/SPI was removed
​https://bugs.webkit.org/show_bug.cgi?id=86748

Reverted r117428.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebView.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDomainRelaxationForbidden):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setDomainRelaxationForbiddenForURLScheme):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebKit.order:
  • WebView/WebView.mm:

(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):

  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::setDomainRelaxationForbiddenForURLScheme):

  • WebView.h:

(WebView):

Source/WebKit2:

  • win/WebKit2.def:

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(setDomainRelaxationForbiddenForURLSchemeCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

LayoutTests:

  • http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
10:25 AM Changeset in webkit [117459] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Fix link error caused by not directly linking with edbus
​https://bugs.webkit.org/show_bug.cgi?id=86747

Unreviewed build fix.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-05-17

.:

  • Source/cmake/FindEFL.cmake:

Source/WebKit:

  • PlatformEfl.cmake:
10:20 AM Changeset in webkit [117458] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Build fix, SelectionHandler extra debug logs
​https://bugs.webkit.org/show_bug.cgi?id=86743

Reviewed by Antonio Gomes.

Add include for BlackBerryPlatformLog to SelectionHandler.cpp

  • WebKitSupport/SelectionHandler.cpp:
10:05 AM Changeset in webkit [117457] by zandobersek@gmail.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, adding GTK baselines for new tests added in r115641, r116975 and r117339.

  • platform/gtk/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/gtk/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.txt: Added.
9:35 AM Changeset in webkit [117456] by Csaba Osztrogonác
  • 3 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
9:05 AM Changeset in webkit [117455] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: create SourceFrames with content providers.
​https://bugs.webkit.org/show_bug.cgi?id=86742

Reviewed by Vsevolod Vlasov.

Simple refactoring.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.get resource):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSourceFrame):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.contentURL):

9:00 AM Changeset in webkit [117454] by yurys@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: error when expanding an HTMLAllCollection object in the console
​https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/console/inspect-html-all-collection.html

  • inspector/InjectedScriptSource.js: take into account that typeof HTMLAllCollection is "undefined"

when checking if object resolved by id is valid.

LayoutTests:

Test that RemoteObject.callFunctionOn can be successfully invoked on a
remote object representing HTMLAllCollection instance.

  • inspector/console/inspect-html-all-collection-expected.txt: Added.
  • inspector/console/inspect-html-all-collection.html: Added.
8:57 AM Changeset in webkit [117453] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix attempt. Changing class to struct in forward declaration.

  • fileapi/File.h:

(WebCore):

8:51 AM Changeset in webkit [117452] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: convert styles panel into UISourceCodeProvider in the scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=86734

Reviewed by Vsevolod Vlasov.

This change also makes Scripts render ans Source Code under that experiment.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.get toolbarItemLabel):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.StylesUISourceCodeProvider.prototype._initialize):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
(WebInspector.StyleSource):
(WebInspector.StyleSourceFrame):
(WebInspector.StyleSourceFrame.prototype.canEditSource):
(WebInspector.StyleSourceFrame.prototype.requestContent):
(WebInspector.StyleSourceFrame.prototype.commitEditing):
(WebInspector.StyleSourceFrame.prototype.afterTextChanged):
(WebInspector.StyleSourceFrame.prototype._clearIncrementalUpdateTimer):
(WebInspector.StyleSourceFrame.prototype._contentChanged):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/inspector.js:

(WebInspector._createPanels):

8:42 AM Changeset in webkit [117451] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Frame flattening should not expand tiny frames
​https://bugs.webkit.org/show_bug.cgi?id=86736

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

If a frame has so small fixed size that it is not usefully scrollable on desktop it is probably
not meant to be scrolled. Displaying any otherwise invisible content by expanding the frame
may end up looking like a rendering error.

The patch prevents expansion of frames that have fixed width or height less than 8px.

Test: fast/frames/flattening/iframe-tiny.html

  • rendering/RenderFrameBase.cpp:

(WebCore::shouldExpandFrame):
(WebCore):
(WebCore::RenderFrameBase::layoutWithFlattening):

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • fast/frames/flattening/iframe-tiny-expected.txt: Added.
  • fast/frames/flattening/iframe-tiny.html: Added.
8:21 AM Changeset in webkit [117450] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=86726

Reviewed by Pavel Feldman.

No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.

  • inspector/WorkerDebuggerAgent.cpp:
8:19 AM Changeset in webkit [117449] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening failure test cases.
​https://bugs.webkit.org/show_bug.cgi?id=86728

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com>, Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2012-05-17

  • platform/efl/Skipped: removing tests related to editing callbacks functionality.
  • platform/efl/test_expectations.txt: adding new bugs regarding drag'n'drop and spell checking.

Merging tests with particular bugs.

8:17 AM Changeset in webkit [117448] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8][Refactoring] Support an optional 'message' argument for throwTypeError()
​https://bugs.webkit.org/show_bug.cgi?id=86576

Reviewed by Adam Barth.

As commented in ​https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am planning to refactor a series of confusing throwError()s into
throwError() and throwTypeError().

This patch supports an optional 'message' argument for V8Proxy::throwTypeError().
Also this patch replaces throwError("message", V8Proxy::TypeError) in custom bindings
with V8Proxy::throwTypeError("message").

No tests. No change in behavior.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::throwTypeError):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):

  • bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

7:21 AM Changeset in webkit [117447] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
​https://bugs.webkit.org/show_bug.cgi?id=86659

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.

  • inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.

(iframe.extension):

7:08 AM Changeset in webkit [117446] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] run-webkit-tests can't work on ubuntu 12.04
​https://bugs.webkit.org/show_bug.cgi?id=86565

Patch by Li Yin <​li.yin@intel.com> on 2012-05-17
Reviewed by Kent Tamura.

On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf

  • DumpRenderTree/chromium/TestShellLinux.cpp:

(checkAndLoadFontFile):
(setupFontconfig):

6:54 AM Changeset in webkit [117445] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
​https://bugs.webkit.org/show_bug.cgi?id=86711

Changed color values with background on hover over breakpoints.

Patch by Sam D <​dsam2912@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

UI change, No new tests.

  • inspector/front-end/inspector.css:

(.breakpoint-list li:hover):

6:35 AM Changeset in webkit [117444] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding platform-specific baselines for
two tests affected by r117339.

  • platform/gtk/fast/repaint/float-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/float-overflow-right-expected.txt: Added.
6:35 AM Changeset in webkit [117443] by epoger@chromium.org
  • 2 edits in trunk/Tools

Add setting of additional_expectations option to
chromium_unittest.test_overrides_and_builder_names(),
so we can test order in which the base and chromium expectations files
are combined.

​https://bugs.webkit.org/show_bug.cgi?id=86642

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_overrides_and_builder_names):

6:32 AM Changeset in webkit [117442] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: DOM Breakpoints Pane should allow to Remove All the breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=86716

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Added a new context menu to provide Remove All DOM breakpoint option.

UI Feature. Tests not required.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._removeAllBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

6:29 AM Changeset in webkit [117441] by kkristof@inf.u-szeged.hu
  • 2 edits
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expectation.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-05-17

  • platform/qt-5.0-wk2/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
  • platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt: Added after r117289.
  • platform/qt/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added after r117419.
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt: Update after r117429.
6:26 AM Changeset in webkit [117440] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Patch by Tsarko Yaroslav <​eriktsarko@googlemail.com> on 2012-05-17
Reviewed by Yury Semikhatsky.

Bug 71271: [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during
​https://bugs.webkit.org/show_bug.cgi?id=71271

Web Inspector should not belong to any other page groups since it is a specialized debugger window.
The reason for this change is when debugger pauses web page it pauses all the pages in the page group of debuggee.
This leads that Web Inspector front-end is paused too leading to locked Web Inspector GUI (bugzilla ticket 71271).

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::openInspectorFrontend):

6:07 AM Changeset in webkit [117439] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
​https://bugs.webkit.org/show_bug.cgi?id=85632

Unskip the now passing test after Qt5 fix.

  • platform/qt-5.0-wk1/Skipped:
5:52 AM Changeset in webkit [117438] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] svg/zoom/page/zoom-svg-float-border-padding.xml crashes
​https://bugs.webkit.org/show_bug.cgi?id=79631

  • platform/qt/Skipped: Try to unskip them.
5:48 AM Changeset in webkit [117437] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapSnapshot: speed-up calculateObjectToWindowDistance
​https://bugs.webkit.org/show_bug.cgi?id=86718

The idea is to switch from nodeIndex2distance array to nodeOrdinal2distance external array.
Due to nature of nodeIndex values the original array was sparsed.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):

5:39 AM Changeset in webkit [117436] by kbalazs@webkit.org
  • 5 edits in trunk

[Qt] Web process hangs while waiting for plugin process connection during layouttests
​https://bugs.webkit.org/show_bug.cgi?id=86620

Reviewed by Csaba Osztrogonác.

Tools:

Reenable TestNetscapePlugin with Qt 4.

  • Tools.pro:

LayoutTests:

Don't disable plugin tests for Qt 4.

  • platform/qt-5.0/Skipped:
  • platform/qt/Skipped:
5:30 AM Changeset in webkit [117435] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] fast/events/page-visibility-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=83263

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-17
Reviewed by Kenneth Rohde Christiansen.

Tools:

Handle "preview" state and avoid string conversion.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):

LayoutTests:

Unskip two page-visibility tests: iframe-propagation-test.html
and transition-test.html.

  • platform/qt-5.0-wk2/Skipped:
5:27 AM Changeset in webkit [117434] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unksip one more now passing test.

  • platform/qt/Skipped:
5:24 AM Changeset in webkit [117433] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unksip a now passing test.

  • platform/qt/Skipped:
5:07 AM Changeset in webkit [117432] by kinuko@chromium.org
  • 7 edits
    2 adds in trunk

Allow FileSystem API implementation to pass snapshot metadata at File creation time
​https://bugs.webkit.org/show_bug.cgi?id=78879

Reviewed by Jian Li.

Source/WebCore:

We query File metadata (e.g. size and modifiedTime) when File.size,
lastModifiedTime or webkitSlice() is accessed / called, but in some
platform-specific filesystems it may not be feasible since synchronous
metadata query could take very long time.

This patch adds new File constructor which takes metadata argument
to allow each FileSystem API implementation to pass snapshot metadata
so that File object could cache the given metadata not to make
synchronous query.

We only call this constructor if the filesystem type is neither
Temporary nor Persistent, therefore this patch should not affect
existing code behavior.

Test: fast/filesystem/file-read-after-write.html

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::createFile):

  • Modules/filesystem/DOMFileSystemSync.cpp:
  • fileapi/Blob.cpp:

(WebCore::Blob::webkitSlice): Updated implementation.

  • fileapi/Blob.h:
  • fileapi/File.cpp:

(WebCore::File::File): Added new constructor.
(WebCore::File::lastModifiedDate): Updated implementation.
(WebCore::File::size): Updated implementation.
(WebCore::File::captureSnapshot): Updated implementation.

  • fileapi/File.h:

(WebCore::File::createForFileSystemFile): Added.

  • platform/AsyncFileSystem.h:

(AsyncFileSystem): Updated comment.

LayoutTests:

Added tests for making sure metadata is not cached in the regular
temporary filesystem.

  • fast/filesystem/file-metadata-after-write-expected.txt: Added.
  • fast/filesystem/file-metadata-after-write.html: Added.
4:55 AM Changeset in webkit [117431] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating chrome test expectations.

  • platform/chromium/test_expectations.txt:
4:37 AM Changeset in webkit [117430] by haraken@chromium.org
  • 1 edit
    1 add in trunk/PerformanceTests

[Performance test] Add a micro benchmark for div.firstChild getter
​https://bugs.webkit.org/show_bug.cgi?id=86582

Reviewed by Ryosuke Niwa.

We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.

In this bug, we add a micro benchmark for div.firstChild getter.
This benchmark covers 'firstChild', 'lastChild', 'nextSibling' and
'previousSibling' in Dromaeo/dom-traverse.html, and other DOM attributes
that return a Node object.

Multiple test results in my Linux desktop:

RESULT Bindings: first-child= 798.157160346 runs/s
median= 798.004987531 runs/s, stdev= 1.52006063407 runs/s, min= 796.019900498 runs/s, max= 801.001251564 runs/s
RESULT Bindings: first-child= 797.603608554 runs/s
median= 797.872340426 runs/s, stdev= 2.2522621261 runs/s, min= 791.556728232 runs/s, max= 801.001251564 runs/s
RESULT Bindings: first-child= 798.656295468 runs/s
median= 798.004987531 runs/s, stdev= 1.79367478063 runs/s, min= 797.01120797 runs/s, max= 803.011292346 runs/s
RESULT Bindings: first-child= 797.812784267 runs/s
median= 798.004987531 runs/s, stdev= 2.31766523191 runs/s, min= 791.100123609 runs/s, max= 802.005012531 runs/s
RESULT Bindings: first-child= 797.963311597 runs/s
median= 798.004987531 runs/s, stdev= 2.53014907337 runs/s, min= 789.14919852 runs/s, max= 801.001251564 runs/s

  • Bindings/first-child.html: Added.
4:35 AM Changeset in webkit [117429] by kkristof@inf.u-szeged.hu
  • 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Test expectation update.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-05-17

  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:After 117310.
  • platform/qt/fast/repaint/float-overflow-expected.png:
  • platform/qt/fast/repaint/float-overflow-expected.txt: After r117339.
  • platform/qt/fast/repaint/float-overflow-right-expected.png:
  • platform/qt/fast/repaint/float-overflow-right-expected.txt: After r117339.
4:14 AM Changeset in webkit [117428] by gyuyoung.kim@samsung.com
  • 41 edits in trunk

Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
​https://bugs.webkit.org/show_bug.cgi?id=86704

Reviewed by Eric Seidel.

.:

  • Source/autotools/symbols.filter: Add setDomainRelaxationForbiddenForURLScheme symbol filter.

Source/WebCore:

Add setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way by means of the InternalSettings interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

  • testing/InternalSettings.cpp:

(WebCore):
(WebCore::InternalSettings::setDomainRelaxationForbiddenForURLScheme):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/gtk:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:
  • WebView.h:

(WebView):

Source/WebKit2:

  • win/WebKit2.def: Add setDomainRelaxationForbiddenForURLScheme symbol filter.

Tools:

Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Invoke setDomainRelaxationForbiddenForURLScheme functions from internalSettings, because it is able to work in the
cross-port way via the InternalSettings interface.

  • http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
4:09 AM Changeset in webkit [117427] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing reftests.

  • platform/qt/Skipped:
4:06 AM Changeset in webkit [117426] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
​https://bugs.webkit.org/show_bug.cgi?id=84835

Patch by Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2012-05-17
Reviewed by Eric Seidel.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp: Call appropriate callbacks for editing actions.

(WebCore::EditorClientEfl::shouldDeleteRange):
(WebCore::EditorClientEfl::shouldBeginEditing):
(WebCore::EditorClientEfl::shouldEndEditing):
(WebCore::EditorClientEfl::shouldInsertText):
(WebCore::EditorClientEfl::shouldChangeSelectedRange):
(WebCore::EditorClientEfl::shouldApplyStyle):
(WebCore::EditorClientEfl::didBeginEditing):
(WebCore::EditorClientEfl::didEndEditing):
(WebCore::EditorClientEfl::shouldInsertNode):

  • WebCoreSupport/EditorClientEfl.h: Add structures needed by editing callbacks.

(Ewk_Should_Insert_Node_Event):
(Ewk_Should_Insert_Text_Event):
(Ewk_Should_Change_Selected_Range_Event):
(Ewk_Should_Apply_Style_Event):

Tools:

Added editing callbacks implementation.

  • DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.

(DumpRenderTreeChrome::createView):

  • DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.

(dumpPath):
(dumpRange):
(insertActionString):
(selectionAffinityString):
(shouldBeginEditing):
(shouldEndEditing):
(shouldInsertNode):
(shouldInsertText):
(shouldDeleteRange):
(shouldChangeSelectedRange):
(shouldApplyStyle):
(editingBegan):
(userChangedContents):
(editingEnded):
(selectionChanged):
(connectEditingCallbacks):

  • DumpRenderTree/efl/EditingCallbacks.h: Added.
4:03 AM Changeset in webkit [117425] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

3:42 AM Changeset in webkit [117424] by noel.gordon@gmail.com
  • 427 edits
    99 copies
    37 adds
    131 deletes in branches/chromium/1132/LayoutTests

Merge 116839 - Optimise and update test expectations after r116636

Unreviewed test expectations update.

  • fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
  • fast/block/float/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/014-expected.txt.
  • fast/images/gray-scale-jpeg-with-color-profile-expected.txt:
  • fast/repaint/backgroundSizeRepaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/backgroundSizeRepaint-expected.txt.
  • fast/repaint/clipped-relative-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clipped-relative-expected.txt.
  • fast/repaint/selected-replaced-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/selected-replaced-expected.txt.
  • fast/replaced/absolute-image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/absolute-image-sizing-expected.txt.
  • fast/replaced/image-onload-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-onload-expected.txt.
  • fast/replaced/image-sizing-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/image-sizing-expected.txt.
  • fast/replaced/width100percent-image-expected.txt: Renamed from LayoutTests/platform/efl/fast/replaced/width100percent-image-expected.txt.
  • fast/writing-mode/background-horizontal-bt-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-horizontal-bt-expected.txt.
  • fast/writing-mode/background-vertical-lr-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-lr-expected.txt.
  • fast/writing-mode/background-vertical-rl-expected.txt: Renamed from LayoutTests/platform/efl/fast/writing-mode/background-vertical-rl-expected.txt.
  • platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize20-expected.png: Added. [ChangeLog snipped: too many to list in drover and gcl]

TBR=​noel.gordon@gmail.com

3:16 AM Changeset in webkit [117423] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed attempt to fix a Windows build breakage.

  • public/WebIntent.h:

(WebIntent):

3:09 AM Changeset in webkit [117422] by haraken@chromium.org
  • 2 edits in trunk/Tools

[Performance test] In perftest.py, do not include 'description' in 'results'
​https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Csaba Osztrogoná.

'results' in perftest.py should not include any data that is not expected
by the perf bot server. We do not need to send 'description' to the perf bot
server since 'description' is always the same.

Thus this patch just removes 'description' from 'results'.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest.run):

2:55 AM Changeset in webkit [117421] by shinyak@chromium.org
  • 7 edits in trunk

ShadowRoot.selection should be ShadowRoot.getSelection()
​https://bugs.webkit.org/show_bug.cgi?id=86598

Reviewed by Hajime Morita.

Source/WebCore:

In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the implementation.

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:

LayoutTests:

In the latest spec, ShadowRoot.selection is changed to ShadowRoot.getSelection().
So update the tests.

  • editing/shadow/selection-of-orphan-shadowroot.html:
  • editing/shadow/selection-of-shadowroot.html: Removed unnecessary code to

call ShadowRoot.selection by using ShadowRoot.getSelection(). Now ShadowRoot.getSelection()
can be called directly.

2:30 AM Changeset in webkit [117420] by shinyak@chromium.org
  • 13 edits
    2 deletes in trunk/Source/WebCore

[Refactoring] Remove TreeScopeAdjuster
​https://bugs.webkit.org/show_bug.cgi?id=86599

Reviewed by Hajime Morita.

It seems the right place of the method of TreeScopeAdjuster are in VisibleSelection
and TreeScope. So we can remove TreeScopeAdjuster.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::ancestorInThisScope):
(WebCore):

  • dom/TreeScope.h:

(TreeScope):

  • dom/TreeScopeAdjuster.cpp: Removed.
  • dom/TreeScopeAdjuster.h: Removed.
  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustPositionBefore):
(WebCore):
(WebCore::VisibleSelection::adjustPositionAfter):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

  • editing/VisibleSelection.h:

(VisibleSelection):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::shadowAdjustedNode):
(WebCore::DOMSelection::shadowAdjustedOffset):

2:24 AM Changeset in webkit [117419] by mnaganov@chromium.org
  • 3 edits
    6 copies in branches/chromium/1132

Merge 117307 - Avoid jumpscroll when entering new text in a multi-line editor.
​https://bugs.webkit.org/show_bug.cgi?id=82875

Reviewed by Ryosuke Niwa

Scroll caret to the edge of the viewport in case if a line break or a paragraph
separator is inserted at the end of a multi-line editor. This avoids
undesirable jumpscroll in cases when there is content under the editor.

Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html

editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html

  • editing/Editor.cpp:

(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/Editor.h:

(Editor):

  • editing/input/resources/reveal-utilities.js:

(performJumpAtTheEdgeTest):

  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added.
  • editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added.
  • editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added.

TBR=​mnaganov@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10382217

2:12 AM Changeset in webkit [117418] by zherczeg@webkit.org
  • 10 edits
    1 delete in trunk/Source/WebCore

NEON intrinsic should be used with arithmetic mode of composite filter
​https://bugs.webkit.org/show_bug.cgi?id=86622

Reviewed by Nikolas Zimmermann.

Rewrite hand written assembly code to increase portability and readibility
of the code. Remove the unnecessary FECompositeArithmeticNEON.cpp from the
project

Existing tests cover this issue.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore):
(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Removed.
  • platform/graphics/filters/arm/FECompositeArithmeticNEON.h:

(WebCore):
(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):

2:03 AM Changeset in webkit [117417] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

showNodePath will be useful for debugging purpose.
​https://bugs.webkit.org/show_bug.cgi?id=86450

This patch implements showNodePath, which outputs node information in
a xpath-like format, e.g. /HTML/BODY/DIV[@id="test" and position()=0]/P[0]

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-05-17
Reviewed by Hajime Morita.

No new tests, just adding debugging interface.

  • dom/Node.cpp:

(WebCore::Node::showNodePathForThis):
(WebCore):
(showNodePath):

  • dom/Node.h:

(Node):

1:58 AM Changeset in webkit [117416] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking tests which need rebaselining after r117412.

  • platform/chromium/test_expectations.txt:
1:48 AM Changeset in webkit [117415] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking acid3-test-77.html as fail.

  • platform/chromium/test_expectations.txt:
1:21 AM Changeset in webkit [117414] by g.czajkowski@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Do not check NULL pointer allocated by new.
​https://bugs.webkit.org/show_bug.cgi?id=86610

Reviewed by Ryosuke Niwa.

WebKit-Efl doesn't check pointers that are initialized by new.
Those checks are not needed because new operator doesn't return NULL.
Only an overloaded version of new returns NULL pointer.

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_entry_new):

  • ewk/ewk_view.cpp:

(_ewk_view_core_frame_new):

1:18 AM Changeset in webkit [117413] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r116331): RSS Headlines/links are missing (-webkit-box-flex broken?)
​https://bugs.webkit.org/show_bug.cgi?id=85991

Source/WebCore:

Fix for regression failures on deprecated flex box test cases.

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.

Test: fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Fix to use intrinsic width when the fixed width:0 , for deprecated flex boxes.

LayoutTests:

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-05-17
Reviewed by Eric Seidel.

  • fast/css/deprecated-flex-box-zero-width-intrinsic-max-width-expected.txt: Added.
  • fast/css/deprecated-flex-box-zero-width-intrinsic-max-width.html: Added.
1:14 AM Changeset in webkit [117412] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

CSS3 Multicolumn: Content in normal flow extending into column gaps should be clipped at middle of column-gap
​https://bugs.webkit.org/show_bug.cgi?id=86441

Patch by Uday Kiran <​udaykiran@motorola.com> on 2012-05-17
Reviewed by Eric Seidel.

Source/WebCore:

Content in the normal flow that extends into column gaps (e.g., long words or images)
is clipped in the middle of the column gap.
​http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements

Test: fast/multicol/overflow-into-columngap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnContents):

LayoutTests:

Test for content in normal flow that extends into column gaps.
​http://www.w3.org/TR/css3-multicol/#overflow-inside-multicol-elements

  • fast/multicol/overflow-into-columngap-expected.html: Added.
  • fast/multicol/overflow-into-columngap.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
1:06 AM Changeset in webkit [117411] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Worker] Web Worker lacks test to check the name attribute of SharedWorker
​https://bugs.webkit.org/show_bug.cgi?id=86714

Patch by Li Yin <​li.yin@intel.com> on 2012-05-17
Reviewed by Kentaro Hara.

Spec: ​http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope
The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.
So we should have a test to check it, there is a related test "fast/worker/shared-worker-name.html" already,
but it doesn't cover this.

  • fast/workers/resources/shared-worker-common.js:

(handleMessage):

  • fast/workers/resources/shared-worker-name.js:

(test11.worker.port.onmessage):
(test11):

  • fast/workers/shared-worker-name-expected.txt:
12:46 AM Changeset in webkit [117410] by haraken@chromium.org
  • 2 edits in trunk/Tools

[Performance test] Always fill resultsdescription in perftest.py
​https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Ryosuke Niwa.

This is a follow-up patch for r117397 to fix perf bot failures.
This patch fills resultsdescription always.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.run):

12:30 AM Changeset in webkit [117409] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=85879

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-17
Reviewed by Noam Rosenthal.

Source/WebKit/efl:

_ewk_frame_smart_del() is considering now that the frame can be present in cache.
loader()->detachFromParent() is only applied for the main frame.
loader()->cancelAndClear() is not used anymore.

  • ewk/ewk_frame.cpp:

(_ewk_frame_smart_del):

LayoutTests:

  • platform/efl/test_expectations.txt: Removed fast/frames/frame-crash-with-page-cache.html.
12:27 AM Changeset in webkit [117408] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking input-appearance-range.html as fail.

  • platform/chromium/test_expectations.txt:
12:10 AM Changeset in webkit [117407] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking backgr_position-table.html and some others as fail.

  • platform/chromium/test_expectations.txt:
12:07 AM Changeset in webkit [117406] by Csaba Osztrogonác
  • 18 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening after r117339.
​https://bugs.webkit.org/show_bug.cgi?id=84167

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/selection/iframe-expected.png:
  • platform/qt/editing/selection/iframe-expected.txt:
  • platform/qt/editing/selection/inline-table-expected.png:
  • platform/qt/editing/selection/inline-table-expected.txt:
  • platform/qt/editing/selection/table-caret-3-expected.png:
  • platform/qt/editing/selection/table-caret-3-expected.txt:
  • platform/qt/fast/css-generated-content/inline-display-types-expected.png:
  • platform/qt/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
  • platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
  • platform/qt/fast/inline-block/001-expected.png:
  • platform/qt/fast/inline-block/001-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.