Timeline



May 20, 2012:

11:39 PM Changeset in webkit [117735] by Carlos Garcia Campos
  • 16 edits in trunk

[GTK] Add GCancellable parameter to all methods using gio async pattern
​https://bugs.webkit.org/show_bug.cgi?id=86843

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add a private macro WEBKIT_DEFINE_ASYNC_DATA_STRUCT() to make it
easier to define temporary structs used in async operations.

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(GetAcceptPolicyAsyncData):
(webkitCookieManagerGetAcceptPolicyCallback):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_get_accept_policy_finish):
(GetDomainsWithCookiesAsyncData):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_get_domains_with_cookies_finish):

  • UIProcess/API/gtk/WebKitCookieManager.h:
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_plugins):

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(ResourceGetDataAsyncData):
(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):

  • UIProcess/API/gtk/WebKitWebResource.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(ValidateEditingCommandAsyncData):
(didValidateCommand):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_can_execute_editing_command_finish):
(RunJavaScriptAsyncData::~RunJavaScriptAsyncData):
(RunJavaScriptAsyncData):
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_finish):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/tests/TestCookieManager.cpp:
  • UIProcess/API/gtk/tests/TestResources.cpp:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
  • UIProcess/API/gtk/tests/TestWebViewEditor.cpp:
  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::runJavaScriptAndWaitUntilFinished):

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(browser_window_load_uri):

11:30 PM Changeset in webkit [117734] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8] Pass Isolate to throwError()s in V8 custom bindings (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=86981

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in V8 custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallback):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageSetter):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback):
(WebCore::V8WebKitMutationObserver::observeCallback):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):
(WebCore::V8WebSocket::sendCallback):
(WebCore::V8WebSocket::closeCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore::V8XMLHttpRequest::sendCallback):

11:28 PM Changeset in webkit [117733] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

[V8] Pass Isolate to throwError()s in V8 custom bindings (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=86980

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in V8 custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallback):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallback):
(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertySetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):

  • bindings/v8/custom/V8DirectoryEntryCustom.cpp:

(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

11:20 PM Changeset in webkit [117732] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Pass Isolate to V8NPObject::npObjectGetProperty() and V8NPObject::npObjectSetProperty()
​https://bugs.webkit.org/show_bug.cgi?id=86979

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to V8NPObject::npObjectGetProperty()
and V8NPObject::npObjectSetProperty().

No tests. No change in behavior.

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectGetProperty):
(WebCore::npObjectNamedPropertyGetter):
(WebCore::npObjectIndexedPropertyGetter):
(WebCore::npObjectGetNamedProperty):
(WebCore::npObjectGetIndexedProperty):
(WebCore::npObjectQueryProperty):
(WebCore::npObjectSetProperty):
(WebCore::npObjectNamedPropertySetter):
(WebCore::npObjectIndexedPropertySetter):
(WebCore::npObjectSetNamedProperty):
(WebCore::npObjectSetIndexedProperty):

  • bindings/v8/V8NPObject.h:

(WebCore):

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:

(WebCore::npObjectNamedGetter):
(WebCore::npObjectNamedSetter):
(WebCore::npObjectIndexedGetter):
(WebCore::npObjectIndexedSetter):

11:11 PM Changeset in webkit [117731] by rniwa@webkit.org
  • 28 edits
    4 adds in trunk

Using createContextualFragment to insert a <script> does not cause the script to execute
​https://bugs.webkit.org/show_bug.cgi?id=12234

Reviewed by Adam Barth.

Source/WebCore:

Renamed FragmentScriptingAllowed and FragmentScriptingNotAllowed to DisallowScriptingContent
and AllowScriptingContent as these two flags are used in code for non-fragment cases and they
indicate whether attributes and elements that can invoke scripting should be removed or not.

To fix the bug, added a new value AllowScriptingContentAndDoNotMarkAlreadyStarted unset
already-started and parser-inserted flags [1] on script elements in addition to allowing
scripting contents.

While the HTML5 specification and the DOM Parsing and Serialization specification [2] state that
we should set these flags in the parser and later unset them, doing so would require traversing
the parsed fragment to find relevant script elements. We short circuit this logic by simply not
setting parser-inserted and already-started flags in createContextualFragment.

[1] ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#already-started
[2] ​http://html5.org/specs/dom-parsing.html#dom-range-createcontextualfragment

Tests: fast/dom/Range/create-contextual-fragment-script-not-ran.html

fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html

  • dom/DocumentFragment.h:

(DocumentFragment):

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNS):

  • dom/Element.h:

(Element):

  • dom/FragmentScriptingPermission.h:
  • dom/Range.cpp:

(WebCore::Range::createContextualFragment): Removed FragmentScriptingPermission from the argument
list since no one uses it. Always use AllowScriptingContentAndDoNotMarkAlreadyStarted instead.

  • dom/Range.h:
  • editing/markup.h:
  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertScriptElement): Pass false to both parserInserted and
alreadyStarted when the scripting permission is AllowScriptingContentAndDoNotMarkAlreadyStarted.
Also call parserSetAttributes when the scripting permission is either AllowScriptingContent or
AllowScriptingContentAndDoNotMarkAlreadyStarted.

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::processEndTag):

  • html/parser/HTMLTreeBuilder.h:

(FragmentParsingContext):

  • platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asFragment):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragment):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asFragment):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/parser/NewXMLDocumentParser.h:

(NewXMLDocumentParser):

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parseEndElement):

Source/WebKit/mac:

Renamed FragmentScriptingNotAllowed to DisallowScriptingContent.

  • WebView/WebFrame.mm:

(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):

LayoutTests:

Added regressions tests to ensure createContextualFragment doesn't execute script elements
immediately as they are parsed and it doesn't mark those script elements as already started.

The behavior of innerHTML is tested elsewhere and this patch does not affect its behavior.

  • fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Added.
  • fast/dom/Range/create-contextual-fragment-script-not-ran.html: Added.
  • fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Added.
  • fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Added.
10:53 PM Changeset in webkit [117730] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to V8Utilities::createFunctionCallback()
​https://bugs.webkit.org/show_bug.cgi?id=86978

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to V8Utilities::createFunctionCallback().

No tests. No change in behavior.

  • bindings/v8/V8Utilities.cpp:

(WebCore::throwTypeMismatchException):

  • bindings/v8/V8Utilities.h:

(WebCore):
(WebCore::createFunctionOnlyCallback):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):

  • bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionCallback):

10:42 PM Changeset in webkit [117729] by msaboff@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

JSGlobalData ScratchBuffers Are Not Visited During Garbage Collection
​https://bugs.webkit.org/show_bug.cgi?id=86553

Reviewed by Gavin Barraclough.

Scratch buffers can contain the only reference to live objects.
Therefore visit scratch buffer contents as conservative roots.
Changed the scratch buffers to be a struct with an "active"
length and the actual buffer. The users of the scratch
buffer emit code where needed to set and clear the active
length as appropriate. During marking, the active count is
used for conservative marking.

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::gatherConservativeRoots):

  • runtime/JSGlobalData.h:

(JSC::ScratchBuffer::ScratchBuffer):
(ScratchBuffer):
(JSC::ScratchBuffer::allocationSize):
(JSC::ScratchBuffer::setActiveLength):
(JSC::ScratchBuffer::activeLength):
(JSC::ScratchBuffer::activeLengthPtr):
(JSC::ScratchBuffer::dataBuffer):
(JSGlobalData):
(JSC::JSGlobalData::scratchBufferForSize):

10:42 PM Changeset in webkit [117728] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass Isolate to throwError()s in bindings/v8/*.{h,cpp}
​https://bugs.webkit.org/show_bug.cgi?id=86977

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in bindings/v8/*.{h,cpp}
except for a couple of non-trivial cases. I'll upload a follow-up patch
for the non-trivial cases.

No tests. No change in behavior.

  • bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::OnSleepDetected):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectPropertyEnumerator):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::checkNewLegal):

10:16 PM Changeset in webkit [117727] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Delete obsolete Chromium WebKit API method
​https://bugs.webkit.org/show_bug.cgi?id=86933

Implementation was previously removed in r17512 and callers are updated.

Reviewed by Adam Barth.

  • public/WebIDBIndex.h: Delete storeName()

(WebKit::WebIDBIndex::name):

10:05 PM Changeset in webkit [117726] by keishi@webkit.org
  • 4 edits in trunk

[Chromium] Enable datalist for input type email
​https://bugs.webkit.org/show_bug.cgi?id=85356

Reviewed by Kent Tamura.

Source/WebCore:

No new tests. Covered in fast/forms/datalist/input-list.html

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI):

LayoutTests:

  • platform/chromium/fast/forms/datalist/input-list-expected.txt:
10:03 PM Changeset in webkit [117725] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to throwError()s in CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=86976

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to throwError()s in CodeGeneratorV8.pm.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateVoidCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod5Callback):
(WebCore::V8TestObj::constructorCallback):

7:44 PM Changeset in webkit [117724] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Implement the Screen functions to get DPI.
​https://bugs.webkit.org/show_bug.cgi?id=86967

Reviewed by Antonio Gomes.

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):

7:41 PM Changeset in webkit [117723] by shinyak@chromium.org
  • 20 edits in trunk/Source/WebCore

[Refactoring] Node::shadowHost() and Node::setShadowHost() can be moved to ShadowRoot.
​https://bugs.webkit.org/show_bug.cgi?id=86585

Reviewed by Hajime Morita.

Since Node::shadowHost() and Node::setShadowHost() are valid only if Node is ShadowRoot,
they should be moved to ShadowRoot.

However, Node::setParent cannot be called from ShadowRoot, we add Node::setParentOrHostNode
to call it as Node::parentOrHostNode() calls Node::parent(). Node::setParent() is now private.
We also add SVGElementInstance::setParentOrHostNode() to share ContainerNodeAlgorithm.

No new tests, no change in behavior.

  • dom/Attr.cpp:

(WebCore::Attr::createTextChild):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBeforeCommon):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):

  • dom/ContainerNodeAlgorithms.h:

(WebCore::appendChildToContainer):
(WebCore::Private::addChildNodesToDeletionQueue):

  • dom/ElementShadow.cpp:

(WebCore::validateShadowRoot):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules):
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::determineDispatchBehavior):

  • dom/EventDispatcher.h:

(WebCore):
(EventDispatcher):

  • dom/Node.cpp:

(WebCore::Node::parentOrHostElement):

  • dom/Node.h:

(Node):
(WebCore::Node::setParentOrHostNode):
(WebCore):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::host):
(WebCore):
(WebCore::ShadowRoot::setHost):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::focusedNode):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::matches):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::instanceAssociatedWithShadowTreeElement):
(WebCore::EventHandler::dispatchMouseEvent):

  • page/FocusController.cpp:

(WebCore::FocusScope::owner):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hasLineIfEmpty):

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::setParentOrHostNode):
(SVGElementInstance):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGShadowText::willRecalcTextStyle):

7:25 PM Changeset in webkit [117722] by staikos@webkit.org
  • 2 edits in trunk

[BlackBerry] Define navigator.vendor for BlackBerry.
​https://bugs.webkit.org/show_bug.cgi?id=86975

Reviewed by Antonio Gomes.

  • Source/cmake/OptionsBlackBerry.cmake:
6:47 PM Changeset in webkit [117721] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Unsupported commands should have queryCommandValue() = "", not false
​https://bugs.webkit.org/show_bug.cgi?id=86964

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-05-20
Reviewed by Ryosuke Niwa.

queryCommandValue for unsupported commands should return empty string.
The specification related to this can be located at ​http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#methods-to-query-and-execute-commands

Source/WebCore:

Test: editing/execCommand/queryCommandValue-unsupported-commands.html

  • dom/Document.idl:

LayoutTests:

  • editing/execCommand/queryCommandValue-unsupported-commands-expected.txt: Added.
  • editing/execCommand/queryCommandValue-unsupported-commands.html: Added.
  • editing/execCommand/use-css-expected.txt:
  • editing/execCommand/use-css.html:
6:25 PM Changeset in webkit [117720] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/efl

[EFL] ewk_view navigation_policy_decision() input parameters should be extended
​https://bugs.webkit.org/show_bug.cgi?id=85048

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-20
Reviewed by Antonio Gomes.

Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType.
Extended ewk_view navigation_policy_decision() input parameters with new
navigationType parameter. This paramater gives more data for making a
navigation policy decision and also provides dumping necessary for many Layout
testcases.

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

  • ewk/ewk_frame.h:
  • ewk/ewk_view_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_navigation_policy_decision):

  • ewk/ewk_view.h:
6:01 PM Changeset in webkit [117719] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjIntSequenceAttr):
(WebCore::setJSTestObjShortSequenceAttr):
(WebCore::setJSTestObjLongSequenceAttr):
(WebCore::setJSTestObjLongLongSequenceAttr):
(WebCore::setJSTestObjUnsignedIntSequenceAttr):
(WebCore::setJSTestObjUnsignedShortSequenceAttr):
(WebCore::setJSTestObjUnsignedLongSequenceAttr):
(WebCore::setJSTestObjUnsignedLongLongSequenceAttr):
(WebCore::setJSTestObjFloatSequenceAttr):
(WebCore::setJSTestObjDoubleSequenceAttr):
(WebCore::setJSTestObjBooleanSequenceAttr):
(WebCore::setJSTestObjVoidSequenceAttr):
(WebCore::setJSTestObjDateSequenceAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

5:51 PM Changeset in webkit [117718] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

Use reinterpret_cast_ptr<> to fix an alignment warning.
​https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Rob Buis.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::error_exit):

5:51 PM Changeset in webkit [117717] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Fix expectation of

svg/hittest/svg-shapes-non-scale-stroke.html after r117713.

5:50 PM Changeset in webkit [117716] by commit-queue@webkit.org
  • 5 edits in trunk

Needs style recalculation by changing applyAuthorStyles dynamically
​https://bugs.webkit.org/show_bug.cgi?id=84251

Source/WebCore:

Modifying setApplyAuthorStyles to invoke owner()'s
setNeedsRedistributing if applyAuthorStyles changes.

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-05-20
Reviewed by Hajime Morita.

No new tests. Adding new tests to existing
fast/dom/shadow/shadow-root-applyAuthorStyles.html to test this
feature.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setApplyAuthorStyles):
If applyAuthorStyles changes, invoke owner's setNeedsRedistributing to
recalculate styles of the shadow root's child elements.

LayoutTests:

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-05-20
Reviewed by Hajime Morita.

  • fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html:
  • fast/dom/shadow/shadow-root-applyAuthorStyles.html:
4:32 PM Changeset in webkit [117715] by dbates@webkit.org
  • 4 edits
    1 add in trunk/Tools

svn-apply cannot apply patches to files that contain space
characters in their path
​https://bugs.webkit.org/show_bug.cgi?id=85742

Reviewed by Eric Seidel.

Fixes an issue where svn-apply cannot apply a patch to a file
if there is a space in its file path.

The regular expression we were using to fix up +++/--- lines
was too strict; it only matched file paths that contained non-
whitespace characters. Instead, it's sufficient to match file
paths whose characters aren't in the set {\t, \n, \r}.

  • Scripts/VCSUtils.pm:

(parseSvnDiffHeader):
(runCommand): Added.

  • Scripts/svn-apply:

(scmWillDeleteFile): Modified to call runCommand() so as to
handle querying git for a file whose path may contain a space
character.

  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Added test case "new file with spaces in its name".
  • Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: Added.
4:29 PM Changeset in webkit [117714] by dbates@webkit.org
  • 2 edits in trunk/Tools

svn-apply fails to apply a patch that moves files from directory A to A/B
​https://bugs.webkit.org/show_bug.cgi?id=86973

Reviewed by Eric Seidel.

Fixes an issue where svn-apply fails to apply a patch that moves files in a
directory A to some sub-directory B in A with a Git checkout of WebKit.

Currently, svn-apply only creates new directories along a file system path that
it hasn't already processed. That is, if svn-apply creates/traverses all the
intermediate directories along the path A/B then it will assume the directory A/B
exists for all subsequent requests to create sub-directories in A/B (e.g. A/B/C).
When moving a file F in directory A to directory A/B using a Git checkout, Git
may remove directory A if F is the last file in A. Therefore, svn-apply will fail
to create sub-directory B in A (since A no longer exists).

  • Scripts/svn-apply:

(addDirectoriesIfNeeded):

4:12 PM Changeset in webkit [117713] by pdr@google.com
  • 4 edits in trunk/LayoutTests

Skip failing hit testing tests
​https://bugs.webkit.org/show_bug.cgi?id=86971

Unreviewed, skipping tests.

  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/qt/Skipped:
2:35 PM Changeset in webkit [117712] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing test after r117709.

  • platform/efl/test_expectations.txt:
1:58 PM Changeset in webkit [117711] by pdr@google.com
  • 4 edits
    6 adds in trunk

Accumulate SVG animations into first contributing element
​https://bugs.webkit.org/show_bug.cgi?id=86385

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously we were accumulating animations into the first animation element when
there were multiple animations for a single element. This crashed if the first
animation ended first because the first animation was prematurely cleaned up.
This change accumulates animations into the first _contributing_ animation element.

Tests: svg/animations/multiple-animations-ending.html

svg/animations/svg-two-animate-elements-crash-expected.svg
svg/animations/svg-two-animate-elements-crash.svg

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/multiple-animations-ending-expected.txt: Added.
  • svg/animations/multiple-animations-ending.html: Added.
  • svg/animations/resources/multiple-animations-ending.svg: Added.
  • svg/animations/script-tests/multiple-animations-ending.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(sample9):
(sample10):
(sample11):
(sample12):
(sample13):
(sample14):
(sample15):
(sample16):
(sample17):
(sample18):
(sample19):
(sample20):
(sample21):
(sample22):
(sample23):
(executeTest):

  • svg/animations/svg-two-animate-elements-crash-expected.svg: Added.
  • svg/animations/svg-two-animate-elements-crash.svg: Added.
1:29 PM Changeset in webkit [117710] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Clean up no longer used files in DerivedSources.

12:49 PM Changeset in webkit [117709] by pdr@google.com
  • 9 edits
    2 adds in trunk

Fix hit testing on non-scaling strokes
​https://bugs.webkit.org/show_bug.cgi?id=82628

Reviewed by Nikolas Zimmermann.

Source/WebCore:

This change fixes hit testing on non-scaling strokes. It contains fixes for 3 bugs:
1) RenderSVGRect::shapeDependentStrokeContains was not falling back to shape-based hit testing.
2) m_strokeAndMarkerBoundingBox did not account for non-scaling strokes.
3) RenderSVGShape::shapeDependentStrokeContains did not have any support for non-scaling strokes.

This change also contains some refactoring/cleanup of the non-scale-stroke codepaths.

Test: svg/hittest/svg-shapes-non-scale-stroke.html

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::createShape):

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::shapeDependentStrokeContains):
(WebCore::RenderSVGShape::shapeDependentFillContains):
(WebCore::RenderSVGShape::nonScalingStrokePath):
(WebCore):
(WebCore::RenderSVGShape::setupNonScalingStrokeContext):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::strokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::inflateWithStrokeAndMarkerBounds):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::hasNonScalingStroke):
(RenderSVGShape):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • svg/custom/non-scaling-stroke-expected.txt:
  • svg/hittest/svg-shapes-non-scale-stroke-expected.txt: Added.
  • svg/hittest/svg-shapes-non-scale-stroke.html: Added.
12:10 PM Changeset in webkit [117708] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

[Chromium] Print layout test result on buildbot
​https://bugs.webkit.org/show_bug.cgi?id=86965

Reviewed by Eric Seidel.

  • Scripts/run-webkit-tests: Add chrome-bot to buildbot user list.

(runningOnBuildBot):

4:18 AM Changeset in webkit [117707] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Predicted types should know about arguments
​https://bugs.webkit.org/show_bug.cgi?id=85165

Reviewed by Oliver Hunt.

Merge r115604 from dfgopt.

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionToAbbreviatedString):
(JSC::predictionFromClassInfo):

  • bytecode/PredictedType.h:

(JSC):
(JSC::isMyArgumentsPrediction):
(JSC::isArgumentsPrediction):

3:00 AM Changeset in webkit [117706] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Bytecompiler should emit trivially fewer jumps in loops
​https://bugs.webkit.org/show_bug.cgi?id=85144

Reviewed by Oliver Hunt.

Merged r115587 from dfgopt.

1-2% across the board win.

  • bytecompiler/NodesCodegen.cpp:

(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):

May 19, 2012:

9:43 PM Changeset in webkit [117705] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Don't stop the build if a build system update check fails.

6:55 PM Changeset in webkit [117704] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Remove a couple files wx doesn't use from the build.

5:19 PM Changeset in webkit [117703] by aestes@apple.com
  • 5 edits in trunk/Source/WebKit2

Use USE_APPKIT and USE_SECURITY_FRAMEWORK in a few more places
​https://bugs.webkit.org/show_bug.cgi?id=86951

Reviewed by Dan Bernstein.

  • UIProcess/WebProcessProxy.messages.in: Change #if PLATFORM(MAC) to

the more specific #if USE(SECURITY_FRAMEWORK).

  • UIProcess/mac/WebPageProxyMac.mm: Wrap some uses of AppKit classes

with #if USE(APPKIT).

  • UIProcess/mac/WebPopupMenuProxyMac.h: Ditto.
  • UIProcess/mac/WebPopupMenuProxyMac.mm: Ditto.
4:52 PM FeatureFlags edited by rakuco@webkit.org
ENABLE(CSS_GRID_LAYOUT) has been removed in r117613. (diff)
4:51 PM AddingFeatures edited by rakuco@webkit.org
build-webkit does not contain the feature list anymore, it has been … (diff)
4:49 PM AddingFeatures edited by rakuco@webkit.org
Add the related CMake file to the list (diff)
4:36 PM Changeset in webkit [117702] by jsbell@chromium.org
  • 108 edits in trunk/LayoutTests

IndexedDB layout tests should make better use of test library functions
​https://bugs.webkit.org/show_bug.cgi?id=86932

Reviewed by Ojan Vafai.

Use functions like shouldBeEqualToString, shouldBeNull, evalAndExpectException
and so forth where possible.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-population-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/create-object-store-options.js:

(setVersionComplete):

  • storage/indexeddb/resources/createObjectStore-null-name.js:

(createAndPopulateObjectStore):

  • storage/indexeddb/resources/cursor-added-bug.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-continue-validity.js:

(deleteExisting):

  • storage/indexeddb/resources/cursor-continue.js:

(deleteExisting):

  • storage/indexeddb/resources/cursor-delete.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-inconsistency.js:

(setVersionSuccess):
(checkCursor):

  • storage/indexeddb/resources/cursor-index-delete.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-key-order.js:

(checkStore.curreq.onsuccess.getreq.onsuccess):
(checkStore.curreq.onsuccess):
(checkStore):

  • storage/indexeddb/resources/cursor-primary-key-order.js:

(checkStore.cursorRequest.onsuccess):
(checkStore):

  • storage/indexeddb/resources/cursor-skip-deleted.js:

(setVersionSuccess):

  • storage/indexeddb/resources/cursor-update.js:

(setVersionSuccess):
(basicUpdateCursor.request.onsuccess):
(basicUpdateCursor):
(autoIncrementUpdateCursor.request.onsuccess):
(autoIncrementUpdateCursor):
(keyPathUpdateCursor.request.onsuccess):
(keyPathUpdateCursor):
(keyCursor):

  • storage/indexeddb/resources/data-corruption.js:

(setVersionSuccess):
(doCheck):

  • storage/indexeddb/resources/database-basics.js:

(setVersionSuccess):
(createAnotherObjectStore):

  • storage/indexeddb/resources/database-quota.js:

(setVersionSuccess):

  • storage/indexeddb/resources/duplicates.js:

(deleteExisting):
(cursor1Continue):
(cursor1Continue2):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(last):

  • storage/indexeddb/resources/error-causes-abort-by-default.js:

(deleteExisting):

  • storage/indexeddb/resources/exception-in-event-aborts.js:

(deleteExisting):

  • storage/indexeddb/resources/factory-basics.js:

(test):

  • storage/indexeddb/resources/factory-cmp.js:

(test):
(testValidKeys):
(testIdenticalKeys):

  • storage/indexeddb/resources/factory-deletedatabase.js:

(deleteExisting):

  • storage/indexeddb/resources/get-keyrange.js:

(deleteExisting):

  • storage/indexeddb/resources/index-basics.js:

(deleteExisting):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last):

  • storage/indexeddb/resources/index-count.js:

(prepareDatabase):
(verifyCount.request.onsuccess):
(verifyCount):
(verifyCountWithRange.nextTest.request.onsuccess):
(verifyCountWithRange.nextTest):
(verifyCountWithRange):
(verifyCountWithKey.nextTest.request.onsuccess):
(verifyCountWithKey.nextTest):
(verifyCountWithKey):

  • storage/indexeddb/resources/index-cursor.js:

(deleteExisting):

  • storage/indexeddb/resources/index-multientry.js:

(prepareDatabase):
(verifyIndexes.request.onsuccess):
(verifyIndexes):

  • storage/indexeddb/resources/index-population.js:

(setVersion2Abort):

  • storage/indexeddb/resources/index-unique.js:

(deleteExisting):
(cursorSuccess):
(keyCursorSuccess):

  • storage/indexeddb/resources/key-type-array.js:

(test):

  • storage/indexeddb/resources/keyrange.js:

(test):

  • storage/indexeddb/resources/legacy-constants.js:

(populateStore):
(checkNext.request.onsuccess):
(checkNext):
(checkNextNoDuplicate.request.onsuccess):
(checkNextNoDuplicate):
(checkPrev.request.onsuccess):
(checkPrev):
(checkPrevNoDuplicate.request.onsuccess):
(checkPrevNoDuplicate):

  • storage/indexeddb/resources/mutating-cursor.js:

(setVersionSuccess):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(setVersionSuccess):
(testLongKeyPath.cursorRequest.onsuccess):
(testLongKeyPath):

  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):
(createIndex):
(createAnotherIndex):
(addDateSuccess):
(addAgainFailure):

  • storage/indexeddb/resources/objectstore-clear.js:

(deleteExisting):

  • storage/indexeddb/resources/objectstore-count.js:

(prepareDatabase):
(verifyCount.request.onsuccess):
(verifyCount):
(verifyCountWithRange.nextTest.request.onsuccess):
(verifyCountWithRange.nextTest):
(verifyCountWithRange):
(verifyCountWithKey.nextTest.request.onsuccess):
(verifyCountWithKey.nextTest):
(verifyCountWithKey):

  • storage/indexeddb/resources/objectstore-cursor.js:

(deleteExisting):

  • storage/indexeddb/resources/objectstore-removeobjectstore.js:

(deleteExisting):
(deleteObjectStore):

  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):
(setVersionSuccess):

  • storage/indexeddb/resources/opencursor-key.js:

(testObjectStore.request.onsuccess):
(testObjectStore):
(testIndex.request.onsuccess):
(testIndex):
(testIndexWithKey.request.onsuccess):
(testIndexWithKey):

  • storage/indexeddb/resources/prefetch-bugfix-108071.js:

(setVersionSuccess):

  • storage/indexeddb/resources/queued-commands.js:
  • storage/indexeddb/resources/request-event-propagation.js:

(deleteExisting):

  • storage/indexeddb/resources/setVersion-null.js:

(postSetVersion):

  • storage/indexeddb/resources/shared.js:

(evalAndExpectExceptionClass):

  • storage/indexeddb/resources/transaction-abort.js:

(deleteExisting):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(created):
(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(addRemoveIDBObjects):
(addRemoveAddIDBObjects):
(addIDBObjects):
(addIDBObjectsAndCommit):
(removeIDBObjects):
(setVersionSuccess):
(testDOMStringList):

  • storage/indexeddb/resources/transaction-event-propagation.js:

(deleteExisting):

  • storage/indexeddb/resources/transaction-rollback.js:

(addSuccess):
(getSuccess):

  • storage/indexeddb/resources/two-version-changes.js:

(test):

  • storage/indexeddb/resources/values-odd-types.js:

(openACursor.request.onsuccess):
(openACursor):

  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/values-odd-types-expected.txt:
4:03 PM Changeset in webkit [117701] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Remove a test that does not exist anymore from the skipped list, and
improve the comment for the other test at the block which relies on v8
stuff.

  • platform/efl/Skipped:
3:58 PM Changeset in webkit [117700] by aestes@apple.com
  • 8 edits in trunk/Source/WebKit2

2012-05-19 Andy Estes <​aestes@apple.com>

Fix more build errors found when disabling ENABLE_DRAG_SUPPORT

Rubber stamped by Jon Honeycutt.

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/WebPageProxy.cpp: (WebKit):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit):
  • WebProcess/WebPage/WebPage.h: (WebPage):
  • WebProcess/WebPage/WebPage.messages.in:
3:51 PM Changeset in webkit [117699] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Move skipped tests which depend on a showModalDialog()
implementation from Skipped to test_expectations.txt to have all
of them grouped together.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
1:52 PM Changeset in webkit [117698] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r108181): corruption after scrolling
​https://bugs.webkit.org/show_bug.cgi?id=86934
<rdar://problem/11487337>

Reviewed by Dan Bernstein.

Use the flipped Y coordinate when resetting the scrolled rect.

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):

1:48 PM Changeset in webkit [117697] by eae@chromium.org
  • 11 edits in trunk/Source/WebCore

Simplify RenderOverflow by using Rects
​https://bugs.webkit.org/show_bug.cgi?id=86894

Reviewed by Eric Seidel.

Simplify the RenderOverflow class and the uses of it by storing the
overflow values in rects and using the rects instead of the individual
values where it makes sense.

No new tests, no change in functionality.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustPageHeightDeprecated):
Change to use layoutOverflowRect().maxX() and replace C style casts with
C++ style to comply with style guide.

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalTopVisualOverflow):
(WebCore::InlineFlowBox::logicalBottomVisualOverflow):
Change methods to use layoutOverflowRect() and visualOverflowRect().

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
Change methods to use visualOverflowRect().

(WebCore::RenderBox::clearLayoutOverflow):
Use setLayoutOverflow instead of resetLayoutOverflow (which has been
removed as it did exactly the same thing as the set method).

  • rendering/RenderBox.h:

(WebCore::RenderBox::maxLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
Remove minYLayoutOverflow, maxYLayoutOverflow, minXLayoutOverflow and
maxXLayoutOverflow and update the remaining methods to use
layoutOverflowRect().

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Change to use layoutOverflowRect().

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::layoutOverflowRect):
(WebCore::RenderOverflow::visualOverflowRect):
(RenderOverflow):
(WebCore::RenderOverflow::setMinYLayoutOverflow):
(WebCore::RenderOverflow::setMaxYLayoutOverflow):
(WebCore::RenderOverflow::setMinXLayoutOverflow):
(WebCore::RenderOverflow::setMaxXLayoutOverflow):
(WebCore::RenderOverflow::setMinYVisualOverflow):
(WebCore::RenderOverflow::setMaxYVisualOverflow):
(WebCore::RenderOverflow::setMinXVisualOverflow):
(WebCore::RenderOverflow::setMaxXVisualOverflow):
(WebCore):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
Change RenderOverflow to use two rects instead of two sets of four
values. Remove [min|max][Layout|Visual]Overflow getters and change the
layoutOverflowRect and visualOverflowRect methods to return the rects.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
Change to use visualOverflowRect().

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
Change to use visualOverflowRect().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
Change to use visualOverflowRect().

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
Change to use layoutOverflowRect().

1:41 PM Changeset in webkit [117696] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove bbox caching from SVGPathElement
​https://bugs.webkit.org/show_bug.cgi?id=86233

Reviewed by Nikolas Zimmermann.

Remove caching of path bounding box, since SVGLocatable::getBBox is not used much at all.
This saves 200k of memory for worldcup.svg on 64-bit machine.

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):

  • svg/SVGPathElement.h:

(SVGPathElement):

12:29 PM Changeset in webkit [117695] by aestes@apple.com
  • 18 edits in trunk/Source

Fix build errors found when disabling ENABLE_DRAG_SUPPORT
​https://bugs.webkit.org/show_bug.cgi?id=86947

Reviewed by Jon Honeycutt.

Source/WebCore:

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseMoveEventToSubframe):

  • platform/mac/ClipboardMac.mm:

(WebCore):

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:
  • WebView/WebFrame.mm:
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:

(-[WebFrameView _setDocumentView:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView acceptsFirstMouse:]):
(-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
(matchesExtensionOrEquivalent):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView moveDragCaretToPoint:]):
(-[WebView removeDragCaret]):

Source/WebKit2:

  • UIProcess/API/mac/WKView.mm:

(createSandboxExtensionsForFileUpload):
(-[WKView performDragOperation:]):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

11:25 AM Changeset in webkit [117694] by commit-queue@webkit.org
  • 7 edits in trunk

The order of CSS properties is wrong in background shorthand
​https://bugs.webkit.org/show_bug.cgi?id=86152

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-05-19
Reviewed by Ryosuke Niwa.

Corrected the order of properties returned in StylePropertySet::getPropertyValue for background shorthand property to match the specification
​http://www.w3.org/TR/css3-background/#background.

Source/WebCore:

  • css/StylePropertyShorthand.cpp:

(WebCore::backgroundShorthand):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
  • fast/dom/background-shorthand-csstext-expected.txt:
  • fast/dom/background-shorthand-csstext.html:
11:12 AM Changeset in webkit [117693] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, add test expectations for further tests that
fail intermittently with an image diff due to repainting problems.

  • platform/gtk/test_expectations.txt:
10:01 AM Changeset in webkit [117692] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Plug-in process should only be enabled if Netscape plug-in API is enabled
​https://bugs.webkit.org/show_bug.cgi?id=86945

Reviewed by Dan Bernstein.

  • config.h: Only define ENABLE_PLUGIN_PROCESS if ENABLE_NETSCAPE_PLUGIN_API is true.
9:29 AM Changeset in webkit [117691] by commit-queue@webkit.org
  • 1 edit
    14 adds in trunk/LayoutTests

[EFL] More rebaselining needed after r117672
​https://bugs.webkit.org/show_bug.cgi?id=86944

Unreviewed EFL gardening. Add missing EFL expectations for several
CSS3 and forms tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-19

  • platform/efl/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-24-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-68-expected.txt: Added.
  • platform/efl/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Added.
  • platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-24-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-68-expected.txt: Added.
  • platform/efl/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/efl/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/efl/fast/forms/textfield-outline-expected.txt: Added.
6:58 AM Changeset in webkit [117690] by commit-queue@webkit.org
  • 152 edits in trunk/LayoutTests

[EFL] Massive rebaselining needed after r117672
​https://bugs.webkit.org/show_bug.cgi?id=86940

Unreviewed EFL gardening.

Rebaseline is needed for a lot of tests after r117672.
In many tests, contents in input element are shifted to the start
(left in LTR and right in RTL) by 1px, and widths of input
elements are shrunk by 2px.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-19

  • platform/efl/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/efl/fast/css/input-search-padding-expected.png:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/line-height-expected.png:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.png:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/dom/isindex-001-expected.png:
  • platform/efl/fast/dom/isindex-001-expected.txt:
  • platform/efl/fast/dom/isindex-002-expected.png:
  • platform/efl/fast/dom/isindex-002-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.png:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/forms/basic-inputs-expected.png:
  • platform/efl/fast/forms/basic-inputs-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.png:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/encoding-test-expected.png:
  • platform/efl/fast/forms/encoding-test-expected.txt:
  • platform/efl/fast/forms/fieldset-align-expected.png:
  • platform/efl/fast/forms/fieldset-align-expected.txt:
  • platform/efl/fast/forms/floating-textfield-relayout-expected.png:
  • platform/efl/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/efl/fast/forms/input-align-expected.png:
  • platform/efl/fast/forms/input-align-expected.txt:
  • platform/efl/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/efl/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/efl/fast/forms/input-appearance-focus-expected.png:
  • platform/efl/fast/forms/input-appearance-focus-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/efl/fast/forms/input-appearance-selection-expected.png:
  • platform/efl/fast/forms/input-appearance-selection-expected.txt:
  • platform/efl/fast/forms/input-appearance-visibility-expected.png:
  • platform/efl/fast/forms/input-appearance-visibility-expected.txt:
  • platform/efl/fast/forms/input-appearance-width-expected.png:
  • platform/efl/fast/forms/input-appearance-width-expected.txt:
  • platform/efl/fast/forms/input-disabled-color-expected.png:
  • platform/efl/fast/forms/input-disabled-color-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-field-text-truncated-expected.png:
  • platform/efl/fast/forms/input-field-text-truncated-expected.txt:
  • platform/efl/fast/forms/input-readonly-dimmed-expected.png:
  • platform/efl/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/efl/fast/forms/input-readonly-empty-expected.png:
  • platform/efl/fast/forms/input-readonly-empty-expected.txt:
  • platform/efl/fast/forms/input-spaces-expected.png:
  • platform/efl/fast/forms/input-spaces-expected.txt:
  • platform/efl/fast/forms/input-table-expected.png:
  • platform/efl/fast/forms/input-table-expected.txt:
  • platform/efl/fast/forms/input-text-click-inside-expected.png:
  • platform/efl/fast/forms/input-text-click-inside-expected.txt:
  • platform/efl/fast/forms/input-text-double-click-expected.png:
  • platform/efl/fast/forms/input-text-double-click-expected.txt:
  • platform/efl/fast/forms/input-text-option-delete-expected.png:
  • platform/efl/fast/forms/input-text-option-delete-expected.txt:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/efl/fast/forms/input-text-word-wrap-expected.png:
  • platform/efl/fast/forms/input-text-word-wrap-expected.txt:
  • platform/efl/fast/forms/input-type-text-min-width-expected.png:
  • platform/efl/fast/forms/input-type-text-min-width-expected.txt:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/forms/input-width-expected.png:
  • platform/efl/fast/forms/input-width-expected.txt:
  • platform/efl/fast/forms/minWidthPercent-expected.png:
  • platform/efl/fast/forms/minWidthPercent-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/forms/search-rtl-expected.png:
  • platform/efl/fast/forms/search-rtl-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.png:
  • platform/efl/fast/forms/search-styled-expected.txt:
  • platform/efl/fast/forms/search-vertical-alignment-expected.png:
  • platform/efl/fast/forms/search-vertical-alignment-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.png:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.png:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/efl/fast/forms/text-style-color-expected.png:
  • platform/efl/fast/forms/text-style-color-expected.txt:
  • platform/efl/fast/forms/textfield-focus-ring-expected.png:
  • platform/efl/fast/forms/textfield-focus-ring-expected.txt:
  • platform/efl/fast/forms/textfield-outline-expected.png:
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/efl/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.png:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/html/details-no-summary4-expected.png:
  • platform/efl/fast/html/details-no-summary4-expected.txt:
  • platform/efl/fast/html/details-open-javascript-expected.png:
  • platform/efl/fast/html/details-open-javascript-expected.txt:
  • platform/efl/fast/html/details-open2-expected.png:
  • platform/efl/fast/html/details-open2-expected.txt:
  • platform/efl/fast/html/details-open4-expected.png:
  • platform/efl/fast/html/details-open4-expected.txt:
  • platform/efl/fast/lists/dynamic-marker-crash-expected.png:
  • platform/efl/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.png:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/repaint/subtree-root-skipped-expected.png:
  • platform/efl/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.png:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/efl/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/efl/fast/replaced/width100percent-textfield-expected.png:
  • platform/efl/fast/replaced/width100percent-textfield-expected.txt:
  • platform/efl/fast/table/003-expected.png:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.png:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.png:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
  • platform/efl/fast/table/text-field-baseline-expected.png:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.png:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
6:32 AM Changeset in webkit [117689] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2012-05-19 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update two pixel test results on Lion, which show marginal diffs.

  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
4:18 AM Changeset in webkit [117688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build broken due to changes in the ​http://trac.webkit.org/changeset/117646
​https://bugs.webkit.org/show_bug.cgi?id=86939

The changeset 117646 changed the JSString::toBoolean signature. This
change is for fixing the windows build break.

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-05-19
Reviewed by Ryosuke Niwa.

2:29 AM Changeset in webkit [117687] by Csaba Osztrogonác
  • 5 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt-4.8/Skipped: Copy/paste error fix after r117588.
  • platform/qt/fast/forms/form-hides-table-expected.png: Added after r117640.
  • platform/qt/fast/forms/form-hides-table-expected.txt: Updated after r117640.
  • platform/qt/fast/table/form-with-table-style-expected.png: Updated after r117640.
  • platform/qt/fast/table/form-with-table-style-expected.txt: Updated after r117640.
2:24 AM Changeset in webkit [117686] by rniwa@webkit.org
  • 22 edits
    3 adds in trunk

Tools: Build fix. Sometimes --suffixes isn't supplied.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):

LayoutTests: More Chromium rebaselines after r117672.

  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt:
2:07 AM Changeset in webkit [117685] by rniwa@webkit.org
  • 4 edits
    5 copies in trunk/LayoutTests

More SnowLeopard rebaselines.

  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt.
  • platform/mac-snowleopard/fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/mac/fast/css/font-family-pictograph-expected.txt.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
  • platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/canvas-putImageData-expected.txt.
  • platform/mac-snowleopard/media/controls-styling-expected.txt: Copied from LayoutTests/platform/mac/media/controls-styling-expected.txt.
  • platform/mac-snowleopard/media/controls-without-preload-expected.txt:
  • platform/mac-snowleopard/media/media-can-play-wav-audio-expected.txt: Copied from LayoutTests/platform/mac/media/media-can-play-wav-audio-expected.txt.
1:14 AM WebKitGTK/1.8.x edited by zandobersek@gmail.com
(diff)
1:03 AM Changeset in webkit [117684] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Touch Internals.* in an attempt to fix Windows builds after r117646.

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:
12:59 AM Changeset in webkit [117683] by zandobersek@gmail.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, adding GTK baselines for new tests added in r117477.

  • platform/gtk/css2.1/20110323/table-height-algorithm-023-expected.txt: Added.
  • platform/gtk/css2.1/20110323/table-height-algorithm-024-expected.txt: Added.
  • platform/gtk/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
  • platform/gtk/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
12:42 AM Changeset in webkit [117682] by rniwa@webkit.org
  • 17 edits in trunk

Tools: Add "Lion" -> "mac-lion" to the builder port map.

  • Scripts/webkitpy/layout_tests/port/builders.py:

LayoutTests: Lion rebaseline after r117672.

  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
12:27 AM Changeset in webkit [117681] by Csaba Osztrogonác
  • 234 edits
    1 copy
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r117672.

  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.png:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/input-field-1-expected.png:
  • platform/qt/editing/pasteboard/input-field-1-expected.txt:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.png:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.png:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/editing/selection/drag-select-1-expected.png:
  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/qt/fast/css/input-search-padding-expected.png:
  • platform/qt/fast/css/input-search-padding-expected.txt:
  • platform/qt/fast/css/line-height-expected.png:
  • platform/qt/fast/css/line-height-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.png:
  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/dom/isindex-001-expected.png:
  • platform/qt/fast/dom/isindex-001-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.png:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/basic-inputs-expected.png:
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.png:
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/encoding-test-expected.png:
  • platform/qt/fast/forms/encoding-test-expected.txt:
  • platform/qt/fast/forms/fieldset-align-expected.png:
  • platform/qt/fast/forms/fieldset-align-expected.txt:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.png:
  • platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/qt/fast/forms/form-element-geometry-expected.png:
  • platform/qt/fast/forms/form-element-geometry-expected.txt:
  • platform/qt/fast/forms/input-align-expected.png:
  • platform/qt/fast/forms/input-align-expected.txt:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/qt/fast/forms/input-appearance-disabled-expected.png:
  • platform/qt/fast/forms/input-appearance-disabled-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.png:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.png:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.png:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-appearance-visibility-expected.png:
  • platform/qt/fast/forms/input-appearance-visibility-expected.txt:
  • platform/qt/fast/forms/input-baseline-expected.png:
  • platform/qt/fast/forms/input-baseline-expected.txt:
  • platform/qt/fast/forms/input-disabled-color-expected.png:
  • platform/qt/fast/forms/input-disabled-color-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-field-text-truncated-expected.png:
  • platform/qt/fast/forms/input-field-text-truncated-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/qt/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/qt/fast/forms/input-readonly-empty-expected.png:
  • platform/qt/fast/forms/input-readonly-empty-expected.txt:
  • platform/qt/fast/forms/input-spaces-expected.png:
  • platform/qt/fast/forms/input-spaces-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.png:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.png:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.png:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/input-text-word-wrap-expected.png:
  • platform/qt/fast/forms/input-text-word-wrap-expected.txt:
  • platform/qt/fast/forms/input-width-expected.png:
  • platform/qt/fast/forms/input-width-expected.txt:
  • platform/qt/fast/forms/minWidthPercent-expected.png:
  • platform/qt/fast/forms/minWidthPercent-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.png:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textfield-focus-ring-expected.png:
  • platform/qt/fast/forms/textfield-focus-ring-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.png: Added.
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/qt/fast/transforms/transformed-focused-text-input-expected.png.
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.png:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.png:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.png:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open2-expected.png:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open4-expected.png:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/lists/dynamic-marker-crash-expected.png:
  • platform/qt/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.png:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/fast/table/colspanMinWidth-expected.png:
  • platform/qt/fast/table/colspanMinWidth-expected.txt:
  • platform/qt/fast/table/spanOverlapRepaint-expected.png:
  • platform/qt/fast/table/spanOverlapRepaint-expected.txt:
  • platform/qt/fast/table/text-field-baseline-expected.png:
  • platform/qt/fast/table/text-field-baseline-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.png:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/svg/hixie/mixed/003-expected.png:
  • platform/qt/svg/hixie/mixed/003-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.png:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.png:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
12:13 AM Changeset in webkit [117680] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r117675.
​http://trac.webkit.org/changeset/117675
​https://bugs.webkit.org/show_bug.cgi?id=86938

Broke builds. You can't initialize members by members
themselves (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-19

Source/WebKit/chromium:

  • public/WebFrame.h:

(WebFrame):

  • public/WebPlugin.h:

(WebPlugin):
(WebKit::WebPlugin::printBegin):

  • public/WebPrintParams.h:
  • src/WebFrameImpl.cpp:

(WebKit):
(WebKit::WebFrameImpl::printBegin):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::printBegin):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::numberOfPages):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::printPage):

Note: See TracTimeline for information about the timeline view.