Context Navigation

← Previous Period
Next Period →

Timeline

May 26, 2012:

11:52 PM Changeset in webkit [118621] by ddkilzer@apple.com

3 edits in trunk/Tools

Use xcrun to find path to nm for Mac port
<http://webkit.org/b/87588>

Reviewed by Dan Bernstein.

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.nm_command): Add. Tries to find a path for the nm
command using xcrun. Falls back to returning 'nm'.

Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.nm_command): Add. Returns 'nm'.
(WebKitPort._webcore_symbols_string): Call self.nm_command().

6:51 PM Changeset in webkit [118620] by commit-queue@webkit.org

9 edits in trunk

[FileAPI] The result attribute of FileReader shuold use null to replace empty string
https://bugs.webkit.org/show_bug.cgi?id=87578

Patch by Li Yin <li.yin@intel.com> on 2012-05-26
Reviewed by Kentaro Hara.

Source/WebCore:

From Spec: http://www.w3.org/TR/FileAPI/#filedata-attr
Before read method has been called or an error in reading has occurred,
the result attribute should be null, not empty string.

Currently, Firefox, Opera and IE 10 follows the spec, but Webkit based
browser don't.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

Tests: fast/files/read-file-async.html

fast/files/blob-slice-test.html
fast/files/read-blob-async.html
fast/files/workers/worker-read-blob-async.html
fast/files/workers/worker-read-file-async.html

fileapi/FileReader.cpp:

(WebCore::FileReader::stringResult):

LayoutTests:

From Spec: http://www.w3.org/TR/FileAPI/#filedata-attr
Before read method has been called or an error in reading has occurred,
the result attribute should be null, not empty string.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

fast/files/blob-slice-test-expected.txt:
fast/files/read-blob-async-expected.txt:
fast/files/read-file-async-expected.txt:
fast/files/resources/read-common.js:

(logResult):

fast/files/workers/worker-read-blob-async-expected.txt:
fast/files/workers/worker-read-file-async-expected.txt:

6:16 PM Changeset in webkit [118619] by aestes@apple.com

2 edits in trunk/Source/WebCore

Fix the build when NETSCAPE_PLUGIN_API is disabled by marking a
parameter as unused.

plugins/PluginData.cpp:

(WebCore::PluginData::initPlugins):

5:46 PM Changeset in webkit [118618] by Nate Chapin

12 edits
2 adds in trunk

Source/WebCore: Cancel CachedResource loads when the last client is removed.
https://bugs.webkit.org/show_bug.cgi?id=35377

Reviewed by Darin Adler.

Test: http/tests/cache/cancel-in-progress-load.html

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::errorLoadingResource):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::allClientsRemoved):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::allClientsRemoved):

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::allClientsRemoved):

loader/cache/CachedRawResource.cpp:

(WebCore):

loader/cache/CachedRawResource.h:

(WebCore::CachedRawResource::shouldIgnoreHTTPStatusCodeErrors):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::allClientsRemoved):
(WebCore):

loader/cache/CachedResource.h:

(CachedResource):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::allClientsRemoved):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=35377.

Reviewed by Darin Adler.

http/tests/cache/cancel-in-progress-load-expected.txt: Added.
http/tests/cache/cancel-in-progress-load.html: Added.
http/tests/misc/write-while-waiting.html: Add waitUntilDone()/notifyDone().

The slow script will now be cancelled when the script element is removed from the document.
Without waitUntilDone(), LayoutTestController will immediately end the test upon cancellation
of the last resource.

5:43 PM Changeset in webkit [118617] by Simon Fraser

5 edits
2 adds in trunk

fast/block/inline-children-root-linebox-crash.html asserts after r118567
https://bugs.webkit.org/show_bug.cgi?id=87544

Source/WebCore:

Reviewed by Darin Adler.

RenderInline::offsetFromContainer() set offsetDependsOnPoint to true based
on the container's flipped writing mode. However, offsetFromContainer() would
then overwrite that, since it only checked for columns.

Fix by having RenderInline::offsetFromContainer() check for flipping on
the container. This fixes the assertion.

The new testcase exercises fixes another issue; unlike mapLocalToAbsolute(),
RenderGeometryMap::absoluteRect() didn't pass the rect center point through
the mapping, which resulted in a different result in some flipping cases.

Test: compositing/geometry/flipped-blocks-inline-mapping.html

rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::absoluteRect):

rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::pushMappingToContainer):

LayoutTests:

Reviewed by Darin Adler.

Remove fast/block/inline-children-root-linebox-crash.html from the skipped
list.

New, more complex writing mode flipping test with compositing.

compositing/geometry/flipped-blocks-inline-mapping-expected.txt: Added.
compositing/geometry/flipped-blocks-inline-mapping.html: Added.
platform/mac/Skipped:

3:40 PM Changeset in webkit [118616] by ggaren@apple.com

47 edits in trunk/Source

WebKit should be lazy-finalization-safe (esp. the DOM) v2
https://bugs.webkit.org/show_bug.cgi?id=87581

Reviewed by Oliver Hunt.

../JavaScriptCore:

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

heap/WeakBlock.h:
heap/WeakSetInlines.h:

(JSC::WeakBlock::finalize): Since we don't guarantee destruction order,
it's not valid to access GC pointers like the Structure pointer during
finalization. We NULL out the structure pointer in debug builds to try
to make this programming mistake more obvious.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::destroy):

API/JSCallbackObject.cpp:

(JSC::::destroy):
(JSC::JSCallbackObjectData::finalize):

runtime/Arguments.cpp:

(JSC::Arguments::destroy):

runtime/DateInstance.cpp:

(JSC::DateInstance::destroy):

runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::destroy):

runtime/Executable.cpp:

(JSC::ExecutableBase::destroy):
(JSC::NativeExecutable::destroy):
(JSC::ScriptExecutable::destroy):
(JSC::EvalExecutable::destroy):
(JSC::ProgramExecutable::destroy):
(JSC::FunctionExecutable::destroy):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::destroy):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::destroy):

runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::destroy):

runtime/JSString.cpp:

(JSC::JSString::destroy):

runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::destroy):

runtime/NameInstance.cpp:

(JSC::NameInstance::destroy):

runtime/RegExp.cpp:

(JSC::RegExp::destroy):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::destroy):

runtime/Structure.cpp:

(JSC::Structure::destroy):

runtime/StructureChain.cpp:

(JSC::StructureChain::destroy): Use static_cast instead of jsCast because
jsCast does Structure-based validation, and our Structure is not guaranteed
to be alive when we get finalized.

../WebCore:

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::destroy):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::destroy):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::destroy):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):

bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::destroy):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::destroy):
(WebCore::JSTestActiveDOMObjectOwner::finalize):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetterOwner::finalize):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::destroy):
(WebCore::JSTestEventConstructorOwner::finalize):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::destroy):
(WebCore::JSTestEventTargetOwner::finalize):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::destroy):
(WebCore::JSTestExceptionOwner::finalize):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::destroy):
(WebCore::JSTestInterfaceOwner::finalize):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::destroy):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::destroy):
(WebCore::JSTestNamedConstructorOwner::finalize):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::destroy):
(WebCore::JSTestObjOwner::finalize):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::destroy):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::destroy):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::destroy):

bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::QtRuntimeMethod::destroy):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::destroy):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::destroy):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::destroy):

bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::finalize): Use static_cast instead of jsCast because
jsCast does Structure-based validation, and our Structure is not guaranteed
to be alive when we get finalized.

../WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::destroy):
(WebKit::JSNPObject::leakNPObject):

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize): Use static_cast instead of jsCast because
jsCast does Structure-based validation, and our Structure is not guaranteed
to be alive when we get finalized.

3:08 PM Changeset in webkit [118615] by mjs@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r116720): Subframe PDF scrolls extremely slowly
https://bugs.webkit.org/show_bug.cgi?id=87557
<rdar://problem/11499408>

Reviewed by Anders Carlsson.

It's not possible to make an automated test for this.

WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
misleading comment. While the built-in PDF view would get added to the set of scrollable
areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
necessary to reutrn true.

2:25 PM Changeset in webkit [118614] by Dave Barton

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Move myself to committers.

1:35 PM Changeset in webkit [118613] by Dave Barton

2 edits in trunk/LayoutTests

My first commit - set svn:mime-type to image/png on one .png file.

platform/mac/mathml/presentation/mroot-pref-width-expected.png:

1:15 PM Changeset in webkit [118612] by Simon Fraser

3 edits
2 adds in trunk

Clip rects assertion when hovering div with transform
https://bugs.webkit.org/show_bug.cgi?id=87580

Source/WebCore:

Reviewed by Eric Seidel.

Hit testing used to use temporary clip rects in composited documents,
until r118562. Now that we cache clip rects for hit testing, we need
to clear the cache on descendant layers when a layer gains or loses
a transform.

Test: fast/layers/clip-rects-assertion.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateTransform):

LayoutTests:

Reviewed by Eric Seidel.

Test that changes transform on hover style, testing for clipRect-related
assertions.

fast/layers/clip-rects-assertion-expected.txt: Added.
fast/layers/clip-rects-assertion.html: Added.

10:32 AM WebKit Team edited by noam.rosenthal@nokia.com

(diff)

10:14 AM Changeset in webkit [118611] by mitz@apple.com

3 edits in trunk/Source/WebCore

<rdar://problem/11439771> WebProcess sends many synchronous messages to the UI process while scrolling beneath ScrollView::contentsToScreen()
https://bugs.webkit.org/show_bug.cgi?id=87571

Reviewed by Anders Carlsson.

fakeMouseEventTimerFired() uses the last known mouse position for the fake mouse event, but
calls contentsToScreen() to compute a corresponding position in screen coordinates. Avoid
this by also recording the last known mouse position in screen coordinates, and using that
value.

page/EventHandler.cpp:

(WebCore::EventHandler::clear): Added resetting m_currentMouseGlobalPosition.
(WebCore::EventHandler::handleMousePressEvent): Added updating m_currentMouseGlobalPosition
when updating m_currentMousePosition.
(WebCore::EventHandler::handleMouseDoubleClickEvent): Ditto.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Changed to use m_currentMouseGlobalPosition
in the fake event instead of calling contentsToScreen().

page/EventHandler.h: Added m_currentMouseGlobalPosition data member.

8:34 AM Changeset in webkit [118610] by Philippe Normand

2 edits
1 delete in trunk/Source/WebCore

[GStreamer] Remove ImageGStreamerCG implementation
https://bugs.webkit.org/show_bug.cgi?id=87559

The ImageGStreamerCG abstraction is being removed until I manage to
port my gst-mac WebKit branch over to the WebKit2 mac port. No
need to update the XCode project because this file is not
referenced there anyway.

Reviewed by Martin Robinson.

platform/graphics/gstreamer/ImageGStreamer.h:

(ImageGStreamer):

platform/graphics/gstreamer/ImageGStreamerCG.mm: Removed.

4:38 AM Changeset in webkit [118609] by rwlbuis@webkit.org

4 edits
54 adds in trunk

Bug 15799: textPath element does not re-render when referenced path changes
https://bugs.webkit.org/show_bug.cgi?id=15799

Patch by Rob Buis <rwlbuis@webkit.org> on 2012-05-26
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Support textPath updating to changes on the referenced path. To make this possible
use the target reference functionality also used by SVGFEImageElement.

Tests: svg/custom/textPath-change-id-expected.svg

svg/custom/textPath-change-id-pattern-expected.svg
svg/custom/textPath-change-id-pattern.svg
svg/custom/textPath-change-id.svg
svg/custom/textPath-change-id2-expected.svg
svg/custom/textPath-change-id2-pattern-expected.svg
svg/custom/textPath-change-id2-pattern.svg
svg/custom/textPath-change-id2.svg
svg/custom/textPath-change-reference-expected.svg
svg/custom/textPath-change-reference-pattern-expected.svg
svg/custom/textPath-change-reference-pattern.svg
svg/custom/textPath-change-reference-using-baseval-expected.svg
svg/custom/textPath-change-reference-using-baseval-pattern-expected.svg
svg/custom/textPath-change-reference-using-baseval-pattern.svg
svg/custom/textPath-change-reference-using-baseval.svg
svg/custom/textPath-change-reference.svg
svg/custom/textPath-change-reference2-expected.svg
svg/custom/textPath-change-reference2-pattern-expected.svg
svg/custom/textPath-change-reference2-pattern.svg
svg/custom/textPath-change-reference2-using-baseval-expected.svg
svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svg
svg/custom/textPath-change-reference2-using-baseval-pattern.svg
svg/custom/textPath-change-reference2-using-baseval.svg
svg/custom/textPath-change-reference2.svg
svg/custom/textPath-insert-path-expected.svg
svg/custom/textPath-insert-path-pattern-expected.svg
svg/custom/textPath-insert-path-pattern.svg
svg/custom/textPath-insert-path.svg
svg/custom/textPath-modify-child-expected.svg
svg/custom/textPath-modify-child-pattern-expected.svg
svg/custom/textPath-modify-child-pattern.svg
svg/custom/textPath-modify-child.svg
svg/custom/textPath-path-change-expected.svg
svg/custom/textPath-path-change-pattern-expected.svg
svg/custom/textPath-path-change-pattern.svg
svg/custom/textPath-path-change-using-svg-dom-expected.svg
svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svg
svg/custom/textPath-path-change-using-svg-dom-pattern.svg
svg/custom/textPath-path-change-using-svg-dom.svg
svg/custom/textPath-path-change.svg
svg/custom/textPath-path-change2-expected.svg
svg/custom/textPath-path-change2-pattern-expected.svg
svg/custom/textPath-path-change2-pattern.svg
svg/custom/textPath-path-change2.svg
svg/custom/textPath-remove-path-expected.svg
svg/custom/textPath-remove-path-pattern-expected.svg
svg/custom/textPath-remove-path-pattern.svg
svg/custom/textPath-remove-path.svg
svg/custom/textPath-set-id-expected.svg
svg/custom/textPath-set-id.svg
svg/custom/textPath-startoffset-expected.svg
svg/custom/textPath-startoffset-pattern-expected.svg
svg/custom/textPath-startoffset-pattern.svg
svg/custom/textPath-startoffset.svg

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::~SVGTextPathElement):
(WebCore):
(WebCore::SVGTextPathElement::clearResourceReferences):
(WebCore::SVGTextPathElement::svgAttributeChanged):
(WebCore::SVGTextPathElement::buildPendingResource):
(WebCore::SVGTextPathElement::insertedInto):
(WebCore::SVGTextPathElement::removedFrom):

svg/SVGTextPathElement.h:

LayoutTests:

textPath-path-change-id.svg, react to change of id attribute on referenced path (makes the xlink:href valid).
textPath-path-change-id2.svg, react to change of id attribute on referenced path (makes the xlink:href invalid).
textPath-path-set-id.svg, react to setting of id attribute on referenced path (makes the xlink:href valid).
textPath-change-reference.svg, <textPath> references existing <path>, change the xlink:href to a non-existing one.
textPath-change-reference-using-baseval.svg, <textPath> references existing <path>, change the xlink:href to a non-existing one using SVG DOM.
textPath-change-reference2.svg, <textPath> references non-existing <path>, change xlink:href to an existing one.
textPath-change-reference2-using-baseval.svg, <textPath> references non-existing <path>, change xlink:href to an existing one using SVG DOM.
textPath-insert-path.svg, <textPath> references non-existing <path>, <path> added dynamically.
textPath-modify-child.svg, react to change on textPath content.
textPath-path-change-using-svg-dom.svg, react to change on pathSegList of referenced path.
textPath-path-change.svg, react to change on d attribute of referenced path.
textPath-path-change2.svg, react to change on d attribute of path referenced by multiple <textPath>s.
textPath-remove-path.svg, <textPath> references existing <path>, <path> is removed from DOM.
textPath-startoffset.svg, react to startOffset attribute change on <textPath>.

These tests are duplicated for <textPath> inside a <pattern>.

svg/custom/textPath-change-id-expected.svg: Added.
svg/custom/textPath-change-id-pattern-expected.svg: Added.
svg/custom/textPath-change-id-pattern.svg: Added.
svg/custom/textPath-change-id.svg: Added.
svg/custom/textPath-change-id2-expected.svg: Added.
svg/custom/textPath-change-id2-pattern-expected.svg: Added.
svg/custom/textPath-change-id2-pattern.svg: Added.
svg/custom/textPath-change-id2.svg: Added.
svg/custom/textPath-change-reference-expected.svg: Added.
svg/custom/textPath-change-reference-pattern-expected.svg: Added.
svg/custom/textPath-change-reference-pattern.svg: Added.
svg/custom/textPath-change-reference-using-baseval-expected.svg: Added.
svg/custom/textPath-change-reference-using-baseval-pattern-expected.svg: Added.
svg/custom/textPath-change-reference-using-baseval-pattern.svg: Added.
svg/custom/textPath-change-reference-using-baseval.svg: Added.
svg/custom/textPath-change-reference.svg: Added.
svg/custom/textPath-change-reference2-expected.svg: Added.
svg/custom/textPath-change-reference2-pattern-expected.svg: Added.
svg/custom/textPath-change-reference2-pattern.svg: Added.
svg/custom/textPath-change-reference2-using-baseval-expected.svg: Added.
svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svg: Added.
svg/custom/textPath-change-reference2-using-baseval-pattern.svg: Added.
svg/custom/textPath-change-reference2-using-baseval.svg: Added.
svg/custom/textPath-change-reference2.svg: Added.
svg/custom/textPath-insert-path-expected.svg: Added.
svg/custom/textPath-insert-path-pattern-expected.svg: Added.
svg/custom/textPath-insert-path-pattern.svg: Added.
svg/custom/textPath-insert-path.svg: Added.
svg/custom/textPath-modify-child-expected.svg: Added.
svg/custom/textPath-modify-child-pattern-expected.svg: Added.
svg/custom/textPath-modify-child-pattern.svg: Added.
svg/custom/textPath-modify-child.svg: Added.
svg/custom/textPath-path-change-expected.svg: Added.
svg/custom/textPath-path-change-pattern-expected.svg: Added.
svg/custom/textPath-path-change-pattern.svg: Added.
svg/custom/textPath-path-change-using-svg-dom-expected.svg: Added.
svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svg: Added.
svg/custom/textPath-path-change-using-svg-dom-pattern.svg: Added.
svg/custom/textPath-path-change-using-svg-dom.svg: Added.
svg/custom/textPath-path-change.svg: Added.
svg/custom/textPath-path-change2-expected.svg: Added.
svg/custom/textPath-path-change2-pattern-expected.svg: Added.
svg/custom/textPath-path-change2-pattern.svg: Added.
svg/custom/textPath-path-change2.svg: Added.
svg/custom/textPath-remove-path-expected.svg: Added.
svg/custom/textPath-remove-path-pattern-expected.svg: Added.
svg/custom/textPath-remove-path-pattern.svg: Added.
svg/custom/textPath-remove-path.svg: Added.
svg/custom/textPath-set-id-expected.svg: Added.
svg/custom/textPath-set-id.svg: Added.
svg/custom/textPath-startoffset-expected.svg: Added.
svg/custom/textPath-startoffset-pattern-expected.svg: Added.
svg/custom/textPath-startoffset-pattern.svg: Added.
svg/custom/textPath-startoffset.svg: Added.

2:08 AM Changeset in webkit [118608] by Nikolas Zimmermann

17 edits in trunk/Source/WebCore

Avoid updateFromElement() usage in SVG
https://bugs.webkit.org/show_bug.cgi?id=87573

Stop relying on updateFromElement() - instead rely on addChild/removeChild, which
allows us to optimize the resources re-fetching. When a child is added to the tree
we don't need to remove existing resources from the SVGResourcesCache - the renderer
can't be in the cache yet. Similary, remove the entry from the cache earlier: as soon
as the renderer is removed from the tree, instead of waiting for willBeDestroyed().

No new tests, refactoring only.

rendering/svg/RenderSVGBlock.cpp:
rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addChild):
(WebCore):
(WebCore::RenderSVGContainer::removeChild):

rendering/svg/RenderSVGContainer.h:

(RenderSVGContainer):

rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):
(WebCore::RenderSVGInline::removeChild):

rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

rendering/svg/RenderSVGModelObject.cpp:
rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::addChild):
(WebCore):
(WebCore::RenderSVGRoot::removeChild):

rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::removeChild):

rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientStyleChanged):
(WebCore::rendererCanHaveResources):
(WebCore):
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):

rendering/svg/SVGResourcesCache.h:

(SVGResourcesCache):

svg/SVGStyledElement.cpp:
svg/SVGStyledElement.h:

(SVGStyledElement):

12:16 AM Changeset in webkit [118607] by zandobersek@gmail.com

2 edits
2 adds in trunk/LayoutTests

Unreviewed GTK gardening after r118577 and r118585.

platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
platform/gtk/test_expectations.txt:

May 25, 2012:

11:39 PM Changeset in webkit [118606] by nduca@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Instrument V8 GC with TraceEvent
https://bugs.webkit.org/show_bug.cgi?id=87530

Reviewed by Kentaro Hara.

We sometimes get performance issues where performance stalls can
be attributed to badly timed GC operations, especially ones that
happen just before a frame running. This adds tracing calls around
GC so that we can better understand these kinds of hangs.

bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

11:09 PM Changeset in webkit [118605] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS from r139156 to r139184.

DEPS:

8:20 PM Changeset in webkit [118604] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

cursor gets trapped when border-style: dashed is used
https://bugs.webkit.org/show_bug.cgi?id=37693

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-05-25
Reviewed by Tony Chang.

This bug has been fixed. Add a test to make sure that it won't regress.

editing/selection/move-by-line-006-expected.txt: Added.
editing/selection/move-by-line-006.html: Added.

8:09 PM Changeset in webkit [118603] by fpizlo@apple.com

2 edits in trunk/Source/WTF

weakCompareAndSwap should work on Windows
https://bugs.webkit.org/show_bug.cgi?id=87549

Reviewed by Jessie Berlin.

wtf/Atomics.h:

(WTF):
(WTF::weakCompareAndSwap):

7:24 PM Changeset in webkit [118602] by Stephanie Lewis

2 edits in trunk/LayoutTests

Unreviewed, fix bad copy/paste.

platform/mac/Skipped:

7:20 PM Changeset in webkit [118601] by commit-queue@webkit.org

11 edits
1 copy in trunk/Source

Allow WebTextFieldDecoratorClient to see applied decorations.
https://bugs.webkit.org/show_bug.cgi?id=86557

Patch by Garrett Casto <gcasto@chromium.org> on 2012-05-25
Reviewed by Kent Tamura.

Source/WebCore:

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::fromShadowRoot): A function
that will extract a TextFielDecorationElement from a ShadowRoot, if
there is one.

html/shadow/TextFieldDecorationElement.h:

(WebCore):
(TextFieldDecorator):

Source/WebKit/chromium:

WebKit.gyp: Added new files.
public/WebInputElement.h:

(WebKit::WebInputElement::decorationElementFor): Returns the
WebElement attached to the WebInputElement by the given
WebTextFieldDecoratorClient, if one exists.

src/TextFieldDecoratorImpl.cpp:

(WebKit):

src/TextFieldDecoratorImpl.h:

(TextFieldDecoratorImpl::decoratorClient): Get the
WebTextFieldDecoratorClient owned by this object.

7:07 PM Changeset in webkit [118600] by tony@chromium.org

6 edits in trunk

implement new negative flexing algorithm
https://bugs.webkit.org/show_bug.cgi?id=86528

Reviewed by Ojan Vafai.

Source/WebCore:

Rather than just scale by the negative flexibility, we also take the
flex-basis (preferred size) into consideration. That means items with
a larger preferred size will shrink faster.

Test: css3/flexbox/flex-algorithm.html (new test cases added)

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Handle overflow.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeNextFlexLine): Sum weighted negative flex.
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Shrink by weighted amount.
Also handle large values by making sure the flex values are finite.

rendering/RenderFlexibleBox.h:

LayoutTests:

css3/flexbox/flex-algorithm-expected.txt:
css3/flexbox/flex-algorithm.html:

7:05 PM Changeset in webkit [118599] by mihaip@chromium.org

12 edits
2 adds in trunk

Allow synchronous XHRs to be disabled in documents
https://bugs.webkit.org/show_bug.cgi?id=87540

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/xmlhttprequest/xmlhttprequest-sync-disabled.html

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

page/Settings.cpp:

(WebCore):
(WebCore::Settings::Settings):

page/Settings.h:

(Settings):
(WebCore::Settings::setSyncXHRInDocumentsEnabled):
(WebCore::Settings::syncXHRInDocumentsEnabled):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled):
(WebCore):

testing/InternalSettings.h:

(InternalSettings):

testing/InternalSettings.idl:
xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

Source/WebKit/chromium:

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setSyncXHRInDocumentsEnabled):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt: Added.
fast/xmlhttprequest/xmlhttprequest-sync-disabled.html: Added.

6:53 PM Changeset in webkit [118598] by Stephanie Lewis

1 edit
3 adds in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87558

Unreviewed, checking in expected failing results.

platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.

6:43 PM Changeset in webkit [118597] by kinuko@chromium.org

7 edits in trunk/Source

[chromium] Deprecate FileUtilities::getFileSize and getFileModifiedTime in favor of getFileMetadata
https://bugs.webkit.org/show_bug.cgi?id=87492

Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebFileUtilities.h:

Source/WebCore:

No new tests: existing tests (http/tests/local/fileapi/* and fast/files/*) should pass.

platform/chromium/FileSystemChromium.cpp:

(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):

platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getFileMetadata):

6:25 PM Changeset in webkit [118596] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r139024 to r139156 in an attempt to fix Chromium Win builds.

DEPS:

6:21 PM Changeset in webkit [118595] by Stephanie Lewis

2 edits in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87544

Unreviewed, skipping asserting test

platform/mac/Skipped:

6:02 PM Changeset in webkit [118594] by commit-queue@webkit.org

12 edits
7 adds
2 deletes in trunk

Source/WebKit/win: Added methods needed to implement backend for DRT's TextInputController on windows, https://bugs.webkit.org/show_bug.cgi?id=32021

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-05-25
Reviewed by Eric Seidel.

Interfaces/IWebViewPrivate.idl:
WebView.cpp:

(WebView::setCompositionForTesting):
(WebView::hasCompositionForTesting):
(WebView::confirmCompositionForTesting):
(WebView::compositionRangeForTesting):
(WebView::firstRectForCharacterRangeForTesting):
(WebView::selectedRangeForTesting):

WebView.h:

(WebView):

Tools: Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-05-25
Reviewed by Eric Seidel.

DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::FrameLoadDelegate):
(FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):

DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate):

DumpRenderTree/win/TextInputController.cpp: Added.

(setMarkedTextCallback):
(hasMarkedTextCallback):
(unmarkTextCallback):
(markedRangeCallback):
(insertTextCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
(TextInputController::makeWindowObject):
(TextInputController::getJSClass):
(TextInputController::staticValues):
(TextInputController::staticFunctions):

DumpRenderTree/win/TextInputController.h: Added.

(TextInputController):

DumpRenderTree/win/TextInputControllerWin.cpp: Added.

(TextInputController::setMarkedText):
(TextInputController::hasMarkedText):
(TextInputController::unmarkText):
(TextInputController::markedRange):
(TextInputController::insertText):
(TextInputController::firstRectForCharacterRange):
(TextInputController::selectedRange):

LayoutTests: Updated tests as a result of implementing TextInputController in DRT for windows, https://bugs.webkit.org/show_bug.cgi?id=32021

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-05-25
Reviewed by Eric Seidel.

platform/win/Skipped:
platform/win/editing/selection/5825350-1-expected.txt: Added.
platform/win/editing/selection/5825350-2-expected.txt: Added.
platform/win/editing/selection/mixed-editability-10-expected.txt:
platform/win/editing/selection/move-left-right-expected.txt: Added.
platform/win/fast/events/ime-composition-events-001-expected.txt:
platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Removed.
platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Removed.
platform/win/svg/text/caret-in-svg-text-expected.txt: Added.

5:35 PM Changeset in webkit [118593] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Enhance Windows DRT implementation to support platform scroll wheel events.
https://bugs.webkit.org/show_bug.cgi?id=36002

Add another test that uses continuousMouseScrollBy to the Windows Skipped list.

platform/win/Skipped:

5:28 PM Changeset in webkit [118592] by inferno@chromium.org

4 edits
2 adds in trunk

Crash in RenderTableSection::paintCell.
https://bugs.webkit.org/show_bug.cgi?id=87445

Reviewed by Eric Seidel and Julien Chaffraix.

Source/WebCore:

Fix the crash by preventing table parts from being set
as layout root. This prevents us from accessing removed
table cells which can happen if RenderTableSection::layout
is called directly without calling RenderTable::layout first
(in case of cell recalc).

Add ASSERTs to RenderTableSection::layout to prevent
layout to happen when we are already pending cell recalc
or our table is pending section recalc. In those cases,
RenderTable::layout should be called first to relayout
the entire table.

Test: tables/table-section-overflow-clip-crash.html

rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):

LayoutTests:

tables/table-section-overflow-clip-crash-expected.txt: Added.
tables/table-section-overflow-clip-crash.html: Added.

5:23 PM Changeset in webkit [118591] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Implement spinbutton support in RenderThemeSafari
https://bugs.webkit.org/show_bug.cgi?id=54662

Add more spinbutton tests to the Windows Skipped list.

platform/win/Skipped:

5:22 PM Changeset in webkit [118590] by pilgrim@chromium.org

12 edits
5 copies in trunk/Source

[Chomium] Move sandboxSupport to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87518

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::sandboxSupport):

chromium/public/android/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

chromium/public/linux/WebFontFamily.h: Added.

(WebKit):
(WebFontFamily):

chromium/public/linux/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

chromium/public/mac/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

chromium/public/win/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

Source/WebKit/chromium:

WebKit.gyp:
public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

public/platform/android/WebSandboxSupport.h:
public/platform/linux/WebFontFamily.h:
public/platform/linux/WebSandboxSupport.h:
public/platform/mac/WebSandboxSupport.h:
public/platform/win/WebSandboxSupport.h:
src/PlatformSupport.cpp:

(WebCore::PlatformSupport::ensureFontLoaded):
(WebCore::PlatformSupport::loadFont):
(WebCore::PlatformSupport::getFontFamilyForCharacters):
(WebCore::PlatformSupport::getRenderStyleForStrike):

5:18 PM Changeset in webkit [118589] by pdr@google.com

4 edits
2 adds in trunk

Fix for self-closing <use> tags
https://bugs.webkit.org/show_bug.cgi?id=87504

Reviewed by Adam Barth.

Source/WebCore:

This change causes self-closing non-html tags to behave the same
as tags immediately followed by the closing tag.

Test: svg/custom/svg-self-closing-use.html

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):

html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

LayoutTests:

svg/custom/svg-self-closing-use-expected.html: Added.
svg/custom/svg-self-closing-use.html: Added.

4:59 PM Changeset in webkit [118588] by jberlin@webkit.org

1 edit
15 adds in trunk/LayoutTests

[Win] ~1/2 of all the iframe seamless tests fail
https://bugs.webkit.org/show_bug.cgi?id=87543

Add failing expected results for Windows in order to get the bots green.

platform/win/fast/frames: Added.
platform/win/fast/frames/seamless: Added.
platform/win/fast/frames/seamless/seamless-basic-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-css-cascade-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-form-get-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-form-get-named-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-form-post-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-form-post-named-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-hyperlink-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-hyperlink-named-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-inherited-document-style-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-window-location-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-window-location-href-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Added.
platform/win/fast/frames/seamless/seamless-window-open-expected.txt: Added.

4:46 PM Changeset in webkit [118587] by mitz@apple.com

2 edits in trunk/Source/WebCore

Make the ICU-based implementation of NonSharedCharacterBreakIterator work in configurations
that do not have COMPARE_AND_SWAP enabled.

Reviewed by Jessie Berlin.

platform/text/TextBreakIteratorICU.cpp:

(WebCore::compareAndSwapNonSharedCharacterBreakIterator): Added this helper. It uses
weakCompareAndSwap when COMPARE_AND_SWAP is enabled, and uses a mutex to do the atomic
compare and swap otherwise.
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Changed to use
compareAndSwapNonSharedCharacterBreakIterator().
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Ditto.

4:31 PM Changeset in webkit [118586] by tommyw@google.com

7 edits in trunk

MediaStream API: Make sure IceCallback is valid for PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=87480

Reviewed by Adam Barth.

Source/WebCore:

Existing tests have been extended to cover this change.

Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::create):

Modules/mediastream/PeerConnection00.h:
Modules/mediastream/PeerConnection00.idl:

LayoutTests:

fast/mediastream/constructors-expected.txt:
fast/mediastream/constructors.html:

4:29 PM Changeset in webkit [118585] by commit-queue@webkit.org

28 edits
1 copy
9 adds in trunk

Inline script and style blocked by Content Security Policy should provide more detailed console errors.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by Mike West <mkwst@chromium.org> on 2012-05-25
Reviewed by Adam Barth.

Source/WebCore:

This change adds a URL and line number for context to each call to
ContentSecurityPolicy::allowInline*, and pipes it through to the
console message generation in CSPDirectiveList::reportViolation.

Line numbers are not added for injected scripts (document.write(...),
document.body.appendChild, and etc.).

Tests: http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html

http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html
http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html
http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html

bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::executeScript):

dom/ScriptElement.h:

(ScriptElement):

dom/StyleElement.cpp:

(WebCore::StyleElement::StyleElement):
(WebCore::StyleElement::createSheet):

dom/StyleElement.h:

(StyleElement):

dom/StyledElement.cpp:

(WebCore::StyledElement::StyledElement):
(WebCore):
(WebCore::StyledElement::style):
(WebCore::StyledElement::styleAttributeChanged):

dom/StyledElement.h:

(StyledElement):

page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore):
(WebCore::isAllowedByAllWithCallStack):
(WebCore::isAllowedByAllWithContext):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):

page/ContentSecurityPolicy.h:

(WTF):

LayoutTests:

http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/injected-inline-script-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html: Added.
http/tests/security/contentSecurityPolicy/injected-inline-script-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt.
http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html: Added.
http/tests/security/contentSecurityPolicy/injected-inline-style-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html: Added.
http/tests/security/contentSecurityPolicy/injected-inline-style-blocked-expected.txt: Added.
http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html: Added.
http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
http/tests/security/contentSecurityPolicy/report-only-expected.txt:
http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
http/tests/security/contentSecurityPolicy/resources/inject-script.js: Added.
http/tests/security/contentSecurityPolicy/resources/inject-style.js: Added.
http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:

4:26 PM Changeset in webkit [118584] by jsbell@chromium.org

1 edit
3 adds in trunk/LayoutTests

[Chromium] Add missing expectations needed after http://trac.webkit.org/changeset/118577/

Unreviewed gardening.

platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.

4:01 PM Changeset in webkit [118583] by timothy_horton@apple.com

15 edits in trunk/Source/WebCore

ENABLE_CSS3_FLEXBOX is insufficient to disable all web-facing bits of the feature
https://bugs.webkit.org/show_bug.cgi?id=87537
<rdar://problem/11524921>

Reviewed by Simon Fraser.

Allow the feature flag to disable more web-facing parts of the CSS3 flexbox
implementation (primarily fallout from hiding it from computed style).

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):

css/StylePropertyShorthand.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::ensurePropertyMap):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

rendering/style/RenderStyleConstants.h:

4:00 PM Changeset in webkit [118582] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG CSE should eliminate redundant WeakJSConstants
https://bugs.webkit.org/show_bug.cgi?id=87179

Reviewed by Gavin Barraclough.

Merged r118141 from dfgopt.

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::weakConstantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGNode.h:

(JSC::DFG::Node::weakConstant):

3:57 PM Changeset in webkit [118581] by kbr@google.com

2 edits in trunk/LayoutTests

New tex-image-and-sub-image-2d-with-video tests from r118565 failing on Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=87541

Unreviewed; skipping tests until bug can be investigated.

platform/mac/Skipped:

3:49 PM Changeset in webkit [118580] by enne@google.com

5 edits in trunk/Source/WebCore

[chromium] Add setting for painting debug info onto tiles
https://bugs.webkit.org/show_bug.cgi?id=75763

Reviewed by James Robinson.

Add a compile-time CCSetting to paint debug information onto tiles. This
can help to understand paint counts and layer indices. This setting is
off by default.

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerChromium::createTextureUpdater):

platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::setUpdateFrame):
(WebCore::UpdatableTile::incrementPaintCount):
(WebCore::UpdatableTile::updateFrame):
(WebCore::UpdatableTile::paintCount):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::paintDebugTileInfo):

platform/graphics/chromium/TiledLayerChromium.h:
platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

3:45 PM Changeset in webkit [118579] by fpizlo@apple.com

12 edits in trunk/Source/JavaScriptCore

DFG CSE should do redundant store elimination
https://bugs.webkit.org/show_bug.cgi?id=87161

Reviewed by Oliver Hunt.

Merge r118138 from dfgopt.

This patch adds redundant store elimination. For example, consider this
code:

o.x = 42;
o.x = 84;

If o.x is speculated to be a well-behaved field, the first assignment is
unnecessary, since the second just overwrites it. We would like to
eliminate the first assignment in these cases. The need for this
optimization arises mostly from stores that our runtime requires. For
example:

o = {f:1, g:2, h:3};

This will have four assignments to the structure for the newly created
object - one assignment for the empty structure, one for {f}, one for
{f, g}, and one for {f, g, h}. We would like to only have the last of
those assigments in this case.

Intriguingly, doing so for captured variables breaks the way arguments
simplification used to work. Consider that prior to either arguments
simplification or store elimination we will have IR that looks like:

a: SetLocal(r0, Empty)
b: SetLocal(r1, Empty)
c: GetLocal(r0)
d: CreateArguments(@c)
e: SetLocal(r0, @d)
f: SetLocal(r1, @d)

Then redundant store elimination will eliminate the stores that
initialize the arguments registers to Empty, but then arguments
simplification eliminates the stores that initialize the arguments to
the newly created arguments - and at this point we no longer have any
stores to the arguments register, leading to hilarious crashes. This
patch therefore changes arguments simplification to replace
CreateArguments with JSConstant(Empty) rather than eliminating the
SetLocals. But this revealed bugs where arguments simplification was
being overzealous, so I fixed those bugs.

This is a minor speed-up on V8/early and a handful of other tests.

bytecode/CodeBlock.h:

(JSC::CodeBlock::uncheckedActivationRegister):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarStoreElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGGraph.h:

(JSC::DFG::Graph::uncheckedActivationRegisterFor):
(Graph):

dfg/DFGNode.h:

(JSC::DFG::Node::isPhantomArguments):
(Node):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasStructureTransitionData):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:36 PM Changeset in webkit [118578] by adamk@chromium.org

2 edits in trunk/LayoutTests

Remove a bunch of flaky expectations for tests that now pass.

Unreviewed test expectations update.

Also marked some nearby tests as more definitely failing.

platform/chromium/test_expectations.txt:

3:30 PM Changeset in webkit [118577] by fischman@chromium.org

2 edits
3 adds in trunk

[chromium] Default media controls should render only the currentTime-containing buffered range
https://bugs.webkit.org/show_bug.cgi?id=85925

Reviewed by Eric Carlson.

Test: http/tests/media/video-buffered-range-contains-currentTime.html

rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider):

3:24 PM Changeset in webkit [118576] by adamk@chromium.org

2 edits in trunk/LayoutTests

compositing/overflow/overflow-positioning.html fails with timeout on multiple chromium bots
https://bugs.webkit.org/show_bug.cgi?id=85771

Unreviewed test expectations update.

These tests haven't timed out lately on the Chromium bots, so removing
the suppressions.

platform/chromium/test_expectations.txt:

3:22 PM Changeset in webkit [118575] by annacc@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Removing tests from test_expectations.txt that are no longer crashing.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

3:19 PM Changeset in webkit [118574] by annacc@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Removing media/video-volume-slider.html from test_expectations.txt

Unreviewed gardening.

platform/chromium/test_expectations.txt:

3:14 PM Changeset in webkit [118573] by adamk@chromium.org

2 edits in trunk/LayoutTests

Mark some "flaky" TypedArray tests more appropriately as DEBUG SLOW

Unreviewed test expectations update.

platform/chromium/test_expectations.txt:

3:10 PM Changeset in webkit [118572] by Simon Fraser

3 edits in trunk/Source/WebCore

Build fix: add TransformationMatrix ctor from an AffineTransform.

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):

platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

3:07 PM Changeset in webkit [118571] by adamk@chromium.org

2 edits
1 move
10 deletes in trunk/LayoutTests

Rebaseline Chromium expectations for fast/box-shadow/shadow-buffer-partial.html

Unreviewed rebaselining.

The same rebaseline was made in r112582, but only got the Linux expectations.

fast/box-shadow/shadow-buffer-partial-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt.
platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/chromium/test_expectations.txt:
platform/efl/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
platform/mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.

3:02 PM Changeset in webkit [118570] by rniwa@webkit.org

12 edits
2 adds in trunk

createContextualFragment and insertAdjacentHTML should throw syntax error
https://bugs.webkit.org/show_bug.cgi?id=87454

Reviewed by Darin Adler.

Source/WebCore:

Before this patch, createContextualFragment threw NOT_SUPPORTED_ERR and insertAdjacentHTML didn't throw any errors.
Make them throw SYNTAX_ERR to be consistent with the spec and Firefox:
http://html5.org/specs/dom-parsing.html#parsing
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-xhtml-syntax.html#xml-fragment-parsing-algorithm

Also reduced the code duplication.

Test: fast/dom/xhtml-fragment-parsing-exceptions.xhtml

dom/Range.cpp:

(WebCore::Range::createContextualFragment):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML): Explicitly pass AllowScriptingContent.

editing/markup.cpp:

(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentForInnerOuterHTML): Takes ExceptionCode now.
(WebCore::createContextualFragment): Share code with createFragmentForInnerOuterHTML
and propagate the exception code.

editing/markup.h:
html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerHTML): Explicitly pass AllowScriptingContent.
(WebCore::HTMLElement::setOuterHTML): Ditto.
(WebCore::HTMLElement::insertAdjacentHTML): Ditto; also rename ignoredEc to ignoredEC
per Darin's comment on the bug 87339.

Source/WebKit/qt:

Pass an ExceptionCode to createContextualFragment.

Api/qwebelement.cpp:

(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

LayoutTests:

Add a regression test, and rebaselined the existing tests since we throw
DOMException.SYNTAX_ERR instead of DOMException.INVALID_STATE_ERR.

fast/dom/xhtml-fragment-parsing-exceptions-expected.txt: Added.
fast/dom/xhtml-fragment-parsing-exceptions.xhtml: Added.
fast/innerHTML/innerHTML-changing-document-properties-expected.txt:
fast/parser/xhtml-innerhtml-null-byte-first.xhtml:
fast/parser/xhtml-innerhtml-null-byte.xhtml:

2:48 PM Changeset in webkit [118569] by jknotten@chromium.org

3 edits
2 adds in trunk

Body scrollWidth() and scrollHeight() should be page scale-invariant
https://bugs.webkit.org/show_bug.cgi?id=87494

RenderView::documentRect() is calculating the "scaled" document rect by applying
the current transformation matrix to the unscaledDocumentRect() and then
returning the rounded-out IntRect result.

This rounding out is incorrect because it allows the scaled rectangle to
represent an area that is not actually covered by the document.

We fix this by applying the current transform to the document rect
as a FloatRect and then explicitly converting to IntRect, which
takes the floor of the resulting rectangle coordinates instead of
rounding them out.

This is evidenced by the document.body.scrollWidth() and
document.body.scrollHeight() changing under page scale factor when
they are expected to remain invariant.

Reviewed by James Robinson.

Source/WebCore:

Test: fast/dom/window-scroll-scaling.html

rendering/RenderView.cpp:

(WebCore::RenderView::documentRect):

LayoutTests:

fast/dom/window-scroll-scaling-expected.txt: Added.
fast/dom/window-scroll-scaling.html: Added.

2:46 PM Changeset in webkit [118568] by mitz@apple.com

9 edits in trunk/Source/WebCore

characterBreakIterator() is not safe to use reentrantly or from multiple threads
https://bugs.webkit.org/show_bug.cgi?id=87521

Reviewed by Darin Adler.

Replaced characterBreakIterator() with a NonSharedCharacterBreakIterator class, which
obtains a unique TextBreakIterator. Replaced the global shared instance with a single-entry
cache.

dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData): Changed to use NonSharedCharacterBreakIterator.

platform/graphics/StringTruncator.cpp:

(WebCore::centerTruncateToBuffer): Ditto.
(WebCore::rightTruncateToBuffer): Ditto.

platform/text/String.cpp:

(WebCore::numGraphemeClusters): Ditto.
(WebCore::numCharactersInGraphemeClusters): Ditto.

platform/text/TextBreakIterator.h: Removed the declaration of characterBreakIterator().

(NonSharedCharacterBreakIterator): Added. An instance of this class has a character break
iterator instance that is unique to it for the lifetime of the instance.
(WebCore::NonSharedCharacterBreakIterator::operator TextBreakIterator*): Added.

platform/text/TextBreakIteratorICU.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Added. Tries
to swap the m_iterator member variable with the cached instance. If that fails, initializes
m_iterator to a new character break iterator.
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Added. Tries
to put the m_iterator member variable back in the cache. If that fails, meaning there is
already something in the cache, destroys m_iterator.

platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Same as in
TextBreakIteratorICU.cpp.
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Ditto.
(WebCore::cursorMovementIterator): Moved the old implementation of characterBreakIterator()
here.

platform/text/qt/TextBreakIteratorQt.cpp:

platform/text/wince/TextBreakIteratorWinCE.cpp:

2:42 PM Changeset in webkit [118567] by Simon Fraser

32 edits
8 adds in trunk

Terrible performance on http://alliances.commandandconquer.com/ and http://www.lordofultima.com/
https://bugs.webkit.org/show_bug.cgi?id=84410

Source/WebCore:

Reviewed by Dave Hyatt.

First part of fixing O(N^{2) issues when walking the RenderLayer tree

for computeCompositingRequirements().}

For each layer that goes into the OverlapMap, we were computing an absolute
layer bounds, which requires walking back to the root of the tree.
Optimize this when possible by storing a stack of offsets as we walk
the tree, and using this stack to do the mapping.

The stack of offsets and transforms is managed by RenderGeometryMap.
When visiting a RenderLayer, RenderLayerCompositor pushes onto
the geometry map stack data about offsets and transforms between
the current layer and its stacking-parent. RenderGeometryMap handles
the case where the previous renderer pushed is between the current
renderer and its container. RenderGeometryMap can also handle callers
pushing renderers with multiple containers between them.

RenderGeometryMap stores some flags about whether the set of mapping
steps in the stack involve transforms, fixed position, or special non-uniform
mappings like CSS columns. In some cases, it falls back to mapping via
renderers.

Once constructed, the RenderGeometryMap stack can be used to map multiple
rects or points efficiently. Stacks consisting of simple offsets are
collapsed to a single offset.

Mappings between renderers and their containers are pushed by pushMappingToContainer()
methods, which are similar to mapLocalToContainer() methods. Having this code
in RenderObjects was deemed preferable to handling columns, transforms etc. all in
RenderLayer code.

Tested by assertions in RenderGeometryMap code that its mapping matches
mapping via localToAbsolute() calls.

RenderLayerCompositor::updateCompositingLayers() creates a RenderGeometryMap,
and pushes and pops layer renderers as it visits them. The geometry map is used
by RenderLayerCompositor::addToOverlapMap() when computing absolute layer bounds.

Futher optimizations in RenderGeometryMap are possible, especially with stacks that
have many offsets and a few transforms.

Tests: compositing/geometry/composited-in-columns.html

compositing/geometry/flipped-writing-mode.html

CMakeLists.txt: Add RenderGeometryMap
GNUmakefile.list.am: Ditt
Target.pri: Ditto
WebCore.gypi: Ditto
WebCore.vcproj/WebCore.vcproj: Ditto
WebCore.xcodeproj/project.pbxproj: Ditto
rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::offsetFromContainer):

rendering/RenderBox.h:
rendering/RenderGeometryMap.cpp: Added.

(RenderGeometryMapStep):
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep):
(WebCore::RenderGeometryMapStep::mapPoint):
(WebCore::RenderGeometryMapStep::mapQuad):
(WebCore::RenderGeometryMap::RenderGeometryMap):
(WebCore::RenderGeometryMap::~RenderGeometryMap):
(WebCore::RenderGeometryMap::absolutePoint):
(WebCore::RenderGeometryMap::absoluteRect):
(WebCore::RenderGeometryMap::mapToAbsolute):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::push):
(WebCore::RenderGeometryMap::pushView):
(WebCore::RenderGeometryMap::popMappingsToAncestor):
(WebCore::RenderGeometryMap::stepInserted):
(WebCore::RenderGeometryMap::stepRemoved):

rendering/RenderGeometryMap.h: Added.

(RenderGeometryMap):
(WebCore::RenderGeometryMap::hasNonUniformStep):
(WebCore::RenderGeometryMap::hasTransformStep):
(WebCore::RenderGeometryMap::hasFixedPositionStep):

rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::pushMappingToContainer):

rendering/RenderInline.h:

(RenderInline):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::offsetFromContainer):
(WebCore::RenderObject::container):

rendering/RenderObject.h:
rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer):

rendering/RenderTableCell.h:

(RenderTableCell):

rendering/RenderView.cpp:

(WebCore::RenderView::pushMappingToContainer):

rendering/RenderView.h:
rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::pushMappingToContainer):

rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::pushMappingToContainer):

rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::pushMappingToContainer):

rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::pushMappingToContainer):

rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::pushMappingToContainer):

rendering/svg/RenderSVGText.h:

(RenderSVGText):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::pushMappingToContainer):

rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

Reviewed by Dave Hyatt.

Basic tests for compositing inside columns, and in a flipped-writing-mode
document.

compositing/geometry/composited-in-columns-expected.png: Added.
compositing/geometry/composited-in-columns-expected.txt: Added.
compositing/geometry/composited-in-columns.html: Added.
compositing/geometry/flipped-writing-mode-expected.png: Added.
compositing/geometry/flipped-writing-mode-expected.txt: Added.
compositing/geometry/flipped-writing-mode.html: Added.

2:41 PM Changeset in webkit [118566] by commit-queue@webkit.org

8 edits
2 deletes in trunk/LayoutTests

Acid3 fails in WebKit2 regression tests
https://bugs.webkit.org/show_bug.cgi?id=87187

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-05-25
Reviewed by Alexey Proskuryakov.

Since the link test in the acid3.html relies on visited link tracking
it should call layoutTestController.keepWebHistory() because visited
link tracking is disabled by default to avoid interdependencies between
test.

Update expected files and png's now that the result does not show the
"YOU SHOULD NOT SEE THIS AT ALL" text in red in the top left corner.

http/tests/misc/acid3-expected.png:
http/tests/misc/acid3-expected.txt:
http/tests/misc/acid3.html: Fix test.
platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png:
platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png:
platform/chromium-mac/http/tests/misc/acid3-expected.png:
platform/chromium-mac/http/tests/misc/acid3-expected.txt:
platform/mac-wk2/http/tests/misc/acid3-expected.png: Same as the platform independent result. Removed.
platform/mac-wk2/http/tests/misc/acid3-expected.txt: Same as the platform independent result. Removed.

2:38 PM Changeset in webkit [118565] by kbr@google.com

3 edits
3 copies
4 adds in trunk/LayoutTests

Incorporate new tex-image-and-sub-image-2d-with-video*.html tests
https://bugs.webkit.org/show_bug.cgi?id=87042

Reviewed by James Robinson.

Incorporated current version of video-related WebGL tests from
Khronos repository testing uploading to all packed pixel formats.

fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-video.js: Added.

(generateTest.runOneIteration):
(generateTest.runTest):

fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:

2:36 PM Changeset in webkit [118564] by jberlin@webkit.org

1 edit
2 adds in trunk/LayoutTests

Rebaseline the Windows getComputedStyle results to reflect features
turned off on Windows.

platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Added.
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.

2:28 PM Changeset in webkit [118563] by danakj@chromium.org

4 edits in trunk/Source/WebKit/chromium

[chromium] WebLayerTreeViewImpl should not hide methods in CCLayerTreeHost with signatures that match the Client interface
https://bugs.webkit.org/show_bug.cgi?id=87301

Reviewed by James Robinson.

Most methods in the CCLayerTreeHostClient interface have a matching
method signature on CCLayerTreeHost that simply calls the client, if
one exists at all. However, CCLayerTreeHost::updateAnimations() does
important work in addition to calling the client.

Currently WebLayerTreeViewImpl itself implements the interface for
CCLayerTreeHostClient as well as CCLayerTreeHost, and simply forwards
any call to a method in the client interface to its own client. This
blocks WebViewImpl from calling CCLayerTreeHost::updateAnimations, since
the method is also in the client interface.

We change WebLayerTreeViewImpl to own a CCLayerTreeHost and a
WebLayerTreeHostClientAdapter. This fixes the shadowing by making
the two interfaces separate, and resolves lifetime issues by
ensuring that the CCLayerTreeHost is destroyed before its client.

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit::WebLayerTreeView::setRootLayer):
(WebKit::WebLayerTreeView::compositorIdentifier):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit::WebLayerTreeView::setVisible):
(WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeView::startPageScaleAnimation):
(WebKit::WebLayerTreeView::setNeedsAnimate):
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit::WebLayerTreeView::commitRequested):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::updateAnimations):
(WebKit::WebLayerTreeView::compositeAndReadback):
(WebKit::WebLayerTreeView::finishAllRendering):
(WebKit::WebLayerTreeView::context):
(WebKit::WebLayerTreeView::loseCompositorContext):

src/WebLayerTreeViewImpl.cpp:

(WebKit):
(WebLayerTreeViewClientAdapter):
(WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
(WebKit::WebLayerTreeViewClientAdapter::~WebLayerTreeViewClientAdapter):
(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):

src/WebLayerTreeViewImpl.h:

(WebCore):
(WebKit):
(WebKit::WebLayerTreeViewImpl::layerTreeHost):
(WebLayerTreeViewImpl):

2:17 PM Changeset in webkit [118562] by Simon Fraser

8 edits in trunk/Source/WebCore

Cache absolute clip rects on RenderLayer for compositing overlap testing
https://bugs.webkit.org/show_bug.cgi?id=87212

Reviewed by Dave Hyatt.

Enhance the cache of ClipRects on RenderLayers to store three
different types of ClipRects, rather than just one.

We need to compute clip rects relative to different layers
for different purposes. For painting, we compute relative to
the compositing layer which is acting as a painting root.
For hit testing, we compute relative to the root, except
for transformed layers. For composting overlap testing, we
compute relative to the root ("absolute"). At other times, we do one-off
computation which we never want to cache ("temporary clip rects").

This change allows us to cache rects for hit testing, and for
compositing overlap testing. This has huge performance benefits
on some pages (bug 84410).

This change also makes ClipRects not arena-allocated, so we
can use RefPtr<ClipRect>.

No testable behavior change.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed): No need for the
explicit clipRects teardown, since clipRects don't need a live
RenderObject for arena-based destruction.

rendering/RenderLayer.cpp: Remove arena-related new and delete.

(WebCore::RenderLayer::RenderLayer): No need to explicitly initialize m_clipRects,
since it's an OwnPtr now.
(WebCore::RenderLayer::~RenderLayer): No explicit clipRect teardown required.
(WebCore::RenderLayer::clippingRootForPainting): Renamed to make its purpose
more obvious.
(WebCore::RenderLayer::paintLayer): Use the TemporaryClipRects type when necessary.
(WebCore::RenderLayer::paintLayerContents): Ditto
(WebCore::RenderLayer::hitTestLayer): No longer need to use temporary clipRects when
hit testing since we cache clip rects for hit testing.
(WebCore::RenderLayer::updateClipRects): Take a ClipRectsType and pass it through.
(WebCore::RenderLayer::calculateClipRects): Ditto
(WebCore::RenderLayer::parentClipRects): Ditto
(WebCore::RenderLayer::backgroundClipRect): Ditto
(WebCore::RenderLayer::calculateRects): Take ClipRectsType, which obviates temporaryClipRects.
(WebCore::RenderLayer::childrenClipRect): Use clippingRootForPainting().
(WebCore::RenderLayer::selfClipRect): Ditto
(WebCore::RenderLayer::localClipRect): Ditto
(WebCore::RenderLayer::clearClipRectsIncludingDescendants): Take a type of clip rect to clear
(include all). Allows us to just clear painting clip rects.
(WebCore::RenderLayer::clearClipRects):

rendering/RenderLayer.h:

(WebCore::ClipRects::create): We don't use RefCounted<> in order to use a bit in
the refCount for a flag. Add create() method.
(WebCore::ClipRects::deref): No longer arena-allocated.
(WebCore::ClipRectsCache::ClipRectsCache): Struct that holds a small
array of the 3 types of clipRects (and, in debug, the layer relative
to which they were computed).
(WebCore::RenderLayer::clipRects):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds): Use AbsoluteClipRects; rootLayer
is always the RenderView's layer here.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use TemporaryClipRects.
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore): When this variable changes,
we need to invalidate painting clipRects, since it affects the ancestor relative to which
those rects are computed.

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When the composited state
of a layer changes, we have to clear all descendant clip rects, since this
can affect the layers relative to which clip rects are computed.
(WebCore::RenderLayerCompositor::addToOverlapMap): Use AbsoluteClipRects.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): No need
to call updateLayerPosition(), since that should have always happened after
layout. That call cleared clip rects, so removing it is very beneficial.
(WebCore::RenderLayerCompositor::clippedByAncestor): Use TemporaryClipRects.

rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers): Use TemporaryClipRects.

2:14 PM Changeset in webkit [118561] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Pasting into contenteditable table cell pastes into adjacent cell instead.
https://bugs.webkit.org/show_bug.cgi?id=53933

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-05-25
Reviewed by Darin Adler.

This bug has been fixed. Add a test to make sure that it won't regress.

editing/pasteboard/paste-into-table-cell-2-expected.txt: Added.
editing/pasteboard/paste-into-table-cell-2.html: Added.

2:09 PM Changeset in webkit [118560] by beidson@apple.com

4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=87418
WebBackForwardList should separate "has no current index" from the integer value of the current index

This patch also renames "m_current" to "m_currentIndex" for clarity and symmetry with
other variable names that reference "index",

It also removes the m_closed and m_enabled flags which were never actually used.

Reviewed by Darin Adler.

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::currentIndex):
(WebBackForwardList):

UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

2:07 PM Changeset in webkit [118559] by Beth Dakin

2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=87529
Background tabs hosted in window server flash before painting
when they first become active

Reviewed by Anders Carlsson.

Initialize to LayerHostingModeInWindowServer if that is
available to avoid having to re-make the context and re-set
everything later on.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

2:00 PM Changeset in webkit [118558] by jsbell@chromium.org

1 edit
6 deletes in trunk/LayoutTests

[Chromium] Remove 6 incorrect baselines from http://trac.webkit.org/changeset/117821/

Unreviewed gardening.

platform/chromium-win/fast/viewport/viewport-126-expected.txt: Removed.
platform/chromium-win/fast/viewport/viewport-127-expected.txt: Removed.
platform/chromium-win/fast/viewport/viewport-65-expected.txt: Removed.
platform/chromium-win/fast/viewport/viewport-82-expected.txt: Removed.
platform/chromium-win/fast/viewport/viewport-84-expected.txt: Removed.
platform/chromium-win/fast/viewport/viewport-87-expected.txt: Removed.

1:48 PM Changeset in webkit [118557] by dpranke@chromium.org

6 edits in trunk/Tools

webkitpy: change scm.add(), scm.delete() to accept multiple paths
https://bugs.webkit.org/show_bug.cgi?id=87528

Reviewed by Ojan Vafai.

launching git or svn for individual files can be slow; this
change will hand multiple paths at once to git and svn so they
can be added in a batch.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.add_list):
(Git.delete_list):

Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.add):
(SCM):
(SCM.add_list):
(SCM.delete):
(SCM.delete_list):

Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.add):
(MockSCM):
(MockSCM.add_list):
(MockSCM.delete):
(MockSCM.delete_list):

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(_shared_test_exists):
(_shared_test_added_files):
(_test_delete_list):

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list):
(SVN.delete_list):

1:28 PM Changeset in webkit [118556] by jberlin@webkit.org

2 edits in trunk/LayoutTests

2012-05-25 Jessie Berlin <jberlin@apple.com>

Web Timing is not enabled on Windows
https://bugs.webkit.org/show_bug.cgi?id=42435

Add the fast/performance tests to the Windows Skipped list.

platform/win/Skipped:

1:19 PM Changeset in webkit [118555] by fpizlo@apple.com

15 edits in trunk/Source/JavaScriptCore

DFG ConvertThis should just be a CheckStructure if the structure is known
https://bugs.webkit.org/show_bug.cgi?id=87057

Reviewed by Gavin Barraclough.

Merged r118021 from dfgopt.

This gives ValueProfile the ability to track singleton values - i.e. profiling
sites that always see the same value.

That is then used to profile the structure in op_convert_this.

This is then used to optimize op_convert_this into a CheckStructure if the
structure is always the same.

That then results in better CSE in inlined code that uses 'this', since
previously we couldn't CSE accesses on 'this' from different inline call frames.

Also fixed a bug where we were unnecessarily flushing 'this'.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):

bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):

bytecode/LazyOperandValueProfile.h:

(CompressedLazyOperandValueProfileHolder):

bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(ValueProfileBase):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSValue.h:

(JSValue):

runtime/Structure.h:

(JSC::JSValue::structureOrUndefined):
(JSC):

1:11 PM Changeset in webkit [118554] by jhoneycutt@apple.com

1 edit
1 add in trunk/LayoutTests

2012-05-25 Jessie Berlin <jberlin@apple.com>

File API is not yet supported on Windows
https://bugs.webkit.org/show_bug.cgi?id=37957

Add platform specific results for a test that attempts to use the FileReaderConstructor.

platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.

1:02 PM Changeset in webkit [118553] by dino@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r112155.
http://trac.webkit.org/changeset/112155
https://bugs.webkit.org/show_bug.cgi?id=79389
Hitch (due to style recalc?) when starting CSS3 animation

This caused a number of issues, including:
https://bugs.webkit.org/show_bug.cgi?id=87146
https://bugs.webkit.org/show_bug.cgi?id=84194
<rdar://problem/11506629>
<rdar://problem/11267408>
<rdar://problem/11531859>

dom/Element.cpp:

(WebCore::Element::recalcStyle):

12:50 PM Changeset in webkit [118552] by hyatt@apple.com

8 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87525

For the new multi-column layout, create a flow thread and make sure the children get put inside it.

Reviewed by Eric Seidel.

rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::addChild):
(WebCore):

rendering/RenderMultiColumnBlock.h:

(WebCore):
(RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::flowThread):

rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::~RenderMultiColumnFlowThread):
(WebCore):

rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

rendering/RenderMultiColumnSet.h:
rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::isRenderMultiColumnSet):

12:40 PM Changeset in webkit [118551] by eae@chromium.org

4 edits in trunk/Source/WebCore

Change RenderBoxModelObject to compute relativePositionOffset as size
https://bugs.webkit.org/show_bug.cgi?id=87447

Reviewed by Eric Seidel.

Compute relativePositionOffset as size instead of doing one axis at a
time as all call sites uses the size version of the method. This avoids
having to walk the DOM twice to accumulate the offsets.

Also remove the relativePositionOffsetX and Y methods as they are no
longer used.

No new tests, covered by existing tests.

rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation):

rendering/RenderBoxModelObject.cpp:

(WebCore::accumulateRelativePositionOffsets):
(WebCore::RenderBoxModelObject::relativePositionOffset):

rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

12:40 PM Changeset in webkit [118550] by zandobersek@gmail.com

2 edits in trunk

configure.ac has duplicated AC_MSG_RESULT([$enable_sandbox]) and nothing for seamless iframes
https://bugs.webkit.org/show_bug.cgi?id=87453

Reviewed by Eric Seidel.

Report the value of $enable_iframe_seamless rather than $enable_sandbox
after checking whether to enable the iframe seamless option.

configure.ac:

12:38 PM WebKit Team edited by Dave Barton

(diff)

12:21 PM Changeset in webkit [118549] by commit-queue@webkit.org

3 edits
2 deletes in trunk

Unreviewed, rolling out r118395.
http://trac.webkit.org/changeset/118395
https://bugs.webkit.org/show_bug.cgi?id=87526

Breaking sites including GMail and Yahoo mail (Requested by
jsbell on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-25

Source/WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):

LayoutTests:

fast/css/clear-float-sibling-expected.html: Removed.
fast/css/clear-float-sibling.html: Removed.

12:06 PM Changeset in webkit [118548] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Skip the Network Information tests on Windows.

platform/win/Skipped:

12:05 PM Changeset in webkit [118547] by commit-queue@webkit.org

3 edits in trunk/Tools

[NRWT] Add unit testing for perf tests on locked shards
https://bugs.webkit.org/show_bug.cgi?id=87489

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-25
Reviewed by Dirk Pranke.

Adding utests that makes sure that perf tests are running in locked
shards and by passing --no-http won't break NRWT (r118421).

Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ShardingTests):
(ShardingTests.test_shard_by_dir):
(ShardingTests.test_shard_every_file):
(ShardingTests.test_shard_in_two):
(ShardingTests.test_multiple_locked_shards):
(LockCheckingManager):
(LockCheckingManager.init):
(LockCheckingManager.handle_finished_list):
(ManagerTest.test_http_locking):
(ManagerTest):
(ManagerTest.test_perf_locking):

Scripts/webkitpy/layout_tests/port/test.py:

12:04 PM Changeset in webkit [118546] by jsbell@chromium.org

1 edit
2 deletes in trunk/LayoutTests

[Chromium] Remove 2 incorrect rebaselines from http://trac.webkit.org/changeset/117818/

Unreviewed gardening.

platform/chromium-mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Removed.

11:48 AM Changeset in webkit [118545] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Skip more WebGL tests on Windows.

platform/win/Skipped:

11:36 AM Changeset in webkit [118544] by zandobersek@gmail.com

2 edits in trunk

[Gtk] Remove configuration options that do not apply anymore
https://bugs.webkit.org/show_bug.cgi?id=87509

Reviewed by Martin Robinson.

Remove configuration options for enabling or disabling HTML5 datagrid,
DOM storage, image resizer API and sandboxed iframe support. These
features were either turned on by default with the feature defines
removed from the code or removed from the source.

configure.ac:

11:24 AM Changeset in webkit [118543] by epoger@chromium.org

13 edits
2 adds
8 deletes in trunk/LayoutTests

New baselines for http://crbug.com/129184

Unreviewed rebaselining.

Patch by Elliot Poger <epoger@chromium.org> on 2012-05-25

platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png:
platform/chromium-linux/transforms/svg-vs-css-expected.png:
platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
platform/chromium-mac/svg/transforms/svg-css-transforms-expected.png:
platform/chromium-mac/transforms/svg-vs-css-expected.png:
platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
platform/chromium-win/svg/transforms/svg-css-transforms-expected.png:
platform/chromium-win/transforms/svg-vs-css-expected.png:
platform/efl/svg/filters/subRegion-one-effect-expected.txt: Removed.
platform/efl/svg/filters/subRegion-two-effects-expected.txt: Removed.
platform/gtk/svg/filters/subRegion-one-effect-expected.txt: Removed.
platform/gtk/svg/filters/subRegion-two-effects-expected.txt: Removed.
platform/mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
platform/mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
platform/qt/svg/filters/subRegion-one-effect-expected.txt: Removed.
platform/qt/svg/filters/subRegion-two-effects-expected.txt: Removed.
svg/filters/subRegion-one-effect-expected.txt: Added.
svg/filters/subRegion-two-effects-expected.txt: Added.

11:01 AM Changeset in webkit [118542] by kenrb@chromium.org

2 edits in trunk/Source/WebCore

Layout root not getting cleared for anonymous renderers geting destroyed
https://bugs.webkit.org/show_bug.cgi?id=84002

Reviewed by Abhishek Arya.

This is a follow-up to r109406, which added a check to clear layout
roots when they point to a renderer that is being destroyed. The
thinking was that layout roots would never be anonymous renderers,
but there are some cases where this is not true (in particular,
generated content containers with overflow clips can be layout roots).

As in r109406, this patch has no layout test. This is because any test
that exercises this behavior is caused by an existing layout bug where
a child is not properly getting layout (or a renderer is getting dirtied
out of order during layout) and will fail multiple ASSERTs:

in particular, ASSERT(!m_layoutRoot->container()

!m_layoutRoot->

container()->needsLayout()) in FrameView::scheduleRelayoutOfSubtree(),
and ASSERT_NOT_REACHED() in RenderObject::clearLayoutRootIfNeeded().
We are preventing those bugs from manifesting as security issues with
this patch.

This also removes an ASSERT from the RenderObject destructor. This is
redundant with the condition in RenderObject::clearLayoutRootIfNeeded()
which is always called in RenderObject::willBeDestroyed(), so the check
is not needed. It had to be removed because it fails when I try to
adjust the ASSERT condition by removing the !node()
check, due to RenderWidget clearing its node() during destruction.

rendering/RenderObject.cpp:

(WebCore::RenderObject::~RenderObject):
(WebCore::RenderObject::willBeDestroyed):

10:47 AM Changeset in webkit [118541] by jberlin@webkit.org

2 edits in trunk/LayoutTests

Implement LayoutTest's eventSender.beginDragWithFiles interface in windows platform
https://bugs.webkit.org/show_bug.cgi?id=86296

Add more affected tests to the Windows Skipped list.

platform/win/Skipped:

10:47 AM Changeset in webkit [118540] by jberlin@webkit.org

2 edits in trunk/Tools

[Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
https://bugs.webkit.org/show_bug.cgi?id=87511

Reviewed by Alexey Proskuryakov.

Update the Windows implementation of keyDown to match the Mac one changed in r118001.

DumpRenderTree/win/EventSender.cpp:

(keyDownCallback):

10:28 AM Changeset in webkit [118539] by kenrb@chromium.org

2 edits in trunk/Tools

Adding Ken Buchanan to committers.py
https://bugs.webkit.org/show_bug.cgi?id=87443

Unreviewed.

Adding self to committers.py as a Committer.

Scripts/webkitpy/common/config/committers.py:

10:26 AM Changeset in webkit [118538] by apavlov@chromium.org

5 edits in trunk

Web Inspector: Hangup when continuously changing a css width value in Inspector
https://bugs.webkit.org/show_bug.cgi?id=85802

Reviewed by Vsevolod Vlasov.

Source/WebCore:

An error in the property whitespace prefix detection algorithm would append the previous line trailing whitespace,
thereby enormously increasing the actual prefix during multiple incremental property changes.

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

LayoutTests:

inspector/styles/styles-formatting-expected.txt:
inspector/styles/styles-formatting.html:

10:24 AM Changeset in webkit [118537] by jsbell@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Widen CRASH expectation for visibility-simple-canvas2d-layer.html to include Mac10.6.

Unreviewed gardening.

platform/chromium/test_expectations.txt:

10:14 AM Changeset in webkit [118536] by jsbell@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Remove/restore test expectations for html5lib tests.
https://bugs.webkit.org/show_bug.cgi?id=87275

Unreviewed gardening.

platform/chromium/test_expectations.txt:

10:08 AM Changeset in webkit [118535] by jsbell@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Remove test expectation for video-cookie.html now that the issue
is fixed on the Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=87459

Unreviewed gardening.

platform/chromium/test_expectations.txt:

9:44 AM Changeset in webkit [118534] by jberlin@webkit.org

1 edit
2 deletes in trunk/LayoutTests

Remove the Windows platform-specific results for window-domurl-crash.

r115582 changed this test to use Blob instead of WebKitBlobBuilder, so the fact that Windows
doesn't support WebKitBlobBuilder no longer affects this test.

platform/chromium-win/fast/dom/window-domurl-crash-expected.txt: Removed.
platform/win/fast/dom/window-domurl-crash-expected.txt: Removed.

9:24 AM Changeset in webkit [118533] by apavlov@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: Clean up Inspector.json after r118367
https://bugs.webkit.org/show_bug.cgi?id=87499

Reviewed by Yury Semikhatsky.

This cleans up the semantic inconsistencies introduced into type/field names r118367.

No new tests, as this is a refactoring.

inspector/Inspector.json:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):

inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

inspector/InspectorStyleSheet.h:

(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::canBind):
(InspectorStyleSheetForInlineStyle):

9:23 AM Changeset in webkit [118532] by vsevik@chromium.org

2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

platform/chromium/test_expectations.txt:

9:19 AM Changeset in webkit [118531] by kinuko@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed; rolling chromium deps.

DEPS:

8:49 AM Changeset in webkit [118530] by zhajiang@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] History navigation caused google.com scale not kept
https://bugs.webkit.org/show_bug.cgi?id=87438

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 159923
For back/forward history navigation, we were trying to keep the values
set by dispatchViewportDataDidChange. However, when we went back from
the previous page, if the current page didn't contain the meta viewport
tag, then those values set by previous page would never be reset.
Although the current page could get correct saved scale when restoring
view state, the scale would still be clamped by zoomToFitScale which
was based on the virtual viewport of the previous page which could make
the scale incorrect.
Since we know the viewport arguments of the current document before
setLoadState on back/forward history navigation, we can reset these
previous values if the document doesn't have viewport arguments during
setLoadState.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

8:40 AM Changeset in webkit [118529] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: speed-up HeapSnapshot._bfs method.
https://bugs.webkit.org/show_bug.cgi?id=87502

It had containmentEdges.length call in the loop that forced deoptimization.

Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):

8:32 AM Changeset in webkit [118528] by loislo@chromium.org

4 edits in trunk

Web Inspector: Speed up edges iteration in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=87286

Add an extra node to nodes array that points to the end of edges array.
It allows to eliminate a check for the last node in iteration code.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-25
Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest._postprocessHeapSnapshotMock):

8:16 AM Changeset in webkit [118527] by caseq@chromium.org

8 edits
1 add in trunk/Source/WebCore

Web Inspector: put paint and compositing timeline events in a new category of their own
https://bugs.webkit.org/show_bug.cgi?id=86852

Reviewed by Pavel Feldman.

add forth timeline category, "Painting"; make it light-purple;
assign paint and compositing events to Painting category;

WebCore.gypi: added timelineBarLightPurple.png;
inspector/front-end/Images/timelineBarLightPurple.png: Added.
inspector/front-end/Images/timelineCheckmarks.png: added light-purple icon;
inspector/front-end/Images/timelineDots.png: ditto.
inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord): do not merge bars in same raw if these are from different categories;
(WebInspector.TimelineCategoryStrips.prototype.update):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):

inspector/front-end/WebKit.qrc: added timelineBarLightPurple.png;
inspector/front-end/timelinePanel.css: added styles for painting category;

(.timeline-category-statusbar-item.timeline-category-painting .timeline-category-checkbox):
(.timeline-category-painting .timeline-graph-bar):
(.popover .timeline-painting):
(.timeline-category-scripting .timeline-tree-icon):
(.timeline-category-rendering .timeline-tree-icon):
(.timeline-category-painting .timeline-tree-icon):

8:04 AM Changeset in webkit [118526] by mary.wu@torchmobile.com.cn

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pass http headers to loader in download request
https://bugs.webkit.org/show_bug.cgi?id=87449

Reviewed by Rob Buis.

PR# 149283

This is to support byte-range download and we could pass http headers like
"Range" in download request to loader.

Reviewed internally by Lyon Chen.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::download):

7:47 AM Changeset in webkit [118525] by wjmaclean@chromium.org

5 edits in trunk/Source

[chromium] LayerChromium should recognise existing layer active animations when the layer is added.
https://bugs.webkit.org/show_bug.cgi?id=87166

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added.

LayerChromium needs to correctly recognize if a newly added layer has an existing
active animation.

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::notifyAnimationFinished):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::didAddAnimationWasCalled):
(MockLayerTreeHost):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF):
(CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::afterTest):

7:05 AM Changeset in webkit [118524] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118166, r118291 and r118442.

platform/gtk/test_expectations.txt:

6:48 AM Changeset in webkit [118523] by loislo@chromium.org

4 edits in trunk

Web Inspector: HeapSnapshot: introduce performance counter for HeapSnapshotConstructorsDataGrid._aggregatesReceived method.
https://bugs.webkit.org/show_bug.cgi?id=87393

Reviewed by Yury Semikhatsky.

PerformanceTests:

inspector/heap-snapshot.html:

Source/WebCore:

inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._aggregatesReceived):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._populateChildren):

6:45 AM Changeset in webkit [118522] by mario@webkit.org

8 edits
2 adds in trunk/Source/WebKit2

[GTK][WK2] Implement API for generic permission requests
https://bugs.webkit.org/show_bug.cgi?id=84018

Reviewed by Martin Robinson.

Added new 'permission-request' signal to WebKitWebView, to be
fired when WebKit needs confirmation from the user on whether to
allow or deny certain operations, such as sharing the user's
location with web site through the Geolocation API.

New WebKitPermissionRequest interface, providing allow() and
deny() operations, to be called over the objects implementing it
when emitted along with the new 'permission-request' signal.

UIProcess/API/gtk/WebKitPermissionRequest.cpp: Added.

(webkit_permission_request_default_init):
(webkit_permission_request_allow):
(webkit_permission_request_deny):

UIProcess/API/gtk/WebKitPermissionRequest.h: Added.

(_WebKitPermissionRequestIface):

GNUmakefile.am: Added new files.

Added the new signal to WebKitWebView, providing a default handler
that will just deny the request when the signal is not handled.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewDecidePermissionRequest): Default handler.
(webkit_web_view_class_init): Declare the new signal and connect
to the default handler.
(webkitWebViewMakePermissionRequest): Helper function to create a
make a new permission request and emit the new signal signal.

UIProcess/API/gtk/WebKitWebView.h:

(_WebKitWebViewClass):

UIProcess/API/gtk/WebKitWebViewPrivate.h: Declare the creational

function webkitWebViewMakePermissionRequest for internal use only.

Updated documentation files.

UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

6:42 AM Changeset in webkit [118521] by loislo@chromium.org

6 edits in trunk

Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric.
https://bugs.webkit.org/show_bug.cgi?id=87490

Originally WebInspector.Uint32Array was used for dynamic array
reallocation because we had no information about expected arrays sizes.
Now we have these sizes and allocates array precisely.

Reviewed by Yury Semikhatsky.

Source/WebCore:

bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore):

inspector/front-end/HeapSnapshot.js:
inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

LayoutTests:

inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):

6:10 AM Changeset in webkit [118520] by apavlov@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: cmd-[ shortcut navigates page and is fr-keyboard incompatible
https://bugs.webkit.org/show_bug.cgi?id=85312

Reviewed by Vsevolod Vlasov.

Suppress the handling of panel history navigation events if the corresponding keyboard activities produce
the "keypress" event (which is the case on French keyboards, where AltGr+[ is translated into Ctrl+Alt+[ on Windows).
The event is also told to preventDefault() to avoid browser history navigation on Mac while traversing the Inspector panel history.

inspector/front-end/InspectorView.js:

(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._keyPress):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._keyDownInternal):

inspector/front-end/UIUtils.js:

(WebInspector.isWin):

6:08 AM Changeset in webkit [118519] by yurys@chromium.org

2 edits in trunk/Source/WebCore

2012-05-25 Yury Semikhatsky <yurys@google.com>

Unreviewed. Fixed closure compiler warnings.

inspector/front-end/NativeMemorySnapshotView.js: (WebInspector.NativeMemoryProfileType.prototype.buttonClicked): (WebInspector.NativeMemoryProfileHeader.prototype.createView):

6:05 AM Changeset in webkit [118518] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] fix compilation warning in GtkInputMethodFilter.cpp
https://bugs.webkit.org/show_bug.cgi?id=87475

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-25
Reviewed by Martin Robinson.

platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setWidget):

6:04 AM Changeset in webkit [118517] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

[GTK] fix compilation for webkitwebview.cpp
https://bugs.webkit.org/show_bug.cgi?id=87473

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-25
Reviewed by Martin Robinson.

When ACCELERATED_COMPOSITING and TEXTURE_MAPPER_GL is not set,
the local variable 'priv' won't be used. Therefore the following warning:

../../../Source/WebKit/gtk/webkit/webkitwebview.cpp: In function ‘void webkit_web_view_realize(GtkWidget*)’:
../../../Source/WebKit/gtk/webkit/webkitwebview.cpp:971:27: warning: unused variable ‘priv’ [-Wunused-variable]

webkit/webkitwebview.cpp:

(webkit_web_view_realize):

5:54 AM Changeset in webkit [118516] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] fast/forms/color/input-value-sanitization-color.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=87487

Unreviewed EFL gardening. Unskip
fast/forms/color/input-value-sanitization-color.html now that
INPUT_TYPE_COLOR flag has been enabled by default for EFL port in
r114113.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-25

platform/efl/Skipped:

5:24 AM Changeset in webkit [118515] by commit-queue@webkit.org

14 edits in trunk/LayoutTests

[EFL] [DRT] Gardening of failing tests and missing results
https://bugs.webkit.org/show_bug.cgi?id=87486

Unreviewed EFL gardening. Some rebaselines after r118448, and updated
expectations for a couple of tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-25

platform/efl/fast/html/details-position-expected.txt:
platform/efl/fast/replaced/width100percent-checkbox-expected.png:
platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
platform/efl/fast/replaced/width100percent-radio-expected.png:
platform/efl/fast/replaced/width100percent-radio-expected.txt:
platform/efl/mathml/presentation/fractions-expected.png:
platform/efl/mathml/presentation/fractions-expected.txt:
platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
platform/efl/mathml/presentation/mo-stretch-expected.png:
platform/efl/mathml/presentation/mo-stretch-expected.txt:
platform/efl/mathml/presentation/subsup-expected.txt:
platform/efl/test_expectations.txt:

5:18 AM Changeset in webkit [118514] by commit-queue@webkit.org

3 edits
1 add in trunk

[Qt] Broken controls rendering when transform is applied.
https://bugs.webkit.org/show_bug.cgi?id=87483

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-25
Reviewed by Simon Hausmann.

ManualTests/qt/control_paiting_with_transforms.html: Added.

Source/WebCore:

Use only the scaling transform value to determine the size of
the control to be drawn. When other transforms present such as
rotate or skew, ignore them, unless scaling also involved. In
that case, calculate the scaling value out of the transformation.

ManualTests/qt/control_paiting_with_transforms.html: Added.

platform/qt/RenderThemeQtMobile.cpp:

(WebCore::painterScale):
(WebCore):
(WebCore::StylePainterMobile::sizeForPainterScale):

5:05 AM Changeset in webkit [118513] by caseq@chromium.org

15 edits
1 add in trunk/Source

[chromium] add instrumentation for compositing
https://bugs.webkit.org/show_bug.cgi?id=83928

Reviewed by James Robinson.

Source/Platform:

added willCommit() and didBeginFrame() methods for instrumentation of compositing.

chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

plumb willCommit() and didBeginFrame() from CCSingleThreadProxy and CCThreadProxy to inspector instrumentation;
note for threaded case, didBeginFrame() is invoked upon unblocking of main thread;

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(WebCore::CCLayerTreeHost::didBeginFrame):
(WebCore::CCLayerTreeHost::willCommit):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):

Source/WebKit/chromium:

plumb willCommit() and didComposite() to inspector instrumentation via WebViewImpl.

WebKit.gypi: Added WebLayerTreeViewTest
src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didBeginFrame):
(WebKit):
(WebKit::WebLayerTreeViewImpl::willCommit):

src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didBeginFrame):
(WebKit):
(WebKit::WebViewImpl::willCommit):

src/WebViewImpl.h:

(WebViewImpl):

tests/CCLayerTreeHostTest.cpp:
tests/FakeCCLayerTreeHostClient.h:
tests/WebLayerTest.cpp:
tests/WebLayerTreeViewTest.cpp: Added.

4:20 AM Changeset in webkit [118512] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Gardening. Skip a new test: fast/events/domactivate-sets-underlying-click-event-as-handled.html
because it times out on Qt and GTK platforms.

Patch by János Badics <János Badics> on 2012-05-25
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped:

3:34 AM Changeset in webkit [118511] by Csaba Osztrogonác

11 edits in trunk

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=87257

Reviewed by Simon Hausmann.

Source/WebKit/qt:

Api/qgraphicswebview.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
Api/qwebframe.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
Api/qwebhistory.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
Api/qwebsettings.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
Api/qwebview.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
WebCoreSupport/FrameLoaderClientQt.cpp: Adjust QCoreApplication::translate() parameter list to newer Qt 5.

(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):

declarative/experimental/plugin.cpp: QDeclarativeExtensionPlugin -> QQmlExtensionPlugin renaming.
declarative/plugin.cpp: QDeclarativeExtensionPlugin -> QQmlExtensionPlugin renaming.

(WebKitQmlPlugin):

Tools:

MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.

3:23 AM Changeset in webkit [118510] by vsevik@chromium.org

10 edits
1 delete in trunk/Source/WebCore

Web Inspector: Drop InspectorFileSystemInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=87460

Inspector does not need to track DOMFileSystem object now. So we can
drop InspectorFileSystemInstrumentation.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-05-25
Reviewed by Vsevolod Vlasov.

GNUmakefile.list.am:
Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorFileSystemAgent.cpp:

(WebCore::InspectorFileSystemAgent::enable):

inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

inspector/InspectorFileSystemInstrumentation.h: Removed.
inspector/InspectorInstrumentation.cpp:

(WebCore):

inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):

3:15 AM Changeset in webkit [118509] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: HeapProfiler: speed-up _calculateClassesRetainedSize and _buildAggregates.
https://bugs.webkit.org/show_bug.cgi?id=87482

Engine didn't inline node's classIndex method because the switch statement in it wasn't inlineable.

Reviewed by Yury Semikhatsky.

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.classIndex):

3:09 AM Changeset in webkit [118508] by kling@webkit.org

2 edits in trunk/Source/WebCore

Dodge style recalc when id attribute is overwritten with same value.
<http://webkit.org/b/87211>

Reviewed by Eric Seidel.

Don't force style recalc when the id attribute is set to the same value it already had.
~3.5% improvement on Dromaeo's "dom-attr" locally.

dom/Element.cpp:

(WebCore::Element::attributeChanged):

3:05 AM Changeset in webkit [118507] by kinuko@chromium.org

4 edits in branches/chromium/1132

Merge 118497 - [chromium] DataTransferItem.webkitGetAsEntry() shouldn't be exposed without flag yet
https://bugs.webkit.org/show_bug.cgi?id=87457
BUG=129702
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10448022

3:05 AM Changeset in webkit [118506] by g.czajkowski@samsung.com

2 edits in trunk/Source/WebKit2

[WK2] Fix client interface size for WKPageContextMenuClient.
https://bugs.webkit.org/show_bug.cgi?id=87472

Reviewed by Carlos Garcia Campos.

Add correct offset for version 1 and 2 of WKPageContextMenuClient.
Revision 109750 introduces a new API and increases size of interfaceSizesByVersion
but the table is not properly initialized for newly introduced version 2.

Shared/APIClientTraits.cpp:

(WebKit):

3:02 AM Changeset in webkit [118505] by kling@webkit.org

3 edits in trunk/Source/WebKit2

Mac bots crashing under PluginInfo destructor.
<http://webkit.org/b/87414>
<rdar://problem/11527172>

Reviewed by Darin Adler.

We can't safely pass WTF::String to another thread without a deref() race,
so pass the PluginInfo vector by pointer instead of by value.

UIProcess/WebContext.cpp:

(WebKit::WebContext::sendDidGetPlugins):
(WebKit::WebContext::handleGetPlugins):

UIProcess/WebContext.h:

2:49 AM Changeset in webkit [118504] by yurys@chromium.org

8 edits
1 add in trunk/Source/WebCore

Web Inspector: add profile type for native memory snapshots
https://bugs.webkit.org/show_bug.cgi?id=87400

Reviewed by Vsevolod Vlasov.

Introduced new profile type and view classes for native memory snapshots.
All the stuff is hidden behind an experimental setting.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/NativeMemorySnapshotView.js: Added.

(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemorySnapshotView.prototype.dispose):
(WebInspector.NativeMemorySnapshotView.prototype.get statusBarItems):
(WebInspector.NativeMemorySnapshotView.prototype.get profile):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.get buttonTooltip):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryProfileType.prototype.get treeItemTitle):
(WebInspector.NativeMemoryProfileType.prototype.get description):
(WebInspector.NativeMemoryProfileType.prototype.createTemporaryProfile):
(WebInspector.NativeMemoryProfileType.prototype.createProfile):
(WebInspector.NativeMemoryProfileHeader):
(WebInspector.NativeMemoryProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.NativeMemoryProfileHeader.prototype.createView):

inspector/front-end/ProfilesPanel.js:
inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

2:44 AM Changeset in webkit [118503] by yurys@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: make some profiler methods private
https://bugs.webkit.org/show_bug.cgi?id=87479

Reviewed by Vsevolod Vlasov.

Removed unused methods.
Renamed private methods so that their names start with underscore.
ProfileLauncherView methods are called directly from ProfilesPanel instead of sending events.

inspector/front-end/CPUProfileView.js:
inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):

inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.profileStarted):
(WebInspector.ProfileLauncherView.prototype.profileFinished):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot.done):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

2:41 AM Changeset in webkit [118502] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][DRT] Gardening. fast/events/option-tab.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=87471

Unreviewed. fast/events/option-tab.html should not pass as the
EFL port uses different keyboard accelerators than Safari (via Chromium).

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-25

platform/efl/test_expectations.txt:

2:30 AM Changeset in webkit [118501] by keishi@webkit.org

3 edits
2 adds in trunk

Bad checkValidity result on recently "enabled" form fields
https://bugs.webkit.org/show_bug.cgi?id=85704

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/disabled-attr-checkvalidity.html

We were tripping on the assertion m_isValid == validity()->valid()
inside HTMLFormControlElement::isValidFormControlElement.
m_isValid was becoming stale because setNeedsValidityCheck wasn't called
after m_willValidate changed.

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::willValidate): We used const_cast
because it was too difficult to remove const. We are checking if the
value from willValidate has changed to avoid an infinite loop.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

LayoutTests:

fast/forms/disabled-attr-checkvalidity-expected.txt: Added.
fast/forms/disabled-attr-checkvalidity.html: Added.

2:28 AM Changeset in webkit [118500] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r118448. Added rebaseline to 2 tests on Qt platform that
had 1 pixel differences because of rounding mistakes.

Patch by János Badics <János Badics> on 2012-05-25

platform/qt/fast/html/details-position-expected.txt:
platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

2:21 AM Changeset in webkit [118499] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Pasting text in input field is not available if <body> has visibility:hidden
https://bugs.webkit.org/show_bug.cgi?id=66754

Reviewed by Kent Tamura.

Add a regression test since this bug has been fixed by r99076.

editing/pasteboard/input-with-visibility-hidden-expected.txt: Copied from input-with-display-none-div-expected.txt.
editing/pasteboard/input-with-visibility-hidden.html: Copied from input-with-display-none-div.html.

2:21 AM Changeset in webkit [118498] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Pull in Android tools from Chromium's repo through the DEPS file
https://bugs.webkit.org/show_bug.cgi?id=87478

Reviewed by Kent Tamura.

Chromium's r122048 added the forwarder tool, which forwards a TCP port
listening on the device to a port on the host. This now is a required
dependency of DumpRenderTree, so pull it in.

Since it's likely that more tools will be required, pull in the entire
tools/android/ directory in case the Chromium port for Android is being
checked out or updated.

DEPS: Added Android-specific dependency on tools/android/

2:13 AM Changeset in webkit [118497] by kinuko@chromium.org

4 edits in trunk

[chromium] DataTransferItem.webkitGetAsEntry() shouldn't be exposed without flag yet
https://bugs.webkit.org/show_bug.cgi?id=87457

Reviewed by Kent Tamura.

Source/WebCore:

No new tests, marking some tests SKIP as we stop exposing this by default.

Modules/filesystem/DataTransferItemFileSystem.idl: Removed webkitGetAsEntry

LayoutTests:

platform/chromium/test_expectations.txt: Marking tests using webkitGetAsEntry SKIP

2:01 AM Changeset in webkit [118496] by loislo@chromium.org

2 edits in trunk/PerformanceTests

Web Inspector: HeapProfiler's perf test: each N-th run pushes the run results N-th times.
https://bugs.webkit.org/show_bug.cgi?id=87476

The time tracking wrappers were attaching on each run.

Reviewed by Yury Semikhatsky.

inspector/heap-snapshot.html:

1:51 AM Changeset in webkit [118495] by commit-queue@webkit.org

6 edits in trunk

RadioNodeList does not include a object element
https://bugs.webkit.org/show_bug.cgi?id=87371

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-25
Reviewed by Kent Tamura.

Source/WebCore:

As per spec http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-listed
Object element should also be listed in RadioNodeList object.

Updated existing test.

html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
Compares if test element's name/id and form matches that of the RadioNodeList filter.
(WebCore::RadioNodeList::nodeMatches):
Added support for Object element, check if object elements name/id matches the RadioNodeList filter.

html/RadioNodeList.h:

(RadioNodeList): Ditto

LayoutTests:

fast/forms/form-collection-radio-node-list-expected.txt:
fast/forms/form-collection-radio-node-list.html:

Updated test to include test for object element.

1:41 AM Changeset in webkit [118494] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Unreviewed fix after r118484.

Enable CSS_EXCLUSIONS and CSS_REGIONS.
They were enabled uncoditinally before r118484.

qmake/mkspecs/features/features.pri:

1:29 AM Changeset in webkit [118493] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit2

[Qt][WK2] Fix failing qmltests::FitToView::test_basic()
https://bugs.webkit.org/show_bug.cgi?id=87236

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-25
Reviewed by Kenneth Rohde Christiansen.

Rename contentViewportChanged to informVisibleContentChange() to
reflect its functionality better. Centralize m_hadUserInteraction flag
setting and add assertions on it to ensure that designated
functions are called only on user interaction.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_onInformVisibleContentChange):
(QQuickWebViewFlickablePrivate::_q_resume):

UIProcess/API/qt/qquickwebview_p.h:
UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::_q_onInformVisibleContentChange):
(QQuickWebViewFlickablePrivate):

UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::touchBegin):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

1:09 AM Changeset in webkit [118492] by caseq@chromium.org

4 edits in trunk

Web Inspector: Resource object has no methods getContent and setContent
https://bugs.webkit.org/show_bug.cgi?id=87424

Source/WebCore:

This fixes the extension API so that it uses the new Resource()
constructor, which adds the missing getContent and setContent
methods to a Resource object.

Patch by Jan Keromnes <janx@linux.com> on 2012-05-25
Reviewed by Vsevolod Vlasov.

The tests were fixed accordingly in:
LayoutTests/inspector/extensions/extensions-resources-expected.txt

inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):

LayoutTests:

This fixes the expected test result for handleOpenResource(), see fix
for bug #87424 in Source/WebCore/inspector/front-end/ExtensionAPI.js.

Patch by Jan Keromnes <janx@linux.com> on 2012-05-25
Reviewed by Vsevolod Vlasov.

inspector/extensions/extensions-resources-expected.txt:

1:00 AM Changeset in webkit [118491] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/efl

[EFL] API for PageGroup visited links hash populating
https://bugs.webkit.org/show_bug.cgi?id=86370

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-25
Reviewed by Kenneth Rohde Christiansen.

Added "populate,visited,links" ewk_view signal that tells to the client managing
persistent history storage to fill the visited links cache.
Added API for the PageGroup visited links hash populating.

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::populateVisitedLinks): Implementation added (sends notification).
(WebCore):

WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_visited_link_add): PageGroup visited links hash populating.

ewk/ewk_view.h:

12:56 AM Changeset in webkit [118490] by vsevik@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r118461.
http://trac.webkit.org/changeset/118461
https://bugs.webkit.org/show_bug.cgi?id=87468

Breaks two chromium browser_tests. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-25

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):

12:41 AM Changeset in webkit [118489] by vsevik@chromium.org

1 edit
4 adds in trunk/LayoutTests

Unreviewed chromium test expectations rebaseline.

platform/chromium-mac-leopard/editing/spelling/grammar-markers-expected.png: Added.
platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png: Added.
platform/chromium-mac/editing/spelling/grammar-markers-expected.png: Added.
platform/chromium-win/editing/spelling/grammar-markers-expected.png: Added.

12:31 AM Changeset in webkit [118488] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

platform/qt/Skipped:

12:26 AM Changeset in webkit [118487] by commit-queue@webkit.org

2 edits
8 adds in trunk/LayoutTests

Add tests for JPEG and PNG images with a non-generic RGB color profile
https://bugs.webkit.org/show_bug.cgi?id=87437

No layout test currently covers a color transform except for the no-op case of a
Generic RGB profile (image) -> Generic RGB profile (screen) color transform. Add
tests for JPEG and PNG images with a non-identity color correction transform, in
particular, use test images with a (non-generic) RGB color profile.

Patch by Tony Payne <tpayne@chromium.org> on 2012-05-25
Reviewed by Kent Tamura.

fast/images/jpeg-with-color-profile-expected.txt: Added.
fast/images/jpeg-with-color-profile.html: Added.
fast/images/png-with-color-profile-expected.txt: Added.
fast/images/png-with-color-profile.html: Added.
fast/images/resources/red-at-12-oclock-with-color-profile.jpg: Added. The image

has an RGB color profile (non-generic). If color correction is correctly applied,
the image red sector appears at the 12 o'clock position. If color correction fails,
the red sector appears at 4 o'clock.

fast/images/resources/red-at-12-oclock-with-color-profile.png: Added, and ditto

for the expected image red sector position and image color profile type.

platform/chromium/test_expectations.txt: Add MISSING expectations.
platform/mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png: Added.
platform/mac-snowleopard/fast/images/png-with-color-profile-expected.png: Added.

12:22 AM Changeset in webkit [118486] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test.

platform/qt/Skipped:

12:10 AM Changeset in webkit [118485] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a passing test and mark it as SLOW.

platform/qt/Skipped:
platform/qt/test_expectations.txt:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed