Timeline
May 28, 2012:
- 11:44 PM Changeset in webkit [118727] by
-
- 2 edits in trunk/LayoutTests
[Qt] New fast/dom/window-scroll-scaling.html made 3-400 tests flakey
https://bugs.webkit.org/show_bug.cgi?id=87700
Unreviewed gardening to paint the bot less and less red.
- platform/qt/Skipped: Skip fast/dom/window-scroll-scaling.html until proper fix.
- 11:42 PM Changeset in webkit [118726] by
-
- 18 edits in trunk/Source/WebCore
[V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=87692
Reviewed by Adam Barth.
Since v8::Null(isolate) crashes if we pass a NULL isolate, we are planning
to pass Isolate to v8::Null() in the following steps:
[1] Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check.
If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise,
v8Null(isolate) calls v8::Null(isolate).
[2] In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a non-optional
'isolate' parameter. (e.g. void foo(..., Isolate* isolate) { v8::Null(); } )
[3] In V8 bindings, we replace v8::Null() with v8Null(isolate) for an optional
'isolate' parameter. (e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )
This bug fixes [1] by implementing V8Binding::v8Null(isolate). Also this patch uses
V8Binding::v8Null(isolate) in bindings/v8/*.{h,cpp}.
No tests. No behavior change.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(NativeToJSValue):
- bindings/scripts/test/V8/V8Float64Array.h:
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- bindings/v8/V8Binding.h:
(WebCore::v8Null):
(WebCore):
(WebCore::v8DateOrNull):
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(WebCore):
- 10:37 PM Changeset in webkit [118725] by
-
- 8 edits in trunk
Fix a crash in HTMLFormControlElement::disabled().
https://bugs.webkit.org/show_bug.cgi?id=86534
Reviewed by Ryosuke Niwa.
Source/WebCore:
Stop to hold pointers of fildset and legend elements. We can avoid it by
holding ancestor's disabled state.
The ancesotr's disabled state should be invalidated when
- fieldset's disabled value is changed.
- fieldset's children is updated because a legend position might be changed.
- A form control is attached to or detached from a tree.
No new tests. It's almost impossible to make a reliable test.
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Added. Invalidate disabled state of form controls under the specified node.
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
Uses invalidateDisabledStateUnder().
(WebCore::HTMLFieldSetElement::childrenChanged):
Added new override function. We need invalidate disabled state of form
controls under legend elements.
- html/HTMLFieldSetElement.h:
(HTMLFieldSetElement): Add invalidateDisabledStateUnder() and childrenChanged().
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
Remove initialization of the removed data members.
Initialize m_ancestorDisabledState.
(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
Update m_ancestorDisabledState. It should be
AncestorDisabledStateDisabled if the control is under a disabled
fieldset and not under the first legend child of the disabled filedset.
(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Invalidate m_ancestorDisabledState.
(WebCore::HTMLFormControlElement::insertedInto): ditto.
(WebCore::HTMLFormControlElement::removedFrom): ditto.
(WebCore::HTMLFormControlElement::disabled):
Calls updateAncestorDisabledState() if needed.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Remove unnecessary check for m_legendAncestor.
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- Rename updateFieldSetAndLegendAncestor() to updateAncestorDisabledState(), and make it private.
- Remove m_fieldSetAncestor, m_legendAncestor, and m_fieldSetAncestorValid.
- Add m_ancestorDisabledState.
LayoutTests:
Add a testcase to confirm <lagend> doesn't affect validation.
- fast/forms/datalist/datalist-child-validation-expected.txt:
- fast/forms/datalist/datalist-child-validation.html:
- 10:16 PM Changeset in webkit [118724] by
-
- 2 edits in trunk/LayoutTests
Removes pixel result requirements from fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87663
Unreviewed gardening.
This test was added by r118612, but no pixel result were provided.
It seems that it's enough to remove the param for dumpAsText() and just use the text text output.
- fast/layers/clip-rects-assertion.html:
- 10:15 PM Changeset in webkit [118723] by
-
- 11 edits in trunk
[WebSocket] Receiving reserved close codes, 1005, 1006, and 1015 must appear as code=1006 and wasClean=false
https://bugs.webkit.org/show_bug.cgi?id=87084
Reviewed by Kent Tamura.
Source/WebCore:
Status codes 1005, 1006, and 1015 are forbidden to be sent in actual close frames.
If a client received these frames, the client should handle them as broken.
Close frames containing invalid body size are the same as these forbidden cases.
Update close-code-and-reason tests to verify this patch.
- Modules/websockets/WebSocket.cpp: Handle AbnormalClosure as wasClean == false
(WebCore::WebSocket::didClose):
- Modules/websockets/WebSocketChannel.cpp: Handle close frames' status code carefully
(WebCore::WebSocketChannel::processFrame):
- Modules/websockets/WebSocketChannel.h: Update on newly defined close event codes
Source/WebKit/chromium:
Update close event codes corresponding to WebSocketChannel::CloseEventCode.
- public/WebSocket.h: Update on newly defined close event codes
LayoutTests:
Add test cases where server initiates a closing handshake with forbidden status codes.
- http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
- http/tests/websocket/tests/hybi/close-code-and-reason.html:
- http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
- http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:
(WebSocketTest.prototype.onclose):
- 9:11 PM Changeset in webkit [118722] by
-
- 5 edits in trunk/Source/WebCore
[V8] Avoid passing NULL to an 'isolate' parameter
https://bugs.webkit.org/show_bug.cgi?id=87689
Reviewed by Adam Barth.
v8::Null(isolate) crashes if we pass a NULL isolate.
Thus we are planning to replace v8::Null()s in a following way:
- Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check.
If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise,
v8Null(isolate) calls v8::Null(isolate).
- In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a
non-optional 'isolate' parameter.
(e.g. void foo(..., Isolate* isolate) { v8::Null(); } )
- In V8 bindings, we replace v8::Null() with v8Null(isolate) for an
optional 'isolate' parameter.
(e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )
However, currently we cannot do the replacement mechanically, since some code
pass NULL to a non-optional 'isolate' parameter. In other words, currently
"non-optional" does not guarantee that 'isolate' is not NULL.
This patch removes all the code that passes NULL to a non-optional 'isolate'
parameter. This will enable us to achieve the replacement mechanically.
No tests. No behavior change.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation):
(NativeToJSValue):
- bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::installPerContextProperties):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):
- 9:08 PM Changeset in webkit [118721] by
-
- 5 edits2 adds in trunk
Form controls in <fieldset disabled> should not be validated.
https://bugs.webkit.org/show_bug.cgi?id=87381
Reviewed by Hajime Morita.
Source/WebCore:
We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.
Test: fast/forms/fieldset/validation-in-fieldset.html
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
- Do not traverse this.
- Calls ancestorDisabledStateWasChanged() instead of setNeedsStyleRecalc() because we'd like to do additional tasks.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
LayoutTests:
- fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
- fast/forms/fieldset/validation-in-fieldset.html: Added.
- 9:05 PM AddingFeatures edited by
- Add another CMake-related file that should be changed. (diff)
- 8:57 PM Changeset in webkit [118720] by
-
- 9 edits4 adds in trunk
[Forms] HTMLFieldSetElement.idl doesn't have elements attribute.
https://bugs.webkit.org/show_bug.cgi?id=80110
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-28
Reviewed by Kent Tamura.
Source/WebCore:
Implemented elements attribute for HTMLFieldSetElement. This is spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-fieldset-elements
Tests: fast/forms/fieldset/fieldset-elements.html
fast/forms/fieldset/fieldset-form-collection-radionode-list.html
- dom/Node.cpp:
(WebCore::Node::radioNodeList):
Extended ASSERT to assert if not HTMLFieldSetElement or HTMLFormElement.
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
Elements attribute implementation.
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):
Update the formcontrol elements collections if dom tree got modified.
(WebCore::HTMLFieldSetElement::associatedElements):
FormControl elements collection accessor.
(WebCore::HTMLFieldSetElement::length):
Number of elements in the fieldset group.
- html/HTMLFieldSetElement.h:
Added elements collection member and form control collection members.
- html/HTMLFieldSetElement.idl:
Added elements attribute.
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::formControlElements):
Added support for HTMLFieldSetElement, based on base element type gets its associated elements.
(WebCore::HTMLFormCollection::numberOfFormControlElements): Ditto
(WebCore::HTMLFormCollection::getNamedFormItem): Process image elements only for form element.
(WebCore::HTMLFormCollection::updateNameCache): Ditto
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
DynamicSubTree root element is decided based on the type whether base element is form or fieldset element.
Renamed m_formElement to m_baseElement.
(WebCore::RadioNodeList::~RadioNodeList):
Renamed m_formElement to m_baseElement.
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
Form element specific changes moved under form element check.
- html/RadioNodeList.h:
(WebCore::RadioNodeList::create):
(RadioNodeList):
Renamed m_formElement to m_baseElement.
LayoutTests:
- fast/forms/fieldset/fieldset-elements-expected.txt: Added.
- fast/forms/fieldset/fieldset-elements.html: Added.
- fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt: Added.
- fast/forms/fieldset/fieldset-form-collection-radionode-list.html: Added.
- 8:49 PM Changeset in webkit [118719] by
-
- 11 edits in trunk
[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135
Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by Rob Buis.
Source/WebCore:
RIM PR: 145660
Fixed a regression introduced by r111810, we should cancel the new
request when user press cancel button in http authentication challenge
dialog, and we should also allow sending empty username and password
with the request.
Also removed redundant codes which checked the existence of the
FrameLoaderClient pointer, as we've already moved authenticationChallenge()
out of class FrameLoaderClient, it is not needed.
Manual test added. Testing http authentication dialog relies on user interaction.
Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.
Internally reviewed by Joe Mason <jmason@rim.com>
- platform/blackberry/PageClientBlackBerry.h:
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
Source/WebKit/blackberry:
RIM PR: 145660
Fixed a regression introduced by r111810, which used the wrong
credential object.
Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.
Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html
Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.
Internally reviewed by Joe Mason <jmason@rim.com>
- Api/DumpRenderTreeClient.h:
(WebCore):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
Tools:
Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.
Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.
Internally reviewed by Joe Mason <jmason@rim.com>
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):
(DumpRenderTree):
- 8:24 PM Changeset in webkit [118718] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r118646.
http://trac.webkit.org/changeset/118646
https://bugs.webkit.org/show_bug.cgi?id=87691
broke V8 raytrace benchmark (Requested by pizlo_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28
- heap/Heap.cpp:
(JSC::Heap::collect):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::sweepWeakSet):
(JSC):
- heap/MarkedSpace.cpp:
(JSC::SweepWeakSet::operator()):
(JSC):
(JSC::MarkedSpace::sweepWeakSets):
- heap/MarkedSpace.h:
(MarkedSpace):
- 8:04 PM Changeset in webkit [118717] by
-
- 2 edits in trunk/LayoutTests
mathml/presentation/mo-stretch.html and mroot-pref-width.html tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=86786
Unreviewed gardening - add back these two tests to skip for now.
- platform/mac/Skipped:
- 7:58 PM Changeset in webkit [118716] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] http authentication challenge issue when loading favicon
https://bugs.webkit.org/show_bug.cgi?id=87665
Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by Rob Buis.
Provide the TargetType when generating a favicon loading
request. Loading favicons is triggered after the main resource
has been loaded and parsed, so if we cancel the authentication
challenge when loading main resource, we should also cancel
loading the favicon when it starts to load. If not we will
receive another challenge after we canceled the main resource
loading, which may confuse the user.
Internally reviewed by Joe Mason <jmason@rim.com>
No new tests because of no behavior changes.
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
- 7:43 PM Changeset in webkit [118715] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG should not generate code for code that the CFA proves to be unreachable
https://bugs.webkit.org/show_bug.cgi?id=87682
Reviewed by Sam Weinig.
This also fixes a small performance bug where CFA was not marking blocks
as having constants (and hence not triggering constant folding) if the only
constants were on GetLocals.
And fixing that bug revealed another bug: constant folding was assuming that
a GetLocal must be the first access to a local in a basic block. This isn't
true. The first access may be a Flush. This patch fixes that issue using the
safest approach possible, since we don't need to be clever for something that
only happens in one of our benchmarks.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:50 PM Changeset in webkit [118714] by
-
- 6 edits in trunk/Source
Rename FrameLoaderClient::shadowDOMAllowed() to allowShadowDOM()
https://bugs.webkit.org/show_bug.cgi?id=87101
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. No behavior change.
- bindings/generic/ContextEnabledFeatures.cpp:
(WebCore::ContextEnabledFeatures::shadowDOMEnabled):
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowShadowDOM):
Source/WebKit/chromium:
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowShadowDOM):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- 6:24 PM Changeset in webkit [118713] by
-
- 10 edits in trunk
mathml/presentation/mo-stretch.html and mroot-pref-width.html tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=86786
Reviewed by Darin Adler.
Source/WebCore:
The fix to https://bugs.webkit.org/show_bug.cgi?id=84167 changed inline-table baselines,
including for <mtable>. We therefore have to correct <mtable>'s vertical-align CSS
property.
Tested by existing tests mo-stretch.html, row-alignment.xhtml, and tables.xhtml.
- css/mathml.css:
(mtable):
LayoutTests:
- platform/mac/Skipped:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
- 4:56 PM Changeset in webkit [118712] by
-
- 4 edits in trunk/Source/WebCore
Make CSSParser::filteredProperties() O(n) instead of O(n2) and improve readability.
https://bugs.webkit.org/show_bug.cgi?id=87078
Reviewed by Darin Adler.
This patch implements a number of improvements to filteredProperties:
1) Make the code more linearly readable by separating out handling of important and non-important properties.
2) Eliminate one BitArray instance (reduces hot memory so more cache friendly).
3) Remove O(n2) behavior caused by scanning for and removing previously encountered definitions of each property.
The key algorithmic change is to add properties in decreasing precedence:
a) Iterating once per (important, !important) so that important properties are visited first.
b) Reverse iteration of m_parsedProperties visits the properties in decreasing precedence.
Covered by loads of existing tests - getting CSS property precedence wrong results in too many errors to list.
In particular fast/css contains test cases for important corner cases like duplicated important properties.
- css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
- css/CSSProperty.h:
Add vector traits so that CSSProperty can just be memset by vector without calling constructor.
- 4:52 PM Changeset in webkit [118711] by
-
- 6 edits2 adds in trunk
Can't edit <input> elements with :first-letter
https://bugs.webkit.org/show_bug.cgi?id=87615
Reviewed by Kent Tamura.
A check using canHaveGeneratedChildren() should cover not only
button and menulist, but also RenderTextControl.
This change pulles canHaveGeneratedChildren() up
from RenderDeprecatedFlexibleBox to RenderObject,
and lets RenderTextControl override it.
Test: fast/forms/input-first-letter-edit.html
- rendering/RenderBlock.cpp:
(WebCore):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderBlock.h: Removed a static function canHaveGeneratedChildren()
(RenderBlock):
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::canHaveGeneratedChildren): Added.
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderTextControl.h:
- 3:49 PM Changeset in webkit [118710] by
-
- 10 edits in trunk/Source/WebCore
[BlackBerry] Add support for layers with scale invariant size
https://bugs.webkit.org/show_bug.cgi?id=87601
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
To support layers that have a "floating" appearance, i.e. don't change size
when the web page is drawn at a different scale, we add a new layer property
named "sizeIsScaleInvariant".
The anchor position will still be given in document coordinates for these
"floating" layers, so this is well suited for interface elements like selection
handles whose size is always the same but move with the web page contents.
PR #156812
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawMissingTextures):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
- platform/graphics/blackberry/LayerCompositingThreadClient.h:
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::drawMissingTextures):
- platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(WebCore::LayerData::sizeIsScaleInvariant):
(LayerData):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):
- platform/graphics/blackberry/LayerTiler.h:
(LayerTiler):
- platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::setSizeIsScaleInvariant):
(LayerWebKitThread):
- 3:22 PM Changeset in webkit [118709] by
-
- 5 edits in trunk/Source/WebCore
[BlackBerry] Make it possible to manipulate layers on the compositing thread
https://bugs.webkit.org/show_bug.cgi?id=87602
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
Normally, layers are manipulated on the WebKit thread, and the changes are
synced to the compositing thread during the next accelerated compositing commit
operation.
However, for overlay layers the ability to manipulate layers on the compositing
thread is necessary for adequate user interface responsiveness.
Two mechanisms are added:
- For a layer with a WebKit-thread counterpart, you can temporarily override
attributes or add animations whose output override attributes.
- For a layer with no WebKit-thread counterpart, you can now directly set the
compositing thread values for attributes. If you attempt to do this for layers
that do have a WebKit-thread counterpart, the compositing thread values will
be overwritten at the time of the next commit, which makes the override
mechanism more useful there.
PR #156812
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::addSublayer):
(WebCore):
(WebCore::LayerCompositingThread::updateAnimations):
(WebCore::LayerCompositingThread::removeAnimation):
(WebCore::LayerCompositingThread::override):
(WebCore::LayerCompositingThread::clearOverride):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerOverride):
(WebCore::LayerOverride::create):
(WebCore::LayerOverride::setPosition):
(WebCore::LayerOverride::setAnchorPoint):
(WebCore::LayerOverride::setBounds):
(WebCore::LayerOverride::setTransform):
(WebCore::LayerOverride::setOpacity):
(WebCore::LayerOverride::addAnimation):
(WebCore::LayerOverride::LayerOverride):
(WebCore):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::setPosition):
(WebCore::LayerCompositingThread::setAnchorPoint):
(WebCore::LayerCompositingThread::setBounds):
(WebCore::LayerCompositingThread::setSizeIsScaleInvariant):
(WebCore::LayerCompositingThread::setTransform):
(WebCore::LayerCompositingThread::setOpacity):
(WebCore::LayerCompositingThread::setNeedsTexture):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
- platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
(WebCore::LayerWebKitThread::clearOverride):
- 3:22 PM Changeset in webkit [118708] by
-
- 4 edits in trunk/LayoutTests
Flaky tests in fast/profiler/
https://bugs.webkit.org/show_bug.cgi?id=84102
Unreviewed gardening.
Tests fast/profiler/stop-profiling-after-setTimeout.html and
fast/profiler/dead-time.html were still failing after
https://bugs.webkit.org/show_bug.cgi?id=42328 . Mac and chromium
already skip these tests.
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/qt/Skipped:
- 2:55 PM Changeset in webkit [118707] by
-
- 12 edits in trunk/Source
[chromium] Only increase size of Combo Box Options when displayed on touch screen
https://bugs.webkit.org/show_bug.cgi?id=85921
Patch by Rob Flack <flackr@chromium.org> on 2012-05-28
Reviewed by Adam Barth.
Adds a flag to set whether the current device is a touch screen, independent of whether touch events are supported and use this for the combo box sizing.
Source/WebCore:
No new tests as this is a flag change and covered by existing tests: WebKit/chromium/tests/PopupMenuTest.cpp
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setDeviceSupportsTouch):
(WebCore::Settings::deviceSupportsTouch):
(Settings):
- platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::getRowHeight):
- platform/chromium/PopupListBox.h:
(PopupContainerSettings):
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupMenuChromium::show):
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::defaultDeviceScaleFactor):
(WebKit):
(WebKit::WebSettingsImpl::setDeviceSupportsTouch):
(WebKit::WebSettingsImpl::deviceSupportsTouch):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutofillSuggestions):
- tests/PopupMenuTest.cpp:
(WebKit::SelectPopupMenuTest::SetUp):
(WebKit::SelectPopupMenuTest::TearDown):
(SelectPopupMenuTest):
(WebKit::TEST_F):
- 2:20 PM Changeset in webkit [118706] by
-
- 8 edits1 add in trunk/Source/WebCore
[BlackBerry] Make custom compositing thread layers more flexible
https://bugs.webkit.org/show_bug.cgi?id=87600
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
Introduce a LayerCompositingThreadClient that's used to fine tune the
behaviour of custom layers. Let the LayerTiler be a
LayerCompositingThreadClient and thus decouple it from
LayerCompositingThread. Adjust method signatures to allow a one-to-many
relationship between Client and Layer.
Remove the old LayerCompositingThread::drawCustom() in favour of this new
Client interface.
PR #156812
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::create):
(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::hasMissingTextures):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::bindContentsTexture):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::scheduleCommit):
- platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore):
(LayerCompositingThread):
- platform/graphics/blackberry/LayerCompositingThreadClient.h: Added.
(WebCore):
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::~LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::bindContentsTexture):
(WebCore::LayerCompositingThreadClient::hasMissingTextures):
(WebCore::LayerCompositingThreadClient::drawMissingTextures):
(WebCore::LayerCompositingThreadClient::scheduleCommit):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawDebugBorder):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::scheduleCommit):
(WebCore):
(WebCore::LayerTiler::bindContentsTexture):
- platform/graphics/blackberry/LayerTiler.h:
(LayerTiler):
(WebCore::LayerTiler::hasMissingTextures):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
- platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
- 1:00 PM Changeset in webkit [118705] by
-
- 95 edits in trunk
WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42328
Reviewed by Eric Seidel.
.:
- Source/autotools/symbols.filter: Added needed symbols for GTK build.
Source/WebCore:
Add setJavaScriptProfilingEnabled() to window.internals.settings. No new tests, but this
change will allow more tests to run in WebKitTestRunner and DRT for ports that weren't
implementing this function before.
This patch also refactors InspectorController::enableProfiler() and
InspectorController::disableProfiler() to InspectorController::setProfilerEnabled(bool).
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::setProfilerEnabled):
- inspector/InspectorController.h:
(InspectorController):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setJavaScriptProfilingEnabled):
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit/chromium:
Removed private APIs that were only being used by DRT.
- public/WebDevToolsAgent.h:
(WebDevToolsAgent):
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
Source/WebKit/efl:
Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
move to windows.internals.settings.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- webkit/webkitwebinspector.cpp:
(webkit_web_inspector_set_property):
Source/WebKit/mac:
- WebInspector/WebInspector.mm:
(-setJavaScriptProfilingEnabled:):
Source/WebKit/qt:
Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
move to windows.internals.settings.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
- WebInspector.cpp:
(WebInspector::setJavaScriptProfilingEnabled):
Source/WebKit2:
Removed unneeded setJavaScriptProfilingEnabled function from WTR after its
move to windows.internals.settings.
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleInspector.h:
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
- win/WebKit2.def:
Tools:
Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
move to windows.internals.settings.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
(DRTDevToolsAgent):
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
Updated tests to use windows.internals instead of layoutTestController.
- fast/profiler/anonymous-event-handler.html:
- fast/profiler/anonymous-function-called-from-different-contexts.html:
- fast/profiler/anonymous-function-calls-built-in-functions.html:
- fast/profiler/anonymous-function-calls-eval.html:
- fast/profiler/anonymous-functions-with-display-names.html:
- fast/profiler/apply.html:
- fast/profiler/built-in-function-calls-anonymous.html:
- fast/profiler/built-in-function-calls-user-defined-function.html:
- fast/profiler/call-register-leak.html:
- fast/profiler/call.html:
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
- fast/profiler/compare-multiple-profiles.html:
- fast/profiler/constructor.html:
- fast/profiler/dead-time.html:
- fast/profiler/document-dot-write.html:
- fast/profiler/event-handler.html:
- fast/profiler/execution-context-and-eval-on-same-line.html:
- fast/profiler/inline-event-handler.html:
- fast/profiler/many-calls-in-the-same-scope.html:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
- fast/profiler/multiple-and-different-scoped-function-calls.html:
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html:
- fast/profiler/multiple-frames.html:
- fast/profiler/named-functions-with-display-names.html:
- fast/profiler/nested-anonymous-functon.html:
- fast/profiler/nested-start-and-stop-profiler.html:
- fast/profiler/no-execution-context.html:
- fast/profiler/one-execution-context.html:
- fast/profiler/profile-calls-in-included-file.html:
- fast/profiler/profile-with-no-title.html:
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
- fast/profiler/profiling-from-a-nested-location.html:
- fast/profiler/simple-event-call.html:
- fast/profiler/simple-no-level-change.html:
- fast/profiler/start-and-stop-profiler-multiple-times.html:
- fast/profiler/start-and-stop-profiling-in-the-same-function.html:
- fast/profiler/start-but-dont-stop-profiling.html:
- fast/profiler/stop-profiling-after-setTimeout.html:
- fast/profiler/stop-then-function-call.html:
- fast/profiler/throw-exception-from-eval.html-disabled:
- fast/profiler/two-execution-contexts.html:
- fast/profiler/user-defined-function-calls-built-in-functions.html:
- fast/profiler/window-dot-eval.html:
- inspector/profiler/cpu-profiler-profiling-without-inspector.html:
- platform/wk2/Skipped:
- 12:57 PM Changeset in webkit [118704] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Always create a compositor
https://bugs.webkit.org/show_bug.cgi?id=87598
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
There will likely be compositing layers either due to web content or
due to overlays.
Defer initialization of OpenGL objects (i.e., delay creation of the
LayerRenderer object) until we actually need to draw and there are such
layers, to avoid initializing OpenGL in the unlikely case that there
are no compositing layers or overlay layers.
PR #156811
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 12:37 PM Changeset in webkit [118703] by
-
- 4 edits2 adds in trunk
Crash on incomplete :not().
https://bugs.webkit.org/show_bug.cgi?id=86673
Patch by Yong Li <yoli@rim.com> on 2012-05-28
Reviewed by Antti Koivisto.
Source/WebCore:
Add back null-checks for incomplete :not() class
which were dropped by r81845.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::selectorText):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::determineLinkMatchType):
LayoutTests:
Add a test case that makes CSS parser create incomplete
:not selector.
- fast/css/crash-on-incomplete-not.html: Added.
- fast/css/crash-on-incomplete-not-expected.txt: Added.
- 12:21 PM Changeset in webkit [118702] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Dangling pointer in WebPagePrivate::setCompositor() message
https://bugs.webkit.org/show_bug.cgi?id=87590
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
A crash would be seen in GuardedPointerBase::getWithGuardLocked when
attempting to unpickle and execute serialized call to setCompositor.
The problem was that the message had been created with a dangling
pointer as the target. The web page failed to inform its compositor
that it was being destroyed due to an early return in
WebPagePrivate::destroyCompositor.
The root cause was that a method called "destroyCompositor" was being
called in two situations, when navigating to a new page as well as when
actually deleting the web page. And in one case, we really only wanted
to free up some memory by clearing textures, while in the other case we
really did want to destroy the compositor.
Fixed by calling a method to release textures when that's what we want
to do, and calling a method to destroy the compositor when that's what
we want to do, and making that latter method unconditional.
Reviewed internally by Jeff Rogers.
PR #156765
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- 11:53 AM Changeset in webkit [118701] by
-
- 8 edits3 adds in trunk/Source/WebKit
[BlackBerry] Add a default tap highlight
https://bugs.webkit.org/show_bug.cgi?id=87569
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
Source/WebKit:
Add DefaultTapHighlight to the build system
Reviewed internally by Mike Lattanzio and Mike Fenton.
PR #154329
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
We used to require the embedder to implement tap highlight drawing.
Now, a default tap highlight, implemented using the recently added
accelerated compositing overlay layer support, can be used instead.
The tap highlight appears instantly but fades out when hidden.
The default tap highlight can be overridden using the new
WebPage::setTapHighlight() method.
Reviewed internally by Mike Lattanzio and Mike Fenton.
PR #154329
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::tapHighlight):
(WebKit):
(BlackBerry::WebKit::WebPage::setTapHighlight):
- Api/WebPage.h:
(WebKit):
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- Api/WebTapHighlight.h: Added.
(WebKit):
- WebKitSupport/DefaultTapHighlight.cpp: Added.
(WebKit):
(BlackBerry::WebKit::fadeAnimationName):
(BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::~DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
(BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
- WebKitSupport/DefaultTapHighlight.h: Added.
(WebKit):
(DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::create):
(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 11:33 AM Changeset in webkit [118700] by
-
- 2 edits in trunk/Source/WebCore
FileWriterSync binding should have no static table
https://bugs.webkit.org/show_bug.cgi?id=87645
Reviewed by George Staikos.
FileWriterSync could be used in filesystem FileWriter in worker thread, so we should add ProgressEvent in idl file.
Covered by existing test: fast/filesystem/workers/sync-operations.html.
- Modules/filesystem/FileWriterSync.idl:
- 11:29 AM Changeset in webkit [118699] by
-
- 11 edits in trunk/Source
[BlackBerry] Add an overlay layer
https://bugs.webkit.org/show_bug.cgi?id=87567
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Antonio Gomes.
The overlay layer allows us to have compositing layers even though the
web page is not currently using accelerated compositing.
These layers can be used to implement tap highlight, inspector overlay
and more.
Source/WebCore:
The WebCore changes support the overlay layer functionality in WebKit
by making it possible to add animations from the compositing thread
without them being instantly overwritten during the next commit.
Also a new custom layer type is added, which allow an overlay layer to
draw itself using raw OpenGL calls. An instance of a custom subclass of
LayerCompositingThread must be provided when creating the
LayerWebKitThread. Then, the custom layer can be used as the content
layer of a GraphicsLayer, or by itself.
Reviewed internally by Filip Spacek.
PR #154335
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::scheduleCommit):
- platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::addAnimation):
(WebCore::LayerCompositingThread::setRunningAnimations):
(WebCore::LayerCompositingThread::setSuspendedAnimations):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::drawCustom):
- platform/graphics/blackberry/LayerData.h:
(LayerData):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::setIsMask):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):
- platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
Source/WebKit/blackberry:
Reviewed internally by Filip Spacek.
PR #154335
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::overlayLayer):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::setOverlayLayer):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::overlayLayer):
(WebPageCompositorPrivate):
- Api/WebPage_p.h:
(WebPagePrivate):
- 11:17 AM Changeset in webkit [118698] by
-
- 2 edits in trunk/Source/WebCore
ProgressEvent JSC binding should have no static table
https://bugs.webkit.org/show_bug.cgi?id=87365
Reviewed by George Staikos.
ProgressEvent could be used in filesystem FileWriter in worker thread, so we should add ProgressEvent in idl file.
Covered by existing test: fast/filesystem/workers/file-writer-events.html.
- dom/ProgressEvent.idl:
- 10:48 AM Changeset in webkit [118697] by
-
- 3 edits in trunk/Source/WebKit2
Remove unused argument coders for animation
https://bugs.webkit.org/show_bug.cgi?id=87435
Reviewed by Sam Weinig.
Left the used argument coders only, behind a proper USE(UI_SIDE_COMPOSITING) flag.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC):
- Shared/WebCoreArgumentCoders.h:
- 10:29 AM Changeset in webkit [118696] by
-
- 12 edits in trunk/Source
[BlackBerry] Update WebPageCompositor::render() API
https://bugs.webkit.org/show_bug.cgi?id=87565
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
Source/WebCore:
The new API allows the embedder to specify the root transform and many
OpenGL related parameters.
Also refactor the code to allow several sets of layers to be rendered,
and to allow interleaving the rendering of layers with rendering of
buffers and checkerboard.
Reviewed internally by Filip Spacek.
PR #154334
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::orthoMatrix):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::prepareFrame):
(WebCore):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawCheckerboardPattern):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::prepareFrameRecursive):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::updateScissorIfNeeded):
(WebCore::LayerRenderingResults::addHolePunchRect):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
Source/WebKit/blackberry:
The new API allows the embedder to specify the root transform and many
OpenGL related parameters to be used when rendering the web page.
To honor the transform, we have to implement a way to composite the
BackingStore output using a generic transform. This method,
BackingStorePrivate::compositeContents(), uses a strategy that differs
from blitContents(), because that one is optimized for software
blitting, while this one is optimized for GPU rendering. Specifically,
instead of drawing the checkerboard first, and the rendered subregions
of the tile afterward, we draw the whole tile in one call, and then
draw checkered regions on top, if any.
Removed the blit generation condvar from the new code paths for drawing
BackingStore output using a transform, since the condvar is ineffective
in preventing flicker when we're not in charge of swapping the window.
Instead, another synchronization solution will be implemented in the
future.
Reviewed internally by Filip Spacek.
Some parts reviewed internally by Jacky Jiang and others by
Mike Lattanzio.
PR #151887, #154334
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- Api/BackingStore_p.h:
(WebCore):
(BackingStorePrivate):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositor::prepareFrame):
(BlackBerry::WebKit::WebPageCompositor::render):
- Api/WebPageCompositor.h:
- Api/WebPageCompositorClient.h:
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
- 9:59 AM Changeset in webkit [118695] by
-
- 2 edits in trunk/LayoutTests
[chromium] Adjust expectations for fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87671
Unreviewed gardening.
Temporarily adds "MISSING" for this test.
- platform/chromium/test_expectations.txt:
- 9:54 AM Changeset in webkit [118694] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Merged r118399 -> <rdar://problem/11527190>
- 9:52 AM Changeset in webkit [118693] by
-
- 12 edits in branches/safari-536-branch
Merged r118397 -> <rdar://problem/11024330>
- 9:49 AM Changeset in webkit [118692] by
-
- 5 edits4 copies in branches/safari-536-branch
Merged r118039 -> <rdar://problem/11348396>
- 9:41 AM Changeset in webkit [118691] by
-
- 2 edits in trunk/LayoutTests
[chromium] http/tests/cache/cancel-in-progress-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87657
Unreviewed gardening.
It should be "MISSING" rather than "IMAGE" (fixes r118683).
- platform/chromium/test_expectations.txt:
- 9:28 AM Changeset in webkit [118690] by
-
- 1 edit1 add in trunk/LayoutTests
Adds missing expectation after r118577
https://bugs.webkit.org/show_bug.cgi?id=87670
Unreviewed gardening.
A few baselines were already added by r118584. Adds baseline for Windows.
- platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
- 9:23 AM Changeset in webkit [118689] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Plumb through the return value of makeCurrent to caller
https://bugs.webkit.org/show_bug.cgi?id=87564
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.
This way the caller can take appropriate action if makeCurrent fails,
for example because we're running out of memory.
Reviewed internally by George Staikos.
PR #149721
- WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::makeCurrent):
- 9:22 AM Changeset in webkit [118688] by
-
- 3 edits2 adds in trunk
REGRESSION(r96517): Attribute selector fails to match dynamically modified style attribute
https://bugs.webkit.org/show_bug.cgi?id=87349
Source/WebCore:
Reviewed by Andreas Kling.
Selector fast path does not trigger lazy style attribute generation. Since attribute selectors matching
style attribute are rare, disallow them from the fast path rather than making it more branchy.
Test: fast/css/dynamic-style-attribute-query.html
- css/SelectorChecker.cpp:
(WebCore::isFastCheckableMatch):
LayoutTests:
Reviewed by Andreas Kling.
- fast/css/dynamic-style-attribute-query-expected.txt: Added.
- fast/css/dynamic-style-attribute-query.html: Added.
- 9:05 AM Changeset in webkit [118687] by
-
- 2 edits in trunk/LayoutTests
[Chromium] [V8] Layout Test fast/js/string-replace-2.html failing following 11594 => 11648 v8 update
https://bugs.webkit.org/show_bug.cgi?id=87423
Unreviewed gardening.
We have rolled v8 and we can now set the expectation for both debug and release back to TEXT.
- platform/chromium/test_expectations.txt:
- 8:57 AM Changeset in webkit [118686] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 8:52 AM Changeset in webkit [118685] by
-
- 16 edits in trunk
Web Inspector: Expose function (closure) scopes in remote protocol
https://bugs.webkit.org/show_bug.cgi?id=86861
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-05-28
Reviewed by Yury Semikhatsky.
Source/WebCore:
A data transfer from V8's FunctionMirror via DebuggerScript.js via InjectedScriptHost is built.
Scope field is added to protocol declaration similar to scopes of stack call frame.
Test for function details is extended.
JSC code binging got fixme for implemting the corresponding feature.
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionDetails):
- bindings/v8/DebuggerScript.js:
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::functionScopes):
(WebCore):
- bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionDetailsCallback):
- inspector/InjectedScriptHost.cpp:
(WebCore):
(WebCore::InjectedScriptHost::scriptDebugServer):
- inspector/InjectedScriptHost.h:
(WebCore):
(WebCore::InjectedScriptHost::init):
(InjectedScriptHost):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
LayoutTests:
Test for function details now checks scopes.
- inspector/debugger/function-details-expected.txt:
- inspector/debugger/function-details.html:
- platform/chromium/inspector/debugger/function-details-expected.txt:
- 8:45 AM Changeset in webkit [118684] by
-
- 1 edit2 adds in trunk/LayoutTests
[chromium] Rebaseline following r118598
https://bugs.webkit.org/show_bug.cgi?id=87669
Unreviewed gardening.
In chromium we print a prefix "line 1:" on one console message.
- platform/chromium/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
- 8:07 AM Changeset in webkit [118683] by
-
- 2 edits in trunk/LayoutTests
[chromium] http/tests/cache/cancel-in-progress-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87657
Unreviewed gardening.
Adds PASS and IMAGE expectations.
- platform/chromium/test_expectations.txt:
- 8:04 AM Changeset in webkit [118682] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Add a constructor to create a Path from an SkPath
https://bugs.webkit.org/show_bug.cgi?id=87566
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Antonio Gomes.
Skia allows the creation of more complex paths than WebCore would
allow. This will be used in the BlackBerry port to implement a default
tap highlight appearance.
Reviewed internally by Mike Lattanzio.
PR #154329
- platform/graphics/Path.h:
(Path):
- platform/graphics/skia/PathSkia.cpp:
(WebCore):
(WebCore::Path::Path):
- 7:54 AM Changeset in webkit [118681] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for Mac on Lion.
- inspector/CodeGeneratorInspector.py:
- 6:49 AM Changeset in webkit [118680] by
-
- 2 edits in trunk/LayoutTests
[chromium] http/tests/cache/cancel-in-progress-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87657
Unreviewed gardening.
r118618 added this new test but it's been flaky in chromium.
- platform/chromium/test_expectations.txt:
- 6:23 AM Changeset in webkit [118679] by
-
- 2 edits in trunk/LayoutTests
[chromium] Baseline compositing/geometry/composited-in-columns.html
https://bugs.webkit.org/show_bug.cgi?id=87653
Unreviewed gardening.
r118567 introduced a new test. Chromium is positioning the layers
a few pixels off.
Set the baseline for IMAGE+TEXT temporarily.
- platform/chromium/test_expectations.txt:
- 6:16 AM Changeset in webkit [118678] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Build fix for the Android bot, set CXX_target at gyp generation-time
https://bugs.webkit.org/show_bug.cgi?id=87649
Unreviewed build fix.
Chromium Android builds were broken because v8 tried to compile files
for target with the "-m32" flag. This was caused by a v8 check falling
back to using "which g++" to find the right compiler, whereas it should
have used the $CXX_target environment variable. This isn't being set
for Android builds.
- gyp_webkit: Set the CXX_target environment variable. Annotate the fix with a FIXME comment too.
- 5:50 AM Changeset in webkit [118677] by
-
- 12 edits in trunk/Source
Expose value localization function of HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=84356
Reviewed by Kent Tamura.
Source/WebCore:
No new tests.
We want to localize the values that are defined in the datalist element.
This adds HTMLInputElement::localizeValue() which will localize a given
value.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::localizeValue):
(WebCore):
(WebCore::BaseDateAndTimeInputType::visibleValue):
- html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::localizeValue):
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::localizeValue):
(WebCore):
- html/InputType.h:
(InputType):
- html/NumberInputType.cpp:
(WebCore::NumberInputType::localizeValue):
(WebCore):
(WebCore::NumberInputType::visibleValue):
- html/NumberInputType.h:
(NumberInputType):
Source/WebKit/chromium:
- public/WebInputElement.h:
(WebInputElement):
- src/WebInputElement.cpp:
(WebKit::WebInputElement::localizeValue):
(WebKit):
- 5:38 AM Changeset in webkit [118676] by
-
- 2 edits in trunk/LayoutTests
[chromium] LayoutTestController needs DeferredFrameLoading flag
https://bugs.webkit.org/show_bug.cgi?id=87652
Unreviewed gardening.
r118631 introduced a new test and a new API on LayoutTestController
that we need to implement in chromium.
Skip the test temporarily.
- platform/chromium/test_expectations.txt:
- 5:15 AM Changeset in webkit [118675] by
-
- 3 edits in trunk/LayoutTests
fast/tokenizer/entities-01.html & fast/tokenizer/entities-03.html need new baseline after r118672
https://bugs.webkit.org/show_bug.cgi?id=87648
Unreviewed gardening.
r118672 fixed a rendering bug with Æ but did not update the
expected results for fast/tokenizer/entities-01.html and
fast/tokenizer/entities-03.html.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28
- fast/tokenizer/entities-01-expected.txt:
- fast/tokenizer/entities-03-expected.txt:
- 5:09 AM Changeset in webkit [118674] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Test fix after r118670: saved timeline data may
not have DOM counters data and MemoryStatistics object should
take this into account.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
- 4:13 AM Changeset in webkit [118673] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r118580.
http://trac.webkit.org/changeset/118580
https://bugs.webkit.org/show_bug.cgi?id=87647
Caused webkit_unit_tests to crash on chromium. (Requested by
bulach on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(ContentLayerPainter):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
- 3:23 AM Changeset in webkit [118672] by
-
- 5 edits in trunk
Æ doesn't get rendered as U+00C6
https://bugs.webkit.org/show_bug.cgi?id=87465
Reviewed by Adam Barth.
Source/WebCore:
The if-statement to check whether the first entry of a certain letter
already exists in the index used .get(). The very first alphabetical
entry is in position "0", which evaluates to false, causing the first
entry to be ignored. Instead, use a "x not in y" check here.
Also update WebCore.gyp to list the create-html-entity-table script as
an input for the action, to make sure the table will be recreated.
Test: html5lib/resources/entities02.dat
- WebCore.gyp/WebCore.gyp:
- html/parser/create-html-entity-table:
LayoutTests:
Test that the (current) first alphabetical entity in the named entity
table (Æ, without a semi-colon) renders as expected.
- html5lib/resources/entities02.dat:
- 3:21 AM Changeset in webkit [118671] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file.
- 3:20 AM Changeset in webkit [118670] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: dom counters graphs vanish on switching between timeline views
https://bugs.webkit.org/show_bug.cgi?id=87628
Reviewed by Vsevolod Vlasov.
MemoryStatistics object now listens to the TimelineModel events instead of being
populated by timeline panel. This behavior mathes that of the overview pane.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
- 3:19 AM Changeset in webkit [118669] by
-
- 2 edits in trunk/WebKitLibraries
Remove obsolete feature define ENABLE_3D_CANVAS from FeatureDefines.vsprops for windows
https://bugs.webkit.org/show_bug.cgi?id=87622
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-28
Reviewed by Eric Seidel.
Removed the ENABLE_3D_CANVAS from the property define as this is
obsolete since bug #53041
- win/tools/vsprops/FeatureDefines.vsprops:
- 3:14 AM Changeset in webkit [118668] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Buildfix: remove obsolete file from gypi.
https://bugs.webkit.org/show_bug.cgi?id=87643
Reviewed by no-reviewer.
Following http://trac.webkit.org/changeset/118610.
Removes reference to platform/graphics/gstreamer/ImageGStreamerCG.mm
- WebCore.gypi:
- 3:12 AM Changeset in webkit [118667] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/dom/beforeload/image-object-before-load* need to be skipped after r118618
https://bugs.webkit.org/show_bug.cgi?id=87632
Unreviewed EFL gardening.
fast/dom/beforeload/image-object-before-load* need to be skipped after
r118618. The issue will be addressed in Bug 87631.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28
- platform/efl/test_expectations.txt:
- 3:07 AM Changeset in webkit [118666] by
-
- 2 edits in trunk/LayoutTests
[EFL] http/tests/appcache/abort-cache* are flaky and should be skipped
https://bugs.webkit.org/show_bug.cgi?id=87634
Unreviewed EFL gardening. Aborting application cache downloads is
flaky on EFL port so we need to skip the corresponding test cases for
now.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28
- platform/efl/test_expectations.txt:
- 2:54 AM Changeset in webkit [118665] by
-
- 3 edits in trunk/LayoutTests
[EFL] Move input element's internal spinner layout tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=87629
Unreviewed EFL gardening.
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-28
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 2:54 AM Changeset in webkit [118664] by
-
- 3 edits in trunk/Source/WebCore
HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
https://bugs.webkit.org/show_bug.cgi?id=87608
Reviewed by Kent Tamura.
Moved m_validationMessage clearance from detach() to removedFrom() and
remove detach().
No new tests. This change has no visible difference. Upcoming changes rely on this though.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::removedFrom):
- 2:49 AM Changeset in webkit [118663] by
-
- 1 edit2 adds in trunk/LayoutTests
[EFL] Unreviewed EFL gardening after r118585
https://bugs.webkit.org/show_bug.cgi?id=87621
Unreviewed EFL Gardening.
Two contentSecurityPolicy tests need expectation for EFL port after
r118585 due to line numbers not being printed. Mac and GTK port are
already doing the same.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28
- platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
- platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
- 2:44 AM Changeset in webkit [118662] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Record CPU profile" button doesn't change its state after finishing profiling
https://bugs.webkit.org/show_bug.cgi?id=87624
Reviewed by Vsevolod Vlasov.
Keep record button state in sync with the current profiling state.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
- 2:38 AM Changeset in webkit [118661] by
-
- 2 edits in trunk/LayoutTests
[EFL] Test added in r118577 is failing and should be skipped
https://bugs.webkit.org/show_bug.cgi?id=87620
Unreviewed EFL gardening. Skipping new test introduced in r118577
which is failing on our port.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28
- platform/efl/test_expectations.txt:
- 2:14 AM Changeset in webkit [118660] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed Mac Chromium build fix.
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowStyleScoped):
- 2:14 AM Changeset in webkit [118659] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r118650.
http://trac.webkit.org/changeset/118650
https://bugs.webkit.org/show_bug.cgi?id=87639
Patch caused massive failures throughout the builders
(Requested by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28
- css/MediaQuery.cpp:
(WebCore):
(WebCore::MediaQuery::serialize):
(WebCore::MediaQuery::MediaQuery):
(WebCore::MediaQuery::cssText):
- css/MediaQuery.h:
(WebCore::MediaQuery::expressions):
(WebCore::MediaQuery::mediaType):
(MediaQuery):
(WebCore::MediaQuery::copy):
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
(WebCore::MediaQueryEvaluator):
(WebCore::MediaQueryEvaluator::eval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::device_aspect_ratioMediaFeatureEval):
(WebCore::transform_3dMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::createFunctionMap):
- css/MediaQueryEvaluator.h:
(WebCore):
(MediaQueryEvaluator):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(MediaQueryResult):
(WebCore::MediaQueryResult::MediaQueryResult):
(WebCore):
(StyleResolver):
- 2:08 AM Changeset in webkit [118658] by
-
- 2 edits in trunk/LayoutTests
[EFL] New tests added in r118567 should be skipped on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87618
Unreviewed EFL gardening. Move the test added in r118567 to test
expectations since the EFL port lacks support for
LayoutTestController::layerTreeAsText.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28
- platform/efl/test_expectations.txt:
- 2:05 AM Changeset in webkit [118657] by
-
- 20 edits in trunk
Move allowRoundingHacks to Internals interface
https://bugs.webkit.org/show_bug.cgi?id=87328
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter: Add allowRoundingHacks symbol filter.
Source/WebCore:
Add allowRoundingHacks function, because it is able to work in the
cross-port way by means of the Internals interface.
In addition, a function is added in order to restore default setting values.
No new tests, since we are improving here the infra-structure for testing
a specific method.
- testing/Internals.cpp:
(WebCore::Internals::reset):
(WebCore):
(WebCore::Internals::resetDefaultsToConsistentValues):
(WebCore::Internals::allowRoundingHacks):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def: Add setAllowsRoundingHacks() to symbol filter.
Tools:
Remove allowRoundingHacks functions, because it is able to work in the
cross-port way through the Internals interface.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
LayoutTests:
Invoke allowRoundingHacks function from internals, because it is able to work in the
cross-port way via the Internals interface.
- platform/mac/fast/text/rounding-hacks-expansion.html:
- platform/mac/fast/text/rounding-hacks.html:
- 2:03 AM Changeset in webkit [118656] by
-
- 2 edits in trunk/Tools
Fix mac build with older XCode by defining NSEC_PER_MSEC.
https://bugs.webkit.org/show_bug.cgi?id=87616
Reviewed by Hajime Morita.
The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
Patch just adds a #ifndef / #define check.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
- 1:53 AM Changeset in webkit [118655] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] http authentication crash the browser when user commit or cancel the http authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=87579
Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by George Staikos.
In function NetworkJob::startNewJobWithRequest, We should cancel the
NetworkJob first before we start a new NetworkJob which reuses the
resource handle of the old one. If we only set the m_handle = 0 of the
old NetworkJob without cancelling itself, it will still receives data
notification from network thread and handles the received data with
the released resource handler, which will cause the crash.
No new tests because no behavior has changed.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):
- 1:40 AM Changeset in webkit [118654] by
-
- 4 edits in trunk/Source/WebCore
[Refactoring][ShadowDOM] Some ElementShadow methods can be inlined.
https://bugs.webkit.org/show_bug.cgi?id=87617
Reviewed by Kentaro Hara.
Inlined ElementShadow::attachHost(), ElementShadow::detachHost() and
ElementShadow::reattach()
No new tests. No behavior change.
- dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
- dom/ElementShadow.cpp:
(WebCore::ElememtnShadow::reattachHostChildrenAndShadow):
- dom/ElementShadow.h:
(ElementShadow):
- 1:17 AM Changeset in webkit [118653] by
-
- 3 edits in trunk/Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=87609
[Chromium] FrameLoaderClient::allowStyleScoped() should be implemented interms of WebPermissionClient
Reviewed by Kent Tamura.
Added allowStyleScoped() implementation which is essentially same as shadowDOMAllowed().
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- 1:03 AM Changeset in webkit [118652] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py: protect typed API from C++ implicit float to int cast
https://bugs.webkit.org/show_bug.cgi?id=87183
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-05-28
Reviewed by Yury Semikhatsky.
An intermediate C++ class is introduced that uses C++ template technique to control actual type
of its constructor argument.
All input parameters of type "int" now have type ExactlyInt.
All usage sites are fixed accordingly.
- inspector/CodeGeneratorInspector.py:
(TypeModel.RefPtrBased):
(TypeModel.Enum):
(TypeModel.ValueType):
(TypeModel.ValueType.get_opt_output_type_):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(TypeModel.ExactlyInt):
(TypeModel.ExactlyInt.init):
(TypeModel.ExactlyInt.get_input_param_type_text):
(TypeModel.ExactlyInt.get_opt_output_type_):
(TypeModel.init_class):
(ExactlyInt):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::jsHeapInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
- 12:48 AM Changeset in webkit [118651] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-binding-tests results.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectOwner::finalize):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterOwner::finalize):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetOwner::finalize):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionOwner::finalize):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjOwner::finalize):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::installPerContextProperties):
- 12:11 AM Changeset in webkit [118650] by
-
- 7 edits in trunk/Source/WebCore
StyleResolver need not allocate each MediaQueryResult on the heap
https://bugs.webkit.org/show_bug.cgi?id=75223
Reviewed by Daniel Bates.
- css/MediaQuery.cpp: Removed some comments that pointed to CSS documents.
There is no guarantee these links will be valid over time.
(WebCore::MediaQuery::MediaQuery): Rewrote for clarity, conventional WebKit coding
style, and simplicity.
(WebCore::MediaQuery::copy): Moved out of line; not performance critical, and this
allows us to cut down header dependencies.
(WebCore::MediaQuery::cssText): Updated for change to data member name.
- css/MediaQuery.h: Removed unneeded includes. Removed non-helpful argument name
"exprs". Changed expressions function to return a reference instead of
a pointer. Changed mediaType and cssText functions to return a reference. Renamed
m_serializationCache to m_serializedQuery. Moved copy function out of header.
- css/MediaQueryEvaluator.cpp: Renamed EvalFunc to MediaFeatureEvaluationFunction.
Broke a FIXME into three and reworded for clarity.
(WebCore::MediaQueryEvaluator): Updated for name changes.
(WebCore::MediaQueryEvaluator::eval): Rewrote this for clarity and to regularize
the logic a bit.
(WebCore::aspect_ratioMediaFeatureEval): Got rid of a != 0 that is contrary to the
normal WebKit style.
(WebCore::device_aspect_ratioMediaFeatureEval): Ditto.
(WebCore::transform_3dMediaFeatureEval): Fixed mangled #if that was here.
(WebCore::view_modeMediaFeatureEval): Replaced UNUSED_PARAM usage with ASSERT_UNUSED.
(WebCore::createFunctionMap): Changed this so it returns the map so we can use a
cleaner style in the caller.
(WebCore::MediaQueryEvaluator::eval): Updated to take a reference and improved the
comments and coding style a bit.
- css/MediaQueryEvaluator.h: Updated comment style. Removed unused constructor.
Removed unneeded destructor declaration. Renamed m_expResult to m_mediaFeatureResult.
- css/StyleResolver.cpp: Moved the MediaQueryResult class into this file
and made it a structure rather than a class.
(WebCore::StyleResolver::addViewportDependentMediaQueryResult): Updated to take
a reference argument instead of a pointer and for the new vector type.
(WebCore::StyleResolver::affectedByViewportChange): Updated for above changes.
- css/StyleResolver.h: Removed many unneeded includes and forward declarations of
classes, including now-unneeded include of MediaQueryExp.h. Replaced MediaQueryResult
definition with a forward declaration. Changed addViewportDependentMediaQueryResult
to take a reference instead of a pointer. Changed m_viewportDependentMediaQueryResults
to be a vector of values rather than of pointers.
May 27, 2012:
- 10:48 PM Changeset in webkit [118649] by
-
- 2 edits in trunk/Source/WTF
Fix an incorrect assertion in Vector::remove
https://bugs.webkit.org/show_bug.cgi?id=87612
Reviewed by Dan Bernstein.
- wtf/Vector.h: There's no good reason to disallow calling remove
with a size of 0, even when the position is at the end of the vector,
so changed the two-argument Vector::remove assertion to assert that
the position is <= size rather than < size.
- 10:13 PM Changeset in webkit [118648] by
-
- 3 edits4 adds in trunk
cut, copy or paste event won't be fired in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87352
Reviewed by Dimitri Glazkov.
Source/WebCore:
cut, copy or paste event was not fired in Shadow DOM.
Since event re-targeting has been implemented, it should be safe to fire them in Shadow DOM now.
Tests: fast/dom/shadow/cppevent-in-shadow.html
fast/dom/shadow/cppevent-input-in-shadow.html
- editing/Editor.cpp:
(WebCore::Editor::findEventTargetFrom):
LayoutTests:
- fast/dom/shadow/cppevent-in-shadow-expected.txt: Added.
- fast/dom/shadow/cppevent-in-shadow.html: Added.
- fast/dom/shadow/cppevent-input-in-shadow-expected.txt: Added.
- fast/dom/shadow/cppevent-input-in-shadow.html: Added.
- 10:00 PM Changeset in webkit [118647] by
-
- 7 edits in trunk
[EFL] Enable blob support for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=85363
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-27
Reviewed by Hajime Morita.
.:
Enable Blob support by default for the EFL port.
- Source/cmake/OptionsEfl.cmake:
Tools:
Enable Blob support by default for the EFL port.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip tests which require blob support to be enabled.
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 9:56 PM Changeset in webkit [118646] by
-
- 6 edits in trunk/Source/JavaScriptCore
Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599
Reviewed by Darin Adler.
- heap/Heap.cpp:
(JSC::Heap::collect): Don't force immediate finalization -- it will
happen lazily.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep): Sweep a block's weak set when sweeping the
block. The weak set may not have been swept yet, and this is our last
chance to run weak finalizers before we recycle the memory they reference.
- heap/MarkedBlock.h:
- heap/MarkedSpace.cpp:
(JSC::MarkedBlock::sweepWeakSets):
- heap/MarkedSpace.h:
(JSC::MarkedSpace::sweepWeakSets): Nixed sweepWeakSets because it's unused
now.
- 9:39 PM Changeset in webkit [118645] by
-
- 5 edits in trunk
Support multiple shadow roots in event dispatching.
https://bugs.webkit.org/show_bug.cgi?id=87470
Reviewed by Dimitri Glazkov.
Source/WebCore:
The current implementation does not set event's target correctly
if an event happens on DOM tree with multiple shadow roots. So
this patch updates an event re-targeting algorithm so that it
works even if it is applied to multiple shadow roots.
Tests: fast/dom/shadow/shadow-dom-event-dispatching.html
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::ensureEventAncestors):
LayoutTests:
- fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching.html:
- 9:22 PM Changeset in webkit [118644] by
-
- 3 edits in trunk/Source/WebCore
Minor code cleaning for the interface of MainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=87607
Reviewed by Darin Adler.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::handleSubstituteDataLoadSoon):
- loader/MainResourceLoader.h:
(MainResourceLoader):
-Add the OVERRIDE keyword for the methods inherited from ResourceLoader.
-Remove the useless declaration of handleDataLoad(ResourceRequest&), this method does not exist.
-Rename handleDataLoadNow() to handleSubstituteDataLoadNow() and make the method private. This should
only be used by handleSubstituteDataLoadSoon() and indirectly through the timer.
- 7:26 PM Changeset in webkit [118643] by
-
- 4 edits in trunk/Source
[WTF] Introduce UINT64_C to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=87485
Reviewed by Kent Tamura.
Source/WebCore:
This patch introduces UINT64_C for all platforms to avoid using
conditional compilation.
No new tests. This patch doesn't change behavior.
- Modules/websockets/WebSocketFrame.cpp:
(WebCore::WebSocketFrame::parseFrame): Replace conditional compilation with UINT64_C.
Source/WTF:
- wtf/MathExtras.h:
- 7:05 PM Changeset in webkit [118642] by
-
- 5 copies1 add in releases/Apple/Safari 5.1.7
Added a tag for the Safari 5.1.7 release.
Safari 5.1.7 includes JavaScriptCore-x534.57.3, JavaScriptGlue-x534.57.2, WebCore-x534.57.2, WebKit-x534.57.2, and WebKit2-x534.57.2.
- 6:58 PM Changeset in webkit [118641] by
-
- 4 copies1 add in releases/Apple/OS X Lion Update 10.7.4
Added a tag for the OS X Lion Update 10.7.4 release.
OS X Lion v10.7.4 includes JavaScriptCore-7534.56.6, WebCore-7534.56.5, WebKit-7534.56.5, and WebKit2-7534.56.5.
- 6:56 PM Changeset in webkit [118640] by
-
- 2 edits in trunk
[CMake] Make WEBKIT_SET_EXTRA_COMPILER_FLAGS work with clang.
https://bugs.webkit.org/show_bug.cgi?id=87597
Reviewed by Daniel Bates.
Building with clang requires at least the -fPIC option being
passed correctly, just like it is needed with gcc. clang is also
compatible with most of gcc's compiler options, so we only need to
check for clang besides g++ in the macro definition.
- Source/cmake/WebKitHelpers.cmake: Check for "Clang" and use
CMAKE_COMPILER_IS_GNUCXX for the previous check, as it is shorter
and achieves the same effect.
- 6:53 PM Changeset in webkit [118639] by
-
- 2 edits in trunk/Source/WebCore
Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=87462
Reviewed by Dimitri Glazkov.
Factor out strings into a const char* array, and use a StringBuilder instead of String concatenation.
This will allow future code to re-use the array of transform names, and StringBuilder is generally faster.
Covered by existing CSS transform tests.
- css/WebKitCSSTransformValue.cpp:
(WebCore):
(WebCore::WebKitCSSTransformValue::customCssText):
- 6:52 PM Changeset in webkit [118638] by
-
- 5 copies1 add in releases/Apple/Safari 5.1.5
Added a tag for the Safari 5.1.5 release.
Safari 5.1.5 includes JavaScriptCore-x534.55.2, JavaScriptGlue-x534.55.2, WebCore-x534.55.3, WebKit-x534.55.3, and WebKit2-x534.55.3.
- 6:49 PM Changeset in webkit [118637] by
-
- 5 copies1 add in releases/Apple/Safari 5.1.4
Added a tag for the Safari 5.1.4 release.
Safari 5.1.4 includes JavaScriptCore-x534.54.15, JavaScriptGlue-x534.54.5, WebCore-x534.54.17, WebKit-x534.54.16, and WebKit2-x534.54.16.
- 6:44 PM Changeset in webkit [118636] by
-
- 4 copies1 add in releases/Apple/OS X Lion Update 10.7.3
Added a tag for the OS X Lion Update 10.7.3 release.
OS X Lion v10.7.3 includes JavaScriptCore-x534.53.8, WebCore-x534.53.11, WebKit-x534.53.11, and WebKit2-x534.53.11.
- 6:24 PM Changeset in webkit [118635] by
-
- 5 copies1 add in releases/Apple/Safari 5.1.2
Added a tag for the Safari 5.1.2 release.
Safari 5.1.2 includes JavaScriptCore-x534.52.7, JavaScriptGlue-x534.51.13, WebCore-x534.52.11, WebKit-x534.52.7, and WebKit2-x534.52.7.
- 6:17 PM Changeset in webkit [118634] by
-
- 5 copies1 add in releases/Apple/Safari 5.1.1
Added a tag for the Safari 5.1.1 release.
Safari 5.1.1 includes JavaScriptCore-x534.51.21, JavaScriptGlue-x534.51.13, WebCore-x534.51.22, WebKit-x534.51.22, and WebKit2-x534.51.22.
- 5:28 PM Changeset in webkit [118633] by
-
- 3 edits in trunk/LayoutTests
fast/dom/shadow/content-element-in-media.html is wrong.
https://bugs.webkit.org/show_bug.cgi?id=81310
Modifying to check() to dump expected and actual text at the same
absolute position, because DumpRenderTree dumps absolute x,y-position
information for a layer which contains RenderVideo. For example,
backgroundClip at (8,163), clip at (8, 163) and so on.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-27
Reviewed by Hajime Morita.
- fast/dom/resources/shadow-test-driver.js:
(check):
Disabled actual block when dumping expected block as text, and vice
versa.
- platform/chromium/test_expectations.txt:
Removed BUGWK81310.
- 5:23 PM Changeset in webkit [118632] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update color for tap highlight and selection
https://bugs.webkit.org/show_bug.cgi?id=87606
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-27
Reviewed by Antonio Gomes.
PR #154813
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::platformTapHighlightColor):
(WebCore::RenderThemeBlackBerry::platformActiveSelectionBackgroundColor):
- 2:31 PM Changeset in webkit [118631] by
-
- 9 edits4 adds in trunk
When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
https://bugs.webkit.org/show_bug.cgi?id=87582
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-27
Reviewed by Darin Adler.
Source/WebCore:
Previously, there was a shortcut when a deferred MainResourceLoader is resumed: If the data
was coming from AppCache we could jump directly to startDataLoadTimer().
The problem with the shortcut is willSendRequest() is never called in that particular case
(substituteData + deferred-resume). The imbalance between willSendRequest() and didReceiveResponse()
causes problems.
This patch removes the shortcut so that MainResourceLoader::loadNow() is used regardless of
the deferred loading. The method MainResourceLoader::loadNow() handle the substituteData as if the loading
was not deferred.
Test: http/tests/appcache/load-from-appcache-defer-resume-crash.html
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::handleSubstituteDataLoadSoon):
Rename the method to be consistent with the attribute it uses, making the naming more explicit.
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::setDefersLoading):
- loader/MainResourceLoader.h:
(MainResourceLoader):
Tools:
Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
possible to test pages in a similar way as they are loaded in Browsers.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(setUseDeferredFrameLoadingCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::useDeferredFrameLoading):
(LayoutTestController::setUseDeferredFrameLoading):
(LayoutTestController):
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
LayoutTests:
- http/tests/appcache/load-from-appcache-defer-resume-crash-expected.txt: Added.
- http/tests/appcache/load-from-appcache-defer-resume-crash.html: Added.
- http/tests/appcache/resources/load-from-appcache-defer-resume-bounce-back.html: Added.
- http/tests/appcache/resources/load-from-appcache-defer-resume-crash.manifest: Added.
- 12:51 PM Changeset in webkit [118630] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening after r118618.
- platform/gtk/test_expectations.txt:
- 12:48 PM Changeset in webkit [118629] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Trivial unreviewed build fix with newer Qt
- Api/qwebpage.cpp:
(QWebPage::javaScriptPrompt): Don't use deprecated QString/QChar functions.
- 12:27 PM Changeset in webkit [118628] by
-
- 2 edits in trunk/Tools
[watchlist] Improve MathML rule
https://bugs.webkit.org/show_bug.cgi?id=87592
Reviewed by Adam Barth.
The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
but if this changed the rule would be slow. We protect against this, clarify the rule,
and make it more similar to existing rules.
- Scripts/webkitpy/common/config/watchlist:
- 7:54 AM Changeset in webkit [118627] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash when deleting WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=87589
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-27
Reviewed by Rob Buis.
The WebPageCompositorPrivate is reference counted, so it may outlive
either the WebPage or the WebPageCompositor, depending on who releases
its reference first.
Fixed by disconnecting the objects properly, regardless of who goes
away first.
Reviewed internally by Mike Lattanzio.
PR #156444
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::client):
- Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
- 7:41 AM Changeset in webkit [118626] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] BackingStore accesses tiles even though it's not active
https://bugs.webkit.org/show_bug.cgi?id=87563
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-18
Reviewed by Antonio Gomes.
There are many scenarios that can call render and cause tile access,
and they used to be rerouted to the direct rendering code when the
backing store was not active. This was thanks to an implicit check for
isActive() by virtue of calling shouldDirectRenderingToWindow() from
render().
If we're using OpenGL for compositing the backing store contents
however, direct rendering is always disabled and we jump right into the
tile based rendering code.
Fixed by adding an explicit check for isActive() in render(), now that
the implicit check in shouldDirectRenderingToWindow() is conditional on
having raster usage.
Since PR136381/bug83131, when OpenGL compositing is used, and the
backing store is not active, it is not in charge of drawing the root
layer. Instead, we switch off the paintingGoesToWindow flag on the root
RenderLayer so no invalidates will reach the ChromeClient or the
BackingStore any more. Instead, invalidations will cause the root
accelerated compositing layer to be repainted. Any BackingStore render
calls while in this state are pointless, and can safely do an early
return.
Reviewed internally by Jakob Petsovits.
PR #150403
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
- 7:17 AM Changeset in webkit [118625] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Web page fails to render after clicking link with target=_blank
https://bugs.webkit.org/show_bug.cgi?id=87562
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-12
Reviewed by Antonio Gomes.
Clicking such a link opens a new tab. The compositor was briefly in
charge of drawing the root layer while the backing store was inactive
and the user was looking at the other tab. The problem was that the
compositor believed it was still painting the root layer even after the
backing store became active again. The flag was not properly cleared
when turning off compositing.
Fixed by returning false from drawsRootLayer() if we don't have a root
layer.
Reviewed internally by Filip Spacek.
PR #149342
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
- 4:35 AM Changeset in webkit [118624] by
-
- 5 edits in trunk/Source/WebCore
Use xcrun to find gperf path on platforms that use Xcode
<http://webkit.org/b/87587>
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj:
(Generate Derived Sources): Set GPERF environment variable using
xcrun.
- css/makeprop.pl: Use GPERF environment variable if set, else
"gperf".
- css/makevalues.pl: Ditto.
- make-hash-tools.pl: Ditto.
- 12:40 AM Changeset in webkit [118623] by
-
- 2 edits in trunk/Tools
[watchlist] Add myself & a rule for MathML
https://bugs.webkit.org/show_bug.cgi?id=87586
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/watchlist:
- 12:35 AM Applications using WebKit edited by
- (diff)
- 12:34 AM Applications using WebKit edited by
- (diff)
- 12:34 AM Changeset in webkit [118622] by
-
- 5 edits in trunk
[FileAPI] FileReader should fire progress event when blob has been completely read into memory
https://bugs.webkit.org/show_bug.cgi?id=87585
Patch by Li Yin <li.yin@intel.com> on 2012-05-27
Reviewed by Kentaro Hara.
From Spec: http://www.w3.org/TR/FileAPI/#dfn-progress-event
One progress event will fire when blob has been completely read into memory.
Firefox, Opera and IE follows the spec.
Webkit based browser doesn't do that, it only fires progress event at interval of 50ms.
WebKit should add the behavior to make the conformance with the spec.
Source/WebCore:
Tests: fast/files/file-reader-event-listener.html
- fileapi/FileReader.cpp:
(WebCore::FileReader::didFinishLoading):
LayoutTests:
- fast/files/file-reader-event-listener-expected.txt:
- fast/files/file-reader-event-listener.html:
