⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 6, 2012:

11:57 PM Changeset in webkit [119690] by wangxianzhu@chromium.org
  • 7 edits
    5 adds in trunk

Element.getBoundingClientRect() and Element.getClientRects() return incorrect values in frames in a scaled page
​https://bugs.webkit.org/show_bug.cgi?id=88430

Source/WebCore:

Element.getBoudingClientRect() and Element.getClientRects() should not scale back the rects
if the element is in a frame because page scale only apply to elements in the main frame.

Reviewed by James Robinson.

Tests: fast/dom/Element/scale-page-bounding-client-rect-in-frame.html

fast/dom/Element/scale-page-client-rects-in-frame.html

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and Range.cpp and fixed issue of pageScale in frames.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and fixed issue of pageScale in frames.

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

  • dom/Range.cpp:

(WebCore):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale): Moved into Document and fixed issue of pageScale in frames.
(WebCore::Range::getBorderAndTextQuads):

  • rendering/RenderObject.h: Removed adjustFloatQuadForPageScale and adjustFloatRectForPageScale because they seem unrelated to RenderObject.

(WebCore):

LayoutTests:

Reviewed by James Robinson.

  • fast/dom/Element/resources/client-rect-frame.html: Added.
  • fast/dom/Element/scale-page-bounding-client-rect-in-frame-expected.txt: Added.
  • fast/dom/Element/scale-page-bounding-client-rect-in-frame.html: Added.
  • fast/dom/Element/scale-page-client-rects-in-frame-expected.txt: Added.
  • fast/dom/Element/scale-page-client-rects-in-frame.html: Added.
11:54 PM Changeset in webkit [119689] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
​https://bugs.webkit.org/show_bug.cgi?id=88469

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::shouldDrawLayer):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
11:25 PM Changeset in webkit [119688] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r60044.
​http://trac.webkit.org/changeset/60044

It made a regression, crbug.com/114922.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll): Do not hide popups by scrolling.
(WebKit::ChromeClientImpl::scroll): ditto.

11:20 PM Changeset in webkit [119687] by aestes@apple.com
  • 17 edits in trunk/Source

Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT)
​https://bugs.webkit.org/show_bug.cgi?id=88504

Reviewed by Dan Bernstein.

uppercaseWord, lowercaseWord, and capitalizeWord are methods declared
by NSResponder that subclasses are expected to implement. WebKit should
only support these implementations on platforms that use AppKit.

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.cpp:
  • editing/Editor.h:
  • loader/EmptyClients.h:
  • page/ContextMenuController.cpp:
  • page/EditorClient.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:14 PM Changeset in webkit [119686] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS: Roll to chromium 140955.
11:01 PM Changeset in webkit [119685] by loislo@chromium.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r119683.
​http://trac.webkit.org/changeset/119683
​https://bugs.webkit.org/show_bug.cgi?id=88505

it broke webkit-unit-test
WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac
(Requested by loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-06

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setVisible):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

10:56 PM Changeset in webkit [119684] by rjkroege@chromium.org
  • 9 edits in trunk/Source

Source/WebCore: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
​https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for
m_hasPreciseScrollingDelta on all Chromium platforms and adjusting ScrollAnimator
and ScrollAnimatorNone accordingly to let m_hasPreciseScrollingDelta == true
force exact (non-animated) scrolling.

Reviewed by James Robinson.

Updated WebKit unit tests to validate change.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Adjusted #ifdefs to
make m_hasPreciseScrollingDelta available on all Chromium platforms.
(PlatformWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Default scroll type is set based on
m_hasPreciseScrollingDelta value.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll): Scroll precisely when necessary.

  • platform/ScrollTypes.h: Added additional pixel scrolling subtype.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll): Updated for additional pixel scroll subtype.

Source/WebKit/chromium: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
​https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for precise
scrolling deltas on all Chromium platforms.

Reviewed by James Robinson.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): Create PlatformWheelEvents
with m_hasPreciseScrollingDelta flag as required.

  • tests/ScrollAnimatorNoneTest.cpp: Added new unit test condiiton for precise scrolling.

(TEST):

10:00 PM Changeset in webkit [119683] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation.
​https://bugs.webkit.org/show_bug.cgi?id=87747

Patch by Michal Mocny <​mmocny@google.com> on 2012-06-06
Reviewed by Adrienne Walker.

Source/WebCore:

GpuMemoryManager manages texture memory allocation limits. It will send a 0 allocation when a renderer becomes
invisible, and an appropriate allocation after a renderer is initialized. These numbers will change
depending on the state of memory across devices and other renderers, so we would like to remove all explicit
management by the renderers themselves.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setVisible):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

9:52 PM Changeset in webkit [119682] by kinuko@chromium.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r119680.
​http://trac.webkit.org/changeset/119680
​https://bugs.webkit.org/show_bug.cgi?id=88498

It broke mac build (Requested by kinuko on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-06

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding):
(WebCore):
(WebCore::File::captureSnapshot):

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.cpp:

(WebCore):

9:34 PM Changeset in webkit [119681] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=88488
PR #162991

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

When we use width:100%/pageScale as the math to calculate the width of the
FullScreen element, it goes too wide for horizontally scrollable webpages.
The reason is that 100% is relative to the content size here, and we want 100%
relative to the viewport size. However, since there is no such a thing in CSS,
we set an absolute file.

A known problem with this will be rotating the device when in fullscreen mode
that we can address when rotating is supported.

Internally reviewed by Jacky Jiang.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

9:34 PM Changeset in webkit [119680] by kinuko@chromium.org
  • 8 edits in trunk/Source/WebCore

File::lastModifiedDate should use NaN or separate boolean flag for null Date value
​https://bugs.webkit.org/show_bug.cgi?id=87826

Reviewed by Kent Tamura.

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.cpp:

(WebCore):

9:34 PM Changeset in webkit [119679] by tonikitoo@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
​https://bugs.webkit.org/show_bug.cgi?id=88254
PR #125237

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Patch implements a top-down visibleWindowRect calculation for all scrollable
elements hit-tested by a given point.

The reason on why this approach is better is that it calculates the visible
window rect from the outtermost scrollable element towards the inner ones, and
that allows it to use the visible window rect of the previous scrollable element
as the clipping rect for the current one.

Patch also changes the return vector to store ScrollViewBase pointers, so
we can make use of static_cast properly.

Internally reviewed by Jakob Petsovits.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::pushBackInRegionScrollable):
(BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::InRegionScrollableArea::setVisibleWindowRect):
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::visibleWindowRect):

  • WebKitSupport/InRegionScrollableArea.h:

(InRegionScrollableArea):

9:26 PM Changeset in webkit [119678] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Compile webkit1 and webkit2 by default.
​https://bugs.webkit.org/show_bug.cgi?id=85041

Patch by Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2012-06-06
Reviewed by Chang Shu.

Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.

  • Scripts/build-webkit:
9:23 PM Changeset in webkit [119677] by rniwa@webkit.org
  • 7 edits
    4 deletes in trunk

Unreviewed, rolling out r119668.
​http://trac.webkit.org/changeset/119668
​https://bugs.webkit.org/show_bug.cgi?id=88493

Hitting assertions in debug builds (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-06

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):

  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:

(RenderInline):

LayoutTests:

  • editing/selection/caret-in-empty-inline-1-expected.txt: Removed.
  • editing/selection/caret-in-empty-inline-1.html: Removed.
  • editing/selection/caret-in-empty-inline-2-expected.txt: Removed.
  • editing/selection/caret-in-empty-inline-2.html: Removed.
9:20 PM Changeset in webkit [119676] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Cache isSelfPaintingLayer() for better performance
​https://bugs.webkit.org/show_bug.cgi?id=88464

Reviewed by Simon Fraser.

Covered by existing tests (repaint tests among them).

isSelfPaintingLayer() has shown up several times on some scrolling benchmarks due
to the function being called several time per paint phase. This change caches the
boolean at style change time.

On ​http://dglazkov.github.com/performance-tests/biggrid.html, this nearly speed-up
painting by 2 (lowering the time taken to paint the newly exposed area when scrolling
on a 10,000 * 100 table from 95ms to 50ms).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Initialized m_isSelfPaintingLayer here.

(WebCore::RenderLayer::paintLayer):
Changed the order of the checks to get the more likely check first.

(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Renamed from isSelfPaintingLayer to make m_isNormalFlowOnly.

(WebCore::RenderLayer::styleChanged):
Added code to update our cached m_isSelfPaintingLayer.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isSelfPaintingLayer):
Changed to return m_isSelfPaintingLayer.

9:19 PM Changeset in webkit [119675] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

One more Chromium rebaseline for r119617.

Also update the test expectation per r119659.
fast/sub-pixel/file-upload-control-at-fractional-offset.html should have MISSING expectation.

  • platform/chromium-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium/TestExpectations:
8:54 PM Changeset in webkit [119674] by rniwa@webkit.org
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

More Chromium rebaselines for r119591 and r119617.

  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
8:47 PM Changeset in webkit [119673] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add an image failure expectation to fast/repaint/fixed-tranformed.html
on Chromium Windows and Chromium Mac. The failure is tracked by the bug 88490.

  • platform/chromium/TestExpectations:
8:47 PM Changeset in webkit [119672] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
​https://bugs.webkit.org/show_bug.cgi?id=88059

Reviewed by Kent Tamura.

This patch changes not to share RenderStyle object for option and
optgroup element regardless attributes.

When we tried to shared RenderStyle object, rendering performance was
good but we had issue in selected option and text transform, see
​https://bugs.webkit.org/show_bug.cgi?id=88405 for details.

No new tests. This patch doesn't change behavior but rendering performance.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Changed to always
return false for option and optgroup.

8:39 PM Changeset in webkit [119671] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Optimize single-key get()
​https://bugs.webkit.org/show_bug.cgi?id=85288

Patch by Alec Flett <​alecflett@chromium.org> on 2012-06-06
Reviewed by Tony Chang.

No new tests, this is just an optimization.

After a recent refactoring, we started creating
an internal cursor with every call to get(). The
most common use of get() is with a single key,
so provide a fast-path to avoid creating the cursor.

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getByRangeInternal):

  • Modules/indexeddb/IDBKeyRange.h:

(WebCore::IDBKeyRange::isOnlyKey):
(IDBKeyRange):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):

8:39 PM Changeset in webkit [119670] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a timeout expectation to http/tests/media/video-cookie.html.
The failure is tracked by the Chromium issue 131533.

  • platform/chromium/TestExpectations:
8:16 PM Changeset in webkit [119669] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r119662.
​http://trac.webkit.org/changeset/119662
​https://bugs.webkit.org/show_bug.cgi?id=88487

Broke builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-06

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp:

(untestedCompareImages):

8:11 PM Changeset in webkit [119668] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Caret is not rendered in empty inline contenteditable elements
​https://bugs.webkit.org/show_bug.cgi?id=85793

Patch by Shezan Baig <​shezbaig.wk@gmail.com> on 2012-06-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

Override localCaretRect in RenderInline. The implementation was almost
identical to localCaretRect in RenderBlock for empty block elements, so
I refactored RenderBlock::localCaretRect and moved the logic to a new
method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
implementation of 'localCaretRect' in RenderBlock and RenderInline both
use this helper method in RenderBoxModelObject.

Tests: editing/selection/caret-in-empty-inline-1.html

editing/selection/caret-in-empty-inline-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):
Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
(WebCore):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Add localCaretRectForEmptyElement helper method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect):
(WebCore):

  • rendering/RenderInline.h:

(RenderInline):
Override localCaretRect using localCaretRectForEmptyElement.

LayoutTests:

Add test cases for caret in empty inline.

  • editing/selection/caret-in-empty-inline-1-expected.txt: Added.
  • editing/selection/caret-in-empty-inline-1.html: Added.
  • editing/selection/caret-in-empty-inline-2-expected.txt: Added.
  • editing/selection/caret-in-empty-inline-2.html: Added.
7:47 PM Changeset in webkit [119667] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Chromium build fix attempt. Why do we need to list these files in gyp!?

7:40 PM Changeset in webkit [119666] by pilgrim@chromium.org
  • 14 edits
    2 copies in trunk/Source

[Chromium] Move createMessagePortChannel to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=85764

Source/Platform:

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createMessagePortChannel):

  • chromium/public/WebMessagePortChannel.h: Added.

(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):

  • chromium/public/WebMessagePortChannelClient.h: Added.

(WebKit):
(WebMessagePortChannelClient):
(WebKit::WebMessagePortChannelClient::~WebMessagePortChannelClient):

Source/WebKit/chromium:

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • WebKit.gyp:
  • public/WebFrame.h:

(WebFrame):

  • public/WebMessagePortChannel.h:
  • public/WebMessagePortChannelClient.h:
  • public/WebSharedWorkerClient.h:

(WebSharedWorkerClient):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

  • src/PlatformMessagePortChannel.h:
  • src/SharedWorkerRepository.cpp:
  • src/WebSharedWorkerImpl.cpp:
7:39 PM Changeset in webkit [119665] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Add failing test expectation for the test added by r119644.
The failure is tracked by the bug 88481.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
7:32 PM Changeset in webkit [119664] by noel.gordon@gmail.com
  • 5 edits
    4 adds in trunk/LayoutTests

Add a test for PNG COLOR_TYPE_PALETTE image with a color profile
​https://bugs.webkit.org/show_bug.cgi?id=86722

Reviewed by Adam Barth

Add paletted PNG image with a color profile and write a test. Add platform exceptions
since color correction is not implemented on all platforms. Note: that wincairo skips
fast/images/*.

  • fast/images/paletted-png-with-color-profile-expected.txt: Added.
  • fast/images/paletted-png-with-color-profile.html: Added.
  • fast/images/resources/palatted-color-png-gamma-one-color-profile.png: Added.
  • platform/chromium/TestExpectations: No color correction for paletted PNG images.
  • platform/efl/TestExpectations: SKIP, no color correction.
  • platform/gtk/TestExpectations: SKIP, no color correction.
  • platform/mac-snowleopard/fast/images/paletted-png-with-color-profile-expected.png: Added.

The image is a 64-color, paletted PNG image containing a gamma 1.0 sRGB color profile.
See the bug for more detailed properties of the test image and its color profile.

  • platform/qt/TestExpectations: SKIP, no color correction.
7:22 PM Changeset in webkit [119663] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

Fix border-image-slice failures on ​http://css3test.com.
​https://bugs.webkit.org/show_bug.cgi?id=88328

Reviewed by Tony Chang.

Source/WebCore:

The old parsing code was assuming that the fill keyword comes after the
numbers or the percentage values. ​http://www.w3.org/TR/css3-background/#the-border-image-slice
defines the property like this : [<number> | <percentage>]{1,4} && fill? where the fill
keyword is not mandatory. But according to ​http://www.w3.org/TR/CSS2/about.html "&&"
separates two or more components, all of which must occur, in any order. So the previous
code was wrong the fill can come first following by the percentages or the numbers. ​http://css3test.com
was covering this particular case. I took the opportunity to extend our coverage
by adding tests on many different values the boder-image-slice property could take. I
also did a small cleanup by removing unused functions in BorderImageSliceParseContext.

Test: fast/css/getComputedStyle/getComputedStyle-border-image-slice.html

  • css/CSSParser.cpp:

(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitFill):

LayoutTests:

Make sure we cover more border-image-slice parsing.

  • fast/css/getComputedStyle/getComputedStyle-border-image-slice-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-image-slice.html: Added.
6:46 PM Changeset in webkit [119662] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Remove header dependency of ImageDiff to WTF
​https://bugs.webkit.org/show_bug.cgi?id=88422

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp:

(untestedCompareImages):

6:36 PM Changeset in webkit [119661] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] DeviceOrientation cleanup
​https://bugs.webkit.org/show_bug.cgi?id=88406

Patch by Amy Ousterhout <​aousterh@chromium.org> on 2012-06-06
Reviewed by Kent Tamura.

Made default constructor public and added a set function for each property.
This will allow us to remove the 8-parameter constructor.

  • public/WebDeviceOrientation.h:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::setNull):
(WebKit::WebDeviceOrientation::setAlpha):
(WebKit::WebDeviceOrientation::setBeta):
(WebKit::WebDeviceOrientation::setGamma):
(WebKit::WebDeviceOrientation::setAbsolute):
(WebDeviceOrientation):

Tools: [WebKit] DeviceOrientation cleanup
​https://bugs.webkit.org/show_bug.cgi?id=88406

Patch by Amy Ousterhout <​aousterh@chromium.org> on 2012-06-06
Reviewed by Kent Tamura.

Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setMockDeviceOrientation):

6:35 PM Changeset in webkit [119660] by fpizlo@apple.com
  • 31 edits
    2 moves in trunk/Source/JavaScriptCore

PredictedType should be called SpeculatedType
​https://bugs.webkit.org/show_bug.cgi?id=88477

Rubber stamped by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::prediction):

  • bytecode/LazyOperandValueProfile.h:

(LazyOperandValueProfileParser):

  • bytecode/PredictedType.cpp: Removed.
  • bytecode/PredictedType.h: Removed.
  • bytecode/SpeculatedType.cpp: Copied from Source/JavaScriptCore/bytecode/PredictedType.cpp.

(JSC::speculationToString):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromClassInfo):
(JSC::speculationFromStructure):
(JSC::speculationFromCell):
(JSC::speculationFromValue):

  • bytecode/SpeculatedType.h: Copied from Source/JavaScriptCore/bytecode/PredictedType.h.

(JSC):
(JSC::isAnySpeculation):
(JSC::isCellSpeculation):
(JSC::isObjectSpeculation):
(JSC::isFinalObjectSpeculation):
(JSC::isFinalObjectOrOtherSpeculation):
(JSC::isFixedIndexedStorageObjectSpeculation):
(JSC::isStringSpeculation):
(JSC::isArraySpeculation):
(JSC::isFunctionSpeculation):
(JSC::isInt8ArraySpeculation):
(JSC::isInt16ArraySpeculation):
(JSC::isInt32ArraySpeculation):
(JSC::isUint8ArraySpeculation):
(JSC::isUint8ClampedArraySpeculation):
(JSC::isUint16ArraySpeculation):
(JSC::isUint32ArraySpeculation):
(JSC::isFloat32ArraySpeculation):
(JSC::isFloat64ArraySpeculation):
(JSC::isArgumentsSpeculation):
(JSC::isActionableIntMutableArraySpeculation):
(JSC::isActionableFloatMutableArraySpeculation):
(JSC::isActionableTypedMutableArraySpeculation):
(JSC::isActionableMutableArraySpeculation):
(JSC::isActionableArraySpeculation):
(JSC::isArrayOrOtherSpeculation):
(JSC::isMyArgumentsSpeculation):
(JSC::isInt32Speculation):
(JSC::isDoubleRealSpeculation):
(JSC::isDoubleSpeculation):
(JSC::isNumberSpeculation):
(JSC::isBooleanSpeculation):
(JSC::isOtherSpeculation):
(JSC::isEmptySpeculation):
(JSC::mergeSpeculations):
(JSC::mergeSpeculation):

  • bytecode/StructureSet.h:

(JSC::StructureSet::speculationFromStructures):

  • bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(ValueProfileBase):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::speculateInt32Unary):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::speculationFromStructures):
(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validateIgnoringValue):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
(AbstractValue):

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):
(JSC::DFG::ArgumentPosition::prediction):
(ArgumentPosition):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getSpeculationWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getSpeculation):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::fixVariableAccessSpeculations):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::nameOfVariableAccessData):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::getJSConstantSpeculation):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getSpeculation):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):
(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateDouble):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateBoolean):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::shouldSpeculateArguments):
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint8ClampedArray):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):
(JSC::DFG::Node::shouldSpeculateArrayOrOther):
(JSC::DFG::Node::shouldSpeculateObject):
(JSC::DFG::Node::shouldSpeculateCell):
(Node):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::setPrediction):
(JSC::DFG::PredictionPropagationPhase::mergePrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(JSC::DFG::ValueSource::forSpeculation):
(SpeculativeJIT):
(GPRTemporary):
(FPRTemporary):
(JSC::DFG::SpecDoubleOperand::SpecDoubleOperand):
(JSC::DFG::SpecDoubleOperand::~SpecDoubleOperand):
(JSC::DFG::SpecDoubleOperand::fpr):
(JSC::DFG::SpecCellOperand::SpecCellOperand):
(JSC::DFG::SpecCellOperand::~SpecCellOperand):
(JSC::DFG::SpecCellOperand::gpr):
(JSC::DFG::SpecBooleanOperand::SpecBooleanOperand):
(JSC::DFG::SpecBooleanOperand::~SpecBooleanOperand):
(JSC::DFG::SpecBooleanOperand::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpecDouble):
(JSC::DFG::SpeculativeJIT::fillSpecCell):
(JSC::DFG::SpeculativeJIT::fillSpecBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpecDouble):
(JSC::DFG::SpeculativeJIT::fillSpecCell):
(JSC::DFG::SpeculativeJIT::fillSpecBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::nonUnifiedPrediction):
(JSC::DFG::VariableAccessData::prediction):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):
(VariableAccessData):

6:28 PM Changeset in webkit [119659] by leviw@chromium.org
  • 18 edits
    3 adds in trunk

Use enclosingIntRect instead of pixelSnappedIntRect in RenderFileUploadControl
​https://bugs.webkit.org/show_bug.cgi?id=88454

Reviewed by Kent Tamura.

Source/WebCore:

Properly clipping the file upload control to avoid clipping out the top of the file upload button
when the control is positioned at a sub-pixel offset that rounds up.

Test: fast/sub-pixel/file-upload-control-at-fractional-offset.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

Skipping new test on non-chromium platforms, and correcting a typo in several skipped files.
Also updating the bug number in the gtk skipped file to 85532 from 60318 to better reflect
the outstanding work of enabling each port to support sub-pixel layout, instead of sub-pixel
layout itself.

  • fast/sub-pixel/file-upload-control-at-fractional-offset.html: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
6:26 PM Changeset in webkit [119658] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1132

Merge 118955
BUG=129951
Review URL: ​https://chromiumcodereview.appspot.com/10543046

6:00 PM Changeset in webkit [119657] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Revert erroneous change in r119637.

  • platform/chromium/TestExpectations:
5:57 PM Changeset in webkit [119656] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/dom/ContainerNodeAlgorithms.h

Revert 119622 - Merge 118096
BUG=128157
Review URL: ​https://chromiumcodereview.appspot.com/10545041

TBR=​cevans@google.com
Review URL: ​https://chromiumcodereview.appspot.com/10543044

5:49 PM Changeset in webkit [119655] by fpizlo@apple.com
  • 33 edits
    4 adds in trunk/Source

Global object variable accesses should not require an extra load
​https://bugs.webkit.org/show_bug.cgi?id=88385

Source/JavaScriptCore:

Reviewed by Gavin Barraclough and Geoffrey Garen.

Previously, if you wanted to access a global variable, you'd first have
to load the register array from the appropriate global object and then
either load or store at an offset to the register array. This is because
JSGlobalObject inherited from JSVariableObject, and JSVariableObject is
designed with the pessimistic assumption that its register array may
point into the call stack. This is never the case for global objects.
Hence, even though the global object may add more registers at any time,
it does not need to store them in a contiguous array. It can use a
SegmentedVector or similar.

This patch refactors global objects and variable objects as follows:

  • The functionality to track variables in an indexable array using a SymbolTable to map names to indices is moved into JSSymbolTableObject, which is now a supertype of JSVariableObject. JSVariableObject is now just a holder for a registers array and implements the registerAt() method that is left abstract in JSSymbolTableObject. Because all users of JSVariableObject know whether they are a JSStaticScopeObject, JSActivation, or JSGlobalObject, this "abstract" method is not virtual; instead the utility methods that would call registerAt() are now template functions that require you to know statically what subtype of JSSymbolTableObject you're using (JSVariableObject or something else), so that registerAt() can be statically bound.


  • A new class is added called JSSegmentedVariableObject, which only differs from JSVariableObject in how it allocates registers. It uses a SegmentedVector instead of manually managing a pointer to a contiguous slab of registers. This changes the interface somewhat; for example with JSVariableObject if you wanted to add a register you had to do it yourself since the JSVariableObject didn't know how the registers array ought to be allocated. With JSSegmentedVariableObject you can just call addRegisters(). JSSegmentedVariableObject preserves the invariant that once you get a pointer into a register, that pointer will continue to be valid so long as the JSSegmentedVariableObject is alive. This allows the JITs and interpreters to skip the extra load.


  • JSGlobalObject now inherits from JSSegmentedVariableObject. For now (and possibly forever) it is the only subtype of this new class.


  • The bytecode format is changed so that get_global_var and put_global_var have a pointer to the register directly rather than having an index. A convenience method is provided in JSSegmentedVariableObject to get the index given a a pointer, which is used for assertions and debug dumps.


This appears to be a 1% across the board win.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Instruction.h:

(Instruction):
(JSC::Instruction::Instruction):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::registerPointer):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::retrieveLastUnaryOp):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(ResolveResult):
(BytecodeGenerator):

  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::globalObjectFor):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):
(Node):
(JSC::DFG::Node::hasRegisterPointer):
(JSC::DFG::Node::registerPointer):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.h:

(Heap):
(JSC::Heap::isWriteBarrierEnabled):
(JSC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSGlobalObject.cpp:

(JSC):
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::JSGlobalObject):
(JSC):
(JSC::JSGlobalObject::hasOwnPropertyForWrite):

  • runtime/JSSegmentedVariableObject.cpp: Added.

(JSC):
(JSC::JSSegmentedVariableObject::findRegisterIndex):
(JSC::JSSegmentedVariableObject::addRegisters):
(JSC::JSSegmentedVariableObject::visitChildren):

  • runtime/JSSegmentedVariableObject.h: Added.

(JSC):
(JSSegmentedVariableObject):
(JSC::JSSegmentedVariableObject::registerAt):
(JSC::JSSegmentedVariableObject::assertRegisterIsInThisObject):
(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
(JSC::JSSegmentedVariableObject::finishCreation):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putDirectVirtual):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSSymbolTableObject.cpp: Added.

(JSC):
(JSC::JSSymbolTableObject::destroy):
(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnPropertyNames):
(JSC::JSSymbolTableObject::putDirectVirtual):
(JSC::JSSymbolTableObject::isDynamicScope):

  • runtime/JSSymbolTableObject.h: Added.

(JSC):
(JSSymbolTableObject):
(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSVariableObject):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):
(JSC):

  • runtime/WriteBarrier.h:

Source/WebCore:

Reviewed by Gavin Barraclough and Geoffrey Garen.

Updated JSDOMWindowBase.cpp to use the new symbol table API. this->symbolTableFoo(...)
becomes symbolTableFoo(this, ...).

No new tests because no change in behavior.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::updateDocument):

5:49 PM Changeset in webkit [119654] by dpranke@chromium.org
  • 4 edits
    1 add in trunk/Tools

webkitpy: add support for an ordered dict of test expectations
​https://bugs.webkit.org/show_bug.cgi?id=87802

Reviewed by Ojan Vafai.

As per ​https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
support a cascaded list of test expectations files. An easy way
to think of this is as an ordered dictionary of name -> contents
for files, where the name is usually a path on disk (I say
usually because we want to support other kinds of expectations
like the compile-time skips for unsupported features in
webkit.py, and we want to continue to support "in-memory" test
expectations that don't require a filesystem).

Conveniently there is an OrderedDict implementation in Python
2.7+ and it is available as a backport, so the first step in
adding this support is to use that implementation. Subsequent
patches will update the test_expectations.py module (and other
callers) to access the dict directly.

This patch just changes the base internal implementation and
provides wrappers for compatibility. The derived ports
(WebKitPort, TestPort, etc.) still need to be updated.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._expectations_dict):
(Port.test_expectations):
(Port):
(Port._expectations_overrides_dict):
(Port.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_expectations_ordering):
(PortTestCase):
(PortTestCase.test_expectations_overrides_ordering):

  • Scripts/webkitpy/thirdparty/ordered_dict.py: Added.

(OrderedDict):
(OrderedDict.init):
(OrderedDict.clear):
(OrderedDict.setitem):
(OrderedDict.delitem):
(OrderedDict.iter):
(OrderedDict.reversed):
(OrderedDict.popitem):
(OrderedDict.reduce):
(OrderedDict.repr):
(OrderedDict.copy):
(OrderedDict.fromkeys):

5:39 PM Changeset in webkit [119653] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
fast/loader/reload-zero-byte-plugin.html

Skip another affected test on Windows to get the bots greener.

  • platform/win/Skipped:
5:39 PM Changeset in webkit [119652] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed gardening. Unit test fails on GTK 64bit debug bot.

  • gtk/run-api-tests:

(TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.

5:38 PM Changeset in webkit [119651] by jamesr@google.com
  • 4 edits
    4 moves in trunk/Source

[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
​https://bugs.webkit.org/show_bug.cgi?id=86257

Reviewed by Kenneth Russell.

Source/WebCore:

The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium
on top of the Platform interface WebGraphicsContext3D. This moves the implementation support code from
WebKit/chromium/src to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore
interfaces and allows code in WebCore/platform to use this support code directly where appropriate.

Refactor only, no new functionality or tests.

  • WebCore.gypi:
  • platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.

(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.

(WebCore):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):

  • platform/chromium/support/GraphicsContext3DPrivate.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.cpp.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(GraphicsContext3DContextLostCallbackAdapter):
(WebCore::GraphicsContext3DContextLostCallbackAdapter::GraphicsContext3DContextLostCallbackAdapter):
(WebCore::GraphicsContext3DContextLostCallbackAdapter::~GraphicsContext3DContextLostCallbackAdapter):
(WebCore::GraphicsContext3DContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsContext3DErrorMessageCallbackAdapter):
(WebCore::GraphicsContext3DErrorMessageCallbackAdapter::GraphicsContext3DErrorMessageCallbackAdapter):
(WebCore::GraphicsContext3DErrorMessageCallbackAdapter::~GraphicsContext3DErrorMessageCallbackAdapter):
(WebCore::GraphicsContext3DErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):

  • platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.

(WebKit):
(WebCore):
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::webContext):
(WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer):

Source/WebKit/chromium:

  • WebKit.gyp:
5:37 PM Changeset in webkit [119650] by rniwa@webkit.org
  • 115 edits
    38 adds
    1 delete in trunk/LayoutTests

Chromium rebaseline after r119617 part 5.

  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/columns-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug16252-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43039-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-linux/tables/mozilla/core/borders-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test6-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug19526-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/col_span2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/columns-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/other: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/other/empty_cells-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug131020-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56405-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-win/tables/mozilla/core/borders-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_span-expected.png:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.png:
5:31 PM Changeset in webkit [119649] by dpranke@chromium.org
  • 10 edits in trunk/Tools

nrwt should look in 'out' for binaries on chromium win to support ninja
​https://bugs.webkit.org/show_bug.cgi?id=88273

Reviewed by Tony Chang.

This patch standardizes the search algorithm the chromium ports
use to figure out which driver to run. We will look in a
chromium location before a webkit location (e.g., in
Source/WebKit/chromium/out before out/) and we will look in the
"legacy" directory (xcodebuild) before the directory ninja uses
(out).

Unfortunately due to the way the test code is set up testing the
properly requires some duplication of test code. I will fix that
in a followup patch.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._static_build_path):
(ChromiumPort._build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):
(ChromiumLinuxPort._determine_driver_path_statically):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):
(ChromiumLinuxPortTest):
(ChromiumLinuxPortTest.test_driver_name_option):
(ChromiumLinuxPortTest.path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):
(ChromiumMacPortTest):
(ChromiumMacPortTest.test_driver_name_option):
(ChromiumMacPortTest.path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_overrides_and_builder_names):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):
(ChromiumWinTest.test_operating_system):
(ChromiumWinTest):
(ChromiumWinTest.test_driver_name_option):
(ChromiumWinPortTest.path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.assert_build_path):

5:27 PM Changeset in webkit [119648] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r119624.
​http://trac.webkit.org/changeset/119624
​https://bugs.webkit.org/show_bug.cgi?id=88472

Caused worker tests to become flaky (Requested by mhahnenberg
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-06

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::~AbstractWorker):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerObjectDestroyed):

5:23 PM Changeset in webkit [119647] by fpizlo@apple.com
  • 8 edits
    6 adds in trunk

DFG arguments access slow path should not crash if the arguments haven't been created
​https://bugs.webkit.org/show_bug.cgi?id=88471

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/dfg-arguments-out-of-bounds-expected.txt: Added.
  • fast/js/dfg-arguments-out-of-bounds.html: Added.
  • fast/js/dfg-inline-arguments-out-of-bounds-expected.txt: Added.
  • fast/js/dfg-inline-arguments-out-of-bounds.html: Added.
  • fast/js/script-tests/dfg-arguments-out-of-bounds.js: Added.

(foo.bar):
(foo):

  • fast/js/script-tests/dfg-inline-arguments-out-of-bounds.js: Added.

(foo):
(bar):

5:20 PM Changeset in webkit [119646] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1132

Merge 119409
BUG=130369
Review URL: ​https://chromiumcodereview.appspot.com/10546039

5:13 PM Changeset in webkit [119645] by rniwa@webkit.org
  • 132 edits
    11 adds
    1 delete in trunk/LayoutTests

Chromium rebaseline after r119617 part 4.

  • platform/chromium-linux-x86/fast/text/international: Added.
  • platform/chromium-linux-x86/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-linux-x86/ietestcenter: Added.
  • platform/chromium-linux-x86/ietestcenter/css3: Added.
  • platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds: Added.
  • platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/compositing: Removed.
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/chromium-linux/fast/text/softHyphen-expected.png:
  • platform/chromium-linux/fast/text/wbr-expected.png:
  • platform/chromium-linux/fast/text/whitespace/024-expected.png:
  • platform/chromium-linux/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/fonts/cursive-expected.png:
  • platform/chromium-linux/fonts/default-expected.png:
  • platform/chromium-linux/fonts/fantasy-expected.png:
  • platform/chromium-linux/fonts/serif-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/media/video-frame-size-change-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-linux/printing/return-from-printing-mode-expected.png:
  • platform/chromium-linux/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-linux/svg/custom/altglyph-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/chromium-linux/svg/text/multichar-glyph-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-leopard/media/video-zoom-expected.png:
  • platform/chromium-mac-leopard/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-mac-leopard/scrollbars/disabled-scrollbar-expected.png:
  • platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/disabled-scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/img-layer-grow-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-mac/scrollbars/disabled-scrollbar-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-win-vista/platform/chromium/compositing: Added.
  • platform/chromium-win-vista/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-win/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-win/fast/text/word-break-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-win/media/video-zoom-expected.png:
  • platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-win/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/svg/custom/altglyph-expected.png:
  • platform/chromium-win/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/chromium-win/svg/custom/junk-data-expected.png:
  • platform/chromium-win/svg/custom/missing-xlink-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/chromium-win/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png:
  • platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/hixie/error/012-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/chromium-win/svg/repaint/image-with-clip-path-expected.png:
  • platform/chromium-win/svg/text/multichar-glyph-expected.png:
5:10 PM Changeset in webkit [119644] by beidson@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/11575112> and ​https://bugs.webkit.org/show_bug.cgi?id=88428
REGRESSION (r115654): Opening many non-English WebArchives shows obvious encoding issues

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/loader/webarchive-encoding-respected.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): Properly set the main resource encoding from the webarchive.

LayoutTests:

  • fast/loader/resources/utf8-encoded.webarchive: Added.
  • fast/loader/webarchive-encoding-respected-expected.txt: Added.
  • fast/loader/webarchive-encoding-respected.html: Added.
5:10 PM Changeset in webkit [119643] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 119227
BUG=130723
Review URL: ​https://chromiumcodereview.appspot.com/10543041

5:09 PM Changeset in webkit [119642] by dgrogan@chromium.org
  • 6 edits
    2 adds in branches/chromium/1132/Source

Re-Merge 117978

original bug at ​https://bugs.webkit.org/show_bug.cgi?id=85579

BUG=130671
Review URL: ​https://chromiumcodereview.appspot.com/10535043

5:07 PM Changeset in webkit [119641] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merge r119570.

5:06 PM Changeset in webkit [119640] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 119050
BUG=130235
Review URL: ​https://chromiumcodereview.appspot.com/10539032

5:03 PM Changeset in webkit [119639] by mrowe@apple.com
  • 4 edits in branches/safari-536-branch/Source/WebCore

Merge r119548.

5:01 PM Changeset in webkit [119638] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merge r119535.

4:48 PM Changeset in webkit [119637] by rniwa@webkit.org
  • 180 edits
    29 adds
    2 deletes in trunk/LayoutTests

Chromium rebaseline after r119617 part 3.

  • platform/chromium-linux-x86/fast/images: Removed.
  • platform/chromium-linux-x86/fast/media: Removed.
  • platform/chromium-linux-x86/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/form-hides-table-expected.png:
  • platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-linux/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png:
  • platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.png:
  • platform/chromium-linux/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/li-br-expected.png:
  • platform/chromium-linux/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-linux/fast/multicol/float-paginate-expected.png:
  • platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-linux/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-linux/fast/overflow/005-expected.png:
  • platform/chromium-linux/fast/overflow/008-expected.png:
  • platform/chromium-linux/fast/overflow/childFocusRingClip-expected.png:
  • platform/chromium-linux/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-linux/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-linux/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-linux/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-linux/fast/table/023-expected.png:
  • platform/chromium-linux/fast/table/027-vertical-expected.png:
  • platform/chromium-linux/fast/table/034-expected.png:
  • platform/chromium-linux/fast/table/040-expected.png:
  • platform/chromium-linux/fast/table/040-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-linux/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-linux/fast/table/wide-colspan-expected.png:
  • platform/chromium-linux/fast/table/wide-column-expected.png:
  • platform/chromium-mac/fast/frames/transparent-scrollbar-expected.png:
  • platform/chromium-win-vista/fast/multicol: Added.
  • platform/chromium-win-vista/fast/multicol/span: Added.
  • platform/chromium-win-vista/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-win/fast/forms/button-default-title-expected.png:
  • platform/chromium-win/fast/forms/form-hides-table-expected.png:
  • platform/chromium-win/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-win/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-win/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/chromium-win/fast/frames/transparent-scrollbar-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.png:
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/inline-block/tricky-baseline-expected.png:
  • platform/chromium-win/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-win/fast/inline/long-wrapped-line-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.png:
  • platform/chromium-win/fast/layers/overflow-scroll-auto-switch-expected.png:
  • platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/chromium-win/fast/lists/001-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/li-br-expected.png:
  • platform/chromium-win/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-win/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/overflow/003-expected.png:
  • platform/chromium-win/fast/overflow/005-expected.png:
  • platform/chromium-win/fast/overflow/007-expected.png:
  • platform/chromium-win/fast/overflow/008-expected.png:
  • platform/chromium-win/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-win/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-win/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-win/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-win/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-win/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/chromium-win/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/fast/table/034-expected.png:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/chromium-win/fast/table/edge-offsets-expected.png:
  • platform/chromium-win/fast/table/empty-cells-expected.png:
  • platform/chromium-win/fast/table/frame-and-rules-expected.png:
  • platform/chromium-win/fast/table/overflowHidden-expected.png:
  • platform/chromium-win/fast/table/table-display-types-expected.png:
  • platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-win/fast/table/wide-colspan-expected.png:
  • platform/chromium-win/fast/table/wide-column-expected.png:
  • platform/chromium/TestExpectations:
4:42 PM Changeset in webkit [119636] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Remove very red Windows WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=88452

Reviewed by Steve Falkenburg.

Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
need to focus on getting the WK1 testers green.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:21 PM Changeset in webkit [119635] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed build fix, add an apparently used include of OwnArrayPtr.h back to GraphicsContext3DPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=88468

  • src/GraphicsContext3DPrivate.h:
4:21 PM Changeset in webkit [119634] by rniwa@webkit.org
  • 120 edits
    8 adds
    2 deletes in trunk/LayoutTests

Chromium rebaseline after r119617 part 2.

  • fast/block/float/021-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-lr: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/block/float/019-expected.png:
  • platform/chromium-linux/fast/block/float/021-expected.png:
  • platform/chromium-linux/fast/block/float/025-expected.png:
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/027-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-linux/fast/block/float/033-expected.png:
  • platform/chromium-linux/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-linux/fast/block/positioning/047-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-linux/fast/block/positioning/negative-rel-position-expected.png:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/002-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/chromium-linux/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-linux/fast/css/005-expected.png:
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-linux/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/chromium-linux/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/font_property_normal-expected.png:
  • platform/chromium-linux/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/chromium-linux/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-linux/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
  • platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/chromium-linux/fast/dynamic/008-expected.png:
  • platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/events/resize-events-expected.png:
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-linux/fast/flexbox/016-expected.png:
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/34176-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-win/fast/block/float/008-expected.png:
  • platform/chromium-win/fast/block/float/021-expected.png:
  • platform/chromium-win/fast/block/float/021-expected.txt:
  • platform/chromium-win/fast/block/float/032-expected.png:
  • platform/chromium-win/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/chromium-win/fast/block/float/br-with-clear-2-expected.png:
  • platform/chromium-win/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/104-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-win/fast/block/positioning/047-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-win/fast/block/positioning/negative-rel-position-expected.png:
  • platform/chromium-win/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/chromium-win/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-win/fast/clip/014-expected.png:
  • platform/chromium-win/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/chromium-win/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/font_property_normal-expected.png:
  • platform/chromium-win/fast/css/hsl-color-expected.png:
  • platform/chromium-win/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/chromium-win/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/chromium-win/fast/css/word-space-extra-expected.png:
  • platform/chromium-win/fast/dom/34176-expected.png:
  • platform/chromium-win/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
  • platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.png:
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/events/resize-events-expected.png:
  • platform/chromium-win/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-win/fast/flexbox/016-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/block/float/021-expected.txt: Removed.
  • platform/gtk/fast/block/float/021-expected.txt: Removed.
4:11 PM Changeset in webkit [119633] by msaboff@apple.com
  • 14 edits in trunk/Source

ENH: Add Logging to GC Marking Phase
​https://bugs.webkit.org/show_bug.cgi?id=88364

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Log GC marking to stderr or a file. The logging in controlled
with the define ENABLE_OBJECT_MARK_LOGGING in wtf/Platform.h.
If DATA_LOG_TO_FILE in wtf/DataLog.cpp is set to 1, output is
logged to a file otherwise it is logged to stderr.

When logging is enabled, the GC is built single threaded since the
log output from the various threads isn't buffered and output in a
thread safe manner.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::resetChildren):
(JSC::MarkStackThreadSharedData::childVisitCount):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):

  • heap/MarkStack.h:

(MarkStackThreadSharedData):
(MarkStack):
(JSC::MarkStack::sharedData):
(JSC::MarkStack::resetChildCount):
(JSC::MarkStack::childCount):
(JSC::MarkStack::incrementChildCount):

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSCell.cpp:

(JSC::JSCell::className):

  • runtime/JSCell.h:

(JSCell):
(JSC::JSCell::visitChildren):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):

  • runtime/JSString.h:

(JSString):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

Source/WTF:

  • wtf/DataLog.cpp:

(WTF::dataLogString): Additional method to support GC Mark logging.

  • wtf/DataLog.h:
  • wtf/Platform.h: New ENABLE_OBJECT_MARK_LOGGING flag macro.
4:04 PM Changeset in webkit [119632] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118816
BUG=129947
Review URL: ​https://chromiumcodereview.appspot.com/10533037

3:59 PM Changeset in webkit [119631] by jamesr@google.com
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Clean up GraphicsContext3D implementation
​https://bugs.webkit.org/show_bug.cgi?id=88460

Reviewed by Kenneth Russell.

Chromium's implementation of the GraphicsContext3D implementation has been somewhat messy for historical
reasons. The actual implementation of the majority of these functions is done by delegating to the Platform API
WebGraphicsContext3D. A few bits of functionality - extension mapping, some compositor functionality, a readback
utility - are implemented by code in WebKit. Previously, all GraphicsContext3D functions delegates to a clone of
the interface in GraphicsContext3DPrivate which in turn delegated to WebGraphicsContext3D. This required
duplicating the entire GraphicsContext3D interface and made updating the interface an epic pain in the rear.

This patch provides the implementations of GraphicsContext3D functions in GraphicsContext3DChromium.cpp. Most of
these functions delegate directly to WebGraphicsContext3D. The ones that do not delegate to
GraphicsContext3DPrivate, which now has a dedicated header and cpp file. GraphicsContext3DPrivate.cpp implements
all GraphicsContext3DPrivate functions. I've also reordered the implementation files so that the function order
matches the associated header file and normalized the names of callback adapters.

Refactor only, no change in functionality. Existing tests apply.

  • WebKit.gyp:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):

  • src/GraphicsContext3DPrivate.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::webContext):
(WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer):

3:58 PM Changeset in webkit [119630] by rniwa@webkit.org
  • 133 edits
    11 adds
    7 deletes in trunk/LayoutTests

Chromium rebaseline after r119617 part 1.

  • platform/chromium-linux-x86/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-linux-x86/css2.1/20110323: Removed.
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/scaling: Removed.
  • platform/chromium-linux/css1/basic/comments-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_style-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_width-expected.png:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css1/box_properties/margin-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_top-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/width-expected.png:
  • platform/chromium-linux/css1/color_and_background/background-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_position-expected.png:
  • platform/chromium-linux/css1/font_properties/font-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/css1/font_properties/font_weight-expected.png:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-linux/css1/pseudo/firstletter-expected.png:
  • platform/chromium-linux/css1/pseudo/firstline-expected.png:
  • platform/chromium-linux/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-linux/css1/text_properties/line_height-expected.png:
  • platform/chromium-linux/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-linux/css1/text_properties/text_transform-expected.png:
  • platform/chromium-linux/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-linux/css1/units/color_units-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t1202-counters-08-b-expected.png:
  • platform/chromium-linux/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-linux/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-linux/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-linux/editing/selection/select-all-003-expected.png:
  • platform/chromium-linux/editing/selection/select-all-004-expected.png:
  • platform/chromium-mac-leopard/compositing/masks/multiple-masks-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac/compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
  • platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
  • platform/chromium-mac/compositing/layer-creation/fixed-position-and-transform-expected.png: Added.
  • platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png:
  • platform/chromium-mac/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win-vista/css1/formatting_model/inline_elements-expected.png: Removed.
  • platform/chromium-win-vista/css1/formatting_model/replaced_elements-expected.png: Added.
  • platform/chromium-win-xp/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win-xp/css1/formatting_model: Removed.
  • platform/chromium-win-xp/css1/formatting_model/inline_elements-expected.png: Removed.
  • platform/chromium-win/compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png:
  • platform/chromium-win/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/fixed-position-and-transform-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png:
  • platform/chromium-win/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
  • platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-win/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win/css1/basic/comments-expected.png:
  • platform/chromium-win/css1/basic/inheritance-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_width-expected.png:
  • platform/chromium-win/css1/box_properties/clear-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/height-expected.png:
  • platform/chromium-win/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_top-expected.png:
  • platform/chromium-win/css1/box_properties/padding-expected.png:
  • platform/chromium-win/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-win/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding_top-expected.png:
  • platform/chromium-win/css1/classification/white_space-expected.png:
  • platform/chromium-win/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-win/css1/color_and_background/background_position-expected.png:
  • platform/chromium-win/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-win/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-win/css1/font_properties/font_weight-expected.png:
  • platform/chromium-win/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-win/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-win/css1/pseudo/firstline-expected.png:
  • platform/chromium-win/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-win/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-win/css1/text_properties/text_indent-expected.png:
  • platform/chromium-win/css1/text_properties/text_transform-expected.png:
  • platform/chromium-win/css1/units/color_units-expected.png:
  • platform/chromium-win/css1/units/length_units-expected.png:
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png:
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/chromium-win/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-023-expected.png:
  • platform/chromium-win/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-win/editing/selection/select-all-003-expected.png:
  • platform/chromium-win/editing/selection/select-all-004-expected.png:
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
3:55 PM Changeset in webkit [119629] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118703
BUG=128498
Review URL: ​https://chromiumcodereview.appspot.com/10533036

3:55 PM ScalesAndZooms edited by jamesr@google.com
(diff)
3:44 PM Changeset in webkit [119628] by dpranke@chromium.org
  • 3 edits in trunk/Tools

get rebaselining tools to kinda work with the skia overrides file
​https://bugs.webkit.org/show_bug.cgi?id=88456

Reviewed by Ryosuke Niwa.

Update rebaseline-expectations so that we read in the overrides
when looking for tests to rebaseline, but don't read in the
overrides when we are writing the expectations file back out.
This prevents the overrides from getting written into the main
file. This is kind of a hack but will have to do until we
support multiple expectations files properly.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations._expectations):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_overrides_are_included_correctly):

3:44 PM Changeset in webkit [119627] by cevans@google.com
  • 16 edits in branches/chromium/1132/Source/WebCore

Merge 118608
BUG=124356
Review URL: ​https://chromiumcodereview.appspot.com/10540037

3:38 PM Changeset in webkit [119626] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118213
BUG=127371
Review URL: ​https://chromiumcodereview.appspot.com/10543038

3:30 PM Changeset in webkit [119625] by cevans@google.com
  • 6 edits in branches/chromium/1132

Merge 118725
BUG=118725
Review URL: ​https://chromiumcodereview.appspot.com/10542040

3:28 PM Changeset in webkit [119624] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

Worker tear-down can re-enter JSC during GC finalization
​https://bugs.webkit.org/show_bug.cgi?id=88449

Reviewed by Geoffrey Garen.

No new tests. Current regression tests cover these changes.

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
will be called elsewhere in contextDestroyed().

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerObjectDestroyed): We make the call to terminateWorkerContext()
and workerContextDestroyed() asynchronous to avoid entering JSC during GC finalization.

3:09 PM Changeset in webkit [119623] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Assigning to a static property should not change iteration order
​https://bugs.webkit.org/show_bug.cgi?id=88401

Reviewed by Geoff Garen.

A specific iteration order is not defined by the spec, but test-262 somewhat tenuously
requires that it is at least stable, e.g. ch10/10.4/10.4.2/S10.4.2_A1.1_T1.js

Whilst it is not clear that this behavior really arises from the specification, it
would seem like common sense to conform to this.

The problem here is that we allow properties in the structure to shadow those in the
static table, and we iterate the properties in the structure first - which means that
as values of existing properties are modified, their iteration order changes too.

The easy fix is to iterate the properties from the static table first. This has a
further benefit, since it will mean that user added properties will come after those
present in the static table (respected the expected insertion-order).

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

  • Iterate static properties first.

LayoutTests:

  • fast/js/property-iteration-expected.txt: Added.
  • fast/js/property-iteration.html: Added.
  • fast/js/script-tests/property-iteration.js: Added.

(arrayEqual):

  • Added test case.
2:48 PM Changeset in webkit [119622] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/dom/ContainerNodeAlgorithms.h

Merge 118096
BUG=128157
Review URL: ​https://chromiumcodereview.appspot.com/10545041

2:43 PM Changeset in webkit [119621] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp

Merge 118542
BUG=120944
Review URL: ​https://chromiumcodereview.appspot.com/10538032

2:41 PM Changeset in webkit [119620] by tony@chromium.org
  • 9 edits in trunk

webkit crashes on debug builds when running IETC flexbox-ordinal-group-001.htm
​https://bugs.webkit.org/show_bug.cgi?id=85832

Reviewed by Ojan Vafai.

Source/WebCore:

We were using a HashSet<unsigned>, which can't hold the value of 0.
According to the spec, 0 isn't a valid value, so at CSS parse time,
reject the value 0. This lets us pass the test, although that's kind
of by accident.

We could allow 0 for box-ordinal-group, but there are some perf implications
to having allowing a value below the initial value (1 in this case).

We still allow 0 for box-flex-group, because that's what the existing code
does and there are tests expecting this behavior.

No new tests, covered by ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm
which was crashing.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Reject 0 for -webkit-box-ordinal-group.

LayoutTests:

  • platform/chromium/TestExpectations: Remove test that passes.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
2:19 PM Changeset in webkit [119619] by ddkilzer@apple.com
  • 2 edits in trunk

Teach git about localizable *.strings files
<​http://webkit.org/b/88447>

Reviewed by Adam Roben.

  • .gitattributes: Set diff attribute for *.strings files so

git-diff doesn't complain about them being binary files once the
git-config command is run.

2:16 PM Changeset in webkit [119618] by ojan@chromium.org
  • 5 edits in trunk

Remove some magic from the -webkit-flex shorthand parsing to match the changes in the spec
​https://bugs.webkit.org/show_bug.cgi?id=88444

Reviewed by Tony Chang.

Source/WebCore:

-Unset positive flex defaults to 0.
-Unset negative flex defaults to 1. No magic of doing something different if positive flex was set.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
2:11 PM Changeset in webkit [119617] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Revert r119440 now that I have a time to rebaseline them all!

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbLength):

2:03 PM Changeset in webkit [119616] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: two manager_worker_broker_unittest tests are broken
​https://bugs.webkit.org/show_bug.cgi?id=88445

Reviewed by Ojan Vafai.

These tests were never updated when we removed the
--worker-model argument, and we were passing 'inline' instead of
1 (for the number of workers) :(. As a result we were creating
multiprocessing queues unnecessarily and that was failing on cygwin.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):

2:01 PM Changeset in webkit [119615] by jsbell@chromium.org
  • 5 edits in trunk

IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
​https://bugs.webkit.org/show_bug.cgi?id=88431

Reviewed by Tony Chang.

Source/WebCore:

Function was calling itself, rather than delegating to the correct (IDBKeyRange) overload.

Test: storage/indexeddb/legacy-constants.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):

LayoutTests:

  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/resources/legacy-constants.js: Refactored and added test cases.

(populateStore):
(doChecks.doNext.request.onsuccess):
(doChecks.doNext.testWithKey.request.onsuccess):
(doChecks.doNext.testWithKey):
(doChecks.doNext):
(doChecks):

1:56 PM Changeset in webkit [119614] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merge r119261.

1:56 PM Changeset in webkit [119613] by mrowe@apple.com
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merge r119260.

1:56 PM Changeset in webkit [119612] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit/mac

Merge r119339.

1:56 PM Changeset in webkit [119611] by mrowe@apple.com
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merge r119136.

1:56 PM Changeset in webkit [119610] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-536-branch

Merge r119274.

1:56 PM Changeset in webkit [119609] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merge r118995.

1:56 PM Changeset in webkit [119608] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merge r118992.

1:41 PM Changeset in webkit [119607] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Avoid limiting page-scale-factor when device-scale-factor is applied in the compositor.
​https://bugs.webkit.org/show_bug.cgi?id=88417

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-06-06
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

1:24 PM Changeset in webkit [119606] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:12 PM Changeset in webkit [119605] by rniwa@webkit.org
  • 4 edits in trunk/Tools

REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=87406

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_does_not_include_overrides):

12:57 PM Changeset in webkit [119604] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: perf tests unit tests fail on chromium win
​https://bugs.webkit.org/show_bug.cgi?id=88279

Reviewed by Ryosuke Niwa.

I'm seeing weird failures running the unit tests in my win32
checkout, and we don't really expect webpagereplay to work on
win32 anyway, so I'm skipping the import of that module for now
and adding a warning.

  • Scripts/run-perf-tests:
  • Scripts/webkitpy/performance_tests/perftest.py:
12:00 PM Changeset in webkit [119603] by jsbell@chromium.org
  • 5 edits in trunk

IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
​https://bugs.webkit.org/show_bug.cgi?id=86874

Reviewed by Ojan Vafai.

Source/WebCore:

The function is non-standard, and should be prefixed.

Test: storage/indexeddb/factory-basics.html

  • Modules/indexeddb/IDBFactory.idl:

LayoutTests:

  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/resources/factory-basics.js:

(test):
(openSuccess):
(deleteDatabaseSuccess):

11:59 AM Changeset in webkit [119602] by wingo@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

Ensure consistent order of evaluation in LLInt slow paths
​https://bugs.webkit.org/show_bug.cgi?id=88409

Reviewed by Geoffrey Garen.

  • llint/LLIntSlowPaths.cpp:

(slow_path_mul)
(slow_path_sub)
(slow_path_div)
(slow_path_mod)
(slow_path_lshift)
(slow_path_rshift)
(slow_path_urshift)
(slow_path_bitand)
(slow_path_bitor)
(slow_path_bitxor): Avoid calling toNumber, toInt32, or toUInt32
multiple times without intervening sequence points. Fixes
fast/js/exception-sequencing-binops.html with GCC 4.7 on x86-64
Linux, which reordered evaluation of the arguments to fmod.

11:47 AM Changeset in webkit [119601] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my email address in committers.py.

Patch by Yong Li <​yoli@rim.com> on 2012-06-06

  • Scripts/webkitpy/common/config/committers.py:
11:00 AM Changeset in webkit [119600] by thakis@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose setPictographFontFamily through the chromium webkit api.
​https://bugs.webkit.org/show_bug.cgi?id=88393

Reviewed by Adam Barth.

This was added to WebCore in
​https://bugs.webkit.org/show_bug.cgi?id=65197

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPictographFontFamily):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

10:58 AM Changeset in webkit [119599] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:51 AM Changeset in webkit [119598] by rniwa@webkit.org
  • 3 edits
    11 adds
    1 delete in trunk/LayoutTests

Chromium rebaseline after r119591 because it was failing with missing results.

  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
  • platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
10:34 AM Changeset in webkit [119597] by rjkroege@chromium.org
  • 2 edits in trunk/Tools

Add Robert Kroeger to commiters.py
​https://bugs.webkit.org/show_bug.cgi?id=88415

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
10:33 AM Changeset in webkit [119596] by commit-queue@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

[WK2] fast/hidpi/device-scale-factor-paint.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=88350

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-06-06
Reviewed by Alexey Proskuryakov.

  • fast/hidpi/device-scale-factor-paint-expected.html: Renamed from LayoutTests/platform/chromium/fast/hidpi/device-scale-factor-paint-expected.html.
  • platform/wk2/Skipped:
10:21 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:20 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:15 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:13 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:12 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
9:47 AM Changeset in webkit [119595] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline for r119591.

  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
9:07 AM Changeset in webkit [119594] by jchaffraix@webkit.org
  • 9 edits
    30 adds in trunk

Add support for direction on table row group with collapsing borders
​https://bugs.webkit.org/show_bug.cgi?id=87900

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html

fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html
fast/table/border-collapsing/left-border-table-ltr-section-rtl.html
fast/table/border-collapsing/left-border-table-rtl-section-ltr.html
fast/table/border-collapsing/left-border-table-rtl-section-rtl.html
fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html
fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html
fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html
fast/table/border-collapsing/rtl-table-left-border-hidden.html
fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html
fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html
fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html
fast/table/table-ltr-section-rtl.html
fast/table/table-rtl-section-ltr.html
fast/table/table-rtl-section-rtl.html

This change enables proper support for direction on table row group.
The current code would allow people to set direction on the row group but would still
use the table's code for directionality checks (with surprising consequences).

The main change involve swapping end / start borders in case of mixed directionality
as those 2 are not in sync.

Example: <table dir="ltr"><tbody dir="rtl"><td id="cell0"></td><td id="cell1"></td></tbody></table>

Visually:
Table: Start ---------------------> End
Tbody: End <---------------------- Start
Cell: | #cell0 | #cell1 |

In this example, the end table border should be compared with the tbody's start border
and the last cell's (in DOM order) start border.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
Same as the other adjoining functions.

  • rendering/RenderTable.h:

(WebCore::RenderTable::lastColumnIndex):
Helper function to get the last column index.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Updated to call the table's adjoining border helpers.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::styleForCellFlow):
Updated to use the table row group's style now that we properly support it.

(WebCore::RenderTableCell::isFirstOrLastCellInRow):
Debug only helper to make sure we don't call the border adjoining function
on non-terminal cells.

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Updated the previous function to account for mixed directionality.

(WebCore::RenderTableSection::layoutRows):
Move some of the code to setLogicalPositionForCell to match RenderBlock.

(WebCore::RenderTableSection::setLogicalPositionForCell):
Switched direction checks to styleForCellFlow (this doesn't change anything as we
were already properly flipping already but ensure better).

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::hasSameDirectionAsTable):
Added this helper to know if we have a mixed direction.

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated to account for mixed directionality.

LayoutTests:

  • fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-ltr-expected.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-ltr.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr-expected.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html: Added.
  • fast/table/border-collapsing/rtl-table-left-border-hidden-expected.html: Added.
  • fast/table/border-collapsing/rtl-table-left-border-hidden.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr-expected.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html: Added.

Most of those are test are a variation of direction on table and row group along with disabling some
borders (either using 'hidden' or just disabling it by setting it to 0px).

  • fast/table/table-ltr-section-rtl-expected.html: Added.
  • fast/table/table-ltr-section-rtl.html: Added.
  • fast/table/table-rtl-section-ltr-expected.html: Added.
  • fast/table/table-rtl-section-ltr.html: Added.
  • fast/table/table-rtl-section-rtl-expected.html: Added.
  • fast/table/table-rtl-section-rtl.html: Added.

Bonus as there was little testing for mixed direction + separate borders.

9:00 AM Changeset in webkit [119593] by wingo@igalia.com
  • 10 edits in trunk

[GTK] Enable the LLInt
​https://bugs.webkit.org/show_bug.cgi?id=88315

Reviewed by Filip Pizlo.

.:

  • configure.ac: Require Ruby, to build the low-level interpreter.

Source/JavaScriptCore:

  • GNUmakefile.am: Add rules to generate LLIntDesiredOffsets.h and

LLIntAssembly.h.

  • GNUmakefile.list.am: Add offlineasm and llint files to the

dist. Add LLInt source files to the build.

  • llint/LowLevelInterpreter.asm (crash): Generate a store of

0xbbadbeef to a register, not to a constant. Otherwise, gas was
failing to assemble result.

  • offlineasm/asm.rb (labelReference): Generate a

SYMBOL_STRING_RELOCATION instead of a SYMBOL_STRING, so that we go
through the PLT on ELF systems.

Source/WTF:

  • wtf/InlineASM.h: Add an implementation of LOCAL_LABEL_STRING for

OS(LINUX).

  • wtf/Platform.h: Add OS(LINUX) to the set of operating systems

for ENABLE_LLINT. Add a specific check for PLATFORM(MAC) or
PLATFORM(IOS), and add to that a check for PLATFORM(GTK).

8:57 AM Changeset in webkit [119592] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0
​https://bugs.webkit.org/show_bug.cgi?id=87842

Patch by chandra Shekar Vallala <​chandra.vallala@motorola.com> on 2012-06-06
Reviewed by Martin Robinson.

Fix for compilation errors while building webkit2-gtk with CONTEXT_MENUS=0

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added code under CONTEXT_MENUS CC
  • UIProcess/gtk/WebContextMenuProxyGtk.h: Ditto
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Ditto
8:38 AM wxWebKit edited by kevino@theolliviers.com
(diff)
8:17 AM Changeset in webkit [119591] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[Chromium] imageSmoothingEnabled should apply to patterns
​https://bugs.webkit.org/show_bug.cgi?id=88103

Patch by Keyar Hood <​keyar@chromium.org> on 2012-06-06
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled-patterns.html

When drawing patterns on a Canvas, the imageSmoothingEnabled flag is
respected.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setupShader):

LayoutTests:

Added tests for imageSmoothingEnabled flag applying to patterns.

Modified the TestExpectations file as tests are failing due to the new
change. It makes the pictures prettier (and it agrees with other
browsers) so we have decided that the new results are to be considered
correct.

  • fast/canvas/canvas-imageSmoothingEnabled-patterns.html: Added.
  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium/TestExpectations:
7:57 AM Changeset in webkit [119590] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][DRT] http/tests/globalhistory testcases do not pass
​https://bugs.webkit.org/show_bug.cgi?id=82579

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-06-06
Reviewed by Csaba Osztrogonác.

Tools:

DRT has provided callbacks for ewk_view "global history delegate" signals.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(isGlobalHistoryTest): Aux function to ident global history testcase.
(createLayoutTestController):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
(DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
(DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
(DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
(DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

  • platform/efl/Skipped: Unskip http/tests/globalhistory.
7:12 AM Changeset in webkit [119589] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: [JSC] Add WebGL instrumentation support
​https://bugs.webkit.org/show_bug.cgi?id=87975

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-06-06
Reviewed by Vsevolod Vlasov.

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::injectAndExecuteFunction):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectWebGLScript):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorWebGLAgent.cpp:

(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InspectorWebGLAgent.h:

(InspectorWebGLAgent):

  • inspector/InspectorWebGLInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

6:09 AM Changeset in webkit [119588] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] run-qtwebkit-tests hangs with -j1
run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
This could happen due to an uncancelled timer after results were returned. This timer was
started only if --timeout was set.
​https://bugs.webkit.org/show_bug.cgi?id=85475

Patch by János Badics <János Badics> on 2012-06-06
Reviewed by Csaba Osztrogonác.

  • Scripts/run-qtwebkit-tests:

(run_test):

5:24 AM Changeset in webkit [119587] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update chromium test expectations.

  • platform/chromium/TestExpectations:

css3/filters/huge-region-composited.html = CRASH : was removed

4:41 AM Changeset in webkit [119586] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a few spelling mistakes in IconDatabase logging

Makes debugging harder if the logging is confusing.

Reviewed by Jocelyn Turcotte.

4:37 AM Changeset in webkit [119585] by vsevik@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/Source/WebCore

Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource errors.
​https://bugs.webkit.org/show_bug.cgi?id=87512

Reviewed by Yury Semikhatsky.

Removed compile-front-end.sh, compile-front-end.py should be used instead now.
Made generate_protocol_externs a python module to call it from compile-front-end.py.
Temporary copy of InjectedScriptSource.js is created and modified to
avoid "This code lacks side effects" warning.

  • inspector/compile-front-end.py:
  • inspector/compile-front-end.sh: Removed.
  • inspector/generate-protocol-externs: Removed.
  • inspector/generate_protocol_externs.py: Added.

(full_qualified_type_id):
(param_type):
(generate_protocol_externs):

4:34 AM Changeset in webkit [119584] by zherczeg@webkit.org
  • 6 edits in trunk/Source/WebCore

[Qt] REGRESSION(r118616): It made all tests crash in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=87701

Reviewed by Csaba Osztrogonác.

Replace WriteBarrier<JSObject> to Weak<JSObject> by introducing a new
QtWeakObjectReference sub class. Rewrite all affected type definitions.

All existing test in debug mode cover this issue.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(QtRuntimeObject):
(JSC::Bindings::QtInstance::removeUnusedMethods):

  • bridge/qt/qt_instance.h:

(QtInstance):
(QtWeakObjectReference):
(JSC::Bindings::QtInstance::QtWeakObjectReference::QtWeakObjectReference):
(JSC::Bindings::QtInstance::QtWeakObjectReference::operator=):
(JSC::Bindings::QtInstance::QtWeakObjectReference::get):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethodData::finalize):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::QtRuntimeMethodData::finalize):

4:27 AM Changeset in webkit [119583] by loislo@chromium.org
  • 4 edits in trunk

Web Inspector: Option for selecting/deselecting all breakpoints in breakpoint pane
​https://bugs.webkit.org/show_bug.cgi?id=87644

Patch by Sam D <​dsam2912@gmail.com> on 2012-06-06
Reviewed by Pavel Feldman.

Added an option to enable/disable all breakpoints in Breakpoint pane.

  • Source/WebCore/English.lproj/localizedStrings.js:
  • Source/WebCore/inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.enableAllBreakpoints):
(WebInspector.BreakpointManager.prototype.disableAllBreakpoints):

  • Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu.enabledBreakpointCount):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

4:21 AM Changeset in webkit [119582] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Qt DRT / WTR should be able to load external resources
​https://bugs.webkit.org/show_bug.cgi?id=87326

Reviewed by Hajime Morita.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port and to r119153 Chromium port.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::blockRequest):
(WebCore):
(WebCore::isLocalhost):
(WebCore::hostIsUsedBySomeTestsToGenerateError):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

3:41 AM Changeset in webkit [119581] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: help/settings screen does not overlay console in split screen mode
​https://bugs.webkit.org/show_bug.cgi?id=88352

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-06-06
Reviewed by Pavel Feldman.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen): Mark view as root.
(WebInspector.HelpScreen.prototype.showModal): Change view parent.

  • inspector/front-end/helpScreen.css:

(.help-window-outer): Add panel and status bar indent.
(body.compact .help-window-outer): Ditto.

3:26 AM Changeset in webkit [119580] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Form] Changes for InputNumber type
​https://bugs.webkit.org/show_bug.cgi?id=88394

Reviewed by Kent Tamura.

This patch changes codes for consitency of InputNumber usage for
reducing size of patch when we change InputNumber type alias from
double to Decimal.

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Fixed parameter type for getAllowedValueStep.

  • html/InputType.cpp:

(WebCore::InputType::minimum): Fixed return value type to InputNumber.
(WebCore::InputType::maximum): ditto.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp): Fix return value type to InputNumber.
(WebCore::MonthInputType::parseToNumber): ditto.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsDouble): Removed extra convertDoubleToInputNumber.

  • html/StepRange.cpp:

(WebCore::StepRange::alignValueForStep): Use roundByStep for code sharing.
(WebCore::StepRange::clampValue): ditto.
(WebCore::StepRange::roundByStep): Added.

  • html/StepRange.h:

(StepRange): Added a declaration of roundByStep.

3:24 AM Changeset in webkit [119579] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Fix harmattan builds broken by r119247.
​https://bugs.webkit.org/show_bug.cgi?id=88330

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-06-06
Reviewed by Jocelyn Turcotte.

Fix Harmattan build break caused by undefined constant
GL_TEXTURE_RECTANGLE_ARB by adding defined(GL_ARB_texture_rectangle)
guards around TextureMapperGL::drawTextureRectangleARB.

  • platform/graphics/texmap/TextureMapperGL.cpp: Added defined(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.

(WebCore):

  • platform/graphics/texmap/TextureMapperGL.h: Added definded(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.
3:12 AM Changeset in webkit [119578] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

[Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=88327

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-06-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::setPreferredMinimumContentsWidth):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
  • MiniBrowser/qt/icons/contents_width.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
  • MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
3:04 AM Changeset in webkit [119577] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated TestExpectations after several tests have been
regularly passing in the 3 GTK bots for some time.

  • platform/gtk/TestExpectations:
2:57 AM Changeset in webkit [119576] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Turning the bot into a springtime green
​https://bugs.webkit.org/show_bug.cgi?id=88400

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-06

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
2:39 AM Changeset in webkit [119575] by wingo@igalia.com
  • 3 edits
    3 adds in trunk

REGRESSION (r106478): None of the Paper.js JavaScript examples work
​https://bugs.webkit.org/show_bug.cgi?id=87158

Source/JavaScriptCore:

Reviewed by Michael Saboff.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve): If we have to bail out to
dynamicResolve(), only skip static scopes from the head of the
scope chain. Before, we were also skipping activations with
direct eval as well, which was incorrect.

LayoutTests:

Added regression tests for functions inside eval inside a with.

Reviewed by Michael Saboff.

  • fast/js/eval-and-with-expected.txt: Added.
  • fast/js/eval-and-with.html: Added.
  • fast/js/script-tests/eval-and-with.js: Added.
2:34 AM Changeset in webkit [119574] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Skip modified falining test. Rebase a test.
[Qt] Fix wrong skipping.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-06-06

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/Skipped:
2:03 AM Changeset in webkit [119573] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

PositionIterator:;setOffsetInLeafNode() is not used anywhere.
​https://bugs.webkit.org/show_bug.cgi?id=88397

Reviewed by Ryosuke Niwa.

It's not used anywhere. We can remove it safely.

No new tests, no change in behavior.

  • WebCore.order:
  • dom/PositionIterator.cpp:
  • dom/PositionIterator.h:
1:35 AM Changeset in webkit [119572] by caseq@chromium.org
  • 24 edits
    4 adds in trunk/Source/WebCore

Web Inspector: [WebGL] Add WebGL instrumentation support on the backend
​https://bugs.webkit.org/show_bug.cgi?id=87960

Adds a WebGLAgent, injects a WebGL script upon calling the getContext
method of a HTMLCanvasElement that will wrap the WebGL rendering context
for instrumentation purposes.

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-06-06
Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):
(WebCore::JSHTMLCanvasElement::toDataURL):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):

  • bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::forContext):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScriptManager.cpp:

(WebCore):
(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InjectedScriptManager::injectedWebGLScriptSource):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/InjectedWebGLScriptSource.js: Added.
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::markResourceAsCached):

  • inspector/InspectorWebGLAgent.cpp: Added.

(WebCore):
(WebGLAgentState):
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::~InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::setFrontend):
(WebCore::InspectorWebGLAgent::clearFrontend):
(WebCore::InspectorWebGLAgent::restore):
(WebCore::InspectorWebGLAgent::enable):
(WebCore::InspectorWebGLAgent::disable):
(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InspectorWebGLAgent.h: Added.

(WebCore):
(InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::create):
(WebCore::InspectorWebGLAgent::enabled):

  • inspector/InspectorWebGLInstrumentation.h: Added.

(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorWebGLAgent):
(WebCore::InstrumentingAgents::setInspectorWebGLAgent):

1:13 AM QtWebKitBuildBots edited by kkristof@inf.u-szeged.hu
(diff)
12:55 AM Changeset in webkit [119571] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140700 to r140711.

  • DEPS:
12:54 AM Changeset in webkit [119570] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WebPage::windowIsVisible is incorrect during resumePainting
​https://bugs.webkit.org/show_bug.cgi?id=88374
<rdar://problem/11587039>

Reviewed by Simon Fraser.

Currently, when changing window visibility, WKView calls viewStateDidChange(ViewIsVisible)
and then _updateWindowVisibility. This means that during viewStateDidChange, the WebPage's
windowIsVisible state is incorrect.

viewStateDidChange(ViewIsVisible) can end up in (one of the DrawingArea implementations)::resumePainting(),
which uses windowIsVisible to determine whether or not to unpause requestAnimationFrame.

This results in a state where, with some configurations, doing the following:

  1. requestAnimationFrame()
  2. requestFullScreen()
  3. requestAnimationFrame()
  4. cancelFullScreen()
  5. requestAnimationFrame()

Will cause the second and third rAF calls to have no effect. Even after cancelFullScreen() is called,
the fact that we have had unpaired suspend/resumeScriptedAnimations will cause the suspend count
on the ScriptedAnimationController to never return to zero, which will cause us to never
recover rAF functionality.

The fix is very simple: we should _updateWindowVisibility *before* viewStateDidChange, so that it is
always correct for any code called underneath that method.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):

12:51 AM Changeset in webkit [119569] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
​https://bugs.webkit.org/show_bug.cgi?id=88388

Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:
12:37 AM Changeset in webkit [119568] by mitz@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Reverted r119567, the fix for <​http://webkit.org/b/88378>, because it broke the 32-bit build.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • llint/LowLevelInterpreter.asm:
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):

12:29 AM Changeset in webkit [119567] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Build fix for Accelerated Compositing with OpenGL
​https://bugs.webkit.org/show_bug.cgi?id=88292

Patch by Joone Hur <​joone.hur@intel.com> on 2012-06-06
Reviewed by Martin Robinson.

Build fix after r119247.
Do not include GraphicsSurface.h when not building
with GRAPHICS_SURFACE.

No new tests. This is only a build fix.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
12:01 AM Changeset in webkit [119566] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
​https://bugs.webkit.org/show_bug.cgi?id=88065

Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::indexedDataBasePath):
(BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):

  • Api/WebSettings.h:

Jun 5, 2012:

11:53 PM Changeset in webkit [119565] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
​https://bugs.webkit.org/show_bug.cgi?id=88197

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-06-05
Reviewed by Daniel Bates.

RenderSVGRoot extends RenderReplaced and it overrides the computeIntrinsicRatioInformation()
method of RenderReplaced. RenderSVGRoot::computeIntrinsicRatioInformation
sets isPercentageIntrinsicSize to true while it handles width and height of percentage types.
So this assertion should be fired only if intrinsicRatio is non-zero.

Source/WebCore:

Test: svg/in-html/svg-assert-failure-percentage.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):

LayoutTests:

  • svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
  • svg/in-html/svg-assert-failure-percentage.html: Added.
11:45 PM Changeset in webkit [119564] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Changing flexbox justify/alignment doesn't update their positioning
​https://bugs.webkit.org/show_bug.cgi?id=88366

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/style-change.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Since these member variables were moved
out of StyleFlexibleBoxData, we have to compare them in RenderStyle::diff.

LayoutTests:

  • css3/flexbox/style-change-expected.txt: Added.
  • css3/flexbox/style-change.html: Added.
10:51 PM Changeset in webkit [119563] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

JSC implementation of SerializedScriptValue for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=88048

Reviewed by George Staikos.

No new tests. All the current indexeddb test cases apply when indexeddb works for JSC.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serializeNumber):
(CloneSerializer):
(WebCore::CloneDeserializer::toWireString):
(CloneDeserializer):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

10:41 PM Changeset in webkit [119562] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Nested CSS flexbox renders incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=87679

Reviewed by Julien Chaffraix.

Source/WebCore:

If the containing block with a perpendicular writing mode has an overrideHeight,
then its logical height should be based off that instead of its RenderStyle.

Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):

LayoutTests:

  • css3/flexbox/perpendicular-writing-modes-inside-flex-item-expected.txt: Added.
  • css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: Added.
10:37 PM Changeset in webkit [119561] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need special-case toJS(IDBAny) for IDBCursorWithValue
​https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

10:35 PM Changeset in webkit [119560] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140653 to r140700.

  • DEPS:
10:32 PM Changeset in webkit [119559] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
​https://bugs.webkit.org/show_bug.cgi?id=88247

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-06-05
Reviewed by Kenneth Rohde Christiansen.

With r116936, Component.onCompleted can be used for callback instead of the
1s timer in single and multi file upload tests.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
10:25 PM Changeset in webkit [119558] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Improve Math.round and Math.floor intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=88314

Reviewed by Filip Pizlo.

Currently we call a native function from the JIT code to complete the
"round" and "floor" operations. We could inline some fast paths
especially for those positive values on the platforms where floating
point truncation is supported.
This brings 3% gain on Kraken, especially 32% on audio-oscillator,
and slight win on SunSpider, measured on IA32.

  • jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):
(JSC):
(JSC::roundThunkGenerator):

10:19 PM Changeset in webkit [119557] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] show the feature list in alphabetical order
​https://bugs.webkit.org/show_bug.cgi?id=88343

Patch by Danilo Cesar Lemes de Paula <​danilo.cesar@collabora.co.uk> on 2012-06-05
Reviewed by Gustavo Noronha Silva.

  • configure.ac:
10:08 PM Changeset in webkit [119556] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove JSObject::m_inheritorID
​https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Geoff Garen.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • No need m_inheritorID to initialize!
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • No need m_inheritorID to initialize!
  • llint/LowLevelInterpreter.asm:
    • No need m_inheritorID to initialize!
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • Added private name 'm_inheritorIDKey'.
  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • resetInheritorID is now passed a JSGlobalData&.
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • No m_inheritorID to be marked.

(JSC::JSObject::createInheritorID):

  • Store the newly created inheritorID in the property map.
  • runtime/JSObject.h:

(JSC::JSObject::resetInheritorID):

  • Remove the inheritorID from property storage.

(JSC::JSObject::inheritorID):

  • Read the inheritorID from property storage.
10:01 PM ScalesAndZooms created by jamesr@google.com
9:58 PM Changeset in webkit [119555] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove erroneous expected image added in r119544.

  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Removed.
9:44 PM Changeset in webkit [119554] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
​https://bugs.webkit.org/show_bug.cgi?id=87996

Patch by Michal Mocny <​mmocny@google.com> on 2012-06-05
Reviewed by James Robinson.

Soon we hope to have renderers not manage there own memory allocation limits, and rely exclusively on the
allocation given by GpuMemoryManager. However, when the graphics context does not support the
GL_CHROMIUM_gpu_memory_manager extension, such as the one used by DumpRenderTree, we must default the
memory allocation limit to some non-0 value.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):
(DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::~DebugScopedSetMainThreadFromEither):

8:44 PM Changeset in webkit [119553] by haraken@chromium.org
  • 5 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r119494.
​http://trac.webkit.org/changeset/119494
​https://bugs.webkit.org/show_bug.cgi?id=87911

We found similar APIs are already implemented

  • public/WebWidget.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebViewTest.cpp:
  • tests/data/textarea.html: Removed.
8:04 PM Changeset in webkit [119552] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
​https://bugs.webkit.org/show_bug.cgi?id=78720

Patch by Roland Takacs <​takacs.roland@stud.u-szeged.hu> on 2012-06-05
Reviewed by Noam Rosenthal.

Source/WebCore:

Functions are removed from GraphicsContext3DQt that already implemented
in GraphicsContext3DCommon. Macros that not supported at GLES have been
changed to their appropriate pair that found in GraphicsContext3D
(e.g. GL_FRAMEBUFFER_EXT to GraphicsContext3D::FRAMEBUFFER).
It was needed because OpenGLES does not support these macros.
Extensions3DQt is removed beceause it has never been used.
Some functions have been moved fron GraphicsContext3DCommon to *OpenGL
and *OpenGLES to provide specialization.
The "m_depthStencilBuffer" member is added to Qt port because it uses
"m_depthStencilBuffer" like the other platforms.

  • Target.pri:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::readPixels):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):

Source/WTF:

Defined a global Opengl ES macro to check OpenGL ES on every platforms.

  • wtf/Platform.h:
7:41 PM Changeset in webkit [119551] by rniwa@webkit.org
  • 7 edits
    3 adds in trunk/LayoutTests

Chromium rebaselines after r115091.

  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium/TestExpectations:
7:13 PM Changeset in webkit [119550] by rniwa@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

More Chromium rebaselines after r119528 and r119512.

  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
6:57 PM Changeset in webkit [119549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
​https://bugs.webkit.org/show_bug.cgi?id=88342

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-06-05
Reviewed by Rob Buis.

RIM PR: 163141

Reviewed internally by Mike Fenton.

We set all options' type to TypeOption, which can't tell if an option belongs to a group,
introduce TypeOptionInGroup to fix it.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

6:51 PM Changeset in webkit [119548] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Special layout handler should be done on top frame being printed.
​https://bugs.webkit.org/show_bug.cgi?id=88201

Patch by Vitaly Buka <​vitalybuka@chromium.org> on 2012-06-05
Reviewed by Brady Eidson.

No new tests. Root case is already covered by tests.
Case described in the issue can be reproduced only by direct call
to Frame::setPrinting of subframe. Probably it's not possible with
layout tests.

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):
Use shouldUsePrintingLayout to choose proper version of forceLayout().
(WebCore::Frame::shouldUsePrintingLayout):
Checks if current frame is the top frame being printed.

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame.

6:40 PM Changeset in webkit [119547] by commit-queue@webkit.org
  • 36 edits
    5 adds in trunk

[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
​https://bugs.webkit.org/show_bug.cgi?id=87551

Patch by Max Feil <​mfeil@rim.com> on 2012-06-05
Reviewed by Antonio Gomes.

Source/WebCore:

Changes to make media controls larger in fullscreen mode. The
BlackBerry media controls used to be sized by a combination
of CSS styles specified in mediaControlsBlackBerry.css and
hard coded constants in RenderThemeBlackBerry.cpp. This patch
moves all the dimensional sizes to a common location, i.e.
RenderThemeBlackBerry.cpp. Having all the logic in C++ code allows
more complex decision making for when and how much to enlarge the
media controls. Currently the controls are enlarged by a factor
of 2 if the document is in fullscreen mode, the video element
is the current fullscreen element, and the deviceScaleFactor of
the page is less than 2.0. This avoids overly large controls
on pages which are already at least doubling the size of the
controls via viewport meta tag device-width settings. In other
words, if the CSS pixels are already enlarged compared to device
pixels by a factor of at least 2 in length and width.

In order to accomplish this, I had to add a new Element* parameter
to RenderTheme::adjustSliderThumbSize(). This is needed so
that fullscreen mode can be checked and the deviceScaleFactor
retrieved. I feel that this does not have a big impact on the
code and the other ports, for which I will simply be adding the
additional parameter in their platform code.

Tests:
video-controls-enlarged-fullscreen-meta.html
video-controls-enlarged-fullscreen-nometa.html

  • css/mediaControlsBlackBerry.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::updateAppearance):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::determineRenderSlider):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

  • platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderThumbSize):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbSize):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::adjustSliderThumbSize):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustSliderThumbSize):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustSliderThumbSize):

  • rendering/RenderThemeWinCE.h:

(RenderThemeWinCE):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):

  • rendering/RenderTheme.h:

(RenderTheme):

Source/WebKit/qt:

Add a new parameter to adjustSliderThumbSize() for BlackBerry
port. Fixing compiles of other ports.

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • WebCoreSupport/RenderThemeQStyle.h:

(RenderThemeQStyle):

LayoutTests:

  • media/media-controls.js:

(mediaControlsButtonDimensions):

  • platform/blackberry/media/video-controls-enlarged-fullscreen-meta-expected.txt: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-meta.html: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-nometa-expected.txt: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-nometa.html: Added.
6:37 PM Changeset in webkit [119546] by Stephanie Lewis
  • 6 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=88370
Memory sampler should trigger low memory signal

Reviewed by Geoff Garen.

Source/WebCore:

No new tests. Verify by running stress test which crashes
in a few minutes without the fix.

Fix assumption in block code. We could get in a state where timer_event_source
had already been released before the block ran.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::holdOff):

Source/WebKit2:

Send low memory signal when running the memory sampler. We'd
like to test memory that cannot be freed.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::sampleTimerFired):

  • Shared/WebMemorySampler.h:

(WebMemorySampler):

  • Shared/mac/WebMemorySampler.mac.mm:

(WebKit):
(WebKit::WebMemorySampler::sendMemoryPressureEvent):

6:10 PM Changeset in webkit [119545] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Stop generating image results in the tests added by r114172.

Rubber-stamped by Simon Fraser.

  • css3/filters/huge-region-composited.html:
  • css3/filters/huge-region.html:
  • platform/chromium/TestExpectations:
6:01 PM Changeset in webkit [119544] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Chromium rebaselines after r118772.

  • platform/chromium-mac-leopard/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-win/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations:
5:57 PM Changeset in webkit [119543] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.

5:48 PM Changeset in webkit [119542] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Rename a plug-in loading error constant
​https://bugs.webkit.org/show_bug.cgi?id=88381
<rdar://problem/11602601>

Reviewed by Sam Weinig.

  • Misc/WebKitErrors.h:
5:47 PM Changeset in webkit [119541] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fixing an incorrect path in lion Skipped file.

  • platform/mac-lion/Skipped:
5:39 PM Changeset in webkit [119540] by yosin@chromium.org
  • 24 edits in trunk/Source/WebCore

[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
​https://bugs.webkit.org/show_bug.cgi?id=88275

Reviewed by Kent Tamura.

This patch introduced InputNumber type as alias of double to be
replaced to Decimal and convertDoubleToInputNumber and
convertToInputNumberToDouble for reducing size of patch when we
introduce Decimal type.

This patch added new vairables to use const variable to reduce
copy operation when introducing Decimal type.

In the implementation, we use InputNumber, will be Decimal, however some methods in IDL
use double. To clarify internal usage of value and external usage, thit patch renamed
following functions:

  • parseToDouble => parseNumber
  • setValueAsNumber => setValueAsDouble and setValueAsInputNumber
  • valueAsNumber => valueAsDouble

This patch is a part of introducing Decimal, ​https://bugs.webkit.org/show_bug.cgi?id=80009

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::valueAsDate): Replaced parseToNumber() to valueAsDouble()
(WebCore::BaseDateAndTimeInputType::setValueAsDate): Inserted convertDoubleToInputNumber.
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Use new function parseToDouble().
(WebCore::BaseDateAndTimeInputType::setValueAsInputNumber): Added.
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::BaseDateAndTimeInputType::parseToNumber): This is replacement of parseToDouble().
(WebCore::BaseDateAndTimeInputType::parseToDouble): Added for valueAsDate and valueAsDouble.
(WebCore::BaseDateAndTimeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Replace double to InputNumber for getAllowdStep.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replaced double to InputNumber.

  • html/DateInputType.h:

(DateInputType):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::DateTimeInputType::createStepRange): Replaced double to InputNumber.

  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replaced double to InputNumber.

  • html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::HTMLInputElement::valueAsNumber): Use InputType::valueAsDouble.
(WebCore::HTMLInputElement::setValueAsNumber): Use InputType::valueAsDouble.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsInputNumber): Replacement of valueAsNumber.
(WebCore::InputType::rangeUnderflow): Replaced double to InputNumber.
(WebCore::InputType::rangeOverflow): Replaced double to InputNumber.
(WebCore::InputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::InputType::isInRange): Replaced double to InputNumber.
(WebCore::InputType::isOutOfRange): Replaced double to InputNumber.
(WebCore::InputType::stepMismatch): Replaced double to InputNumber.
(WebCore::InputType::validationMessage): Replaced double to InputNumber.
(WebCore::InputType::parseToNumber): Replacement of parseToDouble.
(WebCore::InputType::parseToNumberOrNaN): Added for reducing number of std::numeric_limits<double>::quiet_NaN().
(WebCore::InputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::InputType::serialize): Changed parameter type to InputNumber.
(WebCore::InputType::applyStep): Replaced double to InputNumber.
(WebCore::InputType::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::InputType::stepUpFromRenderer): Replaced double to InputNumber.

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::MonthInputType::createStepRange): Replaced double to InputNumber.
(WebCore::MonthInputType::parseToNumber): Replacement of parseToDouble.

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::valueAsDouble): Replacement of valueAsNumber. Changed to use parseToDoubleForNumberType.
(WebCore::NumberInputType::setValueAsDouble): Replacement of setValueAsNumber. Changed to use serializeForNumberType.
(WebCore::NumberInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::NumberInputType::createStepRange): Replaced double to InputNumber.
(WebCore::NumberInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::NumberInputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::NumberInputType::serialize):

  • html/NumberInputType.h:

(NumberInputType):

  • html/RangeInputType.cpp:

(WebCore::ensureMaximum): Replaced double to InputNumber.
(WebCore::RangeInputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::RangeInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::RangeInputType::createStepRange): Replaced double to InputNumber.
(WebCore::RangeInputType::handleKeydownEvent): Replaced double to InputNumber.
(WebCore::RangeInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::RangeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::RangeInputType::sanitizeValue): Replaced double to InputNumber.

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange): Replaced double to InputNumber.
(WebCore::StepRange::acceptableError): Replaced double to InputNumber.
(WebCore::StepRange::alignValueForStep): Replaced double to InputNumber.
(WebCore):
(WebCore::StepRange::clampValue): Replaced double to InputNumber.
(WebCore::StepRange::stepMismatch): Replaced double to InputNumber.

  • html/StepRange.h:

(WebCore::convertDoubleToInputNumber): Added.
(WebCore::convertInputNumberToDouble): Added.
(WebCore::StepRange::NumberWithDecimalPlaces::NumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::StepRange::StepDescription::defaultValue): Replaced double to InputNumber.
(StepRange):
(WebCore::StepRange::maximum): Replaced double to InputNumber.
(WebCore::StepRange::minimum): Replaced double to InputNumber.
(WebCore::StepRange::step): Replaced double to InputNumber.
(WebCore::StepRange::stepBase): Replaced double to InputNumber.
(WebCore::StepRange::defaultValue): Replaced double to InputNumber.
(WebCore::StepRange::proportionFromValue): Replaced double to InputNumber.
(WebCore::StepRange::valueFromProportion): Replaced double to InputNumber.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::defaultValueForStepUp): Replaced double to InputNumber.
(WebCore::TimeInputType::createStepRange): Replaced double to InputNumber.

  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Replaced double to InputNumber.

  • html/WeekInputType.h:

(WeekInputType):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument): Replaced double to InputNumber.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition): Replaced double to InputNumber.
(WebCore::RenderSliderThumb::layout): Replaced double to InputNumber.
(WebCore::SliderThumbElement::setPositionFromPoint): Replaced double to InputNumber.

5:38 PM Changeset in webkit [119539] by eae@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed gardening. Chromium windows test expectation updates.

  • platform/chromium-win/fast/sub-pixel: Added.
  • platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium/TestExpectations:
5:32 PM Changeset in webkit [119538] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140528 to r140653.

  • DEPS:
5:31 PM Changeset in webkit [119537] by leviw@chromium.org
  • 37 edits
    18 adds in trunk/LayoutTests

Unreviewed gardening. More updated Chromium test expectations following 119528.

  • platform/chromium-linux-x86/editing/selection: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
  • platform/chromium-linux-x86/fast/sub-pixel: Added.
  • platform/chromium-linux-x86/fast/sub-pixel/selection: Added.
  • platform/chromium-linux-x86/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-linux/fast/sub-pixel: Added.
  • platform/chromium-linux/fast/sub-pixel/selection: Added.
  • platform/chromium-linux/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/fast/sub-pixel/selection: Added.
  • platform/chromium-mac/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-win-vista/fast/sub-pixel: Added.
  • platform/chromium-win-vista/fast/sub-pixel/selection: Added.
  • platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/fast/sub-pixel: Added.
  • platform/chromium-win/fast/sub-pixel/selection: Added.
  • platform/chromium-win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium/TestExpectations:
5:25 PM Changeset in webkit [119536] by rniwa@webkit.org
  • 4 edits
    4 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for r119523 and r119529.

  • platform/chromium-linux/compositing/layer-creation: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
5:15 PM Changeset in webkit [119535] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11575898> and ​https://bugs.webkit.org/show_bug.cgi?id=88372
REGRESSION(110494): Can no longer drag-and-drop links into FileMaker Pro 12

  • Before r110494 we used to write the NSStringPboardType to the pasteboard. After r110494 we write NSURLPboardType instead. That's basically a no-op, but the NSStringPboardType needs to be restored.
  • Before r110494 we wrote the link destination URL to the pasteboard. After r110494 we write the image src URL if the link is an image. We need to revert to writing the link URL.

Fortunately these changes can be accomplished with a 2-line fix.

Reviewed by Enrica Casucci.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
n

5:05 PM Changeset in webkit [119534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r119527.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

4:12 PM Changeset in webkit [119533] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
​https://bugs.webkit.org/show_bug.cgi?id=87583

Patch by Martin Robinson <​mrobinson@igalia.com> on 2012-06-05
Reviewed by Alejandro G. Castro.

No new tests. This is covered by oes-standard-derivatives.html
in the Khronos WebGL conformance tests, which may one day be part
of the WebKit test suite.

Activate the GL_OES_standard_derivatives on Cairo along with
Qt and Mac.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

3:45 PM Changeset in webkit [119532] by jonlee@apple.com
  • 2 edits in trunk/Tools

Buildbot fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier

in the function. Store in a local variable.
(loadBuilderConfig):

3:28 PM Changeset in webkit [119531] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

Fixing two leopard-specific baselines following r119528.

  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
3:19 PM Changeset in webkit [119530] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/TestExpectations:
3:18 PM Changeset in webkit [119529] by Simon Fraser
  • 8 edits
    1 copy
    1 add in trunk

Avoid creating compositing layers for preserve-3d without transformed descendants
​https://bugs.webkit.org/show_bug.cgi?id=88115

Source/WebCore:

Reviewed by Antti Koivisto.

Avoid creating compositing layers, and therefore using excess backing store,
for elements that have -webkit-transform-style: preserve-3d, but no 3D-transformed
descendants that would be affected by that preserve-3d.

Test: compositing/layer-creation/no-compositing-for-preserve-3d.html

  • rendering/RenderLayer.h: Replace the "mustOverlap" flag with a enum

that describes the different reasons for indirect compositing, so that
we can use that information to decide whether to allocate backing store.
(WebCore::RenderLayer::setIndirectCompositingReason):
(WebCore::RenderLayer::indirectCompositingReason):
(WebCore::RenderLayer::mustCompositeForIndirectReasons):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Initialize m_indirectCompositingReason

  • rendering/RenderLayerCompositor.h: New out param for computeCompositingRequirements()

that is uses to indicate that a 3d-transformed descendant has been encountered.
Rename requiresCompositingWhenDescendantsAreCompositing() to requiresCompositingForIndirectReason(),
and return the reason as an out param.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Pass in the saw3DTransform
param to computeCompositingRequirements().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Return a flag
from computeCompositingRequirements() that is set to true if we've seen descendants
that have 3d transforms. This is later used to decide whether to composite for
perspective or preserve-3d.
Change the "mustOverlapCompositedLayers" code to use the new "indirect compositing"
enum flags.
After enumerating children, call requiresCompositingForIndirectReason() and
record the reason in the layer.
(WebCore::RenderLayerCompositor::needsToBeComposited): Use mustCompositeForIndirectReasons() now.
(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Consult the indirect compositing
reason rather than just looking for the overlap flag.
(WebCore::RenderLayerCompositor::reasonForCompositing): Now that we have more information
about indirect compositing reasons, the logging can be more detailed.
(WebCore::RenderLayerCompositor::requiresCompositingForTransform): This now only looks
for 3d transforms. We now treat perspective and perserve-3d as "indirect" reasons, because
whether they composite depends on descendants having non-affine transforms.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): Includes the logic
previously in requiresCompositingWhenDescendantsAreCompositing(), and now determines
whether to composite for preserve-3d and perspective, based on whether we have transformed descendants.

LayoutTests:

Reviewed by Antti Koivisto.

  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/backing/no-backing-for-perspective.html: Change the transform to be non-affine so that

we keep making layers for perspective.

  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • compositing/layer-creation/no-compositing-for-preserve-3d.html: Copied from LayoutTests/compositing/backing/no-backing-for-perspective.html.
2:56 PM Changeset in webkit [119528] by leviw@chromium.org
  • 37 edits
    6 adds in trunk

Block selection gaps painted not properly pixel snapped
​https://bugs.webkit.org/show_bug.cgi?id=88000

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes for selection painting in both inline line heights and block gaps. We were unintentionally
flooring inline and block offsets in RenderBlock, but actually need to intentionally floor the
logical left and right values in logical(Left|Right)SelectionGap to properly align our block
selection gaps. This is to properly mirror the behavior in pixelSnappedLogicalRightOffsetForLine.

We were also unintentionally upcasting LayoutUnits to floats in InlineTextBox's selection painting
routine. Now we're properly rounding.

Test: fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection): Move paint values to integers and do proper rounding.

  • rendering/RenderBlock.cpp:

(WebCore::blockDirectionOffset): Fix incorrect flooring in return value.
(WebCore::inlineDirectionOffset): Ditto.
(WebCore): Removing previous attempt to properly mirror inline box selection pixel alignment. This
implementation rounded the final x value instead of properly rounding our block offset then flooring
the offset that corresponds to the behavior in InlineTextBox. It also didn't properly pixel snap
the y offset and height.
(WebCore::RenderBlock::blockSelectionGap): Properly pixel snapping the gap rect before painting.
(WebCore::RenderBlock::logicalLeftSelectionGap): Correctly match InlineTextBox's selection pixel
alignment by flooring the logicalLeft and pixel snapping the subsequent rect. We do this in order
to maintain proper render tree pixel snapping while simultaneously mirroring the flooring in the
inline direction that occurs in InlineTextBox.cpp's alignSelectionRectToDevicePixels method.
(WebCore::RenderBlock::logicalRightSelectionGap): Ditto with the right.

LayoutTests:

One new selection test and updated snowleopard expectations for a handful that improved.

Note: a couple of the RTL results appear worse, but sadly are only returning to our old pre-sub-pixel results.

  • fast/sub-pixel/selection: Added.
  • fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
  • fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:36 PM Changeset in webkit [119527] by abarth@webkit.org
  • 10 edits
    12 deletes in trunk

Remove support for target-densitydpi in the viewport meta tag
​https://bugs.webkit.org/show_bug.cgi?id=88047

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The target-densitydpi parameter was originally implemented on Android,
but it does not appear to be widely used and introduces significant
implementation complexity because it forces us to track three scale
factors (defaultDeviceScaleFactor, deviceScaleFactor, and
pageScaleFactor) rather than just two (deviceScaleFactor and
pageScaleFactor).

There don't appear to be many web sites that use target-densitydpi
because it is not supported on iOS. There are also concerns from the
standards community about the design of the feature. It seems our best
course of action is to remove target-densitydpi and address these use
cases via other mechanisms, such as responsive images and device units
in CSS because those approaches are likely to be implemented broadly.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

  • Api/WebViewportArguments.cpp:

(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):

  • Api/WebViewportArguments.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

LayoutTests:

These tests are no longer needed because they're testing a feature we
no longer support.

  • fast/viewport/viewport-133-expected.txt: Removed.
  • fast/viewport/viewport-133.html: Removed.
  • fast/viewport/viewport-92-expected.txt: Removed.
  • fast/viewport/viewport-92.html: Removed.
  • fast/viewport/viewport-93-expected.txt: Removed.
  • fast/viewport/viewport-93.html: Removed.
  • fast/viewport/viewport-94-expected.txt: Removed.
  • fast/viewport/viewport-94.html: Removed.
  • fast/viewport/viewport-95-expected.txt: Removed.
  • fast/viewport/viewport-95.html: Removed.
  • fast/viewport/viewport-96-expected.txt: Removed.
  • fast/viewport/viewport-96.html: Removed.
2:32 PM Changeset in webkit [119526] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
​https://bugs.webkit.org/show_bug.cgi?id=88362

Reviewed by Gavin Barraclough.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

2:31 PM Changeset in webkit [119525] by kerz@chromium.org
  • 6 edits
    2 deletes in branches/chromium/1132/Source

Revert 119486 - Merge 117978 - IndexedDB: Fire error when there are problems opening a DB
​https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

TBR=​dgrogan@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10536007

TBR=​dgrogan@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10534013

2:24 PM Changeset in webkit [119524] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/TestExpectations:
2:16 PM Changeset in webkit [119523] by eae@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium mac rebaseline for float-containing-block-with-margin.

  • platform/chromium-mac-leopard/fast/sub-pixel: Added.
  • platform/chromium-mac-leopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png:
1:54 PM Changeset in webkit [119522] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add Chromium test failure expectations per Skia roll:
​http://src.chromium.org/viewvc/chrome?view=rev&revision=140580

  • platform/chromium/TestExpectations:
1:53 PM Changeset in webkit [119521] by jonlee@apple.com
  • 2 edits in trunk/Tools

Buildbot fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

1:47 PM Changeset in webkit [119520] by dpranke@chromium.org
  • 12 edits in trunk/Tools

webkitpy: clean up win-specific path handling and tests
​https://bugs.webkit.org/show_bug.cgi?id=88281

Reviewed by Adam Barth.

There was a bunch of inconsistent logic for handling path
conversions for win32 and cygwin paths due to us sometimes
looking at sys.platform and sometimes using mock hosts. This
patch cleans everything up so that we are required to pass
PlatformInfo objects to the path module and stop trying to do
different things when running on cygwin or win32 hosts (except
in the path_unittest module itself).

This may slightly reduce test coverage for the win32 code paths
but will be a lot easier to follow and maintain.

  • Scripts/webkitpy/common/system/path.py:

(abspath_to_uri):
(_convert_path):

  • Scripts/webkitpy/common/system/path_unittest.py:

(AbspathTest.platforminfo):
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
(AbspathTest.test_stop_cygpath_subprocess):

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo.is_cygwin):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.test_to_uri):
(Driver.uri_to_test):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

1:41 PM Changeset in webkit [119519] by jonlee@apple.com
  • 3 edits in trunk/Tools

Workaround buildbot bug when merging build requests.
​https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Mark Rowe.

For expediency, we still want testers to pick the latest build to test, but to ensure
that the builders are reporting the correct revision number, we should let the building bots
run as they normally would. That is, the builder picks the oldest revision, and merges
subsequent requests. Because merged requests get appended to the list of changes for a given
build, the last change in that list is also the latest change. When we used pickLatestBuild
for the builders, this was not the case (it would always report the penultimate change).

​http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override

for all Apple builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick

the latest build to run.
(loadBuilderConfig):

1:38 PM Changeset in webkit [119518] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Entry into JSC should CRASH() if the Heap is busy
​https://bugs.webkit.org/show_bug.cgi?id=88355

Reviewed by Geoffrey Garen.

Interpreter::execute() returns jsNull() right now if we try to enter it while
the Heap is busy (e.g. with a collection), which is okay, but some code paths
that call Interpreter::execute() allocate objects before checking if the Heap
is busy. Attempting to execute JS code while the Heap is busy should not be
allowed and should be enforced by a release-mode CRASH() to prevent vague,
unhelpful backtraces later on if somebody makes a mistake. Normally, recursively
executing JS code is okay, e.g. for evals, but it should not occur during a
Heap allocation or collection because the Heap is not guaranteed to be in a
consistent state (especially during collections). We are protected from
executing JS on the same Heap concurrently on two separate threads because
they must each take a JSLock first. However, we are not protected from reentrant
execution of JS on the same thread because JSLock allows reentrancy. Therefore,
we should fail early if we detect an entrance into JS code while the Heap is busy.

  • heap/Heap.cpp: Changed Heap::collect so that it sets the m_operationInProgress field

at the beginning of collection and then unsets it at the end so that it is set at all
times throughout the duration of a collection rather than sporadically during various
phases. There is no reason to unset during a collection because our collector does
not currently support running additional JS between the phases of a collection.
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute): Crash if the Heap is busy.

  • runtime/Completion.cpp: Crash if the Heap is busy. We do it here before we call

Interpreter::execute() because we do some allocation prior to calling execute() which
could cause Heap corruption if, for example, that allocation caused a collection.
(JSC::evaluate):

1:21 PM NewRunWebKitTests edited by alex.bravo@nokia.com
Removed link to HackingOnNewRunWebKitTests as it onlyhas a link back … (diff)
1:06 PM Changeset in webkit [119517] by vestbo@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebKit2

[Qt] Implement log channel initialization for WebKit2

Reviewed by Alexis Menard.

12:59 PM Changeset in webkit [119516] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
​https://bugs.webkit.org/show_bug.cgi?id=88357

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2012-06-05
Reviewed by Alexis Menard.

The contentsScale needs to get a default value in case no
value is explicitely set yet.
This fixes the blank-until-resize problem when running MiniBrowser
in --desktop mode.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):

12:52 PM Changeset in webkit [119515] by timothy_horton@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Assertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
​https://bugs.webkit.org/show_bug.cgi?id=88356

Unreviewed, remove incorrect baselines and skip test on Mac.

  • platform/mac/Skipped:
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Removed.
12:22 PM Changeset in webkit [119514] by arv@chromium.org
  • 6 edits
    1 copy
    3 adds in trunk

[V8] Improve variable resolution order on window
​https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

Source/WebCore:

Test: fast/dom/Window/window-property-shadowing-onclick.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded): Set the flag as we initialize V8.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate): Ditto.

LayoutTests:

  • fast/dom/Window/window-property-shadowing-name-expected.txt: The expectation is now reversed.
  • fast/dom/Window/window-property-shadowing-name.html: JSC fails so this test says fail. Bug 75575 tracks JSC.
  • fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing-onclick.html: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt.
  • platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
12:16 PM Changeset in webkit [119513] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Delete dead code from RenderBox::computeLogicalWidthInRegion
​https://bugs.webkit.org/show_bug.cgi?id=88353

Reviewed by Tony Chang.

No new tests obviously since this is dead code.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):

12:16 PM Changeset in webkit [119512] by eae@chromium.org
  • 3 edits
    3 adds
    1 delete in trunk/LayoutTests

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
​https://bugs.webkit.org/show_bug.cgi?id=88351

Reviewed by Levi Weintraub.

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
test to allow for platform differences as the default styling makes it
very hard to use a reftests for this.

  • fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
  • fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
  • fast/sub-pixel/float-containing-block-with-margin.html:
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium/TestExpectations:
12:01 PM Changeset in webkit [119511] by leviw@chromium.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed gardening. Fixing improper text expectation following r119503.

  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium/fast/line-grid: Added.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Added.
11:53 AM Changeset in webkit [119510] by pilgrim@chromium.org
  • 8 edits
    2 copies in trunk/Source

[Chromium] Move createLocalStorageNamespace to Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=85766

Source/Platform:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):

  • chromium/public/WebStorageArea.h: Added.

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • chromium/public/WebStorageNamespace.h: Added.

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • WebKit.gyp:
  • public/WebStorageArea.h:
  • public/WebStorageNamespace.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

11:53 AM Changeset in webkit [119509] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

Chromium rebaseline per Chromium r140536.

  • platform/chromium-linux-x86/http/tests/media: Added.
  • platform/chromium-linux-x86/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win-vista/http/tests/media: Added.
  • platform/chromium-win-vista/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
11:39 AM Changeset in webkit [119508] by commit-queue@webkit.org
  • 10 edits in trunk

New constructor for WebIntent to be used for delivery
​https://bugs.webkit.org/show_bug.cgi?id=87143

Patch by Greg Billock <​gbillock@google.com> on 2012-06-05
Reviewed by Darin Fisher.

Source/WebCore:

  • Modules/intents/Intent.cpp:

(WebCore::Intent::setExtras):
(WebCore):

  • Modules/intents/Intent.h:

(Intent):

Source/WebKit/chromium:

When delivering an intent to webkit, the caller needs to be able to
provide the action, type, and data, and also extra data and ports.

  • public/WebIntent.h:

(WebIntent):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::deliverIntent):

  • src/WebIntent.cpp:

(WebKit::WebIntent::WebIntent):
(WebKit):
(WebKit::WebIntent::reset):
(WebKit::WebIntent::messagePortChannelsRelease):

11:32 AM Changeset in webkit [119507] by ojan@chromium.org
  • 16 edits
    2 adds in trunk

Change overrideSizes to be content-box instead of border-box
​https://bugs.webkit.org/show_bug.cgi?id=88116

Reviewed by Tony Chang.

Source/WebCore:

Previously, the code used border-box everywhere except for one place
where it used content-box when setting the override size. Conversely,
it subtracted the borderAndPaddingSize everywhere it grabbed the override
size except for one.

Instead, make the override size override the content-box size.
Converging on using the border-box size would be tricky given RenderTableCell's
tricky management of intrinsic padding.

There is no behavior change except in RenderBox::availableLogicalHeightUsing,
which fixes a table test.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::setOverrideLogicalContentHeight):
(WebCore::RenderBox::setOverrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
We were incorrectly subtracting the borderAndPaddingLogicalWidth instead
of the borderAndPaddingLogicalHeight.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):

LayoutTests:

  • fast/table/padding-height-and-override-height-expected.txt:
  • fast/table/padding-height-and-override-height.html:

Tests the change in RenderBox::availableLogicalHeightUsing to correctly subtract the
borderAndPaddingLogicalHeight instead of the borderAndPaddingLogicalWidth.

  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:

The new results are more correct. The table cell had 2px too much padding-top and padding-bottom before.

11:28 AM Changeset in webkit [119506] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
​https://bugs.webkit.org/show_bug.cgi?id=88296

Reviewed by Dan Bernstein.

refresh() and initPlugins() should call into PluginStrategy even if
ENABLE(NETSCAPE_PLUGIN_API) is false. Some ports support non-Netscape
plug-ins, so PluginStrategy should be consulted even if Netscape
plug-ins specifically are disabled.

Ports that support platform strategies but not Netscape plug-ins should
handle this inside their PluginStrategy rather than modifying generic
plug-in code.

  • plugins/PluginData.cpp:

(WebCore::PluginData::refresh):
(WebCore::PluginData::initPlugins):

11:23 AM Changeset in webkit [119505] by jberlin@webkit.org
  • 2 edits in trunk/Tools

[Win] DumpRenderTree should call resetInternalsObject
​https://bugs.webkit.org/show_bug.cgi?id=88346

Reviewed by Simon Fraser.

Invoke it on Windows in the same place it is invoked on Mac.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

11:15 AM Changeset in webkit [119504] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/media/remove-while-loading.html times out on mac-lion-wk2
​https://bugs.webkit.org/show_bug.cgi?id=88348

Unreviewed skip of this test for greenness.

  • platform/mac-wk2/Skipped:
11:13 AM Changeset in webkit [119503] by leviw@chromium.org
  • 43 edits
    4 adds
    3 deletes in trunk/LayoutTests

Unreviewed gardening. Updating test expectations after r119456.

  • fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/fast/forms/001-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/line-grid: Removed.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/efl/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
  • platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
11:05 AM Changeset in webkit [119502] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when modifying fixed-position elements in a detached frame
​https://bugs.webkit.org/show_bug.cgi?id=88288

Patch by Douglas Stockwell <​dstockwell@chromium.org> on 2012-06-05
Reviewed by James Robinson.

Source/WebCore:

Test: fast/block/positioning/fixed-position-detached-frame.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • fast/block/positioning/fixed-position-detached-frame-expected.txt: Added.
  • fast/block/positioning/fixed-position-detached-frame.html: Added.
10:33 AM Changeset in webkit [119501] by leviw@chromium.org
  • 1 move in branches/old/subpixellayout

Moving the sub-pixel layout branch to branches/old since the feature has landed and development on the branch has ceased.

10:22 AM Changeset in webkit [119500] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140492 to r140528.

  • DEPS:
10:12 AM Changeset in webkit [119499] by caseq@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: render timeline paint category dark green
​https://bugs.webkit.org/show_bug.cgi?id=88333

Reviewed by Pavel Feldman.

  • Added a new, dark-green color for timeline events.
  • WebCore.gypi: Added timelineBarDarkGreen.png
  • inspector/front-end/Images/timelineBarDarkGreen.png: Added.
  • inspector/front-end/Images/timelineCheckmarks.png: Added a dark-green checkbox.
  • inspector/front-end/Images/timelineDots.png: Added a dark-green dot.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):

  • inspector/front-end/WebKit.qrc: Added timelineBarDarkGreen.png.
  • inspector/front-end/timelinePanel.css:

(.timeline-category-statusbar-item.timeline-category-painting .timeline-category-checkbox):
(.timeline-category-painting .timeline-graph-bar):
(.popover .timeline-painting):
(.timeline-category-painting .timeline-tree-icon):

10:08 AM Changeset in webkit [119498] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: serialize edge counts instead of indexes in heap snapshot
​https://bugs.webkit.org/show_bug.cgi?id=88324

The serialized node structure currently holds an index
of its first containment edge in the edges array.
The index can be quite big (up to 7 digits for large snapshots).
The patch changes the serialization format to pass
node containment edge count instead. For most nodes the count
is just a single digit number.
This reduces serialized snapshot size and therefore its transfer time.

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-06-05
Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot-performance-test.js:

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNode.prototype._ordinal):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildEdgeIndexes):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):

  • inspector/profiler/heap-snapshot.html:
10:01 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
9:30 AM Changeset in webkit [119497] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't propagate viewport size changes if the viewport is empty.
​https://bugs.webkit.org/show_bug.cgi?id=88336

Reviewed by Tor Arne Vestbø.

Qt Quick sequentially set the x, y, width, height of the view. We really want to
start propagating further when the size of the viewport becomes valid, i.e. both
height and width are defined. In any case lower level classes are discarding an empty
size such as WebPage::sendViewportAttributesChanged() so it was pointless to send the size
through the IPC bus for nothing.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

9:23 AM Changeset in webkit [119496] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Web Inspector highlight is slow
​https://bugs.webkit.org/show_bug.cgi?id=88331

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-06-05
Reviewed by Rob Buis.

Highlight is slow on large pages because of constant repaint calls.
Change to use the accelerated layer highlight all the time.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):

  • WebCoreSupport/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):

9:18 AM Changeset in webkit [119495] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Fix two more memory leaks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=88255

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-05
Reviewed by Martin Robinson.

Fixed memory leaks in GTK's DRT code.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpHistoryItem): webkit_web_history_item_get_target() returns a
g_strdup()'d string. So, use GOwnPtr to manage memory automatically.

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(createBitmapContextFromWebView): Free the cairo surface.

9:04 AM Changeset in webkit [119494] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] There is no way to retrieve composition character rectangle in WebKit/chromium
​https://bugs.webkit.org/show_bug.cgi?id=87911

Patch by Seigo Nonaka <​nona@chromium.org> on 2012-06-05
Reviewed by Ryosuke Niwa.

Add an API for retreieving each character bounds in composition text.
This API is necessary for implementing IMR_QUERYCHARPOSITION message in Windows.
The message is used by Japanese IME for showing their window at the correct position.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::compositionCharacterBounds):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositionCharacterBounds):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

8:47 AM Changeset in webkit [119493] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_download_get_received_data_length to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=88323

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_get_received_data_length):

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestDownloads.cpp:
8:37 AM Changeset in webkit [119492] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

CSS 2.1 failure: border-conflict-element-021a
​https://bugs.webkit.org/show_bug.cgi?id=86885

Patch by Arpita Bahuguna <​arpitabahuguna@gmail.com> on 2012-06-05
Reviewed by Julien Chaffraix.

Source/WebCore:

When two adjacent table row groups (thead, tbody, tfoot) have the same border-width
and the same border-style in a 'border-collapse: collapse' table the color of the border
from the top-most table row wins.

Tests: fast/table/border-collapsing/adjacent-row-groups-multi.html

fast/table/border-collapsing/adjacent-row-groups.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
Currently each row group is sent for paint from top (firstChild) to bottom thereby causing
the borders of the bottom-most row group (which is painted last) to overlap over the
previous row-group. This breaks the precedence for collapsed borders between adjacent cells.

This fix thus reverses the order in which the row-groups/sections are passed for painting.
Additional change has been done to iterate over the RenderTableSections directly.

(WebCore):
(WebCore::RenderTable::bottomSection):

  • rendering/RenderTable.h:

New function has been added to obtain the last section of the table.

(RenderTable):

  • rendering/RenderTableSection.h:

(RenderTableSection):
RenderTableSection's paint() method has now been made public so as to make it accessible
from RenderTable.

LayoutTests:

  • css2.1/20110323/border-conflict-element-021a-expected.html: Added.
  • css2.1/20110323/border-conflict-element-021a.htm: Added.

Added ref test under the css2.1 test-suite for border-conflict-element-021a.

  • fast/table/border-collapsing/adjacent-row-groups-expected.html: Added.
  • fast/table/border-collapsing/adjacent-row-groups.html: Added.

Added ref test for verifying 'border-collapse: collapse' table rendering when two
adjacent table row-groups have the same border-width and the same border-style. In
such a case the color of the border from the top-most table row-group wins.

  • fast/table/border-collapsing/adjacent-row-groups-multi.html: Added.
  • fast/table/border-collapsing/adjacent-row-groups-multi-expected.html: Added.

Additional ref test added for verifying 'border-collapse: collapse' table rendering
for adjacent table row-groups when more than one table headers and/or footers are specified.

8:32 AM Changeset in webkit [119491] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium unreviewed sheriffing: enable blob tests that are passing since r119454.

  • platform/chromium/TestExpectations:

fast/filesystem/file-writer-gc-blob.html
fast/filesystem/workers/file-writer-sync-truncate-extend.html
fast/filesystem/workers/file-writer-gc-blob.html

8:26 AM Changeset in webkit [119490] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix IDL dependency generation
​https://bugs.webkit.org/show_bug.cgi?id=88304

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri:
8:17 AM Changeset in webkit [119489] by loislo@chromium.org
  • 8 edits
    7 deletes in trunk

Unreviewed, rolling out r119467, r119471, and r119476.
​http://trac.webkit.org/changeset/119467
​http://trac.webkit.org/changeset/119471
​http://trac.webkit.org/changeset/119476
​https://bugs.webkit.org/show_bug.cgi?id=88332

it broke chromium-mac static initializers test.\ (Requested by
loislo on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-05

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/FontPlatformData.h:

(FontPlatformData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Removed.
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):

LayoutTests:

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Removed.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Removed.
  • platform/chromium/TestExpectations:
8:13 AM Changeset in webkit [119488] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Building when a top directory is named Source
​https://bugs.webkit.org/show_bug.cgi?id=77727

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-06-05
Reviewed by Tor Arne Vestbø.

Change regex to only replace the last instance of OUT_PWD.

  • qmake/mkspecs/features/default_pre.prf:
8:01 AM Changeset in webkit [119487] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: SHIFT key as helper to color adjustment in color picker
​https://bugs.webkit.org/show_bug.cgi?id=88319

Reviewed by Pavel Feldman.

With Shift depressed, the dragger in the color picker will snap to the horizontal
or vertical axis while dragging, depending on which axis offset is greater.

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.colorDragStart):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):

7:51 AM Changeset in webkit [119486] by dgrogan@chromium.org
  • 6 edits
    2 copies in branches/chromium/1132/Source

Merge 117978 - IndexedDB: Fire error when there are problems opening a DB
​https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

TBR=​dgrogan@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10536007

7:50 AM Changeset in webkit [119485] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: aggregate all events before first frame into a fake frame
​https://bugs.webkit.org/show_bug.cgi?id=88229

  • in Timeline's frame mode, start aggregating events by frame even before we get first frame marker.
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createFrame):

5:27 AM Changeset in webkit [119484] by charles.wei@torchmobile.com.cn
  • 5 edits in trunk/Source/WebCore

JSC:need to implement Dictionary::getWithUndefinedOrNullCheck for IDB
​https://bugs.webkit.org/show_bug.cgi?id=88283

Reviewed by Kentaro Hara.

No new tests, idb not working for JSC yet.

  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/Dictionary.h:

(Dictionary):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):
(WebCore):

  • bindings/js/JSDictionary.h:

(JSDictionary):

4:37 AM FeatureFlags edited by tkent@chromium.org
Add CUSTOM_SCHEME_HANDLER (diff)
4:35 AM Changeset in webkit [119483] by rwlbuis@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Hit ASSERT when editing attribute value in Element in SVG Document
​https://bugs.webkit.org/show_bug.cgi?id=88179

Reviewed by Pavel Feldman.

Test setting attribute on non HTML element.

  • inspector/elements/set-attribute-non-html-expected.txt: Added.
  • inspector/elements/set-attribute-non-html.svg: Added.
4:32 AM Changeset in webkit [119482] by commit-queue@webkit.org
  • 30 edits
    2 adds in trunk

Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
​https://bugs.webkit.org/show_bug.cgi?id=73176

Patch by Dongwoo Im <​dw.im@samsung.com> on 2012-06-05
Reviewed by Adam Barth.

Two more APIs are added in Custom Scheme Handler specification.
​http://dev.w3.org/html5/spec/Overview.html#custom-handlers
One is 'isProtocolHandlerRegistered' to query whether the specific URL
is registered or not.
The other is 'unregisterProtocolHandler' to remove the registered URL.

.:

  • Source/cmake/WebKitFeatures.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • Source/cmakeconfig.h.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebCore:

Test: fast/dom/unregister-protocol-handler.html

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • loader/EmptyClients.h: Add prototypes.

(EmptyChromeClient):
(WebCore::EmptyChromeClient::isProtocolHandlerRegistered):
(WebCore::EmptyChromeClient::unregisterProtocolHandler):

  • page/ChromeClient.h:

(ChromeClient):

  • page/NavigatorRegisterProtocolHandler.cpp:

(WebCore):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler): Unregister the registered handler.

  • page/NavigatorRegisterProtocolHandler.h:

(NavigatorRegisterProtocolHandler):

  • page/NavigatorRegisterProtocolHandler.idl:

Source/WebKit/chromium:

  • features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::ChromeClientEfl::registerProtocolHandler):
(WebCore):
(WebCore::ChromeClientEfl::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::ChromeClientEfl::unregisterProtocolHandler): Unregister the registered handler.

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • ewk/ewk_custom_handler.cpp:

(ewk_custom_handler_is_protocol_handler_registered): Query if the handler is registered.
(ewk_custom_handler_unregister_protocol_handler): Unregister the registered handler.

  • ewk/ewk_custom_handler_private.h: Adds private function.
  • ewk/ewk_view.h: Adds enumeration.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

LayoutTests:

  • fast/dom/unregister-protocol-handler-expected.txt: Added.
  • fast/dom/unregister-protocol-handler.html: Added.
4:28 AM Changeset in webkit [119481] by morrita@google.com
  • 5 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=88029
content-element-api.html and shadow-element.html depend on V8.

Reviewed by Kentaro Hara.

Replaced typeof checking with comparison.

  • fast/dom/shadow/content-element-api.html:
  • fast/dom/shadow/shadow-element.html:
4:13 AM Changeset in webkit [119480] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] WebKit2-EFL does not link with gold linker
​https://bugs.webkit.org/show_bug.cgi?id=88295

Unreviewed. Fix linking when using gold linker.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-05

  • PlatformEfl.cmake:
3:57 AM Changeset in webkit [119479] by kinuko@chromium.org
  • 4 edits in trunk

Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
​https://bugs.webkit.org/show_bug.cgi?id=85174

Reviewed by Kentaro Hara.

Source/WebCore:

This fixes a crash problem which could happen when the constructor is
given an array which contains String-type item(s).

There're still some Text mismatches between v8 results and
JSC results, most of them are v8 not throwing exception
when it is given an object whose toString() method throws
exception. (The issue will be addresse in a separate patch.)

Test: fast/files/blob-constructor.html

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

Changing blob-constructor.html label from CRASH to TEXT.

  • platform/chromium/TestExpectations:
3:39 AM Changeset in webkit [119478] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary constructor of SelectorQueryCache
​https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Ryosuke Niwa.

Per the comment from darin@ (​https://bugs.webkit.org/show_bug.cgi?id=87942#c27),
this patch removes an inline constructor that has no arguments.
To have the compiler generate the constructor,
this patch also removes WTF_MAKE_NONCOPYABLE().

No tests. No change in behavior.

  • dom/SelectorQuery.h:

(SelectorQueryCache):

3:25 AM Changeset in webkit [119477] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused methods from SelectorQuery.h
​https://bugs.webkit.org/show_bug.cgi?id=88289

Reviewed by Antti Koivisto.

This patch removes SelectorDataList::size() and
SelectorDataList::SelectorDataList().
SelectorDataList::size() is not used by anybody.
SelectorDataList::SelectorDataList() can be auto-generated
by a compiler.

No tests. No change in behavior.

  • dom/SelectorQuery.cpp:
  • dom/SelectorQuery.h:

(SelectorDataList):

2:55 AM Changeset in webkit [119476] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

  • platform/chromium/TestExpectations:
2:47 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
2:46 AM Changeset in webkit [119475] by mario@webkit.org
  • 10 edits
    3 adds in trunk

[GTK][WK2] Implement API for Geolocation permission requests in the GTK port
​https://bugs.webkit.org/show_bug.cgi?id=83879

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Added a new kind of permission request for supporting the
Geolocation API in WebKit2GTK+.

New WebKitGeolocationPermissionRequest class, implementing the
WebKitPermissionRequest interface, to enabling client applications
to allow or deny geolocation permission requests.

  • GNUmakefile.list.am: Added new files.
  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp: Added.

(_WebKitGeolocationPermissionRequestPrivate):
(webkitGeolocationPermissionRequestAllow):
(webkitGeolocationPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkit_geolocation_permission_request_init):
(webkitGeolocationPermissionRequestFinalize):
(webkit_geolocation_permission_request_class_init):
(webkitGeolocationPermissionRequestCreate):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h: Added.

(_WebKitGeolocationPermissionRequest):
(_WebKitGeolocationPermissionRequestClass):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h: Added.

Include WKGeolocationPermissionRequest.h in WebKitPrivate.h, so we
can use it from the new WebKitGeolocationPermissionRequest class.

  • UIProcess/API/gtk/WebKitPrivate.h: Added new include.

Implement geolocation permission requests in the UI client.

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(decidePolicyForGeolocationPermissionRequest): Create a new
instance of the WebKitGeolocationPermissionRequest class and call
to webkitWebViewMakePermissionRequest().
(attachUIClientToView): Provide an implementation function for
decidePolicyForGeolocationPermissionRequest.

  • UIProcess/API/gtk/WebKitWebView.h: Add new element to

WebKitPermissionRequestType enumeration for geolocation requests.

  • UIProcess/API/gtk/webkit2.h: Added header file for

WebKitGeolocationPermissionRequest

New unit tests to test allowing and denying permission requests.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewPermissionRequests): New test that loads a simple HTML
with JavaScript code requesting the current location.
(beforeAll): Added new test.

Updated documentation files.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Make minibrowser connect to the new 'permission requests' signal
to allow users handle the Geolocation permission requests.

  • MiniBrowser/gtk/BrowserWindow.c:

(geolocationRequestDialogCallback): Callback for the dialog asking
the user for allowing or not geolocation permission requests.
(webViewDecidePermissionRequest): Launch a dialog to ask the user
whether to allow or deny geolocation permission requests.
(browserWindowConstructed): Connect to 'permission-request' signal.

2:37 AM Changeset in webkit [119474] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Build fix for r119470.

  • loader/EmptyClients.cpp: Add #include "IntentRequest.h".
2:34 AM Changeset in webkit [119473] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused function: Document::formElements
​https://bugs.webkit.org/show_bug.cgi?id=88272

Reviewed by Kentaro Hara.

No new tests. No behavior change.

  • dom/Document.h:

(Document): remove formElements(). It was used for radio group
validation, but the current code doesn't use it any more.

2:33 AM Changeset in webkit [119472] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, build fix after r119469.

  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
2:28 AM Changeset in webkit [119471] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on Chromium mac

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::isAATFont):

2:08 AM Changeset in webkit [119470] by tkent@chromium.org
  • 7 edits in trunk/Source

Move some function definitions in EmptyClients.h to EmptyClients.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88285

Reviewed by Ryosuke Niwa.

Source/WebCore:

If we have definitions of functions with RefPtr<> in EmptyClients.h like

virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) { }

and a source file includes EmptyClient.h, the source file needs to
include FileChooser.h though the source file doesn't use FileChooser
class explicitly because the definition of runOpenPanel() needs to call
FileChooser::deref().
To avoid this, we had better move such functions to EmptyClients.cpp.

No new tests. No behavior changes.

  • loader/EmptyClients.cpp: Move such functions from EmptyClients.h to

here, and move EmptyPopupMenu and EmptySearchPopupMenu too because
they're used only by EmptyChromeClient.
(WebCore):
(EmptyPopupMenu):
(WebCore::EmptyPopupMenu::show):
(WebCore::EmptyPopupMenu::hide):
(WebCore::EmptyPopupMenu::updateFromElement):
(WebCore::EmptyPopupMenu::disconnectClient):
(EmptySearchPopupMenu):
(WebCore::EmptySearchPopupMenu::popupMenu):
(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):
(WebCore::EmptySearchPopupMenu::enabled):
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
(WebCore::EmptyChromeClient::createColorChooser):
(WebCore::EmptyChromeClient::runOpenPanel):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):
(WebCore::EmptyFrameLoaderClient::createDocumentLoader):
(WebCore::EmptyFrameLoaderClient::createFrame):
(WebCore::EmptyFrameLoaderClient::createPlugin):
(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
(WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
(WebCore::EmptyEditorClient::registerUndoStep):
(WebCore::EmptyEditorClient::registerRedoStep):
(WebCore::EmptyContextMenuClient::customizeMenu):

  • loader/EmptyClients.h: Move such function definitions to

EmptyClient.cpp, and append OVERRIDE.
(EmptyChromeClient):
(EmptyFrameLoaderClient):
(EmptyTextCheckerClient):
(EmptyEditorClient):
(EmptyContextMenuClient):

  • svg/graphics/SVGImage.cpp: Remove unnecessary #includes.

Source/WebKit/chromium:

  • src/WebHelperPluginImpl.cpp: Remove unnecessary #includes, and add necessary #includes.
  • src/WebPagePopupImpl.cpp: ditto.
1:56 AM Changeset in webkit [119469] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
​https://bugs.webkit.org/show_bug.cgi?id=88257

Reviewed by Pavel Feldman.

Source/WebCore:

Canonical names for properties should be used when checking if they are inherited (since only canonical names
are put into the usedProperties set).

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/elements-panel-styles.html:
1:27 AM Changeset in webkit [119468] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:15 AM Changeset in webkit [119467] by bashi@chromium.org
  • 8 edits
    8 adds in trunk

[Chromium] Implement font shaping with font-feature-settings on Mac
​https://bugs.webkit.org/show_bug.cgi?id=69826

Reviewed by Tony Chang.

Source/WebCore:

Add HarfBuzz-ng text shaper.
Chromium mac port uses it as secondary text shaper to support OpenType features.
HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
corresponding font is not an AAT font.

No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.

  • WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
  • WebCore.gypi: Added harfbuzz-ng files.
  • platform/graphics/FontPlatformData.h:

(FontPlatformData): Added m_harfbuzzFace.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore):
(WebCore::isAATFont):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.

(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.

(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.

(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.

(WebCore):
(WebCore::harfbuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::setupHarfBuzzRun):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.

(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore):
(WebCore::preferHarfBuzz): Added.
(WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

LayoutTests:

Added the expectation for sss3/font-feature-settings-rendering.html.

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations: Removed css3/font-feature-settings-rendering.html.
1:12 AM Changeset in webkit [119466] by commit-queue@webkit.org
  • 5 edits in trunk

IETC: FileList.item(-1) should return null instead of raising
​https://bugs.webkit.org/show_bug.cgi?id=77899

Patch by Li Yin <​li.yin@intel.com> on 2012-06-05
Reviewed by Kentaro Hara.

Source/WebCore:

IETC: ​http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Accroding to ​http://es5.github.com/#x9.6
When the index is negative, it should not raise exception.
Firefox and IE returns null when there is not indexth File object.

Test: fast/files/file-list-test.html

  • fileapi/FileList.idl:

LayoutTests:

IETC: ​http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Ref: ​http://es5.github.com/#x9.6
Some index values have been covered in this test, including negative index,
undefined, null, normal index(0~length-1), more than length index.

  • fast/files/file-list-test-expected.txt:
  • fast/files/file-list-test.html:
12:38 AM Changeset in webkit [119465] by abarth@webkit.org
  • 12 edits
    2 adds in trunk

EventHandler shouldn't dispatch fake mousemove events when scrolling on devices that don't have a mouse
​https://bugs.webkit.org/show_bug.cgi?id=88270

Reviewed by James Robinson.

Source/WebCore:

This patch adds a setting analogous to deviceSupportsTouch to determine
whether the device supports mouse. We then don't dispatch fake mouse
events on devices that don't have a mouse in the first place.

Test: fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setDeviceSupportsMouse):
(WebCore::Settings::deviceSupportsMouse):
(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsMouse):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeviceSupportsMouse):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

  • fast/events/touch/scroll-without-mouse-lacks-mousemove-events-expected.txt: Added.
  • fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html: Added.
Note: See TracTimeline for information about the timeline view.