Context Navigation

← Previous Period
Next Period →

Timeline

Jun 8, 2012:

11:18 PM Changeset in webkit [119894] by rniwa@webkit.org

3 edits in trunk/Tools

webkit-patch land-safely should set cq? if the patch author is not in committers.py
https://bugs.webkit.org/show_bug.cgi?id=88689

Reviewed by Dirk Pranke.

When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
in committers.py or the contributor cannot commit. If anything, the contributor can still
set cq+ on thier patches manually so I don't think this will be an issue for people who
don't list their Bugzille email on committers.py.

Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._commit_queue_flag):

Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_commit_queue_flag):
(test_commit_queue_flag.assert_commit_queue_flag):

10:44 PM Changeset in webkit [119893] by leviw@chromium.org

9 edits
2 adds in trunk

RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
https://bugs.webkit.org/show_bug.cgi?id=88554

Reviewed by Darin Adler.

Source/WebCore:

Column handling code in RenderLayer and RenderBlock was improperly clipping and translating
using floats derived from FractionalLayoutUnits without pixel snapping. RenderLayer also
improperly stored render tree offsets in ints instead of LayoutUnits. This corrects this
issue.

Test: fast/sub-pixel/column-clipping.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnContents):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):

LayoutTests:

fast/sub-pixel/column-clipping-expected.html: Added.
fast/sub-pixel/column-clipping.html: Added.
platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
platform/chromium/TestExpectations:

10:02 PM Changeset in webkit [119892] by rniwa@webkit.org

4 edits in trunk/LayoutTests

Remove FAIL test expectations from EFL, Mac, and Qt ports' test expectations.

platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

8:50 PM Changeset in webkit [119891] by commit-queue@webkit.org

7 edits
2 adds in trunk

REGRESSION(r116487?): HTMLFormElement::elementsname is empty if the form is detached from the document tree
https://bugs.webkit.org/show_bug.cgi?id=88632

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Update root node of RadioNodeList when the form element is detached from dom tree.

Test: fast/forms/radionodelist-whose-form-element-detached-from-domtree.html

dom/Node.cpp:

(WebCore::Node::resetCachedRadioNodeListRootNode):
New function to update the root node of RadioNodeLists to form element from document.

dom/Node.h: Ditto.
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removedFrom):
On detach, we update the root node of all RadioNodeLists of this form element.

html/RadioNodeList.cpp:

(WebCore::RadioNodeList::setRootElement):
Setter for updating root node.

html/RadioNodeList.h:

(RadioNodeList): Ditto.

LayoutTests:

fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt: Added.
fast/forms/radionodelist-whose-form-element-detached-from-domtree.html: Added.

8:04 PM Changeset in webkit [119890] by dpranke@chromium.org

2 edits in trunk/Tools

remove obsolete NewRunWebKitTests buildbot master factory classes
https://bugs.webkit.org/show_bug.cgi?id=88693

Reviewed by Ryosuke Niwa.

I believe these aren't used any more ...

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.getText2):
(BuildAndTestLeaksFactory):

7:51 PM Changeset in webkit [119889] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Remove all uses of FAIL test expectation from Chromium test expectations.

platform/chromium/TestExpectations:
platform/gtk/TestExpectations:

7:45 PM Changeset in webkit [119888] by wangxianzhu@chromium.org

3 edits in trunk/Tools

[Chromium-Android] Build DumpRenderTree with Android SDK
https://bugs.webkit.org/show_bug.cgi?id=88598

Change WebKit side of DRT related code according to some recent changes at chromium side.

Reviewed by Adam Barth.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort._path_to_driver):

7:29 PM Changeset in webkit [119887] by commit-queue@webkit.org

21 edits in trunk/Source

[Chromium] Compositor doesn't support translucent root layers.
https://bugs.webkit.org/show_bug.cgi?id=87821

Patch by David Reveman <reveman@chromium.org> on 2012-06-08
Reviewed by James Robinson.

Source/Platform:

chromium/public/WebLayer.h:

(WebLayer):

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Forward the isTransparent WebView setting to WebLayerTreeView,
CCLayerTreeHost and CCLayerTreeHostImpl as hasTransparentBackground.
Use hasTransparentBackground setting to determine how to clear the
root render pass and draw the background. Set opaque flag correctly
on the NonCompositedContentHost's graphics layer to make sure
sub-pixel rendering is not used with a transparent WebView.

Unit tests: CCLayerTreeHostImplTest.hasTransparentBackground

LayerRendererChromiumTest2.opaqueRenderPass
LayerRendererChromiumTest2.transparentRenderPass

platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderPass):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawBackgroundFilters):

platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setHasTransparentBackground):
(CCLayerTreeHost):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::hasTransparentBackground):
(WebCore::CCLayerTreeHostImpl::setHasTransparentBackground):
(CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::CCRenderPass):

platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::hasTransparentBackground):
(WebCore::CCRenderPass::setHasTransparentBackground):
(CCRenderPass):

Source/WebKit/chromium:

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setOpaque):
(WebKit):

src/NonCompositedContentHost.h:

(NonCompositedContentHost):

src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setHasTransparentBackground):
(WebKit):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

tests/CCLayerTreeHostImplTest.cpp:
tests/LayerRendererChromiumTest.cpp:

(ClearCountingContext):
(ClearCountingContext::ClearCountingContext):
(ClearCountingContext::clear):
(ClearCountingContext::clearCount):
(TEST):

7:26 PM Changeset in webkit [119886] by commit-queue@webkit.org

6 edits
3 adds in trunk/Source

[chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
https://bugs.webkit.org/show_bug.cgi?id=88668

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer.runSingleThreaded

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

WebKit.gypi:
tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread):
(WTF):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::didAddAnimation):
(CCLayerTreeHostTestLayerAddedWithAnimation):

tests/CCSingleThreadProxyTest.cpp: Added.

(FakeWebGraphicsContext3DMakeCurrentFails):
(FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(TEST_F):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::beginTest):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::animateLayers):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didRecreateContext):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didAddAnimation):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::afterTest):

tests/CCThreadedTest.cpp: Added.

(WebKitTests):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WebKitTests::TestHooks::createContext):
(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::beginCommit):
(WebKitTests::MockLayerTreeHostImpl::commitComplete):
(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):
(WebKitTests::MockLayerTreeHostImpl::drawLayers):
(WebKitTests::MockLayerTreeHostImpl::animateLayers):
(WebKitTests::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHostClient):
(WebKitTests::MockLayerTreeHostClient::create):
(WebKitTests::MockLayerTreeHostClient::MockLayerTreeHostClient):
(TimeoutTask):
(WebKitTests::TimeoutTask::TimeoutTask):
(WebKitTests::TimeoutTask::clearTest):
(WebKitTests::TimeoutTask::~TimeoutTask):
(WebKitTests::TimeoutTask::run):
(BeginTask):
(WebKitTests::BeginTask::BeginTask):
(WebKitTests::BeginTask::~BeginTask):
(WebKitTests::BeginTask::run):
(EndTestTask):
(WebKitTests::EndTestTask::EndTestTask):
(WebKitTests::EndTestTask::~EndTestTask):
(WebKitTests::EndTestTask::clearTest):
(WebKitTests::EndTestTask::run):
(WebKitTests::CCThreadedTest::CCThreadedTest):
(WebKitTests::CCThreadedTest::endTest):
(WebKitTests::CCThreadedTest::endTestAfterDelay):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateToMainThread):
(WebKitTests::CCThreadedTest::postAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::postAddInstantAnimationToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsCommitToMainThread):
(WebKitTests::CCThreadedTest::postAcquireLayerTextures):
(WebKitTests::CCThreadedTest::postSetNeedsRedrawToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateAndCommitToMainThread):
(WebKitTests::CCThreadedTest::postSetVisibleToMainThread):
(WebKitTests::CCThreadedTest::postDidAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::doBeginTest):
(WebKitTests::CCThreadedTest::timeout):
(WebKitTests::CCThreadedTest::scheduleComposite):
(WebKitTests::CCThreadedTest::onEndTest):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimate):
(WebKitTests::CCThreadedTest::dispatchAddInstantAnimation):
(WebKitTests::CCThreadedTest::dispatchAddAnimation):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimateAndCommit):
(WebKitTests::CCThreadedTest::dispatchSetNeedsCommit):
(WebKitTests::CCThreadedTest::dispatchAcquireLayerTextures):
(WebKitTests::CCThreadedTest::dispatchSetNeedsRedraw):
(WebKitTests::CCThreadedTest::dispatchSetVisible):
(WebKitTests::CCThreadedTest::dispatchSetInvisible):
(WebKitTests::CCThreadedTest::dispatchComposite):
(WebKitTests::CCThreadedTest::dispatchDidAddAnimation):
(WebKitTests::CCThreadedTest::runTest):

tests/CCThreadedTest.h: Added.

(WebCore):
(WebKit):
(WebKitTests):
(TestHooks):
(WebKitTests::TestHooks::beginCommitOnCCThread):
(WebKitTests::TestHooks::commitCompleteOnCCThread):
(WebKitTests::TestHooks::prepareToDrawOnCCThread):
(WebKitTests::TestHooks::drawLayersOnCCThread):
(WebKitTests::TestHooks::animateLayers):
(WebKitTests::TestHooks::willAnimateLayers):
(WebKitTests::TestHooks::applyScrollAndScale):
(WebKitTests::TestHooks::updateAnimations):
(WebKitTests::TestHooks::layout):
(WebKitTests::TestHooks::didRecreateContext):
(WebKitTests::TestHooks::didAddAnimation):
(WebKitTests::TestHooks::didCommit):
(WebKitTests::TestHooks::didCommitAndDrawFrame):
(WebKitTests::TestHooks::scheduleComposite):
(WebKitTests::TestHooks::notifyAnimationStarted):
(WebKitTests::TestHooks::notifyAnimationFinished):
(CCThreadedTest):
(WebKitTests::CCThreadedTest::clearTimeout):
(WebKitTests::CCThreadedTest::clearEndTestTask):
(WebKitTests::CCThreadedTest::layerTreeHost):
(CCThreadedTestThreadOnly):
(WebKitTests::CCThreadedTestThreadOnly::runTestThreaded):
(MockLayerTreeHostImpl):
(CompositorFakeWebGraphicsContext3DWithTextureTracking):

7:00 PM Changeset in webkit [119885] by ojan@chromium.org

1 edit
8 adds in trunk/LayoutTests

Last set of chromium rebaselines missed in r119875.

platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
platform/chromium-linux/svg/custom/js-update-container-expected.png: Added.
platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Added.
platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Added.
platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Added.
platform/chromium-linux/svg/custom/js-update-transform-changes-expected.png: Added.
platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Added.
platform/chromium-linux/svg/custom/non-scaling-stroke-markers-expected.png: Added.

6:56 PM Changeset in webkit [119884] by commit-queue@webkit.org

7 edits
4 adds in trunk

Caret is not rendered in empty inline contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=85793

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Override localCaretRect in RenderInline. The implementation was almost
identical to localCaretRect in RenderBlock for empty block elements, so
I refactored RenderBlock::localCaretRect and moved the logic to a new
method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
implementation of 'localCaretRect' in RenderBlock and RenderInline both
use this helper method in RenderBoxModelObject.

Tests: editing/selection/caret-in-empty-inline-1.html

editing/selection/caret-in-empty-inline-2.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):
Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
(WebCore):

rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Add localCaretRectForEmptyElement helper method.

rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect):
(WebCore):

rendering/RenderInline.h:

(RenderInline):
Override localCaretRect using localCaretRectForEmptyElement.

LayoutTests:

Add test cases for caret in empty inline.

editing/selection/caret-in-empty-inline-1-expected.txt: Added.
editing/selection/caret-in-empty-inline-1.html: Added.
editing/selection/caret-in-empty-inline-2-expected.txt: Added.
editing/selection/caret-in-empty-inline-2.html: Added.

6:51 PM Changeset in webkit [119883] by commit-queue@webkit.org

5 edits
4 adds in trunk

Source/WebCore: Treat blob: and filesystem: URLs generated via secure origins as secure.
https://bugs.webkit.org/show_bug.cgi?id=84054

Loading a blob: or filesystem: URL into an iframe or image that's
contained on an HTTPS page shouldn't generate a mixed content warning.
This change adds a SecurityOrigin::isSecure to check both against a
URLs protocol, and the protocol of it's so-called "inner URL" if it's
the type of URL that has such a thing. These sorts of URLs which are
generated from secure sources will themselves be treated as secure.

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

Tests: http/tests/security/mixedContent/blob-url-in-iframe.html

http/tests/security/mixedContent/filesystem-url-in-iframe.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::isMixedContent):

page/SecurityOrigin.cpp:

(WebCore):
(WebCore::SecurityOrigin::isSecure):

page/SecurityOrigin.h:

(SecurityOrigin):

LayoutTests: Excluding blob: and filesystem: schemes from the mixed content check.
https://bugs.webkit.org/show_bug.cgi?id=84054

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

http/tests/security/mixedContent/blob-url-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/blob-url-in-iframe.html: Added.
http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Added.
http/tests/security/mixedContent/filesystem-url-in-iframe.html: Added.

5:56 PM Changeset in webkit [119882] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Cairo] [TextureMapperGL] Nvidia card does not update WebGL texture when interacting with canvas
https://bugs.webkit.org/show_bug.cgi?id=87797

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-08
Reviewed by Philippe Normand.

No new tests. WebGL is already covered by WebGL tests and this
bug is only present on certain hardware.

After resolving multisampling before drawing the texture via the
TextureMapper, first rebind the multisampling framebuffer. This ensures
that the texture isn't active in two framebuffers at a time.

platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Rebind the multisampling
framebuffer.

5:46 PM Changeset in webkit [119881] by bfulgham@webkit.org

2 edits in trunk/Source/WebKit2

[WinCairo] Build fix after Windows export definition file change.

win/WebKit2CFLite.def: This file needs to be kept in sync with

WebKit2.def (aside from the WebKitInterface exports.)

5:12 PM Changeset in webkit [119880] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix crash on PagePopupChromeClient
https://bugs.webkit.org/show_bug.cgi?id=88675

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.

PR 163672.

Actually it's the bug inside InputHandler, should delete the old popup and create a new one,
because update() is problematic. Also no need to save pointer in InputHandler.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore::ChromeClientBlackBerry::closePagePopup):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):
(BlackBerry::WebKit::InputHandler::openSelectPopup):

WebKitSupport/InputHandler.h:

(WebCore):
(InputHandler):

5:07 PM Changeset in webkit [119879] by efidler@rim.com

3 edits
2 adds in trunk

[BlackBerry] Default font settings are getting deleted
https://bugs.webkit.org/show_bug.cgi?id=88670

Reviewed by Rob Buis.

Source/WebKit/blackberry:

RIM PR: 163720

WebSettings is overriding the default font settings with "", which deletes them.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

LayoutTests:

This test crashes if -webkit-body (i.e. WebCore::Settings::standardFontFamily())
is not a valid font family.

fonts/valid-standard-font.html: Added.

4:57 PM Changeset in webkit [119878] by ggaren@apple.com

6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in part1 of r118646.

This patch includes everything necessary for lazy finalization, but
keeps eager finalization enabled for the time being.

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

heap/MarkedBlock.cpp:
heap/MarkedBlock.h:

(JSC::MarkedBlock::resetAllocator):

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):

heap/MarkedSpace.h:

(JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
It will happen automatically when a weak set is swept. It's simpler to
have only one canonical way for this to happen, and it wasn't buying
us anything to do it eagerly.

heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
the sweep would be a no-op. If even one finalizer is pending, we need to
run it, since we won't get another chance.

heap/WeakSet.cpp:

(JSC::WeakSet::sweep): This loop can be simpler now that
WeakBlock::sweep() does what we mean.
Reset our allocator after a sweep because this is the optimal time to
start trying to recycle old weak pointers.
(JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
allocator because we've swept already, and forcing a new sweep would be
wasteful.

heap/WeakSet.h:

(JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
because the shrink may have removed the block the allocator was going to
allocate out of.

4:54 PM Changeset in webkit [119877] by ap@apple.com

2 edits in trunk/Source/WebCore

<rdar://problem/11412294> Add appropriate iOS default font settings

Reviewed by Dan Bernstein.

page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):

4:41 PM Changeset in webkit [119876] by charles.wei@torchmobile.com.cn

3 edits in trunk/Source/WebCore

IndexedDB: Transactions without any request scheduled should abort itself.
https://bugs.webkit.org/show_bug.cgi?id=88052

Reviewed by Kentaro Hara.

This is needed for indexedDB to make it work for JSC. We need to clean up all the
pending transactions(transactions without any request scheduled) when leaving Javascript context.

Manually tested using the existing test LayoutTests/storage/indexeddb/tutorial.html

bindings/js/JSMainThreadExecState.cpp:

(WebCore):
(WebCore::JSMainThreadExecState::didLeaveScriptContext):

bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):

4:18 PM Changeset in webkit [119875] by ojan@chromium.org

34 edits
9 copies
8 adds
1 delete in trunk/LayoutTests

Final set of chromium rebaselines for skia change. See crbug.com/131829.

platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
platform/chromium-linux/svg/css/arrow-with-shadow-expected.png: Added.
platform/chromium-linux/svg/css/background-image-svg-expected.png: Added.
platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Added.
platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Added.
platform/chromium-linux/svg/custom/svgpolyparser-extra-space-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Added.
platform/chromium-linux/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
platform/chromium-linux/svg/text/text-hkern-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
platform/chromium-linux/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
platform/chromium-win-xp/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Removed.
platform/chromium-win/svg/custom/js-late-marker-creation-expected.png:
platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
platform/chromium-win/svg/custom/js-update-bounce-expected.png:
platform/chromium-win/svg/custom/js-update-container-expected.png:
platform/chromium-win/svg/custom/js-update-path-changes-expected.png:
platform/chromium-win/svg/custom/js-update-path-removal-expected.png:
platform/chromium-win/svg/custom/js-update-polygon-changes-expected.png:
platform/chromium-win/svg/custom/js-update-polygon-removal-expected.png:
platform/chromium-win/svg/custom/js-update-transform-addition-expected.png:
platform/chromium-win/svg/custom/js-update-transform-changes-expected.png:
platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
platform/chromium-win/svg/custom/marker-changes-expected.png:
platform/chromium-win/svg/custom/marker-child-changes-css-expected.png:
platform/chromium-win/svg/custom/marker-child-changes-expected.png:
platform/chromium-win/svg/custom/marker-opacity-expected.png:
platform/chromium-win/svg/custom/marker-referencePoint-expected.png:
platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png:
platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
platform/chromium-win/svg/custom/mask-colorspace-expected.png:
platform/chromium-win/svg/custom/mask-on-multiple-objects-expected.png:
platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png:
platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png:
platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png:
platform/chromium-win/svg/filters/invalidate-on-child-layout-expected.png:
platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
platform/chromium/TestExpectations:

4:13 PM Changeset in webkit [119874] by Martin Robinson

2 edits in trunk

Fix the GTK+ build when OpenGL is enabled.

configure.ac: Fix the build.

4:13 PM Changeset in webkit [119873] by ojan@chromium.org

2 edits in trunk/LayoutTests

viewspec-parser tests still timeout in Chromium debug even when marked slow.

platform/chromium/TestExpectations:

4:09 PM Changeset in webkit [119872] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Crash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem
https://bugs.webkit.org/show_bug.cgi?id=88361

Reviewed by Levi Weintraub.

Use RefPtr instead of raw pointers across DOM mutations.

No tests are added for the lack of a reliable reduction.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

4:00 PM Changeset in webkit [119871] by commit-queue@webkit.org

6 edits
4 deletes in trunk

Unreviewed, rolling out r119514.
http://trac.webkit.org/changeset/119514
https://bugs.webkit.org/show_bug.cgi?id=88664

Broke JSFiddle.net (Requested by arv on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

Source/WebCore:

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

LayoutTests:

fast/dom/Window/window-property-shadowing-name-expected.txt:
fast/dom/Window/window-property-shadowing-name.html:
fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
fast/dom/Window/window-property-shadowing-onclick.html: Removed.
platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Removed.
platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.

3:35 PM Changeset in webkit [119870] by rniwa@webkit.org

6 edits in trunk/Source/WebCore

Crash in WebCore::InsertParagraphSeparatorCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=88108

Reviewed by Levi Weintraub.

Use NodeVector instead of walking through siblings as we mutate the DOM.

No new tests are added since there is no reliable reduction.

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveRemainingSiblingsToNewParent):
(WebCore):

editing/CompositeEditCommand.h:

(CompositeEditCommand):

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

3:24 PM Changeset in webkit [119869] by Martin Robinson

2 edits in trunk

[GTK] build accelerated compositing on by default if OpenGL is present
https://bugs.webkit.org/show_bug.cgi?id=88677

Reviewed by Alejandro G. Castro.

Build accelerated compositing by default if OpenGL is present, just like WebGL.
Also prevent enabling WebGL if Clutter is turned on.

configure.ac: Build AC by default.

2:59 PM Changeset in webkit [119868] by dgrogan@chromium.org

12 edits in trunk/Source

IndexedDB: rename some instances of open to registerFrontendCallbacks
https://bugs.webkit.org/show_bug.cgi?id=88611

Source/WebCore:

We should still make the change in the WebKit API.

Reviewed by Tony Chang.

No new tests, just a method rename.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::registerFrontendCallbacks):

Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):

Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

Source/WebKit/chromium:

Reviewed by Tony Chang.

src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):

src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::open):

src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

2:37 PM Changeset in webkit [119867] by danakj@chromium.org

5 edits in trunk/Source

[chromium] Skip willDraw() and didDraw() on fully occluded layers
https://bugs.webkit.org/show_bug.cgi?id=88435

Reviewed by Adrienne Walker.

Source/WebCore:

Current willDraw() is called on all layers with non-empty
visibleLayerRect and non-empty scissorRect. This excludes
layers outside the viewport, but does not exclude occluded
layers. We add a check for occlusion to calculateRenderPasses
in order to avoid willDraw() when it will be culled anyway.

We prevent didDraw() from being called for occluded layers, for
which we did not call didDraw() by holding a vector of layers
for which we did call willDraw(). This lets us avoid storing a
flag on the layers, or computing occlusion again in
didDrawAllLayers.

Unit test: CCLayerTreeHostImplTest.willDrawNotCalledOnOccludedLayer

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

2:37 PM Changeset in webkit [119866] by ojan@chromium.org

462 edits
4 copies
9 moves
10 adds
221 deletes in trunk/LayoutTests

Second wave of Chromium rebaselines after skia change. See crbug.com/131829.

List of changed expectations deleted because it's too long.

2:30 PM Changeset in webkit [119865] by barraclough@apple.com

8 edits in trunk/Source/JavaScriptCore

Unreviewed roll out r119795.

This broke jquery/core.html

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

llint/LowLevelInterpreter.asm:
runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):

runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):

2:13 PM Changeset in webkit [119864] by mitz@apple.com

1 edit
2 adds
2 deletes in trunk/LayoutTests

Added Mac pixel results for canvas-imageSmoothingEnabled-patterns.html, and made the text
results shared between platforms.

fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
platform/mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.

2:12 PM Changeset in webkit [119863] by tony@chromium.org

3 edits in trunk/LayoutTests

[chromium] Unreviewed, rebaseline a chromium-win result that changed
due to the various mock scrollbar changes.
https://bugs.webkit.org/show_bug.cgi?id=88490

platform/chromium-win/fast/repaint/fixed-tranformed-expected.png:
platform/chromium/TestExpectations:

1:37 PM Changeset in webkit [119862] by tonikitoo@webkit.org

2 edits in trunk/Source/WebCore

EventHandler shouldn't schedule the fake mousemove event timer when scrolling on devices that don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88379

Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>

Paraphrasing Andy Estes:
"In <http://trac.webkit.org/changeset/119465> we stopped dispatching fake
mousemove events when scrolling on devices that don't support mice. This event
is dispatched on a timer, so one better would be to not even schedule the
timer (rather than scheduling the timer but making it a no-op).

No new tests, as no functionality has changed. We basically do not
start a timer under a given circumstance instead of fire it, it times out,
and we make the callback no-op when under the given circumstance.

It is still possible though that we have the following scenario:

Setting::deviceSupportsMouse set as true;
we fire the timer;
before its callback gets executed (timed out) the setting gets toggled.

So for sakeness, lets keep the check in both places.

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

1:31 PM Changeset in webkit [119861] by jamesr@google.com

4 edits in trunk/Source

[chromium] Clean up some unnecessary LayerChromium.h includes
https://bugs.webkit.org/show_bug.cgi?id=88599

Reviewed by Adam Barth.

Source/WebCore:

Reworks test code slightly to use WebCore interfaces.

testing/Internals.cpp:

(WebCore::Internals::setBackgroundBlurOnNode):

Source/WebKit/chromium:

Removes unused include, update comment.

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):

1:13 PM Changeset in webkit [119860] by schenney@chromium.org

1184 edits
93 adds
229 deletes in trunk/LayoutTests

WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321

Unreviewed Chromium test expectations update after changes to SVG filter color conversion.

Full list of changed files excluded to to very large number.

platform/chromium/TestExpectations:

1:04 PM Changeset in webkit [119859] by fpizlo@apple.com

1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix JavaScriptCore/ChangeLog goof, where Geoff's change did not have a date + name + email header

1:02 PM Changeset in webkit [119858] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PredictedType should be called SpeculatedType
https://bugs.webkit.org/show_bug.cgi?id=88477

Unreviewed, fix a renaming goof from http://trac.webkit.org/changeset/119660.
I accidentally renamed ByteCodeParser::getPrediction to
ByteCodeParser::getSpeculation. That was not the intent. This changes it
back.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

12:57 PM Changeset in webkit [119857] by wingo@igalia.com

13 edits in trunk/Source

Explictly mark stubs called by JIT as being internal
https://bugs.webkit.org/show_bug.cgi?id=88552

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

dfg/DFGOSRExitCompiler.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
jit/HostCallReturnValue.h:
jit/JITStubs.cpp:
jit/JITStubs.h:
jit/ThunkGenerators.cpp:
llint/LLIntSlowPaths.h: Mark a bunch of stubs as being

WTF_INTERNAL. Change most calls to SYMBOL_STRING_RELOCATION to
LOCAL_REFERENCE, or GLOBAL_REFERENCE in the case of the wrappers
to truly global symbols.

offlineasm/asm.rb: Generate LOCAL_REFERENCE instead of

SYMBOL_STRING_RELOCATION.

Don't rely on weak pointers for eager CodeBlock finalization
https://bugs.webkit.org/show_bug.cgi?id=88465

Reviewed by Gavin Barraclough.

This is incompatible with lazy weak pointer finalization.

I considered just making CodeBlock finalization lazy-friendly, but it
turns out that the heap is already way up in CodeBlock's business when
it comes to finalization, so I decided to finish the job and move full
responsibility for CodeBlock finalization into the heap.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Maybe this

will build.

debugger/Debugger.cpp: Updated for rename.

heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
where we would not delete code for a code block that had been previously
jettisoned. I don't know if this happens in practice -- I mostly did
this to improve consistency with deleteUnmarkedCompiledCode.

(JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
eager finalization of unmarked code blocks.

(JSC::Heap::collect): Updated for rename. Updated to call
deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
blocks too.

(JSC::Heap::addCompiledCode): Renamed, since this points to all code
now, not just functions.

heap/Heap.h:

(Heap): Keep track of all user code, not just functions. This is a
negligible additional overhead, since most code is function code.

runtime/Executable.cpp:

(JSC::*::finalize): Removed these functions, since we don't rely on
weak pointer finalization anymore.

(JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::clearCode): All we need to do is delete our
CodeBlock -- that will delete all of its internal data structures.

(JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
function to improve clarity.

runtime/Executable.h:

(JSC::ExecutableBase): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::NativeExecutable::create):
(NativeExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
(JSC::EvalExecutable::create):
(EvalExecutable):
(JSC::ProgramExecutable::create):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
will call us back to destroy our code block.

(JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
for clarity.

(JSC::FunctionExecutable::isCompiling): New helper function, for clarity.

(JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
the heap needs to make polymorphic calls to clear code.

runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
renames.

Source/WTF:

wtf/ExportMacros.h (WTF_INTERNAL, HAVE_INTERNAL_VISIBILITY): New

defines. Regardless of what the port does about visibility in
general, for code referenced only from assembly it is useful to
give it internal visibility.

wtf/InlineASM.h: Split SYMBOL_STRING_RELOCATION into

LOCAL_REFERENCE and GLOBAL_REFERENCE; the former will try to avoid
indirection if HAVE(INTERNAL_VISIBILITY).

12:49 PM Changeset in webkit [119856] by jsbell@chromium.org

6 edits in trunk/LayoutTests

IndexedDB: Add regression test to verify that legacy constants have been removed
https://bugs.webkit.org/show_bug.cgi?id=88669

Reviewed by Tony Chang.

storage/indexeddb/legacy-constants-expected.txt:
storage/indexeddb/mozilla/create-index-unique-expected.txt:
storage/indexeddb/mozilla/resources/create-index-unique.js:

(createAndVerifyIndex):

storage/indexeddb/resources/constants.js:

(test):

storage/indexeddb/resources/legacy-constants.js:

(testObsoleteConstants):

12:25 PM Changeset in webkit [119855] by ojan@chromium.org

1 edit in trunk/LayoutTests/ChangeLog

First wave of Chromium rebaselines after skia rollback. See crbug.com/131829.

List of changed expected files excluded because it's too long.

12:19 PM Changeset in webkit [119854] by ojan@chromium.org

535 edits
21 copies
16 moves
218 adds
15 deletes in trunk/LayoutTests

First wave of Chromium rebaselines after skia rollback. See crbug.com/131289.

List of changed expected files excluded because it's too long.

12:05 PM Changeset in webkit [119853] by arv@chromium.org

8 edits
1 copy in trunk

[V8] Keep TextTrackList alive as long as its owner is alive
https://bugs.webkit.org/show_bug.cgi?id=88541

Reviewed by Adam Barth.

Add a hidden reference from the owner to the text track list.

Source/WebCore:

Covered by existing tests.

Target.pri: Add V8TextTrackListCustom.cpp.
UseV8.cmake: Ditto.
WebCore.gypi: Ditto.
bindings/v8/V8HiddenPropertyName.h:

(WebCore):

bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(WebCore):
(WebCore::toV8): When the wrapper is created add a reference to the owner of the TextTrackList to the TextTrackList.

html/track/TextTrackList.idl:

LayoutTests:

platform/chromium/TestExpectations:

11:53 AM Changeset in webkit [119852] by jochen@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

11:44 AM Changeset in webkit [119851] by commit-queue@webkit.org

2 edits in trunk/Tools

Add app_abi option for DumpRenderTree_apk
https://bugs.webkit.org/show_bug.cgi?id=88626

Patch by Wei James <james.wei@intel.com> on 2012-06-08
Reviewed by Adam Barth.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

11:41 AM Changeset in webkit [119850] by commit-queue@webkit.org

20 edits
2 adds in trunk/Source

[chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.

CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.

Source/WebCore:

Unit tests:

GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation

WebCore.gypi:
platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.

(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):

platform/graphics/chromium/AnimationTranslationUtil.h: Added.

(WebCore):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::bounds):
(LayerChromium):

platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::bounds):

Source/WebKit/chromium:

tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

tests/CCAnimationTestCommon.h:
tests/CCKeyframedAnimationCurveTest.cpp:
tests/CCLayerAnimationControllerTest.cpp:
tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

tests/GraphicsLayerChromiumTest.cpp:

(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):

tests/LayerChromiumTest.cpp:

11:39 AM Changeset in webkit [119849] by noam.rosenthal@nokia.com

6 edits in trunk/Source/WebCore

[Texmap] Accelerated versions of drop-shadow and blur filters
https://bugs.webkit.org/show_bug.cgi?id=87695

Reviewed by Kenneth Rohde Christiansen.

Added shaders for blur and drop-shadow effects.
The shaders use sampling of multiple coordinates and averaging them with normal-
distribution to create a fast gaussian blur effect.

Covered by existing tests in css3/filters.

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawFiltered):

Call the prepare function explicitly, with a size argument that's used to calculate
some of the uniform values.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::intermediateSurfaceRect):

The outsets of the effect have to be considered when calculating the intermediate rect.
Otherwise the resulting image is scaled instead of outsetted.

(WebCore::applyFilters):

platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::StandardFilterProgram::StandardFilterProgram):

Added the new shaders.

(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

platform/graphics/texmap/TextureMapperShaderManager.h:

(StandardFilterProgram):

11:36 AM Changeset in webkit [119848] by mitz@apple.com

2 edits in trunk/Source/WebCore

Tried to fix the build after r119844.

bindings/js/GCController.cpp:

(WebCore::GCController::discardAllCompiledCode):

11:34 AM Changeset in webkit [119847] by ostapenko.viatcheslav@nokia.com

3 edits in trunk/Source/WebKit2

[Qt] [WK2] API tests randomly assert in WebLayerTreeRenderer::assignImageToLayer
https://bugs.webkit.org/show_bug.cgi?id=88667

Reviewed by Noam Rosenthal.

Move deactivation of WebLayerTreeRenderer from LayerTreeHostProxy::purgeBackingStores
to WebLayerTreeRenderer::purgeGLResources. LayerTreeHostProxy::purgeBackingStores is
invoked on main thread after going through call gate and it is too late to deactivate
renderer here, because some update messages are able to go through.
WebLayerTreeRenderer::purgeGLResources is called directly from render node deallocation
and it is right place to deactivate renderer.

UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::purgeBackingStores):

UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::purgeGLResources):

11:24 AM Changeset in webkit [119846] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Add COMPILE_ASSERT to StyledElement to ensure it doesn't accidentally grow larger.
https://bugs.webkit.org/show_bug.cgi?id=88627

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

No change in user-facing behavior.

dom/StyledElement.cpp:

(WebCore):

11:19 AM Changeset in webkit [119845] by tony@chromium.org

2 edits
3 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html after skia gamma correction
https://bugs.webkit.org/show_bug.cgi?id=88589

platform/chromium-linux/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
platform/chromium/TestExpectations:

11:17 AM Changeset in webkit [119844] by ggaren@apple.com

9 edits in trunk/Source/JavaScriptCore

Don't rely on weak pointers for eager CodeBlock finalization
https://bugs.webkit.org/show_bug.cgi?id=88465

Reviewed by Gavin Barraclough.

This is incompatible with lazy weak pointer finalization.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Maybe this

will build.

debugger/Debugger.cpp: Updated for rename.

heap/Heap.cpp:

(JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
eager finalization of unmarked code blocks.

(JSC::Heap::collect): Updated for rename. Updated to call
deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
blocks too.

(JSC::Heap::addCompiledCode): Renamed, since this points to all code
now, not just functions.

heap/Heap.h:

(Heap): Keep track of all user code, not just functions. This is a
negligible additional overhead, since most code is function code.

runtime/Executable.cpp:

(JSC::*::finalize): Removed these functions, since we don't rely on
weak pointer finalization anymore.

(JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
function to improve clarity.

runtime/Executable.h:

(JSC::ExecutableBase): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
for clarity.

(JSC::FunctionExecutable::isCompiling): New helper function, for clarity.

(JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
the heap needs to make polymorphic calls to clear code.

runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
renames.

11:14 AM Changeset in webkit [119843] by rjkroege@chromium.org

2 edits in trunk/Source/WebKit/chromium

More than 8 fingers get ignored by touch
https://bugs.webkit.org/show_bug.cgi?id=88359

Reviewed by James Robinson.

public/WebInputEvent.h: Increase of TouchPoints per TouchEvent from 8 to 12.

10:59 AM Changeset in webkit [119842] by mitz@apple.com

2 edits in trunk/LayoutTests

Added svg/filters/color-space-conversion.svg to the Mac skip list. It has been failing since
its addition in r119841. <http://webkit.org/b/88672> is tracking the failure.

platform/mac/Skipped:

10:52 AM Changeset in webkit [119841] by schenney@chromium.org

2 edits in trunk/LayoutTests

WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321

Unreviewed Chromium expectations update.

Adding tests that are failing pending a rebaseline.

platform/chromium/TestExpectations:

10:46 AM Changeset in webkit [119840] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove css3/flexbox/child-overflow.html from TestExpectations.
Since bug 77368 is now fixed, this test passes.

platform/chromium/TestExpectations:

9:57 AM Changeset in webkit [119839] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Fix several compiler warnings and errors.
https://bugs.webkit.org/show_bug.cgi?id=88660

Reviewed by Pavel Feldman.

Fixed several compiler warnings and errors.
Removed isEmpty method from Object.prototype and made it static method on Object.

inspector/InjectedScriptExterns.js:
inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._detachFrame):

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildDominatorTree):

inspector/front-end/utilities.js:

(Object.isEmpty):

9:54 AM Changeset in webkit [119838] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Fix assertion failure introduced by bug 87551
https://bugs.webkit.org/show_bug.cgi?id=88659

Patch by Max Feil <mfeil@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.

The determineRenderSlider() convenience function added in bug
87551 made an assumption that wasn't always true. This didn't
cause a functional error but it caused an assertion failure,
which indicates a problem with the code. PR164142.

No new tests because this case is already covered by ASSERT's.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::determineRenderSlider):

9:37 AM Changeset in webkit [119837] by Carlos Garcia Campos

11 edits
3 adds in trunk

[GTK] Add API to get the library version to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=88426

Reviewed by Martin Robinson.

configure.ac: Generate WebKitVersion.h from WebKitVersion.h.in

file.

Source/WebKit2:

GNUmakefile.am:
GNUmakefile.list.am:
UIProcess/API/gtk/WebKitVersion.cpp: Added.

(webkit_get_major_version):
(webkit_get_minor_version):
(webkit_get_micro_version):

UIProcess/API/gtk/WebKitVersion.h.in: Added.
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new symbols.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new section

for WebKitVersion.

UIProcess/API/gtk/tests/GNUmakefile.am:
UIProcess/API/gtk/tests/TestWebKitVersion.cpp: Added.

(testWebKitVersion):
(testWebKitCheckVersion):
(beforeAll):
(afterAll):

UIProcess/API/gtk/webkit2.h: Include WebKitVersion.h.

Tools:

gtk/generate-gtkdoc:

(get_webkit2_options): Add built sources to the list of files, but
ignore enum types and marshallers.

9:27 AM BuildBot edited by alex.bravo@nokia.com

FIxed a typo (diff)

9:26 AM BuildBot edited by alex.bravo@nokia.com

Fixed formatting of lists (diff)

8:36 AM Changeset in webkit [119836] by schenney@chromium.org

2 edits in trunk/LayoutTests

Unreviewed fix for Chromium TestExpectations.

A file crept into the expectations that has not yet been submitted.

platform/chromium/TestExpectations:

8:35 AM Changeset in webkit [119835] by Simon Hausmann

2 edits in trunk/Source/WebKit/qt

Unreviewed, fix file permissions.

WebCoreSupport/FrameLoaderClientQt.cpp:

8:23 AM Changeset in webkit [119834] by commit-queue@webkit.org

4 edits
1 add in trunk

Some overlay scrollbar API calls in ScrollAnimatorMac can lead to an assertion in RenderBox::mapAbsoluteToLocalPoint
https://bugs.webkit.org/show_bug.cgi?id=74111

Patch by Ion Rosca <Ion Rosca> on 2012-06-08
Reviewed by Simon Fraser.

ManualTests/scrollbar-crash-on-hide-scrolled-area.html: Added.

Source/WebCore:

Added zero-delay timer for AppKit scroll notification that can be called during layout.
Manual test: ManualTests/scrollbar-crash-on-hide-scrolled-area.html
This assertion does not fire when running layout tests. It can be easly reproduced using a debug build by loading the manual test page.

platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
(WebCore):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

8:20 AM Changeset in webkit [119833] by reni@webkit.org

6 edits in trunk

Adding few already supported features to the FeatureSet in DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=86482

Source/WebCore:

Text, Filter and View features are already implemented but they
are not added to the SVG11 feature set. This is corrected in this patch.

Reviewed by Nikolas Zimmermann.

No new testcase is needed because we already have one what checks the svg features via
DOMImplementation (svg/custom/svg-features.html).

dom/DOMImplementation.cpp:

(WebCore::isSVG11Feature):

LayoutTests:

Reviewed by Nikolas Zimmermann.

platform/qt-5.0/svg/custom/svg-features-expected.txt:
platform/qt/svg/custom/svg-features-expected.txt:
svg/custom/svg-features-expected.txt:

8:13 AM Changeset in webkit [119832] by scheib@chromium.org

4 edits in trunk

Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88604

Reviewed by Kent Tamura.

Tools:

DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerUnlock):

LayoutTests:

Removed CRASH expectation.
Test is no longer crashing with this fix to DumpRenderTree.

platform/chromium/TestExpectations:

8:01 AM Changeset in webkit [119831] by schenney@chromium.org

5 edits
2 adds in trunk

WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321

Reviewed by Dirk Schulze.

Source/WebCore:

The code in ImageBuffer::transformColorSpace had two problems that are
fixed by this patch.

First, it was using member variables for data
that is static constant. This is incredibly wasteful, as every
ImageBuffer that is created (and we make a lot of them) gets its own
copy of the LUT and the table is initialized again and again. The
patch replaces this with a static local, with lazy evaluation, in
the method that uses the tables.

Second, the code for filling the table was mapping 255 to 254, thus
reducing the intensity and alpha of every image it pushed through a
color transform.

Test: svg/filters/color-space-conversion.svg

platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):

platform/graphics/ImageBuffer.h:

(ImageBuffer):

LayoutTests:

Temporarily marking Chromium tests expected to fail as a result of this patch. And a new test.

platform/chromium/TestExpectations:
svg/filters/color-space-conversion.svg:
svg/filters/color-space-conversion-expected.svg:

7:44 AM Changeset in webkit [119830] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Better labels positioning on the memory pie chart
https://bugs.webkit.org/show_bug.cgi?id=88652

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-08
Reviewed by Vsevolod Vlasov.

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):

7:30 AM Changeset in webkit [119829] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Tried to fix the Snow Leopard build after r119806.

WebKit2Prefix.h:

7:23 AM Changeset in webkit [119828] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

DEPS:

7:11 AM Changeset in webkit [119827] by qi.2.zhang@nokia.com

2 edits in trunk/LayoutTests

[Qt] fast/viewport/viewport-133.html fails
https://bugs.webkit.org/show_bug.cgi?id=80689

Since https://bugs.webkit.org/show_bug.cgi?id=88047 remove this
test case, remove it from skip list.

Reviewed by Laszlo Gombos.

platform/qt/Skipped:

6:07 AM Changeset in webkit [119826] by caseq@chromium.org

30 edits in trunk

Web Inspector: Annotate timeline records with a frame identifier
https://bugs.webkit.org/show_bug.cgi?id=86406

Patch by Bryan McQuade <bmcquade@google.com> on 2012-06-08
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests: Updated existing layout tests.

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorInstrumentation.cpp:

(WebCore::frameForScriptExecutionContext):
(WebCore):
(WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
(WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::willLayoutImpl):
(WebCore::InspectorInstrumentation::willLoadXHRImpl):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didScheduleResourceRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::willChangeXHRReadyState):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::willReceiveResourceData):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRequestAnimationFrame):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrame):
(WebCore::InspectorTimelineAgent::willFireAnimationFrame):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):

inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):

inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.isEventDivider):
(WebInspector.TimelinePresentationModel.Record):

LayoutTests:

inspector/timeline/timeline-animation-frame-expected.txt:
inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
inspector/timeline/timeline-event-dispatch-expected.txt:
inspector/timeline/timeline-injected-script-eval-expected.txt:
inspector/timeline/timeline-layout-expected.txt:
inspector/timeline/timeline-load-event-expected.txt:
inspector/timeline/timeline-network-resource-expected.txt:
inspector/timeline/timeline-paint-expected.txt:
inspector/timeline/timeline-parse-html-expected.txt:
inspector/timeline/timeline-recalculate-styles-expected.txt:
inspector/timeline/timeline-script-tag-1-expected.txt:
inspector/timeline/timeline-script-tag-2-expected.txt:
inspector/timeline/timeline-test.js:
inspector/timeline/timeline-timer-expected.txt:
platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
platform/chromium/inspector/timeline/timeline-layout-expected.txt:
platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
platform/chromium/inspector/timeline/timeline-paint-expected.txt:
platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
platform/chromium/inspector/timeline/timeline-timer-expected.txt:

5:59 AM Changeset in webkit [119825] by loislo@chromium.org

2 edits in trunk/LayoutTests

Unreviewed update for chromium test expectations.
viewspec-parser-*.html were marked as SLOW.

platform/chromium/TestExpectations:

BUGWK87772 SLOW : svg/dom/viewspec-parser-1.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-2.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-3.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-4.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-5.html = PASS

5:46 AM Changeset in webkit [119824] by kinuko@chromium.org

12 edits in trunk/Source/WebCore

Unreviewed, rolling out r119821.
http://trac.webkit.org/changeset/119821
https://bugs.webkit.org/show_bug.cgi?id=88648

Seems to have regression on Mac (Requested by kinuko on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding):
(WebCore):
(WebCore::File::captureSnapshot):

fileapi/File.h:

(File):

fileapi/File.idl:
platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

platform/FileSystem.h:
platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

platform/network/BlobData.cpp:

(WebCore):

platform/network/BlobData.h:

(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):

platform/network/FormData.cpp:

(WebCore::FormData::appendFile):

platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::blobIsOutOfDate):

5:29 AM Changeset in webkit [119823] by kinuko@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, removing duplicated entries in gyp.

WebCore.gypi:

5:16 AM Changeset in webkit [119822] by arko@motorola.com

3 edits
2 adds in trunk

Microdata: An element with an empty itemprop= should not get listed in the .properties list.
https://bugs.webkit.org/show_bug.cgi?id=88235

Reviewed by Ryosuke Niwa.

Source/WebCore:

As per the specification change http://html5.org/r/6854, an element should be listed in .properties
if the elelement has an attribute itemprop specified and the element has one or more property names.

Test: fast/dom/MicroData/element-with-empty-itemprop.html

html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::itemAfter):

LayoutTests:

fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Added.
fast/dom/MicroData/element-with-empty-itemprop.html: Added.

4:50 AM Changeset in webkit [119821] by kinuko@chromium.org

12 edits in trunk/Source/WebCore

File::lastModifiedDate should use NaN or separate boolean flag for null Date value
https://bugs.webkit.org/show_bug.cgi?id=87826

Reviewed by Kent Tamura.

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.

fileapi/File.h:

(File):

fileapi/File.idl:
platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

platform/FileSystem.h:
platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

platform/network/BlobData.h:

(WebCore::BlobDataItem::doNotCheckFileChange): Removed.

platform/network/BlobData.cpp:
platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::blobIsOutOfDate):

4:44 AM Changeset in webkit [119820] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unskip passing sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=88641

Unreviewed, unskip sputnik tests which are passing now.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-08

platform/efl/TestExpectations:

4:11 AM Changeset in webkit [119819] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening, removing crash expectations for two plugins
tests that were fixed after LLInt was enabled for the Gtk port in r119593.

platform/gtk/TestExpectations:

4:02 AM Changeset in webkit [119818] by hans@chromium.org

7 edits
4 adds in trunk

Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=87976

Reviewed by Kent Tamura.

Tools:

Provide a mock implementation of WebSpeechRecognizer for
DumpRenderTree. This will allow better testing of the API via layout
tests.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::addMockSpeechRecognitionResult):

DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.

(MockWebSpeechRecognizer::create):
(MockWebSpeechRecognizer::start):
(MockWebSpeechRecognizer::stop):
(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::ResultTask::runIfValid):

DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.

(WebKit):
(MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::addMockResult):
(MockWebSpeechRecognizer::taskList):
(ClientCallTask):
(MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
(ResultTask):
(MockWebSpeechRecognizer::ResultTask::ResultTask):
(NoMatchTask):
(MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::speechRecognizer):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::mockSpeechRecognizer):

LayoutTests:

Add a layout test using the new mock, pushing a mock result through
and checking that events fire correctly.

fast/speech/scripted/speechrecognition-basics-expected.txt: Added.
fast/speech/scripted/speechrecognition-basics.html: Added.

3:59 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

3:41 AM Changeset in webkit [119817] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r119795, adding separate test expectations
for jquery/core.html - the test is crashing on debug builds and failing
with a text diff on release builds.

platform/gtk/TestExpectations:

2:53 AM Changeset in webkit [119816] by tkent@chromium.org

15 edits
2 adds in trunk/Source/WebCore

Move form-related functions of Document to FormController
https://bugs.webkit.org/show_bug.cgi?id=88497

Reviewed by Hajime Morita.

A lot of files depend on Document.h. We had to build many files when we
touched form-related features in Document.h or
CheckedRadioButtons.h. This patch reduces such pain.

No new tests. Just a refactoring.

CMakeLists.txt: Add FormController.cpp and/or FormController.h.
GNUmakefile.list.am: ditto.
Target.pri: ditto.
WebCore.gypi: ditto.
WebCore.vcproj/WebCore.vcproj: ditto.
WebCore.xcodeproj/project.pbxproj: ditto.

dom/Document.cpp: Removed form-releated features except the followings.

(WebCore::Document::formController): Accessor for a FormController.
(WebCore::Document::formElementsState):
Just returns FormController::formElementsState().
We don't create new FormController.
(WebCore::Document::setStateForNewFormElements):
Just returns FormController::setStateForNewFormElements().
We don't create new FormController if the specified vector is empty.

dom/Document.h:

Moved form-related functions to FormController.

html/FormController.cpp: Added. Moved from Document.cpp.
html/FormController.h: Added. Moved from Document.h

html/FormAssociatedElement.cpp: Use Document::formController().

(WebCore::FormAssociatedElement::didMoveToNewDocument):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formAttributeChanged):

html/HTMLFormControlElementWithState.cpp: Use Document::formController().

(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

html/HTMLFormElement.cpp: Use Document::formController().

(WebCore::HTMLFormElement::didNotifyDescendantInsertions):
(WebCore::HTMLFormElement::removedFrom):

html/HTMLInputElement.cpp: Use Document::formController().

(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::checkedRadioButtons):

html/HTMLInputElement.h:

Declare CheckedRadioButtons. It was provided by Document.h.

html/parser/HTMLConstructionSite.h:

Declare HTMLFormElement. It was provided by Document.h

2:50 AM Changeset in webkit [119815] by commit-queue@webkit.org

12 edits
2 adds in trunk/Source

Add FileSystem item to storage tree.
https://bugs.webkit.org/show_bug.cgi?id=72691

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-08
Reviewed by Vsevolod Vlasov.

Source/WebCore:

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/FileSystemModel.js: Added.
inspector/front-end/Images/fileSystem.png: Added.
inspector/front-end/ResourcesPanel.js:

(WebInspector.FileSystemListTreeElement):
(WebInspector.FileSystemListTreeElement.prototype.onexpand):
(WebInspector.FileSystemListTreeElement.prototype.onattach):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
(WebInspector.FileSystemTreeElement):
(WebInspector.FileSystemTreeElement.prototype.get fileSystemName):
(WebInspector.FileSystemTreeElement.prototype.get itemURL):

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/resourcesPanel.css:

(.file-system-storage-tree-item .icon):

inspector/front-end/utilities.js:

Source/WebKit/chromium:

src/js/DevTools.js:

2:19 AM Changeset in webkit [119814] by haraken@chromium.org

5 edits in trunk/Source/WebCore

REGRESSION r119802: Remove unnecessary ASSERT(!m_deletionHasBegun) from Document.h
https://bugs.webkit.org/show_bug.cgi?id=88528

Reviewed by Ryosuke Niwa.

m_deletionHasBegun should become true just before 'delete this'.

No tests. No change in behavior.

dom/Document.h:

(WebCore::Document::guardRef):
(WebCore::Document::guardDeref):

2:09 AM Changeset in webkit [119813] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved.
https://bugs.webkit.org/show_bug.cgi?id=88637

Unreviewed build fix.

Linking content_shell on the Chromium side fails due to an unresolved
call to WebSharedWorker::create(). Since this blocks WebKit rolls,
temporarily re-enable the feature until this has been solved.

features.gypi:

1:29 AM Changeset in webkit [119812] by noel.gordon@gmail.com

1 edit
1 copy
1 move in trunk/LayoutTests

[chromium] Run optimize-baselines over canvas-toDataURL-webp.html results

Unreviewed test expectations update.

platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png.
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png.

1:14 AM Changeset in webkit [119811] by abarth@webkit.org

2 edits in trunk/Source/WebCore

HTTP 204 No Content responses shouldn't trigger MIME type warnings in the web inspector
https://bugs.webkit.org/show_bug.cgi?id=88603

Reviewed by Pavel Feldman.

A 204 response doesn't have an entity body, so its MIME type is kind of
meaningless. We shouldn't spam the console with a warning about MIME
types.

inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):

1:01 AM Changeset in webkit [119810] by kkristof@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip tests using disabled SHADOW_DOM feature on Qt.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-08

platform/qt/Skipped:

12:51 AM Changeset in webkit [119809] by yosin@chromium.org

11 edits in trunk/Source/WebCore

[Forms] Drop StepRange::NumberWithDecimalPlacesOrMissing
https://bugs.webkit.org/show_bug.cgi?id=88621

Reviewed by Kent Tamura.

This patch changes NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
We use NaN as indication of having value or not.

No new tests, because this patch doesn't change behavior.

html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.

html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange): ditto.

html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): ditto.

html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): ditto.

html/NumberInputType.cpp:

(WebCore::NumberInputType::createStepRange): ditto.

html/RangeInputType.cpp:

(WebCore::RangeInputType::createStepRange): ditto.

html/StepRange.cpp:

(WebCore::StepRange::StepRange): Checks value is finite or not.
(WebCore::StepRange::parseStep): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.

html/StepRange.h:

(StepRange): Removed NumberWithDecimalPlacesOrMissing.

html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange): NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.

html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): ditto.

12:45 AM Changeset in webkit [119808] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Fixed a comment, pointed out by ap@.

platform/TreeShared.h:

(WebCore):

12:42 AM Changeset in webkit [119807] by noel.gordon@gmail.com

2 edits in trunk/Source/WebCore

[chromium] WEBP image blue and red color channels reversed on Android
https://bugs.webkit.org/show_bug.cgi?id=88613

Reviewed by Kent Tamura.

No new tests. Covered by test fast/images/webp-image-decoding.html though I'm
not sure where/how the Androids run their layout tests.

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(outputMode): Detect little-endian Skia with a blue pixel shift (aka Android)
which seems to be the way for them per bug 75861.

12:29 AM Changeset in webkit [119806] by aestes@apple.com

3 edits in trunk/Source/WebKit2

[WebKit2] Move Mac-specific bits from config.h to WebKit2Prefix.h
https://bugs.webkit.org/show_bug.cgi?id=88625

Reviewed by Dan Bernstein.

Since the Mac supports prefix headers, there is no point in having
Mac-specific code in WebKit2's config.h. Move it to WebKit2Prefix.h.

WebKit2Prefix.h:
config.h:

12:27 AM Changeset in webkit [119805] by mitz@apple.com

2 edits in trunk/LayoutTests

Fixed fast/files/read-blob-async.html failing after r119791.

fast/files/resources/read-blob-test-cases.js:

(testReadingSingleArrayBufferBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingMultipleArrayBufferBlob):
(testReadingHybridBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):

12:22 AM Changeset in webkit [119804] by noel.gordon@gmail.com

1 edit
1 add in trunk/LayoutTests

[chromium] New virtual GPU canvas-toDataURL-webp.html results after r119787

Unreviewed test expectations update.

platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png: Added.

12:04 AM Changeset in webkit [119803] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove the assertion that has been moved to TreeScope after r119802.

dom/Document.cpp:

(WebCore::Document::removedLastRef):

Jun 7, 2012:

11:28 PM Changeset in webkit [119802] by haraken@chromium.org

16 edits in trunk

Reduce Node object size from 72 byte to 64 byte
https://bugs.webkit.org/show_bug.cgi?id=88528

Reviewed by Ryosuke Niwa.

Added a symbol for callRemovedLastRef().

Source/autotools/symbols.filter:

Source/WebCore:

This patch removes all virtual methods from TreeShared.h,
by which we can remove a virtual method table pointer (8 byte
in a 64bit architechture) from each Node object. Consequently,
this patch reduces the Node object size from 72 byte to 64 byte.

e.g. The HTML spec (http://www.whatwg.org/specs/web-apps/current-work/)
contains 325640 Node objects. Thus this patch saves 325640 * 8 byte = 2.6 MB.

e.g. sizeof(Element) is reduced from 104 byte to 96 byte.

In multiple inheritance, a virtual method table pointer is allocated

for each base class that has virtual methods. For example, for
'class A : public B, C {};' where B and C have virtual methods,
two virtual method table pointers are allocated for each A object.
In this patch, A = Node, B = EventTarget, and C = TreeShared.
By removing the virtual methods from TreeShared, we can save the virtual
method table pointer for TreeShared. 8 byte saving.

Node and SVGElementInstance are the only classes that inherit TreeShared.

This patch removes virtual TreeShared::removeLastRef() and implements

virtual Node::removeLastRef() and virtual SVGElementInstance::removeLastRef().
Node::removeLastRef() calls 'delete this' for 'this' of type Node*,
and SVGElementInstance::removeLastRef() calls 'delete this' for 'this' of type
SVGElementInstance*.

This patch removes the virtual destructor of TreeShared. This removal is safe

because (1) no one calls 'delete this' for 'this' of type TreeShared*,
and (2) both Node and SVGElementInstance have virtual destructor.

No change in behavior. Confirm no regression in existing tests.

dom/ContainerNode.cpp:

(WebCore::callRemovedLastRef):
(WebCore):

dom/Node.h:

(WebCore::Node::removedLastRef):

platform/TreeShared.h:

(WebCore):
(TreeShared):
(WebCore::TreeShared::deref):

svg/SVGElementInstance.cpp:

(WebCore::callRemovedLastRef):
(WebCore):

svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::removedLastRef):

WebCore.order: Added a symbol for callRemovedLastRef().
WebCore.exp.in: Ditto.

Source/WebKit/mac:

Added a symbol for callRemovedLastRef().

WebKit.order:

Source/WebKit2:

Added a symbol for callRemovedLastRef().

mac/WebKit2.order:
win/WebKit2.def:
win/WebKit2CFLite.def:

11:22 PM Changeset in webkit [119801] by noel.gordon@gmail.com

2 edits
1 add in trunk/LayoutTests

[chromium] Update canvas-toDataURL-webp.html results after r119787

Unreviewed test expectations update.

platform/chromium/TestExpectations:
platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png: Added.

10:48 PM Changeset in webkit [119800] by aestes@apple.com

2 edits in trunk/Source/WebKit2

[WebKit2] Explicitly include CoreFoundation.h in config.h
https://bugs.webkit.org/show_bug.cgi?id=88619

Reviewed by Dan Bernstein.

WebKit2 relies (probably unintentionally) on CoreFoundation.h being
included by CoreGraphics.h (via CGSession.h), but some versions of
CoreGraphics headers don't include CoreFoundation.h. WebKit2 should
include it explicitly in config.h.

config.h: Import CoreFoundation.h.

10:29 PM Changeset in webkit [119799] by commit-queue@webkit.org

11 edits
2 adds in trunk

ShadowRoot needs resetStyleInheritance
https://bugs.webkit.org/show_bug.cgi?id=84048

Source/WebCore:

Added resetStyleInheritance API to ShadowRoot. The spec URL is
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
To implement the API, modified StyleResolver to use empty style
instead of parent style if resetStyleInheritance is true,
and a node and its parent node are placed in different shadow trees.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Hajime Morita.

Test: fast/dom/shadow/shadow-root-resetStyleInheritance.html

fast/dom/shadow/shadow-root-resetStyleInheritance-expected.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::initForStyleResolve):
Set m_parentStyle to NULL when resetStyleInheritance.
(WebCore::StyleResolver::documentSettings):
Added a new method to obtain current document's settings.
(WebCore::StyleResolver::initializeFontStyle):
Initialize m_style by using document settings. Its code was move
from the code initializing font style in applyProperty.
(WebCore::StyleResolver::styleForElement):
Initialize font style if m_parentStyle is NULL. The old code just
used style() and don't touch font style. The new code uses the above
initializeFontStyle.
(WebCore::StyleResolver::applyProperty):
Moved a code for initializing font style as "initial" to
a new method: initializeFontStyle and modified to use the method.
Modified to use documentSettings().
(WebCore::StyleResolver::checkForGenericFamilyChange):
Modified to use documentSettings().

css/StyleResolver.h:

(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::initializeFontStyle):
Added two new methods to class StyleResolver.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
Modified to calculate m_resetStyleInheritance in its constructor.

dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::resetStyleInheritance):
Implemented a new method, just returning m_resetStyleInheritance.

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setResetStyleInheritance):
Modified to force to recalculate children's styles if
resetStyleInheritance is changed.

dom/ShadowRoot.h:

(ShadowRoot):
Added resetStyleInheritance getter and setter.

dom/ShadowRoot.idl:

Added an attribute, resetStyleInheritance.

dom/TreeScope.cpp:

(WebCore::TreeScope::resetStyleInheritance):

dom/TreeScope.h:

(TreeScope):
Added resetStyleInheritance's default getter.
The getter will be overrided by class ShadowRoot's getter.

LayoutTests:

Added layout tests for checking whether resetStyleInheritance works correctly or not.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Hajime Morita.

fast/dom/shadow/shadow-root-resetStyleInheritance.html: Added.
fast/dom/shadow/shadow-root-resetStyleInheritance-expected.html: Added.

9:49 PM Changeset in webkit [119798] by aestes@apple.com

3 edits in trunk/Source/WebKit2

[WebKit2] Only include Cocoa.h on platforms that use AppKit
https://bugs.webkit.org/show_bug.cgi?id=88517

Reviewed by Sam Weinig.

WebKit2Prefix.h: Include Platform.h to get USE() macros. GTK needs to

include autotoolsconfig.h before including Platform.h, so do that first
if building on GTK. Then, if compiling an Objective-C file, it's safe
to include Foundation.h, but not necessarily Cocoa.h; only include the
latter if USE(APPKIT) is true.

config.h: There's no need to import Cocoa.h since this is already

imported in the prefix header.

9:27 PM Changeset in webkit [119797] by mrowe@apple.com

4 edits in branches/safari-536-branch/Source

Versioning.

9:26 PM Changeset in webkit [119796] by mrowe@apple.com

1 copy in tags/Safari-536.17

New tag.

9:25 PM Changeset in webkit [119795] by barraclough@apple.com

8 edits in trunk/Source/JavaScriptCore

DFG should inline prototype chain accesses, and do the right things if the
specific function optimization is available
https://bugs.webkit.org/show_bug.cgi?id=88594

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-06-07
Reviewed by Gavin Barraclough.

Looks like a 3% win on V8.

bytecode/CodeBlock.h:

(JSC::Structure::prototypeForLookup):
(JSC):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::isSimple):
(JSC::GetByIdStatus::chain):
(JSC::GetByIdStatus::specificValue):
(GetByIdStatus):

bytecode/StructureSet.h:

(StructureSet):
(JSC::StructureSet::singletonStructure):

bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):

runtime/JSGlobalObject.h:

(JSC::Structure::prototypeForLookup):
(JSC):

runtime/Structure.h:

(Structure):

9:24 PM Changeset in webkit [119794] by kinuko@chromium.org

3 edits in trunk/Tools

check-webkit-style needs to be taught about <public/Foo.h>
https://bugs.webkit.org/show_bug.cgi?id=88524

Reviewed by David Levin.

Scripts/webkitpy/style/checkers/cpp.py:

(_classify_include):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_public_primary_header):
(OrderOfIncludesTest.test_classify_include):

9:15 PM Changeset in webkit [119793] by kinuko@chromium.org

3 edits in trunk/LayoutTests

Fix unmatched parenthesis in fast/dom/HTMLAnchorElement/anchor-download-unset.html
https://bugs.webkit.org/show_bug.cgi?id=88526

Reviewed by Alexey Proskuryakov.

This test is skipped on other platforms than chromium.

fast/dom/HTMLAnchorElement/anchor-download-unset.html:
platform/chromium/TestExpectations:

8:21 PM Changeset in webkit [119792] by commit-queue@webkit.org

6 edits in trunk

addTextTrack should set track mode to HIDDEN
https://bugs.webkit.org/show_bug.cgi?id=88317

Patch by Victor Carbune <victor@rosedu.org> on 2012-06-07
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTextTrack): Set the default parameters
for the newly created TextTrack.

html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

LayoutTests:

media/track/track-texttracks-expected.txt: Updated.
media/track/track-texttracks.html: Updated.

8:15 PM Changeset in webkit [119791] by commit-queue@webkit.org

15 edits in trunk

FileAPI: Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
https://bugs.webkit.org/show_bug.cgi?id=88294

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Jian Li.

Source/WebCore:

From Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
Currently we add the support for ArrayBufferView, while still keeping ArrayBuffer for
backward compatibility. We will remove it in the near future.

Test: fast/files/blob-constructor.html

bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):
(WebCore):

fileapi/WebKitBlobBuilder.h:

(WebCore):
(WebKitBlobBuilder):

fileapi/WebKitBlobBuilder.idl: Add support for ArrayBufferView in append method

LayoutTests:

Support ArrayBufferView in Blob constructing function.

fast/files/blob-constructor-expected.txt:
fast/files/file-reader-fffd-expected.txt:
fast/files/file-reader-fffd.html:
fast/files/script-tests/blob-constructor.js:
http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
http/tests/websocket/tests/hybi/send-blob.html:
http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

(createBlobContainingAllDistinctBytes):

8:13 PM Changeset in webkit [119790] by morrita@google.com

3 edits
2 adds in trunk

A style in an older shadow subtree causes assert when composing with <shadow>
https://bugs.webkit.org/show_bug.cgi?id=88299

Reviewed by Dimitri Glazkov.

Source/WebCore:

InsertionPoint::attach() assumes its distributed content not being attach()-ed.
But this assumption can break. This change added a guard for that.
This can happen for shadow boundaries in general. But ShadowRoot already handles that case.

Test: fast/dom/shadow/insertion-point-shadow-crash.html

html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):

LayoutTests:

fast/dom/shadow/insertion-point-shadow-crash-expected.txt: Added.
fast/dom/shadow/insertion-point-shadow-crash.html: Added.

8:06 PM Changeset in webkit [119789] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Show correct fullscreen button image (media controls)
https://bugs.webkit.org/show_bug.cgi?id=88563

Patch by Max Feil <mfeil@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

PR159306: Show "exit" fullscreen button image instead of "enter"
fullscreen button image when in fullscreen mode (HTML5 media
controls).

I am not providing a test due to the simplicity of this patch
and the relative difficulty and maintainability issues associated
with testing how an image is rendered.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):

7:59 PM Changeset in webkit [119788] by commit-queue@webkit.org

4 edits in trunk

[EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67255

Patch by Joshua Lock <joshua.lock@intel.com> on 2012-06-07
Reviewed by Dirk Pranke.

Tools:

Implement pathToLocalResource to redirect file:///tmp URL's to
DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
LayoutTests sub-directory of the WebKit source tree.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pathToLocalResource):

LayoutTests:

platform/efl/TestExpectations: unskip

fast/dom/frame-loading-via-document-write.html now that
LayoutTestController::pathToLocalResource() is implemented for EFL.

7:57 PM Changeset in webkit [119787] by noel.gordon@gmail.com

6 edits
2 adds in trunk

[chromium] Use WEBPImportPictureRGBX|BGRX to import picture data
https://bugs.webkit.org/show_bug.cgi?id=88218

Reviewed by Kent Tamura.

Source/WebCore:

Stop using the RGBA and RGBA variants of the picture import routines (since
these will import alpha channel data in a future libwebp). Use the RGBX and
BGRX variants to import picture data for encoding to make it clear that the
alpha channel is (and must be) ignored.

Test: fast/canvas/canvas-toDataURL-webp.html

platform/image-encoders/skia/WEBPImageEncoder.cpp:

(WebCore::rgbPictureImport):
(WebCore::importPictureBGRX): Use WEBPImportPictureBGRX for picture imports
that must ignore the alpha channel. Change the template parameter to be the
premultiplied alpha state of the input image data.
(WebCore::importPictureRGBX): Use WEBPImportPictureRGBX, ditto.
(WebCore::encodePixels): Invert the sense of the template parameter to make
it now indicate the premultiplied alpha state of the input image data.

LayoutTests:

The test image (html5.png) has an alpha 255 background. The background should
be rendered black when a <canvas>.toDataURL('image/webp') is used as an <img>
element src attribute for example, since WEBP does not support alpha.

fast/canvas/canvas-toDataURL-webp-expected.txt:
fast/canvas/canvas-toDataURL-webp.html: Change the test to encode the added

html5.png test image as an image/webp data url.

fast/canvas/resources/html5.png: Added.
platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png: Added.
platform/chromium/TestExpectations: Requires WIN, LINUX rebaselines.

7:51 PM Changeset in webkit [119786] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Improve deviceDPI, rect, and availableRect computation
https://bugs.webkit.org/show_bug.cgi?id=88596

Reviewed by Adam Barth.

Set deviceDPI to 160 for normal displays and 320 for HiDPI displays.
(Why 160? That's what chromium's render_view.cc assumes as default
single-resolution resolution at the moment. The only other place
where this number gets used is fixed layout mode, which is currently
not enabled.)

Also fix rect and availableRect computations: They get returned in
user space already.

Needed for http://crbug.com/31960.

src/mac/WebScreenInfoFactory.mm:

(WebKit::toUserSpace):
(WebKit::deviceScaleFactor):
(WebKit):
(WebKit::WebScreenInfoFactory::screenInfo):

7:40 PM Changeset in webkit [119785] by commit-queue@webkit.org

3 edits in trunk/Tools

[chromium] Allow LayoutTests under new git workflow
https://bugs.webkit.org/show_bug.cgi?id=88575

On Windows, chromium indirects through git.bat. Adds the same hack that
is currently used for discovering svn.bat to support the new git
workflow.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-07
Reviewed by Dirk Pranke.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git): Replaces all hard-coded references to 'git' with the class
variable executable_name.
(Git._check_git_architecture):
(Git.in_working_directory):
(Git.find_checkout_root):
(Git.read_git_config):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.status_command):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git.changed_files):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.conflicted_files):
(Git.svn_revision):
(Git.create_patch):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):

Scripts/webkitpy/common/host.py:

(Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
that duplicates the logic in the existing 'svn.bat' hack.

7:19 PM Changeset in webkit [119784] by ojan@chromium.org

2 edits in trunk/Tools

Style build architectures like build versions for non-layout test failures
https://bugs.webkit.org/show_bug.cgi?id=88590

Reviewed by Tony Chang.

Since we show the list of failing tests after the architecture, we want the
buildtype and architecture to be grouped together visually.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:

(.effects a.failing-builder>span.architecture):

7:18 PM Changeset in webkit [119783] by ojan@chromium.org

175 edits
34 deletes in trunk/LayoutTests

Last set of chromium rebaselines after r119748.
Also mark pointer-lock/pointerlockchange-pointerlockerror-events.html
as crashing in Chromium debug after r119763.

Excluding list of changed pngs because it's too long.

platform/chromium/TestExpectations:

7:06 PM Changeset in webkit [119782] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Improve the performance of pushScope in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=88222

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Hajime Morita.

As setupScopeStack always sets m_scopeStackParent to be NULL,
m_scopeStack is never reused. m_scopeStackParent should be the last
element of m_scopeStack.

No new tests, because fast/css/style-scoped/ uses pushScope,
popScope and setupScopeStack and checks whether there exists
any crash bug or not. And this patch doesn't change any behavior
of scoped author syltes.

css/StyleResolver.cpp:

(WebCore::StyleResolver::setupScopeStack):
Modified to set m_scopeSackParent to be the last element of
m_scopeStack.
(WebCore::StyleResolver::popScope):
Modified to remove the last element if m_scopeStack is not empty and
the last element of m_scopeStack has the same scope as the scoping
element given by the argument.

6:35 PM Changeset in webkit [119781] by wangxianzhu@chromium.org

3 edits in trunk/Tools

[Chromium] Remove header dependency of ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88422

Reviewed by Ryosuke Niwa.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/chromium/ImageDiff.cpp:

(untestedCompareImages):

6:33 PM Changeset in webkit [119780] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
https://bugs.webkit.org/show_bug.cgi?id=88491

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-07
Reviewed by Dirk Pranke.

DRT should enable WebAudio when WebAudio feature is enabled,
so that the WebAudio feature could be tested by the Layouttest.

DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.

(LayoutTestController::overridePreference):

6:31 PM Changeset in webkit [119779] by fpizlo@apple.com

11 edits in trunk/Source/JavaScriptCore

DFG should inline prototype chain accesses, and do the right things if the
specific function optimization is available
https://bugs.webkit.org/show_bug.cgi?id=88594

Reviewed by Gavin Barraclough.

Looks like a 3% win on V8.

bytecode/CodeBlock.h:

(JSC::Structure::prototypeForLookup):
(JSC):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::isSimple):
(JSC::GetByIdStatus::chain):
(JSC::GetByIdStatus::specificValue):
(GetByIdStatus):

bytecode/StructureSet.h:

(StructureSet):
(JSC::StructureSet::singletonStructure):

bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):

runtime/JSGlobalObject.h:

(JSC::Structure::prototypeForLookup):
(JSC):

runtime/Structure.h:

(Structure):

6:21 PM Changeset in webkit [119778] by morrita@google.com

5 edits
2 copies in branches/chromium/1132

Merge 118711 - Can't edit <input> elements with :first-letter
https://bugs.webkit.org/show_bug.cgi?id=87615

Reviewed by Kent Tamura.

A check using canHaveGeneratedChildren() should cover not only
button and menulist, but also RenderTextControl.
This change pulles canHaveGeneratedChildren() up
from RenderDeprecatedFlexibleBox to RenderObject,
and lets RenderTextControl override it.

Test: fast/forms/input-first-letter-edit.html

rendering/RenderBlock.cpp:

(WebCore):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateFirstLetter):

rendering/RenderBlock.h: Removed a static function canHaveGeneratedChildren()

(RenderBlock):

rendering/RenderDeprecatedFlexibleBox.h:
rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::canHaveGeneratedChildren): Added.

rendering/RenderObject.h:

(RenderObject):

rendering/RenderTextControl.h:

TBR=morrita@google.com
Review URL: https://chromiumcodereview.appspot.com/10538049

5:48 PM Changeset in webkit [119777] by pilgrim@chromium.org

7 edits in trunk/Source

[Chromium] Move didStartWorkerRunLoop to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=88562

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

WebCore.gyp/WebCore.gyp:
bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):

platform/chromium/PlatformSupport.h:

(WebCore):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit/chromium:

src/PlatformSupport.cpp:

(WebCore):

5:36 PM Changeset in webkit [119776] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Dropping m_startingLineNumber property from StyledElement.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by Mike West <mkwst@chromium.org> on 2012-06-07
Reviewed by Adam Barth.

We can have the same effect by moving the line-number calculation
directly into StyledElement::styleAttributeChanged. This means that
subsequent changes to the style attribute (via script) won't generate
error messages with line numbers, but that's an acceptable tradeoff.

Behavior is covered by existing CSP tests.

dom/StyledElement.cpp:

(WebCore::StyledElement::StyledElement):
(WebCore::StyledElement::styleAttributeChanged):

dom/StyledElement.h:

(WebCore::StyledElement::destroyInlineStyle):

5:29 PM Changeset in webkit [119775] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Math.pow on iOS does not support denormal numbers.
https://bugs.webkit.org/show_bug.cgi?id=88592

Reviewed by Filip Pizlo.

Import an implementation from fdlibm, detect cases where it is safe to use the system
implementation & where we should fall back to fdlibm.

runtime/MathObject.cpp:

(JSC::isDenormal):
(JSC::isEdgeCase):
(JSC::mathPow):

On iOS, detect cases where denormal support may be required & use fdlibm in these cases.

(JSC::mathProtoFuncPow):

Changed to use mathPow.

(JSC::fdlibmScalbn):
(JSC::fdlibmPow):

These functions imported from fdlibm; original style retained to ease future merging.

5:00 PM Changeset in webkit [119774] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
https://bugs.webkit.org/show_bug.cgi?id=88576

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-07
Reviewed by Rob Buis.

When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use
this to load popup, no need to create a new one. The old code is based on an old solution
which has been abandoned.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::openPagePopup):

WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::init):
(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::handleMouseEvent):
(WebCore::PagePopupBlackBerry::closePopup):

WebCoreSupport/PagePopupBlackBerry.h:

(PagePopupBlackBerry):

4:59 PM Changeset in webkit [119773] by peter@chromium.org

2 edits in trunk/Source/WebCore

Initialize m_document in AXObjectCache's constructor for !HAVE(ACCESSIBILITY) builds
https://bugs.webkit.org/show_bug.cgi?id=88527

Reviewed by Adam Barth.

Initialize the m_document member with the passed on document in the stubbed
AXObjectCache constructor. No behavioral changes.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):

4:46 PM Changeset in webkit [119772] by ojan@chromium.org

2 edits in trunk/LayoutTests

Mark fast/table/multiple-captions-display.xhtml as flaky on Chromium.

platform/chromium/TestExpectations:

4:44 PM Changeset in webkit [119771] by zhajiang@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Get rid of unused maximumLayoutSize in WebPage
https://bugs.webkit.org/show_bug.cgi?id=88574

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 164098
maximumLayoutSize was deprecated when we made use of
WebCore::computeViewportAttributes for
WebPagePrivate::recomputeVirtualViewportFromViewportArguments.
So clean it up.

Api/WebPage.cpp:

(WebKit):

4:36 PM Changeset in webkit [119770] by ojan@chromium.org

2 edits
2 adds in trunk/LayoutTests

Chromium rebaselines after http://trac.webkit.org/changeset/119760.

platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png: Added.

4:35 PM Changeset in webkit [119769] by jamesr@google.com

11 edits
3 adds
3 deletes in trunk/Source

[chromium] Move deferral-related logic out of Canvas2DLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=86050

Reviewed by Stephen White.

Source/WebCore:

This removes Canvas2DLayerChromium and puts the deferral and double-buffering related logic in a new class,
Canvas2DLayerBridge, that uses TextureLayerChromium for compositing. The bridge is responsible for managing the
front texture when double buffering is active, inserting the correct makeContextCurrent() and flush() calls on
the GraphicsContext3D and SkCanvas when appropriate, and owning the lifetime of the layer.

WebCore.gypi:
platform/graphics/chromium/Canvas2DLayerBridge.cpp: Added.

(WebCore):
(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::context):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):

platform/graphics/chromium/Canvas2DLayerBridge.h: Added.

(WebCore):
(Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::create):

platform/graphics/chromium/Canvas2DLayerChromium.cpp: Removed.
platform/graphics/chromium/Canvas2DLayerChromium.h: Removed.
platform/graphics/chromium/GraphicsLayerChromium.cpp:
platform/graphics/chromium/ImageBufferDataSkia.h:

(WebCore):
(ImageBufferData):

platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::willModifyTexture):

willModifyTexture() is called whenever the texture currently owned by the TextureLayerChromium will be
modified by a system out of the compositor's control. It makes sure that the compositor does not attempt to
draw with the potentially-modified texture until the next commit. For canvas, this is used when threading is
enabled and a non-deferrable drawing command is invoked from JS.

(WebCore):

platform/graphics/chromium/TextureLayerChromium.h:

(TextureLayerChromium):

platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):

Source/WebKit/chromium:

WebKit.gypi:
tests/Canvas2DLayerBridgeTest.cpp: Renamed from tests/Canvas2DLayerChromiumTest

(Canvas2DLayerBridgeTest):
(Canvas2DLayerBridgeTest::fullLifecycleTest):

4:24 PM Changeset in webkit [119768] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r119441.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

4:18 PM Changeset in webkit [119767] by Patrick Gansterer

2 edits in trunk

Build fix for WinCE after r113570.

Source/cmake/OptionsWinCE.cmake:

4:10 PM Changeset in webkit [119766] by dpranke@chromium.org

5 edits in trunk/Tools

webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581

Reviewed by Ojan Vafai.

webkit-paptch rebaseline-expectations was ignoring what the
expected results for a test were and pulling down all the result
files from a bot. This could lead to us pulling down old,
incorrect .txt or .png files. With this patch we will now only
pull down expectations of the appropriate file types (so an
IMAGE failure will only pull the png and not the txt file).

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(has_pixel_failures):
(suffixes_for_expectations):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(FunctionsTest.test_suffixes_for_expectations):

Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand.init):
(RebaselineExpectations._is_supported_port):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):
(RebaselineExpectations._rebaseline_port):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_overrides_are_included_correctly):

4:07 PM Changeset in webkit [119765] by Patrick Gansterer

4 edits in trunk/Source/WebCore

Remove HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
https://bugs.webkit.org/show_bug.cgi?id=87931

Reviewed by Beth Dakin.

r62035 added HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until all ports implement
GraphicsContext::clipConvexPolygon(). All major ports define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in the
meantime and the alternative path has unnecessary maintainace costs and even don't compile at the moment.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::drawBoxSideFromPath):

rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):

rendering/RenderObject.h:

(RenderObject):

3:44 PM Changeset in webkit [119764] by tony@chromium.org

499 edits
1 move
2 adds
14 deletes in trunk/LayoutTests

[chromium] Unreviewed, new baselines for chromium-win after fixing
scrollbar rendering in r119748.

List of files omitted since it's long.

3:40 PM Changeset in webkit [119763] by scheib@chromium.org

13 edits
2 adds in trunk

Add new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror
https://bugs.webkit.org/show_bug.cgi?id=88377

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402

New change and error events added. Follow up patches will remove
the previous callbacks and pointerlocklost event. Tests updated
to include the new events, and a new test added specifically for
the new events, pointerlockchange-pointerlockerror-events.html.

Source/WebCore:

Test: pointer-lock/pointerlockchange-pointerlockerror-events.html

dom/Document.h:

(Document):

dom/Document.idl:
dom/EventNames.h:

(WebCore):

page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::enqueueEvent):
(WebCore):

page/PointerLockController.h:

(PointerLockController):

LayoutTests:

pointer-lock/lock-already-locked-expected.txt:
pointer-lock/lock-already-locked.html:
pointer-lock/pointer-lock-api-expected.txt:
pointer-lock/pointer-lock-api.html:
pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt: Added.
pointer-lock/pointerlockchange-pointerlockerror-events.html: Added.
pointer-lock/pointerlocklost-event-expected.txt:
pointer-lock/pointerlocklost-event.html:

3:37 PM Changeset in webkit [119762] by commit-queue@webkit.org

4 edits in trunk/Source

Unreviewed, rolling out r119744.
http://trac.webkit.org/changeset/119744
https://bugs.webkit.org/show_bug.cgi?id=88584

Fails assertions in debug builds (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

3:27 PM Changeset in webkit [119761] by jchaffraix@webkit.org

3 edits in trunk/Source/WebCore

Cache RenderLayer::isRootLayer for better performance
https://bugs.webkit.org/show_bug.cgi?id=88570

Reviewed by Ojan Vafai.

Caching covered by existing tests.

RenderLayer::isRootLayer()'s answer will be the same during the RenderLayer's
lifetime as a RenderLayer is tied to a RenderBoxModelObject. This change caches
isRootLayer value in the constructor.

On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
by 100 columns table, it saves about 10% on the paint time during scrolling on
my machine (going from 50ms to 45ms). It would expect all code paths to see some
improvement as checking renderer()->isRenderView() was pretty common.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Added code to cache the result of renderer()->isRenderView() here.

(WebCore::RenderLayer::stackingContext):
(WebCore::isPositionedContainer):
(WebCore::isFixedPositionedContainer):
(WebCore::RenderLayer::enclosingTransformedAncestor):
(WebCore::RenderLayer::clippingRootForPainting):
(WebCore::shouldSuppressPaintingLayer):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::intersectsDamageRect):

rendering/RenderLayer.h:

(WebCore::RenderLayer::isStackingContext):
Updated all the call sites to use isRootLayer() instead of renderer()->isRenderView()
as it is faster.

(WebCore::RenderLayer::isRootLayer):
Added our caching here. Also made m_canSkipRepaintRectsUpdateOnScroll to follow
m_isRootLayer example.

3:12 PM Changeset in webkit [119760] by commit-queue@webkit.org

3 edits
3 adds in trunk

Incorrect border rendering when border radius is above 2px.
https://bugs.webkit.org/show_bug.cgi?id=88046

Source/WebCore:

Fixing findInnerVertex's logic to decide which is the better line
to find an inner vertex, x=center point's x of a rendering box or
y=center point's y of a rendering box.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Simon Fraser.

Test: fast/borders/border-radius-valid-border-clipping.html

rendering/RenderBoxModelObject.cpp:

(WebCore::findInnerVertex):

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Simon Fraser.

fast/borders/border-radius-valid-border-clipping-expected.txt: Added.
fast/borders/border-radius-valid-border-clipping.html: Added.
platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png: Added.

3:08 PM Changeset in webkit [119759] by commit-queue@webkit.org

6 edits
6 adds in trunk

Source/WebCore: Should fire error event for empty 404 script
https://bugs.webkit.org/show_bug.cgi?id=50589

Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
Reviewed by Brady Eidson.

Tests:
http/tests/loading/fire-error-event-empty-404-script.html
http/tests/loading/fire-error-script-no-content-type.html

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): We should check for http status
codes here to stop depending on the response being non-empty.
(WebCore::SubresourceLoader::didReceiveData): Moved the http status check but
avoid messing with multipart responses.
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError): Renamed from
errorLoadingResource for clarity.

loader/SubresourceLoader.h:
loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):
Updated for errorLoadingResource renaming.

LayoutTests: Should fire error event for empty 404 script
https://bugs.webkit.org/show_bug.cgi?id=50589

Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
Reviewed by Brady Eidson.

Based on a test by Ojan Vafai.

http/tests/loading/fire-error-event-empty-404-script-expected.txt: Added.
http/tests/loading/fire-error-event-empty-404-script.html: Added.
http/tests/loading/fire-error-event-script-no-content-type-expected.txt: Added.
http/tests/loading/fire-error-event-script-no-content-type.html: Added.
http/tests/loading/resources/404-with-empty-body-no-content-type.cgi: Added.
http/tests/loading/resources/404-with-empty-body.cgi: Added.
http/tests/resources/network-simulator.php: Fixed to no longer return 404 error

when logging a request.

3:08 PM Changeset in webkit [119758] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Search highlight does not scroll with the content of the page, and find overlay doesn't work, on large-enough window
https://bugs.webkit.org/show_bug.cgi?id=88577
<rdar://problem/11430118>

Reviewed by John Sullivan.

Prevent the page overlay layer from falling into tiled mode.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

3:01 PM Changeset in webkit [119757] by zoltan@webkit.org

2 edits in trunk/Source/WebKit/qt

[Qt] Qt DRT should load external resources - cleanup
https://bugs.webkit.org/show_bug.cgi?id=88568

Make things more straighforward to load external URLs in DRT.

Reviewed by Ryosuke Niwa.

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

2:55 PM Changeset in webkit [119756] by ojan@chromium.org

2 edits in trunk/LayoutTests

fast/js/dfg-double-vote-fuzz.html fails on Chromium release.

platform/chromium/TestExpectations:

2:35 PM Changeset in webkit [119755] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Update PlayBook's User Agent String for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=88543

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

We expect users to upgrade their devices so developers only need the latest UA String.

No tests needed.

inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

2:32 PM Changeset in webkit [119754] by ojan@chromium.org

3 edits in trunk/Tools

Fix recent null pointer error regression in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=88573

Reviewed by Dirk Pranke.

TestResultServer/static-dashboards/builders.js:

(requestBuilderList):

TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

2:32 PM Changeset in webkit [119753] by shawnsingh@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Remove obsolete FIXME comment about a layer sorting bug.
https://bugs.webkit.org/show_bug.cgi?id=88546

Reviewed by James Robinson.

No tests needed, only comment changed. The comment referred to a
potential bug that actually will not occur. The W3C spec on CSS 3d
transforms indicates that layers that do not share the same "3d
rendering context" do not sort together, and our existing code
sorts this way already.

platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):

2:21 PM Changeset in webkit [119752] by abarth@webkit.org

16 edits in trunk

Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=88375

Reviewed by James Robinson.

This symbol no longer exists.

Source/autotools/symbols.filter:

Source/WebCore:

This patch removes Settings::defaultDeviceScaleFactor because it is
redundant with Page::deviceScaleFactor now that we no longer support
target-densitydpi. Page::deviceScaleFactor is the canonical place to
store the device scale factor.

WebCore.exp.in:
page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore):

page/Settings.h:

(Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setDeviceScaleFactor):

Source/WebKit/chromium:

public/WebSettings.h:

(WebKit::WebSettings::setDefaultDeviceScaleFactor):
(WebSettings):

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

src/WebSettingsImpl.cpp:

(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

tests/WebFrameTest.cpp:

(WebKit::TEST_F):

2:11 PM Changeset in webkit [119751] by commit-queue@webkit.org

35 edits in trunk

IndexedDB: Error codes, phase one
https://bugs.webkit.org/show_bug.cgi?id=88459

Patch by Alec Flett <alecflett@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Source/WebCore:

This phase gets rid of the now-deprecated NOT_ALLOWED_ERR and
NON_TRANSIENT_ERR from earlier versions of the spec, and
normalizes the place where TypeError should be thrown so that it's
easier to update when the bindings change.

No new tests: existing tests cover these changes and have been updated.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):

Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::deleteFunction):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):

Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):

Modules/indexeddb/IDBDatabaseException.h:
Modules/indexeddb/IDBDatabaseException.idl:
Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::index):

Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::result):
(WebCore::IDBRequest::errorCode):
(WebCore::IDBRequest::webkitErrorMessage):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

LayoutTests:

storage/indexeddb/basics-expected.txt:
storage/indexeddb/basics-shared-workers-expected.txt:
storage/indexeddb/basics-workers-expected.txt:
storage/indexeddb/create-and-remove-object-store-expected.txt:
storage/indexeddb/cursor-advance-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/database-basics-expected.txt:
storage/indexeddb/deleteIndex-expected.txt:
storage/indexeddb/resources/basics.js:

(test):

storage/indexeddb/resources/create-and-remove-object-store.js:

(testCreateAndRemove):
(tryOnceMore):

storage/indexeddb/resources/cursor-advance.js:

(testBadAdvance.advanceBadly):
(testBadAdvance):

storage/indexeddb/resources/cursor-update.js:

(keyCursor):

storage/indexeddb/resources/database-basics.js:

(testClose):

storage/indexeddb/resources/deleteIndex.js:

(postTwiddling):

storage/indexeddb/resources/transaction-after-close.js:

(firstTransactionComplete):

storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(afterComplete):

storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):

storage/indexeddb/transaction-after-close-expected.txt:
storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
storage/indexeddb/transaction-basics-expected.txt:

1:08 PM Changeset in webkit [119750] by commit-queue@webkit.org

2 edits in trunk/Tools

Add Konrad Piascik to committers.py
https://bugs.webkit.org/show_bug.cgi?id=88560

Unreviewed.

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07

Scripts/webkitpy/common/config/committers.py:

1:07 PM Changeset in webkit [119749] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] features.gypi should have the correct definitions for Android
https://bugs.webkit.org/show_bug.cgi?id=88533

Reviewed by Adam Barth.

Make all features which are enabled on Android but disabled on other platforms,
or are disabled on Android while enabled on other platforms, conditional. This
also means that the selection of code compiled for Android will slightly change.

This change also removes the enable_viewport variable as the value of this is
no longer respected by WebKit - it's enabled by default for all of Chromium.
Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again.

features.gypi:

1:06 PM Changeset in webkit [119748] by tony@chromium.org

2 edits in trunk/Tools

[chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
https://bugs.webkit.org/show_bug.cgi?id=77368

Reviewed by Ojan Vafai.

It doesn't look like we ever get a rect with width or height of 0.
I ran css1, css2.1, fast/forms, and tables without any crashes.

DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:

(webRectToSkIRect): Correctly convert a WebRect to a SkIRect.

12:44 PM Changeset in webkit [119747] by dpranke@chromium.org

3 edits in trunk/Tools

run-webkit-tests --lint-test-files gives an error when run on linux
https://bugs.webkit.org/show_bug.cgi?id=88551

Reviewed by Ojan Vafai.

We weren't mapping the expectations properly for the
google-chrome ports.

Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file):

Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(TestGoogleChromePort.test_path_to_expectations):

12:27 PM Changeset in webkit [119746] by epoger@chromium.org

443 edits
147 copies
88 deletes in trunk/LayoutTests

Unreviewed, rolling out r119737.
http://trac.webkit.org/changeset/119737

see https://bugs.webkit.org/show_bug.cgi?id=88561

css1/basic/class_as_selector-expected.txt: Removed.
css1/basic/containment-expected.txt: Removed.

...

platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt.
platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt.

12:16 PM Changeset in webkit [119745] by ojan@chromium.org

2 edits in trunk/LayoutTests

Hopefully final chromium rebaseline for r119617.

platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:

12:07 PM Changeset in webkit [119744] by danakj@chromium.org

4 edits in trunk/Source

[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
https://bugs.webkit.org/show_bug.cgi?id=88371

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.layersFreeTextures

platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

11:46 AM Changeset in webkit [119743] by peter@chromium.org

3 edits in trunk/Source/WebCore

Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined)
https://bugs.webkit.org/show_bug.cgi?id=88564

Reviewed by Adam Barth.

Where ENABLE(X) mandates that X both has to be defined and evaluates to
true as a lone preprocessor statement, there were two places in the CSS
property and value input files where only was checked whether is has
been defined. This also goes against other #ifdefs in those files.

css/CSSPropertyNames.in:
css/CSSValueKeywords.in:

11:37 AM Changeset in webkit [119742] by fischman@chromium.org

19 edits
3 adds in trunk

Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):

html/HTMLMediaElement.h:

(HTMLMediaElement):

html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::didPassCORSAccessCheck):
(WebCore):

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCORSMode):
(MediaPlayer):

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

public/WebMediaPlayer.h:

(WebMediaPlayer):

src/AssertMatchingEnums.cpp:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
(WebKit):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

http/tests/security/resources/video-cross-origin-allow.php: Added.
http/tests/security/video-cross-origin-readback-expected.txt: Added.
http/tests/security/video-cross-origin-readback.html: Added.
platform/efl/Skipped:
platform/gtk/TestExpectations:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wk2/Skipped:

11:32 AM Changeset in webkit [119741] by senorblanco@chromium.org

1 edit
4 deletes in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Removing expected-to-fail results for now-passing tests.

platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.

11:31 AM Changeset in webkit [119740] by mhahnenberg@apple.com

2 edits in trunk/Source/WebCore

Worker tear-down can re-enter JSC during GC finalization
https://bugs.webkit.org/show_bug.cgi?id=88449

Reviewed by Geoffrey Garen.

No new tests.

This is the first of two patches to fix this issue with Workers.

workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
will be called elsewhere in contextDestroyed().

11:18 AM Changeset in webkit [119739] by jer.noble@apple.com

3 edits
2 adds in trunk

sometimes all slaved videos don't start playing
https://bugs.webkit.org/show_bug.cgi?id=88553

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-controller-time-clamp.html

Some PlatformClock classes will occasionally return times < 0 and will
always return times slightly > duration() when playback has ended. Clamp
the value of currentTime() to the specified [0..duration] range.

html/MediaController.cpp:

(MediaController::currentTime):

LayoutTests:

media/media-controller-time-clamp-expected.txt: Added.
media/media-controller-time-clamp.html: Added.

11:02 AM Changeset in webkit [119738] by ojan@chromium.org

2 edits in trunk/LayoutTests

Mark another test as slow on Chromium Windows.

platform/chromium/TestExpectations:

10:58 AM Changeset in webkit [119737] by epoger@chromium.org

443 edits
88 adds
147 deletes in trunk/LayoutTests

Part 1 of rebaselines for http://crbug.com/131189

Unreviewed rebaselining.

css1/basic/class_as_selector-expected.txt: Added.
css1/basic/containment-expected.txt: Added.

...

platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Removed.
platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Removed.

10:57 AM Changeset in webkit [119736] by Simon Fraser

9 edits in trunk/Source/WebCore

Optimize FrameView::scrollXForFixedPosition() / scrollYForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=88475

Reviewed by Sam Weinig.

FrameView's scrollXForFixedPosition() and scrollYForFixedPosition()
methods were often called together, but they do duplicate work,
including calling into platform widget code which might be slow.

Fix by converting scrollOffsetForFixedPosition() from being a wrapper
that just calls scrollXForFixedPosition() and scrollYForFixedPosition()
to the method that does all the work, calling just once into platform
widget code.

Changed callers to use scrollOffsetForFixedPosition() rather than make
two separate method calls.

Added ScrollView::layoutSize() and visibleSize() methods for
convenience.

Removed FrameView::scrollXForFixedPosition and FrameView::scrollYForFixedPosition
to avoid inefficient callers in future.

No new tests; refactoring only.

page/FrameView.cpp:

(WebCore::fixedPositionScrollOffset):
(WebCore::FrameView::scrollOffsetForFixedPosition):

page/FrameView.h: Removed scrollXForFixedPosition and scrollYForFixedPosition.
platform/ScrollView.cpp:

(WebCore::ScrollView::layoutSize):

platform/ScrollView.h:

(WebCore::ScrollView::visibleSize):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundClipRect):

rendering/RenderLayer.h:

(WebCore::ClipRect::move):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

10:44 AM Changeset in webkit [119735] by reed@google.com

2 edits in trunk/LayoutTests

clean up suppressions around two-point-radial-gradient in skia (fix will come later)
https://bugs.webkit.org/show_bug.cgi?id=88549

Expectations change only.

platform/chromium/TestExpectations:

10:37 AM Changeset in webkit [119734] by ojan@chromium.org

2 edits in trunk/LayoutTests

Update some flaky/slow expectations to better match the bots.

platform/chromium/TestExpectations:

10:02 AM Changeset in webkit [119733] by commit-queue@webkit.org

3 edits
2 adds in trunk

Incorrect rect-based hit-test result for culled-inline elements
https://bugs.webkit.org/show_bug.cgi?id=85849

Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-07
Reviewed by Levi Weintraub.

Source/WebCore:

Modified code which blindly adds culled inlines to rect-based hit-test
results so that it only does so if the child node does not fully cover
the hit-test region.

Test: fast/dom/nodesFromRect-culled-inline.html

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

LayoutTests:

Added tests for rect-based hit-testing for the case when the child of a
culled inline element is in the hit-test result. One of these tests is
expected to fail due to https://bugs.webkit.org/show_bug.cgi?id=88376.

fast/dom/nodesFromRect-culled-inline-expected.txt: Added.
fast/dom/nodesFromRect-culled-inline.html: Added.

9:58 AM Changeset in webkit [119732] by commit-queue@webkit.org

18 edits
3 adds in trunk

Source/WebCore: Make Skia backend honor requests for subpixel-positioned text.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Add subpixel positioning field to FontRenderStyle and rename
subpixel rendering field.

Pass setting to SkPaint in FontPlatformDataHarfBuzz and remove
round() call when computing glyph widths in SimpleFontDataSkia.

Test: platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html

platform/graphics/blackberry/skia/PlatformSupport.cpp:

(WebCore::setFontRenderStyleDefaults):
(WebCore::PlatformSupport::getRenderStyleForStrike):

platform/graphics/chromium/FontRenderStyle.h:

(WebCore::FontRenderStyle::FontRenderStyle):
(WebCore::FontRenderStyle::operator==):
(FontRenderStyle):

platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
(WebCore::FontPlatformData::querySystemForRenderStyle):

platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph):

Source/WebKit/chromium: Add setting to enable subpixel-positioned text on Linux.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Add subpixel positioning field to WebFontRenderStyle and rename
subpixel rendering field. Make similar changes in
WebFontRendering.

Also add global WebFontInfo::setSubpixelPositioning() to turn
subpixel positioning on or off (there's not currently a
well-defined way to configure subpixel positioning via FontConfig).

public/linux/WebFontInfo.h:

(WebFontInfo):

public/linux/WebFontRenderStyle.h:
public/linux/WebFontRendering.h:

(WebFontRendering):

src/linux/WebFontInfo.cpp:

(WebKit):
(WebKit::WebFontInfo::setSubpixelPositioning):
(WebKit::WebFontInfo::renderStyleForStrike):

src/linux/WebFontRenderStyle.cpp:

(WebKit::WebFontRenderStyle::toFontRenderStyle):
(WebKit::WebFontRenderStyle::setDefaults):

src/linux/WebFontRendering.cpp:

(WebKit::WebFontRendering::setSubpixelGlyphs):
(WebKit):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):

Tools: [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/chromium/fonts.conf:

LayoutTests: [chromium] Add test for subpixel positioning.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.png: Added.
platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.txt: Added.
platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html: Added.

9:53 AM Changeset in webkit [119731] by commit-queue@webkit.org

2 edits
9 adds in trunk/LayoutTests

[GTK] Add baselines for new tests
https://bugs.webkit.org/show_bug.cgi?id=88540

Unreviewed gardening. Added baselines for new tests.

Patch by Simon Pena <Simon Pena> on 2012-06-07

platform/gtk/TestExpectations:
platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
platform/gtk/fast/reflections/reflection-with-zoom-expected.png: Added.
platform/gtk/fast/reflections/reflection-with-zoom-expected.txt: Added.
platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
platform/gtk/svg/repaint/text-mask-update-expected.png: Added.
platform/gtk/svg/repaint/text-mask-update-expected.txt: Added.

9:50 AM Changeset in webkit [119730] by beidson@apple.com

5 edits
3 moves in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=88481

Move new test added by r119644 that was only meant for platform/mac into the platform/mac directory:

platform/mac/fast/loader/resources/utf8-encoded.webarchive: Renamed from LayoutTests/fast/loader/resources/utf8-encoded.webarchive.
platform/mac/fast/loader/webarchive-encoding-respected-expected.txt: Renamed from LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt.
platform/mac/fast/loader/webarchive-encoding-respected.html: Renamed from LayoutTests/fast/loader/webarchive-encoding-respected.html.

Also remove it from the TestExpectations files for platforms where it was Skipped:

platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/qt/TestExpectations:

9:05 AM Changeset in webkit [119729] by wingo@igalia.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r119593.

llint/LLIntOfflineAsmConfig.h (OFFLINE_ASM_GLOBAL_LABEL): Fix

uses of "name" to be "label", the macro's parameter. Otherwise we
serialize mentions of the literal symbol "name" into the objcode.
Causes a build error using GNU ld (not gold).

9:03 AM Changeset in webkit [119728] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r119707.
http://trac.webkit.org/changeset/119707
https://bugs.webkit.org/show_bug.cgi?id=88539

Because the original patch with the failing test was rolled
out by 119712 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

platform/qt/Skipped:

8:31 AM Changeset in webkit [119727] by senorblanco@chromium.org

18 edits
1 delete in trunk/LayoutTests

[Chromium] Rebaseline tests after r119591 that enabled imageSmoothingEnabled for patterns
https://bugs.webkit.org/show_bug.cgi?id=88253

Unreviewed; test expectations update.

platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Removed.
platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/chromium-mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
platform/chromium-mac/svg/custom/oversized-pattern-scale-expected.png:
platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png:
platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png:
platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
platform/chromium/TestExpectations:

8:24 AM Changeset in webkit [119726] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/gtk

[GTK] deviceScaleFactor setting is not honored
https://bugs.webkit.org/show_bug.cgi?id=88511

Patch by Simon Pena <Simon Pena> on 2012-06-07
Reviewed by Gustavo Noronha Silva.

Honor the deviceScaleFactor property in the paintWebView
method of the ChromeClientGtk.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

8:09 AM Changeset in webkit [119725] by danakj@chromium.org

4 edits in trunk/Source

[chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
https://bugs.webkit.org/show_bug.cgi?id=88469

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::shouldDrawLayer):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

7:54 AM Changeset in webkit [119724] by mario@webkit.org

2 edits in trunk/LayoutTests

Unreviewed. Unskip passing tests for GTK.

platform/gtk/TestExpectations:

7:46 AM Changeset in webkit [119723] by ahf@0x90.dk

1 edit
1 add in trunk/Source/WebKit2

Add QML API tests for Device Pixel Ratio
https://bugs.webkit.org/show_bug.cgi?id=88531

Reviewed by Kenneth Rohde Christiansen.

This patch adds an initial test case for the QML device pixel ratio
API. The test currently fails and is therefore marked as being
expected to fail. This will be fixed in a separated patch.

UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml: Added.

7:41 AM Changeset in webkit [119722] by loislo@chromium.org

8 edits
4 adds in trunk

Web Inspector: sorting of object fields is broken in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=88532

A recent change to heap profiler has replaced getters with functions.
Function calls were missing in couple places after that change.

Source/WebCore:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html

inspector/profiler/heap-snapshot-summary-sorting-instances.html

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):

LayoutTests:

The following changes were made to the tests:

generateSnapshot now uses pseudo random numbers for object sizes. It allows to test sorting.
Added a test that checks sorting of object instances of a particular class.
Added a test that checks sorting of fields in an object instance.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html

inspector/profiler/heap-snapshot-summary-sorting-instances.html

inspector/profiler/heap-snapshot-summary-sorting-fields-expected.txt: Added.
inspector/profiler/heap-snapshot-summary-sorting-fields.html: Added.
inspector/profiler/heap-snapshot-summary-sorting-instances-expected.txt: Added.
inspector/profiler/heap-snapshot-summary-sorting-instances.html: Added.
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

7:30 AM Changeset in webkit [119721] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] User viewport arguments are not respected
https://bugs.webkit.org/show_bug.cgi?id=88530

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

RIM PR #163767

Fixed by applying the user supplied viewport arguments if the page
specifies default viewport arguments (i.e. the page has no viewport
meta tag).

If the user didn't supply any viewport arguments either, the behaviour
is the same as before the patch, the caller will successfully reset to
default viewport arguments.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

7:19 AM Changeset in webkit [119720] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] WebKit2-EFL does not link in debug mode
https://bugs.webkit.org/show_bug.cgi?id=88518

Unreviewed. Fix WebKit2-EFL linking error in debug mode.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-07

CMakeLists.txt:

7:17 AM Changeset in webkit [119719] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Consider Ctrl+Shift+key as valid zoom change combinations
https://bugs.webkit.org/show_bug.cgi?id=88520

Reviewed by Vsevolod Vlasov.

inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

7:00 AM Changeset in webkit [119718] by commit-queue@webkit.org

10 edits in trunk/Source

[BlackBerry] Allow WebPageCompositor to blend a transparent web page
https://bugs.webkit.org/show_bug.cgi?id=88233

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-07
Reviewed by Rob Buis.

RIM PR #159998

Source/WebCore:

Add a parameter to LayerRenderer::compositeBuffer() indicating whether
the buffer contents are opaque, and set the GL blend mode accordingly.

This is not currently testable using BlackBerry testing infrastructure.

Reviewed internally by Jakob Petsovits.

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeBuffer):

platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

Source/WebKit/blackberry:

Keep track of the web page background color in the compositor so we can
determine whether the contents of the root layer are transparent.

Reviewed internally by Jakob Petsovits.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::compositeContents):

Api/BackingStore_p.h:

(BackingStorePrivate):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackgroundColor):
(WebKit):

Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::backgroundColor):
(WebPageCompositorPrivate):

Api/WebPage_p.h:

(WebPagePrivate):

6:45 AM Changeset in webkit [119717] by loislo@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Clean chromium test expectations.

platform/chromium/TestExpectations:

6:43 AM Changeset in webkit [119716] by kov@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Fix broken build due to missing <SECTION> in GTK-DOC
https://bugs.webkit.org/show_bug.cgi?id=88525

Unreviewed gardening. Added missing <SECTION> tag.

Patch by Simon Pena <Simon Pena> on 2012-06-07

UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

6:21 AM Changeset in webkit [119715] by zandobersek@gmail.com

2 edits in trunk/Tools

[Gtk] Assertions in gtk_widget_draw when acquiring pixel output
https://bugs.webkit.org/show_bug.cgi?id=88060

Reviewed by Martin Robinson.

Spin the main loop before acquiring the pixel content. This ensures things
like late size allocations are finished before calling gtk_widget_draw,
avoiding assertions and subsequent empty pixel results.

DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(createBitmapContextFromWebView):

6:09 AM Changeset in webkit [119714] by commit-queue@webkit.org

4 edits in trunk

Web Inspector: reuse edge_count field of heap snapshot to store retained size
https://bugs.webkit.org/show_bug.cgi?id=88416

The edge_count field is unused after node first edge indexes have been built.
Store node retained size in there instead of allocating an extra array for it.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.retainedSize):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

LayoutTests:

inspector/profiler/heap-snapshot.html:

5:59 AM Changeset in webkit [119713] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add enable credential autofill and enable form autofill feature control in WebSetting
https://bugs.webkit.org/show_bug.cgi?id=88513

Patch by Jonathan Dong <Jonathan Dong> on 2012-06-07
Reviewed by Rob Buis.

RIM PR: #163391
Implemented credential autofill setting and form autofill setting.

Internally reviewed by Leo Yang <leo.yang@torchmobile.com.cn>.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::autofillTextField):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::clearCredentials):
(BlackBerry::WebKit::WebPage::clearAutofillData):
(BlackBerry::WebKit::WebPage::clearNeverRememberSites):

Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isCredentialAutofillEnabled):
(BlackBerry::WebKit::WebSettings::setCredentialAutofillEnabled):
(BlackBerry::WebKit::WebSettings::isFormAutofillEnabled):
(BlackBerry::WebKit::WebSettings::setFormAutofillEnabled):

Api/WebSettings.h:
WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

5:56 AM Changeset in webkit [119712] by loislo@chromium.org

13 edits
3 deletes in trunk

Unreviewed, rolling out r119694.
http://trac.webkit.org/changeset/119694
https://bugs.webkit.org/show_bug.cgi?id=88529

it broke PrerenderBrowserTest.PrerenderHTML5VideoNetwork
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

html/HTMLMediaElement.cpp:
html/HTMLMediaElement.h:

(HTMLMediaElement):

html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

platform/graphics/MediaPlayer.cpp:
platform/graphics/MediaPlayer.h:

(MediaPlayer):

platform/graphics/MediaPlayerPrivate.h:

Source/WebKit/chromium:

public/WebMediaPlayer.h:

(WebMediaPlayer):

src/AssertMatchingEnums.cpp:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

http/tests/security/resources/video-cross-origin-allow.php: Removed.
http/tests/security/video-cross-origin-readback-expected.txt: Removed.
http/tests/security/video-cross-origin-readback.html: Removed.

5:22 AM Changeset in webkit [119711] by shinyak@chromium.org

3 edits
2 adds in trunk

Delete a contenteditable element having a Shadow DOM causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=86345

Reviewed by Ryosuke Niwa.

Source/WebCore:

In VisibleSelection::validate(), m_start.downstream() or m_end.upstream() might cross
editing boundaries. So we adjust selection after calling them again.

Test: editing/shadow/select-contenteditable-shadowhost.html

editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::validate):

LayoutTests:

editing/shadow/select-contenteditable-shadowhost-expected.txt: Added.
editing/shadow/select-contenteditable-shadowhost.html: Added.

5:11 AM Changeset in webkit [119710] by kenneth@webkit.org

2 edits in trunk/Tools

[Qt] Improve the visual of the viewport info box
https://bugs.webkit.org/show_bug.cgi?id=88410

Reviewed by Tor Arne Vestbø.

Improve the visual and make it possible to see the content more easy.

MiniBrowser/qt/qml/ViewportInfoItem.qml:

5:08 AM Changeset in webkit [119709] by kinuko@chromium.org

3 edits in trunk/LayoutTests

Unreviewed rebaseline for r115582.

http/tests/security/filesystem-iframe-from-remote-expected.txt:
platform/chromium/TestExpectations:

4:58 AM Changeset in webkit [119708] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

No new line at the end for SVGCSSPropertyNames.in causes compilation warning
https://bugs.webkit.org/show_bug.cgi?id=88503

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-07
Reviewed by Ryosuke Niwa.

Added new line at the end of the file.

No new tests required.

css/SVGCSSPropertyNames.in:

4:57 AM Changeset in webkit [119707] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Gardening. Skip failing new test.
https://bugs.webkit.org/show_bug.cgi?id=88523

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-07
Reviewed by Csaba Osztrogonác.

platform/qt/Skipped: Skip http/tests/security/video-cross-origin-readback.html.

4:49 AM Changeset in webkit [119706] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsContext.h
https://bugs.webkit.org/show_bug.cgi?id=88305

Reviewed by Simon Hausmann.

platform/graphics/GraphicsContext.h: Buildfix.

(GraphicsContext):

4:45 AM Changeset in webkit [119705] by shinyak@chromium.org

4 edits in trunk/Source/WebCore

Incorrect data retrieved in calls to get selection data in client->textWillBeReplaced from CharacterData::setDataAndUpdate
https://bugs.webkit.org/show_bug.cgi?id=66120

Reviewed by Ryosuke Niwa.

Since FrameSelection::textWillBeReplaced was called before replacing text, updated Selection became
temporarily invalid. The invalid selection was set to updateSelection(), so client will have
invalid selection.

This patch makes calling updateSelection() after updating selection.

No new tests, it's too hard to create a correct test cases in DRT.

dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

editing/FrameSelection.cpp:

(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWasReplaced):

editing/FrameSelection.h:

(FrameSelection):

4:39 AM Changeset in webkit [119704] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

[Qt][Win] Fix linking WTF with ICU
https://bugs.webkit.org/show_bug.cgi?id=88302

Reviewed by Simon Hausmann.

WTF.pri: Use proper library names on win32 platforms.

4:25 AM Changeset in webkit [119703] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed Skipped list cleanup. Remove disabled/passing tests, add bug reports.

platform/qt-arm/Skipped:
platform/qt/Skipped:

4:06 AM Changeset in webkit [119702] by commit-queue@webkit.org

6 edits in trunk

FileAPI: If type consists of non-ASCII characters in Blob constructor, it should throw a SyntaxError.
https://bugs.webkit.org/show_bug.cgi?id=88411

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Kentaro Hara.

Source/WebCore:

From spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
If type consists of any non-ASCII characters, throw a SyntaxError and
return from this algorithm.
This patch checks the String is ASCii or not, if not, throw SyntaxError.

Test: fast/files/blob-constructor.html

bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

From Spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
If type consists of any non-ASCII characters, throw a SyntaxError and
return from this algorithm.

fast/files/blob-constructor-expected.txt:
fast/files/script-tests/blob-constructor.js:

3:36 AM Changeset in webkit [119701] by commit-queue@webkit.org

3 edits
2 adds in trunk

InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets
https://bugs.webkit.org/show_bug.cgi?id=84597

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-06-07
Reviewed by Ryosuke Niwa.

Source/WebCore:

Comparison between start and end VisiblePositions will fail when a position inside
a paragraph is compared with one at the start of the paragraph.

This fix thus converts the end VisiblePosition (which could be inside the paragraph)
to the start of the paragraph thereby enabling a proper comparison of start and end
positions.

Test: editing/execCommand/remove-list-from-multi-list-items.html

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::selectionHasListOfType):

LayoutTests:

This test verifies removing of an (un)ordered list on a selection consisting of multiple
list items (paragraphs) when the end point of the selection points to the end of the last
list item; followed by another paragraph not part of the selection/list.

editing/execCommand/remove-list-from-multi-list-items-expected.txt: Added.
editing/execCommand/remove-list-from-multi-list-items.html: Added.

3:16 AM Changeset in webkit [119700] by Carlos Garcia Campos

11 edits
5 adds in trunk/Source/WebKit2

[GTK] Add API to register custom URI schemes to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=84133

Reviewed by Martin Robinson.

GNUmakefile.list.am: Add new files to compilation.
UIProcess/API/gtk/WebKitPrivate.h:
UIProcess/API/gtk/WebKitRequestManagerClient.cpp: Added.

(didReceiveURIRequest): Callback emitted by the C API when a
request for a custom URI scheme has been received. Call
webkitWebContextReceivedURIRequest() to handle the request.
(didFailToLoadURIRequest): Callback emitted by the C API when a
request for a custom URI scheme failed to load. Call
webkitWebContextDidFailToLoadURIRequest() to noitfy the web
context.
(attachRequestManagerClientToContext): Initialize the
WKSoupRequestManagerClient.

UIProcess/API/gtk/WebKitRequestManagerClient.h: Added.
UIProcess/API/gtk/WebKitURISchemeRequest.cpp: Added.

(webkit_uri_scheme_request_init):
(webkitURISchemeRequestFinalize):
(webkit_uri_scheme_request_class_init):
(webkitURISchemeRequestCreate): Create a new
WebKitURISchemeRequest for the given URI and request identifier.
(webkitURISchemeRequestGetID): Return the request identifier.
(webkitURISchemeRequestCancel): Cancel the request operation.
(webkit_uri_scheme_request_get_scheme): Return the scheme of the
request.
(webkit_uri_scheme_request_get_uri): Return the full URI of the
request.
(webkit_uri_scheme_request_get_path): Return the path of the URI.
(webkitURISchemeRequestReadCallback): Read callback emitted when
reading the contents of the input stream.
(webkit_uri_scheme_request_finish): Finish the request by reading
the contents of the input stream and sending the data to the
WebProcess.

UIProcess/API/gtk/WebKitURISchemeRequest.h: Added.
UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h: Added.
UIProcess/API/gtk/WebKitWebContext.cpp:

(WebKitURISchemeHandler::WebKitURISchemeHandler): Helper struct to
save callback and user data of registered URI schemes.
(createDefaultWebContext): Initialize the SoupRequestManager.
(webkit_web_context_register_uri_scheme): Public API to register a
custom URI scheme providing a callback that will be called to
handle requests for that URI scheme.
(webkitWebContextGetRequestManager): Helper private method to
return the SoupRequestManager.
(webkitWebContextReceivedURIRequest): Get the
WebKitURISchemeHandler for the given request identifier and call
the callback. Save the request in the request map.
(webkitWebContextDidFailToLoadURIRequest): Cancel the ongoing
request.
(webkitWebContextDidFinishURIRequest): Remove the request from the
map.

UIProcess/API/gtk/WebKitWebContext.h:
UIProcess/API/gtk/WebKitWebContextPrivate.h:
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add

WebKitURISchemeRequest section.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_uri_scheme_request_get_type.

UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextURIScheme):
(beforeAll):

UIProcess/API/gtk/webkit2.h: Include WebKitURISchemeRequest.h.

2:47 AM Changeset in webkit [119699] by yosin@chromium.org

3 edits in trunk/LayoutTests

[Forms] Improve test coverage of input-number-size.html
https://bugs.webkit.org/show_bug.cgi?id=88489

Reviewed by Kent Tamura.

This patch improves test coverage for NumberInputType::sizeShouldIncludeDecoration()
for preparation of introducing decimal arithmetic.

fast/forms/number/input-number-size-expected.txt: Updated for a new test case.
fast/forms/number/input-number-size.html: Added a test case.

2:42 AM Changeset in webkit [119698] by commit-queue@webkit.org

16 edits
3 deletes in trunk

[FileAPI] FileReader should throw an InvalidStateError exception when readyState is LOADING
https://bugs.webkit.org/show_bug.cgi?id=88212

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Jian Li.

Source/WebCore:

From Spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR
when the readyState is LOADING.
Also delete OperationNotAllowedException related code, because it is not longer needed.

Tests: fast/files/read-file-async.html

fast/files/workers/worker-read-file-async.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/DOMExceptions.in:
fileapi/FileReader.cpp:

(WebCore::FileReader::readInternal): Changed it to throw INVALID_STATE_ERR.

fileapi/FileReader.idl: Changed it to raise DOMException for all read methods.
fileapi/OperationNotAllowedException.cpp: Removed.
fileapi/OperationNotAllowedException.h: Removed.
fileapi/OperationNotAllowedException.idl: Removed.

LayoutTests:

From spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR.

fast/files/read-file-async-expected.txt:
fast/files/workers/worker-read-file-async-expected.txt:

2:38 AM Changeset in webkit [119697] by abecsi@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] setPageItemRectVisible() is not guarded by ViewportUpdateDeferrer at scaleAnimationValueChanged()
https://bugs.webkit.org/show_bug.cgi?id=87954

Reviewed by Kenneth Rohde Christiansen.

Resetting the end value, the easing curve or the duration of the scale animation triggers
a recalculation of the animation interval. This might change the current value of the
animated property.
Since guarding of setPageItemRectVisible() relies on animation state change we have to
make sure we only act on animation value changes if the animation is in active state.

UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::QtViewportHandler):
(WebKit::QtViewportHandler::animatePageItemRectVisible):
(WebKit::QtViewportHandler::scaleAnimationValueChanged):

2:26 AM Changeset in webkit [119696] by loislo@chromium.org

4 edits in trunk/Source

Unreviewed, rolling out r119689.
http://trac.webkit.org/changeset/119689
https://bugs.webkit.org/show_bug.cgi?id=88516

it broke didDrawNotCalledOnScissoredLayer webkit_unit_test
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

tests/CCLayerTreeHostImplTest.cpp:

2:11 AM Changeset in webkit [119695] by Carlos Garcia Campos

10 edits in trunk/Source/WebKit2

[SOUP] WebSoupRequestManager should handle loading errors and zero-length replies
https://bugs.webkit.org/show_bug.cgi?id=88087

Reviewed by Martin Robinson.

UIProcess/API/C/soup/WKSoupRequestManager.h:
UIProcess/soup/WebSoupRequestManagerClient.cpp:

(WebKit::WebSoupRequestManagerClient::didFailToLoadURIRequest):
Call didFailToLoadURIRequest in the client if present.

UIProcess/soup/WebSoupRequestManagerClient.h:
UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
Initialize m_loadFailed.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
Don't send more data to the web process if the resource failed to
load.
(WebKit::WebSoupRequestManagerProxy::didFailToLoadURIRequest): Set
m_loadFailed and notifiy the client calling didFailToLoadURIRequest.

UIProcess/soup/WebSoupRequestManagerProxy.h:
UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Add

DidFailToLoadURIRequest message.

WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync): Pass the cancellable to the
WebSoupRequestManager.

WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData): Helper
struct to save requests.
(WebSoupRequestAsyncData): Add a weak pointer to invalidate the
request when it's destroyed before the operation has finished.
(WebKit::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
Remove the weak pointer.
(WebKit::WebSoupRequestAsyncData::requestFailed): Return whther
the request failed.
(WebKit::WebSoupRequestAsyncData::releaseResult): Return the
result and clear the pointer.
(WebKit::WebSoupRequestManager::didHandleURIRequest): Create and
empty memory stream for zero-length replies instead of creating an
error.
(WebKit::WebSoupRequestManager::didReceiveURIRequestData): If the
request failed and more data expected from the UI process, send a
message to the UI process to notify that the resource load failed.
(WebKit::WebSoupRequestManager::send): Save request information in
the request map.

WebProcess/soup/WebSoupRequestManager.h:

1:48 AM Changeset in webkit [119694] by fischman@chromium.org

12 edits
3 adds in trunk

Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):

html/HTMLMediaElement.h:

(HTMLMediaElement):

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCORSMode):

Source/WebKit/chromium:

public/WebMediaPlayer.h:

(WebMediaPlayer):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):

1:28 AM Changeset in webkit [119693] by hbono@chromium.org

5 edits in trunk

Use light gray for grammar markers on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=88398

Reviewed by Ryosuke Niwa.

This change changes the color of grammar markers from dark gray to light gray
and rebaselines a couple of pixel tests affected by this change.

Source/WebCore:

No new tests because it changes the marker color of an existing test 'grammar-markers.html'.

platform/graphics/skia/GraphicsContextSkia.cpp: Change dark gray to light gray.

LayoutTests:

platform/chromium-linux/editing/spelling/grammar-markers-expected.png:
platform/chromium-win/editing/spelling/grammar-markers-expected.png:

12:56 AM Changeset in webkit [119692] by yosin@chromium.org

5 edits in trunk/Source

Source/WebCore: [Platform] Introduce conversion from/to Deciaml to/from double
https://bugs.webkit.org/show_bug.cgi?id=88480

Reviewed by Kent Tamura.

This patch added functions for Decimal/Double conversion and isInfinity
for reducing patch size of introducing Decimal arithmetic, bug 88383.

Tests: WebKit/chromium/tests/DecimalTest.cpp

platform/Decimal.cpp:

(WebCore::Decimal::fromDouble): Added.
(WebCore::Decimal::toDouble): Added.

platform/Decimal.h:

(WebCore::Decimal::EncodedData::isInfinity): Added for isinf()
(WebCore::Decimal::isInfinity): Added.

Source/WebKit/chromium: [Platform] Introduce conversion from/to Deciaml to/from double and helper functions
https://bugs.webkit.org/show_bug.cgi?id=88480

Reviewed by Kent Tamura.

This patch added tests for Decimal::fromDouble, isInfinity, toDouble.

tests/DecimalTest.cpp:

(TEST_F):

12:45 AM Changeset in webkit [119691] by fischman@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed