⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 11, 2012:

11:24 PM Changeset in webkit [120044] by thakis@chromium.org
  • 69 edits in trunk/Source

Remove unused member variables found by clang's -Wunused-private-field
​https://bugs.webkit.org/show_bug.cgi?id=88812

Reviewed by Anders Carlsson.

Source/WebCore:

Change a few |class|s that were used only to pin down the size of
existing classes to |struct|, so that clang doesn't warn about these
memvars.

No intended behavior change.

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioParamTimeline.h:

(AudioParamTimeline):

  • accessibility/AccessibilityScrollbar.h:

(AccessibilityScrollbar):

  • bindings/v8/ScriptScope.cpp:

(WebCore::ScriptScope::ScriptScope):

  • bindings/v8/ScriptScope.h:

(ScriptScope):

  • css/CSSValue.cpp:
  • css/StylePropertySet.cpp:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::DeviceOrientationController):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):

  • editing/ReplaceSelectionCommand.cpp:

(ReplacementFragment):
(WebCore::ReplacementFragment::ReplacementFragment):

  • editing/TextIterator.cpp:

(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):

  • editing/TextIterator.h:

(SimplifiedBackwardsTextIterator):
(BackwardsCharacterIterator):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):

  • html/shadow/MediaControlElements.h:

(MediaControlFullscreenButtonElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):

  • html/track/LoadableTextTrack.h:

(LoadableTextTrack):

  • inspector/CodeGeneratorInspector.py:

(Generator.go):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::NotificationController):

  • notifications/NotificationController.h:

(NotificationController):

  • page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::CompositeAnimation):
(CompositeAnimation):

  • platform/Length.cpp:
  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

  • platform/audio/ReverbConvolver.h:

(ReverbConvolver):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • platform/audio/ReverbConvolverStage.h:

(ReverbConvolverStage):

  • platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(JPEGImageReader):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::TreeIterator::next):

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::TextCodecICU):

  • platform/text/TextCodecICU.h:

(TextCodecICU):

  • rendering/InlineBox.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderText.cpp:
  • rendering/style/KeyframeList.h:

(WebCore::KeyframeList::KeyframeList):
(KeyframeList):

  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::RenderSVGTextPath):

  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/SVGInlineTextBox.cpp:
  • svg/SVGPathByteStreamSource.cpp:
  • svg/SVGPathByteStreamSource.h:
  • svg/SVGPathTraversalStateBuilder.cpp:

(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):

  • svg/SVGPathTraversalStateBuilder.h:

(SVGPathTraversalStateBuilder):

  • xml/XSLStyleSheet.h:

Source/WebKit/chromium:

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

  • src/AudioDestinationChromium.h:

(AudioDestinationChromium):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

  • src/WebFrameImpl.cpp:

(ChromePluginPrintContext):

  • src/WebInputEvent.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

  • src/WorkerAsyncFileWriterChromium.cpp:

(WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium):

  • src/WorkerAsyncFileWriterChromium.h:

(WorkerAsyncFileWriterChromium):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible):
(CCLayerTreeHostTestSetVisible):

11:22 PM Changeset in webkit [120043] by dominicc@chromium.org
  • 30 edits
    1 copy
    2 adds
    5 deletes in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline gradients tests

r120033 added IMAGE failures for bunch of gradient tests that will
need rebaselining as a result of that change. This is that
rebaseline.

(File list elided because it is too long.)

11:17 PM Changeset in webkit [120042] by kinuko@chromium.org
  • 3 edits
    2 adds in trunk

XHR returns size==0 Blob
​https://bugs.webkit.org/show_bug.cgi?id=88750

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Response Blob's .size field must have the correct response size.

Test: http/tests/xmlhttprequest/response-blob-size.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseBlob):

LayoutTests:

  • http/tests/xmlhttprequest/response-blob-size-expected.txt: Added.
  • http/tests/xmlhttprequest/response-blob-size.html: Added.
11:03 PM Changeset in webkit [120041] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[CMAKE][WK2] Make WebProcess target name more clear.
​https://bugs.webkit.org/show_bug.cgi?id=88767

Reviewed by Ryosuke Niwa.

  • CMakeLists.txt: Change WebProcess_NAME to WebProcess_EXECUTABLE_NAME.
10:40 PM Changeset in webkit [120040] by commit-queue@webkit.org
  • 10 edits in trunk

Introduce an Enclosure Element for Chromium video controls.
​https://bugs.webkit.org/show_bug.cgi?id=87683

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-11
Reviewed by Eric Carlson.

Source/WebCore:

Updated tests.

The Chrome video controls are receiving a visual update. A new enclosure div is required
to provide for a offset space from the video's boundaries. The visual update itself is in
a separate patch.

  • css/mediaControlsChromium.css:

(video::-webkit-media-controls-enclosure):
Introduce CSS for enclosure div so it doesn't show yet.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
Definition of the new enclosure element.
(WebCore::MediaControlChromiumEnclosureElement::create):
Definition of a create operator for the new enclosure element.
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
Definition of the shadowPseudoId of -webkit-media-controls-enclosure for the enclosure div.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Initialize member element for enclosure div.
(WebCore::MediaControlRootElementChromium::create):
Instantiate enclosure div and add into DOM between controls and panel elements.
(WebCore::MediaControlRootElementChromium::setMediaController):
Set media controller for enclosure div.
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
Insert text track display container to enclosure rather than panel.

  • html/shadow/MediaControlRootElementChromium.h:

(WebCore):
(MediaControlChromiumEnclosureElement):
(WebCore::MediaControlChromiumEnclosureElement::setMediaController):
(WebCore::MediaControlChromiumEnclosureElement::mediaController):
(WebCore::MediaControlChromiumEnclosureElement::isMediaControlElement):
Add declaration of the new enclosure element and its member functions.
(MediaControlRootElementChromium):
Add member variable to controls root element to hold the enclosure element.

LayoutTests:

Change fullscreen/video-controls-override.html, media/media-controls-invalid-url.html and
media/track/track-cue-rendering-snap-to-lines-not-set.html to deal with the new enclosure
div in Chromium controls and use the mediaControlsElement() helper function to find elements
inside the controls.
Fail video controls tests in test expectations.

  • fullscreen/video-controls-override-expected.txt: Updated.
  • fullscreen/video-controls-override.html: Use mediaControlsElement helper function.
  • media/media-controls-invalid-url.html: Use mediaControlsElement helper function.
  • media/track/track-cue-rendering-snap-to-lines-not-set.html: Height is provided by enclosure element.
  • platform/chromium/TestExpectations: Fail video controls tests.
10:32 PM Changeset in webkit [120039] by ojan@chromium.org
  • 3 edits in trunk/Tools

Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
​https://bugs.webkit.org/show_bug.cgi?id=88836

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
9:23 PM Changeset in webkit [120038] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Expectations for track-cues-cuechange.html
​https://bugs.webkit.org/show_bug.cgi?id=88833

media/track/track-cues-cuechange.html is timing out flakily like
some other media tests noted in bug 88833.

  • platform/chromium/TestExpectations:
9:10 PM Changeset in webkit [120037] by commit-queue@webkit.org
  • 5 edits in trunk

WebKit doesn't allow replacing the document element with a DocumentFragment containing one element
​https://bugs.webkit.org/show_bug.cgi?id=88681

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-06-11
Reviewed by Ojan Vafai.

Source/WebCore:

Fix bug where replacing an immediate child of a Document with a DocumentFragment
would throw a HIERARCHY_REQUEST_ERR instead of replacing the node as required by DOM4.
​http://www.w3.org/TR/domcore/#mutation-algorithms

  • dom/Document.cpp:

(WebCore::Document::canReplaceChild):

When the newChild was a DocumentFragment we incorrectly
iterated over the document's children twice instead of the
fragment when counting the total number of elements and
doctypes to enfoce that there's only one of each.

LayoutTests:

Re-enables a bunch of disabled tests that are long since fixed and rewrites
the tests to use a more modern js-test-pre.js style.
​https://bugs.webkit.org/show_bug.cgi?id=12751

  • fast/dom/Document/replace-child-expected.txt:
  • fast/dom/Document/replace-child.html:
8:46 PM Changeset in webkit [120036] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
​https://bugs.webkit.org/show_bug.cgi?id=88773

Reviewed by Rob Buis.

Handling notifyDataReceived event even if there is no data inside.
This event was critical because it gives downloadFilterStream a chance
to follow up NetworkStream close event, and it also make pluginView in
FrameLoaderBlackBerry return normal logic.

RIM PR# 164563

Reviewed internally by Leo Yang.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyDataReceived):

8:44 PM Changeset in webkit [120035] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Wrong mimetype for empty file link
​https://bugs.webkit.org/show_bug.cgi?id=88642

Reviewed by Rob Buis.

RIM PR# 164164

For empty file link, we shouldn't give "application/octet-stream"
which will lead to download.

Reviewed internally by Charles Wei.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

8:21 PM Changeset in webkit [120034] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update test expectations with bugs for media test timeouts

  • platform/chromium/TestExpectations:
8:04 PM Changeset in webkit [120033] by commit-queue@webkit.org
  • 4 edits in trunk

GeneratorGeneratedImage should cache images for the non-tiled case
​https://bugs.webkit.org/show_bug.cgi?id=87094

Patch by Jin Yang <​jin.a.yang@intel.com> on 2012-06-11
Reviewed by Simon Fraser.

Source/WebCore:

We cache the generated image if generator is not changed. By compared
with generating image on the fly, it will lose a little pixel precision
and several layout tests should be rebaselined. With this patch, the IE test
drive benchmark "Bayou" can gain about 50%.

No new tests. Performance optimization.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

LayoutTests:

Update expectations: added failures for baselines to come.

  • platform/chromium/TestExpectations:
8:04 PM Changeset in webkit [120032] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Remove CMakeCache.txt before building
​https://bugs.webkit.org/show_bug.cgi?id=88717

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11
Reviewed by Antonio Gomes.

Remove CMake cache file before every build to avoid using outdated
build flags when new features get enabled. This will avoid unexpected
failures on the bots due to outdated build flags.

  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

8:02 PM Changeset in webkit [120031] by scheib@chromium.org
  • 15 edits in trunk

Add new Pointer Lock spec attribute webkitPointerLockElement.
​https://bugs.webkit.org/show_bug.cgi?id=88799

Source/WebCore:

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockElementEnabled):

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::webkitPointerLockElement):

  • dom/Document.h:

(Document):

  • dom/Document.idl:
  • page/PointerLockController.h:

(WebCore::PointerLockController::element):

Tools:

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.

WebViewHost logic required modification to correctly repond to
a lock, unlock, pointerLockElement call series. Specifically,
unlocking must be queued after a lock command is issued always
as the lock state may not be set yet with a lock request in flight.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
(WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.

LayoutTests:

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.

Reviewed by Dimitri Glazkov.

  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
7:51 PM Changeset in webkit [120030] by scheib@chromium.org
  • 7 edits in trunk/Source

Consolidate Pointer Lock runtime enabled flags to just one.
​https://bugs.webkit.org/show_bug.cgi?id=88810

Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):

  • dom/MouseEvent.idl:
  • page/Navigator.idl:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

7:21 PM Changeset in webkit [120029] by alexis.menard@openbossa.org
  • 26 edits in trunk

[CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
​https://bugs.webkit.org/show_bug.cgi?id=88804

Reviewed by Tony Chang.

Protect box-decoration-break behind a feature flag enabled by default.

.:

  • configure.ac:

Source/WebCore:

No new tests : no behavior change here.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

  • rendering/style/StyleBoxData.h:

(StyleBoxData):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
7:05 PM Changeset in webkit [120028] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: http/tests/xmlhttprequest/origin-exact-matching.html is timing out on XP about half the time

  • platform/chromium/TestExpectations:
6:48 PM Changeset in webkit [120027] by jchaffraix@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed expected result update after r120017.

  • platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.txt:

Rebaselined gtk.

  • platform/efl/Skipped:
  • platform/qt/Skipped:

Skipped the test with some explanation on those platforms as I couldn't get
the new baseline.

6:42 PM Changeset in webkit [120026] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected results for this test after r120017.

  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
6:12 PM Changeset in webkit [120025] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added http/tests/security/mixedContent/blob-url-in-iframe.html back to the Mac skip list, as
it is still failing intermittently. <​http://webkit.org/b/88736> will track this.

  • platform/mac/Skipped:
6:09 PM FeatureFlags edited by tkent@chromium.org
Add CSS_IMAGE_RESOLUTION (diff)
5:58 PM Changeset in webkit [120024] by gyuyoung.kim@samsung.com
  • 7 edits in trunk

[CMAKE][EFL] Remove duplicated executable output path
​https://bugs.webkit.org/show_bug.cgi?id=88765

Reviewed by Daniel Bates.

CMake files for EFL port have redefined executable output path. However, EFL port doesn't
need to define again because it is already defined in top-level CMake file.

Source/JavaScriptCore:

  • shell/CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
5:39 PM Changeset in webkit [120023] by jamesr@google.com
  • 11 edits
    1 copy in trunk/Source

[chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer
​https://bugs.webkit.org/show_bug.cgi?id=86273

Reviewed by Adrienne Walker.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebExternalTextureLayer.h:

(WebKit):
(WebExternalTextureLayer):

  • chromium/public/WebExternalTextureLayerClient.h: Copied from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.

(WebKit):
(WebTextureUpdater):
(WebKit::WebTextureUpdater::~WebTextureUpdater):
(WebExternalTextureLayerClient):
(WebKit::WebExternalTextureLayerClient::~WebExternalTextureLayerClient):

Source/WebCore:

This converts more WebCore code over to using public APIs instead of internal compositor layer types.

Refactor only, no change in behavior thus no new tests.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):
(WebCore::TextureLayerChromium::update):

  • platform/graphics/chromium/TextureLayerChromium.h:

(WebKit):
(TextureLayerChromiumClient):

Source/WebKit/chromium:

  • src/WebExternalTextureLayer.cpp:

(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):

5:32 PM Changeset in webkit [120022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Autofill feature implementation for BlackBerry porting
​https://bugs.webkit.org/show_bug.cgi?id=85577

Patch by Jonathan Dong <Jonathan Dong> on 2012-06-11
Reviewed by Rob Buis.

Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
is same as the procedure in dispatchWillSendSubmitEvent.
Some sites will redirect to other url in its login process, which will cause the
user get notified to save credentials for this provisional redirecting url if we
put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
sure we only save the autofill data before the submit event is fired.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):

5:29 PM Changeset in webkit [120021] by andersca@apple.com
  • 26 edits
    1 copy
    1 add in trunk

Pass the right color space over to the web process so we can set it on our CA context
​https://bugs.webkit.org/show_bug.cgi?id=88819
<rdar://problem/11629050>

Reviewed by John Sullivan.

Source/WebKit2:

  • Platform/mac/LayerHostingContext.h:

(LayerHostingContext):

  • Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
Use a single constructor and explicitly set up the parameters of the constructed object.

(WebKit::LayerHostingContext::setColorSpace):
(WebKit::LayerHostingContext::colorSpace):
Add getter and setter.

  • Scripts/webkit2/messages.py:

(struct_or_class):
WebKit::ColorSpaceData is a struct.

  • Shared/WebPageCreationParameters.cpp:

Encode and decode the color space parameter.

  • Shared/WebPageCreationParameters.h:

Add the color space.

  • Shared/mac/ColorSpaceData.h: Added.
  • Shared/mac/ColorSpaceData.mm: Added.

Add a new class that represents a color space that can be sent over the wire.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::colorSpace):
Call through to the WKView.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidChangeBackingProperties:]):
Fix whitespace.

(-[WKView viewDidChangeBackingProperties]):
Check if our new color space is different from the current one and null the current one out if that is the case,
it will be reinitialized by the next call to -[WKView _colorSpace].

(-[WKView _colorSpace:]):
Compute the color space. If we're not in a window we'll get the main screen's color space.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::colorSpaceDidChange):
Add empty stub.

  • UIProcess/PageClient.h:

Add colorSpace getter.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
Initialize the color space.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::colorSpaceDidChange):
Send the new color space over to the web process.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::colorSpace):
Call through to the page client.

  • WebKit2.xcodeproj/project.pbxproj:

Add ColorSpaceData.h and ColorSpaceData.mm.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:

Add SetColorSpace message.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Set the color space from the creation parameters.

(WebKit::TiledCoreAnimationDrawingArea::setColorSpace):
Set the color space on the layer hosting context.

(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext):
Make sure we apply the color space from the previous layer hosting context if one exists.

WebKitLibraries:

Add WKCAContextSetColorSpace and WKCAContextGetColorSpace.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:02 PM Changeset in webkit [120020] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Seek calls are being unnecessarily delayed
​https://bugs.webkit.org/show_bug.cgi?id=88732

Patch by Max Feil <​mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.

There is a problem with the way the m_userDrivenSeekTimer is
implemented. When MediaPlayerPrivate::seek() is called, there
is always a 100ms delay even if the timer is not running. The
timer is supposed to space out (i.e. throttle) repeated seeks
that come in too soon after a previous seek, but currently it
is slowing down even single seeks and seeks that come in with
adequate delay after a previous seek. I fixed this in my patch
by improving the way the timer fired function is called.

A note on the new m_lastSeekTimePending flag: This flag is
needed so that userDrivenSeekTimerFired() knows whether or not
to perform the seek. The only case where this flag will not be
set is if no MediaPlayerPrivate::seek() call came in while the
timer was active, in which case it's important to do nothing.
I could encode this flag's information into the m_lastSeekTime
float, for example by initializing it and resetting it to NAN
and using isnan(). But I feel that using a separate bool is a
more portable approach.

No new tests. I would like to propose not including a layout test
with this fix. Doing timing tests for 100ms delays is tricky
from Javascript, and I don't think the benefit of such a test
outweighs the extra time it would take to develop one. The test
would also be a problem to maintain as it may give different
results over different runs and across different target hardware.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

4:48 PM Changeset in webkit [120019] by ojan@chromium.org
  • 4 edits in trunk/Tools

Don't consider show warnings in the garden-o-matic UI for non-layout test failures
​https://bugs.webkit.org/show_bug.cgi?id=88816

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:

Expose a way to clear AsynchronousCaches.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:

Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.

4:18 PM Changeset in webkit [120018] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[BlackBerry] Unexpected repeats of short media
​https://bugs.webkit.org/show_bug.cgi?id=88733

Patch by Max Feil <​mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.

Source/WebCore:

The m_userDrivenSeekTimer is causing unwanted repeats of short
media such as sound effects because it is causing the current
time to not reflect that the media has finished playing.
This problem only affects media whose duration is close to
or less than the SeekSubmissionDelay, which is currently
set to 100ms. My fix is to ignore the userDrivenSeekTimer in
MediaPlayerPrivate::currentTime() if the duration of the media
is within twice the SeekSubmissionDelay. Seek drag smoothness
is a non-issue for such short media.

Test: platform/blackberry/media/short-media-repeats-correctly.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

Test for problem where short media repeats unintentionally.

  • media/content/short.wav: Added.
  • platform/blackberry/media/short-media-repeats-correctly-expected.txt: Added.
  • platform/blackberry/media/short-media-repeats-correctly.html: Added.
4:14 PM Changeset in webkit [120017] by jchaffraix@webkit.org
  • 3 edits
    8 adds in trunk

Account for margin after when laying out <legend> element
​https://bugs.webkit.org/show_bug.cgi?id=35981

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/forms/legend-after-margin-horizontal-writing-mode.html

fast/forms/legend-after-margin-vertical-writing-mode.html
fast/forms/legend-after-margin-with-before-border-horizontal-mode.html
fast/forms/legend-small-after-margin-before-border-horizontal-mode.html

The existing code would ignore margin after when layouting out the <legend>. This
change only adds the code to handle the margin after, the margin before is still
ignored as it's not obvious how it should be working.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutSpecialExcludedChild):
Split the code in 2 code paths to reflect how we position and size. Those are covered by the
tests above.

LayoutTests:

  • fast/forms/legend-after-margin-horizontal-writing-mode-expected.html: Added.
  • fast/forms/legend-after-margin-horizontal-writing-mode.html: Added.
  • fast/forms/legend-after-margin-vertical-writing-mode-expected.html: Added.
  • fast/forms/legend-after-margin-vertical-writing-mode.html: Added.
  • fast/forms/legend-after-margin-with-before-border-horizontal-mode-expected.html: Added.
  • fast/forms/legend-after-margin-with-before-border-horizontal-mode.html: Added.
  • fast/forms/legend-small-after-margin-before-border-horizontal-mode-expected.html: Added.
  • fast/forms/legend-small-after-margin-before-border-horizontal-mode.html: Added.
4:12 PM Changeset in webkit [120016] by jamesr@google.com
  • 6 edits in trunk/Source/WebCore

[chromium] Use WebGraphicsContext3D in rate limiting logic inside compositor
​https://bugs.webkit.org/show_bug.cgi?id=86259

Reviewed by Adrienne Walker.

This refactors the compositor's rate limiting implementation to use the Platform API's WebGraphicsContext3D
directly instead of WebCore::GraphicsContext3D to cut down on the number of spurious WebCore dependencies in the
compositor. The one change in contract is that the caller to CCLayerTreeHost::startRateLimit() now has to call
CCLayerTreeHost::stopRateLimit() before allowing the referenced context to go away since CCLayerTreeHost no
longer retains a reference, but this was always happening already.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):

  • platform/graphics/chromium/RateLimiter.cpp:

(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::rateLimitContext):

  • platform/graphics/chromium/RateLimiter.h:

(WebKit):
(RateLimiter):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

3:58 PM Changeset in webkit [120015] by danakj@chromium.org
  • 13 edits
    1 delete in trunk/Source

[chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad
​https://bugs.webkit.org/show_bug.cgi?id=88363

Reviewed by Adrienne Walker.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebVideoFrame.h:
  • chromium/src/WebVideoFrame.cpp: Removed.

Source/WebCore:

CCVideoDrawQuad should not contain any pointers to data in the layer
tree so we are able to serialize it across process boundaries. This
patch removes the ManagedTexture pointers from the quad class,
replacing them with texture ids. It removes the WebVideoFrame* from
the quad, replacing it with the frame provider's texture id included
in the WebVideoFrame structure. And it uses a WebTransformationMatrix
instead of a pointer to an array of floats.

Texture allocation is done in CCVideoLayerImpl via the
contentsTextureAllocator, so that the memory usage can be tracked.

We move the copyPlaneToTextures() method back from LayerRendererChromium
to CCVideoLayerImpl, as this method uses the texture data pointer in the
WebVideoFrame, and we do not want to give this pointer to the quad
class. Instead, this method makes use of the LayerTextureSubImage class
to copy the pixel data into the texture.

LayerTextureSubImage is updated to allow non-4byte texture formats.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture2D):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/TextureCopier.cpp:
  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::planes):
(WebCore::CCVideoDrawQuad::frameProviderTextureId):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(FramePlane):
(WebCore::CCVideoLayerImpl::FramePlane::FramePlane):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCTiledLayerTestCommon.h:

(WebKitTests::FakeTextureCopier::copyToTexture):

  • tests/Canvas2DLayerChromiumTest.cpp:
3:41 PM Changeset in webkit [120014] by jsbell@chromium.org
  • 4 edits in trunk/Source

IndexedDB: Object stores are not successfully deleted
​https://bugs.webkit.org/show_bug.cgi?id=88788

Reviewed by Tony Chang.

Source/WebCore:

Discovered while working on ​http://webkit.org/b/83074 - object stores are not
being deleted from the backing store. Deletion would succeed in the in-memory
data structures, but after closing/re-opening the backing store the object store
(but not its indexes/data) would reappear. Due to 83074, this isn't detectable
by DRT without a full restart.

Test: [chromium] webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):

Source/WebKit/chromium:

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

3:29 PM Changeset in webkit [120013] by ericu@chromium.org
  • 5 edits in trunk

Crash in fast/files/read tests during Garbage Collection
​https://bugs.webkit.org/show_bug.cgi?id=87165

Reviewed by Michael Saboff

Source/WebCore:

Fix previous fix for hasPendingActivity, and fix a bug in a complex
abort case as well--abort during the final progress event of a write
would hang the writer.

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::didWrite):
(WebCore::FileWriter::didTruncate):
(WebCore::FileWriter::didFail):
(WebCore::FileWriter::completeAbort):
(WebCore::FileWriter::doOperation):
(WebCore::FileWriter::signalCompletion):

LayoutTests:

Simplify file-writer-abort-continue.js a bit, and add a new test case
for a write that gets aborted in the final progress event, which
previously would have hung the FileWriter.

  • fast/filesystem/file-writer-abort-continue-expected.txt:
  • fast/filesystem/resources/file-writer-abort-continue.js:
3:16 PM Changeset in webkit [120012] by commit-queue@webkit.org
  • 5 edits in trunk

.: Replace obsolete mkdir_p variable with MKDIR_P
​https://bugs.webkit.org/show_bug.cgi?id=88790

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • configure.ac:

Source/WebKit/gtk/po: Replace obsolete mkdir_p variables with MKDIR_P
​https://bugs.webkit.org/show_bug.cgi?id=88790

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.

  • GNUmakefile.am:
3:05 PM Changeset in webkit [120011] by commit-queue@webkit.org
  • 13 edits in trunk/LayoutTests

WebAudio tests need to set WebKitWebAudioEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=88624

Patch by Dongwoo Im <​dw.im@samsung.com> on 2012-06-11
Reviewed by Chris Rogers.

  • webaudio/audiochannelmerger-basic.html: Set WebKitWebAudioEnabled by including 'audio-testing.js'.
  • webaudio/audionode-connect-order.html: ditto.
  • webaudio/biquadfilternode-basic.html: ditto.
  • webaudio/delaynode-maxdelay.html: ditto.
  • webaudio/delaynode-scheduling.html: ditto.
  • webaudio/delaynode.html: ditto.
  • webaudio/javascriptaudionode-downmix8-2channel-input.html: ditto.
  • webaudio/javascriptaudionode-upmix2-8channel-input.html: ditto.
  • webaudio/mediaelementaudiosourcenode-gc.html: ditto.
  • webaudio/mediaelementaudiosourcenode.html: ditto.
  • webaudio/realtimeanalyser-fft-sizing.html: ditto.
  • webaudio/stereo2mono-down-mixing.html: ditto.
3:04 PM Changeset in webkit [120010] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
​https://bugs.webkit.org/show_bug.cgi?id=88809

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Adjust the media container dimensions, whenever the FrameView::frameRect
(aka viewport rect) changes

Reviewed internally by Jacky Jiang.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

3:03 PM Changeset in webkit [120009] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen ​https://bugs.webkit.org/show_bug.cgi?id=88719 PR #164026

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Instead of using WebPage's viewport size, which suffers from
dealing with transformed coordinates, viewport metatag changes,
etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
which abstract all these variations.

It fixes an overscale issue we were having when video player entered
fullscreen, and webpage had viewport metatag set.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

2:37 PM Changeset in webkit [120008] by shawnsingh@chromium.org
  • 8 edits in trunk/Source

[chromium] Implement position:fixed in compositor thread
​https://bugs.webkit.org/show_bug.cgi?id=70103

Reviewed by Adrienne Walker.

Source/WebCore:

Significant contributions to this patch by Alpha Lam and Sami Kyostila.

This patch is the compositor-side change that adds support for
fixed-position layers to be composited layers. Before this patch,
fixed-position elements were positioned only by WebCore (i.e. main
thread when painting), and the compositor did not have enough
knowledge on its own to position it properly. This patch adds the
necessary math and plumbs the necessary layer information so that
the impl thread can properly position fixed-position elements on
its own. This support is necessary for correctness of composited
fixed-position elements, which can greatly help to avoid
repainting container layers when scrolling with a fixed-position
layer.

There also needs to be WebCore-side support for this, which is
addressed in ​https://bugs.webkit.org/show_bug.cgi?id=78864

Unit tests added to CCLayerTreeHostCommonTest:

CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDirectContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithTransformedDirectContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainerAndTransforms
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleScrollDeltas
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithIntermediateSurfaceAndTransforms
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleIntermediateSurfaces
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithContainerLayerThatHasSurface
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatIsAlsoFixedPositionContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatHasNoContainer

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setIsContainerForFixedPositionLayers):
(WebCore::LayerChromium::isContainerForFixedPositionLayers):
(LayerChromium):
(WebCore::LayerChromium::setFixedToContainerLayerVisibleRect):
(WebCore::LayerChromium::fixedToContainerLayerVisibleRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setIsContainerForFixedPositionLayers):
(WebCore::CCLayerImpl::isContainerForFixedPositionLayers):
(CCLayerImpl):
(WebCore::CCLayerImpl::setFixedToContainerLayerVisibleRect):
(WebCore::CCLayerImpl::fixedToContainerLayerVisibleRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::computeScrollCompensationForThisLayer):
(WebCore):
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
2:17 PM Changeset in webkit [120007] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt exits early too frequently
​https://bugs.webkit.org/show_bug.cgi?id=73843

Reviewed by Ryosuke Niwa.

Change the defaults for new-run-webkit-tests for both
--exit-after-n-failures and --exit-after-n-crashes-or-timeouts
to zero (i.e., we will never exit early by default).

If people want their buildbots to exit early it is their
responsibility to update their buildbot configs appropriately.

Note that we have tests that ensure that these flags work for
non-zero numbers, but we don't have tests that either test the
default or ensure that zero means "run all of the tests". I
think that's okay but can add tests if others disagree.

Also note that it looks like no changes on the build.webkit.org
master.cfg are necessary; all of the bots seem to be using the
RunWebKitTests wrapper which is already setting the flags. There
is a NewRunWebKitTests wrapper, but that looks to be unused; I
will delete that in a separate patch.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

2:01 PM Changeset in webkit [120006] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/1132

Merge 119733

BUG=127185
TBR=​raymes@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10540108

1:52 PM Changeset in webkit [120005] by weinig@apple.com
  • 22 edits in trunk/Source

Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
​https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:

Update export.

  • editing/Editor.cpp:

(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:

(Editor):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/Frame.h:

(Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(FrameTree):

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/blackberry:

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

1:30 PM Changeset in webkit [120004] by ojan@chromium.org
  • 515 edits
    32 deletes in trunk/LayoutTests

Last large slew of Chromium windows png rebaselines. See ​http://crbug.com/131829 for more information.
List of rebaselined files excluded because it's too long.

1:22 PM Changeset in webkit [120003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap
​https://bugs.webkit.org/show_bug.cgi?id=88789

Patch by Varun Jain <​varunjain@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

1:16 PM Changeset in webkit [120002] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Crash when a plug-in tries to use the NPRuntime API with JavaScript disabled
​https://bugs.webkit.org/show_bug.cgi?id=88797
<rdar://problem/11574844>

Reviewed by Brady Eidson.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Handle the windowNPObjectID being 0.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Handle m_windownPObject being null.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowScriptNPObject):
Return null if JavaScript is disabled.

(WebKit::PluginView::pluginElementNPObject):
Ditto.

1:16 PM Changeset in webkit [120001] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] [DRT] Reset CacheModel before running each test
​https://bugs.webkit.org/show_bug.cgi?id=87534

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Gustavo Noronha Silva.

Reset cache model to default before running each test to fix some
flaky tests on EFL build bots. Also fix case value in setCacheModel.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setCacheModel):

1:15 PM Changeset in webkit [120000] by wangxianzhu@chromium.org
  • 15 edits
    2 adds in trunk

SVGImageCache leaks image data
​https://bugs.webkit.org/show_bug.cgi?id=87792

Source/WebCore:

There are two functions to remove a client from a CachedImage:

  • CachedResource::removeClient()
  • CachedImage::removeClientForRenderer().

It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.

This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.

Reviewed by Nikolas Zimmermann.

Test: svg/as-image/svg-image-leak-cached-data.html

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType): Added 'const'.

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.

  • loader/cache/CachedRawResource.h:

(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedSVGDocument.h:

(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::removeClient):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

LayoutTests:

Reviewed by Nikolas Zimmermann.

New test case.

  • svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
  • svg/as-image/svg-image-leak-cached-data.html: Added.
12:50 PM Changeset in webkit [119999] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leaks in DRT EventSender.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88774

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Martin Robinson.

Fix a few possible memory leaks in EventSender code.

  • DumpRenderTree/gtk/EventSender.cpp:

(contextClickCallback): Free the event returned by gdk_event_new().
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.

12:45 PM Changeset in webkit [119998] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
​https://bugs.webkit.org/show_bug.cgi?id=88661

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Dirk Pranke.

Tools:

Pass string length explicitly when creating String object from
non-null-terminated UChar* returned by characters().

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pathToLocalResource):

LayoutTests:

Unskip test cases which rely on pathToLocalResource().

  • platform/efl/TestExpectations:
11:54 AM Changeset in webkit [119997] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium] Call shared timer functions directly
​https://bugs.webkit.org/show_bug.cgi?id=88781

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

11:48 AM Changeset in webkit [119996] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Relative pos. input fields in columns vanish when you start typing in them
​https://bugs.webkit.org/show_bug.cgi?id=76834

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-06-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/multicol/multicol-with-child-renderLayer-for-input.html

  • page/FrameView.cpp:

(WebCore::updateLayerPositionFlags):
Helper function to prepare the UpdateLayerPositionsFlags based on the input parameters.
If didFullRepaint flag is set, then CheckForRepaints flag is removed from the default flags.
Also during a relayout of a subtree, if the RenderLayer of the subtree root is paginated then updatePagination flag is
included in the flags.

(WebCore):
(WebCore::FrameView::layout):
Now uses the helper function updateLayerPositionFlags() to get the final set of UpdateLayerPositionsFlags.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isPaginated):
(RenderLayer):
isPaginated function is made public so that FrameView class can use it prepare UpdateLayerPositionsFlags.

LayoutTests:

  • fast/multicol/multicol-with-child-renderLayer-for-input-expected.html: Added.
  • fast/multicol/multicol-with-child-renderLayer-for-input.html: Added.
11:37 AM Changeset in webkit [119995] by fischman@chromium.org
  • 15 edits
    3 copies in branches/chromium/1132

Merge 119742 - Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
​https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::didPassCORSAccessCheck):
(WebCore):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCORSMode):
(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
(WebKit):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/security/resources/video-cross-origin-allow.php: Added.
  • http/tests/security/video-cross-origin-readback-expected.txt: Added.
  • http/tests/security/video-cross-origin-readback.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:

TBR=​fischman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10536097

11:36 AM Changeset in webkit [119994] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove some dead code in PasteboardChromium
​https://bugs.webkit.org/show_bug.cgi?id=88782

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.
Leftover detritus from bug 88038.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

11:35 AM Changeset in webkit [119993] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Removing long WebDeviceOrientation constructor
​https://bugs.webkit.org/show_bug.cgi?id=88779

Patch by Amy Ousterhout <​aousterh@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

Removing the WebDeviceOrientation constructor with nine parameters.
Chromium has been changed to use the default constructor and setter
functions instead (see ​https://chromiumcodereview.appspot.com/10542025/).

  • public/WebDeviceOrientation.h:
11:29 AM Changeset in webkit [119992] by rniwa@webkit.org
  • 273 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=88766

Reviewed by Tony Chang.

  • compositing/:
  • compositing/animation/:
  • compositing/backface-visibility/:
  • compositing/backing/:
  • compositing/culling/:
  • compositing/geometry/:
  • compositing/iframes/:
  • compositing/iframes/resources/:
  • compositing/images/:
  • compositing/layer-creation/:
  • compositing/masks/:
  • compositing/overflow/:
  • compositing/plugins/:
  • compositing/reflections/:
  • compositing/repaint/:
  • compositing/resources/:
  • compositing/rtl/:
  • compositing/scaling/:
  • compositing/tiling/:
  • compositing/transitions/:
  • compositing/video/:
  • compositing/visibility/:
  • compositing/webgl/:
  • platform/chromium/compositing/:
  • platform/chromium/compositing/force-compositing-mode/:
  • platform/chromium/compositing/rubberbanding/:
  • platform/mac/compositing/canvas/:
11:26 AM Changeset in webkit [119991] by ojan@chromium.org
  • 539 edits
    9 adds
    24 deletes in trunk/LayoutTests

Large slew of Chromium windows png rebaselines. See ​http://crbug.com/131829 for more information.

List of rebaselined files excluded because it's too long.

11:23 AM Changeset in webkit [119990] by rniwa@webkit.org
  • 153 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in css 1, css 2.1, and css3 tests
​https://bugs.webkit.org/show_bug.cgi?id=88769

Reviewed by Tony Chang.

  • css1/units/zero-duration-without-units.html:
  • css3/calc/:
  • css3/filters/:
  • css3/filters/custom/:
  • css3/filters/resources/:
  • css3/filters/script-tests/:
  • css3/flexbox/:
  • css3/font-feature-settings-rendering.html:
  • css3/images/cross-fade-invalidation.html:
  • css3/images/optimize-contrast-canvas.html:
  • css3/images/optimize-contrast-image.html:
  • css3/khtml-background-size-0x0-bmp.html:
  • css3/parsing-css3-nthchild.html:
  • css3/style-zoomed-image.html:
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
  • css3/zoom-coords.xhtml:
  • platform/win/css2.1/resources/run-webkit-tests-epilogue.html:
  • platform/win/css2.1/resources/run-webkit-tests-prologue.html:
11:21 AM Changeset in webkit [119989] by fischman@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebKit/chromium/public/WebMediaPlayer.h

Merge 119569 - [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
​https://bugs.webkit.org/show_bug.cgi?id=88388

Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:

TBR=​fischman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10533083

11:14 AM Changeset in webkit [119988] by commit-queue@webkit.org
  • 11 edits in trunk

[chromium] Provide access to the WebPlugin created by the helper plugin widget
​https://bugs.webkit.org/show_bug.cgi?id=88028

Patch by David Dorwin <​ddorwin@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

Source/WebKit/chromium:

A WebPlugin is created when the document created by createHelperPlugin() is laid out.
Expose it so the embedder can interact with the plugin instance.

  • public/WebHelperPlugin.h:

(WebKit):
(WebHelperPlugin):

  • public/WebMediaPlayerClient.h:

(WebKit):

  • public/WebPlugin.h:

(WebKit::WebPlugin::isPlaceholder):
(WebPlugin):

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::WebHelperPluginImpl):
(WebKit):
(WebKit::WebHelperPluginImpl::getPlugin):
(WebKit::WebHelperPluginImpl::initPage):
(WebKit::WebHelperPluginImpl::close):

  • src/WebHelperPluginImpl.h:

(WebKit):
(WebHelperPluginImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebPagePopupImpl.cpp:

Tools:

Added isPlaceholder() to WebPlugin.

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin::isPlaceholder):

11:13 AM Changeset in webkit [119987] by peter@chromium.org
  • 5 edits in trunk/Source/WebCore

[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
​https://bugs.webkit.org/show_bug.cgi?id=88775

Reviewed by Adam Barth.

For Chrome on Android, use the width of the scrollbar down arrow instead
of the scrollbar's width for determining the arrow padding to apply for
menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).

Furthermore, change the default active selection background color to be
equal to the tap highlighting color.

These changes should be covered by existing layout tests.

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
(WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.

  • rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding

and platformActiveSelectionBackgroundColor methods, and add a static
static RGBA32 color for the default active selection bg color.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to

the scrollbar thickness, not changing behavior for non-Android.

(WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead

of polling the scrollbar thickness, call menuListArrowPadding().

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.

10:39 AM Changeset in webkit [119986] by tony@chromium.org
  • 3 edits in trunk/Tools

rebaseline from garden-o-matic leaves N processes each time it is run
​https://bugs.webkit.org/show_bug.cgi?id=88586

Reviewed by Dirk Pranke.

This appears to only be a problem on python 2.7. Maybe a bug causing
pools to not be garbage collected?

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_in_parallel): close() and join() the process pool.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_in_parallel):

10:22 AM Changeset in webkit [119985] by rniwa@webkit.org
  • 53 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in animations tests
​https://bugs.webkit.org/show_bug.cgi?id=88757

Reviewed by Tony Chang.

  • animations/3d/change-transform-in-end-event.html:
  • animations/3d/replace-filling-transform.html:
  • animations/3d/state-at-end-event-transform.html:
  • animations/3d/transform-origin-vs-functions.html:
  • animations/animation-add-events-in-handler.html:
  • animations/animation-border-overflow.html:
  • animations/animation-controller-drt-api.html:
  • animations/animation-direction-reverse-fill-mode-hardware.html:
  • animations/animation-direction-reverse-fill-mode.html:
  • animations/animation-drt-api-multiple-keyframes.html:
  • animations/animation-drt-api.html:
  • animations/animation-end-event-destroy-renderer.html:
  • animations/animation-end-event-short-iterations.html:
  • animations/animation-hit-test-transform.html:
  • animations/animation-hit-test.html:
  • animations/animation-iteration-event-destroy-renderer.html:
  • animations/animation-matrix-negative-scale-unmatrix.html:
  • animations/animation-on-inline-crash.html:
  • animations/animation-shorthand-overriding.html:
  • animations/animation-shorthand-removed.html:
  • animations/animation-shorthand.html:
  • animations/animation-start-event-destroy-renderer.html:
  • animations/animation-welcome-safari.html:
  • animations/body-removal-crash.html:
  • animations/change-keyframes-name.html:
  • animations/change-transform-style-during-animation.html:
  • animations/combo-transform-translate+scale.html:
  • animations/empty-keyframes.html:
  • animations/fill-mode-forwards.html:
  • animations/fill-mode-iteration-count-non-integer.html:
  • animations/fill-mode-missing-from-to-keyframes.html:
  • animations/fill-mode-multiple-keyframes.html:
  • animations/fill-mode-removed.html:
  • animations/fill-mode-reverse.html:
  • animations/fill-mode-transform.html:
  • animations/fill-mode.html:
  • animations/fill-unset-properties.html:
  • animations/font-size-using-ems.html-disabled:
  • animations/import-crash.html:
  • animations/keyframe-timing-functions-transform.html:
  • animations/keyframe-timing-functions2.html:
  • animations/keyframes-iteration-count-non-integer.html:
  • animations/longhand-timing-function.html:
  • animations/missing-from-to-transforms.html:
  • animations/missing-from-to.html:
  • animations/pause-crash.html:
  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):
(endTest):

  • animations/state-at-end-event.html:
  • animations/suspend-resume-animation-events.html:
  • animations/suspend-transform-animation.html:
  • animations/transition-and-animation-3.html:
  • animations/unanimated-style.html:
10:19 AM Changeset in webkit [119984] by commit-queue@webkit.org
  • 22 edits
    3 adds in trunk

Add css3-images image-resolution (dppx only)
​https://bugs.webkit.org/show_bug.cgi?id=85332

Patch by David Barr <​davidbarr@chromium.org> on 2012-06-11
Reviewed by Tony Chang.

The css3-images module is at candidate recommendation.
​http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution

Source/WebCore:

Test: fast/css/image-resolution.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore):
(ApplyPropertyImageResolution):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyImageResolution::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageDimensionsChanged):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests:

  • fast/css/image-resolution/image-resolution-expected.txt: Added.
  • fast/css/image-resolution/image-resolution.html: Added.
  • platform/chromium/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/efl/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/gtk/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/mac/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/qt/TestExpectations: Skip tests until image-resolution implementation lands.
9:57 AM Changeset in webkit [119983] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Make media (<video> and <audio>) slide draggable again ​https://bugs.webkit.org/show_bug.cgi?id=88742 PR #158199

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

First check if the element is a range type then gets its
shadow DOM ancestor.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::shouldConvertTouchToMouse):

9:49 AM Changeset in webkit [119982] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=88371

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.layersFreeTextures

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
8:31 AM Changeset in webkit [119981] by Carlos Garcia Campos
  • 9 edits in trunk

Unreviewed. Fix make distcheck issues.

.:

  • GNUmakefile.am: Initialize jscore nosource variables.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Remove non existent header file.

Source/WebCore:

  • GNUmakefile.am: Add idl files in editing dir to EXTRA_DIST.
  • GNUmakefile.list.am: Add missing header file.

Source/WTF:

  • GNUmakefile.list.am: Add missing header file.
7:59 AM Changeset in webkit [119980] by dominicc@chromium.org
  • 21 edits
    5 adds
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline more SVG tests on Windows.

  • platform/chromium-linux-x86/svg/batik/filters/filterRegions-expected.png: Removed.
  • platform/chromium-win-vista/svg/batik/paints/gradientLimit-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/text/smallFonts-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png:
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
7:37 AM Changeset in webkit [119979] by dominicc@chromium.org
  • 7 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed: Rebaselines for svg/as-background-image tests on Windows.

  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
7:33 AM Changeset in webkit [119978] by mitz@apple.com
  • 5 edits
    2 deletes in trunk

Reverted r119940 because it caused multiple media tests to fail on Lion.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore):
(WebCore::HTMLMediaElement::userCancelledLoad):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

  • http/tests/media/video-src-invalid-error-expected.txt: Removed.
  • http/tests/media/video-src-invalid-error.html: Removed.
7:05 AM Changeset in webkit [119977] by zoltan@webkit.org
  • 6 edits
    3 adds in trunk

Source/WebCore: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)$
​https://bugs.webkit.org/show_bug.cgi?id=87841

Reviewed by Simon Hausmann.

No new tests were needed.

  • Target.pri:
  • WebCore.pri:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

Tools: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
​https://bugs.webkit.org/show_bug.cgi?id=87841

Reviewed by Simon Hausmann.

  • qmake/config.tests/libwebp/libwebp.cpp: Added.

(main):

  • qmake/config.tests/libwebp/libwebp.pro: Added.
  • qmake/sync.profile:
7:02 AM Changeset in webkit [119976] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r119962. Four inspector/debugger tests still fail after they have been re-enabled.
​https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by János Badics <János Badics> on 2012-06-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
6:53 AM Changeset in webkit [119975] by kenneth@webkit.org
  • 8 edits in trunk/Source

Add QML api for setting device width and height
​https://bugs.webkit.org/show_bug.cgi?id=88777

Reviewed by Simon Hausmann.

Source/WebCore:

Change the default values for deviceWidth/Height to be 0 (unset). The
original values were introduced by Qt and 0 makes it possible to
detect if a value has never been set and therefore fall back.

Only Qt depended on the former values.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

Source/WebKit2:

Add the new API and set the default values to 0 (unset). The
current values were introduced by Qt and only Qt depends on them.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::deviceWidth):
(QQuickWebViewExperimental::setDeviceWidth):
(QQuickWebViewExperimental::deviceHeight):
(QQuickWebViewExperimental::setDeviceHeight):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::viewportItemSizeChanged):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

6:20 AM Changeset in webkit [119974] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Should call frameDetached() in WebPagePopupImpl::close()
​https://bugs.webkit.org/show_bug.cgi?id=88754

Reviewed by Adam Barth.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::close): Calls FrameLoader::frameDetached().

5:49 AM Changeset in webkit [119973] by dominicc@chromium.org
  • 19 edits in trunk/LayoutTests

[Chromium] Unreviewed: Rebaselines and updated expectations for media tests

Pixel differences are due to antialiasing and different rounded
corners on the media progress bar. The difference is not
noticeable.

  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium/TestExpectations:
5:19 AM Changeset in webkit [119972] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Mark track-cue-rendering-inner-timestamps.html failing on Vista

  • platform/chromium/TestExpectations:
4:27 AM Changeset in webkit [119971] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skipping http/tests/security/mixedContent/filesystem-url-in-iframe.html
​https://bugs.webkit.org/show_bug.cgi?id=88770

ENABLE(FILE_SYSTEM) is disabled; this test should be skipped until
that feature is enabled. Moving it up into the proper section of the
Skipped file to make sure it's enabled if and when the feature makes
it into the port.

Patch by Mike West <​mkwst@chromium.org> on 2012-06-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
3:29 AM Changeset in webkit [119970] by Csaba Osztrogonác
  • 6 edits in trunk/Source/WebKit/qt

[Qt][Win] Add missing includes to fix the build
​https://bugs.webkit.org/show_bug.cgi?id=88538

Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:
  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/GeolocationClientQt.cpp:
  • WebCoreSupport/IconDatabaseClientQt.cpp:
3:24 AM Changeset in webkit [119969] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88310

Reviewed by Simon Hausmann.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getPropertyNames):

2:49 AM Changeset in webkit [119968] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Unreviewed build fix.

No new tests added as this is a build fix.

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-06-11

  • platform/qt/FileSystemQt.cpp:
2:38 AM Changeset in webkit [119967] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Rect-based hittesting doesn't work in tables.
​https://bugs.webkit.org/show_bug.cgi?id=86605

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-06-11
Reviewed by Julien Chaffraix.

Source/WebCore:

The existing code only performed a single binary lookup for the central
hit-test point. This meant area-based hit-testing did not work across
table-cell borders. All cells spanned by a hit-test area must be hit
tested.

This patch introduces three auxilary functions to help calculate rows
and columns spanned by an rect. These are intended to also be used by
repaint logic in a later patch.

For point-based hit-testing we maintain unchanged behavior and still
only hit test a single column in a single row.

Test: fast/dom/nodesFromRect-table.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Test nodesFromRect on tables.

  • fast/dom/nodesFromRect-table-expected.txt: Added.
  • fast/dom/nodesFromRect-table.html: Added.
2:26 AM Changeset in webkit [119966] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Adding a flag to show fullscreen media controls in chromium
​https://bugs.webkit.org/show_bug.cgi?id=88266

Patch by Min Qin <​qinmin@google.com> on 2012-06-11
Reviewed by Adam Barth.

Source/WebCore:

The default chromium shadow DOM for media element does not contain fullscreen button.
This change adds a flag to display the fullscreen button.
It will be used by the android port.

No new tests needed. We will use the same layout tests as desktop chromium.
However, new test result expections will be added later.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::reportedError):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):

Source/WebKit/chromium:

Adding a flag to the gyp file so that we can enable fullscreen media control

  • features.gypi:
2:17 AM Changeset in webkit [119965] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-06-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests needed / applicable (using operating system functionality).

Added method to read free file system space for a path to support cache model
implementation in Qt WK 2.

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath): Added for Qt ports.
(WebCore):

Source/WebKit2:

Added implementation of cache model for Qt WK 2 port including supporting
functionality such as WebProcess creation parameters and default values
for disk cache directories.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::physicalMemorySizeInBytes):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

2:00 AM Changeset in webkit [119964] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip new failing tests.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-06-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
1:26 AM Changeset in webkit [119963] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
​https://bugs.webkit.org/show_bug.cgi?id=88751

Unreviewed EFL gardening. Skip newly introduced test case that is failing
on most ports.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11

  • platform/efl/TestExpectations:
1:24 AM Changeset in webkit [119962] by commit-queue@webkit.org
  • 4 edits in trunk

[JSC] Web Inspector: implement breaking from native callback
​https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.

These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::breakProgram):

  • bindings/js/ScriptDebugServer.h:

(WebCore::supportsNativeBreakpoints):

1:23 AM Changeset in webkit [119961] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Remove expectations for passing tests

The flakiness dashboard indicates that
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
and
platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html
are passing on all platforms now.

  • platform/chromium/TestExpectations:
1:17 AM Changeset in webkit [119960] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Spellchecker crash in async scenario.
​https://bugs.webkit.org/show_bug.cgi?id=88617

Reviewed by Tony Chang.

SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.

No new tests. It's hard to reproduce this.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::invokeRequest):

1:11 AM Changeset in webkit [119959] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
​https://bugs.webkit.org/show_bug.cgi?id=88752

Unreviewed EFL gardening. Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
now that it no longer depends on the legacy blob builder (r119944).

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11

  • platform/efl/TestExpectations:
12:41 AM Changeset in webkit [119958] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebCore

[EFL] Extract CursorMap from WidgetEfl.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=88633

Reviewed by Ryosuke Niwa.

In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
extract it and expose getEcoreCursor.

No new tests, refactoring only.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore):
(CursorMap):
(WebCore::CursorMap::cursor):
(WebCore::CursorMap::CursorMap):
(WebCore::getEcoreCursor):

  • platform/efl/EflScreenUtilities.h:

(WebCore):

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::applyFallbackCursor):

12:14 AM QtWebKitForQt5 edited by Simon Hausmann
(diff)

Jun 10, 2012:

11:58 PM Changeset in webkit [119957] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r119955.
​http://trac.webkit.org/changeset/119955
​https://bugs.webkit.org/show_bug.cgi?id=88758

Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-10

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::insideVisibleArea):
(WebCore):
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:

(Editor):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/Frame.h:

(Frame):
(WebCore::Frame::isDisconnected):
(WebCore):
(WebCore::Frame::setIsDisconnected):
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):

  • page/FrameTree.cpp:

(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(FrameTree):

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::hasNoStyleInformation):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _setIsDisconnected:]):
(-[WebFrame _setExcludeFromTextSearch:]):

  • WebView/WebFramePrivate.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):

11:23 PM Changeset in webkit [119956] by kinuko@chromium.org
  • 7 edits in trunk

Using BlobBuilder should show a deprecation warning message (if it is enabled)
​https://bugs.webkit.org/show_bug.cgi?id=88644

Reviewed by Jian Li.

Source/WebCore:

Mac has already disabled BlobBuilder, but Chromium still has it.
We should start showing a warning to let people migrate to using Blob constructor.

Tests: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore):
(WebCore::WebKitBlobBuilder::create):

  • fileapi/WebKitBlobBuilder.h:

(WebCore):
(WebKitBlobBuilder):

  • fileapi/WebKitBlobBuilder.idl:

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt:
11:11 PM Changeset in webkit [119955] by weinig@apple.com
  • 18 edits in trunk/Source

Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
​https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:

Update export.

  • editing/Editor.cpp:

(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:

(Editor):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/Frame.h:

(Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(FrameTree):

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

11:03 PM Changeset in webkit [119954] by kinuko@chromium.org
  • 17 edits
    3 copies
    9 moves
    1 add in trunk/Source/WebCore

Move Quota related code out of DOMWindow and into the quota/ folder
​https://bugs.webkit.org/show_bug.cgi?id=88512

Patch by Kinuko Yasuda <​kinuko@google.com> on 2012-06-07
Reviewed by Adam Barth.

No new tests: no visible changes.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Modules/quota/DOMWindowQuota.cpp: Added.
  • Modules/quota/DOMWindowQuota.h: Added.
  • Modules/quota/DOMWindowQuota.idl: Added.
  • Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
  • Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
  • Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
  • Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
  • Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
  • Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
  • Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
  • Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
  • Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
10:47 PM Changeset in webkit [119953] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Add expectations for svg-as-background-6.html

Like other SVG tests noted in bug 83303, this test fails on
Windows because it uses a sans-serif font where a serif font is
expected.

  • platform/chromium/TestExpectations:
10:35 PM Changeset in webkit [119952] by dominicc@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale on Linux, Win

These differ in antialiasing only, where there are already
platform differences antialiasing.

  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
9:45 PM Changeset in webkit [119951] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html again -- actually it may
pass if a particular DLL is installed. So expect PASS or
IMAGE+TEXT failure from this test.

  • platform/chromium/TestExpectations:
9:38 PM Changeset in webkit [119950] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html expectations to fail on
XP.

  • platform/chromium/TestExpectations:
8:58 PM Changeset in webkit [119949] by hayato@chromium.org
  • 6 edits
    2 adds in trunk

An inheritance of '-webkit-user-modify' does not stop at shadow boundary.
​https://bugs.webkit.org/show_bug.cgi?id=88514

Reviewed by Ryosuke Niwa.

Source/WebCore:

In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
CSS property after inheriting a parent style, but that is not
enough. We also have to reset '-webkit-user-modify' when we use a
cached result in applying matched properties.

Test: fast/dom/shadow/user-modify-inheritance.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::styleForElement):

  • css/StyleResolver.h:

(StyleResolver):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::inheritFrom):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/dom/shadow/user-modify-inheritance-expected.txt: Added.
  • fast/dom/shadow/user-modify-inheritance.html: Added.
7:30 PM Changeset in webkit [119948] by yosin@chromium.org
  • 19 edits
    2 adds in trunk

[Forms] Introduce Decimal behind the InputNumber type
​https://bugs.webkit.org/show_bug.cgi?id=88383

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces decimal arithmetic for steppable input types,
e.g. date, datetime, number, range, and so on, to avoid rounding error
caused by base 2 floating point representation, e.g. C/C++ double type.

Most of decimal arithmetic calculations are implemented in StepRange
class, replacing "double" with "Decimal", InputType::applyStep, and
InputType::stepFromRenderer.

Changes introduced by this patch are still intermediate state.
Following patch will replace InputNumber type to Decimal type for
completion of introducing decimal arithmetic.

Test: fast/forms/range/range-value-rounding.html

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.

  • html/InputType.cpp:

(WebCore::InputType::rangeUnderflow): Changed for Decimal type.
(WebCore::InputType::rangeOverflow): Changed for Decimal type.
(WebCore::InputType::minimum): Changed for Decimal type.
(WebCore::InputType::maximum): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumberOrNaN): ditto.
(WebCore::InputType::applyStep): ditto.
(WebCore::InputType::stepUpFromRenderer): ditto.

  • html/InputType.h:

(InputType): Removed parseToNumberWIthDecimaplPlaces.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): Changed for Decimal type.

  • html/NumberInputType.cpp:

(WebCore::RealNumberRenderSize): Added for calculateRenderSize.
(WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
(WebCore::NumberInputType::createStepRange): Changed for Decimal type.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
(WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
(WebCore::NumberInputType::serialize): ditto.

  • html/NumberInputType.h:

(NumberInputType): Removed parseToNumberWIthDecimaplPlaces.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createStepRange): Changed for Decimal type.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::serialize): ditto.

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
(WebCore::StepRange::acceptableError): Changed for Decimal type.
(WebCore::StepRange::alignValueForStep): ditto.
(WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
(WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Changed for Decimal type.
(WebCore::convertDoubleToInputNumber): Changed to real implementation.
(WebCore::convertInputNumberToDouble): Changed to real implementation.

  • html/StepRange.h:

(InputNumber): Replacement of NumberWithDecimalPlaces.
(WebCore::StepRange::InputNumber::InputNumber):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange): Changed for Decimal type.

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Changed for Decimal type.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType): Added Decimal version.
(WebCore::parseToDecimalForNumberType): Added.

  • html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition): Changed for Decimal type.

LayoutTests:

  • fast/forms/range/range-value-rounding-expected.txt: Added.
  • fast/forms/range/range-value-rounding.html: Added.
7:16 PM Changeset in webkit [119947] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

[BlackBerry] Possible to clobber httponly cookie.
​https://bugs.webkit.org/show_bug.cgi?id=86067

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-06-10
Reviewed by Rob Buis.

Source/WebCore:

If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.html

  • platform/blackberry/CookieJarBlackBerry.cpp:

(WebCore::setCookies):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):

  • platform/blackberry/CookieMap.h:

(CookieMap):

LayoutTests:

  • http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
  • http/tests/cookies/js-get-and-set-http-only-cookie.html: Added.
  • platform/chromium/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
2:36 PM Changeset in webkit [119946] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

Expose layoutTestController as testRunner
​https://bugs.webkit.org/show_bug.cgi?id=88210

Reviewed by Darin Adler.

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::makeWindowObject):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::initJSObjects):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::makeWindowObject):

LayoutTests:

Add a test for testRunner object.

  • fast/harness/testrunner-object-expected.txt: Added.
  • fast/harness/testrunner-object.html: Added.
1:18 PM Changeset in webkit [119945] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Access control allow lists starting with a comma are parsed incorrectly (CORS)
​https://bugs.webkit.org/show_bug.cgi?id=88461

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-06-10
Reviewed by Adam Barth.

Source/WebCore:

The parsing algorithm would stop parsing at the first comma (being an
empty entry, of sorts) and bail out, effectively ignoring the whole
header.

Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::parseAccessControlAllowList):

LayoutTests:

  • http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-allow-lists.php: Added.
12:48 PM Changeset in webkit [119944] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Removing mixed content tests' dependency on WebKitBlobBuilder:
​https://bugs.webkit.org/show_bug.cgi?id=88736

http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.

It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).

Patch by Mike West <​mkwst@chromium.org> on 2012-06-10
Reviewed by Adam Barth.

  • http/tests/security/mixedContent/blob-url-in-iframe.html:
  • http/tests/security/mixedContent/filesystem-url-in-iframe.html:
  • platform/mac/Skipped:
12:19 PM Changeset in webkit [119943] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Some additional tweaks to keep TreeShared code simple/clean
​https://bugs.webkit.org/show_bug.cgi?id=88738

Reviewed by Adam Barth.

  • platform/TreeShared.h: Make constructor and destructor both protected.

It's slightly dangerous to have a public non-virtual destructor, and there
is no reason it needs to be public.
(WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
we were getting no value from it being virtual. Now that it's non-virtual,
there is no need to use an #if on it since it's an empty inline destructor
in non-debug builds.

11:44 AM Changeset in webkit [119942] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=88725

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
Reviewed by Eric Carlson.

  • media/track/track-cue-rendering-inner-timestamps.html: Round the timestamp values

so that the test passes for EFL and GTK ports.

  • platform/efl/TestExpectations: Unskip test.
  • platform/gtk/TestExpectations: Unskip test.
11:41 AM Changeset in webkit [119941] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/dom/frame-loading-via-document-write.html
​https://bugs.webkit.org/show_bug.cgi?id=88737

Unreviewed EFL gardening. Skipping test that is flaky after r119788.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
11:18 AM Changeset in webkit [119940] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION: Setting invalid media "src" does not cause "error" event
​https://bugs.webkit.org/show_bug.cgi?id=88423

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/video-src-invalid-error.html

Two problems here. When the loadTimer is scheduled, the m_pendingLoadFlags
variable is set to specify what type of load is scheduled. It is cleared
when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
it does not clear the m_pendingLoadFlags variable, so the next time
scheduleLoad() is called (when the src is changed to an invalid URL)
prepareForLoad() is not called again.

Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
QTMovieLoadStateChangedNotification is never fired for an invalid http
URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
the QTMovie.

Add a new utility method which both stops the m_loadTimer and clears the
m_pendingLoadFlags, and use it in all the places where m_loadTimer was
stopped explicitly:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::stopLoadTimer): Added
(WebCore::HTMLMediaElement::userCancelledLoad):

  • html/HTMLMediaElement.h:

And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

  • http/tests/media/video-src-invalid-error-expected.txt: Added.
  • http/tests/media/video-src-invalid-error.html: Added.
11:14 AM Changeset in webkit [119939] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Add logging functions to MediaPlayerPrivateQTKit.
​https://bugs.webkit.org/show_bug.cgi?id=88425

Reviewed by Eric Carlson.

No new tests; adds logging functions to aide debugging.

MediaPlayerPrivateQTKit should emit the same kind of logging messages as
other MediaPlayerPrivate engines to aide in debugging.

Distinguish between loadedRangesChanged() and loadStateChanged() for logging
purposes:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
(-[WebCoreMovieObserver loadedRangesChanged:]):

Add LOG messages for each of the following functions:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):

11:09 AM Changeset in webkit [119938] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebCore

WebCore should use a single definition of an invalid media time.
​https://bugs.webkit.org/show_bug.cgi?id=88572

Reviewed by Eric Carlson.

No new tests; no change in functionality, so covered by existing tests.

Add a new, universal definition for an invalid media time:

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayer::invalidTime):

Use this new definition instead of the hodge podge of (identical) local
definitions for an invalid media time:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::initialTime):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseTimeFragment):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

10:15 AM Changeset in webkit [119937] by Darin Adler
  • 16 edits in trunk

Remove unneeded callRemovedLastRef function from TreeShared refactoring
​https://bugs.webkit.org/show_bug.cgi?id=88653

Reviewed by Sam Weinig.

.:

  • Source/autotools/symbols.filter: Filter removedLastRef instead of

callRemovedLastRef.

Source/WebCore:

  • WebCore.exp.in: Updated to remove callRemovedLastRef and add removedLastRef.
  • dom/ContainerNode.cpp: Removed callRemovedLastRef, which is no longer

needed and also had a bad cast in it.

  • dom/Document.h: Made removedLastRef private and non-virtual and made Node

a friend so it can call the private function.

  • dom/Node.cpp:

(WebCore::Node::removedLastRef): Moved here. This should not be an inline
function. Added comments explaining why it should not be inlined. Also added
explicit code to call to Document::removedLastRef, and added a comment why
that's the right thing to do here.

  • dom/Node.h: Inherit from TreeShared<Node, ContainerNode>. Made the

removedLastRef function non-virtual and removed it from the header file.
Updated TreeShared using statements. Made the TreeShared template class a
friend so it can call the private removedLastRef.

  • html/HTMLFormControlElement.h: Updated TreeShared using statements to specify

Node instead, which accomplishes the same thing.

  • html/HTMLObjectElement.h: Ditto.
  • platform/TreeShared.h: Made TreeShared take two template arguments for the

node type and the parent node type. Removed the callRemovedLastRef functions and
the extra forward declarations it required. Removed the private unused
removedLastRef function; not sure why it was left in here at all.
(WebCore::TreeShared::deref): Call removedLastRef instead of callRemovedLastRef.
(WebCore::TreeShared::setParent): Use ParentNodeType.
(WebCore::TreeShared::parent): Ditto.
(WebCore::adopted): Updated to have both template arguments.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::removedLastRef): Replaced callRemovedLastRef with
this. Moved the body out of the header and added a comment explaining why the
function should not be inlined.

  • svg/SVGElementInstance.h: Made removedLastRef non-virtual, non-inline, and

private. Made TreeShared a friend so it can call the private removedLastRef.
Updated TreeShared using statements.

Source/WebKit2:

  • win/WebKit2.def: Export removedLastRef instead of callRemovedLastRef.
  • win/WebKit2CFLite.def: Ditto.
9:54 AM Changeset in webkit [119936] by zandobersek@gmail.com
  • 4 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening. Updating a few animations tests baselines,
adding test expectations for one FileSystem test.

  • platform/gtk/TestExpectations:
  • platform/gtk/animations/3d/change-transform-in-end-event-expected.txt:
  • platform/gtk/animations/3d/matrix-transform-type-animation-expected.txt: Added.
  • platform/gtk/animations/3d/state-at-end-event-transform-expected.txt:
9:33 AM Changeset in webkit [119935] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Temporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the Mac skip
list. <​http://webkit.org/b/88736> tracks moving this test off of the legacy
WebKitBlobBuilder API.

  • platform/mac/Skipped:
9:14 AM Changeset in webkit [119934] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip list,
because FILE_SYSTEM is not enabled.

Part of: http/tests/security/mixedContent/blob-url-in-iframe.html and http/tests/security/mixedContent/filesystem-url-in-iframe.html are failing
<​http://webkit.org/b/88736>

  • platform/mac/Skipped:
9:14 AM Changeset in webkit [119933] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] 2 fast/multicol/span tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=88734

Unreviewed EFL gardening. Move to TestExpectations 2 tests that
are flaky on the bot.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
8:37 AM Changeset in webkit [119932] by Darin Adler
  • 2 edits in trunk/Source/WebCore
  • WebCore.exp.in: Re-sorted and alphabetized the file.
8:32 AM Changeset in webkit [119931] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
​https://bugs.webkit.org/show_bug.cgi?id=88728

Unreviewed gardening. Skip new test added in r119911 which fails for both
GTK and EFL ports.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
8:29 AM Changeset in webkit [119930] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Several test cases can be unskipped
​https://bugs.webkit.org/show_bug.cgi?id=88731

Unreviewed EFL gardening. Unskip a few tests that are passing after
r118618 was rolled out.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
7:53 AM Changeset in webkit [119929] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
​https://bugs.webkit.org/show_bug.cgi?id=88730

Unreviewed EFL gardening. Skip a few tests causing flakiness.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
7:21 AM Changeset in webkit [119928] by ryuan.choi@samsung.com
  • 5 edits
    2 copies
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
​https://bugs.webkit.org/show_bug.cgi?id=84124

Reviewed by Chang Shu.

Modify ewk_view and add ewk_context to provide a platform-depedent WebKit2
API.
This patch provides the minimum to support MiniBrowser.

  • PlatformEfl.cmake: add ewk_context.cpp.
  • UIProcess/API/efl/EWebKit2.h: Added.
  • UIProcess/API/efl/ewk_context.cpp: Added.

(_Ewk_Context):
(createDefaultWebContext):
(ewk_context_WKContext_get):
(ewk_context_default_get):

  • UIProcess/API/efl/ewk_context.h: Added.
  • UIProcess/API/efl/ewk_context_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_add):
(ewk_view_uri_set):
(ewk_view_uri_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
6:44 AM Changeset in webkit [119927] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88308

Reviewed by Simon Hausmann.

No new tests, just a build fix.

Use ownerWindow() from page client. It has been
introduced for x11 plugins to solve exactly the
same problem.

  • plugins/win/PluginViewWin.cpp:

(windowHandleForPageClient):

5:49 AM Changeset in webkit [119926] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.

  • runtime/Executable.h:

(ExecutableBase):
(JSC::ExecutableBase::clearCodeVirtual):

5:25 AM Changeset in webkit [119925] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r119844.

  • runtime/Executable.h:

(ExecutableBase):
(JSC):

5:09 AM Changeset in webkit [119924] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix building ImageQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88306

Reviewed by Simon Hausmann.

No new tests, this is just a build fix.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore):
(WebCore::BitmapImage::create):
Adapt to the "API" changes in Qt.

4:43 AM Changeset in webkit [119923] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
​https://bugs.webkit.org/show_bug.cgi?id=88726

Unreviewed gardening. Skip test added in r119907 for GTK and EFL ports.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
Note: See TracTimeline for information about the timeline view.