⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 15, 2012:

10:01 PM Changeset in webkit [120523] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r120280.
​http://trac.webkit.org/changeset/120280
​https://bugs.webkit.org/show_bug.cgi?id=89273

Enabling CSS regions broke all Windows tests (Requested by
jhomeycutt on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-15

Source/WebCore:

  • css/CSSPropertyNames.in:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
8:54 PM Changeset in webkit [120522] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in fast/workers/storage tests
​https://bugs.webkit.org/show_bug.cgi?id=89271

Reviewed by Adam Barth.

  • fast/workers/storage/change-version-sync.html:
  • fast/workers/storage/interrupt-database-sync.html-disabled:
  • fast/workers/storage/interrupt-database.html:
  • fast/workers/storage/resources/database-worker.js:

(onmessage):

  • fast/workers/storage/resources/multiple-transactions-sync.js:

(checkCompletion):

  • fast/workers/storage/resources/test-inputs-common.js:

(finishTest):

  • fast/workers/storage/use-same-database-in-page-and-workers.html:
8:42 PM Changeset in webkit [120521] by rniwa@webkit.org
  • 206 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in transforms, transitions, traversal, userscripts, webarchive, webaudio, and webintents tests
​https://bugs.webkit.org/show_bug.cgi?id=89269

Reviewed by Adam Barth.

  • transitions/:
  • traversal/:
  • userscripts/:
  • webarchive/:
  • webaudio/:
  • webintents/web-intents-delivery.html:
  • webintents/web-intents-failure.html:
  • webintents/web-intents-reload.html:
  • webintents/web-intents-reply.html:
8:35 PM Changeset in webkit [120520] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic's results.js should use RequestTracker
​https://bugs.webkit.org/show_bug.cgi?id=89257

Reviewed by Dimitri Glazkov.

We wrote results.js before we recognized the RequestTracker pattern.
This patch replaces the manual implementations of RequestTracker with
the real deal.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
8:30 PM Changeset in webkit [120519] by rniwa@webkit.org
  • 293 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in the rest of sputnik tests
​https://bugs.webkit.org/show_bug.cgi?id=89262

Reviewed by Antti Koivisto.

  • sputnik/Implementation_Diagnostics/:
  • sputnik/Regression/:
  • sputnik/Unicode/:
8:10 PM Changeset in webkit [120518] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Test fix attempt after r120516.

  • fast/workers/storage/resources/database-worker-controller.js:

(databaseWorker.onmessage):
(runTest):

7:23 PM Changeset in webkit [120517] by Darin Adler
  • 2 edits in trunk/Tools
  • Scripts/webkitpy/bindings: Added property svn:ignore.
7:16 PM Changeset in webkit [120516] by rniwa@webkit.org
  • 105 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in storage, tables, touchadjustments, and transforms tests
​https://bugs.webkit.org/show_bug.cgi?id=89263

Reviewed by Antti Koivisto.

  • storage/domstorage/events/resources/eventTestHarness.js:

(testStorages.allDone):

  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/window-open-second.html:
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
  • storage/domstorage/script-tests/storage-functions-not-overwritten.js:
  • storage/domstorage/sessionstorage/delete-removal.html:
  • storage/domstorage/sessionstorage/enumerate-storage.html:
  • storage/domstorage/sessionstorage/enumerate-with-length-and-key.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
  • storage/domstorage/sessionstorage/resources/window-open-second.html:
  • storage/domstorage/sessionstorage/simple-usage.html:
  • storage/domstorage/sessionstorage/string-conversion.html:
  • storage/domstorage/sessionstorage/window-open.html:
  • storage/domstorage/window-attributes-exist.html:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/tutorial.html:
  • storage/websql/change-version-handle-reuse.js:

(finishTest):

  • storage/websql/change-version-no-crash-on-preflight-failure.html:
  • storage/websql/change-version.html:
  • storage/websql/close-during-stress-test.html:
  • storage/websql/database-lock-after-reload.html:
  • storage/websql/empty-statement.html:
  • storage/websql/execute-sql-args.js:

(runTransactionTests):

  • storage/websql/executesql-accepts-only-one-statement.html:
  • storage/websql/hash-change-with-xhr.js:

(stopTest):

  • storage/websql/multiple-databases-garbage-collection.js:

(checkCompletion):

  • storage/websql/multiple-transactions-on-different-handles.js:

(checkCompletion):

  • storage/websql/multiple-transactions.js:

(checkCompletion):

  • storage/websql/null-callbacks.html:
  • storage/websql/open-database-creation-callback-isolated-world.html:
  • storage/websql/open-database-creation-callback.html:
  • storage/websql/open-database-empty-version.html:
  • storage/websql/open-database-over-quota.html:
  • storage/websql/open-database-set-empty-version.html:
  • storage/websql/open-database-while-transaction-in-progress.js:

(runTest):

  • storage/websql/private-browsing-noread-nowrite.html:
  • storage/websql/quota-tracking.html:
  • storage/websql/read-and-write-transactions-dont-run-together.js:

(terminateTest):

  • storage/websql/read-transactions-running-concurrently.html:
  • storage/websql/resources/database-common.js:

(setupAndRunTest):

  • storage/websql/resources/database-lock-after-reload-2.html:
  • storage/websql/sql-data-types.js:

(notifyDone):
(runTest):

  • storage/websql/sql-error-codes.js:

(finishTest):
(runTest):

  • storage/websql/statement-error-callback-isolated-world.html:
  • storage/websql/statement-error-callback.html:
  • storage/websql/statement-success-callback-isolated-world.html:
  • storage/websql/success-callback.html:
  • storage/websql/test-authorizer.js:

(terminateTest):

  • storage/websql/transaction-callback-exception-crash.html:
  • storage/websql/transaction-callback-isolated-world.html:
  • storage/websql/transaction-error-callback-isolated-world.html:
  • storage/websql/transaction-error-callback.html:
  • storage/websql/transaction-success-callback-isolated-world.html:
  • tables/hittesting/filltable-emptycells.html:
  • tables/hittesting/filltable-levels.html:
  • tables/hittesting/filltable-outline.html:
  • tables/hittesting/filltable-rtl.html:
  • tables/hittesting/filltable-stress.html:
  • tables/layering/paint-test-layering-1.html:
  • tables/layering/paint-test-layering-2.html:
  • tables/table-section-overflow-clip-crash.html:
  • touchadjustment/block-testing.html:
  • touchadjustment/event-triggered-widgets.html:
  • touchadjustment/html-label.html:
  • touchadjustment/iframe.html:
  • touchadjustment/nested-touch.html:
  • touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
  • touchadjustment/scroll-offset.html:
  • touchadjustment/touch-inlines.html:
  • touchadjustment/zoom-basic.html:
  • touchadjustment/zoom-fatfinger.html:
  • transforms/2d/compound-2d-transforms.html:
  • transforms/2d/cssmatrix-2d-zoom.html:
  • transforms/2d/set-transform-and-top.html:
  • transforms/2d/transform-2d.html:
  • transforms/2d/transform-accuracy.html:
  • transforms/3d/general/3dtransform-values.html:
  • transforms/3d/general/cssmatrix-3d-zoom.html:
  • transforms/3d/general/matrix-with-zoom-3d.html:
  • transforms/3d/general/transform-origin-z-change.html:
  • transforms/3d/hit-testing/hit-preserves-3d.html:
  • transforms/3d/point-mapping/3d-point-mapping-2.html:
  • transforms/3d/point-mapping/3d-point-mapping-3.html:
  • transforms/3d/point-mapping/3d-point-mapping-deep.html:
  • transforms/3d/point-mapping/3d-point-mapping-origins.html:
  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
  • transforms/no_transform_hit_testing.html:
7:06 PM Changeset in webkit [120515] by rniwa@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove empty directories.

  • platform/editing: Removed.
  • platform/editing/inserting: Removed.
  • websocket: Removed.
  • websocket/tests: Removed.
  • websocket/tests/workers: Removed.
6:15 PM Changeset in webkit [120514] by atwilson@chromium.org
  • 6 edits in trunk/LayoutTests/platform

2012-06-15 Andrew Wilson <​atwilson@chromium.org>

Unreviewed chromium expectations update.
​https://bugs.webkit.org/show_bug.cgi?id=82122
​https://bugs.webkit.org/show_bug.cgi?id=79914

  • platform/chromium-mac-leopard/fast/lists/001-expected.png:
  • platform/chromium-mac/fast/lists/001-expected.png:
  • platform/chromium-mac/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/001-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium/TestExpectations:
5:49 PM Changeset in webkit [120513] by commit-queue@webkit.org
  • 8 edits
    2 moves in trunk

Unreviewed, rolling out r120511.
​http://trac.webkit.org/changeset/120511
​https://bugs.webkit.org/show_bug.cgi?id=89255

Breaks at least Android builder (Requested by wangxianzhu on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-15

Source/WebCore:

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebFontRendering.h:
  • public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.

(WebKit):
(WebFontRendering):

  • src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

5:33 PM Changeset in webkit [120512] by atwilson@chromium.org
  • 209 edits
    71 adds in trunk/LayoutTests

Unreviewed baselines for chromium.
​https://bugs.webkit.org/show_bug.cgi?id=87761

  • platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Added.
  • platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac-leopard/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac-leopard/fast/css/color-correction-expected.png:
  • platform/chromium-mac-leopard/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-leopard/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-leopard/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-leopard/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-leopard/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac-leopard/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/color-correction-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac/svg/repaint/image-href-change-expected.png:
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-saturate-expected.png:
  • platform/chromium-win/css3/filters/effect-sepia-expected.png:
  • platform/chromium-win/css3/filters/regions-expanding-expected.png:
  • platform/chromium-win/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium/TestExpectations:
5:24 PM Changeset in webkit [120511] by wangxianzhu@chromium.org
  • 8 edits
    2 moves in trunk

[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
​https://bugs.webkit.org/show_bug.cgi?id=89228

Source/WebCore:

Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.

Reviewed by Tony Chang.

Refactory only. No new tests.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.

This also avoids the ambiguous name 'linuxish'.

Reviewed by Tony Chang.

  • WebKit.gyp:
  • public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.

(WebFontRendering):

  • public/linux/WebFontRendering.h:
  • public/linuxish: Removed.
  • public/linuxish/WebFontRendering.h: Removed.
  • src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):

  • src/linuxish: Removed.
  • src/linuxish/WebFontRendering.cpp: Removed.

Tools:

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

4:35 PM Changeset in webkit [120510] by dgrogan@chromium.org
  • 72 edits in trunk/LayoutTests

IndexedDB: Remove obsolete description parameter from factory.open calls
​https://bugs.webkit.org/show_bug.cgi?id=89047

Reviewed by Tony Chang.

This parameter has been obsolete for 18 months and is getting replaced
with a version parameter.

  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/global-data-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/object-cursors-expected.txt:
  • storage/indexeddb/mozilla/object-identity-expected.txt:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
  • storage/indexeddb/mozilla/objectstorenames-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/put-get-values-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/remove-index-expected.txt:
  • storage/indexeddb/mozilla/remove-objectstore-expected.txt:
  • storage/indexeddb/mozilla/resources/add-twice-failure.js:

(test):

  • storage/indexeddb/mozilla/resources/autoincrement-indexes.js:

(test):

  • storage/indexeddb/mozilla/resources/bad-keypath.js:

(test):

  • storage/indexeddb/mozilla/resources/clear.js:

(test):

  • storage/indexeddb/mozilla/resources/create-index-unique.js:

(test):

  • storage/indexeddb/mozilla/resources/create-index-with-integer-keys.js:

(test):

  • storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(test):

  • storage/indexeddb/mozilla/resources/create-objectstore-null-name.js:

(test):

  • storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:

(test):

  • storage/indexeddb/mozilla/resources/cursor-update-updates-indexes.js:

(test):

  • storage/indexeddb/mozilla/resources/cursors.js:

(test):

  • storage/indexeddb/mozilla/resources/delete-result.js:

(test):

  • storage/indexeddb/mozilla/resources/event-source.js:

(test):

  • storage/indexeddb/mozilla/resources/global-data.js:

(test):
(cleanDatabase):

  • storage/indexeddb/mozilla/resources/indexes.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements.js:

(test):

  • storage/indexeddb/mozilla/resources/object-cursors.js:

(test):

  • storage/indexeddb/mozilla/resources/object-identity.js:

(test):

  • storage/indexeddb/mozilla/resources/object-store-inline-autoincrement-key-added-on-put.js:

(test):

  • storage/indexeddb/mozilla/resources/object-store-remove-values.js:

(test):

  • storage/indexeddb/mozilla/resources/objectstorenames.js:

(test):

  • storage/indexeddb/mozilla/resources/odd-result-order.js:

(test):

  • storage/indexeddb/mozilla/resources/put-get-values.js:

(test):

  • storage/indexeddb/mozilla/resources/readonly-transactions.js:

(test):

  • storage/indexeddb/mozilla/resources/readwrite-transactions.js:

(test):

  • storage/indexeddb/mozilla/resources/readyState.js:

(test):

  • storage/indexeddb/mozilla/resources/remove-index.js:

(test):

  • storage/indexeddb/mozilla/resources/remove-objectstore.js:

(test):

  • storage/indexeddb/mozilla/resources/versionchange-abort.js:

(test):

  • storage/indexeddb/mozilla/resources/versionchange.js:

(test):
(openSuccess):
(postSetVersion):

  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/mozilla/versionchange-expected.txt:
4:33 PM Changeset in webkit [120509] by enne@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Fix composited scrollbars with transparent thumbs
​https://bugs.webkit.org/show_bug.cgi?id=89247

Reviewed by James Robinson.

On some platforms, the thumb of a scrollbar can be transparent. Fix by
always drawing the thumb quad with blending.

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:

(WebCore::CCTextureDrawQuad::setNeedsBlending):
(WebCore):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h:

(CCTextureDrawQuad):

4:18 PM Changeset in webkit [120508] by tony@chromium.org
  • 1 edit
    1 delete in trunk/Source/WebKit/chromium

[chromium] Remove WebKit/chromium/public/gtk/WebFontInfo.h since it's no longer referenced.
​https://bugs.webkit.org/show_bug.cgi?id=89251

Reviewed by Adam Barth.

This was a forwarding header when we moved the file to public/linux.

  • public/gtk/WebFontInfo.h: Removed.
4:13 PM Changeset in webkit [120507] by jamesr@google.com
  • 5 edits
    2 deletes in trunk/Source/WebCore

[chromium] Use SkBitmap in ImageLayerChromium
​https://bugs.webkit.org/show_bug.cgi?id=89134

Reviewed by Adrienne Walker.

GraphicsLayer::setContentsToImage(Image*) is called whenever an image layer's image is or might have changed.
In Chromium, this used to hang on to a RefPtr<WebCore::Image> until the compositor was ready to upload texture contents.
This is potentially a bit fishy since the Image itself might not be in exactly the same state when we get around
to uploading textures and it also creates a bad dependency from ImageLayerChromium on WebCore::Image.

This patch grabs the underlying SkBitmap in the setContentsTo call and passes that into ImageLayerChromium
instead. I've also removed the venerable but redundant PlatformImage concept since all of chromium's images are
skia bitmaps these days.

Covered by existing tests, particularly compositing/images/ and compositing/color-matching/.

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::setBitmap):
(ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::setBitmap):
(WebCore::ImageLayerChromium::update):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/PlatformImage.cpp: Removed.
  • platform/graphics/chromium/PlatformImage.h: Removed.
4:09 PM Changeset in webkit [120506] by efidler@rim.com
  • 4 edits in trunk/Source

[BlackBerry] Use platform font settings for the standard settings.
​https://bugs.webkit.org/show_bug.cgi?id=89232

Reviewed by Rob Buis.

RIM PR 159708

Source/WebCore:

  • page/blackberry/SettingsBlackBerry.cpp:

(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):

Source/WebKit/blackberry:

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

3:58 PM Changeset in webkit [120505] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove touch events handling hook for popup
​https://bugs.webkit.org/show_bug.cgi?id=89245

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-06-15
Reviewed by Rob Buis.

In the old patches we create our own WebPage for popup, so we need to hook up our own
touch handling functions, since we don't use our own WebPage any more, no need to keep
the touch handling code, because it just does nothing other than passing out the events
which might cause the touch events being handled twice.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • WebCoreSupport/PagePopupBlackBerry.cpp:
  • WebCoreSupport/PagePopupBlackBerry.h:

(PagePopupBlackBerry):

3:49 PM Changeset in webkit [120504] by jsbell@chromium.org
  • 10 edits
    3 adds in trunk

IndexedDB: Raise exceptions when methods are called on deleted objects
​https://bugs.webkit.org/show_bug.cgi?id=89243

Reviewed by Tony Chang.

Source/WebCore:

Implement the IDB spec requirement that InvalidStateError exceptions are
thrown when methods are called on objects (i.e. object stores and indexes)
that have been deleted within a version change transaction.

Test: storage/indexeddb/deleted-objects.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore): Don't relay to transaction if back-end failed.

  • Modules/indexeddb/IDBIndex.cpp: Check deleted state in methods, raise if set.

(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBIndex.h: Add flag to track deleted state, method to mark it.

(WebCore::IDBIndex::markDeleted):
(IDBIndex):

  • Modules/indexeddb/IDBObjectStore.cpp: Check deleted state in methods, raise if set.

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex): If the index being deleted has been instantiated,
mark it as deleted.
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • Modules/indexeddb/IDBObjectStore.h: Add flag to track deleted state, method to mark it.

(WebCore::IDBObjectStore::markDeleted):
(IDBObjectStore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted): If the store being deleted has been instantiated,
mark it as deleted.

LayoutTests:

  • storage/indexeddb/deleted-objects-expected.txt: Added.
  • storage/indexeddb/deleted-objects.html: Added.
  • storage/indexeddb/resources/deleted-objects.js: Added.

(test):
(openDatabase.request.onsuccess.request.onsuccess):
(openDatabase.request.onsuccess):
(openDatabase):

  • storage/indexeddb/resources/transaction-basics.js: Fix test that relied on

non-compliant behavior.
(addRemoveIDBObjects):
(addRemoveAddIDBObjects):

  • storage/indexeddb/transaction-basics-expected.txt:
3:30 PM Changeset in webkit [120503] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Forgot a rebaseline for r120477.

  • platform/chromium-win/fast/forms/formmove3-expected.txt:
3:24 PM Changeset in webkit [120502] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

[BlackBerry] Put platform-specific GC policy in GCActivityCallback
​https://bugs.webkit.org/show_bug.cgi?id=89236

Patch by Yong Li <​yoli@rim.com> on 2012-06-15
Reviewed by Rob Buis.

Add GCActivityCallbackBlackBerry.cpp and implement platform-specific
low memory GC policy there.

  • PlatformBlackBerry.cmake:
  • heap/Heap.h:

(JSC::Heap::isSafeToCollect): Added.

  • runtime/GCActivityCallbackBlackBerry.cpp: Added.

(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::DefaultGCActivityCallbackPlatformData):
(DefaultGCActivityCallbackPlatformData):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::synchronize):
(JSC::DefaultGCActivityCallback::cancel):

3:24 PM Changeset in webkit [120501] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
​https://bugs.webkit.org/show_bug.cgi?id=89126

Reviewed by Stephen White.

When drawing an image buffer into a deferred device context, we have to make a deep copy of the source (Skia
can't for some reason). Stephen White fixed this in r101325 by adding a bit on PlatformContextSkia indicating if
a given context is deferred, but I broke this again in r120346 by refactoring the SkCanvas creation to happen in
a different location from the PlatformContextSkia construction.

This moves the check into ImageBufferSkia and directly queries the state of the destination SkDevice to be more
robust and work without needing special PlatformContextSkia setup.

Covered by LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::drawNeedsCopy):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

3:21 PM Changeset in webkit [120500] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should be able to set watchpoints on structure transitions in the
method check prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=89058

Adding the same assertion to 32-bit that I added to 64-bit. This change
does not affect correctness but it's a good thing for assertion coverage.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:14 PM Changeset in webkit [120499] by fpizlo@apple.com
  • 24 edits
    3 adds in trunk

DFG should be able to set watchpoints on structure transitions in the
method check prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=89058

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This adds the ability to set watchpoints on Structures, and then does
the most modest thing we can do with this ability: the DFG now sets
watchpoints on structure transitions in the prototype chain of method
checks.

This appears to be a >1% speed-up on V8.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • bytecode/StructureSet.h:

(JSC::StructureSet::containsOnly):
(StructureSet):

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::WatchpointSet):
(JSC::InlineWatchpointSet::add):
(JSC):
(JSC::InlineWatchpointSet::inflateSlow):
(JSC::InlineWatchpointSet::freeFat):

  • bytecode/Watchpoint.h:

(WatchpointSet):
(JSC):
(InlineWatchpointSet):
(JSC::InlineWatchpointSet::InlineWatchpointSet):
(JSC::InlineWatchpointSet::~InlineWatchpointSet):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::isStillValid):
(JSC::InlineWatchpointSet::startWatching):
(JSC::InlineWatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::isFat):
(JSC::InlineWatchpointSet::fat):
(JSC::InlineWatchpointSet::inflate):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isCellConstant):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addWeakReferences):
(JITCompiler):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasStructure):
(Node):
(JSC::DFG::Node::structure):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::transitionWatchpointSetHasBeenInvalidated):
(Structure):
(JSC::Structure::transitionWatchpointSetIsStillValid):
(JSC::Structure::addTransitionWatchpoint):
(JSC::Structure::notifyTransitionFromThisStructure):
(JSC::JSCell::setStructure):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::attemptToWatch):

LayoutTests:

Rubber stamped by Gavin Barraclough.

  • fast/js/dfg-call-method-hit-watchpoint-expected.txt: Added.
  • fast/js/dfg-call-method-hit-watchpoint.html: Added.
  • fast/js/script-tests/dfg-call-method-hit-watchpoint.js: Added.

(Thingy):
(Thingy.prototype.foo):
(callFoo):
(.Thingy.prototype.foo):

3:02 PM Changeset in webkit [120498] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Add support for explicit intents
​https://bugs.webkit.org/show_bug.cgi?id=89206

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Expose the service URL of a Web Intent. This URL
is set for explicit intents.

  • Shared/IntentData.h:

(IntentData):

  • UIProcess/WebIntentData.h:

(WebKit::WebIntentData::service):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

3:00 PM Changeset in webkit [120497] by fischman@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Compositor should be aware of |flipped| status of video textures per-platform
​https://bugs.webkit.org/show_bug.cgi?id=89189

Reviewed by James Robinson.

No new tests (sadly HW video decode is still only being tested manually for orientation).

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

2:58 PM Changeset in webkit [120496] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

2:54 PM Changeset in webkit [120495] by rniwa@webkit.org
  • 56 edits
    2 moves in trunk

Source/WebCore: The initial value of text-align should be start instead of -webkit-auto
​https://bugs.webkit.org/show_bug.cgi?id=79914

Reviewed by Tony Chang.

Change the initial value of text-align CSS property from -webkit-auto to start as specified in
​http://www.w3.org/TR/css3-text/#text-align

In editing, we have to coerce start and end to left and right for now because match-parent,
which is the text-align value of li in UA stylesheet is going to result in the computed values of
left as supposed to start by default, and this causes editing code not being able to remove
text-align: left when computing typing styles and preserving styles.

In the long term, we should detect this specific case and ignore match-parent but that seemed like
too much work to be done in a single patch also because the test result improved because of this change.

This behavior change is covered by existing regression tests.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(WebCore::getAttributeSetForAccessibilityObject):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): No longer supports TAAUTO since it's identical to TASTART.
(WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto. Parse -webkit-auto as start.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Replace TAAUTO by TASTART.

  • editing/EditingStyle.cpp:

(WebCore):
(WebCore::textAlignResolvingStartAndEnd): Coerce start and end into left and right based on the directionality
for editing. Otherwise, we end up adding lots of text-align: left due to li's UA style rule having match-parent
as the text alignment and its descendent inherits this style. We need to handle it better in the future
since start and left or end and right are semantically different.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::getPropertiesNotIn):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::textAlignmentForLine): Justified text is aligned at start by default.
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::startAlignedOffsetForLine):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

  • rendering/RenderListBox.cpp:

(WebCore::itemOffsetForAlignment):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::updateMarqueeStyle):

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::textAlignmentForLine):
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests: The default value of text-align should be start instead of -webkit-auto
​https://bugs.webkit.org/show_bug.cgi?id=79914

Reviewed by Tony Chang.

Rebaselined tests. For query-text-alignment.html, we now match start and end
with justifyLeft and justifyRight, which appears to be consistent with Firefox for time being.

  • editing/execCommand/query-text-alignment-expected.txt:
  • editing/execCommand/script-tests/query-text-alignment.js:

(queryTextAlignment):
(selectFirstPosition):
(selectMiddleOfHelloWorld):
(runRangeTests):

  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/list-item-text-align.html:
  • fast/css/text-align-initial-expected.html: Renamed from fast/css/text-align-webkit-auto-expected.html.
  • fast/css/text-align-initial.html: Ditto.
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/fast/lists/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/001-vertical-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:45 PM Changeset in webkit [120494] by jianli@chromium.org
  • 5 edits
    1 copy
    1 move
    1 add in trunk

[File API] FileReader should work in sandbox iframe
​https://bugs.webkit.org/show_bug.cgi?id=89242

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/file-reader-sandbox-iframe.html

  • fileapi/ThreadableBlobRegistry.cpp: Should remove from map for all threads.

(WebCore::ThreadableBlobRegistry::unregisterBlobURL):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canRequest): Check and use cached origin for blob URL first.

LayoutTests:

  • fast/files/file-reader-file-url.html:
  • fast/files/file-reader-sandbox-iframe-expected.txt: Added.
  • fast/files/file-reader-sandbox-iframe.html: Added.
  • fast/files/resources/file-reader-real.html: Renamed from LayoutTests/fast/files/resources/file-reader-file-url-iframe.html.
2:34 PM Changeset in webkit [120493] by jianli@chromium.org
  • 8 edits in trunk/LayoutTests

http/tests/fileapi/create-blob-url-from-data-url.html fails
​https://bugs.webkit.org/show_bug.cgi?id=89149

Reviewed by Adam Barth.

Convert the test to check if blob URL can be created in a data iframe.

  • http/tests/fileapi/create-blob-url-from-data-url-expected.txt:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
2:21 PM Changeset in webkit [120492] by Dave Barton
  • 43 edits
    2 adds in trunk

Inherit style changes in MathML anonymous renderers
​https://bugs.webkit.org/show_bug.cgi?id=88476

Reviewed by Julien Chaffraix.

Source/WebCore:

A RenderObject that is not the main renderer() for a DOM node is called "anonymous".
Standard WebCore practice is to mark such a renderer as isAnonymous(). For example,
RenderBlock::styleDidChange calls propagateStyleToAnonymousChildren to flow style
changes to such children, by re-initializing their styles and then inheriting from
this->style(). A derived class' styleDidChange() can then set non-default style
properties as needed.

This patch implements this standard practice for RenderMathMLBlock classes, except
RenderMathMLOperator which currently uses a RenderLayer, which reportedly means it
should not be isAnonymous(). We also follow common practice and change
isAnonymousBlock() to return false for RenderMathMLBlock classes, since
isAnonymousBlock() is really used by RenderBlock to detect its own anonymous blocks for
wrapping inline children, which RenderBlock then combines or deletes assuming this.

Test: mathml/presentation/style-changed.html, also added to mathml/presentation/over.xhtml

  • rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
(WebCore::RenderMathMLBlock::renderName):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::createMathMLOperator):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::styleDidChange):

  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::RenderMathMLFraction):
(WebCore::RenderMathMLFraction::fixChildStyle):
(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::styleDidChange):

  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::styleDidChange):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::fixScriptsStyle):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::styleDidChange):

  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::addChild):
(WebCore::RenderMathMLUnderOver::styleDidChange):

  • rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

  • mathml/presentation/over.xhtml:
  • mathml/presentation/style-changed-expected.html: Added.
  • mathml/presentation/style-changed.html: Added.
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
2:13 PM Changeset in webkit [120491] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/TestExpectations:
1:48 PM Changeset in webkit [120490] by bbudge@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones.
​https://bugs.webkit.org/show_bug.cgi?id=89185

Reviewed by Adam Barth.

This change adds an option to turn off whitelist filtering of response headers for CORS loads,
and modifies AssociatedURLLoader check for that before filtering.

  • public/WebURLLoaderOptions.h:

(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
(WebURLLoaderOptions):

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit):
(WebKit::TEST_F):

1:36 PM Changeset in webkit [120489] by rniwa@webkit.org
  • 5247 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in sputnik's conformance tests
​https://bugs.webkit.org/show_bug.cgi?id=89184

Reviewed by Tony Chang.

  • sputnik/Conformance/:
1:25 PM Changeset in webkit [120488] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
​https://bugs.webkit.org/show_bug.cgi?id=89135

Re-land change in r120370 with fix in
PortFactory.get_from_builder_name() that changes BuilderOptions
to an actual optparse.Values object.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.get_option):
(Port.set_option_default):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(_builder_options):
(PortFactory.get_from_builder_name):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_get_from_builder_name):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions.ensure_value):

1:00 PM Changeset in webkit [120487] by inferno@chromium.org
  • 13 edits in trunk/LayoutTests

Unreviewed. Rebaselines for r120477.

  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/chromium-win/fast/dynamic/011-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/invalid/001-expected.txt:
  • platform/chromium-win/fast/invalid/003-expected.txt:
  • platform/chromium-win/fast/invalid/004-expected.txt:
  • platform/chromium-win/fast/invalid/007-expected.txt:
  • platform/chromium-win/fast/invalid/019-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
12:53 PM Changeset in webkit [120486] by scheib@chromium.org
  • 16 edits in trunk

Add new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods.
​https://bugs.webkit.org/show_bug.cgi?id=88891

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

Entering and exiting mouse lock is provided in the new webkitRequestPointerLock and
webkitExitPointerLock methods.

Source/WebCore:

Existing pointer-lock tests updated to use the new methods.

  • dom/Document.cpp:

(WebCore::Document::webkitExitPointerLock):
(WebCore):

  • dom/Document.h:

(Document):

  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore):
(WebCore::Element::webkitRequestPointerLock):

  • dom/Element.h:
  • dom/Element.idl:

LayoutTests:

Existing tests updated to use the new methods. Also, several updated to
support manual testing.

  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/mouse-event-delivery-expected.txt:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
12:51 PM Changeset in webkit [120485] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port

​https://bugs.webkit.org/show_bug.cgi?id=81974

Reviewed by Adam Barth.

Covered by existing layout tests which will be rebaselined.

  • WebCore.gyp/WebCore.gyp: Add qcms to the build.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.

(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <​tpayne@chromium.org> on 2012-06-15

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <​tpayne@chromium.org> on 2012-06-15

  • wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB

to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

12:41 PM Changeset in webkit [120484] by bbudge@chromium.org
  • 2 edits in trunk/Tools

Add ​bbudge@chromium.org to committers.py

Unreviewed.

Patch by Bill Budge <​bbudge@chromium.org> on 2012-06-15

  • Scripts/webkitpy/common/config/committers.py:
12:39 PM Changeset in webkit [120483] by Lucas Forschler
  • 1 copy in tags/Safari-536.19

New Tag.

11:53 AM Changeset in webkit [120482] by tonikitoo@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
​https://bugs.webkit.org/show_bug.cgi?id=89227
PR #146642

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Make use of the Settings::supportsMouseDevice setting in order to
prevent mouse move event to fire as a response to a scroll action.
We might still want to dynamically toggle this setting ON, in case for
example of a mouse wheel driven scroll action, but we can revisit it
when it becomes a fully supported/primary use case.

Internally reviewed by Eli Fidler.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::isDeviceSupportsMouseEnabled):
(BlackBerry::WebKit::WebSettings::setDeviceSupportsMouseEnabled):

  • Api/WebSettings.h:
11:43 AM Changeset in webkit [120481] by inferno@chromium.org
  • 30 edits
    8 adds in trunk/LayoutTests

Unreviewed. Rebaselines for r120477.

  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/formmove3-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/gtk/fast/dynamic/011-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/gtk/fast/invalid/001-expected.txt:
  • platform/gtk/fast/invalid/003-expected.txt:
  • platform/gtk/fast/invalid/004-expected.txt:
  • platform/gtk/fast/invalid/007-expected.txt:
  • platform/gtk/fast/invalid/019-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
  • platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/qt/fast/dynamic/011-expected.txt:
  • platform/qt/fast/forms/formmove3-expected.txt:
  • platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/qt/fast/invalid/001-expected.txt:
  • platform/qt/fast/invalid/003-expected.txt:
  • platform/qt/fast/invalid/004-expected.txt:
  • platform/qt/fast/invalid/007-expected.txt:
  • platform/qt/fast/invalid/019-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug647-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
11:39 AM Changeset in webkit [120480] by Simon Fraser
  • 6 edits in trunk/LayoutTests

Rebaseline some tests after r120411.

  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/mac/fast/multicol/client-rects-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
11:37 AM Changeset in webkit [120479] by fmalita@chromium.org
  • 53 edits in trunk/LayoutTests

Unreviewed chromium rebaseline for r120467.

Patch by Florin Malita <​fmalita@chromium.org> on 2012-06-15

  • platform/chromium-linux-x86/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-win-xp/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feLighting-crash-expected.png:
  • platform/chromium/TestExpectations:
10:59 AM Changeset in webkit [120478] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove volume thumb for videos without audio track.
​https://bugs.webkit.org/show_bug.cgi?id=89093

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.

No new tests, since this was already tested in media/video-no-audio.html.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaMuteButton):
Change mute button when there is no audio or no source file.
(WebCore::paintMediaVolumeSlider):
Set volume slider to 0 when there is no audio or no source file.
(WebCore::paintMediaVolumeSliderThumb):
Don't paint the volume slider thumb when there is no audio or no source file.

10:57 AM Changeset in webkit [120477] by inferno@chromium.org
  • 16 edits
    2 adds in trunk

Cleanup empty anonymous block continuation.
​https://bugs.webkit.org/show_bug.cgi?id=74976

Reviewed by Julien Chaffraix.

Source/WebCore:

Fix rendering on ​http://docs.google.com/demo.

Test: fast/inline/inline-empty-block-continuation-remove.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): If we are removing our last child,
and are an anonymous block which is part of a continuation chain, then
we need to first fix our continuation chain by setting our previous
continuation renderer to point to the next continuation renderer. Then,
we reset our continuation pointer and destroy ourselves. Since we no
longer are part of continuation chain, we will be removed and previous
and next anonymous block will be merged automatically.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::previousInPreOrder): add an argument to previousInOrder

  • stayWithin.

(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

  • fast/inline/inline-empty-block-continuation-remove-expected.html: Added.
  • fast/inline/inline-empty-block-continuation-remove.html: Added.

and a bunch of rebaselines in existing tests.

10:47 AM Changeset in webkit [120476] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Clean up the flaky tests section in Gtk's TestExpectations file. Remove
flakiness expectations for tests that have been consistently passing and
move expectations for tests that have been consistently failing under
the failing tests section, changing the expectations to represent a constant
expected failure for that test.

Rubber-stamped by Philippe Normand.

  • platform/gtk/TestExpectations:
10:16 AM Changeset in webkit [120475] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Move FileSystem frame management from frontend to backend
​https://bugs.webkit.org/show_bug.cgi?id=89190

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/read-directory.html

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore::InspectorFileSystemAgent::readDirectory):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::scriptExecutionContextForOrigin):
(WebCore):

  • inspector/InspectorFileSystemAgent.h:

(WebCore):
(InspectorFileSystemAgent):

LayoutTests:

  • http/tests/inspector/filesystem/read-directory.html:
10:13 AM Changeset in webkit [120474] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix after r120469.

  • css/CSSPropertySourceData.h:

(WebCore):

10:10 AM Changeset in webkit [120473] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Certain web pages (i.e., ​http://www.cloudtweaks.com/) are allowed to be wider than the screen
​https://bugs.webkit.org/show_bug.cgi?id=89211

Reviewed by Rob Buis.
Patch by Jacky Jiang <​zhajiang@rim.com>

PR: 135215
Make simpler rules for zoom to fit scale:

  • Zoom to fit horizontally first without clamping the contents width.
  • Zoom to fit vertically instead without clamping the contents height if the horizontal zoom to fit can cause a grey area below the web page. Get rid of the virtual viewport guard as there may be cases that zooming can cause a grey area without a virtual viewport.
  • Clamp the scale by the minimum zoom to fit scale 0.25 and apply this rule to image documents as well. This minimum scale can be changed if there is a better vaule in the future.

In this way, we can get rid of the issue that many web pages don't fit
the screen.

Reviewed internally by Arvid Nilsson.

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):

9:57 AM Changeset in webkit [120472] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add FileSystemRequestManager and FileSystemDispatcher
​https://bugs.webkit.org/show_bug.cgi?id=89191

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototoype._requestId):
(WebInspector.FileSystemRequestManager.prototoype.readDirectory):
(WebInspector.FileSystemRequestManager.prototoype._didReadDirectory):
(WebInspector.FileSystemDispatcher):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.didReadDirectory):

9:50 AM Changeset in webkit [120471] by pfeldman@chromium.org
  • 10 edits in trunk

Web Inspector: extension's Resource.getContent always returns original revision.
​https://bugs.webkit.org/show_bug.cgi?id=89219

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Fetching proper content from the UISourceCode now.

  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping.prototype._debuggerReset):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetResourceContent):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.isHidden):
(WebInspector.Resource.prototype.uiSourceCode):
(WebInspector.Resource.prototype.setUISourceCode):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
9:48 AM Changeset in webkit [120470] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
​https://bugs.webkit.org/show_bug.cgi?id=89225

Reviewed by Pavel Feldman.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):

9:36 AM Changeset in webkit [120469] by apavlov@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: CSSParser::parseSheet() should provide ready-to-use source data
​https://bugs.webkit.org/show_bug.cgi?id=88646

Reviewed by Antti Koivisto.

This change moves the post-processing step from InspectorStyleSheet into CSSParser, so that
CSSParser::parseSheet() will return a ready-to-use list with style rule source code data.
Also, universal data structures are introduced, which allow for the full rule source data tree building.

No new tests, as this is a refactoring.

  • css/CSSParser.cpp: Use universal data structures, which can be used for building the full rule tree.

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseSheet): Return ready-to-use source code data entries rather than an intermediate structure.
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::fixUnparsedPropertyRanges): Moved in from InspectorStyleSheet.
(WebCore::CSSParser::markSelectorListStart):
(WebCore::CSSParser::markSelectorListEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyEnd):

  • css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::resetPropertyRange): Renamed.
(WebCore::CSSParser::isExtractingSourceData): A convenience check.

  • css/CSSPropertySourceData.h: Introduce the RuleSourceDataList typedef.

(WebCore):

  • inspector/InspectorStyleSheet.cpp: Make use of RuleSourceDataList and follow the CSSParser::parse*() API changes.

(ParsedStyleSheet::sourceData):
(ParsedStyleSheet):
(ParsedStyleSheet::setSourceData):
(WebCore::InspectorStyleSheet::ensureSourceData): Remove source data postprocessing, follow the new parseSheet() API.

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId): Drive-by: uninitialized field fix.
(WebCore::InspectorStyleProperty::InspectorStyleProperty): Ditto.
(InspectorStyleSheet):

9:03 AM Changeset in webkit [120468] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Long frame urls make all/errors/warnings/logs buttons inaccessible.
​https://bugs.webkit.org/show_bug.cgi?id=88907

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.css:

(#console-context):

8:56 AM Changeset in webkit [120467] by fmalita@chromium.org
  • 17 edits
    2 adds in trunk

Specular light filters produce dark results
​https://bugs.webkit.org/show_bug.cgi?id=89116

Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/filters/feSpecularLight-premultiplied-expected.svg

svg/filters/feSpecularLight-premultiplied.svg

Per spec (​http://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement),
light filters should operate on pre-multiplied RGBA. Currently, the results
are stored in the unmultiplied buffer but the alpha channel is calculated
for premultiplied values (which causes a darkening of the result upon the
subsequent unmultiplied->premultiplied conversion). This patch updates
FELighting to generate premultiplied results.

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

LayoutTests:

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/svg/filters/feLighting-crash-expected.png:
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • svg/filters/feSpecularLight-premultiplied-expected.svg: Added.
  • svg/filters/feSpecularLight-premultiplied.svg: Added.
8:56 AM Changeset in webkit [120466] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed style fix after r120351.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(body.interface):

8:51 AM Changeset in webkit [120465] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: incorrect filtering of async timeline events
​https://bugs.webkit.org/show_bug.cgi?id=89214

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.accept):

8:37 AM Changeset in webkit [120464] by schenney@chromium.org
  • 5 edits
    2 adds in trunk

SVG Composite of Offset filters incorrectly clips
​https://bugs.webkit.org/show_bug.cgi?id=77660

Reviewed by Dirk Schulze.

Source/WebCore:

Prior to this patch, when a group of filtered objects was used as input to another filter,
the filter only operated on the stroke boundary of the group, and hence excluded the results
of filtering elements within the group, or extraneously included regions clipped from the
elements in the group.

This patch modifies the strokeBoundingBox of SVG container elements to
be the union of the repaint rects for the children. This modifes the
results returned for sizing filters and for absoluteRects, which will cause
inline layout around the group to factor in the resources applied to
the group's children.

The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
as though the paint operations had been applied to an intermediate canvas initialized to
transparent black, of a size determined by the rules given in Filter Effects then filtered
by the processes defined in Filter Effects." In this case the "paint operations" is implied
to include the result of applying "paint" but no resources to the group, which in turn would
have resources applied to the children of the group. This makes the most sense, as the current,
incorrect behavior makes it extremely diffucult to understand the actions of filters on
groups of filtered content.

Tests: svg/filters/container-with-filters-expected.svg

svg/filters/container-with-filters.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::updateCachedBoundaries):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::updateCachedBoundaries):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

  • svg/filters/container-with-filters-expected.svg: Added.
  • svg/filters/container-with-filters.svg: Added.
8:29 AM Changeset in webkit [120463] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
​https://bugs.webkit.org/show_bug.cgi?id=89210

Patch by Yong Li <​yoli@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.

Remove BackingStoreClient::scrollsHorizontally()/scrollsVeritically(), because
calling them is neither nessary nor safe.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
(BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):

  • WebKitSupport/BackingStoreClient.cpp:
  • WebKitSupport/BackingStoreClient.h:

(BackingStoreClient):

8:19 AM Changeset in webkit [120462] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Sort ENABLE(INSPECTOR) section of WebCore.exp.in

  • WebCore.exp.in: Sort ENABLE(INSPECTOR) symbols.
8:19 AM Changeset in webkit [120461] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove duplicate symbol from WebCore.exp.in

  • WebCore.exp.in: Remove duplicate symbol for:

WebCore::Range::textQuads(WTF::Vector<WebCore::FloatQuad, 0ul>&, bool, WebCore::Range::RangeInFixedPosition*) const

8:18 AM Changeset in webkit [120460] by fmalita@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed debug build fix for r120457

Patch by Florin Malita <​fmalita@chromium.org> on 2012-06-15

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toYUVVideoDrawQuad):

8:15 AM Changeset in webkit [120459] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: remove redundant Mac-specific style rule from inspector front-end.

  • inspector/front-end/helpScreen.css:
8:11 AM Changeset in webkit [120458] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix help close button appearance on Mac
​https://bugs.webkit.org/show_bug.cgi?id=89208

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/helpScreen.css:

(.help-close-button):
(body.platform-mac .help-close-button):
(body.platform-mac .help-window-main .tabbed-pane-header-contents):

7:34 AM Changeset in webkit [120457] by danakj@chromium.org
  • 7 edits
    2 moves in trunk/Source/WebCore

[chromium] Create a CCYUVVideoDrawQuad and remove the now-unused generic CCVideoDrawQuad
​https://bugs.webkit.org/show_bug.cgi?id=88828

Reviewed by Adrienne Walker.

The CCVideoDrawQuad is now only used for YUV video, so we remove the
class and replace it with CCYUVVideoDrawQuad. This class holds what is
needed to draw a YUV video frame.

No new tests, no change in behaviour.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toYUVVideoDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.cpp.

(WebCore):
(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.h.

(WebCore):
(CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::yPlane):
(WebCore::CCYUVVideoDrawQuad::uPlane):
(WebCore::CCYUVVideoDrawQuad::vPlane):

7:28 AM Changeset in webkit [120456] by loislo@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: CRASH: getProfile is crashing for unknown profiles.
​https://bugs.webkit.org/show_bug.cgi?id=89202

Source/WebCore:

agents' functions have to set a value to errorString if it can't assign values to the mandatory out arguments.

Reviewed by Pavel Feldman.

Test: inspector/profiler/heap-snapshot-get-profile-crash.html

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Added.
  • inspector/profiler/heap-snapshot-get-profile-crash.html: Added.
7:26 AM Changeset in webkit [120455] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg cleanup, remove unnecessary workaround
​https://bugs.webkit.org/show_bug.cgi?id=88994

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

7:22 AM Changeset in webkit [120454] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
​https://bugs.webkit.org/show_bug.cgi?id=88581

Reviewed by Adam Barth.

Make sure we only optimize the suffixes we rebaselined during
rebaseline-expectations, and not all suffixes for a test.
While optimizing is somewhere between harmless and good, it's also confusing :)

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
7:17 AM Changeset in webkit [120453] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] media volume slider in wrong position (master_38 regression)
​https://bugs.webkit.org/show_bug.cgi?id=89165

Patch by Max Feil <​mfeil@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.

Due to upstream simplification of the volume slider (webkit.org
bug 82150) it now appears in the wrong location below the
media controls. The programmatic controls sizing we do in
RenderThemeBlackBerry.cpp relies on absolute positioning of the
volume slider container, so the best way to fix this is to set
the bottom offset.

No new tests since this is a regression fix. BlackBerry media
controls are manually tested.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

7:14 AM Changeset in webkit [120452] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Update builder.html template for newer buildmaster
​https://bugs.webkit.org/show_bug.cgi?id=89207

Rebasing builder.html template from v0.8.3 to v0.8.6p1.

Reviewed by Zoltan Herczeg.

  • BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
7:10 AM Changeset in webkit [120451] by tkent@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Rebaseline for type=range tests.
​https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Added.
7:07 AM Changeset in webkit [120450] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in layout test resources
​https://bugs.webkit.org/show_bug.cgi?id=89182

Reviewed by Kent Tamura.

  • resources/dump-as-markup.js:

(Markup.waitUntilDone):
(Markup.notifyDone):

  • resources/magnitude-perf.js:

(Magnitude._run):
(Magnitude._runIteration):
(Magnitude):

  • resources/testharnessreport.js:
6:58 AM Changeset in webkit [120449] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: remove garbage line from inspector view in docked-to-right mode.

  • inspector/front-end/inspectorCommon.css:

(body.docked.dock-to-right.docked):
(body.docked.dock-to-right.inactive):

6:54 AM Changeset in webkit [120448] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding TEXT expectation for
editing/spelling/grammar-edit-word.html after r120423.

  • platform/gtk/TestExpectations:
6:36 AM Changeset in webkit [120447] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Buildfix for !ENABLE(BLOB) platforms after r120433.
​https://bugs.webkit.org/show_bug.cgi?id=78648

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerBlobURL):

6:27 AM Changeset in webkit [120446] by tkent@chromium.org
  • 4 edits
    2 moves
    2 adds in trunk/LayoutTests

[Chromium] Rebaseline for type=range tests.
​https://bugs.webkit.org/show_bug.cgi?id=89067

  • fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt.
  • platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt.
  • platform/chromium-linux/fast/forms/range/slider-padding-expected.txt: Added.
  • platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium/TestExpectations:
6:06 AM Changeset in webkit [120445] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening. Skip a failing test. After r120423.
​https://bugs.webkit.org/show_bug.cgi?id=89199

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-06-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
5:45 AM Changeset in webkit [120444] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] Allow scrolling non-root layers in the compositor thread
​https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-06-15
Reviewed by James Robinson.

Source/WebCore:

This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.

If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.

Layer hit testing code by Shawn Singh.

Added new unit tests to verify layer scrolling behavior:

CCLayerTreeHostCommonTest.verifySubtreeSearch
CCLayerTreeHostImplTest.clearRootRenderSurfaceAndScroll
CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhileAnimatingPageScale
CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhilePinchZooming
CCLayerTreeHostImplTest.replaceTreeWhileScrolling
CCLayerTreeHostImplTest.scrollBeforeRedraw
CCLayerTreeHostImplTest.scrollBlockedByContentLayer
CCLayerTreeHostImplTest.scrollChildAndChangePageScaleOnMainThread
CCLayerTreeHostImplTest.scrollChildBeyondLimit
CCLayerTreeHostImplTest.scrollChildCallsCommitAndRedraw
CCLayerTreeHostImplTest.scrollEventBubbling
CCLayerTreeHostImplTest.scrollMissesBackfacingChild
CCLayerTreeHostImplTest.scrollMissesChild
CCLayerTreeHostImplTest.scrollNonCompositedRoot
CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnImplThread
CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnMainThread
CCLayerTreeHostImplTest.scrollRootIgnored
CCLayerTreeHostImplTest.scrollWithoutRootLayer
CCLayerTreeHostTestScrollChildLayer
WebCompositorInputHandlerImplTest.gestureScrollOnMainThread

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::scrollBy):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromiumScrollDelegate):
(WebCore::LayerChromiumScrollDelegate::~LayerChromiumScrollDelegate):
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setLayerScrollDelegate):

  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::tryScroll):
(WebCore):
(WebCore::sortLayers):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::findFirstScrollableLayer):
(WebCore):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):
(WebCore):
(WebCore::CCLayerTreeHostCommon::findLayerInSubtree):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::findRootScrollLayer):
(WebCore):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::detachLayerTree):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::clearCurrentlyScrollingLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):

Source/WebKit/chromium:

New unit tests to verify layer scrolling behavior and the associated
utility functions.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockContentLayerDelegate::paintContents):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST_F):

5:31 AM Changeset in webkit [120443] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Add ForceScheduler to build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=88982

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

5:16 AM Changeset in webkit [120442] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[EFL][WK2] Add title support to Ewk_View
​https://bugs.webkit.org/show_bug.cgi?id=89095

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add a method to get the title of the main frame in
an Ewk_View. A "title,changed" signal is now emitted
on the view to notify clients that the main frame
title was changed.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_title_get):
(ewk_view_title_changed):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp: Added.

(didReceiveTitleForFrame):
(ewk_view_loader_client_attach):

  • UIProcess/API/efl/ewk_view_loader_client_private.h: Added.
  • UIProcess/API/efl/ewk_view_private.h:

Tools:

Update the MiniBrowser so it listens for the "title,change"
signal on the view and keeps the browser window title
up-to-date.

  • MiniBrowser/efl/main.c:

(on_title_changed):
(browserCreate):

4:48 AM Changeset in webkit [120441] by commit-queue@webkit.org
  • 18 edits in trunk/LayoutTests

[EFL] Gardening after r120411
​https://bugs.webkit.org/show_bug.cgi?id=89194

Unreviewed EFL gardening, updating baselines after r120411.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-15

  • platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/range/input-appearance-range-expected.png:
  • platform/efl/fast/forms/range/input-appearance-range-expected.txt:
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/efl/fast/forms/range/slider-padding-expected.png:
  • platform/efl/fast/forms/range/slider-padding-expected.txt:
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/efl/fast/multicol/client-rects-expected.png:
  • platform/efl/fast/multicol/client-rects-expected.txt:
  • platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:
4:44 AM Changeset in webkit [120440] by morrita@google.com
  • 4 edits
    5 copies
    4 adds in trunk/LayoutTests

Unreviewed expectation rebaselining.

  • platform/chromium-linux-x86/fast/multicol/client-rects-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/multicol/client-rects-expected.png.
  • platform/chromium-linux-x86/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-linux/fast/multicol/client-rects-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-mac-snowleopard/fast/multicol/client-rects-expected.txt: Added.
  • platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-win/fast/multicol/client-rects-expected.png:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
4:41 AM Changeset in webkit [120439] by tkent@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Chromium] Rebaseline for type=range tests.
​https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt: Added.
  • platform/chromium/TestExpectations:
4:22 AM Changeset in webkit [120438] by Csaba Osztrogonác
  • 11 edits
    2 adds in trunk/LayoutTests

[Qt] Gardening after r120411. Updated baselines of 7 tests because of a color property change.

Patch by János Badics <János Badics> on 2012-06-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.png:
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/range/input-appearance-range-expected.txt:
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png: Added.
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/forms/range/slider-padding-expected.png:
  • platform/qt/fast/forms/range/slider-padding-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.png: Added.
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/qt/fast/repaint/slider-thumb-drag-release-expected.txt:
3:58 AM Changeset in webkit [120437] by commit-queue@webkit.org
  • 5 edits in trunk

[WK2][EFL] Implement navigation back/forward in Ewk_View
​https://bugs.webkit.org/show_bug.cgi?id=89173

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add API for Ewk_View to ask the main frame to navigate backwards
or forwards in history. Also add API to query if such navigation
is possible.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_back):
(ewk_view_forward):
(ewk_view_back_possible):
(ewk_view_forward_possible):

  • UIProcess/API/efl/ewk_view.h:

Tools:

Implement navigation back / forward in MiniBrowser. Use
'F1' to navigate back and 'F2' to navigate forward.

  • MiniBrowser/efl/main.c:

(on_key_down):

3:32 AM Changeset in webkit [120436] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium/TestExpectations:

Mark some tests for type=range FAIL until all bots have the new results.

3:03 AM Changeset in webkit [120435] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix a syntax error of TestExpectations.

  • platform/chromium/TestExpectations:
2:58 AM Changeset in webkit [120434] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed, rolling out r120404.
​http://trac.webkit.org/changeset/120404
​https://bugs.webkit.org/show_bug.cgi?id=89193

This patch breaks [BlackBerry]'s text selection handles moving
in editable elements. (Requested by Sean1 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-15

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

2:57 AM Changeset in webkit [120433] by jianli@chromium.org
  • 10 edits
    3 adds in trunk

FileReader is dysfunctional in documents with "null" origin string
​https://bugs.webkit.org/show_bug.cgi?id=78648

Reviewed by Adam Barth.

Source/WebCore:

The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.

Test: fast/files/file-reader-file-url.html

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.

  • fileapi/BlobURL.h:

(BlobURL):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::getCachedOrigin): Retrieve the origin associated with the blob URL.

  • fileapi/ThreadableBlobRegistry.h:

(WebCore):
(ThreadableBlobRegistry):

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • page/SecurityOrigin.cpp:

(WebCore::getCachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call getCachedOrigin to get the cached origin first.

LayoutTests:

  • fast/files/file-reader-file-url-expected.txt: Added.
  • fast/files/file-reader-file-url.html: Added.
  • fast/files/resources/file-reader-file-url-iframe.html: Added.
2:53 AM Changeset in webkit [120432] by yosin@chromium.org
  • 20 edits in trunk/Source/WebCore

[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
​https://bugs.webkit.org/show_bug.cgi?id=88980

Reviewed by Kent Tamura.

This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.

No new tests. This patch doesn't change behavior.

  • CMakeLists.txt: Added new file RenderSearchField.cpp
  • GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
  • Target.pri: ditto
  • WebCore.gypi: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.

  • html/InputType.cpp:

(WebCore::InputType::addSearchResult): Added.

  • html/InputType.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.

  • html/SearchInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.

  • rendering/RenderSearchField.h:

(WebCore::toRenderSearchField): Added.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.

  • rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
2:41 AM Changeset in webkit [120431] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium-mac/fast/multicol/client-rects-expected.txt:
2:33 AM Changeset in webkit [120430] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test.
​https://bugs.webkit.org/show_bug.cgi?id=89066

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.clearFileSystem):
(dispatchCallback):
(createDirectory.gotFileSystem):
(createDirectory):
(createFile.gotFileSystem):
(clearFileSystem.gotRoot):
(clearFileSystem.gotRoot.removeAll):
(clearFileSystem.onError):

  • http/tests/inspector/filesystem/read-directory.html:
2:30 AM Changeset in webkit [120429] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=89192

  • platform/chromium/TestExpectations:

Failulre of platform/chromium/accessibility/add-to-menu-list-crashes.html is expected.

2:24 AM Changeset in webkit [120428] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] EFL's LayoutTestController does not support titleTextDirection
​https://bugs.webkit.org/show_bug.cgi?id=86475

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Hajime Morita.

Source/WebKit/efl:

Emit the "title,changed" signal even if the title direction has
changed but not its text.

  • ewk/ewk_frame.cpp:

(ewk_frame_title_set):

Tools:

Add titleTextDirection getter and setter to LayoutTestController and
expose its value to JavaScript.
Update the titleTextDirection value from EFL's "title,changed"
callback in DumpRenderTree.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(getTitleTextDirectionCallback):
(LayoutTestController::staticValues):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::titleTextDirection):
(LayoutTestController::setTitleTextDirection):
(LayoutTestController):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameTitleChanged):

LayoutTests:

Unskip title-directionality tests now that EFL's LayoutTestController
supports titleTextDirection.

  • platform/efl/TestExpectations:
2:20 AM Changeset in webkit [120427] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][WK2] Implement reload / stop in Ewk_View
​https://bugs.webkit.org/show_bug.cgi?id=89168

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add API on the Ewk_View to reload the main frame
and to stop the current load.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_reload):
(ewk_view_stop):

  • UIProcess/API/efl/ewk_view.h:

Tools:

Implement view reload / stop loading in MiniBrowser.
Use 'F5' for reload and 'F6' for stopping the load.

  • MiniBrowser/efl/main.c:

(on_key_down):
(browserCreate):

2:07 AM Changeset in webkit [120426] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium windows rebaseline.

  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
1:55 AM Changeset in webkit [120425] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

A followup for r120413.
​https://bugs.webkit.org/show_bug.cgi?id=89187

We need to update fast/dom/htmlcollection-non-html.html for
HTMLSelectElement::selectedOptions removal.

  • fast/dom/htmlcollection-non-html-expected.txt:
  • fast/dom/htmlcollection-non-html.html:
  • platform/gtk/TestExpectations:
1:45 AM Changeset in webkit [120424] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a CRASH PASS expectation for
storage/websql/quota-tracking.html which crashes intermittently
on release builds.

  • platform/gtk/TestExpectations:
1:41 AM Changeset in webkit [120423] by hbono@chromium.org
  • 8 edits
    2 adds in trunk

Allow platforms to choose whether to remove markers on editing
​https://bugs.webkit.org/show_bug.cgi?id=88838

Reviewed by Hajime Morita.

Source/WebCore:

This change allows platforms to choose whether to remove markers on a word being
edited. WebKit does not remove markers when we move a selection to a markered
word on platforms that shouldEraseMarkersAfterChangeSelection returns false.
On such platforms, WebKit expects to set WTF_USE_MARKER_REMOVAL_UPON_EDITING to
1 so Editor::updateMarkersForWordsAffectedByEditing can remove markers. This
change also checks the return value of shouldEraseMarkersAfterChangeSelection so
platform can choose it. This change also adds grammar markers so it can also
remove grammar markers.

Test: editing/spelling/grammar-edit-word.html

  • editing/Editor.cpp:

(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

Source/WebKit/chromium:

This change implements EditorClientImpl::checkGrammarOfString so
DumpRenderTree can run grammar tests.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::isGrammarCheckingEnabled): Return true also when unified text-checking is enabled.
(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection): ditto.
(WebKit::EditorClientImpl::checkGrammarOfString): Implement this function with our unified text-checker.

Tools:

This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
run grammar tests.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.

LayoutTests:

This change adds a test that verifies WebKit removes a grammar marker from a
grammatically-incorrect word when editing the word.

  • editing/spelling/grammar-edit-word-expected.txt: Added.
  • editing/spelling/grammar-edit-word.html: Added.
1:36 AM Changeset in webkit [120422] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding test expectation for
fast/dom/htmlcollection-non-html.html after r120413.

  • platform/gtk/TestExpectations:
1:15 AM Changeset in webkit [120421] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Simple implementation of the InjectedWebGLScriptSource to support capturing WebGL calls for a frame
​https://bugs.webkit.org/show_bug.cgi?id=89088

Simple experimental implementation of the InjectedWebGLScriptSource.js that allows to wrap
a WebGL context and capture names (for now) of the WebGL function calls for a frame being captured.

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

  • inspector/InjectedWebGLScriptSource.js:

(.):

1:15 AM Changeset in webkit [120420] by eae@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline.

  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
12:50 AM Changeset in webkit [120419] by zandobersek@gmail.com
  • 5 edits in trunk/Tools

Unreviewed, rolling out r120370.
​http://trac.webkit.org/changeset/120370
​https://bugs.webkit.org/show_bug.cgi?id=89183

Broke webkit-patch rebaseline (Requested by zdobersek on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-15

  • Scripts/webkitpy/layout_tests/port/base.py:

(DummyOptions):
(DummyOptions.init):
(DummyOptions.init.this):
(Port.init):
(Port.get_option):
(Port.set_option_default):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.RegisterCygwinOption):
(ChromiumWinTest.RegisterCygwinOption.init):
(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions.update):

12:40 AM Changeset in webkit [120418] by zandobersek@gmail.com
  • 11 edits in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines after r120411.

  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/range/slider-padding-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
12:38 AM Changeset in webkit [120417] by rniwa@webkit.org
  • 220 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in networkinformation, perf, plugins, pointer-lock, printing, scrollbars, and security tests
​https://bugs.webkit.org/show_bug.cgi?id=89181

Reviewed by Kent Tamura.

  • perf/clone-with-focus.html:
  • perf/nested-combined-selectors.html:
  • perf/table-rows-length-caching.html:
  • platform/chromium/plugins/call-as-function.html:
  • platform/chromium/plugins/get-url-with-blank-target2.html:
  • platform/chromium/plugins/get-url-with-iframe-target-no-crash.html:
  • platform/chromium/printing/custom-page-size-style-expected.txt:
  • platform/chromium/printing/custom-page-size-style.html:
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html:
  • platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html:
  • platform/mac-wk2/plugins/contents-scale-factor.html:
  • platform/mac-wk2/plugins/mouse-events-scaled.html:
  • platform/mac/plugins/bindings-array-apply-crash.html:
  • platform/mac/plugins/bindings-objc-long-method-name.html:
  • platform/mac/plugins/bindings-objc-method-name-conversion.html:
  • platform/mac/plugins/bindings-test-objc.html:
  • platform/mac/plugins/call-as-function-test.html:
  • platform/mac/plugins/convert-point.html:
  • platform/mac/plugins/disable-plugins.html:
  • platform/mac/plugins/jsobjc-dom-wrappers.html:
  • platform/mac/plugins/jsobjc-simple.html:
  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled:
  • platform/mac/plugins/root-object-premature-delete-crash.html:
  • platform/mac/plugins/supports-carbon-event-model.html:
  • platform/mac/plugins/testplugin-onnew-onpaint.html:
  • platform/mac/plugins/throw-on-dealloc.html:
  • platform/mac/plugins/undefined-property-crash.html:
  • platform/mac/plugins/update-widget-from-style-recalc.html:
  • platform/mac/plugins/webScriptObject-exception-deadlock.html:
  • platform/mac/scrollbars/key-window-not-first-responder.html:
  • platform/qt/plugins/application-plugin-plugins-disabled.html:
  • platform/win/plugins/call-javascript-that-destroys-plugin.html:
  • platform/win/plugins/get-value-netscape-window.html:
  • platform/win/plugins/iframe-inside-overflow.html:
  • platform/win/plugins/npn-invalidate-rect-invalidates-window.html:
  • platform/win/plugins/visibility-hidden.html:
  • platform/win/plugins/window-geometry-initialized-before-set-window.html:
  • platform/win/plugins/window-region-is-set-to-clip-rect.html:
  • platform/win/plugins/windowless-paint-rect-coordinates.html:
  • plugins/:
  • pointer-lock/lock-fail-responses-expected.txt:
  • pointer-lock/lock-fail-responses.html:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
  • printing/compositing-layer-printing.html:
  • printing/css2.1/README.txt:
  • printing/css2.1/page-break-after-000.html:
  • printing/css2.1/page-break-after-001.html:
  • printing/css2.1/page-break-after-002.html:
  • printing/css2.1/page-break-after-003.html:
  • printing/css2.1/page-break-after-004.html:
  • printing/css2.1/page-break-before-000.html:
  • printing/css2.1/page-break-before-001.html:
  • printing/css2.1/page-break-before-002.html:
  • printing/css2.1/page-break-inside-000.html:
  • printing/iframe-print.html:
  • printing/media-queries-print.html:
  • printing/numberOfPages-expected.txt:
  • printing/page-count-layout-overflow.html:
  • printing/page-count-relayout-shrink.html:
  • printing/page-count-with-one-word.html:
  • printing/page-format-data-display-none.html:
  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
  • printing/page-rule-css-text.html:
  • printing/page-rule-in-media-query.html:
  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:
  • printing/pageNumerForElementById-expected.txt:
  • printing/print-close-crash.html:
  • printing/pseudo-class-outside-page.html:
  • printing/resources/paged-media-test-utils.js:

(pageNumberForElementShouldBe):
(numberOfPagesShouldBe):
(runPrintingTest):

  • printing/return-from-printing-mode.html:
  • printing/script-tests/numberOfPages.js:
  • printing/script-tests/pageNumerForElementById.js:
  • printing/setPrinting.html:
  • printing/simultaneous-position-float-change.html:
  • printing/single-line-must-not-be-split-into-two-pages.html:
  • printing/width-overflow.html:
  • printing/zoomed-document.html:
  • scrollbars/hidden-iframe-scrollbar-crash.html:
  • scrollbars/hidden-iframe-scrollbar-crash2.html:
  • scrollbars/hidden-scrollbar-prevents-layout.html:
  • scrollbars/overflow-custom-scrollbar-crash.html:
  • scrollbars/resources/hidden-iframe-scrollbar-crash2.html:
  • scrollbars/scroll-rtl-or-bt-layer.html:
  • scrollbars/scrollable-iframe-remove-crash.html:
  • scrollbars/scrollbar-click-does-not-blur-content.html:
  • scrollbars/scrollbar-crash-on-refresh.html:
  • scrollbars/scrollbar-drag-thumb-with-large-content.html:
  • scrollbars/scrollbar-gradient-crash.html:
  • scrollbars/scrollbar-iframe-click-does-not-blur-content.html:
  • scrollbars/scrollbar-initial-position.html:
  • scrollbars/scrollbar-middleclick-nopaste.html:
  • scrollbars/scrollbar-miss-mousemove-disabled.html:
  • scrollbars/scrollbar-miss-mousemove.html:
  • scrollbars/scrollbar-owning-renderer-crash.html:
  • scrollbars/scrollbar-part-created-with-no-parent-crash.html:
  • scrollbars/scrollbar-percent-padding-crash.html:
  • scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
  • scrollbars/scrollevent-iframe-no-scrolling-wheel.html:
  • scrollbars/scrollevent-iframe-no-scrolling.html:
  • security/autocomplete-cleared-on-back.html:
  • security/block-test-no-port.html:
  • security/block-test.html:
  • security/set-form-autocomplete-attribute.html:
12:33 AM Changeset in webkit [120416] by rniwa@webkit.org
  • 288 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests
​https://bugs.webkit.org/show_bug.cgi?id=89176

Reviewed by Kent Tamura.

  • ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm:
  • inspector/audits/resources/audits-style1.css:
  • inspector/console/console-long-eval-crash.html:
  • inspector/extensions/extensions-audits-content-script.html:
  • inspector/extensions/extensions-eval-content-script.html:
  • inspector/profiler/cpu-profiler-profiling-without-inspector.html:
  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-receive-response-event.html:
  • inspector/timeline/timeline-timer.html:
  • java/argument-to-object-type.html:
  • java/array-return.html:
  • java/array-sort.html:
  • java/embedding-java-with-object.html:
  • java/inaccessible-class.html:
  • java/inline-applet-crash.html:
  • java/java-and-plugins.html:
  • java/lc3/:
  • jquery/resources/helper.js:
  • loader/go-back-to-different-window-size.html:
  • loader/load-defer-resume-crash.html:
  • loader/navigation-while-deferring-loads.html:
  • loader/reload-subresource-when-type-changes.html:
  • mathml/EmptyMFracCrash.xhtml:
  • mathml/EmptyMunderOverCrash.xhtml:
  • mathml/empty-mroot-crash.xhtml:
  • mathml/empty-msubsup-crash.html:
  • mathml/fenced-whitespace-separators-crash.html:
  • mathml/msub-anonymous-child-render-crash.html:
  • mathml/msubsup-no-grandchild.xhtml:
  • mathml/msubsup-remove-children.xhtml:
  • mathml/munderover-remove-children.html:
  • mathml/operator-hijacks-fenced-node.xhtml:
  • mathml/wbr-in-mroot-crash.html:
  • media/W3C/w3cwrapper.js:

(test):
(async_test.t.done):
(async_test):

  • media/adopt-node-crash.html:
  • media/audio-controls-do-not-fade-out.html:
  • media/audio-controls-rendering.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-garbage-collect.html:
  • media/audio-no-installed-engines.html:
  • media/audio-only-video-intrinsic-size.html:
  • media/audio-repaint.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-drag-timebar.html:
  • media/controls-layout-direction.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-without-preload.html:
  • media/crash-closing-page-with-media-as-plugin-fallback.html:
  • media/fallback.html:
  • media/media-blocked-by-beforeload.html:
  • media/media-blocked-by-willsendrequest.html:
  • media/media-controls-clone-crash.html:
  • media/media-controls-invalid-url.html:
  • media/media-document-audio-repaint.html:
  • media/media-document-audio-size.html:
  • media/media-fullscreen.js:

(canplaythrough):

  • media/media-volume-slider-rendered-normal.html:
  • media/no-auto-play-in-sandbox.html:
  • media/remove-from-document-before-load.html:
  • media/resources/foreignobject-media.svg:
  • media/restore-from-page-cache.html:
  • media/svg-as-image-with-media-blocked.html:
  • media/video-beforeload-remove-source.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas.html-disabled:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-in-media-document.html:
  • media/video-controls-no-scripting.html:
  • media/video-controls-toggling.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-with-mutation-event-handler.html:
  • media/video-delay-load-event.html:
  • media/video-display-toggle.html:
  • media/video-document-types.html:
  • media/video-element-other-namespace-crash.html:
  • media/video-empty-source.html:
  • media/video-no-audio.html:
  • media/video-paint-test.js:

(init.waitForMultipleEvents):
(initAndPause.waitForMultipleEvents):
(initAndPause):

  • media/video-plays-past-end-of-test.html:
  • media/video-poster-blocked-by-willsendrequest.html:
  • media/video-replaces-poster.html:
  • media/video-source-inserted.html:
  • media/video-test.js:

(endTest):

  • media/video-volume-slider.html:
  • media/video-zoom.html:
  • mhtml/check_domain.mht:
  • mhtml/multi_frames.html_original:
  • mhtml/multi_frames_binary.mht:
  • mhtml/multi_frames_ie.mht:
  • mhtml/multi_frames_unmht.mht:
  • mhtml/page_with_css_and_js_ie.mht:
  • mhtml/page_with_css_and_js_unmht.mht:
  • mhtml/page_with_image.html_original:
  • mhtml/page_with_image_ie.mht:
  • mhtml/page_with_image_unmht.mht:
  • mhtml/simple_page.html_original:
  • mhtml/simple_page_ie.mht:
  • mhtml/simple_page_unmht.mht:
  • networkinformation/resources/event-after-navigation-new.html:
  • networkinformation/script-tests/event-after-navigation.js:
  • platform/chromium/media/video-frame-size-change.html:
12:22 AM Changeset in webkit [120415] by eae@chromium.org
  • 20 edits in trunk/LayoutTests

Unreviewed chromium win and mac rebaseline for r120403.

  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium/TestExpectations:
12:19 AM Changeset in webkit [120414] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Add fullscreen button to Chrome video controls for video.
​https://bugs.webkit.org/show_bug.cgi?id=88818

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update.
This patch includes a fullscreen button for video elements and the rendering of the controls
in fullscreen including hiding them after 2 seconds when the mouse is out of the controls
and not moved.

  • css/fullscreen.css:

(video:-webkit-full-screen, audio:-webkit-full-screen):
Add audio to the default fullscreen styling rules.

  • css/mediaControlsChromium.css:

(video:-webkit-full-page-media::-webkit-media-controls-panel):
Align controls to the bottom of the fullscreen page.
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
Include styling for the fullscreen button.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore):
Add a constant for when to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Add member fields for fullscreen button, hiding timer and tracking of whether we are in fullscreen.
(WebCore::MediaControlRootElementChromium::create):
Add fullscreen button element to the visual layout.
(WebCore::MediaControlRootElementChromium::setMediaController):
Add fullscreen button element to the media controller.
(WebCore::MediaControlRootElementChromium::reset):
Show the fullscreen button if the controller supports fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStarted):
Start the timer to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStopped):
Don't hide the controls when the video is paused in fullscreen.
(WebCore::MediaControlRootElementChromium::reportedError):
Hide the fullscreen button when we hit an error.
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
Add logic for mouse events in fullscreen to start/stop the hiding timer.
(WebCore::MediaControlRootElementChromium::startHideFullscreenControlsTimer):
Start the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::hideFullscreenControlsTimerFired):
Timer fired: hide the video controls in fullscreen.
(WebCore::MediaControlRootElementChromium::stopHideFullscreenControlsTimer):
Reset the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::enteredFullscreen):
Add logic to enter fullscreen.
(WebCore::MediaControlRootElementChromium::exitedFullscreen):
Add logic to exit fullscreen.

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):
Add declaration of member functions and fields for fullscreen.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaFullscreenButton):
Use the new image for the fullscreen button.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Declare the fullscreen painting function for Chrome Mac.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Mac.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Skia.

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
Declare the fullscreen painting function for Chrome Skia.

12:13 AM Changeset in webkit [120413] by tkent@chromium.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r110340.
​http://trac.webkit.org/changeset/110340
​https://bugs.webkit.org/show_bug.cgi?id=88749

Source/WebCore:

r110340 added a broken implementation of
HTMLSelectElement::selectedOptions. This roll out removes
HTMLSelectElement::selectedOptions.

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSelectElement.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Removed.
  • fast/dom/HTMLSelectElement/select-selectedOptions.html: Removed.
12:11 AM Changeset in webkit [120412] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix for r120405.

  • platform/chromium/TestExpectations:

Jun 14, 2012:

11:52 PM Changeset in webkit [120411] by keishi@webkit.org
  • 26 edits
    6 copies in trunk

Add color property to input type=range
​https://bugs.webkit.org/show_bug.cgi?id=89067

Reviewed by Kent Tamura.

Source/WebCore:

Adding color property to input type=range in preparation for
supporting tick marks for datalist for input type=range.

  • css/html.css:

(input[type="range"]): Setting color property for input type=range.
This will set the color of tick mark when we implement <datalist>.

  • css/themeChromiumLinux.css:

(input[type=range]):

  • css/themeWin.css:

(input[type="range"]):

LayoutTests:

  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
  • fast/repaint/slider-thumb-float-expected.txt:
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt.
  • platform/chromium-linux/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/fast/repaint/slider-thumb-float-expected.txt.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/mac/fast/forms/range/slider-padding-expected.txt:
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
11:38 PM Changeset in webkit [120410] by tkent@chromium.org
  • 8 edits in trunk/Source

Support file extensions in HTMLInputElement::accept
​https://bugs.webkit.org/show_bug.cgi?id=88298

Reviewed by Hajime Morita.

Source/WebCore:

The WHATWG specification added file extensions supoprt for
HTMLInputElement::accept recently.

In the WebCore FileChooser interface, we rejected invalid MIME type
strings in HTMLInputElement::acceptMIMETypes(), and platform file
choosers don't expect that it containts file extensions. So, this patch
introduces additional member "acceptFileExtensions" to
FileChooserSettings, and it contains only file extensions specified by
an accept attribute.

  • html/FileInputType.cpp:

Sets HTMLInputElement::acceptFileExtensions() to
FileChooserSettings::acceptFileExtensions.
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):

  • html/HTMLInputElement.cpp:

(WebCore::isValidFileExtension): Added.
(WebCore::parseAcceptAttribute):
Common part for acceptMIMETyps() and acceptFileExtensions().
(WebCore::HTMLInputElement::acceptMIMETypes):
Uses parseAcceptAttribute() with isValidMIMEType().
(WebCore::HTMLInputElement::acceptFileExtensions):
Added. Uses parseAcceptAttribute() with isValidFileExtension().

  • html/HTMLInputElement.h:

(HTMLInputElement): Add acceptFileExtensions().

  • platform/FileChooser.h:

(FileChooserSettings): Add acceptFileExtensions and acceptTypes().

  • platform/FileChooser.cpp:

(WebCore::FileChooserSettings::acceptTypes): Added.

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):
Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions.

11:35 PM Changeset in webkit [120409] by eae@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed rebaseline for mac chromium following r120403.

  • platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.
11:33 PM Changeset in webkit [120408] by Kaustubh Atrawalkar
  • 4 edits in trunk/Source/WebKit/chromium

Remove support for counterValueForElementById from chromium port
​https://bugs.webkit.org/show_bug.cgi?id=88851

Reviewed by Adam Barth.

Moved the counterValueForElementById from LayoutTestCotroller to Internals so
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

11:23 PM Changeset in webkit [120407] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in battery status and canvas tests
​https://bugs.webkit.org/show_bug.cgi?id=88761

Reviewed by Tony Chang.

  • batterystatus/resources/event-after-navigation-new.html:
  • batterystatus/script-tests/event-after-navigation.js:
  • canvas/philip/tests.js:

(_addTest.endTest):
(_addTest.window.onload):
(_addTest):

  • canvas/philip/tests/2d.text-custom-font-load-crash.html:
11:18 PM Changeset in webkit [120406] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/Source/WebCore

[chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
​https://bugs.webkit.org/show_bug.cgi?id=89152

Patch by James Robinson <​jamesr@chromium.org> on 2012-06-14
Reviewed by Adrienne Walker.

These files have been unused and not in the build system since r119769

  • platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
  • platform/graphics/chromium/CanvasLayerChromium.h: Removed.
11:17 PM Changeset in webkit [120405] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Cast paddings to int in RenderTableCell
​https://bugs.webkit.org/show_bug.cgi?id=88918

Patch by Emil A Eklund <​eae@chromium.org> on 2012-06-14
Reviewed by Levi Weintraub.

Add test ensuring that table cells does not wrap when using fractional
paddings.

  • fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
  • fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/chromium/TestExpectations:
11:16 PM Changeset in webkit [120404] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection - Crash when manipulating selection by dragging handle
​https://bugs.webkit.org/show_bug.cgi?id=89160

RIMBUG:164970
Avoid to set position in shadow tree to the new selection's base. It
crashes when setting a shadow position to a selection' base.

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-06-14
Reviewed by Antonio Gomes.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

11:13 PM LayoutUnit edited by eae@chromium.org
(diff)
11:07 PM Changeset in webkit [120403] by eae@chromium.org
  • 12 edits
    2 adds in trunk

Cast paddings to int in RenderTableCell
​https://bugs.webkit.org/show_bug.cgi?id=88918

Reviewed by Levi Weintraub.

Source/WebCore:

Table layout uses integers throughout yet the TableCell paddingLeft/
Right/Top/Bottom methods returns LayoutUnits. This causes inconsistent
rounding as some call sites cast the numbers to ints before doing
computation and others do computation before casting.

By changing the methods to always cast the padding values to int we
ensure consistent padding calculations.

Ideally we'd change the type of the return value for the methods but as
they are overriden that would likely cause more confusion.

Test: fast/sub-pixel/table-cells-with-padding-do-not-wrap.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):

LayoutTests:

Add test ensuring that table cells does not wrap when using fractional
paddings.

  • fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
  • fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/chromium/TestExpectations:
10:55 PM Changeset in webkit [120402] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Check the result of FontCache::getCachedFontPlatformData()
​https://bugs.webkit.org/show_bug.cgi?id=89141

Reviewed by Kent Tamura.

The value of FontCache::getCachedFontPlatformData() could be invalid,
so we should check the value before use it.

No new tests. No new functionality.

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getFontDataForCharacters):

10:53 PM Changeset in webkit [120401] by commit-queue@webkit.org
  • 6 edits in trunk

Fix framebuffer completeness test
​https://bugs.webkit.org/show_bug.cgi?id=89127

Patch by Gregg Tavares <​gman@google.com> on 2012-06-14
Reviewed by Kenneth Russell.

No new tests just fixing failing tests.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::initializeAttachments):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
(WebCore::GraphicsContext3D::getChannelBitsByFormat):

  • platform/graphics/GraphicsContext3D.h:
10:29 PM Changeset in webkit [120400] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed expectation update.

  • Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html
  • platform/chromium/TestExpectations:
10:24 PM Changeset in webkit [120399] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] empty plugin cause browser hang
​https://bugs.webkit.org/show_bug.cgi?id=89091

Reviewed by Rob Buis.

Add check before clean pluginView in FrameLoaderBlackBerry in case
it didn't have any content.
RIM PR# 165336
Reviewed internally by George Staikos

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

9:59 PM Changeset in webkit [120398] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Make TiledLayerChromium robust to unexpected null tiles
​https://bugs.webkit.org/show_bug.cgi?id=89143

Reviewed by James Robinson.

Although there shouldn't ever be null tiles in the map, it appears to
be occurring frequently enough to show up in crash reports. In the
short term, be robust to this so the tiler doesn't crash. This should
eventually be reverted.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

9:34 PM Changeset in webkit [120397] by tkent@chromium.org
  • 12 edits
    4 adds in trunk

Validate form state strings in FormController::setStateForNewFormElements()
​https://bugs.webkit.org/show_bug.cgi?id=88768

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.

Source/WebCore:

Reject invalid form state vectors. This state vectors are generated by
WebKit itself. However it can be invalid because

  • Serialized state vectors can be corrupted
  • A future version of WebKit might change the format

So we had better reject unexpected state vectors as possible.

Test: fast/forms/state-restore-broken-state.html

  • WebCore.exp.in: Expose some symbols used by Internals.cpp.
  • html/FormController.cpp:

(WebCore::isNotFormControlTypeCharacter): A helper for state validation.
(WebCore::FormController::setStateForNewFormElements):
Reject state vectors of which size is not a multiple of 3, or a type name is invalid.

  • testing/Internals.cpp:

(WebCore::Internals::formControlStateOfPreviousHistoryItem):
Returns a form state vector of the previous document.
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
Sets a form state vector for the previous document.

  • testing/Internals.h: Declare new functions.
  • testing/Internals.idl: ditto.

Source/WebKit2:

  • win/WebKit2.def: Expose some symbols used by Internals.cpp.
  • win/WebKit2CFLite.def: ditto.

LayoutTests:

  • fast/forms/resources/state-restore-broken-state-1.html: Added.
  • fast/forms/resources/state-restore-broken-state-2.html: Added.
  • fast/forms/state-restore-broken-state-expected.txt: Added.
  • fast/forms/state-restore-broken-state.html: Added.
9:21 PM Changeset in webkit [120396] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r120393.
​http://trac.webkit.org/changeset/120393
​https://bugs.webkit.org/show_bug.cgi?id=89163

breaks cr-mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(ImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(turboSwizzled):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode):
(JPEGImageReader):
(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::currentBufferSize):
(PNGImageReader):
(WebCore::PNGImageReader::decodingSizeOnly):
(WebCore::PNGImageReader::interlaceBuffer):
(WebCore::PNGImageReader::hasAlpha):
(WebCore::PNGImageReader::setHasAlpha):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore):
(WebCore::resolveColorSpace):
(WebCore::createColorSpace):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • platform/chromium/TestExpectations:
9:17 PM Changeset in webkit [120395] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

RenderLayer subtrees without any self-painting layer shouldn't be walked during painting
​https://bugs.webkit.org/show_bug.cgi?id=88888

Reviewed by Simon Fraser.

Performance optimization, covered by existing tests.

The gist of this change is to add a has-self-painting-layer-descendant flag (including an
invalidation logic) that is used to avoid walking subtrees without any self-painting layer.

On ​http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms
on my machine. The test case is a pathologic example here but the optimization should
apply in other cases.

The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that
got repurposed and renamed as part of this change.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::styleChanged):
These functions were updated to dirty / set the new flag.

(WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus):
(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
Added those functions to handle setting / invalidating the new flag.

(WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange):
Added this function to handle style update.

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
Changed this logic to bail out if we have no self-painting descendants. This is what
is giving the performance improvement. Also added some performance ASSERTs to ensure
the methods are not called when they shouldn't.

(WebCore::RenderLayer::updateDescendantDependentFlags):
Renamed from updateVisibilityStatus to account for the new usage.

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::collectLayers):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Updated after updateVisibilityStatus rename.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasSelfPaintingLayerDescendant):
Added the declaration of the new functions as well as the new flag and dirty bit.

8:06 PM Changeset in webkit [120394] by wangxianzhu@chromium.org
  • 5 edits in trunk

[Chromium-Android] Initialize font rendering in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=89133

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • src/linuxish/WebFontRendering.cpp:

(WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit):

7:53 PM Changeset in webkit [120393] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port

​https://bugs.webkit.org/show_bug.cgi?id=81974

Reviewed by Adam Barth.

Covered by existing layout tests which will be rebaselined.

  • WebCore.gyp/WebCore.gyp: Add qcms to the build.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.

(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <​tpayne@chromium.org> on 2012-06-14

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <​tpayne@chromium.org> on 2012-06-14

  • wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB

to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

7:50 PM Changeset in webkit [120392] by commit-queue@webkit.org
  • 10 edits
    3 deletes in trunk

Unreviewed, rolling out r120384.
​http://trac.webkit.org/changeset/120384
​https://bugs.webkit.org/show_bug.cgi?id=89157

breaks create-blob-url-from-data-url.html (Requested by
morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

Source/WebCore:

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::createBlobURL):

  • fileapi/BlobURL.h:

(BlobURL):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):

  • fileapi/ThreadableBlobRegistry.h:

(WebCore):
(ThreadableBlobRegistry):

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create):

LayoutTests:

  • fast/files/file-reader-file-url-expected.txt: Removed.
  • fast/files/file-reader-file-url.html: Removed.
  • fast/files/resources/file-reader-file-url-iframe.html: Removed.
7:46 PM Changeset in webkit [120391] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=89132

Reviewed by Adam Barth.

This test is currently in src/webkit/glue/iframe_redirect_unittest.cc
and uses test_shell's layoutTestController. Moving this will make
it easier to get rid of layoutTestController in test_shell.

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/data/iframe_redirect.html: Added.
7:25 PM Changeset in webkit [120390] by yosin@chromium.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=89155

Reviewed by Kent Tamura.

This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.

No new tests. This patch doesn't change behavior.

  • rendering/RenderSearchField.cpp: Added.

(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderSearchField.h: Added.

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):

7:11 PM Changeset in webkit [120389] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

[JSC/V8] "DOMString[]" for function return values should not be null
​https://bugs.webkit.org/show_bug.cgi?id=89151

Reviewed by Kentaro Hara.

jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
we should not return JavaScript null object.

No new tests. We have no plan to use this code in production code for
now. It will be used for window.internals functions.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray): For null input, returns an empty array, not null.

  • bindings/v8/V8Binding.cpp:

(WebCore::v8Array): Implement DOMStringList -> JavaScript array conversion.
Like jsArray(), we don't return null object.

  • bindings/v8/V8Binding.h:

(WebCore): Declare v8Array().

7:04 PM Changeset in webkit [120388] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk

Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
​https://bugs.webkit.org/show_bug.cgi?id=89129

Source/WebCore:

As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium. A
long standing issue (~3 years) has been to disable this feature.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

Uses existing click/double-click test.

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

LayoutTests:

Fixes layout test to actually test what it says it tests. Previously it was
testing the opposite behavior and passing because MediaDocument auto-plays.

Additionally failing one half of the test would still allow you to pass the
other half. Both issues have been fixed.

Updates the test expectations for Chromium to reflect a failure.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

  • media/video-click-dblckick-standalone-expected.txt:
  • media/video-click-dblckick-standalone.html:
  • platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.
6:54 PM ScalesAndZooms edited by jamesr@google.com
(diff)
6:45 PM Changeset in webkit [120387] by jianli@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed. Skip the failed test due to r120384 for future investigation.

  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
6:32 PM Changeset in webkit [120386] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=88622

Patch by Dongwoo Im <​dw.im@samsung.com> on 2012-06-14
Reviewed by Philippe Normand.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

6:26 PM Changeset in webkit [120385] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Should retry a few times when failed to start DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=89124

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver._start_once):

5:57 PM Changeset in webkit [120384] by jianli@chromium.org
  • 10 edits
    3 adds in trunk

FileReader is dysfunctional in documents with "null" origin string
​https://bugs.webkit.org/show_bug.cgi?id=78648

Reviewed by Adam Barth.

Source/WebCore:

The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.

Test: fast/files/file-reader-file-url.html

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.

  • fileapi/BlobURL.h:

(BlobURL):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::cachedOrigin): Retrieve the origin associated with the blob URL.

  • fileapi/ThreadableBlobRegistry.h:

(WebCore):
(ThreadableBlobRegistry):

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • page/SecurityOrigin.cpp:

(WebCore::cachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call cachedOrigin to get the cached origin first.

LayoutTests:

  • fast/files/file-reader-file-url-expected.txt: Added.
  • fast/files/file-reader-file-url.html: Added.
  • fast/files/resources/file-reader-file-url-iframe.html: Added.
5:56 PM Changeset in webkit [120383] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add test cases for header/footer elements' AXRoleDescription
​https://bugs.webkit.org/show_bug.cgi?id=88911

Header and footer elements change their accessibility roles depending
on the elements which contain them. Specifically, they are described
as "banner" or "footer" in the general case, and fall back to
generic "group" role descriptions when contained in either article or
section elements. This patch simply tests that existing behavior on
Mac.

Patch by Mike West <​mkwst@chromium.org> on 2012-06-14
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/footer-expected.txt: Added.
  • platform/mac/accessibility/footer.html: Added.
  • platform/mac/accessibility/header-expected.txt: Added.
  • platform/mac/accessibility/header.html: Added.
5:51 PM Changeset in webkit [120382] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake
​https://bugs.webkit.org/show_bug.cgi?id=89015

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-14
Reviewed by Antonio Gomes.

Include JSDeprecatedPeerConnectionCustom.cpp in UseJSC.cmake
instead of CMakeLists.txt.

No change in functionality so no new tests.

  • CMakeLists.txt:
  • UseJSC.cmake:
5:43 PM Changeset in webkit [120381] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background.
​https://bugs.webkit.org/show_bug.cgi?id=89033

Patch by David Reveman <​reveman@chromium.org> on 2012-06-14
Reviewed by James Robinson.

Add canvas background argument to PageWidgetDelegate::paint and call
PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel
rendering is only used when WebView has opaque background.

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/PageWidgetDelegate.h:
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):

5:35 PM Changeset in webkit [120380] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug
​https://bugs.webkit.org/show_bug.cgi?id=89065

Reviewed by James Robinson.

A debug assertion was being triggered in the hit-testing unit
tests because I accidentally forgot to set the
DebugScopedSetImplThread for the tests.

This patch also re-enables the disabled broken test.

  • tests/CCLayerTreeHostCommonTest.cpp:
5:12 PM Changeset in webkit [120379] by wangxianzhu@chromium.org
  • 6 edits in trunk/Source

[Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering
​https://bugs.webkit.org/show_bug.cgi?id=89014

Reviewed by James Robinson.

Source/WebCore:

No new tests because of no change of functionality.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • public/linuxish/WebFontRendering.h:

(WebFontRendering):

  • src/linuxish/WebFontRendering.cpp:

(WebKit):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):

5:06 PM Changeset in webkit [120378] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r120364 -> <rdar://problem/11629106>

5:03 PM Changeset in webkit [120377] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r120329 -> <rdar://problem/11449702>

5:03 PM Changeset in webkit [120376] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

DrawingArea: Painting is being resumed while the view is not visible
​https://bugs.webkit.org/show_bug.cgi?id=88940
<rdar://problem/11652545>

Reviewed by Dean Jackson.

Using requestAnimationFrame and the fullscreen API on a DrawingArea-backed window would cause
rAF to permanently suspend animations after entering full-screen mode, because of the following:

  1. JavaScript causes fullscreen transition to start.
  2. Painting (and rAF) are suspended.
  3. The page changes size.
    1. DrawingAreaProxyImpl::sizeDidChange() calls DrawingAreaImpl::updateBackingStoreState, which calls DrawingAreaImpl::resumePainting.
    2. DrawingAreaImpl::resumePainting resumes painting, but does *not* resume rAF, because windowIsVisible is (legitimately) false.
  4. The view becomes visible, windowIsVisible is updated to true.
  5. visibilityDidChange() calls resumePainting again, but this time it early exits because painting is not suspended.

Notice that because of the early exit in 4, rAF is never resumed.

To solve this and prevent any further bugs caused by these unnecessary calls to resume/suspendPainting,
temporarily stop sending SuspendPainting/ResumePainting messages from DrawingAreaProxyImpl::visibilityDidChange
during the window animations that occur while entering and exiting full-screen.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView setAutomaticallySuspendAndResumePainting:]):
(-[WKView automaticallySuspendAndResumePainting]):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::visibilityDidChange):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setShouldSuspendAndResumePainting):
(WebKit::WebPageProxy::shouldSuspendAndResumePainting):

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):

4:59 PM Changeset in webkit [120375] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectation after r120371.

  • platform/chromium/TestExpectations:
4:54 PM Changeset in webkit [120374] by tonyg@chromium.org
  • 2 edits in trunk/Tools

Update webpagereplay to 1.1.2
​https://bugs.webkit.org/show_bug.cgi?id=89118

This includes the following patch which avoids pkg_resources import errors:
​http://code.google.com/p/web-page-replay/source/detail?r=476

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_webpagereplay):

4:53 PM Changeset in webkit [120373] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Always convert touch events to mouse events if the
meta-tag TouchEventMode::PureWithMouseConversion is set.
Minor style fix.
​https://bugs.webkit.org/show_bug.cgi?id=89115

Patch by Genevieve Mak <​gmak@rim.com> on 2012-06-14
Reviewed by Antonio Gomes.

Reviewed Internally by Antonio Gomes.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

4:39 PM Changeset in webkit [120372] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update of chromium TestExpectations to mark hybi/workers/close.html as failing.

  • platform/chromium/TestExpectations:
4:28 PM Changeset in webkit [120371] by rniwa@webkit.org
  • 13 edits in trunk

Get rid of FAIL test expectation
​https://bugs.webkit.org/show_bug.cgi?id=89137

Reviewed by Dirk Pranke.

Tools:

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_summarized_results_wontfix):

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(result_was_expected):
(suffixes_for_expectations):
(TestExpectationsModel._add_test):
(TestExpectations):
(TestExpectations.get_rebaselining_failures):
(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(FunctionsTest.test_result_was_expected):
(FunctionsTest.test_suffixes_for_expectations):
(TestExpectationSerializerTests.test_parsed_expectations_string):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_test_expectations):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_valid_expectations):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
4:18 PM Changeset in webkit [120370] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
​https://bugs.webkit.org/show_bug.cgi?id=89135

Reviewed by Ryosuke Niwa.

This patch is just some minor cleanup and simplification. There
should be no functional changes here.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.get_option):
(Port.set_option_default):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions.ensure_value):

4:09 PM Changeset in webkit [120369] by ryuan.choi@samsung.com
  • 9 edits in trunk/Source

[EFL] Move cursor related code from WidgetEfl to ewk_view and EflScreenUtilities.
​https://bugs.webkit.org/show_bug.cgi?id=88803

Reviewed by Chang Shu.

Because WebProcess can not control cursor,
setCursor should be passed to ChromeClient like other ports.

Source/WebCore:

  • platform/Widget.h:

(Widget):

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::applyFallbackCursor): Moved from WidgetEfl.cpp.
(WebCore):
(WebCore::isUsingEcoreX): Moved from WidgetEfl.cpp.

  • platform/efl/EflScreenUtilities.h:

(WebCore):

  • platform/efl/WidgetEfl.cpp: Removes cursor related codes.

(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::~Widget):
(WebCore::Widget::setCursor): Redirect to HostWindow.
(WebCore::Widget::setEvasObject):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setCursor):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new): Check whether ecore_x can be used.
(_ewk_view_priv_del):
(_ewk_view_smart_add):
Change order of initialization to use base structure in _ewk_view_priv_new.
(ewk_view_cursor_set): Moved from Widget::applyCursor.

  • ewk/ewk_view_private.h:

(WebCore):

4:00 PM Changeset in webkit [120368] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Implement computeRAMSize for QNX
​https://bugs.webkit.org/show_bug.cgi?id=89110

Patch by Yong Li <​yoli@rim.com> on 2012-06-14
Reviewed by Rob Buis.

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

3:38 PM Changeset in webkit [120367] by rniwa@webkit.org
  • 19 edits in trunk

Radio node lists do not get updated when inserted back into a document
​https://bugs.webkit.org/show_bug.cgi?id=88825

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by RadioNodeList's m_node not being adjusted back to a document after
it was removed from the document and inserted back. While we could be doing this adjustment again
when the HTMLFormElement is inserted back into the document, this whole approach is fragile
because adds a maintenance burden on root elements of RadioNodeList.

Change the approach to the problem instead and detect when m_node is detached from the document.
Now RadioNodeList and LabelsNodeList will always use its root element as m_node and
DynamicSubtreeNodeList's node() will then determine whether it should use its document or not based
on the flag (rootedAtDocument) passed by the constructor of the node list and m_node->inDocument().

Also invalidate node lists rooted at the document level regardless where the DOM mutation took place.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):

  • dom/Document.cpp:

(WebCore::Document::registerDynamicSubtreeNodeList): Moved from Node.
(WebCore::Document::unregisterDynamicSubtreeNodeList): Ditto.

  • dom/Document.h:

(Document):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Takes DynamicNodeListRootType which tell us
whether node() should return m_node's document by default or not.
(WebCore::DynamicSubtreeNodeList::length): Refactor code to avoid node() multiple times.
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent): Ditto.
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent): Ditto.
(WebCore::DynamicNodeList::itemWithName): Ditto.

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicNodeList::node): Returns m_node->document() if m_node is still in the document and
the node list was rooted at document.
(WebCore::DynamicNodeList::Caches::Caches):
(Caches):
(DynamicNodeList):
(DynamicSubtreeNodeList):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::~NameNodeList):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Invalidate m_listsInvalidatedAtDocument
at document instead of trying to invalidate it on every ancestor we traverse.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Ditto.
(WebCore::NodeListsNodeData::invalidateCachesForDocument): Extracted from
invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
(WebCore::Node::radioNodeList):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::~TagNodeList):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removedFrom):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList): Takes Element* first since that's the order we use elsewhere.

  • html/RadioNodeList.h:

(WebCore::RadioNodeList::create):
(RadioNodeList):

LayoutTests:

Add a test case to an existing test.

  • fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt:
  • fast/forms/radionodelist-whose-form-element-detached-from-domtree.html:
3:33 PM Changeset in webkit [120366] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix bit packing of StyleRareInheritedData on Windows
​https://bugs.webkit.org/show_bug.cgi?id=89112

Reviewed by Ryosuke Niwa.

On my machine (64 bit Chromium Linux), StyleRareInheritedData is 168 bytes.

No new tests, added a compile assert to ensure correctness going forward.

  • rendering/style/StyleRareInheritedData.cpp:

(SameSizeAsStyleRareInheritedData):
(WebCore):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

3:24 PM Changeset in webkit [120365] by Lucas Forschler
  • 49 edits
    8 copies in branches/safari-536-branch

Merged r120357 -> <rdar://problem/11033898>

3:21 PM Changeset in webkit [120364] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
<​http://webkit.org/b/88846>
<rdar://problem/11629106>

Reviewed by Brady Eidson.

Put isolatedCopy() strings in the retain/release operation queues to make sure it's safe
for secondary threads to ref/deref them in performPendingRetainAndReleaseOperations().
Also added assertions as appropriate.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

3:00 PM Changeset in webkit [120363] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium/linux] Drop deprecated WebFontRenderStyle::useSubpixel
​https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <​derat@chromium.org> on 2012-06-14
Reviewed by Adam Barth.

This removes the useSubpixel member, which was replaced by
useSubpixelRendering. Chrome has been updated to set only the
useSubpixelRendering field.

No test updates since the existing behavior shouldn't change.

  • public/linux/WebFontInfo.h:

(WebFontInfo):

  • public/linux/WebFontRenderStyle.h:
  • src/linux/WebFontInfo.cpp:

(WebKit::WebFontInfo::renderStyleForStrike):

  • src/linux/WebFontRenderStyle.cpp:

(WebKit::WebFontRenderStyle::toFontRenderStyle):
(WebKit::WebFontRenderStyle::setDefaults):

2:45 PM Changeset in webkit [120362] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
​https://bugs.webkit.org/show_bug.cgi?id=89049

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCLayerTreeHostCommonTest.cpp:

CCLayerTreeHostCommonTest.verifyHitTestingForUninvertibleTransform

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::pointHitsRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
2:15 PM Changeset in webkit [120361] by mjs@apple.com
  • 3 edits in trunk/Source/WebCore

The whole world rebuilds when you touch any IDL file
​https://bugs.webkit.org/show_bug.cgi?id=89125

Reviewed by Sam Weinig.

No new tests; this only changes the build system and its dependencies.

  • bindings/scripts/preprocess-idls.pl: Optionally generate the

dependencies for supplemental IDLs in Makefile format.

  • DerivedSources.make: Use the new feature of preprocess-idls.pl to generate

the correct IDL dependencies created by Supplemental, then include it. This way,
we avoid the situation where every bindings file implicitly depends on every single
IDL file in the project.

1:41 PM Changeset in webkit [120360] by commit-queue@webkit.org
  • 45 edits
    3 adds in trunk

[chromium] Certain settings in CCSettings could be global
​https://bugs.webkit.org/show_bug.cgi?id=88384

Patch by Ian Vollick <​vollick@chromium.org> on 2012-06-14
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebCore):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

No new tests. No new functionality.

  • WebCore.gypi:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:

(WebCore):
(CCDebugRectHistory):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawDebugRects):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::settings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRendererClient):
(WebCore::CCRenderer::settings):

  • platform/graphics/chromium/cc/CCSettings.cpp: Added.

(WebCore):
(WebCore::CCSettings::perTilePaintingEnabled):
(WebCore::CCSettings::setPerTilePaintingEnabled):
(WebCore::CCSettings::partialSwapEnabled):
(WebCore::CCSettings::setPartialSwapEnabled):
(WebCore::CCSettings::acceleratedAnimationEnabled):
(WebCore::CCSettings::setAcceleratedAnimationEnabled):
(WebCore::CCSettings::reset):

  • platform/graphics/chromium/cc/CCSettings.h: Added.

(WebCore):
(CCSettings):

  • testing/InternalSettings.cpp:
  • testing/InternalSettings.h:

(InternalSettings):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebCompositor.h:

(WebCompositor):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::shutdown):
(WebKit):
(WebKit::WebCompositor::setPerTilePaintingEnabled):
(WebKit::WebCompositor::setPartialSwapEnabled):
(WebKit::WebCompositor::setAcceleratedAnimationEnabled):

  • src/WebLayerTreeView.cpp:

(WebKit):
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):

  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestShortlived1):
(WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1):
(WTF::CCLayerTreeHostTestShortlived1::beginTest):
(WTF::CCLayerTreeHostTestShortlived1::afterTest):

  • tests/CCTestCommon.h: Added.

(WebKitTests):
(CCScopedSettings):
(WebKitTests::CCScopedSettings::CCScopedSettings):
(WebKitTests::CCScopedSettings::~CCScopedSettings):

  • tests/CCThreadedTest.cpp:

(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::CCThreadedTest::runTest):

  • tests/CCThreadedTest.h:

(CCThreadedTest):
(MockLayerTreeHostImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/LayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(LayerRendererChromiumTest):
(TEST_F):
(TEST):

  • tests/TextureLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::TEST):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::setPerTilePaintingEnabled):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

1:36 PM Changeset in webkit [120359] by alex
  • 12 edits
    1 copy
    2 deletes in trunk/Source

2012-06-14 Alejandro G. Castro <​alex@igalia.com>

[GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path
​https://bugs.webkit.org/show_bug.cgi?id=73634

Add the new graphics layer client that uses cairo to render the
composition. The cairo transformations do not support perspective
so in perspective cases we have just a representation not the real
perspective transformation.

This patch adds a new implementation of already tested cases.

Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • WebCoreSupport/AcceleratedCompositingContext.h: (AcceleratedCompositingContext):
  • WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Added.
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateWidgetRect): We need to invalidate the widget in this case because we do not directly render to a texture but to the widget surface. (WebKit::ChromeClient::paint): We can not render here, we have to invalidate and wait for the widget rendering.
  • webkit/webkitwebview.cpp: (webkit_web_view_draw): In this case the renderLayersToWindow requires the graphics context used to render in the window. (webkit_web_view_realize): Small cleanup of the priv variable definition.

2012-06-14 Alejandro G. Castro <​alex@igalia.com>

[GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path
​https://bugs.webkit.org/show_bug.cgi?id=73634

Remove the TextureMapperCairo classes, now we use
TextureMapperImageBuffer to implement the software fallback. Add
implementation for the 3D transformations in the 2D cairo graphics
context.

Reviewed by Martin Robinson.

This patch adds a new implementation of already tested cases.

  • GNUmakefile.list.am:
  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: (WebCore): (WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Required for compilation when WebGL is enabled.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::get3DTransform): (WebCore::GraphicsContext::concat3DTransform): (WebCore::GraphicsContext::set3DTransform):
  • platform/graphics/cairo/TextureMapperCairo.cpp: Removed.
  • platform/graphics/cairo/TextureMapperCairo.h: Removed.
  • platform/graphics/texmap/TextureMapperImageBuffer.cpp: (WebCore::BitmapTextureImageBuffer::updateContents):
1:23 PM Changeset in webkit [120358] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed, rolling out r120352.
​http://trac.webkit.org/changeset/120352
​https://bugs.webkit.org/show_bug.cgi?id=89120

It seems something is still wrong with it :/ (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

1:22 PM Changeset in webkit [120357] by jpu@apple.com
  • 49 edits
    8 adds in trunk

Mark text with text alternative with blue underline.
​https://bugs.webkit.org/show_bug.cgi?id=83047

Reviewed by Enrica Casucci.

Tests: platform/mac/editing/input/edit-dictated-text-with-alternative.html

platform/mac/editing/input/insert-dictated-text.html

This patch implements visual indication on dictated text with alternatives, and provides UI
to show alternative text on OS X. Majority of the changes is for generalizing existing AlternativeTextController
class to handle dictation alternatives. The two new classes, AlternativeTextUIController and
TextAlternativeWithRange, are used by both WebKit and WK2. So WebCore seems to be the natural place
for them.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/AlternativeTextController.cpp: Expanded exising class interface to support dictation alternatives.

(DictationAlternativeDetails): Marker detail class for dictation alternative mark.
(WebCore::DictationAlternativeDetails::create):
(WebCore::DictationAlternativeDetails::dictationContext):
(WebCore::DictationAlternativeDetails::DictationAlternativeDetails):
(WebCore::markerTypesForAppliedDictationAlternative):
(WebCore::AlternativeTextController::applyAlternativeTextToRange): Generalized existing applyAlternativeTextToRange() to handle dictation alternatives.
(WebCore::AlternativeTextController::timerFired): Expanded existing code to handle dictation alternatives.
(WebCore::AlternativeTextController::handleAlternativeTextUIResult): Expanded existing code to handle dictation alternatives.
(WebCore::AlternativeTextController::respondToChangedSelection): Moved part of the function into respondToMarkerAtEndOfWord() to improve readability.
(WebCore::AlternativeTextController::shouldStartTimerFor):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::markerDescriptionForAppliedAlternativeText):
(WebCore::AlternativeTextController::removeDictationAlternativesForMarker):
(WebCore::AlternativeTextController::dictationAlternativesForMarker):
(WebCore::AlternativeTextController::applyDictationAlternative):

  • editing/AlternativeTextController.h:
  • editing/Editor.cpp:

(WebCore::Editor::notifyComponentsOnChangedSelection): Renamed existing respondToChangedSelection() function to avoid naming collision.
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::dictationAlternativesForMarker):
(WebCore::Editor::applyDictationAlternativelternative):

  • editing/Editor.h:
  • editing/FrameSelection.h:
  • editing/mac/AlternativeTextUIController.h: Added. WK1 and WK2 use this class to keep track of text alternatives objects.

(AlternativeTextUIController):
(WebCore::AlternativeTextUIController::AlternativeTextUIController):
(AlernativeTextContextController):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::AlernativeTextContextController):

  • editing/mac/AlternativeTextUIController.mm: Added.

(WebCore::AlternativeTextUIController::AlernativeTextContextController::addAlternatives):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::removeAlternativesForContext):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::clear):
(WebCore::AlternativeTextUIController::addAlternatives):
(WebCore::AlternativeTextUIController::alternativesForContext):
(WebCore::AlternativeTextUIController::clear):
(WebCore::AlternativeTextUIController::showAlternatives):
(WebCore::AlternativeTextUIController::handleAcceptedAlternative):
(WebCore::AlternativeTextUIController::dismissAlternatives):
(WebCore::AlternativeTextUIController::removeAlternatives):

  • editing/mac/TextAlternativeWithRange.h: Added. A simple struct to make it easier to pass around a pair of text alternatives object and range.
  • editing/mac/TextAlternativeWithRange.mm: Added.

(WebCore::TextAlternativeWithRange::TextAlternativeWithRange):
(WebCore::collectDictationTextAlternatives):

  • page/AlternativeTextClient.h:
  • page/ContextMenuController.cpp: Added code to show alternative dictated text in context menu.

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::dictationAlternatives):

  • rendering/HitTestResult.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarker):

Changes in WebKit include implementation of new functions declared in AlternativeTextClient,
and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's
alternatives attached to the input string.

  • WebCoreSupport/CorrectionPanel.mm:

(correctionIndicatorType):
(CorrectionPanel::handleAcceptedReplacement):

  • WebCoreSupport/WebAlternativeTextClient.h:

(WebAlternativeTextClient):

  • WebCoreSupport/WebAlternativeTextClient.mm:

(WebAlternativeTextClient::showCorrectionAlternative):
(WebAlternativeTextClient::dismissAlternative):
(WebAlternativeTextClient::dismissAlternativeSoon):
(WebAlternativeTextClient::recordAutocorrectionResponse):
(WebAlternativeTextClient::removeDictationAlternatives):
(WebAlternativeTextClient::showDictationAlternativeUI):
(WebAlternativeTextClient::dismissDictationAlternativeUI):
(WebAlternativeTextClient::dictationAlternatives):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView validAttributesForMarkedText]):
(-[WebHTMLView insertText:]):

  • WebView/WebView.mm:

(-[WebView handleAcceptedAlternativeText:]):
(-[WebView _getWebCoreDictationAlternatives:fromTextAlternatives:]):
(-[WebView _showDictationAlternativeUI:WebCore::forDictationContext:]):
(-[WebView _dismissDictationAlternativeUI]):
(-[WebView _removeDictationAlternatives:]):
(-[WebView _dictationAlternatives:]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

Changes in WebKit2 include implementation of new functions declared in AlternativeTextClient,
and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's
alternatives attached to the input string.

  • Shared/API/c/WKContextMenuItemTypes.h:
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::pageClosed):
(WebKit::PageClientImpl::addDictationAlternatives):
(WebKit::PageClientImpl::removeDictationAlternatives):
(WebKit::PageClientImpl::showDictationAlternativeUI):
(WebKit::PageClientImpl::dictationAlternatives):
(WebKit::PageClientImpl::dismissDictationAlternativeUI):

  • UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView validAttributesForMarkedText]):
(-[WKView handleAcceptedAlternativeText:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::dismissDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/CorrectionPanel.mm:

(correctionIndicatorType):
(WebKit::CorrectionPanel::handleAcceptedReplacement):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::insertDictatedText):

  • WebProcess/WebCoreSupport/WebAlternativeTextClient.h:

(WebAlternativeTextClient):

  • WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:

(WebKit::WebAlternativeTextClient::showCorrectionAlternative):
(WebKit::WebAlternativeTextClient::dismissAlternative):
(WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
(WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
(WebKit::WebAlternativeTextClient::removeDictationAlternatives):
(WebKit::WebAlternativeTextClient::showDictationAlternativeUI):
(WebKit::WebAlternativeTextClient::dismissDictationAlternativeUI):
(WebKit::WebAlternativeTextClient::dictationAlternatives):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::insertDictatedText):

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac/editing/input/edit-dictated-text-with-alternative-expected.txt: Added.
  • platform/mac/editing/input/edit-dictated-text-with-alternative.html: Added.
  • platform/mac/editing/input/insert-dictated-text-expected.txt: Added.
  • platform/mac/editing/input/insert-dictated-text.html: Added.
  • DumpRenderTree/mac/TextInputController.m:

(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):

1:18 PM Changeset in webkit [120356] by ggaren@apple.com
  • 4 edits in trunk/Source/WTF

ARMv7 should support spinlocks
​https://bugs.webkit.org/show_bug.cgi?id=88957

Reviewed by Darin Adler.

More info @ ​http://infocenter.arm.com/help/topic/
com.arm.doc.genc007826/Barrier_Litmus_Tests_and_Cookbook_A08.pdf

  • wtf/Atomics.h:

(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock): Added memory barrier primitives since
ARMv7 has a weakly ordered memory model.

  • wtf/Platform.h: Enabled compare-and-swap on Windows so our spinlock

implementation would continue working on Windows.

  • wtf/TCSpinLock.h:

(TCMalloc_SpinLock::Lock):
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SpinLock): Use our compare-and-swap helper function to avoid
rewriting it in assembly here.

Added memory barriers since ARMv7 needs them.

Removed PPC support because our helper function doesn't support PPC.

1:15 PM Changeset in webkit [120355] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed, rolling out r120353.
​http://trac.webkit.org/changeset/120353
​https://bugs.webkit.org/show_bug.cgi?id=89119

It seems we still need this workaround (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

1:08 PM Changeset in webkit [120354] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
​https://bugs.webkit.org/show_bug.cgi?id=88813

Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderTableSection::calcRowLogicalHeight to round the
logicalHeight instead of flooring it. This matches our rounding logic
elsewhere and results in table rows better matching the expected height.

Test: fast/sub-pixel/table-rows-have-stable-height.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Add new test ensuring that rows are laid out the desired height when
given a height that maps to a device pixel value.

  • fast/sub-pixel/table-rows-have-stable-height-expected.txt: Added.
  • fast/sub-pixel/table-rows-have-stable-height.html: Added.
1:02 PM Changeset in webkit [120353] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg cleanup, remove unnecessary workaround
​https://bugs.webkit.org/show_bug.cgi?id=88994

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

1:02 PM Changeset in webkit [120352] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
​https://bugs.webkit.org/show_bug.cgi?id=89001

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

1:02 PM Changeset in webkit [120351] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unhide login form on the build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=88981

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
12:52 PM Changeset in webkit [120350] by zandobersek@gmail.com
  • 133 edits
    98 adds in trunk

[Gtk] Add support in DumpRenderTree for tracking repaints
​https://bugs.webkit.org/show_bug.cgi?id=87658

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add methods to the DumpRenderTreeSupport class for controlling the
status of repaint tracking along with retreiving and resetting the
tracked repaints.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setTracksRepaints):
(DumpRenderTreeSupportGtk::isTrackingRepaints):
(DumpRenderTreeSupportGtk::trackedRepaintRects):
(DumpRenderTreeSupportGtk::resetTrackedRepaints):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Reimplement the displayWebView method in DumpRenderTree - force a
repaint before starting tracking repaints and resetting them.

When gathering pixel output from a web view, if tracking repaints,
paint an overlay over the output with the overlay being clear in the
areas where the repaints occurred.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(displayWebView):
(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(paintOverlay):
(fillRepaintOverlayIntoContext):
(createBitmapContextFromWebView):

LayoutTests:

Update pixel baselines for all the tests in fast/repaint now that the
Gtk's DumpRenderTree properly tracks the repaint rects and displays
an appropriate overlay in the pixel results for such tests.

  • platform/gtk/fast/repaint/4774354-expected.png:
  • platform/gtk/fast/repaint/4776765-expected.png:
  • platform/gtk/fast/repaint/absolute-position-change-containing-block-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/absolute-position-changed-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-visibility-expected.png.
  • platform/gtk/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/background-clip-text-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/background-generated-expected.png:
  • platform/gtk/fast/repaint/background-misaligned-expected.png:
  • platform/gtk/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/gtk/fast/repaint/block-selection-gap-in-table-cell-expected.png:
  • platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png:
  • platform/gtk/fast/repaint/body-background-image-expected.png:
  • platform/gtk/fast/repaint/border-fit-lines-expected.png:
  • platform/gtk/fast/repaint/border-radius-repaint-expected.png:
  • platform/gtk/fast/repaint/border-repaint-glitch-expected.png:
  • platform/gtk/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/gtk/fast/repaint/box-shadow-h-expected.png:
  • platform/gtk/fast/repaint/box-shadow-v-expected.png:
  • platform/gtk/fast/repaint/bugzilla-3509-expected.png:
  • platform/gtk/fast/repaint/bugzilla-5699-expected.png:
  • platform/gtk/fast/repaint/bugzilla-6278-expected.png:
  • platform/gtk/fast/repaint/bugzilla-6388-expected.png:
  • platform/gtk/fast/repaint/bugzilla-6473-expected.png:
  • platform/gtk/fast/repaint/bugzilla-7235-expected.png:
  • platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png:
  • platform/gtk/fast/repaint/canvas-putImageData-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/caret-outside-block-expected.png:
  • platform/gtk/fast/repaint/change-transform-expected.png:
  • platform/gtk/fast/repaint/clip-with-layout-delta-expected.png:
  • platform/gtk/fast/repaint/clipped-relative-expected.png:
  • platform/gtk/fast/repaint/containing-block-position-change-expected.png:
  • platform/gtk/fast/repaint/content-into-overflow-expected.png:
  • platform/gtk/fast/repaint/continuation-after-outline-expected.png:
  • platform/gtk/fast/repaint/control-clip-expected.png:
  • platform/gtk/fast/repaint/create-layer-repaint-expected.png:
  • platform/gtk/fast/repaint/delete-into-nested-block-expected.png:
  • platform/gtk/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/gtk/fast/repaint/erase-overflow-expected.png:
  • platform/gtk/fast/repaint/fixed-after-scroll-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-expected.png:
  • platform/gtk/fast/repaint/fixed-in-page-scale-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/fixed-right-bottom-in-page-scale-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/gtk/fast/repaint/fixed-right-in-page-scale-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/fixed-scale-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-scroll-simple-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-section-overflow-expected.png.
  • platform/gtk/fast/repaint/fixed-table-cell-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-table-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-table-overflow-zindex-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/gtk/fast/repaint/flexible-box-overflow-expected.png:
  • platform/gtk/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/gtk/fast/repaint/float-move-during-layout-expected.png:
  • platform/gtk/fast/repaint/float-new-in-block-expected.png:
  • platform/gtk/fast/repaint/float-overflow-expected.png: Added.
  • platform/gtk/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/gtk/fast/repaint/focus-layers-expected.png:
  • platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png.
  • platform/gtk/fast/repaint/inline-block-overflow-expected.png:
  • platform/gtk/fast/repaint/inline-block-resize-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/inline-color-change-expected.png:
  • platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • platform/gtk/fast/repaint/inline-outline-repaint-expected.png:
  • platform/gtk/fast/repaint/inline-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png:
  • platform/gtk/fast/repaint/intermediate-layout-position-expected.png:
  • platform/gtk/fast/repaint/invisible-objects-expected.png:
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/gtk/fast/repaint/layer-child-outline-expected.png:
  • platform/gtk/fast/repaint/layer-full-repaint-expected.png:
  • platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png:
  • platform/gtk/fast/repaint/layer-outline-expected.png:
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/gtk/fast/repaint/layer-visibility-expected.png:
  • platform/gtk/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/gtk/fast/repaint/layout-state-relative-expected.png:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/gtk/fast/repaint/line-in-scrolled-clipped-block-expected.png:
  • platform/gtk/fast/repaint/line-overflow-expected.png:
  • platform/gtk/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/gtk/fast/repaint/list-marker-2-expected.png:
  • platform/gtk/fast/repaint/list-marker-expected.png:
  • platform/gtk/fast/repaint/make-children-non-inline-expected.png:
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/gtk/fast/repaint/multicol-repaint-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/gtk/fast/repaint/nested-iframe-scroll-inner-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/intermediate-layout-position-expected.png.
  • platform/gtk/fast/repaint/nested-iframe-scroll-outer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-table-cell-expected.png.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/gtk/fast/repaint/outline-child-repaint-expected.png:
  • platform/gtk/fast/repaint/outline-inset-expected.png:
  • platform/gtk/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/gtk/fast/repaint/outline-shrinking-expected.png:
  • platform/gtk/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/overflow-delete-line-expected.png:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-full-repaint-expected.png.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/overflow-hide-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • platform/gtk/fast/repaint/overflow-into-content-expected.png:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.png:
  • platform/gtk/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/gtk/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/gtk/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/overflow-show-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-row-expected.png.
  • platform/gtk/fast/repaint/reflection-redraw-expected.png:
  • platform/gtk/fast/repaint/reflection-repaint-test-expected.png:
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/rel-positioned-inline-with-overflow-expected.png:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/gtk/fast/repaint/repaint-svg-after-style-change-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.png:
  • platform/gtk/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/erase-overflow-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-visibility-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-reflected-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/erase-overflow-expected.png.
  • platform/gtk/fast/repaint/scroll-in-clipped-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/scroll-in-fixed-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/gtk/fast/repaint/scroll-inside-table-cell-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/continuation-after-outline-expected.png.
  • platform/gtk/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/gtk/fast/repaint/search-field-cancel-expected.png:
  • platform/gtk/fast/repaint/select-option-background-color-expected.png: Added.
  • platform/gtk/fast/repaint/selected-replaced-expected.png:
  • platform/gtk/fast/repaint/selection-after-delete-expected.png:
  • platform/gtk/fast/repaint/selection-after-remove-expected.png:
  • platform/gtk/fast/repaint/selection-clear-expected.png:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/gtk/fast/repaint/selection-rl-expected.png: Added.
  • platform/gtk/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/gtk/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/gtk/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/gtk/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/gtk/fast/repaint/slider-thumb-float-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/gtk/fast/repaint/static-to-positioned-expected.png:
  • platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.png:
  • platform/gtk/fast/repaint/svg-layout-root-style-attr-update-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/gtk/fast/repaint/table-cell-move-expected.png:
  • platform/gtk/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/table-col-background-expected.png:
  • platform/gtk/fast/repaint/table-collapsed-border-expected.png:
  • platform/gtk/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/gtk/fast/repaint/table-hover-on-link-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png.
  • platform/gtk/fast/repaint/table-outer-border-expected.png:
  • platform/gtk/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/table-row-expected.png:
  • platform/gtk/fast/repaint/table-section-overflow-expected.png:
  • platform/gtk/fast/repaint/table-section-repaint-expected.png:
  • platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.png:
  • platform/gtk/fast/repaint/table-writing-modes-h-expected.png: Added.
  • platform/gtk/fast/repaint/table-writing-modes-v-expected.png: Added.
  • platform/gtk/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/gtk/fast/repaint/text-emphasis-h-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/continuation-after-outline-expected.png.
  • platform/gtk/fast/repaint/text-emphasis-v-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/text-in-relative-positioned-inline-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/gtk/fast/repaint/text-shadow-expected.png:
  • platform/gtk/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/gtk/fast/repaint/textarea-set-disabled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-row-expected.png.
  • platform/gtk/fast/repaint/transform-absolute-child-expected.png:
  • platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/gtk/fast/repaint/transform-disable-layoutstate-expected.png:
  • platform/gtk/fast/repaint/transform-layout-repaint-expected.png:
  • platform/gtk/fast/repaint/transform-relative-position-expected.png:
  • platform/gtk/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/gtk/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/gtk/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/transform-translate-expected.png:
  • platform/gtk/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png.
  • platform/gtk/fast/repaint/view-background-from-body-2-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/invisible-objects-expected.png.
12:43 PM Changeset in webkit [120349] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests doesn't find similar platform tests for a keyword
​https://bugs.webkit.org/show_bug.cgi?id=37956

Reviewed by Ryosuke Niwa.

This patches adds support for NRWT so that if you type
"new-run-webkit-tests foo" it will run all the tests in foo as
well as platform/foo for all of the platforms that are normally
searched (this only applies to directories, not to individual tests).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.collect_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.tests):
(Port):
(Port._expanded_paths):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_no_http_tests):
(MainTest):
(MainTest.test_platform_tests_are_found):

12:40 PM Changeset in webkit [120348] by dpranke@chromium.org
  • 5 edits in trunk/Tools

NRWT should honor --skipped=[default|ignore|only], like ORWT does
​https://bugs.webkit.org/show_bug.cgi?id=66308

Reviewed by Ryosuke Niwa.

This patch adds support for ORWT's --skipped=(default|ignore|only)
flag and cleans up the interaction between that and --ignore.

Individual tests (but not directories) explicitly listed on the
command line will always be run regardless of what is passed
for --skipped and --ignore.

This patch also changes the "found" and "running" log messages
since it wasn't clear how the skipped tests were included in those numbers.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.collect_tests):
(Manager.prepare_lists_and_print_output):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_ignore_flag):
(MainTest):
(MainTest.test_skipped_flag):

12:24 PM Changeset in webkit [120347] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Remove devtoolsInjectedScript hidden property
​https://bugs.webkit.org/show_bug.cgi?id=89087

We use the devtoolsInjectedScript hidden property to reference a InjectedScript object
for a given ScriptState, but we also have the same reference in the InjectedScriptManager's
hash maps. Just use the hash maps and remove the hidden property from the global object.

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-06-14
Reviewed by Pavel Feldman.

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(JSDOMGlobalObject):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:
  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore):
(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

11:54 AM Changeset in webkit [120346] by commit-queue@webkit.org
  • 36 edits
    3 adds
    1 delete in trunk/Source

[chromium] Move opaque rectangle tracking logic out of compositor core
​https://bugs.webkit.org/show_bug.cgi?id=89031

Patch by James Robinson <​jamesr@chromium.org> on 2012-06-14
Reviewed by Adrienne Walker.

Source/WebCore:

This moves the opaque paint tracking logic from the compositor (specifically CanvasLayerTextureUpdater) out to a
dedicated class used by GraphicsLayerChromium for GraphicsContext-painted content. This changes the interface
exposed by the compositor to pass a SkCanvas and let the user fill in an opaque rect if needed. Callers that are
using GraphicsContext to paint can instantiate a PlatformContextSkia / GraphicsContext around this SkCanvas if
they choose to, or use some other strategy, or not fill it in at all. This avoids creating extra wrapper classes
if the eventual caller is going to use the underlying SkCanvas anyway (such as WebContentLayer) and breaks the
dependency from the compositor code on GraphicsContext / PlatformContextSkia.

OpaqueRectTrackingContentLayerDelegate is a helper class that wraps a ContentLayerDelegate implementation with
PlatformContextSkia's opaque region tracking logic.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):
(WebCore::BitmapCanvasLayerTextureUpdater::setOpaque):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(WebCore):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(WebCore):
(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerDelegate):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::paint):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerPainterChromium.h:

(LayerPainterChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::paintContents):

  • platform/graphics/chromium/LinkHighlight.h:

(LinkHighlight):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: Added.

(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegate::OpaqueRectTrackingContentLayerDelegate):
(WebCore::OpaqueRectTrackingContentLayerDelegate::~OpaqueRectTrackingContentLayerDelegate):
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h: Added.

(WebCore):
(GraphicsContextPainter):
(WebCore::GraphicsContextPainter::~GraphicsContextPainter):
(OpaqueRectTrackingContentLayerDelegate):
(WebCore::OpaqueRectTrackingContentLayerDelegate::setOpaque):

  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::Painter::Painter):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

Source/WebKit/chromium:

Moves the grayscale/subpixel AA text decision into NonCompositedContentHost and removes one layer of indirection
betwen NCCH and WVI that existed only for historical reasons.

Ports the opaque rect tracking tests that were in LayerTextureUpdaterTest to
OpaquerectTrackingContentLayerDelegateTest to reflect the move in responsibilities.

  • WebKit.gypi:
  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):

  • src/NonCompositedContentHost.h:

(WebCore):
(WebKit):
(WebKit::NonCompositedContentHost::create):
(NonCompositedContentHost):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paintRootLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::paintContents):

  • tests/LayerChromiumTest.cpp:
  • tests/LayerTextureUpdaterTest.cpp: Removed.
  • tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: Added.

(WebCore):
(PaintCallback):
(TestLayerPainterChromium):
(WebCore::TestLayerPainterChromium::TestLayerPainterChromium):
(WebCore::PaintFillAlpha::operator()):
(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::skCanvas):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):

11:37 AM Changeset in webkit [120345] by Simon Fraser
  • 10 edits in trunk/LayoutTests

Rebaseline some Mac results after r120246.

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-colorspace-yuv420-expected.txt:
  • platform/mac/media/video-colorspace-yuv422-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt:
11:33 AM Changeset in webkit [120344] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw
​https://bugs.webkit.org/show_bug.cgi?id=89018

Patch by Justin Novosad <​junov@chromium.org> on 2012-06-14
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled-repaint.html

When an accelerated canvas layer prepares its texture for the
compositor, it must send a notification to skia to invalidate texture
proprties that are cached by skia, since the compositor may modify them.
The use case this fixes is when a canvas to canvas copy is performed
with webkitImageSmoothingEnabled=false on the destination canvas.
The backing texture of the source canvas will be set to "nearest"
filtering by skia in order to perform the copy. Then, the compositor
sets filtering back to "linear" when the source canvas is drawn.
Skia is designed to only update GL attributes when required, so errors
occur when the skia-side GL state cache is out of sync.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::prepareTexture):

Source/WebKit/chromium:

Rolling chromium DEPS to 141884

  • DEPS:

LayoutTests:

New layout test that verifies that disabling image smoothing on a 2d
canvas continues to work after multiple paint cycles.

  • fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt: Added.
  • fast/canvas/canvas-imageSmoothingEnabled-repaint.html: Added.
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js: Added.

(draw):
(testResult):
(TestControllerPaint):
(BrowserPaint):
(onLoadHandler):

11:23 AM Changeset in webkit [120343] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
​https://bugs.webkit.org/show_bug.cgi?id=64966

Unreviewed suppression of crashing tests:
svg/batik/text/textDecoration.svg
svg/batik/text/textEffect3.svg

  • platform/chromium/TestExpectations:
11:06 AM Changeset in webkit [120342] by toyoshim@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-websocketserver must handle TLS related arguments
​https://bugs.webkit.org/show_bug.cgi?id=89079

Reviewed by Dirk Pranke.

PyWebSocket class must accept private_key, certificate, and
ca_certificate arguments and pass them to launching pywebsocket.
Also add ca_certificate handling to new-run-webkit-websocketserver.

  • Scripts/new-run-webkit-websocketserver:

(main):

  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

(PyWebSocket.init):
(PyWebSocket._prepare_config):

11:02 AM Changeset in webkit [120341] by jhoneycutt@apple.com
  • 4 edits in trunk

2012-06-14 Jon Honeycutt <​jhoneycutt@apple.com>

Fix some failing tests on Windows by resetting the page scale factor
between tests.
​https://bugs.webkit.org/show_bug.cgi?id=89078

Reviewed by Dirk Pranke.

WebCore:

  • testing/Internals.cpp: (WebCore::Internals::reset): Set the scale factor to 1.0.

LayoutTests:
Unskip some now-passing tests.
​https://bugs.webkit.org/show_bug.cgi?id=89078

  • platform/win/Skipped:
10:45 AM Changeset in webkit [120340] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Register fixed position layers with ScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=78864

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-06-14
Reviewed by James Robinson.

This patch makes ScrollingCoordinator aware of page elements that are
either fixed positioned directly or through their ancestors and that
also have their own composited backing layers. This allows the
ScrollingCoordinator implementation to potentially enable fast
scrolling even if there are fixed elements on the page, because the
compositor can automatically reposition the fixed element layers after
scrolling.

Since fixed position layers need to be explicitly supported by the
ScrollingCoordinator implementation, we add a new
supportsFixedPositionLayers() query for checking this.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::fixedObjects):
(WebCore::FrameView::hasFixedObjects):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition):
(WebCore):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleWillChange):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore):
(WebCore::RenderLayerCompositor::fixedPositionedByAncestor):
(WebCore::RenderLayerCompositor::ensureRootLayer):

  • rendering/RenderLayerCompositor.h:
10:42 AM Changeset in webkit [120339] by ap@apple.com
  • 4 edits
    4 adds in trunk

[CFNetwork] XMLHttpRequest incorrectly returns cached responses even when there is a Vary header field
​https://bugs.webkit.org/show_bug.cgi?id=88925

Reviewed by David Kilzer.

Test: http/tests/cache/xhr-vary-header.html

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Don't cache the response at all if there is a Vary header field. CFNetwork won't look at it if we allowed the response cached.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): [NSURLResponse copy] is mutable in practice, but we should be nice, and use -mutableCopy. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Same fix as in CFNet code.
10:06 AM Changeset in webkit [120338] by caseq@chromium.org
  • 8 edits
    1 move
    10 deletes in trunk/Source/WebCore

Web Inspector: use CSS gradients instead of images for timeline bars, checkboxes & bullets
​https://bugs.webkit.org/show_bug.cgi?id=89024

Reviewed by Pavel Feldman.

This brings a bunch of UI changes to the way Timeline bars and related controls are rendered:

  • introduce new color palette for categories;
  • replace images used to render timeline bars, list bullets and categories checkboxes with CSS gradients;
  • "flatten" timeline bars
  • make square list bullets, sharpen corners for lower pane bars;
  • make links on the list sidebar grey
  • add more space between categories checkboxes, make labels lighter.
  • WebCore.gypi: Remove old images, add tickMark.png.
  • inspector/front-end/Images/timelineBarBlue.png: Removed.
  • inspector/front-end/Images/timelineBarDarkGreen.png: Removed.
  • inspector/front-end/Images/timelineBarGray.png: Removed.
  • inspector/front-end/Images/timelineBarGreen.png: Removed.
  • inspector/front-end/Images/timelineBarLightPurple.png: Removed.
  • inspector/front-end/Images/timelineBarOrange.png: Removed.
  • inspector/front-end/Images/timelineBarPurple.png: Removed.
  • inspector/front-end/Images/timelineBarRed.png: Removed.
  • inspector/front-end/Images/timelineBarYellow.png: Removed.
  • inspector/front-end/Images/timelineCheckmarks.png: Removed.
  • inspector/front-end/Images/timelineDots.png: Removed.
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.wasShown):
(WebInspector.TimelinePanel.prototype._closeRecordDetails): Fixed trailing spaces;
(WebInspector.TimelinePanel.prototype._injectCategoryStyles): Inject generated styles for categories, if necessary.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.createFillStyle):
(WebInspector.TimelinePresentationModel.createStyleRuleForCategory):

  • inspector/front-end/WebKit.qrc: Remove old images, add tickMark.png
  • inspector/front-end/inspector.css:

(.sidebar-tree-section):

  • inspector/front-end/timelinePanel.css:

(#timeline-container .webkit-html-resource-link):
(.timeline-category-statusbar-item):
(.timeline-category-statusbar-item .timeline-category-checkbox):
(.timeline-category-statusbar-item .timeline-category-checkbox:checked::before):
(.timeline-tree-item):
(.timeline-tree-item .timeline-tree-icon):
(.timeline-graph-bar):
(.timeline-graph-bar.with-children):
(.timeline-graph-bar.cpu):
(.timeline-aggregated-category):

  • inspector/front-end/utilities.js:

(Object.values): Return an array of object field's values.

10:00 AM Changeset in webkit [120337] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Change mute button and volume slider behaviour for new Chromium video controls.
​https://bugs.webkit.org/show_bug.cgi?id=88743

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update. This patch makes the mute button and
the volume slider interact with each other. When the user mutes the video through clicking the
mute button, the volume slider animates to 0% volume. Upon unmute, the previous volume level
is restored. Further, when the user drags the volume slider thumb or clicks on the slider and
the video is muted, the video unmutes and sets the volume to the user's chosen level.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
Add a member field to the volume slider to allow user interaction to unmute the video.
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Add the logic to unmute the video if the m_clearMutedOnUserInteraction member field is true.
(WebCore::MediaControlVolumeSliderElement::setClearMutedOnUserInteraction):
Add a member function to change the value of the m_clearMutedOnUserInteraction member field.

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderElement):
Add the setClearMutedOnUserInteraction member function and the m_clearMutedOnUserInteraction member field.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create):
Activate unmute on user interaction on the Chromium video volume slider.
(WebCore::MediaControlRootElementChromium::changedMute):
Add logic to set volume slider to 0 when muted and reset to volume when unmuted.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaVolumeSlider):
Add logic to paint the volume slider active area as 0 when muted.

9:58 AM Changeset in webkit [120336] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Breakpoints should not be set when UISourceCode content is diverged from VM version of the script.
​https://bugs.webkit.org/show_bug.cgi?id=89109

Reviewed by Pavel Feldman.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.isDivergedFromVM):
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

9:57 AM Changeset in webkit [120335] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only.
​https://bugs.webkit.org/show_bug.cgi?id=88988

Reviewed by Pavel Feldman.

This change allows setting all saved breakpoints in debugger model by url before the site
with corresponding scripts was loaded (allows breaking in onload handler on first load).
This change also simplifies implementation of snippets debugging.

  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):

9:53 AM Changeset in webkit [120334] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] Update TestExpectations with tests crashing in 64bits Debug build
​https://bugs.webkit.org/show_bug.cgi?id=89105

Unreviewed gardening.

Mark svg/batik/text/textDecoration.svg and
svg/batik/text/textEffect3.svg as crashing in DEBUG.

Patch by Simon Pena <Simon Pena> on 2012-06-14

  • platform/gtk/TestExpectations:
9:53 AM Changeset in webkit [120333] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] Update TestExpectations with non-passing tests
​https://bugs.webkit.org/show_bug.cgi?id=89100

Unreviewed gardening.

Mark plugins/plugin-initiate-popup-window.html as flaky and
svg/transforms/transformed-text-fill-pattern.html as failing.

Patch by Simon Pena <Simon Pena> on 2012-06-14

  • platform/gtk/TestExpectations:
9:49 AM Changeset in webkit [120332] by qi.2.zhang@nokia.com
  • 2 edits in trunk/Tools

Unreviewed. Update my email.

  • Scripts/webkitpy/common/config/committers.py:
9:49 AM Changeset in webkit [120331] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: refactor settings screen to move user agent and experiments out of general tab.
​https://bugs.webkit.org/show_bug.cgi?id=89101

Reviewed by Vsevolod Vlasov.

See image attached to the bug.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype.selectTab):
(WebInspector.SettingsScreen.prototype._tabSelected):
(WebInspector.SettingsScreen.prototype.set wasShown):
(WebInspector.SettingsScreen.prototype.willHide):
(WebInspector.SettingsTab):
(WebInspector.SettingsTab.prototype._appendSection):
(WebInspector.SettingsTab.prototype._createCustomSetting):
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype._showPaintRectsChanged):
(WebInspector.GenericSettingsTab.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged):
(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textDoubleClicked):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textChanged):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
(WebInspector.ExperimentsSettingsTab):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentsWarningSubsection):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox.listener):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox):

  • inspector/front-end/ShortcutsScreen.js:
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.get headerContentsElement):

  • inspector/front-end/helpScreen.css:

(.settings-tab.help-container):
(.settings-tab .help-block):
(.help-content fieldset):
(#settings-screen .tabbed-pane-header-tabs):
(#settings-screen .tabbed-pane-header-tab):

9:44 AM Changeset in webkit [120330] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] New css3/flexbox/flexitem.html fails
​https://bugs.webkit.org/show_bug.cgi?id=88963

Reviewed by Hajime Morita.

  • css3/flexbox/flexitem.html: The height of the alt text was taller

than the height of the missing image placeholder graphic on Qt. To
get the same results, force the font size to something small.
The test still fails on Qt so leaving it in the Skipped file for now.

8:52 AM Changeset in webkit [120329] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
<​http://webkit.org/b/89048>
<rdar://problem/11449702>

Reviewed by Darin Adler.

Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag
for keyboard events. This ensures that it always arrives before the corresponding synchronous
InterpretQueuedKeyEvent message.

The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in
the same order they were sent. This was not always true, since DidReceiveEvent (async) would
get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync)
gets dispatched right away.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):

8:39 AM Changeset in webkit [120328] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

Worker tear-down can re-enter JSC during GC finalization pt. 2
​https://bugs.webkit.org/show_bug.cgi?id=88601

Reviewed by David Levin.

No new tests. Current regression tests are sufficient.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed): We clear the m_workerObject here because
we don't want anybody else trying to send messages to the Worker now that it has been destroyed.
We also queue the asynchronous task for the various other cleanup that still needs to be done.
This allows us to avoid the problem of re-entrant JS code execution during GC.
(WebCore):
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Here we set m_mayBeDestroyed to true.
This is the point after which deleting the WorkerMessagingProxy in workerContextDestroyedInternal()
is okay. It could happen during this function call if the worker thread has been shutdown already, or
it could be called later after we shut down the worker thread.
(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): We check m_mayBeDestroyed here
instead of checking m_workerObject. This change effectively orthogonalizes the roles that m_workerObject
was filling. Since we were eagerly clearing m_workerObject, but we wanted to asynchronously call
workerObjectDestroyed(), we needed to make sure we didn't accidentally try to delete the WorkerMessagingProxy
twice (once from destroying the Worker and once from destroying the WorkerContext). This boolean field
should fix that issue--we set it lazily like we wanted to do without being in danger of causing use-after-free
issues with m_workerObject.

  • workers/WorkerMessagingProxy.h: Added the new field and function.

(WorkerMessagingProxy):

8:34 AM Changeset in webkit [120327] by apavlov@chromium.org
  • 4 edits in trunk

Web Inspector: Selector list start position is not extracted for style rules inside @media rules
​https://bugs.webkit.org/show_bug.cgi?id=89094

Reviewed by Pavel Feldman.

Source/WebCore:

Selector list start is now marked inside the "ruleset" rule rather than separately, before its invocation(s).

  • css/CSSGrammar.y:

LayoutTests:

  • inspector/audits/audits-panel-functional.html:
7:57 AM Changeset in webkit [120326] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Fix race condition where animations start, finish and are deleted on the composite thread, all before the start even arrives on the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=88439

Patch by Eric Penner <​epenner@google.com> on 2012-06-14
Reviewed by James Robinson.

Scheduling behavior covered by existing tests.

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::isFinishedAt):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(WebCore::CCActiveAnimation::isFinished):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::animate):
(WebCore::CCLayerAnimationController::hasActiveAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::markAnimationsForDeletion):
(WebCore::CCLayerAnimationController::purgeAnimationsMarkedForDeletion):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

7:44 AM Changeset in webkit [120325] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ConsoleView.evaluateUsingTextPrompt should evaluate without command line API.
​https://bugs.webkit.org/show_bug.cgi?id=89096

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:
7:35 AM Changeset in webkit [120324] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed, build fix for Mac 10.5

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):

7:15 AM Changeset in webkit [120323] by commit-queue@webkit.org
  • 15 edits in trunk/LayoutTests

[EFL] Tests rebaselining after r120167, r120246
​https://bugs.webkit.org/show_bug.cgi?id=89069

Unreviewed EFL gardening after r120246 and r120167, updating baselines.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-06-14

  • platform/efl/fast/layers/video-layer-expected.txt:
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.txt:
7:01 AM Changeset in webkit [120322] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Update the time display of the new Chromium media controls.
​https://bugs.webkit.org/show_bug.cgi?id=88724

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update. This patch changes
the format of the time digits that are displayed. They are different for media
files of different duration. For non-autoplaying videos, the duration is shown
before playback is started.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
Format the new duration display the same as the current time display.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Add a member field for the duration display.
(WebCore::MediaControlRootElementChromium::create):
Add an element for the duration display and initially hide the current time display.
(WebCore::MediaControlRootElementChromium::setMediaController):
Add the duration display to the controller.
(WebCore::MediaControlRootElementChromium::reset):
Add reset functionality for the duration display.
(WebCore::MediaControlRootElementChromium::playbackStarted):
Show the current time display and hide the duration display upon playback start.
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):
Show the current time display and hide the duration display when current time is non-zero.

  • html/shadow/MediaControlRootElementChromium.h:

(WebCore):
Add the MediaControlTimeRemainingDisplayElement which provides use with the duration display.
(MediaControlRootElementChromium):
Add a duration member field, reusing the existing MediaControlTimeRemainingDisplayElement.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::formatChromiumMediaControlsTime):
Formats a given time under the condition of a given duration.
(WebCore::RenderMediaControlsChromium::formatMediaControlsTime):
When formatting a single time, assume it to also provide the duration conditions.
(WebCore::RenderMediaControlsChromium::formatMediaControlsCurrentTime):
Format the current time given the duration.
(WebCore::RenderMediaControlsChromium::formatMediaControlsRemainingTime):
Format the remaining time from the current time given the duration.

  • rendering/RenderMediaControlsChromium.h:

(RenderMediaControlsChromium):
Declare the time formatting member functions.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Declare the time formatting member functions for Chromium on the Mac.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::formatMediaControlsTime):
(WebCore::RenderThemeChromiumMac::formatMediaControlsCurrentTime):
(WebCore::RenderThemeChromiumMac::formatMediaControlsRemainingTime):
Call the time formatting member functions of RenderMediaControlsChromium on the Mac.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::formatMediaControlsTime):
(WebCore::formatMediaControlsCurrentTime):
(WebCore::formatMediaControlsRemainingTime):
Call the time formatting member functions of RenderMediaControlsChromium on Skia.

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
Declare the time formatting member functions for Chromium Skia.

6:58 AM Changeset in webkit [120321] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test rebaseline after r120317.

  • inspector/styles/override-screen-size-expected.txt:
6:54 AM Changeset in webkit [120320] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Mark fast/forms/text-input-event.html as flaky in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=89085

Unreviewed gardening. Mark test as flaky.

Patch by Simon Pena <Simon Pena> on 2012-06-14

  • platform/gtk/TestExpectations:
6:52 AM Changeset in webkit [120319] by schenney@chromium.org
  • 20 edits
    1 delete in trunk/LayoutTests

[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
​https://bugs.webkit.org/show_bug.cgi?id=64966

Unreviewed Chromium test expectations update.

Bug fixed by Dominik Röttsches.

  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium/TestExpectations:
6:26 AM Changeset in webkit [120318] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Web Inspector: Refactor message loop instrumentation.
​https://bugs.webkit.org/show_bug.cgi?id=88978

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-06-14
Reviewed by Pavel Feldman.

1) Remove "messageLoop" term
2) Reuse WebThread::TaskObserver interface
3) Move implementation (from embedder) to platform code.

Source/Platform:

  • chromium/public/WebThread.h:

(TaskObserver): add "willProcessTask" method.

Source/WebCore:

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::startMainThreadMonitoring): Renamed method.
(WebCore::InspectorClient::stopMainThreadMonitoring): Ditto.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:

(WebDevToolsAgent):

  • public/WebDevToolsAgentClient.h:

(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::startMainThreadMonitoring): Renamed medthod.
(WebKit::WebDevToolsAgentClient::stopMainThreadMonitoring): Ditto.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::startMainThreadMonitoring): Ditto.
(WebKit::InspectorClientImpl::stopMainThreadMonitoring): Ditto.

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::startMainThreadMonitoring): Use platform threading.
(WebKit::WebDevToolsAgentImpl::stopMainThreadMonitoring): Ditto.
(WebKit::WebDevToolsAgentImpl::willProcessTask): Renamed medthod.
(WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebKit.cpp:
6:05 AM Changeset in webkit [120317] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Device Metrics] "Fit window" results in duplicate rescaling in WebDevToolsAgentImpl::autoZoomPageToFitWidth()
​https://bugs.webkit.org/show_bug.cgi?id=89092

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

Do not apply the sizeRatio after it has been applied in scaledEmulatedFrameSize().

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):

LayoutTests:

  • platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
  • platform/chromium/inspector/styles/device-metrics-fit-window.html:
5:51 AM Changeset in webkit [120316] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r120314.

  • platform/qt/Skipped: skip svg/transforms/transformed-text-fill-gradient.html
5:40 AM Changeset in webkit [120315] by toyoshim@chromium.org
  • 9 edits in trunk/Tools

Update pywebsocket to 0.7.6 from 0.7.4
​https://bugs.webkit.org/show_bug.cgi?id=88975

Reviewed by Kent Tamura.

This new version of pywebsocket introduce following features.

  • Allow handlers to send a close frame with empty body in response of

a client initiated closing handshake

  • Implement perframe compression extension
  • Support client certificate authentication
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:

(_create_control_frame):
(Stream._receive_frame):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:

(ExtensionParsingException):
(ExtensionParsingException.init):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extension):
(format_extensions):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:

(_parse_compression_method):
(_create_accepted_method_desc):
(PerFrameCompressionExtensionProcessor):
(PerFrameCompressionExtensionProcessor.init):
(PerFrameCompressionExtensionProcessor._lookup_compression_processor):
(PerFrameCompressionExtensionProcessor._get_compression_processor_response):
(PerFrameCompressionExtensionProcessor.get_extension_response):
(PerFrameCompressionExtensionProcessor.setup_stream_options):
(PerFrameCompressionExtensionProcessor.get_compression_processor):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:

(parse_token_list):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:

(Handshaker._parse_extensions):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:

(WebSocketServer._create_sockets):
(_get_logger_from_class):
(_configure_logging):
(_build_option_parser):
(_main.if):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:

(RepeatedXorMasker.mask):

5:18 AM Changeset in webkit [120314] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
​https://bugs.webkit.org/show_bug.cgi?id=64966

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-14
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVGInlineTextBox::paintTextWithShadows for non-CG implementations resets the scale aspect
of the currently applied CTM. This leads to patterns and gradients being incorrectly downscaled.
This way of resetting the CTM and drawing fonts "natively" scaled was introduced
in r77485 to fix a number of issues with SVG font scaling.
Unfortunately, this breaks scaling of patterns and gradients. To fix it,
we need to push the transformation back into the pattern/gradient space transformation.

Tests: svg/transforms/transformed-text-fill-gradient.html

svg/transforms/transformed-text-fill-pattern.html

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): Moving the scaling factor calculation out into SVGRenderingContext.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting): Reusing the scaling factor calculation from SVGRenderingContext.
(WebCore):

  • rendering/svg/RenderSVGResourceContainer.h:

(RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource): If needed, push down transformation into gradient space.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource): If needed, push transformation into pattern space.

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor): Common scaling factor calculation for RenderSVGInlineText and RenderSVGResourceContainer.

  • rendering/svg/SVGRenderingContext.h:

(SVGRenderingContext):

LayoutTests:

For Pattern: RefTest that compare a scaled rectangle with a scaled block of Ahem characters.
The pattern or gradient should scale in the same way for the text and the rectangle.
This approach needs a clipping path hack to work around micro gaps between Ahem characters
due to rounding.
For Gradient: Scaling text at two different scale factors and adjusting font size to yield the same effective text size.
Gradient fill should be identical in both cases.

  • platform/chromium/TestExpectations: Added 3 tests that need rebaselining for text gradient fills.
  • svg/transforms/transformed-text-fill-gradient-expected.html: Added.
  • svg/transforms/transformed-text-fill-gradient.html: Added.
  • svg/transforms/transformed-text-fill-pattern-expected.html: Added.
  • svg/transforms/transformed-text-fill-pattern.html: Added.
4:53 AM Changeset in webkit [120313] by yosin@chromium.org
  • 24 edits in trunk/Source/WebCore

[Form] Replace InputNumber type to Decimal type and drop InputNumber
​https://bugs.webkit.org/show_bug.cgi?id=88746

Reviewed by Kent Tamura.

This patch removes InputNumber introduced by r119540 by replacing
InputNumber type to Decimal type and changing convertDoubleToDecimal
and convertDecimalToDouble to Decimal::fromDouble and
Decimal::toDouble, respectively.

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsDecimal):
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp):
(WebCore::BaseDateAndTimeInputType::parseToNumber):
(WebCore::BaseDateAndTimeInputType::serialize):
(WebCore::BaseDateAndTimeInputType::serializeWithComponents):
(WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::defaultValueForStepUp):
(WebCore::DateTimeInputType::createStepRange):

  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::getAllowedValueStep):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::setValueAsDouble):
(WebCore::InputType::setValueAsDecimal):
(WebCore::InputType::rangeUnderflow):
(WebCore::InputType::rangeOverflow):
(WebCore::InputType::defaultValueForStepUp):
(WebCore::InputType::minimum):
(WebCore::InputType::maximum):
(WebCore::InputType::isInRange):
(WebCore::InputType::isOutOfRange):
(WebCore::InputType::stepMismatch):
(WebCore::InputType::validationMessage):
(WebCore::InputType::parseToNumber):
(WebCore::InputType::parseToNumberOrNaN):
(WebCore::InputType::serialize):
(WebCore::InputType::applyStep):
(WebCore::InputType::getAllowedValueStep):
(WebCore::InputType::stepUpFromRenderer):

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp):
(WebCore::MonthInputType::createStepRange):
(WebCore::MonthInputType::parseToNumber):

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsDecimal):
(WebCore::NumberInputType::createStepRange):
(WebCore::NumberInputType::parseToNumber):
(WebCore::NumberInputType::serialize):

  • html/NumberInputType.h:

(NumberInputType):

  • html/RangeInputType.cpp:

(WebCore::ensureMaximum):
(WebCore::RangeInputType::setValueAsDecimal):
(WebCore::RangeInputType::createStepRange):
(WebCore::RangeInputType::handleKeydownEvent):
(WebCore::RangeInputType::parseToNumber):
(WebCore::RangeInputType::serialize):
(WebCore::RangeInputType::sanitizeValue):

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):
(WebCore::StepRange::acceptableError):
(WebCore::StepRange::alignValueForStep):
(WebCore::StepRange::clampValue):
(WebCore::StepRange::parseStep):
(WebCore::StepRange::roundByStep):
(WebCore::StepRange::stepMismatch):

  • html/StepRange.h:

(WebCore::StepRange::StepDescription::defaultValue):
(StepRange):
(WebCore::StepRange::maximum):
(WebCore::StepRange::minimum):
(WebCore::StepRange::step):
(WebCore::StepRange::stepBase):
(WebCore::StepRange::defaultValue):
(WebCore::StepRange::proportionFromValue):
(WebCore::StepRange::valueFromProportion):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::defaultValueForStepUp):
(WebCore::TimeInputType::createStepRange):

  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition):
(WebCore::RenderSliderThumb::layout):
(WebCore::SliderThumbElement::setPositionFromPoint):

3:57 AM Changeset in webkit [120312] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi
​https://bugs.webkit.org/show_bug.cgi?id=89062

Reviewed by Kent Tamura.

This patch removes ENABLE_INPUT_TYPE_*=0 from default entry of feature_defines to
allows us overriding by ~/.gyp/include.gypi

  • features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME=0, ENABLE_INPUT_TYPE_DATETIMELOCAL=0,

and so on.

3:34 AM Changeset in webkit [120311] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Implement ExtensionPanel.show() method
​https://bugs.webkit.org/show_bug.cgi?id=88473

Source/WebCore:

Implemented ExtensionPanel.show() API method to allow extension
developers to show their panel when needed.

Patch by Jan Keromnes <​janx@linux.com> on 2012-06-14
Reviewed by Pavel Feldman.

Tests for this method are in:
LayoutTests/inspector/extensions/extensions-panel.html

  • inspector/front-end/ExtensionAPI.js:

(defineCommonExtensionSymbols):
(injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
(injectedExtensionAPI.ExtensionPanelImpl.prototype.show):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onShowPanel):

LayoutTests:

Add output for ExtensionPanel callbacks, and use ExtensionPanel.show()
to show the panel. Fix expected.

Patch by Jan Keromnes <​janx@linux.com> on 2012-06-14
Reviewed by Pavel Feldman.

  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
3:31 AM Changeset in webkit [120310] by zoltan@webkit.org
  • 2 edits in trunk/Tools

[Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore

Reviewed by Noam Rosenthal.

  • qmake/mkspecs/features/features.prf:
3:27 AM Changeset in webkit [120309] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix a typo in r120304.
​https://bugs.webkit.org/show_bug.cgi?id=89070

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestObj.cpp:
3:20 AM Changeset in webkit [120308] by commit-queue@webkit.org
  • 8 edits in trunk

Add dpcm to css3-images image-resolution
​https://bugs.webkit.org/show_bug.cgi?id=85442

Patch by David Barr <​davidbarr@chromium.org> on 2012-06-14
Reviewed by Tony Chang.

Source/WebCore:

The css3-images module is at candidate recommendation.
​http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution

No new tests; extended fast/css/image-resolution/image-resolution.html

  • css/CSSGrammar.y: Add DPCM token and unary term.
  • css/CSSParser.cpp: Extend range of units accepted for resolution and tokenize "dpcm".

(WebCore::CSSParser::validUnit): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::CSSParser::createPrimitiveNumericValue): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::unitFromString): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM.
(WebCore::CSSParser::parseValidPrimitive): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::CSSParser::detectNumberToken): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM.

  • css/CSSPrimitiveValue.cpp: Add CSSPrimitiveValue::CSS_DPCM as a numeric unit.

(WebCore::isValidCSSUnitTypeForDoubleConversion): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::unitCategory): Map CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::UResolution.
(WebCore::conversionToCanonicalUnitsScaleFactor): Scale CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::CSS_DPPX.
(WebCore::CSSPrimitiveValue::customCssText): Format CSSPrimitiveValue::CSS_DPCM as "<num>dpcm".
(WebCore::CSSPrimitiveValue::cloneForCSSOM): Accept CSSPrimitiveValue::CSS_DPCM as numeric unit.

  • css/CSSPrimitiveValue.h: Add CSSPrimitiveValue::CSS_DPCM.

LayoutTests:

  • fast/css/image-resolution/image-resolution-expected.txt:
  • fast/css/image-resolution/image-resolution.html:
3:16 AM Changeset in webkit [120307] by vsevik@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

Merge 120214 - Web Inspector: Errors when pending console messages are attached to JavaScriptSourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=88712

Reviewed by Pavel Feldman.

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):

TBR=​vsevik@chromium.org
BUG=132449

---All lines above this line become the description.
---Repository Root: /home/vsevik/webkit_merges/drover_120214_1132/1132
---Paths in this changelist (120214):

---Paths modified but not in any changelist:

! Source/WebCore/inspector/front-end/PresentationConsoleMessageHelper.js
Review URL: ​https://chromiumcodereview.appspot.com/10548044

3:13 AM Changeset in webkit [120306] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION HeapProfiler can't remove heap snapshot from the list if Dominators view has been opened.
​https://bugs.webkit.org/show_bug.cgi?id=89080

There was no dispose method on artificial ShowMoreDataGrid node.

Reviewed by Pavel Feldman.

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
(WebInspector.ShowMoreDataGridNode.prototype.dispose):

3:10 AM Changeset in webkit [120305] by Carlos Garcia Campos
  • 8 edits
    2 adds in trunk/Source/WebKit2

[GTK] Add input methods submenu item to the default context menu for editable content
​https://bugs.webkit.org/show_bug.cgi?id=80600

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitContextMenuClient.cpp: Added.

(getContextMenuFromProposedMenu): Call webkitWebViewContextMenu().
(attachContextMenuClientToView): Add implementation for
getContextMenuFromProposedMenu callback.

  • UIProcess/API/gtk/WebKitContextMenuClient.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach context menu client to view.
(webkitWebViewCreateAndAppendDefaultMenuItems): Helper function to
add default context menu items to the new context menu items vector.
(webkitWebViewShouldShowInputMethodsMenu): Helper function to
check whether to show the input methods submenu according to the
gtk-show-input-method-menu GTK+ setting.
(webkitWebViewCreateAndAppendInputMethodsMenuItem): Helper
function to add input methods submenu to the new context menu
items vector.
(webkitWebViewContextMenu): Create a new context menu items vector
containing default items and input methods submenu in case of
editable content. The active content menu is populated using that
new vector.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetActiveContextMenu): Set the active context menu.
(webkitWebViewBaseGetActiveContextMenu): Get the active context menu.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::append): Helper method to add a
new item to the context menu.
(WebKit::WebContextMenuProxyGtk::populate): Add items to the
context menu.
(WebKit::WebContextMenuProxyGtk::showContextMenu): Populate the
menu with the given items and popup the menu if it's not empty.
(WebKit::WebContextMenuProxyGtk::hideContextMenu): Get the GtkMenu
from the WebCore ContextMenu to popdown it.
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Call
webkitWebViewBaseSetActiveContextMenu() to set the menu as the current
active one for the view.
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Call
webkitWebViewBaseSetActiveContextMenu() with NULL to reset the
current active context of the view. GtkMenu is destroyed by
WebCore ContextMenu in its destructor.

  • UIProcess/gtk/WebContextMenuProxyGtk.h:
2:59 AM Changeset in webkit [120304] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

[JSC/V8] Improve DOMString[] support
​https://bugs.webkit.org/show_bug.cgi?id=89070

Reviewed by Kentaro Hara.

Tests: new test case in TestObj.idl

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray): Implement jsArray() for DOMStringList.

  • bindings/js/JSDOMBinding.h: Declare jsArray() for DOMStringList.
  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue): Avoid to include JSDOMString.h and DOMString.h.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeType): Move a check for DOMString[] because it's a RefPtr type
and we'd like to avoid to generate RefPtr<DOMString[]>
(%non_wrapper_types): DOMString[] is not a wrapper type. This is needed
to avoid to generate unnecessary custom function template.
(NativeToJSValue): Avoid to include V8DOMString.h and DOMString.h.

  • bindings/scripts/test/TestObj.idl: Add non-overload function using DOMString[].
  • bindings/scripts/test/JS/JSTestObj.cpp: Update expectation.
  • bindings/scripts/test/JS/JSTestObj.h: ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: ditto.
2:56 AM Changeset in webkit [120303] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88845

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-06-14
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/text/international/jpan-script-equivalence.html

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):

LayoutTests:

  • fast/text/international/jpan-script-equivalence-expected.html: Added.
  • fast/text/international/jpan-script-equivalence.html: Added.
2:52 AM Changeset in webkit [120302] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: render dock-to-right icon in status bar.
​https://bugs.webkit.org/show_bug.cgi?id=89040

Reviewed by Vsevolod Vlasov.

Today we render dock to bottom icon for both actions (dock to bottom and dock to right).

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/inspector.css:

(button.dock-status-bar-item.status-bar-item.toggled-undock .glyph):
(button.dock-status-bar-item.status-bar-item.toggled-bottom .glyph):
(button.dock-status-bar-item.status-bar-item.toggled-right .glyph):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._installDockToRight.listener):
(windowLoaded):
(WebInspector.setDockingUnavailable):

2:43 AM Changeset in webkit [120301] by commit-queue@webkit.org
  • 19 edits
    4 adds in trunk

[WK2] Add implementation for registerIntentService in WebFrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=88399

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for registerIntentService() in
WebFrameLoaderClient.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.h:
  • Shared/APIObject.h:
  • Shared/IntentServiceInfo.cpp: Added.

(WebKit):
(WebKit::IntentServiceInfo::encode):
(WebKit::IntentServiceInfo::decode):

  • Shared/IntentServiceInfo.h: Added.

(CoreIPC):
(WebKit):
(IntentServiceInfo):

  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • UIProcess/WebIntentServiceInfo.cpp: Added.

(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

  • UIProcess/WebIntentServiceInfo.h: Added.

(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):

  • UIProcess/WebLoaderClient.cpp:

(WebKit):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):

  • UIProcess/WebLoaderClient.h:

(WebKit):
(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::registerIntentServiceForFrame):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):
(WebKit::WebFrameLoaderClient::registerIntentService):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Tools:

Update initialization of WKPageLoaderClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

2:32 AM Changeset in webkit [120300] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[Blackberry] add a new Api named setAllowNotification
​https://bugs.webkit.org/show_bug.cgi?id=88950

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2012-06-14
Reviewed by Antonio Gomes.

.:

Add a new API named setAllowNotification in webpage class to
let client set those allowed domains into notifications.

Test case:

  • ManualTests/blackberry/notification.html: Added.

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setAllowNotification):
(WebKit):

  • Api/WebPage.h:
2:31 AM Changeset in webkit [120299] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: clear execution live before the text edit.
​https://bugs.webkit.org/show_bug.cgi?id=89016

Reviewed by Vsevolod Vlasov.

Otherwise we can't remove them after committing the edit.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):

2:25 AM Changeset in webkit [120298] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=89044

Patch by Min Qin <​qinmin@google.com> on 2012-06-14
Reviewed by Adam Barth.

Source/WebCore:

enterFullscreen() and exitFullscreen() could both modify the player state.
This change reverts the change we made in r120213.

Just function declaration change, no test needed.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):

Source/WebKit/chromium:

enterFullscreen() should be treated similarly as exitFullscreen() as it could alter the player state.
This reverts the change from r120213.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

1:40 AM Changeset in webkit [120297] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

[WK2] Add WKHitTestResultIsContentEditable()
​https://bugs.webkit.org/show_bug.cgi?id=80597

Reviewed by Martin Robinson.

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::encode): Encode isContentEditable.
(WebKit::WebHitTestResult::Data::decode): Decode isContentEditable.

  • Shared/WebHitTestResult.h:

(Data): Add isContentEditable.
(WebKit::WebHitTestResult::Data::Data): Initialize
isContentEditable.
(WebKit::WebHitTestResult::isContentEditable): Returns whether
hit test result target is editable content.

  • UIProcess/API/C/WKHitTestResult.cpp:

(WKHitTestResultIsContentEditable): C API to get whether hit test
result target is editable content.

  • UIProcess/API/C/WKHitTestResult.h:
  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkitHitTestResultCreate): Add
WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE flags to the context if
hit test result target is editable content.
(webkit_hit_test_result_context_is_editable): Returns TRUE if
WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE flags is present in
context.

  • UIProcess/API/gtk/WebKitHitTestResult.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Add tests for
WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE.

1:31 AM Changeset in webkit [120296] by commit-queue@webkit.org
  • 7 edits in trunk

el.getAttribute('type') returns 'null' when setting el.type to null
​https://bugs.webkit.org/show_bug.cgi?id=89030

Patch by Edaena Salinas Jasso <​edaena@apple.com> on 2012-06-14
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/dom/HTMLButtonElement/change-type.html

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::setType): Changed parameter to be AtomicString to
address an unrelated review comment from bug 14439 for slightly better performance.

  • html/HTMLButtonElement.h:

(HTMLButtonElement): Changed parameter to be AtomicString to address an unrelated
review comment from bug 14439 for slightly better performance.

  • html/HTMLButtonElement.idl: Specified TreatNullAs NullString for the type attribute.

LayoutTests:

  • fast/dom/HTMLButtonElement/change-type-expected.txt: Updated the expected output

so that it matches the null return type of getAttribute('type').

  • fast/dom/HTMLButtonElement/change-type.html: Change test of getAttribute('type')

to be null instead of 'null'. Addressed and unrelated review comment from bug 14439
about how 'undefined' is specified in the shouldBe function.

1:06 AM Changeset in webkit [120295] by commit-queue@webkit.org
  • 20 edits in trunk

IndexedDB: Creating a transaction from within a transaction callback should fail
​https://bugs.webkit.org/show_bug.cgi?id=80547

Patch by Alec Flett <​alecflett@chromium.org> on 2012-06-14
Reviewed by Tony Chang.

Source/WebCore:

Prevent creation of a transaction, via IDBDatabase.transaction()
or IDBDatabase.setVersion(), from inside a setVersion()
transaction, as per spec. Update many tests to deal with this.

Test restructuring uncovered some inconsistencies in transaction
mode handling. So also do some minor cleanup in the way the
transaction mode is passed between the frontend and backend
transaction objects, and add additional asserts.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

LayoutTests:

  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/resources/cursor-update-updates-indexes.js:

(setupObjectStoreAndCreateIndexAndAdd.transaction.oncomplete):
(setupObjectStoreAndCreateIndexAndAdd):

  • storage/indexeddb/mozilla/resources/object-store-remove-values.js:

(createObjectStore):
(finalCheck):

  • storage/indexeddb/mozilla/resources/remove-objectstore.js:

(createAndPopulateObjectStore):
(postSetVersion2.request.onsuccess):
(postSetVersion2):
(deleteSecondObjectStore):

  • storage/indexeddb/resources/cursor-update.js:

(openBasicCursor):
(keyCursor):
(testReadOnly):
(attemptUpdate):

  • storage/indexeddb/resources/database-basics.js:

(openSuccess.request.onsuccess):
(openSuccess):
(setVersionSuccess.request.onsuccess):
(setVersionSuccess):
(createObjectStore):

  • storage/indexeddb/resources/version-change-exclusive.js:

(test):

  • storage/indexeddb/version-change-exclusive-expected.txt:
1:00 AM Changeset in webkit [120294] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
​https://bugs.webkit.org/show_bug.cgi?id=84577

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-14
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

Add missing implementation setDomainRelaxationForbiddenForURLScheme to
EFL's DumpRenderTreeSupport to allow disabling domain relaxation.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setDomainRelaxationForbiddenForURLScheme):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
LayoutTestController.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

LayoutTests:

Unskip http/tests/security/setDomainRelaxationForbiddenForURLScheme.html

  • platform/efl/Skipped:
12:52 AM Changeset in webkit [120293] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updating baseline after r120257.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-06-14

  • fast/table/max-width-integer-overflow-expected.txt:
12:36 AM Changeset in webkit [120292] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Rename WebFrameClient::userAgent() to better reflect what it does
​https://bugs.webkit.org/show_bug.cgi?id=89028

Patch by Dan Alcantara <​dfalcantara@chromium.org> on 2012-06-14
Reviewed by Adam Barth.

Renames WebFrameClient::userAgent() to userAgentOverride() and makes it return
the user agent override string directly.

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::userAgentOverride):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::userAgent):

  • tests/FrameLoaderClientImplTest.cpp:
12:22 AM Changeset in webkit [120291] by commit-queue@webkit.org
  • 8 edits in trunk

[WebSocket] WebSocket object in Worker Context should fire error event when it fails connection.
​https://bugs.webkit.org/show_bug.cgi?id=88744

Patch by Li Yin <​li.yin@intel.com> on 2012-06-14
Reviewed by Kent Tamura.

Source/WebCore:

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
The behavior of firing error event in Document has been implemented in Committed r117944.
WebSocket in WorkerContext is also required to fire error event.

Test: http/tests/websocket/tests/hybi/workers/close.html

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageErrorCallback):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidReceiveMessageError):
(WebCore):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(Peer):

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/close-expected.txt:
  • http/tests/websocket/tests/hybi/workers/resources/close.js:

(testPassed):
(runCodeTest.else.ws.onerror):
(runCodeTest):
(runReasonTest.else.ws.onerror):
(runReasonTest):

12:04 AM Changeset in webkit [120290] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix client interface size for WKPageLoaderClient.
​https://bugs.webkit.org/show_bug.cgi?id=88764

Reviewed by Anders Carlsson.

Fixes offset of WKPageLoaderClient for version 0 by adding didDetectXSSForFrame.
The offset should be off the first new callback that was added in the new version.

  • Shared/APIClientTraits.cpp:

(WebKit):

Note: See TracTimeline for information about the timeline view.