Timeline
Jun 16, 2012:
- 9:53 PM Changeset in webkit [120546] by
-
- 18 edits in trunk/Tools
Make garden-o-matic work for the Apple Mac port
https://bugs.webkit.org/show_bug.cgi?id=84642
Reviewed by Adam Barth.
Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
educating the scripts in various ways:
- Wrap up platform-related differences in config.kPlatforms[]
- Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
- The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do, so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most recent build with valid results.
- The webkit.org bots often generate results directories with no layout test data (e.g. when testers try to test a build that has already been deleted). Make walkHistory() more robust here.
- webkit.org uses differently named test result directories, that include the SVN revision as well as the build number. That forces us to fetch more build info before we can get the result directory URL.
- chromium.org serves raw directory listings for a builder's results directories. webkit.org serves those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results dirs.
- Various URLs differ between webkit.org and chromium.org
- Better UI for the failures info, so that some info is visible even when not hovered.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li table.failures):
(ol.notifications>li:hover table.failures):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#onebar #platform-picker):
- Scripts/webkitpy/layout_tests/port/builders.py:
- 9:42 PM Changeset in webkit [120545] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.
https://bugs.webkit.org/show_bug.cgi?id=89277
This patch makes blur and drop shadow shader share gaussian formula.
On the other hand, blur and drop shadow filter computed a gaussian weight in
pixel shader. However, a gaussian kernal has always same values, so this patch
computes the gaussian kernel only one time using CPU.
It is more accurate and faster.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
Covered by existing tests, particularly css3/filters/.
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::gauss):
(WebCore::gaussianKernel):
(WebCore::StandardFilterProgram::prepare):
- platform/graphics/texmap/TextureMapperShaderManager.h:
- 8:55 PM Changeset in webkit [120544] by
-
- 11 edits in trunk/Source
[chromium] Make the deviceScaleFactor dynamically adjustable.
https://bugs.webkit.org/show_bug.cgi?id=88916
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h: Plumb setDeviceScaleFactor and
deviceScaleFactor functions.
(WebKit::WebLayerTreeView::Settings::Settings): Remove deviceScaleFactor from
settings as it is now dynamic.
(Settings):
(WebLayerTreeView):
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed use of static
deviceScaleFactor from settings with dyanmic m_deviceScaleFactor
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings): Removed static deviceScaleFactor
(CCSettings):
(CCLayerTreeHost): Added dynamic m_deviceScaleFactor in its place.
(WebCore::CCLayerTreeHost::deviceScaleFactor):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Same as above.
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Added dynamic
m_deviceScaleFactor instance variable.
(WebCore::CCLayerTreeHostImpl::deviceScaleFactor):
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings): Removed unused
static deviceScaleFactor.
(WebKit::WebLayerTreeView::setDeviceScaleFactor):
(WebKit):
(WebKit::WebLayerTreeView::deviceScaleFactor):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDeviceScaleFactor): Push the dynamic deviceScaleFactor
to the compositor as required.
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- tests/CCLayerTreeHostTest.cpp: Tests use dynamic setDeviceScaleFactor.
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
- 6:05 PM Changeset in webkit [120543] by
-
- 9 edits2 moves in trunk
Unreviewed, rolling out r120536.
http://trac.webkit.org/changeset/120536
https://bugs.webkit.org/show_bug.cgi?id=89296
Does not compile on chromium-linux (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
Source/WebCore:
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
- WebKit.gyp:
- public/linux/WebFontRendering.h:
- public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.
(WebKit):
(WebFontRendering):
- src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 6:01 PM Changeset in webkit [120542] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r120539.
http://trac.webkit.org/changeset/120539
https://bugs.webkit.org/show_bug.cgi?id=89295
Does not compile on chromium-mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
Source/WebCore:
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 5:39 PM Changeset in webkit [120541] by
-
- 34 edits in trunk
layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=89274
Reviewed by Levi Weintraub.
Tools:
Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
Note: The WebKit2 API that setBackingScaleFactor exercises is still
tested by API-level tests.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
LayoutTests:
We don't need both layoutTestController.setBackingScaleFactor and
internals.settings.setDeviceScaleFactor because they do exactly the
same thing. This patch removes setBackingScaleFactor because it's
async nature is annoying and implementing it requires a bunch of
port-specific code.
- fast/hidpi/broken-image-icon-hidpi.html:
- fast/hidpi/broken-image-with-size-hidpi.html:
- fast/hidpi/clip-text-in-hidpi.html:
- fast/hidpi/focus-rings.html:
- fast/hidpi/image-set-as-background.html:
- fast/hidpi/image-set-background-dynamic.html:
- fast/hidpi/image-set-background-repeat-without-size.html:
- fast/hidpi/image-set-background-repeat.html:
- fast/hidpi/image-set-border-image-comparison.html:
- fast/hidpi/image-set-border-image-dynamic.html:
- fast/hidpi/image-set-border-image-simple.html:
- fast/hidpi/image-set-in-content-dynamic.html:
- fast/hidpi/image-set-out-of-order.html:
- fast/hidpi/image-set-simple.html:
- fast/hidpi/image-set-without-specified-width.html:
- fast/hidpi/resize-corner-hidpi.html:
- fast/hidpi/video-controls-in-hidpi.html:
- svg/as-image/image-respects-deviceScaleFactor.html:
- 5:35 PM Changeset in webkit [120540] by
-
- 3 edits4 adds in trunk
Ignore paths in Content Security Policy sources rather than failing to parse them.
https://bugs.webkit.org/show_bug.cgi?id=89281
Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Adam Barth.
Source/WebCore:
In short:
script-src http://example.com/should allow scripts from
http://example.com. Currently, it allows no scripts at all, as the
terminal/isn't accepted as part of a hostname.
This patch adjusts CSPSourceList::parseSource to accept paths (and
discard them). Once this lands, the next step will be to keep the
path, and use it when comparing source origins in the various
allowXXXFromSource methods.
Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-05.html
http/tests/security/contentSecurityPolicy/source-list-parsing-06.html
- page/ContentSecurityPolicy.cpp:
(CSPSourceList):
(WebCore):
(WebCore::CSPSourceList::parseSource):
Reworked this method entirely to support paths.
(WebCore::CSPSourceList::parsePath):
More or less a no-op at the moment.
(WebCore::CSPSourceList::parsePort):
Moved the
:assertion here from parseSource.
LayoutTests:
- http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-05.html: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-06.html: Added.
- 5:26 PM Changeset in webkit [120539] by
-
- 13 edits in trunk/Source
[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-16
Reviewed by Adrienne Walker.
Source/WebCore:
Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.
The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script
encoded as C string.
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 5:17 PM Changeset in webkit [120538] by
-
- 3 edits in trunk/LayoutTests
Fix test cases for
header/footerAXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=88911
The relative URLs to js-test-pre.js and js-test-post.js were incorrect.
Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Simon Fraser.
- platform/mac/accessibility/footer.html:
- platform/mac/accessibility/header.html:
- 5:13 PM Changeset in webkit [120537] by
-
- 5 edits in trunk/LayoutTests
[EFL] Rebaseline fast/lists/001*.html tests after r120495
https://bugs.webkit.org/show_bug.cgi?id=89283
Unreviewed EFL gardening after r120495.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-16
- platform/efl/fast/lists/001-expected.png:
- platform/efl/fast/lists/001-expected.txt:
- platform/efl/fast/lists/001-vertical-expected.png:
- platform/efl/fast/lists/001-vertical-expected.txt:
- 4:28 PM Changeset in webkit [120536] by
-
- 9 edits2 moves in trunk
[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228
Source/WebCore:
Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.
Reviewed by Tony Chang.
Refactory only. No new tests.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.
This also avoids the ambiguous name 'linuxish'.
Reviewed by Tony Chang.
- WebKit.gyp:
- public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.
(WebFontRendering):
- public/linux/WebFontRendering.h:
- public/linuxish: Removed.
- public/linuxish/WebFontRendering.h: Removed.
- src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):
- src/linuxish: Removed.
- src/linuxish/WebFontRendering.cpp: Removed.
Tools:
Reviewed by Tony Chang.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 4:01 PM WebKit Team edited by
- Changed affiliation (diff)
- 3:59 PM Changeset in webkit [120535] by
-
- 22 edits in trunk/LayoutTests
[EFL] Rebaseline MathML tests after r120492
https://bugs.webkit.org/show_bug.cgi?id=89282
Unreviewed EFL gardening. Several MathML tests needed
rebaselining after r120492.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-16
- platform/efl/mathml/presentation/attributes-expected.txt:
- platform/efl/mathml/presentation/fenced-expected.txt:
- platform/efl/mathml/presentation/fenced-mi-expected.txt:
- platform/efl/mathml/presentation/fractions-expected.txt:
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
- platform/efl/mathml/presentation/roots-expected.txt:
- platform/efl/mathml/presentation/row-alignment-expected.png:
- platform/efl/mathml/presentation/row-alignment-expected.txt:
- platform/efl/mathml/presentation/sub-expected.txt:
- platform/efl/mathml/presentation/subsup-expected.txt:
- platform/efl/mathml/presentation/sup-expected.txt:
- platform/efl/mathml/presentation/tables-expected.txt:
- platform/efl/mathml/presentation/tokenElements-expected.txt:
- platform/efl/mathml/presentation/under-expected.png:
- platform/efl/mathml/presentation/under-expected.txt:
- platform/efl/mathml/presentation/underover-expected.png:
- platform/efl/mathml/presentation/underover-expected.txt:
- platform/efl/mathml/xHeight-expected.png:
- platform/efl/mathml/xHeight-expected.txt:
- 3:35 PM Changeset in webkit [120534] by
-
- 7 edits in trunk/Source
Settings::devicePixelRatio doesn't do anything and is confusing
https://bugs.webkit.org/show_bug.cgi?id=89272
Reviewed by James Robinson.
Source/WebCore:
Settings::devicePixelRatio is yet another piece of state trying to
represent the device scale factor. The canonical place to store this
state is Page::m_deviceScaleFactor. Nothing in WebCore references
Settings::devicePixelRatio anymore, so we can remove it.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(Settings):
Source/WebKit2:
- Shared/WebPreferencesStore.h:
(WebKit):
- Remove boilerplate code for the setting.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):
- Change these functions to get and set the real device scale factor.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
- Use the real device scale factor for the viewport calculation.
(WebKit::WebPage::updatePreferences):
- Remove boilerplate code for the setting.
- 3:22 PM Changeset in webkit [120533] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] SIGSEV in WebCore::TextureMapperGL::drawTexture.
https://bugs.webkit.org/show_bug.cgi?id=89113
TextureMapperTile::m_texture is created lazilly, so we need null check before
using it.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
No new tests. This patch doesn't change behavior.
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::paint):
- 3:17 PM Changeset in webkit [120532] by
-
- 5 edits in trunk/Source/WebCore
[Texmap] Remove unused code in Texmap.
https://bugs.webkit.org/show_bug.cgi?id=89265
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingState):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
- 3:10 PM Changeset in webkit [120531] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
- DEPS:
- 1:00 PM Changeset in webkit [120530] by
-
- 12 edits2 adds9 deletes in trunk/LayoutTests
Remove a bunch of 32-bit specific results. These results are the same
on 64 bit.
- platform/chromium-linux-x86/compositing/color-matching: Removed.
- platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom: Removed.
- platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
- platform/chromium-linux-x86/fast/images: Removed.
- platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Removed.
- platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Removed.
- platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-linux/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-linux/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-linux/fast/images/png-with-color-profile-expected.png: Added.
- 12:53 PM Changeset in webkit [120529] by
-
- 61 edits19 adds27 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/120485
- platform/chromium-linux-x86/http/tests/local: Removed.
- platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Removed.
- platform/chromium-linux-x86/scrollbars: Removed.
- platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
- platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
- platform/chromium-linux-x86/svg/as-border-image: Removed.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Removed.
- platform/chromium-linux-x86/svg/repaint: Removed.
- platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Removed.
- platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
- platform/chromium-linux/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/createImageElement2-expected.png:
- platform/chromium-linux/svg/custom/focus-ring-expected.png:
- platform/chromium-linux/svg/custom/image-parent-translation-expected.png:
- platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
- platform/chromium-linux/svg/custom/text-image-opacity-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win-vista/http/tests/local: Removed.
- platform/chromium-win-vista/svg/dynamic-updates: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/chromium-win-xp/svg/dynamic-updates: Removed.
- platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/custom/createImageElement-expected.png:
- platform/chromium-win/svg/custom/createImageElement2-expected.png:
- platform/chromium-win/svg/custom/focus-ring-expected.png:
- platform/chromium-win/svg/custom/group-opacity-expected.png:
- platform/chromium-win/svg/custom/image-parent-translation-expected.png:
- platform/chromium-win/svg/custom/image-small-width-height-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-win/svg/custom/js-update-image-expected.png:
- platform/chromium-win/svg/custom/text-image-opacity-expected.png:
- platform/chromium-win/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/chromium-win/svg/filters/filter-source-position-expected.png:
- platform/chromium-win/svg/repaint/image-href-change-expected.png:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- 9:48 AM Changeset in webkit [120528] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines
after r120492 and r120495.
- platform/gtk/fast/lists/001-expected.txt:
- platform/gtk/fast/lists/001-vertical-expected.txt:
- platform/gtk/mathml/xHeight-expected.txt:
- 9:16 AM Changeset in webkit [120527] by
-
- 2 edits in trunk/Source/WebCore
[TexmapGL] Reduce the number of glTexSubImage2D calls
https://bugs.webkit.org/show_bug.cgi?id=83665
Instead of copy the pixels row by row, put the pixels in a buffer and
call glTexSubImage2D just once.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 2:21 AM Changeset in webkit [120526] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument
https://bugs.webkit.org/show_bug.cgi?id=89233
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-06-16
Reviewed by Darin Fisher.
Adds a WebFrame* to the WebFrameClient::userAgentOverride() function.
- public/WebFrameClient.h:
(WebKit::WebFrameClient::userAgentOverride):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp:
- 1:42 AM Changeset in webkit [120525] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip a new failing test.
- platform/qt-5.0-wk2/Skipped:
- 1:34 AM Changeset in webkit [120524] by
-
- 9 edits1 add in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
- platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
- platform/qt-5.0/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
- platform/qt-5.0/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
- platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Updated after r120495.
- platform/qt/fast/lists/001-expected.png: Updated after r120495.
- platform/qt/fast/lists/001-expected.txt: Updated after r120495.
- platform/qt/fast/lists/001-vertical-expected.png: Updated after r120495.
- platform/qt/fast/lists/001-vertical-expected.txt: Updated after r120495.
Jun 15, 2012:
- 10:01 PM Changeset in webkit [120523] by
-
- 5 edits in trunk
Unreviewed, rolling out r120280.
http://trac.webkit.org/changeset/120280
https://bugs.webkit.org/show_bug.cgi?id=89273
Enabling CSS regions broke all Windows tests (Requested by
jhomeycutt on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15
Source/WebCore:
- css/CSSPropertyNames.in:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 8:54 PM Changeset in webkit [120522] by
-
- 8 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in fast/workers/storage tests
https://bugs.webkit.org/show_bug.cgi?id=89271
Reviewed by Adam Barth.
- fast/workers/storage/change-version-sync.html:
- fast/workers/storage/interrupt-database-sync.html-disabled:
- fast/workers/storage/interrupt-database.html:
- fast/workers/storage/resources/database-worker.js:
(onmessage):
- fast/workers/storage/resources/multiple-transactions-sync.js:
(checkCompletion):
- fast/workers/storage/resources/test-inputs-common.js:
(finishTest):
- fast/workers/storage/use-same-database-in-page-and-workers.html:
- 8:42 PM Changeset in webkit [120521] by
-
- 206 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in transforms, transitions, traversal, userscripts, webarchive, webaudio, and webintents tests
https://bugs.webkit.org/show_bug.cgi?id=89269
Reviewed by Adam Barth.
- transitions/:
- traversal/:
- userscripts/:
- webarchive/:
- webaudio/:
- webintents/web-intents-delivery.html:
- webintents/web-intents-failure.html:
- webintents/web-intents-reload.html:
- webintents/web-intents-reply.html:
- 8:35 PM Changeset in webkit [120520] by
-
- 2 edits in trunk/Tools
garden-o-matic's results.js should use RequestTracker
https://bugs.webkit.org/show_bug.cgi?id=89257
Reviewed by Dimitri Glazkov.
We wrote results.js before we recognized the RequestTracker pattern.
This patch replaces the manual implementations of RequestTracker with
the real deal.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- 8:30 PM Changeset in webkit [120519] by
-
- 293 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in the rest of sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=89262
Reviewed by Antti Koivisto.
- sputnik/Implementation_Diagnostics/:
- sputnik/Regression/:
- sputnik/Unicode/:
- 8:10 PM Changeset in webkit [120518] by
-
- 2 edits in trunk/LayoutTests
Test fix attempt after r120516.
- fast/workers/storage/resources/database-worker-controller.js:
(databaseWorker.onmessage):
(runTest):
- 7:23 PM Changeset in webkit [120517] by
-
- 2 edits in trunk/Tools
- Scripts/webkitpy/bindings: Added property svn:ignore.
- 7:16 PM Changeset in webkit [120516] by
-
- 105 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in storage, tables, touchadjustments, and transforms tests
https://bugs.webkit.org/show_bug.cgi?id=89263
Reviewed by Antti Koivisto.
- storage/domstorage/events/resources/eventTestHarness.js:
(testStorages.allDone):
- storage/domstorage/localstorage/delete-removal.html:
- storage/domstorage/localstorage/enumerate-storage.html:
- storage/domstorage/localstorage/enumerate-with-length-and-key.html:
- storage/domstorage/localstorage/index-get-and-set.html:
- storage/domstorage/localstorage/private-browsing-affects-storage.html:
- storage/domstorage/localstorage/resources/window-open-second.html:
- storage/domstorage/localstorage/simple-usage.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt:
- storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt:
- storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html:
- storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt:
- storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html:
- storage/domstorage/localstorage/string-conversion.html:
- storage/domstorage/localstorage/window-open.html:
- storage/domstorage/script-tests/storage-functions-not-overwritten.js:
- storage/domstorage/sessionstorage/delete-removal.html:
- storage/domstorage/sessionstorage/enumerate-storage.html:
- storage/domstorage/sessionstorage/enumerate-with-length-and-key.html:
- storage/domstorage/sessionstorage/index-get-and-set.html:
- storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
- storage/domstorage/sessionstorage/resources/window-open-second.html:
- storage/domstorage/sessionstorage/simple-usage.html:
- storage/domstorage/sessionstorage/string-conversion.html:
- storage/domstorage/sessionstorage/window-open.html:
- storage/domstorage/window-attributes-exist.html:
- storage/indexeddb/mozilla/index-prev-no-duplicate.html:
- storage/indexeddb/tutorial.html:
- storage/websql/change-version-handle-reuse.js:
(finishTest):
- storage/websql/change-version-no-crash-on-preflight-failure.html:
- storage/websql/change-version.html:
- storage/websql/close-during-stress-test.html:
- storage/websql/database-lock-after-reload.html:
- storage/websql/empty-statement.html:
- storage/websql/execute-sql-args.js:
(runTransactionTests):
- storage/websql/executesql-accepts-only-one-statement.html:
- storage/websql/hash-change-with-xhr.js:
(stopTest):
- storage/websql/multiple-databases-garbage-collection.js:
(checkCompletion):
- storage/websql/multiple-transactions-on-different-handles.js:
(checkCompletion):
- storage/websql/multiple-transactions.js:
(checkCompletion):
- storage/websql/null-callbacks.html:
- storage/websql/open-database-creation-callback-isolated-world.html:
- storage/websql/open-database-creation-callback.html:
- storage/websql/open-database-empty-version.html:
- storage/websql/open-database-over-quota.html:
- storage/websql/open-database-set-empty-version.html:
- storage/websql/open-database-while-transaction-in-progress.js:
(runTest):
- storage/websql/private-browsing-noread-nowrite.html:
- storage/websql/quota-tracking.html:
- storage/websql/read-and-write-transactions-dont-run-together.js:
(terminateTest):
- storage/websql/read-transactions-running-concurrently.html:
- storage/websql/resources/database-common.js:
(setupAndRunTest):
- storage/websql/resources/database-lock-after-reload-2.html:
- storage/websql/sql-data-types.js:
(notifyDone):
(runTest):
- storage/websql/sql-error-codes.js:
(finishTest):
(runTest):
- storage/websql/statement-error-callback-isolated-world.html:
- storage/websql/statement-error-callback.html:
- storage/websql/statement-success-callback-isolated-world.html:
- storage/websql/success-callback.html:
- storage/websql/test-authorizer.js:
(terminateTest):
- storage/websql/transaction-callback-exception-crash.html:
- storage/websql/transaction-callback-isolated-world.html:
- storage/websql/transaction-error-callback-isolated-world.html:
- storage/websql/transaction-error-callback.html:
- storage/websql/transaction-success-callback-isolated-world.html:
- tables/hittesting/filltable-emptycells.html:
- tables/hittesting/filltable-levels.html:
- tables/hittesting/filltable-outline.html:
- tables/hittesting/filltable-rtl.html:
- tables/hittesting/filltable-stress.html:
- tables/layering/paint-test-layering-1.html:
- tables/layering/paint-test-layering-2.html:
- tables/table-section-overflow-clip-crash.html:
- touchadjustment/block-testing.html:
- touchadjustment/event-triggered-widgets.html:
- touchadjustment/html-label.html:
- touchadjustment/iframe.html:
- touchadjustment/nested-touch.html:
- touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
- touchadjustment/scroll-offset.html:
- touchadjustment/touch-inlines.html:
- touchadjustment/zoom-basic.html:
- touchadjustment/zoom-fatfinger.html:
- transforms/2d/compound-2d-transforms.html:
- transforms/2d/cssmatrix-2d-zoom.html:
- transforms/2d/set-transform-and-top.html:
- transforms/2d/transform-2d.html:
- transforms/2d/transform-accuracy.html:
- transforms/3d/general/3dtransform-values.html:
- transforms/3d/general/cssmatrix-3d-zoom.html:
- transforms/3d/general/matrix-with-zoom-3d.html:
- transforms/3d/general/transform-origin-z-change.html:
- transforms/3d/hit-testing/hit-preserves-3d.html:
- transforms/3d/point-mapping/3d-point-mapping-2.html:
- transforms/3d/point-mapping/3d-point-mapping-3.html:
- transforms/3d/point-mapping/3d-point-mapping-deep.html:
- transforms/3d/point-mapping/3d-point-mapping-origins.html:
- transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
- transforms/no_transform_hit_testing.html:
- 7:06 PM Changeset in webkit [120515] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove empty directories.
- platform/editing: Removed.
- platform/editing/inserting: Removed.
- websocket: Removed.
- websocket/tests: Removed.
- websocket/tests/workers: Removed.
- 6:15 PM Changeset in webkit [120514] by
-
- 6 edits in trunk/LayoutTests/platform
2012-06-15 Andrew Wilson <atwilson@chromium.org>
Unreviewed chromium expectations update.
https://bugs.webkit.org/show_bug.cgi?id=82122
https://bugs.webkit.org/show_bug.cgi?id=79914
- platform/chromium-mac-leopard/fast/lists/001-expected.png:
- platform/chromium-mac/fast/lists/001-expected.png:
- platform/chromium-mac/fast/lists/001-vertical-expected.png:
- platform/chromium-win/fast/lists/001-expected.png:
- platform/chromium-win/fast/lists/001-vertical-expected.png:
- platform/chromium/TestExpectations:
- 5:49 PM Changeset in webkit [120513] by
-
- 8 edits2 moves in trunk
Unreviewed, rolling out r120511.
http://trac.webkit.org/changeset/120511
https://bugs.webkit.org/show_bug.cgi?id=89255
Breaks at least Android builder (Requested by wangxianzhu on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15
Source/WebCore:
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
- WebKit.gyp:
- public/linux/WebFontRendering.h:
- public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.
(WebKit):
(WebFontRendering):
- src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- 5:33 PM Changeset in webkit [120512] by
-
- 209 edits71 adds in trunk/LayoutTests
Unreviewed baselines for chromium.
https://bugs.webkit.org/show_bug.cgi?id=87761
- platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Added.
- platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Added.
- platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Added.
- platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
- platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Added.
- platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Added.
- platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
- platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
- platform/chromium-mac-leopard/compositing/reflections/simple-composited-reflections-expected.png:
- platform/chromium-mac-leopard/compositing/visibility/visibility-image-layers-expected.png:
- platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
- platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png:
- platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
- platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
- platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
- platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
- platform/chromium-mac-leopard/fast/css/color-correction-expected.png:
- platform/chromium-mac-leopard/fast/css/color-correction-on-backgrounds-expected.png:
- platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
- platform/chromium-mac-leopard/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-mac-leopard/fast/images/png-with-color-profile-expected.png: Added.
- platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
- platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac-leopard/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
- platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png:
- platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png:
- platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-leopard/svg/custom/group-opacity-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
- platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png:
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/chromium-mac-leopard/svg/filters/filter-source-position-expected.png:
- platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png:
- platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
- platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac-snowleopard/fast/css/color-correction-expected.png:
- platform/chromium-mac-snowleopard/fast/css/color-correction-on-backgrounds-expected.png:
- platform/chromium-mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/images/png-with-color-profile-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png:
- platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png:
- platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png:
- platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
- platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
- platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
- platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
- platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
- platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-mac/css3/filters/effect-blur-expected.png:
- platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-expected.png:
- platform/chromium-mac/css3/filters/effect-contrast-expected.png:
- platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
- platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-mac/css3/filters/effect-invert-expected.png:
- platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-opacity-expected.png:
- platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-saturate-expected.png:
- platform/chromium-mac/css3/filters/effect-sepia-expected.png:
- platform/chromium-mac/css3/filters/regions-expanding-expected.png:
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
- platform/chromium-mac/fast/css/color-correction-expected.png:
- platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
- platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.png:
- platform/chromium-mac/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-mac/fast/images/png-with-color-profile-expected.png: Added.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
- platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
- platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
- platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
- platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png:
- platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-mac/svg/custom/createImageElement-expected.png:
- platform/chromium-mac/svg/custom/createImageElement2-expected.png:
- platform/chromium-mac/svg/custom/focus-ring-expected.png:
- platform/chromium-mac/svg/custom/group-opacity-expected.png:
- platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-mac/svg/custom/js-update-image-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
- platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
- platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/chromium-mac/svg/filters/filter-source-position-expected.png:
- platform/chromium-mac/svg/repaint/image-href-change-expected.png:
- platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-win/css3/filters/crash-filter-change-expected.png:
- platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-win/css3/filters/effect-blur-expected.png:
- platform/chromium-win/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-win/css3/filters/effect-combined-expected.png:
- platform/chromium-win/css3/filters/effect-contrast-expected.png:
- platform/chromium-win/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
- platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-win/css3/filters/effect-grayscale-expected.png:
- platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
- platform/chromium-win/css3/filters/effect-invert-expected.png:
- platform/chromium-win/css3/filters/effect-invert-hw-expected.png:
- platform/chromium-win/css3/filters/effect-opacity-expected.png:
- platform/chromium-win/css3/filters/effect-opacity-hw-expected.png:
- platform/chromium-win/css3/filters/effect-saturate-expected.png:
- platform/chromium-win/css3/filters/effect-sepia-expected.png:
- platform/chromium-win/css3/filters/regions-expanding-expected.png:
- platform/chromium-win/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-win/fast/images/png-with-color-profile-expected.png: Added.
- platform/chromium/TestExpectations:
- 5:24 PM Changeset in webkit [120511] by
-
- 8 edits2 moves in trunk
[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228
Source/WebCore:
Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.
Reviewed by Tony Chang.
Refactory only. No new tests.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.
This also avoids the ambiguous name 'linuxish'.
Reviewed by Tony Chang.
- WebKit.gyp:
- public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.
(WebFontRendering):
- public/linux/WebFontRendering.h:
- public/linuxish: Removed.
- public/linuxish/WebFontRendering.h: Removed.
- src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):
- src/linuxish: Removed.
- src/linuxish/WebFontRendering.cpp: Removed.
Tools:
Reviewed by Tony Chang.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- 4:35 PM Changeset in webkit [120510] by
-
- 72 edits in trunk/LayoutTests
IndexedDB: Remove obsolete description parameter from factory.open calls
https://bugs.webkit.org/show_bug.cgi?id=89047
Reviewed by Tony Chang.
This parameter has been obsolete for 18 months and is getting replaced
with a version parameter.
- storage/indexeddb/mozilla/add-twice-failure-expected.txt:
- storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
- storage/indexeddb/mozilla/bad-keypath-expected.txt:
- storage/indexeddb/mozilla/clear-expected.txt:
- storage/indexeddb/mozilla/create-index-unique-expected.txt:
- storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
- storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
- storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
- storage/indexeddb/mozilla/cursors-expected.txt:
- storage/indexeddb/mozilla/delete-result-expected.txt:
- storage/indexeddb/mozilla/event-source-expected.txt:
- storage/indexeddb/mozilla/global-data-expected.txt:
- storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
- storage/indexeddb/mozilla/index-prev-no-duplicate.html:
- storage/indexeddb/mozilla/indexes-expected.txt:
- storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
- storage/indexeddb/mozilla/key-requirements-expected.txt:
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
- storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
- storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
- storage/indexeddb/mozilla/object-cursors-expected.txt:
- storage/indexeddb/mozilla/object-identity-expected.txt:
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
- storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
- storage/indexeddb/mozilla/objectstorenames-expected.txt:
- storage/indexeddb/mozilla/odd-result-order-expected.txt:
- storage/indexeddb/mozilla/put-get-values-expected.txt:
- storage/indexeddb/mozilla/readonly-transactions-expected.txt:
- storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
- storage/indexeddb/mozilla/readyState-expected.txt:
- storage/indexeddb/mozilla/remove-index-expected.txt:
- storage/indexeddb/mozilla/remove-objectstore-expected.txt:
- storage/indexeddb/mozilla/resources/add-twice-failure.js:
(test):
- storage/indexeddb/mozilla/resources/autoincrement-indexes.js:
(test):
- storage/indexeddb/mozilla/resources/bad-keypath.js:
(test):
- storage/indexeddb/mozilla/resources/clear.js:
(test):
- storage/indexeddb/mozilla/resources/create-index-unique.js:
(test):
- storage/indexeddb/mozilla/resources/create-index-with-integer-keys.js:
(test):
- storage/indexeddb/mozilla/resources/create-objectstore-basics.js:
(test):
- storage/indexeddb/mozilla/resources/create-objectstore-null-name.js:
(test):
- storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:
(test):
- storage/indexeddb/mozilla/resources/cursor-update-updates-indexes.js:
(test):
- storage/indexeddb/mozilla/resources/cursors.js:
(test):
- storage/indexeddb/mozilla/resources/delete-result.js:
(test):
- storage/indexeddb/mozilla/resources/event-source.js:
(test):
- storage/indexeddb/mozilla/resources/global-data.js:
(test):
(cleanDatabase):
- storage/indexeddb/mozilla/resources/indexes.js:
(test):
- storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:
(test):
- storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:
(test):
- storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:
(test):
- storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:
(test):
- storage/indexeddb/mozilla/resources/key-requirements.js:
(test):
- storage/indexeddb/mozilla/resources/object-cursors.js:
(test):
- storage/indexeddb/mozilla/resources/object-identity.js:
(test):
- storage/indexeddb/mozilla/resources/object-store-inline-autoincrement-key-added-on-put.js:
(test):
- storage/indexeddb/mozilla/resources/object-store-remove-values.js:
(test):
- storage/indexeddb/mozilla/resources/objectstorenames.js:
(test):
- storage/indexeddb/mozilla/resources/odd-result-order.js:
(test):
- storage/indexeddb/mozilla/resources/put-get-values.js:
(test):
- storage/indexeddb/mozilla/resources/readonly-transactions.js:
(test):
- storage/indexeddb/mozilla/resources/readwrite-transactions.js:
(test):
- storage/indexeddb/mozilla/resources/readyState.js:
(test):
- storage/indexeddb/mozilla/resources/remove-index.js:
(test):
- storage/indexeddb/mozilla/resources/remove-objectstore.js:
(test):
- storage/indexeddb/mozilla/resources/versionchange-abort.js:
(test):
- storage/indexeddb/mozilla/resources/versionchange.js:
(test):
(openSuccess):
(postSetVersion):
- storage/indexeddb/mozilla/versionchange-abort-expected.txt:
- storage/indexeddb/mozilla/versionchange-expected.txt:
- 4:33 PM Changeset in webkit [120509] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Fix composited scrollbars with transparent thumbs
https://bugs.webkit.org/show_bug.cgi?id=89247
Reviewed by James Robinson.
On some platforms, the thumb of a scrollbar can be transparent. Fix by
always drawing the thumb quad with blending.
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:
(WebCore::CCTextureDrawQuad::setNeedsBlending):
(WebCore):
- platform/graphics/chromium/cc/CCTextureDrawQuad.h:
(CCTextureDrawQuad):
- 4:18 PM Changeset in webkit [120508] by
-
- 1 edit1 delete in trunk/Source/WebKit/chromium
[chromium] Remove WebKit/chromium/public/gtk/WebFontInfo.h since it's no longer referenced.
https://bugs.webkit.org/show_bug.cgi?id=89251
Reviewed by Adam Barth.
This was a forwarding header when we moved the file to public/linux.
- public/gtk/WebFontInfo.h: Removed.
- 4:13 PM Changeset in webkit [120507] by
-
- 5 edits2 deletes in trunk/Source/WebCore
[chromium] Use SkBitmap in ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=89134
Reviewed by Adrienne Walker.
GraphicsLayer::setContentsToImage(Image*) is called whenever an image layer's image is or might have changed.
In Chromium, this used to hang on to a RefPtr<WebCore::Image> until the compositor was ready to upload texture contents.
This is potentially a bit fishy since the Image itself might not be in exactly the same state when we get around
to uploading textures and it also creates a bad dependency from ImageLayerChromium on WebCore::Image.
This patch grabs the underlying SkBitmap in the setContentsTo call and passes that into ImageLayerChromium
instead. I've also removed the venerable but redundant PlatformImage concept since all of chromium's images are
skia bitmaps these days.
Covered by existing tests, particularly compositing/images/ and compositing/color-matching/.
- WebCore.gypi:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::setBitmap):
(ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::setBitmap):
(WebCore::ImageLayerChromium::update):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):
- platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
- platform/graphics/chromium/PlatformImage.cpp: Removed.
- platform/graphics/chromium/PlatformImage.h: Removed.
- 4:09 PM Changeset in webkit [120506] by
-
- 4 edits in trunk/Source
[BlackBerry] Use platform font settings for the standard settings.
https://bugs.webkit.org/show_bug.cgi?id=89232
Reviewed by Rob Buis.
RIM PR 159708
Source/WebCore:
- page/blackberry/SettingsBlackBerry.cpp:
(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):
Source/WebKit/blackberry:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- 3:58 PM Changeset in webkit [120505] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove touch events handling hook for popup
https://bugs.webkit.org/show_bug.cgi?id=89245
Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-15
Reviewed by Rob Buis.
In the old patches we create our own WebPage for popup, so we need to hook up our own
touch handling functions, since we don't use our own WebPage any more, no need to keep
the touch handling code, because it just does nothing other than passing out the events
which might cause the touch events being handled twice.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- WebCoreSupport/PagePopupBlackBerry.cpp:
- WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
- 3:49 PM Changeset in webkit [120504] by
-
- 10 edits3 adds in trunk
IndexedDB: Raise exceptions when methods are called on deleted objects
https://bugs.webkit.org/show_bug.cgi?id=89243
Reviewed by Tony Chang.
Source/WebCore:
Implement the IDB spec requirement that InvalidStateError exceptions are
thrown when methods are called on objects (i.e. object stores and indexes)
that have been deleted within a version change transaction.
Test: storage/indexeddb/deleted-objects.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::deleteObjectStore): Don't relay to transaction if back-end failed.
- Modules/indexeddb/IDBIndex.cpp: Check deleted state in methods, raise if set.
(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBIndex.h: Add flag to track deleted state, method to mark it.
(WebCore::IDBIndex::markDeleted):
(IDBIndex):
- Modules/indexeddb/IDBObjectStore.cpp: Check deleted state in methods, raise if set.
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex): If the index being deleted has been instantiated,
mark it as deleted.
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
- Modules/indexeddb/IDBObjectStore.h: Add flag to track deleted state, method to mark it.
(WebCore::IDBObjectStore::markDeleted):
(IDBObjectStore):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted): If the store being deleted has been instantiated,
mark it as deleted.
LayoutTests:
- storage/indexeddb/deleted-objects-expected.txt: Added.
- storage/indexeddb/deleted-objects.html: Added.
- storage/indexeddb/resources/deleted-objects.js: Added.
(test):
(openDatabase.request.onsuccess.request.onsuccess):
(openDatabase.request.onsuccess):
(openDatabase):
- storage/indexeddb/resources/transaction-basics.js: Fix test that relied on
non-compliant behavior.
(addRemoveIDBObjects):
(addRemoveAddIDBObjects):
- storage/indexeddb/transaction-basics-expected.txt:
- 3:30 PM Changeset in webkit [120503] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Forgot a rebaseline for r120477.
- platform/chromium-win/fast/forms/formmove3-expected.txt:
- 3:24 PM Changeset in webkit [120502] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
[BlackBerry] Put platform-specific GC policy in GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=89236
Patch by Yong Li <yoli@rim.com> on 2012-06-15
Reviewed by Rob Buis.
Add GCActivityCallbackBlackBerry.cpp and implement platform-specific
low memory GC policy there.
- PlatformBlackBerry.cmake:
- heap/Heap.h:
(JSC::Heap::isSafeToCollect): Added.
- runtime/GCActivityCallbackBlackBerry.cpp: Added.
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::DefaultGCActivityCallbackPlatformData):
(DefaultGCActivityCallbackPlatformData):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::synchronize):
(JSC::DefaultGCActivityCallback::cancel):
- 3:24 PM Changeset in webkit [120501] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
https://bugs.webkit.org/show_bug.cgi?id=89126
Reviewed by Stephen White.
When drawing an image buffer into a deferred device context, we have to make a deep copy of the source (Skia
can't for some reason). Stephen White fixed this in r101325 by adding a bit on PlatformContextSkia indicating if
a given context is deferred, but I broke this again in r120346 by refactoring the SkCanvas creation to happen in
a different location from the PlatformContextSkia construction.
This moves the check into ImageBufferSkia and directly queries the state of the destination SkDevice to be more
robust and work without needing special PlatformContextSkia setup.
Covered by LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::drawNeedsCopy):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
- 3:21 PM Changeset in webkit [120500] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should be able to set watchpoints on structure transitions in the
method check prototype chain
https://bugs.webkit.org/show_bug.cgi?id=89058
Adding the same assertion to 32-bit that I added to 64-bit. This change
does not affect correctness but it's a good thing for assertion coverage.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:14 PM Changeset in webkit [120499] by
-
- 24 edits3 adds in trunk
DFG should be able to set watchpoints on structure transitions in the
method check prototype chain
https://bugs.webkit.org/show_bug.cgi?id=89058
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
This adds the ability to set watchpoints on Structures, and then does
the most modest thing we can do with this ability: the DFG now sets
watchpoints on structure transitions in the prototype chain of method
checks.
This appears to be a >1% speed-up on V8.
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- bytecode/StructureSet.h:
(JSC::StructureSet::containsOnly):
(StructureSet):
- bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::WatchpointSet):
(JSC::InlineWatchpointSet::add):
(JSC):
(JSC::InlineWatchpointSet::inflateSlow):
(JSC::InlineWatchpointSet::freeFat):
- bytecode/Watchpoint.h:
(WatchpointSet):
(JSC):
(InlineWatchpointSet):
(JSC::InlineWatchpointSet::InlineWatchpointSet):
(JSC::InlineWatchpointSet::~InlineWatchpointSet):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::isStillValid):
(JSC::InlineWatchpointSet::startWatching):
(JSC::InlineWatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::isFat):
(JSC::InlineWatchpointSet::fat):
(JSC::InlineWatchpointSet::inflate):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.h:
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isCellConstant):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addWeakReferences):
(JITCompiler):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasStructure):
(Node):
(JSC::DFG::Node::structure):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
(JSC::Structure::transitionWatchpointSetHasBeenInvalidated):
(Structure):
(JSC::Structure::transitionWatchpointSetIsStillValid):
(JSC::Structure::addTransitionWatchpoint):
(JSC::Structure::notifyTransitionFromThisStructure):
(JSC::JSCell::setStructure):
- runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::attemptToWatch):
LayoutTests:
Rubber stamped by Gavin Barraclough.
- fast/js/dfg-call-method-hit-watchpoint-expected.txt: Added.
- fast/js/dfg-call-method-hit-watchpoint.html: Added.
- fast/js/script-tests/dfg-call-method-hit-watchpoint.js: Added.
(Thingy):
(Thingy.prototype.foo):
(callFoo):
(.Thingy.prototype.foo):
- 3:02 PM Changeset in webkit [120498] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Add support for explicit intents
https://bugs.webkit.org/show_bug.cgi?id=89206
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.
Expose the service URL of a Web Intent. This URL
is set for explicit intents.
- Shared/IntentData.h:
(IntentData):
- UIProcess/WebIntentData.h:
(WebKit::WebIntentData::service):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchIntent):
- 3:00 PM Changeset in webkit [120497] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Compositor should be aware of |flipped| status of video textures per-platform
https://bugs.webkit.org/show_bug.cgi?id=89189
Reviewed by James Robinson.
No new tests (sadly HW video decode is still only being tested manually for orientation).
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
- 2:58 PM Changeset in webkit [120496] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 2:54 PM Changeset in webkit [120495] by
-
- 56 edits2 moves in trunk
Source/WebCore: The initial value of text-align should be start instead of -webkit-auto
https://bugs.webkit.org/show_bug.cgi?id=79914
Reviewed by Tony Chang.
Change the initial value of text-align CSS property from -webkit-auto to start as specified in
http://www.w3.org/TR/css3-text/#text-align
In editing, we have to coerce start and end to left and right for now because match-parent,
which is the text-align value of li in UA stylesheet is going to result in the computed values of
left as supposed to start by default, and this causes editing code not being able to remove
text-align: left when computing typing styles and preserving styles.
In the long term, we should detect this specific case and ignore match-parent but that seemed like
too much work to be done in a single patch also because the test result improved because of this change.
This behavior change is covered by existing regression tests.
- accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(WebCore::getAttributeSetForAccessibilityObject):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): No longer supports TAAUTO since it's identical to TASTART.
(WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto. Parse -webkit-auto as start.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Replace TAAUTO by TASTART.
- editing/EditingStyle.cpp:
(WebCore):
(WebCore::textAlignResolvingStartAndEnd): Coerce start and end into left and right based on the directionality
for editing. Otherwise, we end up adding lots of text-align: left due to li's UA style rule having match-parent
as the text alignment and its descendent inherits this style. We need to handle it better in the future
since start and left or end and right are semantically different.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::getPropertiesNotIn):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::textAlignmentForLine): Justified text is aligned at start by default.
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::startAlignedOffsetForLine):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
- rendering/RenderListBox.cpp:
(WebCore::itemOffsetForAlignment):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::textAlignmentForLine):
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
LayoutTests: The default value of text-align should be start instead of -webkit-auto
https://bugs.webkit.org/show_bug.cgi?id=79914
Reviewed by Tony Chang.
Rebaselined tests. For query-text-alignment.html, we now match start and end
with justifyLeft and justifyRight, which appears to be consistent with Firefox for time being.
- editing/execCommand/query-text-alignment-expected.txt:
- editing/execCommand/script-tests/query-text-alignment.js:
(queryTextAlignment):
(selectFirstPosition):
(selectMiddleOfHelloWorld):
(runRangeTests):
- editing/pasteboard/paste-4039777-fix-expected.txt:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/list-item-text-align.html:
- fast/css/text-align-initial-expected.html: Renamed from fast/css/text-align-webkit-auto-expected.html.
- fast/css/text-align-initial.html: Ditto.
- fast/events/ondrop-text-html-expected.txt:
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/fast/lists/001-expected.png:
- platform/chromium-mac-snowleopard/fast/lists/001-vertical-expected.png:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/lists/001-expected.txt:
- platform/mac/fast/lists/001-vertical-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 2:45 PM Changeset in webkit [120494] by
-
- 5 edits1 copy1 move1 add in trunk
[File API] FileReader should work in sandbox iframe
https://bugs.webkit.org/show_bug.cgi?id=89242
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/files/file-reader-sandbox-iframe.html
- fileapi/ThreadableBlobRegistry.cpp: Should remove from map for all threads.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canRequest): Check and use cached origin for blob URL first.
LayoutTests:
- fast/files/file-reader-file-url.html:
- fast/files/file-reader-sandbox-iframe-expected.txt: Added.
- fast/files/file-reader-sandbox-iframe.html: Added.
- fast/files/resources/file-reader-real.html: Renamed from LayoutTests/fast/files/resources/file-reader-file-url-iframe.html.
- 2:34 PM Changeset in webkit [120493] by
-
- 8 edits in trunk/LayoutTests
http/tests/fileapi/create-blob-url-from-data-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=89149
Reviewed by Adam Barth.
Convert the test to check if blob URL can be created in a data iframe.
- http/tests/fileapi/create-blob-url-from-data-url-expected.txt:
- http/tests/fileapi/create-blob-url-from-data-url.html:
- platform/chromium/TestExpectations:
- platform/efl/Skipped:
- platform/gtk/TestExpectations:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 2:21 PM Changeset in webkit [120492] by
-
- 43 edits2 adds in trunk
Inherit style changes in MathML anonymous renderers
https://bugs.webkit.org/show_bug.cgi?id=88476
Reviewed by Julien Chaffraix.
Source/WebCore:
A RenderObject that is not the main renderer() for a DOM node is called "anonymous".
Standard WebCore practice is to mark such a renderer as isAnonymous(). For example,
RenderBlock::styleDidChange calls propagateStyleToAnonymousChildren to flow style
changes to such children, by re-initializing their styles and then inheriting from
this->style(). A derived class' styleDidChange() can then set non-default style
properties as needed.
This patch implements this standard practice for RenderMathMLBlock classes, except
RenderMathMLOperator which currently uses a RenderLayer, which reportedly means it
should not be isAnonymous(). We also follow common practice and change
isAnonymousBlock() to return false for RenderMathMLBlock classes, since
isAnonymousBlock() is really used by RenderBlock to detect its own anonymous blocks for
wrapping inline children, which RenderBlock then combines or deletes assuming this.
Test: mathml/presentation/style-changed.html, also added to mathml/presentation/over.xhtml
- rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
(WebCore::RenderMathMLBlock::renderName):
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::styleDidChange):
- rendering/mathml/RenderMathMLFenced.h:
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::RenderMathMLFraction):
(WebCore::RenderMathMLFraction::fixChildStyle):
(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::styleDidChange):
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::styleDidChange):
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLSquareRoot.h:
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::fixScriptsStyle):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::styleDidChange):
- rendering/mathml/RenderMathMLSubSup.h:
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::addChild):
(WebCore::RenderMathMLUnderOver::styleDidChange):
- rendering/mathml/RenderMathMLUnderOver.h:
LayoutTests:
- mathml/presentation/over.xhtml:
- mathml/presentation/style-changed-expected.html: Added.
- mathml/presentation/style-changed.html: Added.
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.txt:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/style-expected.txt:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.txt:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- platform/mac/mathml/presentation/under-expected.png:
- platform/mac/mathml/presentation/under-expected.txt:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
- platform/mac/mathml/xHeight-expected.txt:
- 2:13 PM Changeset in webkit [120491] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectations change.
- platform/chromium/TestExpectations:
- 1:48 PM Changeset in webkit [120490] by
-
- 4 edits in trunk/Source/WebKit/chromium
AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones.
https://bugs.webkit.org/show_bug.cgi?id=89185
Reviewed by Adam Barth.
This change adds an option to turn off whitelist filtering of response headers for CORS loads,
and modifies AssociatedURLLoader check for that before filtering.
- public/WebURLLoaderOptions.h:
(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
(WebURLLoaderOptions):
- src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
- tests/AssociatedURLLoaderTest.cpp:
(WebKit):
(WebKit::TEST_F):
- 1:36 PM Changeset in webkit [120489] by
-
- 5247 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in sputnik's conformance tests
https://bugs.webkit.org/show_bug.cgi?id=89184
Reviewed by Tony Chang.
- sputnik/Conformance/:
- 1:25 PM Changeset in webkit [120488] by
-
- 7 edits in trunk/Tools
webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
https://bugs.webkit.org/show_bug.cgi?id=89135
Re-land change in r120370 with fix in
PortFactory.get_from_builder_name() that changes BuilderOptions
to an actual optparse.Values object.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
(Port.get_option):
(Port.set_option_default):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
- Scripts/webkitpy/layout_tests/port/factory.py:
(_builder_options):
(PortFactory.get_from_builder_name):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_get_from_builder_name):
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
- Scripts/webkitpy/tool/mocktool.py:
(MockOptions.ensure_value):
- 1:00 PM Changeset in webkit [120487] by
-
- 13 edits in trunk/LayoutTests
Unreviewed. Rebaselines for r120477.
- platform/chromium-linux/fast/forms/formmove3-expected.txt:
- platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
- platform/chromium-win/fast/dynamic/011-expected.txt:
- platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/chromium-win/fast/invalid/001-expected.txt:
- platform/chromium-win/fast/invalid/003-expected.txt:
- platform/chromium-win/fast/invalid/004-expected.txt:
- platform/chromium-win/fast/invalid/007-expected.txt:
- platform/chromium-win/fast/invalid/019-expected.txt:
- platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
- platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
- 12:53 PM Changeset in webkit [120486] by
-
- 16 edits in trunk
Add new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods.
https://bugs.webkit.org/show_bug.cgi?id=88891
Reviewed by Dimitri Glazkov.
Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
Entering and exiting mouse lock is provided in the new webkitRequestPointerLock and
webkitExitPointerLock methods.
Source/WebCore:
Existing pointer-lock tests updated to use the new methods.
- dom/Document.cpp:
(WebCore::Document::webkitExitPointerLock):
(WebCore):
- dom/Document.h:
(Document):
- dom/Document.idl:
- dom/Element.cpp:
(WebCore):
(WebCore::Element::webkitRequestPointerLock):
- dom/Element.h:
- dom/Element.idl:
LayoutTests:
Existing tests updated to use the new methods. Also, several updated to
support manual testing.
- pointer-lock/lock-already-locked-expected.txt:
- pointer-lock/lock-already-locked.html:
- pointer-lock/mouse-event-delivery-expected.txt:
- pointer-lock/mouse-event-delivery.html:
- pointer-lock/pointer-lock-api-expected.txt:
- pointer-lock/pointer-lock-api.html:
- pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
- pointer-lock/pointerlockchange-pointerlockerror-events.html:
- 12:51 PM Changeset in webkit [120485] by
-
- 9 edits in trunk
Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port
Reviewed by Adam Barth.
Covered by existing layout tests which will be rebaselined.
- WebCore.gyp/WebCore.gyp: Add qcms to the build.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
- platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.
Patch by Tony Payne <tpayne@chromium.org> on 2012-06-15
Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974
Patch by Tony Payne <tpayne@chromium.org> on 2012-06-15
- wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB
to each Chromium platform, excluding Android.
Reviewed by Adam Barth.
- 12:41 PM Changeset in webkit [120484] by
-
- 2 edits in trunk/Tools
Add bbudge@chromium.org to committers.py
Unreviewed.
Patch by Bill Budge <bbudge@chromium.org> on 2012-06-15
- Scripts/webkitpy/common/config/committers.py:
- 12:39 PM Changeset in webkit [120483] by
-
- 1 copy in tags/Safari-536.19
New Tag.
- 11:53 AM Changeset in webkit [120482] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=89227
PR #146642
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Make use of the Settings::supportsMouseDevice setting in order to
prevent mouse move event to fire as a response to a scroll action.
We might still want to dynamically toggle this setting ON, in case for
example of a mouse wheel driven scroll action, but we can revisit it
when it becomes a fully supported/primary use case.
Internally reviewed by Eli Fidler.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::isDeviceSupportsMouseEnabled):
(BlackBerry::WebKit::WebSettings::setDeviceSupportsMouseEnabled):
- Api/WebSettings.h:
- 11:43 AM Changeset in webkit [120481] by
-
- 30 edits8 adds in trunk/LayoutTests
Unreviewed. Rebaselines for r120477.
- fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-mac-leopard/fast/forms/formmove3-expected.txt: Added.
- platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
- platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
- platform/chromium-mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
- platform/chromium-mac/fast/forms/formmove3-expected.txt:
- platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/efl/TestExpectations:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/fast/dynamic/011-expected.txt:
- platform/gtk/fast/forms/formmove3-expected.txt:
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/gtk/fast/invalid/001-expected.txt:
- platform/gtk/fast/invalid/003-expected.txt:
- platform/gtk/fast/invalid/004-expected.txt:
- platform/gtk/fast/invalid/007-expected.txt:
- platform/gtk/fast/invalid/019-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
- platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
- platform/qt/fast/dynamic/011-expected.txt:
- platform/qt/fast/forms/formmove3-expected.txt:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/qt/fast/invalid/001-expected.txt:
- platform/qt/fast/invalid/003-expected.txt:
- platform/qt/fast/invalid/004-expected.txt:
- platform/qt/fast/invalid/007-expected.txt:
- platform/qt/fast/invalid/019-expected.txt:
- platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
- platform/qt/tables/mozilla/bugs/bug647-expected.txt:
- platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
- 11:39 AM Changeset in webkit [120480] by
-
- 6 edits in trunk/LayoutTests
Rebaseline some tests after r120411.
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/range/input-appearance-range-expected.txt:
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- 11:37 AM Changeset in webkit [120479] by
-
- 53 edits in trunk/LayoutTests
Unreviewed chromium rebaseline for r120467.
Patch by Florin Malita <fmalita@chromium.org> on 2012-06-15
- platform/chromium-linux-x86/svg/filters/feLighting-crash-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/feLighting-crash-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feLighting-crash-expected.png:
- platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png:
- platform/chromium-win-xp/svg/filters/feLighting-crash-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feLighting-crash-expected.png:
- platform/chromium/TestExpectations:
- 10:59 AM Changeset in webkit [120478] by
-
- 2 edits in trunk/Source/WebCore
Remove volume thumb for videos without audio track.
https://bugs.webkit.org/show_bug.cgi?id=89093
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.
No new tests, since this was already tested in media/video-no-audio.html.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaMuteButton):
Change mute button when there is no audio or no source file.
(WebCore::paintMediaVolumeSlider):
Set volume slider to 0 when there is no audio or no source file.
(WebCore::paintMediaVolumeSliderThumb):
Don't paint the volume slider thumb when there is no audio or no source file.
- 10:57 AM Changeset in webkit [120477] by
-
- 16 edits2 adds in trunk
Cleanup empty anonymous block continuation.
https://bugs.webkit.org/show_bug.cgi?id=74976
Reviewed by Julien Chaffraix.
Source/WebCore:
Fix rendering on http://docs.google.com/demo.
Test: fast/inline/inline-empty-block-continuation-remove.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): If we are removing our last child,
and are an anonymous block which is part of a continuation chain, then
we need to first fix our continuation chain by setting our previous
continuation renderer to point to the next continuation renderer. Then,
we reset our continuation pointer and destroy ourselves. Since we no
longer are part of continuation chain, we will be removed and previous
and next anonymous block will be merged automatically.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::previousInPreOrder): add an argument to previousInOrder
- stayWithin.
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- fast/inline/inline-empty-block-continuation-remove-expected.html: Added.
- fast/inline/inline-empty-block-continuation-remove.html: Added.
and a bunch of rebaselines in existing tests.
- 10:47 AM Changeset in webkit [120476] by
-
- 2 edits in trunk/LayoutTests
Clean up the flaky tests section in Gtk's TestExpectations file. Remove
flakiness expectations for tests that have been consistently passing and
move expectations for tests that have been consistently failing under
the failing tests section, changing the expectations to represent a constant
expected failure for that test.
Rubber-stamped by Philippe Normand.
- platform/gtk/TestExpectations:
- 10:16 AM Changeset in webkit [120475] by
-
- 6 edits in trunk
Web Inspector: Move FileSystem frame management from frontend to backend
https://bugs.webkit.org/show_bug.cgi?id=89190
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: http/tests/inspector/filesystem/read-directory.html
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore::InspectorFileSystemAgent::readDirectory):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::scriptExecutionContextForOrigin):
(WebCore):
- inspector/InspectorFileSystemAgent.h:
(WebCore):
(InspectorFileSystemAgent):
LayoutTests:
- http/tests/inspector/filesystem/read-directory.html:
- 10:13 AM Changeset in webkit [120474] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix after r120469.
- css/CSSPropertySourceData.h:
(WebCore):
- 10:10 AM Changeset in webkit [120473] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen
https://bugs.webkit.org/show_bug.cgi?id=89211
Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>
PR: 135215
Make simpler rules for zoom to fit scale:
- Zoom to fit horizontally first without clamping the contents width.
- Zoom to fit vertically instead without clamping the contents height if the horizontal zoom to fit can cause a grey area below the web page. Get rid of the virtual viewport guard as there may be cases that zooming can cause a grey area without a virtual viewport.
- Clamp the scale by the minimum zoom to fit scale 0.25 and apply this rule to image documents as well. This minimum scale can be changed if there is a better vaule in the future.
In this way, we can get rid of the issue that many web pages don't fit
the screen.
Reviewed internally by Arvid Nilsson.
- Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):
- 9:57 AM Changeset in webkit [120472] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add FileSystemRequestManager and FileSystemDispatcher
https://bugs.webkit.org/show_bug.cgi?id=89191
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototoype._requestId):
(WebInspector.FileSystemRequestManager.prototoype.readDirectory):
(WebInspector.FileSystemRequestManager.prototoype._didReadDirectory):
(WebInspector.FileSystemDispatcher):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.didReadDirectory):
- 9:50 AM Changeset in webkit [120471] by
-
- 10 edits in trunk
Web Inspector: extension's Resource.getContent always returns original revision.
https://bugs.webkit.org/show_bug.cgi?id=89219
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Fetching proper content from the UISourceCode now.
- inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
- inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping.prototype._debuggerReset):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
- inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isHidden):
(WebInspector.Resource.prototype.uiSourceCode):
(WebInspector.Resource.prototype.setUISourceCode):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
LayoutTests:
- inspector/extensions/extensions-resources-expected.txt:
- inspector/extensions/extensions-resources.html:
- 9:48 AM Changeset in webkit [120470] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
https://bugs.webkit.org/show_bug.cgi?id=89225
Reviewed by Pavel Feldman.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):
- 9:36 AM Changeset in webkit [120469] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: CSSParser::parseSheet() should provide ready-to-use source data
https://bugs.webkit.org/show_bug.cgi?id=88646
Reviewed by Antti Koivisto.
This change moves the post-processing step from InspectorStyleSheet into CSSParser, so that
CSSParser::parseSheet() will return a ready-to-use list with style rule source code data.
Also, universal data structures are introduced, which allow for the full rule source data tree building.
No new tests, as this is a refactoring.
- css/CSSParser.cpp: Use universal data structures, which can be used for building the full rule tree.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseSheet): Return ready-to-use source code data entries rather than an intermediate structure.
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::fixUnparsedPropertyRanges): Moved in from InspectorStyleSheet.
(WebCore::CSSParser::markSelectorListStart):
(WebCore::CSSParser::markSelectorListEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyEnd):
- css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::resetPropertyRange): Renamed.
(WebCore::CSSParser::isExtractingSourceData): A convenience check.
- css/CSSPropertySourceData.h: Introduce the RuleSourceDataList typedef.
(WebCore):
- inspector/InspectorStyleSheet.cpp: Make use of RuleSourceDataList and follow the CSSParser::parse*() API changes.
(ParsedStyleSheet::sourceData):
(ParsedStyleSheet):
(ParsedStyleSheet::setSourceData):
(WebCore::InspectorStyleSheet::ensureSourceData): Remove source data postprocessing, follow the new parseSheet() API.
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId): Drive-by: uninitialized field fix.
(WebCore::InspectorStyleProperty::InspectorStyleProperty): Ditto.
(InspectorStyleSheet):
- 9:03 AM Changeset in webkit [120468] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Long frame urls make all/errors/warnings/logs buttons inaccessible.
https://bugs.webkit.org/show_bug.cgi?id=88907
Reviewed by Vsevolod Vlasov.
- inspector/front-end/inspector.css:
(#console-context):
- 8:56 AM Changeset in webkit [120467] by
-
- 17 edits2 adds in trunk
Specular light filters produce dark results
https://bugs.webkit.org/show_bug.cgi?id=89116
Reviewed by Dirk Schulze.
Source/WebCore:
Tests: svg/filters/feSpecularLight-premultiplied-expected.svg
svg/filters/feSpecularLight-premultiplied.svg
Per spec (http://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement),
light filters should operate on pre-multiplied RGBA. Currently, the results
are stored in the unmultiplied buffer but the alpha channel is calculated
for premultiplied values (which causes a darkening of the result upon the
subsequent unmultiplied->premultiplied conversion). This patch updates
FELighting to generate premultiplied results.
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplySoftware):
LayoutTests:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-linux/svg/filters/feLighting-crash-expected.png:
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- svg/filters/feSpecularLight-premultiplied-expected.svg: Added.
- svg/filters/feSpecularLight-premultiplied.svg: Added.
- 8:56 AM Changeset in webkit [120466] by
-
- 2 edits in trunk/Tools
Unreviewed style fix after r120351.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):
- 8:51 AM Changeset in webkit [120465] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: incorrect filtering of async timeline events
https://bugs.webkit.org/show_bug.cgi?id=89214
Reviewed by Vsevolod Vlasov.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.accept):
- 8:37 AM Changeset in webkit [120464] by
-
- 5 edits2 adds in trunk
SVG Composite of Offset filters incorrectly clips
https://bugs.webkit.org/show_bug.cgi?id=77660
Reviewed by Dirk Schulze.
Source/WebCore:
Prior to this patch, when a group of filtered objects was used as input to another filter,
the filter only operated on the stroke boundary of the group, and hence excluded the results
of filtering elements within the group, or extraneously included regions clipped from the
elements in the group.
This patch modifies the strokeBoundingBox of SVG container elements to
be the union of the repaint rects for the children. This modifes the
results returned for sizing filters and for absoluteRects, which will cause
inline layout around the group to factor in the resources applied to
the group's children.
The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
as though the paint operations had been applied to an intermediate canvas initialized to
transparent black, of a size determined by the rules given in Filter Effects then filtered
by the processes defined in Filter Effects." In this case the "paint operations" is implied
to include the result of applying "paint" but no resources to the group, which in turn would
have resources applied to the children of the group. This makes the most sense, as the current,
incorrect behavior makes it extremely diffucult to understand the actions of filters on
groups of filtered content.
Tests: svg/filters/container-with-filters-expected.svg
svg/filters/container-with-filters.svg
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::updateCachedBoundaries):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::updateCachedBoundaries):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
LayoutTests:
- svg/filters/container-with-filters-expected.svg: Added.
- svg/filters/container-with-filters.svg: Added.
- 8:29 AM Changeset in webkit [120463] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
https://bugs.webkit.org/show_bug.cgi?id=89210
Patch by Yong Li <yoli@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.
Remove BackingStoreClient::scrollsHorizontally()/scrollsVeritically(), because
calling them is neither nessary nor safe.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
(BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
- WebKitSupport/BackingStoreClient.cpp:
- WebKitSupport/BackingStoreClient.h:
(BackingStoreClient):
- 8:19 AM Changeset in webkit [120462] by
-
- 2 edits in trunk/Source/WebCore
Sort ENABLE(INSPECTOR) section of WebCore.exp.in
- WebCore.exp.in: Sort ENABLE(INSPECTOR) symbols.
- 8:19 AM Changeset in webkit [120461] by
-
- 2 edits in trunk/Source/WebCore
Remove duplicate symbol from WebCore.exp.in
- WebCore.exp.in: Remove duplicate symbol for:
WebCore::Range::textQuads(WTF::Vector<WebCore::FloatQuad, 0ul>&, bool, WebCore::Range::RangeInFixedPosition*) const
- 8:18 AM Changeset in webkit [120460] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed debug build fix for r120457
Patch by Florin Malita <fmalita@chromium.org> on 2012-06-15
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toYUVVideoDrawQuad):
- 8:15 AM Changeset in webkit [120459] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: remove redundant Mac-specific style rule from inspector front-end.
- inspector/front-end/helpScreen.css:
- 8:11 AM Changeset in webkit [120458] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix help close button appearance on Mac
https://bugs.webkit.org/show_bug.cgi?id=89208
Reviewed by Vsevolod Vlasov.
- inspector/front-end/helpScreen.css:
(.help-close-button):
(body.platform-mac .help-close-button):
(body.platform-mac .help-window-main .tabbed-pane-header-contents):
- 7:34 AM Changeset in webkit [120457] by
-
- 7 edits2 moves in trunk/Source/WebCore
[chromium] Create a CCYUVVideoDrawQuad and remove the now-unused generic CCVideoDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=88828
Reviewed by Adrienne Walker.
The CCVideoDrawQuad is now only used for YUV video, so we remove the
class and replace it with CCYUVVideoDrawQuad. This class holds what is
needed to draw a YUV video frame.
No new tests, no change in behaviour.
- WebCore.gypi:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toYUVVideoDrawQuad):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.cpp.
(WebCore):
(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
- platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.h.
(WebCore):
(CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::yPlane):
(WebCore::CCYUVVideoDrawQuad::uPlane):
(WebCore::CCYUVVideoDrawQuad::vPlane):
- 7:28 AM Changeset in webkit [120456] by
-
- 3 edits2 adds in trunk
Web Inspector: CRASH: getProfile is crashing for unknown profiles.
https://bugs.webkit.org/show_bug.cgi?id=89202
Source/WebCore:
agents' functions have to set a value to errorString if it can't assign values to the mandatory out arguments.
Reviewed by Pavel Feldman.
Test: inspector/profiler/heap-snapshot-get-profile-crash.html
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfile):
LayoutTests:
Reviewed by Pavel Feldman.
- inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Added.
- inspector/profiler/heap-snapshot-get-profile-crash.html: Added.
- 7:26 AM Changeset in webkit [120455] by
-
- 2 edits in trunk/Tools
master.cfg cleanup, remove unnecessary workaround
https://bugs.webkit.org/show_bug.cgi?id=88994
Reviewed by Lucas Forschler.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- 7:22 AM Changeset in webkit [120454] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581
Reviewed by Adam Barth.
Make sure we only optimize the suffixes we rebaselined during
rebaseline-expectations, and not all suffixes for a test.
While optimizing is somewhere between harmless and good, it's also confusing :)
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- 7:17 AM Changeset in webkit [120453] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] media volume slider in wrong position (master_38 regression)
https://bugs.webkit.org/show_bug.cgi?id=89165
Patch by Max Feil <mfeil@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.
Due to upstream simplification of the volume slider (webkit.org
bug 82150) it now appears in the wrong location below the
media controls. The programmatic controls sizing we do in
RenderThemeBlackBerry.cpp relies on absolute positioning of the
volume slider container, so the best way to fix this is to set
the bottom offset.
No new tests since this is a regression fix. BlackBerry media
controls are manually tested.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
- 7:14 AM Changeset in webkit [120452] by
-
- 2 edits in trunk/Tools
Update builder.html template for newer buildmaster
https://bugs.webkit.org/show_bug.cgi?id=89207
Rebasing builder.html template from v0.8.3 to v0.8.6p1.
Reviewed by Zoltan Herczeg.
- BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
- 7:10 AM Changeset in webkit [120451] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067
- platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Added.
- 7:07 AM Changeset in webkit [120450] by
-
- 4 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in layout test resources
https://bugs.webkit.org/show_bug.cgi?id=89182
Reviewed by Kent Tamura.
- resources/dump-as-markup.js:
(Markup.waitUntilDone):
(Markup.notifyDone):
- resources/magnitude-perf.js:
(Magnitude._run):
(Magnitude._runIteration):
(Magnitude):
- resources/testharnessreport.js:
- 6:58 AM Changeset in webkit [120449] by
-
- 2 edits in trunk/Source/WebCore
Not reviewed: remove garbage line from inspector view in docked-to-right mode.
- inspector/front-end/inspectorCommon.css:
(body.docked.dock-to-right.docked):
(body.docked.dock-to-right.inactive):
- 6:54 AM Changeset in webkit [120448] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, adding TEXT expectation for
editing/spelling/grammar-edit-word.html after r120423.
- platform/gtk/TestExpectations:
- 6:36 AM Changeset in webkit [120447] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(BLOB) platforms after r120433.
https://bugs.webkit.org/show_bug.cgi?id=78648
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- 6:27 AM Changeset in webkit [120446] by
-
- 4 edits2 moves2 adds in trunk/LayoutTests
[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067
- fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt.
- platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt.
- platform/chromium-linux/fast/forms/range/slider-padding-expected.txt: Added.
- platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
- platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
- platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
- platform/chromium/TestExpectations:
- 6:06 AM Changeset in webkit [120445] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening. Skip a failing test. After r120423.
https://bugs.webkit.org/show_bug.cgi?id=89199
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-06-15
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 5:45 AM Changeset in webkit [120444] by
-
- 16 edits in trunk/Source
[chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-06-15
Reviewed by James Robinson.
Source/WebCore:
This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.
If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.
Layer hit testing code by Shawn Singh.
Added new unit tests to verify layer scrolling behavior:
CCLayerTreeHostCommonTest.verifySubtreeSearch
CCLayerTreeHostImplTest.clearRootRenderSurfaceAndScroll
CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhileAnimatingPageScale
CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhilePinchZooming
CCLayerTreeHostImplTest.replaceTreeWhileScrolling
CCLayerTreeHostImplTest.scrollBeforeRedraw
CCLayerTreeHostImplTest.scrollBlockedByContentLayer
CCLayerTreeHostImplTest.scrollChildAndChangePageScaleOnMainThread
CCLayerTreeHostImplTest.scrollChildBeyondLimit
CCLayerTreeHostImplTest.scrollChildCallsCommitAndRedraw
CCLayerTreeHostImplTest.scrollEventBubbling
CCLayerTreeHostImplTest.scrollMissesBackfacingChild
CCLayerTreeHostImplTest.scrollMissesChild
CCLayerTreeHostImplTest.scrollNonCompositedRoot
CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnImplThread
CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnMainThread
CCLayerTreeHostImplTest.scrollRootIgnored
CCLayerTreeHostImplTest.scrollWithoutRootLayer
CCLayerTreeHostTestScrollChildLayer
WebCompositorInputHandlerImplTest.gestureScrollOnMainThread
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::scrollBy):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromiumScrollDelegate):
(WebCore::LayerChromiumScrollDelegate::~LayerChromiumScrollDelegate):
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setLayerScrollDelegate):
- platform/graphics/chromium/cc/CCInputHandler.h:
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::tryScroll):
(WebCore):
(WebCore::sortLayers):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::findFirstScrollableLayer):
(WebCore):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
(WebCore):
(WebCore::CCLayerTreeHostCommon::findLayerInSubtree):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::findRootScrollLayer):
(WebCore):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::detachLayerTree):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::clearCurrentlyScrollingLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):
Source/WebKit/chromium:
New unit tests to verify layer scrolling behavior and the associated
utility functions.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockContentLayerDelegate::paintContents):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):
- tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
- 5:31 AM Changeset in webkit [120443] by
-
- 2 edits in trunk/Tools
Add ForceScheduler to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=88982
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- 5:16 AM Changeset in webkit [120442] by
-
- 7 edits2 adds in trunk
[EFL][WK2] Add title support to Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89095
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add a method to get the title of the main frame in
an Ewk_View. A "title,changed" signal is now emitted
on the view to notify clients that the main frame
title was changed.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_title_get):
(ewk_view_title_changed):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_loader_client.cpp: Added.
(didReceiveTitleForFrame):
(ewk_view_loader_client_attach):
- UIProcess/API/efl/ewk_view_loader_client_private.h: Added.
- UIProcess/API/efl/ewk_view_private.h:
Tools:
Update the MiniBrowser so it listens for the "title,change"
signal on the view and keeps the browser window title
up-to-date.
- MiniBrowser/efl/main.c:
(on_title_changed):
(browserCreate):
- 4:48 AM Changeset in webkit [120441] by
-
- 18 edits in trunk/LayoutTests
[EFL] Gardening after r120411
https://bugs.webkit.org/show_bug.cgi?id=89194
Unreviewed EFL gardening, updating baselines after r120411.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-15
- platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.png:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.png:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/range/input-appearance-range-expected.png:
- platform/efl/fast/forms/range/input-appearance-range-expected.txt:
- platform/efl/fast/forms/range/range-thumb-height-percentage-expected.png:
- platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt:
- platform/efl/fast/forms/range/slider-padding-expected.png:
- platform/efl/fast/forms/range/slider-padding-expected.txt:
- platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
- platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt:
- platform/efl/fast/multicol/client-rects-expected.png:
- platform/efl/fast/multicol/client-rects-expected.txt:
- platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:
- 4:44 AM Changeset in webkit [120440] by
-
- 4 edits5 copies4 adds in trunk/LayoutTests
Unreviewed expectation rebaselining.
- platform/chromium-linux-x86/fast/multicol/client-rects-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/multicol/client-rects-expected.png.
- platform/chromium-linux-x86/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
- platform/chromium-linux/fast/multicol/client-rects-expected.png:
- platform/chromium-linux/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
- platform/chromium-mac-snowleopard/fast/multicol/client-rects-expected.txt: Added.
- platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Added.
- platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
- platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Added.
- platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
- platform/chromium-win/fast/multicol/client-rects-expected.png:
- platform/chromium-win/fast/multicol/client-rects-expected.txt:
- 4:41 AM Changeset in webkit [120439] by
-
- 5 edits2 adds in trunk/LayoutTests
[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067
- platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
- platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
- platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
- platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt: Added.
- platform/chromium/TestExpectations:
- 4:22 AM Changeset in webkit [120438] by
-
- 11 edits2 adds in trunk/LayoutTests
[Qt] Gardening after r120411. Updated baselines of 7 tests because of a color property change.
Patch by János Badics <János Badics> on 2012-06-15
Reviewed by Csaba Osztrogonác.
- platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.png:
- platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/qt/fast/forms/box-shadow-override-expected.png:
- platform/qt/fast/forms/box-shadow-override-expected.txt:
- platform/qt/fast/forms/range/input-appearance-range-expected.txt:
- platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png: Added.
- platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
- platform/qt/fast/forms/range/slider-padding-expected.png:
- platform/qt/fast/forms/range/slider-padding-expected.txt:
- platform/qt/fast/multicol/client-rects-expected.png: Added.
- platform/qt/fast/multicol/client-rects-expected.txt:
- platform/qt/fast/repaint/slider-thumb-drag-release-expected.png:
- platform/qt/fast/repaint/slider-thumb-drag-release-expected.txt:
- 3:58 AM Changeset in webkit [120437] by
-
- 5 edits in trunk
[WK2][EFL] Implement navigation back/forward in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89173
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add API for Ewk_View to ask the main frame to navigate backwards
or forwards in history. Also add API to query if such navigation
is possible.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_back):
(ewk_view_forward):
(ewk_view_back_possible):
(ewk_view_forward_possible):
- UIProcess/API/efl/ewk_view.h:
Tools:
Implement navigation back / forward in MiniBrowser. Use
'F1' to navigate back and 'F2' to navigate forward.
- MiniBrowser/efl/main.c:
(on_key_down):
- 3:32 AM Changeset in webkit [120436] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89067
- platform/chromium/TestExpectations:
Mark some tests for type=range FAIL until all bots have the new results.
- 3:03 AM Changeset in webkit [120435] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Fix a syntax error of TestExpectations.
- platform/chromium/TestExpectations:
- 2:58 AM Changeset in webkit [120434] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Unreviewed, rolling out r120404.
http://trac.webkit.org/changeset/120404
https://bugs.webkit.org/show_bug.cgi?id=89193
This patch breaks [BlackBerry]'s text selection handles moving
in editable elements. (Requested by Sean1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
- 2:57 AM Changeset in webkit [120433] by
-
- 10 edits3 adds in trunk
FileReader is dysfunctional in documents with "null" origin string
https://bugs.webkit.org/show_bug.cgi?id=78648
Reviewed by Adam Barth.
Source/WebCore:
The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.
Test: fast/files/file-reader-file-url.html
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.
- fileapi/BlobURL.h:
(BlobURL):
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::getCachedOrigin): Retrieve the origin associated with the blob URL.
- fileapi/ThreadableBlobRegistry.h:
(WebCore):
(ThreadableBlobRegistry):
- html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
- page/SecurityOrigin.cpp:
(WebCore::getCachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call getCachedOrigin to get the cached origin first.
LayoutTests:
- fast/files/file-reader-file-url-expected.txt: Added.
- fast/files/file-reader-file-url.html: Added.
- fast/files/resources/file-reader-file-url-iframe.html: Added.
- 2:53 AM Changeset in webkit [120432] by
-
- 20 edits in trunk/Source/WebCore
[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980
Reviewed by Kent Tamura.
This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Added new file RenderSearchField.cpp
- GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
- Target.pri: ditto
- WebCore.gypi: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.
- html/InputType.cpp:
(WebCore::InputType::addSearchResult): Added.
- html/InputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
- html/SearchInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.
- rendering/RenderSearchField.h:
(WebCore::toRenderSearchField): Added.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.
- rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
- 2:41 AM Changeset in webkit [120431] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89067
- platform/chromium-mac/fast/multicol/client-rects-expected.txt:
- 2:33 AM Changeset in webkit [120430] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test.
https://bugs.webkit.org/show_bug.cgi?id=89066
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.
- http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.clearFileSystem):
(dispatchCallback):
(createDirectory.gotFileSystem):
(createDirectory):
(createFile.gotFileSystem):
(clearFileSystem.gotRoot):
(clearFileSystem.gotRoot.removeAll):
(clearFileSystem.onError):
- http/tests/inspector/filesystem/read-directory.html:
- 2:30 AM Changeset in webkit [120429] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89192
- platform/chromium/TestExpectations:
Failulre of platform/chromium/accessibility/add-to-menu-list-crashes.html is expected.
- 2:24 AM Changeset in webkit [120428] by
-
- 8 edits in trunk
[EFL] EFL's LayoutTestController does not support titleTextDirection
https://bugs.webkit.org/show_bug.cgi?id=86475
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Hajime Morita.
Source/WebKit/efl:
Emit the "title,changed" signal even if the title direction has
changed but not its text.
- ewk/ewk_frame.cpp:
(ewk_frame_title_set):
Tools:
Add titleTextDirection getter and setter to LayoutTestController and
expose its value to JavaScript.
Update the titleTextDirection value from EFL's "title,changed"
callback in DumpRenderTree.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(getTitleTextDirectionCallback):
(LayoutTestController::staticValues):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::titleTextDirection):
(LayoutTestController::setTitleTextDirection):
(LayoutTestController):
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameTitleChanged):
LayoutTests:
Unskip title-directionality tests now that EFL's LayoutTestController
supports titleTextDirection.
- platform/efl/TestExpectations:
- 2:20 AM Changeset in webkit [120427] by
-
- 5 edits in trunk
[EFL][WK2] Implement reload / stop in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89168
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Add API on the Ewk_View to reload the main frame
and to stop the current load.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_reload):
(ewk_view_stop):
- UIProcess/API/efl/ewk_view.h:
Tools:
Implement view reload / stop loading in MiniBrowser.
Use 'F5' for reload and 'F6' for stopping the load.
- MiniBrowser/efl/main.c:
(on_key_down):
(browserCreate):
- 2:07 AM Changeset in webkit [120426] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium windows rebaseline.
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- 1:55 AM Changeset in webkit [120425] by
-
- 4 edits in trunk/LayoutTests
A followup for r120413.
https://bugs.webkit.org/show_bug.cgi?id=89187
We need to update fast/dom/htmlcollection-non-html.html for
HTMLSelectElement::selectedOptions removal.
- fast/dom/htmlcollection-non-html-expected.txt:
- fast/dom/htmlcollection-non-html.html:
- platform/gtk/TestExpectations:
- 1:45 AM Changeset in webkit [120424] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, adding a CRASH PASS expectation for
storage/websql/quota-tracking.html which crashes intermittently
on release builds.
- platform/gtk/TestExpectations:
- 1:41 AM Changeset in webkit [120423] by
-
- 8 edits2 adds in trunk
Allow platforms to choose whether to remove markers on editing
https://bugs.webkit.org/show_bug.cgi?id=88838
Reviewed by Hajime Morita.
Source/WebCore:
This change allows platforms to choose whether to remove markers on a word being
edited. WebKit does not remove markers when we move a selection to a markered
word on platforms that shouldEraseMarkersAfterChangeSelection returns false.
On such platforms, WebKit expects to set WTF_USE_MARKER_REMOVAL_UPON_EDITING to
1 so Editor::updateMarkersForWordsAffectedByEditing can remove markers. This
change also checks the return value of shouldEraseMarkersAfterChangeSelection so
platform can choose it. This change also adds grammar markers so it can also
remove grammar markers.
Test: editing/spelling/grammar-edit-word.html
- editing/Editor.cpp:
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
Source/WebKit/chromium:
This change implements EditorClientImpl::checkGrammarOfString so
DumpRenderTree can run grammar tests.
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::isGrammarCheckingEnabled): Return true also when unified text-checking is enabled.
(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection): ditto.
(WebKit::EditorClientImpl::checkGrammarOfString): Implement this function with our unified text-checker.
Tools:
This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
run grammar tests.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
LayoutTests:
This change adds a test that verifies WebKit removes a grammar marker from a
grammatically-incorrect word when editing the word.
- editing/spelling/grammar-edit-word-expected.txt: Added.
- editing/spelling/grammar-edit-word.html: Added.
- 1:36 AM Changeset in webkit [120422] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, adding test expectation for
fast/dom/htmlcollection-non-html.html after r120413.
- platform/gtk/TestExpectations:
- 1:15 AM Changeset in webkit [120421] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [WebGL] Simple implementation of the InjectedWebGLScriptSource to support capturing WebGL calls for a frame
https://bugs.webkit.org/show_bug.cgi?id=89088
Simple experimental implementation of the InjectedWebGLScriptSource.js that allows to wrap
a WebGL context and capture names (for now) of the WebGL function calls for a frame being captured.
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.
- inspector/InjectedWebGLScriptSource.js:
(.):
- 1:15 AM Changeset in webkit [120420] by
-
- 5 edits in trunk/LayoutTests
Unreviewed chromium mac rebaseline.
- platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 12:50 AM Changeset in webkit [120419] by
-
- 5 edits in trunk/Tools
Unreviewed, rolling out r120370.
http://trac.webkit.org/changeset/120370
https://bugs.webkit.org/show_bug.cgi?id=89183
Broke webkit-patch rebaseline (Requested by zdobersek on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15
- Scripts/webkitpy/layout_tests/port/base.py:
(DummyOptions):
(DummyOptions.init):
(DummyOptions.init.this):
(Port.init):
(Port.get_option):
(Port.set_option_default):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.RegisterCygwinOption):
(ChromiumWinTest.RegisterCygwinOption.init):
(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
- Scripts/webkitpy/tool/mocktool.py:
(MockOptions.update):
- 12:40 AM Changeset in webkit [120418] by
-
- 11 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r120411.
- platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
- platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt:
- platform/gtk/fast/forms/range/slider-padding-expected.txt:
- platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt:
- platform/gtk/fast/multicol/client-rects-expected.txt:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
- 12:38 AM Changeset in webkit [120417] by
-
- 220 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in networkinformation, perf, plugins, pointer-lock, printing, scrollbars, and security tests
https://bugs.webkit.org/show_bug.cgi?id=89181
Reviewed by Kent Tamura.
- perf/clone-with-focus.html:
- perf/nested-combined-selectors.html:
- perf/table-rows-length-caching.html:
- platform/chromium/plugins/call-as-function.html:
- platform/chromium/plugins/get-url-with-blank-target2.html:
- platform/chromium/plugins/get-url-with-iframe-target-no-crash.html:
- platform/chromium/printing/custom-page-size-style-expected.txt:
- platform/chromium/printing/custom-page-size-style.html:
- platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html:
- platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html:
- platform/mac-wk2/plugins/contents-scale-factor.html:
- platform/mac-wk2/plugins/mouse-events-scaled.html:
- platform/mac/plugins/bindings-array-apply-crash.html:
- platform/mac/plugins/bindings-objc-long-method-name.html:
- platform/mac/plugins/bindings-objc-method-name-conversion.html:
- platform/mac/plugins/bindings-test-objc.html:
- platform/mac/plugins/call-as-function-test.html:
- platform/mac/plugins/convert-point.html:
- platform/mac/plugins/disable-plugins.html:
- platform/mac/plugins/jsobjc-dom-wrappers.html:
- platform/mac/plugins/jsobjc-simple.html:
- platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled:
- platform/mac/plugins/root-object-premature-delete-crash.html:
- platform/mac/plugins/supports-carbon-event-model.html:
- platform/mac/plugins/testplugin-onnew-onpaint.html:
- platform/mac/plugins/throw-on-dealloc.html:
- platform/mac/plugins/undefined-property-crash.html:
- platform/mac/plugins/update-widget-from-style-recalc.html:
- platform/mac/plugins/webScriptObject-exception-deadlock.html:
- platform/mac/scrollbars/key-window-not-first-responder.html:
- platform/qt/plugins/application-plugin-plugins-disabled.html:
- platform/win/plugins/call-javascript-that-destroys-plugin.html:
- platform/win/plugins/get-value-netscape-window.html:
- platform/win/plugins/iframe-inside-overflow.html:
- platform/win/plugins/npn-invalidate-rect-invalidates-window.html:
- platform/win/plugins/visibility-hidden.html:
- platform/win/plugins/window-geometry-initialized-before-set-window.html:
- platform/win/plugins/window-region-is-set-to-clip-rect.html:
- platform/win/plugins/windowless-paint-rect-coordinates.html:
- plugins/:
- pointer-lock/lock-fail-responses-expected.txt:
- pointer-lock/lock-fail-responses.html:
- pointer-lock/pointer-lock-api.html:
- pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
- pointer-lock/pointerlockchange-pointerlockerror-events.html:
- pointer-lock/pointerlocklost-event-expected.txt:
- pointer-lock/pointerlocklost-event.html:
- printing/compositing-layer-printing.html:
- printing/css2.1/README.txt:
- printing/css2.1/page-break-after-000.html:
- printing/css2.1/page-break-after-001.html:
- printing/css2.1/page-break-after-002.html:
- printing/css2.1/page-break-after-003.html:
- printing/css2.1/page-break-after-004.html:
- printing/css2.1/page-break-before-000.html:
- printing/css2.1/page-break-before-001.html:
- printing/css2.1/page-break-before-002.html:
- printing/css2.1/page-break-inside-000.html:
- printing/iframe-print.html:
- printing/media-queries-print.html:
- printing/numberOfPages-expected.txt:
- printing/page-count-layout-overflow.html:
- printing/page-count-relayout-shrink.html:
- printing/page-count-with-one-word.html:
- printing/page-format-data-display-none.html:
- printing/page-format-data-expected.txt:
- printing/page-format-data.html:
- printing/page-rule-css-text.html:
- printing/page-rule-in-media-query.html:
- printing/page-rule-selection-expected.txt:
- printing/page-rule-selection.html:
- printing/pageNumerForElementById-expected.txt:
- printing/print-close-crash.html:
- printing/pseudo-class-outside-page.html:
- printing/resources/paged-media-test-utils.js:
(pageNumberForElementShouldBe):
(numberOfPagesShouldBe):
(runPrintingTest):
- printing/return-from-printing-mode.html:
- printing/script-tests/numberOfPages.js:
- printing/script-tests/pageNumerForElementById.js:
- printing/setPrinting.html:
- printing/simultaneous-position-float-change.html:
- printing/single-line-must-not-be-split-into-two-pages.html:
- printing/width-overflow.html:
- printing/zoomed-document.html:
- scrollbars/hidden-iframe-scrollbar-crash.html:
- scrollbars/hidden-iframe-scrollbar-crash2.html:
- scrollbars/hidden-scrollbar-prevents-layout.html:
- scrollbars/overflow-custom-scrollbar-crash.html:
- scrollbars/resources/hidden-iframe-scrollbar-crash2.html:
- scrollbars/scroll-rtl-or-bt-layer.html:
- scrollbars/scrollable-iframe-remove-crash.html:
- scrollbars/scrollbar-click-does-not-blur-content.html:
- scrollbars/scrollbar-crash-on-refresh.html:
- scrollbars/scrollbar-drag-thumb-with-large-content.html:
- scrollbars/scrollbar-gradient-crash.html:
- scrollbars/scrollbar-iframe-click-does-not-blur-content.html:
- scrollbars/scrollbar-initial-position.html:
- scrollbars/scrollbar-middleclick-nopaste.html:
- scrollbars/scrollbar-miss-mousemove-disabled.html:
- scrollbars/scrollbar-miss-mousemove.html:
- scrollbars/scrollbar-owning-renderer-crash.html:
- scrollbars/scrollbar-part-created-with-no-parent-crash.html:
- scrollbars/scrollbar-percent-padding-crash.html:
- scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
- scrollbars/scrollevent-iframe-no-scrolling-wheel.html:
- scrollbars/scrollevent-iframe-no-scrolling.html:
- security/autocomplete-cleared-on-back.html:
- security/block-test-no-port.html:
- security/block-test.html:
- security/set-form-autocomplete-attribute.html:
- 12:33 AM Changeset in webkit [120416] by
-
- 288 edits in trunk/LayoutTests
Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests
https://bugs.webkit.org/show_bug.cgi?id=89176
Reviewed by Kent Tamura.
- ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm:
- inspector/audits/resources/audits-style1.css:
- inspector/console/console-long-eval-crash.html:
- inspector/extensions/extensions-audits-content-script.html:
- inspector/extensions/extensions-eval-content-script.html:
- inspector/profiler/cpu-profiler-profiling-without-inspector.html:
- inspector/timeline/timeline-animation-frame.html:
- inspector/timeline/timeline-paint.html:
- inspector/timeline/timeline-receive-response-event.html:
- inspector/timeline/timeline-timer.html:
- java/argument-to-object-type.html:
- java/array-return.html:
- java/array-sort.html:
- java/embedding-java-with-object.html:
- java/inaccessible-class.html:
- java/inline-applet-crash.html:
- java/java-and-plugins.html:
- java/lc3/:
- jquery/resources/helper.js:
- loader/go-back-to-different-window-size.html:
- loader/load-defer-resume-crash.html:
- loader/navigation-while-deferring-loads.html:
- loader/reload-subresource-when-type-changes.html:
- mathml/EmptyMFracCrash.xhtml:
- mathml/EmptyMunderOverCrash.xhtml:
- mathml/empty-mroot-crash.xhtml:
- mathml/empty-msubsup-crash.html:
- mathml/fenced-whitespace-separators-crash.html:
- mathml/msub-anonymous-child-render-crash.html:
- mathml/msubsup-no-grandchild.xhtml:
- mathml/msubsup-remove-children.xhtml:
- mathml/munderover-remove-children.html:
- mathml/operator-hijacks-fenced-node.xhtml:
- mathml/wbr-in-mroot-crash.html:
- media/W3C/w3cwrapper.js:
(test):
(async_test.t.done):
(async_test):
- media/adopt-node-crash.html:
- media/audio-controls-do-not-fade-out.html:
- media/audio-controls-rendering.html:
- media/audio-delete-while-slider-thumb-clicked.html:
- media/audio-delete-while-step-button-clicked.html:
- media/audio-garbage-collect.html:
- media/audio-no-installed-engines.html:
- media/audio-only-video-intrinsic-size.html:
- media/audio-repaint.html:
- media/context-menu-actions.html:
- media/controls-after-reload.html:
- media/controls-drag-timebar.html:
- media/controls-layout-direction.html:
- media/controls-right-click-on-timebar.html:
- media/controls-without-preload.html:
- media/crash-closing-page-with-media-as-plugin-fallback.html:
- media/fallback.html:
- media/media-blocked-by-beforeload.html:
- media/media-blocked-by-willsendrequest.html:
- media/media-controls-clone-crash.html:
- media/media-controls-invalid-url.html:
- media/media-document-audio-repaint.html:
- media/media-document-audio-size.html:
- media/media-fullscreen.js:
(canplaythrough):
- media/media-volume-slider-rendered-normal.html:
- media/no-auto-play-in-sandbox.html:
- media/remove-from-document-before-load.html:
- media/resources/foreignobject-media.svg:
- media/restore-from-page-cache.html:
- media/svg-as-image-with-media-blocked.html:
- media/video-beforeload-remove-source.html:
- media/video-canvas-alpha.html:
- media/video-canvas.html-disabled:
- media/video-click-dblckick-standalone.html:
- media/video-controls-in-media-document.html:
- media/video-controls-no-scripting.html:
- media/video-controls-toggling.html:
- media/video-controls-visible-audio-only.html:
- media/video-controls-with-mutation-event-handler.html:
- media/video-delay-load-event.html:
- media/video-display-toggle.html:
- media/video-document-types.html:
- media/video-element-other-namespace-crash.html:
- media/video-empty-source.html:
- media/video-no-audio.html:
- media/video-paint-test.js:
(init.waitForMultipleEvents):
(initAndPause.waitForMultipleEvents):
(initAndPause):
- media/video-plays-past-end-of-test.html:
- media/video-poster-blocked-by-willsendrequest.html:
- media/video-replaces-poster.html:
- media/video-source-inserted.html:
- media/video-test.js:
(endTest):
- media/video-volume-slider.html:
- media/video-zoom.html:
- mhtml/check_domain.mht:
- mhtml/multi_frames.html_original:
- mhtml/multi_frames_binary.mht:
- mhtml/multi_frames_ie.mht:
- mhtml/multi_frames_unmht.mht:
- mhtml/page_with_css_and_js_ie.mht:
- mhtml/page_with_css_and_js_unmht.mht:
- mhtml/page_with_image.html_original:
- mhtml/page_with_image_ie.mht:
- mhtml/page_with_image_unmht.mht:
- mhtml/simple_page.html_original:
- mhtml/simple_page_ie.mht:
- mhtml/simple_page_unmht.mht:
- networkinformation/resources/event-after-navigation-new.html:
- networkinformation/script-tests/event-after-navigation.js:
- platform/chromium/media/video-frame-size-change.html:
- 12:22 AM Changeset in webkit [120415] by
-
- 20 edits in trunk/LayoutTests
Unreviewed chromium win and mac rebaseline for r120403.
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium/TestExpectations:
- 12:19 AM Changeset in webkit [120414] by
-
- 11 edits in trunk/Source
Add fullscreen button to Chrome video controls for video.
https://bugs.webkit.org/show_bug.cgi?id=88818
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.
No new tests, final patch will contain the rebaselined tests.
The Chrome video controls are receiving a visual update.
This patch includes a fullscreen button for video elements and the rendering of the controls
in fullscreen including hiding them after 2 seconds when the mouse is out of the controls
and not moved.
- css/fullscreen.css:
(video:-webkit-full-screen, audio:-webkit-full-screen):
Add audio to the default fullscreen styling rules.
- css/mediaControlsChromium.css:
(video:-webkit-full-page-media::-webkit-media-controls-panel):
Align controls to the bottom of the fullscreen page.
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
Include styling for the fullscreen button.
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore):
Add a constant for when to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Add member fields for fullscreen button, hiding timer and tracking of whether we are in fullscreen.
(WebCore::MediaControlRootElementChromium::create):
Add fullscreen button element to the visual layout.
(WebCore::MediaControlRootElementChromium::setMediaController):
Add fullscreen button element to the media controller.
(WebCore::MediaControlRootElementChromium::reset):
Show the fullscreen button if the controller supports fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStarted):
Start the timer to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStopped):
Don't hide the controls when the video is paused in fullscreen.
(WebCore::MediaControlRootElementChromium::reportedError):
Hide the fullscreen button when we hit an error.
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
Add logic for mouse events in fullscreen to start/stop the hiding timer.
(WebCore::MediaControlRootElementChromium::startHideFullscreenControlsTimer):
Start the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::hideFullscreenControlsTimerFired):
Timer fired: hide the video controls in fullscreen.
(WebCore::MediaControlRootElementChromium::stopHideFullscreenControlsTimer):
Reset the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::enteredFullscreen):
Add logic to enter fullscreen.
(WebCore::MediaControlRootElementChromium::exitedFullscreen):
Add logic to exit fullscreen.
- html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
Add declaration of member functions and fields for fullscreen.
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaFullscreenButton):
Use the new image for the fullscreen button.
- rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
Declare the fullscreen painting function for Chrome Mac.
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Mac.
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Skia.
- rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
Declare the fullscreen painting function for Chrome Skia.
- 12:13 AM Changeset in webkit [120413] by
-
- 7 edits2 deletes in trunk
Unreviewed, rolling out r110340.
http://trac.webkit.org/changeset/110340
https://bugs.webkit.org/show_bug.cgi?id=88749
Source/WebCore:
r110340 added a broken implementation of
HTMLSelectElement::selectedOptions. This roll out removes
HTMLSelectElement::selectedOptions.
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
- html/HTMLSelectElement.cpp:
- html/HTMLSelectElement.h:
(HTMLSelectElement):
- html/HTMLSelectElement.idl:
LayoutTests:
- fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Removed.
- fast/dom/HTMLSelectElement/select-selectedOptions.html: Removed.
- 12:11 AM Changeset in webkit [120412] by
-
- 2 edits in trunk/LayoutTests
Unreviewed typo fix for r120405.
- platform/chromium/TestExpectations: