Timeline
Jun 17, 2012:
- 11:43 PM Changeset in webkit [120573] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Add EFL baseline for fast/parser/nested-fragment-parser-crash.html
https://bugs.webkit.org/show_bug.cgi?id=89329
Unreviewed EFL gardening. Use the same expectation for
fast/parser/nested-fragment-parser-crash.html as mac.
The test is passing since it does not crash.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-17
- platform/efl/TestExpectations:
- platform/efl/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
- 11:36 PM Changeset in webkit [120572] by
-
- 4 edits in trunk/Source/WebCore
[TextureMapper] Reduce boilerplate code in the TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=89293
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-17
Reviewed by Noam Rosenthal.
Refactor TextureMapperShaderManager to reduce boilerplate code, by:
- Making fragment and shader source arguments to the superclass constructor.
- Removing virtual methods (which should not be called in constructors) with constructor implementations. This exchanges a small amount of code duplication for a lot less boilerplate.
- Standardizing on the fooLocation name instead of fooVariable.
- Removing the ::prepare() series of methods for non-filter shaders. It's betters to have all the uniform and attribute binding in the same place.
No new tests. This is just a refactor and shouldn't change any functionality.
- platform/graphics/texmap/TextureMapperGL.cpp:
Handle binding the mask texture and opacity at both of the previous ::prepare callsites. Also
rename "shaderInfo" to "program".
- platform/graphics/texmap/TextureMapperShaderManager.cpp: Perform the refactoring described above.
- platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.
- 11:32 PM Changeset in webkit [120571] by
-
- 2 edits in trunk/Source/WebCore
Fix Framebuffer restrictions
https://bugs.webkit.org/show_bug.cgi?id=89320
Patch by Gregg Tavares <gman@google.com> on 2012-06-17
Reviewed by Kenneth Russell.
No new tests, just fixing old ones
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::checkStatus):
- 10:34 PM UsingGitWithWebKit edited by
- Add "Copying file aka svn copy" section (diff)
- 9:57 PM Changeset in webkit [120570] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking some tests as failures..
- platform/chromium/TestExpectations:
- 9:57 PM Changeset in webkit [120569] by
-
- 20 edits in trunk/Source/WebCore
[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980
Reviewed by Kent Tamura.
This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.
No new tests. This patch doesn't change behavior.
- CMakeLists.txt: Added new file RenderSearchField.cpp
- GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
- Target.pri: ditto
- WebCore.gypi: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/project.pbxproj: ditto
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.
- html/InputType.cpp:
(WebCore::InputType::addSearchResult): Added.
- html/InputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
(WebCore::SearchInputType::searchEventsShouldBeDispatched): Moved from HTMLInputElement.
(WebCore::SearchInputType::subtreeHasChanged) Moved search related code from HTMLInputElement.
- html/SearchInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.
- rendering/RenderSearchField.h:
(WebCore::toRenderSearchField): Added.
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.
- rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
- 9:35 PM Changeset in webkit [120568] by
-
- 6 edits in trunk/Source/JavaScriptCore
GC copy phase spends needless cycles zero-filling blocks
https://bugs.webkit.org/show_bug.cgi?id=89128
Reviewed by Gavin Barraclough.
We only need to zero-fill when we're allocating memory that might not
get fully initialized before GC.
- heap/CopiedBlock.h:
(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::create): Added a way to create without zero-filling.
This is our optimization.
(JSC::CopiedBlock::zeroFillToEnd):
(JSC::CopiedBlock::CopiedBlock): Split zero-filling out from creation,
so we can sometimes create without zero-filling.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::doneCopying): Renamed addNewBlock to allocateBlock()
to clarify that the new block is always newly-allocated.
(JSC::CopiedSpace::doneFillingBlock): Make sure to zero-fill to the end
of a block that might be used in the future for allocation. (Most of the
time, this is a no-op, since we've already filled the block completely.)
(JSC::CopiedSpace::getFreshBlock): Removed this function because the
abstraction of "allocation must succeed" is no longer useful.
- heap/CopiedSpace.h: Updated declarations to match.
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::allocateBlockForCopyingPhase): New function, which
knows that it can skip zero-filling.
Added tighter scoping to our lock, to improve parallelism.
(JSC::CopiedSpace::allocateBlock): Folded getFreshBlock functionality
into this function, for simplicity.
- heap/MarkStack.cpp:
(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace): Use our new zero-fill-free helper
function for great good.
- 9:18 PM Changeset in webkit [120567] by
-
- 1 edit2 copies in trunk/Source/WebCore
[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=89155
This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.
No new tests. This patch doesn't change behavior.
- rendering/RenderSearchField.cpp: Added. (WebCore): (WebCore::RenderTextControlInnerBlock::positionForPoint): (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::containerElement): (WebCore::RenderTextControlSingleLine::innerBlockElement): (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): (WebCore::RenderTextControlSingleLine::resultsButtonElement): (WebCore::RenderTextControlSingleLine::cancelButtonElement): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::getAvgCharWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::computeControlHeight): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::visibilityForCancelButton): (WebCore::RenderTextControlSingleLine::textShouldBeTruncated): (WebCore::RenderTextControlSingleLine::autosaveName): (WebCore::RenderTextControlSingleLine::valueChanged): (WebCore::RenderTextControlSingleLine::itemText): (WebCore::RenderTextControlSingleLine::itemLabel): (WebCore::RenderTextControlSingleLine::itemIcon): (WebCore::RenderTextControlSingleLine::itemIsEnabled): (WebCore::RenderTextControlSingleLine::itemStyle): (WebCore::RenderTextControlSingleLine::menuStyle): (WebCore::RenderTextControlSingleLine::clientInsetLeft): (WebCore::RenderTextControlSingleLine::clientInsetRight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::listSize): (WebCore::RenderTextControlSingleLine::selectedIndex): (WebCore::RenderTextControlSingleLine::popupDidHide): (WebCore::RenderTextControlSingleLine::itemIsSeparator): (WebCore::RenderTextControlSingleLine::itemIsLabel): (WebCore::RenderTextControlSingleLine::itemIsSelected): (WebCore::RenderTextControlSingleLine::setTextFromItem): (WebCore::RenderTextControlSingleLine::fontSelector): (WebCore::RenderTextControlSingleLine::hostWindow): (WebCore::RenderTextControlSingleLine::autoscroll): (WebCore::RenderTextControlSingleLine::scrollWidth): (WebCore::RenderTextControlSingleLine::scrollHeight): (WebCore::RenderTextControlSingleLine::scrollLeft): (WebCore::RenderTextControlSingleLine::scrollTop): (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): (WebCore::RenderTextControlSingleLine::scroll): (WebCore::RenderTextControlSingleLine::logicalScroll): (WebCore::RenderTextControlSingleLine::createScrollbar): (WebCore::RenderTextControlSingleLine::inputElement):
- rendering/RenderSearchField.h: Added. (WebCore): (RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::popupIsVisible): (WebCore::RenderTextControlSingleLine::isTextField): (WebCore::toRenderTextControlSingleLine): (RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
- 9:11 PM Changeset in webkit [120566] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r120565.
http://trac.webkit.org/changeset/120565
https://bugs.webkit.org/show_bug.cgi?id=89155
Bad commit message
- rendering/RenderSearchField.cpp: Removed.
- rendering/RenderSearchField.h: Removed.
- 9:08 PM Changeset in webkit [120565] by
-
- 1 edit2 copies in trunk/Source/WebCore
Try 1
- 7:43 PM Changeset in webkit [120564] by
-
- 4 edits in trunk/Source
Unreviewed build fix.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- 7:42 PM Changeset in webkit [120563] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer] optimize ::naturalSize()
https://bugs.webkit.org/show_bug.cgi?id=89314
Reviewed by Martin Robinson.
Keep track of the video-sink sinkpad in the MediaPlayerPrivate and
adapt the webkitGstGetPadCaps API accordingly. The benefit of this
change is to reduce the number of calls to
gst_element_get_static_pad() and the corresponding gst_pad_unref().
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(webkitGstGetPadCaps):
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- 7:35 PM Changeset in webkit [120562] by
-
- 2 edits in trunk
Unreviewed, GTK 64-bit build fix after r120551.
- Source/autotools/symbols.filter:
- 7:28 PM Changeset in webkit [120561] by
-
- 2 edits in trunk/Source/WebCore
Don't mark main frame layer opaque if the frame view is transparent
https://bugs.webkit.org/show_bug.cgi?id=88234
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-17
Reviewed by Simon Fraser.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
- 7:22 PM Changeset in webkit [120560] by
-
- 1 edit2 adds in trunk/LayoutTests
colspan in table-layout:fixed does not add up widths properly
https://bugs.webkit.org/show_bug.cgi?id=20213
Reviewed by Abhishek Arya.
The bug has been fixed (likely by bug 14858) so landing the test case as fixed table layout with cell spanning several
<col>'s with fixed widths is not properly covered.
- fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size-expected.txt: Added.
- fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size.html: Added.
- 7:12 PM Changeset in webkit [120559] by
-
- 3 edits2 adds in trunk
Prevent crash in SVGDocumentExtensions::removeAllElementReferencesForTarget.
https://bugs.webkit.org/show_bug.cgi?id=88144
Reviewed by Abhishek Arya.
Source/WebCore:
When iterating over referencing elements to rebuild after a reference change in
SVGDocumentExtensions::removeAllElementReferencesForTarget, we can
modify the underlying toBeNotified vector, invalidating it. This change checks
that a vector element is valid before rebuilding, preventing a crash.
Some definitions from SVGDocumentExtensions that may put this patch in context:
An example of a "referenced elements" is a <path>.
An example of a "referencing element" is a <textPath href='some_path_id'>.
m_elementDependencies is a map from referenced elements (e.g., paths) to
a set of referencing elements (e.g., textPaths).
The check that the vector element is valid relies on checking if the referencing
element is in m_elementDependencies. This check is allowed because in the
destructor of SVGTextPathElement (and SVGFeImageElement),
removeAllTargetReferencesForElement() is called, removing the referencing element
from m_elementDependencies.
Simply checking if the referencing element is anywhere in m_elementDependencies
is enough to show it is valid, but that requires iterating over all referenced
elements to see if the given referencing element is present. This change
only checks if the textPath is still in the elements referencing the
path being removed, and only removes the referenced element from
m_elementDependencies after forcing the referencing elements to be rebuilt.
Test: svg/text/textpath-reference-crash.html
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):
LayoutTests:
- svg/text/textpath-reference-crash-expected.txt: Added.
- svg/text/textpath-reference-crash.html: Added.
- 7:09 PM Changeset in webkit [120558] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r120390.
http://trac.webkit.org/changeset/120390
https://bugs.webkit.org/show_bug.cgi?id=89155
Failed to copy merge history to RenderSerachField.{cpp,h}
- rendering/RenderSearchField.cpp: Removed.
- rendering/RenderSearchField.h: Removed.
- 7:06 PM Changeset in webkit [120557] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r120432.
http://trac.webkit.org/changeset/120432
https://bugs.webkit.org/show_bug.cgi?id=88980
Failed to copy merge history to RenderSerachField.{cpp,h}
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore):
(WebCore::HTMLInputElement::addSearchResult):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
- html/InputType.h:
(InputType):
- html/SearchInputType.cpp:
- html/SearchInputType.h:
(SearchInputType):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- rendering/RenderSearchField.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):
- rendering/RenderSearchField.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(WebCore):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::createScrollbar):
- rendering/RenderTextControlSingleLine.h:
(WebCore):
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):
- rendering/RenderingAllInOne.cpp:
- 6:59 PM Changeset in webkit [120556] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should attempt to use structure watchpoints for all inlined get_by_id's and put_by_id's
https://bugs.webkit.org/show_bug.cgi?id=89316
Reviewed by Oliver Hunt.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- 5:20 PM Changeset in webkit [120555] by
-
- 7 edits in trunk/Tools
garden-o-matic 'Results' panel is broken for the Apple platform
https://bugs.webkit.org/show_bug.cgi?id=89310
Reviewed by Adam Barth.
For platforms that don't use accumulated build directories on the server,
carry along buildLocation data with buildInfo, so that we know where to
look for the test results files for a given test.
Renamed historicalResultsSummaryURLs to historicalResultsLocations because
it now returns an array of objects with buildNumber, revision and url info.
Fixed results.fetchResultsURLs() to use this data to find results.
Fixed the results display to not scroll when you click on a test to see the results.
Made the h3s look less ugly
Don't try to show the flakiness dashboard for the Apple platform.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
(.results-view .top-panel):
(.results-view h3):
- 4:06 PM Changeset in webkit [120554] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r111041): Missing element type check in RenderThemeMac::paintMediaFullscreenButton
https://bugs.webkit.org/show_bug.cgi?id=89270
Reviewed by Oliver Hunt.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaFullscreenButton): Use the proper idiom for getting
a media control element's type.
- 2:19 PM Changeset in webkit [120553] by
-
- 13 edits in trunk/Source
[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-17
Reviewed by Adrienne Walker.
Source/WebCore:
Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.
The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script encoded as C
string.
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 2:06 PM Changeset in webkit [120552] by
-
- 2 edits in trunk/Source/WTF
[WIN] Simplify implementation of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=83156
Reviewed by Brent Fulgham.
Use GetSystemTimeAsFileTime() instead of ftime().
This avoids an unneeded call to the MS CRT and
brings the Win/WinCE code closer together.
- wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
(WTF::currentTime):
- 11:36 AM Changeset in webkit [120551] by
-
- 2 edits in trunk
Unreviewed, GTK build fix after r120397.
- Source/autotools/symbols.filter:
- 4:15 AM Changeset in webkit [120550] by
-
- 5 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r120541.
- platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
- platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
- 3:16 AM Changeset in webkit [120549] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=89302
Unreviewed EFL gardening. Skip flaky test.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-17
- platform/efl/TestExpectations:
- 1:34 AM Changeset in webkit [120548] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix a large number of tests I broke with http://trac.webkit.org/changeset/120547
We need to reset the device scale facter after each test.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
- testing/InternalSettings.h:
(InternalSettings):
- 12:01 AM Changeset in webkit [120547] by
-
- 5 edits in trunk/LayoutTests
Update a few more tests to use internals.settings.setDeviceScaleFactor.
- compositing/tiled-layers-hidpi.html:
- fast/canvas/2d.backingStorePixelRatio.html:
- fast/canvas/2d.imageDataHD.html:
- platform/mac-wk2/plugins/contents-scale-factor.html:
Jun 16, 2012:
- 9:53 PM Changeset in webkit [120546] by
-
- 18 edits in trunk/Tools
Make garden-o-matic work for the Apple Mac port
https://bugs.webkit.org/show_bug.cgi?id=84642
Reviewed by Adam Barth.
Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
educating the scripts in various ways:
- Wrap up platform-related differences in config.kPlatforms[]
- Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
- The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do, so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most recent build with valid results.
- The webkit.org bots often generate results directories with no layout test data (e.g. when testers try to test a build that has already been deleted). Make walkHistory() more robust here.
- webkit.org uses differently named test result directories, that include the SVN revision as well as the build number. That forces us to fetch more build info before we can get the result directory URL.
- chromium.org serves raw directory listings for a builder's results directories. webkit.org serves those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results dirs.
- Various URLs differ between webkit.org and chromium.org
- Better UI for the failures info, so that some info is visible even when not hovered.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li table.failures):
(ol.notifications>li:hover table.failures):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#onebar #platform-picker):
- Scripts/webkitpy/layout_tests/port/builders.py:
- 9:42 PM Changeset in webkit [120545] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.
https://bugs.webkit.org/show_bug.cgi?id=89277
This patch makes blur and drop shadow shader share gaussian formula.
On the other hand, blur and drop shadow filter computed a gaussian weight in
pixel shader. However, a gaussian kernal has always same values, so this patch
computes the gaussian kernel only one time using CPU.
It is more accurate and faster.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
Covered by existing tests, particularly css3/filters/.
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::gauss):
(WebCore::gaussianKernel):
(WebCore::StandardFilterProgram::prepare):
- platform/graphics/texmap/TextureMapperShaderManager.h:
- 8:55 PM Changeset in webkit [120544] by
-
- 11 edits in trunk/Source
[chromium] Make the deviceScaleFactor dynamically adjustable.
https://bugs.webkit.org/show_bug.cgi?id=88916
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h: Plumb setDeviceScaleFactor and
deviceScaleFactor functions.
(WebKit::WebLayerTreeView::Settings::Settings): Remove deviceScaleFactor from
settings as it is now dynamic.
(Settings):
(WebLayerTreeView):
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed use of static
deviceScaleFactor from settings with dyanmic m_deviceScaleFactor
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings): Removed static deviceScaleFactor
(CCSettings):
(CCLayerTreeHost): Added dynamic m_deviceScaleFactor in its place.
(WebCore::CCLayerTreeHost::deviceScaleFactor):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Same as above.
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Added dynamic
m_deviceScaleFactor instance variable.
(WebCore::CCLayerTreeHostImpl::deviceScaleFactor):
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings): Removed unused
static deviceScaleFactor.
(WebKit::WebLayerTreeView::setDeviceScaleFactor):
(WebKit):
(WebKit::WebLayerTreeView::deviceScaleFactor):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDeviceScaleFactor): Push the dynamic deviceScaleFactor
to the compositor as required.
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- tests/CCLayerTreeHostTest.cpp: Tests use dynamic setDeviceScaleFactor.
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
- 6:05 PM Changeset in webkit [120543] by
-
- 9 edits2 moves in trunk
Unreviewed, rolling out r120536.
http://trac.webkit.org/changeset/120536
https://bugs.webkit.org/show_bug.cgi?id=89296
Does not compile on chromium-linux (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
Source/WebCore:
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
- WebKit.gyp:
- public/linux/WebFontRendering.h:
- public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.
(WebKit):
(WebFontRendering):
- src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 6:01 PM Changeset in webkit [120542] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r120539.
http://trac.webkit.org/changeset/120539
https://bugs.webkit.org/show_bug.cgi?id=89295
Does not compile on chromium-mac (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
Source/WebCore:
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 5:39 PM Changeset in webkit [120541] by
-
- 34 edits in trunk
layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=89274
Reviewed by Levi Weintraub.
Tools:
Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
Note: The WebKit2 API that setBackingScaleFactor exercises is still
tested by API-level tests.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
LayoutTests:
We don't need both layoutTestController.setBackingScaleFactor and
internals.settings.setDeviceScaleFactor because they do exactly the
same thing. This patch removes setBackingScaleFactor because it's
async nature is annoying and implementing it requires a bunch of
port-specific code.
- fast/hidpi/broken-image-icon-hidpi.html:
- fast/hidpi/broken-image-with-size-hidpi.html:
- fast/hidpi/clip-text-in-hidpi.html:
- fast/hidpi/focus-rings.html:
- fast/hidpi/image-set-as-background.html:
- fast/hidpi/image-set-background-dynamic.html:
- fast/hidpi/image-set-background-repeat-without-size.html:
- fast/hidpi/image-set-background-repeat.html:
- fast/hidpi/image-set-border-image-comparison.html:
- fast/hidpi/image-set-border-image-dynamic.html:
- fast/hidpi/image-set-border-image-simple.html:
- fast/hidpi/image-set-in-content-dynamic.html:
- fast/hidpi/image-set-out-of-order.html:
- fast/hidpi/image-set-simple.html:
- fast/hidpi/image-set-without-specified-width.html:
- fast/hidpi/resize-corner-hidpi.html:
- fast/hidpi/video-controls-in-hidpi.html:
- svg/as-image/image-respects-deviceScaleFactor.html:
- 5:35 PM Changeset in webkit [120540] by
-
- 3 edits4 adds in trunk
Ignore paths in Content Security Policy sources rather than failing to parse them.
https://bugs.webkit.org/show_bug.cgi?id=89281
Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Adam Barth.
Source/WebCore:
In short:
script-src http://example.com/should allow scripts from
http://example.com. Currently, it allows no scripts at all, as the
terminal/isn't accepted as part of a hostname.
This patch adjusts CSPSourceList::parseSource to accept paths (and
discard them). Once this lands, the next step will be to keep the
path, and use it when comparing source origins in the various
allowXXXFromSource methods.
Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-05.html
http/tests/security/contentSecurityPolicy/source-list-parsing-06.html
- page/ContentSecurityPolicy.cpp:
(CSPSourceList):
(WebCore):
(WebCore::CSPSourceList::parseSource):
Reworked this method entirely to support paths.
(WebCore::CSPSourceList::parsePath):
More or less a no-op at the moment.
(WebCore::CSPSourceList::parsePort):
Moved the
:assertion here from parseSource.
LayoutTests:
- http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-05.html: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-06.html: Added.
- 5:26 PM Changeset in webkit [120539] by
-
- 13 edits in trunk/Source
[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-16
Reviewed by Adrienne Walker.
Source/WebCore:
Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.
The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
Source/WebKit/chromium:
Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script
encoded as C string.
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
- tests/CCLayerImplTest.cpp:
(WebCore):
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
- 5:17 PM Changeset in webkit [120538] by
-
- 3 edits in trunk/LayoutTests
Fix test cases for
header/footerAXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=88911
The relative URLs to js-test-pre.js and js-test-post.js were incorrect.
Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Simon Fraser.
- platform/mac/accessibility/footer.html:
- platform/mac/accessibility/header.html:
- 5:13 PM Changeset in webkit [120537] by
-
- 5 edits in trunk/LayoutTests
[EFL] Rebaseline fast/lists/001*.html tests after r120495
https://bugs.webkit.org/show_bug.cgi?id=89283
Unreviewed EFL gardening after r120495.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-16
- platform/efl/fast/lists/001-expected.png:
- platform/efl/fast/lists/001-expected.txt:
- platform/efl/fast/lists/001-vertical-expected.png:
- platform/efl/fast/lists/001-vertical-expected.txt:
- 4:28 PM Changeset in webkit [120536] by
-
- 9 edits2 moves in trunk
[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228
Source/WebCore:
Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.
Reviewed by Tony Chang.
Refactory only. No new tests.
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::setupPaint):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
Source/WebKit/chromium:
Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.
This also avoids the ambiguous name 'linuxish'.
Reviewed by Tony Chang.
- WebKit.gyp:
- public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.
(WebFontRendering):
- public/linux/WebFontRendering.h:
- public/linuxish: Removed.
- public/linuxish/WebFontRendering.h: Removed.
- src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.
(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):
- src/linuxish: Removed.
- src/linuxish/WebFontRendering.cpp: Removed.
Tools:
Reviewed by Tony Chang.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
- DumpRenderTree/chromium/TestShellAndroid.cpp:
- 4:01 PM WebKit Team edited by
- Changed affiliation (diff)
- 3:59 PM Changeset in webkit [120535] by
-
- 22 edits in trunk/LayoutTests
[EFL] Rebaseline MathML tests after r120492
https://bugs.webkit.org/show_bug.cgi?id=89282
Unreviewed EFL gardening. Several MathML tests needed
rebaselining after r120492.
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-16
- platform/efl/mathml/presentation/attributes-expected.txt:
- platform/efl/mathml/presentation/fenced-expected.txt:
- platform/efl/mathml/presentation/fenced-mi-expected.txt:
- platform/efl/mathml/presentation/fractions-expected.txt:
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
- platform/efl/mathml/presentation/roots-expected.txt:
- platform/efl/mathml/presentation/row-alignment-expected.png:
- platform/efl/mathml/presentation/row-alignment-expected.txt:
- platform/efl/mathml/presentation/sub-expected.txt:
- platform/efl/mathml/presentation/subsup-expected.txt:
- platform/efl/mathml/presentation/sup-expected.txt:
- platform/efl/mathml/presentation/tables-expected.txt:
- platform/efl/mathml/presentation/tokenElements-expected.txt:
- platform/efl/mathml/presentation/under-expected.png:
- platform/efl/mathml/presentation/under-expected.txt:
- platform/efl/mathml/presentation/underover-expected.png:
- platform/efl/mathml/presentation/underover-expected.txt:
- platform/efl/mathml/xHeight-expected.png:
- platform/efl/mathml/xHeight-expected.txt:
- 3:35 PM Changeset in webkit [120534] by
-
- 7 edits in trunk/Source
Settings::devicePixelRatio doesn't do anything and is confusing
https://bugs.webkit.org/show_bug.cgi?id=89272
Reviewed by James Robinson.
Source/WebCore:
Settings::devicePixelRatio is yet another piece of state trying to
represent the device scale factor. The canonical place to store this
state is Page::m_deviceScaleFactor. Nothing in WebCore references
Settings::devicePixelRatio anymore, so we can remove it.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(Settings):
Source/WebKit2:
- Shared/WebPreferencesStore.h:
(WebKit):
- Remove boilerplate code for the setting.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):
- Change these functions to get and set the real device scale factor.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
- Use the real device scale factor for the viewport calculation.
(WebKit::WebPage::updatePreferences):
- Remove boilerplate code for the setting.
- 3:22 PM Changeset in webkit [120533] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] SIGSEV in WebCore::TextureMapperGL::drawTexture.
https://bugs.webkit.org/show_bug.cgi?id=89113
TextureMapperTile::m_texture is created lazilly, so we need null check before
using it.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
No new tests. This patch doesn't change behavior.
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::paint):
- 3:17 PM Changeset in webkit [120532] by
-
- 5 edits in trunk/Source/WebCore
[Texmap] Remove unused code in Texmap.
https://bugs.webkit.org/show_bug.cgi?id=89265
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingState):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
- 3:10 PM Changeset in webkit [120531] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16
- DEPS:
- 1:00 PM Changeset in webkit [120530] by
-
- 12 edits2 adds9 deletes in trunk/LayoutTests
Remove a bunch of 32-bit specific results. These results are the same
on 64 bit.
- platform/chromium-linux-x86/compositing/color-matching: Removed.
- platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom: Removed.
- platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Removed.
- platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
- platform/chromium-linux-x86/fast/images: Removed.
- platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Removed.
- platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Removed.
- platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
- platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
- platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
- platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
- platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png:
- platform/chromium-linux/css3/filters/effect-blur-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png:
- platform/chromium-linux/fast/images/jpeg-with-color-profile-expected.png: Added.
- platform/chromium-linux/fast/images/png-with-color-profile-expected.png: Added.
- 12:53 PM Changeset in webkit [120529] by
-
- 61 edits19 adds27 deletes in trunk/LayoutTests
Update baselines after http://trac.webkit.org/changeset/120485
- platform/chromium-linux-x86/http/tests/local: Removed.
- platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Removed.
- platform/chromium-linux-x86/scrollbars: Removed.
- platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
- platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
- platform/chromium-linux-x86/svg/as-border-image: Removed.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Removed.
- platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Removed.
- platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Removed.
- platform/chromium-linux-x86/svg/repaint: Removed.
- platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Removed.
- platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
- platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
- platform/chromium-linux/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/createImageElement2-expected.png:
- platform/chromium-linux/svg/custom/focus-ring-expected.png:
- platform/chromium-linux/svg/custom/image-parent-translation-expected.png:
- platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
- platform/chromium-linux/svg/custom/text-image-opacity-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win-vista/http/tests/local: Removed.
- platform/chromium-win-vista/svg/dynamic-updates: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/chromium-win-xp/svg/dynamic-updates: Removed.
- platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/custom/createImageElement-expected.png:
- platform/chromium-win/svg/custom/createImageElement2-expected.png:
- platform/chromium-win/svg/custom/focus-ring-expected.png:
- platform/chromium-win/svg/custom/group-opacity-expected.png:
- platform/chromium-win/svg/custom/image-parent-translation-expected.png:
- platform/chromium-win/svg/custom/image-small-width-height-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display2-expected.png:
- platform/chromium-win/svg/custom/js-update-image-and-display3-expected.png:
- platform/chromium-win/svg/custom/js-update-image-expected.png:
- platform/chromium-win/svg/custom/text-image-opacity-expected.png:
- platform/chromium-win/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/chromium-win/svg/filters/filter-source-position-expected.png:
- platform/chromium-win/svg/repaint/image-href-change-expected.png:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- 9:48 AM Changeset in webkit [120528] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines
after r120492 and r120495.
- platform/gtk/fast/lists/001-expected.txt:
- platform/gtk/fast/lists/001-vertical-expected.txt:
- platform/gtk/mathml/xHeight-expected.txt:
- 9:16 AM Changeset in webkit [120527] by
-
- 2 edits in trunk/Source/WebCore
[TexmapGL] Reduce the number of glTexSubImage2D calls
https://bugs.webkit.org/show_bug.cgi?id=83665
Instead of copy the pixels row by row, put the pixels in a buffer and
call glTexSubImage2D just once.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 2:21 AM Changeset in webkit [120526] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument
https://bugs.webkit.org/show_bug.cgi?id=89233
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-06-16
Reviewed by Darin Fisher.
Adds a WebFrame* to the WebFrameClient::userAgentOverride() function.
- public/WebFrameClient.h:
(WebKit::WebFrameClient::userAgentOverride):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::userAgent):
- tests/FrameLoaderClientImplTest.cpp:
- 1:42 AM Changeset in webkit [120525] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip a new failing test.
- platform/qt-5.0-wk2/Skipped:
- 1:34 AM Changeset in webkit [120524] by
-
- 9 edits1 add in trunk/LayoutTests
[Qt] Unreviewed weekend gardening.
- platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
- platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
- platform/qt-5.0/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
- platform/qt-5.0/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
- platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Updated after r120495.
- platform/qt/fast/lists/001-expected.png: Updated after r120495.
- platform/qt/fast/lists/001-expected.txt: Updated after r120495.
- platform/qt/fast/lists/001-vertical-expected.png: Updated after r120495.
- platform/qt/fast/lists/001-vertical-expected.txt: Updated after r120495.
