Context Navigation

← Previous Period
Next Period →

Timeline

Jun 18, 2012:

11:52 PM Changeset in webkit [120682] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests.

platform/qt-4.8/Skipped:
platform/qt-5.0/Skipped:
platform/qt/Skipped:

11:35 PM Changeset in webkit [120681] by rniwa@webkit.org

87 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests
https://bugs.webkit.org/show_bug.cgi?id=89422

Reviewed by Kent Tamura.

fast/animation/request-animation-frame-detach-element.html:
fast/animation/request-animation-frame-detach-element2.html:
fast/animation/request-animation-frame-disabled.html:
fast/animation/request-animation-frame-during-modal.html:
fast/animation/request-animation-frame-iframe.html:
fast/animation/script-tests/request-animation-frame-cancel.js:
fast/animation/script-tests/request-animation-frame-cancel2.js:
fast/animation/script-tests/request-animation-frame-disabled.js:
fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
fast/animation/script-tests/request-animation-frame-timestamps.js:
fast/animation/script-tests/request-animation-frame-within-callback.js:
fast/animation/script-tests/request-animation-frame.js:
fast/autoresize/autoresize-with-iframe.html:
fast/autoresize/basic.html:
fast/autoresize/turn-off-autoresize.html:
fast/backgrounds/animated-gif-as-background.html:
fast/backgrounds/animated-svg-as-mask.html:
fast/backgrounds/background-fast-path-simple-color.html:
fast/backgrounds/background-fill-zero-area-crash.html:
fast/backgrounds/background-repeat-computed-style.html:
fast/backgrounds/multiple-backgrounds-assert.html:
fast/backgrounds/root-background-propagation.html:
fast/backgrounds/root-background-propagation2.html:
fast/backgrounds/size/contain-and-cover-zoomed.html:
fast/backgrounds/solid-color-context-restore.html:
fast/block/:
fast/borders/border-image-reset-by-border-shorthand.html:
fast/borders/border-image-slice-omission.html:
fast/borders/border-mixed-alpha.html:
fast/borders/border-radius-complex-inner.html:
fast/borders/border-radius-parsing.html:
fast/borders/negative-border-width.html:
fast/borders/outline-alpha-block.html:
fast/borders/outline-alpha-inline.html:
fast/box-shadow/box-shadow-clipped-slices.html:
fast/box-shadow/box-shadow-currentcolor.html:
fast/box-shadow/no-blur-multiple-offsets.html:
fast/box-shadow/resources/box-shadow-overflow-scroll.js:
fast/box-shadow/spread-multiple-inset.html:
fast/box-shadow/spread-multiple-normal.html:

11:33 PM Changeset in webkit [120680] by aestes@apple.com

2 edits in trunk/Source/WebCore

[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
https://bugs.webkit.org/show_bug.cgi?id=89424

Reviewed by Dan Bernstein.

editing/mac/EditorMac.mm:

(WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
in a RetainPtr so that it's released before going out of scope.

11:20 PM Changeset in webkit [120679] by tkent@chromium.org

21 edits in trunk/Source/WebCore

Refactoring: Introduce a class to represent restoring state of a form control
https://bugs.webkit.org/show_bug.cgi?id=89412

Reviewed by Hajime Morita.

HTMLFormControlElementWithState::saveFormControlState had two return
values; One is a boolean to represent whether we should save the state
or not, and another is form control value. This patch introduces
FormControlState class representing these values.

We're going to extend FormControlState class so that it can contain
multiple strings to fix a FileInputType issue and it have another type
to fix Bug 89409.

No new tests. Just a refactoring.

html/FormController.cpp:

(WebCore::FormController::formElementsState):
Gets a state string from a FormControlState instance.
(WebCore::FormController::takeStateForFormElement):
Creates a FormControlState instance with a state string.

html/FormController.h:

(WebCore::FormControlState): Added.

html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState):
Use FormControlState class.
(WebCore::BaseCheckableInputType::restoreFormControlState): ditto.

html/BaseCheckableInputType.h:

(BaseCheckableInputType): ditto.

html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): ditto.
(WebCore::FileInputType::restoreFormControlState): ditto.

html/FileInputType.h:

(FileInputType): ditto.

html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::saveFormControlState): ditto.
(WebCore::HTMLFormControlElementWithState::finishParsingChildren): ditto.

html/HTMLFormControlElementWithState.h:

(HTMLFormControlElementWithState): ditto.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::saveFormControlState): ditto.
(WebCore::HTMLInputElement::restoreFormControlState): ditto.

html/HTMLInputElement.h:

(HTMLInputElement): ditto.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.

html/HTMLSelectElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
(WebCore::HTMLTextAreaElement::restoreFormControlState): ditto.

html/HTMLTextAreaElement.h:
html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState): ditto.
(WebCore::HiddenInputType::restoreFormControlState): ditto.

html/HiddenInputType.h:

(HiddenInputType): ditto.

html/InputType.cpp:

(WebCore::InputType::saveFormControlState): ditto.
(WebCore::InputType::restoreFormControlState): ditto.

html/InputType.h:

(InputType): ditto.

html/PasswordInputType.cpp:

(WebCore::PasswordInputType::saveFormControlState): ditto.
(WebCore::PasswordInputType::restoreFormControlState): ditto.

html/PasswordInputType.h:

(PasswordInputType): ditto.

11:16 PM Changeset in webkit [120678] by zandobersek@gmail.com

5 edits in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines after rollouts in r120627.

platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:

11:09 PM Changeset in webkit [120677] by Csaba Osztrogonác

4 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

platform/qt/Skipped: Skip a new failing test to paint the bot green.
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r120609.
platform/qt/fast/multicol/progression-reverse-expected.png: Added after r120609.
platform/qt/fast/multicol/progression-reverse-expected.txt: Added after r120609.
platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r120609.

11:07 PM Changeset in webkit [120676] by commit-queue@webkit.org

5 edits
3 adds in trunk

Source/JavaScriptCore: Changed JSC to always record line number information so that error.stack
and window.onerror() can report proper line numbers.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit): m_lineInfo is now available unconditionally.

bytecode/CodeBlock.h:

(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasLineInfo): Unused. Now removed.
(JSC::CodeBlock::needsCallReturnIndices):
(CodeBlock):
(RareData): Hoisted m_lineInfo out of m_rareData. m_lineInfo is now
filled in unconditionally.

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::addLineInfo):

LayoutTests: Ensure that error.stack and window.onerror always have the appropriate
line numbers of the exception being thrown.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

fast/js/exception-line-number-expected.txt: Added.
fast/js/exception-line-number.html: Added.
fast/js/script-tests/exception-line-number.js: Added.

(foo):
(window.onerror):

10:47 PM Changeset in webkit [120675] by Joone Hur

4 edits in trunk

[EFL] Fontconfig can't be linked properly
https://bugs.webkit.org/show_bug.cgi?id=89418

Unreviewed build fix.

Make Fontconfig be linked correctly.

Source/WebCore:

No new tests. This is only a build fix.

PlatformEfl.cmake: add FONTCONFIG_LIBRARIES to WebCore_LIBRARIES.

Tools:

MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.

10:47 PM Changeset in webkit [120674] by kinuko@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.

fast/forms/file/input-file-entries.html:

10:34 PM Changeset in webkit [120673] by Martin Robinson

2 edits in trunk/Source/WebCore

[Cairo] Fix memory leaks in GLContextGLX.cpp
https://bugs.webkit.org/show_bug.cgi?id=89346

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-18
Reviewed by Martin Robinson.

Fix memory leaks found in GLContextGLX.cpp.

platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::cleanupActiveContextsAtExit): Removing element reduces
size of the vector, so the loop termination condition was failing in the last
iteration, when the vector contains more than one element. This patch fixes the
issue by iterating the vector backwards, so the termination condition doesn't
fail until the size() reaches 0.
(WebCore::GLContextGLX::createPbufferContext): Delete GLXPbuffer
returned by glXCreatePbuffer().
(WebCore::GLContextGLX::createPixmapContext): Delete XVisualInfo
returned by glXChooseVisual().

10:19 PM Changeset in webkit [120672] by mikelawther@chromium.org

1 edit
1 add in trunk/LayoutTests

Unreviewed gardening. Add missing expectation file.

fast/text/title-crash-expected.txt: Added.

10:09 PM Changeset in webkit [120671] by Joone Hur

2 edits in trunk/Tools

Unreviewed. Updating email for committers.py script.

Scripts/webkitpy/common/config/committers.py:

10:08 PM Changeset in webkit [120670] by kinuko@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test fix for r120667: skip '.svn' directory from the test results.

fast/forms/file/input-file-entries.html:

9:56 PM Changeset in webkit [120669] by Simon Fraser

2 edits in trunk/Tools

Fix a typo that caused TestFailures to have a syntax error.

Sadly TestFailures is broken for another reason now too:
https://bugs.webkit.org/show_bug.cgi?id=89419

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._domForBuildName):

9:34 PM Changeset in webkit [120668] by commit-queue@webkit.org

16 edits
2 copies
3 adds in trunk

Source/WebCore: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-depth-texture.html

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

html/canvas/WebGLDepthTexture.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::~WebGLDepthTexture):
(WebCore::WebGLDepthTexture::getName):
(WebCore::WebGLDepthTexture::create):
(WebCore::WebGLDepthTexture::supported):

html/canvas/WebGLDepthTexture.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLDepthTexture):

html/canvas/WebGLDepthTexture.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
html/canvas/WebGLExtension.h:
html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::initializeAttachments):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateSettableTexFormat):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):

html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):

platform/graphics/GraphicsContext3D.h:

LayoutTests: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

fast/canvas/webgl/webgl-depth-texture-expected.txt: Added.
fast/canvas/webgl/webgl-depth-texture.html: Added.

9:13 PM Changeset in webkit [120667] by kinuko@chromium.org

21 edits
8 adds in trunk

Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293

Reviewed by Tony Chang.

Source/WebCore:

Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries

Test: fast/forms/file/input-file-entries.html

Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
Modules/filesystem/HTMLInputElementFileSystem.h: Added.
Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
WebCore.gypi:
html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.

html/FileInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::droppedFileSystemId): Added.

html/HTMLInputElement.h:
html/InputType.cpp:

(WebCore::InputType::droppedFileSystemId): Added.

html/InputType.h:
platform/DragData.cpp:
platform/DragData.h:
platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::droppedFileSystemId): Added.

LayoutTests:

fast/forms/file/input-file-entries-expected.txt: Added.
fast/forms/file/input-file-entries.html: Added.
fast/forms/resources/dir1/UTF8-2.txt: Added.
fast/forms/resources/dir1/UTF8.txt: Added.
fast/forms/resources/dir2/green.jpg: Added.
platform/efl/Skipped:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

9:02 PM Changeset in webkit [120666] by shinyak@chromium.org

4 edits
2 adds in trunk

[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in some Shadow DOM case.
https://bugs.webkit.org/show_bug.cgi?id=88500

Reviewed by Ryosuke Niwa.

Source/WebCore:

When selecting from a child of shadow host to an element in Shadow DOM, the start position of
Selection comes after the end position of Selection in some cases. This caused a crash.

For example, let's think '<div id="host">A</div>D' and host has a Shadow DOM whose innerHTML
is 'B<content></content>C'. When selecting from just after A (p1 = (PositionIsOffsetInAnchor,
#text, 1)) to just before B (p2 = (PositionIsOffsetInAnchor, shadowRoot, 0)), since
comparePosition always judge as p2 is before p1, m_start and m_end in VisibleSelection
will be p2 and p1 respectively.

However, the anchorNodes of p1 and p2 have the different tree scope, we have to adjust p2 to
the same tree scope as p1. Since p2 is m_start, m_start was adjusted to positionAfterNode(div).
This breaks the assumption that m_start is always before (or equal to) m_end.

This patch keeps the assumption. When we cannot move m_start to positionAfterNode(div),
we move m_start to positionBeforeNode(div). Note that we cannot always move m_start to
positionBeforeNode(div), because when selecting just after D (p3 = (PositionIsOffsetInAnchor,
D's parent, 2), we don't want to select A.

In this case, m_start should be adjusted to positionAfterNode(div).

Test: editing/shadow/breaking-editing-boundaries.html

editing/VisibleSelection.cpp:

(WebCore::adjustPositionForEnd):
(WebCore):
(WebCore::adjustPositionForStart):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

editing/VisibleSelection.h:

(VisibleSelection):

LayoutTests:

editing/shadow/breaking-editing-boundaries-expected.txt: Added.
editing/shadow/breaking-editing-boundaries.html: Added.

8:54 PM Changeset in webkit [120665] by morrita@google.com

2 edits in trunk/LayoutTests

Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

platform/chromium/TestExpectations:

8:34 PM Changeset in webkit [120664] by aestes@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix r120663, which didn't land the change that was reviewed.

8:32 PM Changeset in webkit [120663] by aestes@apple.com

2 edits in trunk/Source/JavaScriptCore

[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
https://bugs.webkit.org/show_bug.cgi?id=89415

Reviewed by Sam Weinig.

In the case where canUseJIT was a non-NULL CFBooleanRef,
enableAssembler() would leak both canUseJITKey and canUseJIT by
returning before calling CFRelease. Fix this by using RetainPtr.

runtime/JSGlobalData.cpp:

(JSC::enableAssembler):

8:20 PM Changeset in webkit [120662] by mikelawther@chromium.org

3 edits
1 add in trunk

Crash when setting title dynamically
https://bugs.webkit.org/show_bug.cgi?id=88083

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/title-crash.html

The crashing code takes a rare branch in StyleResolver::styleForElement() where
m_parentStyle is set to point to m_style. Consequently, while applying properties
to m_style we end up mutating m_parentStyle.

In this situation, we clone style() and point m_parentStyle at the clone. The
clone is destroyed at the end of StyleResolver::styleForElement().

css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

fast/text/title-crash.html: Added.

8:04 PM Changeset in webkit [120661] by enne@google.com

3 edits
3 adds in trunk

RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
https://bugs.webkit.org/show_bug.cgi?id=89402

Reviewed by James Robinson.

Source/WebCore:

RenderLayerBacking only attaches scrollbar layers to the graphics
layer tree if there's a clip layer. This is wrong, because these
scrollbars become orphans and other code expects them to handle
repainting the scrollbars (which now become invisible). Fix by always
attaching scrollbar layers.

Test: compositing/overflow/image-load-overflow-scrollbars.html

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateInternalHierarchy):

LayoutTests:

Add a test where an image load creates overflow.

compositing/overflow/image-load-overflow-scrollbars-expected.png: Added.
compositing/overflow/image-load-overflow-scrollbars-expected.txt: Added.
compositing/overflow/image-load-overflow-scrollbars.html: Added.

7:54 PM Changeset in webkit [120660] by fischman@chromium.org

2 edits in trunk/LayoutTests

Make serve-video.php serve 206 responses
https://bugs.webkit.org/show_bug.cgi?id=89252

Reviewed by Adam Barth.

http/tests/media/resources/serve-video.php:

7:51 PM Changeset in webkit [120659] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] GesturePinchBegin and friends are gesture events
https://bugs.webkit.org/show_bug.cgi?id=89398

Reviewed by James Robinson.

public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

7:25 PM Changeset in webkit [120658] by morrita@google.com

2 edits in trunk/LayoutTests

Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

platform/chromium/TestExpectations:

7:06 PM Changeset in webkit [120657] by Simon Fraser

4 edits in trunk/Tools

Provide bug links for suspicious commits
https://bugs.webkit.org/show_bug.cgi?id=89408

Reviewed by Adam Barth.

Add links to bugs for the suspicious commits if we have bug data.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):

6:54 PM Changeset in webkit [120656] by jchaffraix@webkit.org

4 edits
6 copies in branches/chromium/1132

Merge 120257 - Padding and borders can cause integer overflow in block layouts

https://bugs.webkit.org/show_bug.cgi?id=88820

< rdar://problem/11328762>
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/block/block-size-integer-overflow.html
fast/flexbox/box-size-integer-overflow.html
fast/table/table-size-integer-overflow.html

rendering/AutoTableLayout.cpp: Decreased max int.

(WebCore::AutoTableLayout::computePreferredLogicalWidths):

rendering/FixedTableLayout.cpp: Use shared constant.

(WebCore::FixedTableLayout::computePreferredLogicalWidths):

rendering/RenderBlock.cpp: Removed unused constant.
rendering/TableLayout.h: Add shared constant.

(TableLayout):
LayoutTests:

fast/block/block-size-integer-overflow-expected.txt: Added.
fast/block/block-size-integer-overflow.html: Added.
fast/flexbox/box-size-integer-overflow-expected.txt: Added.
fast/flexbox/box-size-integer-overflow.html: Added.
fast/table/table-size-integer-overflow-expected.txt: Added.
fast/table/table-size-integer-overflow.html: Added.

TBR=tc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10583010

6:38 PM Changeset in webkit [120655] by commit-queue@webkit.org

10 edits in trunk

[Chromium] DeviceOrientation Cleanup
https://bugs.webkit.org/show_bug.cgi?id=89354

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.

Source/WebCore:

No new tests because there is no intended change in behavior.

platform/mock/DeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions

(DeviceOrientationClientMock):

Source/WebKit/chromium:

public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions

(WebKit::WebDeviceOrientation::isNull):
(WebKit::WebDeviceOrientation::canProvideAlpha):
(WebKit::WebDeviceOrientation::alpha):
(WebKit::WebDeviceOrientation::canProvideBeta):
(WebKit::WebDeviceOrientation::beta):
(WebKit::WebDeviceOrientation::canProvideGamma):
(WebKit::WebDeviceOrientation::gamma):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
(WebDeviceOrientation):

public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions

(WebKit::WebDeviceOrientationClient::setController):
(WebKit::WebDeviceOrientationClient::startUpdating):
(WebKit::WebDeviceOrientationClient::stopUpdating):
(WebKit::WebDeviceOrientationClient::lastOrientation):

public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions

(WebDeviceOrientationClientMock):

src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier

(DeviceOrientationClientProxy):

src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):

Tools:

DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function

(WebViewHost):

6:32 PM Changeset in webkit [120654] by commit-queue@webkit.org

4 edits in trunk

[EFL] media/video-seek-past-end-playing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=89301

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-18
Reviewed by Philippe Normand.

Source/WebCore:

Switch to double for media duration and playback position
calculations to avoid precision problems.
This patch also removes the workaround for the precision
problem in didEnd() which is no longer needed.

Test: media/video-seek-past-end-playing.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::duration):

LayoutTests:

Unskip media/video-seek-past-end-playing.html now that the
precision problem in MediaPlayerPrivateGStreamer is fixed.

platform/efl/TestExpectations:

6:30 PM Changeset in webkit [120653] by scherkus@chromium.org

117 edits
16 moves
1 add
6 deletes in trunk/LayoutTests

2012-06-18 Andrew Scherkus <scherkus@chromium.org>

[Chromium] Unreviewed. Rebaseline media layout tests due to updated controls.

https://bugs.webkit.org/show_bug.cgi?id=89050

platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
platform/chromium-linux/fast/layers/video-layer-expected.png:
platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-linux/media/audio-controls-rendering-expected.png:
platform/chromium-linux/media/audio-repaint-expected.png:
platform/chromium-linux/media/controls-after-reload-expected.png:
platform/chromium-linux/media/controls-layout-direction-expected.png:
platform/chromium-linux/media/controls-strict-expected.png:
platform/chromium-linux/media/controls-styling-expected.png:
platform/chromium-linux/media/controls-without-preload-expected.png:
platform/chromium-linux/media/media-controls-clone-expected.png:
platform/chromium-linux/media/media-document-audio-repaint-expected.png:
platform/chromium-linux/media/video-controls-rendering-expected.png:
platform/chromium-linux/media/video-display-toggle-expected.png:
platform/chromium-linux/media/video-empty-source-expected.png:
platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
platform/chromium-linux/media/video-no-audio-expected.png:
platform/chromium-linux/media/video-playing-and-pause-expected.png:
platform/chromium-linux/media/video-zoom-controls-expected.png:
platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
platform/chromium-mac-leopard/media/audio-repaint-expected.png:
platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
platform/chromium-mac-leopard/media/controls-strict-expected.png:
platform/chromium-mac-leopard/media/controls-styling-expected.png:
platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
platform/chromium-mac-leopard/media/video-empty-source-expected.png:
platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
platform/chromium-mac-leopard/media/video-no-audio-expected.png:
platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
platform/chromium-mac/fast/layers/video-layer-expected.png:
platform/chromium-mac/fast/layers/video-layer-expected.txt:
platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-mac/media/audio-controls-rendering-expected.png:
platform/chromium-mac/media/audio-controls-rendering-expected.txt:
platform/chromium-mac/media/audio-repaint-expected.png:
platform/chromium-mac/media/audio-repaint-expected.txt:
platform/chromium-mac/media/controls-after-reload-expected.png:
platform/chromium-mac/media/controls-after-reload-expected.txt:
platform/chromium-mac/media/controls-layout-direction-expected.png:
platform/chromium-mac/media/controls-strict-expected.png:
platform/chromium-mac/media/controls-strict-expected.txt:
platform/chromium-mac/media/controls-styling-expected.png:
platform/chromium-mac/media/controls-styling-expected.txt:
platform/chromium-mac/media/controls-without-preload-expected.png:
platform/chromium-mac/media/controls-without-preload-expected.txt:
platform/chromium-mac/media/media-controls-clone-expected.png:
platform/chromium-mac/media/media-controls-clone-expected.txt:
platform/chromium-mac/media/media-document-audio-repaint-expected.png:
platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
platform/chromium-mac/media/video-controls-rendering-expected.png:
platform/chromium-mac/media/video-controls-rendering-expected.txt:
platform/chromium-mac/media/video-display-toggle-expected.png:
platform/chromium-mac/media/video-display-toggle-expected.txt:
platform/chromium-mac/media/video-empty-source-expected.png:
platform/chromium-mac/media/video-empty-source-expected.txt:
platform/chromium-mac/media/video-no-audio-expected.png:
platform/chromium-mac/media/video-no-audio-expected.txt:
platform/chromium-mac/media/video-playing-and-pause-expected.png:
platform/chromium-mac/media/video-playing-and-pause-expected.txt:
platform/chromium-mac/media/video-zoom-controls-expected.png:
platform/chromium-mac/media/video-zoom-controls-expected.txt:
platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
platform/chromium-win-xp/media/video-empty-source-expected.txt: Removed.
platform/chromium-win/fast/layers/video-layer-expected.png:
platform/chromium-win/fast/layers/video-layer-expected.txt:
platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
platform/chromium-win/media/audio-controls-rendering-expected.png:
platform/chromium-win/media/audio-controls-rendering-expected.txt:
platform/chromium-win/media/audio-repaint-expected.png:
platform/chromium-win/media/audio-repaint-expected.txt:
platform/chromium-win/media/controls-after-reload-expected.png:
platform/chromium-win/media/controls-after-reload-expected.txt:
platform/chromium-win/media/controls-layout-direction-expected.png:
platform/chromium-win/media/controls-strict-expected.png:
platform/chromium-win/media/controls-strict-expected.txt:
platform/chromium-win/media/controls-styling-expected.png:
platform/chromium-win/media/controls-styling-expected.txt:
platform/chromium-win/media/controls-without-preload-expected.png:
platform/chromium-win/media/controls-without-preload-expected.txt:
platform/chromium-win/media/media-controls-clone-expected.png:
platform/chromium-win/media/media-controls-clone-expected.txt:
platform/chromium-win/media/media-document-audio-repaint-expected.png:
platform/chromium-win/media/media-document-audio-repaint-expected.txt:
platform/chromium-win/media/video-controls-rendering-expected.png:
platform/chromium-win/media/video-controls-rendering-expected.txt:
platform/chromium-win/media/video-display-toggle-expected.png:
platform/chromium-win/media/video-display-toggle-expected.txt:
platform/chromium-win/media/video-empty-source-expected.png:
platform/chromium-win/media/video-empty-source-expected.txt:
platform/chromium-win/media/video-no-audio-expected.png:
platform/chromium-win/media/video-no-audio-expected.txt:
platform/chromium-win/media/video-playing-and-pause-expected.png:
platform/chromium-win/media/video-playing-and-pause-expected.txt:
platform/chromium-win/media/video-zoom-controls-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.txt:
platform/chromium/TestExpectations:
platform/win-xp/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/layers/video-layer-expected.txt.
platform/win-xp/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/audio-controls-rendering-expected.txt.
platform/win-xp/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/audio-repaint-expected.txt.
platform/win-xp/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-after-reload-expected.txt.
platform/win-xp/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/win/media/controls-strict-expected.txt.
platform/win-xp/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/win/media/controls-styling-expected.txt.
platform/win-xp/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-without-preload-expected.txt.
platform/win-xp/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/win/media/media-controls-clone-expected.txt.
platform/win-xp/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt.
platform/win-xp/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/video-controls-rendering-expected.txt.
platform/win-xp/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/win/media/video-display-toggle-expected.txt.
platform/win-xp/media/video-empty-source-expected.txt: Renamed from LayoutTests/platform/win/media/video-empty-source-expected.txt.
platform/win-xp/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/win/media/video-no-audio-expected.txt.
platform/win-xp/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/win/media/video-playing-and-pause-expected.txt.
platform/win-xp/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.png.
platform/win-xp/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.txt.

6:29 PM Changeset in webkit [120652] by fischman@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

6:21 PM Changeset in webkit [120651] by atwilson@chromium.org

2 edits in trunk/LayoutTests

Unreviewed chromium expectations update to mark tests as timing out due to r120627.

platform/chromium/TestExpectations:

6:12 PM Changeset in webkit [120650] by commit-queue@webkit.org

2 edits in trunk/Tools

[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=89254

Patch by James Robinson <jamesr@chromium.org> on 2012-06-18
Reviewed by Adrienne Walker.

This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
upstream.

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createGraphicsContext3D):

6:09 PM Changeset in webkit [120649] by Simon Fraser

2 edits in trunk/Tools

Minor fix suggested by Adam Barth.

Use $(this._what).empty(); rather than removing children one at a time.
For some reason removeAllChildren() is undefined on this node.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

6:03 PM Changeset in webkit [120648] by Simon Fraser

7 edits in trunk/Tools

Show TOT revision in garden-o-matic, and make the revisions into links
https://bugs.webkit.org/show_bug.cgi?id=89396

Reviewed by Adam Barth.

The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
where the revisions are links to trac.

To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
the knock-on effect of flipping the target and href attributes for anchors in some test output.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._displayTesters.updateList.list):
(ViewController.prototype._displayTesters.updateList):
(ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForBuildName):
(ViewController.prototype):
(ViewController.prototype.):

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

6:02 PM Changeset in webkit [120647] by atwilson@chromium.org

1 edit
1 move
1 add in trunk/LayoutTests

Unreviewed chromium expectations.

platform/chromium-mac/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
platform/chromium-win/compositing/fixed-position-scroll-offset-history-restore-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png.

5:58 PM Changeset in webkit [120646] by dpranke@chromium.org

2 edits in trunk/Tools

REGRESSION(r100558): NRWT should work without SVN or GIT
https://bugs.webkit.org/show_bug.cgi?id=76630

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-06-18
Reviewed by Dirk Pranke.

NRWT is not supposed to have a requirement that we have an
actual SVN or Git checkout, and we were unnecessarily
initializing the checkout. This patch removes that line :).

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

5:50 PM Changeset in webkit [120645] by commit-queue@webkit.org

21 edits
8 deletes in trunk

Unreviewed, rolling out r120593.
http://trac.webkit.org/changeset/120593
https://bugs.webkit.org/show_bug.cgi?id=89404

Caused failures in fast/forms/file/input-file-entries.html
(Requested by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::createIsolatedFileSystem):

Modules/filesystem/HTMLInputElementFileSystem.cpp: Removed.
Modules/filesystem/HTMLInputElementFileSystem.h: Removed.
Modules/filesystem/HTMLInputElementFileSystem.idl: Removed.
WebCore.gypi:
html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles):

html/FileInputType.h:

(FileInputType):

html/HTMLInputElement.cpp:
html/HTMLInputElement.h:

(HTMLInputElement):

html/InputType.cpp:
html/InputType.h:

(InputType):

platform/DragData.cpp:

(WebCore::DragData::modifierKeyState):
(WebCore):

platform/DragData.h:

(DragData):

platform/chromium/DragDataChromium.cpp:

LayoutTests:

fast/forms/file/input-file-entries-expected.txt: Removed.
fast/forms/file/input-file-entries.html: Removed.
fast/forms/resources/dir1/UTF8-2.txt: Removed.
fast/forms/resources/dir1/UTF8.txt: Removed.
fast/forms/resources/dir2/green.jpg: Removed.
platform/efl/Skipped:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:
platform/wk2/Skipped:

4:54 PM Changeset in webkit [120644] by jamesr@google.com

6 edits
2 adds in trunk/Source

[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
https://bugs.webkit.org/show_bug.cgi?id=89150

Reviewed by Adrienne Walker.

Source/Platform:

Adds a WebImageLayer type to represent layers backed by (guess what) Images.

Platform.gypi:
chromium/public/WebImageLayer.h: Added.

(WebCore):
(WebKit):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::~WebImageLayer):

Source/WebCore:

Uses WebImageLayer instead of ImageLayerChromium for GraphicsLayerChromium::setContentsToImage.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

Source/WebKit/chromium:

Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's
here to be next to the other Web*Layer.cpp implementation files.

WebKit.gyp:
src/WebImageLayer.cpp: Added.

(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):

4:41 PM Changeset in webkit [120643] by jamesr@google.com

11 edits in trunk/Source

[chromium] GraphicsLayerChromium should use WebContentLayer directly
https://bugs.webkit.org/show_bug.cgi?id=89145

Reviewed by Adrienne Walker.

Source/Platform:

Add an opaque rect parameter to WebContentLayerClient::paintContents() for a client to (optionally) provide
information about opaque portions of the painted region for culling optimizations.

chromium/public/WebContentLayerClient.h:

(WebContentLayerClient):

Source/WebCore:

Ports GraphicsLayerChromium (or more specifically OpaqueRectTrackingContentLayerDelegate) to implement
WebContentLayerClient instead of ContentLayerDelegate. In addition to the mechanical changes, this requires
eagerly setting drawsContent on GraphicsLayerChromium::m_layer since WebContentLayerImpl's default value is
different from LayerChromium's. Covered by all of compositing/

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:

(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer):

tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):

tests/WebLayerTest.cpp:

4:35 PM Changeset in webkit [120642] by enrica@apple.com

2 edits in trunk/LayoutTests

Skipping dictation tests on WK2.

Unreviewed.

platform/mac-wk2/Skipped:

4:30 PM Changeset in webkit [120641] by commit-queue@webkit.org

13 edits in trunk

Add from-image to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=85451

Patch by David Barr <davidbarr@chromium.org> on 2012-06-18
Reviewed by Tony Chang.

Source/WebCore:

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution

No new tests; extended fast/css/image-resolution/image-resolution.html

css/CSSParser.cpp: Accept from-image identifier in image-resolution property.

(WebCore::CSSParser::parseImageResolution): Map CSSValueFromImage to identifier value from cssValuePool.

css/CSSValueKeywords.in: Add from-image.
css/StyleBuilder.cpp: Extend ApplyPropertyImageResolution to apply RenderStyle::imageResolutionSource.

(WebCore::ApplyPropertyImageResolution::applyInheritValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyInitialValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyValue): Map CSSValueFromImage to ImageResolutionFromImage.

rendering/RenderImage.cpp: Extend conditions for recalculation of intrinsic size.

(WebCore::RenderImage::styleDidChange): Update intrinsic size if RenderStyle::imageResolutionSource() has changed.

rendering/style/RenderStyle.cpp: Include StyleRareInheritedData::m_imageResolutionSource in style diff.

(WebCore::RenderStyle::diff): Map change in StyleRareInheritedData::m_imageResolutionSource to StyleDifferenceLayout.

rendering/style/RenderStyle.h: Add RenderStyle::imageResolutionSource, RenderStyle::setImageResolutionSource, RenderStyle::initialImageResolutionSource.
rendering/style/RenderStyleConstants.h: Add enum ImageResolutionSource.
rendering/style/StyleRareInheritedData.cpp: Add StyleRareInheritedData::m_imageResolutionSource.

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageResolutionSource to default and copy constructor.
(WebCore::StyleRareInheritedData::operator==): Include m_imageResolutionSource in comparison.

rendering/style/StyleRareInheritedData.h: Add StyleRareInheritedData::m_imageResolutionSource.

(StyleRareInheritedData): Add 1-bit field StyleRareInheritedData::m_imageResolutionSource.

LayoutTests:

fast/css/image-resolution/image-resolution-expected.txt:
fast/css/image-resolution/image-resolution.html:

4:16 PM Changeset in webkit [120640] by jamesr@google.com

4 edits in trunk/Source/WebCore

[chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
https://bugs.webkit.org/show_bug.cgi?id=89376

Reviewed by Adrienne Walker.

In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all
ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium
backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas
wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip
into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter.

platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

4:14 PM Changeset in webkit [120639] by igor.o@sisa.samsung.com

12 edits
8 deletes in trunk

Unreviewed, rolling out r120119.
http://trac.webkit.org/changeset/120119

Multiple regressions on ClusterFuzz

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

rendering/RenderObject.cpp:
rendering/RenderObject.h:

(RenderObject):

LayoutTests:

animations/first-letter-animation-expected.txt: Removed.
animations/first-letter-animation.html: Removed.
animations/first-letter-play-state-expected.txt: Removed.
animations/first-letter-play-state.html: Removed.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
transitions/first-letter-color-transition-expected.txt: Removed.
transitions/first-letter-color-transition.html: Removed.
transitions/first-letter-transition-expected.txt: Removed.
- transitions/first-letter-transition.html: Removed.

4:09 PM Changeset in webkit [120638] by rniwa@webkit.org

3 edits
2 adds in trunk

REGRESSION(r118414): some pages on concursolutions.com doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=89399

Reviewed by Adam Barth.

Source/WebCore:

The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.

Test: fast/html/adjacent-html-context-element.html

html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentHTML):

LayoutTests:

Add a regression test.

fast/html/adjacent-html-context-element-expected.txt: Added.
fast/html/adjacent-html-context-element.html: Added.

4:03 PM Changeset in webkit [120637] by isherman@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox()
Also update existing code to use updateLayoutIgnorePendingStylesheets()
https://bugs.webkit.org/show_bug.cgi?id=89258

Reviewed by James Robinson.

src/WebNode.cpp:

(WebKit::WebNode::isFocusable): Use updateLayoutIgnorePendingStylesheets()
(WebKit::WebNode::hasNonEmptyBoundingBox): Force layout before checking the bounding box

3:37 PM Changeset in webkit [120636] by zmo@google.com

5 edits in trunk/Source/WebCore

Fix framebuffer-object-attachment.html failures
https://bugs.webkit.org/show_bug.cgi?id=89387

Reviewed by Kenneth Russell.

html/canvas/WebGLFramebuffer.cpp: fix detachment behavior with depth/stencil/depth_stencil conflicts

(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):

html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer): move logic to WebGLFramebuffer
(WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto.
(WebCore::WebGLRenderingContext::getParameter): Correct the wrong assumption that it's always checking the drawingbuffer's DEPTH_BITS/STENCIL_BITS

html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

3:17 PM Changeset in webkit [120635] by atwilson@chromium.org

1 edit
1 add in trunk/LayoutTests

Unreviewed expectations update for chromium after r120602.

platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.

3:17 PM Changeset in webkit [120634] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation
https://bugs.webkit.org/show_bug.cgi?id=87766

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-18
Reviewed by James Robinson.

Source/WebCore:

Unit tests:

CCLayerTreeHostTestCheckerboardDoesNotStarveDraws.runMultiThread
CCSchedulerStateMachineTest.TestFailedDrawsWillEventuallyForceADrawAfterTheNextCommit

platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::didDrawIfPossibleCompleted):
(WebCore::CCSchedulerStateMachine::setMaximumNumberOfFailedDrawsBeforeDrawIsForced):
(WebCore):

platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::beginTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::afterTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::animateLayers):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::prepareToDrawOnCCThread):
(WTF::TEST_F):

tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

tests/CCThreadedTest.cpp:

(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):

tests/CCThreadedTest.h:

(WebKitTests::TestHooks::prepareToDrawOnCCThread):

3:16 PM Changeset in webkit [120633] by zandobersek@gmail.com

2 edits in trunk/Tools

[garden-o-matic] Add support for the GTK builders
https://bugs.webkit.org/show_bug.cgi?id=89360

Reviewed by Adam Barth.

Add the 'gtk' platform, essentially a copy of the 'apple' platform since
both get their data from build.webkit.org.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

3:08 PM Changeset in webkit [120632] by rwlbuis@webkit.org

2 edits in trunk

[BlackBerry] Enable LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=89381

Reviewed by Antonio Gomes.

PR 163598

Enable LEGACY_VIEWPORT_ADAPTION.

Source/cmake/OptionsBlackBerry.cmake:

3:08 PM Changeset in webkit [120631] by thakis@chromium.org

6 edits in branches/chromium/1132

Merge 120629 - [chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327

Reviewed by Dimitri Glazkov.

Broken by Sam in r115589 / r115591.

Source/WebCore:

platform/mac/ScrollAnimatorMac.mm:

(WebCore::scrollAnimationEnabledForSystem):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10572004

3:07 PM Changeset in webkit [120630] by abarth@webkit.org

12 edits
4 adds
2 deletes in trunk/LayoutTests

Update baselines after http://trac.webkit.org/changeset/120609.

platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-linux/fast/multicol/progression-reverse-expected.png: Added.
platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-mac-leopard/fast/css/getComputedStyle: Removed.
platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png: Added.
platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-mac/fast/multicol/progression-reverse-expected.png: Added.
platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/fast/multicol/progression-reverse-expected.png: Added.
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

2:48 PM Changeset in webkit [120629] by thakis@chromium.org

6 edits in trunk

[chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327

Reviewed by Dimitri Glazkov.

Broken by Sam in r115589 / r115591.

Source/WebCore:

platform/mac/ScrollAnimatorMac.mm:

(WebCore::scrollAnimationEnabledForSystem):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

2:43 PM Changeset in webkit [120628] by enrica@apple.com

2 edits in trunk/LayoutTests

Updating test results to include flakey cookies tests.

Unreviewed.

platform/mac/TestExpectations:

2:38 PM Changeset in webkit [120627] by commit-queue@webkit.org

41 edits in trunk

Unreviewed, rolling out r120541, r120547, and r120548.
http://trac.webkit.org/changeset/120541
http://trac.webkit.org/changeset/120547
http://trac.webkit.org/changeset/120548
https://bugs.webkit.org/show_bug.cgi?id=89383

This approach doesn't work for WebKit2 (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):

testing/InternalSettings.h:

(InternalSettings):

Tools:

DumpRenderTree/LayoutTestController.cpp:

(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):

DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: