Timeline
Jun 26, 2012:
- 11:37 PM Changeset in webkit [121322] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
- DEPS:
- 11:03 PM Changeset in webkit [121321] by
-
- 3 edits in trunk/Source/WebCore
[Platform] Change implementation of LocaleICU class to support more UDateFormat.
https://bugs.webkit.org/show_bug.cgi?id=89967
Reviewed by Kent Tamura.
This patch changes internal functions of LocaleICU class to process
multiple ICU date time format handles in addition to short date time
format handle.
This patch is a part of implementing input type time. I'll add time
format related ICU date time format handles.
No new tests. This patch doesn't change behavior.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
(WebCore::localizeFormat): Changed to take String parameter.
(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.
- platform/text/LocaleICU.h:
(LocaleICU):
- 10:40 PM Changeset in webkit [121320] by
-
- 2 edits in trunk/Source/WebCore
Return correct value for css variables enabled runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=90040
Reviewed by Dimitri Glazkov.
Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
but not so much for production.
- page/Settings.h:
(WebCore::Settings::cssVariablesEnabled):
- 9:22 PM Changeset in webkit [121319] by
-
- 3 edits2 adds in trunk
DragData::asFilenames should not push same file names to result in Windows.
https://bugs.webkit.org/show_bug.cgi?id=79861
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-06-26
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: platform/win/fast/forms/file/drag-and-drop-files.html
- platform/win/DragDataWin.cpp:
(WebCore::DragData::asFilenames):
LayoutTests:
- platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
- platform/win/fast/forms/file/drag-and-drop-files.html: Added.
- 9:03 PM Changeset in webkit [121318] by
-
- 2 edits in trunk/LayoutTests
Rebaseline after r121286 and r121290.
- editing/deleting/merge-into-empty-block-2-expected.txt:
- 8:49 PM Changeset in webkit [121317] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296
Unreviewed.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png:
- platform/chromium-mac/fast/backgrounds/size/zero-expected.png:
- 8:44 PM Changeset in webkit [121316] by
-
- 6 edits in trunk/Source
Reduced (but did not eliminate) use of "berzerker GC"
https://bugs.webkit.org/show_bug.cgi?id=89237
Reviewed by Gavin Barraclough.
(PART 2)
This part turns off "berzerker GC" and turns on incremental shrinking.
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to
maintain the behavior we used to get from the occasional berzerker GC,
which would run all finalizers and then free or shrink all blocks
synchronously.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always
safe to sweep a zapped block (that's the point of zapping), and it's
sometimes profitable. For example, consider this case: Block A does some
allocation (transitioning Block A from Marked to FreeListed), then GC
happens (transitioning Block A to Zapped), then all objects in Block A
are free, then the incremental sweeper visits Block A. If we skipped
Zapped blocks, we'd skip Block A, even though it would be profitable to
run its destructors and free its memory.
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do
this incrementally.
../WebCore:
Don't ASSERT that RootObject's destructor runs and invalidates all
RuntimeObjects before their destructors run.
We don't guarantee this behavior because some RuntimeObjects may already
be garbage by the time RootObject's destructor runs, in which case
RootObject's weak pointers will be NULL, and RootObject will not call
invalidate() on them.
It's been theoretically possible for this ASSERT to fire for a while now.
This patch makes it fire all the time.
Luckily, we only needed the behavior guarded by this ASSERT for WebKit1
in Safari on Windows (cf. https://bugs.webkit.org/show_bug.cgi?id=61317),
to handle the way WebKit1 would unload plugin DLLs. If this ever becomes
an issue again, we can fix it by (a) not unloading plugin DLLs,
(b) migrating WebKit1 to the WebKit2 JS-plugin binding model, (c) making
the Instance pointer in a RuntimeObject an indirect pointer through
RootObject, or (c) giving RuntimeObject some sort of special way to
access a zombie weak pointer.
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::destroy): ASSERT removed. Anders said so.
- 8:30 PM Changeset in webkit [121315] by
-
- 5 edits12 copies2 adds in trunk/LayoutTests
[Chromium] Rebaseline 4 tests in editing/deleting. Caused by r121303.
Unreviewed.
- platform/chromium-linux-x86/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
- platform/chromium-linux-x86/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
- platform/chromium-linux-x86/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
- platform/chromium-linux-x86/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
- platform/chromium-linux/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
- platform/chromium-linux/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
- platform/chromium-linux/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
- platform/chromium-linux/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
- platform/chromium-win-xp/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
- platform/chromium-win-xp/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
- platform/chromium-win-xp/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
- platform/chromium-win-xp/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
- platform/chromium-win/editing/deleting/delete-br-002-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-004-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-005-expected.txt:
- platform/chromium-win/editing/deleting/delete-br-006-expected.txt:
- 8:02 PM Changeset in webkit [121314] by
-
- 4 edits5 adds in trunk
REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
https://bugs.webkit.org/show_bug.cgi?id=89958
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-06-26
Reviewed by Simon Fraser.
Source/WebCore:
Don't attempt to draw the box shadow as part of the background if the background is
obscured.
Test: fast/box-shadow/image-box-shadow.html
- rendering/RenderImage.cpp:
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore):
- rendering/RenderImage.h:
(RenderImage):
LayoutTests:
- fast/box-shadow/image-box-shadow-expected.html: Added.
- fast/box-shadow/image-box-shadow.html: Added.
- fast/box-shadow/resources/green-alpha.png: Added.
- fast/box-shadow/resources/green.jpg: Added.
- fast/box-shadow/resources/green.png: Added.
- 7:20 PM Changeset in webkit [121313] by
-
- 2 edits in trunk/Source/WebCore
Fix new Wunused-private-field violations that crept in
https://bugs.webkit.org/show_bug.cgi?id=90032
Reviewed by Adam Barth.
- page/Performance.h:
(Performance):
- 7:11 PM Changeset in webkit [121312] by
-
- 12 edits in trunk/Source
Change return type in bandwidth attribute of network information API
https://bugs.webkit.org/show_bug.cgi?id=89959
Reviewed by Adam Barth.
According to network information API spec, bandwidth attribute should return double type.
But, existing implementation has used *long* and *unsigned int* types.
Source/WebCore:
No new tests. Covered by existing tests.
- Modules/networkinfo/NetworkInfo.cpp:
(WebCore::NetworkInfo::NetworkInfo):
- Modules/networkinfo/NetworkInfo.h:
(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(NetworkInfo):
- Modules/networkinfo/NetworkInfoClient.h:
(NetworkInfoClient):
- Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::bandwidth):
- Modules/networkinfo/NetworkInfoConnection.h:
(NetworkInfoConnection):
- testing/Internals.cpp:
(WebCore::Internals::setNetworkInformation):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
- WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::bandwidth):
- WebCoreSupport/NetworkInfoClientEfl.h:
(NetworkInfoClientEfl):
- 6:57 PM Changeset in webkit [121311] by
-
- 2 edits2 adds in trunk
Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=89949
Reviewed by Abhishek Arya.
Added repro case as fast/css/short-inline-style.html.
- css/CSSParser.cpp:
(WebCore::CSSParser::lex):
- 6:49 PM Changeset in webkit [121310] by
-
- 15 edits in trunk/Source
[chromium] Remove WebView::graphicsContext3D getter
https://bugs.webkit.org/show_bug.cgi?id=89916
Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Adrienne Walker.
Source/Platform:
Remove unused getter.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Deletes code supporting compositor context getter.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an
inherently dangerous operation since the compositor context may not be safe to use on the main thread and has
somewhat complicated creation / recreation semantics. A shared context is exposed
(WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the
compositor.
- public/WebView.h:
(WebView):
- src/WebLayerTreeView.cpp:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
(WebViewImpl):
- 6:41 PM Changeset in webkit [121309] by
-
- 3 edits2 adds in trunk
Unexpected element sizes when mixing inline-table with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=89819
Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2012-06-26
Reviewed by Julien Chaffraix.
Source/WebCore:
This change handles box-sizing: border-box property for CSS tables properly.
Test: fast/box-sizing/css-table-with-box-sizing.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
LayoutTests:
- fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
- fast/box-sizing/css-table-with-box-sizing.html: Added.
- 6:38 PM Changeset in webkit [121308] by
-
- 4 edits in trunk/Tools
Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027
Reviewed by Darin Adler.
It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::preciseTime):
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- 6:34 PM Changeset in webkit [121307] by
-
- 6 edits6 adds in trunk
DFG PutByValAlias is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=90026
<rdar://problem/11751830>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
For CSE on normal arrays, we now treat PutByVal as impure. This does not appear to affect
performance by much.
For CSE on typed arrays, we fix PutByValAlias by making GetByVal speculate that the access
is within bounds. This also has the effect of making our out-of-bounds handling consistent
with WebCore.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
LayoutTests:
Reviewed by Gavin Barraclough.
- fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
- fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added.
- fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added.
- fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added.
- fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.
(foo):
(for):
- fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added.
(foo):
- 6:31 PM Changeset in webkit [121306] by
-
- 2 edits in trunk/Source/WebCore
Optimize mappings of simple transforms in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=90034
Reviewed by Dean Jackson.
For transforms that are identity or simple translations, don't
fall off the fast path in RenderGeometryMap; we can just
treat them as offsets.
Improves performance on pages with lots of translateZ(0) elements.
Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
were unused.
No new tests; optimization only, and tested by assertions.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::push):
- 5:41 PM Changeset in webkit [121305] by
-
- 3 edits2 adds in trunk
Touch adjustment does not target shadow DOM elements
https://bugs.webkit.org/show_bug.cgi?id=89556
Source/WebCore:
The position of internal shadow-DOM nodes were not being considered
when determining the snap position when TOUCH_ADJUSTMENT is enabled
for fine tuning the position of synthetic mouse events. This
restriction results in not being able to select the calendar picker
when input type=date, or to clear the search field for input
type=search.
Patch by Kevin Ellis <kevers@chromium.org> on 2012-06-26
Reviewed by Antonio Gomes.
Test: touchadjustment/nested-shadow-node.html
- page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
LayoutTests:
Cannot open calendar picker for input type=date using a touch tap
gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is
enabled, the position of a touch point is snapped to the center of an
element when generating synthetic mouse events. The position of shadow
nodes was not being considered when determining the snap position.
This test verifies that touch adjustment now considers shadow-DOM
when calculating the snap position.
Patch by Kevin Ellis <kevers@chromium.org> on 2012-06-26
Reviewed by Antonio Gomes.
- touchadjustment/nested-shadow-node-expected.txt: Added.
- touchadjustment/nested-shadow-node.html: Added.
- 5:06 PM Changeset in webkit [121304] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Decrease the number of conditional blocks in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=90013
Reviewed by Adam Barth.
Consolidate two Android-specific and accelerated-compositing-specific
conditional blocks into other blocks which serve an identical purpose.
- features.gypi:
- 5:00 PM Changeset in webkit [121303] by
-
- 9 edits in trunk
Stop calling node() and deprecatedEditingOffset() in comparePositions
https://bugs.webkit.org/show_bug.cgi?id=54535
Reviewed by Enrica Casucci.
Source/WebCore:
Replaced deprecatedNode() and deprecatedEditingOffset() by containerNode() and computeOffsetInContainerNode()
in comparePositions().
In addition, fixed a bunch of bugs in DeleteSelectionCommand::handleSpecialCaseBRDelete revealed by this change:
- Use node after position instead of deprecated node in determinig whether start and end positions at a br.
- Don't set m_startsAtEmptyLine true when BR is wrapped in a block element. The only reason this code had worked
was positions like (div, offset, 0) and (br, before) in <div><br> were treated differently, which we no longer do.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
- editing/htmlediting.cpp:
(WebCore::comparePositions):
LayoutTests:
Rebaselined existing tests. There are no user-visible changes.
- editing/inseting/font-size-clears-from-typing-style-expected.txt: No longer keeps div's around
when merging paragraphs.
- platform/mac/editing/deleting/delete-br-002-expected.txt:
- platform/mac/editing/deleting/delete-br-004-expected.txt:
- platform/mac/editing/deleting/delete-br-005-expected.txt:
- platform/mac/editing/deleting/delete-br-006-expected.txt:
- 4:54 PM Changeset in webkit [121302] by
-
- 3 edits in trunk/Tools
Teach the Apple port how to build the test tools in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=89540
Reviewed by Jon Lee & Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive (RunUnitTests.start): ditto
- Scripts/build-webkit: add tools to the projects build list
- 4:43 PM Changeset in webkit [121301] by
-
- 4 edits in trunk/Tools
Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90025
Reviewed by Simon Fraser.
Move the chromium-specific filtering code into config.js and replace it with a method on each platform
config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- 4:39 PM Changeset in webkit [121300] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
https://bugs.webkit.org/show_bug.cgi?id=89976
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-26
Reviewed by Antonio Gomes.
Rewrite EFL implementation of Filesystem listDirectory() in order to
use eina_file_ls() instead of POSIX C functions. This results in
shorter code.
No new tests, behavior has not changed.
- platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory):
- 4:34 PM Changeset in webkit [121299] by
-
- 7 edits2 adds in trunk
Crash at WebCore::TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=89526
<rdar://problem/10305315>
Patch by Alice Cheng <alice_cheng@apple.com> on 2012-06-26
Reviewed by Darin Adler.
Source/WebCore:
The range used for marking becomes invalid after SpellingCorrectionCommand, due to changes in the DOM made by ReplaceSelectionCommand.
This invalid range caused marking to be incorrect, and Mail.app to crash when iterating through the invalid range. To fix this,
recalculate the range for marking after SpellingCorrectionCommand.
Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
- editing/Editor.cpp: (WebCore::Editor::markAndReplaceFor):
- testing/Internals.cpp:
(WebCore):
(WebCore::Internals::hasAutocorrectedMarker):
- testing/Internals.h: (Internals):
- testing/Internals.idl:
LayoutTests:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.
- 4:32 PM Changeset in webkit [121298] by
-
- 3 edits1 delete in trunk/LayoutTests
Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=90024
Reviewed by Ojan Vafai.
Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.
- editing/inserting/font-size-clears-from-typing-style-expected.txt:
- editing/inserting/font-size-clears-from-typing-style.html:
- editing/inserting/script-tests: Removed.
- editing/inserting/script-tests/TEMPLATE.html: Removed.
- editing/inserting/script-tests/font-size-clears-from-typing-style.js: Removed.
- 4:18 PM Changeset in webkit [121297] by
-
- 8 edits5 adds in trunk
[chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.
https://bugs.webkit.org/show_bug.cgi?id=89906
Reviewed by Nate Chapin.
This patch treats mixed CachedRawResources as affecting the display of insecure content.
Source/WebCore:
Tests: http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html
http/tests/security/mixedContent/insecure-xhr-in-main-frame.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkInsecureContent):
LayoutTests:
- http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-xhr-in-main-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 4:08 PM Changeset in webkit [121296] by
-
- 10 edits2 adds in trunk
background-size:0 shows as 1px instead of invisible
https://bugs.webkit.org/show_bug.cgi?id=86942
Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Eric Seidel.
As per the specification http://www.w3.org/TR/css3-background/#background-size, if the background image's width or height resolves to zero,
this causes the image not to be displayed. The effect should be the same as if it had been a transparent image.
This is also mentioned in http://www.w3.org/TR/2002/WD-css3-background-20020802/#background-size.
Source/WebCore:
Test: fast/backgrounds/zero-background-size.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
LayoutTests:
- fast/backgrounds/size/zero.html:
- fast/backgrounds/zero-background-size-expected.html: Added.
- fast/backgrounds/zero-background-size.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/fast/backgrounds/size/zero-expected.png:
- platform/mac/fast/backgrounds/size/zero-expected.txt:
- platform/qt/TestExpectations:
- 4:02 PM Changeset in webkit [121295] by
-
- 3 edits in trunk/Source/WebCore
[v8] Clean up generated Dictionary-handling code
https://bugs.webkit.org/show_bug.cgi?id=89994
Reviewed by Adam Barth.
No change in behavior, so no new tests.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):
- 4:00 PM Changeset in webkit [121294] by
-
- 4 edits in trunk/Tools
Fix failing garden-o-matic unittests
https://bugs.webkit.org/show_bug.cgi?id=90021
Reviewed by Adam Barth.
These had all just fallen out of date.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
- 4:00 PM Changeset in webkit [121293] by
-
- 2 edits in trunk/Source/WebCore
Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set
https://bugs.webkit.org/show_bug.cgi?id=89997
Patch by Raymond Toy <Raymond Toy> on 2012-06-26
Reviewed by Eric Seidel.
No new tests needed for a compile issue
- Modules/webaudio/AudioNode.cpp: Include stdio.h
- 3:51 PM Changeset in webkit [121292] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Use premultiplied alpha when extracting image data in WebGL
https://bugs.webkit.org/show_bug.cgi?id=89937
Reviewed by Jocelyn Turcotte.
Perform conversion in QImage only if the image format is not ARGB32 or
ARGB32_Premultiplied. Otherwise, allow packPixels to perform the conversion if the formats
don't match, as packPixels already performs pixel-specific operations.
Covered by tests in LayoutTests/fast/canvas/webgl, e.g. webgl-composite-modes.html.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
- 3:07 PM Exposing WebKit internals for Layout Tests edited by
- (diff)
- 3:05 PM Exposing WebKit internals for Layout Tests edited by
- (diff)
- 3:04 PM Exposing WebKit internals for Layout Tests created by
- Added instructions (still needs formatting)
- 3:04 PM Changeset in webkit [121291] by
-
- 13 edits in trunk/Source/WebCore
IndexedDB: Move method precondition checks to front end objects
https://bugs.webkit.org/show_bug.cgi?id=89377
Reviewed by Tony Chang.
Now that metadata exists on the front end, most of the pre-condition validation checks
done on IDB method calls from script can be moved to the front end which simplifies the
code significantly in the case of complex methods like IDBObjectStore::put().
Adds an internal "active" flag for transactions, although the behavior is not accurate
to the spec (it should only be true during event callbacks - http://webkit.org/b/89379).
The back-end methods can then be simplifed to just adding async tasks to the transaction,
and the front end methods can take care of all exception cases except for asynchronous
transaction abort which still requires plumbing back to the front end.
No functional changes - no new tests.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Migrate from IDBObjectStoreBackendImpl::put.
(WebCore::IDBCursor::advance): Add more explicit transaction-is-active check.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto.
(WebCore::IDBCursor::effectiveObjectStore): Convenience function (source may be store or index).
(WebCore):
- Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::isKeyCursor): Distinguish from IDBCursorWithValue.
(IDBCursor):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update): Remove migrated check.
- Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
- Modules/indexeddb/IDBDatabase.cpp: Migrate checks.
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Replace checks with assertions.
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
- Modules/indexeddb/IDBIndex.cpp: Add transaction-is-active checks.
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBObjectStore.cpp: Migrate cehcks.
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add): Delegates to put(PutMode)
(WebCore::IDBObjectStore::put): Delegates to put(PutMode)
(WebCore): Adds put(PutMode) which has the unified checks migrated from
IDBObjectStoreBackendImpl::put.
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
- Modules/indexeddb/IDBObjectStore.h: Adds put(PutMode).
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal): Fix trace symbol.
(WebCore::IDBObjectStoreBackendImpl::put): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::deleteIndex): Remove migrated checks.
- Modules/indexeddb/IDBTransaction.cpp: Add active flag tracking.
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
- Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isActive):
(WebCore::IDBTransaction::isReadOnly): Group IDL/non-IDL methods.
(IDBTransaction):
- 3:03 PM WikiStart edited by
- (diff)
- 2:46 PM Changeset in webkit [121290] by
-
- 2 edits in trunk/LayoutTests
Fix a test after r121286.
- editing/deleting/merge-into-empty-block-2.html:
- 2:35 PM Changeset in webkit [121289] by
-
- 23 edits6 deletes in trunk
Unreviewed, rolling out r121285.
http://trac.webkit.org/changeset/121285
https://bugs.webkit.org/show_bug.cgi?id=90014
"We misinterpreted 'size of the initial containing block'"
(Requested by tomz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
Source/WebCore:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
- css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
- css/CSSToStyleMap.h:
(CSSToStyleMap):
- css/MediaQueryEvaluator.cpp:
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(StyleResolver):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
LayoutTests:
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Removed.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Removed.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Removed.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Removed.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Removed.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Removed.
- ietestcenter/css3/valuesandunits/units-000.htm:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:30 PM Changeset in webkit [121288] by
-
- 20 edits2 adds in trunk/Source
[chromium] Expose rendering statistics to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=88268
Patch by Dave Tu <dtu@chromium.org> on 2012-06-26
Reviewed by James Robinson.
The WebKit side of a basic framework for exposing rendering statistics
to Chromium's --enable-benchmarking extension.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebRenderingStatistics):
(WebKit):
(WebLayerTreeView):
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::implFrameNumber):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::implFrameNumber):
(WebCore):
(WebCore::CCThreadProxy::implFrameNumberOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStatistics):
(WebKit):
- 2:21 PM Changeset in webkit [121287] by
-
- 3 edits in trunk/Tools
Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
The old code never worked. This is hard to test because change handlers require
a user-initiated action and the code is changing the window's location, which would
navigate the test page.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
due to the large margin-bottom.
- 2:06 PM Changeset in webkit [121286] by
-
- 5 edits4 adds44 deletes in trunk/LayoutTests
Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries-001.html, merge-into-empty-block-1.html and merge-into-empty-block-2.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=90011
Reviewed by Eric Seidel.
- editing/deleting/delete-3959464-fix-expected.txt: Added.
- editing/deleting/delete-3959464-fix.html:
- editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
- editing/deleting/delete-at-paragraph-boundaries-001.html:
- editing/deleting/merge-into-empty-block-1-expected.txt: Added.
- editing/deleting/merge-into-empty-block-1.html:
- editing/deleting/merge-into-empty-block-2-expected.txt: Added.
- editing/deleting/merge-into-empty-block-2.html:
- platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/chromium-linux/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/chromium-linux/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/chromium-mac-leopard/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt: Removed.
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
- platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
- platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
- platform/gtk/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/gtk/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
- platform/gtk/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/gtk/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
- platform/mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
- platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
- platform/mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
- platform/mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
- platform/qt/editing/deleting/delete-3959464-fix-expected.png: Removed.
- platform/qt/editing/deleting/delete-3959464-fix-expected.txt: Removed.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
- platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
- platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
- platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
- platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
- 1:23 PM Changeset in webkit [121285] by
-
- 23 edits6 adds in trunk
ietestcenter/css3/valuesandunits/units-000.htm asserts
https://bugs.webkit.org/show_bug.cgi?id=86176
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-06-26
Reviewed by Beth Dakin.
Source/WebCore:
Modified computeLengthDouble() to handle vh, vw, and vmin units. Per the spec
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) viewport -percentage
lengths are "relative to the size of the initial containing block", which I read to be
the size of the parent element. Since parentStyle was not available in computeLengthDouble,
most of the changes for this patch involved "pushing down" the parentStyle pointer through
the network of computeLength methods and dependencies.
Tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html
css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html
css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
- css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::parentStyle):
(WebCore):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
- css/CSSToStyleMap.h:
(CSSToStyleMap):
- css/MediaQueryEvaluator.cpp:
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(WebCore::StyleResolver::parentNode):
(StyleResolver):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
LayoutTests:
Adding explicit tests for viewport border length tests. Inspired by IE Test center
units-000 test which highlighted that vw, vh, and vmin were not being handled in computeLengthDouble().
Also, adjusting test_expectations and Skipped for units-000, which no longer Asserts with this
patch implemented.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Added.
- ietestcenter/css3/valuesandunits/units-000.htm:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 1:17 PM Changeset in webkit [121284] by
-
- 11 edits2 copies in trunk/Source
[chromium] Add WebLayer API for scrolling
https://bugs.webkit.org/show_bug.cgi?id=89913
Reviewed by Adrienne Walker.
Source/Platform:
Adds WebScrollableLayer type to represent a layer that can be scrolled by the user. Currently WebContentLayers
are scrollable and no other layer types are, although this might change in the future.
- chromium/public/WebContentLayer.h:
(WebKit::WebContentLayer::WebContentLayer):
- chromium/public/WebLayer.h:
(WebLayer):
- chromium/public/WebScrollableLayer.h:
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
Source/WebCore:
Use new WebScrollableLayer type in ScrollingCoordinatorChromium. This file peeks "under the hood" a fair amount
since we don't have WebLayer API for scrollbar layers yet.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
Source/WebKit/chromium:
Use WebScrollableLayer type in NonCompositedContentHost.
- WebKit.gyp:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::reserveScrollbarLayers):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::haveScrollLayer):
(WebKit):
(WebKit::NonCompositedContentHost::scrollLayer):
- src/NonCompositedContentHost.h:
(WebCore):
- src/WebContentLayer.cpp:
(WebKit::WebContentLayer::WebContentLayer):
- src/WebLayer.cpp:
(WebKit::WebLayer::numberOfChildren):
(WebKit):
(WebKit::WebLayer::childAt):
(WebKit::WebLayer::setAlwaysReserveTextures):
- src/WebScrollableLayer.cpp:
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
- 1:09 PM Changeset in webkit [121283] by
-
- 5 edits in trunk
Unreviewed, rolling out r120501.
http://trac.webkit.org/changeset/120501
https://bugs.webkit.org/show_bug.cgi?id=89126
[skia] Fix is too heavy-handed
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::drawNeedsCopy):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::isDeferred):
(WebCore::PlatformContextSkia::setDeferred):
- 12:55 PM Changeset in webkit [121282] by
-
- 2 edits in trunk/Source/JavaScriptCore
[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779
Patch by Yong Li <yoli@rim.com> on 2012-06-26
Reviewed by Rob Buis.
Fix non-JIT build on BlackBerry broken by r121196.
- runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):
- 12:52 PM Changeset in webkit [121281] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add WebPage interface for Async spell check.
https://bugs.webkit.org/show_bug.cgi?id=89999
Reviewed by Rob Buis.
PR 124517.
Add interface for IMS async spell checking.
Reviewed Internally by Nima Ghanavatian.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(WebKit):
- Api/WebPage.h:
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 12:42 PM Changeset in webkit [121280] by
-
- 15 edits15 adds in trunk
DFG::operationNewArray is unnecessarily slow, and may use the wrong array
prototype when inlined
https://bugs.webkit.org/show_bug.cgi?id=89821
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Fixes all array allocations to use the right structure, and hence the right prototype. Adds
inlining of new Array(...) with a non-zero number of arguments. Optimizes allocations of
empty arrays.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSArray.h:
(JSC):
(JSC::constructArray):
- runtime/JSGlobalObject.h:
(JSC):
(JSC::constructArray):
LayoutTests:
Rubber stamped by Geoffrey Garen.
- fast/js/dfg-cross-global-object-inline-new-array-expected.txt: Added.
- fast/js/dfg-cross-global-object-inline-new-array-literal-expected.txt: Added.
- fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Added.
- fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Added.
- fast/js/dfg-cross-global-object-inline-new-array-literal.html: Added.
- fast/js/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Added.
- fast/js/dfg-cross-global-object-inline-new-array-with-elements.html: Added.
- fast/js/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Added.
- fast/js/dfg-cross-global-object-inline-new-array-with-size.html: Added.
- fast/js/dfg-cross-global-object-inline-new-array.html: Added.
- fast/js/script-tests/cross-global-object-inline-global-var.js:
(done):
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Added.
(foo):
(done):
(doit):
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Added.
(foo):
(done):
(doit):
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Added.
(foo):
(done):
(doit):
- fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Added.
(foo):
(done):
(doit):
- fast/js/script-tests/dfg-cross-global-object-inline-new-array.js: Added.
(foo):
(done):
(doit):
- 12:40 PM Changeset in webkit [121279] by
-
- 3 edits in trunk/Source/WebCore
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676
Unreviewed typo fix, pointed out by Darin Adler.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
- 12:36 PM Changeset in webkit [121278] by
-
- 4 edits in trunk
MutationObserver.observe should treat a null or undefined options argument as empty
https://bugs.webkit.org/show_bug.cgi?id=89992
Reviewed by Ojan Vafai.
Source/WebCore:
The WebIDL spec was recently updated to treat null or undefined
Dictionary arguments the same as the empty dictionary. This patch
updates MutationObserver.observe to follow that spec.
Note that we still throw a SYNTAX_ERR in this case, since it's an
error not to pass one of "attributes", "childList", or "characterData"
as a key in the dictionary.
- dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
LayoutTests:
- fast/mutation/observe-exceptions-expected.txt:
- 12:34 PM Changeset in webkit [121277] by
-
- 5 edits1 delete in trunk/Source
[chromium] The single thread proxy should not automatically tick new animations.
https://bugs.webkit.org/show_bug.cgi?id=89996
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.
Source/WebCore:
No new tests. No change to existing functionality.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCSingleThreadProxyTest.cpp: Removed.
- 12:21 PM Changeset in webkit [121276] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark a layout test as timeout
https://bugs.webkit.org/show_bug.cgi?id=90003
fast/js/repeat-cached-vm-reentry.html started timing out on Mac debug and Win debug builds
between r121233:121239.
- platform/chromium/TestExpectations:
- 12:16 PM Changeset in webkit [121275] by
-
- 4 edits6 adds in trunk
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676
Reviewed by Abhishek Arya.
Source/WebCore:
Tests: fast/table/auto-table-layout-colgroup-removal-crash.html
fast/table/fixed-table-layout/colgroup-removal-crash.html
fast/table/fixed-table-layout/prepend-in-fixed-table.html
The issue comes from RenderTable not properly dirtying its preferred logical
widths. As the table layout codes (both fixed and auto), recomputes their internal
structures at computePreferredLogicalWidth, the internal structure doesn't match
the table sizing and we crash.
This fix adds a work-around in FixedTableLayout::layout (which matches AutoTableLayout).
The long-term fix would be to properly fix the logic but this is a lot safer, especially
since our logic is really not bullet-proof at the moment.
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
Added an internal structure recomputation, if we have drifted from our table's structure.
Also we need to update nEffCols if we call calcWidthArray.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
Added a comment matching FixedTableLayout. The nEffCols is unneeded but kept for consistency
with FixedTableLayout.
LayoutTests:
- fast/table/auto-table-layout-colgroup-removal-crash-expected.txt: Added.
- fast/table/auto-table-layout-colgroup-removal-crash.html: Added.
- fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt: Added.
- fast/table/fixed-table-layout/colgroup-removal-crash.html: Added.
2 cases where we remove a colgroup after having done layout.
- fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt: Added.
- fast/table/fixed-table-layout/prepend-in-fixed-table.html: Added.
This is a copy of fast/table/prepend-in-anonymous-table.html modified to work with
fixed table layout. This covers a bug found during testing that is fixed as part of
this broader change.
- 11:58 AM Changeset in webkit [121274] by
-
- 1 edit4 copies in branches/chromium/1180
Merge 120934 - Non-fixed length margins don't work with align=center
https://bugs.webkit.org/show_bug.cgi?id=89626
Reviewed by Levi Weintraub.
Source/WebCore:
Tests: fast/block/negative-start-margin-align-center-percent.html
fast/block/positive-margin-block-child-align-center-calc.html
Calling Length::value() is a bad idea as it returns the *raw* value of
the length. For percent and calculated length this is a bad idea as they
bear not relation to the actual computed length.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeInlineDirectionMargins):
Fixed the code to use minimumValueForLength as this nicely takes care of the 'auto' case.
LayoutTests:
- fast/block/negative-start-margin-align-center-percent-expected.html: Added.
- fast/block/negative-start-margin-align-center-percent.html: Added.
- fast/block/positive-margin-block-child-align-center-calc-expected.html: Added.
- fast/block/positive-margin-block-child-align-center-calc.html: Added.
TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10668050
- 11:42 AM Changeset in webkit [121273] by
-
- 4 edits in trunk/Source
[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.
Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.
Source/WebCore:
Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 11:39 AM Changeset in webkit [121272] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark a layout test as fail
https://bugs.webkit.org/show_bug.cgi?id=89998
compositing/webgl/webgl-nonpremultiplied-blend.html started failing after r121267, give it IMAGE failure.
- platform/chromium/TestExpectations:
- 11:38 AM Changeset in webkit [121271] by
-
- 2 edits in trunk/Source/WebCore
On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982
Reviewed by Darin Adler.
Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
behave consistently.
Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor().
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
- 11:34 AM Changeset in webkit [121270] by
-
- 2 edits in trunk/Source/WebCore
Do early-return when author and user styles are disabled.
https://bugs.webkit.org/show_bug.cgi?id=89947
Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):
- 11:27 AM Changeset in webkit [121269] by
-
- 5 edits in trunk/Tools
webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Eric Seidel.
webkit-patch patches-to-review will now output the list of
bugs with patches pending for review that has the user on CC,
excluding patches with cq-, sorted by the age of the patch.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_from_review_queue):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_from_review_queue):
(MockBugzilla.init):
(MockBugzilla.authenticate):
- Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview._print_report):
(PatchesToReview._generate_report):
(PatchesToReview.execute):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_patches_to_review):
- 11:09 AM Changeset in webkit [121268] by
-
- 8 edits in trunk/Source
[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=89933
Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Kenneth Russell.
Source/WebCore:
GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
Since the compositor doesn't use GC3D any more, these are no longer needed.
- platform/chromium/support/Extensions3DChromium.cpp:
- platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
- platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DPrivate::grContext):
- platform/chromium/support/GraphicsContext3DPrivate.h:
(WebCore):
(GraphicsContext3DPrivate):
- platform/graphics/chromium/Extensions3DChromium.h:
Source/WebKit/chromium:
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- 10:56 AM Changeset in webkit [121267] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=89797
Patch by Yasuhiro Matsuda <mazda@chromium.org> on 2012-06-26
Reviewed by James Robinson.
No new tests. This patch doesn't change behavior.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):
- 10:48 AM WebKitGTK/1.8.x edited by
- (diff)
- 10:01 AM Changeset in webkit [121266] by
-
- 3 edits in trunk/Tools
nrwt: broken for chromium on vista
https://bugs.webkit.org/show_bug.cgi?id=89988
Reviewed by Tony Chang.
r121194 removed support for 'chromium-win-vista' as a separate
port, but this actually prevented the code from running on vista
at all, which is unduly harsh and broke the websocket tests on
the (non-webkit) chromium bots that are still running on vista.
It's probably good enough to pretend that vista is win7 instead;
some layout tests will still fail but at least things'll run.
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.determine_full_port_name):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):
- 9:30 AM Changeset in webkit [121265] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Native memory snapshots crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=89977
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):
- 9:20 AM Changeset in webkit [121264] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931
Reviewed by James Robinson.
WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
#ifdef or #if have different behavior. There are some places in
the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should
actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those
#ifdef statements.
- public/WebTextRun.h:
(WebTextRun):
- public/linux/WebFontRenderStyle.h:
- 8:00 AM Changeset in webkit [121263] by
-
- 2 edits in trunk/Tools
master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215
We need it because it is deprecated and will be dropped in buildbot 0.8.7
Reviewed by Tony Chang.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.init):
(Factory.init):
- 7:39 AM Changeset in webkit [121262] by
-
- 2 edits12 adds in trunk/LayoutTests
[Qt] Baseline missing for 3D transforms tests.
https://bugs.webkit.org/show_bug.cgi?id=89973
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.
Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
Add missing baselines for all unskipped 3D transforms tests.
- platform/qt/Skipped:
- platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
- platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
- platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
- 7:01 AM Changeset in webkit [121261] by
-
- 4 edits1 add in trunk
[Qt][Win] Symbols are not exported in QtWebKit5.dll
https://bugs.webkit.org/show_bug.cgi?id=88873
Reviewed by Tor Arne Vestbø.
Source/WebKit:
- api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.
Tools:
When linking the target dll make sure to re-export the symbols from
the static libraries marked as export, with the help of a little python
script and a qmake extra compiler.
- Scripts/generate-win32-export-forwards: Added.
- qmake/mkspecs/features/win32/default_post.prf:
- 6:09 AM Changeset in webkit [121260] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=89924
"bytesPerLine == targetRect.width() / 4" is invalid.
This patch amended it into "bytesPerLine == targetRect.width() * 4".
Moreover, changed magic number 4 to bytesPerPixel.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-26
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 6:07 AM Changeset in webkit [121259] by
-
- 4 edits in trunk/Source/WebCore
Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-26
Reviewed by Noam Rosenthal.
Defined a new member that says what type of output code must be generated
(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):
- platform/graphics/ANGLEWebKitBridge.h:
(ANGLEWebKitBridge):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 5:56 AM Changeset in webkit [121258] by
-
- 3 edits2 adds in trunk
Fix bug where animations failed to start
https://bugs.webkit.org/show_bug.cgi?id=89943
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The unpause code previously checked that the animations had not started
before un-setting the pause state. This meant that if an animation was
paused and unpaused before the animations started, it would remain in the
paused state. This patch simply reorders the unpause logic to fix this bug.
Test: svg/custom/animate-initial-pause-unpause.html
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::resume):
LayoutTests:
- svg/custom/animate-initial-pause-unpause-expected.txt: Added.
- svg/custom/animate-initial-pause-unpause.html: Added.
- 5:49 AM Changeset in webkit [121257] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening of new passing tests
https://bugs.webkit.org/show_bug.cgi?id=89970
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
- platform/efl/TestExpectations:
- 5:32 AM Changeset in webkit [121256] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955
Reviewed by Vsevolod Vlasov.
Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
- 5:17 AM Changeset in webkit [121255] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Limit session storage quota to 5MB by default
https://bugs.webkit.org/show_bug.cgi?id=89941
Patch by Jonathan Dong <Jonathan Dong> on 2012-06-26
Reviewed by Rob Buis.
Limit session storage quota to 5MB by default for BlackBerry
porting.
Internally reviewed by George Staikos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::sessionStorageQuota):
(BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
- Api/WebSettings.h:
- 5:10 AM Changeset in webkit [121254] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-26
Reviewed by Csaba Osztrogonác.
Simplify the implementation of SharedBuffer::createWithContentsOfFile()
in EFL port.
No new test, no behavior change.
- platform/efl/SharedBufferEfl.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
- 4:27 AM Changeset in webkit [121253] by
-
- 2 edits in trunk/Source/WebCore
[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=89964
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Andreas Kling.
Added missing null pointer check.
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
- 3:36 AM Changeset in webkit [121252] by
-
- 2 edits in trunk/LayoutTests
[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89647
Unreviewed, update GTK test expectations.
r121215 has fixed the assertion failure, so the test doesn't crash
anymore.
Patch by Simon Pena <Simon Pena> on 2012-06-26
- platform/gtk/TestExpectations:
- 3:26 AM Changeset in webkit [121251] by
-
- 7 edits2 adds in trunk
Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/filesystem/get-metadata.html
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
- inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.Entry.prototype.get isDirectory):
(WebInspector.FileSystemModel.Entry.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._directoryContentReceived):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.directoryContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):
LayoutTests:
- http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.writeFile):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest):
(writeFile.didGetFileSystem):
(writeFile):
(writeFile.didGetWriter.writer.onwrite):
(writeFile.didGetWriter):
- http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
- http/tests/inspector/filesystem/get-metadata.html: Added.
- 3:19 AM Changeset in webkit [121250] by
-
- 2 edits in trunk/Source/WebCore
[Qt] GraphicsSurface: Fix tile update artifacts on Mac
https://bugs.webkit.org/show_bug.cgi?id=89887
Reviewed by Noam Rosenthal.
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformCopyToGLTexture):
- 3:17 AM Changeset in webkit [121249] by
-
- 2 edits in trunk/Source/WebCore
GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
https://bugs.webkit.org/show_bug.cgi?id=89883
Reviewed by Noam Rosenthal.
Follow the documentation which says: "If locking the buffer requires a readback,
the lock will fail with an error return of kIOReturnCannotLock."
Also make sure that we use the same set of flags when locking and unlocking
for simplicity and to follow this requirement on the kIOSurfaceLockReadOnly flag.
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
- 3:16 AM Changeset in webkit [121248] by
-
- 2 edits in trunk/Tools
Add a note about hostname completion not working well with --cc completion
Reviewed by Simon Hausmann.
Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.
- Scripts/webkit-tools-completion.sh:
- 3:11 AM Changeset in webkit [121247] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r121244.
http://trac.webkit.org/changeset/121244
https://bugs.webkit.org/show_bug.cgi?id=89966
skip list path is incorrect now. (Requested by Ossy on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
- 3:06 AM Changeset in webkit [121246] by
-
- 3 edits2 adds in trunk
Fix setCurrentTime for paused animations
https://bugs.webkit.org/show_bug.cgi?id=81350
Reviewed by Nikolas Zimmermann.
Source/WebCore:
SMILTimeContainer::setElapsed was not resetting the pause time, breaking
setCurrentTime if the animation was paused.
Test: svg/custom/animate-pause-resume.html
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
LayoutTests:
This test does not use the SVG animation test framework because the framework
works by pausing animations and testing animated values at fixed times
(through calling setCurrentTime). Testing this patch requires that we run
the animation and cannot be tested with the animation test framework.
- svg/custom/animate-pause-resume-expected.txt: Added.
- svg/custom/animate-pause-resume.html: Added.
- 3:04 AM Changeset in webkit [121245] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
https://bugs.webkit.org/show_bug.cgi?id=89960
Reviewed by Antonio Gomes.
We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
in a page, even though only the one in fullscreen mode will process this.
With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
which is either a plugin, or an Video element.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
- 2:42 AM Changeset in webkit [121244] by
-
- 3 edits in trunk/Tools
[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882
Patch by János Badics <János Badics> on 2012-06-26
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):
- 2:22 AM Changeset in webkit [121243] by
-
- 2 edits in trunk/Source/JavaScriptCore
New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=89953
Reviewed by Zoltan Herczeg.
DFG 32-bit JIT was confused about the difference between a predicted type and a
proven type. This is easy to get confused about, since a local that is predicted int32
almost always means that the local must be an int32 since speculations are hoisted to
stores to locals. But that is less likely to be the case for arguments, where there is
an additional least-upper-bounding step: any store to an argument with a weird type
may force the argument to be any type.
This patch basically duplicates the functionality in DFGSpeculativeJIT64.cpp for
GetLocal: the decision of whether to load a local as an int32 (or as an array, or as
a boolean) is made based on the AbstractValue::m_type, which is a type proof, rather
than the VariableAccessData::prediction(), which is a predicted type.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:21 AM Changeset in webkit [121242] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed typo fix after r121144.
- Target.pri:
- 2:11 AM Changeset in webkit [121241] by
-
- 8 edits in trunk
[Qt] Enable grid layout LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=89909
Reviewed by Csaba Osztrogonác.
Source/WebKit/qt:
These tests pass, we just need to hook up the overridePreference.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
- Api/qwebsettings.h: Add enum value for CSS grid layout
Tools:
These tests pass, we just need to hook up the overridePreference.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
LayoutTests:
- platform/qt/Skipped: Enable fast/css-grid-layout tests.
- 2:04 AM Changeset in webkit [121240] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: columns in heap snapshot summary view are not resizable
https://bugs.webkit.org/show_bug.cgi?id=89952
Reviewed by Vsevolod Vlasov.
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): overriden method
should call overriden one to make sure column resizers are added to the DataGrid.
- 1:25 AM Changeset in webkit [121239] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r121236.
http://trac.webkit.org/changeset/121236
https://bugs.webkit.org/show_bug.cgi?id=89956
It's broke the nrwt on qt and gtk platform (Requested by
kkristof on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):
- 12:59 AM Changeset in webkit [121238] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening after r120845.
Update expectations for test crashing in the GTK 64bit debug bot.
- platform/gtk/TestExpectations: Add test to CRASHING section.
- 12:59 AM Changeset in webkit [121237] by
-
- 2 edits in trunk/Source/WebKit/chromium
Allow using <input type="color"> UI in ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=89944
Patch by Jun Mukai <mukai@chromium.org> on 2012-06-26
Reviewed by Kent Tamura.
http://crrev.com/144111 adds the UI of <input type="color"> for
ChromeOS, so now we can set its flag too.
- features.gypi:
- 12:55 AM Changeset in webkit [121236] by
-
- 3 edits in trunk/Tools
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.init):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):
- 12:55 AM Changeset in webkit [121235] by
-
- 4 edits in trunk/Source/WebCore
Refactoring: Simplify FormController interface
https://bugs.webkit.org/show_bug.cgi?id=89951
Reviewed by Kentaro Hara.
- Remove FormController::hasStateForNewFormElements() takeStateForFormElement() can check the emptiness, and return an empty FormControlState.
- Change the argument of takeStateForFormElement() Passing just one HTMLFormControlElementWithState object instead of two AtomicStringImpl. This is a preparation to use HTMLFormControlElementWithState::form() in FormController.
No new tests. Just a refactoring.
- html/FormController.cpp:
(WebCore::FormController::takeStateForFormElement):
- html/FormController.h:
(FormController):
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- 12:41 AM Changeset in webkit [121234] by
-
- 11 edits in trunk
WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104
Reviewed by Kentaro Hara.
Source/WebCore:
The spec for WheelEvent is
<http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent>
Tests: fast/events/event-creation.html
- bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
- bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
- dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor
(WebCore::WheelEvent::isMouseEvent): Existing callers use this just for
moves and clicks, ie the type is exactly MouseEvent.
- dom/WheelEvent.h: Extend MouseEvent
- dom/WheelEvent.idl: "
LayoutTests:
- fast/events/event-creation-expected.txt:
- fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event
- 12:24 AM Changeset in webkit [121233] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=89948
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-26
Reviewed by Martin Robinson.
Properly initialize didInitializeState in
TextChecker::state().
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::state):
Jun 25, 2012:
- 11:29 PM Changeset in webkit [121232] by
-
- 14 edits in trunk/Source
Get rid of firstItem and nextItem from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=89923
Reviewed by Andreas Kling.
Source/WebCore:
Removed HTMLCollection::firstItem and HTMLCollection::nextItem.
Also added hasAnyItem() and hasExactlyOneItem() to HTMLCollection so that named getter on Document
doesn't need to compute the full length before returning a HTMLCollection.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
- dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
- html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore):
(WebCore::HTMLCollection::item):
- html/HTMLCollection.h:
(HTMLCollection):
(WebCore::HTMLCollection::hasAnyItem):
(WebCore::HTMLCollection::hasExactlyOneItem):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
Source/WebKit/chromium:
Re-implement WebNodeCollection::firstItem() and WebNodeCollection::nextItem() in WebKit code
because we got rid of it from WebCore implementation.
This is an extremely poor API and we shouldn't be exposing it in the future.
- public/WebNodeCollection.h:
(WebKit::WebNodeCollection::WebNodeCollection):
(WebNodeCollection):
- src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::nextItem):
(WebKit::WebNodeCollection::firstItem):
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::collectTargetFrames):
- 11:05 PM Changeset in webkit [121231] by
-
- 2 edits in trunk/Source/WebCore
JavaScript resources have low priority when SVG is enabled
https://bugs.webkit.org/show_bug.cgi?id=89932
<rdar://problem/11741325>
Reviewed by Adele Peterson.
r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set
the correct priority for scripts. Also, move the code so that all ifdefs are together at the
bottom to make it a bit easier to read..
- loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
- 10:32 PM Changeset in webkit [121230] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed build fix: Don't do QT += widgets with Qt 4
Source/WebKit:
- WebKit1.pro: This is already done in WebKit1.pri.
Source/WebKit/qt:
- examples/platformplugin/platformplugin.pro:
- 10:23 PM Changeset in webkit [121229] by
-
- 30 edits2 adds in trunk
Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag).
https://bugs.webkit.org/show_bug.cgi?id=89542
Reviewed by Dimitri Glazkov.
Source/WebCore:
Added fast/css/variables/build-supports-variables.html to test runtime flag in test environment.
Updated all other css variables tests to enable the runtime flag from JS.
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::cssVariablesEnabled):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
- css/CSSParser.h:
(CSSParser):
- css/CSSParserMode.h:
(CSSParserContext):
- page/Settings.h:
(Settings):
(WebCore::Settings::setCSSVariablesEnabled):
(WebCore::Settings::cssVariablesEnabled):
Source/WebKit/chromium:
- features.gypi:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- 9:47 PM Changeset in webkit [121228] by
-
- 12 edits3 adds in trunk
[Qt] Make it possible to build WebKit without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=78109
Reviewed by Tor Arne Vestbø.
.:
- Source/QtWebKit.pro: Don't build WK1 tests and examples if WK1 is disabled.
- Source/api.pri: Move WK1 sources away from here and use WEBKIT += webkit1 instead
- WebKit.pro: Add WK1 to SUBDIRS unless no_webkit1 is set.
Source/WebKit:
Moved WebKit1 sources into a separate static library. Only WK1
depends on QtWidgets.
- WebKit1.pri: Added.
- WebKit1.pro: Added.
Source/WebKit2:
- WebKit2.pri: Add missing WK2 specific dependencies.
- qt/MainQt.cpp: Do the QStyle initialization hook only if we are
compiling with QtWidgets support.
(WebKit):
(main):
Tools:
- Tools.pro: Disable various tools that depend on WK1.
- qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
- qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
- qmake/mkspecs/modules/webkit1.prf: Added.
- 9:43 PM Changeset in webkit [121227] by
-
- 2 edits2 adds in trunk/Source/WebKit/chromium
[chromium] Add WebPluginScrollbar and WebPluginScrollbarClient stub implementations
https://bugs.webkit.org/show_bug.cgi?id=89928
Reviewed by Darin Fisher.
These classes are just typedef'd to be the non-Plugin version. The
next step is to change Chromium to use the Plugin version, then move
most of WebPluginScrollbar to a WebScrollbar in Platform to separate
out the base functionality, while providing the same top level API.
- WebKit.gyp:
- public/WebPluginScrollbar.h: Added.
(WebKit):
- public/WebPluginScrollbarClient.h: Added.
(WebKit):
- 9:41 PM Changeset in webkit [121226] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r121223.
Fix the --minimal Qt build, TextureMapperGL now requires WebGL to be enabled.
- Target.pri:
- WebCore.pri:
- 9:31 PM Changeset in webkit [121225] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fill more data in device motion event
https://bugs.webkit.org/show_bug.cgi?id=89857
Reviewed by Antonio Gomes.
Reviewed internally by Robin Cao.
Fill acceleration and rotation rate into DeviceMotionData.
- WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
(DeviceMotionClientBlackBerry::onMotion):
- 9:14 PM Changeset in webkit [121224] by
-
- 2 edits in trunk/Source/WebCore
[chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels
https://bugs.webkit.org/show_bug.cgi?id=89922
Reviewed by Adrienne Walker.
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
- 8:59 PM Changeset in webkit [121223] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Remove platform specific code in BitmapImageGL::updateContents by using
GraphicsContext3D::extractImageData.
https://bugs.webkit.org/show_bug.cgi?id=89867
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
- 8:46 PM Changeset in webkit [121222] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Include unistd.h in PlatformProcessIdentifier.h.
https://bugs.webkit.org/show_bug.cgi?id=89804
Reviewed by Hajime Morita.
The pid_t typedef ends up coming from stdlib.h (indirectly via WTF
includes) on Mac and Linux, even though that is not mandated by
POSIX and breaks other platforms (such as FreeBSD). Fix that by
explicitly including unistd.h, which is where the typedef is
supposed to come from.
- Platform/PlatformProcessIdentifier.h:
- 8:41 PM Changeset in webkit [121221] by
-
- 21 edits8 moves1 add in trunk/Source/WebKit2
[WK2][Qt][EFL] Extract common code from LayerTreeHostQt
https://bugs.webkit.org/show_bug.cgi?id=89837
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-06-25
Reviewed by Noam Rosenthal.
Extract common code from LayerTreeHostQt to be used by both Qt and Efl.
I renamed LayerTreeHost to LayerTreeCoordinator, and these are moved under WebProcess/WebPage/LayerTreeCoordinator.
I Modified LayerTreeHostProxy to LayerTreeCoordinatorProxy too, Because LayerTreeHostProxy and LayerTreeHost were pair.
Also WebGraphicsLayer moved under that directory.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Platform/CoreIPC/MessageID.h:
- Target.pri:
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didReceiveLayerTreeCoordinatorProxyMessage):
- UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeCoordinatorProxy):
(DrawingAreaProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeCoordinatorProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.h:
(WebKit):
(DrawingAreaProxyImpl):
- UIProcess/LayerTreeCoordinatorProxy.cpp: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp.
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::~LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::updateViewport):
(WebKit::LayerTreeCoordinatorProxy::dispatchUpdate):
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerState):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerChildren):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerFilters):
(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):
(WebKit::LayerTreeCoordinatorProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeCoordinatorProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeCoordinatorProxy::setContentsSize):
(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
(WebKit::LayerTreeCoordinatorProxy::renderNextFrame):
(WebKit::LayerTreeCoordinatorProxy::didChangeScrollPosition):
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
- UIProcess/LayerTreeCoordinatorProxy.h: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.
(WebKit):
(LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::layerTreeRenderer):
- UIProcess/LayerTreeCoordinatorProxy.messages.in: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.messages.in.
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
- UIProcess/WebLayerTreeRenderer.h:
(WebKit):
(WebLayerTreeRenderer):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
- WebKit2.pri:
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveLayerTreeCoordinatorMessage):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp.
(WebKit):
(WebKit::LayerTreeCoordinator::create):
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeCoordinator::scheduleLayerFlush):
(WebKit::LayerTreeCoordinator::cancelPendingLayerFlush):
(WebKit::LayerTreeCoordinator::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::setRootCompositingLayer):
(WebKit::LayerTreeCoordinator::invalidate):
(WebKit::LayerTreeCoordinator::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeCoordinator::scrollNonCompositedContents):
(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::sizeDidChange):
(WebKit::LayerTreeCoordinator::didInstallPageOverlay):
(WebKit::LayerTreeCoordinator::didUninstallPageOverlay):
(WebKit::LayerTreeCoordinator::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeCoordinator::setPageOverlayOpacity):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::syncLayerState):
(WebKit::LayerTreeCoordinator::syncLayerChildren):
(WebKit::LayerTreeCoordinator::syncCanvas):
(WebKit::LayerTreeCoordinator::syncLayerFilters):
(WebKit::LayerTreeCoordinator::attachLayer):
(WebKit::LayerTreeCoordinator::detachLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeCoordinator::syncFixedLayers):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::layerFlushTimerFired):
(WebKit::LayerTreeCoordinator::createPageOverlayLayer):
(WebKit::LayerTreeCoordinator::destroyPageOverlayLayer):
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
(WebKit::LayerTreeCoordinator::notifyAnimationStarted):
(WebKit::LayerTreeCoordinator::notifySyncRequired):
(WebKit::LayerTreeCoordinator::paintContents):
(WebKit::LayerTreeCoordinator::showDebugBorders):
(WebKit::LayerTreeCoordinator::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::visibleContentsRect):
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):
(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::layerTreeTileUpdatesAllowed):
(WebKit::LayerTreeCoordinator::purgeBackingStores):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
- WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h: Renamed from Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h.
(WebKit):
(LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::layerTreeContext):
(WebKit::LayerTreeCoordinator::pageOverlayShouldApplyFadeWhenPainting):
(WebKit::LayerTreeCoordinator::pauseRendering):
(WebKit::LayerTreeCoordinator::resumeRendering):
(WebKit::LayerTreeCoordinator::deviceScaleFactorDidChange):
- WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.messages.in: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeHost.messages.in.
- WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp.
(WebCore):
(WebCore::layerByIDMap):
(WebCore::WebGraphicsLayer::layerByID):
(WebCore::toWebLayerID):
(WebCore::WebGraphicsLayer::didChangeLayerState):
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore::WebGraphicsLayer::didChangeFilters):
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::willBeDestroyed):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setMasksToBounds):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setBackfaceVisibility):
(WebCore::WebGraphicsLayer::setOpacity):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToCanvas):
(WebCore::WebGraphicsLayer::setFilters):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::id):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::toWebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncChildren):
(WebCore::WebGraphicsLayer::syncFilters):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::syncCanvas):
(WebCore::WebGraphicsLayer::ensureImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::effectiveContentsScale):
(WebCore::WebGraphicsLayer::adjustContentsScale):
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::shouldUseTiledBackingStore):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
(WebCore::createWebGraphicsLayer):
(WebCore::WebGraphicsLayer::initFactory):
(WebCore::WebGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):
- WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h.
(WebCore):
(WebKit):
(WebGraphicsLayerClient):
(WebGraphicsLayer):
(WebCore::WebGraphicsLayer::image):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebCore::WebGraphicsLayer::maskTarget):
(WebCore::WebGraphicsLayer::setMaskTarget):
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- 8:37 PM Changeset in webkit [121220] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Remove uncalled ManagedTexture::framebufferTexture2D
https://bugs.webkit.org/show_bug.cgi?id=89930
Patch by James Robinson <jamesr@chromium.org> on 2012-06-25
Reviewed by Adrienne Walker.
Removing dead code.
- platform/graphics/chromium/ManagedTexture.cpp:
- platform/graphics/chromium/ManagedTexture.h:
(ManagedTexture):
- 8:28 PM Changeset in webkit [121219] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
- DEPS:
- 7:53 PM Changeset in webkit [121218] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSC should try to make profiling deterministic because otherwise reproducing failures is
nearly impossible
https://bugs.webkit.org/show_bug.cgi?id=89940
Rubber stamped by Gavin Barraclough.
This rolls out the part of http://trac.webkit.org/changeset/121215 that introduced randomness
into the system. Now, instead of randomizing the tier-up threshold, we always set it to an
artificially low (and statically predetermined!) value. This gives most of the benefit of
threshold randomization without actually making the system behave completely differently on
each invocation.
- bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
- runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- 7:52 PM Changeset in webkit [121217] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r121206.
http://trac.webkit.org/changeset/121206
https://bugs.webkit.org/show_bug.cgi?id=89935
[chromium] webkit_unit_tests
WebViewTest.MHTMLWithMissingResourceFinishesLoading crash
(Requested by ukai on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
Source/WebCore:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
Source/WebKit/chromium:
- tests/EventListenerTest.cpp:
- tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
- tests/FrameTestHelpers.h:
(FrameTestHelpers):
- tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
- tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
- tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):
- 7:28 PM Changeset in webkit [121216] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update chromium test expectations.
- platform/chromium/TestExpectations:
- 7:14 PM Changeset in webkit [121215] by
-
- 17 edits3 adds in trunk
Value profiling should use tier-up threshold randomization to get more coverage
https://bugs.webkit.org/show_bug.cgi?id=89802
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
This patch causes both LLInt and Baseline JIT code to take the OSR slow path several
times before actually doing OSR. If we take the OSR slow path before the execution
count threshold is reached, then we just call CodeBlock::updateAllPredictions() to
compute the current latest least-upper-bound SpecType of all values seen in each
ValueProfile.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(CodeBlock):
(JSC::CodeBlock::updateAllPredictions):
- bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::status):
(JSC):
- bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::count):
(ExecutionCounter):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::weakRandomInteger):
- runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
- runtime/Options.h:
(Options):
- runtime/WeakRandom.h:
(WeakRandom):
(JSC::WeakRandom::seedUnsafe):
LayoutTests:
Reviewed by Gavin Barraclough.
- fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Added.
- fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Added.
- fast/js/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Added.
(foo):
- 7:02 PM Changeset in webkit [121214] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
per platform executes on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89914
Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2012-06-25
Reviewed by James Robinson.
No new tests. (HW video decode is still only being tested manually for orientation)
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
- 6:59 PM Changeset in webkit [121213] by
-
- 6 edits1 add in trunk/Source/WebKit/chromium
[Chromium] Let the embedder override the max page scale factor set by the page
https://bugs.webkit.org/show_bug.cgi?id=89406
Reviewed by James Robinson.
Chrome on Android has an option to force the web site to allow page
scaling (for accessibility). This patch adds
WebView::setIgnoreViewportTagMaximumScale, which instructs the WebView
to ignore the maximum scale factor supplied by by the page in the
viewport meta tag.
This patch is a bit different from how this is implemented on the
chromium-android branch, but I'll clean up the branch once this patch
lands.
- public/WebView.h:
(WebView):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIgnoreViewportTagMaximumScale):
(WebKit):
- src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::ignoreViewportTagMaximumScale):
- tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):
- 6:57 PM Changeset in webkit [121212] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r121176.
http://trac.webkit.org/changeset/121176
https://bugs.webkit.org/show_bug.cgi?id=89934
[chromium] browser_tests assert failed:
FATAL:native_theme_win.cc(1541)] Check failed: false. Invalid
part: 16 (Requested by ukai on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
Source/Platform:
- chromium/public/win/WebThemeEngine.h:
(WebKit::WebThemeEngine::paintProgressBar):
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
- 6:49 PM Changeset in webkit [121211] by
-
- 3 edits2 adds in trunk
[Shadow] Deleting list distributed to Shadow DOM does not work correctly.
https://bugs.webkit.org/show_bug.cgi?id=89170
Reviewed by Ryosuke Niwa.
Source/WebCore:
When deleting several elements distributed to Shadow DOM, some renderers might be gone in
processing deletion. To fix them, we should call isContentEditable() instead of rendererIsEditable().
Test: editing/shadow/delete-list-in-shadow.html
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
LayoutTests:
- editing/shadow/delete-list-in-shadow-expected.txt: Added.
- editing/shadow/delete-list-in-shadow.html: Added.
- 6:34 PM Changeset in webkit [121210] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Fix the css stylesheet for android media controls after recent changes
https://bugs.webkit.org/show_bug.cgi?id=89910
Patch by Min Qin <qinmin@chromium.org> on 2012-06-25
Reviewed by Adam Barth.
After the recent changes on upstream chrome video controls, we need to change the css style sheet for chrome on android.
No tests needed, just css changes.
- css/mediaControlsChromiumAndroid.css:
(audio):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(::-webkit-media-controls):
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-fullscreen-button):
(input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-media-slider-thumb):
(audio::-webkit-media-controls-fullscreen-button):
- 6:30 PM Changeset in webkit [121209] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid a deep copy of QImage in GraphicsContext3D::getImageData.
https://bugs.webkit.org/show_bug.cgi?id=89865
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
- 6:26 PM Changeset in webkit [121208] by
-
- 3 edits in trunk/Source/WebCore
Reduce memory footprint of BitmapImage Vectors.
https://bugs.webkit.org/show_bug.cgi?id=86563
Patch by Nick Carter <nick@chromium.org> on 2012-06-25
Reviewed by Simon Fraser.
No new tests, affects template params only.
- platform/graphics/BitmapImage.h:
(BitmapImage): use an inline capacity of 1 for the image frame Vector
- platform/image-decoders/ImageDecoder.h:
(ImageDecoder): use an inline capacity of 1 for the image frame Vector
- 6:20 PM Changeset in webkit [121207] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r121145.
http://trac.webkit.org/changeset/121145
https://bugs.webkit.org/show_bug.cgi?id=89847
Had an objection for the change.
Source/WebCore:
- html/FormController.cpp:
(WebCore):
(WebCore::FormControlState::serializeTo):
(WebCore::FormControlState::deserialize):
(WebCore::formStateSignature):
(WebCore::FormController::formElementsState):
(WebCore::FormController::setStateForNewFormElements):
- html/FormController.h:
(FormControlState):
- html/shadow/CalendarPickerElement.cpp:
(WebCore::addJavaScriptString):
Source/WTF:
- wtf/text/StringBuilder.h:
LayoutTests:
- fast/forms/state-restore-broken-state-expected.txt:
- fast/forms/state-restore-various-values-expected.txt: Removed.
- fast/forms/state-restore-various-values.html: Removed.
- 6:12 PM Changeset in webkit [121206] by
-
- 9 edits in trunk/Source
Fix progress load reporting for MHTML documents.
MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859
Reviewed by Nate Chapin.
Source/WebCore:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
Source/WebKit/chromium:
- tests/EventListenerTest.cpp:
- tests/FrameTestHelpers.cpp:
(FrameTestHelpers):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
- tests/FrameTestHelpers.h:
(FrameTestHelpers):
- tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
- tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
- tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):
(TestWebViewClient):
(WebKit::TestWebViewClient::TestWebViewClient):
(WebKit::TestWebViewClient::didStartLoading):
(WebKit::TestWebViewClient::didStopLoading):
(WebKit::TestWebViewClient::didChangeLoadProgress):
(WebKit::TestWebViewClient::loadingStarted):
(WebKit::TestWebViewClient::loadingStopped):
(WebKit::TestWebViewClient::loadProgress):
(WebKit):
- 5:56 PM Changeset in webkit [121205] by
-
- 3 edits in trunk/Tools
put vista back for chromium (non-webkit) bots ...
https://bugs.webkit.org/show_bug.cgi?id=89929
Unreviewed, build fix.
Turns out we've only gotten rid of vista on the webkit tests so
far. Put vista back for the other chromium bots ...
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(chromiumPlatform):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- 5:55 PM Changeset in webkit [121204] by
-
- 53 edits2 deletes in trunk/Source
[chromium] Use WebGraphicsContext3D in compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=89700
Reviewed by Adrienne Walker.
Source/Platform:
Puts all callback destructors in protected section and removes obsolete memory callback signature.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
Source/WebCore:
This converts the compositor implementation from using WebCore::GraphicsContext3D to using the Platform-provided
WebGraphicsContext3D. This removes several unnecessary layers of indirection/wrapping and cuts down the
compositor's implementation dependencies. GraphicsContext3D.h is still widely used to provide GL enum values.
Most of the changes are purely mechanical - changing type names and the like.
Ownership is changed a bit. Instead of multiple components holding references to the compositor's context, the
context is now owned by the CCGraphicsContext, which is now owned directly by CCLayerTreeHostImpl.
CCLayerTreeHostImpl also has ownership of its CCRenderer (LayerRendererChromium in 3D mode) and passes a
non-owning pointer down to the CCRenderer.
Extension checking is a bit different. The compositor does not (and never has) used extensions provided by
WebGL's request/ensure mechanism. It simply checks for the existence of extensions it needs in the GL_EXTENSIONS
string.
FrameBufferSkPictureCanvasLayerTextureUpdater had to be patched as well, since it was grabbing a GrContext off
of the compositor's GraphicsContext3D. This caused many problems. It was inefficient, since it required a full
state flush when switching between ganesh and compositor calls. The gpu memory management was completely broken
since the compositor clobbered ganesh's onMemoryAllocationChanged callback. This moves FBSkPCLTU over to using
the appropriate SharedGraphicsContext3D, like filters.
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
(FrameBufferSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/GeometryBinding.cpp:
(WebCore::GeometryBinding::GeometryBinding):
- platform/graphics/chromium/GeometryBinding.h:
(WebKit):
(GeometryBinding):
(WebCore::GeometryBinding::context):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::context):
(WebCore::LayerRendererChromium::debugGLCall):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::onMemoryAllocationChanged):
(WebCore):
(WebCore::LayerRendererChromium::onMemoryAllocationChangedOnImplThread):
(WebCore::LayerRendererChromium::discardFramebuffer):
(WebCore::LayerRendererChromium::ensureFramebuffer):
(WebCore::LayerRendererChromium::onContextLost):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::isContextLost):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebKit):
(WebCore):
(LayerRendererChromium):
(WebCore::LayerRendererChromium::isFramebufferDiscarded):
- platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/PlatformColor.h:
(WebCore::PlatformColor::bestTextureFormat):
- platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::contextLost):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
- platform/graphics/chromium/ProgramBinding.h:
(WebKit):
(ProgramBindingBase):
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):
- platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderCheckerboard::init):
- platform/graphics/chromium/ShaderChromium.h:
(WebKit):
(VertexShaderPosTex):
(VertexShaderPosTexYUVStretch):
(VertexShaderPos):
(WebCore::VertexShaderPosTexIdentity::init):
(VertexShaderPosTexTransform):
(VertexShaderQuad):
(VertexShaderTile):
(VertexShaderVideoTransform):
(FragmentTexAlphaBinding):
(FragmentTexOpaqueBinding):
(FragmentShaderOESImageExternal):
(FragmentShaderRGBATexAlphaAA):
(FragmentTexClampAlphaAABinding):
(FragmentShaderRGBATexAlphaMask):
(FragmentShaderRGBATexAlphaMaskAA):
(FragmentShaderYUVVideo):
(FragmentShaderColor):
(FragmentShaderCheckerboard):
- platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::~AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
- platform/graphics/chromium/TextureCopier.h:
(WebKit):
(WebCore):
(WebCore::AcceleratedTextureCopier::create):
(AcceleratedTextureCopier):
- platform/graphics/chromium/TextureManager.h:
- platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::Query::Query):
(WebCore::ThrottledTextureUploader::Query::~Query):
(WebCore::ThrottledTextureUploader::Query::begin):
(WebCore::ThrottledTextureUploader::Query::end):
(WebCore::ThrottledTextureUploader::Query::isPending):
(WebCore::ThrottledTextureUploader::Query::wait):
(WebCore::ThrottledTextureUploader::ThrottledTextureUploader):
- platform/graphics/chromium/ThrottledTextureUploader.h:
(WebKit):
(WebCore::ThrottledTextureUploader::create):
(WebCore::ThrottledTextureUploader::Query::create):
(Query):
(ThrottledTextureUploader):
- platform/graphics/chromium/TrackingTextureAllocator.cpp:
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
(WebCore::TrackingTextureAllocator::deleteAllTextures):
- platform/graphics/chromium/TrackingTextureAllocator.h:
(WebKit):
(WebCore::TrackingTextureAllocator::create):
(TrackingTextureAllocator):
- platform/graphics/chromium/cc/CCGraphicsContext.h:
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createContext):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
(LayerRendererCapabilities):
(WebCore::CCLayerTreeHost::needsSharedContext):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
Source/WebKit/chromium:
Updates tests for refactor, mostly by removing unnecessary GraphicsContext3D wrapper around mock contexts.
- WebKit.gypi:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::context):
- src/WebLayerTreeViewImpl.cpp:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
- tests/CCSingleThreadProxyTest.cpp:
- tests/CCThreadedTest.cpp:
(WebKitTests::TestHooks::createContext):
- tests/CCThreadedTest.h:
(TestHooks):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/CompositorFakeGraphicsContext3D.h: Removed.
- tests/DrawingBufferChromiumTest.cpp: Removed.
- tests/FakeCCLayerTreeHostClient.h:
- tests/FakeGraphicsContext3DTest.cpp:
(TEST):
- tests/GraphicsLayerChromiumTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST_F):
(TEST):
- tests/TextureCopierTest.cpp:
- tests/ThrottledTextureUploaderTest.cpp:
(WebKit::TEST):
- tests/TiledLayerChromiumTest.cpp:
- 5:43 PM Changeset in webkit [121203] by
-
- 4 edits in trunk
[Lion WK2] fast/loader/reload-zero-byte-plugin.html hits assert
https://bugs.webkit.org/show_bug.cgi?id=89611
<rdar://problem/11714023>
Reviewed by Sam Weinig.
Source/WebKit2:
Make sure to send the response along to the plug-in in the case where the stream was empty.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::finishedLoading):
LayoutTests:
Remove the test from the Skipped list.
- platform/mac-wk2/Skipped:
- 5:31 PM Changeset in webkit [121202] by
-
- 1 edit160 deletes in trunk/LayoutTests
remove chromium vista baselines
https://bugs.webkit.org/show_bug.cgi?id=89927
Unreviewed, expectations change.
Now that we no longer run tests on Vista, no need for the
baselines either.
- platform/chromium-win-vista/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
- platform/chromium-win-vista/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Removed.
- platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
- platform/chromium-win-vista/compositing/overflow/theme-affects-visual-overflow-expected.txt: Removed.
- platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
- platform/chromium-win-vista/css1/font_properties/font-expected.txt: Removed.
- platform/chromium-win-vista/css1/text_properties/line_height-expected.txt: Removed.
- platform/chromium-win-vista/css1/units/percentage_units-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t040103-ident-03-c-expected.png: Removed.
- platform/chromium-win-vista/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Removed.
- platform/chromium-win-vista/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/html/css3-modsel-32-expected.txt: Removed.
- platform/chromium-win-vista/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
- platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
- platform/chromium-win-vista/editing/inserting/4959067-expected.txt: Removed.
- platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Removed.
- platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Removed.
- platform/chromium-win-vista/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
- platform/chromium-win-vista/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
- platform/chromium-win-vista/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
- platform/chromium-win-vista/fast/block/positioning/trailing-space-test-expected.png: Removed.
- platform/chromium-win-vista/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
- platform/chromium-win-vista/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
- platform/chromium-win-vista/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
- platform/chromium-win-vista/fast/canvas/webgl/context-lost-expected.txt: Removed.
- platform/chromium-win-vista/fast/compact/001-expected.png: Removed.
- platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png: Removed.
- platform/chromium-win-vista/fast/css/text-rendering-expected.png: Removed.
- platform/chromium-win-vista/fast/css/text-rendering-expected.txt: Removed.
- platform/chromium-win-vista/fast/css/zoom-body-scroll-expected.txt: Removed.
- platform/chromium-win-vista/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- platform/chromium-win-vista/fast/dom/HTMLProgressElement/progress-element-expected.txt: Removed.
- platform/chromium-win-vista/fast/forms/select-writing-direction-natural-expected.txt: Removed.
- platform/chromium-win-vista/fast/inline-block/002-expected.png: Removed.
- platform/chromium-win-vista/fast/inline/002-expected.png: Removed.
- platform/chromium-win-vista/fast/js/large-expressions-expected.txt: Removed.
- platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Removed.
- platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Removed.
- platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
- platform/chromium-win-vista/fast/parser/style-script-head-test-expected.png: Removed.
- platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Removed.
- platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Removed.
- platform/chromium-win-vista/fast/replaced/image-tag-expected.png: Removed.
- platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Removed.
- platform/chromium-win-vista/fast/table/tableInsideCaption-expected.png: Removed.
- platform/chromium-win-vista/fast/text/atsui-kerning-and-ligatures-expected.png: Removed.
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Removed.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
- platform/chromium-win-vista/fast/text/international/bidi-neutral-run-expected.png: Removed.
- platform/chromium-win-vista/fast/text/international/danda-space-expected.png: Removed.
- platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Removed.
- platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/chromium-win-vista/fast/text/selection-rect-rounding-expected.txt: Removed.
- platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
- platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
- platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Removed.
- platform/chromium-win-vista/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
- platform/chromium-win-vista/fast/writing-mode/broken-ideographic-font-expected.txt: Removed.
- platform/chromium-win-vista/fast/writing-mode/english-lr-text-expected.png: Removed.
- platform/chromium-win-vista/http/tests/misc/acid2-expected.txt: Removed.
- platform/chromium-win-vista/http/tests/misc/acid2-pixel-expected.png: Removed.
- platform/chromium-win-vista/platform/chromium/compositing/layout-width-change-expected.png: Removed.
- platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
- platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
- platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
- platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.txt: Removed.
- platform/chromium-win-vista/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
- platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Removed.
- platform/chromium-win-vista/svg/css/shadow-changes-expected.png: Removed.
- platform/chromium-win-vista/svg/custom/bug45331-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
- platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
- platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
- platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/use-clipped-hit-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
- platform/chromium-win-vista/svg/custom/use-modify-target-symbol-expected.txt: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Removed.
- platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/big-sized-filter-2-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/feComposite-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/feMerge-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
- platform/chromium-win-vista/svg/filters/subRegion-in-userSpace-expected.png: Removed.
- platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
- platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
- platform/chromium-win-vista/svg/text/bidi-text-query-expected.png: Removed.
- platform/chromium-win-vista/svg/text/bidi-text-query-expected.txt: Removed.
- platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt: Removed.
- platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
- platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Removed.
- platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
- platform/chromium-win-vista/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Removed.
- platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug120107-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug1271-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug13169-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug196870-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla/marvin/tables_align_center-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png: Removed.
- platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
- platform/chromium-win-vista/transforms/2d/hindi-rotated-expected.png: Removed.
- platform/chromium-win-vista/transforms/2d/hindi-rotated-expected.txt: Removed.
- 5:29 PM Changeset in webkit [121201] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Make CCThreadProxy not draw a frame mid-commit
https://bugs.webkit.org/show_bug.cgi?id=89905
Reviewed by James Robinson.
If commitComplete is not called before the next frame goes up, then
then the max scroll position on the root scroll layer is not updated.
This causes the compositor-side scrollbar to have an incorrect
visibleSize, causing the thumbRect to become stretched, relative to
when it was originally painted.
CCScheduler::setVisible has the side effect of kicking off a frame, so
move it last.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionCommit):
- 5:18 PM Changeset in webkit [121200] by
-
- 3 edits in trunk/Tools
update flakiness dashboard after removing chromium-vista bots
https://bugs.webkit.org/show_bug.cgi?id=89925
Unreviewed, build fix.
More changes missed in r121194 :(.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(chromiumPlatform):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- 5:17 PM Changeset in webkit [121199] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 5:15 PM Changeset in webkit [121198] by
-
- 1 copy in tags/Safari-536.24
New Tag.
- 5:11 PM Changeset in webkit [121197] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Add a chromium-webkit API to create a serializable file system.
https://bugs.webkit.org/show_bug.cgi?id=89776
In order to send a DOMFileSystem as part of WebIntent payload data it
should be serializable. Therefore, I added an API that allows us to
create serializable file system in chromium code.
Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-06-25
Reviewed by Adam Barth.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 5:08 PM Changeset in webkit [121196] by
-
- 7 edits in trunk/Source
[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779
Patch by Yong Li <yoli@rim.com> on 2012-06-25
Reviewed by Rob Buis.
Source/JavaScriptCore:
Add MemoryStatistics.cpp into build, and fill JITBytes for BlackBerry port.
- PlatformBlackBerry.cmake:
- runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):
Source/WebKit/blackberry:
Add detailed JS memory statistics to about:memory page.
- WebCoreSupport/AboutData.cpp:
(WebCore::dumpJSCTypeCountSetToTableHTML):
(WebCore):
(WebCore::memoryPage):
Source/WTF:
Turn on WTF_USE_EXPORT_MACROS for BlackBerry port.
This will make macros like JS_EXPORT_PRIVATE work without
extra porting.
- wtf/Platform.h:
- 4:59 PM Changeset in webkit [121195] by
-
- 3 edits2 adds in trunk
EventSource: Events should not be dispatched after close()
https://bugs.webkit.org/show_bug.cgi?id=85346
Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-25
Reviewed by Adam Barth.
Source/WebCore:
Spec changed to make sure that no events are dispatched after close() is
called, even if more data was received before the call to close().
See,
https://www.w3.org/Bugs/Public/show_bug.cgi?id=14331#c5
http://html5.org/tools/web-apps-tracker?from=6771&to=6772
Firefox behaves like this already.
Test: http/tests/eventsource/eventsource-events-after-close.html
- page/EventSource.cpp:
(WebCore::EventSource::parseEventStream):
LayoutTests:
- http/tests/eventsource/eventsource-events-after-close-expected.txt: Added.
- http/tests/eventsource/eventsource-events-after-close.html: Added.
- 4:53 PM Changeset in webkit [121194] by
-
- 15 edits in trunk
remove support for chromium vista from tools
https://bugs.webkit.org/show_bug.cgi?id=89915
Reviewed by Tony Chang.
Tools:
This change is all deleting code and updating tests to handle
the configuration being gone. All tests now pass except for a
few unittests for the flakiness dashboard which were failing
before this patch.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_complex_shadowing):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):
(ChromiumWinTest.test_baseline_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(BuildCoverageExtrapolatorTest.test_extrapolate):
LayoutTests:
- platform/chromium/TestExpectations:
- 4:28 PM Changeset in webkit [121193] by
-
- 5 edits in trunk/LayoutTests
Unreviewed. Build fix.
Rebaseline layout test expectations from r121179.
- platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
- 4:15 PM Changeset in webkit [121192] by
-
- 3 edits in trunk/Source/WebCore
Fixing compilation failure in StyleResolver.cpp/CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=89892
Patch by Mike West <mkwst@chromium.com> on 2012-06-25
Reviewed by Alexis Menard.
Adding CSSPropertyVariable to switch statements in CSSParser and
StyleResolver to fix compilation errors under ninja/clang. I've
added both as new cases to the switches, with FIXME comments for
implementation.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 4:03 PM Changeset in webkit [121191] by
-
- 5 edits in trunk/Source/WebCore
Fix for a memory leak with MHTMLArchives.
MHTML files present a flat list of frames and resources but the WebKit Archive
has a tree strcture. So the MHTMLArchive class make sures that every frame
knows about any other frames and resources.
Because these objects are ref counted, that would introduce circular references
preventing the entire Archive from being deleted.
This fixes this by:
- making sure the top-frame (which appears as the first entry in the MHTML) is not referenced by the other frames.
- when the main frame is deleted it traverse the entire subarchive (sub-frames) graph and makes sure they clear all their references to other subarchives.
https://bugs.webkit.org/show_bug.cgi?id=88470
Reviewed by Adam Barth.
- loader/archive/Archive.cpp:
(WebCore::Archive::clearAllSubframeArchives):
(WebCore):
(WebCore::Archive::clearAllSubframeArchivesImpl):
- loader/archive/Archive.h:
(Archive):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::~MHTMLArchive):
(WebCore):
(WebCore::MHTMLArchive::create):
- loader/archive/mhtml/MHTMLArchive.h:
(MHTMLArchive):
- 3:45 PM Changeset in webkit [121190] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r121178.
http://trac.webkit.org/changeset/121178
https://bugs.webkit.org/show_bug.cgi?id=89784
New unit test added is failing on WebKit Linux (dbg)
Source/WebCore:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 3:27 PM Changeset in webkit [121189] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r121137.
http://trac.webkit.org/changeset/121137
Chromium build fix, (un)touch files to build on Chromium Win
Release
- css/CSSParserMode.h:
- css/CSSValue.h:
(WebCore):
- css/CSSVariableValue.h:
- page/Settings.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleVariableData.h:
- 3:25 PM Changeset in webkit [121188] by
-
- 2 edits in trunk/LayoutTests
Mac bot gardening.
https://bugs.webkit.org/show_bug.cgi?id=89611
- platform/mac-wk2/Skipped:
- 3:19 PM Changeset in webkit [121187] by
-
- 32 edits2 deletes in trunk
Unreviewed, rolling out r121129.
http://trac.webkit.org/changeset/121129
https://bugs.webkit.org/show_bug.cgi?id=89542
Chromium ASan failure: crbug.com/134402
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
- css/CSSParser.h:
(CSSParser):
- css/CSSParserMode.h:
(CSSParserContext):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- page/Settings.h:
(Settings):
- testing/InternalSettings.cpp:
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit/chromium:
- features.gypi:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
(WebSettingsImpl):
LayoutTests:
- fast/css/variables/border-width.html:
- fast/css/variables/build-supports-variables-expected.txt: Removed.
- fast/css/variables/build-supports-variables.html: Removed.
- fast/css/variables/colors-test.html:
- fast/css/variables/complex-cycle.html:
- fast/css/variables/computed-style.html:
- fast/css/variables/inherited-values.html:
- fast/css/variables/inline-styles.html:
- fast/css/variables/invalid-shorthand.html:
- fast/css/variables/invalid-variable-value.html:
- fast/css/variables/multi-level-cycle.html:
- fast/css/variables/redefinition.html:
- fast/css/variables/shorthand.html:
- fast/css/variables/simple-cycle.html:
- fast/css/variables/transform-test.html:
- fast/css/variables/undefined.html:
- fast/css/variables/use-before-defined.html:
- fast/css/variables/var-inside-shorthand.html:
- fast/css/variables/variable-chain.html:
- 3:13 PM Changeset in webkit [121186] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll Chromium DEPS to r144020
https://bugs.webkit.org/show_bug.cgi?id=89912
Build fixed now! Unreviewed.
Rolled DEPS to fix chromium build.
Patch by Scott Graham <scottmg@chromium.org>.
- DEPS:
- 3:09 PM Changeset in webkit [121185] by
-
- 6 edits in trunk/Source/WebKit/chromium
IndexedDB: Stub out new onSuccess() handler for chromium
https://bugs.webkit.org/show_bug.cgi?id=89895
This is the chromium side of a refactor which will
introduce an onSuccess() method which includes the raw
SerializedScriptValue to the frontend, so the primaryKey
injection can happen in the front end, rather than
the V8 helper process.
Patch by Alec Flett <alecflett@chromium.org> on 2012-06-25
Reviewed by Darin Fisher.
- public/WebIDBCallbacks.h:
(WebKit):
(WebKit::WebIDBCallbacks::onSuccess):
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
(WebKit):
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- 3:01 PM Changeset in webkit [121184] by
-
- 4 edits in trunk/Source
Use InterpolationLow on chromium-android
https://bugs.webkit.org/show_bug.cgi?id=89849
Reviewed by Daniel Bates.
Source/WebCore:
Min Qin writes:
Using InterpolationHigh is very very expensive when resampling
images. For example, it took 1400ms to decode an image on
http://www.crossfitsunnyvale.com/blog/, but it took 2800 ms to do the
resampling Switch to InterpolationLow will result in linear
resampling. It is much faster as the time it tooks is almost
non-noticable [sic] on the trace.
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
Source/WTF:
Introduce a USE macro to control image interpolation quality.
- wtf/Platform.h:
- 2:57 PM Changeset in webkit [121183] by
-
- 16 edits in trunk/Source
IndexedDB: Remove unused backend property accessors
https://bugs.webkit.org/show_bug.cgi?id=89893
Reviewed by Darin Fisher.
Source/WebCore:
Following the "metadata" API addition in trac.webkit.org/changeset/121059
the IDBXXXBackendInterface types no longer need per-property accessors.
No new tests - no functional changes.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Remove method implementation.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Remove methods.
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h: Remove methods.
(IDBDatabaseBackendInterface):
- Modules/indexeddb/IDBIndexBackendImpl.h: Make methods simple accessors.
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::name):
(WebCore::IDBIndexBackendImpl::keyPath):
(WebCore::IDBIndexBackendImpl::unique):
(WebCore::IDBIndexBackendImpl::multiEntry):
- Modules/indexeddb/IDBIndexBackendInterface.h: Remove methods.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Remove method implementation.
- Modules/indexeddb/IDBObjectStoreBackendImpl.h: Make methods simple accessors.
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h: Remove methods.
Source/WebKit/chromium:
Following the "metadata" API addition in trac.webkit.org/changeset/121059
per-property accessors can be removed from the Chromium WebKit API.
- src/WebIDBDatabaseImpl.cpp: Removed name, version, objectStoreNames.
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- src/WebIDBIndexImpl.cpp: Removed name, keyPath, unique, multiEntry.
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
- src/WebIDBObjectStoreImpl.cpp: Removed name, keyPath, autoIncrement, indexNames.
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
- 2:45 PM Changeset in webkit [121182] by
-
- 6 edits48 adds in trunk/LayoutTests
Add layout tests for audio codecs
https://bugs.webkit.org/show_bug.cgi?id=88794
Patch by Raymond Toy <Raymond Toy> on 2012-06-25
Reviewed by Chris Rogers.
New tests and expected results
- webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
- webaudio/codec-tests/aac/vbr-128kbps-44khz.html: Added.
- webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
- webaudio/codec-tests/mp3/128kbps-44khz.html: Added.
- webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
- webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html: Added.
- webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
- webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html: Added.
- webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
- webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html: Added.
- webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
- webaudio/codec-tests/wav/24bit-22khz-resample.html: Added.
- webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
- webaudio/codec-tests/wav/24bit-44khz.html: Added.
- webaudio/resources/audio-codec-test.js: Added.
(runDecodingTest):
(finishedLoading):
Media files for the tests
- webaudio/resources/media/128kbps-44khz.mp3: Added.
- webaudio/resources/media/24bit-22khz.wav: Added.
- webaudio/resources/media/24bit-44khz.wav: Added.
- webaudio/resources/media/vbr-128kbps-44khz.m4a: Added.
- webaudio/resources/media/vbr-128kbps-44khz.ogg: Added.
- webaudio/resources/media/vbr-70kbps-44khz.ogg: Added.
- webaudio/resources/media/vbr-96kbps-44khz.ogg: Added.
Platform-specific expected results
- platform/chromium-linux/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
- platform/chromium-linux/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
- platform/chromium-linux/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
- platform/chromium-mac/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
- platform/chromium-mac/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
- platform/chromium-win/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
- platform/chromium-win/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
- platform/chromium-win/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
New test expectations
- platform/chromium/TestExpectations: Disable aac/mp3 tests until bots have support.
- platform/efl/TestExpectations: Disable all webaudio codec tests
- platform/gtk/TestExpectations: Disable all webaudio codec tests
- platform/mac/TestExpectations: Disable all webaudio codec tests
- platform/qt/TestExpectations: Disable all webaudio codec tests
- 2:31 PM Changeset in webkit [121181] by
-
- 3 edits in trunk/Tools
[Chromium] add empty impl of WebThemeEngine::getSize() for DRT
https://bugs.webkit.org/show_bug.cgi?id=89907
Not reviewed. Fix build in Chromium.
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(WebThemeEngineDRTWin::getSize):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
(WebThemeEngineDRTWin):
- 2:26 PM Changeset in webkit [121180] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Add support for building with ENABLE_MEDIA_STREAM
https://bugs.webkit.org/show_bug.cgi?id=88413
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-25
Reviewed by Dirk Pranke.
Add files which are needed for supporting the Media Stream
feature.
No change in functionality so no new tests.
- PlatformEfl.cmake:
- 2:18 PM Changeset in webkit [121179] by
-
- 11 edits3 adds in trunk
[Texmap] TextureMapperPaintOptions should keep current surface.
https://bugs.webkit.org/show_bug.cgi?id=89266
Source/WebCore:
Before this patch, if a replica layer has a descendant replica child, the child
layer does not render the result in the parent layer's surface because
TextureMapperPaintOptions does not keep current surface.
This patch amends that TextureMapperPaintOptions keeps current surface before
calling paintSelfAndChildrenWithReplica recursively, so previous surface could be
restored after paintSelfAndChildrenWithReplica.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
Test: compositing/reflections/animation-inside-reflection.html
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintRecursive):
LayoutTests:
Add a opacity property to two div layers in animation-insiVde-reflection
test.
Texmap has a bug when a transparent reflection layer has another
transparent reflection layer, so two reflection layer in
animation-inside-reflection test have opacity in order to cover Texmap's
bug.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
- compositing/reflections/animation-inside-reflection.html:
- platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
- platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
- platform/mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
- platform/qt/compositing/reflections/animation-inside-reflection-expected.png: Added.
- platform/qt/compositing/reflections/animation-inside-reflection-expected.txt: Added.
- 1:19 PM Changeset in webkit [121178] by
-
- 4 edits in trunk/Source
[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.
Source/WebCore:
Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 1:14 PM Changeset in webkit [121177] by
-
- 1 edit in branches/chromium/1180/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Merge 120881 - Perform hit-test from correct frame in isRectTopmost()
https://bugs.webkit.org/show_bug.cgi?id=89492
Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-20
Reviewed by Levi Weintraub.
Hit-testing was being performed from the main frame, which gave the
incorrect result if the plugin was in a different frame.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10656025
- 12:47 PM Changeset in webkit [121176] by
-
- 7 edits in trunk/Source
Source/Platform: Plumb Scrollbar button dimensions through WebThemeEngine
https://bugs.webkit.org/show_bug.cgi?id=89264
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Rather than making the height of the scrollbar buttons the same as the
width of the scrollbar, delegate to the WebThemeEngine. This allows
matching the Aura theme rather than the standard Windows theme.
- chromium/public/win/WebThemeEngine.h:
(WebKit):
(WebThemeEngine):
Source/WebCore: Plumb Scrollbar button dimensions down to WebThemeEngine
https://bugs.webkit.org/show_bug.cgi?id=89264
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Rather than making the height of the scrollbar buttons the same as the
width of the scrollbar, delegate to the WebThemeEngine. This allows
matching the Aura theme rather than the standard Windows theme.
No new tests, as bounds are overridden for DRT.
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
Source/WebKit/chromium: Plumb Scrollbar button dimensions down to WebThemeEngine
https://bugs.webkit.org/show_bug.cgi?id=89264
Patch by Scott Graham <scottmg@chromium.org> on 2012-06-25
Reviewed by James Robinson.
Rather than making the height of the scrollbar buttons the same as the
width of the scrollbar, delegate to the WebThemeEngine. This allows
matching the Aura theme rather than the standard Windows theme.
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getThemePartSize):
(WebCore):
- 12:33 PM Changeset in webkit [121175] by
-
- 2 edits in trunk/Source/WebCore
Fast path for simple transform parsing
https://bugs.webkit.org/show_bug.cgi?id=89898
Reviewed by Anders Carlsson.
When manipulating transforms using script, the transform value parsing can show up in profiles pretty heavily
(up 4% in some cases). We can optimize it easily by implementing a fast path that does not spin up the full CSS
parser, like we already do for several other common value types.
The patch implements a fast path for transform(), transformX/Y/Z() and transform3D(). It speeds up parsing by >5x.
- css/CSSParser.cpp:
(WebCore):
(WebCore::parseTransformArguments):
(WebCore::parseTransformValue):
(WebCore::CSSParser::parseValue):
- 12:04 PM Changeset in webkit [121174] by
-
- 2 edits in trunk/Source/WebCore
Remove unused static function shadowFor
https://bugs.webkit.org/show_bug.cgi?id=89824
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-25
Reviewed by Daniel Bates.
shadowFor is not used anymore after r117796. No behaviour changes.
- dom/TreeScopeAdopter.cpp:
- 11:56 AM Changeset in webkit [121173] by
-
- 2 edits in trunk/Source/WebCore
Remove unused constant timeWithoutMouseMovementBeforeHidingControls
https://bugs.webkit.org/show_bug.cgi?id=89823
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-25
Reviewed by Daniel Bates.
After r87692, timeWithoutMouseMovementBeforeHidingControls is not used anymore.
- html/HTMLMediaElement.cpp:
(WebCore):
- 11:49 AM Changeset in webkit [121172] by
-
- 4 edits in trunk/Source
[Chromium] RenderPass textures are evicted at the end of every frame
https://bugs.webkit.org/show_bug.cgi?id=89786
Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-25
Reviewed by Adrienne Walker.
Source/WebCore:
Removed calls to TextureManager::reduceMemoryToLimit inside
finishDrawingFrame() method.
Added unit tests to verify new behavior.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finishDrawingFrame):
Source/WebKit/chromium:
Added unit tests to verify large textures are staying in memory
and available for render pass optimization.
- tests/CCLayerTreeHostImplTest.cpp:
- 11:05 AM Changeset in webkit [121171] by
-
- 2 edits in trunk/LayoutTests
Missing implementation of textInputController.setComposition() causes bot redness
https://bugs.webkit.org/show_bug.cgi?id=89845
- platform/mac/Skipped: Skip fast/forms/input-set-composition-scroll.html
- 11:01 AM Changeset in webkit [121170] by
-
- 9 edits in trunk
[EFL] Implement Network Information API
https://bugs.webkit.org/show_bug.cgi?id=87067
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/cmake/FindEFL.cmake: Find eeze library in build system.
Source/WebKit:
- PlatformEfl.cmake: Add dependency of eeze library.
Source/WebKit/efl:
Implement NetworkInfoClientEfl.cpp using eeze library. However, this patch only
supports this feature on ethernet interface.
- WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore):
(WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
- WebCoreSupport/NetworkInfoClientEfl.h:
(NetworkInfoClientEfl):
Tools:
- efl/jhbuild.modules: Add eeze library dependency.
- 10:47 AM Changeset in webkit [121169] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Add graphviz debug output for the gstreamer video pipeline.
https://bugs.webkit.org/show_bug.cgi?id=89660
Patch by Allan Xavier <allan.xavier@undefinedltd.co.uk> on 2012-06-25
Reviewed by Martin Robinson.
Dump the current video pipeline as a graphviz DOT file when the
pipeline state changes or when an error occours.
No new tests as the change is only useful for debugging.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- 10:43 AM Changeset in webkit [121168] by
-
- 2 edits in branches/safari-536-branch/Source/WebKit2
Merged r121138 -> <rdar://problem/11686974>
- 10:41 AM Changeset in webkit [121167] by
-
- 5 edits in branches/safari-536-branch/Source/WebKit2
Merged r121113 -> <rdar://problem/11686974>
- 10:39 AM Changeset in webkit [121166] by
-
- 4 edits2 adds in trunk
ASSERT(m_wheelEventHandlerCount > 0) can fire
https://bugs.webkit.org/show_bug.cgi?id=89856
Reviewed by Eric Seidel.
Source/WebCore:
When a node with a wheel or a touch event is moved from one document to
another, the didAddMumble/didRemoveMumble calls do not balance because
they're called on different documents. This patch twiddles the counts
appropriately in that case.
Test: fast/events/move-element-with-wheel-and-touch-event-listeners.html
- dom/EventNames.h:
(WebCore::EventNames::isTouchEventType):
(EventNames):
(WebCore::EventNames::touchEventNames):
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):
LayoutTests:
Test what happens when we move a node with wheel and/or touch events
from one document to another. Prior to this patch, this test triggers
ASSERT(m_wheelEventHandlerCount > 0) in Document.cpp.
- fast/events/move-element-with-wheel-and-touch-event-listeners-expected.txt: Added.
- fast/events/move-element-with-wheel-and-touch-event-listeners.html: Added.
- 10:38 AM Changeset in webkit [121165] by
-
- 2 edits in branches/safari-536-branch/Source/WebCore
Rollout r121034 -> <rdar://problem/11718988>
- 10:36 AM Changeset in webkit [121164] by
-
- 10 edits2 adds in trunk/Source/WebCore
Split map* functions out of StyleResolver into a helper object
https://bugs.webkit.org/show_bug.cgi?id=89881
Reviewed by Daniel Bates.
These map* functions are completely independent of the rest of StyleResolver
and only exist to serve StyleBuilder.
CSSToStyleMap doesn't even want to have a StyleResolver pointer, but
currently needs one to access the resolve-lifetime caches for the
current resolve. Once we split out that per-resolve state into
some sort of ResolveState/ResolveInfo object (akin to PaintInfo/LayoutState)
then this object will be even simpler.
No behavioral change, thus no tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSToStyleMap.cpp: Added.
(WebCore):
(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillImage):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSToStyleMap.h: Added.
(WebCore):
(CSSToStyleMap):
(WebCore::CSSToStyleMap::CSSToStyleMap):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/StyleResolver.h:
(WebCore::StyleResolver::styleMap):
(StyleResolver):
- 10:14 AM Changeset in webkit [121163] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Support screenDepth() functionality.
https://bugs.webkit.org/show_bug.cgi?id=89423
Reviewed by Kenneth Rohde Christiansen.
Support screenDepth() based on ecore_x_window_depth_get(). This functionality may be used by
both WebKit1 and WebKit2. So, concrete function is placed into EflScreenUtilities.cpp.
This patch can't support existing test cases. Because, EFL DumpRenderTree works without X11 window
by default.
- platform/efl/EflScreenUtilities.cpp:
(WebCore::getPixelDepth):
(WebCore):
- platform/efl/EflScreenUtilities.h:
(WebCore):
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
- 9:59 AM Changeset in webkit [121162] by
-
- 3 edits2 adds in trunk
[Shadow] Executing Italic and InsertUnorderedList in Shadow DOM causes a crash
https://bugs.webkit.org/show_bug.cgi?id=88495
Reviewed by Ryosuke Niwa.
Source/WebCore:
InsertionPoint::removedFrom(insertionPoint) tries to find its owner ElementShadow from
parentNode or insertionPoint. If the parent node exsits but we cannot reach ElementShadow from
the parent node, InsertionPoint::removedFrom does not try to find ElementShadow anymore.
It's OK if the ElementShadow is being destructed, but there is a case ElementShadow is not being
destructed in editing. In this case, we should try to find ElementShadow from insertionPoint.
Otherwise it will bring inconsistency to Shadow DOM, and causes a crash.
Actually checking the existence of parentNode() does not make any sense. We should get
shadowRoot() directly.
Test: editing/shadow/insertorderedlist-crash.html
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::removedFrom):
LayoutTests:
- editing/shadow/insertorderedlist-crash-expected.txt: Added.
- editing/shadow/insertorderedlist-crash.html: Added.
- 9:56 AM Changeset in webkit [121161] by
-
- 2 edits in trunk/Source/WebCore
Remove responseBlob field from XMLHttpResponse.idl
https://bugs.webkit.org/show_bug.cgi?id=89859
Reviewed by Eric Seidel.
Remove XMLHttpResponse.responseBlob from XMLHttpResponse.idl, which
has only been exposed for a very limited time (since r120574) but
probably should not have been done so since XHR2 spec no longer has
the field. A quick search also showed that no one seems to be using the field.
(More context: the field was added long time ago with a runtime guard
which had never been enabled until the guard was removed in r120574
to remove XHR_RESPONSE_BLOB on all platforms.)
No new tests as no tests use this field.
- xml/XMLHttpRequest.idl: Removed responseBlob field.
- 9:30 AM Changeset in webkit [121160] by
-
- 2 edits in trunk/Source/WebKit/chromium
Heap-use-after-free in WebKit::MainThreadFileSystemCallbacks
https://bugs.webkit.org/show_bug.cgi?id=87019
Reviewed by David Levin.
Should not access the CallbacksBridge's member field after it's freed.
- src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::cleanUpAfterCallback):
- 8:40 AM Changeset in webkit [121159] by
-
- 2 edits in trunk/Source/WebCore
Add static qualifier to GraphicsContext3D::extractImageData.
https://bugs.webkit.org/show_bug.cgi?id=89866
GraphicsContext3D::extractImageData does not use member variables.
Each platform Accelerated-compositing implementation can use this method in
order to get pixel data of an Image or ImageBuffer object.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.
No new tests since there's no change on code behavior.
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
- 8:27 AM Changeset in webkit [121158] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use AIR controls if client doesn't support HTML control
https://bugs.webkit.org/show_bug.cgi?id=89777
Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-25
Reviewed by Yong Li.
Currently HTML controls depend on client implementing CreateWindow event, for those clients
that don't implement CreateWindow event, use old AIR controls so we don't break them.
PR 163818.
Internal reviewed by Mike Fenton.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::openPagePopup):
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest):
- WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
- 8:14 AM Changeset in webkit [121157] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unskip 3D transform tests.
https://bugs.webkit.org/show_bug.cgi?id=89878
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-25
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- 7:36 AM Changeset in webkit [121156] by
-
- 9 edits in trunk
Web Inspector: toggling style should not start property edit first.
https://bugs.webkit.org/show_bug.cgi?id=89834
Reviewed by Yury Semikhatsky.
Source/WebCore:
Otherwise property flickers upon toggling.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
LayoutTests:
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
(initialize_ElementTest.InspectorTest.toggleStylePropertyEnabled):
- inspector/styles/styles-disable-inherited.html:
- inspector/styles/styles-disable-then-change.html:
- inspector/styles/styles-disable-then-delete.html:
- inspector/styles/styles-disable-then-enable.html:
- inspector/styles/undo-property-toggle.html:
- 7:30 AM Changeset in webkit [121155] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Require text editable element to be enabled for VKB
https://bugs.webkit.org/show_bug.cgi?id=89876
Reviewed by Yong Li.
After bug 58837 got in, children of <fieldset> now can inherit the disabled
state of the fieldset. When trying for instance fast/forms/fieldset/fieldset-disabled.html,
it can be seen that when they are visually disabled, the input handling can still be triggered. So
add an extra check to isTextBasedContentEditableElement that the element is enabled.
Reviewed internally by Mike Fenton.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
- 7:26 AM Changeset in webkit [121154] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Emulate Touch Events" breaks selecting elements with "touchstart" event listeners for inspection.
https://bugs.webkit.org/show_bug.cgi?id=89861
Reviewed by Vsevolod Vlasov.
Upon a mousepress, Inspector should be queried for the "Inspect element" mode up-front,
before dispatching a synthetic "touchstart" event.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
- 6:42 AM Changeset in webkit [121153] by
-
- 1 copy in releases/WebKitGTK/webkit-1.9.4
Tagging the WebKitGTK+ 1.9.4 release
- 6:39 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 6:38 AM Changeset in webkit [121152] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and configure.ac for 1.9.4 release
.:
- configure.ac: Bump version number.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.9.4.
- 6:16 AM Changeset in webkit [121151] by
-
- 3 edits2 moves1 add in trunk/Source/WebKit2
[WK2][Qt][EFL] Move LayerBackingStore into common directory
https://bugs.webkit.org/show_bug.cgi?id=89838
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-06-25
Reviewed by Noam Rosenthal.
Move LayerBackingStore into 'Source/WebKit2/UIProcess/texmap' to be used by both Qt and Efl.
- Target.pri:
- UIProcess/texmap/LayerBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/qt/LayerBackingStore.cpp.
(WebKit):
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::createTile):
(WebKit::LayerBackingStore::removeTile):
(WebKit::LayerBackingStore::updateTile):
(WebKit::LayerBackingStore::texture):
(WebKit::LayerBackingStore::paintToTextureMapper):
(WebKit::LayerBackingStore::commitTileOperations):
- UIProcess/texmap/LayerBackingStore.h: Renamed from Source/WebKit2/UIProcess/qt/LayerBackingStore.h.
(WebKit):
(LayerBackingStoreTile):
(WebKit::LayerBackingStoreTile::LayerBackingStoreTile):
(WebKit::LayerBackingStoreTile::scale):
(LayerBackingStore):
(WebKit::LayerBackingStore::create):
(WebKit::LayerBackingStore::LayerBackingStore):
- 5:41 AM Changeset in webkit [121150] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Styles] Cannot visually set caret before the first CSS property name character
https://bugs.webkit.org/show_bug.cgi?id=89869
Reviewed by Vsevolod Vlasov.
The issue was due to the "editbox" SPAN having a negative margin, thus the leftmost caret position was getting clipped
by a synthetic SPAN container added by the TextPrompt.
- inspector/front-end/elementsPanel.css:
(.styles-section .properties > li.child-editing .webkit-css-property):
(.styles-section .properties li.child-editing):
- 5:09 AM Changeset in webkit [121149] by
-
- 4 edits in trunk/Source/WebCore
Microdata: document.getItems(typeNames) is not returning Microdata items when typeNames argument is not specified.
https://bugs.webkit.org/show_bug.cgi?id=89757
Reviewed by Ryosuke Niwa.
With r120979 change, it creates MicroDataItemList with m_typeNames = "http://webkit.org/microdata/undefinedItemType",
when typeNames argument is not specified. Modified the check in nodeMatches() accordingly.
This fixes the following failing tests :
fast/dom/MicroData/002.html
fast/dom/MicroData/003.html
fast/dom/MicroData/007.html
fast/dom/MicroData/009.html
fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html
- dom/Document.cpp:
(WebCore::Document::getItems): Use undefinedItemType to avoid String conversion.
- dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::undefinedItemType): It defines "http://webkit.org/microdata/undefinedItemType"
string using DEFINE_STATIC_LOCAL to avoid String conversion.
(WebCore::MicroDataItemList::MicroDataItemList): Use document() method of DynamicNodeList to obtain
document of owner element.
(WebCore::MicroDataItemList::~MicroDataItemList): Removed originalTypeNames null check.
(WebCore::MicroDataItemList::nodeMatches): Return true if originalTypeNames is equal to undefinedItemType.
- dom/MicroDataItemList.h:
- 4:55 AM Changeset in webkit [121148] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file.
- 4:21 AM Changeset in webkit [121147] by
-
- 4 edits1 add in trunk
[Qt] Fix Win32 debug build
Reviewed by Tor Arne Vestbø.
Source/WebCore:
Consistently use use_all_in_one_files when requested in the configuration. The previous
Linux condition has been moved to Tools/qmake/mkspecs/features/unix/default_pre.prf
- Target.pri:
Tools:
Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
- qmake/mkspecs/features/unix/default_pre.prf:
- qmake/mkspecs/features/win32/default_pre.prf: Added.
- 3:31 AM Changeset in webkit [121146] by
-
- 3 edits2 adds in trunk
Fix rewinding of SVG animations
https://bugs.webkit.org/show_bug.cgi?id=89846
Reviewed by Nikolas Zimmermann.
Source/WebCore:
r116451 introduced an optimization to only clear non-freeze animations when
calling setCurrentTime (via reset()). This causes fill=freeze animations to
not clear which breaks rewinding of an animation.
In the presence of multiple animations, we reset the first animation to the
base value and accumulate all results into that; this masked the problem because
2 animations were required to hit the bug (our tests primarily cover just 1).
Test: svg/animations/animate-reset-freeze.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::reset):
LayoutTests:
- svg/animations/animate-reset-freeze-expected.txt: Added.
- svg/animations/animate-reset-freeze.html: Added.
- 2:43 AM Changeset in webkit [121145] by
-
- 8 edits2 adds in trunk
Change the serialization format of form control state to make the code simple
https://bugs.webkit.org/show_bug.cgi?id=89847
Reviewed by Hajime Morita.
Source/WebCore:
We used multiple strings to represent state of single form control. It
made the code complex. We change the serialization format so that one
CSV string represents state.
Examples in the old format:
"0"
"1", "value"
"3", "value1", "value2,value2", "value3"
Examples in the new format:
""
",value"
",value1,value2\,value2,value3"
Test: fast/forms/state-restore-various-values.html
- html/FormController.cpp:
(WebCore::FormControlState::serialize):
Generate comma-separated string.
',' in a value is serialized as "\,".
We changed the signature because we don't need the out-argument.
(WebCore::FormControlState::deserialize):
Parses the input comma-separated string.
We changed the signature because we don't need multiple input strings.
(formStateSignature):
Bump up the version because of the representation change.
(WebCore::FormController::formElementsState):
The new serialized format occupies just one string for one control.
- Expected size is now 3n+1.
- Use FormControlState::serialize().
(WebCore::FormController::setStateForNewFormElements):
The new serialized format occupies just one string for one control.
So we can check the vector size before the iteration.
- html/FormController.h:
(FormControlState): Change the function signatures.
- html/shadow/CalendarPickerElement.cpp:
(WebCore::addJavaScriptString): Use StringBuilder::appendEscaped().
Source/WTF:
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::appendEscaped): Added. This function adds the
escaped form of the input string. e.g. if stiring="foo,bar" escape='\'
special=',', the appended string is foo\,bar.
LayoutTests:
- fast/forms/state-restore-broken-state-expected.txt:
Apply the serialization format change.
- fast/forms/state-restore-various-values-expected.txt: Added.
- fast/forms/state-restore-various-values.html: Added.
- 2:26 AM Changeset in webkit [121144] by
-
- 13 edits1 move in trunk/Source/WebCore
Web Inspector: add external resources size to the native memory diagram
https://bugs.webkit.org/show_bug.cgi?id=89754
Reviewed by Vsevolod Vlasov.
Size of external strings and arrays is now reported through the inspector
protocol and displayed on the native memory chart.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptProfiler.h:
(WebCore):
(WebCore::ScriptProfiler::visitJSDOMWrappers):
(WebCore::ScriptProfiler::visitExternalJSStrings):
(WebCore::ScriptProfiler::visitExternalJSArrays):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitJSDOMWrappers):
(WebCore::ScriptProfiler::visitExternalJSStrings):
(WebCore::ScriptProfiler::visitExternalJSArrays):
(WebCore):
- bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
- bindings/v8/V8Binding.cpp:
(WebCore::WebCoreStringResource::visitStrings):
(WebCore::V8BindingPerIsolateData::visitJSExternalStrings):
- bindings/v8/V8Binding.h:
(WebCore):
(V8BindingPerIsolateData):
- inspector/BindingVisitors.h: Renamed from Source/WebCore/inspector/DOMWrapperVisitor.h.
(WTF):
(WebCore):
(NodeWrapperVisitor):
(WebCore::NodeWrapperVisitor::~NodeWrapperVisitor):
(ExternalStringVisitor):
(WebCore::ExternalStringVisitor::~ExternalStringVisitor):
(ExternalArrayVisitor):
(WebCore::ExternalArrayVisitor::~ExternalArrayVisitor):
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::jsExternalResourcesInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- 1:42 AM Changeset in webkit [121143] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebView/permission-requests fails due to a runtime warning
https://bugs.webkit.org/show_bug.cgi?id=89858
Reviewed by Xan Lopez.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPermissionRequests): Make runtime warnings non-fatal
for test /webkit2/WebKitWebView/permission-requests.
- 12:18 AM Changeset in webkit [121142] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Remove unused code in LayerTreeHostGtk.
https://bugs.webkit.org/show_bug.cgi?id=89854
LayerTreeHostGtk::deviceScaleFactor() is unused and LayerTreeHost does not have
virtual float deviceScaleFactor() const;
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Martin Robinson.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- 12:02 AM Changeset in webkit [121141] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
