Timeline
Jun 30, 2012:
- 8:54 PM Changeset in webkit [121633] by
-
- 10 edits in trunk/Source/JavaScriptCore
JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255
Reviewed by Mark Hahnenberg.
Rolling back in after applying a simple fix: it appears that
JSObject::setStructureAndReallocateStorageIfNecessary() was allocating more
property storage than necessary. Fixing this appears to resolve the crash.
This does a few things:
- JSNonFinalObject no longer has inline property storage.
- Initial out-of-line property storage size is 4 slots for JSNonFinalObject, or 2x the inline storage for JSFinalObject.
- Property storage is only reallocated if it needs to be. Previously, we would reallocate the property storage on any transition where the original structure said shouldGrowProperyStorage(), but this led to spurious reallocations when doing transitionless property adds and there are deleted property slots available. That in turn led to crashes, because we would switch to out-of-line storage even if the capacity matched the criteria for inline storage.
- Inline JSFunction allocation is killed off because we don't have a good way of inlining property storage allocation. This didn't hurt performance. Killing off code is better than fixing it if that code wasn't doing any good.
This looks like a 1% progression on V8.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
- runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
- runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSC::JSNonFinalObject::hasInlineStorage):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::hasInlineStorage):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::inlineStorageCapacity):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::nextPropertyStorageCapacity):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):
- runtime/Structure.h:
(JSC::Structure::putWillGrowPropertyStorage):
(Structure):
- 4:32 PM Changeset in webkit [121632] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed chromium rebaseline for svg/zoom.
- platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
- platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
- 4:29 PM Changeset in webkit [121631] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium windows rebaseline.
- platform/chromium-win-xp/http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt:
- 3:54 PM Changeset in webkit [121630] by
-
- 4 edits in trunk
[BlackBerry] WebView/Browser cause blank screen when selecting a dropdown field.
https://bugs.webkit.org/show_bug.cgi?id=90241
This issue is caused by single quotes in option's labels.
We should use the escape character of single quotes in JavaScript's string which
starts and ends with single quotes.
So we replace lablels' single quotes with its escape character during generating the
select popUp's HTML.
.:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-30
Reviewed by George Staikos.
- ManualTests/blackberry/select-popup-items-unicode-display.html:
Source/WebKit/blackberry:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-30
Reviewed by George Staikos.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
- 12:28 PM Changeset in webkit [121629] by
-
- 3 edits3 adds in trunk
Webkit crashes in DFG on Google Docs when creating a new document
https://bugs.webkit.org/show_bug.cgi?id=90209
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
Don't attempt to short-circuit Phantom(GetLocal) if the GetLocal is for a
captured variable.
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
LayoutTests:
Reviewed by Gavin Barraclough.
- fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local-expected.txt: Added.
- fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.html: Added.
- fast/js/script-tests/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.js: Added.
(baz):
(stuff):
(foo):
(o.g):
- 8:55 AM Changeset in webkit [121628] by
-
- 22 edits1 add in trunk/Source
[chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space.
https://bugs.webkit.org/show_bug.cgi?id=90092
The CanvasLayerTextureUpdater currently receives its opaque rects in
layer space, but is expected to return them in content space and does
not convert them. This patch adds this conversion. To avoid numerical
errors, this patch also switches to using float rects to store opaque
rects where appropriate.
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-30
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebContentLayerClient.h:
(WebKit):
(WebContentLayerClient):
Source/WebCore:
Unit test: ContentLayerTest.ContentLayerPainterWithDeviceScale
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
- platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerDelegate):
(ContentLayerPainter):
- platform/graphics/chromium/LayerPainterChromium.h:
(WebCore):
(LayerPainterChromium):
- platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::paintContents):
- platform/graphics/chromium/LinkHighlight.h:
(LinkHighlight):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
Source/WebKit/chromium:
- WebKit.gypi:
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::paintContents):
- tests/ContentLayerChromiumTest.cpp: Added.
(WebKit):
(OpaqueRectDrawingGraphicsContextPainter):
(WebKit::OpaqueRectDrawingGraphicsContextPainter::OpaqueRectDrawingGraphicsContextPainter):
(WebKit::OpaqueRectDrawingGraphicsContextPainter::~OpaqueRectDrawingGraphicsContextPainter):
(MockContentLayerDelegate):
(WebKit::MockContentLayerDelegate::MockContentLayerDelegate):
(WebKit::TEST):
- tests/LayerChromiumTest.cpp:
- tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):
- tests/TiledLayerChromiumTest.cpp:
- tests/WebLayerTest.cpp:
- 5:09 AM Changeset in webkit [121627] by
-
- 10 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r121605.
http://trac.webkit.org/changeset/121605
https://bugs.webkit.org/show_bug.cgi?id=90336
Changes caused flaky crashes in sputnik/Unicode tests on Apple
WK1 and GTK Linux builders
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC):
(JSC::JIT::emitAllocateJSFunction):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):
- runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
- runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):
- runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage):
(JSC::Structure::propertyStorageSize):
- 4:56 AM Changeset in webkit [121626] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Allow surface resizing for use cases other than rotation.
https://bugs.webkit.org/show_bug.cgi?id=90295
RIM PR 171459
Reviewed by George Staikos.
A new API method setHasPendingSurfaceSizeChange() is
introduced for that effect, and used inside of
setViewportSize() to let the WebPageClient do the
resizing. Methods are renamed to reflect that this
is not exclusively meant for rotation anymore.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(WebKit):
(BlackBerry::WebKit::WebPage::setHasPendingSurfaceSizeChange):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 3:39 AM Changeset in webkit [121625] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK and EFL gardening, adding image expectation
for the failing css3/flexbox/anonymous-block.html test.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 3:21 AM Changeset in webkit [121624] by
-
- 4 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening, updating baselines after r121599.
- platform/gtk/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/gtk/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 2:29 AM Changeset in webkit [121623] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Remove unused declaration.
HTMLDocumentParser::begin() has no method definition.
- html/parser/HTMLDocumentParser.h:
Jun 29, 2012:
- 10:02 PM Changeset in webkit [121622] by
-
- 2 edits in trunk/Tools
Turns out we need zip too.
- EWSTools/cold-boot.sh:
- 10:00 PM Changeset in webkit [121621] by
-
- 2 edits1 add in trunk/Tools
Add a cold-boot.sh script for the EWS
https://bugs.webkit.org/show_bug.cgi?id=90330
Unreviewed.
- EWSTools/cold-boot.sh: Added.
- This script can take us from a cold GCE instance to a running EWS bot in one fell swoop.
- EWSTools/start-queue.sh:
- The if-block at the top of this script was causing trouble. I removed it from the bots a while ago. Now that we're using SVN to cold-boot the EWS bots, we need to make this change in the repo.
- 9:18 PM Changeset in webkit [121620] by
-
- 7 edits18 adds in trunk
[Qt][WK2] Private non-QtQuick API
https://bugs.webkit.org/show_bug.cgi?id=84532
.:
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.
API tests for QRawWebView.
- Source/tests.pri:
Source/WebKit2:
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.
Adding new private non-QtQuick API. This new C++ API makes it possible
to have control over the lower levels of WebKit without going via QML.
This is a first version of the API, enough to show pages on the screen.
Many features are not implemented.
- Target.pri:
- UIProcess/API/qt/raw/qrawwebview.cpp: Added.
- UIProcess/API/qt/raw/qrawwebview_p.h: Added.
- UIProcess/API/qt/raw/qrawwebview_p_p.h: Added.
The tests for the new API are pixel tests. They use QRawWebView to load
html files and generate images, and them compare those images to the ones
in UIProcess/API/qt/tests/html/resources.
- UIProcess/API/qt/tests/html/bluesquare.html: Added.
- UIProcess/API/qt/tests/html/redsquare.html: Added.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Added.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Added.
- UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Added.
- UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Added.
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Added.
Tools:
MiniBrowserRaw is an usage example for the QRawWebView API.
It is only an example and is not fully implemented.
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-06-29
Reviewed by Noam Rosenthal.
- MiniBrowser/qt/raw/DerivedSources.pri: Added.
- MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
- MiniBrowser/qt/raw/Target.pri: Added.
- MiniBrowser/qt/raw/View.cpp: Added.
- MiniBrowser/qt/raw/View.h: Added.
- Scripts/webkitpy/style/checker.py:
- Tools.pro:
- 8:54 PM Changeset in webkit [121619] by
-
- 4 edits in trunk/Tools
Remove leopard bots from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90328
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- 8:52 PM Changeset in webkit [121618] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r121569.
http://trac.webkit.org/changeset/121569
https://bugs.webkit.org/show_bug.cgi?id=90082
It broke a couple of tests in Qt Linux Release
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
- 8:36 PM Changeset in webkit [121617] by
-
- 3 edits in trunk/Tools
garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
https://bugs.webkit.org/show_bug.cgi?id=90243
Reviewed by Dirk Pranke.
jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
all.
Not really sure how to unittest this. I tested it all manually of course.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
Not related to this patch, but figured I'd update the failing test while I was at it.
- 8:36 PM Changeset in webkit [121616] by
-
- 2 edits in trunk/Source/WebCore
updateDescendantDependentFlags() is inside #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=90245
Reviewed by Dan Bernstein.
updateDescendantDependentFlags() and updateTransform() should be
outside the USE(ACCELERATED_COMPOSITING) #ifdef. They do work
that is needed even if accelerated compositing is disabled.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
- 8:32 PM Changeset in webkit [121615] by
-
- 7 edits4 adds in trunk
[V8] HTMLCollection wrappers are not retained
https://bugs.webkit.org/show_bug.cgi?id=90208
Reviewed by Adam Barth.
Source/WebCore:
Generate visitDOMWrapper for HTMLCollection and HTMLAllCollection so that we add an implicit reference from the owner
to the collection.
Tests: fast/dom/htmlallcollection-reachable.html
fast/dom/htmlcollection-reachable.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Instead of hard coding to use base() for HTMLAllCollection and HTMLCollection we now
annotate the IDL file to use GenerateIsReachable=ImplBaseRoot.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateVisitDOMWrapper): Generate visitDOMWrapper if GenerateIsReachable is ImplBaseRoot.
- bindings/scripts/IDLAttributes.txt: Added ImplBaseRoot.
- html/HTMLAllCollection.idl: Added annotations.
- html/HTMLCollection.idl: Ditto.
LayoutTests:
- fast/dom/htmlallcollection-reachable-expected.txt: Added.
- fast/dom/htmlallcollection-reachable.html: Added.
- fast/dom/htmlcollection-reachable-expected.txt: Added.
- fast/dom/htmlcollection-reachable.html: Added.
- 8:27 PM Changeset in webkit [121614] by
-
- 2 edits in trunk/Tools
Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
https://bugs.webkit.org/show_bug.cgi?id=90309
Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-06-29
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_http_server):
- 8:16 PM Changeset in webkit [121613] by
-
- 7 edits in trunk
All child elements of a flex container should be turned into a flex item
https://bugs.webkit.org/show_bug.cgi?id=90323
Reviewed by Ojan Vafai.
Source/WebCore:
We used to only convert some elements to blocks, but now we convert everything except text nodes.
This was recently changed here:
http://wiki.csswg.org/topics/css3-flexbox-flexbox-replaced-children
Tests: css3/flexbox/anonymous-block.html : Add new test case.
css3/flexbox/flexitem.html: Update results.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
LayoutTests:
- css3/flexbox/anonymous-block-expected.html:
- css3/flexbox/anonymous-block.html:
- css3/flexbox/flexitem-expected.txt:
- css3/flexbox/flexitem.html:
- 8:09 PM Changeset in webkit [121612] by
-
- 17 edits in trunk/Source
IndexedDB: Keep direction on IDBCursor to avoid calls to back end
https://bugs.webkit.org/show_bug.cgi?id=90114
Source/WebCore:
Reviewed by Tony Chang.
Let IDBCursor handle direction() accessor locally, without a call to
the IDBCursorBackendImpl which (in some ports) may reside in a different
process. Not a heavily called function, but further reduces the surface
area exposed by the XXXInterface classes.
No new tests - no functional changes.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::create): Accept direction, known at creation time.
(WebCore::IDBCursor::IDBCursor): Stash in member.
(WebCore::IDBCursor::direction): Use local copy
(WebCore::IDBCursor::stringToDirection): Return enum value, not int.
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBCursorBackendImpl.cpp: Remove accessor.
- Modules/indexeddb/IDBCursorBackendImpl.h:
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendInterface.h: Remove accessor.
- Modules/indexeddb/IDBCursorWithValue.cpp:
(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):
- Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
- Modules/indexeddb/IDBIndex.cpp: Prep IDBRequest with cursor direction too.
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBObjectStore.cpp: Ditto.
(WebCore::IDBObjectStore::openCursor):
- Modules/indexeddb/IDBRequest.cpp: Stash direction for pending cursor too.
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::onSuccess): Apply stashed direction to new cursor.
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
Source/WebKit/chromium:
Stop plumbing IDBCursorBackendInterface::direction() through API.
Reviewed by Tony Chang.
- src/IDBCursorBackendProxy.cpp:
- src/IDBCursorBackendProxy.h:
(IDBCursorBackendProxy):
- src/WebIDBCursorImpl.cpp:
- src/WebIDBCursorImpl.h:
(WebIDBCursorImpl):
- 7:36 PM Changeset in webkit [121611] by
-
- 6 edits in trunk
Allow align-self: stretch to cause the item size to shrink below its intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=90304
Reviewed by Ojan Vafai.
Source/WebCore:
The spec used to say that stretch could only make items grow, but now
it allows items to shrink.
http://dev.w3.org/csswg/css3-flexbox/#align-items-stretch
Tests: css3/flexbox/flex-align-stretch.html Updated expectations.
css3/flexbox/child-overflow.html Updated expectations.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
LayoutTests:
- css3/flexbox/child-overflow-expected.html:
- css3/flexbox/child-overflow.html:
- css3/flexbox/flex-align-stretch.html:
- 7:02 PM Changeset in webkit [121610] by
-
- 12 edits3 adds2 deletes in trunk
NPObjectWrapper may not address all window script object lifetime issues
https://bugs.webkit.org/show_bug.cgi?id=85679
Source/WebCore:
The ScriptController implementations force-deallocate the window script object to ensure that DOM objects are not leaked if an NPAPI plugin fails to release a reference to it before being destroyed. The NPObjectWrapper was added to ensure that NPAPI scripting could not touch the real window script object after it had been deallocated, by providing the plugin with a small wrapper which will leak if the plugin fails to dereference it.
This patch removes NPObjectWrapper and instead drops the window script NPObject's reference to the underlying V8Object in ScriptController::clearScriptObjects(). If a plugin fails to dereference the object then the NPV8Object wrapper will be leaked but the DOM objects it references will not.
Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.
Test: plugins/npruntime/leak-window-scriptable-object.html
- WebCore.gypi:
- bindings/v8/NPObjectWrapper.cpp: Removed.
- bindings/v8/NPObjectWrapper.h: Removed.
- bindings/v8/NPV8Object.cpp:
(WebCore::disposeUnderlyingV8Object):
(WebCore):
(WebCore::freeV8NPObject):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_EvaluateHelper):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
(_NPN_Construct):
- bindings/v8/NPV8Object.h:
(WebCore):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):
- bindings/v8/ScriptController.h:
(ScriptController):
Tools:
TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetProperty):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):
- DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
(LeakWindowScriptableObject):
(LeakWindowScriptableObject::LeakWindowScriptableObject):
(LeakWindowScriptableObject::NPP_New):
LayoutTests:
Test that NPAPI plugins that leak references to the window script object don't cause the containing document to be leaked.
Patch by James Weatherall <wez@chromium.org> on 2012-06-29
Reviewed by Nate Chapin.
- plugins/npruntime/leak-window-scriptable-object-expected.txt: Added.
- plugins/npruntime/leak-window-scriptable-object.html: Added.
- 6:23 PM Changeset in webkit [121609] by
-
- 2 edits in trunk/Source/WebCore
Update complex fonts on Android to use fonts from a newer SDK
https://bugs.webkit.org/show_bug.cgi?id=90296
Reviewed by Nate Chapin.
These fonts are available in the Jelly Bean SDK.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::getComplexFontPlatformData):
- 6:20 PM Changeset in webkit [121608] by
-
- 3 edits8 adds in trunk/Source/WebKit
Source/WebKit: [EFL] Add support for Unit Tests, based on the gtest library.
https://bugs.webkit.org/show_bug.cgi?id=68509
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-06-29
Reviewed by Chang Shu.
Add configuration for building gtest library, testing framework and unit tests.
- PlatformEfl.cmake:
Source/WebKit/efl: [EFL] Implementation of testing framework and unit tests for WebKit-EFL port.
https://bugs.webkit.org/show_bug.cgi?id=68509
Patch by Krzysztof Czech <k.czech@samsung.com>, Tomasz Morawski <t.morawski@samsung.com> on 2012-06-29
Reviewed by Chang Shu.
Testing framework is based on gtest library. Gtest library is part of the WebKit project. Framework is devided into base part and view part.
Base part takes care of efl initialization, defines test macros and prepares test to run. View part is a context of each test.
- tests/UnitTestUtils/EWKTestBase.cpp: Added.
(EWKUnitTests):
(EWKUnitTests::EWKTestBase::init):
(EWKUnitTests::EWKTestBase::shutdown):
(EWKUnitTests::EWKTestBase::shutdownAll):
(EWKUnitTests::EWKTestBase::startTest):
(EWKUnitTests::EWKTestBase::endTest):
(EWKUnitTests::EWKTestBase::createTest):
(EWKUnitTests::EWKTestBase::runTest):
- tests/UnitTestUtils/EWKTestBase.h: Added.
(EWKUnitTests):
(EWKTestBase):
- tests/UnitTestUtils/EWKTestConfig.h: Added.
(Config):
- tests/UnitTestUtils/EWKTestView.cpp: Added.
(EWKUnitTests):
(EWKUnitTests::EWKTestEcoreEvas::EWKTestEcoreEvas):
(EWKUnitTests::EWKTestEcoreEvas::evas):
(EWKUnitTests::EWKTestEcoreEvas::show):
(EWKUnitTests::EWKTestView::EWKTestView):
(EWKUnitTests::EWKTestView::init):
(EWKUnitTests::EWKTestView::show):
(EWKUnitTests::EWKTestView::mainFrame):
(EWKUnitTests::EWKTestView::evas):
(EWKUnitTests::EWKTestView::bindEvents):
- tests/UnitTestUtils/EWKTestView.h: Added.
(EWKUnitTests):
(EWKTestEcoreEvas):
(EWKTestView):
(EWKUnitTests::EWKTestView::webView):
- tests/resources/default_test_page.html: Added.
- tests/test_ewk_view.cpp: Added.
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
- tests/test_runner.cpp: Added.
(parseCustomArguments):
(main):
- 6:14 PM Changeset in webkit [121607] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove warning about protected values when the Heap is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=90302
Reviewed by Geoffrey Garen.
Having to do book-keeping about whether values allocated from a certain
VM are or are not protected makes the JSC API much more difficult to use
correctly. Clients should be able to throw an entire VM away and not have
to worry about unprotecting all of the values that they protected earlier.
- heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
- 5:58 PM Changeset in webkit [121606] by
-
- 6 edits in trunk/LayoutTests
Unreviewed chromium windows rebaselines for r121599.
- platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- 5:25 PM Changeset in webkit [121605] by
-
- 10 edits in trunk/Source/JavaScriptCore
JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255
Reviewed by Mark Hahnenberg.
This does a few things:
- JSNonFinalObject no longer has inline property storage.
- Initial out-of-line property storage size is 4 slots for JSNonFinalObject, or 2x the inline storage for JSFinalObject.
- Property storage is only reallocated if it needs to be. Previously, we would reallocate the property storage on any transition where the original structure said shouldGrowProperyStorage(), but this led to spurious reallocations when doing transitionless property adds and there are deleted property slots available. That in turn led to crashes, because we would switch to out-of-line storage even if the capacity matched the criteria for inline storage.
- Inline JSFunction allocation is killed off because we don't have a good way of inlining property storage allocation. This didn't hurt performance. Killing off code is better than fixing it if that code wasn't doing any good.
This looks like a 1% progression on V8.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC):
(JSC::JIT::emit_op_new_func_exp):
- runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
- runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSObject):
(JSC::JSObject::finishCreation):
(JSC):
(JSC::JSNonFinalObject::hasInlineStorage):
(JSNonFinalObject):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSC::JSFinalObject::hasInlineStorage):
(JSC::JSFinalObject::finishCreation):
(JSC::JSObject::offsetOfInlineStorage):
(JSC::JSObject::setPropertyStorage):
(JSC::Structure::inlineStorageCapacity):
(JSC::Structure::isUsingInlineStorage):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::nextPropertyStorageCapacity):
(JSC):
(JSC::Structure::growPropertyStorageCapacity):
(JSC::Structure::suggestedNewPropertyStorageSize):
- runtime/Structure.h:
(JSC::Structure::putWillGrowPropertyStorage):
(Structure):
- 5:20 PM Changeset in webkit [121604] by
-
- 9 edits in trunk/LayoutTests
Unreviewed chromium rebaselines for r121599.
- platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac-snowleopard/fast/transforms/bounding-rect-zoom-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- 4:56 PM Changeset in webkit [121603] by
-
- 27 edits in trunk/Source/WebCore
HTMLCollection's caches should be owned by either ElementRareData or Document
https://bugs.webkit.org/show_bug.cgi?id=90322
Reviewed by Anders Carlsson.
Removed all instances of OwnPtr<HTMLCollection> except ones on ElementRareData and Document.
ElementRareData::ensureCachedHTMLCollection then polymorphically creates HTMLCollection or
its subclass as deemed necessary.
This refactoring allows us to move HTMLCollection to use the same invalidation model as
DynamicNodeList (invalidated during DOM mutations) in a follow up.
- dom/Document.cpp:
(WebCore::Document::all):
- dom/Document.h:
(Document):
- dom/Element.cpp:
(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore):
(WebCore::Element::cachedHTMLCollection):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(WebCore):
(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
- dom/Node.cpp:
(WebCore):
- dom/Node.h:
(Node):
- dom/NodeRareData.h:
(WebCore::NodeRareData::setItemType):
(NodeRareData):
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
- html/HTMLElement.cpp:
(WebCore):
(WebCore::HTMLElement::properties):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
- html/HTMLFieldSetElement.h:
(HTMLFieldSetElement):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):
- html/HTMLFormCollection.h:
(HTMLFormCollection):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
- html/HTMLFormElement.h:
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
(WebCore::HTMLOptionsCollection::create):
- html/HTMLOptionsCollection.h:
(HTMLOptionsCollection):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
- html/HTMLSelectElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
- html/HTMLTableElement.h:
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):
- html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):
- 4:49 PM Changeset in webkit [121602] by
-
- 2 edits in trunk/Source/WebCore
Add FIXMEs for vertical writing mode and override sizes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
- 4:45 PM Changeset in webkit [121601] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer
https://bugs.webkit.org/show_bug.cgi?id=90300
Reviewed by Adrienne Walker.
- platform/graphics/chromium/RateLimiter.cpp:
(RateLimiter::Task):
(WebCore::RateLimiter::Task::create):
(WebCore::RateLimiter::Task::~Task):
(WebCore::RateLimiter::Task::Task):
(WebCore):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::stop):
(WebCore::RateLimiter::rateLimitContext):
- platform/graphics/chromium/RateLimiter.h:
(WebCore):
(RateLimiter):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
- 4:40 PM Changeset in webkit [121600] by
-
- 12 edits in trunk/Source
Remove type from screenColorProfile API
https://bugs.webkit.org/show_bug.cgi?id=90299
Patch by Tony Payne <tpayne@chromium.org> on 2012-06-29
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/Platform.h:
(WebKit::Platform::screenColorProfile): Removed type from chromium
public API's version of screenColorProfile().
Source/WebCore:
Covered by existing tests.
- platform/PlatformScreen.h:
(WebCore): Removed type from screenColorProfile().
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenColorProfile):
- platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenColorProfile):
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenColorProfile):
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenColorProfile):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile): Updated call to
screenColorProfile() to not pass type param.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenColorProfile):
- platform/qt/PlatformScreenQt.cpp:
(WebCore::screenColorProfile):
- platform/win/PlatformScreenWin.cpp:
(WebCore::screenColorProfile):
- 4:26 PM Changeset in webkit [121599] by
-
- 19 edits2 adds in trunk
Allow non-borders to be adjusted to less than 1 when zoomed out
https://bugs.webkit.org/show_bug.cgi?id=90104
Reviewed by Eric Seidel.
Source/WebCore:
Change CSSPrimitiveValue::computeLengthDouble to allow values to be
adjusted to less than 1.0 when zoomed out. This avoids an off by one
error for floats with margins when zoomed out that can cause floats to
wrap and break pages.
The logic that prevents the value from being adjusted to less than 1 was
added to ensure that borders are still painted even when zoomed out.
By moving the logic to ApplyPropertyComputeLength::applyValue, which is
used for borders and outlines, that functionality is preserved.
Test: fast/sub-pixel/float-with-margin-in-container.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
LayoutTests:
Add test ensuring that floats with margins do not wrap in fixed sized
containers and update existing results as needed.
- fast/css/zoom-background-repeat-x.html:
- fast/sub-pixel/float-with-margin-in-container-expected.txt: Added.
- fast/sub-pixel/float-with-margin-in-container.html: Added.
- platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png:
- platform/chromium-linux/fast/transforms/bounding-rect-zoom-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 3:55 PM Changeset in webkit [121598] by
-
- 2 edits in trunk/Source/WebCore
Let Xcode have its own way after r121513.
- WebCore.xcodeproj/project.pbxproj:
- 3:51 PM Changeset in webkit [121597] by
-
- 13 edits in trunk
[CSS Regions] Adding feature defines for CSS Regions for Windows
https://bugs.webkit.org/show_bug.cgi?id=88645
Patch by Mihai Balan <mibalan@adobe.com> on 2012-06-29
Reviewed by Tony Chang.
Source/WebCore:
Re-trying to enable CSS regions on Windows. This time only enabling
regions (not exclusions) because of some strange compilation/linking
issues.
- css/CSSPropertyNames.in: Touched file to make sure property names get properly rebuilt.
Source/WebKit/win:
Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems. This time adding preferences code to make sure the settings
get propagated to DRT (previous experiments by abucur showed they
didn't.).
- WebPreferenceKeysPrivate.h: Added preference key for CSS regions
- Interfaces/IWebPreferences.idl: Added getters and setters for CSS regions settings
- WebPreferences.cpp: ditto
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isCSSRegionsEnabled):
(WebPreferences::setCSSRegionsEnabled):
- WebPreferences.h: ditto
(WebPreferences):
- WebView.cpp: Added settings code to handle CSS regions, too
(WebView::notifyPreferencesChanged):
WebKitLibraries:
Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems.
- win/tools/vsprops/FeatureDefines.vsprops: Added default value for ENABLE_CSS_REGIONS
- win/tools/vsprops/FeatureDefinesCairo.vsprops: ditto
LayoutTests:
Re-trying to enable CSS regions on Windows. This time only enabling
regions (not exclusions) because of some strange compilation/linking
issues. Fixing a couple of non-regions related tests that get different
results once regions are enabled.
- platform/win/fast/js/global-constructors-expected.txt: Added WebKitCSSRule to expected
- 3:45 PM WebKitIDL edited by
- (diff)
- 3:25 PM Changeset in webkit [121596] by
-
- 2 edits in trunk/Tools
webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
https://bugs.webkit.org/show_bug.cgi?id=90314
Reviewed by Ojan Vafai.
Add comments and fix a bug in how we would handle the mac-wk2
and win-wk2 port names after confusion around in bug 90312 :).
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.determine_full_port_name):
- 3:16 PM Changeset in webkit [121595] by
-
- 8 edits in trunk/Tools
webkitpy: remove support for mac leopard from chromium configurations
https://bugs.webkit.org/show_bug.cgi?id=90313
Reviewed by Tony Chang.
Google has shipped the last version of Chrome that will support
Mac OS 10.5 (Leopard), and we no longer have bots that run this
configuration, so we're removing support for it.
A subsequent change will remove the baselines in platform/chromium-mac-leopard.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_complex_shadowing):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_versions):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_mac):
(FactoryTest.test_chromium_mac):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_and_copy_test_with_lion_result):
- 3:10 PM Changeset in webkit [121594] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] WebFontRendering.cpp requires some OS(ANDROID) ifdefs to build downstream
https://bugs.webkit.org/show_bug.cgi?id=90292
Reviewed by Nate Chapin.
These ifdefs are required to build this file downstream. There's some
sublte difference between how the OS flags are set upstream and
downstream. This is on our list of issues to resolve, but in the
meantime, this patch makes these files identical upstream and
downstream to reduce noise in the upstreaming queue.
- src/linux/WebFontRendering.cpp:
(WebKit::WebFontRendering::setSubpixelPositioning):
- 3:02 PM Changeset in webkit [121593] by
-
- 2 edits53 adds1 delete in trunk/LayoutTests
[Qt][WK2] Unskip/rebaseline some compositing tests.
https://bugs.webkit.org/show_bug.cgi?id=90290
Reviewed by Laszlo Gombos.
Rebaseline compositing tests that have good results that are slightly different than the
generic results, and unskipping several tests that should not be skipped.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/fixed-position-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/iframe-content-flipping-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/invisible-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/nested-composited-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/remove-iframe-crash-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/scroll-fixed-transformed-element-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/scroll-grandchild-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-in-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-on-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/remove-add-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/remove-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/rtl/rtl-relative-expected.txt: Added.
- 2:57 PM Changeset in webkit [121592] by
-
- 12 edits2 adds in trunk
Source/WebCore: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length
https://bugs.webkit.org/show_bug.cgi?id=89244
Patch by Hanna Ma <Hanma@rim.com> on 2012-06-29
Reviewed by Pavel Feldman.
Added data length to inspector timeline popup
content for resources to keep track of the amount of data loaded.
Tests: inspector/timeline/timeline-network-received-data.html
- English.lproj/localizedStrings.js:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willReceiveResourceData):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createReceiveResourceData):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._showPopover):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveData):
- inspector/timeline/timeline-network-received-data.html: Added.
- inspector/timeline/timeline-network-received-data-expected.txt: Added.
- inspector/timeline/timeline-test.js:
LayoutTests: Web Inspector: Add data length to resource events on timeline to
keep track of the amount of data loaded and the total data length.
https://bugs.webkit.org/show_bug.cgi?id=89244
Patch by Hanna Ma <Hanma@rim.com> on 2012-06-29
Reviewed by Pavel Feldman.
Added tests for resource receive data events.
- inspector/timeline/timeline-network-received-data-expected.txt: Added.
- inspector/timeline/timeline-network-received-data.html: Added.
- inspector/timeline/timeline-test.js:
- 2:53 PM Changeset in webkit [121591] by
-
- 3 edits in trunk/Tools
Fix optimize-baselines to not move baselines from win to win-7sp0
https://bugs.webkit.org/show_bug.cgi?id=90312
Reviewed by Dirk Pranke.
It used to consider win-7sp0 as the common directory for all the Apple
windows ports and incorrectly move results out of win.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
- 2:43 PM Changeset in webkit [121590] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Move intent delivery code from the frame to the page
https://bugs.webkit.org/show_bug.cgi?id=89974
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-29
Reviewed by Anders Carlsson.
Move the intent delivery code from the frame to the page
and add the corresponding C API for WKPage.
- UIProcess/API/C/WKPage.cpp:
(WKPageDeliverIntentToFrame):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::stopLoading):
- UIProcess/WebFrameProxy.h:
(WebKit):
- UIProcess/WebPageProxy.cpp:
(WebKit):
(WebKit::WebPageProxy::deliverIntentToFrame):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- 2:25 PM Changeset in webkit [121589] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after 121580.
WebKit Linux debug bots was complaining about signed vs unsigned integer comparison.
- html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
- 2:23 PM Changeset in webkit [121588] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed chromium xp rebaseline.
- platform/chromium-win-xp/http/tests/inspector: Added.
- platform/chromium-win-xp/http/tests/inspector/resource-tree: Added.
- platform/chromium-win-xp/http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt: Added.
- 2:13 PM Changeset in webkit [121587] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/platform/graphics/chromium/cc/CCOverdrawMetrics.cpp
Merge 121224 - [chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels
https://bugs.webkit.org/show_bug.cgi?id=89922
Reviewed by Adrienne Walker.
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10704050
- 2:11 PM Changeset in webkit [121586] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Page jumps after post-pinch-zoom re-render
https://bugs.webkit.org/show_bug.cgi?id=90282
Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>
PR: 170255
In r120622, we moved ScrollableArea::setConstrainsScrollingToContentEdge(false|true)
from WebPage::setScrollPosition() to BackingStorePrivate::setScrollingOrZooming()
to address an overscroll reset issue.
However, when we are ending bitmap zooming, UI thread can call
BackingStorePrivate::setScrollingOrZooming(false) before WebKit thread
calls WebPage::setScrollPosition(), in which case it will set
ScrollableArea::m_constrainsScrollingToContentEdge to true earlier.
To fix this, we can cache ScrollableArea::m_constrainsScrollingToContentEdge
and always set it to false before we set scroll position in WebKit
thread to avoid scroll position clamping during scrolling, and restore
it to what it was after that.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setScrollPosition):
- 1:32 PM Changeset in webkit [121585] by
-
- 2 edits2 adds1 delete in trunk/LayoutTests
Rebaseline some tests where Chrome differs due to V8's different toString implementation
for some built-ins. We should probably get V8 and JSC to agree here, but that's not terribly
pressing since the web clearly doesn't depend on the specifics here.
- platform/chromium-win/fast/js/global-constructors-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/js/function-names-expected.txt: Added.
- platform/chromium/fast/js/global-constructors-expected.txt: Added.
- 1:26 PM Changeset in webkit [121584] by
-
- 10 edits in trunk/Source/WebKit2
Can’t get basic element info from a WKRenderObject
https://bugs.webkit.org/show_bug.cgi?id=90301
Reviewed by Anders Carlsson.
Moved the element info (tag name, id and class names) from WebRenderLayer to WebRenderObject,
and gave WebRenderLayer a reference to a (shallow) WebRenderObject. Added WKRenderObject API
for getting element info, while leaving the WKRenderLayer API in place for now for Safari.
- Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetRenderer): Added this wrapper.
(WKRenderLayerCopyRendererName): Changed to get the name from the renderer.
(WKRenderLayerCopyElementTagName): Changed to go through the renderer.
(WKRenderLayerCopyElementID): Ditto.
(WKRenderLayerGetElementClassNames): Ditto.
- Shared/API/c/WKRenderLayer.h: Added declaration of WKRenderLayerGetRenderer() and comments
about removing older API.
- Shared/API/c/WKRenderObject.cpp:
(WKRenderObjectCopyElementTagName): Added this wrapper.
(WKRenderObjectCopyElementID): Ditto.
(WKRenderObjectGetElementClassNames): Ditto.
- Shared/API/c/WKRenderObject.h:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode): Removed the element info from the encoding of
WebRenderLayer, and added the renderer. Added the element info to the encoding of
WebRenderObject.
(WebKit::UserMessageDecoder::baseDecode): Updated to match the encoding changes.
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::WebRenderLayer): Changed to initialize the m_renderer member
variable with a WebRenderObject for the layer’s renderer, and removed the initialization of
the element-related member variables that were removed.
- Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::create): Changed to take a renderer instead of renderer and element
info.
(WebKit::WebRenderLayer::renderer): Added this getter.
(WebKit::WebRenderLayer::WebRenderLayer): Changed to take a renderer instead of renderer and
element info.
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create): Changed to pass true for the shouldIncludeDescendants
parameter.
(WebKit::WebRenderObject::WebRenderObject): Added a shouldIncludeDescdendants boolean
parameter. When it is false, the m_children array remains null. Added initialization of
member variables with the element’s tag name, id and class list.
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::create): Added an overload that takes a RenderObject and creates
a shallow WebRenderObject.
(WebRenderObject): Changed to take element tag name, id and class list.
(WebKit::WebRenderObject::elementTagName): Added this getter.
(WebKit::WebRenderObject::elementID): Ditto.
(WebKit::WebRenderObject::elementClassNames): Ditto.
(WebKit::WebRenderObject::WebRenderObject):
- 12:57 PM Changeset in webkit [121583] by
-
- 13 edits in trunk/Source
[chromium] Remove mapRect and mapQuad from WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=90230
Reviewed by Adrienne Walker.
Source/Platform:
Removes clipping-unaware mapRect, mapQuad and projectPoint functions from the WebTransformationMatrix interface.
- chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):
Source/WebCore:
Replaces calls to WebTransformationMatrix::mapRect/mapQuad with clipping-aware calls to CCMathUtils. In most
cases, we do not expect clipping to happen. For others (such as area calculations in CCOverdrawMetrics) we can
handle a clipped quad easily.
- platform/chromium/support/WebTransformationMatrix.cpp:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::drawableContentRect):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::getDrawRect):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::addOcclusionBehindLayer):
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore):
(WebCore::polygonArea):
(WebCore::areaOfMappedQuad):
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::didDraw):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawableContentRect):
- platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::isLayerAxisAlignedIntRect):
- 12:05 PM Changeset in webkit [121582] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after r121575. It rolls out r121547 but didn't roll out the follow up build fix r121553.
- platform/graphics/mac/FontCustomPlatformData.h:
(FontCustomPlatformData):
- 12:03 PM Changeset in webkit [121581] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed GTK gardening, adding a new baseline required after r121555.
- platform/gtk/fast/viewport/viewport-91-expected.txt: Added.
- 11:58 AM Changeset in webkit [121580] by
-
- 13 edits in trunk/Source/WebCore
Share the same cache in HTMLCollection and DynamicNodeLists
https://bugs.webkit.org/show_bug.cgi?id=90118
Reviewed by Anders Carlsson.
This patch introduces two new base classes DynamicNodeListCacheBase and HTMLCollectionCacheBase to share
the cache object between DynamicNodeList and HTMLCollection. HTMLCollectionCacheBase inherits from
DynamicNodeListCacheBase and contains extra caches and bit flags for HTMLCollection. DynamicNodeList::Cache
and HTMLCollection::Cache had been removed and flattened into these two classes for the easy inheritance.
In DynamicNodeList, we have a very straight forward one-to-one mapping from old Caches member variables:
m_caches.lastItem -> cachedItem()
m_caches.lastItemOffset -> cachedItemOffset()
m_caches.cachedLength -> cachedLength()
m_caches.isItemCacheValid -> isItemCacheValid()
m_caches.isLengthCacheValid -> isLengthCacheValid()
m_caches.type -> removed because it was never used.
m_caches.rootedAtDocument -> isRootedAtDocument()
m_caches.shouldInvalidateOnAttributeChange -> shouldInvalidateOnAttributeChange()
In HTMLCollection, there is one semantic change in the way item cache is managed. Previously, we only had
m_cache.current which was used as both cachedItem() and isItemCacheValid() (not valid when current is null).
There are some asymmetric code changes due to one-to-many relationship. Also, all method names have been updated
to use that of DynamicNodeList terminology. Thus we have the following correspondence:
m_cache.current -> cachedItem() / isItemCacheValid()
m_cache.position -> cachedItemOffset()
m_cache.length -> cachedLength()
m_cache.elementsArrayPosition -> cachedElementsArrayOffset()
m_cache.hasLength -> isLengthCacheValid()
m_cache.hasNameCache -> hasNameCache() / setHasNameCache()
m_cache.idCache -> idCache() / addIdCache()
m_cache.nameCache -> idCache() / addNameCache()
In addition, we had to rename HTMLCollection::clearCache to invalidateCache to avoid the name collision with
HTMLCollectionCacheBase::clearCache.
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):
- dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
- dom/DynamicNodeList.h:
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument):
(WebCore::DynamicNodeListCacheBase::shouldInvalidateOnAttributeChange):
(WebCore::DynamicNodeListCacheBase::isItemCacheValid):
(WebCore::DynamicNodeListCacheBase::cachedItem):
(WebCore::DynamicNodeListCacheBase::cachedItemOffset):
(WebCore::DynamicNodeListCacheBase::isLengthCacheValid):
(WebCore::DynamicNodeListCacheBase::cachedLength):
(WebCore::DynamicNodeListCacheBase::setLengthCache):
(WebCore::DynamicNodeListCacheBase::setItemCache):
(WebCore::DynamicNodeListCacheBase::clearCache):
(WebCore):
(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicNodeList::invalidateCache):
(WebCore::DynamicNodeList::rootNode):
(DynamicNodeList):
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::namedItemWithIndex):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::invalidateCacheIfNeeded):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::isAcceptableElement):
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::hasNamedItem):
(WebCore::HTMLCollection::namedItems):
(WebCore::HTMLCollectionCacheBase::append):
- html/HTMLCollection.h:
(HTMLCollectionCacheBase):
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(WebCore::HTMLCollectionCacheBase::type):
(WebCore::HTMLCollectionCacheBase::clearCache):
(WebCore::HTMLCollectionCacheBase::setItemCache):
(WebCore::HTMLCollectionCacheBase::cachedElementsArrayOffset):
(WebCore::HTMLCollectionCacheBase::includeChildren):
(WebCore::HTMLCollectionCacheBase::cacheTreeVersion):
(WebCore::HTMLCollectionCacheBase::idCache):
(WebCore::HTMLCollectionCacheBase::nameCache):
(WebCore::HTMLCollectionCacheBase::appendIdCache):
(WebCore::HTMLCollectionCacheBase::appendNameCache):
(WebCore::HTMLCollectionCacheBase::hasNameCache):
(WebCore::HTMLCollectionCacheBase::setHasNameCache):
(WebCore):
(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):
(WebCore::HTMLCollection::base):
(HTMLCollection):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::item):
(WebCore::HTMLFormCollection::updateNameCache):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
- html/HTMLNameCollection.h:
(HTMLNameCollection):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::invalidateSelectedItems):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::itemAfter):
- html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):
- 11:52 AM Changeset in webkit [121579] by
-
- 4 edits in trunk/LayoutTests
[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90287
Unreviewed gardening. Skip fast/viewport/viewport-91.html
for EFL, GTK and QT ports. The test is failing after r121555.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-29
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 11:43 AM Changeset in webkit [121578] by
-
- 18 edits in trunk/Source
Unreviewed, rolling out r121572.
http://trac.webkit.org/changeset/121572
https://bugs.webkit.org/show_bug.cgi?id=90249
Breaks Mac build since it depends on r121547, which was rolled
out
Source/WebCore:
- WebCore.exp.in:
- page/AlternativeTextClient.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
- platform/mac/WebCoreSystemInterface.h:
- platform/network/Credential.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
- platform/text/TextChecking.h:
(WebCore):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Source/WTF:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- 11:28 AM Changeset in webkit [121577] by
-
- 5 edits in trunk/Tools
Fix rebaselining for Qt and Apple ports
https://bugs.webkit.org/show_bug.cgi?id=90204
Reviewed by Dirk Pranke.
-Apporpriately put wk2 results in the -wk2 directories.
-Since Qt and Apple-Win don't have bots that correspond to the
platform/qt and platform/win directories, we need to fudge it
and always put the results in those directories for those ports.
- Scripts/webkitpy/layout_tests/port/builders.py:
(rebaseline_override_dir):
- Scripts/webkitpy/layout_tests/port/factory.py:
(_builder_options):
Identify webkit2 builders by the WK2 in the builder name.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._baseline_directory):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_baseline_directory):
- 11:27 AM Changeset in webkit [121576] by
-
- 3 edits in trunk/Source/WebKit/blackberry
Add blitVisibleContents() as public API.
https://bugs.webkit.org/show_bug.cgi?id=90211
Reviewed by Adam Treat.
We keep blitContents() (with src/dst rectangles)
for compatibility with older Cascades sprints for now,
but want to switch to always blitting the full viewport
and this is a good first step.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStore::blitVisibleContents):
(WebKit):
- Api/BackingStore.h:
- 11:14 AM Changeset in webkit [121575] by
-
- 21 edits in trunk/Source/WebCore
Unreviewed, rolling out r121547.
http://trac.webkit.org/changeset/121547
https://bugs.webkit.org/show_bug.cgi?id=90256
Breaks Chromium Mac build
- platform/LocalizedStrings.cpp:
(WebCore::imageTitle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore):
(WebCore::canSetCascadeListForCustomFont):
(WebCore::FontPlatformData::ctFont):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/mac/ComplexTextController.cpp:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore):
(WebCore::fontCacheATSNotificationCallback):
(WebCore::FontCache::platformInit):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- platform/graphics/mac/WebLayer.h:
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore):
(WebCore::DisplaySleepDisabler::systemActivityTimerFired):
- platform/mac/DisplaySleepDisabler.h:
(DisplaySleepDisabler):
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
- platform/mac/ScrollElasticityController.mm:
- 10:55 AM Changeset in webkit [121574] by
-
- 27 edits7 adds in trunk/Source
[chromium] Adding PrioritizedTexture and replacing ContentsTextureManager
https://bugs.webkit.org/show_bug.cgi?id=84308
Patch by Eric Penner <epenner@google.com> on 2012-06-29
Reviewed by Adrienne Walker.
Source/WebCore:
PrioritizedTextures have a priority such that all texture requests can be
prioritized. There are three steps involved:
- Call setRequestPriority()
- Check if the request succeeded with canAcquireBackingTexture()
- Call acquireBackingTexture() when uploading a new texture.
Internally both the texture requests and the backing textures get sorted.
Requests are sorted so they can be prioritized. Backing textures are sorted
so that they can be recycled/evicted in the right order (lowest priority first).
Prioritizing textures doesn't assign backing textures to texture requests but
rather just marks which textures can have a backing texture "when needed". This
allows us to keep the old textures in use as long as possible.
The unit tests support all the use cases from the original texture manager
but also adds assumptions about priority order throughout all the tests. The
function assertInvariants() is added to test the validity of the manager
and all textures/allocations within it.
The TiledLayerChromium tests are updated to request textures first with
prioritizeTextures(), and update them with the updater (such that allocate
gets called) before pushPropertiesTo is called (when they need to be valid).
- WebCore.gypi:
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapCanvasLayerTextureUpdater::createTexture):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(WebCore):
(Texture):
(BitmapCanvasLayerTextureUpdater):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::createTexture):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::setTexturePriorities):
(WebCore):
(WebCore::ContentLayerChromium::update):
- platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::Texture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::createTexture):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::Texture::Texture):
(WebCore::ImageLayerTextureUpdater::createTexture):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerChromium::setTexturePriorities):
(WebCore):
- platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::setTexturePriorities):
- platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::Texture::texture):
(WebCore::LayerTextureUpdater::Texture::swapTextureWith):
(WebCore::LayerTextureUpdater::Texture::Texture):
(Texture):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
- platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::managedTexture):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::textureManager):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::setTexturePriorities):
(WebCore):
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::evictAllContentTextures):
(WebCore::CCLayerTreeHost::contentsTextureManager):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::prioritizeTextures):
(WebCore::CCLayerTreeHost::deleteTextureAfterCommit):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCPrioritizedTexture.cpp: Added.
(WebCore):
(WebCore::CCPrioritizedTexture::CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::~CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::setTextureManager):
(WebCore::CCPrioritizedTexture::setDimensions):
(WebCore::CCPrioritizedTexture::requestLate):
(WebCore::CCPrioritizedTexture::acquireBackingTexture):
(WebCore::CCPrioritizedTexture::textureId):
(WebCore::CCPrioritizedTexture::bindTexture):
(WebCore::CCPrioritizedTexture::framebufferTexture2D):
(WebCore::CCPrioritizedTexture::setCurrentBacking):
- platform/graphics/chromium/cc/CCPrioritizedTexture.h: Added.
(WebCore):
(CCPrioritizedTexture):
(WebCore::CCPrioritizedTexture::create):
(WebCore::CCPrioritizedTexture::textureManager):
(WebCore::CCPrioritizedTexture::format):
(WebCore::CCPrioritizedTexture::size):
(WebCore::CCPrioritizedTexture::memorySizeBytes):
(WebCore::CCPrioritizedTexture::setRequestPriority):
(WebCore::CCPrioritizedTexture::requestPriority):
(WebCore::CCPrioritizedTexture::canAcquireBackingTexture):
(WebCore::CCPrioritizedTexture::haveBackingTexture):
(Backing):
(WebCore::CCPrioritizedTexture::Backing::size):
(WebCore::CCPrioritizedTexture::Backing::format):
(WebCore::CCPrioritizedTexture::Backing::memorySizeBytes):
(WebCore::CCPrioritizedTexture::Backing::textureId):
(WebCore::CCPrioritizedTexture::Backing::currentTexture):
(WebCore::CCPrioritizedTexture::Backing::setCurrentTexture):
(WebCore::CCPrioritizedTexture::Backing::Backing):
(WebCore::CCPrioritizedTexture::Backing::~Backing):
(WebCore::CCPrioritizedTexture::isAbovePriorityCutoff):
(WebCore::CCPrioritizedTexture::setAbovePriorityCutoff):
(WebCore::CCPrioritizedTexture::setManagerInternal):
(WebCore::CCPrioritizedTexture::currentBacking):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp: Added.
(WebCore):
(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::~CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::setMemoryAllocationLimitBytes):
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::clearPriorities):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::allBackingTexturesWereDeleted):
(WebCore::CCPrioritizedTextureManager::unlink):
(WebCore::CCPrioritizedTextureManager::link):
(WebCore::CCPrioritizedTextureManager::registerTexture):
(WebCore::CCPrioritizedTextureManager::unregisterTexture):
(WebCore::CCPrioritizedTextureManager::returnBackingTexture):
(WebCore::CCPrioritizedTextureManager::createBacking):
(WebCore::CCPrioritizedTextureManager::destroyBacking):
(WebCore::CCPrioritizedTextureManager::assertInvariants):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.h: Added.
(WebCore):
(CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::create):
(WebCore::CCPrioritizedTextureManager::createTexture):
(WebCore::CCPrioritizedTextureManager::memoryUseBytes):
(WebCore::CCPrioritizedTextureManager::memoryAboveCutoffBytes):
(WebCore::CCPrioritizedTextureManager::setMaxMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::maxMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::setPreferredMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::preferredMemoryLimitBytes):
(WebCore::CCPrioritizedTextureManager::setMaxMemoryPriorityCutoff):
(WebCore::CCPrioritizedTextureManager::maxMemoryPriorityCutoff):
(WebCore::CCPrioritizedTextureManager::compareTextures):
(WebCore::CCPrioritizedTextureManager::compareBackings):
- platform/graphics/chromium/cc/CCPriorityCalculator.cpp: Added.
(WebCore):
(WebCore::CCPriorityCalculator::uiPriority):
(WebCore::CCPriorityCalculator::visiblePriority):
(WebCore::CCPriorityCalculator::lingeringPriority):
(WebCore::CCPriorityCalculator::priorityFromDistance):
(WebCore::CCPriorityCalculator::priorityFromVisibility):
- platform/graphics/chromium/cc/CCPriorityCalculator.h: Added.
(WebCore):
(CCPriorityCalculator):
(WebCore::CCPriorityCalculator::highestPriority):
(WebCore::CCPriorityCalculator::lowestPriority):
(WebCore::CCPriorityCalculator::priorityIsLower):
(WebCore::CCPriorityCalculator::priorityIsHigher):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
- tests/CCPrioritizedTextureTest.cpp: Added.
(WTF):
(CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::texturesMemorySize):
(WTF::CCPrioritizedTextureTest::createManager):
(WTF::CCPrioritizedTextureTest::validateTexture):
(WTF::CCPrioritizedTextureTest::allocator):
(WTF::TEST_F):
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::Texture::Texture):
(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):
(WebKitTests::FakeLayerTextureUpdater::createTexture):
(WebKitTests::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
- tests/CCTiledLayerTestCommon.h:
(Texture):
(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):
(FakeTiledLayerWithScaledBounds):
- tests/TiledLayerChromiumTest.cpp:
- 10:47 AM Changeset in webkit [121573] by
-
- 3 edits in branches/safari-534.57-branch/Source/WebCore
Merge <rdar://problem/11736630>
- 10:36 AM Changeset in webkit [121572] by
-
- 18 edits in trunk/Source
Remove BUILDING_ON_LEOPARD now that no ports build on Leopard
https://bugs.webkit.org/show_bug.cgi?id=90249
Reviewed by Ryosuke Niwa.
Source/WebCore:
I don't think I quite got it all yet, but this is another step towards
removing Leopard support in WebCore.
- WebCore.exp.in:
- page/AlternativeTextClient.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
- platform/mac/WebCoreSystemInterface.h:
- platform/network/Credential.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
- platform/text/TextChecking.h:
(WebCore):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
Source/WebKit2:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Source/WTF:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- 10:29 AM Changeset in webkit [121571] by
-
- 3 edits in trunk/Tools
Add support for --force parameter to run-performance-tests
https://bugs.webkit.org/show_bug.cgi?id=90279
Reviewed by Dirk Pranke.
It's helpful to be able to run tests from the Skipped list of the performance tests.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
(test_collect_tests_with_skipped_list):
- 10:20 AM Changeset in webkit [121570] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r121562.
http://trac.webkit.org/changeset/121562
https://bugs.webkit.org/show_bug.cgi?id=89945
Broke a couple of editing/pasteboard tests.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::parentStyleSheet):
- css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(PropertySetCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentElement):
(WebCore):
- css/StylePropertySet.h:
(StylePropertySet):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::~StyledElement):
(WebCore):
(WebCore::StyledElement::styleAttributeChanged):
- dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::destroyInlineStyle):
- 10:17 AM Changeset in webkit [121569] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Add missing support for tiled shadow blur on fillRect
https://bugs.webkit.org/show_bug.cgi?id=90082
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-06-29
Reviewed by Noam Rosenthal.
This overloaded fillRect implementation also supports this optimization in
certain situations.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
- 9:48 AM Changeset in webkit [121568] by
-
- 8 edits in trunk
[GTK] Enable CSS grid layout LayoutTests on GTK+
https://bugs.webkit.org/show_bug.cgi?id=90226
Reviewed by Martin Robinson.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSGridLayoutEnabled): Pass through to Settings object.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
This feature is disabled via Settings by default, but for testing,
we enable it using layoutTestController.overridePreferences. Add the
necessary plumbing for DRT.
WTR already works because support was added for Apple Mac earlier.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Feature is off by default.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
LayoutTests:
- platform/gtk/TestExpectations: Tests should pass.
- 9:01 AM Changeset in webkit [121567] by
-
- 87 edits18 adds18 deletes in trunk/LayoutTests
Unreviewed gardening.
Rebaseline tests affected by r121452.
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
- platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/transitions/cross-fade-background-image-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win-xp/svg/carto.net: Removed.
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
- platform/chromium-win/svg/carto.net/scrollbar-expected.png:
- platform/chromium-win/svg/custom/image-small-width-height-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/transitions/cross-fade-background-image-expected.png:
- platform/chromium/TestExpectations:
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
- platform/win-7sp0/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
- platform/win-7sp0/svg/carto.net: Added.
- platform/win-7sp0/svg/carto.net/scrollbar-expected.png: Added.
- platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
- platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
- platform/win/svg/carto.net: Removed.
- platform/win/svg/carto.net/scrollbar-expected.png: Removed.
- 8:57 AM Changeset in webkit [121566] by
-
- 3 edits in trunk/Source/WebCore
Build fix - These should not be executable!
Rubberstamped by Jessie Berlin.
- loader/cache/CachedSVGDocument.cpp: Removed property svn:executable.
- loader/cache/CachedSVGDocument.h: Removed property svn:executable.
- 8:30 AM Changeset in webkit [121565] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout Test inspector/debugger/debugger-compile-and-run.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90285
Reviewed by Pavel Feldman.
- inspector/debugger/debugger-compile-and-run.html:
- 8:27 AM Changeset in webkit [121564] by
-
- 2 edits in trunk/Source/WebCore
Update FIXME comment in XMLDocumentParser::wellFormed
https://bugs.webkit.org/show_bug.cgi?id=90223
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-29
Reviewed by Adam Barth.
XMLDocumentParser::wellFormed is still used by the XMLHttpRequest to check if the responseXML was well formed.
So it can't be removed.
- xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
- 8:23 AM Changeset in webkit [121563] by
-
- 2 edits in trunk/Tools
[Qt] Added Qt port for garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=82719
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-06-29
Reviewed by Adam Barth.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 8:21 AM Changeset in webkit [121562] by
-
- 9 edits in trunk/Source/WebCore
Separate mutating CSSStyleDeclaration operations.
<http://webkit.org/b/89945>
Reviewed by Antti Koivisto.
Use separate paths for mutating the StylePropertySet wrapped by a CSSStyleDeclaration.
PropertySetCSSStyleDeclaration now has:
- propertySet() const
- ensureMutablePropertySet()
This is prep work for supporting immutable ElementAttributeData objects, the idea being
that calling ensureMutablePropertySet() may cause the element to convert its internal
attribute storage (which also holds the inline StylePropertySet.)
To that end, also removed the weird logic that allowed you to kill the inline style object
by removing the 'style' attribute. We now simply clear out all the properties in that case
which saves us a bunch of hassle (no need for a ~StyledElement anymore.)
Note that InlineCSSStyleDeclaration now refs the element rather than the inline style.
There should be no web-facing behavior change from any of this.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::ref):
(WebCore::InlineCSSStyleDeclaration::deref):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::parentStyleSheet):
(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):
- css/PropertySetCSSStyleDeclaration.h:
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::propertySet):
(WebCore::PropertySetCSSStyleDeclaration::ensureMutablePropertySet):
(InlineCSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
- dom/ElementAttributeData.cpp:
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::styleAttributeChanged):
- dom/StyledElement.h:
(WebCore::StyledElement::~StyledElement):
(StyledElement):
- 8:19 AM Changeset in webkit [121561] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Roll chromium rev to 144906
https://bugs.webkit.org/show_bug.cgi?id=90278
Unreviewed. Deps roll.
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-29
- DEPS:
- 8:16 AM Changeset in webkit [121560] by
-
- 2 edits in trunk/Source/WebCore
Don't call SegmentedString::toString() twice in XMLDocumentParser::append(const SegmentedString&)
https://bugs.webkit.org/show_bug.cgi?id=90254
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-29
Reviewed by Adam Barth.
We can reuse the local variable parseString instead of calling s.toString() again.
No behavior change, so no new tests.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
- 7:38 AM Changeset in webkit [121559] by
-
- 2 edits in trunk
Unreviewed build fix after r121518, adding a missing symbol to symbols.filter.
- Source/autotools/symbols.filter:
- 7:35 AM Changeset in webkit [121558] by
-
- 2 edits15 adds8 deletes in trunk/LayoutTests
[chromium] Unreviewed gardening.
New baselines for tests added in r121513.
- platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
- platform/chromium-linux/css3/filters/effect-reference-external-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-external-expected.txt: Removed.
- platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-hw-expected.txt: Removed.
- platform/chromium-linux/css3/filters/effect-reference-ordering-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-ordering-expected.txt: Removed.
- platform/chromium-mac/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-expected.txt: Added.
- platform/chromium-mac/css3/filters/effect-reference-external-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-ordering-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-external-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-ordering-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-ordering-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/css3/filters/effect-reference-external-expected.txt: Added.
- 7:31 AM Changeset in webkit [121557] by
-
- 7 edits10 adds in trunk
Crash when flowing a fixed positioned element into a region.
https://bugs.webkit.org/show_bug.cgi?id=88133
Reviewed by Julien Chaffraix and Abhishek Arya.
Source/WebCore:
When a fixed positioned element is collected into a named flow, we have to make sure
that such element has the RenderFlowThread as containing block instead of RenderView,
so that the fixed positioned element is laid out properly.
Making the RenderFlowThread the top most containing block for named flow elements required the
modification of RenderLayer::convertToLayerCoords so that the fixed positioned elements inside the
named flow take the same code path as the absolute positioned elements inside the named flow.
I also added a method, checkBlockPositionedObjectsNeedLayout, in order to verify that a block
that is ending its layout, setNeedsLayout(false), has all the positioned children laid out.
This way, we will hit an assertion if an out-of-flow positioned child inside a RenderFlowThread
is not laid out after the RenderFlowThread is laid out.
Tests: fast/regions/absolute-pos-elem-in-named-flow.html
fast/regions/absolute-pos-elem-in-region.html
fast/regions/fixed-pos-elem-in-named-flow.html
fast/regions/fixed-pos-elem-in-named-flow2.html
fast/regions/fixed-pos-elem-in-region.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::checkBlockPositionedObjectsNeedLayout):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::container):
- rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::setNeedsLayout):
LayoutTests:
When a fixed positioned element is collected into a named flow, we have to make sure
that such element has the RenderFlowThread as containing block instead of RenderView,
so that the fixed positioned element is laid out properly.
- fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
- fast/regions/absolute-pos-elem-in-named-flow.html: Added.
- fast/regions/absolute-pos-elem-in-region-expected.html: Added.
- fast/regions/absolute-pos-elem-in-region.html: Added.
- fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
- fast/regions/fixed-pos-elem-in-named-flow.html: Added.
- fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
- fast/regions/fixed-pos-elem-in-named-flow2.html: Added.
- fast/regions/fixed-pos-elem-in-region-expected.html: Added.
- fast/regions/fixed-pos-elem-in-region.html: Added.
- 6:52 AM Changeset in webkit [121556] by
-
- 5 edits in trunk
Web Inspector: [Device Metrics] "Fit window" option inhibits adjusting the page zoom factor
https://bugs.webkit.org/show_bug.cgi?id=90187
Reviewed by Vsevolod Vlasov.
Source/WebKit/chromium:
This change fixes the stale zoom factor, which does not get updated upon browser window resize in the "Fit window" mode.
The expected test results have little to do with actual dimensions of the test page in Chrome on a real mobile device,
since Chrome on the mobile uses a different zooming technique (pageScaleFactor-based viewport using layout width
rather than plain pageZoomFactor) and font boosting, which has not been upstreamed yet.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
LayoutTests:
- inspector/styles/override-screen-size-expected.txt:
- platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
- 5:51 AM Changeset in webkit [121555] by
-
- 24 edits in trunk/Source
Don't hardcode target dpi of 160 (it should be 96 on desktop)
https://bugs.webkit.org/show_bug.cgi?id=88114
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-29
Reviewed by Adam Barth.
Source/WebCore:
No behavioural change, current tests in fast/viewport cover all
functionality.
- WebCore.exp.in: Updated symbol for computeViewportAttributes.
- dom/ViewportArguments.cpp: Use new parameter for devicePixelRatio
and don't calculate it anymore.
(WebCore::computeViewportAttributes):
- dom/ViewportArguments.h: Change the deviceDPI parameter to
devicePixelRatio and put the onus
on the embedder to supply the
correct value. Add temporary constant.
(WebCore):
Source/WebKit/blackberry:
Added new WebSetting to specify what the devicePixelRatio should be.
Updated the call to computeViewportAttributes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::devicePixelRatio):
(BlackBerry::WebKit::WebSettings::setDevicePixelRatio):
- Api/WebSettings.h:
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::dumpConfigurationForViewport):
Source/WebKit/chromium:
Updated the call to computeViewportAttributes.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
Source/WebKit/efl:
Updated the call to computeViewportAttributes.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::dumpConfigurationForViewport):
- ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):
Source/WebKit/gtk:
Updated the call to computeViewportAttributes.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
- webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):
Source/WebKit/qt:
Updated the call to computeViewportAttributes.
- Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):
Source/WebKit2:
Updated the call to computeViewportAttributes.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::viewportConfigurationAsText):
- 5:49 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 5:47 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 5:25 AM Changeset in webkit [121554] by
-
- 3 edits in trunk/Source/WebCore
JS binding code generator doesn't handle "attribute unsigned long[]" well.
https://bugs.webkit.org/show_bug.cgi?id=84540
Patch by Vineet Chaudhary <Vineet> on 2012-06-29
Reviewed by Kentaro Hara.
In JS/V8 Bindings using traits instead of specialised functions.
Also added support for "unsigned long" in JSDOMBinding and V8Binding.
No new tests, as no behavioural changes.
- bindings/js/JSDOMBinding.h:
(WebCore::Traits::arrayJSValue):
(WebCore::jsArray):
- bindings/v8/V8Binding.h:
(WebCore::Traits::arrayV8Value):
(WebCore::v8Array):
- 5:23 AM Changeset in webkit [121553] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed mac build fix after r121547.
Remove the now-unused FontCustomPlatformData::m_atsContainer.
- platform/graphics/mac/FontCustomPlatformData.h:
(FontCustomPlatformData):
- 5:08 AM Changeset in webkit [121552] by
-
- 3 edits2 adds in trunk
<textarea> unnecessarily saves the value in some cases
https://bugs.webkit.org/show_bug.cgi?id=90259
Reviewed by Hajime Morita.
Source/WebCore:
Test: fast/forms/textarea/textarea-state-restore.html
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::saveFormControlState):
We apply EOL normalization to value(), but don't apply it to
defaultValue(). Also value() can return a null string, which never
equals to any strings. To check m_isDirty is what we need..
LayoutTests:
- fast/forms/textarea/textarea-state-restore-expected.txt: Added.
- fast/forms/textarea/textarea-state-restore.html: Added.
- 5:06 AM Changeset in webkit [121551] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: Provide source data for all known rule types in CSSParser, except "keyframe" and "region"
https://bugs.webkit.org/show_bug.cgi?id=88420
Reviewed by Antti Koivisto.
This change transitions the CSS source code model from a flat list of style rules to a tree of all types of CSS rules
(some of them lack actual source code data), which is crucial to model-based CSS stylesheet source editing
(add/remove CSS rule) and navigation.
As a side effect, the CSS parsing performance on PerformanceTests/Parser/css-parser-yui.html is improved roughly by 2%:
- originally: median= 282.051282051 runs/s, stdev= 1.51236798322 runs/s, min= 278.481012658 runs/s, max= 283.870967742 runs/s
- with patch applied: median= 287.206266319 runs/s, stdev= 1.31518320219 runs/s, min= 282.051282051 runs/s, max= 288.713910761 runs/s
No new tests, as there is no client-visible behavior change. Existing Inspector tests will be modified
to test the new data provided, along with the necessary Inspector plumbing.
- css/CSSGrammar.y:
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reattach): Check for mediaQueries() validity before reattaching.
- css/CSSParser.cpp: Unless explicitly specified below, the method changes are related to the extension of the
source-based CSS model provided by the parser.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseDeclaration): Accept a CSSRuleSourceData for filling, since it now contains
the related style source range.
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule): Create CSSMediaRule even if media and rules are empty,
which is consistent with Mozilla.
(WebCore::CSSParser::processAndAddNewRuleToSourceTreeIfNeeded):
(WebCore):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::fixUnparsedPropertyRanges):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleHeaderEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyStart):
(WebCore::CSSParser::markPropertyEnd):
- css/CSSParser.h:
(CSSParser):
- css/CSSPropertySourceData.h: Extend the model to handle more types of rules and their containments.
(WebCore):
(WebCore::CSSRuleSourceData::create):
(WebCore::CSSRuleSourceData::createUnknown):
(CSSRuleSourceData):
(WebCore::CSSRuleSourceData::CSSRuleSourceData):
- inspector/InspectorStyleSheet.cpp: Follow the CSSParser API changes but retain the flat stored CSS rules structure.
(ParsedStyleSheet):
(flattenSourceData): Flatten the rule tree to retain the existing rule-handling code intact.
(ParsedStyleSheet::setSourceData):
(ParsedStyleSheet::ruleSourceDataAt):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
(WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- inspector/InspectorStyleSheet.h:
- 5:05 AM Changeset in webkit [121550] by
-
- 4 edits in trunk/Tools
[Qt][WTR] Get rid of using DumpRenderTreeSupportQt
https://bugs.webkit.org/show_bug.cgi?id=90262
Reviewed by Alexey Proskuryakov.
Now that we decided to not support v8 in WebKit2
we can get rid of using DumpRenderTreeSupportQt
in WebKitTestRunner.
- Tools.pro:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
- 4:22 AM Changeset in webkit [121549] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Annotate TextViewer.js
https://bugs.webkit.org/show_bug.cgi?id=90266
Reviewed by Yury Semikhatsky.
Annotated TextViewer.js and fixed found errors.
Drive-by: Fixed NativeMemorySnapshotView.js compilation.
Drive-by: Fixed protocol-externs.js compilation.
Drive-by: Removed unused platform parameter from TextViewer constructor.
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::runScript):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart.prototype._updateView):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
- 4:21 AM Changeset in webkit [121548] by
-
- 1 edit2 adds1 delete in trunk/LayoutTests
[EFL] Gardening after r121468
https://bugs.webkit.org/show_bug.cgi?id=90257
Unreviewed EFL gardening after r121468.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-29
- platform/efl/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
- platform/efl/fast/forms/label/labelable-elements-expected.txt: Added.
- 3:44 AM Changeset in webkit [121547] by
-
- 21 edits in trunk/Source/WebCore
Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard
https://bugs.webkit.org/show_bug.cgi?id=90256
Reviewed by Ryosuke Niwa.
- platform/LocalizedStrings.cpp:
(WebCore::imageTitle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/mac/ComplexTextController.cpp:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- platform/graphics/mac/WebLayer.h:
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
- platform/mac/DisplaySleepDisabler.h:
(DisplaySleepDisabler):
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
- platform/mac/ScrollElasticityController.mm:
- 3:31 AM Changeset in webkit [121546] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt at a build fix for 64-bit debug build,
touch InsertionPoint.cpp to try to get it rebuilt.
- html/shadow/InsertionPoint.cpp:
(WebCore):
- 3:15 AM Changeset in webkit [121545] by
-
- 3 edits in trunk/Tools
Revert r121540, it broke most Qt builds
- 3:09 AM Changeset in webkit [121544] by
-
- 2 edits in trunk/Tools
[Qt] Make build-webkit reject uknown configurations, eg. --profile
The qmake-based buildsystem doesn't support it.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-29
Reviewed by Tor Arne Vestbø.
- Scripts/webkitdirs.pm:
(buildQMakeProjects):
- 3:03 AM Changeset in webkit [121543] by
-
- 4 edits in trunk
[Qt] Don't add Qt module dependencies in features.prf
The required dependencies are already added in WebCore.pri.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-29
Reviewed by Tor Arne Vestbø.
- 2:54 AM Changeset in webkit [121542] by
-
- 10 edits3 adds in trunk
Web Inspector: Add FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=73301
This patch introduce a split view as FileSystemView. Including directory tree as sidebar tree.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-29
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: http/tests/inspector/filesystem/directory-tree.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.Entry.compare):
- inspector/front-end/FileSystemView.js: Added.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showFileSystem):
(WebInspector.FileSystemTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement.prototype.onattach):
(WebInspector.FileSystemTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemTreeElement.prototype._refreshFileSystem):
(WebInspector.FileSystemTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- http/tests/inspector/filesystem/directory-tree-expected.txt: Added.
- http/tests/inspector/filesystem/directory-tree.html: Added.
- http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.incrementRequestCount):
(initialize_FileSystemTest.decrementRequestCount):
(initialize_FileSystemTest.InspectorTest.callOnRequestCompleted):
- 2:50 AM Changeset in webkit [121541] by
-
- 17 edits in trunk/Source/WebCore
[V8] Replace v8::Integer::New() with v8Integer() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=90242
Reviewed by Yury Semikhatsky.
v8Integer() is a fast wrapper of v8::Integer::New().
This patch replaces v8::Integer::New() with v8Integer() in custom bindings,
and pass isolates.
No tests. No change in behavior.
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyQuery):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAccessorGetter):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionDetailsCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::portsAccessorGetter):
- bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::V8Storage::indexedPropertyGetter):
(WebCore::V8Storage::namedPropertyQuery):
(WebCore::V8Storage::indexedPropertySetter):
(WebCore::V8Storage::indexedPropertyDeleter):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
- 2:49 AM Changeset in webkit [121540] by
-
- 3 edits in trunk/Tools
[Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø..
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/functions.prf:
- 2:44 AM Changeset in webkit [121539] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r121520.
http://trac.webkit.org/changeset/121520
https://bugs.webkit.org/show_bug.cgi?id=90246
the performance optimization needs more investigation
- dom/DatasetDOMStringMap.cpp:
(WebCore::convertPropertyNameToAttributeName):
- dom/Element.cpp:
(WebCore::Element::getAttributeNS):
(WebCore::Element::removeAttribute):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::getAttributeNode):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- 2:35 AM Changeset in webkit [121538] by
-
- 17 edits in trunk/Source/WebCore
[V8] Replace v8::Integer::New() with v8Integer() in bindings/v8/*.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=90238
Reviewed by Yury Semikhatsky.
v8Integer() is a fast wrapper of v8::Integer::New().
We can replace v8::Integer::New() with v8Integer()
in bindings/v8/*.{h,cpp}. In addition, we pass isolate
to v8Integer() where possible.
No tests. No change in behavior.
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- bindings/v8/NPV8Object.cpp:
(_NPN_Enumerate): Changed v8::None to 0, for consistency with other code.
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::compileScript):
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/V8Binding.cpp:
(WebCore::v8Array):
(WebCore::v8ValueToWebCoreDOMStringList):
- bindings/v8/V8Binding.h:
(WebCore::v8Array):
(WebCore::v8NumberArrayToVector):
- bindings/v8/V8Collection.h:
(WebCore::nodeCollectionIndexedPropertyEnumerator):
(WebCore::collectionIndexedPropertyEnumerator):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectQueryProperty):
(WebCore::npObjectPropertyEnumerator):
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
- bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureConstants):
(WebCore::V8Proxy::compileScript):
- bindings/v8/V8Utilities.cpp:
(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
- bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
- bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
- bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
- 2:32 AM Changeset in webkit [121537] by
-
- 7 edits2 adds in trunk
Web Inspector: Resource content is not loaded if Resource.requestContent method is called before network request is finished.
https://bugs.webkit.org/show_bug.cgi?id=90153
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/resource-tree/resource-request-content-while-loading.html
- inspector/front-end/NetworkRequest.js:
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._requestFinished):
LayoutTests:
Resource.requestContent() now checks that request (if there is one) was already loaded before requesting content from PageAgent.
Drive-by: Removed unneeded legacy request._resource field.
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/resource-tree/resource-request-content-while-loading-expected.txt: Added.
- http/tests/inspector/resource-tree/resource-request-content-while-loading.html: Added.
- http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished.checkResources):
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest.InspectorTest.resourceMatchingURL.visit):
(initialize_ResourceTest.InspectorTest.resourceMatchingURL):
(initialize_ResourceTest):
- inspector/debugger/raw-source-code.html:
- 2:17 AM Changeset in webkit [121536] by
-
- 33 edits in trunk/Source
Unreviewed, rolling out r121529.
http://trac.webkit.org/changeset/121529
https://bugs.webkit.org/show_bug.cgi?id=90260
Failed to compile on Chromium WebKitMacBuilder (Requested by
keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-29
Source/WebCore:
- platform/LocalizedStrings.cpp:
(WebCore):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/text/cf/HyphenationCF.cpp:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Source/WebKit/mac:
- DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
- Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebEditorClient::getGuessesForWord):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
- WebView/WebView.mm:
(+[WebView initialize]):
(-[WebView _deviceScaleFactor]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 2:12 AM Changeset in webkit [121535] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Add toggle breakpoint shortcut.
https://bugs.webkit.org/show_bug.cgi?id=90188
Reviewed by Yury Semikhatsky.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._toggleBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.selection):
- 2:09 AM Changeset in webkit [121534] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Cursor should follow execution line when debugging.
https://bugs.webkit.org/show_bug.cgi?id=90184
Reviewed by Yury Semikhatsky.
Added TextViewer.setSelection public method to set cursor selection in the editor.
Added TextRange.createFromLocation method to create TextRanges with the same start and end points.
Drive-by: removed unused _setCaretLocation() method in TextViewer.js
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._editorSelected):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype.setContent):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.createFromLocation):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.setSelection):
(WebInspector.TextEditorMainPanel.prototype.highlightLine):
- 2:05 AM Changeset in webkit [121533] by
-
- 9 edits in trunk
Web Inspector: IDBObjectStore.autoIncrement flag not exposed
https://bugs.webkit.org/show_bug.cgi?id=89701
Reviewed by Yury Semikhatsky.
Source/WebCore:
Plumbed objectStore.autoIncrement to inspector front-end and added it to tooltip.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.ObjectStore):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
LayoutTests:
- http/tests/inspector/indexeddb/database-structure-expected.txt:
- http/tests/inspector/indexeddb/database-structure.html:
- 2:02 AM Changeset in webkit [121532] by
-
- 3 edits in trunk/Source/WebKit/chromium
Deleting unused function in WebDeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=90185
Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-29
Reviewed by Adam Barth.
Deleting the unused copy assignment function in WebDeviceOrientation.
- public/WebDeviceOrientation.h:
(WebDeviceOrientation):
- src/WebDeviceOrientation.cpp:
- 1:55 AM Changeset in webkit [121531] by
-
- 5 edits2 adds in trunk
Use floating keyframe rule list when parsing @-webkit-keyframes and allow abrupt rule termination
https://bugs.webkit.org/show_bug.cgi?id=90073
Reviewed by Antti Koivisto.
Source/WebCore:
- The grammar is changed to allow abruptly terminated stylesheet in the @-webkit-keyframes (use closing_brace, not '}').
- A floating StyleKeyframe vector is introduced to separate the creation and filling of StyleRuleKeyframes, as other rules do.
Test: fast/css/css-keyframe-unexpected-end.html
- css/CSSGrammar.y:
- css/CSSParser.cpp:
(WebCore::CSSParser::createFloatingKeyframeVector):
(WebCore):
(WebCore::CSSParser::sinkFloatingKeyframeVector):
(WebCore::CSSParser::createKeyframesRule):
- css/CSSParser.h:
LayoutTests:
- fast/css/css-keyframe-unexpected-end-expected.txt: Added.
- fast/css/css-keyframe-unexpected-end.html: Added.
- 1:46 AM Changeset in webkit [121530] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: add character data to the DOM section of native memory view
https://bugs.webkit.org/show_bug.cgi?id=89968
Reviewed by Vsevolod Vlasov.
Count strings referenced from CharacterData node and its descendants
as part of the DOM tree structures in the native memory view.
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
(WebCore):
- dom/CharacterData.h:
(CharacterData):
- dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryObjectInfo::reportString):
(MemoryObjectInfo):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::domTreeInfo):
(WebCore::jsExternalResourcesInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- 1:28 AM Changeset in webkit [121529] by
-
- 33 edits in trunk/Source
Remove more BUILDING_ON_LEOPARD branches now that no port builds on Leopard
https://bugs.webkit.org/show_bug.cgi?id=90252
Reviewed by Ryosuke Niwa.
Source/WebCore:
- platform/LocalizedStrings.cpp:
(WebCore):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- platform/text/cf/HyphenationCF.cpp:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Source/WebKit/mac:
- DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
- Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebEditorClient::getGuessesForWord):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
- WebView/WebView.mm:
(+[WebView initialize]):
(-[WebView _deviceScaleFactor]):
Source/WebKit2:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 1:14 AM Changeset in webkit [121528] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: showConsole() should close previous view in drawer.
https://bugs.webkit.org/show_bug.cgi?id=90070
Reviewed by Yury Semikhatsky.
- inspector/front-end/inspector.js:
(WebInspector.showConsole):
(WebInspector.showPanel):
- 12:59 AM BuildingQtOnLinux edited by
- Update the required dependencies on Debian/Ubuntu command (diff)
- 12:46 AM Changeset in webkit [121527] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r121494. Added new baseline to
fast/frames/flattening/frameset-flattening-advanced.html
Patch by János Badics <János Badics> on 2012-06-29
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- 12:44 AM Changeset in webkit [121526] by
-
- 2 edits in trunk/Source/WebCore
Remove a #include erroneously added in r120896.
- editing/VisibleSelection.h:
- 12:26 AM Changeset in webkit [121525] by
-
- 9 edits3 adds in trunk/Source
[Platform] Implement Date Time format parser
https://bugs.webkit.org/show_bug.cgi?id=89963
Reviewed by Kent Tamura.
Source/WebCore:
This patch introduces Unicode TR35 LDML date time format parser for
input type "time" if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true.
Test: WebKit/chromium/tests/DateTimeFormatTest.cpp
- CMakeLists.txt: Added DateTimeFormat.cpp
- GNUmakefile.list.am: Added DateTimeFormat.{cpp,h}
- Target.pri: ditto
- WebCore.gypi: ditto
- WebCore.vcproj/WebCore.vcproj: ditto
- WebCore.xcodeproj/product.pbxproj: ditto
- platform/text/DateTimeFormat.cpp: Added.
(WebCore::mapCharacterToFieldTypeInternal):
(WebCore::DateTimeFormat::DateTimeFormat):
(WebCore::DateTimeFormat::mapCharacterToFieldType):
(WebCore::DateTimeFormat::parse):
- platform/text/DateTimeFormat.h: Added.
(DateTimeFormat):
(TokenHandler):
(WebCore::DateTimeFormat::TokenHandler::~TokenHandler):
Source/WebKit/chromium:
This patch adds an unit test for date time format parser if
ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true.
- tests/DateTimeFormatTest.cpp: Added.
(DateTimeFormatTest):
(Token):
(DateTimeFormatTest::Token::Token):
(DateTimeFormatTest::Token::operator==):
(DateTimeFormatTest::Token::toString):
(Tokens):
(DateTimeFormatTest::Tokens::Tokens):
(DateTimeFormatTest::Tokens::operator==):
(DateTimeFormatTest::Tokens::toString):
(DateTimeFormatTest::parse):
(DateTimeFormatTest::single):
(TokenHandler):
(DateTimeFormatTest::TokenHandler::~TokenHandler):
(DateTimeFormatTest::TokenHandler::fieldType):
(DateTimeFormatTest::TokenHandler::tokens):
(DateTimeFormatTest::TokenHandler::visitField):
(DateTimeFormatTest::TokenHandler::visitLiteral):
(operator<<):
(TEST_F):
- 12:15 AM Changeset in webkit [121524] by
-
- 15 edits in trunk/Source
Remove more BUILDING_ON_LEOPARD usage in PLATFORM(MAC) code
https://bugs.webkit.org/show_bug.cgi?id=85846
Reviewed by Adam Barth.
PLATFORM(MAC) has not supported Leopard for several months now.
This change removes about 1/3 of the remaining BUILDING_ON_LEOPARD
uses in the PLATFORM(MAC) codepaths. PLATFORM(CHROMIUM) still
supports BUILDING_ON_LEOPARD for now.
Source/WebCore:
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::updateRangesAfterChildrenChanged):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):
(WebCore::Document::textNodeSplit):
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):
- editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard):
- loader/EmptyClients.h:
(EmptyEditorClient):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- page/EditorClient.h:
(EditorClient):
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagSearchWeb):
- platform/MemoryPressureHandler.cpp:
(WebCore):
- platform/SuddenTermination.h:
(WebCore):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::constrainedSize):
- platform/graphics/ca/PlatformCALayer.h:
(PlatformCALayer):
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(fromCAValueFunctionType):
(PlatformCAAnimation::valueFunction):
(PlatformCAAnimation::setValueFunction):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(toCAFilterType):
(PlatformCALayer::anchorPoint):
(PlatformCALayer::setAnchorPoint):
(PlatformCALayer::contentsTransform):
(PlatformCALayer::setContentsTransform):
(PlatformCALayer::isGeometryFlipped):
(PlatformCALayer::setGeometryFlipped):
(PlatformCALayer::acceleratesDrawing):
(PlatformCALayer::setAcceleratesDrawing):
(PlatformCALayer::setMinificationFilter):
(PlatformCALayer::setMagnificationFilter):
(PlatformCALayer::contentsScale):
(PlatformCALayer::setContentsScale):
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setScale):
(WebCore::TileCache::setAcceleratesDrawing):
(WebCore::TileCache::createTileLayer):
Source/WTF:
- wtf/Platform.h:
- 12:06 AM Changeset in webkit [121523] by
-
- 3 edits in trunk/Source/WebCore
Use StringBuilder in SegmentedString::toString()
https://bugs.webkit.org/show_bug.cgi?id=90247
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-06-29
Reviewed by Adam Barth.
Use a StringBuilder instead of String concatenation because StringBuilder is generally faster.
No new tests. Covered by existing tests.
- platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::toString):
- platform/text/SegmentedString.h:
(WebCore::SegmentedSubstring::appendTo):
