Context Navigation

← Previous Period
Next Period →

Timeline

Jul 7, 2012:

9:03 PM Changeset in webkit [122058] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[EFL][CMake] Remove non-existent include directory
https://bugs.webkit.org/show_bug.cgi?id=90605

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-07
Reviewed by Kentaro Hara.

PlatformEfl.cmake:

6:08 PM FeatureFlags edited by tkent@chromium.org

Add TEXT_AUTOSIZING (diff)

6:02 PM Changeset in webkit [122057] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/efl

[EFL] Fix build break when Accelerated Compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=90718

Unreviewed build fix.

ewk_view_accelerated_compositing_XXX APIs are in ewk_view_private.h

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-07-07

WebCoreSupport/PageClientEfl.cpp:

(PageClientEfl::createEvasObjectForAcceleratedCompositing):
(PageClientEfl::acceleratedCompositingContext):

WebCoreSupport/PageClientEfl.h:

(PageClientEfl):

3:26 PM Changeset in webkit [122056] by staikos@webkit.org

4 edits in trunk/Source/WebKit/blackberry

Detach animation clients properly if we clear the web page pointer.
https://bugs.webkit.org/show_bug.cgi?id=90730

Reviewed by Adam Treat.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):

Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

1:53 PM Changeset in webkit [122055] by fpizlo@apple.com

2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90729

Unreviewed, skip crashing test.

platform/mac/Skipped:

12:49 PM Changeset in webkit [122054] by zandobersek@gmail.com

4 edits in trunk

REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=90719

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Follow the approach of the BlackBerry port outlined in r122035, using in exitFullScreenForElement
the fullscreen element to which the reference was saved when enterFullScreenForElement was called.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

Remove the crashing test expectation for the affected test.

platform/gtk/TestExpectations:

1:27 AM Changeset in webkit [122053] by commit-queue@webkit.org

4 edits in trunk/Tools

Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90712

Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-07
Reviewed by Alexey Proskuryakov.

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(DOMWindowExtensionBasic):

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(DOMWindowExtensionNoCache):

TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

12:26 AM Changeset in webkit [122052] by fpizlo@apple.com

2 edits in trunk/LayoutTests

media/media-blocked-by-beforeload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90725

Unreviewed, skip flaky test.

platform/mac/Skipped:

12:22 AM Changeset in webkit [122051] by fpizlo@apple.com

2 edits in trunk/LayoutTests

compositing/iframes/iframe-size-from-zero.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90724

Unreviewed, skip flaky test.

platform/mac/Skipped:

12:17 AM Changeset in webkit [122050] by fpizlo@apple.com

2 edits in trunk/LayoutTests

inspector/debugger/set-breakpoint.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90723

Unreviewed, skip crashing test.

platform/mac/Skipped:

12:13 AM Changeset in webkit [122049] by fpizlo@apple.com

2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-comparison-show-next.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90722

Unreviewed, skip crashing test.

platform/mac/Skipped:

Jul 6, 2012:

11:36 PM Changeset in webkit [122048] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a test expectation for
a crashing test introduced in r122035.

platform/gtk/TestExpectations:

9:50 PM Applications using WebKit edited by wesley

(diff)

9:49 PM Applications using WebKit edited by wesley

(diff)

9:48 PM Applications using WebKit edited by wesley

(diff)

5:43 PM Changeset in webkit [122047] by fpizlo@apple.com

4 edits
6 adds in trunk

WebKit Version 5.1.7 (6534.57.2, r121935): Double-click no longer works on OpenStreetMap
https://bugs.webkit.org/show_bug.cgi?id=90703

Source/JavaScriptCore:

Reviewed by Michael Saboff.

It turns out that in my object model refactoring, I managed to fix get_by_pname in all
execution engines except 64-bit baseline JIT.

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_pname):

LayoutTests:

Reviewed by Michael Saboff.

fast/js/get-by-pname-expected.txt: Added.
fast/js/get-by-pname-non-final-object-expected.txt: Added.
fast/js/get-by-pname-non-final-object.html: Added.
fast/js/get-by-pname.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/get-by-pname-non-final-object.js: Added.

(foo):

fast/js/script-tests/get-by-pname.js: Added.

(foo):

5:23 PM Changeset in webkit [122046] by Lucas Forschler

5 edits in branches/safari-534.57-branch/Source

Versioning.

5:18 PM Changeset in webkit [122045] by Lucas Forschler

1 copy in tags/Safari-534.57.7

New Tag.

5:13 PM Changeset in webkit [122044] by Lucas Forschler

5 edits in branches/safari-534.57-branch/Source

Versioning.

4:48 PM Changeset in webkit [122043] by fpizlo@apple.com

2 edits in trunk/LayoutTests

fast/canvas/webgl/gl-vertexattribpointer.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90711

Unreviewed, skip crashing test.

platform/mac/Skipped:

4:38 PM Changeset in webkit [122042] by fpizlo@apple.com

2 edits in trunk/LayoutTests

plugins/npruntime/leak-window-scriptable-object.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90710

Unreviewed. skip failing test.

platform/mac/Skipped:

4:18 PM Changeset in webkit [122041] by fpizlo@apple.com

2 edits in trunk/LayoutTests

iframe and global variable related inspector tests are failing
https://bugs.webkit.org/show_bug.cgi?id=90709

Unreviewed, skip failing tests.

platform/mac/Skipped:

4:14 PM Changeset in webkit [122040] by fpizlo@apple.com

2 edits in trunk/LayoutTests

fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed, skip failing test.

platform/mac/Skipped:

4:09 PM Changeset in webkit [122039] by fpizlo@apple.com

2 edits in trunk/LayoutTests

inspector/timeline/timeline-receive-response-event is flaky
https://bugs.webkit.org/show_bug.cgi?id=90707

Unreviewed, skip flaky test.

platform/mac/Skipped:

4:04 PM Changeset in webkit [122038] by fpizlo@apple.com

2 edits in trunk/LayoutTests

Reproducible crash in inspector/timeline/timeline-frames.html
https://bugs.webkit.org/show_bug.cgi?id=90706

Unreviewed, skip crashng test.

platform/mac/Skipped:

3:44 PM Changeset in webkit [122037] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
https://bugs.webkit.org/show_bug.cgi?id=90705

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-07-06
Reviewed by Noam Rosenthal.

Use QImage.constBits() as argument to packPixels instead of bits() to avoid
deep copying it.

platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

3:13 PM Changeset in webkit [122036] by aestes@apple.com

2 edits in trunk/Source/WebCore

Fix errors reported by generate-bindings.pl after r121882.

DerivedSources.make: Specify the correct path for notifications idl

files now that notifications/ lives in WebCore/Modules/.

2:40 PM Changeset in webkit [122035] by commit-queue@webkit.org

5 edits
2 adds in trunk

[BlackBerry] exitFullScreenForElement() is not working for fullscreen elements in iframes
https://bugs.webkit.org/show_bug.cgi?id=90327

Patch by Max Feil <mfeil@rim.com> on 2012-07-06
Reviewed by Antonio Gomes.

Source/WebKit/blackberry:

Fix exit fullscreen problem for elements in iframes. The
exitFullScreenForElement() call is passed a null element in
this case, instead of the original element which entered
fullscreen. If you look in Document.cpp you can see the
exitFullScreenForElement() call being made on the topDocument
(which has a null m_fullScreenElement) instead of the iframe's
document.

The Chromium and Windows ports get around this problem by
storing either the fullscreen element or its frame during
enterFullScreenForElement(), so I will bring the BlackBerry port
in line with this. See also bug 89817.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

LayoutTests:

Test of exit fullscreen for an iframe.

fullscreen/exit-full-screen-iframe-expected.txt: Added.
fullscreen/exit-full-screen-iframe.html: Added.

1:43 PM Changeset in webkit [122034] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

Add an API to explicitly call a JavaScript function with args.
https://bugs.webkit.org/show_bug.cgi?id=90694

Currently the Blackberry port doesn't expose the JavaScript
engine to 3rd parties so they rely upon executeJavaScript
which can be slower than necessary and unsafe as eval is used.
This new API provides a way to explicitly call a specific
JavaScript function with a list of args preventing the case
where an argument comes from a untrusted source and tries to
escape the arg list to take control of the JavaScript engine.

In the future if the Blackberry port introduces a formal
way to interact with the JavaScript engine this function should
be removed.

PR 149294

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-06
Reviewed by Unreviewed

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(WebKit):

Api/WebPage.h:

1:41 PM Changeset in webkit [122033] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Build Error on Qt Linux build
https://bugs.webkit.org/show_bug.cgi?id=90699

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-06
Reviewed by Laszlo Gombos.

parser/Parser.cpp:

(JSC::::parseForStatement):
Removed unused boolean variable as this was causing build error on Qt Linux.

1:22 PM Changeset in webkit [122032] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merge - 121360 [gtk] Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Reviewed by Gustavo Noronha Silva.

Work-around a bug in Pango by trying to detect apostrophes
that create contractions. This work-around is similar to one
found in gtkspell.

webkit/webkitspellcheckerenchant.cpp:

(wordEndIsAContractionApostrophe): Added this helper which tries to detect
situations where a word end is both an apostrophe and followed by a alphabetic
character.
(checkSpellingOfString): When searching for the end of a word, skip over
apostrophes that appear to be part of contractions.

1:22 PM Changeset in webkit [122031] by Martin Robinson

158 edits in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 109100 - Rebaseline Gtk results after r109097.

Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-28

platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
platform/gtk/svg/batik/filters/feTile-expected.txt:
platform/gtk/svg/batik/filters/filterRegions-expected.txt:
platform/gtk/svg/batik/masking/maskRegions-expected.txt:
platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
platform/gtk/svg/batik/paints/patternRegions-expected.txt:
platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
platform/gtk/svg/batik/text/textAnchor-expected.txt:
platform/gtk/svg/batik/text/textDecoration-expected.txt:
platform/gtk/svg/batik/text/textEffect-expected.txt:
platform/gtk/svg/batik/text/textEffect2-expected.txt:
platform/gtk/svg/batik/text/textEffect3-expected.txt:
platform/gtk/svg/batik/text/textFeatures-expected.txt:
platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
platform/gtk/svg/batik/text/textLayout-expected.txt:
platform/gtk/svg/batik/text/textLayout2-expected.txt:
platform/gtk/svg/batik/text/textLength-expected.txt:
platform/gtk/svg/batik/text/textOnPath-expected.txt:
platform/gtk/svg/batik/text/textOnPath2-expected.txt:
platform/gtk/svg/batik/text/textOnPath3-expected.txt:
platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
platform/gtk/svg/batik/text/textPosition-expected.txt:
platform/gtk/svg/batik/text/textPosition2-expected.txt:
platform/gtk/svg/batik/text/textProperties-expected.txt:
platform/gtk/svg/batik/text/textProperties2-expected.txt:
platform/gtk/svg/batik/text/textStyles-expected.txt:
platform/gtk/svg/batik/text/verticalText-expected.txt:
platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
platform/gtk/svg/carto.net/button-expected.txt:
platform/gtk/svg/carto.net/colourpicker-expected.txt:
platform/gtk/svg/carto.net/slider-expected.txt:
platform/gtk/svg/carto.net/window-expected.txt:
platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt:
platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt:
platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt:
platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt:
platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt:
platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt:
platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt:
platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt:
platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt:
platform/gtk/svg/clip-path/clip-path-with-container-expected.txt:
platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt:
platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt:
platform/gtk/svg/css/clippath-with-shadow-expected.txt:
platform/gtk/svg/css/mask-with-shadow-expected.txt:
platform/gtk/svg/custom/broken-internal-references-expected.txt:
platform/gtk/svg/custom/clip-path-referencing-use-expected.txt:
platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
platform/gtk/svg/custom/pattern-rotate-expected.txt:
platform/gtk/svg/custom/recursive-clippath-expected.txt:
platform/gtk/svg/custom/recursive-mask-expected.txt:
platform/gtk/svg/custom/recursive-pattern-expected.txt:
platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
platform/gtk/svg/custom/struct-use-09-b-expected.txt:
platform/gtk/svg/custom/use-clipped-hit-expected.txt:
platform/gtk/svg/custom/use-detach-expected.txt:
platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt:
platform/gtk/svg/custom/use-dynamic-append-expected.txt:
platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt:
platform/gtk/svg/custom/use-elementInstance-methods-expected.txt:
platform/gtk/svg/custom/use-empty-reference-expected.txt:
platform/gtk/svg/custom/use-event-handler-on-referenced-element-expected.txt:
platform/gtk/svg/custom/use-event-handler-on-use-element-expected.txt:
platform/gtk/svg/custom/use-events-crash-expected.txt:
platform/gtk/svg/custom/use-instanceRoot-modifications-expected.txt:
platform/gtk/svg/custom/use-modify-container-in-target-expected.txt:
platform/gtk/svg/custom/use-modify-target-container-expected.txt:
platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
platform/gtk/svg/custom/use-nested-transform-expected.txt:
platform/gtk/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
platform/gtk/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
platform/gtk/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
platform/gtk/svg/custom/use-on-g-containing-use-expected.txt:
platform/gtk/svg/custom/use-on-g-expected.txt:
platform/gtk/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
platform/gtk/svg/custom/use-on-rect-expected.txt:
platform/gtk/svg/custom/use-on-symbol-expected.txt:
platform/gtk/svg/custom/use-on-text-expected.txt:
platform/gtk/svg/custom/use-on-use-expected.txt:
platform/gtk/svg/custom/use-property-changes-through-dom-expected.txt:
platform/gtk/svg/custom/use-property-changes-through-svg-dom-expected.txt:
platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
platform/gtk/svg/custom/use-recursion-1-expected.txt:
platform/gtk/svg/custom/use-recursion-2-expected.txt:
platform/gtk/svg/custom/use-recursion-3-expected.txt:
platform/gtk/svg/custom/use-recursion-4-expected.txt:
platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
platform/gtk/svg/custom/use-transform-expected.txt:
platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
platform/gtk/svg/filters/filter-placement-issue-expected.txt:
platform/gtk/svg/filters/filter-refresh-expected.txt:
platform/gtk/svg/filters/filter-source-position-expected.txt:
platform/gtk/svg/hixie/error/014-expected.txt:
platform/gtk/svg/hixie/error/017-expected.txt:
platform/gtk/svg/hixie/use/001-expected.txt:
platform/gtk/svg/hixie/use/002-expected.txt:
platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt:
platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
platform/gtk/svg/text/text-gradient-positioning-expected.txt:
platform/gtk/svg/text/text-path-01-b-expected.txt:
platform/gtk/svg/text/text-text-04-t-expected.txt:
platform/gtk/svg/text/text-text-05-t-expected.txt:
platform/gtk/svg/text/text-text-06-t-expected.txt:
platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt:
platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:

1:22 PM Changeset in webkit [122030] by Martin Robinson

232 edits
4 deletes in releases/WebKitGTK/webkit-1.8

Merge 109097 - Integrate SVGUseElement within the new shadow root concept
https://bugs.webkit.org/show_bug.cgi?id=78902

Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-28
Reviewed by Zoltan Herczeg.

Source/WebCore:

Replace SVG shadow tree implementation with the new, modern #shadow-root implementation.

Current situation in trunk:
SVGUseElement doesn't create/hold the shadow tree, unlike its expected in
the modern #shadow-root concept, but its renderer RenderSVGShadowTreeRootContainer.
That creates a cycle, as the actual DOM tree is stored as RefPtr<SVGGElement> inside
a renderer - that's weak conceptually, and has lead to sublte security bugs in the past.

Whenever a target element of a <use> element changed, invalidateShadowTree() is called
which calls setNeedsStyleRecalc(), and sets m_needsShadodwTreeRecreation to true.
Once style recalculation happens, the RenderSVGShadowTreeRootContainer then eventually
built the shadow tree, by cloning the target node, building the SVGElementInstance tree
etc, -- all within the render tree.

To easy reviewing, here's a dump of the current render tree for a simple <use> example:
<defs><rect id="rect"/></defs><use xlink:href="#rect"/>

Dump of render tree:
RenderSVGHiddenContainer {defs} <defs> (SVGDefsElement)

RenderSVGRect {rect} <rect> (SVGRectElement)

RenderSVGShadowTreeRootContainer {use} <use> (SVGUseElement)

RenderSVGContainer {g} <g> (SVGShadowTreeRootElement)

RenderSVGRect {rect} <rect> (SVGRectElement, clone of <rect> in <defs>)

The SVGShadowTreeRootElement is created & stored by RenderSVGShadowTreeRootContainer,
the renderer of the <use> element. The RenderSVGTransformableContainer renderer created
for the SVGShadowTreeRootElement stores the x/y translation induced by the <use> attributes.

There are lots of places all over WebCore that assume the existance of a <g> renderer
as first child of the <use> element, representing the "SVG shadow tree root".

Summary of this patch:
Let SVGUseElement create&maintain a #shadow-root, and append the cloned target elements
into this shadow root. We no longer have to take care of attachment/detachment, style
recalculation, etc. - that's handled transparenly by ShadowRoot(List) now.

This makes SVGShadowTreeElements & RenderSVGShadowTreeRootContainer obsolete. Switch
SVGUseElement to create a RenderSVGTransformableContainer as its renderer, and make
it respect the translation induced by the x/y attributes, given for a <use> element.

Remove all occourences of SVGShadowRoot, remove all special cases it induced.

It's all covered by existing tests, took a while to make them all pass again.

CMakeLists.txt: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList): Enable fast path for selector checking, now that special shadow tree rules are gone.

css/SelectorChecker.cpp:

(WebCore::linkAttribute): No need to guard this code with ENABLE(SVG).
(WebCore::SelectorChecker::checkSelector): Remove obsolete SVG shadow root special case.

dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules): Remove loop, simplify & cleanup this code.
(WebCore::EventDispatcher::adjustToShadowBoundaries): s/isShadowRootOrSVGShadowRoot/isShadowRoot/.
(WebCore::EventDispatcher::adjustRelatedTarget): Ditto.
(WebCore::EventDispatcher::ensureEventAncestors): Simplify logic for SVG, fixed a FIXME.

dom/Node.cpp: Remove obsolete svgShadowHost().

(WebCore::Node::shadowTreeRootNode): Remove obsolete isSVGShadowRoot() checks.
(WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
(WebCore::Node::isInShadowTree): Make it const.

dom/Node.h: Remove isSVGShadowRoot/svgShadowHost.

(WebCore::Node::isShadowRoot): s/IsShadowRootOrSVGShadowRootFlag/isShadowRoot/.
(WebCore::Node::parentNode): Augment comments.
(WebCore::Node::parentNodeGuaranteedHostFree): Ditto.

dom/Range.cpp:

(WebCore::Range::checkNodeBA): Remove obsolete SVG shadow root special case.

dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript): Ditto.

rendering/RenderObject.h: Remove isSVGShadowTreeRootContainer.

(WebCore::RenderObject::isSVGTransformableContainer): Added.

rendering/svg/RenderSVGAllInOne.cpp: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
rendering/svg/RenderSVGModelObject.cpp:

(WebCore::isGraphicsElement): To check for <use>, a tag name comparision is needed now, as it no longer has a special renderer.

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Ditto.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Ditto.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Ditto.

rendering/svg/RenderSVGResourceContainer.cpp: Remove RenderSVGShadowTreeRootContainer.h include.
rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Removed.
rendering/svg/RenderSVGShadowTreeRootContainer.h: Removed.
rendering/svg/RenderSVGTransformableContainer.cpp: Keep track of last used additional x/y translation.

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Handle x/y translation for <use> contains here, instead of storing it in the SVGShadowTreeRootElement.

rendering/svg/RenderSVGTransformableContainer.h: Store last used x/y translation.

(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer): Return true.
(WebCore::toRenderSVGTransformableContainer): Add conversion helpers.

rendering/svg/RenderSVGViewportContainer.cpp: Ditto.

(WebCore::RenderSVGViewportContainer::calcViewport): Handle width/height attributes inheritance from the <use> element, if we're a <svg> or <symbol> replacement in the shadow tree.

rendering/svg/RenderSVGViewportContainer.h: Remove isSVGContainer() override which is not needed here (already present in RenderSVGContainer).
rendering/svg/SVGShadowTreeElements.cpp: Removed.
rendering/svg/SVGShadowTreeElements.h: Removed.
svg/SVGAElement.cpp:

(WebCore::SVGAElement::createRenderer): Check if parentNode is really a SVGElement, before casting.

svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement): Early exit if tag name isn't <svg>, or if we're in a shadow tree (can't be an outermost <svg> element then).
(WebCore::hasLoadListener): Deploy parentOrHostElement() usage to remove any special cases, related to shadow boundaries.
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
(WebCore::SVGElement::customStyleForRenderer): Ditto.

svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Call updateStyleIfNeeded() instead of updateLayoutIgnorePendingStylesheets().

svg/SVGGElement.cpp:

(WebCore::SVGGElement::rendererIsNeeded): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.

svg/SVGGElement.h: Remove obsolete isShadowTreeContainerElement().
svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::nearestViewportElement): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.
(WebCore::SVGLocatable::farthestViewportElement): Ditto.
(WebCore::SVGLocatable::computeCTM): Ditto.

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title): Ditto. (+ simplify code a lot, no need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.)
(WebCore::SVGStyledElement::rendererIsNeeded): Ditto.

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement): Remove no longer needed m_updatesBlocked.
(WebCore::SVGUseElement::create): Always call ensureShadowRoot(), to create a #shadow-root, upon creating a SVGUseElement.
(WebCore::SVGUseElement::insertedIntoDocument): Align with SVGFEImageElement/SVGTRefElement - call buildPendingResource() from insertedIntoDocument(), finally! (no renderer needed anymore to update the SVG shadow subtree).
(WebCore::SVGUseElement::removedFromDocument): Align with SVGFEImageElement/SVGTRefElement - immediately release the SVGElementInstance & shadow tree, once we're removed from the document.
(WebCore::SVGUseElement::svgAttributeChanged): Simplify code a lot, no longer need to deal with x/y/width/height attributes, the renderes in the shadow tree grab these values from their corresponding <use> elements automatically now.
(WebCore::SVGUseElement::willRecalcStyle):

New main part of the logic. invalidateShadowTree() calls setNeedsStyleRecalc, and sets m_needsShadowTreeRecreation=true. If we encounter this case, force rebuilding the SVG shadow tree
and the SVGElementInstance tree, immediately, before executing the actual style recalc. This allows us to lazily rebuild the SVG shadow tree for the <use> element. Consider:
<defs><rect id="rect"></defs> <use xlink:href="#rect"/>. Now from a script we change the rect x/y/width/height attributes:
rect.setAttribute("x", "10"); rect.setAttribute("y", "10")... each call will lead to a SVGUseElement::invalidateShadowTree() call by SVGElementInstance::invalidateAllInstancesOfElement, invoked after the <rect> element got parsed.
This won't update the shadow tree four times, but only once upon the next style recalculation - otherwise performance is a nightmare.
This will serve as future starting point, to explore partial SVG subtree re-clones, which should easily be doable now.

(WebCore::dumpInstanceTree): Add a 'static' to allow DUMP_INSTANCE_TREE to be used in clang builds.
(WebCore::SVGUseElement::clearResourceReferences): Added helper to release instance & shadow tree.
(WebCore::SVGUseElement::buildPendingResource): Modeled exactly like SVGFEImageElement/SVGTRefElement. It's possible to share more code between these in future.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Cleanup code, adapt to new shadow-root concept.
(WebCore::SVGUseElement::createRenderer): Create a RenderSVGTransformableContainer, no longer a <use> specific renderer.
(WebCore::removeDisallowedElementsFromSubtree): Use new replacedChild/appendChild variants, that don't require a ExceptionCode to be passed in.
(WebCore::SVGUseElement::buildShadowTree): Ditto.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::invalidateShadowTree): Only trigger style recalculations if needed.

svg/SVGUseElement.h: Remove lots of now unnecessary overrides: attach/detach/didRecalcStyle/updateContainerOffset/updateContainerSizes/etc..
svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedIntoDocument): No need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.

LayoutTests:

Update results after the <use> rewrite. Lots of RendeSVGContainer lines are
gone in the expected results, as the artifical <g> element representing the
SVG shadow root is gone, replaced by a standar #shadow-root.

platform/chromium/test_expectations.txt:
platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
platform/mac/svg/batik/filters/feTile-expected.txt:
platform/mac/svg/batik/filters/filterRegions-expected.txt:
platform/mac/svg/batik/masking/maskRegions-expected.txt:
platform/mac/svg/batik/paints/gradientLimit-expected.txt:
platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
platform/mac/svg/batik/paints/patternRegionA-expected.txt:
platform/mac/svg/batik/paints/patternRegions-expected.txt:
platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
platform/mac/svg/batik/text/longTextOnPath-expected.txt:
platform/mac/svg/batik/text/smallFonts-expected.txt:
platform/mac/svg/batik/text/textAnchor-expected.txt:
platform/mac/svg/batik/text/textDecoration-expected.txt:
platform/mac/svg/batik/text/textEffect-expected.txt:
platform/mac/svg/batik/text/textEffect2-expected.txt:
platform/mac/svg/batik/text/textEffect3-expected.txt:
platform/mac/svg/batik/text/textFeatures-expected.txt:
platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
platform/mac/svg/batik/text/textLayout-expected.txt:
platform/mac/svg/batik/text/textLayout2-expected.txt:
platform/mac/svg/batik/text/textLength-expected.txt:
platform/mac/svg/batik/text/textOnPath-expected.txt:
platform/mac/svg/batik/text/textOnPath2-expected.txt:
platform/mac/svg/batik/text/textOnPath3-expected.txt:
platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
platform/mac/svg/batik/text/textPosition-expected.txt:
platform/mac/svg/batik/text/textPosition2-expected.txt:
platform/mac/svg/batik/text/textProperties-expected.txt:
platform/mac/svg/batik/text/textProperties2-expected.txt:
platform/mac/svg/batik/text/textStyles-expected.txt:
platform/mac/svg/batik/text/verticalText-expected.txt:
platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
platform/mac/svg/carto.net/button-expected.txt:
platform/mac/svg/carto.net/colourpicker-expected.txt:
platform/mac/svg/carto.net/slider-expected.txt:
platform/mac/svg/carto.net/window-expected.txt:
platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt:
platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt:
platform/mac/svg/clip-path/clipper-placement-issue-expected.txt:
platform/mac/svg/css/clippath-with-shadow-expected.txt:
platform/mac/svg/css/mask-with-shadow-expected.txt:
platform/mac/svg/custom/broken-internal-references-expected.txt:
platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
platform/mac/svg/custom/embedding-external-svgs-expected.txt:
platform/mac/svg/custom/path-textPath-simulation-expected.txt:
platform/mac/svg/custom/pattern-rotate-expected.txt:
platform/mac/svg/custom/recursive-clippath-expected.txt:
platform/mac/svg/custom/recursive-mask-expected.txt:
platform/mac/svg/custom/recursive-pattern-expected.txt:
platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt:
platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
platform/mac/svg/custom/struct-use-09-b-expected.txt:
platform/mac/svg/custom/use-clipped-hit-expected.txt:
platform/mac/svg/custom/use-css-events-expected.txt:
platform/mac/svg/custom/use-detach-expected.txt:
platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
platform/mac/svg/custom/use-disappears-after-style-update-expected.txt:
platform/mac/svg/custom/use-dynamic-append-expected.txt:
platform/mac/svg/custom/use-elementInstance-event-target-expected.txt:
platform/mac/svg/custom/use-elementInstance-methods-expected.txt:
platform/mac/svg/custom/use-empty-reference-expected.txt:
platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.txt:
platform/mac/svg/custom/use-event-handler-on-use-element-expected.txt:
platform/mac/svg/custom/use-events-crash-expected.txt:
platform/mac/svg/custom/use-font-face-crash-expected.txt:
platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
platform/mac/svg/custom/use-modify-target-container-expected.txt:
platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
platform/mac/svg/custom/use-nested-transform-expected.txt:
platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
platform/mac/svg/custom/use-on-g-expected.txt:
platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
platform/mac/svg/custom/use-on-rect-expected.txt:
platform/mac/svg/custom/use-on-symbol-expected.txt:
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
platform/mac/svg/custom/use-on-text-expected.txt:
platform/mac/svg/custom/use-on-use-expected.txt:
platform/mac/svg/custom/use-property-changes-through-dom-expected.txt:
platform/mac/svg/custom/use-property-changes-through-svg-dom-expected.txt:
platform/mac/svg/custom/use-property-synchronization-crash-expected.txt:
platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
platform/mac/svg/custom/use-recursion-1-expected.txt:
platform/mac/svg/custom/use-recursion-2-expected.txt:
platform/mac/svg/custom/use-recursion-3-expected.txt:
platform/mac/svg/custom/use-recursion-4-expected.png:
platform/mac/svg/custom/use-recursion-4-expected.txt:
platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
platform/mac/svg/custom/use-symbol-overflow-expected.txt:
platform/mac/svg/custom/use-transform-expected.txt:
platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
platform/mac/svg/filters/filter-placement-issue-expected.txt:
platform/mac/svg/filters/filter-refresh-expected.txt:
platform/mac/svg/filters/filter-source-position-expected.txt:
platform/mac/svg/hixie/error/014-expected.txt:
platform/mac/svg/hixie/error/017-expected.txt:
platform/mac/svg/hixie/use/001-expected.txt:
platform/mac/svg/hixie/use/002-expected.txt:
platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt:
platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
platform/mac/svg/text/text-gradient-positioning-expected.txt:
platform/mac/svg/text/text-path-01-b-expected.txt:
platform/mac/svg/text/text-text-04-t-expected.txt:
platform/mac/svg/text/text-text-05-t-expected.txt:
platform/mac/svg/text/text-text-06-t-expected.txt:
platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
svg/clip-path/clip-path-childs-clipped-expected.txt:
svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
svg/clip-path/clip-path-clipped-expected.txt:
svg/clip-path/clip-path-clipped-nonzero-expected.txt:
svg/clip-path/clip-path-on-clipped-use-expected.txt:
svg/clip-path/clip-path-use-as-child-expected.txt:
svg/css/circle-in-mask-with-shadow-expected.txt:
svg/custom/deep-dynamic-updates-expected.txt:
svg/custom/non-scaling-stroke-expected.txt:
svg/custom/resource-client-removal-expected.txt:
svg/custom/use-clipped-transform-expected.txt:
svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
svg/custom/use-forward-refs-expected.txt:
svg/custom/use-image-in-g-expected.txt:
svg/custom/use-in-symbol-with-offset-expected.txt:
svg/custom/use-inherit-style-expected.txt:
svg/custom/use-move-to-offset-expected.txt:
svg/custom/use-multiple-on-nested-disallowed-font-expected.txt:
svg/custom/use-on-clip-path-with-transformation-expected.txt:
svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
svg/custom/use-setAttribute-crash-expected.txt:
svg/custom/use-transfer-width-height-properties-to-svg-expected.txt:
svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt:
svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
svg/repaint/inner-svg-change-viewPort-relative-expected.txt:

1:20 PM Changeset in webkit [122029] by Martin Robinson

13 edits
16 adds in releases/WebKitGTK/webkit-1.8

Merge 108699 - Recompute font metrics on scale changes
https://bugs.webkit.org/show_bug.cgi?id=75091

Patch by Philip Rogers <pdr@google.com> on 2012-02-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVG text metrics depend on the transform from renderer to the svg root
which requires that we propagate transform changes down to text.
This change adds a boolean for tracking transform changes to
SVGViewportContainers and SVGTransformableContainers, and updates
RenderSVGText::layout() to recalculate text metrics if the transform
of an ancestor has changed.

Tests: platform/mac/svg/text/text-rescale.html

platform/mac/svg/text/text-viewbox-rescale.html
svg/text/text-rescale.html
svg/text/text-viewbox-rescale.html

rendering/RenderObject.h:

(WebCore::RenderObject::isSVGTransformableContainer):
(WebCore::RenderObject::isSVGViewportContainer):

rendering/svg/RenderSVGContainer.h:

(WebCore::RenderSVGContainer::didTransformToRootUpdate):

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::layout):

rendering/svg/RenderSVGText.h:

(WebCore::RenderSVGText::setNeedsTextMetricsUpdate):
(RenderSVGText):

rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

rendering/svg/RenderSVGTransformableContainer.h:

(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::didTransformToRootUpdate):
(RenderSVGTransformableContainer):

rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):

rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::didTransformToRootUpdate):
(RenderSVGViewportContainer):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::transformToRootChanged):
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren):

rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

platform/chromium-linux/svg/text/text-rescale-expected.png: Added.
platform/chromium-linux/svg/text/text-rescale-expected.txt: Added.
platform/chromium-linux/svg/text/text-viewbox-rescale-expected.png: Added.
platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Added.
platform/chromium/test_expectations.txt:
platform/mac/svg/text/text-rescale-expected.png: Added.
platform/mac/svg/text/text-rescale-expected.txt: Added.
platform/mac/svg/text/text-rescale.html: Added.
platform/mac/svg/text/text-viewbox-rescale-expected.png: Added.
platform/mac/svg/text/text-viewbox-rescale-expected.txt: Added.
platform/mac/svg/text/text-viewbox-rescale.html: Added.
svg/text/text-rescale-expected.png: Added.
svg/text/text-rescale-expected.txt: Added.
svg/text/text-rescale.html: Added.
svg/text/text-viewbox-rescale-expected.png: Added.
svg/text/text-viewbox-rescale-expected.txt: Added.
svg/text/text-viewbox-rescale.html: Added.

1:20 PM Changeset in webkit [122028] by Martin Robinson

3 edits
3 adds in releases/WebKitGTK/webkit-1.8

Merge 109345 - Crash in WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget
https://bugs.webkit.org/show_bug.cgi?id=79831

Patch by Stephen Chenney <schenney@chromium.org> on 2012-03-01
Reviewed by Eric Seidel.

Out-of-order operations in the SVGSMILElement::removedFromDocument
method caused its target to be removed and then re-added due to a
later call. This led to the target being set on the animation while
the target element itself was unaware. At deletion time, this caused a
crash (or assert in debug builds). Thanks to Abhishek Arya for help
with the layout test.

Source/WebCore:

Test: svg/animations/smil-element-target-crash-main.html

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFromDocument):

LayoutTests:

svg/animations/resources/smil-element-target-crash.svg: Added.
svg/animations/smil-element-target-crash-main-expected.txt: Added.
svg/animations/smil-element-target-crash-main.html: Added.

1:20 PM Changeset in webkit [122027] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 108847 - Overhanging floats not removed from new flex box.
https://bugs.webkit.org/show_bug.cgi?id=79522

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-24
Reviewed by Ojan Vafai.

Source/WebCore:

Similar to r69476.

Test: fast/flexbox/overhanging-floats-not-removed-crash.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

fast/flexbox/overhanging-floats-not-removed-crash-expected.txt: Added.
fast/flexbox/overhanging-floats-not-removed-crash.html: Added.

1:20 PM Changeset in webkit [122026] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 108372 - Crash in RenderTableSection::nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=78922

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-21
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-section-node-at-point-crash.html

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
m_needsCellRecalc is set. Otherwise, we will end up accessing
removed table cells.

LayoutTests:

fast/table/table-section-node-at-point-crash-expected.txt: Added.
fast/table/table-section-node-at-point-crash.html: Added.

1:20 PM Changeset in webkit [122025] by Martin Robinson

3 edits
7 adds in releases/WebKitGTK/webkit-1.8

Merge 108543 - Cloning and linebox issues in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78273

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-22
Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/multicol/span/clone-flexbox.html

fast/multicol/span/clone-summary.html
fast/multicol/span/textbox-not-removed-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): Fix cloning algorithm to take
care of cloning descendant classes of RenderBlock.
(WebCore::RenderBlock::splitBlocks): When we move our inline children
to cloneBlock, we need to clear our entire line box tree. Any descendant
child in the hierarchy could be a part of our line box tree and will
never get cleared since the child has moved to new parent cloneBlock.

LayoutTests:

fast/multicol/span/clone-flexbox-expected.png:
fast/multicol/span/clone-flexbox-expected.txt: Added.
fast/multicol/span/clone-flexbox.html: Added. Test passes if we

see two RenderFlexibox in the rendertree.

fast/multicol/span/clone-summary-expected.png: Added.
fast/multicol/span/clone-summary-expected.txt: Added.
fast/multicol/span/clone-summary.html: Added. Test passes if we

see two RenderSummary in the rendertree.

fast/multicol/span/textbox-not-removed-crash-expected.txt: Added.
fast/multicol/span/textbox-not-removed-crash.html: Added. Test

passes it we do not crash on m_hasBadParent assert in InlineBox.

1:19 PM Changeset in webkit [122024] by Martin Robinson

3 edits
3 adds in releases/WebKitGTK/webkit-1.8

Merge 109140 - Incorrect before child parent calculation when adding new children
to anonymous column blocks.
https://bugs.webkit.org/show_bug.cgi?id=79755

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-28
Reviewed by David Hyatt.

Source/WebCore:

before child can be wrapped in anonymous containers, so need to
take care of that in before child parent calculation.

Test: fast/multicol/span/before-child-anonymous-column-block.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):

LayoutTests:

Test passes if you don't see the div block inside table and you see
two blocks in different columns in the pixel test.

fast/multicol/span/before-child-anonymous-column-block-expected.png: Added.
fast/multicol/span/before-child-anonymous-column-block-expected.txt: Added.
fast/multicol/span/before-child-anonymous-column-block.html: Added.

1:19 PM Changeset in webkit [122023] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 108415 - ContainerNode::childrenChanged must be called immediately after removing children
https://bugs.webkit.org/show_bug.cgi?id=79162

Patch by Adam Klein <adamk@chromium.org> on 2012-02-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

In r108152, a call to childrenChanged() was erroneously moved
below the call to child->removedFromDocument(). This breaks, at the
least, the behavior of the <title> element. This patch corrects the
mistake and adds a test.

Test: fast/dom/title-directionality-removeChild.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

LayoutTests:

fast/dom/title-directionality-removeChild-expected.txt: Added.
fast/dom/title-directionality-removeChild.html: Added.

1:19 PM Changeset in webkit [122022] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8

Merge 108152 - Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
https://bugs.webkit.org/show_bug.cgi?id=76087

Patch by Adam Klein <adamk@chromium.org> on 2012-02-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.

Tests: fast/dom/getElementById-consistency.html

fast/dom/getElementById-consistency2.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.

LayoutTests:

fast/dom/getElementById-consistency-expected.txt: Added.
fast/dom/getElementById-consistency.html: Added.
fast/dom/getElementById-consistency2-expected.txt: Added.
fast/dom/getElementById-consistency2.html: Added.

1:19 PM Changeset in webkit [122021] by Martin Robinson

4 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 112051 - Crash in ContainerNode::resumePostAttachCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=82159

Patch by Abhishek Arya <inferno@chromium.org> on 2012-03-25
Reviewed by Hajime Morita.

Source/WebCore:

Test: plugins/object-onfocus-mutation-crash.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::resumePostAttachCallbacks): dispatching post attach
callbacks when our attach depth is 1 can fire mutation events such as onfocus
which can blow away |this|. Need to protect it with a RefPtr.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::attach): add calls to suspend attach callbacks
until the function completes.

LayoutTests:

plugins/object-onfocus-mutation-crash-expected.txt: Added.
plugins/object-onfocus-mutation-crash.html: Added.

1:19 PM Changeset in webkit [122020] by Martin Robinson

3 edits
3 adds in releases/WebKitGTK/webkit-1.8

Merge 110326 - Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
https://bugs.webkit.org/show_bug.cgi?id=80186

Patch by Tom Sepez <tsepez@chromium.org> on 2012-03-09
Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/css/cross-fade-reload.html

css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

LayoutTests:

http/tests/css/cross-fade-reload-expected.txt: Added.
http/tests/css/cross-fade-reload.html: Added.
http/tests/css/resources/abe.png: Added.

1:19 PM Changeset in webkit [122019] by Martin Robinson

34 edits in releases/WebKitGTK/webkit-1.8

Merge 119192 - REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
https://bugs.webkit.org/show_bug.cgi?id=86859

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

The test tries to reach an invalid SpellChecker object. Such an access should be guarded
beforehand.

Asynchronous spellchecking can return results after originated
frame is gone, which triggered an invalid access to the dead spellchecker
object. This chagne prevents it by marking request objects from
the spellchecker as invalid:

Originally TextCheckerClient API was passed a SpellCheker object. This change abstracted it behind TextCheckingRequest interface, didSucceed() and didCancel() method specifically.
TextCheckingRequest was turned from a plain old object into a refcounted abstract class, which is now subclassed by SpellCheckRequest.
SpellChecker now marks pending SpellCheckRequest objects as invalid on its destructor.

Test: editing/spelling/spellcheck-async-remove-frame.html

WebCore.exp.in:
editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellCheckRequest::didSucceed):
(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::wasRequestedBy):
(WebCore::SpellCheckRequest::requesterDestroyed):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::didCheckSucceed):
(WebCore::SpellChecker::didCheckCancel):

editing/SpellChecker.h:

(WebCore):
(SpellCheckRequest):
(WebCore::SpellCheckRequest::isStarted):
(SpellChecker):

loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

platform/text/TextCheckerClient.h:

(TextCheckerClient):

platform/text/TextChecking.h:

(GrammarDetail):
(TextCheckingResult):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):

Source/WebKit/blackberry:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

Removed a port specific fix which was introduced at r117572.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit::EditorClientImpl::requestCheckingOfString):

src/EditorClientImpl.h:

(WebCore):
(EditorClientImpl):

src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

src/WebTextCheckingCompletionImpl.h:

(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):

Source/WebKit/efl:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder initWithClient:sequence:results:]):
(-[WebEditorSpellCheckResponder perform]):
(WebEditorClient::didCheckSucceeded):
(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/wince:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

WebProcess/WebCoreSupport/WebEditorClient.h:

LayoutTests:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

platform/mac/Skipped: Unskipped the test.

1:18 PM Changeset in webkit [122018] by Martin Robinson

13 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 114605 - Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748

Reviewed by Ryosuke Niwa.

Source/WebCore:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

Test: platform/chromium/editing/spelling/delete-misspelled-word.html

WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.

editing/SpellChecker.h:

(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.

Source/WebKit/chromium:

This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.

public/WebTextCheckingCompletion.h:

(WebKit::WebTextCheckingCompletion::didCancelCheckingText):

src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

src/WebTextCheckingCompletionImpl.h:

(WebTextCheckingCompletionImpl):

Source/WebKit/mac:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().

WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.

Tools:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.

LayoutTests:

platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
platform/chromium/editing/spelling/delete-misspelled-word.html: Added.

Conflicts:

Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp

1:05 PM Changeset in webkit [122017] by Martin Robinson

12 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 113127 - Prevent spellchecking text pasted to an element having spellchecking disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Patch by Hironori Bono <hbono@chromium.org> on 2012-04-03
Reviewed by Hajime Morita.

This change prevent calling SpellChecker::requestCheckingFor when pasting text
to an element whose spellcheck attribute is false or a password input.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-disabled.html

editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Disabled spellchecking on password inputs.

editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable): Return false when spellchecking is disabled.

LayoutTests:

editing/spelling/spellcheck-paste-disabled-expected.txt: Added.
editing/spelling/spellcheck-paste-disabled.html: Added.
platform/efl/Skipped: Skipped due to the lack of requestCheckingOfString().
platform/gtk/Skipped: ditto.
platform/mac-leopard/Skipped: ditto.
platform/mac-lion/Skipped: ditto.
platform/mac-wk2/Skipped: ditto.
platform/qt/Skipped: ditto.
platform/win-wk2/Skipped: ditto.
platform/win/Skipped: ditto.
platform/wincairo/Skipped: ditto.

1:05 PM Changeset in webkit [122016] by Martin Robinson

32 edits in releases/WebKitGTK/webkit-1.8/Source

Merge 108772 - SpellCheckRequest needs to know the context where the spellcheck happened.
https://bugs.webkit.org/show_bug.cgi?id=79320

Patch by Shinya Kawanaka <shinyak@chromium.org> on 2012-02-24
Reviewed by Hajime Morita.

Source/WebCore:

WebKit clients should be able to get the context how the spellcheck happended.
For example, WebKit clients may want to change the behavior by a spellcheck request is
invoked in typing or in pasting.

This patch added an enum in SpellCheckRequest so that WebKit clients can understand the context.

editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellChecker::invokeRequest):

editing/SpellChecker.h:

(SpellCheckRequest):
(WebCore::SpellCheckRequest::textCheckingRequest):
(WebCore::SpellCheckRequest::processType):

loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

platform/text/TextCheckerClient.h:

(WebCore):
(TextCheckerClient):

platform/text/TextChecking.h:

(TextCheckingRequest):
(WebCore::TextCheckingRequest::TextCheckingRequest):
(WebCore::TextCheckingRequest::setSequence):
(WebCore::TextCheckingRequest::sequence):
(WebCore::TextCheckingRequest::text):
(WebCore::TextCheckingRequest::mask):
(WebCore::TextCheckingRequest::processType):
(WebCore):

Source/WebKit/blackberry:

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::requestCheckingOfString):

src/EditorClientImpl.h:

(EditorClientImpl):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::requestTextChecking):

Source/WebKit/efl:

WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):
(WebEditorClient):

Source/WebKit/wince:

WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

WebProcess/WebCoreSupport/WebEditorClient.h:

1:05 PM Changeset in webkit [122015] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merge 117578 - Yet another unreviewed build fix on r117572, this time for wk2...

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18

WebProcess/WebCoreSupport/WebEditorClient.h:

1:04 PM Changeset in webkit [122014] by Martin Robinson

10 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit

Merge 117575 - Another unreviewed attempt to fix build breakage on r117572.

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18

Source/WebKit/gtk:

WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.h:

Source/WebKit/win:

WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

1:04 PM Changeset in webkit [122013] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 117574 - Unreviewed attempt to fix build breakage on r117572

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18

editing/Editor.cpp:

(WebCore::Editor::willDetachPage):

1:04 PM Changeset in webkit [122012] by Martin Robinson

27 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 117572 - https://bugs.webkit.org/show_bug.cgi?id=85515
Stale frame in WebCore::SpellChecker::didCheckSucceeded

Source/WebCore:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Added EditorClient::frameWillDetachPage() notification to give a
change to invalidate pending spellcheck requests on the client.

Test: editing/spelling/spellcheck-async-remove-frame.html

editing/Editor.cpp:

(WebCore::Editor::Editor):

editing/Editor.h:

(Editor):

loader/EmptyClients.h:

(WebCore::EmptyEditorClient::frameWillDetachPage):

page/EditorClient.h:

(EditorClient):

Source/WebKit/blackberry:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientBlackBerry.h:

(WebCore::EditorClientBlackBerry::frameWillDetachPage):

Source/WebKit/chromium:

Added WebTextCheckingCompletionImpl::invalidate() to mark
pending spellcheck request as invalid, and added frameWillDetachPage()
to fire it.

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit):
(WebKit::EditorClientImpl::requestCheckingOfString):
(WebKit::EditorClientImpl::didCheckString):

src/EditorClientImpl.h:

(WebKit):
(EditorClientImpl):

src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
(WebKit::WebTextCheckingCompletionImpl::invalidate):
(WebKit):

src/WebTextCheckingCompletionImpl.h:

(WebKit):
(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):
(WebKit::WebTextCheckingCompletionImpl::spellChecker):

Source/WebKit/efl:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::frameWillDetachPage):

Source/WebKit/gtk:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::frameWillDetachPage):

Source/WebKit/win:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

LayoutTests:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
editing/spelling/spellcheck-async-remove-frame.html: Added.

1:04 PM Changeset in webkit [122011] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source

Merge 121018 - Causes crashes in LLVMPipe
https://bugs.webkit.org/show_bug.cgi?id=89358

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-06-18
Reviewed by Martin Robinson.

Change suggested by Dave Airlie and Xan Lopez.

wtf/Platform.h: disable global fastMalloc for GTK+

1:04 PM Changeset in webkit [122010] by Martin Robinson

21 edits in releases/WebKitGTK/webkit-1.8

Merge 115829 - [GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=84378

Patch by Philippe Normand <pnormand@igalia.com> on 2012-05-02
Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS. Also remove some duplicate CSS attributes.

css/mediaControlsGtk.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

platform/gtk/media/audio-controls-rendering-expected.txt:
platform/gtk/media/audio-repaint-expected.txt:
platform/gtk/media/controls-after-reload-expected.txt:
platform/gtk/media/controls-strict-expected.txt:
platform/gtk/media/controls-styling-expected.txt:
platform/gtk/media/controls-without-preload-expected.txt:
platform/gtk/media/media-controls-clone-expected.txt:
platform/gtk/media/media-document-audio-repaint-expected.txt:
platform/gtk/media/video-controls-rendering-expected.txt:
platform/gtk/media/video-display-toggle-expected.txt:
platform/gtk/media/video-empty-source-expected.txt:
platform/gtk/media/video-no-audio-expected.txt:
platform/gtk/media/video-playing-and-pause-expected.txt:
platform/gtk/media/video-volume-slider-expected.txt:
platform/gtk/media/video-zoom-controls-expected.txt:
platform/gtk/test_expectations.txt: Unflag fixed test.

1:03 PM Changeset in webkit [122009] by Martin Robinson

4 edits
3 adds in releases/WebKitGTK/webkit-1.8

Merge 115321 - [cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator
https://bugs.webkit.org/show_bug.cgi?id=84848

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.

Source/WebCore:

FillRectWithColor used to be called fillRectSourceOver before r89314
where this operator still made sense. The way this function is used
these days doesn't expect the composite operator to be overridden anymore.

No new tests, covered by existing tests, e.g.
svg/filters/feDropShadow.svg

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::fillRectWithColor):

LayoutTests:

Unskipping and baselining feDropShadow test,
now works because of composite operator fix.
Fixed png baseline result for drop shadow test on GTK.

platform/efl/svg/filters/feDropShadow-expected.png: Added.
platform/efl/svg/filters/feDropShadow-expected.txt: Added.
platform/efl/test_expectations.txt:
platform/gtk/svg/filters/feDropShadow-expected.png:

1:03 PM Changeset in webkit [122008] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 116117 - [GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url())

!defersLoading() in MainResourceLoader.cpp:382

Remove a soup_session_pause_message() call that got left behind,
update the defersLoading stuff to handle this case.

https://bugs.webkit.org/show_bug.cgi?id=85159

Patch by Dan Winship <danw@gnome.org> on 2012-05-04
Reviewed by Martin Robinson.

No new tests. Now passes loader/load-defer-resume-crash.html under
debug build.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):

1:03 PM Changeset in webkit [122007] by Martin Robinson

3 edits in releases/WebKitGTK/webkit-1.8

Merge 116160 - [soup] URL of the ResourceResponse passed to willSendRequest is incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Store the response message by catching the "got-headers" signal so
that it can be passed later to willSendRequest() in case of
redirection. This is required because the SoupMessage headers and URL
have already been updated once restartedCallback() is called.

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
and http/tests/loading/307-after-303-after-post.html now that the
response passed to willSendRequest is correct and now that the right
redirect URL is being printed in EFL port.

Unfortunately, http/tests/loading/redirect-methods.html cannot be
unskipped yet due to bug 66873.

platform/efl/test_expectations.txt:

1:03 PM Changeset in webkit [122006] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merge 116948 - [GTK] Wrong documentation for Web Database
https://bugs.webkit.org/show_bug.cgi?id=86362

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fixed docs for webkit_set_default_web_database_quota().

webkit/webkitwebdatabase.cpp:

1:03 PM Changeset in webkit [122005] by Martin Robinson

7 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 116949 - [Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be under condition guards
https://bugs.webkit.org/show_bug.cgi?id=86060

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-05-14
Reviewed by Martin Robinson.

Property set/get functions generated was referencing WebCore::interface without any condition guard.
This issue was triggered usually when an interface gets disabled; For instance; --disable-video, disables WebCore::HTMLMediaElement.
Also updated the GObject binding reference tests

No new tests - covered by existing bindings tests

bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperties):

bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(webkit_dom_test_active_dom_object_get_property):

bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(webkit_dom_test_event_constructor_get_property):

bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(webkit_dom_test_exception_get_property):

bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):

bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):

1:03 PM Changeset in webkit [122004] by Martin Robinson

3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 118949 - Check for GTK2/GTK3 symbol mismatch earlier
https://bugs.webkit.org/show_bug.cgi?id=87687

Patch by Daniel Drake <dsd@laptop.org> on 2012-05-30
Reviewed by Martin Robinson.

No new tests. Regressions in core behavior are covered by existing
plugin tests and the fix deals with particular aspects of the system
environment that are difficult to test.

Detect plugins that would mix GTK+ symbols earlier, so that the
WebKit can skip them and choose a more appropriate plugin module.

plugins/gtk/PluginPackageGtk.cpp: Move this code from PluginViewGtk.

(WebCore::moduleMixesGtkSymbols):
(WebCore::PluginPackage::load):

plugins/gtk/PluginViewGtk.cpp: Move this code to PluginPackageGtk.

(WebCore::PluginView::platformStart):

1:02 PM Changeset in webkit [122003] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 110324 - Crash when splitting an anonymous block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=80432

Patch by Abhishek Arya <inferno@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

Calculating currChild->nextSibling() is risky after destroying :after content
because it can blow away currChild if it is a left over empty anonymous block.
We need to calculate next sibling upfront, using the same trick, we do in
RenderBlock::addChildIgnoringAnonymousColumnBlock to reset beforeChild (check
out the line before splitFlow call).

Test: fast/multicol/anonymous-block-split-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

fast/multicol/anonymous-block-split-crash-expected.txt: Added.
fast/multicol/anonymous-block-split-crash.html: Added.

1:02 PM Changeset in webkit [122002] by Martin Robinson

6 edits in releases/WebKitGTK/webkit-1.8

Merge 112023 - XML error document creation should not fire mutation events
https://bugs.webkit.org/show_bug.cgi?id=80765

Patch by Jeffrey Pfau <jpfau@apple.com> on 2012-03-24
Reviewed by Adam Barth.

Source/WebCore:

Broke two tests that expected the old behavior, which have now been updated.

xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

LayoutTests:

Fixed tests that relied on old behavior.

fast/css/stylesheet-candidate-nodes-crash-expected.txt:
fast/css/stylesheet-candidate-nodes-crash.xhtml:
fast/dom/xml-parser-error-message-crash-expected.txt:

1:02 PM Changeset in webkit [122001] by Martin Robinson

14 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 115668 - Source/WebCore: Remove positioned float code.
https://bugs.webkit.org/show_bug.cgi?id=84795

Patch by Abhishek Arya <inferno@chromium.org> on 2012-04-30
Reviewed by Dan Bernstein.

Backout r92004 and some pieces from r91702.

Test: fast/block/float/positioned-float-crash.html

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFloat):

css/CSSValueKeywords.in:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
(WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):

rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::forceLayoutInlineChildren):
(FloatingObject):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::hasOverhangingFloats):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(FloatingObjects):

rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

rendering/RenderDeprecatedFlexibleBox.h:

(RenderDeprecatedFlexibleBox):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):

rendering/style/RenderStyleConstants.h:

LayoutTests: Remove positioned float code.
https://bugs.webkit.org/show_bug.cgi?id=84795

Patch by Abhishek Arya <inferno@chromium.org> on 2012-04-30
Reviewed by Dan Bernstein.

fast/block/float/positioned-float-crash-expected.txt: Added.
fast/block/float/positioned-float-crash.html: Added.

1:02 PM Changeset in webkit [122000] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116325 - Crash in RenderBlock::updateFirstLetterStyle.
https://bugs.webkit.org/show_bug.cgi?id=85759

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-07
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/first-letter-next-sibling-crash.html

RenderBlock::removeChild can bring up the children from last single anonymous block,
causing |nextSibling| in RenderBlock::updateFirstLetterStyle to go stale. We prevent
this by removing the child safely using removeChildNode before destroying it.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

LayoutTests:

fast/css-generated-content/first-letter-next-sibling-crash-expected.txt: Added.
fast/css-generated-content/first-letter-next-sibling-crash.html: Added.

1:02 PM Changeset in webkit [121999] by Martin Robinson

15 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116174 - ASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=84606

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-04
Reviewed by Julien Chaffraix.

Source/WebCore:

RenderBlock::removeChild forgot to set display on the anonymous block, causing it
to display as INLINE. To prevent this kind of failure in future, we replace
createAnonymousStyle with createAnonymousStyleWithDisplay to make everyone explictly
pass display as the argument.

Test: fast/block/block-add-child-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):

rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::addChildIgnoringContinuation):

rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

rendering/RenderRuby.cpp:

(WebCore::createAnonymousRubyInlineBlock):

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRenderer):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::createAnonymousWithParentRenderer):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::createAnonymousWithParentRenderer):

rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createAnonymousStyleWithDisplay):

rendering/style/RenderStyle.h:

LayoutTests:

fast/block/block-add-child-crash-expected.txt: Added.
fast/block/block-add-child-crash.html: Added.

1:01 PM Changeset in webkit [121998] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 117304 - Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
https://bugs.webkit.org/show_bug.cgi?id=86627

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-16
Reviewed by Andreas Kling.

Source/WebCore:

Test: java/inline-applet-crash.html

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

LayoutTests:

java/inline-applet-crash-expected.txt: Added.
java/inline-applet-crash.html: Added.

1:01 PM Changeset in webkit [121997] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116669 - Crash in ApplyStyleCommand::joinChildTextNodes.
https://bugs.webkit.org/show_bug.cgi?id=85939

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/style/apply-style-join-child-text-nodes-crash.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
to bail out if our start and end position nodes are removed due to
mutation events in joinChildTextNodes.
(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
to bail out if our start and end position nodes are removed due to
mutation events.
(WebCore::ApplyStyleCommand::joinChildTextNodes): hold all the children
in a ref vector to prevent them from getting destroyed due to mutation events.

LayoutTests:

editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
editing/style/apply-style-join-child-text-nodes-crash.html: Added.

1:01 PM Changeset in webkit [121996] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116545 - Crash in ReplaceSelectionCommand::performTrivialReplace
https://bugs.webkit.org/show_bug.cgi?id=85943

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr nodeAfterInsertionPos to guard against mutation events.

Test: editing/inserting/insert-html-crash.html

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::performTrivialReplace):

LayoutTests:

editing/inserting/insert-html-crash-expected.txt: Added.
editing/inserting/insert-html-crash.html: Added.

1:01 PM Changeset in webkit [121995] by Martin Robinson

4 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116683 - Crash due to floats not removed from first-letter element.
https://bugs.webkit.org/show_bug.cgi?id=86019

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-10
Reviewed by Julien Chaffraix.

Source/WebCore:

Move clearing logic of a floating/positioned object from removeChild
to removeChildNode. There are lot of places which use removeChildNode
directly and hence the object is not removed from the floating or
positioned objects list.

Test: fast/block/float/float-not-removed-from-first-letter.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::removeChild):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

LayoutTests:

fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
fast/block/float/float-not-removed-from-first-letter.html: Added.

1:01 PM Changeset in webkit [121994] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116864 - Crash in HTMLSelectElement::setOption
https://bugs.webkit.org/show_bug.cgi?id=85420

Source/WebCore:

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-12
Reviewed by Eric Seidel

RefPtr before option in HTMLSelectElement::setOption since it
can get destroyed due to mutation events.

Test: fast/dom/HTMLSelectElement/option-add-crash.html

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setOption):

LayoutTests:

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-12
Reviewed by Eric Seidel.

fast/dom/HTMLSelectElement/option-add-crash-expected.txt: Added.
fast/dom/HTMLSelectElement/option-add-crash.html: Added.

1:00 PM Changeset in webkit [121993] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 117224 - Crash in Document::nodeChildrenWillBeRemoved.
https://bugs.webkit.org/show_bug.cgi?id=85247

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-15
Reviewed by Hajime Morita.

Source/WebCore:

Reverse ordering of commands to ref ptr the children set
first before calling nodeChildrenWillBeRemoved, since it
can fire mutation events.

Test: fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

LayoutTests:

fast/dom/HTMLObjectElement/beforeload-set-text-crash-expected.txt: Added.
fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml: Added.

1:00 PM Changeset in webkit [121992] by Martin Robinson

2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 116717 - Crash in swapInNodePreservingAttributesAndChildren.
https://bugs.webkit.org/show_bug.cgi?id=85197

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-10
Reviewed by Ryosuke Niwa.

Keep the children in a ref vector before adding them to newNode.
They can get destroyed due to mutation events.

No new tests because we don't have a reduction.

editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

1:00 PM Changeset in webkit [121991] by Martin Robinson

3 edits
2 adds in releases/WebKitGTK/webkit-1.8

Merge 116357 - Crash due to positioned object list not being cleared during block flow split
https://bugs.webkit.org/show_bug.cgi?id=85074

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-07
Reviewed by Abhishek Arya.

Source/WebCore:

When an element is being split due to a column span element being
inserted, any of its ancestors that are underneath the column
containing block also get split. If an ancestor has an object in
its positioned object list from a previous layout, then the list
will have to be cleared because the positioned object could have moved
to be under the continuation. This patch causes the list to be
cleared.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

Test exercises crashing condition in bug 85074. It creates a column
span that requires multiple layers of splitting blocks from the
element that contains the columns, puts a positioned element underneath
one of the split blocks, and then causes a reattach of the column span
element.

fast/block/positioning/positioned-object-under-split-block-parent-crash-expected.txt: Added
fast/block/positioning/positioned-object-under-split-block-parent-crash.html: Added

12:19 PM Changeset in webkit [121990] by commit-queue@webkit.org

6 edits
2 adds in trunk

[EFL][CMake] Move gtest sources to an upper level
https://bugs.webkit.org/show_bug.cgi?id=90602

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-06
Reviewed by Chang Shu.

CTest was enabled for all the ports, but used only by EFL. Now
ENABLE_API_TESTS has to be defined, which will also build gtest.

CMakeLists.txt:
Source/CMakeLists.txt:
Source/cmake/OptionsEfl.cmake:
Source/cmake/gtest/CMakeLists.txt: Added.

Source/WebKit:

Removed gtest since it is now built as a separated component.
This will allow us to share it with WebKit 2 API tests.

PlatformEfl.cmake:

12:12 PM Changeset in webkit [121989] by commit-queue@webkit.org

13 edits
15 adds in trunk/Source/WebKit2

[WK2] Add support for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=89870

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-06
Reviewed by Anders Carlsson.

Add Network Information API support for WebKit2.

CMakeLists.txt:
DerivedSources.pri:
GNUmakefile.am:
GNUmakefile.list.am:
Platform/CoreIPC/MessageID.h:
Shared/API/c/WKBase.h:
Shared/APIObject.h:
Shared/WebNetworkInfo.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfo::WebNetworkInfo):
(WebKit::WebNetworkInfo::~WebNetworkInfo):
(WebKit::WebNetworkInfo::Data::encode):
(WebKit::WebNetworkInfo::Data::decode):

Shared/WebNetworkInfo.h: Added.

(WebKit):
(WebNetworkInfo):
(Data):
(WebKit::WebNetworkInfo::create):
(WebKit::WebNetworkInfo::bandwidth):
(WebKit::WebNetworkInfo::metered):
(WebKit::WebNetworkInfo::data):
(WebKit::WebNetworkInfo::type):

Target.pri:
UIProcess/API/C/WKAPICast.h:

(WebKit):

UIProcess/API/C/WKNetworkInfoManager.cpp: Added.

(WKNetworkInfoManagerGetTypeID):

UIProcess/API/C/WKNetworkInfoManager.h: Added.
UIProcess/WebNetworkInfoManagerProxy.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoManagerProxy::create):
(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::~WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::invalidate):
(WebKit::WebNetworkInfoManagerProxy::initializeProvider):
(WebKit::WebNetworkInfoManagerProxy::providerDidChangeNetworkInformation):
(WebKit::WebNetworkInfoManagerProxy::didReceiveMessage):
(WebKit::WebNetworkInfoManagerProxy::startUpdating):
(WebKit::WebNetworkInfoManagerProxy::stopUpdating):
(WebKit::WebNetworkInfoManagerProxy::getBandwidth):
(WebKit::WebNetworkInfoManagerProxy::isMetered):

UIProcess/WebNetworkInfoManagerProxy.h: Added.

(CoreIPC):
(WebKit):
(WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::clearContext):
(WebKit::WebNetworkInfoManagerProxy::type):

UIProcess/WebNetworkInfoManagerProxy.messages.in: Added.
UIProcess/WebNetworkInfoProvider.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoProvider::startUpdating):
(WebKit::WebNetworkInfoProvider::stopUpdating):
(WebKit::WebNetworkInfoProvider::bandwidth):
(WebKit::WebNetworkInfoProvider::metered):

UIProcess/WebNetworkInfoProvider.h: Added.

(WebKit):
(WebNetworkInfoProvider):

WebKit2.pri:
WebProcess/NetworkInfo/WebNetworkInfoManager.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):
(WebKit::WebNetworkInfoManager::~WebNetworkInfoManager):
(WebKit::WebNetworkInfoManager::didReceiveMessage):
(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):
(WebKit::WebNetworkInfoManager::didChangeNetworkInformation):

WebProcess/NetworkInfo/WebNetworkInfoManager.h: Added.

(CoreIPC):
(WebKit):
(WebNetworkInfoManager):

WebProcess/NetworkInfo/WebNetworkInfoManager.messages.in: Added.
WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoClient::~WebNetworkInfoClient):
(WebKit::WebNetworkInfoClient::bandwidth):
(WebKit::WebNetworkInfoClient::metered):
(WebKit::WebNetworkInfoClient::startUpdating):
(WebKit::WebNetworkInfoClient::stopUpdating):

WebProcess/WebCoreSupport/WebNetworkInfoClient.h: Added.

(WebKit):
(WebNetworkInfoClient):
(WebKit::WebNetworkInfoClient::WebNetworkInfoClient):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

WebProcess/WebProcess.h:

(WebProcess):
(WebKit::WebProcess::networkInfoManager):

11:36 AM Changeset in webkit [121988] by zandobersek@gmail.com

4 edits in trunk

[Gtk] Add a configuration option for disabling unstable features in releases
https://bugs.webkit.org/show_bug.cgi?id=87995

Reviewed by Martin Robinson.

Add a configuration flag for enabling the unstable features - features of which
support in the Gtk port is being worked on but is not yet complete. The primary
use of this flag is when compiling through the build-webkit script.

All the features that are currently enabled when building through build-webkit but
are disabled by default when executing the configure script directly have their default
value (when the correspondent flag is not passed) set to 'yes' when unstable features
are enabled and 'no' otherwise. This way unstable features are kept disabled when performing
a release build (unless they are specifically enabled).

configure.ac:

Tools:

Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.

Scripts/webkitdirs.pm:

(buildAutotoolsProject):

10:47 AM Changeset in webkit [121987] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Drawing to accelerated 2D canvas causes compositor to recompute layer tree
https://bugs.webkit.org/show_bug.cgi?id=90630

Patch by Justin Novosad <junov@chromium.org> on 2012-07-06
Reviewed by Simon Fraser.

No new tests: covered by existing canvas/compositing layout tests

Before this change, there was no distinction between canvas changes
that require recomputing the compositor tree and canvas changes that
only require re-display. The new CanvasPixelsChanged member of enum
ContentChangeType requests re-display without re-layout.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):

rendering/RenderBoxModelObject.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentChanged):

10:39 AM Changeset in webkit [121986] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90634

Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-06
Reviewed by Oliver Hunt.

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(SpecializedThunkJIT):

jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

parser/NodeConstructors.h:

(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::ForNode::ForNode):
(JSC::ForInNode::ForInNode):

parser/Nodes.h:

(FunctionCallResolveNode):
(PostfixErrorNode):
(PrefixErrorNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(AssignErrorNode):
(ForNode):
(ForInNode):

parser/Parser.cpp:

(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createForLoop):

10:26 AM Changeset in webkit [121985] by Lucas Forschler

12 edits in branches/safari-534.57-branch

Merge 116381.

10:19 AM Changeset in webkit [121984] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: get rid of this._lastMarkedRange in TextEditor.
https://bugs.webkit.org/show_bug.cgi?id=90691

Reviewed by Vsevolod Vlasov.

We don't need it, should use setSelection instead.

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleSelectionChange):
(WebInspector.TextEditor.prototype.setSelection):
(WebInspector.TextEditor.prototype._handleFocused):

10:08 AM Changeset in webkit [121983] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Snippet renaming behavior is not correct.
https://bugs.webkit.org/show_bug.cgi?id=90689

Reviewed by Pavel Feldman.

Navigator overlay is now not closed when editing is canceled.
Esc handler in NavigatorOverlayController is not installed as a shortcut anymore since
it should not be called until all underlying DOM elements handled the key down event.

inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._keyDown):
(WebInspector.NavigatorOverlayController.prototype._innerHideNavigatorOverlay):

inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._itemRenamingRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._itemRenamingRequested.callback):
(WebInspector.ScriptsPanel.prototype._itemRenamingRequested):

10:05 AM Changeset in webkit [121982] by kling@webkit.org

3 edits in trunk/Source/WebCore

Separate mutating CSSStyleDeclaration operations.
<http://webkit.org/b/89945>

Reviewed by Antti Koivisto.

Use separate paths for mutating the StylePropertySet wrapped by a CSSStyleDeclaration.
PropertySetCSSStyleDeclaration now has:

propertySet() const
ensureMutablePropertySet()

This is prep work for supporting immutable ElementAttributeData objects, the idea being
that calling ensureMutablePropertySet() may cause the element to convert its internal
attribute storage (which also holds the inline StylePropertySet.)

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):

css/PropertySetCSSStyleDeclaration.h:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::propertySet):
(WebCore::PropertySetCSSStyleDeclaration::ensureMutablePropertySet):

9:54 AM Changeset in webkit [121981] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: text editor scrolls 2px horizontally as one navigates the source code.
https://bugs.webkit.org/show_bug.cgi?id=90682

Reviewed by Vsevolod Vlasov.

Removing the hack that is glueing the scroller to the left.

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype._updatePanelOffsets):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):

inspector/front-end/textEditor.css:

9:41 AM Changeset in webkit [121980] by caseq@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: get rid of cancellable records in Timeline, manage frame records explicitly
https://bugs.webkit.org/show_bug.cgi?id=90684

Reviewed by Pavel Feldman.

drop handling of "cancelable" records;
keep frame record until other records come (or frame is canceled)

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):

inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):

9:35 AM Changeset in webkit [121979] by jberlin@webkit.org

14 edits
2 copies
2 adds in trunk

Source/WebKit2: WKContext should ask for its injected bundle initialization user data when it needs it so the
client doesn't have to keep it up to date.
https://bugs.webkit.org/show_bug.cgi?id=90627

Reviewed by NOBODY (OOPS!).

Add a getInjectedBundleInitializationUserData callback to WKContextInjectedBundleClient.

Shared/APIClientTraits.cpp:

Allow the WKContextInjectedBundleClient API to be versioned.

Shared/APIClientTraits.h:

UIProcess/API/C/WKContext.h:

Add the callback and bump the version of WKContextInjectedBundleClient.

UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Prefer any user data returned when the callback is invoked over that set with
WKContextSetInitializationUserDataForInjectedBundle.

UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
Invoke the callback if the client has registered for it.

UIProcess/WebContextInjectedBundleClient.h:

Tools: WKContext should ask for its initialization data when it needs it so the client doesn't have
to keep it up to date.
https://bugs.webkit.org/show_bug.cgi?id=90627

Reviewed by NOBODY (OOPS!).

Add tests and update other WKContextInjectedBundleClients.

MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
Updated for the change to WKContextInjectedBundleClient.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
Ditto.

TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
Moved the logic to create the initialization dictionary here ...
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
... from here so that it can be used without automatically using
WKContextSetInitializationUserDataForInjectedBundle.

TestWebKitAPI/PlatformUtilities.h:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add the new test files.

TestWebKitAPI/GNUmakefile.am:

Ditto.

TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Check that the message received from the injected bundle matches the user data it was
initialized with.
(TestWebKitAPI::getInjectedBundleInitializationUserData):
Return the user data that the injected bundle should be initialized with.
(TestWebKitAPI::TEST):
Set up WKContextInjectedBundleClient and load a page.

TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.

(TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
Send the initialization user data back up to the UI Process.

TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Check that the message received from the injected bundle matches the user data it was
initialized with in the callback.
(TestWebKitAPI::getInjectedBundleInitializationUserData):
Return the user data that the injected bundle should be initialized with.
(TestWebKitAPI::TEST):
Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
initialization user data (which should be overridden by the user data returned in
getInjectedBundleInitializationUserData).

TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.

(TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
Send the initialization user data back up to the UI Process.

9:35 AM Changeset in webkit [121978] by jberlin@webkit.org

2 edits in trunk/Source/WebKit2

WebContext::injectedBundleInitializationUserData() is unused, should be removed
https://bugs.webkit.org/show_bug.cgi?id=90486

Reviewed by Anders Carlsson.

UIProcess/WebContext.h:

Remove it.

9:29 AM Changeset in webkit [121977] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

platform/qt-5.0-wk1/Skipped:

9:04 AM Changeset in webkit [121976] by Carlos Garcia Campos

5 edits in trunk/Source/WebKit2

[GTK] Add site specific quirks setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90663

Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_site_specific_quirks):
(webkit_settings_set_enable_site_specific_quirks):

UIProcess/API/gtk/WebKitSettings.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

9:01 AM Changeset in webkit [121975] by commit-queue@webkit.org

3 edits in trunk/Tools

[EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
https://bugs.webkit.org/show_bug.cgi?id=90593

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-06
Reviewed by Philippe Normand.

efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.

8:55 AM Changeset in webkit [121974] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening, clean up the TestExpectations file, removing
non-existent or doubled test entries and re-specifying detailed test
expectations so the TestExpectations lint passes.

platform/gtk/TestExpectations:

8:02 AM Changeset in webkit [121973] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] [GTK] http/tests/multipart/multipart-replace-non-html-content.php is failing after r121912
https://bugs.webkit.org/show_bug.cgi?id=90685

Unreviewed gardening, add test expectation for a failing
test after r121912.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-06

platform/efl/TestExpectations:

7:49 AM Changeset in webkit [121972] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

ProcessLauncher's WorkQueue's name is too long on Windows
https://bugs.webkit.org/show_bug.cgi?id=44041

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-06
Reviewed by Andreas Kling.

Shorten thread name for process launcher so that we can silence the warning
for thread names getting truncated under VisualStudio -
see createThread() in Threading.cpp.

UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::processLauncherWorkQueue):

7:37 AM Changeset in webkit [121971] by Csaba Osztrogonác

7 edits in trunk

[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203

The test fonts used for Qt tests were moved to the Liberation font family.

Due to this change we are skipping tons of tests. They will be gradually
unskipped in batches, ASAP.

Also, the now unneeded special font configuration for Qt5 WK1 was removed.

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Tools:

DumpRenderTree/qt/QtInitializeTestFonts.cpp:

(WebKit::initializeTestFonts):

LayoutTests:

platform/qt-4.8/Skipped:
platform/qt-5.0-wk1/Skipped:
platform/qt-5.0-wk2/Skipped:
platform/qt-5.0/Skipped:

7:21 AM Changeset in webkit [121970] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687

Unreviewed gardening, skip new failing tests.

platform/qt-5.0/Skipped:

7:16 AM Changeset in webkit [121969] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] WebKit-EFL headers do not build with gcc < 4.6
https://bugs.webkit.org/show_bug.cgi?id=90681

Unreviewed EFL build fix.

Remove several forward declarations from ewk_view
header to avoid typedef redefinitions which are
illegal in C.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-06

UIProcess/API/efl/ewk_view.h:

7:11 AM SelectiveTestEWS edited by rhino666@gmail.com

(diff)

7:09 AM Changeset in webkit [121968] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Web Inspector: Add native memory used by GlyphCache to the snapshot
https://bugs.webkit.org/show_bug.cgi?id=90615

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-06
Reviewed by Yury Semikhatsky.

inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::addPlatformComponentsInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

platform/MemoryUsageSupport.h:

(MemoryUsageSupport):
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):

platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::glyphCacheVisitor):
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageByComponents):

6:46 AM SelectiveTestEWS edited by kerekattila.hun@gmail.com

(diff)

6:23 AM Changeset in webkit [121967] by Csaba Osztrogonác

8 edits in trunk

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90519

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

WebCoreSupport/QtFallbackWebPopup.cpp: Include QtGui/QStandardItemModel instead of deprecated QStandardItemModel.

Source/WebKit2:

UIProcess/API/qt/qwebkittest.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h.

Tools:

MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h

6:20 AM Changeset in webkit [121966] by Csaba Osztrogonác

3 edits in trunk/Tools

[Qt] Make use of Qt5 qmake's changed makefile recursion behavior

When not using the -r option, qmake now interleaves qmake and make calls,
so we don't need custom logic for this. There's also an option to supress
the effect of the -r option, which we use to make WebKit.pro the only
project file parsed in a recursive qmake-run.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

qmake/mkspecs/features/default_post.prf:
qmake/mkspecs/features/functions.prf:

6:18 AM Changeset in webkit [121965] by Csaba Osztrogonác

4 edits in trunk

[Qt] Remove custom qmake logic for module creation

Qmake now has the necessary hooks to cleanly override the build locations.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/api.pri:

Tools:

qmake/mkspecs/features/default_pre.prf:

6:17 AM Changeset in webkit [121964] by Csaba Osztrogonác

4 edits
1 add in trunk

[Qt] Add top-level .qmake.conf

With Qt5, this makes setting $QMAKEPATH externally unnecessary.

The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
hurt, and is still required for Qt4.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.qmake.conf: Added.
WebKit.pro:

Tools:

qmake/mkspecs/features/default_pre.prf:

6:16 AM Changeset in webkit [121963] by Csaba Osztrogonác

4 edits in trunk/Tools

[Qt] Unify qtFeatureDefaults code paths

There's no reason to run qmake on features.prf directly anymore, as we
can selectivly run configure tests in the project file now.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Scripts/webkitdirs.pm:

(qtFeatureDefaults):

qmake/configure.pri:
qmake/mkspecs/features/features.prf:

6:15 AM Changeset in webkit [121962] by Csaba Osztrogonác

2 edits in trunk

[Qt] Let qt_module_config create the forwarding module pri file

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/sync.profile:

6:14 AM Changeset in webkit [121961] by Csaba Osztrogonác

4 edits in trunk

[Qt] Don't let qt_webkit.pri proclaim its own location

This won't work any more with recent Qt5 versions, as the forwarding
pri is created by qt_module_config, which needs MODULE_PRI to be set
up already.

We also need to load build_config, not qt_module.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/api.pri:

Tools:

qmake/qt_webkit.pri:

6:13 AM Changeset in webkit [121960] by Csaba Osztrogonác

4 edits in trunk

[Qt] Remove redundant CONFIG+=module

qt_module_config takes care of that.

In api.pri we are actually testing the flag ourselves, so now we need to
test a related flag qt_module_config sets instead.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/api.pri:

Tools:

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

qmake/mkspecs/features/default_post.prf:

6:12 AM Changeset in webkit [121959] by Csaba Osztrogonác

8 edits in trunk

[Qt] Adjust to changed generation of master include file

The responsiblity for creating the master include was moved out of syncqt.
@ignore_for_master_contents still stays, as syncqt (ab-)uses this for
determining whether a header is private.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/sync.profile:

Source/WebKit/qt:

Api/qwebscriptworld.h:
tests/util.h:

Source/WebKit2:

UIProcess/API/qt/tests/bytearraytestdata.h:
UIProcess/API/qt/tests/testwindow.h:

6:10 AM Changeset in webkit [121958] by Csaba Osztrogonác

8 edits
1 copy
1 delete in trunk

[Qt] Switch to new-style Qt 5 configure tests

Use explicit project file action instead of syncqt magic.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/WebCore:

WebCore.pri:

Tools:

Scripts/webkitdirs.pm:

(buildQMakeProjects):

qmake/configure.pri: Copied from Tools/qmake/configure.pro.
qmake/configure.pro:
qmake/mkspecs/features/default_pre.prf:
qmake/mkspecs/features/features.prf:
qmake/sync.profile: Removed.

6:08 AM Changeset in webkit [121957] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: start searching from the cursor position in the Sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90677

Reviewed by Vsevolod Vlasov.

Web Inspector: start searching from the cursor position in the Sources panel.
Drive-by: select whole match upon search cancel.

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.lastSelection):
(WebInspector.TextEditor.prototype._handleFocused):

inspector/front-end/TextEditorModel.js:

(WebInspector.TextRange.prototype.serializeToObject):
(WebInspector.TextRange.prototype.compareTo):

5:19 AM Changeset in webkit [121956] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Snippets should be correctly (re)loaded when inspector is open and on navigation.
https://bugs.webkit.org/show_bug.cgi?id=90672

Reviewed by Pavel Feldman.

Snippets are now reloaded from the storage on ScriptSnippetMapping reset.
Fixed snippets storage.

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._loadSnippets):
(WebInspector.ScriptSnippetModel.prototype._reset):

inspector/front-end/SnippetStorage.js:

(WebInspector.Snippet.fromObject):

5:14 AM Changeset in webkit [121955] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Implement snippets removing.
https://bugs.webkit.org/show_bug.cgi?id=90674

Reviewed by Pavel Feldman.

inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.rename.afterEditing):

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.removeUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

inspector/front-end/TabbedEditorContainer.js:

5:02 AM Changeset in webkit [121954] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a test expectation for a failing
http multipart test after r121912.

platform/gtk/TestExpectations:

4:45 AM Changeset in webkit [121953] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Not reviewed: fix inspector front-end compilation.

inspector/front-end/ElementsTreeOutline.js:
inspector/front-end/SearchController.js:

4:25 AM Changeset in webkit [121952] by yurys@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: add memory reporting routine to Document
https://bugs.webkit.org/show_bug.cgi?id=90668

Reviewed by Pavel Feldman.

Added methods for reporting HashSet, ListHashSet and Vector memory
footprint. Made Document report its size along with its internal
collections sizes.

dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):
(WebCore):

dom/Document.h:

(Document):

dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportHashMap):
(WebCore::MemoryObjectInfo::reportHashSet):
(WebCore::MemoryObjectInfo::reportListHashSet):
(WebCore::MemoryObjectInfo::reportVector):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportListHashSet):
(WebCore::MemoryInstrumentation::reportVector):

inspector/InspectorMemoryAgent.cpp:

(WebCore):

3:05 AM Changeset in webkit [121951] by rgabor@webkit.org

4 edits in trunk/Source/WebCore

Fixing defines for NEON intrinsics.
https://bugs.webkit.org/show_bug.cgi?id=90666

Reviewed by Zoltan Herczeg.

Existing tests cover this issue.

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):

platform/graphics/filters/arm/FEGaussianBlurNEON.h:
platform/graphics/filters/arm/NEONHelpers.h:

3:04 AM Changeset in webkit [121950] by toyoshim@chromium.org

1 edit
2 moves
1 add in trunk/LayoutTests

[Inspector][WebSocket][NRWT] layout tests which requires websocket server must be in a websocket subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=90524

Reviewed by Pavel Feldman.

http/tests/inspector/websocket/web-socket-frame-expected.txt: Renamed from LayoutTests/http/tests/inspector/web-socket-frame-expected.txt.
http/tests/inspector/websocket/web-socket-frame.html: Renamed from LayoutTests/http/tests/inspector/web-socket-frame.html.

2:46 AM Changeset in webkit [121949] by vsevik@chromium.org

13 edits in trunk

Web Inspector: Workspace should dispatch WorkspaceReset event on navigation.
https://bugs.webkit.org/show_bug.cgi?id=90616

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace UISourceCodeProviders are now reset on navigation.
UISourceCodeRemoved event is not dispatched from UISourceCodeProviders on reset (page navigation) anymore.

inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.reset):

inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._reset):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):

inspector/front-end/StylesPanel.js:

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):

inspector/front-end/Workspace.js:

(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeProviders):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.registerUISourceCodeProvider):
(WebInspector.Workspace.prototype._reset):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

inspector/debugger/linkifier.html:
inspector/debugger/scripts-panel.html:
inspector/styles/edit-inspector-stylesheet.html:

1:42 AM Changeset in webkit [121948] by zherczeg@webkit.org

4 edits in trunk/Source/JavaScriptCore

[Qt][ARM] REGRESSION(r121885): It broke 30 jsc tests, 500+ layout tests
https://bugs.webkit.org/show_bug.cgi?id=90656

Reviewed by Csaba Osztrogonác.

Typo fixes.

assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
Rename getOp2Byte() -> getOp2Half()

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::convertibleLoadPtr):
Add a necessary space.

jit/JITStubs.cpp:

(JSC):
Revert INLINE_ARM_FUNCTION macro.

12:17 AM Changeset in webkit [121947] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit

[EFL] Add Web Inspector to WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=83865

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-06
Reviewed by Pavel Feldman.

Source/WebKit:

EFL port implementation for Web Inspector.
Prepare Web Inspector resources.

PlatformEfl.cmake:

Source/WebKit/efl:

EFL port implementation for Web Inspector.
Implementation of InspectorClientEfl and InspectorFrontendClientEfl
for using the Web Inspector in WebKit-EFL with new EWK APIs.

WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::notifyWebInspectorDestroy):
(WebCore):
(InspectorFrontendSettingsEfl):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):
(WebCore::InspectorClientEfl::InspectorClientEfl):
(WebCore::InspectorClientEfl::~InspectorClientEfl):
(WebCore::InspectorClientEfl::inspectorDestroyed):
(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorClientEfl::closeInspectorFrontend):
(WebCore::InspectorClientEfl::bringFrontendToFront):
(WebCore::InspectorClientEfl::sendMessageToFrontend):
(WebCore::InspectorClientEfl::releaseFrontendPage):
(WebCore::InspectorClientEfl::inspectorFilesPath):
(WebCore::InspectorFrontendClientEfl::InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::~InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::localizedStringsURL):
(WebCore::InspectorFrontendClientEfl::hiddenPanels):
(WebCore::InspectorFrontendClientEfl::bringToFront):
(WebCore::InspectorFrontendClientEfl::closeWindow):
(WebCore::InspectorFrontendClientEfl::inspectedURLChanged):
(WebCore::InspectorFrontendClientEfl::attachWindow):
(WebCore::InspectorFrontendClientEfl::detachWindow):
(WebCore::InspectorFrontendClientEfl::setAttachedWindowHeight):
(WebCore::InspectorFrontendClientEfl::destroyInspectorWindow):

WebCoreSupport/InspectorClientEfl.h:

(WebCore):
(InspectorClientEfl):
(InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::disconnectInspectorClient):

ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_web_inspector_show):
(ewk_view_web_inspector_close):
(ewk_view_web_inspector_view_get):
(ewk_view_web_inspector_view_set):

ewk/ewk_view.h:

12:01 AM Changeset in webkit [121946] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r121925): It broke 5 sputnik tests on x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=90658

Reviewed by Zoltan Herczeg.

Under the new object model, out-of-line property accesses such as those
in ResolveGlobal must account for the fact that the offset to the Kth
property is represented by K + inlineStorageCapacity. Hence, the property
loads in ResolveGlobal must have an additional -inlineStorageCapacity *
sizeof(JSValue) offset.

Context Navigation

Timeline

Jul 7, 2012:

Jul 6, 2012:

Download in other formats: