Timeline
Jul 9, 2012:
- 11:42 PM Changeset in webkit [122197] by
-
- 6 edits1 copy2 moves2 adds in trunk/Source
[EFL] Battery status code needs refactoring to be reused in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90760
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-09
Reviewed by Hajime Morita.
Source/WebCore:
Rename BatteryClientEfl to BatteryProviderEfl and remove dependency
on BatteryController by introducing the BatteryProviderEflClient
interface. This will allow reusing the BatteryProviderEfl class
in WebKit2.
No new tests. Already tested by batterystatus/*.
- PlatformEfl.cmake:
- platform/efl/BatteryProviderEfl.cpp: Renamed from Source/WebCore/platform/efl/BatteryClientEfl.cpp.
(WebCore):
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::batteryStatus):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired):
(WebCore::BatteryProviderEfl::getBatteryStatus):
(WebCore::BatteryProviderEfl::setBatteryClient):
- platform/efl/BatteryProviderEfl.h: Copied from Source/WebCore/platform/efl/BatteryClientEfl.h.
(WebCore):
(BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
- platform/efl/BatteryProviderEflClient.h: Added.
(WebCore):
(BatteryProviderEflClient):
Source/WebKit:
Add BatteryClientEfl to PlatformEfl.cmake.
- PlatformEfl.cmake:
Source/WebKit/efl:
Add BatteryClientEfl to WebKit, which uses BatteryProviderEfl from
WebCore internally.
- WebCoreSupport/BatteryClientEfl.cpp: Added.
(BatteryClientEfl::BatteryClientEfl):
(BatteryClientEfl::setController):
(BatteryClientEfl::startUpdating):
(BatteryClientEfl::stopUpdating):
(BatteryClientEfl::batteryControllerDestroyed):
(BatteryClientEfl::didChangeBatteryStatus):
- WebCoreSupport/BatteryClientEfl.h: Renamed from Source/WebCore/platform/efl/BatteryClientEfl.h.
(WebCore):
(BatteryClientEfl):
(BatteryClientEfl::~BatteryClientEfl):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 11:37 PM WebKitIDL edited by
- (diff)
- 11:34 PM Drosera edited by
- (diff)
- 11:24 PM WebInspector edited by
- (diff)
- 10:55 PM Changeset in webkit [122196] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed gardening.
Fix a wrong fix of r122194.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
- 10:45 PM Changeset in webkit [122195] by
-
- 31 edits3 adds in trunk
Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.
No new tests, as there is no behavior change.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):
- dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
- html/HTMLDialogElement.cpp: Added.
(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):
- html/HTMLDialogElement.h: Added.
(WebCore):
(HTMLDialogElement):
- html/HTMLDialogElement.idl: Added.
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 10:22 PM Changeset in webkit [122194] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed gardening.
Remove an assertion starting to fail on interactive_ui_tests on Chromium OS.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
- 9:56 PM Changeset in webkit [122193] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed gardening.
Build fix after r122175
- WebCore.gypi: Remove Source/WebCore/platform/graphics/qt/Extensions3DQt.{cpp,h}
- 9:35 PM Changeset in webkit [122192] by
-
- 5 edits in trunk/Tools
Improve the boilerplate generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560
Reviewed by Ryosuke Niwa.
Produce the following boilerplate:
2012-06-20 Kent Tamura <tkent@chromium.org>
Need a short description (Oops!).
Need the bug URL (Oops!).
Reviewed by NOBODY (Oops!).
Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
No new tests (Oops!).
- Scripts/prepare-ChangeLog:
(generateNewChangeLogs): Generate the updated template.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.update_with_unreviewed_message):
Update the pattern for the beginning of the boilerplate.
(ChangeLog.set_short_description_and_bug_url):
- Use self._changelog_indent
- Update the pattern for the description line
- Skip the bug boilerplate.
We substitute the specified bug URL to the description boilerplate
because we need to add it even if the bug URL boilerplate is missing.
- Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.
(test_set_short_description_and_bug_url):
- Update the description boilerplate.
- Add a test for a case with both of the description boilerplace and the bug URL boilerplate.
- Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.
- 9:34 PM Changeset in webkit [122191] by
-
- 2 edits in trunk/Source/WebCore
Improve performance of RenderInline::absoluteQuads for deeply nested inlines.
https://bugs.webkit.org/show_bug.cgi?id=90715
Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-09
Reviewed by Maciej Stachowiak.
No new tests: functionality unchanged.
- rendering/RenderInline.cpp: Cache transformation from local to absolute coordinates using a
RenderGeometryMap and use it for subsequent mappings.
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::AbsoluteQuadsGeneratorContext):
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::operator()):
- 9:31 PM Changeset in webkit [122190] by
-
- 5 edits in trunk/Source
[Chromium-Mac] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=90237
Reviewed by Kent Tamura.
Source/WebCore:
This patch introduces following localized time format related
functions:
- localizeTimeFormatText()
- localizeShortTimeFormatText()
- timeAMPMLabels
for Mac OSX in feature flag: ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
These function will be used by input type "time" with multiple input
fields UI.
Note: ICU version of localized time format functions are implemented
in https://bugs.webkit.org/show_bug.cgi?id=89965
Tests: WebKit/chromium/tests/LocaleMacTest.cpp
- platform/text/mac/LocaleMac.h:
(LocaleMac): Added time format related functions and variables.
- platform/text/mac/LocaleMac.mm:
(WebCore::createDateTimeFormatter): Added. A helper function for creating date time formatter.
(WebCore::LocaleMac::createShortDateFormatter): Changed to use createDateTimeFormatter.
(WebCore::LocaleMac::createTimeFormatter): Added.
(WebCore::LocaleMac::createShortTimeFormatter): Added.
(WebCore::LocaleMac::timeFormatText): Added.
(WebCore::LocaleMac::shortTimeFormatText): Added.
(WebCore::LocaleMac::timeAMPMLabels): Added.
Source/WebKit/chromium:
- tests/LocaleMacTest.cpp:
(LocaleMacTest):
(LocaleMacTest::timeFormatText):
(LocaleMacTest::shortTimeFormatText):
(LocaleMacTest::timeAMPMLabel):
(TEST_F):
- 8:27 PM Changeset in webkit [122189] by
-
- 6 edits in trunk/Source/WebCore
[CSS Shaders] The FECustomFilter is not making the GL context active
https://bugs.webkit.org/show_bug.cgi?id=90840
Reviewed by Dean Jackson.
I've added a couple of makeContextCurrent() in the FECustomFilter related classes.
Also, removed the assumption that GraphicsContext3D::create() never returns 0.
No new tests, this was crashing on existing tests.
- platform/graphics/filters/CustomFilterCompiledProgram.cpp:
(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
(WebCore::CustomFilterCompiledProgram::~CustomFilterCompiledProgram):
- platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
- platform/graphics/filters/CustomFilterMesh.cpp:
(WebCore::CustomFilterMesh::CustomFilterMesh):
(WebCore::CustomFilterMesh::~CustomFilterMesh):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):
- platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
- 8:18 PM Changeset in webkit [122188] by
-
- 3 edits3 adds in trunk
REGRESSION(r114862-r114886): Fix a crash by switching the input type to hidden.
https://bugs.webkit.org/show_bug.cgi?id=90774
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/forms/hidden/change-type-to-hidden-after-updating-value.html
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
Pass a copy of the existing Attribute object.
LayoutTests:
- fast/forms/hidden/change-type-to-hidden-after-updating-value.html: Added.
- fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt: Added.
- 7:38 PM Changeset in webkit [122187] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] cache video dimensions
https://bugs.webkit.org/show_bug.cgi?id=90733
Reviewed by Martin Robinson.
Invalidate the cached video dimensions whenever the video-sink sink pad caps
change and let ::naturalSize() lazily recalculate them.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- 7:29 PM Changeset in webkit [122186] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Update TestExpectations.
- platform/chromium/TestExpectations: http/tests/misc/script-defer.html started failing after r122168.
- 7:29 PM Changeset in webkit [122185] by
-
- 12 edits in trunk/Source
[chromium] Merge updates and idle updates into one pass
https://bugs.webkit.org/show_bug.cgi?id=90324
Patch by Eric Penner <epenner@google.com> on 2012-07-09
Reviewed by Adrienne Walker.
Source/WebCore:
We no longer need to do painting is passes in order
to allocate memory in the right order. So this merges
updates and idle updates into one pass.
Covered by existing unit tests (some of which are
updated with this patch).
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::needMoreUpdates):
- platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::needMoreUpdates):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateLayerRect):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
- tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
- tests/TiledLayerChromiumTest.cpp:
- 7:16 PM Changeset in webkit [122184] by
-
- 8 edits1 add1 delete in trunk/Source
[Platform] Introduce LocaleMac class
https://bugs.webkit.org/show_bug.cgi?id=90248
Reviewed by Kent Tamura.
Source/WebCore:
This patch moves implementation of localized date format related
functions into LocaleMac class as of LocaleWin class for ease of
maintain and using specific locale in testing rather than system
default locale.
Tests: WebKit/chromium/tests/LocaleMacTest.cpp
- WebCore.gyp/WebCore.gyp: Include LocaleMac.mm
- WebCore.gypi:
- platform/text/mac/LocaleMac.h: Replace LocaleWin to LocaleMac.
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::~LocaleMac):
(WebCore::LocaleMac::create):
(WebCore::LocaleMac::currentLocale):
(WebCore::LocaleMac::createShortDateFormatter):
(WebCore::LocaleMac::parseDate):
(WebCore::LocaleMac::formatDate):
(WebCore::LocaleMac::dateFormatText):
(WebCore::LocaleMac::monthLabels):
(WebCore::LocaleMac::weekDayShortLabels):
(WebCore::LocaleMac::firstDayOfWeek):
- platform/text/mac/LocalizedDateMac.cpp:
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):
- platform/text/mac/LocalizedDateMac.mm: Removed.
Source/WebKit/chromium:
This patch added tests for LocaleMac class.
- WebKit.gypi:
- tests/LocaleMacTest.cpp: Added.
(LocaleMacTest):
(LocaleMacTest::dateComponents):
(LocaleMacTest::msForDate):
(LocaleMacTest::formatDate):
(LocaleMacTest::parseDate):
(LocaleMacTest::dateFormatText):
(LocaleMacTest::firstDayOfWeek):
(LocaleMacTest::monthLabel):
(LocaleMacTest::weekDayShortLabel):
(TEST_F):
- 7:14 PM Changeset in webkit [122183] by
-
- 2 adds in trunk/LayoutTests/compositing
Forgot to actually add these files in r122152
- compositing/tile-cache-must-flatten-expected.html: Added.
- compositing/tile-cache-must-flatten.html: Added.
- 6:50 PM Changeset in webkit [122182] by
-
- 11 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out http://trac.webkit.org/changeset/121511
It made in-browser V8v7 10% slower.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::countSpeculationSuccess):
(JSC::CodeBlock::countSpeculationFailure):
(JSC::CodeBlock::speculativeSuccessCounter):
(JSC::CodeBlock::speculativeFailCounter):
(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfSpeculativeSuccessCounter):
(JSC::CodeBlock::addressOfSpeculativeFailCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfSpeculativeSuccessCounter):
(JSC::CodeBlock::offsetOfSpeculativeFailCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
- bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
- bytecode/ExecutionCounter.h:
(ExecutionCounter):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGOSRExitCompiler.cpp:
(JSC::DFG::OSRExitCompiler::handleExitCounts):
- dfg/DFGOperations.cpp:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Options.h:
(JSC):
- 6:46 PM Changeset in webkit [122181] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Update TestExpectations.
- platform/chromium/TestExpectations: Mark fast/forms/select/select-state-restore.html as flaky on WIN DEBUG.
- 6:43 PM Changeset in webkit [122180] by
-
- 4 edits5 adds in trunk/Source
[chromium] Create CCScopedTexture class for creating/freeing textures
https://bugs.webkit.org/show_bug.cgi?id=89485
Reviewed by Adrienne Walker.
Source/WebCore:
This class provides a standard way to create texture ids in a way that
ensures they will be freed later.
Also includes a CCTexture base class that holds textureId, size, and
format together in a struct that can be used in place of storing an
unsigned textureId in other classes.
Unit tests: CCScopedTexureTest.NewScopedTexture
CCScopedTexureTest.CreateScopedTexture
CCScopedTexureTest.ScopedTextureIsDeleted
CCScopedTexureTest.LoseScopedTexture
- WebCore.gypi:
- platform/graphics/chromium/cc/CCScopedTexture.cpp: Added.
(WebCore):
(WebCore::CCScopedTexture::CCScopedTexture):
(WebCore::CCScopedTexture::~CCScopedTexture):
(WebCore::CCScopedTexture::allocate):
(WebCore::CCScopedTexture::free):
(WebCore::CCScopedTexture::leak):
- platform/graphics/chromium/cc/CCScopedTexture.h: Added.
(WebCore):
(CCScopedTexture):
(WebCore::CCScopedTexture::create):
- platform/graphics/chromium/cc/CCTexture.cpp: Added.
(WebCore):
(WebCore::CCTexture::setDimensions):
(WebCore::CCTexture::bytes):
(WebCore::CCTexture::memorySizeBytes):
- platform/graphics/chromium/cc/CCTexture.h: Added.
(WebCore):
(CCTexture):
(WebCore::CCTexture::CCTexture):
(WebCore::CCTexture::id):
(WebCore::CCTexture::size):
(WebCore::CCTexture::format):
(WebCore::CCTexture::setId):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/CCScopedTextureTest.cpp: Added.
(WebKitTests):
(WebKitTests::TEST):
(TrackingTextureAllocator):
(WebKitTests::TrackingTextureAllocator::TrackingTextureAllocator):
(WebKitTests::TrackingTextureAllocator::numTextures):
- 6:39 PM Changeset in webkit [122179] by
-
- 3 edits2 adds in trunk
IndexedDB: deleteDatabase fails if transaction running in other database
https://bugs.webkit.org/show_bug.cgi?id=90822
Reviewed by Tony Chang.
Source/WebCore:
The IDBLevelDBBackingStore was preventing a deleteDatabase() from running
if any other database was running a transaction. Fix by just creating a scratch
LevelDBTransaction for the delete steps.
Test: storage/indexeddb/deletedatabase-transaction.html
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::deleteDatabase): Use a LevelDBTransaction
directly.
LayoutTests:
- storage/indexeddb/deletedatabase-transaction-expected.txt: Added.
- storage/indexeddb/deletedatabase-transaction.html: Added.
- 6:37 PM Changeset in webkit [122178] by
-
- 17 edits4 adds in trunk
.: Expose an export for the iconUrl list so Internals can use it
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.
- Source/autotools/symbols.filter: export iconURLs
Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura..
As it turns out, it can contain stale URLs in the case that some script
manipulates the DOM, which breaks scripts trying to reset the favicon
URL. Also added a method in Internals to allow tests to get the list of
icon
Tests: fast/dom/icon-url-change.html
fast/dom/icon-url-list.html
- WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
- dom/Document.cpp:
(WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
(WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
(WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace
- dom/Document.h:
(Document): removed the addIconURL method which is no longer used
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
(WebCore):
(WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor
- html/HTMLLinkElement.h:
(HTMLLinkElement): declared the icon type and size accessors
- testing/Internals.cpp:
(WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
(WebCore):
- testing/Internals.h:
(Internals): declared the method for unit testing the icon URL list
- testing/Internals.idl: exported the Document::iconURLs function
Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.
- win/WebKit2.def: export the DocumentL::iconURLs function
LayoutTests: Add some new unit tests to test the favicon changing dynamically
https://bugs.webkit.org/show_bug.cgi?id=88665
Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.
- fast/dom/icon-url-change-expected.txt: Added.
- fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
- fast/dom/icon-url-list-expected.txt: Added.
- fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
- fast/dom/icon-url-property-expected.txt: update unit test expectations
- fast/dom/icon-url-property.html: update and enable existing favicon test
- platform/chromium/TestExpectations: reenable the url-property test
- 6:35 PM Changeset in webkit [122177] by
-
- 2 edits in trunk/Source/WebCore
Gcc build fix after r122174.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::decrementAccessCount):
- 6:25 PM Changeset in webkit [122176] by
-
- 5 edits in trunk
Editing: Autocorrection in blockquotes causes text to break out of quote
https://bugs.webkit.org/show_bug.cgi?id=90487
<rdar://problem/11769020>
Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-09
Reviewed by Enrica Casucci.
Source/WebCore:
Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html
SpellingCorrectionCommand uses ReplaceSelectionCommand to replace the misspelled word with the auto-corrected word. Specifically, ReplaceSelectionCommand does a smart copy, where it breaks out of blockquotes. Thus, the fix is to substitute ReplaceSelectionCommand with InserTextCommand.
- editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply):
LayoutTests:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
- 6:06 PM Changeset in webkit [122175] by
-
- 48 edits2 deletes in trunk
90506
- 6:03 PM Changeset in webkit [122174] by
-
- 20 edits3 adds in trunk
Consider closing unused localStorage database after a timeout.
https://bugs.webkit.org/show_bug.cgi?id=90713
For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
we can close the underlying sqlite database.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-07-09
Reviewed by Brady Eidson.
Source/WebCore:
Test: storage/domstorage/storage-close-database-on-idle.html
- storage/Storage.cpp:
(WebCore::Storage::Storage): increment storageArea access count when a DOMWindow is referencing it.
(WebCore::Storage::~Storage): decrement storageArea access count when DOMWindow is done with it.
- storage/StorageArea.h:
(StorageArea):
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::StorageAreaImpl):
(WebCore::StorageAreaImpl::incrementAccessCount):
(WebCore):
(WebCore::StorageAreaImpl::decrementAccessCount): schedule closeDatabaseTimer if there is no active document
referencing to this storageArea.
(WebCore::StorageAreaImpl::closeDatabaseTimerFired): close the underlying sqlite database.
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::sync): if m_syncCloseDatabase flag is set and the database is not opened, bail out.
- storage/StorageTracker.cpp:
(WebCore):
(WebCore::StorageTracker::StorageTracker):
- storage/StorageTracker.h:
(WebCore::StorageTracker::storageDatabaseIdleInterval):
(WebCore::StorageTracker::setStorageDatabaseIdleInterval): set the timeout value that we will wait before closing the
database. This is currently used by DumpRenderTree only.
(StorageTracker):
Source/WebKit/mac:
- Storage/WebStorageManager.mm:
(+[WebStorageManager setStorageDatabaseIdleInterval:]): add a new method for DumpRenderTree to set the timeout
that we will wait before closing database.
(initializeLocalStoragePath):
- Storage/WebStorageManagerPrivate.h:
Tools:
- DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner
to set a different timeout value for closing localStorage database.
(setStorageDatabaseIdleIntervalCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setStorageDatabaseIdleInterval): add empty method.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setStorageDatabaseIdleInterval): ditto.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setStorageDatabaseIdleInterval): ditto.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setStorageDatabaseIdleInterval): ditto.
LayoutTests:
- platform/chromium/TestExpectations: the test needs setCacheModel implementation, skip it in chromium.
- storage/domstorage/storage-close-database-on-idle-expected.txt: Added.
- storage/domstorage/storage-close-database-on-idle.html: Added.
- storage/resources/storage-close-data-on-idle-switch.html: Added.
- 5:48 PM Changeset in webkit [122173] by
-
- 6 edits in trunk
IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
https://bugs.webkit.org/show_bug.cgi?id=90474
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/transaction-basics.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBDatabase.idl:
LayoutTests:
- storage/indexeddb/resources/transaction-basics.js:
(testInvalidMode):
(testDegenerateNames.request.onsuccess):
(testDegenerateNames.verifyDegenerateNames):
(testDegenerateNames):
- storage/indexeddb/transaction-basics-expected.txt:
- 5:41 PM Changeset in webkit [122172] by
-
- 17 edits in trunk/Source
IndexedDB: Remove obsolete accessor plumbing
https://bugs.webkit.org/show_bug.cgi?id=90812
Reviewed by Tony Chang.
Source/WebCore:
No new tests - just deleting code.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction): Since backend mode() is disconnected, can no
longer assert that front-end/back-end modes match; not worth it to keeping the plumbing.
Source/WebKit/chromium:
- public/WebIDBCursor.h: Remove direction.
- public/WebIDBDatabase.h: Remove name, version, objectStoreNames;
(WebKit::WebIDBDatabase::metadata):
- public/WebIDBIndex.h: Remove name, keyPath, unique, multiEntry;
- public/WebIDBObjectStore.h: Remove name, keyPath, indexNames, autoIncrement;
- src/IDBDatabaseBackendProxy.cpp: Remove plumbing.
- src/IDBDatabaseBackendProxy.h: Remove plumbing.
(IDBDatabaseBackendProxy):
- src/IDBIndexBackendProxy.cpp: Remove plumbing.
- src/IDBIndexBackendProxy.h: Remove plumbing.
(IDBIndexBackendProxy):
- src/IDBObjectStoreBackendProxy.cpp: Remove plumbing.
- src/IDBObjectStoreBackendProxy.h: Remove plumbing.
(IDBObjectStoreBackendProxy):
- src/IDBTransactionBackendProxy.cpp: Remove plumbing.
- src/IDBTransactionBackendProxy.h: Assert stub is not used - only needed
by real IDBTransactionBackendImpl
(WebKit::IDBTransactionBackendProxy::mode):
- src/WebIDBTransactionImpl.cpp: Remove plumbing.
- src/WebIDBTransactionImpl.h: Remove plumbing.
- 5:20 PM Changeset in webkit [122171] by
-
- 15 edits2 deletes in trunk/Source/WebKit/chromium
Unreviewed, rolling out r122161.
http://trac.webkit.org/changeset/122161
https://bugs.webkit.org/show_bug.cgi?id=90837
failed to compile on chromium webkit linux bot (Requested by
shawnsingh on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09
- WebKit.gypi:
- WebKitUnitTests.gyp:
- public/WebDOMMessageEvent.h:
- tests/AssociatedURLLoaderTest.cpp:
(WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
(WebKit::AssociatedURLLoaderTest::SetUp):
(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):
- tests/EventListenerTest.cpp:
- tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::loadFrame):
- tests/FrameTestHelpers.h:
(FrameTestHelpers):
- tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
- tests/PopupMenuTest.cpp:
(WebKit::SelectPopupMenuTest::registerMockedURLLoad):
(WebKit::SelectPopupMenuTest::loadFrame):
(WebKit::TEST_F):
- tests/RunAllTests.cpp:
- tests/URLTestHelpers.cpp: Removed.
- tests/URLTestHelpers.h: Removed.
- tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):
- tests/WebPageNewSerializerTest.cpp:
(WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
(WebPageNewSerializeTest):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):
- tests/WebPageSerializerTest.cpp:
(WebKit::WebPageSerializerTest::registerMockedURLLoad):
(WebKit::WebPageSerializerTest::loadURLInTopFrame):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):
- tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):
- 5:17 PM Changeset in webkit [122170] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=90825
Reviewed by Adrienne Walker.
Layer ids are no longer allowed to be 0, and the behaviour is guarded
with asserts, so this workaround is not needed any longer.
- platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
- 5:08 PM Changeset in webkit [122169] by
-
- 3 edits2 adds in trunk
Pointer Lock requestPointerLock rejects locking an element not in a document.
https://bugs.webkit.org/show_bug.cgi?id=90821
Reviewed by Adrienne Walker.
Source/WebCore:
Test: pointer-lock/lock-element-not-in-dom.html
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
LayoutTests:
- pointer-lock/lock-element-not-in-dom-expected.txt: Added.
- pointer-lock/lock-element-not-in-dom.html: Added.
- 4:48 PM Changeset in webkit [122168] by
-
- 8 edits3 adds in trunk
document.write of scripts that also document.write sometimes writes async
https://bugs.webkit.org/show_bug.cgi?id=89102
Reviewed by Adam Barth.
Source/WebCore:
When a script tag is first encountered, the TreeBuilder holds the element and returns
out to the outer HTMLDocumentParser parse loop. The HTMLDocumentParser then takes
the script element and passes it to the HTMLScriptRunner for execution. However, if the
script is an "external script" the HTMLScriptRunner may have to wait for that parser
blocking script to load, and may store the script in its own m_parserBlockingScript member.
While the HTMLScriptRunner has this not-yet-loaded-script the parser is also blocked.
Because the "paused" state of the parser was held as a separate bool on the TreeBuilder
we'd have to be careful to update it to reflect the current state of this pending script
on the HTMLScriptRunner.
This patch removes this separate "paused" bool and makes the HTMLDocumentParser responsible
for the "paused" state of the parser through the isWaitingForScripts() function which
knows how to check both the TreeBuilder and the ScriptRunner for possible parser-blocking scripts.
I suspect this change may actually fix a bunch of edge cases where we were not
checking for the HTMLScriptRunner's parser blocking script and thus incorrectly ending
the parser, or not starting the pre-load scanner, etc.
As part of this change I also renamed m_haveParsingBlockingScript in HTMLScriptRunner to match
the naming style used elsewhere in the parser, as well as removed all the "bool" return values
for these parse/execute functions as they are no longer useful (or correct). The correct way
is always to check HTMLDocumentParser::isWaitingForScripts().
Test: fast/parser/cached-script-document-write.html
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizerIfPossible):
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::isWaitingForScripts):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
(WebCore::HTMLDocumentParser::notifyFinished):
(WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):
- html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::~HTMLScriptRunner):
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::hasParserBlockingScript):
(WebCore::HTMLScriptRunner::executeParsingBlockingScripts):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::requestParsingBlockingScript):
(WebCore::HTMLScriptRunner::runScript):
- html/parser/HTMLScriptRunner.h:
(HTMLScriptRunner):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
- html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::hasParserBlockingScript):
LayoutTests:
- fast/parser/cached-script-document-write-expected.txt: Added.
- fast/parser/cached-script-document-write.html: Added.
- fast/parser/resources/cached-script-document-write.js: Added.
- 4:28 PM Changeset in webkit [122167] by
-
- 5 edits3 adds in trunk
Source/JavaScriptCore: DFG may get stuck in an infinite fix point if it constant folds a mispredicted node
https://bugs.webkit.org/show_bug.cgi?id=90829
<rdar://problem/11823843>
Reviewed by Oliver Hunt.
If a node is shown to have been mispredicted during CFA, then don't allow constant
folding to make the graph even more degenerate. Instead, pull back on constant folding
and allow the normal OSR machinery to fix our profiling so that a future recompilation
doesn't see the same mistake.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::trySetConstant):
(AbstractState):
- dfg/DFGPhase.h:
(JSC::DFG::Phase::name):
(Phase):
(JSC::DFG::runAndLog):
(DFG):
(JSC::DFG::runPhase):
LayoutTests: DFG may get stuck in an infinite fix point if it constant folds a mispredicted node
https://bugs.webkit.org/show_bug.cgi?id=90829
Reviewed by Oliver Hunt.
- fast/js/dfg-constant-fold-misprediction-expected.txt: Added.
- fast/js/dfg-constant-fold-misprediction.html: Added.
- fast/js/script-tests/dfg-constant-fold-misprediction.js: Added.
(foo):
- 4:26 PM Changeset in webkit [122166] by
-
- 25 edits6 adds in trunk/Source
It should be possible to jettison JIT stub routines even if they are currently running
https://bugs.webkit.org/show_bug.cgi?id=90731
Reviewed by Gavin Barraclough.
This gives the GC awareness of all JIT-generated stubs for inline caches. That
means that if you want to delete a JIT-generated stub, you don't have to worry
about whether or not it is currently running: if there is a chance that it might
be, the GC will kindly defer deletion until non-running-ness is proved.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/Instruction.h:
(JSC):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- bytecode/PolymorphicPutByIdList.cpp:
(JSC::PutByIdAccess::fromStructureStubInfo):
- bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::stubRoutine):
(PutByIdAccess):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::reset):
- dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
- heap/ConservativeRoots.cpp:
(JSC):
(DummyMarkHook):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::add):
(CompositeMarkHook):
(JSC::CompositeMarkHook::CompositeMarkHook):
(JSC::CompositeMarkHook::mark):
- heap/ConservativeRoots.h:
(JSC):
(ConservativeRoots):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::deleteUnmarkedCompiledCode):
- heap/Heap.h:
(JSC):
(Heap):
- heap/JITStubRoutineSet.cpp: Added.
(JSC):
(JSC::JITStubRoutineSet::JITStubRoutineSet):
(JSC::JITStubRoutineSet::~JITStubRoutineSet):
(JSC::JITStubRoutineSet::add):
(JSC::JITStubRoutineSet::clearMarks):
(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
(JSC::JITStubRoutineSet::traceMarkedStubRoutines):
- heap/JITStubRoutineSet.h: Added.
(JSC):
(JITStubRoutineSet):
(JSC::JITStubRoutineSet::mark):
- heap/MachineStackMarker.h:
(JSC):
- interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
- interpreter/RegisterFile.h:
(JSC):
- jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::DemandExecutableAllocator):
- jit/ExecutableAllocator.h:
(JSC):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC):
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
- jit/GCAwareJITStubRoutine.cpp: Added.
(JSC):
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::GCAwareJITStubRoutine::deleteFromGC):
(JSC::GCAwareJITStubRoutine::markRequiredObjectsInternal):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::~MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::createJITStubRoutine):
- jit/GCAwareJITStubRoutine.h: Added.
(JSC):
(GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::markRequiredObjects):
(MarkingGCAwareJITStubRoutineWithOneObject):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubRoutine.cpp: Added.
(JSC):
(JSC::JITStubRoutine::~JITStubRoutine):
(JSC::JITStubRoutine::observeZeroRefCount):
- jit/JITStubRoutine.h: Added.
(JSC):
(JITStubRoutine):
(JSC::JITStubRoutine::JITStubRoutine):
(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::code):
(JSC::JITStubRoutine::asCodePtr):
(JSC::JITStubRoutine::ref):
(JSC::JITStubRoutine::deref):
(JSC::JITStubRoutine::startAddress):
(JSC::JITStubRoutine::endAddress):
(JSC::JITStubRoutine::addressStep):
(JSC::JITStubRoutine::canPerformRangeFilter):
(JSC::JITStubRoutine::filteringStartAddress):
(JSC::JITStubRoutine::filteringExtentSize):
(JSC::JITStubRoutine::passesFilter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
- 4:21 PM Changeset in webkit [122165] by
-
- 2 edits in trunk/LayoutTests
fast/js/global-constructors.html is flaky and mostly useless
https://bugs.webkit.org/show_bug.cgi?id=90833
Unreviewed, skip flaky and useless test.
- platform/mac/Skipped:
- 4:10 PM Changeset in webkit [122164] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marked webgl/glsl-conformance tests failing after dependency roll in chromium.
- platform/chromium/TestExpectations:
- 4:07 PM Changeset in webkit [122163] by
-
- 2 edits in trunk/Source/WebCore
Microdata tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=90830
Reviewed by Antti Koivisto.
The bug was caused by SpaceSplitString's not copying on write properly.
Even if there was exactly one owner of the SpaceSplitString, we should still not modify
m_data since m_data is associated with a particular m_keyString in sharedDataMap().
The only situation in which we can safely modify m_data is when m_data's m_keyString is null
meaning that it had been unique'ed. Furthermore, this optimization had not been used for
class lists because class list's refCount is always zero as its ref and deref are forwarded
to the associated Element's ref and deref. This fix re-enables the optimization for class lists.
This behavior change is tested by existing microdata API tests. Without this patch,
some tests such as properties-collection-add-remove-property.html fail on the first run
when several tests were ran in the same WebKit instance.
- dom/SpaceSplitString.h:
(WebCore::SpaceSplitStringData::isUnique):
(WebCore::SpaceSplitString::ensureUnique):
- 4:05 PM Changeset in webkit [122162] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=90817
Patch by Yong Li <yoli@rim.com> on 2012-07-09
Reviewed by Rob Buis.
PR# 174085.
PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes.
This patch also removes unused variable m_parentPopup and its setter.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Remove m_parentPopup.
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::closePagePopup):
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::init): Remove the setParentPopup() call.
(WebCore::PagePopupBlackBerry::closePopup): Clear the reference in WebPagePrivate.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValueAndClosePopup): Add an assert for valid m_element.
- 4:03 PM Changeset in webkit [122161] by
-
- 15 edits1 copy1 add in trunk/Source/WebKit/chromium
[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094
Reviewed by Adam Barth.
This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored, and GURL types were replaced with KURL types.
- WebKit.gypi:
- WebKitUnitTests.gyp:
- public/WebDOMMessageEvent.h:
(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):
- tests/AssociatedURLLoaderTest.cpp:
- tests/EventListenerTest.cpp:
- tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::loadFrame):
- tests/FrameTestHelpers.h:
- tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
- tests/PopupMenuTest.cpp:
- tests/RunAllTests.cpp:
- tests/URLTestHelpers.cpp: Added.
(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):
- tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.
(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):
- tests/WebFrameTest.cpp:
- tests/WebPageNewSerializerTest.cpp:
- tests/WebPageSerializerTest.cpp:
- tests/WebViewTest.cpp:
- 3:31 PM Changeset in webkit [122160] by
-
- 24 edits in trunk/Source
[chromium] Decouple RenderPass drawing from CCRenderSurface
https://bugs.webkit.org/show_bug.cgi?id=90573
Reviewed by Adrienne Walker.
Source/WebCore:
Removes the managed textures from CCRenderSurface and stores them in a
HashMap in LayerRendererChromium.
At the start of a frame, all textures for the frame are reserved, and
unneeded textures are deleted. After each quad is drawn, evicted textures
(ie temporary textures used for background filters) are deleted to keep
within memory limits. At the end of the frame, all surface contents
textures are kept reserved and thus not deleted.
We add a numeric identifier to CCRenderPass which can be used to
identify the pass across serialization in the future, and is used
in the interface to LayerRendererChromium. Also we add to the
CCRenderPass a contentsChangedSinceLastFrame() flag so that the
value does not need to be retrieved from the CCRenderSurface.
The pointer from CCRenderPass to CCRenderSurface remains for some
code in the CCLayerTreeHostImpl, and will be addressed in the future, but
the pointer is no longer used at all while drawing a frame inside
LayerRendererChromium.
Covered by existing tests, no intended change in behaviour.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore):
(WebCore::LayerRendererChromium::haveCachedResourcesForRenderPassId):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::initializeSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore::CCRenderPass::setFramebufferOutputRect):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):
(WebCore::CCRenderPassDrawQuad::contentsChangedSinceLastFrame):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendQuads):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
(CCRenderSurface):
- platform/graphics/chromium/cc/CCRenderer.h:
(CCRenderer):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::pushTileProperties):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
- tests/LayerRendererChromiumTest.cpp:
(FakeCCRendererClient::FakeCCRendererClient):
- 2:34 PM Changeset in webkit [122159] by
-
- 39 edits5 moves in trunk
Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=90810
Reviewed by Ojan Vafai.
Source/WebCore:
This is in preparation for removing the vendor prefix from the
MutationObserver constructor on Window (currently it's called
WebKitMutationObserver). Doing the WebCore-internal rename first
makes that change a much smaller one, which is especially useful
because there's ongoing discussion of when the prefix should be
removed from the web-facing API.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSMainThreadExecState.cpp:
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
- bindings/js/JSMutationCallbackCustom.cpp:
(WebCore::JSMutationCallback::handleEvent):
- bindings/js/JSMutationObserverCustom.cpp: Renamed from Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp.
(WebCore):
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
- bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext):
- bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/custom/V8MutationObserverCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp.
(WebCore):
(WebCore::V8MutationObserver::constructorCallback):
- dom/CharacterData.cpp:
- dom/ChildListMutationScope.h:
(WebCore::ChildListMutationScope::ChildListMutationScope):
- dom/DOMAllInOne.cpp:
- dom/Document.h:
(WebCore::Document::hasMutationObserversOfType):
- dom/Element.cpp:
- dom/MutationCallback.h:
(WebCore):
(MutationCallback):
- dom/MutationCallback.idl:
- dom/MutationObserver.cpp: Renamed from Source/WebCore/dom/WebKitMutationObserver.cpp.
(WebCore):
(WebCore::MutationObserver::ObserverLessThan::operator()):
(WebCore::MutationObserver::create):
(WebCore::MutationObserver::MutationObserver):
(WebCore::MutationObserver::~MutationObserver):
(WebCore::MutationObserver::validateOptions):
(WebCore::MutationObserver::observe):
(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::disconnect):
(WebCore::MutationObserver::observationStarted):
(WebCore::MutationObserver::observationEnded):
(WebCore::activeMutationObservers):
(WebCore::MutationObserver::enqueueMutationRecord):
(WebCore::MutationObserver::setHasTransientRegistration):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):
- dom/MutationObserver.h: Renamed from Source/WebCore/dom/WebKitMutationObserver.h.
(WebCore):
(MutationObserver):
- dom/MutationObserver.idl: Renamed from Source/WebCore/dom/WebKitMutationObserver.idl.
- dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::createIfNeeded):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
- dom/MutationObserverInterestGroup.h:
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
- dom/MutationObserverRegistration.h:
(MutationObserverRegistration):
(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):
- dom/Node.cpp:
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
- dom/Node.h:
(Node):
- dom/NodeRareData.h:
- page/DOMWindow.idl:
Source/WebKit/chromium:
- src/WebKit.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):
Tools:
- DumpRenderTree/gtk/EventSender.cpp:
- 2:19 PM Changeset in webkit [122158] by
-
- 13 edits2 adds in trunk/LayoutTests
Refactor common Pointer Lock test code to a harness.
https://bugs.webkit.org/show_bug.cgi?id=90813
Reviewed by Adrienne Walker.
- pointer-lock/bug90391-move-then-window-open-crash-expected.txt:
- pointer-lock/bug90391-move-then-window-open-crash.html:
- pointer-lock/lock-already-locked-expected.txt:
- pointer-lock/lock-already-locked.html:
- pointer-lock/lock-fail-responses-expected.txt:
- pointer-lock/lock-fail-responses.html:
- pointer-lock/mouse-event-delivery-expected.txt:
- pointer-lock/mouse-event-delivery.html:
- pointer-lock/pointer-lock-api-expected.txt:
- pointer-lock/pointer-lock-api.html:
- pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
- pointer-lock/pointerlockchange-pointerlockerror-events.html:
- pointer-lock/pointerlocklost-event-expected.txt:
- pointer-lock/pointerlocklost-event.html:
- pointer-lock/resources/pointer-lock-test-harness.js: Added.
(doNextStep.else):
(doNextStepWithUserGesture):
(eventExpected.targetHanderNode.eventHandlerName):
(eventExpected):
(expectOnlyChangeEvent):
(expectOnlyErrorEvent):
(expectNoEvents):
- 2:19 PM Changeset in webkit [122157] by
-
- 1 edit in branches/chromium/1180/Source/WebKit/chromium/features.gypi
Revert 116356
BUG=135658
Review URL: https://chromiumcodereview.appspot.com/10758010
- 2:12 PM Changeset in webkit [122156] by
-
- 21 edits in trunk/Source/WebCore
Unreviewed, rolling out http://trac.webkit.org/changeset/122116 and http://trac.webkit.org/changeset/122119
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext3D.h:
(WebCore):
- platform/graphics/OpenGLESShims.h:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore):
- platform/graphics/clutter/GraphicsContext3DClutter.cpp:
(WebCore):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::Extensions3DOpenGL):
(WebCore::Extensions3DOpenGL::supports):
(WebCore):
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):
(WebCore::Extensions3DOpenGL::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGL::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DOpenGL::copyTextureCHROMIUM):
- platform/graphics/opengl/Extensions3DOpenGL.h:
(Extensions3DOpenGL):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
- platform/graphics/opengl/Extensions3DOpenGLCommon.h:
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
- platform/graphics/opengl/Extensions3DOpenGLES.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getExtensions):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore):
- 1:52 PM Changeset in webkit [122155] by
-
- 6 edits in trunk/Source/WebCore
Build fix after r122115 and some cleanups.
- html/HTMLCollection.h:
(HTMLCollection):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::properties):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
- html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):
- 1:46 PM Changeset in webkit [122154] by
-
- 2 edits in trunk/Tools
Handle missing results in TestResultsServer better
https://bugs.webkit.org/show_bug.cgi?id=90816
Reviewed by Ojan Vafai.
If we can't load the results JSON, don't try to wrap it with the JSONP
callback invocation.
- TestResultServer/handlers/testfilehandler.py:
(GetFile.get):
- 1:46 PM Changeset in webkit [122153] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Add missing Battery Status API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=90784
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-09
Reviewed by Anders Carlsson.
Integrate Battery Status API to WebPage, WebContext and
properly route messages to the WebBatteryManagerProxy.
Without this, the Battery Status tests are crashing for
WebKit2.
- UIProcess/API/C/WKContext.cpp:
(WKContextGetBatteryManager):
- UIProcess/API/C/WKContext.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
- UIProcess/WebContext.h:
(WebKit):
(WebContext):
(WebKit::WebContext::batteryManagerProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
- WebProcess/WebCoreSupport/WebBatteryClient.cpp:
(WebKit::WebBatteryClient::setController):
(WebKit):
- WebProcess/WebCoreSupport/WebBatteryClient.h:
(WebBatteryClient):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 1:36 PM Changeset in webkit [122152] by
-
- 6 edits in trunk
Tiled drawing means some elements can disappear behind the page
https://bugs.webkit.org/show_bug.cgi?id=88906
Reviewed by Simon Fraser.
Source/WebCore:
The compositing layers in the tile cache could become siblings
of the compositing layers for page elements. This meant that in
some 3d transforms, the elements could disappear behind the
page background (which is rendered into the tile cache) or intersect
with the tile cache tiles.
Fix this by inserting a flattening layer between the tile cache
and the page, ensuring that the cache will always be rendered
first. I was able to reuse the clipping layer for this, because
the tile cache is attached to the RenderView, so there should never
be a case where we have both a clipping layer and tiles.
The unfortunate part of this code is the temporary state variable
that wraps the call to GraphicsLayer::create. Because that method
calls back into the object, we need to make sure we don't create
another tile cache.
Also added some obvious names to the tile cache layers to
help with debugging.
Test: compositing/tile-cache-must-flatten.html
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache): give the tile host layer a name.
(WebCore::TileCache::createTileLayer):
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(WebCore): give each tile layer a name.
- rendering/RenderLayerBacking.cpp:
(WebCore):
(WebCore::RenderLayerBacking::shouldUseTileCache): check if we're in the middle
of creating the primary graphics layer before answering.
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): wrap our call to
createGraphicsLayer with a message to indicate we are making the layer that should
get a tile cache.
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): needs to make
sure the flattening layer is in the tree.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
- rendering/RenderLayerBacking.h: rename m_clippingLayer to m_containmentLayer
because it can now either be the clip or the tile cache flattener. Also
a new state property used when creating the main graphics layer.
(WebCore::RenderLayerBacking::hasClippingLayer):
(WebCore::RenderLayerBacking::clippingLayer):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
(RenderLayerBacking):
LayoutTests:
Reftest to make sure elements can't disappear behind the tile cache.
- compositing/tile-cache-must-flatten-expected.html: Added.
- compositing/tile-cache-must-flatten.html: Added.
- 1:10 PM Changeset in webkit [122151] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r122124.
http://trac.webkit.org/changeset/122124
https://bugs.webkit.org/show_bug.cgi?id=90815
It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._skipped_file_search_paths):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_skipped_path):
(QtPortTest.test_skipped_file_search_path):
- 12:59 PM Changeset in webkit [122150] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Log significant Gamepad API-related events
https://bugs.webkit.org/show_bug.cgi?id=90595
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-09
Reviewed by Antonio Gomes.
Log significant Gamepad API-related events in
GamepadsEfl.
No new tests, no behavior change.
- platform/efl/GamepadsEfl.cpp:
(WebCore::GamepadDeviceEfl::deviceFile):
(GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):
- 12:58 PM Changeset in webkit [122149] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 120731
BUG=132690
Review URL: https://chromiumcodereview.appspot.com/10763008
- 12:57 PM Changeset in webkit [122148] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 120731
BUG=132690
Review URL: https://chromiumcodereview.appspot.com/10750009
- 12:53 PM Changeset in webkit [122147] by
-
- 35 edits2 adds in trunk
[Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89356
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a new method for returning the WebKitDOMDocument that is loaded
in a given frame, webkit_web_frame_get_dom_document.
- docs/webkitgtk-sections.txt:
- webkit/webkitwebframe.cpp:
(webkit_web_frame_get_dom_document):
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp: State explicitly that the document being returned
when calling webkit_web_view_get_dom_document is loaded in the main frame.
Also call the webkit_web_frame_get_dom_document on WebKitWebView's main frame
to get the document.
Tools:
Implement dumpFrameScrollPosition, acquiring the scroll position
through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
whose scroll position is being dumped.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpFrameScrollPosition):
LayoutTests:
Update baselines for affected tests, removing these tests from the GTK WK2 Skipped list.
- platform/gtk-wk2/Skipped:
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt:
- platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt:
- platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
- platform/gtk/fast/dom/focus-contenteditable-expected.txt:
- platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt:
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt:
- platform/gtk/fast/dynamic/anchor-lock-expected.txt:
- platform/gtk/fast/events/autoscroll-expected.txt:
- platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
- platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
- platform/gtk/fast/multicol/scrolling-overflow-expected.txt: Added.
- platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
- platform/gtk/fast/overflow/overflow_hidden-expected.txt:
- platform/gtk/fast/overflow/position-fixed-transform-clipping-expected.txt:
- platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
- platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
- platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
- platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
- platform/gtk/fast/repaint/fixed-expected.txt:
- platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
- platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
- platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
- platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
- platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
- 12:53 PM Changeset in webkit [122146] by
-
- 1 edit in branches/chromium/1180/Source/WebCore/loader/DocumentThreadableLoader.cpp
Merge 120845
BUG=132241
Review URL: https://chromiumcodereview.appspot.com/10750008
- 12:52 PM Changeset in webkit [122145] by
-
- 2 edits in trunk/Source/WebCore
Reduce the amount of flashing when falling into tiled layers
https://bugs.webkit.org/show_bug.cgi?id=90808
Reviewed by Dean Jackson.
Implement +prefetchedTiles so that CATiledLayer renders more
tiles at a time, reducing the appearance of flashing.
- platform/graphics/mac/WebTiledLayer.mm:
(+[WebTiledLayer prefetchedTiles]):
- 12:51 PM Changeset in webkit [122144] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 120845
BUG=132241
Review URL: https://chromiumcodereview.appspot.com/10765006
- 12:42 PM Changeset in webkit [122143] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 121491
BUG=134428
Review URL: https://chromiumcodereview.appspot.com/10762005
- 12:41 PM Changeset in webkit [122142] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 121491
BUG=134428
Review URL: https://chromiumcodereview.appspot.com/10762004
- 12:39 PM Changeset in webkit [122141] by
-
- 3 edits2 copies in branches/chromium/1180
Merge 121388
BUG=134305
Review URL: https://chromiumcodereview.appspot.com/10756010
- 12:37 PM Changeset in webkit [122140] by
-
- 3 edits2 copies in branches/chromium/1132
Merge 121388
BUG=134305
Review URL: https://chromiumcodereview.appspot.com/10763005
- 12:36 PM Changeset in webkit [122139] by
-
- 7 edits in trunk
SurroundingText should not advance character iterators if they are at end.
https://bugs.webkit.org/show_bug.cgi?id=90560
Reviewed by Ryosuke Niwa.
Source/WebCore:
CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.
Test: platform/chromium/editing/surrounding-text/surrounding-text.html
- editing/SurroundingText.cpp:
(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):
Source/WebKit/chromium:
Moving the check for null visible positions to WebCore as it makes no
sense to be in a platform-specific code.
- src/WebSurroundingText.cpp:
(WebKit::WebSurroundingText::initialize):
LayoutTests:
Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705
- platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
- platform/chromium/editing/surrounding-text/surrounding-text.html:
- 12:33 PM Changeset in webkit [122138] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 121031
BUG=134123
Review URL: https://chromiumcodereview.appspot.com/10750006
- 12:31 PM Changeset in webkit [122137] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 121031
BUG=134123
Review URL: https://chromiumcodereview.appspot.com/10757006
- 12:27 PM Changeset in webkit [122136] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] [WK2] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
https://bugs.webkit.org/show_bug.cgi?id=90464
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.
HashMap has the property that 0 is the empty value for integer
keys, so do not use 0 as a key in the HashMap.
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::dispatchAfterDelay):
- 12:27 PM Changeset in webkit [122135] by
-
- 3 edits1 add in trunk
[BlackBerry] meta viewport initial-scale doesn't factor in device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90575
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-09
Reviewed by Rob Buis.
.:
Add a manual test to verify wide content doesn't interfere
with initial-scale calculations.
Internal review from Konrad Piascik.
- ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html: Added.
Source/WebKit/blackberry:
Refactor meta viewport handling to multiply the developer
specified scale properties by the devicePixelRatio. This
required moving the setting of these values until after
the call to computeViewportAttributes.
This fixes an isssue where content wider than the meta viewport
would case a zoom-out-to-fit scenario because we misinterpreted
the specified initial-scale.
New test to verify wide content doesn't affect initial-scale:
ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html
Internal review from Konrad Piascik, Arvid Nilsson.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- 12:25 PM Changeset in webkit [122134] by
-
- 2 edits in trunk/Source/WebCore
[EFL] [WK2] Ecore errors from ecore_evas_screen_geometry_get()
https://bugs.webkit.org/show_bug.cgi?id=90609
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.
Do not call ecore_evas_screen_geometry_get() if ecoreEvas is null.
No new tests. This patch doesn't change behavior.
- platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenRect): Early return if Evas is null.
- 12:19 PM Changeset in webkit [122133] by
-
- 4 edits2 copies in branches/chromium/1180
Merge 121001
BUG=133418
Review URL: https://chromiumcodereview.appspot.com/10729003
- 12:18 PM Changeset in webkit [122132] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Update TestExpectations after filename change in r122109.
- platform/chromium/TestExpectations:
- 12:17 PM Changeset in webkit [122131] by
-
- 4 edits2 copies in branches/chromium/1132
Merge 121001
BUG=133418
Review URL: https://chromiumcodereview.appspot.com/10764007
- 12:16 PM Changeset in webkit [122130] by
-
- 6 edits10 adds in trunk
[CSS Filters] Blur filter is not repainted correctly when applied on a parent of a fixed element
https://bugs.webkit.org/show_bug.cgi?id=90087
Reviewed by Simon Fraser.
Source/WebCore:
Added a new method, RenderLayer::hasAncestorWithFilterOutsets, to check that there's no filter with outsets (ie. blur)
applied on top level fixed positioned elements, nor any of its parent layers. In the event of a blur filter we need to
disable the fast scrolling optimization, otherwise the outsets of the filter will be carried around the page and
repainting will not work correctly.
Tests: css3/filters/blur-filter-page-scroll-parents.html
css3/filters/blur-filter-page-scroll-self.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
- rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::hasAncestorWithFilterOutsets):
- rendering/RenderLayer.h:
(RenderLayer):
LayoutTests:
Added two new tests to check that we disable fast path scrolling for fixed positioned
elements that have blur applied on them or any of the parent layers.
- css3/filters/blur-filter-page-scroll-parents.html: Added.
- css3/filters/blur-filter-page-scroll-self.html: Added.
- platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
- platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
- platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
- platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
- platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
- platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
- platform/mac/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
- platform/mac/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
- platform/qt/Skipped: Qt needs platform results.
- 12:06 PM Changeset in webkit [122129] by
-
- 3 edits2 copies in branches/chromium/1180
Merge 120862
BUG=130595
Review URL: https://chromiumcodereview.appspot.com/10764006
- 12:04 PM Changeset in webkit [122128] by
-
- 3 edits2 copies in branches/chromium/1132
Merge 120862
BUG=130595
Review URL: https://chromiumcodereview.appspot.com/10756009
- 12:04 PM Changeset in webkit [122127] by
-
- 7 edits in trunk
IndexedDB: Empty arrays shouldn't be valid key paths
https://bugs.webkit.org/show_bug.cgi?id=90798
Reviewed by Tony Chang.
Source/WebCore:
Other IDB implementations already enforce this although it is not yet in
the spec (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=17657). If an
empty array is passed as the key path arg to IDBDatabase.createObjectStore()
or IDBObjectStore.createIndex(), a SYNTAX_ERR DOMException is now thrown.
Test: storage/indexeddb/keypath-arrays.html
storage/indexeddb/keypath-basics.html
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPath::isValid): Test for empty array.
LayoutTests:
- storage/indexeddb/keypath-arrays-expected.txt:
- storage/indexeddb/keypath-basics-expected.txt:
- storage/indexeddb/resources/keypath-arrays.js:
(openSuccess.request.onsuccess):
(openSuccess):
- storage/indexeddb/resources/keypath-basics.js:
- 11:58 AM Changeset in webkit [122126] by
-
- 1 edit4 copies in branches/chromium/1180
Merge 120761
BUG=129936
Review URL: https://chromiumcodereview.appspot.com/10763003
- 11:57 AM Changeset in webkit [122125] by
-
- 1 edit4 copies in branches/chromium/1132
Merge 120761
BUG=129936
Review URL: https://chromiumcodereview.appspot.com/10765005
- 11:53 AM Changeset in webkit [122124] by
-
- 3 edits in trunk/Tools
[Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108
Patch by János Badics <János Badics> on 2012-07-09
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.expectations_files):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_expectations_files):
(QtPortTest.test_expectations_files):
- 11:52 AM Changeset in webkit [122123] by
-
- 1 edit2 copies in branches/chromium/1180
Merge 120801
BUG=129898
Review URL: https://chromiumcodereview.appspot.com/10759003
- 11:50 AM Changeset in webkit [122122] by
-
- 1 edit2 copies in branches/chromium/1132
Merge 120801
BUG=129898
Review URL: https://chromiumcodereview.appspot.com/10770002
- 11:48 AM Changeset in webkit [122121] by
-
- 1 edit in branches/chromium/1180/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp
Merge 121160
BUG=128151
Review URL: https://chromiumcodereview.appspot.com/10748005
- 11:37 AM Changeset in webkit [122120] by
-
- 4 edits in trunk/Source
[chromium] Create render surfaces on main thread only for the current frame
https://bugs.webkit.org/show_bug.cgi?id=89793
Reviewed by Adrienne Walker.
Source/WebCore:
Previously we would create render surfaces for animating layers
in the main thread since these layers might have a surface on impl,
in order to assist culling. This makes it very difficult to estimate
how much texture memory is needed for RenderSurfaces on the main
thread, in order to keep contents+surface memory below our limit.
Here we stop doing this, and create RenderSurfaces on both threads
under the same conditions, so main thread has surfaces only if the
layers in its current frame demand them. While this may reduce
paint culling within an animating subtree, this seems like an edge
case and knowing the amount of surface memory needed for the frame
is important.
Animation tests in CCLayerTreeHostCommonTest used to verify that these
layers got surfaces, so now no longer do. Creation of surfaces under
other conditions is covered by other CCLayerTreeHostCommonTests.
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp:
- 11:32 AM Changeset in webkit [122119] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after r122116.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- 11:25 AM Changeset in webkit [122118] by
-
- 2 edits in trunk/Source/WebCore
EFL build fix after r122115.
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
- 11:25 AM Changeset in webkit [122117] by
-
- 2 edits in trunk/Tools
Fixed clean builds of the All target in the DumpRenderTree project.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the
DumpRenderTree Perl Support target depends on the DumpRenderTree target.
- 11:00 AM Changeset in webkit [122116] by
-
- 16 edits2 copies3 adds in trunk/Source/WebCore
Make GC3D and E3D more maintainable for GLES platforms
https://bugs.webkit.org/show_bug.cgi?id=90567
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-09
Reviewed by Rob Buis.
This patch cleans up code for WebGL on OpenGLES platforms which use
GraphicsContext3DOpenGL* and Extensions3DOpenGL*. Although
GraphicsContext3DOpenGL was already split into GraphicsContext3DOpenGL,
GraphicsContext3DOpenGLCommon, and GraphicsContext3DOpenGLES, this patch
is an attempt to refactor this code in a way that will help BlackBerry and
other teams support WebGL on mobile platforms with as little use of
"#IF USE(OPENGL_ES_2)" in common code as possible. Also included is the
separation of Extensions3DOpenGL into Extensions3DOpenGLCommon,
Extensions3DOpenGL, and Extensions3DOpenGLES as well as the introduction
of OpenGLESShims.
This patch is created in large part by Jonathan Feldstein.
No new tests: no new behaviour.
- PlatformBlackBerry.cmake: Recognize BlackBerry as OPENGL ES, add new files to build
- Target.pri: Add new Extensions3DOpenGL* to WebGL builds
- platform/graphics/GraphicsContext3D.h: Add validateDepthStencil, make systemAllowsMultisamplingOnATICards a a member function.
(WebCore):
- platform/graphics/OpenGLESShims.h: Added.
- platform/graphics/opengl/Extensions3DOpenGL.cpp: Move code to Extensions3DOpenGLCommon where possible
(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Reflect that it is now inherits Extensions3DCommon
(WebCore::Extensions3DOpenGL::supportsExtension): Contains OpenGL specific code from supports
(WebCore):
(WebCore::Extensions3DOpenGL::getExtensions): Returns a list of extensions
- platform/graphics/opengl/Extensions3DOpenGL.h: Remove functions now in Extensions3DOpenGLCommon
(WebCore):
(Extensions3DOpenGL):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Added.
(WebCore):
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::supports):
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
(WebCore::Extensions3DOpenGLCommon::isEnabled):
(WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Existed before, but did nothing. Now does what is says it does.
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions): Moved from Extensions3DOpenGL::supports
- platform/graphics/opengl/Extensions3DOpenGLCommon.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.
(WebCore):
(Extensions3DOpenGLCommon):
- platform/graphics/opengl/Extensions3DOpenGLES.cpp: Added.
(WebCore):
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::~Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::Extensions3DOpenGLES::createVertexArrayOES):
(WebCore::Extensions3DOpenGLES::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGLES::isVertexArrayOES):
(WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
(WebCore::Extensions3DOpenGLES::supportsExtension): Contains OpenGLES specific code from supports
(WebCore::Extensions3DOpenGLES::getExtensions):
- platform/graphics/opengl/Extensions3DOpenGLES.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.
(WebCore):
(Extensions3DOpenGLES):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
(WebCore::GraphicsContext3D::getExtensions):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::isTexture):
(WebCore):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::deleteBuffer):
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
- 10:40 AM Changeset in webkit [122115] by
-
- 48 edits in trunk/Source
Make HTMLCollection RefCounted
https://bugs.webkit.org/show_bug.cgi?id=90414
Reviewed by Sam Weinig.
Source/WebCore:
Make HTMLCollection ref counted and stop forwarding ref and deref to its owner (m_base)
so as to align its life time management to that of DynamicNodeList.
After this patch, each HTMLCollection is owned by JSC/V8 and m_cachedCollections in ElementRareData
and m_collection in Document merely hold raw pointers for the caching purpose. These raw pointers
are cleared when each HTMLCollection is destructed via corresponding removeCachedHTMLCollection's.
In the destructor of HTMLCollection, we use the CollectionType to decide whether base() is an element
or an document, and call the appropriate removeCachedHTMLCollection except for WindowNamedItems and
DocumentNamedItems. For those two types, we need to know the atomic string name associated with
the collection just like many DynamicNodeList to remove the cache, so we let HTMLNameCollection
directly call removeWindowNamedItemCache and removeDocumentNamedItemCache. We'll cleanup this mess in
a follow up patch using a nice class hierarchy and virtual destructors.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore):
(WebCore::Document::cachedCollection):
(WebCore::Document::removeCachedHTMLCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::removeWindowNamedItemCache):
(WebCore::Document::removeDocumentNamedItemCache):
- dom/Document.h:
(Document):
- dom/Element.cpp:
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore::Element::removeCachedHTMLCollection):
(WebCore):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):
- html/CollectionType.h:
(WebCore): Since WindowNamedItems is not a part of UnnamedDocumentCachedType, we shouldn't addd 1.
(WebCore::isUnnamedDocumentCachedType):
(WebCore::isNodeCollectionType):
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
- html/HTMLAllCollection.h:
(HTMLAllCollection):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::itemAfter):
- html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):
(WebCore::HTMLCollection::base):
- html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h:
(HTMLDataListElement):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
(WebCore::HTMLElement::properties):
- html/HTMLElement.h:
(HTMLElement):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
- html/HTMLFieldSetElement.h:
(HTMLFieldSetElement):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::create):
- html/HTMLFormCollection.h:
(HTMLFormCollection):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
- html/HTMLFormElement.h:
(HTMLFormElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):
- html/HTMLMapElement.h:
(HTMLMapElement):
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore):
- html/HTMLNameCollection.h:
(WebCore::HTMLNameCollection::create):
(HTMLNameCollection):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
- html/HTMLOptionsCollection.h:
(HTMLOptionsCollection):
- html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
- html/HTMLSelectElement.h:
(HTMLSelectElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):
- html/HTMLTableRowElement.h:
(HTMLTableRowElement):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::create):
- html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):
- html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
Source/WebKit/chromium:
- src/WebPageSerializer.cpp:
(WebCore::retrieveResourcesForFrame):
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::collectTargetFrames):
Source/WebKit/win:
- DOMHTMLClasses.cpp:
(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):
- 10:30 AM Changeset in webkit [122114] by
-
- 9 edits in trunk
Web Inspector: unindent line ending block upon { hit.
https://bugs.webkit.org/show_bug.cgi?id=90795
Reviewed by Vsevolod Vlasov.
Added block-start / block-end markup into the highlighter.
- inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
- inspector/front-end/SourceCSSTokenizer.re2js:
- inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._unindentAfterBlock):
- 10:24 AM Changeset in webkit [122113] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add a setting to enable/disable page cache to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90773
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_page_cache):
(webkit_settings_set_enable_page_cache):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
- 9:39 AM Changeset in webkit [122112] by
-
- 50 edits32 adds in trunk
[Gtk] Unskip the CSS Regions layout tests
https://bugs.webkit.org/show_bug.cgi?id=90771
Reviewed by Martin Robinson.
Source/WebKit/gtk:
Add a method to DumpRenderTreeSupportGtk for enabling or disabling
CSS Regions from DumpRenderTree.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Tools:
Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
calling it when resetting the defaults in DumpRenderTree or when the
settings value is overriden through the testRunner.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference):
LayoutTests:
Unskip CSS Regions tests, updating baselines for the affected tests.
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
- platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
- platform/gtk/fast/regions/flow-content-basic-expected.png: Added.
- platform/gtk/fast/regions/flow-content-basic-expected.txt:
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Added.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt:
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt:
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt:
- platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Added.
- platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt:
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
- platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
- platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
- platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
- platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
- platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
- platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
- platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
- platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
- platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
- platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
- platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt:
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
- platform/gtk/fast/regions/region-style-block-background-color-expected.png: Added.
- platform/gtk/fast/regions/region-style-block-background-color-expected.txt:
- platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Added.
- platform/gtk/fast/regions/region-style-block-background-color2-expected.txt:
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Added.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
- platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/gtk/fast/repaint/region-painting-invalidation-expected.png:
- platform/gtk/fast/repaint/region-painting-invalidation-expected.txt:
- platform/gtk/fast/repaint/region-painting-via-layout-expected.png:
- platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
- 9:32 AM Changeset in webkit [122111] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Memory leak in webkitwebnavigationaction.cpp
https://bugs.webkit.org/show_bug.cgi?id=90787
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Martin Robinson.
Fixed a memory leak in WebKitWebNavigationAction.
- webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_finalize): Free the g_strdup()'d string.
- 8:39 AM Changeset in webkit [122110] by
-
- 31 edits3 deletes in trunk
Unreviewed, rolling out r122107.
http://trac.webkit.org/changeset/122107
https://bugs.webkit.org/show_bug.cgi?id=90794
Build failure on Mac debug bots (Requested by falken_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- dom/ContextFeatures.cpp:
- dom/ContextFeatures.h:
- html/HTMLDialogElement.cpp: Removed.
- html/HTMLDialogElement.h: Removed.
- html/HTMLDialogElement.idl: Removed.
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 8:35 AM Changeset in webkit [122109] by
-
- 5 edits12 moves in trunk
[CSSRegions] Rename NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent
https://bugs.webkit.org/show_bug.cgi?id=90759
Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.
Source/WebCore:
Renamed NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent as per CSS Regions spec:
http://www.w3.org/TR/css3-regions/#dom-named-flow
Tests: fast/regions/get-regions-by-content-horiz-bt.html
fast/regions/get-regions-by-content-horiz-tb.html
fast/regions/get-regions-by-content-vert-lr.html
fast/regions/get-regions-by-content-vert-rl.html
fast/regions/get-regions-by-content.html
fast/regions/get-regions-by-content2.html
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
- dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
LayoutTests:
Renamed test files and functions from 77746: [CSSRegions]Implement NamedFlow::getRegionsByContentNode
- fast/regions/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-expected.txt.
- fast/regions/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr-expected.txt.
- fast/regions/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt.html.
- fast/regions/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb-expected.txt.
- fast/regions/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb.html.
- fast/regions/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl-expected.txt.
- fast/regions/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr.html.
- fast/regions/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt-expected.txt.
- fast/regions/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl.html.
- fast/regions/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node.html.
- fast/regions/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2-expected.txt.
- fast/regions/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2.html.
- 8:11 AM Changeset in webkit [122108] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix inspector detach when inspector was attached by the client
https://bugs.webkit.org/show_bug.cgi?id=90763
Reviewed by Martin Robinson.
When the inspector is detached, we are unconditionally removing it
from the inspected view, but if the inspector was attached by the
client, the parent might be another widget.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from its parent widget.
- 7:49 AM FeatureFlags edited by
- Add DIALOG_ELEMENT (diff)
- 7:42 AM Changeset in webkit [122107] by
-
- 31 edits3 adds in trunk
Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521
Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.
No new tests, as there is no behavior change.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):
- dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):
- dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
- html/HTMLDialogElement.cpp: Added.
(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):
- html/HTMLDialogElement.h: Added.
(WebCore):
(HTMLDialogElement):
- html/HTMLDialogElement.idl: Added.
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 6:45 AM Changeset in webkit [122106] by
-
- 5 edits in trunk
Web Inspector: inspector does not reflect newly created text nodes from contenteditable
https://bugs.webkit.org/show_bug.cgi?id=90779
Reviewed by Vsevolod Vlasov.
Source/WebCore:
We need to report first text node as inserted, otherwise we fail to report character data modified on it.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::characterDataModified):
LayoutTests:
- inspector/elements/insert-node-expected.txt:
- inspector/elements/insert-node.html:
- 6:36 AM Changeset in webkit [122105] by
-
- 4 edits in trunk
REGRESSION(r121980) Layout Test inspector/timeline/timeline-frames.html started to crash.
https://bugs.webkit.org/show_bug.cgi?id=90747
Reviewed by Pavel Feldman.
Source/WebCore:
- consider didCancelFrame() call normal if there is no pending frame, remove assertion;
- always set empty data object for frame records;
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
LayoutTests:
- remove CRASH expectations for timeline-frames.html
- platform/chromium/TestExpectations:
- 5:33 AM Changeset in webkit [122104] by
-
- 7 edits1 add in trunk/Source/WebCore
Web Inspector: Add FileContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=90529
Adding FileContentView to Inspector.
This class provides preview of text files in FileSystem.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileContentView.js: Added.
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.prototype.get visibleView):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 5:28 AM Changeset in webkit [122103] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
https://bugs.webkit.org/show_bug.cgi?id=90769
Reviewed by Gustavo Noronha Silva.
It's currently set to false, because there were no API to know
whether cookies were persistent or not. Now that we bumped libsoup
requirements, we can use soup_cookie_jar_is_persistent().
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
- 4:36 AM Changeset in webkit [122102] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Simplify runTest function by defining default arguments.
https://bugs.webkit.org/show_bug.cgi?id=90525
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-07-09
Reviewed by Chang Shu.
Default arguments will simplify macro RUN_TEST.
Function will only have one mandatory argument, callback test function.
Added static modifiers to callback functions.
- tests/UnitTestUtils/EWKTestBase.h:
(EWKTestBase):
- tests/test_ewk_view.cpp:
(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):
- 3:52 AM Changeset in webkit [122101] by
-
- 10 edits in trunk
Web Inspector: Add text file support for FileSystemAgent::requestFileContent
https://bugs.webkit.org/show_bug.cgi?id=90439
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileContent):
- inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager.prototype._fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):
LayoutTests:
- http/tests/inspector/filesystem/read-directory-expected.txt:
- http/tests/inspector/filesystem/read-file-expected.txt:
- http/tests/inspector/filesystem/read-file.html:
- 2:33 AM Changeset in webkit [122100] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Mac build when codesign_allocate is not installed at /usr/bin.
- PluginProcess/mac/add-entitlements.sh: Let codesign(1) know where the codesign_allocate
tool is by setting the CODESIGN_ALLOCATE environment variable to its path as obtained with
xcrun.
- 1:53 AM Changeset in webkit [122099] by
-
- 6 edits in trunk/Source
[Chromium] ContextFeaturesClient::isEnabled is slow
https://bugs.webkit.org/show_bug.cgi?id=90367
Reviewed by Kent Tamura.
Source/WebCore:
- dom/ContextFeatures.h:
(WebCore::ContextFeaturesClient::urlDidChange): Added.
(WebCore::ContextFeatures::urlDidChange): Added.
(WebCore):
- dom/Document.cpp:
(WebCore::Document::setURL): Added an urlDidChange() call.
Source/WebKit/chromium:
ContextFeaturesClientImpl::isEnabled touches a heavy part in chrome
where locks are acquired for each invocation.
This change introduces a set of caches to avoid such slow calls.
The cache class ContextFeaturesCache is implemented as a
Supplement of ScriptExecutionContext because the flag bits
depend on the domain of each Document.
- src/ContextFeaturesClientImpl.cpp:
(ContextFeaturesCache): Added.
(Entry): Added.
(WebKit::ContextFeaturesCache::Entry::Entry):
(WebKit::ContextFeaturesCache::Entry::isEnabled):
(WebKit::ContextFeaturesCache::Entry::set):
(WebKit::ContextFeaturesCache::Entry::needsRefresh):
(WebKit::ContextFeaturesCache::entryFor):
(WebKit):
(WebKit::ContextFeaturesCache::supplementName):
(WebKit::ContextFeaturesCache::from):
(WebKit::ContextFeaturesCache::refreshAgainst):
(WebKit::ContextFeaturesClientImpl::isEnabled):
(WebKit::ContextFeaturesClientImpl::urlDidChange): Added to invoke refrshAgainst.
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):
- src/ContextFeaturesClientImpl.h:
(ContextFeaturesClientImpl):
- 1:36 AM Changeset in webkit [122098] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed chromium inspector test fix.
- src/js/Tests.js:
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
- 1:14 AM Changeset in webkit [122097] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unskipping CSS Exclusions tests for the Gtk port.
The feature is already enabled for this port and all the tests pass.
- platform/gtk/TestExpectations:
- 1:08 AM Changeset in webkit [122096] by
-
- 5 edits2 adds in trunk
[CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
https://bugs.webkit.org/show_bug.cgi?id=90608
Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.
Source/WebCore:
Implemented NamedFlow::firstEmptyRegionIndex as per spec: http://www.w3.org/TR/css3-regions/#dom-named-flow
Test: fast/regions/webkit-named-flow-first-empty-region-index.html
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore):
- dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
LayoutTests:
Added tests for NamedFlow::firstEmptyRegionIndex.
- fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
- fast/regions/webkit-named-flow-first-empty-region-index.html: Added.
- 12:07 AM Changeset in webkit [122095] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip the failing test.
- platform/qt/Skipped:
Jul 8, 2012:
- 11:55 PM Changeset in webkit [122094] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marking a storage/indexeddb/mozilla/key-requirements.html as flaky on WebKit Win.
- platform/chromium/TestExpectations:
- 11:43 PM Changeset in webkit [122093] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip the new failing test.
- platform/qt/Skipped:
- 11:36 PM Changeset in webkit [122092] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed, checking in platform results.
- platform/mac/css3/filters/effect-reference-expected.txt: Added.
- platform/mac/css3/filters/effect-reference-external-expected.txt: Added.
- platform/mac/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/mac/css3/filters/effect-reference-ordering-expected.txt: Added.
- platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
- 11:33 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:31 PM UsingGitWithWebKit edited by
- Fix "Copying file aks svn copy" secion: Change "p" to "--patch" (diff)
- 11:30 PM Changeset in webkit [122091] by
-
- 1 edit3 copies in trunk/Source/WebCore
[Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=90752
Reviewed by Kent Tamura.
This patch is preparation of introducing LocaleMac class for localize date form.
This patch copies LocaleWin and LocalizedDateWin.cpp as below:
- LocaleMac.h from LocaleWin.h
- LocaleMac.mm from LocaliedDateMac.mm
- LocaliedDateMac.cpp from LocalizedDateWin.cpp
Due by git, diffs are appeared as new thing. I'll do svn copy at landing time.
No new tests. This patch doesn't change behavior.
- platform/text/mac/LocaleMac.h: Copied from platform/text/LocaleWin.h
- platform/text/mac/LocaleMac.mm: Copied from platform/text/mac/LocalizedDateMac.mm
- platform/text/mac/LocalizedDateMac.cpp: Copied from platform/text/LocalizedDateWin.cpp
- 11:30 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:30 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:19 PM Changeset in webkit [122090] by
-
- 2 edits in trunk/Source/JavaScriptCore
gcc build fix after r121925.
- runtime/JSObject.h:
(JSC::JSFinalObject::finishCreation):
- 11:12 PM Changeset in webkit [122089] by
-
- 4 edits in trunk/Source
Introduce a build flag for low quality JPEG images
https://bugs.webkit.org/show_bug.cgi?id=90748
Reviewed by Adam Barth.
Source/WebCore:
Introduce build options for no JPEG dithering (USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING))
and no JPEG fancy upsampling (USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)).
No new tests as there is no change in functionality.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(ditherMode):
(doFancyUpsampling):
Source/WTF:
Turn on the newly introduced flags for android.
- wtf/Platform.h:
- 10:10 PM Changeset in webkit [122088] by
-
- 11 edits in trunk/LayoutTests
Check returned value in BatteryStatus APIs test cases
https://bugs.webkit.org/show_bug.cgi?id=90665
Reviewed by Adam Barth.
It is good to compare with actual values to recognize what is difference.
- batterystatus/add-listener-from-callback-expected.txt:
- batterystatus/basic-all-types-of-events-expected.txt:
- batterystatus/basic-operation-expected.txt:
- batterystatus/script-tests/add-listener-from-callback.js:
(checkBatteryStatus):
- batterystatus/script-tests/basic-all-types-of-events.js:
(checkBatteryStatus):
- batterystatus/script-tests/basic-operation.js:
- batterystatus/script-tests/updates.js:
(checkBatteryStatus):
- batterystatus/updates-expected.txt:
- 9:59 PM Changeset in webkit [122087] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r121968.
http://trac.webkit.org/changeset/121968
https://bugs.webkit.org/show_bug.cgi?id=90749
Caused a link error on chromium Win dbg. (Requested by hayato
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-08
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- platform/MemoryUsageSupport.cpp:
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
- platform/chromium/MemoryUsageSupportChromium.cpp:
- 9:56 PM Changeset in webkit [122086] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Make setForceDownload a setter method.
https://bugs.webkit.org/show_bug.cgi?id=90591
Reviewed by Rob Buis.
- platform/network/blackberry/ResourceRequest.h:
(WebCore::ResourceRequest::setForceDownload):
- 9:54 PM Changeset in webkit [122085] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed GTK gardening, remove a redundant baseline for the
http/tests/xmlhttprequest/send-array-buffer.html test,
required after r122074.
- platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.
- 9:47 PM Changeset in webkit [122084] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r122076.
http://trac.webkit.org/changeset/122076
https://bugs.webkit.org/show_bug.cgi?id=89560
Broke sheriffbot rollout
- Scripts/prepare-ChangeLog:
(generateNewChangeLogs):
- 9:38 PM Changeset in webkit [122083] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marking a inspector/timeline/timeline-frames.html as a CRASH on WebKit Linux (dbg).
- platform/chromium/TestExpectations:
- 9:36 PM Changeset in webkit [122082] by
-
- 7 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=90480
Reviewed by Kent Tamura.
Source/WebCore:
If <select> has any insertion point, the attachment phase
unpextedly creates a renderer for distributed node and added to
the renderer of the <select>, which breaks an assumption and
results the crash.
This change tighten the childShouldCreateRenderer() to forbid
child renderers even from distributed nodes.
There is an exception as always: ValidationMessage can create a
ShadowRoot to <select>, which generates usually-forbidden child
renderers. This change introduces HTMLFormControlElement::validationMessageContains()
to let these renderers in.
Test: fast/dom/shadow/insertion-point-list-menu-crash.html
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::validationMessageContains):
(WebCore):
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::contains):
(WebCore):
- html/ValidationMessage.h:
(WebCore):
(ValidationMessage):
LayoutTests:
- fast/dom/shadow/insertion-point-list-menu-crash-expected.txt: Added.
- fast/dom/shadow/insertion-point-list-menu-crash.html: Added.
- 9:30 PM Changeset in webkit [122081] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary member HTMLTreeBuilder::m_lastScriptElementStartPosition
https://bugs.webkit.org/show_bug.cgi?id=90726
Reviewed by Adam Barth.
HTMLTreeBuilder::m_lastScriptElementStartPosition is of no use. Currently,
m_lastScriptElementStartPosition is used to store the text position in
"script" start tag, and then the stored position is passed to m_scriptToProcessStartPosition
later in "script" end tag. Because HTMLTreeBuilder handles one script tag at
a time, we can store the text position directly to m_scriptToProcessStartPosition
in "script" start tag.
No behavior change, so no new tests.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
- 9:15 PM Changeset in webkit [122080] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marking a fast/multicol/column-span-parent-continuation-crash.html as a flaky.
- platform/chromium/TestExpectations:
- 8:57 PM Changeset in webkit [122079] by
-
- 7 edits in trunk/Source/WebCore
Refactor RenderSVGShape to not contain fallback code
https://bugs.webkit.org/show_bug.cgi?id=90514
Reviewed by Nikolas Zimmermann.
The interaction between RenderSVGShape and {RenderSVGEllipse, RenderSVGRect}
was too coupled and it was not clear when a path existed or who controlled
falling back to path codepaths in RenderSVGShape.
This patch cleans up RenderSVGShape so that it does not track fallback state
and does not have special handling for creating a shape in strokeContains. Because
some functions of RenderSVGShape can be called without a path existing, each
of these functions has switched to using the path() function which asserts that
a path exists.
There is only one remaining use of hasPath() in RenderSVGShape which I plan
to remove in a followup patch.
This patch also cleans up RenderSVGRect and RenderSVGEllipse. These classes
now handle fallback tracking themselves and choose when to use their optimized
strokeContains codepaths.
No new tests as this is just a refactoring.
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::createShape):
(WebCore::RenderSVGEllipse::objectBoundingBox):
(WebCore::RenderSVGEllipse::strokeBoundingBox):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains):
- rendering/svg/RenderSVGEllipse.h:
(WebCore::RenderSVGEllipse::isEmpty):
(RenderSVGEllipse):
- rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):
- rendering/svg/RenderSVGRect.h:
(WebCore::RenderSVGRect::isEmpty):
(RenderSVGRect):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
(WebCore::RenderSVGShape::shapeDependentFillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::hasSmoothStroke):
(WebCore):
- rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
- 8:51 PM Changeset in webkit [122078] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90735
Patch by Christophe Dumez <Christophe Dumez> on 2012-07-08
Reviewed by Antonio Gomes.
Keep a reference to the Element passed to enterFullScreenForElement() so
that we can reuse it later in exitFullScreenForElement(). This is needed
because the Element passed to exitFullScreenForElement() may be null.
This fixes the crash for the fullscreen/exit-full-screen-iframe.html
test introduced in r122035.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
- 8:48 PM Changeset in webkit [122077] by
-
- 5 edits in trunk
Update the description of LayoutTestController::textSurroundingElement
https://bugs.webkit.org/show_bug.cgi?id=90620
Reviewed by Adam Barth.
Tools:
Rename and fix the description of the method as its behaviour changed
during the review of https://bugs.webkit.org/show_bug.cgi?id=82461
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::textSurroundingNode):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
LayoutTests:
Rename textSurroundingElement to match is real behaviour.
- platform/chromium/editing/surrounding-text/surrounding-text.html:
- 8:38 PM Changeset in webkit [122076] by
-
- 2 edits in trunk/Tools
Improve the template generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560
Reviewed by Ryosuke Niwa.
Produce the following template:
2012-06-20 Kent Tamura <tkent@chromium.org>
Need a short description (Oops!).
Need the bug URL (Oops!).
Reviewed by Ryosuke Niwa.
Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
No new tests (Oops!).
- Scripts/prepare-ChangeLog:
(generateNewChangeLogs):
- 8:26 PM Changeset in webkit [122075] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marking a fast/events/display-none-on-focus-crash.html as a flaky.
- platform/chromium/TestExpectations:
- 8:09 PM Changeset in webkit [122074] by
-
- 9 edits2 copies in trunk
XHR.send should support ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90536
Source/WebCore:
XHR.send should support ArrayBufferView according to the latest draft
and also eventually deprecate ArrayBuffer.
Spec: http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-send
Reviewed by Kenneth Russell.
Test: http/tests/xmlhttprequest/send-array-buffer.html
http/tests/xmlhttprequest/send-data-view.html
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
- xml/XMLHttpRequest.cpp:
(WebCore):
(WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
(XMLHttpRequest):
- xml/XMLHttpRequest.idl:
LayoutTests:
Reviewed by Kenneth Russell.
- http/tests/xmlhttprequest/send-array-buffer-expected.txt:
- http/tests/xmlhttprequest/send-array-buffer.html:
- http/tests/xmlhttprequest/send-data-view-expected.txt: Added.
- http/tests/xmlhttprequest/send-data-view.html: Added.
- 7:42 PM Changeset in webkit [122073] by
-
- 2 edits in trunk/Source/WebKit
[EFL] Change notifications directory path of WebKit_INCLUDE_DIRECTORIES in the PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=90650
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-08
Reviewed by Laszlo Gombos.
Change directory path for including notifications of WebCore
from WebCore/notifications to WebCore/Modules/notifications
- PlatformEfl.cmake:
- 7:42 PM Changeset in webkit [122072] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Fix a wrong entry in r122070.
- platform/chromium/TestExpectations: Replace dont-commit-on-blocked.html with cursor-delete.html.
- 7:29 PM Changeset in webkit [122071] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Fix a wrong entry in r122064.
- platform/chromium/TestExpectations:
- 7:22 PM Changeset in webkit [122070] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. marking a storage/indexeddb/cursor-delete.html as a flaky crasher after r121629.
- platform/chromium/TestExpectations:
- 6:52 PM Changeset in webkit [122069] by
-
- 114 edits7 copies18 adds25 deletes in trunk/LayoutTests
Unreviewed gardening.
Rebaseline after r121917.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
- platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Removed.
- platform/chromium-linux-x86/editing/selection/3690703-expected.png: Removed.
- platform/chromium-linux-x86/editing/selection/3690719-expected.png: Removed.
- platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
- platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt.
- platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
- platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.png:
- platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
- platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
- platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac/css1/formatting_model/floating_elements-expected.txt:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
- platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
- platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
- platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
- platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/chromium-mac/editing/deleting/5144139-2-expected.txt: Added.
- platform/chromium-mac/editing/selection/3690703-2-expected.png:
- platform/chromium-mac/editing/selection/3690703-2-expected.txt:
- platform/chromium-mac/editing/selection/3690703-expected.png:
- platform/chromium-mac/editing/selection/3690703-expected.txt:
- platform/chromium-mac/editing/selection/3690719-expected.png:
- platform/chromium-mac/editing/selection/3690719-expected.txt:
- platform/chromium-mac/editing/selection/4397952-expected.png:
- platform/chromium-mac/editing/selection/4397952-expected.txt:
- platform/chromium-mac/editing/selection/selection-button-text-expected.png:
- platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
- platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
- platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png:
- platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.txt: Added.
- platform/chromium-mac/fast/css/continuationCrash-expected.png:
- platform/chromium-mac/fast/css/continuationCrash-expected.txt:
- platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/chromium-mac/fast/css/rtl-ordering-expected.png:
- platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
- platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/chromium-mac/fast/forms/001-expected.png:
- platform/chromium-mac/fast/forms/001-expected.txt:
- platform/chromium-mac/fast/forms/basic-buttons-expected.png:
- platform/chromium-mac/fast/forms/blankbuttons-expected.png:
- platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
- platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
- platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png:
- platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.txt: Added.
- platform/chromium-mac/fast/forms/button-generated-content-expected.png:
- platform/chromium-mac/fast/forms/button-generated-content-expected.txt: Added.
- platform/chromium-mac/fast/forms/button-positioned-expected.png:
- platform/chromium-mac/fast/forms/button-positioned-expected.txt:
- platform/chromium-mac/fast/forms/button-sizes-expected.png:
- platform/chromium-mac/fast/forms/button-sizes-expected.txt:
- platform/chromium-mac/fast/forms/button-style-color-expected.png:
- platform/chromium-mac/fast/forms/button-style-color-expected.txt:
- platform/chromium-mac/fast/forms/button-table-styles-expected.png:
- platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
- platform/chromium-mac/fast/forms/button-text-transform-expected.png:
- platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
- platform/chromium-mac/fast/forms/button-white-space-expected.png:
- platform/chromium-mac/fast/forms/button-white-space-expected.txt: Added.
- platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
- platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
- platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
- platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
- platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
- platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
- platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- 6:47 PM Changeset in webkit [122068] by
-
- 2 edits in trunk/Tools
[wx] Unreviewed. Fix notificaitons directory path after notifications move.
- waf/build/settings.py:
- 6:41 PM Changeset in webkit [122067] by
-
- 157 edits2 copies10 adds2 deletes in trunk/LayoutTests
Unreviewed gardening.
Rebaseline after r121917.
- platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
- platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
- platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
- platform/chromium-mac-snowleopard/fast/selectors/064-expected.png:
- platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
- platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.png:
- platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.png:
- platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
- platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
- platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png:
- platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
- platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Removed.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
- platform/chromium-mac/fast/forms/formmove3-expected.png:
- platform/chromium-mac/fast/forms/formmove3-expected.txt:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
- platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
- platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
- platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
- platform/chromium-mac/fast/forms/input-first-letter-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/select-baseline-expected.png:
- platform/chromium-mac/fast/forms/select-baseline-expected.txt: Added.
- platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
- platform/chromium-mac/fast/html/details-replace-text-expected.png:
- platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
- platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
- platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
- platform/chromium-mac/fast/selectors/064-expected.png:
- platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
- platform/chromium-mac/fast/table/append-cells2-expected.png:
- platform/chromium-mac/fast/table/append-cells2-expected.txt: Added.
- platform/chromium-mac/fast/table/remove-td-display-none-expected.png:
- platform/chromium-mac/fast/table/remove-td-display-none-expected.txt: Added.
- platform/chromium-mac/fast/table/rowindex-expected.png:
- platform/chromium-mac/fast/table/rowindex-expected.txt: Added.
- platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
- platform/chromium-mac/fast/text/international/bidi-override-expected.png:
- platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Added.
- platform/chromium-mac/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-mac/fast/text/international/hindi-spacing-expected.txt: Added.
- platform/chromium-mac/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
- platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
- platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png:
- platform/chromium-mac/fullscreen/full-screen-remove-ancestor-after-expected.png:
- platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- 6:26 PM Changeset in webkit [122066] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Rebaseline after r121917.
- platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
- 6:20 PM Changeset in webkit [122065] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=90722
https://bugs.webkit.org/show_bug.cgi?id=90742
Unreviewed, skip crashing tests.
- platform/mac/Skipped:
- 6:11 PM Changeset in webkit [122064] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=90741
fast/text-autosizing/simple-paragraph.html (reftest) started to fail after r121907.
- platform/chromium/TestExpectations: Add IMAGE on Mac.
- 5:38 PM Changeset in webkit [122063] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Add TIMEOUT for inspector/timeline/timeline-network-received-data.html.
- platform/chromium/TestExpectations:
- 5:26 PM Changeset in webkit [122062] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Add TIMEOUT for inspector/debugger/live-edit.html.
- platform/chromium/TestExpectations:
- 4:33 PM Changeset in webkit [122061] by
-
- 2 edits in trunk/LayoutTests
inspector/profiler/heap-snapshot-comparison-*.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=90722
Unreviewed, skipping another crashing inspector/profiler test and consolidating
the bugs for those tests.
- platform/mac/Skipped:
- 3:00 AM Changeset in webkit [122060] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Qt][ARM] Implementing missing macro assembler instructions after r121925
https://bugs.webkit.org/show_bug.cgi?id=90657
Reviewed by Csaba Osztrogonác.
Implementing convertibleLoadPtr, replaceWithLoad and
replaceWithAddressComputation.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::replaceWithLoad):
(ARMAssembler):
(JSC::ARMAssembler::replaceWithAddressComputation):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::convertibleLoadPtr):
(MacroAssemblerARM):
- 2:04 AM Changeset in webkit [122059] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
https://bugs.webkit.org/show_bug.cgi?id=90697
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-08
Reviewed by Vsevolod Vlasov.
Fix to remove the statements with no effect. The check for errors is added only when some valid
statements exist.
No new tests as generator related patch.
- inspector/CodeGeneratorInspector.py:
(Generator.process_command):
