⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 15, 2012:

11:50 PM Changeset in webkit [122699] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new failing test.

  • platform/qt/Skipped:
11:44 PM Changeset in webkit [122698] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark a few media tests as flaky on RELEASE bot as well
​https://bugs.webkit.org/show_bug.cgi?id=91361

Unreviewed EFL gardening. Mark a few media test as flaky on
the RELEASE bot as well.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
11:25 PM Changeset in webkit [122697] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[EFL][WK2] Define destructors for Ewk structures
​https://bugs.webkit.org/show_bug.cgi?id=91338

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
Reviewed by Kentaro Hara.

Add destructors to Ewk structures and move
memory freeing code from *_free() or *_unref()
functions to the destructors.

  • UIProcess/API/efl/ewk_intent.cpp:

(_Ewk_Intent::_Ewk_Intent):
(_Ewk_Intent):
(_Ewk_Intent::~_Ewk_Intent):
(ewk_intent_unref):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(_Ewk_Intent_Service):
(_Ewk_Intent_Service::~_Ewk_Intent_Service):
(ewk_intent_service_unref):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):

  • UIProcess/API/efl/ewk_url_request.cpp:

(_Ewk_Url_Request):
(_Ewk_Url_Request::~_Ewk_Url_Request):
(ewk_url_request_unref):

  • UIProcess/API/efl/ewk_url_response.cpp:

(_Ewk_Url_Response):
(_Ewk_Url_Response::~_Ewk_Url_Response):
(ewk_url_response_unref):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_del):

  • UIProcess/API/efl/ewk_web_error.cpp:

(_Ewk_Web_Error):
(_Ewk_Web_Error::~_Ewk_Web_Error):
(ewk_web_error_free):

  • UIProcess/API/efl/ewk_web_resource.cpp:

(_Ewk_Web_Resource):
(_Ewk_Web_Resource::~_Ewk_Web_Resource):
(ewk_web_resource_unref):

11:22 PM Changeset in webkit [122696] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip css3/flexbox/flexbox-overflow-auto.html
​https://bugs.webkit.org/show_bug.cgi?id=91360

Unreviewed EFL gardening. Skip css3/flexbox/flexbox-overflow-auto.html
which started failing after r122681.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
11:15 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:07 PM Changeset in webkit [122695] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Disable perf tests for DEBUG builds
​https://bugs.webkit.org/show_bug.cgi?id=91358

Unreviewed EFL gardening. Disable performance tests
in DEBUG builds since they are really slow and there
are very few benefits in running them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
10:32 PM EFLWebKitCodingStyle edited by eunmi15.lee@samsung.com
Add "Use "void" for empty parameter of public APIs" (diff)
10:26 PM Changeset in webkit [122694] by mikelawther@chromium.org
  • 8 edits
    2 adds in trunk

Fix calculation of rgba's alpha in CSS custom text
​https://bugs.webkit.org/show_bug.cgi?id=91355

Reviewed by Ryosuke Niwa.

Source/WebCore:

Alpha values are stored as an 8 bit value. To convert this to a float in the
range [0,1], we need to divide by 255, not 256.

Test: fast/css/rgba-custom-text.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::customCssText):

LayoutTests:

  • css3/calc/color-hsl-expected.txt:
  • css3/calc/color-rgb-expected.txt:
  • editing/execCommand/query-command-value-background-color-expected.txt:
  • editing/execCommand/query-command-value-background-color.html:
  • fast/css/rgba-custom-text-expected.txt: Added.
  • fast/css/rgba-custom-text.html: Added.
  • media/track/track-cue-rendering-expected.txt:
8:22 PM Changeset in webkit [122693] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add a API for getting security origin string
​https://bugs.webkit.org/show_bug.cgi?id=90936

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-07-15
Reviewed by Ryosuke Niwa.

Support to change from Ewk_Security_Origin to string on the API level.
Add ewk_security_origin_string_get for getting security origin string.

  • ewk/ewk_security_origin.cpp:

(_Ewk_Security_Origin):
(ewk_security_origin_string_get):
(ewk_security_origin_free):
(ewk_security_origin_new):

  • ewk/ewk_security_origin.h:
7:53 PM Changeset in webkit [122692] by jason.liu@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] We shouldn't call didFinishLoading for the old request when a new request has been sent by notifyAuthReceived.
​https://bugs.webkit.org/show_bug.cgi?id=90962

Reviewed by Rob Buis.

We start a new NetworkJob with credentials after receiving 401/407 status.
We should not release resources in webcore when the old job is closed because
they are needed by the new one.
We should do as 3XX.

No new tests. No change in behaviour.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::shouldReleaseClientResource):
(WebCore::NetworkJob::handleRedirect):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

7:29 PM Changeset in webkit [122691] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move icon database to application data directory.
​https://bugs.webkit.org/show_bug.cgi?id=91195

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-15
Reviewed by Rob Buis.

RIM PR: 156852
Create icon database in application data directory instead of
database or local storage directory, by doing this we can make
things easier when clearing database or local storage data files.

Internally reviewed by Charles Wei <​charles.wei@torchmobile.com.cn>

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

7:27 PM Changeset in webkit [122690] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Several media tests are flaky in DEBUG mode
​https://bugs.webkit.org/show_bug.cgi?id=91347

Unreviewed EFL gardening. Add to TestExpectations a
few media tests which are flaky in DEBUG mode only.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
7:26 PM Changeset in webkit [122689] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r122660): Cannot iterate over HTMLCollection that contains non-child descendent nodes in some conditions
​https://bugs.webkit.org/show_bug.cgi?id=91334

Reviewed by Ojan Vafai.

Source/WebCore:

The bug was caused by using lastChild() as the starting node for traversePreviousNode. Since it's the inverse of
Node::traverseNextNode(), which visits nodes in pre order, we must start our search from the last descendent node,
which is visited traverseNextNode immediately before reaching the root node.

Test: fast/dom/htmlcollection-backwards-subtree-iteration.html

  • html/HTMLCollection.cpp:

(WebCore::lastDescendent):
(WebCore):
(WebCore::itemBeforeOrAfter):

LayoutTests:

Add a regression test. Without this patch, it results in an console error in release builds and an assertion failure
in debug builds.

  • fast/dom/htmlcollection-backwards-subtree-iteration-expected.txt: Added.
  • fast/dom/htmlcollection-backwards-subtree-iteration.html: Added.
7:25 PM Changeset in webkit [122688] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebKit

[EFL] Move files guarded by #ifdef to existing file list.
​https://bugs.webkit.org/show_bug.cgi?id=91336

Reviewed by Ryosuke Niwa.

Some EFL files are already guared by #ifdef. So, cmake files doesn't need to guard
them again. In addition, some files are missing #ifdef guard its header files.

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit/efl:

  • WebCoreSupport/DeviceMotionClientEfl.h:
  • WebCoreSupport/InspectorClientEfl.h:
  • WebCoreSupport/NetworkInfoClientEfl.h:
  • WebCoreSupport/VibrationClientEfl.h:
6:41 PM Changeset in webkit [122687] by rniwa@webkit.org
  • 381 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in fast/js, layers, leaks, line-grid, lists, loader, loading, media, mediastream, multicol, and mutation tests
​https://bugs.webkit.org/show_bug.cgi?id=91315

Reviewed by Adam Barth.

  • fast/js/:
  • fast/layers/add-layer-with-nested-stacking.html:
  • fast/layers/assert-RenderLayer-update-positions.html:
  • fast/layers/clip-rects-assertion.html:
  • fast/layers/clip-rects-transformed-2.html:
  • fast/layers/clip-rects-transformed.html:
  • fast/layers/generated-layer-scrollbar-crash.html:
  • fast/layers/inline-dirty-z-order-lists.html:
  • fast/layers/layer-content-visibility-change.html:
  • fast/layers/layer-visibility.html:
  • fast/layers/nested-layers-1.html:
  • fast/layers/nested-layers-2.html:
  • fast/layers/nested-layers-3.html:
  • fast/layers/nested-layers-4.html:
  • fast/layers/remove-layer-with-nested-stacking.html:
  • fast/layers/remove-only-this-layer-update.html:
  • fast/layers/removed-by-scroll-handler.html:
  • fast/layers/resize-layer-deletion-crash.html:
  • fast/layers/scroll-with-transform-composited-layer.html:
  • fast/layers/scroll-with-transform-layer.html:
  • fast/layers/scrollByLines-overflow-no-layer.html:
  • fast/layers/visible-layer-with-hidden-parent.html:
  • fast/layers/zindex-hit-test.html:
  • fast/leaks/001.html:
  • fast/leaks/002.html:
  • fast/leaks/003.html-disabled:
  • fast/line-grid/line-grid-nested.html:
  • fast/lists/alpha-boundary-values.html:
  • fast/lists/alpha-list-wrap.html:
  • fast/lists/calc-width-with-space.html:
  • fast/lists/decimal-leading-zero.html:
  • fast/lists/drag-into-marker.html:
  • fast/lists/item-not-in-list-line-wrapping.html:
  • fast/lists/li-values.html:
  • fast/lists/list-style-type-dynamic-change.html:
  • fast/lists/ol-nested-items-dynamic-insert.html:
  • fast/lists/ol-nested-items-dynamic-remove.html:
  • fast/lists/ol-nested-items.html:
  • fast/lists/ol-nested-list-dynamic-insert.html:
  • fast/lists/ol-nested-list-dynamic-remove.html:
  • fast/lists/ol-nested-list.html:
  • fast/lists/ol-reversed-dynamic-simple.html:
  • fast/lists/ol-reversed-dynamic.html:
  • fast/lists/ol-reversed-nested-items.html:
  • fast/lists/ol-reversed-nested-list.html:
  • fast/lists/ol-reversed-simple.html:
  • fast/lists/ol-reversed-simple.xhtml:
  • fast/lists/ol-start-roman.html:
  • fast/lists/parent-box-not-box-crash.html:
  • fast/lists/positioned-count-crash.html:
  • fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html:
  • fast/lists/resources/dump-list.js:

(dumpListItemAsHTML):
(testListItemMarkerEqualsListItemText):

  • fast/lists/w3-css3-list-styles-alphabetic.html:
  • fast/lists/w3-css3-list-styles-fallback-style.html:
  • fast/lists/w3-css3-list-styles-numeric.html:
  • fast/lists/w3-css3-list-styles-symbolic.html:
  • fast/lists/w3-css3-lower-armenian.html:
  • fast/lists/w3-css3-upper-armenian.html:
  • fast/lists/w3-list-styles.html:
  • fast/loader/:
  • fast/media/color-does-not-include-alpha.html:
  • fast/media/invalid-lengths.html:
  • fast/media/lifetime.html:
  • fast/media/matchmedium-query-api.html:
  • fast/media/media-query-list-01.html:
  • fast/media/media-query-list-02.html:
  • fast/media/media-query-list-03.html:
  • fast/media/media-query-list-04.html:
  • fast/media/media-query-list-05.html:
  • fast/media/media-query-list-06.html:
  • fast/media/media-query-list-07.html:
  • fast/media/media-query-list-callback.html:
  • fast/media/media-svg-crash.html:
  • fast/media/mq-pointer.html:
  • fast/media/print-restores-previous-mediatype.html:
  • fast/media/update-media-query-css-parser.html:
  • fast/media/view-mode-media-feature.html:
  • fast/multicol/:
  • fast/mutation/end-of-task-delivery.html:
  • fast/mutation/inline-event-listener.html:
  • fast/mutation/mutation-callback-non-element-crash.html:
  • platform/chromium/fast/loader/create-view-target-blank.html:
  • platform/chromium/fast/loader/resources/done.html:
  • platform/gtk/fast/loader/crash-display-local-directory.html:
  • platform/mac/fast/loader/file-url-mimetypes-2.html:
  • platform/mac/fast/loader/file-url-mimetypes-3.html:
  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac/fast/loader/non-html-load-event.html:
  • platform/mac/fast/loader/webarchive-encoding-respected.html:
  • platform/qt/fast/loader/user-stylesheet-qrc-path.html:
6:13 PM Changeset in webkit [122686] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.

  • Scripts/webkitpy/common/config/watchlist:
5:36 PM Changeset in webkit [122685] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add ​gyuyoung.kim@samsung.com to watch list.

  • Scripts/webkitpy/common/config/watchlist:
4:01 PM Changeset in webkit [122684] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit/mac

Fix case sensitive build issue.

Unreviewed build fix.

  • WebView/WebPreferences.mm:
2:26 PM Changeset in webkit [122683] by Joseph Pecoraro
  • 4 edits
    2 adds in trunk

Windowless WebView not firing JavaScript load event if there is a media element
​https://bugs.webkit.org/show_bug.cgi?id=91331

Reviewed by Eric Carlson.

Source/WebCore:

In prepareForLoad we start deferring the load event. If we fall into this
clause where the page can not start loading media we bail, potentially
indefinitely waiting until we can start loading media. Since we can not
be certain this will ever happen, we should stop deferring the page's
load event.

Test: WebKit1.WindowlessWebViewWithMedia TestWebKitAPI test. The only
way this path was reachable right now is on the mac port.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

Tools:

Test a windowless WebView loading a page with a media element. The load
event should happen on the next spin of the run loop, but we spin check
the page, with a timeout of 250ms.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
  • TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.

(-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
(TestWebKitAPI::TEST):

1:24 PM Changeset in webkit [122682] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Make WebPreferencesPrivate a simple struct
​https://bugs.webkit.org/show_bug.cgi?id=91330

Reviewed by Filip Pizlo.

To avoid taking time creating a new Objective-C object for WebPreferencesPrivate, we can just make
it a simple struct.

  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm:

(WebPreferencesPrivate):
(WebPreferencesPrivate::WebPreferencesPrivate):
Replace the Objective-C WebPreferencesPrivate by a struct.
Remove IBCreatorID from the object as it is unused.
Use RetainPtr for the Objective-C attribute to avoid tracking their memory manually.

(-[WebPreferences initWithIdentifier:]):
Change the order of the initialization to avoid allocating anyting if a WebPreferences exists
for the identifier.
Both [NSObject init] and WebPreferencesPrivate allocation are moved after the fast path.

(-[WebPreferences initWithCoder:]):
(-[WebPreferences encodeWithCoder:]):
(-[WebPreferences dealloc]):
(-[WebPreferences identifier]):
(-[WebPreferences _valueForKey:]):
(-[WebPreferences _setStringValue:forKey:]):
(-[WebPreferences _setIntegerValue:forKey:]):
(-[WebPreferences _setFloatValue:forKey:]):
(-[WebPreferences _setBoolValue:forKey:]):
(-[WebPreferences _setLongLongValue:forKey:]):
(-[WebPreferences _setUnsignedLongLongValue:forKey:]):

1:15 PM Changeset in webkit [122681] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
​https://bugs.webkit.org/show_bug.cgi?id=91348

Reviewed by Anders Carlsson.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged): Added an early return if the scroll position
did not, in fact, change. This avoids the call to ScrollAnimator::notifyContentAreaScrolled,
which is what causes the scroll bars to flash.

8:40 AM Changeset in webkit [122680] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/text/descent-clip-in-scaled-page.html
​https://bugs.webkit.org/show_bug.cgi?id=91342

Unreviewed EFL gardening. Skip new test added in r122651
that fails on EFL port because our LayoutTestController
does not implement setSubpixelTextPositioning().

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
5:10 AM Changeset in webkit [122679] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip css2.1/20110323/vertical-align-boxes-001.htm
​https://bugs.webkit.org/show_bug.cgi?id=91340

Unreviewed EFL gardening. Skipping new test introduced in
r122663 which is failing on EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:

Jul 14, 2012:

10:23 PM Changeset in webkit [122678] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG PutByVal opcodes should accept more than 3 operands
​https://bugs.webkit.org/show_bug.cgi?id=91332

Reviewed by Oliver Hunt.

Turned PutByVal/PutByValAlias into var-arg nodes, so that we can give them
4 or more operands in the future.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::varArgNumChildren):
(Graph):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::varArgChild):
(JSC::DFG::Graph::child):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:02 PM Changeset in webkit [122677] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Rationalize and optimize storage allocation
​https://bugs.webkit.org/show_bug.cgi?id=91303

Reviewed by Oliver Hunt.

This implements a backwards bump allocator for copied space storage
allocation, shown in pseudo-code below:

pointer bump(size) {

pointer tmp = allocator->remaining;
tmp -= size;
if (tmp < 0)

fail;

allocator->remaining = tmp;
return allocator->payloadEnd - tmp - size;

}

The advantage of this allocator is that it:

  • Only requires one comparison in the common case where size is known to not be huge, and this comparison can be done by checking the sign bit of the subtraction.


  • Can be implemented even when only one register is available. This register is reused for both temporary storage during allocation and for the result.


  • Preserves the behavior that memory in a block is filled in from lowest address to highest address, which allows for a cheap reallocation fast path.


  • Is resilient against the block used for allocation being the last one in virtual memory, thereby otherwise leading to the risk of overflow in the bump pointer, despite only doing one branch.


In order to implement this allocator using the smallest possible chunk
of code, I refactored the copied space code so that all of the allocation
logic is in CopiedAllocator, and all of the state is in either
CopiedBlock or CopiedAllocator. This should make changing the allocation
fast path easier in the future.

In order to do this, I needed to add some new assembler support,
particularly for various forms of add(address, register) and negPtr().

This is performance neutral. The purpose of this change is to facilitate
further inlining of storage allocation without having to reserve
additional registers or emit too much code.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::addPtr):
(MacroAssembler):
(JSC::MacroAssembler::negPtr):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::add32):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(MacroAssemblerX86):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::addPtr):
(JSC::MacroAssemblerX86_64::negPtr):

  • assembler/X86Assembler.h:

(X86Assembler):
(JSC::X86Assembler::addl_mr):
(JSC::X86Assembler::addq_mr):
(JSC::X86Assembler::negq_r):

  • heap/CopiedAllocator.h:

(CopiedAllocator):
(JSC::CopiedAllocator::isValid):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::tryAllocate):
(JSC):
(JSC::CopiedAllocator::tryReallocate):
(JSC::CopiedAllocator::forceAllocate):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::setCurrentBlock):
(JSC::CopiedAllocator::currentCapacity):

  • heap/CopiedBlock.h:

(CopiedBlock):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payloadEnd):
(JSC):
(JSC::CopiedBlock::payloadCapacity):
(JSC::CopiedBlock::data):
(JSC::CopiedBlock::dataEnd):
(JSC::CopiedBlock::dataSize):
(JSC::CopiedBlock::wilderness):
(JSC::CopiedBlock::wildernessEnd):
(JSC::CopiedBlock::wildernessSize):
(JSC::CopiedBlock::size):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC):

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace):
(JSC::SlotVisitor::doneCopying):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::SlotVisitor):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage):
(JSC::JIT::emitAllocateJSArray):

7:19 PM Changeset in webkit [122676] by eric.carlson@apple.com
  • 25 edits in trunk/Source

Enable AVCF hardware video decoding
​https://bugs.webkit.org/show_bug.cgi?id=90015
<rdar://problem/10770317>

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter): New, return the client's graphics

device adapter.

  • html/HTMLMediaElement.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::graphicsDeviceAdapter): New.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::graphicsDeviceAdapter): New, ask the media element for the graphics

device adapter.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Soft-link AVCFPlayerSetDirect3DDevice

and AVCFPlayerEnableHardwareAcceleratedVideoDecoderKey.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL): Pass the current d3d9

device interface to the AVFWrapper.

(WebCore::AVFWrapper::createAssetForURL): If the d3d9 device implements IDirect3DDevice9Ex,

tell the AVAsset to enable hardware video decoding.

(WebCore::AVFWrapper::createPlayer): Pass the d3d9 device to the player if it implements IDirect3DDevice9Ex.

  • platform/graphics/ca/win/CACFLayerTreeHost.h:

(WebCore::CACFLayerTreeHost::graphicsDeviceAdapter): New, default implementation.

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:

(WebCore::LegacyCACFLayerTreeHost::graphicsDeviceAdapter): New, default implementation.

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:

(WebCore::WKCACFViewLayerTreeHost::graphicsDeviceAdapter): New.

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
  • platform/win/SoftLinking.h: Define SOFT_LINK_DLL_IMPORT_OPTIONAL, SOFT_LINK_LOADED_LIBRARY,

and SOFT_LINK_VARIABLE_DLL_IMPORT_OPTIONAL.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::graphicsDeviceAdapter): New, return the view's graphics adapter.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebView.cpp:

(WebView::graphicsDeviceAdapter): New, return the layer tree host's graphics adapter.

  • WebView.h:

(WebCore):
(WebView):

Source/WebKit2:

  • DerivedSources.make: Define HAVE_AVCF if necessary.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit):
(WebKit::WebChromeClient::graphicsDeviceAdapter): New, return the layer tree host's

graphics adapter.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebCore):
(LayerTreeHost):
(WebKit::LayerTreeHost::graphicsDeviceAdapter): New, default implementation.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

(LayerTreeHostCAWin):

4:31 PM Changeset in webkit [122675] by benjamin@webkit.org
  • 6 edits
    1 add in trunk

[Mac] Do not try to update the cache model for every WebPreferences change
​https://bugs.webkit.org/show_bug.cgi?id=91302

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-07-14
Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
we can just listen to updates of the CacheModel property.

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _postCacheModelChangedNotification]):
(-[WebPreferences setCacheModel:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _cacheModelChangedNotification:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

2:56 PM Changeset in webkit [122674] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Chromium Mac build failure after r122670.

  • platform/graphics/mac/ComplexTextController.cpp:
2:45 PM Changeset in webkit [122673] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Snow Leopard build.

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary): Fix a typo in the condition so that Snow Leopard
continues to take the expected path.

2:38 PM Changeset in webkit [122672] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Accessing the last item in children should be a constant time operation
​https://bugs.webkit.org/show_bug.cgi?id=91320

Reviewed by Ojan Vafai.

Source/WebCore:

Traverse nodes from the last item when the target offset we're looking for is closer to the last item
than to the cached item. e.g. if the cached item was at offset 0 in the collection and length was 100,
we should not be looking for the item at offset 95 from the cached item.

Note that this trick can be only used in HTML collection that supports itemBefore and when the length
cache is available.

Also broke shouldSearchFromFirstItem into smaller logical pieces to clarify the intents.

Test: perf/htmlcollection-last-item.html

  • html/HTMLCollection.cpp:

(WebCore):
(WebCore::HTMLCollection::isLastItemCloserThanLastOrCachedItem):
(WebCore::HTMLCollection::isFirstItemCloserThanCachedItem):
(WebCore::HTMLCollection::item):

  • html/HTMLCollection.h:

(HTMLCollection):

LayoutTests:

Added an asymptotic time complexity test.

  • perf/htmlcollection-last-item-expected.txt: Added.
  • perf/htmlcollection-last-item.html: Added.
2:34 PM Changeset in webkit [122671] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build.

  • platform/network/cf/DNSCFNet.cpp: Fix the condition to take Windows in to account.
2:11 PM Changeset in webkit [122670] by mrowe@apple.com
  • 60 edits in trunk/Source/WebCore

Make it explicit which code paths iOS should use when doing checks based on OS X versions.

Rubber-stamped by David Kilzer.

  • WebCore.exp.in:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityTable.h:
  • accessibility/mac/AXObjectCacheMac.mm:
  • editing/mac/EditorMac.mm:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • page/AlternativeTextClient.h:
  • page/mac/SettingsMac.mm:
  • platform/LocalizedStrings.cpp:
  • platform/MemoryPressureHandler.cpp:
  • platform/audio/mac/AudioBusMac.mm:
  • platform/graphics/Gradient.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/mac/TileCache.mm:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/FontCustomPlatformData.cpp:
  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/mac/DisplaySleepDisabler.cpp:
  • platform/mac/DisplaySleepDisabler.h:
  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/MemoryPressureHandlerMac.mm:
  • platform/mac/SharedTimerMac.mm:
  • platform/mac/SuddenTermination.mm:
  • platform/mac/WebFontCache.mm:
  • platform/network/Credential.h:
  • platform/network/ResourceHandle.h:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/WebCoreURLResponse.mm:
  • platform/text/TextChecking.h:
  • platform/text/cf/HyphenationCF.cpp:
  • platform/text/mac/HyphenationMac.mm:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerCompositor.cpp:
12:28 PM Changeset in webkit [122669] by fpizlo@apple.com
  • 4 edits in trunk/Source/WTF

Unreviewed, build fix.

  • wtf/Assertions.cpp:
  • wtf/Platform.h:
  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

7:09 AM Changeset in webkit [122668] by allan.jensen@nokia.com
  • 5 edits in trunk/LayoutTests

[Tests] Unskip not failing tests previously relying on LTC::nodesFromRect implementation
​https://bugs.webkit.org/show_bug.cgi?id=46600

Reviewed by Ryosuke Niwa.

These tests no longer relies on LayoutTestController.nodesFromRect but on Internals, and should work
in all platforms.

  • platform/chromium/TestExpectations:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
3:53 AM Changeset in webkit [122667] by rniwa@webkit.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r122665.
​http://trac.webkit.org/changeset/122665
​https://bugs.webkit.org/show_bug.cgi?id=91321

Broke Mac builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-07-14

Source/WebKit/mac:

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences setCacheModel:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _preferencesChangedNotification:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
2:50 AM Changeset in webkit [122666] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

Skip test added in r122663 on Qt and GTK

Unreviewed, gardening.

Qt has 1px difference tracked under

​https://bugs.webkit.org/show_bug.cgi?id=89597

Gtk has a platform-specific rendering issue with the test.

​https://bugs.webkit.org/show_bug.cgi?id=91319

  • platform/gtk/TestExpectations:
  • platform/qt/Skipped:
2:03 AM Changeset in webkit [122665] by benjamin@webkit.org
  • 6 edits
    1 add in trunk

[Mac] Do not try to update the cache model for every WebPreferences change
​https://bugs.webkit.org/show_bug.cgi?id=91302

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-07-13
Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
we can just listen to updates of the CacheModel property.

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences _postCacheModelChangedNotification]):
(-[WebPreferences setCacheModel:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(+[WebView initialize]):
(+[WebView _cacheModelChangedNotification:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

1:59 AM Changeset in webkit [122664] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122614.
​http://trac.webkit.org/changeset/122614
​https://bugs.webkit.org/show_bug.cgi?id=91317

Broke performance tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-07-14

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::v8ExternalStringSlow):

1:57 AM Changeset in webkit [122663] by robert@webkit.org
  • 3 edits
    2 adds in trunk

CSS 2.1 failure: vertical-align-boxes-001 fails
​https://bugs.webkit.org/show_bug.cgi?id=90626

Reviewed by Eric Seidel.

Source/WebCore:

Tests: css2.1/20110323/vertical-align-boxes-001.htm

A percentage value vertical-align is always a percentage of the actual line-height rather than
the margin box per ​http://www.w3.org/TR/CSS21/visudet.html#propdef-vertical-align: 'Percentages:
refer to the 'line-height' of the element itself'. Confusingly, RenderBox::lineheight() is a
shorthand into the dimensions of the margin box for replaced elements in the other vertical-align
cases, i.e. where it's the margin box that's relevant rather than the 'line-height'. So rather than patch RenderBox's
lineHeight() to somehow consider the percentage cases, just give percentage vertical-align the full computedLineHeight()
rather than lineHeight()'s margin box.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

LayoutTests:

  • css2.1/20110323/vertical-align-boxes-001-expected.html: Added.
  • css2.1/20110323/vertical-align-boxes-001.htm: Added. This patch fixes the 'percentage' case in this test so that it calculates 50% of the line-height of 60px rather than 50% of the img's margin-box of -8px.
1:09 AM Changeset in webkit [122662] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, marking http/tests/misc/webtiming-origins.html as flaky.

  • platform/gtk/TestExpectations:
12:19 AM Changeset in webkit [122661] by zandobersek@gmail.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding an image expectation for a test introduced
in r122651. Also creating platform-specific baselines for two File API tests
that behave differently because of function overloading problems but pass otherwise,
and skipping a test for correct viewport of sites with Mobile DTD which GTK port
does not (yet) support.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/files/create-blob-url-crash-expected.txt: Added.
  • platform/gtk/fast/files/url-required-arguments-expected.txt: Added.
12:08 AM Changeset in webkit [122660] by rniwa@webkit.org
  • 11 edits
    2 adds in trunk

Iterating backwards over HTMLCollection is O(n2)
​https://bugs.webkit.org/show_bug.cgi?id=91306

Reviewed by Anders Carlsson.

Source/WebCore:

Fixed the bug by introducing itemBefore that iterates nodes backwards to complement itemAfter.
Unfortunately, some HTML collections such as HTMLFormCollection and HTMLTableRowsCollection have
its own itemAfter function and writing an equivalent itemBefore is somewhat tricky. For now,
added a new boolean flag indicating whether a given HTML collection supports itemBefore or not,
and left those HTML collections that override itemAfter alone.

This also paves our way to share more code between DynamicNodeList and HTMLCollection.

Test: perf/htmlcollection-backwards-iteration.html

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Takes ItemBeforeSupportType.
(WebCore::DynamicNodeListCacheBase::supportsItemBefore): Added.
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::setItemCache): Replaced a FIXME by an assertion now that
we can.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection): Supports itemBefore since it doesn't override
itemAfter.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::isAcceptableElement): Made it a static local function instead of a static member.
(WebCore::nextNode): Templatized.
(WebCore::itemBeforeOrAfter): Extracted from itemAfter and templatized.
(WebCore::HTMLCollection::itemBefore): Added.
(WebCore::HTMLCollection::itemAfter):
(WebCore::HTMLCollection::shouldSearchFromFirstItem): Added. Determines whether we should reset
the item cache to the first item. We obviously do if the cache is invalid. If the target offset
is after the cached offset, then we shouldn't go back regardless of availability of itemBefore.
Otherwise, we go back to the first item iff itemBefore is not available or the distance from
the cached offset to the target offset is greater than the target offset itself.
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item): Use the term "offset" to match the terminology elsewhere.
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem): Ditto. Also added the logic to iterate
nodes backwards using itemBefore. Once we're in this branch, we should always find a matching
item since the target offset was less than the cached offset, and offsets are non-negative.
If we had ever reached the end of the loop without finding an item, it indicates that the cache
has been invalid and we have some serious bug elsewhere.

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Supports itemBefore since it doesn't
override itemAfter.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection): Doesn't support itemBefore as it overrides
itemAfter.

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):

LayoutTests:

Add an asymptotic time complexity test.

  • perf/htmlcollection-backwards-iteration-expected.txt: Added.
  • perf/htmlcollection-backwards-iteration.html: Added.
Note: See TracTimeline for information about the timeline view.