⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 16, 2012:

11:43 PM Changeset in webkit [122811] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed. Remove two empty directories.

  • public/linuxish: Removed.
  • src/linuxish: Removed.
11:37 PM FeatureFlags edited by davidbarr@chromium.org
(diff)
11:27 PM Changeset in webkit [122810] by gyuyoung.kim@samsung.com
  • 25 edits
    6 adds in trunk/Source

Add RegisterProtocolHandlerClient to the Modules/protocolhandler
https://bugs.webkit.org/show_bug.cgi?id=90940

Reviewed by Hajime Morita.

Source/WebCore:

As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.

In addition, NavigatorRegisterProtocolHandler should be supplementable.

No new tests. Covered by existing tests.

  • GNUmakefile.list.am:
  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.cpp:

(WebCore::NavigatorRegisterProtocolHandler::from):
(WebCore::NavigatorRegisterProtocolHandler::create):
(WebCore):
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered):
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::supplementName):
(WebCore::provideRegisterProtocolHandlerTo):

  • Modules/protocolhandler/NavigatorRegisterProtocolHandler.h:

(WebCore):
(NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::NavigatorRegisterProtocolHandler):
(WebCore::NavigatorRegisterProtocolHandler::client):

  • Modules/protocolhandler/RegisterProtocolHandlerClient.h: Added.

(WebCore):
(RegisterProtocolHandlerClient):

  • WebCore.gypi:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:

(ChromeClient):

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::setCookies):
(WebCore::getRawCookies):

Source/WebKit:

As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.

  • PlatformEfl.cmake: Add RegisterProtocolHandlerEfl files and include path.

Source/WebKit/chromium:

As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.

In order to support this, RegisterProtocolHandlerClientImpl class is added to ChromeClientImpl files.

In addition, existing functions related to protocol handler in ChromeClientImpl class are moved to
RegisterProtocolHandlerClientImpl class.

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp: Implement RegisterProtocolHandlerClientImpl class.

(WebKit):
(WebKit::RegisterProtocolHandlerClientImpl::create):
(WebKit::RegisterProtocolHandlerClientImpl::RegisterProtocolHandlerClientImpl):
(WebKit::RegisterProtocolHandlerClientImpl::registerProtocolHandler):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):
(RegisterProtocolHandlerClientImpl):
(WebKit::RegisterProtocolHandlerClientImpl::~RegisterProtocolHandlerClientImpl):
(WebKit):

  • src/WebViewImpl.cpp: Register RegisterProtocolHandlerClientImpl in order to support supplement.

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

Source/WebKit/efl:

As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient

In order to support this, RegisterProtocolHandlerClientEfl class is added and ewk_view registers
RegisterProtocolHandlerClientEfl. In addition, existing concrete functions in ChromeClientEfl are moved
to RegisterProtocolHandlerClientEfl.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:
  • WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp: Added.

(WebCore):
(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::RegisterProtocolHandlerClientEfl::RegisterProtocolHandlerClientEfl):
(WebCore::RegisterProtocolHandlerClientEfl::registerProtocolHandler):
(WebCore::RegisterProtocolHandlerClientEfl::isProtocolHandlerRegistered):
(WebCore::RegisterProtocolHandlerClientEfl::unregisterProtocolHandler):

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.h: Added.

(RegisterProtocolHandlerClientEfl):
(WebCore::RegisterProtocolHandlerClientEfl::~RegisterProtocolHandlerClientEfl):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.

In order to support this, RegisterProtocolHandlerClientGtk class is added and webview registers
RegisterProtocolHandlerClientGtk. In addition, existing concrete functions in ChromeClientGtk are moved
to RegisterProtocolHandlerClientGtk.

  • GNUmakefile.am:
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • WebCoreSupport/RegisterProtocolHandlerClientGtk.cpp: Added.

(WebKit):
(WebKit::RegisterProtocolHandlerClient::RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::registerProtocolHandler):

  • WebCoreSupport/RegisterProtocolHandlerClientGtk.h: Added.

(WebKit):
(RegisterProtocolHandlerClient):
(WebKit::RegisterProtocolHandlerClient::~RegisterProtocolHandlerClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit2:

As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs
to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for
protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient.

In order to support this, WebRegisterProtocolHandlerClient class is added. However, this is not implemented yet.
In addition, existing virtual functions in WebChromeClient are moved to WebRegisterProtocolHandlerClient.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebRegisterProtocolHandlerClient.h: Added.

(WebKit):
(WebRegisterProtoclHandlerClient):
(WebKit::WebRegisterProtoclHandlerClient::isProtocolHandlerRegistered):
(WebKit::WebRegisterProtoclHandlerClient::unregisterProtocolHandler):

11:27 PM Changeset in webkit [122809] by abarth@webkit.org
  • 2 edits
    2 moves in trunk/Tools

[Chromium] Move Task.(cpp|h) into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91446

Reviewed by Ryosuke Niwa.

Task is a dependency of EventSender, which needs to move into TestRunner.a.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
  • DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
11:19 PM Changeset in webkit [122808] by abarth@webkit.org
  • 2 edits
    4 moves in trunk/Tools

[Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91443

Reviewed by Tony Chang.

Purely a file move (and a sorting of #includes).

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
  • DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
  • DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
10:11 PM Changeset in webkit [122807] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing.
https://bugs.webkit.org/show_bug.cgi?id=91244

Reviewed by Kent Tamura.

This patch enables and updates disabled test cases of DecimalTest
caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor()
for small fraction numbers and added test cases. Fixes in r122552
itself is correct however, it didn't update existing tests for very small
fraction numbers.

  • tests/DecimalTest.cpp:

(TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000),
ceiling rounds number toward positive infinity.
(TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000),
floor rounds number toward negative infinity.

9:37 PM Changeset in webkit [122806] by commit-queue@webkit.org
  • 17 edits
    4 adds in trunk

.: Expose an export for the iconUrl list so Internals can use it
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.

  • Source/autotools/symbols.filter: export iconURLs

Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.

As it turns out, it can contain stale URLs in the case that some script
manipulates the DOM, which breaks scripts trying to reset the favicon
URL. Also added a method in Internals to allow tests to get the list of
icon

Tests: fast/dom/icon-url-change.html

fast/dom/icon-url-list.html

  • WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
  • dom/Document.cpp:

(WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
(WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
(WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace

  • dom/Document.h:

(Document): removed the addIconURL method which is no longer used

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
(WebCore):
(WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor

  • html/HTMLLinkElement.h:

(HTMLLinkElement): declared the icon type and size accessors

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
(WebCore):

  • testing/Internals.h:

(Internals): declared the method for unit testing the icon URL list

  • testing/Internals.idl: exported the Document::iconURLs function

Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.

  • win/WebKit2.def: export the DocumentL::iconURLs function

LayoutTests: Add some new unit tests to test the favicon changing dynamically
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-16
Reviewed by Kent Tamura.

  • fast/dom/icon-url-change-expected.txt: Added.
  • fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
  • fast/dom/icon-url-list-expected.txt: Added.
  • fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
  • fast/dom/icon-url-property-expected.txt: update unit test expectations
  • fast/dom/icon-url-property.html: update and enable existing favicon test
  • platform/chromium/TestExpectations: reenable the url-property test
9:33 PM Changeset in webkit [122805] by commit-queue@webkit.org
  • 12 edits in trunk

WebCore needs WEBCORE_TESTING macro to mark methods being exported for testing.
https://bugs.webkit.org/show_bug.cgi?id=90764

Patch by Hajime Morrita <morrita@chromium.org> on 2012-07-16
Reviewed by Adam Barth.

.:

Removed symbols which are now covered by WEBCORE_TESTING.

  • Source/autotools/symbols.filter:

Source/WebCore:

Defined WEBCORE_TESTING based on USE(EXPORT_MACROS_FOR_TESTING) and
applied it to FrameDestructionObserver.

  • bindings/js/JSDOMGlobalObject.h: Removed conflicting symbols
  • page/FrameDestructionObserver.h: Added WEBKIT_TESTING

(FrameDestructionObserver):

  • platform/PlatformExportMacros.h:

Source/WebKit2:

Removed symbols which are now covered by WEBCORE_TESTING.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Source/WTF:

Added USE(EXPORT_MACROS_FOR_TESTING) and enabled it on GTK and Windows.

  • wtf/ExportMacros.h:
  • wtf/Platform.h:
9:00 PM Changeset in webkit [122804] by abarth@webkit.org
  • 4 edits in trunk/Tools

[Chromium] AccessibilityController shouldn't know anything about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91441

Reviewed by Tony Chang.

This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.

  • DumpRenderTree/chromium/AccessibilityController.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::getFocusedElement):
(AccessibilityController::getRootElement):

  • DumpRenderTree/chromium/AccessibilityController.h:

(WebKit):
(AccessibilityController):
(AccessibilityController::setWebView):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):

8:51 PM Changeset in webkit [122803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement decidePolicyForResponse in policy client
https://bugs.webkit.org/show_bug.cgi?id=91401

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-16
Reviewed by Kenneth Rohde Christiansen.

Provide implementation for decidePolicyForResponse callback
in WebKit2 EFL's policy client.

  • UIProcess/API/efl/ewk_view_policy_client.cpp:

(decidePolicyForResponseCallback):
(ewk_view_policy_client_attach):

8:26 PM Changeset in webkit [122802] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

REGRESSION: RenderInline::absoluteQuads produces incorrect results for fixed position.
https://bugs.webkit.org/show_bug.cgi?id=91451

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-16
Reviewed by Simon Fraser.

Source/WebCore:

RenderInline::absoluteQuads relies on copies of RenderGeometryMap,
created indirectly by passing AbsoluteQuadsGeneratorContext object by
value. These copies are unsafe because the individual transform steps
within the geometry map include a owned poitner to their respective
transform.

Modify the callee methods to take context by reference and disable
copy constructor for RenderGeometryMap.

Test: fast/inline/inline-fixed-position-boundingbox.html

  • rendering/RenderGeometryMap.h:

(WebCore::RenderGeometryMapStep::RenderGeometryMapStep): Add missing
m_offset to copy constructor initialization list.
(RenderGeometryMap): Disable copy constructor.

  • rendering/RenderInline.cpp: Pass context object by reference.

(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):

  • rendering/RenderInline.h:

(RenderInline::generateLineBoxRects): Update method declarations to
show pass by reference context parameter.
(RenderInline::generateCulledLineBoxRects): Ditto.

LayoutTests:

Add a regression test for boundingBox of an inline element with fixed position.

  • fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
  • fast/inline/inline-fixed-position-boundingbox.html: Added.
8:24 PM Changeset in webkit [122801] by hayato@chromium.org
  • 3 edits
    2 adds in trunk

Some events should be always stopped at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=90436

Reviewed by Ryosuke Niwa.

Source/WebCore:

The spec is here:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events-that-are-always-stopped

Test: fast/dom/shadow/events-stopped-at-shadow-boundary.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::determineDispatchBehavior):

LayoutTests:

  • fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt: Added.
  • fast/dom/shadow/events-stopped-at-shadow-boundary.html: Added.
8:20 PM Changeset in webkit [122800] by abarth@webkit.org
  • 4 edits
    2 adds in trunk/Tools

[Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=91312

Reviewed by Ryosuke Niwa.

Looking forward to moving more objects into TestRunner.a, we're going
to need an object to own all the interfaces and to put them through
their lifecycle.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
8:09 PM Changeset in webkit [122799] by ryuan.choi@samsung.com
  • 14 edits in trunk

[EFL][WK2] Add APIs to support theme.
https://bugs.webkit.org/show_bug.cgi?id=90107

Reviewed by Hajime Morita.

Source/WebKit2:

RenderThemeEfl uses edj file to render native theme of form elements.
This patch provides default theme and a way to change edj theme file for
WebKit2/Efl.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_base_add):
(ewk_view_theme_set):
(ewk_view_theme_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::setThemePath):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::setThemePath):

Tools:

Override default theme path for MiniBrowser and WebKitTestRunner.

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(browserCreate):

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

8:01 PM Changeset in webkit [122798] by ryuan.choi@samsung.com
  • 29 edits
    2 adds in trunk

[EFL][DRT] Implement dumpFrameScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=87638

Reviewed by Hajime Morita.

Tools:

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFrameScrollPosition): Implemented.
(shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.

LayoutTests:

Updated expected results to dump scrolled position.

  • platform/efl/compositing/geometry/fixed-in-composited-expected.txt:
  • platform/efl/compositing/geometry/horizontal-scroll-composited-expected.txt:
  • platform/efl/compositing/geometry/video-fixed-scrolling-expected.txt:
  • platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt:
  • platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt:
  • platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
  • platform/efl/fast/dom/focus-contenteditable-expected.txt:
  • platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt:
  • platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt:
  • platform/efl/fast/dynamic/anchor-lock-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/events/reveal-link-when-focused-expected.txt:
  • platform/efl/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/efl/fast/multicol/scrolling-overflow-expected.txt: Added.
  • platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • platform/efl/fast/overflow/overflow_hidden-expected.txt:
  • platform/efl/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/efl/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/efl/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/efl/fast/repaint/fixed-expected.txt:
  • platform/efl/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/efl/fast/repaint/fixed-tranformed-expected.txt:
  • platform/efl/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/efl/transforms/2d/transform-fixed-container-expected.txt:
7:25 PM Changeset in webkit [122797] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r119948): [Form] HTMLInputElement.valueAsNumber for input type "month" should return number of month since January 1970
https://bugs.webkit.org/show_bug.cgi?id=91211

Reviewed by Kent Tamura.

This patch changes BaseDateAndTimeInputType::valueAsDouble() to call
virtual function parseToNumber() which "month" input type overrides
instead of non-virtual function parseToDouble() which returns number
of milliseconds.

No new tests. Existing test (fast/form/month/input-valueasnumber-month.html) coverts this, although it is disabled.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::valueAsDouble): Changed to call parseToNumber().
(WebCore::BaseDateAndTimeInputType::parseToNumber): Changed to what parseToDouble() did.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType): Remove parseToDouble().

7:10 PM Changeset in webkit [122796] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline of fast/text/textIteratorNilRenderer for r122769.

  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
6:43 PM Changeset in webkit [122795] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out 122790 because it broke the Windows build. I'm not
sure what to do with exported symbols that are predicated on NDEBUG.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/CodeBlock.cpp:

(JSC):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):

6:39 PM Changeset in webkit [122794] by eae@chromium.org
  • 29 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium mac/win rebaseline for r122769.

  • platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug24200-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-win-xp/css1: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win-xp/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/css1/basic/inheritance-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
6:38 PM Changeset in webkit [122793] by tkent@chromium.org
  • 2 edits in branches/chromium/1180

Merge 122212 -

RTL calendar picker for <input type=date> is too narrow and clipped
https://bugs.webkit.org/show_bug.cgi?id=90864

Reviewed by Kentaro Hara.

.:

  • ManualTests/forms/calendar-picker.html:
  • Add isRTL:true for the arabic setting
  • Reset the iframe size when the setting is changed.

Source/WebCore:

Tests: ManualTests/forms/calendar-picker.html

  • Resources/calendarPicker.js:

(fixWindowSize):
Checks the left edge of elemenets in RTL.
(layout): Add dir=ltr for the manual test, which re-uses the document.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10780025

6:33 PM Changeset in webkit [122792] by tkent@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/html/ImageInputType.cpp

Merge 122418 -

Accessing width or height of a detached image input element causes crash
https://bugs.webkit.org/show_bug.cgi?id=90885

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/forms/image/width-and-height-of-detached-input.html

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::height): Add null check for m_imageLoader.
(WebCore::ImageInputType::width): ditto.

LayoutTests:

  • fast/forms/image/width-and-height-of-detached-input-expected.txt: Added.
  • fast/forms/image/width-and-height-of-detached-input.html: Added.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10780024

6:24 PM Changeset in webkit [122791] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Turn off ScrollbarLayerChromium for Windows due to bad alpha values
https://bugs.webkit.org/show_bug.cgi?id=91438

Reviewed by Kenneth Russell.

r120509 turned on blending for scrollbar thumbs. Unfortunately for
Windows XP scrollbar thumbs, their alpha channel is bogus and so the
thumb ends up being completely transparent. This should ultimately be
fixed in Chromium theme code, but in the meantime this patch turns
off the use of ScrollbarLayerChromium.

This change makes Windows scrollbars fall back to using normal
ContentLayerChromiums and being painted all in one layer on the main
thread rather than being painted separately and composited on the
compositor thread.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::createScrollbarLayer):

6:14 PM Changeset in webkit [122790] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

dumpCallFrame is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=91444

Reviewed by Gavin Barraclough.

Various changes have been made to the SF calling convention, but
dumpCallFrame has not been updated to reflect these changes.
That resulted in both bogus information, as well as numerous
assertions of sadness.

This patch makes dumpCallFrame actually work again and adds the
wonderful feature of telling you the name of the variable that a
register reflects, or what value it contains.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

A really innefficient mechanism for finding the name of a local register.
This should only ever be used by debug code so this should be okay.

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

Debug builds no longer throw away a functions symbol table, this allows
us to actually perform a register# to name mapping

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

We weren't propogating the bytecode offset here leading to assertions
in debug builds when dumping bytecode of DFG compiled code.

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):

Rework to actually be correct.

(JSC::getCallerInfo):

Return the byteocde offset as well now, given we have to determine it
anyway.

(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(Interpreter):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionDumpCallFrame):

Give debug builds of JSC a method for calling dumpCallFrame so we can
inspect a callframe without requiring us to break in a debugger.

5:57 PM Changeset in webkit [122789] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Tools

NRWRT Should provide a VS project to work on
https://bugs.webkit.org/show_bug.cgi?id=91436

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-16
Reviewed by Dirk Pranke.

Adding VS2010 project for modifying webkitpy. Uses pytools
<http://pytools.codeplex.com> which integrates python into
Visual Studio.

  • Scripts/webkitpy/webkitpy.pyproj: Added.
  • Scripts/webkitpy/webkitpy.sln: Added.
5:57 PM Changeset in webkit [122788] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

Vertical alternate glyph (GSUB) support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81389

Patch by Koji Ishii <Koji Ishii> on 2012-07-16
Reviewed by Tony Chang.

Source/WebCore:

This patch adds support for reading 'GSUB' OpenType table to get
vertical alternate glyphs.
http://www.microsoft.com/typography/otspec/gsub.htm

Like bug 81326, this code isn't on any code path yet.

Tests: WebKit/chromium/tests/OpenTypeVerticalDataTest.cpp

  • platform/graphics/opentype/OpenTypeTypes.h:

(WebCore::OpenType::validateTable): Moved from OpenTypeVerticalData.cpp for unit tests.
(OpenType):
(TableBase): Ditto.
(WebCore::OpenType::TableBase::isValidEnd):
(WebCore::OpenType::TableBase::validatePtr):
(WebCore::OpenType::TableBase::validateOffset):

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(OpenType): Added several OpenType tables used by 'GSUB' table.
(CoverageTable):
(Coverage1Table):
(Coverage2Table):
(RangeRecord):
(SubstitutionSubTable):
(WebCore::OpenType::SubstitutionSubTable::coverage):
(SingleSubstitution2SubTable):
(LookupTable):
(WebCore::OpenType::LookupTable::getSubstitutions):
(LookupList):
(WebCore::OpenType::LookupList::lookup):
(FeatureTable):
(WebCore::OpenType::FeatureTable::getGlyphSubstitutions):
(FeatureList):
(FeatureRecord):
(WebCore::OpenType::FeatureList::feature):
(LangSysTable):
(WebCore::OpenType::LangSysTable::feature):
(ScriptTable):
(LangSysRecord):
(WebCore::OpenType::ScriptTable::defaultLangSys):
(ScriptList):
(ScriptRecord):
(WebCore::OpenType::ScriptList::script):
(WebCore::OpenType::ScriptList::defaultScript):
(WebCore::OpenType::ScriptList::defaultLangSys):
(GSUBTable):
(WebCore::OpenType::GSUBTable::scriptList):
(WebCore::OpenType::GSUBTable::featureList):
(WebCore::OpenType::GSUBTable::lookupList):
(WebCore::OpenType::GSUBTable::defaultLangSys):
(WebCore::OpenType::GSUBTable::feature):
(WebCore::OpenType::GSUBTable::getVerticalGlyphSubstitutions):
(WebCore::OpenTypeVerticalData::OpenTypeVerticalData):
(WebCore::OpenTypeVerticalData::loadMetrics): Split code to load metrics from ctor.
(WebCore::OpenTypeVerticalData::loadVerticalGlyphSubstitutions): Load the vertical alternate Glyph substitution table.
(WebCore):
(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs): Substitute Glyph IDs with vertical alternate Glyph IDs.

  • platform/graphics/opentype/OpenTypeVerticalData.h:

(OpenTypeVerticalData): Added m_verticalGlyphMap.

Source/WebKit/chromium:

Tests for pointer validations for OpenType tables.

  • WebKit.gypi:
  • tests/OpenTypeVerticalDataTest.cpp: Added.

(WebCore):
(TestTable):
(WebCore::TestTable::validateOffset):
(WebCore::TEST):

5:52 PM Changeset in webkit [122787] by scheib@chromium.org
  • 6 edits in trunk/Source/WebCore

Fix spelling of EnforceIFrameAllowFullScreenRequirement and ExemptIFrameAllowFullScreenRequirement.
https://bugs.webkit.org/show_bug.cgi?id=91437

Reviewed by Adrienne Walker.

Document contained spelling errors of 'FulScreen' instead of 'FullScreen'
for the FullScreenCheckType enumeration.

No test changes needed.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):
(WebCore::Element::webkitRequestFullScreen):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enterFullscreen):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):

5:48 PM Changeset in webkit [122786] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why
https://bugs.webkit.org/show_bug.cgi?id=91174

Reviewed by Kent Tamura.

Clarified the explanation.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer):

5:46 PM Changeset in webkit [122785] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r120033.
http://trac.webkit.org/changeset/120033
https://bugs.webkit.org/show_bug.cgi?id=91454

Broke background gradients (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

5:44 PM Changeset in webkit [122784] by kareng@chromium.org
  • 1 edit in branches/chromium/1180/Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp

Revert 120033 - GeneratorGeneratedImage should cache images for the non-tiled case
https://bugs.webkit.org/show_bug.cgi?id=87094

Patch by Jin Yang <jin.a.yang@intel.com> on 2012-06-11
Reviewed by Simon Fraser.

Source/WebCore:

We cache the generated image if generator is not changed. By compared
with generating image on the fly, it will lose a little pixel precision
and several layout tests should be rebaselined. With this patch, the IE test
drive benchmark "Bayou" can gain about 50%.

No new tests. Performance optimization.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

LayoutTests:

Update expectations: added failures for baselines to come.

  • platform/chromium/TestExpectations:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10787031

5:43 PM Changeset in webkit [122783] by abarth@webkit.org
  • 4 edits
    6 moves
    1 delete in trunk/Tools

[Chromium] Move GamepadController into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=91311

Reviewed by Tony Chang.

GamepadController looks like a simple class to move into TestRunner.a
because it has almost zero dependence on TestShell.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
  • DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
  • DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
  • DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
    • GamepadController depends on these bindings helpers.
  • DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
  • DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
    • Just moved these files and removed the unused TestShell references.
  • DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
    • No longer needed.
  • DumpRenderTree/chromium/TestShell.cpp:
    • Update call to constructor to avoid passing in this.
5:31 PM Changeset in webkit [122782] by jsbell@chromium.org
  • 8 edits
    3 adds in trunk

IndexedDB: Implement spec updates to IDBTransaction.error
https://bugs.webkit.org/show_bug.cgi?id=91409

Reviewed by Tony Chang.

Source/WebCore:

The Indexed DB spec was updated to resolve some edge cases around the
IDBTransaction.error attribute. It was agreed that accessing error should
never throw, error should be null if the transaction is not finished or
abort() was explicitly called, an appropriate error should be returned if
a commit failed, and a generic AbortError should be used if a request
callback throws. These cases are now handled per spec, except that a reason
is not provided for the commit failure (it's always UnknownError).

Test: storage/indexeddb/transaction-error.html

storage/indexeddb/transaction-abort.html

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent): Refactor some nested if() blocks; don't
re-abort the transaction if dispatching in response to an abort.
(WebCore::IDBRequest::uncaughtExceptionInEventHandler): Abort transaction
only if not already aborting, and set it's error to AbortError.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort): Set error if abort triggered by back end.

  • Modules/indexeddb/IDBTransaction.h:

(WebCore::IDBTransaction::db): Move impl to header file.
(WebCore::IDBTransaction::error): Move impl to header file, simplify.
(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl: The error attribute no longer throws.

LayoutTests:

Update transaction-abort test to accomodate refinements in the spec around
IDBTransaction.error and add a dedicated test to exercise all spec behavior
for the property.

  • storage/indexeddb/resources/transaction-abort.js:

(startTest):
(firstAdd):
(secondAdd):
(transactionAborted):

  • storage/indexeddb/resources/transaction-error.js: Added.

(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(startTest.trans.onabort):
(startTest):
(testErrorFromRequest.request.onerror):
(testErrorFromRequest.trans.onabort):
(testErrorFromRequest):
(testErrorFromException.request.onerror):
(testErrorFromException.trans.onabort):
(testErrorFromException):

  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt: Added.
  • storage/indexeddb/transaction-error.html: Added.
5:31 PM Changeset in webkit [122781] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix WebFrameTest flakiness due to synthetic mouse events
https://bugs.webkit.org/show_bug.cgi?id=91428

Patch by Alexandre Elias <aelias@google.com> on 2012-07-16
Reviewed by Adam Barth.

Synthetic mouse move events on scrolling can cause segfaults in
WebFrameTest due to delayed callbacks on the message loop after
state destruction. This is currently only affecting
the Android port, but has the potential to affect other platforms in the
future.

We can avoid the issue by disabling the deviceSupportsMouse
setting, which shouldn't be needed by any WebFrameTest.

  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebViewAndLoad):

5:03 PM Changeset in webkit [122780] by commit-queue@webkit.org
  • 10 edits in trunk

Source/WebCore: IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.

Refactor IndexWriter to depend only on IDBIndexMetadata and on
(databaseId, objectStoreId, indexId) so that it can talk directly
to the backing store, and also eventually be moved into the renderer.

This also introduces IDBObjectStoreBackendInterface::putWithIndexKeys
as a replacement for IDBObjectStoreBackendInterface::put, already
stubbed out in the chromium port. It will fully replace put()
after both chromium and webkit sides have reached alignment.

No new tests as this is just a refactor and existing tests cover
correctness.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:
  • Modules/indexeddb/IDBIndexBackendImpl.h:
  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

Source/WebKit/chromium: IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.

Stub out implementations of putWithIndexKeys(), already implemented
on the chromium side.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::putWithIndexKeys):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

Tools: [Chromium-android] Don't use test_shell mode of DRT
https://bugs.webkit.org/show_bug.cgi?id=88542

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-07-16
Reviewed by Dirk Pranke.

Test shell mode is about to be removed.
Switch to use DRT mode for chromium-android.

Summary of changes:

  1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
  2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
  3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
  • DumpRenderTree/chromium/TestEventPrinter.cpp:

(DRTPrinter::handleImage): Outputs base64 on Android.

  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit): Changed err_file to err_fifo, required by python ServerProcess.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver.cmd_line):
(ChromiumAndroidDriver._deadlock_detector):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver.start):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._command_from_driver_input):
(ChromiumAndroidDriver._read_prompt):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest.test_driver_cmd_line):
(ChromiumAndroidDriverTest.test_cmd_line):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.test_drt_cmd_line):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_command_from_driver_input):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.init): Added universal_newlines to handle Android 'adb shell' line ends.
(ServerProcess._start):
(ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
(ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
(ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input):
(WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.read_stdout):
(MockServerProcess.start):
(MockServerProcess):
(MockServerProcess.stop):
(MockServerProcess.kill):
(WebKitDriverTest.test_read_block):
(WebKitDriverTest.test_read_binary_block):
(WebKitDriverTest.test_read_base64_block):

4:58 PM Changeset in webkit [122779] by commit-queue@webkit.org
  • 13 edits in trunk/Source

IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer
https://bugs.webkit.org/show_bug.cgi?id=90923

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-16
Reviewed by Darin Fisher.

Source/WebCore:

Refactor IndexWriter to depend only on IDBIndexMetadata and on
(databaseId, objectStoreId, indexId) so that it can talk directly
to the backing store, and also eventually be moved into the renderer.

This also introduces IDBObjectStoreBackendInterface::putWithIndexKeys
as a replacement for IDBObjectStoreBackendInterface::put, already
stubbed out in the chromium port. It will fully replace put()
after both chromium and webkit sides have reached alignment.

No new tests as this is just a refactor and existing tests cover
correctness.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:
  • Modules/indexeddb/IDBIndexBackendImpl.h:
  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::populateIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

Source/WebKit/chromium:

Stub out implementations of putWithIndexKeys(), already implemented
on the chromium side.

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::putWithIndexKeys):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

4:47 PM Changeset in webkit [122778] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Layout Test plugins/embed-attributes-style.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91445

Started failing around r122770

  • platform/chromium/TestExpectations:
4:46 PM Changeset in webkit [122777] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: move a bunch of printing code from manager.py to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91439

Reviewed by Ojan Vafai.

All of the logic that handles what gets logged should eventually
live in printing.py; this patch moves a large chunk of code that
prints all of the stuff after the run completes.

There are no functional changes, this is just moving code
around. Covered by existing tests (updated as necessary).

This code is all pretty messy and most of it should be deleted
(or extracted after the fact from results.json), but I'm saving
that for further patches. My goal is just to manager.py to a
more manageable state.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._num_digits):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_interrupt_if_at_failure_limits):
(ResultSummaryTest.summarized_results):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):
Here we had to add a list of the slow tests to the result
summary so that we didn't need to call back into the manager and
the test expectations object to figure out if a test is SLOW.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_results):
(Printer):
(Printer._print_timing_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_test_list_timing):
(Printer._print_directory_timings):
(Printer._print_statistics_for_test_timings):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):

4:45 PM Changeset in webkit [122776] by enne@google.com
  • 15 edits in trunk/Source

[chromium] Unify compositor quad transforms into content space
https://bugs.webkit.org/show_bug.cgi?id=91350

Reviewed by Kenneth Russell.

Source/WebCore:

For the purpose of simplification and as a first step towards removing
any transform that takes a centered rect, remove the ability of layers
to override the quad transform. All quads and quad transforms operate
on content space with the origin in the top left.

The gutter quads used to use the root layer (that doesn't draw
content) as the layer to create the shared quad state from. This is
now created manually as a layer without bounds should never in general
need a shared quad state created for it.

No change in functionality; tested by existing layout and unit tests.

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

Source/WebKit/chromium:

Update tests to add bounds/contentBounds properties to layers. This
exposed a bug in the quad culler tests where the draw transform was
incorrectly being set to the origin transform rather than being a
transform that operates on centered layer rects. Fixed this bug.

  • tests/CCQuadCullerTest.cpp:
  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):

4:05 PM Changeset in webkit [122775] by jsbell@chromium.org
  • 7 edits in trunk

IndexedDB: Resolve test and IDL FIXMEs for a handful of landed patches
https://bugs.webkit.org/show_bug.cgi?id=91423

Reviewed by Tony Chang.

Source/WebCore:

IDBObjectStore.createIndex() had a hack to handle a null keyPath argument for the
DOMString[] overload and treat it as the string "null". Now that IDL arrays are not
nullable by default following r121817 this hack can be removed and the binding layer
will automagically coerce to DOMString.

Test: storage/indexeddb/keypath-basics.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex): Remove special case for null in DOMString[] overload.

  • Modules/indexeddb/IDBObjectStore.idl: Remove Nullable suffix from DOMString[] overload

so that the DOMString overload will match null.

LayoutTests:

Resolve a couple of test-only FIXMEs: range deletion is now supported and
empty transactions commit.

  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/resources/database-closepending-flag.js:

(testDatabaseClosingSteps): Don't need a dummy request to keep transaction alive.

  • storage/indexeddb/resources/key-generator.js: Can test a range delete now.
3:52 PM Changeset in webkit [122774] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/Tools

[Chromium] Create a stub TestRunner.a target
https://bugs.webkit.org/show_bug.cgi?id=91309

Reviewed by Ryosuke Niwa.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
3:48 PM Changeset in webkit [122773] by commit-queue@webkit.org
  • 13 edits
    5 adds in trunk

Resolve CSS Exclusions shapeInside, shapeOutside properties to Length based WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=89670

Patch by Bear Travis <betravis@adobe.com> on 2012-07-16
Reviewed by Dirk Schulze.

Source/WebCore:

Layout of CSS Exclusions requires length based WrapShape classes,
rather than the existing CSSValue based CSSWrapShape classes. This
patch adds length based WrapShape analogs to the CSSWrapShapes, and
modifies RenderStyle to use a WrapShape instead of a CSSWrapShape.
The translation between WrapShape and CSSWrapShape classes
is handled by helper functions in the new WrapShapeFunctions files.
StyleBuilder resolves CSSWrapShapes to WrapShapes for layout use.
CSSComputedStyleDeclaration translates WrapShapes to CSSWrapShapes
for style use.

There are existing tests that cover the style serialization / resolution
in fast/exclusions/parsing-wrap-shape-inside.html and
fast/exclusions/parsing/wrap-shape-outside.html

Test: fast/exclusions/parsing-wrap-shape-lengths.html

  • CMakeLists.txt: Build system changes for adding new files
  • GNUmakefile.list.am: Ditto
  • Target.pri: Ditto
  • WebCore.gypi: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • css/CSSComputedStyleDeclaration.cpp: Translate WrapShapes back to CSSWrapShapes

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSWrapShapes.h: Mostly changing functions to be const

(WebCore::CSSWrapShapeRectangle::type):
(WebCore::CSSWrapShapeCircle::type):
(WebCore::CSSWrapShapeEllipse::type):
(WebCore::CSSWrapShapePolygon::getXAt):
(WebCore::CSSWrapShapePolygon::getYAt):
(WebCore::CSSWrapShapePolygon::values):
(WebCore::CSSWrapShapePolygon::type):

  • css/StyleBuilder.cpp: Resolve CSSWrapShapes to WrapShapes

(WebCore):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):

  • css/WrapShapeFunctions.cpp: Added.

(WebCore):
(WebCore::valueForWrapShape):
(WebCore::convertToLength):
(WebCore::wrapShapeForValue):

  • css/WrapShapeFunctions.h: Added.

(WebCore):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

  • rendering/style/WrapShapes.h: Added.

(WebCore):
(WrapShape):
(WebCore::WrapShape::~WrapShape):
(WebCore::WrapShape::WrapShape):
(WrapShapeRectangle):
(WebCore::WrapShapeRectangle::create):
(WebCore::WrapShapeRectangle::left):
(WebCore::WrapShapeRectangle::top):
(WebCore::WrapShapeRectangle::width):
(WebCore::WrapShapeRectangle::height):
(WebCore::WrapShapeRectangle::cornerRadiusX):
(WebCore::WrapShapeRectangle::cornerRadiusY):
(WebCore::WrapShapeRectangle::setLeft):
(WebCore::WrapShapeRectangle::setTop):
(WebCore::WrapShapeRectangle::setWidth):
(WebCore::WrapShapeRectangle::setHeight):
(WebCore::WrapShapeRectangle::setCornerRadiusX):
(WebCore::WrapShapeRectangle::setCornerRadiusY):
(WebCore::WrapShapeRectangle::type):
(WebCore::WrapShapeRectangle::WrapShapeRectangle):
(WrapShapeCircle):
(WebCore::WrapShapeCircle::create):
(WebCore::WrapShapeCircle::left):
(WebCore::WrapShapeCircle::top):
(WebCore::WrapShapeCircle::radius):
(WebCore::WrapShapeCircle::setLeft):
(WebCore::WrapShapeCircle::setTop):
(WebCore::WrapShapeCircle::setRadius):
(WebCore::WrapShapeCircle::type):
(WebCore::WrapShapeCircle::WrapShapeCircle):
(WrapShapeEllipse):
(WebCore::WrapShapeEllipse::create):
(WebCore::WrapShapeEllipse::top):
(WebCore::WrapShapeEllipse::left):
(WebCore::WrapShapeEllipse::radiusX):
(WebCore::WrapShapeEllipse::radiusY):
(WebCore::WrapShapeEllipse::setTop):
(WebCore::WrapShapeEllipse::setLeft):
(WebCore::WrapShapeEllipse::setRadiusX):
(WebCore::WrapShapeEllipse::setRadiusY):
(WebCore::WrapShapeEllipse::type):
(WebCore::WrapShapeEllipse::WrapShapeEllipse):
(WrapShapePolygon):
(WebCore::WrapShapePolygon::create):
(WebCore::WrapShapePolygon::windRule):
(WebCore::WrapShapePolygon::values):
(WebCore::WrapShapePolygon::getXAt):
(WebCore::WrapShapePolygon::getYAt):
(WebCore::WrapShapePolygon::setWindRule):
(WebCore::WrapShapePolygon::appendPoint):
(WebCore::WrapShapePolygon::type):
(WebCore::WrapShapePolygon::WrapShapePolygon):

LayoutTests:

Test that wrap shapes accept different length types
Wrap shape parsing and serialization is tested by parsing-wrap-shape-inside/outside

  • fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Added.
  • fast/exclusions/parsing-wrap-shape-lengths.html: Added.
3:34 PM Changeset in webkit [122772] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Assign some bug numbers to failing tests.

  • platform/chromium/TestExpectations:
3:17 PM Changeset in webkit [122771] by fpizlo@apple.com
  • 1 edit
    2 adds in trunk/Source/JavaScriptCore

Unreviewed, adding forgotten files.

  • dfg/DFGRegisterSet.h: Added.

(DFG):
(RegisterSet):
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):

  • dfg/DFGScratchRegisterAllocator.h: Added.

(DFG):
(ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

3:17 PM Changeset in webkit [122770] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix compositing layers in columns when in paginated mode
https://bugs.webkit.org/show_bug.cgi?id=91425

Reviewed by Dave Hyatt.

Source/WebCore:

Enhance a hack that was added to allow composited layers to
display in columns to work for paginated mode, where the
RenderView is renderer with columns.

Test: compositing/columns/composited-in-paginated.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

Testcase with a composited layer in a paginated document,
that dumps layers.

  • compositing/columns/composited-in-paginated-expected.txt: Added.
  • compositing/columns/composited-in-paginated.html: Added.
3:10 PM Changeset in webkit [122769] by eae@chromium.org
  • 23 edits
    2 adds in trunk

Inconsistent rounding in table layout causes background color to bleed through
https://bugs.webkit.org/show_bug.cgi?id=91410

Reviewed by Eric Seidel.

Source/WebCore:

At certain zoom levels a rounding error in the table layout code cases
the table background color to bleed through between cells. Tables layout
happens on pixel bounds however the paint offset wasn't correctly rounded.

Test: fast/sub-pixel/table-rows-no-gaps.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
Round paintOffset before passing it to the paint method of the children.

LayoutTests:

Add test to ensure that the table background color doesn't bleed through
when the table and a cell are positioned on a subpixel bound.

  • fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
  • fast/sub-pixel/table-rows-no-gaps.html: Added.
  • platform/chromium-linux/css1/basic/inheritance-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

Updated expectations to match new rounding logic. The new results better
match the rendering prior to turning on subpixel layout.

  • platform/efl/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Mark new test as skipped on platforms that have not enabled subpixel
layout.

3:08 PM Changeset in webkit [122768] by fpizlo@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

DFG PutById transition should handle storage allocation, and inline it
https://bugs.webkit.org/show_bug.cgi?id=91337

Reviewed by Oliver Hunt.

This enables the patching of DFG PutById to handle the out-of-line storage
allocation case. Furthermore, it inlines out-of-line storage allocation (and
reallocation) into the generated stubs.

To do this, this patch adds the ability to store the relevant register
allocation state (i.e. the set of in-use registers) in the structure stub
info so that the stub generation code can more flexibly select scratch
registers: sometimes it needs none, sometimes one - or sometimes up to
three. Moreover, to make the stub generation register allocation simple and
maintainable, this patch introduces a reusable scratch register allocator
class. This register allocator understands that some registers are in use by
the main path code and so must be spilled as necessary, other registers are
locked for use in the stub itself and so cannot even be spilled, while still
others may be allocated for scratch purposes. A scratch register that is
used must be spilled. If a register is locked, it cannot be used as a
scratch register. If a register is used, it can be used as a scratch
register so long as it is spilled.

This is a sub-1% speed-up on V8 and neutral elsewhere.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerCodeRef.h:

(FunctionPtr):
(JSC::FunctionPtr::FunctionPtr):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGGPRInfo.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::isInUse):
(RegisterBank):

  • dfg/DFGRegisterSet.h: Added.

(DFG):
(RegisterSet):
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):

  • dfg/DFGScratchRegisterAllocator.h: Added.

(DFG):
(ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::usedRegisters):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • heap/CopiedAllocator.h:

(CopiedAllocator):
(JSC::CopiedAllocator::fastPathShouldSucceed):
(JSC):

2:35 PM Changeset in webkit [122767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122739.
http://trac.webkit.org/changeset/122739
https://bugs.webkit.org/show_bug.cgi?id=91424

Broke mac builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16

  • inspector/CodeGeneratorInspector.py:

(flatten_list):

2:30 PM Changeset in webkit [122766] by danakj@chromium.org
  • 11 edits in trunk/Source/WebCore

[chromium] Remove non-ephemeral data from RenderSurface as it duplicates data from the owning layer
https://bugs.webkit.org/show_bug.cgi?id=91418

Reviewed by Adrienne Walker.

This removes the filters and masks from render surfaces, and makes them
used directly from the owning layer. Also removes skipsDraw from
surfaces as it was just not used at all.

Covered by existing tests.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::filters):
(WebCore::LayerChromium::backgroundFilters):
(WebCore::LayerChromium::hasMask):
(WebCore::LayerChromium::hasReplica):
(WebCore::LayerChromium::replicaHasMask):
(LayerChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::hasMask):
(WebCore::CCLayerImpl::hasReplica):
(WebCore::CCLayerImpl::replicaHasMask):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::calculateMemoryForRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::finishedRenderTarget):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToRenderTarget):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

2:18 PM Changeset in webkit [122765] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

2:13 PM Changeset in webkit [122764] by dpranke@chromium.org
  • 6 edits in trunk/Tools

test-webkitpy: clean up logging to make it ninja-esque
https://bugs.webkit.org/show_bug.cgi?id=91297

Reviewed by Adam Barth.

This patch changes the output of test-webkitpy to be closer to
what ninja produces. Namely:

If you are running with stderr writing to a tty (and not -v), we
will no longer print '...' as tests complete. Instead, we use a
metered stream and print entries of the form:

'[X/Y] test_name passed/failed/erred'

where X is the current test # and Y is the total number of tests.

If you are running with stderr piped to a file or other non-tty
object (or with -v), you get the same output, one per line for
every test.

In addition, if tests fail or err out, you get the stack trace
immediately; you don't have to wait until the end of the run.

Lastly, this change cleans up the unit tests for test-webkitpy
itself to not confuse the logger and to work cleanly w/ multiple
processes. It looks like between this and all the clean up in
MessagePool that happened as it landed, we can now run
multiprocessing tests in parallel.

  • Scripts/webkitpy/test/finder.py:

(Finder._default_names):

  • Scripts/webkitpy/test/finder_unittest.py:

(FinderTest.setUp):
(FinderTest.tearDown):

  • Scripts/webkitpy/test/printer.py:

(Printer.init):
(Printer.configure):
(Printer.print_started_test):
(Printer.print_finished_test):
(Printer._test_line):
(Printer.print_result):

  • Scripts/webkitpy/test/runner.py:

(Runner.run):

  • Scripts/webkitpy/test/runner_unittest.py:

(RunnerTest.setUp):
(RunnerTest):
(RunnerTest.tearDown):
(RunnerTest.assert_run):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):

2:13 PM Changeset in webkit [122763] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Layout Test svg/W3C-SVG-1.1/animate-elem-39-t.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=91421

This test is flaky (crashing) on the Win7 bot and has been for some time.

  • platform/chromium/TestExpectations:
2:11 PM Changeset in webkit [122762] by mihaip@chromium.org
  • 3 edits in branches/chromium/1180/Source/WebCore/inspector

Merge 120822 - Web Inspector: don't report context ids before DidCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=89567

Reviewed by Pavel Feldman.

When inspector state is restored only report existing context ids
if "did commit load" even has already been dispatched.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::restore):

  • inspector/PageRuntimeAgent.h:

(WebCore):
(WebCore::PageRuntimeAgent::create):
(PageRuntimeAgent):

TBR=yurys@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10779021

2:06 PM Changeset in webkit [122761] by Beth Dakin
  • 11 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=91299
Paginated views should restrict available height to column height
-and corresponding-
<rdar://problem/11152108>

Reviewed by Dan Bernstein.

Source/WebCore:

Now that RenderViews can have columns, availableLogicalHeight needs to consider
that column height, much like how availableLogicalWidth already considers column
width.

availableLogicalHeight is newly virtual, like the already-virtual
availableLogicalWidth.

  • rendering/RenderBox.h:

(RenderBox):

Check with the columnHeight.

  • rendering/RenderView.cpp:

(WebCore):
(WebCore::RenderView::availableLogicalHeight):

  • rendering/RenderView.h:

setPagination now takes pageLength as an optional parameter.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setPagination):

  • testing/InternalSettings.h:

(WebCore::InternalSettings::setPagination):
(InternalSettings):

  • testing/InternalSettings.idl:
  • testing/Internals.cpp:

(WebCore::Internals::setPagination):

  • testing/Internals.h:

(WebCore::Internals::setPagination):
(Internals):

  • testing/Internals.idl:

LayoutTests:

New test.

  • fast/multicol/resources/big-green.png: Added.
  • fast/multicol/shrink-to-column-height-for-pagination.html: Added.
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Added.
2:06 PM Changeset in webkit [122760] by Michelangelo De Simone
  • 2 edits in trunk/Websites/planet.webkit.org

Adobe Web Platform Team Blog is missing from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=91407

Reviewed by Andreas Kling.

Adding Adobe Web Platform Team Blog feed to Planet WebKit.

  • config.ini:
2:06 PM Changeset in webkit [122759] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: handle failures properly when running in parallel
https://bugs.webkit.org/show_bug.cgi?id=91416

Reviewed by Tony Chang.

It turns out that unittest.TestResults contain a handle to the
test method itself, which isn't picklable; it's sufficient to just
store the test name instead of the actual method. By doing so
we can move the test_name() method from the printer to the
runner where it belongs (so the printer is less dependent on the
unittest framework's data structures).

This change should really have a test but I don't know how to
write one that properly captures the behavior and won't cause
test-webkitpy itself to fail. I've verified the fix by hand, at
least, in the meantime.

  • Scripts/webkitpy/test/printer.py:

(Printer.init):
(Printer.print_result):

  • Scripts/webkitpy/test/runner.py:

(_test_name):
(Runner.all_test_names):
(_Worker.handle):

1:48 PM Changeset in webkit [122758] by scheib@chromium.org
  • 4 edits in trunk/LayoutTests

Fix Layout Test pointer-lock/locked-element-removed-from-dom.html flakiness.
https://bugs.webkit.org/show_bug.cgi?id=91373

Reviewed by Adrienne Walker.

pointer-lock-test-harness corrected to no longer silently allow too many
asynchronous doNextStep calls in a test. The locked-element-removed-from-dom test
generated too many events and incorrectly exited the test early.

  • platform/chromium/TestExpectations:

Re-enabled locked-element-removed-from-dom test.html

  • pointer-lock/locked-element-removed-from-dom.html:

Absorb extra doNextStep.

  • pointer-lock/resources/pointer-lock-test-harness.js:

(doNextStep.setTimeout):

Fail tests that call doNextStep too many times.

1:44 PM Changeset in webkit [122757] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Any webpage can crash webkit via qnx.callExtensionMethod assuming 'this' is the 'qnx' object.
https://bugs.webkit.org/show_bug.cgi?id=91419

Run the following in inspector to crash WebKit

qnx.callExtensionMethod.apply(window, []);

In the c++ that handles the function it assumes that when callExtensionMethod
is called that 'this' is the object 'qnx'. The qnx object has a hidden
variable that the code casts and uses, but when 'this' is not qnx such as the
example this will cause a crash. Any website can insert the above JavaScript
to cause the crash.

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-16
Reviewed by Yong Li.

  • WebCoreSupport/ClientExtension.cpp:

(clientExtensionMethod):

1:39 PM Changeset in webkit [122756] by danakj@chromium.org
  • 23 edits in trunk/Source

[chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into
https://bugs.webkit.org/show_bug.cgi?id=91288

Reviewed by Adrienne Walker.

Source/WebCore:

Always use pointers to layers when discussing render targets instead of
pointing directly to a RenderSurface.

Covered by existing tests.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::createRenderSurface):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::renderTarget):
(WebCore::LayerChromium::setRenderTarget):
(LayerChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::setTexturePriorities):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::createRenderSurface):
(WebCore::CCLayerImpl::dumpLayerProperties):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::renderTarget):
(WebCore::CCLayerImpl::setRenderTarget):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateLayerScissorRect):
(WebCore::calculateSurfaceScissorRect):
(WebCore::calculateVisibleContentRect):
(WebCore::computeScrollCompensationForThisLayer):
(WebCore::calculateDrawTransformsInternal):
(WebCore::pointIsClippedBySurfaceOrClipRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::enterLayer):
(WebCore::::leaveLayer):
(WebCore::::enterRenderTarget):
(WebCore::::finishedRenderTarget):
(WebCore):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::::leaveToRenderTarget):
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore::::layerScissorRectInTargetSurface):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::StackObject::StackObject):
(StackObject):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::appendSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:
  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):

  • tests/CCQuadCullerTest.cpp:
  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeTiledLayerChromium::setTexturePriorities):

  • tests/LayerChromiumTest.cpp:
1:31 PM Changeset in webkit [122755] by fmalita@chromium.org
  • 3 edits
    2 adds in trunk

SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326

Reviewed by Simon Fraser.

SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.

Source/WebCore:

Test: svg/animations/smil-setcurrenttime-crash.svg

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
  • svg/animations/smil-setcurrenttime-crash.svg: Added.
1:29 PM Changeset in webkit [122754] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Upstream WebGL Code
https://bugs.webkit.org/show_bug.cgi?id=91143

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-16
Reviewed by Rob Buis.

This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation.

Source/WebCore:

No new tests, because there is no new functionality.

  • platform/graphics/GraphicsContext3D.h: Add a value for TI Imagination chipsets on BlackBerry platforms
  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp: Multiple downstream changes

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore):
(WebCore::GraphicsContext3D::logFrameBufferStatus):
(WebCore::GraphicsContext3D::readPixelsIMG): BlackBerry-specific fix for Imagination hardware.
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):

  • platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary whitespace.

(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Hack to fix ANGLE-generated code on BlackBerry platforms.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.h:

(Extensions3DOpenGLCommon):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: I am not in a position to change system headers from correct to incorrect.

(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisample):
(WebCore::Extensions3DOpenGLES::supportsExtension):

  • platform/graphics/opengl/Extensions3DOpenGLES.h: I am not in a position to change system headers from correct to incorrect.

(Extensions3DOpenGLES):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Add a BlackBerry-specific anti-aliasing fix.

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore):

Source/WebKit:

  • PlatformBlackBerry.cmake: Define WTF_USE_OPENGL_ES_2 on WebGL-enabled builds.
1:06 PM Changeset in webkit [122753] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Add dfg switch to create_jit_stubs script
https://bugs.webkit.org/show_bug.cgi?id=91256

Reviewed by Geoffrey Garen.

  • create_jit_stubs: Add a switch to enable or disable the generation of

stub functions in #if ENABLE(DFG_JIT) conditions.

12:55 PM Changeset in webkit [122752] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Layout Test fast/frames/calculate-fixed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=91415

Has been intermittently failing TEXT since at least r122699.

  • platform/chromium/TestExpectations:
12:50 PM Changeset in webkit [122751] by enne@google.com
  • 1 edit
    3 copies in branches/chromium/1180

Merge 122529 - [chromium] Root invalidations for RTL pages need to be in the right space
https://bugs.webkit.org/show_bug.cgi?id=91155

Reviewed by Kenneth Russell.

Source/WebKit/chromium:

The root layer has a translation on it when placed in the tree, so any
invalidations on this layer likewise need to be adjusted.

This adjustment is due to the fact that compositor layers all have the
origin in the upper left corner of the layer, but this is not always
the origin for graphics layers. Rather than making compositor layers
have to deal with a potential offset, we change the transform when
inserting the layer into the tree. Invalidations need to be similarly
transformed from document space into compositor layer space.

The need for this offset is due to the definition of the initial
containing block. RTL pages (pages with dir=RTL on the body) start
scrolled all the way to the right, and the origin is in the upper left
hand corner of this initial viewport. Thus on RTL pages with
horizontal overflow, the left of the document is in negative CSS
space.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::invalidateRect):

LayoutTests:

Add a test that demonstrates this problem. Before the code fix, the
test shows just a red square because the invalidation for the style
change repaints the wrong rect.

  • compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
  • compositing/rtl/rtl-overflow-invalidation-expected.txt: Added.
  • compositing/rtl/rtl-overflow-invalidation.html: Added.

TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/10782018

12:37 PM Changeset in webkit [122750] by dpranke@chromium.org
  • 6 edits in trunk/Tools

test-webkitpy: run tests in parallel
https://bugs.webkit.org/show_bug.cgi?id=91294

Reviewed by Ojan Vafai.

This change adds support for running tests in parallel. This is
not yet on by default, since the logging isn't very pretty w/
parallel tests.

Also, there are some (multiprocessing-related) tests that can't be
run in parallel and so we skip them in that situation; I need to
come up with a mechanism for dealing with this, since you
apparently can't use multiprocessing as both a parent and a
child process.

  • Scripts/webkitpy/test/finder.py:

(Finder.find_names):
(Finder._default_names):

  • Scripts/webkitpy/test/main.py:

(Tester._parse_args):
(Tester.run):

  • Scripts/webkitpy/test/main_unittest.py:

(TesterTest.test_no_tests_found):

  • Scripts/webkitpy/test/runner.py:

(Runner.run):

  • Scripts/webkitpy/test/runner_unittest.py:

(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):

12:35 PM Changeset in webkit [122749] by dpranke@chromium.org
  • 4 edits in trunk/Tools

test-webkitpy: use message pools
https://bugs.webkit.org/show_bug.cgi?id=91292

Reviewed by Ojan Vafai.

Restructure the test-running code to be message-driven and
use a MessagePool; note that this does not yet actually run the
tests in parallel.

Also clean up the unit tests so that the fake loader is passed
to the _Worker properly, and reduce a lot of the cut&pasted code
in the tests.

No functional changes; covered by existing tests.

  • Scripts/webkitpy/test/printer.py:

(Printer.print_started_test):
(Printer.print_finished_test):

  • Scripts/webkitpy/test/runner.py:

(Runner.init):
(Runner.run):
(Runner.handle):
(_Worker):
(_Worker.init):
(_Worker.handle):

  • Scripts/webkitpy/test/runner_unittest.py:

(RunnerTest.assert_run):
(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest.test_timing):

12:32 PM Changeset in webkit [122748] by ojan@chromium.org
  • 6 edits
    7 adds in trunk/LayoutTests

Cleanup a bunch of invalid BUG* lines. Rebaseline tests that were straightfoward
rebaselines and update the expectations to match what's actually happening on the bots.

  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-mac/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
12:09 PM Changeset in webkit [122747] by tony@chromium.org
  • 7 edits
    2 adds in trunk

Position grid items by row/column index
https://bugs.webkit.org/show_bug.cgi?id=91293

Reviewed by Ojan Vafai.

Source/WebCore:

Do some initial grid positioning. Only handle the simple case where tracks are
fixed values and don't properly size the grid items. This gives us something to
work with and starts implementing the "Grid Track Sizing Algorithm":
http://dev.w3.org/csswg/css3-grid-layout/#grid-track-sizing-algorithm0

Test: fast/css-grid-layout/place-cell-by-index.html

  • rendering/RenderGrid.cpp:

(RenderGrid::GridTrack): Data structure for holding the track size. UsedBreadth matches the terminology
used in the spec.
(WebCore::RenderGrid::layoutBlock): Pull in some boiler plate code and put the
grid specific code in layoutGridItems.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Implement part of the grid track sizing algorithm.
(WebCore::RenderGrid::layoutGridItems): Compute the size of grid tracks, layout and position children.
(WebCore::RenderGrid::findChildLogicalPosition): Map track sizes to the actual position of the child.

  • rendering/RenderGrid.h:
  • rendering/style/RenderStyle.h: Just return a copy of Length rather than a reference to Length. This seems

more consistent with other getters that return a Length.

LayoutTests:

Add a test for grid layout in each writing mode direction. The height in vertical writing mode is incorrect for now.

  • fast/css-grid-layout/containing-block-grids-expected.html: Scope <p> around text only.
  • fast/css-grid-layout/containing-block-grids.html: Fix missing closing </div>.
  • fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
  • fast/css-grid-layout/place-cell-by-index.html: Added.
12:06 PM Changeset in webkit [122746] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Only apply page scale delta to root scroll layer
https://bugs.webkit.org/show_bug.cgi?id=91374

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-07-16
Reviewed by Adrienne Walker.

Source/WebCore:

When the user pinch-zooms the web page though the Chromium compositor, the
per-layer page scale delta is used to keep track of the difference between the
page scale on the compositor thread versus the main thread. On the next
commit to the main thread these values are reset to 1.

When calculating layer positions, the compositor applies a layer's page scale
delta both to the layer itself as well as all of its children. Since we are
currently updating the page scale delta on all scrollable layers, this results
in scrollable child layers getting scaled multiple times.

This patch changes the compositor to only apply the page scale delta on the
root scroll layer.

New unit test: CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):

Source/WebKit/chromium:

New unit test
CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly to verify
the transformation of child layer while pinch zooming.

  • tests/CCLayerTreeHostImplTest.cpp:
11:59 AM Changeset in webkit [122745] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve about:memory page
https://bugs.webkit.org/show_bug.cgi?id=87676

Patch by Yong Li <yoli@rim.com> on 2012-07-16
Reviewed by Rob Buis.

Add a table for process memory usage summary for easy read.

  • WebCoreSupport/AboutData.cpp:

(WebCore::memoryPage):

11:40 AM Changeset in webkit [122744] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Use newer version of platform API to implement callOnMainThread
https://bugs.webkit.org/show_bug.cgi?id=91404

Patch by Adam Treat <atreat@rim.com> on 2012-07-16
Reviewed by Yong Li.

Right now we're using an outdated API that involves a virtual function call for no reason.
Use the new API that is much more direct and to the point.

  • wtf/blackberry/MainThreadBlackBerry.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

11:28 AM Changeset in webkit [122743] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Remove setController from BatteryClient
https://bugs.webkit.org/show_bug.cgi?id=90944

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-16
Reviewed by Adam Barth.

Source/WebCore:

BatteryClient doesn't need to keep m_controller,
because BatteryController can be accessed using BatteryController::from().
Remove BatteryClient::setController function.

No new tests. Covered by existing tests.

  • Modules/battery/BatteryClient.h:
  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::BatteryController):

Source/WebKit/blackberry:

BatteryClient doesn't need to keep m_controller,
because BatteryController can be accessed using BatteryController::from().
Remove m_controller and Add webPagePrivate to BatteryClientBlackBerry.
And change all m_controller to BatteryController::from.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/BatteryClientBlackBerry.cpp:

(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::onLevelChange):
(WebCore::BatteryClientBlackBerry::onChargingChange):
(WebCore::BatteryClientBlackBerry::onChargingTimeChange):
(WebCore::BatteryClientBlackBerry::onDischargingTimeChange):

  • WebCoreSupport/BatteryClientBlackBerry.h:

(BatteryClientBlackBerry):

Source/WebKit/chromium:

Remove virtual identifier from setController because setController is removed from WebCore::BatteryClient.
In addition, BatteryController is set to instance of BatteryClientImpl in the constructor of WebViewImpl.

  • src/BatteryClientImpl.h:

(BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/efl:

BatteryClient doesn't need to keep m_controller,
because BatteryController can be accessed using BatteryController::from().
Remove m_controller and Add ewk view evas object to BatteryClientEfl.
And change all m_controller to BatteryController::from.

  • WebCoreSupport/BatteryClientEfl.cpp:

(BatteryClientEfl::BatteryClientEfl):
(BatteryClientEfl::didChangeBatteryStatus):

  • WebCoreSupport/BatteryClientEfl.h:

(BatteryClientEfl):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit2:

Remove WebBatteryClient::setController function.

  • WebProcess/WebCoreSupport/WebBatteryClient.cpp:
  • WebProcess/WebCoreSupport/WebBatteryClient.h:

(WebBatteryClient):

11:21 AM Changeset in webkit [122742] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Make Ewk_Navigation_Policy_Decision ref counted
https://bugs.webkit.org/show_bug.cgi?id=91343

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-16
Reviewed by Antonio Gomes.

Make Ewk_Navigation_Policy_Decision ref counted so that the
client can make navigation policy decisions asynchronously
by ref'ing the Ewk_Navigation_Policy_Decision object passed
with the "policy,*" signals.

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_ref):
(ewk_navigation_policy_decision_unref):

  • UIProcess/API/efl/ewk_navigation_policy_decision.h:
  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_policy_client.cpp:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):

11:16 AM Changeset in webkit [122741] by commit-queue@webkit.org
  • 3 edits
    2 adds
    4 deletes in trunk

Invalid script-nonce directives should block script execution.
https://bugs.webkit.org/show_bug.cgi?id=91353

Patch by Mike West <mkwst@chromium.org> on 2012-07-16
Reviewed by Adam Barth.

Source/WebCore:

If the script-nonce Content Security Policy directive contains an
invalid value, we should fail loudly, throwing a warning to the console
and denying execution of script on the page. The is in line with the
current state of the experimental CSP 1.1 Editors Draft[1].

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-nonce--experimental

Test: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkNonceAndReportViolation):

Check against null rather than empty for early exit, otherwise
only compare nonces if the stored nonce isn't empty.

(WebCore::CSPDirectiveList::parseScriptNonce):

Assign the empty string if nonce is invalid.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html: Removed.
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html: Removed.

Replaced these two tests with the following.

  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html: Added.

This tests variously invalid nonces to ensure they block execution.

11:14 AM Changeset in webkit [122740] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Android] remove RenderThemeChromiumAndroid::paintMediaFullscreenButton()
https://bugs.webkit.org/show_bug.cgi?id=91291

Patch by Min Qin <qinmin@chromium.org> on 2012-07-16
Reviewed by Adam Barth.

The recent media control refactoring added paintMediaFullscreenButton() in RenderThemeChromiumSkia.
Since RenderThemeChromiumAndroid inherits from that class, we don't need to redefine this function.
No test needed as this change just removes an unnecessary override.

  • rendering/RenderThemeChromiumAndroid.cpp:
  • rendering/RenderThemeChromiumAndroid.h:
11:10 AM Changeset in webkit [122739] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: fix output write logic to support incremental build
https://bugs.webkit.org/show_bug.cgi?id=90642

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-07-16
Reviewed by Yury Semikhatsky.

A small intermediate writer is added. It handles comparing old and new source before actual writing.

  • inspector/CodeGeneratorInspector.py:

(flatten_list):
(SmartOutput):
(SmartOutput.init):
(SmartOutput.write):
(SmartOutput.close):

11:04 AM Changeset in webkit [122738] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Layout Test storage/indexeddb/cursor-update-value-argument-required.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=91403

This test crashes occasionally, not sure how long it has been flaky.

  • platform/chromium/TestExpectations:
11:01 AM Changeset in webkit [122737] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Incorrect assertion: Replicas will cause a RenderPass to be removed twice
https://bugs.webkit.org/show_bug.cgi?id=91328

Reviewed by Adrienne Walker.

Source/WebCore:

We asserted that we would never attempt to remove a render pass that had
already been removed. This was incorrect as a surface with a replica has
two quads and both may cause us to attempt its removal. We must handle
this case gracefully.

Test: CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):

Source/WebKit/chromium:

Add replicas to the surfaces in the test.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest):
(CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit):

10:56 AM UsingGitWithWebKit edited by dbates@webkit.org
Remove extraneous word "this" to make the sentence read well. (diff)
10:51 AM Changeset in webkit [122736] by kbalazs@webkit.org
  • 76 edits in trunk/LayoutTests

[Qt] platform/qt/editing/execCommand tests update after the font change.
https://bugs.webkit.org/show_bug.cgi?id=91246.

Unreviewed rebaseline.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/editing/execCommand/4580583-1-expected.png:
  • platform/qt/editing/execCommand/4580583-1-expected.txt:
  • platform/qt/editing/execCommand/4580583-2-expected.png:
  • platform/qt/editing/execCommand/4580583-2-expected.txt:
  • platform/qt/editing/execCommand/4641880-1-expected.png:
  • platform/qt/editing/execCommand/4641880-1-expected.txt:
  • platform/qt/editing/execCommand/4641880-2-expected.png:
  • platform/qt/editing/execCommand/4641880-2-expected.txt:
  • platform/qt/editing/execCommand/4747450-expected.png:
  • platform/qt/editing/execCommand/4747450-expected.txt:
  • platform/qt/editing/execCommand/4916402-expected.png:
  • platform/qt/editing/execCommand/4916402-expected.txt:
  • platform/qt/editing/execCommand/4916541-expected.png:
  • platform/qt/editing/execCommand/4916541-expected.txt:
  • platform/qt/editing/execCommand/4924441-expected.png:
  • platform/qt/editing/execCommand/4924441-expected.txt:
  • platform/qt/editing/execCommand/5080333-1-expected.png:
  • platform/qt/editing/execCommand/5080333-1-expected.txt:
  • platform/qt/editing/execCommand/5080333-2-expected.png:
  • platform/qt/editing/execCommand/5080333-2-expected.txt:
  • platform/qt/editing/execCommand/5136770-expected.png:
  • platform/qt/editing/execCommand/5136770-expected.txt:
  • platform/qt/editing/execCommand/5138441-expected.png:
  • platform/qt/editing/execCommand/5138441-expected.txt:
  • platform/qt/editing/execCommand/5142012-1-expected.png:
  • platform/qt/editing/execCommand/5142012-1-expected.txt:
  • platform/qt/editing/execCommand/5142012-2-expected.png:
  • platform/qt/editing/execCommand/5142012-2-expected.txt:
  • platform/qt/editing/execCommand/5190926-expected.png:
  • platform/qt/editing/execCommand/5190926-expected.txt:
  • platform/qt/editing/execCommand/5481523-expected.png:
  • platform/qt/editing/execCommand/5481523-expected.txt:
  • platform/qt/editing/execCommand/5482023-expected.png:
  • platform/qt/editing/execCommand/5482023-expected.txt:
  • platform/qt/editing/execCommand/5569741-expected.png:
  • platform/qt/editing/execCommand/5569741-expected.txt:
  • platform/qt/editing/execCommand/create-list-with-hr-expected.png:
  • platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/qt/editing/execCommand/find-after-replace-expected.png:
  • platform/qt/editing/execCommand/find-after-replace-expected.txt:
  • platform/qt/editing/execCommand/findString-2-expected.png:
  • platform/qt/editing/execCommand/findString-2-expected.txt:
  • platform/qt/editing/execCommand/findString-expected.png:
  • platform/qt/editing/execCommand/findString-expected.txt:
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.png:
  • platform/qt/editing/execCommand/format-block-with-trailing-br-expected.txt:
  • platform/qt/editing/execCommand/indent-empty-root-expected.png:
  • platform/qt/editing/execCommand/indent-empty-root-expected.txt:
  • platform/qt/editing/execCommand/indent-list-item-expected.png:
  • platform/qt/editing/execCommand/indent-list-item-expected.txt:
  • platform/qt/editing/execCommand/indent-selection-expected.png:
  • platform/qt/editing/execCommand/indent-selection-expected.txt:
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/qt/editing/execCommand/insert-list-and-stitch-expected.txt:
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/qt/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/qt/editing/execCommand/insertImage-expected.png:
  • platform/qt/editing/execCommand/insertImage-expected.txt:
  • platform/qt/editing/execCommand/nsresponder-indent-expected.png:
  • platform/qt/editing/execCommand/nsresponder-indent-expected.txt:
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
  • platform/qt/editing/execCommand/nsresponder-outdent-expected.txt:
  • platform/qt/editing/execCommand/paste-1-expected.png:
  • platform/qt/editing/execCommand/paste-1-expected.txt:
  • platform/qt/editing/execCommand/paste-2-expected.png:
  • platform/qt/editing/execCommand/paste-2-expected.txt:
  • platform/qt/editing/execCommand/print-expected.png:
  • platform/qt/editing/execCommand/print-expected.txt:
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.png:
  • platform/qt/editing/execCommand/remove-list-from-range-selection-expected.txt:
  • platform/qt/editing/execCommand/remove-list-item-1-expected.png:
  • platform/qt/editing/execCommand/remove-list-item-1-expected.txt:
  • platform/qt/editing/execCommand/selectAll-expected.png:
  • platform/qt/editing/execCommand/selectAll-expected.txt:
9:23 AM Changeset in webkit [122735] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: native memory: fix instrumentation for string members
https://bugs.webkit.org/show_bug.cgi?id=91384

Reviewed by Pavel Feldman.

It was possible to report a string member via addMember instead of addString.
This patch is fixing the problem and adding a link time guard.

Covered by existing inspector performance tests infrastructure.

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(WebCore):
(WebCore::MemoryClassInfo::addString):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):

9:16 AM Changeset in webkit [122734] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix after r122729. Typo fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::add32):

8:49 AM Changeset in webkit [122733] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

jquery/manipulation.html times out in release too.

  • platform/chromium/TestExpectations:
8:39 AM Changeset in webkit [122732] by kbalazs@webkit.org
  • 2 edits
    2 copies
    14 moves
    4 adds
    1 delete in trunk/LayoutTests

[Qt] remaining compositing tests after rebaseline for new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91377

Unreviewed rebaseline.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.txt: Removed.
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt.
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt.
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt.
  • platform/qt/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.png.
  • platform/qt/compositing/geometry/composited-html-size-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.txt.
  • platform/qt/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-in-columns-expected.txt.
  • platform/qt/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
  • platform/qt/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt.
  • platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/qt/compositing/iframes/composited-iframe-scroll-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
  • platform/qt/compositing/iframes/composited-iframe-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/composited-iframe-scroll-expected.txt.
  • platform/qt/compositing/iframes/iframe-content-flipping-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.png.
  • platform/qt/compositing/iframes/iframe-content-flipping-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/iframe-content-flipping-expected.txt.
  • platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt.
  • platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
  • platform/qt/compositing/overflow/theme-affects-visual-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.png.
  • platform/qt/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
8:28 AM Changeset in webkit [122731] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix Qt5 module dependencies
https://bugs.webkit.org/show_bug.cgi?id=91388

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-16
Reviewed by Laszlo Gombos.

Removed ancient qtscript and qtxmlpatterns module dependencies.

  • qmake/qt_webkit.pri:
8:25 AM Changeset in webkit [122730] by reed@google.com
  • 2 edits in trunk/LayoutTests

Update expectations : rebaseline images after skia 4600 lands
https://bugs.webkit.org/show_bug.cgi?id=91392

Reviewed by NOBODY : expectations change only

  • platform/chromium/TestExpectations:
8:05 AM Changeset in webkit [122729] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix from Zoltan Herczeg after r122677.
Implement missing add32 function to MacroAssemblerARM.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::add32):
(MacroAssemblerARM):

7:56 AM Changeset in webkit [122728] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-webkit-test returns 254 at exit even when it succeeds
https://bugs.webkit.org/show_bug.cgi?id=91370

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-16
Reviewed by Simon Hausmann.

sys.exit() is implemented by raising SystemExit which inherits from
BaseException. Since we are catching BaseException, run_webkit_tests.py
was always returning an error code.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:56 AM Changeset in webkit [122727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix inconsistent DLL linkage on Windows with WebKit1
https://bugs.webkit.org/show_bug.cgi?id=91375

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-16
Reviewed by Laszlo Gombos.

Export QWebHistoryItemPrivate as required for tests. Unfortunately we cannot use
Q_AUTOTEST_EXPORT outside of Qt.

  • Api/qwebhistory_p.h:
7:56 AM Changeset in webkit [122726] by zoltan@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed. Remove unnecessary executable bits after r122720.

  • platform/graphics/ImageSource.h:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/qt/ImageDecoderQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/qt/StillImageQt.h:
  • platform/graphics/qt/TransparencyLayer.h:
7:54 AM Changeset in webkit [122725] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Text selection with touch hold does not start on text field in some cases
https://bugs.webkit.org/show_bug.cgi?id=91267

Patch by Yongxin Dai <yodai@rim.com> on 2012-07-16
Reviewed by Antonio Gomes.

Input fields host node is by spec non-editable unless the field itself has content editable enabled.
We enable selection if the shadow tree for the input field is selectable.
PR # 173450

Reviewed Internally by Mike Fenton.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

7:50 AM Changeset in webkit [122724] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION (r122720): svg/filters/feSpecularLight-premultiplied.svg
https://bugs.webkit.org/show_bug.cgi?id=91390

Unreviewed gardening.

Skip until proper fix.

  • platform/qt/Skipped: Add the test to the skiplist
7:31 AM Changeset in webkit [122723] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Fix TestExpectations after r122718.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-16

  • platform/qt/TestExpectations:
7:29 AM Changeset in webkit [122722] by kbalazs@webkit.org
  • 4 edits
    24 moves
    95 adds
    70 deletes in trunk/LayoutTests

[Qt] compositing tests need rebaseline with new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91234

Unreviewed rebaseline.

Rebaseline compositing tests. Move expectations from qt-5.0-wk2 to qt because these
results should not vary across Qt versions. Co-authored with Csaba Osztrogonác. Some
tests were produced uncorrect result, I keep skipped them and filed
https://bugs.webkit.org/show_bug.cgi?id=91377. Compositing tests are still skipped on
qt-4.8 and qt-5.0-wk1.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/generated-content-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/generated-content-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/masked-reflection-on-composited-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-mask-change-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-in-composited-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.txt: Removed.
  • platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.txt: Removed.
  • platform/qt/animations/3d/change-transform-in-end-event-expected.txt: Removed.
  • platform/qt/animations/3d/state-at-end-event-transform-expected.png: Added.
  • platform/qt/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/qt/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
  • platform/qt/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/qt/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/qt/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/qt/compositing/color-matching/pdf-image-match-expected.txt: Added.
  • platform/qt/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/qt/compositing/compositing-visible-descendant-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.txt.
  • platform/qt/compositing/direct-image-compositing-expected.png: Added.
  • platform/qt/compositing/direct-image-compositing-expected.txt: Added.
  • platform/qt/compositing/generated-content-expected.png: Added.
  • platform/qt/compositing/generated-content-expected.txt: Added.
  • platform/qt/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/qt/compositing/geometry/abs-position-inside-opacity-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.txt.
  • platform/qt/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/qt/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/qt/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/qt/compositing/geometry/fixed-in-composited-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.txt.
  • platform/qt/compositing/geometry/fixed-position-expected.png: Added.
  • platform/qt/compositing/geometry/fixed-position-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.txt.
  • platform/qt/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/qt/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.txt.
  • platform/qt/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/qt/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/qt/compositing/geometry/outline-change-expected.png: Added.
  • platform/qt/compositing/geometry/outline-change-expected.txt: Added.
  • platform/qt/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/qt/compositing/geometry/partial-layout-update-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.txt.
  • platform/qt/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/qt/compositing/geometry/root-layer-update-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.txt.
  • platform/qt/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/qt/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt.
  • platform/qt/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/qt/compositing/geometry/video-fixed-scrolling-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.txt.
  • platform/qt/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/qt/compositing/iframes/composited-iframe-alignment-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.txt.
  • platform/qt/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/qt/compositing/iframes/iframe-copy-on-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.txt.
  • platform/qt/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/qt/compositing/images/direct-image-background-color-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.txt.
  • platform/qt/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/qt/compositing/masks/direct-image-mask-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.txt.
  • platform/qt/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/qt/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/qt/compositing/masks/multiple-masks-expected.png: Added.
  • platform/qt/compositing/masks/multiple-masks-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.txt.
  • platform/qt/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/qt/compositing/masks/simple-composited-mask-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.txt.
  • platform/qt/compositing/overflow/ancestor-overflow-expected.png:
  • platform/qt/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/qt/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/qt/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.txt.
  • platform/qt/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/qt/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
  • platform/qt/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/qt/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/qt/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/qt/compositing/overflow/overflow-scroll-expected.txt: Added.
  • platform/qt/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/qt/compositing/overflow/parent-overflow-expected.txt: Added.
  • platform/qt/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/qt/compositing/overflow/scroll-ancestor-update-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.txt.
  • platform/qt/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/qt/compositing/overflow/scrollbar-painting-expected.txt: Added.
  • platform/qt/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/qt/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
  • platform/qt/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/qt/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
  • platform/qt/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/qt/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
  • platform/qt/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/qt/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
  • platform/qt/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/qt/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
  • platform/qt/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/qt/compositing/reflections/reflection-in-composited-expected.txt: Added.
  • platform/qt/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/qt/compositing/reflections/reflection-on-composited-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/reflection-on-composited-expected.txt.
  • platform/qt/compositing/reflections/reflection-opacity-expected.png: Added.
  • platform/qt/compositing/reflections/reflection-opacity-expected.txt: Added.
  • platform/qt/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/qt/compositing/reflections/reflection-ordering-expected.txt: Added.
  • platform/qt/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/qt/compositing/reflections/reflection-positioning-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.txt.
  • platform/qt/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/qt/compositing/reflections/reflection-positioning2-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.txt.
  • platform/qt/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/qt/compositing/reflections/simple-composited-reflections-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.txt.
  • platform/qt/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
  • platform/qt/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
  • platform/qt/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/qt/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/qt/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/qt/compositing/repaint/layer-repaint-expected.txt: Added.
  • platform/qt/compositing/repaint/layer-repaint-rects-expected.png: Added.
  • platform/qt/compositing/repaint/layer-repaint-rects-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.txt.
  • platform/qt/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/qt/compositing/repaint/opacity-between-absolute-expected.txt: Added.
  • platform/qt/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/qt/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
  • platform/qt/compositing/self-painting-layers-expected.png: Added.
  • platform/qt/compositing/self-painting-layers-expected.txt: Added.
  • platform/qt/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/qt/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/qt/compositing/sibling-positioning-expected.png: Added.
  • platform/qt/compositing/sibling-positioning-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/sibling-positioning-expected.txt.
  • platform/qt/compositing/text-on-large-layer-expected.png: Added.
  • platform/qt/compositing/text-on-large-layer-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.txt.
  • platform/qt/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/qt/compositing/transitions/scale-transition-no-start-expected.txt: Added.
  • platform/qt/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/qt/compositing/transitions/singular-scale-transition-expected.txt: Added.
7:08 AM Changeset in webkit [122721] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91386

  • platform/chromium/TestExpectations:
6:50 AM Changeset in webkit [122720] by zoltan@webkit.org
  • 35 edits
    1 copy in trunk/Source

[Qt] Change NativeImagePtr from QPixmap* to QImage*
https://bugs.webkit.org/show_bug.cgi?id=88785

Reviewed by Simon Hausmann.

Since we use raster engine there is no difference between QPixmap and QImage, so we are going
to use QImage everywhere where it is possible. This refactoring contains the change of the
NativeImagePtr typedef from QPixmap* to QImage* and covers the related modifications.

Part of the change is similar to Viatcheslav Ostapenko's internal work.

Covered by existing tests.

Source/WebCore:

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapAssignToElementMethod::invoke):
(JSC::Bindings::QtPixmapInstance::variantFromObject):

  • platform/DragImage.h:

(WebCore):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:

(ImageGStreamer::ImageGStreamer):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::pushTransparencyLayerInternal):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):

  • platform/graphics/qt/ImageBufferDataQt.h:

(ImageBufferData):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageFrame::asNewNativeImage):

  • platform/graphics/qt/ImageQt.cpp:

(graphics):
(loadResourceImage):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::setPlatformResource):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::create):

  • platform/graphics/qt/NativeImageQt.h: Added.

(WebCore):
(NativeImageQt):
(WebCore::NativeImageQt::defaultFormatForAlphaEnabledImages):
(WebCore::NativeImageQt::defaultFormatForOpaqueImages):

  • platform/graphics/qt/PatternQt.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::StillImage):
(WebCore::StillImage::~StillImage):
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore::StillImage::size):
(WebCore::StillImage::nativeImageForCurrentFrame):
(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(WebCore::StillImage::create):
(WebCore::StillImage::createForRendering):
(StillImage):

  • platform/graphics/qt/TransparencyLayer.h:

(WebCore::TransparencyLayer::TransparencyLayer):
(TransparencyLayer):

  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::createDragImage):
(WebCore::ClipboardQt::declareAndWriteDragImage):

  • platform/qt/CursorQt.cpp:

(WebCore::createCustomCursor):

  • platform/qt/DragImageQt.cpp:

(WebCore::createDragImageFromImage):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeImage):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):
(QWebSettings::setWebGraphic):
(QWebSettings::webGraphic):

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

Source/WebKit2:

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createImage):

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::convertQImageToShareableBitmap):
(WebKit::WebDragClient::startDrag):

  • WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::adoptImageBackingStore):

6:44 AM Changeset in webkit [122719] by kbalazs@webkit.org
  • 762 edits in trunk/LayoutTests

[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242

Unreviewed rebaseline.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-16

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/layering/paint-test-layering-1-expected.png:
  • platform/qt/tables/layering/paint-test-layering-1-expected.txt:
  • platform/qt/tables/layering/paint-test-layering-2-expected.png:
  • platform/qt/tables/layering/paint-test-layering-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/45621-expected.png:
  • platform/qt/tables/mozilla/bugs/45621-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10009-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10009-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug100334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug100334-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10036-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10036-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10039-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10039-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug101201-expected.png:
  • platform/qt/tables/mozilla/bugs/bug101201-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug101674-expected.png:
  • platform/qt/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10269-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1055-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10565-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10565-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug106158-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug106158-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug106158-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug106158-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug10633-expected.png:
  • platform/qt/tables/mozilla/bugs/bug10633-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug106816-expected.png:
  • platform/qt/tables/mozilla/bugs/bug106816-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug108340-expected.png:
  • platform/qt/tables/mozilla/bugs/bug108340-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug109043-expected.png:
  • platform/qt/tables/mozilla/bugs/bug109043-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11026-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11026-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug110566-expected.png:
  • platform/qt/tables/mozilla/bugs/bug110566-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113424-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113424-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11384q-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11384q-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11384s-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11384s-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug11944-expected.png:
  • platform/qt/tables/mozilla/bugs/bug11944-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.png:
  • platform/qt/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug12008-expected.png:
  • platform/qt/tables/mozilla/bugs/bug12008-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug120364-expected.png:
  • platform/qt/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1220-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1220-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1224-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1224-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug12268-expected.png:
  • platform/qt/tables/mozilla/bugs/bug12268-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug123862-expected.png:
  • platform/qt/tables/mozilla/bugs/bug123862-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1261-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1261-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug126742-expected.png:
  • platform/qt/tables/mozilla/bugs/bug126742-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug12709-expected.png:
  • platform/qt/tables/mozilla/bugs/bug12709-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug127267-expected.png:
  • platform/qt/tables/mozilla/bugs/bug127267-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug128229-expected.png:
  • platform/qt/tables/mozilla/bugs/bug128229-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug12908-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug12908-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug12910-expected.png:
  • platform/qt/tables/mozilla/bugs/bug12910-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1296-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1296-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug131020-expected.png:
  • platform/qt/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug13105-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13105-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug13118-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13118-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug13196-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13196-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug133756-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug13484-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13484-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug13526-expected.png:
  • platform/qt/tables/mozilla/bugs/bug13526-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug138725-expected.png:
  • platform/qt/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug139524-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug139524-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug139524-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug139524-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug139524-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug139524-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug139524-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug139524-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug14159-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14159-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug14159-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14159-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1430-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1430-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug14323-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14323-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug145572-expected.png:
  • platform/qt/tables/mozilla/bugs/bug145572-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1474-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1474-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug149275-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug149275-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug149275-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug14929-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14929-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug15247-expected.png:
  • platform/qt/tables/mozilla/bugs/bug15247-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug15544-expected.png:
  • platform/qt/tables/mozilla/bugs/bug15544-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug157890-expected.png:
  • platform/qt/tables/mozilla/bugs/bug157890-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug159108-expected.png:
  • platform/qt/tables/mozilla/bugs/bug159108-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug16012-expected.png:
  • platform/qt/tables/mozilla/bugs/bug16012-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.png:
  • platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug17130-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17130-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug17130-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17130-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug17138-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17138-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug17168-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17168-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug175455-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug175455-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug17548-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug17587-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17587-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1800-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1800-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1802-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1802-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1802s-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1802s-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1809-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1809-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1818-5-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1818-5-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1828-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1828-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18440-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18440-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18558-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18558-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18664-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18664-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18955-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18955-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug19061-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19061-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug19061-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19061-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug19356-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19356-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug194024-expected.png:
  • platform/qt/tables/mozilla/bugs/bug194024-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug19599-expected.png:
  • platform/qt/tables/mozilla/bugs/bug19599-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2050-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2050-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug20579-expected.png:
  • platform/qt/tables/mozilla/bugs/bug20579-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2065-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2065-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug20804-expected.png:
  • platform/qt/tables/mozilla/bugs/bug20804-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug21299-expected.png:
  • platform/qt/tables/mozilla/bugs/bug21299-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug215629-expected.png:
  • platform/qt/tables/mozilla/bugs/bug215629-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug21918-expected.png:
  • platform/qt/tables/mozilla/bugs/bug21918-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22019-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22019-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug220536-expected.png:
  • platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22246-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22246-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22246-2a-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22246-2a-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22246-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22246-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug22246-3a-expected.png:
  • platform/qt/tables/mozilla/bugs/bug22246-3a-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.png:
  • platform/qt/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2267-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2267-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug227123-expected.png:
  • platform/qt/tables/mozilla/bugs/bug227123-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2296-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2296-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23151-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23235-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23235-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug23299-expected.png:
  • platform/qt/tables/mozilla/bugs/bug23299-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24503-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24503-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24627-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24627-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24661-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24661-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2469-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2469-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug24880-expected.png:
  • platform/qt/tables/mozilla/bugs/bug24880-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25004-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25004-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25086-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25086-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2509-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2509-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2516-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug25663-expected.png:
  • platform/qt/tables/mozilla/bugs/bug25663-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2585-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2585-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug26178-expected.png:
  • platform/qt/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2684-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2684-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug275625-expected.png:
  • platform/qt/tables/mozilla/bugs/bug275625-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2757-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2757-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2763-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2763-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2773-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2773-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug278266-expected.png:
  • platform/qt/tables/mozilla/bugs/bug278266-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug278385-expected.png:
  • platform/qt/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27993-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27993-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28341-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28341-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2886-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2886-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2886-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2886-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29058-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29058-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29157-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29429-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29429-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2962-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2962-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2973-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2973-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2981-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2981-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2981-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2997-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2997-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30273-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30273-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30332-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30332-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30332-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30332-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30418-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30418-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30559-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30692-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug30985-expected.png:
  • platform/qt/tables/mozilla/bugs/bug30985-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3103-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3103-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3191-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3191-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32205-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32205-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32205-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32205-5-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32205-5-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3260-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3260-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3263-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3263-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug32841-expected.png:
  • platform/qt/tables/mozilla/bugs/bug32841-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3309-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3309-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug33137-expected.png:
  • platform/qt/tables/mozilla/bugs/bug33137-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.png:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug34176-expected.png:
  • platform/qt/tables/mozilla/bugs/bug34176-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3454-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3454-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug35662-expected.png:
  • platform/qt/tables/mozilla/bugs/bug35662-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3681-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3681-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3681-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3681-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3718-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3718-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug38916-expected.png:
  • platform/qt/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug39209-expected.png:
  • platform/qt/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug3977-expected.png:
  • platform/qt/tables/mozilla/bugs/bug3977-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug40828-expected.png:
  • platform/qt/tables/mozilla/bugs/bug40828-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4093-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4093-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug41890-expected.png:
  • platform/qt/tables/mozilla/bugs/bug41890-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug42187-expected.png:
  • platform/qt/tables/mozilla/bugs/bug42187-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug42443-expected.png:
  • platform/qt/tables/mozilla/bugs/bug42443-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4284-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4284-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43039-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43204-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43204-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4385-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4385-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug43854-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug43854-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4427-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4427-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4429-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44523-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44523-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4501-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4501-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45055-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug45055-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45055-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4520-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4520-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug45486-expected.png:
  • platform/qt/tables/mozilla/bugs/bug45486-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4576-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4576-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46268-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46268-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46268-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46268-5-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-5-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46268-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46268-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46480-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46480-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46623-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46623-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46924-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46924-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46944-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46944-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4739-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4739-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug47432-expected.png:
  • platform/qt/tables/mozilla/bugs/bug47432-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4803-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4803-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4849-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4849-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4849-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4849-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug48827-expected.png:
  • platform/qt/tables/mozilla/bugs/bug48827-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug50695-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51727-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug52505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug52506-expected.png:
  • platform/qt/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug53891-expected.png:
  • platform/qt/tables/mozilla/bugs/bug53891-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug54450-expected.png:
  • platform/qt/tables/mozilla/bugs/bug54450-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5538-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5538-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug55694-expected.png:
  • platform/qt/tables/mozilla/bugs/bug55694-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug56563-expected.png:
  • platform/qt/tables/mozilla/bugs/bug56563-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57300-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57300-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57378-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57378-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug57828-expected.png:
  • platform/qt/tables/mozilla/bugs/bug57828-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5797-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5798-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5798-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5799-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5799-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5835-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5835-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.png:
  • platform/qt/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug58402-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug58402-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.png:
  • platform/qt/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug60013-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60013-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug60749-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug60804-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60804-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug60807-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60807-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug60992-expected.png:
  • platform/qt/tables/mozilla/bugs/bug60992-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug6184-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6184-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug625-expected.png:
  • platform/qt/tables/mozilla/bugs/bug625-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug63785-expected.png:
  • platform/qt/tables/mozilla/bugs/bug63785-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug6404-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6404-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug647-expected.png:
  • platform/qt/tables/mozilla/bugs/bug647-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug650-expected.png:
  • platform/qt/tables/mozilla/bugs/bug650-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug6674-expected.png:
  • platform/qt/tables/mozilla/bugs/bug6674-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug67864-expected.png:
  • platform/qt/tables/mozilla/bugs/bug67864-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug67915-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug68912-expected.png:
  • platform/qt/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug68998-expected.png:
  • platform/qt/tables/mozilla/bugs/bug68998-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug69187-expected.png:
  • platform/qt/tables/mozilla/bugs/bug69187-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug69382-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug69382-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug69382-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug69382-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug709-expected.png:
  • platform/qt/tables/mozilla/bugs/bug709-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7112-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7112-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7121-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7121-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug72359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug727-expected.png:
  • platform/qt/tables/mozilla/bugs/bug727-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug73321-expected.png:
  • platform/qt/tables/mozilla/bugs/bug73321-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7471-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7471-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug75250-expected.png:
  • platform/qt/tables/mozilla/bugs/bug75250-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7714-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug78162-expected.png:
  • platform/qt/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8032-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8032-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug80762-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug80762-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug81934-expected.png:
  • platform/qt/tables/mozilla/bugs/bug81934-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug82946-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug82946-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug82946-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug83786-expected.png:
  • platform/qt/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8411-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8411-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug86220-expected.png:
  • platform/qt/tables/mozilla/bugs/bug86220-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug86708-expected.png:
  • platform/qt/tables/mozilla/bugs/bug86708-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug88035-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug88035-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug88035-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug88035-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8858-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8858-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.png:
  • platform/qt/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9123-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9123-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9123-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9123-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92143-expected.png:
  • platform/qt/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9271-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9271-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug92868-expected.png:
  • platform/qt/tables/mozilla/bugs/bug92868-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug93363-expected.png:
  • platform/qt/tables/mozilla/bugs/bug93363-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug963-expected.png:
  • platform/qt/tables/mozilla/bugs/bug963-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96343-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug965-expected.png:
  • platform/qt/tables/mozilla/bugs/bug965-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug97138-expected.png:
  • platform/qt/tables/mozilla/bugs/bug97138-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug9879-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug9879-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug99923-expected.png:
  • platform/qt/tables/mozilla/bugs/bug99923-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug127040-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug127040-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.txt:
  • platform/qt/tables/mozilla/core/borders-expected.png:
  • platform/qt/tables/mozilla/core/borders-expected.txt:
  • platform/qt/tables/mozilla/core/box_sizing-expected.png:
  • platform/qt/tables/mozilla/core/box_sizing-expected.txt:
  • platform/qt/tables/mozilla/core/captions-expected.png:
  • platform/qt/tables/mozilla/core/captions-expected.txt:
  • platform/qt/tables/mozilla/core/cell_heights-expected.png:
  • platform/qt/tables/mozilla/core/cell_heights-expected.txt:
  • platform/qt/tables/mozilla/core/col_span-expected.png:
  • platform/qt/tables/mozilla/core/col_span-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_auto-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_auto-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_auto_per-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_auto_per-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_auto-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_auto-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
  • platform/qt/tables/mozilla/core/col_widths_fix_per-expected.png:
  • platform/qt/tables/mozilla/core/col_widths_fix_per-expected.txt:
  • platform/qt/tables/mozilla/core/margins-expected.png:
  • platform/qt/tables/mozilla/core/margins-expected.txt:
  • platform/qt/tables/mozilla/core/misc-expected.png:
  • platform/qt/tables/mozilla/core/misc-expected.txt:
  • platform/qt/tables/mozilla/core/nested1-expected.png:
  • platform/qt/tables/mozilla/core/nested1-expected.txt:
  • platform/qt/tables/mozilla/core/one_row-expected.png:
  • platform/qt/tables/mozilla/core/one_row-expected.txt:
  • platform/qt/tables/mozilla/core/row_span-expected.png:
  • platform/qt/tables/mozilla/core/row_span-expected.txt:
  • platform/qt/tables/mozilla/core/table_frame-expected.png:
  • platform/qt/tables/mozilla/core/table_frame-expected.txt:
  • platform/qt/tables/mozilla/core/table_heights-expected.png:
  • platform/qt/tables/mozilla/core/table_heights-expected.txt:
  • platform/qt/tables/mozilla/core/table_rules-expected.png:
  • platform/qt/tables/mozilla/core/table_rules-expected.txt:
  • platform/qt/tables/mozilla/core/table_widths-expected.png:
  • platform/qt/tables/mozilla/core/table_widths-expected.txt:
  • platform/qt/tables/mozilla/dom/appendCol2-expected.png:
  • platform/qt/tables/mozilla/dom/appendCol2-expected.txt:
  • platform/qt/tables/mozilla/dom/appendRowsExpand1-expected.png:
  • platform/qt/tables/mozilla/dom/appendRowsExpand1-expected.txt:
  • platform/qt/tables/mozilla/dom/appendTbodyExpand1-expected.png:
  • platform/qt/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteCellsShrink1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteCellsShrink2-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteCol1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCol1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteCol2-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCol2-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteCol3-expected.png:
  • platform/qt/tables/mozilla/dom/deleteCol3-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteColGroup1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteColGroup1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteColGroup2-expected.png:
  • platform/qt/tables/mozilla/dom/deleteColGroup2-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
  • platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCellsExpand1-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsExpand1-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.png:
  • platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
  • platform/qt/tables/mozilla/dom/insertColGroups1-expected.png:
  • platform/qt/tables/mozilla/dom/insertColGroups1-expected.txt:
  • platform/qt/tables/mozilla/dom/insertColGroups2-expected.png:
  • platform/qt/tables/mozilla/dom/insertColGroups2-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCols1-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols1-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCols2-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols2-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCols3-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols3-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCols4-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols4-expected.txt:
  • platform/qt/tables/mozilla/dom/insertCols5-expected.png:
  • platform/qt/tables/mozilla/dom/insertCols5-expected.txt:
  • platform/qt/tables/mozilla/dom/insertRowsExpand1-expected.png:
  • platform/qt/tables/mozilla/dom/insertRowsExpand1-expected.txt:
  • platform/qt/tables/mozilla/dom/insertRowsRebuild1-expected.png:
  • platform/qt/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
6:37 AM EFLWebKit edited by g.czajkowski@samsung.com
(diff)
6:13 AM EFLWebKit edited by g.czajkowski@samsung.com
(diff)
5:45 AM EFLWebKit edited by g.czajkowski@samsung.com
(diff)
5:43 AM Changeset in webkit [122718] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Adding flaky tests to TextExpectations.
https://bugs.webkit.org/show_bug.cgi?id=91379
https://bugs.webkit.org/show_bug.cgi?id=91376

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-16

  • platform/qt/TestExpectations:
5:42 AM Changeset in webkit [122717] by loislo@chromium.org
  • 19 edits in trunk/Source/WebCore

Web Inspector: moving forward to the better memory instrumentation API
https://bugs.webkit.org/show_bug.cgi?id=91259

Reviewed by Pavel Feldman.

I'm trying to remove unnecessary complexity of the API
reportInstrumentedObject and reportInstrumentedPointer will be replaced with addInstrumentedMember
The same will happen with reportPointer, reportObject pair.
Also info.report* will be replaced with info.add*

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedMember):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addMember):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedMember):
(WebCore::MemoryInstrumentation::OwningTraits::addMember):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore::MemoryInstrumentation::addMemberImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore::MemoryClassInfo::addHashMap):
(WebCore::MemoryClassInfo::addHashSet):
(WebCore::MemoryClassInfo::addListHashSet):
(WebCore::MemoryClassInfo::addVector):
(WebCore::MemoryClassInfo::addString):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

5:37 AM Changeset in webkit [122716] by kbalazs@webkit.org
  • 306 edits
    8 adds in trunk/LayoutTests

[Qt] platform/qt/editing/selection tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91088

Unreviewed rebaseline.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-16

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/editing/selection/13804-expected.png:
  • platform/qt/editing/selection/13804-expected.txt:
  • platform/qt/editing/selection/14971-expected.png:
  • platform/qt/editing/selection/14971-expected.txt:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/editing/selection/4397952-expected.png:
  • platform/qt/editing/selection/4397952-expected.txt:
  • platform/qt/editing/selection/4402375-expected.png:
  • platform/qt/editing/selection/4402375-expected.txt:
  • platform/qt/editing/selection/4776665-expected.png:
  • platform/qt/editing/selection/4776665-expected.txt:
  • platform/qt/editing/selection/4818145-expected.png:
  • platform/qt/editing/selection/4818145-expected.txt:
  • platform/qt/editing/selection/4866671-expected.png:
  • platform/qt/editing/selection/4866671-expected.txt:
  • platform/qt/editing/selection/4889598-expected.png:
  • platform/qt/editing/selection/4889598-expected.txt:
  • platform/qt/editing/selection/4895428-2-expected.png:
  • platform/qt/editing/selection/4895428-2-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.png:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4932260-1-expected.png:
  • platform/qt/editing/selection/4932260-1-expected.txt:
  • platform/qt/editing/selection/4932260-2-expected.png:
  • platform/qt/editing/selection/4932260-2-expected.txt:
  • platform/qt/editing/selection/4932260-3-expected.png:
  • platform/qt/editing/selection/4932260-3-expected.txt:
  • platform/qt/editing/selection/4947387-expected.png:
  • platform/qt/editing/selection/4947387-expected.txt:
  • platform/qt/editing/selection/4960116-expected.png:
  • platform/qt/editing/selection/4960116-expected.txt:
  • platform/qt/editing/selection/4960137-expected.png:
  • platform/qt/editing/selection/4960137-expected.txt:
  • platform/qt/editing/selection/4975120-expected.png:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/editing/selection/4983858-expected.png:
  • platform/qt/editing/selection/4983858-expected.txt:
  • platform/qt/editing/selection/5007143-2-expected.png:
  • platform/qt/editing/selection/5007143-2-expected.txt:
  • platform/qt/editing/selection/5007143-expected.png:
  • platform/qt/editing/selection/5007143-expected.txt:
  • platform/qt/editing/selection/5057506-2-expected.png:
  • platform/qt/editing/selection/5057506-2-expected.txt:
  • platform/qt/editing/selection/5057506-expected.png:
  • platform/qt/editing/selection/5057506-expected.txt:
  • platform/qt/editing/selection/5076323-1-expected.png:
  • platform/qt/editing/selection/5076323-1-expected.txt:
  • platform/qt/editing/selection/5076323-2-expected.png:
  • platform/qt/editing/selection/5076323-2-expected.txt:
  • platform/qt/editing/selection/5076323-3-expected.png:
  • platform/qt/editing/selection/5076323-3-expected.txt:
  • platform/qt/editing/selection/5081257-1-expected.png:
  • platform/qt/editing/selection/5081257-1-expected.txt:
  • platform/qt/editing/selection/5081257-2-expected.png:
  • platform/qt/editing/selection/5081257-2-expected.txt:
  • platform/qt/editing/selection/5099303-expected.png:
  • platform/qt/editing/selection/5099303-expected.txt:
  • platform/qt/editing/selection/5131716-1-expected.png:
  • platform/qt/editing/selection/5131716-1-expected.txt:
  • platform/qt/editing/selection/5131716-2-expected.png:
  • platform/qt/editing/selection/5131716-2-expected.txt:
  • platform/qt/editing/selection/5131716-3-expected.png:
  • platform/qt/editing/selection/5131716-3-expected.txt:
  • platform/qt/editing/selection/5131716-4-expected.png:
  • platform/qt/editing/selection/5131716-4-expected.txt:
  • platform/qt/editing/selection/5195166-2-expected.png:
  • platform/qt/editing/selection/5195166-2-expected.txt:
  • platform/qt/editing/selection/5234383-1-expected.png:
  • platform/qt/editing/selection/5234383-1-expected.txt:
  • platform/qt/editing/selection/5234383-2-expected.png:
  • platform/qt/editing/selection/5234383-2-expected.txt:
  • platform/qt/editing/selection/5240265-expected.png:
  • platform/qt/editing/selection/5240265-expected.txt:
  • platform/qt/editing/selection/5354455-2-expected.png:
  • platform/qt/editing/selection/5354455-2-expected.txt:
  • platform/qt/editing/selection/6476-expected.png:
  • platform/qt/editing/selection/6476-expected.txt:
  • platform/qt/editing/selection/7152-1-expected.png:
  • platform/qt/editing/selection/7152-1-expected.txt:
  • platform/qt/editing/selection/7152-2-expected.png:
  • platform/qt/editing/selection/7152-2-expected.txt:
  • platform/qt/editing/selection/addRange-expected.png:
  • platform/qt/editing/selection/addRange-expected.txt:
  • platform/qt/editing/selection/after-line-wrap-expected.png:
  • platform/qt/editing/selection/after-line-wrap-expected.txt:
  • platform/qt/editing/selection/caret-and-focus-ring-expected.png:
  • platform/qt/editing/selection/caret-and-focus-ring-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.png:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/editing/selection/clear-selection-expected.png:
  • platform/qt/editing/selection/clear-selection-expected.txt:
  • platform/qt/editing/selection/click-start-of-line-expected.png:
  • platform/qt/editing/selection/click-start-of-line-expected.txt:
  • platform/qt/editing/selection/contenteditable-click-inside-expected.png:
  • platform/qt/editing/selection/contenteditable-click-inside-expected.txt:
  • platform/qt/editing/selection/display-table-text-expected.png:
  • platform/qt/editing/selection/display-table-text-expected.txt:
  • platform/qt/editing/selection/doubleclick-crash-expected.png:
  • platform/qt/editing/selection/doubleclick-crash-expected.txt:
  • platform/qt/editing/selection/drag-in-iframe-expected.png:
  • platform/qt/editing/selection/drag-in-iframe-expected.txt:
  • platform/qt/editing/selection/drag-select-1-expected.png:
  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/editing/selection/editable-html-element-expected.png:
  • platform/qt/editing/selection/editable-html-element-expected.txt:
  • platform/qt/editing/selection/editable-non-editable-crash-expected.png:
  • platform/qt/editing/selection/editable-non-editable-crash-expected.txt:
  • platform/qt/editing/selection/end-of-document-expected.png:
  • platform/qt/editing/selection/end-of-document-expected.txt:
  • platform/qt/editing/selection/expanding-selections-expected.png:
  • platform/qt/editing/selection/expanding-selections-expected.txt:
  • platform/qt/editing/selection/expanding-selections2-expected.png:
  • platform/qt/editing/selection/expanding-selections2-expected.txt:
  • platform/qt/editing/selection/extend-by-character-001-expected.png:
  • platform/qt/editing/selection/extend-by-character-001-expected.txt:
  • platform/qt/editing/selection/extend-by-character-002-expected.png:
  • platform/qt/editing/selection/extend-by-character-002-expected.txt:
  • platform/qt/editing/selection/extend-by-character-003-expected.png:
  • platform/qt/editing/selection/extend-by-character-003-expected.txt:
  • platform/qt/editing/selection/extend-by-character-004-expected.png:
  • platform/qt/editing/selection/extend-by-character-004-expected.txt:
  • platform/qt/editing/selection/extend-by-character-005-expected.png:
  • platform/qt/editing/selection/extend-by-character-005-expected.txt:
  • platform/qt/editing/selection/extend-by-character-006-expected.png:
  • platform/qt/editing/selection/extend-by-character-006-expected.txt:
  • platform/qt/editing/selection/extend-by-sentence-001-expected.png:
  • platform/qt/editing/selection/extend-by-sentence-001-expected.txt:
  • platform/qt/editing/selection/extend-by-word-001-expected.png:
  • platform/qt/editing/selection/extend-by-word-001-expected.txt:
  • platform/qt/editing/selection/extend-by-word-002-expected.png:
  • platform/qt/editing/selection/extend-by-word-002-expected.txt:
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
  • platform/qt/editing/selection/extend-inside-transforms-backward-expected.txt:
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
  • platform/qt/editing/selection/extend-inside-transforms-forward-expected.txt:
  • platform/qt/editing/selection/fake-doubleclick-expected.png:
  • platform/qt/editing/selection/fake-doubleclick-expected.txt:
  • platform/qt/editing/selection/focus-body-expected.png:
  • platform/qt/editing/selection/focus-body-expected.txt:
  • platform/qt/editing/selection/focus_editable_html-expected.png:
  • platform/qt/editing/selection/focus_editable_html-expected.txt:
  • platform/qt/editing/selection/iframe-expected.png:
  • platform/qt/editing/selection/iframe-expected.txt:
  • platform/qt/editing/selection/image-before-linebreak-expected.png:
  • platform/qt/editing/selection/image-before-linebreak-expected.txt:
  • platform/qt/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/qt/editing/selection/inline-closest-leaf-child-expected.txt:
  • platform/qt/editing/selection/inline-table-expected.png:
  • platform/qt/editing/selection/inline-table-expected.txt:
  • platform/qt/editing/selection/leave-requested-block-expected.png:
  • platform/qt/editing/selection/leave-requested-block-expected.txt:
  • platform/qt/editing/selection/line-wrap-1-expected.png:
  • platform/qt/editing/selection/line-wrap-1-expected.txt:
  • platform/qt/editing/selection/line-wrap-2-expected.png:
  • platform/qt/editing/selection/line-wrap-2-expected.txt:
  • platform/qt/editing/selection/mixed-editability-1-expected.png:
  • platform/qt/editing/selection/mixed-editability-1-expected.txt:
  • platform/qt/editing/selection/mixed-editability-2-expected.png:
  • platform/qt/editing/selection/mixed-editability-2-expected.txt:
  • platform/qt/editing/selection/mixed-editability-3-expected.png:
  • platform/qt/editing/selection/mixed-editability-3-expected.txt:
  • platform/qt/editing/selection/mixed-editability-4-expected.png:
  • platform/qt/editing/selection/mixed-editability-4-expected.txt:
  • platform/qt/editing/selection/mixed-editability-5-expected.png:
  • platform/qt/editing/selection/mixed-editability-5-expected.txt:
  • platform/qt/editing/selection/mixed-editability-6-expected.png:
  • platform/qt/editing/selection/mixed-editability-6-expected.txt:
  • platform/qt/editing/selection/mixed-editability-7-expected.png:
  • platform/qt/editing/selection/mixed-editability-7-expected.txt:
  • platform/qt/editing/selection/mixed-editability-8-expected.png:
  • platform/qt/editing/selection/mixed-editability-8-expected.txt:
  • platform/qt/editing/selection/mixed-editability-9-expected.png:
  • platform/qt/editing/selection/mixed-editability-9-expected.txt:
  • platform/qt/editing/selection/move-3875618-fix-expected.png:
  • platform/qt/editing/selection/move-3875618-fix-expected.txt:
  • platform/qt/editing/selection/move-3875641-fix-expected.png:
  • platform/qt/editing/selection/move-3875641-fix-expected.txt:
  • platform/qt/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/qt/editing/selection/move-backwords-by-word-001-expected.txt:
  • platform/qt/editing/selection/move-between-blocks-no-001-expected.png:
  • platform/qt/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
  • platform/qt/editing/selection/move-between-blocks-yes-001-expected.txt:
  • platform/qt/editing/selection/move-by-character-001-expected.png:
  • platform/qt/editing/selection/move-by-character-001-expected.txt:
  • platform/qt/editing/selection/move-by-character-002-expected.png:
  • platform/qt/editing/selection/move-by-character-002-expected.txt:
  • platform/qt/editing/selection/move-by-character-003-expected.png:
  • platform/qt/editing/selection/move-by-character-003-expected.txt:
  • platform/qt/editing/selection/move-by-character-004-expected.png:
  • platform/qt/editing/selection/move-by-character-004-expected.txt:
  • platform/qt/editing/selection/move-by-character-005-expected.png:
  • platform/qt/editing/selection/move-by-character-005-expected.txt:
  • platform/qt/editing/selection/move-by-character-6-expected.png:
  • platform/qt/editing/selection/move-by-character-6-expected.txt:
  • platform/qt/editing/selection/move-by-line-001-expected.png:
  • platform/qt/editing/selection/move-by-line-001-expected.txt:
  • platform/qt/editing/selection/move-by-line-002-expected.png:
  • platform/qt/editing/selection/move-by-line-002-expected.txt:
  • platform/qt/editing/selection/move-by-sentence-001-expected.png:
  • platform/qt/editing/selection/move-by-sentence-001-expected.txt:
  • platform/qt/editing/selection/move-by-sentence-linebreak-expected.png:
  • platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/qt/editing/selection/move-by-word-001-expected.png:
  • platform/qt/editing/selection/move-by-word-001-expected.txt:
  • platform/qt/editing/selection/node-removal-1-expected.png:
  • platform/qt/editing/selection/node-removal-1-expected.txt:
  • platform/qt/editing/selection/node-removal-2-expected.png:
  • platform/qt/editing/selection/node-removal-2-expected.txt:
  • platform/qt/editing/selection/paragraph-granularity-expected.png:
  • platform/qt/editing/selection/paragraph-granularity-expected.txt:
  • platform/qt/editing/selection/previous-line-position-expected.png:
  • platform/qt/editing/selection/previous-line-position-expected.txt:
  • platform/qt/editing/selection/range-between-block-and-inline-expected.png:
  • platform/qt/editing/selection/range-between-block-and-inline-expected.txt:
  • platform/qt/editing/selection/replace-selection-1-expected.png:
  • platform/qt/editing/selection/replace-selection-1-expected.txt:
  • platform/qt/editing/selection/replaced-boundaries-1-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-1-expected.txt:
  • platform/qt/editing/selection/replaced-boundaries-2-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-2-expected.txt:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/qt/editing/selection/select-all-001-expected.png:
  • platform/qt/editing/selection/select-all-001-expected.txt:
  • platform/qt/editing/selection/select-all-002-expected.png:
  • platform/qt/editing/selection/select-all-002-expected.txt:
  • platform/qt/editing/selection/select-all-003-expected.png:
  • platform/qt/editing/selection/select-all-003-expected.txt:
  • platform/qt/editing/selection/select-all-004-expected.png:
  • platform/qt/editing/selection/select-all-004-expected.txt:
  • platform/qt/editing/selection/select-all-005-expected.png:
  • platform/qt/editing/selection/select-all-005-expected.txt:
  • platform/qt/editing/selection/select-all-006-expected.png:
  • platform/qt/editing/selection/select-all-006-expected.txt:
  • platform/qt/editing/selection/select-all-iframe-expected.png:
  • platform/qt/editing/selection/select-all-iframe-expected.txt:
  • platform/qt/editing/selection/select-box-expected.png:
  • platform/qt/editing/selection/select-box-expected.txt:
  • platform/qt/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/qt/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
  • platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/qt/editing/selection/selectNode-expected.png:
  • platform/qt/editing/selection/selectNode-expected.txt:
  • platform/qt/editing/selection/selectNodeContents-expected.png:
  • platform/qt/editing/selection/selectNodeContents-expected.txt:
  • platform/qt/editing/selection/selection-3748164-fix-expected.png:
  • platform/qt/editing/selection/selection-3748164-fix-expected.txt:
  • platform/qt/editing/selection/selection-actions-expected.png:
  • platform/qt/editing/selection/selection-actions-expected.txt:
  • platform/qt/editing/selection/selection-background-expected.png:
  • platform/qt/editing/selection/selection-background-expected.txt:
  • platform/qt/editing/selection/selection-button-text-expected.png:
  • platform/qt/editing/selection/selection-button-text-expected.txt:
  • platform/qt/editing/selection/table-caret-1-expected.png:
  • platform/qt/editing/selection/table-caret-1-expected.txt:
  • platform/qt/editing/selection/table-caret-2-expected.png:
  • platform/qt/editing/selection/table-caret-2-expected.txt:
  • platform/qt/editing/selection/table-caret-3-expected.png:
  • platform/qt/editing/selection/table-caret-3-expected.txt:
  • platform/qt/editing/selection/triple-click-in-pre-expected.png:
  • platform/qt/editing/selection/triple-click-in-pre-expected.txt:
  • platform/qt/editing/selection/unrendered-space-expected.png:
  • platform/qt/editing/selection/unrendered-space-expected.txt:
  • platform/qt/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
  • platform/qt/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/qt/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
  • platform/qt/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/qt/editing/selection/word-granularity-expected.png:
  • platform/qt/editing/selection/word-granularity-expected.txt:
  • platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
  • platform/qt/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
  • platform/qt/editing/selection/wrapped-line-caret-2-expected.txt:
5:18 AM Changeset in webkit [122715] by loislo@chromium.org
  • 19 edits in trunk/Source/WebCore

Unreviewed, rolling out r122714.
http://trac.webkit.org/changeset/122714
https://bugs.webkit.org/show_bug.cgi?id=91380

It broke mac compilation (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::reportObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::reportPointer):
(WebCore::MemoryClassInfo::reportInstrumentedPointer):
(WebCore::MemoryClassInfo::reportInstrumentedObject):
(WebCore::MemoryClassInfo::reportPointer):
(WebCore::MemoryClassInfo::reportObject):
(WebCore::MemoryClassInfo::reportHashMap):
(WebCore::MemoryClassInfo::reportHashSet):
(WebCore::MemoryClassInfo::reportListHashSet):
(WebCore::MemoryClassInfo::reportVector):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::reportString):
(WebCore):
(WebCore::MemoryInstrumentation::reportInstrumentedPointer):
(WebCore::MemoryInstrumentation::reportInstrumentedObject):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportListHashSet):
(WebCore::MemoryInstrumentation::reportVector):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

5:00 AM Changeset in webkit [122714] by loislo@chromium.org
  • 19 edits in trunk/Source/WebCore

Web Inspector: moving forward to the better memory instrumentation API
https://bugs.webkit.org/show_bug.cgi?id=91259

Reviewed by Pavel Feldman.

I'm trying to remove unnecessary complexity of the API
reportInstrumentedObject and reportInstrumentedPointer will be replaced with addInstrumentedMember
The same will happen with reportPointer, reportObject pair.
Also info.report* will be replaced with info.add*

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::collectBindingMemoryInfo):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryInstrumentation::addInstrumentedMember):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addMember):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedMember):
(WebCore::MemoryInstrumentation::OwningTraits::addMember):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore::MemoryInstrumentation::addMemberImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore::MemoryClassInfo::addHashMap):
(WebCore::MemoryClassInfo::addHashSet):
(WebCore::MemoryClassInfo::addListHashSet):
(WebCore::MemoryClassInfo::addVector):
(WebCore::MemoryClassInfo::addString):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore::MemoryInstrumentation::addHashSet):
(WebCore::MemoryInstrumentation::addListHashSet):
(WebCore::MemoryInstrumentation::addVector):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

4:48 AM Changeset in webkit [122713] by loislo@chromium.org
  • 17 edits in trunk/Source/WebCore

Web Inspector: native memory instrumentation: extract instrumentation methods into MemoryClassInfo
https://bugs.webkit.org/show_bug.cgi?id=91227

Reviewed by Pavel Feldman.

void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{

MemoryClassInfo<Node> info(memoryObjectInfo, this, MemoryInstrumentation::DOM);
info.visitBaseClass<ScriptWrappable>(this);

info.addMember(m_notInstrumentedPointer); automatically detects poniter/reference
info.addInstrumentedMember(m_next);
info.addHashSet<MemoryInstrumentation::NonClass>(m_aHash);
NonClass value_type (report only size of internal template structures)
info.addHashSet<MemoryInstrumentation::NotInstrumentedClass>(m_aHashSet); not instrumented value_type (use sizeof)
info.addHashSet<MemoryInstrumentation::InstrumentedClass>(m_aHashSet);
instrumented value_type (call visit)

}

The change is covered by existing tests for native memory snapshot.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/IntrusiveDOMWrapperMap.h:

(WebCore::ChunkedTable::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):

  • bindings/v8/V8DOMMap.h:
  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/Element.h:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WebCore::MemoryObjectInfo::objectType):
(WebCore::MemoryObjectInfo::objectSize):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore):
(MemoryClassInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
(WebCore::MemoryClassInfo::visitBaseClass):
(WebCore::MemoryClassInfo::reportInstrumentedPointer):
(WebCore::MemoryClassInfo::reportInstrumentedObject):
(WebCore::MemoryClassInfo::reportPointer):
(WebCore::MemoryClassInfo::reportObject):
(WebCore::MemoryClassInfo::reportHashMap):
(WebCore::MemoryClassInfo::reportHashSet):
(WebCore::MemoryClassInfo::reportListHashSet):
(WebCore::MemoryClassInfo::reportVector):
(WebCore::MemoryClassInfo::reportString):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
(WebCore::QualifiedName::reportMemoryUsage):

  • platform/TreeShared.h:

(WebCore::TreeShared::reportMemoryUsage):

4:28 AM Changeset in webkit [122712] by kbalazs@webkit.org
  • 252 edits
    1 copy
    2 adds in trunk/LayoutTests

[Qt] Update test expectations. Unskip now passing tests.
https://bugs.webkit.org/show_bug.cgi?id=91085.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-16
Reviewed by Csaba Osztorgonác.

  • platform/qt-5.0/Skipped:
  • platform/qt/editing/deleting/4922367-expected.png:
  • platform/qt/editing/deleting/4922367-expected.txt:
  • platform/qt/editing/deleting/5099303-expected.png:
  • platform/qt/editing/deleting/5099303-expected.txt:
  • platform/qt/editing/deleting/5126166-expected.png:
  • platform/qt/editing/deleting/5126166-expected.txt:
  • platform/qt/editing/deleting/5144139-2-expected.png:
  • platform/qt/editing/deleting/5144139-2-expected.txt:
  • platform/qt/editing/deleting/5206311-1-expected.png:
  • platform/qt/editing/deleting/5206311-1-expected.txt:
  • platform/qt/editing/deleting/5272440-expected.png:
  • platform/qt/editing/deleting/5272440-expected.txt:
  • platform/qt/editing/deleting/5369009-expected.png:
  • platform/qt/editing/deleting/5369009-expected.txt:
  • platform/qt/editing/deleting/5433862-2-expected.png:
  • platform/qt/editing/deleting/5433862-2-expected.txt:
  • platform/qt/editing/deleting/5483370-expected.png:
  • platform/qt/editing/deleting/5483370-expected.txt:
  • platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • platform/qt/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3608445-fix-expected.png:
  • platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3608462-fix-expected.png:
  • platform/qt/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3775172-fix-expected.png:
  • platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3800834-fix-expected.png:
  • platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3857753-fix-expected.png:
  • platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3865854-fix-expected.png:
  • platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3928305-fix-expected.png:
  • platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
  • platform/qt/editing/deleting/delete-4083333-fix-expected.png:
  • platform/qt/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-and-undo-expected.png:
  • platform/qt/editing/deleting/delete-and-undo-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.png:
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-001-expected.png:
  • platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-002-expected.png:
  • platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-003-expected.png:
  • platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
  • platform/qt/editing/deleting/delete-br-001-expected.png:
  • platform/qt/editing/deleting/delete-br-001-expected.txt:
  • platform/qt/editing/deleting/delete-br-002-expected.png:
  • platform/qt/editing/deleting/delete-br-002-expected.txt:
  • platform/qt/editing/deleting/delete-br-003-expected.png:
  • platform/qt/editing/deleting/delete-br-003-expected.txt:
  • platform/qt/editing/deleting/delete-br-004-expected.png:
  • platform/qt/editing/deleting/delete-br-004-expected.txt:
  • platform/qt/editing/deleting/delete-br-005-expected.png:
  • platform/qt/editing/deleting/delete-br-005-expected.txt:
  • platform/qt/editing/deleting/delete-br-006-expected.png:
  • platform/qt/editing/deleting/delete-br-006-expected.txt:
  • platform/qt/editing/deleting/delete-br-007-expected.png:
  • platform/qt/editing/deleting/delete-br-007-expected.txt:
  • platform/qt/editing/deleting/delete-br-008-expected.png:
  • platform/qt/editing/deleting/delete-br-008-expected.txt:
  • platform/qt/editing/deleting/delete-br-009-expected.png:
  • platform/qt/editing/deleting/delete-br-009-expected.txt:
  • platform/qt/editing/deleting/delete-br-010-expected.png:
  • platform/qt/editing/deleting/delete-br-010-expected.txt:
  • platform/qt/editing/deleting/delete-br-013-expected.png:
  • platform/qt/editing/deleting/delete-br-013-expected.txt:
  • platform/qt/editing/deleting/delete-character-001-expected.png:
  • platform/qt/editing/deleting/delete-character-001-expected.txt:
  • platform/qt/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-first-list-item-expected.png:
  • platform/qt/editing/deleting/delete-first-list-item-expected.txt:
  • platform/qt/editing/deleting/delete-hr-expected.png:
  • platform/qt/editing/deleting/delete-hr-expected.txt:
  • platform/qt/editing/deleting/delete-image-001-expected.png:
  • platform/qt/editing/deleting/delete-image-001-expected.txt:
  • platform/qt/editing/deleting/delete-image-002-expected.png:
  • platform/qt/editing/deleting/delete-image-002-expected.txt:
  • platform/qt/editing/deleting/delete-image-003-expected.png:
  • platform/qt/editing/deleting/delete-image-003-expected.txt:
  • platform/qt/editing/deleting/delete-image-004-expected.png:
  • platform/qt/editing/deleting/delete-image-004-expected.txt:
  • platform/qt/editing/deleting/delete-leading-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-line-001-expected.png:
  • platform/qt/editing/deleting/delete-line-001-expected.txt:
  • platform/qt/editing/deleting/delete-line-002-expected.png:
  • platform/qt/editing/deleting/delete-line-002-expected.txt:
  • platform/qt/editing/deleting/delete-line-003-expected.png:
  • platform/qt/editing/deleting/delete-line-003-expected.txt:
  • platform/qt/editing/deleting/delete-line-004-expected.png:
  • platform/qt/editing/deleting/delete-line-004-expected.txt:
  • platform/qt/editing/deleting/delete-line-005-expected.png:
  • platform/qt/editing/deleting/delete-line-005-expected.txt:
  • platform/qt/editing/deleting/delete-line-006-expected.png:
  • platform/qt/editing/deleting/delete-line-006-expected.txt:
  • platform/qt/editing/deleting/delete-line-007-expected.png:
  • platform/qt/editing/deleting/delete-line-007-expected.txt:
  • platform/qt/editing/deleting/delete-line-008-expected.png:
  • platform/qt/editing/deleting/delete-line-008-expected.txt:
  • platform/qt/editing/deleting/delete-line-009-expected.png:
  • platform/qt/editing/deleting/delete-line-009-expected.txt:
  • platform/qt/editing/deleting/delete-line-010-expected.png:
  • platform/qt/editing/deleting/delete-line-010-expected.txt:
  • platform/qt/editing/deleting/delete-line-011-expected.png:
  • platform/qt/editing/deleting/delete-line-011-expected.txt:
  • platform/qt/editing/deleting/delete-line-012-expected.png:
  • platform/qt/editing/deleting/delete-line-012-expected.txt:
  • platform/qt/editing/deleting/delete-line-013-expected.png:
  • platform/qt/editing/deleting/delete-line-013-expected.txt:
  • platform/qt/editing/deleting/delete-line-014-expected.png:
  • platform/qt/editing/deleting/delete-line-014-expected.txt:
  • platform/qt/editing/deleting/delete-line-015-expected.png:
  • platform/qt/editing/deleting/delete-line-015-expected.txt:
  • platform/qt/editing/deleting/delete-line-016-expected.png:
  • platform/qt/editing/deleting/delete-line-016-expected.txt:
  • platform/qt/editing/deleting/delete-line-017-expected.png:
  • platform/qt/editing/deleting/delete-line-017-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-listitem-001-expected.png:
  • platform/qt/editing/deleting/delete-listitem-001-expected.txt:
  • platform/qt/editing/deleting/delete-listitem-002-expected.png:
  • platform/qt/editing/deleting/delete-listitem-002-expected.txt:
  • platform/qt/editing/deleting/delete-selection-001-expected.png:
  • platform/qt/editing/deleting/delete-selection-001-expected.txt:
  • platform/qt/editing/deleting/delete-to-select-table-expected.png:
  • platform/qt/editing/deleting/delete-to-select-table-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.png:
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/qt/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/qt/editing/deleting/delete-ws-fixup-003-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-003-expected.txt:
  • platform/qt/editing/deleting/delete-ws-fixup-004-expected.png:
  • platform/qt/editing/deleting/delete-ws-fixup-004-expected.txt:
  • platform/qt/editing/deleting/deletionUI-single-instance-expected.png:
  • platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/qt/editing/deleting/forward-delete-expected.png:
  • platform/qt/editing/deleting/forward-delete-expected.txt:
  • platform/qt/editing/deleting/list-item-1-expected.png:
  • platform/qt/editing/deleting/list-item-1-expected.txt:
  • platform/qt/editing/deleting/merge-different-styles-expected.png:
  • platform/qt/editing/deleting/merge-different-styles-expected.txt:
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.png:
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
  • platform/qt/editing/deleting/merge-no-br-expected.png:
  • platform/qt/editing/deleting/merge-no-br-expected.txt:
  • platform/qt/editing/deleting/merge-unrendered-space-expected.png:
  • platform/qt/editing/deleting/merge-unrendered-space-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/deleting/move-nodes-001-expected.png:
  • platform/qt/editing/deleting/move-nodes-001-expected.txt:
  • platform/qt/editing/deleting/non-smart-delete-expected.png:
  • platform/qt/editing/deleting/non-smart-delete-expected.txt:
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.png:
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/deleting/smart-delete-002-expected.png:
  • platform/qt/editing/deleting/smart-delete-002-expected.txt:
  • platform/qt/editing/deleting/smart-delete-003-expected.png: Added.
  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.png: Added.
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/deleting/table-cells-expected.png:
  • platform/qt/editing/deleting/table-cells-expected.txt:
  • platform/qt/editing/deleting/transpose-empty-expected.png: Copied from LayoutTests/platform/qt/editing/deleting/delete-at-start-or-end-expected.png.
  • platform/qt/editing/deleting/type-delete-after-quote-expected.png:
  • platform/qt/editing/deleting/type-delete-after-quote-expected.txt:
4:04 AM Changeset in webkit [122711] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, marked test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=91373

  • platform/chromium/TestExpectations:
3:40 AM Changeset in webkit [122710] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, skipped failing test.
https://bugs.webkit.org/show_bug.cgi?id=91372

  • platform/chromium/TestExpectations:
3:14 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
2:56 AM Changeset in webkit [122709] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-1.9.5

Tagging the WebKitGTK+ 1.9.5 release

2:43 AM Changeset in webkit [122708] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.9.5 release

.:

  • configure.ac: Bump version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.9.5.
2:38 AM Changeset in webkit [122707] by Carlos Garcia Campos
  • 7 edits in trunk

Unreviewed. Fix make distcheck.

Source/WebCore:

  • GNUmakefile.am: Add missing idl directory.
  • GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit2:

  • UIProcess/API/gtk/tests/GNUmakefile.am: Add test resources to

EXTRA_DIST.

Tools:

  • GNUmakefile.am: Add missing file to compilation.
1:53 AM Changeset in webkit [122706] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Implement message loop instrumentation for timeline
https://bugs.webkit.org/show_bug.cgi?id=88325

Patch by Eugene Klyuchnikov <eustas.big@gmail.com> on 2012-07-16
Reviewed by Pavel Feldman.

Message loop instrumentation will show when the render thread is busy.

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):
Added new experiment.

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.get dividersLabelBarElement):
Exposed label bar element.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._resetPanel):
Cleanups recorded tasks.
(WebInspector.TimelinePanel.prototype._refresh):
Updates CPU bar.
(WebInspector.TimelinePanel.prototype._refreshRecords):
Ditto.
(WebInspector.TimelinePanel.prototype._refreshCpuBars.compareEndTime):
Ditto.
(WebInspector.TimelinePanel.prototype._refreshCpuBars):
Ditto.
(WebInspector.TimelinePanel.prototype._enableMainThreadMonitoringExperiment):
Adds CPU bar to UI.
(WebInspector.TimelinePanel.prototype._showPopover):
Fix NPE.
(WebInspector.TimelineCalculator.prototype.computeTime):
Utility for position to time conversion.
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
Remenbers clientWidth.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
Define CPU bar colors.

  • inspector/front-end/timelinePanel.css:

(.timeline-cpu-bars):
CPU bar styles.
(.timeline-cpu-bars-label):
Ditto.

1:41 AM Changeset in webkit [122705] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark fast/forms/number/spin-button-gets-disabled-or-readonly.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=91367

Unreviewed EFL gardening. Mark fast/forms/number/spin-button-gets-disabled-or-readonly.html
as flaky.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-16

  • platform/efl/TestExpectations:
1:41 AM EFLWebKitTests edited by tmpsantos@gmail.com
(diff)
1:31 AM Changeset in webkit [122704] by zandobersek@gmail.com
  • 39 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines for MathML Presentation
layout tests. The tests are currently marked as flaky so bots should
do some more iterations to see if that's still the case or those
expectations will be removed.

  • platform/gtk/mathml/presentation/attributes-expected.png:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.png:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.png:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.png:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.png:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.png:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.png:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.png:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.png:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.png:
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.png:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.png:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.png:
  • platform/gtk/mathml/presentation/tables-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.png:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.png:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.png:
  • platform/gtk/mathml/presentation/underover-expected.txt:
12:54 AM Changeset in webkit [122703] by zandobersek@gmail.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening, generating baselines for three tests that pass
but require specific baselines. Also removing their test expectations.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/gtk/fast/profiler/dead-time-expected.txt: Added.
  • platform/gtk/fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
12:45 AM Changeset in webkit [122702] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit

Source/WebKit: Add accessible for QWebView.
https://bugs.webkit.org/show_bug.cgi?id=91073

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-07-16
Reviewed by Simon Hausmann.

Add classes to enable accessibility on the widget level.

  • WebKit.pri:
  • WebKit1.pro:

Source/WebKit/qt: Accessible Widget for QWebView
https://bugs.webkit.org/show_bug.cgi?id=91073

Added classes that allow navigation to the web view widget.
This is the glue to later access webkit's accessible objects
though the Qt accessibility framework.

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-07-16
Reviewed by Simon Hausmann.

  • Api/qwebview.cpp:

(QWebView::QWebView):

  • Api/qwebviewaccessible.cpp: Added.

(accessibleInterfaceFactory):
(QWebFrameAccessible::QWebFrameAccessible):
(QWebFrameAccessible::frame):
(QWebFrameAccessible::parent):
(QWebFrameAccessible::text):
(QWebFrameAccessible::childCount):
(QWebFrameAccessible::child):
(QWebFrameAccessible::indexOfChild):
(QWebFrameAccessible::state):
(QWebFrameAccessible::role):
(QWebFrameAccessible::navigate):
(QWebPageAccessible::QWebPageAccessible):
(QWebPageAccessible::page):
(QWebPageAccessible::text):
(QWebPageAccessible::parent):
(QWebPageAccessible::child):
(QWebPageAccessible::childCount):
(QWebPageAccessible::indexOfChild):
(QWebPageAccessible::navigate):
(QWebPageAccessible::role):
(QWebPageAccessible::state):
(QWebViewAccessible::QWebViewAccessible):
(QWebViewAccessible::view):
(QWebViewAccessible::childCount):
(QWebViewAccessible::child):

  • Api/qwebviewaccessible_p.h: Added.

(QWebFrameAccessible):
(QWebPageAccessible):
(QWebViewAccessible):

12:24 AM Changeset in webkit [122701] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r122681.
http://trac.webkit.org/changeset/122681
https://bugs.webkit.org/show_bug.cgi?id=91363

Patch introduces crashes in debug builds for GTK and EFL ports
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-16

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

12:11 AM Changeset in webkit [122700] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Compilation failure in StyleResolver.cpp (clang)
https://bugs.webkit.org/show_bug.cgi?id=89892

Reviewed by Ryosuke Niwa.

Patch adds assertions that unreachable code is in fact not reached.

Covered by fast/css/variables tests.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

Jul 15, 2012:

11:50 PM Changeset in webkit [122699] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new failing test.

  • platform/qt/Skipped:
11:44 PM Changeset in webkit [122698] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark a few media tests as flaky on RELEASE bot as well
https://bugs.webkit.org/show_bug.cgi?id=91361

Unreviewed EFL gardening. Mark a few media test as flaky on
the RELEASE bot as well.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
11:25 PM Changeset in webkit [122697] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[EFL][WK2] Define destructors for Ewk structures
https://bugs.webkit.org/show_bug.cgi?id=91338

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15
Reviewed by Kentaro Hara.

Add destructors to Ewk structures and move
memory freeing code from *_free() or *_unref()
functions to the destructors.

  • UIProcess/API/efl/ewk_intent.cpp:

(_Ewk_Intent::_Ewk_Intent):
(_Ewk_Intent):
(_Ewk_Intent::~_Ewk_Intent):
(ewk_intent_unref):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(_Ewk_Intent_Service):
(_Ewk_Intent_Service::~_Ewk_Intent_Service):
(ewk_intent_service_unref):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::~_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):

  • UIProcess/API/efl/ewk_url_request.cpp:

(_Ewk_Url_Request):
(_Ewk_Url_Request::~_Ewk_Url_Request):
(ewk_url_request_unref):

  • UIProcess/API/efl/ewk_url_response.cpp:

(_Ewk_Url_Response):
(_Ewk_Url_Response::~_Ewk_Url_Response):
(ewk_url_response_unref):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_del):

  • UIProcess/API/efl/ewk_web_error.cpp:

(_Ewk_Web_Error):
(_Ewk_Web_Error::~_Ewk_Web_Error):
(ewk_web_error_free):

  • UIProcess/API/efl/ewk_web_resource.cpp:

(_Ewk_Web_Resource):
(_Ewk_Web_Resource::~_Ewk_Web_Resource):
(ewk_web_resource_unref):

11:22 PM Changeset in webkit [122696] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip css3/flexbox/flexbox-overflow-auto.html
https://bugs.webkit.org/show_bug.cgi?id=91360

Unreviewed EFL gardening. Skip css3/flexbox/flexbox-overflow-auto.html
which started failing after r122681.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
11:15 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:07 PM Changeset in webkit [122695] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Disable perf tests for DEBUG builds
https://bugs.webkit.org/show_bug.cgi?id=91358

Unreviewed EFL gardening. Disable performance tests
in DEBUG builds since they are really slow and there
are very few benefits in running them.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
10:32 PM EFLWebKitCodingStyle edited by eunmi15.lee@samsung.com
Add "Use "void" for empty parameter of public APIs" (diff)
10:26 PM Changeset in webkit [122694] by mikelawther@chromium.org
  • 8 edits
    2 adds in trunk

Fix calculation of rgba's alpha in CSS custom text
https://bugs.webkit.org/show_bug.cgi?id=91355

Reviewed by Ryosuke Niwa.

Source/WebCore:

Alpha values are stored as an 8 bit value. To convert this to a float in the
range [0,1], we need to divide by 255, not 256.

Test: fast/css/rgba-custom-text.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::customCssText):

LayoutTests:

  • css3/calc/color-hsl-expected.txt:
  • css3/calc/color-rgb-expected.txt:
  • editing/execCommand/query-command-value-background-color-expected.txt:
  • editing/execCommand/query-command-value-background-color.html:
  • fast/css/rgba-custom-text-expected.txt: Added.
  • fast/css/rgba-custom-text.html: Added.
  • media/track/track-cue-rendering-expected.txt:
8:22 PM Changeset in webkit [122693] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Add a API for getting security origin string
https://bugs.webkit.org/show_bug.cgi?id=90936

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-15
Reviewed by Ryosuke Niwa.

Support to change from Ewk_Security_Origin to string on the API level.
Add ewk_security_origin_string_get for getting security origin string.

  • ewk/ewk_security_origin.cpp:

(_Ewk_Security_Origin):
(ewk_security_origin_string_get):
(ewk_security_origin_free):
(ewk_security_origin_new):

  • ewk/ewk_security_origin.h:
7:53 PM Changeset in webkit [122692] by jason.liu@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] We shouldn't call didFinishLoading for the old request when a new request has been sent by notifyAuthReceived.
https://bugs.webkit.org/show_bug.cgi?id=90962

Reviewed by Rob Buis.

We start a new NetworkJob with credentials after receiving 401/407 status.
We should not release resources in webcore when the old job is closed because
they are needed by the new one.
We should do as 3XX.

No new tests. No change in behaviour.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::shouldReleaseClientResource):
(WebCore::NetworkJob::handleRedirect):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

7:29 PM Changeset in webkit [122691] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move icon database to application data directory.
https://bugs.webkit.org/show_bug.cgi?id=91195

Patch by Jonathan Dong <Jonathan Dong> on 2012-07-15
Reviewed by Rob Buis.

RIM PR: 156852
Create icon database in application data directory instead of
database or local storage directory, by doing this we can make
things easier when clearing database or local storage data files.

Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

7:27 PM Changeset in webkit [122690] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Several media tests are flaky in DEBUG mode
https://bugs.webkit.org/show_bug.cgi?id=91347

Unreviewed EFL gardening. Add to TestExpectations a
few media tests which are flaky in DEBUG mode only.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
7:26 PM Changeset in webkit [122689] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r122660): Cannot iterate over HTMLCollection that contains non-child descendent nodes in some conditions
https://bugs.webkit.org/show_bug.cgi?id=91334

Reviewed by Ojan Vafai.

Source/WebCore:

The bug was caused by using lastChild() as the starting node for traversePreviousNode. Since it's the inverse of
Node::traverseNextNode(), which visits nodes in pre order, we must start our search from the last descendent node,
which is visited traverseNextNode immediately before reaching the root node.

Test: fast/dom/htmlcollection-backwards-subtree-iteration.html

  • html/HTMLCollection.cpp:

(WebCore::lastDescendent):
(WebCore):
(WebCore::itemBeforeOrAfter):

LayoutTests:

Add a regression test. Without this patch, it results in an console error in release builds and an assertion failure
in debug builds.

  • fast/dom/htmlcollection-backwards-subtree-iteration-expected.txt: Added.
  • fast/dom/htmlcollection-backwards-subtree-iteration.html: Added.
7:25 PM Changeset in webkit [122688] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebKit

[EFL] Move files guarded by #ifdef to existing file list.
https://bugs.webkit.org/show_bug.cgi?id=91336

Reviewed by Ryosuke Niwa.

Some EFL files are already guared by #ifdef. So, cmake files doesn't need to guard
them again. In addition, some files are missing #ifdef guard its header files.

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit/efl:

  • WebCoreSupport/DeviceMotionClientEfl.h:
  • WebCoreSupport/InspectorClientEfl.h:
  • WebCoreSupport/NetworkInfoClientEfl.h:
  • WebCoreSupport/VibrationClientEfl.h:
6:41 PM Changeset in webkit [122687] by rniwa@webkit.org
  • 381 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in fast/js, layers, leaks, line-grid, lists, loader, loading, media, mediastream, multicol, and mutation tests
https://bugs.webkit.org/show_bug.cgi?id=91315

Reviewed by Adam Barth.

  • fast/js/:
  • fast/layers/add-layer-with-nested-stacking.html:
  • fast/layers/assert-RenderLayer-update-positions.html:
  • fast/layers/clip-rects-assertion.html:
  • fast/layers/clip-rects-transformed-2.html:
  • fast/layers/clip-rects-transformed.html:
  • fast/layers/generated-layer-scrollbar-crash.html:
  • fast/layers/inline-dirty-z-order-lists.html:
  • fast/layers/layer-content-visibility-change.html:
  • fast/layers/layer-visibility.html:
  • fast/layers/nested-layers-1.html:
  • fast/layers/nested-layers-2.html:
  • fast/layers/nested-layers-3.html:
  • fast/layers/nested-layers-4.html:
  • fast/layers/remove-layer-with-nested-stacking.html:
  • fast/layers/remove-only-this-layer-update.html:
  • fast/layers/removed-by-scroll-handler.html:
  • fast/layers/resize-layer-deletion-crash.html:
  • fast/layers/scroll-with-transform-composited-layer.html:
  • fast/layers/scroll-with-transform-layer.html:
  • fast/layers/scrollByLines-overflow-no-layer.html:
  • fast/layers/visible-layer-with-hidden-parent.html:
  • fast/layers/zindex-hit-test.html:
  • fast/leaks/001.html:
  • fast/leaks/002.html:
  • fast/leaks/003.html-disabled:
  • fast/line-grid/line-grid-nested.html:
  • fast/lists/alpha-boundary-values.html:
  • fast/lists/alpha-list-wrap.html:
  • fast/lists/calc-width-with-space.html:
  • fast/lists/decimal-leading-zero.html:
  • fast/lists/drag-into-marker.html:
  • fast/lists/item-not-in-list-line-wrapping.html:
  • fast/lists/li-values.html:
  • fast/lists/list-style-type-dynamic-change.html:
  • fast/lists/ol-nested-items-dynamic-insert.html:
  • fast/lists/ol-nested-items-dynamic-remove.html:
  • fast/lists/ol-nested-items.html:
  • fast/lists/ol-nested-list-dynamic-insert.html:
  • fast/lists/ol-nested-list-dynamic-remove.html:
  • fast/lists/ol-nested-list.html:
  • fast/lists/ol-reversed-dynamic-simple.html:
  • fast/lists/ol-reversed-dynamic.html:
  • fast/lists/ol-reversed-nested-items.html:
  • fast/lists/ol-reversed-nested-list.html:
  • fast/lists/ol-reversed-simple.html:
  • fast/lists/ol-reversed-simple.xhtml:
  • fast/lists/ol-start-roman.html:
  • fast/lists/parent-box-not-box-crash.html:
  • fast/lists/positioned-count-crash.html:
  • fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html:
  • fast/lists/resources/dump-list.js:

(dumpListItemAsHTML):
(testListItemMarkerEqualsListItemText):

  • fast/lists/w3-css3-list-styles-alphabetic.html:
  • fast/lists/w3-css3-list-styles-fallback-style.html:
  • fast/lists/w3-css3-list-styles-numeric.html:
  • fast/lists/w3-css3-list-styles-symbolic.html:
  • fast/lists/w3-css3-lower-armenian.html:
  • fast/lists/w3-css3-upper-armenian.html:
  • fast/lists/w3-list-styles.html:
  • fast/loader/:
  • fast/media/color-does-not-include-alpha.html:
  • fast/media/invalid-lengths.html:
  • fast/media/lifetime.html:
  • fast/media/matchmedium-query-api.html:
  • fast/media/media-query-list-01.html:
  • fast/media/media-query-list-02.html:
  • fast/media/media-query-list-03.html:
  • fast/media/media-query-list-04.html:
  • fast/media/media-query-list-05.html:
  • fast/media/media-query-list-06.html:
  • fast/media/media-query-list-07.html:
  • fast/media/media-query-list-callback.html:
  • fast/media/media-svg-crash.html:
  • fast/media/mq-pointer.html:
  • fast/media/print-restores-previous-mediatype.html:
  • fast/media/update-media-query-css-parser.html:
  • fast/media/view-mode-media-feature.html:
  • fast/multicol/:
  • fast/mutation/end-of-task-delivery.html:
  • fast/mutation/inline-event-listener.html:
  • fast/mutation/mutation-callback-non-element-crash.html:
  • platform/chromium/fast/loader/create-view-target-blank.html:
  • platform/chromium/fast/loader/resources/done.html:
  • platform/gtk/fast/loader/crash-display-local-directory.html:
  • platform/mac/fast/loader/file-url-mimetypes-2.html:
  • platform/mac/fast/loader/file-url-mimetypes-3.html:
  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac/fast/loader/non-html-load-event.html:
  • platform/mac/fast/loader/webarchive-encoding-respected.html:
  • platform/qt/fast/loader/user-stylesheet-qrc-path.html:
6:13 PM Changeset in webkit [122686] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.

  • Scripts/webkitpy/common/config/watchlist:
5:36 PM Changeset in webkit [122685] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add gyuyoung.kim@samsung.com to watch list.

  • Scripts/webkitpy/common/config/watchlist:
4:01 PM Changeset in webkit [122684] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit/mac

Fix case sensitive build issue.

Unreviewed build fix.

  • WebView/WebPreferences.mm:
2:26 PM Changeset in webkit [122683] by Joseph Pecoraro
  • 4 edits
    2 adds in trunk

Windowless WebView not firing JavaScript load event if there is a media element
https://bugs.webkit.org/show_bug.cgi?id=91331

Reviewed by Eric Carlson.

Source/WebCore:

In prepareForLoad we start deferring the load event. If we fall into this
clause where the page can not start loading media we bail, potentially
indefinitely waiting until we can start loading media. Since we can not
be certain this will ever happen, we should stop deferring the page's
load event.

Test: WebKit1.WindowlessWebViewWithMedia TestWebKitAPI test. The only
way this path was reachable right now is on the mac port.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal):

Tools:

Test a windowless WebView loading a page with a media element. The load
event should happen on the next spin of the run loop, but we spin check
the page, with a timeout of 250ms.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
  • TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.

(-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
(TestWebKitAPI::TEST):

1:24 PM Changeset in webkit [122682] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Make WebPreferencesPrivate a simple struct
https://bugs.webkit.org/show_bug.cgi?id=91330

Reviewed by Filip Pizlo.

To avoid taking time creating a new Objective-C object for WebPreferencesPrivate, we can just make
it a simple struct.

  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm:

(WebPreferencesPrivate):
(WebPreferencesPrivate::WebPreferencesPrivate):
Replace the Objective-C WebPreferencesPrivate by a struct.
Remove IBCreatorID from the object as it is unused.
Use RetainPtr for the Objective-C attribute to avoid tracking their memory manually.

(-[WebPreferences initWithIdentifier:]):
Change the order of the initialization to avoid allocating anyting if a WebPreferences exists
for the identifier.
Both [NSObject init] and WebPreferencesPrivate allocation are moved after the fast path.

(-[WebPreferences initWithCoder:]):
(-[WebPreferences encodeWithCoder:]):
(-[WebPreferences dealloc]):
(-[WebPreferences identifier]):
(-[WebPreferences _valueForKey:]):
(-[WebPreferences _setStringValue:forKey:]):
(-[WebPreferences _setIntegerValue:forKey:]):
(-[WebPreferences _setFloatValue:forKey:]):
(-[WebPreferences _setBoolValue:forKey:]):
(-[WebPreferences _setLongLongValue:forKey:]):
(-[WebPreferences _setUnsignedLongLongValue:forKey:]):

1:15 PM Changeset in webkit [122681] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11875795> REGRESSION (tiled drawing): Page’s scroll bars flash with each character you type in a textarea (affects Wikipedia and YouTube)
https://bugs.webkit.org/show_bug.cgi?id=91348

Reviewed by Anders Carlsson.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged): Added an early return if the scroll position
did not, in fact, change. This avoids the call to ScrollAnimator::notifyContentAreaScrolled,
which is what causes the scroll bars to flash.

8:40 AM Changeset in webkit [122680] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/text/descent-clip-in-scaled-page.html
https://bugs.webkit.org/show_bug.cgi?id=91342

Unreviewed EFL gardening. Skip new test added in r122651
that fails on EFL port because our LayoutTestController
does not implement setSubpixelTextPositioning().

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
5:10 AM Changeset in webkit [122679] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip css2.1/20110323/vertical-align-boxes-001.htm
https://bugs.webkit.org/show_bug.cgi?id=91340

Unreviewed EFL gardening. Skipping new test introduced in
r122663 which is failing on EFL port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-15

  • platform/efl/TestExpectations:
Note: See TracTimeline for information about the timeline view.