⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 21, 2012:

2:54 PM Changeset in webkit [123294] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/11928576> SVG-as-image (constrained) intrinsic size calculation is wrong in vertical writing modes
​https://bugs.webkit.org/show_bug.cgi?id=91918

Reviewed by Anders Carlsson.

Source/WebCore:

Test: svg/as-image/svg-intrinsic-size-rectangular-vertical.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox): When there is a content
renderer, it returns a physical intrinsic size and aspect ratio. The code was already
accounting for this by taking the reciprocal of the aspect ratio in the vertical case. Made
it also transpose the size itself, turning it from physical to logical. Moved this code
after setting m_intrinsicSize, since that member variable is always physical.

LayoutTests:

  • svg/as-image/svg-intrinsic-size-rectangular-vertical-expected.html: Added.
  • svg/as-image/svg-intrinsic-size-rectangular-vertical.html: Added.
2:22 PM Changeset in webkit [123293] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

[WIN] Use GetDateFormat and GetTimeFormat instead of strftime
​https://bugs.webkit.org/show_bug.cgi?id=83436

Reviewed by Brent Fulgham.

The MS CRT implementation of strftime calls the same two functions.
Using them directly avoids the overhead of parsing the format string and removes
the dependency on strftime() for WinCE where this function does not exist.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

11:33 AM Changeset in webkit [123292] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-07-21

  • DEPS:
7:50 AM Changeset in webkit [123291] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Cleanup TextEncoding USE(XXX_UNICODE) macros
​https://bugs.webkit.org/show_bug.cgi?id=91923

Reviewed by Andreas Kling.

Replace PLATFORM(QT) with USE(QT4_UNICODE) and OS(WINCE) with USE(WINCE_UNICODE).
This gives us more flexibility in choosing the unicode backend for a port.

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

4:10 AM Changeset in webkit [123290] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Remove unnecessary ICU header includes from SimpleFontDataWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=91922

Reviewed by Kentaro Hara.

This allows us to use SimpleFontDataWin with an other Unicode implementation too.

  • platform/graphics/win/SimpleFontDataWin.cpp:
1:01 AM Changeset in webkit [123289] by kseo@webkit.org
  • 4 edits in trunk/Source/WebCore

A start tag whose tag name is "html" in the "in body" insertion mode is a parse error
​https://bugs.webkit.org/show_bug.cgi?id=91916

Reviewed by Eric Seidel.

According to the HTML5 spec, a start tag whose tag name is "html" in the "in body"
insertion mode is a parse error.

Added HTMLTreeBuilder::processHtmlStartTagForInBody(AtomicHTMLToken&) to call parseError(token).
Removed "FIXME: parse error" from HTMLConstructionSite::insertHTMLHtmlStartTagInBody and
HTMLConstructionSite::insertHTMLBodyStartTagInBody because we already marked the call sites
of these two methods with parseError(token).

No behavior change because parseError(token) is just a marker.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

  • html/parser/HTMLTreeBuilder.h:

Jul 20, 2012:

11:07 PM Changeset in webkit [123288] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

double data type shoud be changed to float in ColorMatrix
​https://bugs.webkit.org/show_bug.cgi?id=91499

Patch by Czene Tamás <​tczene@inf.u-szeged.hu> on 2012-07-20
Reviewed by Nikolas Zimmermann.

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::matrix):
(WebCore::saturate):
(WebCore::huerotate):
(WebCore::luminance):
(WebCore::effectType):

8:58 PM Changeset in webkit [123287] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Remove unused headers from ewk_security_origin
​https://bugs.webkit.org/show_bug.cgi?id=91914

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-07-20
Reviewed by Noam Rosenthal.

There are some unused header in the ewk_security_origin.h/cpp
We need to remove them.

  • ewk/ewk_security_origin.cpp:
  • ewk/ewk_security_origin.h:
8:35 PM Changeset in webkit [123286] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Mark anther test as needing a rebaseline due to r123285.

  • platform/chromium/TestExpectations:
7:50 PM Changeset in webkit [123285] by senorblanco@chromium.org
  • 6 edits in trunk

Source/WebCore: [chromium] Take current transformation matrix into account when
deciding on resize algorithm for drawPattern.
​https://bugs.webkit.org/show_bug.cgi?id=90624

Reviewed by Adrienne Walker.

Since the pattern shader uses both the current transformation matrix
and the pattern matrix when transforming pixels, we need to
do the same when computing the resampling mode. Also removed the
resampling hint code, added in r60658, since it appears to be dead
(caller was removed in r76379).

Covered by existing tests, such as
fast/borders/border-image-scale-transform.html.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::computeResamplingMode):
Pass in the matrix to be used for computing the destination width and
height (for awesome resampling). Remove the image resampling hint code.
(WebCore::paintSkBitmap):
Pass in the CTM to computeResamplingMode().
(WebCore::Image::drawPattern):
Concatenate the CTM and the pattern matrix, and pass that to
computeResamplingMode() and TransformDimensions(). Invert the
CTM's scale and apply it to the pattern transform, so their
concatenation gives identity scale.

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:

Remove the image resampling hint (dead code).

LayoutTests: [chromium] Mark a test as needing a rebaseline due to image change.
​https://bugs.webkit.org/show_bug.cgi?id=90624

Reviewed by Adrienne Walker.

  • platform/chromium/TestExpectations:
7:46 PM Changeset in webkit [123284] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Anything else in the "in table" insertion mode is a parse error
​https://bugs.webkit.org/show_bug.cgi?id=91915

Patch by Kwang Yul Seo <​skyul@company100.net> on 2012-07-20
Reviewed by Adam Barth.

According to the HTML5 spec, anything else in the "in table" insertion mode is a parse error.

No behavior change because parseError(token) is just a marker.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTagForInTable):

7:00 PM Changeset in webkit [123283] by tkent@chromium.org
  • 52 edits in trunk

Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
​https://bugs.webkit.org/show_bug.cgi?id=91846

Reviewed by Kentaro Hara.

A flag name for an elmement should be ENABLE_*_ELEMENT.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • css/html.css:
  • html/HTMLDataListElement.cpp:
  • html/HTMLDataListElement.h:
  • html/HTMLDataListElement.idl:
  • html/HTMLInputElement.cpp:

(WebCore):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::parseAttribute):
(WebCore::HTMLOptionElement::childrenChanged):
(WebCore):

  • html/HTMLOptionElement.h:

(HTMLOptionElement):

  • html/HTMLTagNames.in:
  • html/InputType.cpp:

(WebCore):

  • html/InputType.h:

(InputType):

  • html/RangeInputType.cpp:

(WebCore):

  • html/RangeInputType.h:

(RangeInputType):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout):

  • page/DOMWindow.idl:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • rendering/RenderTheme.cpp:

(WebCore):

  • rendering/RenderTheme.h:

(RenderTheme):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebInputElement.cpp:

(WebKit::WebInputElement::dataListOptions):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
6:52 PM Changeset in webkit [123282] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, one more new baselines after r123272 (I missed SL).

  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
6:03 PM Changeset in webkit [123281] by rniwa@webkit.org
  • 25 edits in trunk/Source/WebCore

Unify HTMLCollection and DynamicNodeList
​https://bugs.webkit.org/show_bug.cgi?id=91335

Reviewed by Anders Carlsson.

This is the grand unification of HTMLCollection and DynamicNodeList.

It merges implementations of item() and length() in ChildNodeList, DynamicNodeList,
and HTMLCollection. The unified implementation is based on the one used for HTMLCollection,
that has been improved over the last few days; see r122660 and r122672 for examples.

There are five key changes:

  1. Made itemBeforeOrAfter aware of DynamicNodeList.
  2. itemBeforeOrAfter and related functions take and return Node* to support ChildNodeList.
  3. Renamed InvalidCollectionType to NodeListCollectionType since DynamicNodeLists need to be

identified itemBeforeOrAfter.

  1. Renamed itemAfter to virtualItemAfter in subclasses of HTMLCollection, and devirtualized

itemAfter used in common cases to avoid performance regressions. To make this intent clear,
SupportItemBefore and DoNotSupportItemBefore have been renamed to DoesNotOverrideItemAfter
and OverridesItemAfter. This change also help us detect a subclass of HTMLCollection that
passes in a wrong value to ItemBeforeSupportType by making forward iterations fail (hit an
assertion or doesn't iterate at all) as well as backward iterations.

  1. Restricted the use of elementsArrayOffset to subclasses that provide virtualItemAfter.

This patch completes my effort to share code between HTMLCollection and DynamicNodeList.

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::ChildNodeList):
(WebCore): Removed length() and item().
(WebCore::ChildNodeList::nodeMatches):

  • dom/ChildNodeList.h:

(ChildNodeList):

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

  • dom/Document.cpp:

(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::length):
(WebCore::DynamicNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Takes new boolean argument
shouldOnlyIncludeDirectChildren indicating whether the non-child descendents should be
included or not. This is necessary to identify ChildNodeList in itemBeforeOrAfter.
(WebCore::DynamicNodeListCacheBase::ownerNode): Moved from DynamicNodeListCacheBase and
HTMLCollectionCacheBase.
(WebCore::DynamicNodeListCacheBase::document): Moved from DynamicNodeListCacheBase.
(WebCore::DynamicNodeListCacheBase::rootNode): Ditto.
(WebCore::DynamicNodeListCacheBase::overridesItemAfter): Renamed from supportsItemBefore
and the return value has been negated.
(WebCore::DynamicNodeListCacheBase::shouldOnlyIncludeDirectChildren): Added.
(WebCore::DynamicNodeListCacheBase):
(WebCore::DynamicNodeList::DynamicNodeList): Takes NodeListType to determine the value of
shouldOnlyIncludeDirectChildren.
(DynamicNodeList):
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::MicroDataItemList):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):

  • html/CollectionType.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):

  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::isAcceptableElement):
(WebCore::firstNode): Extracted from itemBeforeOrAfter.
(WebCore::DynamicNodeListCacheBase::iterateForNextNode): Ditto.
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter): Takes and returns Node*.
Special case ChildNodeList since there is no need to skip any node. When "this" is a
node list, call nodeMatches instead of isAcceptableElement.
(WebCore::DynamicNodeListCacheBase::itemBefore): No longer takes offsetInArray since
the use of elementsArrayOffset has been restricted to HTMLCollections that provides
virtualItemAfter.
(WebCore::DynamicNodeListCacheBase::itemAfter): Calls virtualItemAfter if necessary.
Otherwise assert offsetInArray is zero since we should never be using this variable
when virtualItemAfter is not provided.
(WebCore::DynamicNodeListCacheBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::DynamicNodeListCacheBase::isFirstItemCloserThanCachedItem):
(WebCore::DynamicNodeListCacheBase::setItemCache): Updates m_cachedElementsArrayOffset
in HTMLCollection if and only if virtualItemAfter is provided. This is safe because
node lists never provide virtualItemAfter.
(WebCore::DynamicNodeListCacheBase::cachedElementsArrayOffset): Similarly, returns
m_cachedElementsArrayOffset if virtualItemAfter is provided.
(WebCore::DynamicNodeListCacheBase::lengthCommon):
(WebCore::DynamicNodeListCacheBase::itemCommon): Note that supportsItemBefore() is
equivalent to !overridesItemAfter() here.
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfterCachedItem): Uses Node* through
out the function. Since itemBefore never uses offsetInArray, always sets 0 for that.
Note that we never call itemBefore and virtualItemAfter on the same object.
(WebCore::HTMLCollection::virtualItemAfter): Added only to make the class "concrete".
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::tags):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollectionCacheBase):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::base):
(HTMLCollection):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::virtualItemAfter):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::virtualItemAfter):

  • html/HTMLNameCollection.h:

(HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::virtualItemAfter):
(WebCore::HTMLPropertiesCollection::updateNameCache):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::virtualItemAfter):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

5:33 PM Changeset in webkit [123280] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

[chromium] Unreviewed, one more new baselines after r123272.

  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
5:28 PM Changeset in webkit [123279] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Store test pipes in /data/local/tmp
​https://bugs.webkit.org/show_bug.cgi?id=91909

In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
However after tests we found some devices don't allow the app to create pipes there.
So /data/local/tmp is a better place for the pipes.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:
5:24 PM Changeset in webkit [123278] by tony@chromium.org
  • 49 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed, land new baselines after r123272.

  • platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-mac/media/controls-styling-strict-expected.txt: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-win/media/controls-styling-strict-expected.txt: Added.
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
4:56 PM Changeset in webkit [123277] by caio.oliveira@openbossa.org
  • 35 edits in trunk/LayoutTests

[Qt] svg/text rebaseline after new test fonts (part 4)
​https://bugs.webkit.org/show_bug.cgi?id=91905

Unreviewed.

Two tests, svg/text/foreignObject-text-clipping-bug.xml and
svg/text/scaling-font-with-geometric-precision.html, still have incorrect results.

This is not a regression because they were incorrect before, but had expected files with
the wrong results. Instead of updating wrong expectations, I kept them skipped but created
a new bug to track each one.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/text/font-size-below-point-five-2-expected.png:
  • platform/qt/svg/text/font-size-below-point-five-2-expected.txt:
  • platform/qt/svg/text/font-size-below-point-five-expected.png:
  • platform/qt/svg/text/font-size-below-point-five-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
  • platform/qt/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/qt/svg/text/modify-text-node-in-tspan-expected.txt:
  • platform/qt/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/qt/svg/text/remove-text-node-from-tspan-expected.txt:
  • platform/qt/svg/text/remove-tspan-from-text-expected.png:
  • platform/qt/svg/text/remove-tspan-from-text-expected.txt:
  • platform/qt/svg/text/text-altglyph-01-b-expected.png:
  • platform/qt/svg/text/text-altglyph-01-b-expected.txt:
  • platform/qt/svg/text/text-deco-01-b-expected.png:
  • platform/qt/svg/text/text-deco-01-b-expected.txt:
  • platform/qt/svg/text/text-fill-opacity-expected.png:
  • platform/qt/svg/text/text-fill-opacity-expected.txt:
  • platform/qt/svg/text/text-fonts-02-t-expected.png:
  • platform/qt/svg/text/text-fonts-02-t-expected.txt:
  • platform/qt/svg/text/text-gradient-positioning-expected.png:
  • platform/qt/svg/text/text-gradient-positioning-expected.txt:
  • platform/qt/svg/text/text-midpoint-split-bug-expected.png:
  • platform/qt/svg/text/text-midpoint-split-bug-expected.txt:
  • platform/qt/svg/text/text-path-middle-align-expected.txt:
  • platform/qt/svg/text/text-repaint-rects-expected.png:
  • platform/qt/svg/text/text-repaint-rects-expected.txt:
  • platform/qt/svg/text/text-spacing-01-b-expected.png:
  • platform/qt/svg/text/text-spacing-01-b-expected.txt:
  • platform/qt/svg/text/text-tref-01-b-expected.png:
  • platform/qt/svg/text/text-tref-01-b-expected.txt:
  • platform/qt/svg/text/text-viewbox-rescale-expected.png:
  • platform/qt/svg/text/text-viewbox-rescale-expected.txt:
  • platform/qt/svg/text/textPathBoundsBug-expected.txt:
4:54 PM Changeset in webkit [123276] by jsbell@chromium.org
  • 15 edits in trunk/Source

IndexedDB: Simplify backend interface classes
​https://bugs.webkit.org/show_bug.cgi?id=91901

Reviewed by Tony Chang.

Source/WebCore:

The IDBTransactionBackendInterface included several methods only used by the
real implementation objects, not via the interfaces. Expose a static Impl::from(Interface)
method for transaction, and migrate all of the backend-internal uses from Interface to Impl.

No new tests - no functional changes.

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore):
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::countInternal): Drop unused transaction argument.
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal): Drop unused transaction argument.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::from):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(IDBTransactionBackendInterface):

Source/WebKit/chromium:

Remove unnecessary method stubs from proxy class.

  • src/IDBTransactionBackendProxy.cpp:
  • src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

4:51 PM Changeset in webkit [123275] by jsbell@chromium.org
  • 5 edits
    3 adds in trunk

IndexedDB: "ASSERTION FAILED: !m_requestFinished" hit in IDBRequest::dispatchEvent
​https://bugs.webkit.org/show_bug.cgi?id=86911

Reviewed by Tony Chang.

Source/WebCore:

Clean up the IDBRequest/IDBCursor relationship and the IDBRequest lifecycle.

The IDBRequest's m_cursor/setCursor() calls are renamed to m_pendingCursor/setPendingCursor() to
clarify that the request will move between two states - either there's a cursor request in-flight
c/o a continue() or advance() call, or the result has come in (cursor, null-for-done, or error).
Since they were only ever used together, resetReadyState() is merged into setResultCursor(). The
m_requestFinished flag becomes redundant and is dropped - the ASSERT reported in the bug
becomes an ASSERT(m_readyState == PENDING) and m_readyState tracking is already correct.

Test: storage/indexeddb/request-continue-abort.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance): Unreachable code path now dead and gone.
(WebCore::IDBCursor::continueFunction): Ditto.

  • Modules/indexeddb/IDBRequest.cpp: Most functions just add state assertions.

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::setPendingCursor): Merge with old resetReadyState().
(WebCore):
(WebCore::IDBRequest::getResultCursor): Helper, since digging cursor out of IDBAny is pesky.
(WebCore::IDBRequest::setResultCursor): Just moved in the file to be with its friends.
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onError): Just assertions, re-ordering, re-naming.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::hasPendingActivity):
(WebCore::IDBRequest::dispatchEvent): Simplify!
(WebCore::IDBRequest::enqueueEvent):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

LayoutTests:

Added regression test based on repro steps in the bug.

  • storage/indexeddb/request-continue-abort-expected.txt: Added.
  • storage/indexeddb/request-continue-abort.html: Added.
  • storage/indexeddb/resources/request-continue-abort.js: Added.

(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(onUpgrade):
(testCursor.request.onsuccess):
(testCursor.request.onerror):
(testCursor.transaction.onabort):
(testCursor):

4:39 PM Changeset in webkit [123274] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add windows native versions of bison, flex and gperf.

Patch by Scott Graham <​scottmg@chromium.org> on 2012-07-20
Reviewed by Tony Chang.

  • DEPS:
4:15 PM Changeset in webkit [123273] by caio.oliveira@openbossa.org
  • 22 edits
    8 deletes in trunk/LayoutTests

[Qt] svg/text rebaseline after new test fonts (part 3)
​https://bugs.webkit.org/show_bug.cgi?id=91904

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Removed.
  • platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-tselect-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-tselect-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-tspan-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-tspan-01-b-expected.txt: Removed.
  • platform/qt/svg/text/append-text-node-to-tspan-expected.png:
  • platform/qt/svg/text/append-text-node-to-tspan-expected.txt:
  • platform/qt/svg/text/ems-display-none-expected.png:
  • platform/qt/svg/text/ems-display-none-expected.txt:
  • platform/qt/svg/text/exs-display-none-expected.png:
  • platform/qt/svg/text/exs-display-none-expected.txt:
  • platform/qt/svg/text/foreignObject-repaint-expected.png:
  • platform/qt/svg/text/foreignObject-repaint-expected.txt:
  • platform/qt/svg/text/scaled-font-expected.png:
  • platform/qt/svg/text/scaled-font-expected.txt:
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.png:
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
  • platform/qt/svg/text/text-tselect-01-b-expected.png:
  • platform/qt/svg/text/text-tselect-01-b-expected.txt:
  • platform/qt/svg/text/text-tspan-01-b-expected.png:
  • platform/qt/svg/text/text-tspan-01-b-expected.txt:
  • platform/qt/svg/text/text-ws-01-t-expected.png:
  • platform/qt/svg/text/text-ws-01-t-expected.txt:
  • platform/qt/svg/text/text-ws-02-t-expected.png:
  • platform/qt/svg/text/text-ws-02-t-expected.txt:
4:06 PM Changeset in webkit [123272] by scherkus@chromium.org
  • 3 edits in trunk

[chromium] Don't display fullscreen button for video elements not containing video
​https://bugs.webkit.org/show_bug.cgi?id=91811

Reviewed by Eric Carlson.

Covered by media/media-document-audio-repaint.html

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::reset):

4:03 PM Changeset in webkit [123271] by scherkus@chromium.org
  • 36 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed rebaselined due to r123259.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/TestExpectations:
3:56 PM Changeset in webkit [123270] by commit-queue@webkit.org
  • 67 edits
    64 adds in trunk/LayoutTests

[Qt] ietestcenter needs rebaseline after new test fonts
​https://bugs.webkit.org/show_bug.cgi?id=91886

Updating skipped tests inside ietestcenter. The following tests
remain skipped:
/css3/bordersbackgrounds/border-radius-style-001-expected.txt (not using dashed line)
/css3/bordersbackgrounds/border-radius-style-002-expected.txt (not using dashed line)
/css3/text/textshadow-002-expected.txt (missing bar on top of blue text)

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-20
Reviewed by Noam Rosenthal.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt:
3:56 PM Changeset in webkit [123269] by dimich@chromium.org
  • 4 edits in trunk/Source/WebCore

[Chromium] Out of Memory is observed when a large object is passed to a Web Worker.
​https://bugs.webkit.org/show_bug.cgi?id=91535.

Reviewed by David Levin.

No new tests because of no new behavior and lack of mechanism to monitor used memory.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::registerMemoryAllocatedWithCurrentScriptContext):
(WebCore):
(WebCore::SerializedScriptValue::~SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):
Added a method to SerializedScriptValue to add memory pressure on GC proportional to the size of memory allocated in serialized data.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
Call the new method of SerializedScriptValue during creation of MessageEvent (presumably in the thread which contains the right V8 context).

3:41 PM Changeset in webkit [123268] by caio.oliveira@openbossa.org
  • 25 edits
    1 add
    10 deletes in trunk/LayoutTests

[Qt] svg/text rebaseline after new test fonts (part 2)
​https://bugs.webkit.org/show_bug.cgi?id=91902

Reviewed by Noam Rosenthal.

  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.txt: Removed.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/text-align-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-align-02-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-02-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-align-04-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-04-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-align-06-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-06-b-expected.txt: Removed.
  • platform/qt/svg/text/multichar-glyph-expected.png:
  • platform/qt/svg/text/multichar-glyph-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.png: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.png:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.png:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/text/text-align-01-b-expected.png:
  • platform/qt/svg/text/text-align-01-b-expected.txt:
  • platform/qt/svg/text/text-align-02-b-expected.png:
  • platform/qt/svg/text/text-align-02-b-expected.txt:
  • platform/qt/svg/text/text-align-03-b-expected.png:
  • platform/qt/svg/text/text-align-03-b-expected.txt:
  • platform/qt/svg/text/text-align-04-b-expected.png:
  • platform/qt/svg/text/text-align-04-b-expected.txt:
  • platform/qt/svg/text/text-align-05-b-expected.png:
  • platform/qt/svg/text/text-align-05-b-expected.txt:
  • platform/qt/svg/text/text-align-06-b-expected.png:
  • platform/qt/svg/text/text-align-06-b-expected.txt:
  • platform/qt/svg/text/text-path-01-b-expected.png:
  • platform/qt/svg/text/text-path-01-b-expected.txt:
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.png:
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.txt:
2:56 PM Changeset in webkit [123267] by dgrogan@chromium.org
  • 6 edits in trunk/Source

IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
​https://bugs.webkit.org/show_bug.cgi?id=91414

Reviewed by Adam Barth.

Source/WebCore:

No new tests because no new behavior.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):
No behavior change, this just needs a dummy parameter to match the
modified API.

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

2:45 PM Changeset in webkit [123266] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: [Soup] Unnecessary RefPtr usage and null check
​https://bugs.webkit.org/show_bug.cgi?id=91636

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-07-18
Reviewed by Martin Robinson.

Small clean up of code that is not necessary; no change in functionality.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::connected):

Source/WebKit/blackberry: [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
​https://bugs.webkit.org/show_bug.cgi?id=91898

Patch by Jacky Jiang <​zhajiang@rim.com> on 2012-07-20
Reviewed by Yong Li.

PR: 181043
Use CLOCK_MONOTONIC when we do expect a monotonic timer.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

LayoutTests: [Qt] svg/text rebaseline after new test fonts (part 1)
​https://bugs.webkit.org/show_bug.cgi?id=91762

Patch by Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org> on 2012-07-20
Reviewed by Andreas Kling.

  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Removed.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/text-text-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/kerning-expected.txt:
  • platform/qt/svg/text/small-fonts-2-expected.png:
  • platform/qt/svg/text/small-fonts-2-expected.txt:
  • platform/qt/svg/text/small-fonts-3-expected.png:
  • platform/qt/svg/text/small-fonts-3-expected.txt:
  • platform/qt/svg/text/small-fonts-expected.png:
  • platform/qt/svg/text/small-fonts-expected.txt: Added.
  • platform/qt/svg/text/small-fonts-in-html5-expected.png:
  • platform/qt/svg/text/small-fonts-in-html5-expected.txt:
  • platform/qt/svg/text/text-text-01-b-expected.png:
  • platform/qt/svg/text/text-text-01-b-expected.txt:
  • platform/qt/svg/text/text-text-03-b-expected.png:
  • platform/qt/svg/text/text-text-03-b-expected.txt:
  • platform/qt/svg/text/text-text-04-t-expected.png:
  • platform/qt/svg/text/text-text-04-t-expected.txt:
  • platform/qt/svg/text/text-text-05-t-expected.png:
  • platform/qt/svg/text/text-text-05-t-expected.txt:
  • platform/qt/svg/text/text-text-06-t-expected.png:
  • platform/qt/svg/text/text-text-06-t-expected.txt:
  • platform/qt/svg/text/text-text-07-t-expected.png:
  • platform/qt/svg/text/text-text-07-t-expected.txt:
  • platform/qt/svg/text/text-text-08-b-expected.png:
  • platform/qt/svg/text/text-text-08-b-expected.txt:
2:41 PM Changeset in webkit [123265] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Unnecessary RefPtr usage and null check
​https://bugs.webkit.org/show_bug.cgi?id=91636

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2012-07-18
Reviewed by Martin Robinson.

Small clean up of code that is not necessary; no change in functionality.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::connected):

2:40 PM Changeset in webkit [123264] by caio.oliveira@openbossa.org
  • 25 edits
    1 add
    6 deletes in trunk/LayoutTests

[Qt] svg/text rebaseline after new test fonts (part 1)
​https://bugs.webkit.org/show_bug.cgi?id=91762

Reviewed by Andreas Kling.

  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Removed.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/text-text-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/kerning-expected.txt:
  • platform/qt/svg/text/small-fonts-2-expected.png:
  • platform/qt/svg/text/small-fonts-2-expected.txt:
  • platform/qt/svg/text/small-fonts-3-expected.png:
  • platform/qt/svg/text/small-fonts-3-expected.txt:
  • platform/qt/svg/text/small-fonts-expected.png:
  • platform/qt/svg/text/small-fonts-expected.txt: Added.
  • platform/qt/svg/text/small-fonts-in-html5-expected.png:
  • platform/qt/svg/text/small-fonts-in-html5-expected.txt:
  • platform/qt/svg/text/text-text-01-b-expected.png:
  • platform/qt/svg/text/text-text-01-b-expected.txt:
  • platform/qt/svg/text/text-text-03-b-expected.png:
  • platform/qt/svg/text/text-text-03-b-expected.txt:
  • platform/qt/svg/text/text-text-04-t-expected.png:
  • platform/qt/svg/text/text-text-04-t-expected.txt:
  • platform/qt/svg/text/text-text-05-t-expected.png:
  • platform/qt/svg/text/text-text-05-t-expected.txt:
  • platform/qt/svg/text/text-text-06-t-expected.png:
  • platform/qt/svg/text/text-text-06-t-expected.txt:
  • platform/qt/svg/text/text-text-07-t-expected.png:
  • platform/qt/svg/text/text-text-07-t-expected.txt:
  • platform/qt/svg/text/text-text-08-b-expected.png:
  • platform/qt/svg/text/text-text-08-b-expected.txt:
2:31 PM Changeset in webkit [123263] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove a test that hasn't been
added to the tree yet.

  • platform/chromium/TestExpectations:
2:27 PM Changeset in webkit [123262] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored
​https://bugs.webkit.org/show_bug.cgi?id=91506

Patch by Mark Salisbury <​mark.salisbury@hp.com> on 2012-07-20
Reviewed by Joseph Pecoraro.

No new test. The "fallback fallback" code ends up creating a font, so you always
get a fallback font even with this code bug. A test would be buggy, being highly
platform dependent on what the "fallback fallback" font is on the particular
windows machine the test runs on.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

2:24 PM Changeset in webkit [123261] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark some tests as slow in debug.

  • platform/chromium/TestExpectations:
2:24 PM Changeset in webkit [123260] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Clean up scratch texture usage in Chromium's implementation
of GPU-accelerated filters.
​https://bugs.webkit.org/show_bug.cgi?id=83370

Reviewed by Adrienne Walker.

There didn't used to be a safe way to allocate a scratch texture, and
hold into it beyond the lifetime of GrAutoScratchTexture. Now there is:
detach().

Covered by existing tests in css3/filters.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):
Use a GrAutoScratchTexture to allocate the destination texture, and
detach() to detach it from the cache before placing it in an
SkGrTexturePixelRef. This means we no longer need to do any lock/
unlock trickery with the TextureCacheEntry, since the refcount is
enough to keep the texture away from the cache's prying hands.

2:12 PM Changeset in webkit [123259] by scherkus@chromium.org
  • 4 edits
    1 add in trunk

[chromium] CSS tweaks to media controls to prevent styles from being overridden
​https://bugs.webkit.org/show_bug.cgi?id=91802

Reviewed by Eric Carlson.

Source/WebCore:

Having the buttons declared as inline caused them to not be included in the box layout,
resulting in styles set outside the media element to affect the position of the buttons.

In a similar vein, it was also possible to override the font-style attribute for the time
display.

Test: media/controls-styling-strict.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

  • media/controls-styling-strict.html: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.
2:08 PM Changeset in webkit [123258] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
​https://bugs.webkit.org/show_bug.cgi?id=91873

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:
2:01 PM Changeset in webkit [123257] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Unskip some tests that just need new baselines.

  • platform/chromium/TestExpectations:
2:01 PM Changeset in webkit [123256] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6
​https://bugs.webkit.org/show_bug.cgi?id=91752

Patch by Robert Sesek <​rsesek@chromium.org> on 2012-07-20
Reviewed by Eric Seidel.

Use 10.6 NSScreen/NSColorSpace APIs to determine if the screen is
monochrome rather than comparing against deprecated colorspace names.

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

1:42 PM Changeset in webkit [123255] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add Cancel button for Select popup
​https://bugs.webkit.org/show_bug.cgi?id=91887

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-07-20
Reviewed by Yong Li.

PR 177706

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):
(WebCore::SelectPopupClient::setValueAndClosePopup):

1:24 PM Changeset in webkit [123254] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source/WebKit/chromium

Introduce WebViewBenchmarkSupport for performance experiments on a real WebView
​https://bugs.webkit.org/show_bug.cgi?id=88271

Patch by Daniel Murphy <​dmurph@chromium.org> on 2012-07-20
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::benchmarkSupport):

  • public/WebViewBenchmarkSupport.h: Added.

(WebKit):
(WebViewBenchmarkSupport):
(PaintClient):
(WebKit::WebViewBenchmarkSupport::PaintClient::willPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::didPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::~PaintClient):
(WebKit::WebViewBenchmarkSupport::~WebViewBenchmarkSupport):

  • src/WebViewBenchmarkSupportImpl.cpp: Added.

(WebKit):
(WebKit::WebViewBenchmarkSupportImpl::paintLayer):
(WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):
(WebKit::WebViewBenchmarkSupportImpl::softwarePaint):
(WebKit::WebViewBenchmarkSupportImpl::paint):

  • src/WebViewBenchmarkSupportImpl.h: Added.

(WebCore):
(WebKit):
(WebViewBenchmarkSupportImpl):
(WebKit::WebViewBenchmarkSupportImpl::WebViewBenchmarkSupportImpl):
(WebKit::WebViewBenchmarkSupportImpl::~WebViewBenchmarkSupportImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::benchmarkSupport):
(WebKit):
(WebKit::WebViewImpl::rootGraphicsLayer):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

1:09 PM Changeset in webkit [123253] by commit-queue@webkit.org
  • 11 edits in trunk

[Chromium] Compilation fails under gcc 4.7
​https://bugs.webkit.org/show_bug.cgi?id=90227

Patch by Han Shen <​shenhan@google.com> on 2012-07-20
Reviewed by Tony Chang.

Disable warnings about c++0x compatibility in gcc newer than 4.6.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKitUnitTests.gyp:

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1:07 PM Changeset in webkit [123252] by tony@chromium.org
  • 7 edits
    1 move
    5 adds in trunk/LayoutTests

[chromium] Rebaseline css3/filters/custom tests
​https://bugs.webkit.org/show_bug.cgi?id=82372

Unreviewed, but unofficially reviewed by Chiculita Alexandru and Stephen White.

Add baselines for these tests. They are enabled and use the Mesa
software renderer.

  • platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/missing-custom-filter-shader-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png.
  • platform/chromium/TestExpectations:
1:02 PM Changeset in webkit [123251] by jchaffraix@webkit.org
  • 18 edits
    5 deletes in branches/chromium/1180

Revert 117339 - CSS 2.1 failure: inline-table-001 fails
​https://bugs.webkit.org/show_bug.cgi?id=84167

Reviewed by Julien Chaffraix.

Source/WebCore:

Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.

Tests:

css2.1/20110323/inline-table-001.htm
css2.1/20110323/inline-table-002a.htm
css2.1/20110323/inline-table-003.htm
fast/css/empty-cell-baseline.html

  • rendering/RenderTable.cpp:

(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a

baseline. Tested by fast/css/empty-cell-baseline.html

LayoutTests:

  • css2.1/20110323/inline-table-001.htm: Added.
  • css2.1/20110323/inline-table-002a.htm: Added.
  • css2.1/20110323/inline-table-003.htm: Added. From the CSS 2.1 test suite.
  • fast/css/empty-cell-baseline-expected.html: Added.
  • fast/css/empty-cell-baseline.html: Added. This ensures we don't take a baseline from an empty cell.
  • fast/inline-block/001.html: Modified to make expected results clearer.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:

Progression, the baseline of the text in each cell has moved up to where it should be.

  • platform/chromium-linux/editing/selection/iframe-expected.png:

Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.

  • platform/chromium-linux/editing/selection/inline-table-expected.png:

Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.

  • platform/chromium-linux/editing/selection/table-caret-3-expected.png:

Progression, 'foo' and 'baz' line up with the first row of the inline table.

  • platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:

Progression, 'Test' and 'content' now line up.

  • platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:

Progression, the two boxes now line up.

  • platform/chromium-linux/fast/inline-block/001-expected.png:

Progression, the boxes now line up in the same way as FF and Opera.

  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:

Progression, the baseline of the text in each cell has moved up to where it should be.

  • platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/chromium-win/editing/selection/iframe-expected.txt:
  • platform/chromium-win/editing/selection/inline-table-expected.txt:
  • platform/chromium-win/editing/selection/table-caret-3-expected.txt:
  • platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/chromium-win/fast/inline-block/001-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:

Text rebaselines.

TBR=​robert@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10807056

12:59 PM Changeset in webkit [123250] by dpranke@chromium.org
  • 4 edits in trunk/Tools

REGRESSION: run-perf-tests --pause-before-testing is broken
​https://bugs.webkit.org/show_bug.cgi?id=91789

Reviewed by Ryosuke Niwa.

Turns out start() wasn't actually starting things :(. Fixed, and
added tests.

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_read_prompt):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.init):
(Driver._start):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):
(MockServerProcess.init):
(MockServerProcess.start):

12:43 PM Changeset in webkit [123249] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebKit2

QtNetworkAccessManager should not rely on signal sslErrors when QT_NO_SSL is defined
​https://bugs.webkit.org/show_bug.cgi?id=91866

Reviewed by Noam Rosenthal.

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager): QNAM's signal is only defined when
that flag is undefined. Removed the connection when we have the flag set.
(WebKit::QtNetworkAccessManager::onSslErrors): When the flag is set, this slot becomes unused.

12:43 PM Changeset in webkit [123248] by scheib@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed compile fix, r123247 included unintended changes to Document.cpp.

See ​http://trac.webkit.org/changeset/123247.

  • dom/Document.cpp:

(WebCore::Document::webkitExitPointerLock):

12:17 PM Changeset in webkit [123247] by scheib@chromium.org
  • 13 edits
    1 move
    1 add in trunk

Move pointer lock test resources to http/tests/resources in preparation for adding new tests to http.
​https://bugs.webkit.org/show_bug.cgi?id=91882

Reviewed by Adrienne Walker.

  • http/tests/resources/pointer-lock/pointer-lock-test-harness.js: Renamed from LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js.
  • pointer-lock/bug90391-move-then-window-open-crash.html:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/lock-element-not-in-dom.html:
  • pointer-lock/lock-fail-responses.html:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:
  • pointer-lock/locked-element-removed-from-dom.html:
  • pointer-lock/mouse-event-api.html:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlocklost-event.html:
11:58 AM Changeset in webkit [123246] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, adding platform-specific baseline for
fast/dom/Window/window-properties-performance.html that assumes jsHeapSizeLimit
attribute to be undefined, as expected for ports using JavaScriptCore.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/Window/window-properties-performance-expected.txt: Added.
11:43 AM Changeset in webkit [123245] by wsiegrist@apple.com
  • 1 edit in trunk/Websites/bugs.webkit.org/attachment.cgi

Add /usr/bin to PATH so PrettyPatch can find git.

11:40 AM Changeset in webkit [123244] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, adding image baseline for
fast/images/paletted-png-with-color-profile.html.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/images/paletted-png-with-color-profile-expected.png: Added.
11:28 AM Changeset in webkit [123243] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r122873): 15% regression on Dromaeo/dom-attr
​https://bugs.webkit.org/show_bug.cgi?id=91827

Reviewed by Anders Carlsson.

Move shouldInvalidateNodeListCaches from Document.cpp to Node.cpp since it's only called
in Node::invalidateNodeListCachesInAncestors.

Test: PerformanceTests/Dromaeo/dom-attr.html.

  • dom/Document.cpp:

(WebCore):

  • dom/Node.cpp:

(WebCore::shouldInvalidateNodeListCachesForAttr): Extracted from shouldInvalidateNodeListCaches
to unroll the loop in shouldInvalidateNodeListCaches. Apparently gcc wasn't doing the right thing.
(WebCore::Document::shouldInvalidateNodeListCaches):
(WebCore::Document::invalidateNodeListCaches):
(WebCore::Node::invalidateNodeListCachesInAncestors):

11:27 AM Changeset in webkit [123242] by schenney@chromium.org
  • 114 edits
    4 adds
    1 delete in trunk/LayoutTests

SVG Filter Effect sub-region not applied for some filters
​https://bugs.webkit.org/show_bug.cgi?id=89767

Reviewed by Dirk Schulze.

Unreviewed test expectations update.

Numerous results changed by one pixel due to the difference between
clipping and pre-applying the filter subregion. Some feGaussianBlur
and feDropShadow results changed more, but that was expected.

  • platform/chromium-linux-x86/svg/batik/filters: Removed.
  • platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-subregion-expected.png: Added.
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-mac/svg/filters/feGaussianBlur-subregion-expected.png: Added.
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/feOffset-expected.png:
  • platform/chromium-mac/svg/filters/feTile-expected.png:
  • platform/chromium-mac/svg/filters/filter-placement-issue-expected.png:
  • platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-mac/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/filters/filterRes1-expected.png:
  • platform/chromium-mac/svg/filters/filterRes3-expected.png:
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-subregion-expected.png: Added.
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-subregion-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-placement-issue-expected.png:
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png:
  • platform/chromium-win/svg/filters/filterRes1-expected.png:
  • platform/chromium-win/svg/filters/filterRes3-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/TestExpectations:
11:19 AM Changeset in webkit [123241] by abarth@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Add WebView::zoomToFindInPageRect for Android
​https://bugs.webkit.org/show_bug.cgi?id=91801

Reviewed by Tony Chang.

On Android, when you find in page, we scale the viewport to reveal what
you've found (because the screen is small). This function instructs the
WebView to zoom to display a given rect.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animateZoomAroundPoint):

  • This function is a bit more general than necessary for this patch because it is also used in other cases for animating a zoom around a given point (e.g., double-tap to zoom). These uses will be upstreamed in later patches.

(WebKit::WebViewImpl::zoomToFindInPageRect):

  • src/WebViewImpl.h:

(WebViewImpl):

11:13 AM Changeset in webkit [123240] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
​https://bugs.webkit.org/show_bug.cgi?id=91847

Reviewed by Adam Barth.

This allows for including the TestIntefaces.h from content shell
without introducing a dependency to WebCore/wtf

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

11:11 AM Changeset in webkit [123239] by thakis@chromium.org
  • 14 edits in trunk/Source/WebCore

Fix more -Wunused-private-field violations
​https://bugs.webkit.org/show_bug.cgi?id=91876

Reviewed by Adam Barth.

As of ​http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
the warning finds more bugs. Fix them.

  • html/FTPDirectoryDocument.cpp:

(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageResource.h:

(InspectorDOMStorageResource):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::RenderSVGTextPath):

  • rendering/svg/RenderSVGTextPath.h:
11:10 AM Changeset in webkit [123238] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.
Un-marking various tests as flaky on WIN following rollback of r121610
in ​http://trac.webkit.org/changeset/123110. Investigation documented in:
​https://bugs.webkit.org/show_bug.cgi?id=90469

  • platform/chromium/TestExpectations:
11:05 AM Changeset in webkit [123237] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Tools

[Qt] Make WTR use the same color palette as DRT
​https://bugs.webkit.org/show_bug.cgi?id=91870

Reviewed by Noam Rosenthal.

Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
standard from QWindowsStyle.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts): Moved code to platformInitialize since setting style is not
exactly font related.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::InjectedBundle::platformInitialize): Force the usage of the style's
palette. Because at this point QApplication was already instantiated, the
default palette was already initialized to be the system one, so we need to
explicitly set the palette to be the standard from style. This is not needed in
DRT because there we set the style before instantiating QApplication.

11:02 AM Changeset in webkit [123236] by zandobersek@gmail.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Generating baselines for two input placeholder tests that fail. The image
baselines used are from Chromium Linux that clearly denote what's missing
in the GTK port's output for these two tests, ignoring other marginal
rendering differences.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Added.
  • platform/gtk/fast/forms/textarea: Added.
  • platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.
11:01 AM Changeset in webkit [123235] by eae@chromium.org
  • 28 edits
    2 copies in branches/chromium/1180

Merge 122883 - vertical-align: middle causes overflow with subpixel layout
​https://bugs.webkit.org/show_bug.cgi?id=91464

Reviewed by Eric Seidel.

Source/WebCore:

Using vertical-align: middle in combination with an overflow value other
than visible can cause the overflow height to be computed incorrectly.

Test: fast/sub-pixel/vertical-align-middle-overflow.html

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):
Round verticalPosition after calculation instead of flooring the result
of the xHeight calculation. By flooring it the resulting value is in
effect rounded up which can cause the height of the box to grow by one.
By rounding the resulting value thevertical position is more accurate and
the off by one error is avoided.

LayoutTests:

Add new test for vertical-align: middle and adjust existing results to
reflect the improved alignment calculation.

  • fast/sub-pixel/vertical-align-middle-overflow-expected.txt: Added.
  • fast/sub-pixel/vertical-align-middle-overflow.html: Added.
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-linux/fast/inline/002-expected.png:
  • platform/chromium-linux/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/002-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-mac/fast/block/basic/014-expected.txt:
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/fast/block/basic/014-expected.txt:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/inline/002-expected.txt:
  • platform/chromium-win/fast/table/table-display-types-strict-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/fast/inline/002-expected.txt:
  • platform/mac/fast/replaced/008-expected.png:
  • platform/mac/fast/table/table-display-types-strict-expected.txt:

TBR=​eae@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10796066

10:56 AM Changeset in webkit [123234] by eae@chromium.org
  • 7 edits
    2 copies in branches/chromium/1180

Merge 122861 - Incorrect offset used for scrollWidth/Height calculation
​https://bugs.webkit.org/show_bug.cgi?id=91461

Reviewed by Eric Seidel.

Source/WebCore:

Due to a different offset being used to calculate the scrollWidth/Height
and pixelSnappedClientWidth/Height the scroll value can be off by one in
same cases. This can causes scrollbars to appear even when there is no
overflow.

Test: fast/sub-pixel/block-with-margin-overflow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
Change location offset passed to snapSizeToPixel to include x() to match
offset used by pixelSnappedClientWidth.

(WebCore::RenderBox::scrollHeight):
Change location offset passed to snapSizeToPixel to include y() to match
offset used by pixelSnappedClientHeight.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Change calculation to use pixelSnappedClientWidth/Height as it is
subtracted from the pixel snapped scrollWidth/Height values.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Change RenderLayer versions of scrollWidth/Height to include x()/y() as
per the RenderBox versions.

LayoutTests:

Add new test ensuring that a block that shouldn't have overflow doesn't
have scrollbars.

  • fast/sub-pixel/block-with-margin-overflow-expected.html: Added.
  • fast/sub-pixel/block-with-margin-overflow.html: Added.
  • platform/chromium-win/fast/block/float/026-expected.txt:
  • platform/chromium-win/fast/block/float/028-expected.txt:
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:

Update test expectations that incorrectly had overflow.

TBR=​eae@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10790105

10:56 AM Changeset in webkit [123233] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

CodeGeneratorInspector.py is unnecessarily chatty
​https://bugs.webkit.org/show_bug.cgi?id=91758

Reviewed by Vsevolod Vlasov.

The code aded in r123091 included a "print" statement for each written
file. This makes for noisy build output, especially noticeable in the
Chromium ninja build (where build output takes up a single line of the
console).

If this print statement is generally useful, it should be
hidden behind a --verbose commandline option, as we do for the binding
generators.

  • inspector/CodeGeneratorInspector.py:

(SmartOutput.close): Remove print statement.

10:53 AM Changeset in webkit [123232] by tony@chromium.org
  • 2 edits in trunk/Tools

Baseline align text in the flakiness dashboard toolbar
​https://bugs.webkit.org/show_bug.cgi?id=91784

Reviewed by Ojan Vafai.

Baseline align the flex items.

  • TestResultServer/static-dashboards/flakiness_dashboard.css:

(.forms): Add box-align: baseline
(.forms > *): Use block display to force flex items rather than box.
(#tests-form): Add box-align: baseline
(#tests-form > *): Use block display to force flex items rather than box.

10:50 AM Changeset in webkit [123231] by eae@chromium.org
  • 21 edits
    2 copies in branches/chromium/1180

Merge 122769 - Inconsistent rounding in table layout causes background color to bleed through
​https://bugs.webkit.org/show_bug.cgi?id=91410

Reviewed by Eric Seidel.

Source/WebCore:

At certain zoom levels a rounding error in the table layout code cases
the table background color to bleed through between cells. Tables layout
happens on pixel bounds however the paint offset wasn't correctly rounded.

Test: fast/sub-pixel/table-rows-no-gaps.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
Round paintOffset before passing it to the paint method of the children.

LayoutTests:

Add test to ensure that the table background color doesn't bleed through
when the table and a cell are positioned on a subpixel bound.

  • fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
  • fast/sub-pixel/table-rows-no-gaps.html: Added.
  • platform/chromium-linux/css1/basic/inheritance-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

Updated expectations to match new rounding logic. The new results better
match the rendering prior to turning on subpixel layout.

  • platform/efl/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Mark new test as skipped on platforms that have not enabled subpixel
layout.

TBR=​eae@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10815035

10:49 AM Changeset in webkit [123230] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Fix missing css1/text_properties/text_transform.html results (txt)
​https://bugs.webkit.org/show_bug.cgi?id=91875

Expected txt result was added.

Patch by Luciano Wolf <Luciano Miguel Wolf> on 2012-07-20
Reviewed by Noam Rosenthal.

  • platform/qt/css1/text_properties/text_transform-expected.txt: Added.
10:47 AM Changeset in webkit [123229] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk/LayoutTests

[Qt] Added/updated missing fast/table results after rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-07-20
Reviewed by Noam Rosenthal.

The following tests were failing after r122985:

fast/table/003.html = TEXT
fast/table/colspanMinWidth.html = TEXT
fast/table/spanOverlapRepaint.html = TEXT
fast/table/text-field-baseline.html = TEXT

This patch includes/updates the missing expectations.

  • platform/qt-5.0-wk2/fast/table/003-expected.png:
  • platform/qt-5.0-wk2/fast/table/003-expected.txt:
  • platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt: Added.
10:35 AM Changeset in webkit [123228] by wsiegrist@apple.com
  • 5 edits in trunk/Websites/bugs.webkit.org

Port bugs.webkit.org to mod_perl for new hardware.

Reviewed by David Kilzer.

10:29 AM Changeset in webkit [123227] by Philippe Normand
  • 3 edits in trunk/Tools

Unreviewed, rolling out r123220.
​http://trac.webkit.org/changeset/123220
​https://bugs.webkit.org/show_bug.cgi?id=91880

broke Debug build (Requested by philn on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-07-20

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/jhbuild.modules:
10:25 AM Changeset in webkit [123226] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening, rebaselining a test after r117477.

  • platform/gtk/TestExpectations:
  • platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
10:13 AM Changeset in webkit [123225] by senorblanco@chromium.org
  • 3 edits
    1 add in trunk/Source/WebCore

[chromium] Enable GPU-accelerated skia implementation of
feDiffuseLighting, feSpecularLighting.
​https://bugs.webkit.org/show_bug.cgi?id=91865

Reviewed by Dirk Schulze.

Translate the light parameters into the appropriate
SkLightingImageFilter calls. This path is only enabled when
the filters are created with the Accelerated flag set.

This will be covered by tests in svg/filters/* when they are
added to the virtual GPU tests.

  • WebCore.gypi:
  • platform/graphics/filters/FELighting.h:

(FELighting):

  • platform/graphics/filters/skia/FELightingSkia.cpp: Added.

(WebCore):
(WebCore::FELighting::platformApplySkia):

10:09 AM Changeset in webkit [123224] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, managing a few more unexpected passes for the GTK port.

Remove a few expectations for tests that were passing, reclassify some failures as
architecture-specific and add PASS expectations for a few tests that pass even though
they test features that are currently not supported on the GTK port.

  • platform/gtk/TestExpectations:
9:50 AM Changeset in webkit [123223] by pfeldman@chromium.org
  • 23 edits
    1 delete in trunk/Source/WebCore

Web Inspector: disable fake workers inspection.
​https://bugs.webkit.org/show_bug.cgi?id=91867

Reviewed by Vsevolod Vlasov.

'Fake workers' is unreliable error-prone way to debug workers. There are a
lot of frameworks supporting it. Inspector should not do that since it has a more
powerful native worker inspection capabilities. Port owners should enable it
in case they want to provide workers debugging.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):

  • inspector/InjectedScriptHost.h:

(InjectedScriptHost):

  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::enable):

  • inspector/InspectorAgent.h:

(WebCore):
(InspectorAgent):

  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/InjectedFakeWorker.js: Removed.
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane):

  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::contextDestroyed):

  • workers/AbstractWorker.h:

(AbstractWorker):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

8:41 AM Changeset in webkit [123222] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening, adding platform-specific baseline that's required
after changes in r123145.

  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.
8:33 AM Changeset in webkit [123221] by schenney@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline failing test svg/as-image/svg-non-integer-scaled-image.html

Unreviewed test expectations update.

  • platform/chromium/svg/as-image: Added.
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
8:12 AM Changeset in webkit [123220] by Philippe Normand
  • 3 edits in trunk/Tools

[GTK][jhbuild] Switch to GStreamer 0.11 build
​https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.

  • gtk/jhbuild.modules: GStreamer build support.
7:57 AM Changeset in webkit [123219] by commit-queue@webkit.org
  • 27 edits
    4 deletes in trunk

Unreviewed, rolling out r123182.
​http://trac.webkit.org/changeset/123182
​https://bugs.webkit.org/show_bug.cgi?id=91863

Causing ASSERT crashes in tests accessibility/canvas.html and
accessibility/canvas-accessibilitynodeobject.html (Requested
by jernoble on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-07-20

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • accessibility/AXObjectCache.cpp:

(WebCore):

  • accessibility/AXObjectCache.h:

(AXObjectCache):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::create):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::create):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::create):

  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::create):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::create):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):

  • accessibility/AccessibilityMenuList.cpp:
  • accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::create):

  • accessibility/AccessibilityNodeObject.cpp: Removed.
  • accessibility/AccessibilityNodeObject.h: Removed.
  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::create):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::ariaRoleAttribute):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::setRenderer):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::create):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::create):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::create):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::create):

LayoutTests:

  • accessibility/canvas-accessibilitynodeobject-expected.txt: Removed.
  • accessibility/canvas-accessibilitynodeobject.html: Removed.
7:39 AM Changeset in webkit [123218] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[EFL] Proxy configuration should honor the no_proxy environment variable
​https://bugs.webkit.org/show_bug.cgi?id=91747

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement a custom Proxy URI Resolver for libsoup
so that we can use it in EFL port. This custom
proxy resolver brings support for setting
exceptions so that the proxy is not used for the
specified hosts.

By default, the proxy is not used for localhost and
127.0.0.1.

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake:
  • platform/network/soup/ProxyResolverSoup.cpp: Added.

(soup_proxy_resolver_wk_init):
(soupProxyResolverWkFinalize):
(soupProxyResolverWkSetProperty):
(soupProxyResolverWkGetProperty):
(shouldBypassProxy):
(idle_return_proxy_uri):
(soupProxyResolverWkGetProxyURIAsync):
(soupProxyResolverWkGetProxyURISync):
(soup_proxy_resolver_wk_class_init):
(soup_proxy_resolver_wk_interface_init):
(soupProxyResolverWkNew):

  • platform/network/soup/ProxyResolverSoup.h: Added.

Source/WebKit:

Add WebCore/platform/network/soup to INCLUDE paths.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Use the new custom proxy resolver from WebCore in
WebKit1-EFL's ewk_network_proxy_uri_set() / get(),
instead of the less flexible SOUP_SESSION_PROXY_URI
SoupSession property.

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):

Source/WebKit2:

Use the new custom proxy resolver from WebCore in
WebKit2-EFL so that it is possible for the client
to set proxy exceptions via the "no_proxy"
environment variable.

By default, the proxy set in the "http_proxy"
environment variable will not be used for requests
to localhost or 127.0.0.1.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

Tools:

Add ProxyResolverSoup to the list of classes that contain GObjects
in style checker script so that it does not complain about naming
convention issues that are mandated by GObject.

  • Scripts/webkitpy/style/checker.py:
7:38 AM Changeset in webkit [123217] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Fix chromium TestExpectations file.

Unreviewed build fix.

  • platform/chromium/TestExpectations:
7:38 AM Changeset in webkit [123216] by pierre.rossi@gmail.com
  • 17 edits in trunk/Source/WebKit2

[Qt][WK2] Add support for multi-select list
​https://bugs.webkit.org/show_bug.cgi?id=85527

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Added support for multi-select list:

  • Added multi-selection flag to PlatformPopupMenuData to indicate whether to accept multiple selections or not.
  • Added selected state to WebPopupItem.
  • Modified WebPopupMenuQt to support multiple selections.
  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiSelect.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/multiselect.html: Added.
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPopupMenuProxy.h:

(Client):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::changeSelectedIndex):
(WebKit):
(WebKit::WebPageProxy::closePopupMenu):

  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::PopupMenuItemModel::multiple):
(PopupMenuItemModel):
(WebKit::PopupMenuItemModel::Item::Item):
(ItemSelectorContextObject):
(WebKit::ItemSelectorContextObject::allowMultiSelect):
(WebKit::ItemSelectorContextObject::reject):
(WebKit::ItemSelectorContextObject::dismiss):
(WebKit::ItemSelectorContextObject::ItemSelectorContextObject):
(WebKit):
(WebKit::ItemSelectorContextObject::onIndexUpdate):
(WebKit::ItemSelectorContextObject::accept):
(WebKit::PopupMenuItemModel::PopupMenuItemModel):
(WebKit::PopupMenuItemModel::select):
(WebKit::PopupMenuItemModel::toggleItem):
(WebKit::PopupMenuItemModel::buildItems):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):
(WebKit::WebPopupMenuProxyQt::selectIndex):
(WebKit::WebPopupMenuProxyQt::createItem):

  • UIProcess/qt/WebPopupMenuProxyQt.h:

(WebPopupMenuProxyQt):

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebPopupMenu):

  • WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):
(WebKit):
(WebKit::WebPage::changeSelectedIndex):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::selectedIndex):
(WebKit):
(WebKit::WebPage::hidePopupMenu):

7:30 AM Changeset in webkit [123215] by schenney@chromium.org
  • 15 edits
    2 adds
    4 deletes in trunk/LayoutTests

Rebaseline Chromium results after r121171
​https://bugs.webkit.org/show_bug.cgi?id=91474

Reviewed by Dan Bernstein.

Unreviewed test expectations update.

Values have changed by one pixel, which is expected given the description in the bug report.

  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium/svg/as-image: Removed.
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
7:23 AM Changeset in webkit [123214] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source/WebCore

ColorChooserClient should expose the element's location
​https://bugs.webkit.org/show_bug.cgi?id=91767

Reviewed by Kent Tamura.

The rationale is that the chrome client could have an interest in placing the picker next to
the element for usability reasons.

No new tests as there is not much logic here: Just exposing a geometry information to WebKit.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::elementRectRelativeToWindow):
(WebCore):

  • html/ColorInputType.h:

(ColorInputType):

  • platform/ColorChooserClient.h:

(ColorChooserClient):

7:11 AM Changeset in webkit [123213] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Fix build when protocol handler and custom scheme is disabled
​https://bugs.webkit.org/show_bug.cgi?id=91840

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

Fixed namespace closing bracket positioning.

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:

(WebCore):

7:05 AM Changeset in webkit [123212] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WK2] WebIntents doesn't build if mutation observers is disabled
​https://bugs.webkit.org/show_bug.cgi?id=91839

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

WebIntents was depending on a code protected by ENABLE(MUTATION_OBSERVERS).
Now the code is also enabled by ENABLE(WEB_INTENTS).

  • bindings/js/JSDictionary.cpp:

(WebCore):

  • bindings/js/JSDictionary.h:
6:59 AM Changeset in webkit [123211] by mihnea@adobe.com
  • 3 edits
    6 adds in trunk

[CSSRegions]Assert failure when layout positioned objects in regions
​https://bugs.webkit.org/show_bug.cgi?id=90792

Reviewed by Andreas Kling.

Before clamping the containing block (for an out-of-flow positioned element
inside a named flow) to the region, we have to test whether the region is not
null, which can happen when the named flow does not have attached regions.

Source/WebCore:

Tests: fast/regions/positioned-vrl-in-named-flow.html

fast/regions/positioned-vrl-in-parent-named-flow.html
fast/regions/positioned-with-vrl-parent-in-named-flow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

LayoutTests:

  • fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
  • fast/regions/positioned-vrl-in-named-flow.html: Added.
  • fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
  • fast/regions/positioned-vrl-in-parent-named-flow.html: Added.
  • fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
  • fast/regions/positioned-with-vrl-parent-in-named-flow.html: Added.
6:55 AM Changeset in webkit [123210] by schenney@chromium.org
  • 6 edits
    6 adds in trunk

SVG Filter Effect sub-region not applied for some filters
​https://bugs.webkit.org/show_bug.cgi?id=89767

Reviewed by Dirk Schulze.

Source/WebCore:

The filter effect region for SVG feGaussian and feDropShadow filters
was incorrectly set, failing to account for the radius of the blur.
This patch fixes the problem and removes an unneccessary clip
operation when the filter result is blitted into the target. That clip
was clipping the shadow from webkit-shadow.

Tests: svg/filters/feDropShadow-subregion.svg

svg/filters/feGaussianBlur-subregion.svg

  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::determineAbsolutePaintRect): Moved the code
that clips the paint rect by the filter effect subregion to come after
the paint is modified by the filter radius.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
Moved the code that clips the paint rect by the filter effect subregion to
come after the paint is modified by the filter radius.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):
Removed a clip that is unnecessary and that was incorrectly clipping drop shadows.

LayoutTests:

The filter effect region for SVG feGaussian and feDropShadow filters was incorrectly set,
failing to account for the radius of the blur. This patch fixes the problem and removes an
unneccessary clip operation when the filter result is blitted into the target. That clip
was clipping the shadow from webkit-shadow.

  • platform/chromium/TestExpectations: Added temp entries for affected

tests. Will rebaseline later (not closing the bug in the meantime).

  • svg/filters/feDropShadow-subregion-expected.png: Added.
  • svg/filters/feDropShadow-subregion-expected.txt: Added.
  • svg/filters/feDropShadow-subregion.svg: This verifies the subregion for feDropShadow.
  • svg/filters/feGaussianBlur-subregion-expected.png: Added.
  • svg/filters/feGaussianBlur-subregion-expected.txt: Added.
  • svg/filters/feGaussianBlur-subregion.svg: This verifies the subregion for feGaussianBlur.
6:41 AM Changeset in webkit [123209] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip regions inspector test on EFL.

6:26 AM Changeset in webkit [123208] by zeno.albisser@nokia.com
  • 3 edits
    6 adds in trunk/Tools

[Qt][WK2] Add configure tests for Xrender and GLX.
​https://bugs.webkit.org/show_bug.cgi?id=91845

GraphicsSurface on linux requires Xcomposite, Xrender
and GLX. If any of these requirements is not met,
we should disable GraphicsSurface.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/config.tests/glx/glx.cpp: Added.

(main):

  • qmake/config.tests/glx/glx.pro: Added.
  • qmake/config.tests/libXrender/libXrender.cpp: Added.

(main):

  • qmake/config.tests/libXrender/libXrender.pro: Added.
  • qmake/configure.pri:
  • qmake/mkspecs/features/features.prf:
6:07 AM Changeset in webkit [123207] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Status bar icons are misaligned by 1px to the right
​https://bugs.webkit.org/show_bug.cgi?id=91757

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.css:

(.glyph):
(.glyph.shadow):

5:50 AM Changeset in webkit [123206] by kkristof@inf.u-szeged.hu
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] http/tests/security/cross-frame-access-put.html test fail after r123145
​https://bugs.webkit.org/show_bug.cgi?id=91830

Unreviewed gardening.

Patch by Balazs Ankes <​bank@inf.u-szeged.hu> on 2012-07-20

  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
5:34 AM Changeset in webkit [123205] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Web Inspector: Protocol Extension: add getNamedFlowCollection command
​https://bugs.webkit.org/show_bug.cgi?id=91607

Patch by Andrei Poenaru <​poenaru@adobe.com> on 2012-07-20
Reviewed by Pavel Feldman.

Source/WebCore:

Extended the protocol with "getNamedFlowCollection" command.
This command returns the CSS Named Flows from the document.

Test: inspector/styles/protocol-getNamedFlowCollection-command.html

  • dom/WebKitNamedFlowCollection.cpp:

(WebCore::WebKitNamedFlowCollection::namedFlowsNames):
(WebCore):

  • dom/WebKitNamedFlowCollection.h:

(WebKitNamedFlowCollection):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::assertDocument):
(WebCore):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):

LayoutTests:

The test builds a webpage with 3 Named Flows in the main frame and 1 Named Flow in an iframe.
Because the getNamedFlowCollection command is executed with the main document node id as an argument,
it should return only the first 3 Named Flows.

  • inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Added.
  • inspector/styles/protocol-getNamedFlowCollection-command.html: Added.
5:29 AM Changeset in webkit [123204] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[EFL] Gardening of failing tests
​https://bugs.webkit.org/show_bug.cgi?id=91838

Unreviewed EFL gardening. Add failing tests to the Test Expectations.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-07-20

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/state-restore-skip-stateless-expected.txt: Removed

the platform specific expected after r123066.

4:31 AM Changeset in webkit [123203] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Tools

[EFL][WK2][WTR] Implement EventSenderProxy
​https://bugs.webkit.org/show_bug.cgi?id=91731

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-07-20
Reviewed by Kentaro Hara.

This is an initial EFL port implementation of EventSenderProxy.

  • WebKitTestRunner/EventSenderProxy.h:

(WTR):
(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.

(WTR):
(WTREvent):
(WTR::WTREvent::WTREvent):
(WTR::KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(WTR::evasMouseButton):
(WTR::setEvasModifiers):
(WTR::dispatchMouseDownEvent):
(WTR::dispatchMouseUpEvent):
(WTR::dispatchMouseMoveEvent):
(WTR::dispatchMouseScrollByEvent):
(WTR::keyPadName):
(WTR::keyName):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::dispatchEvent):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):
(WTR::EventSenderProxy::setTouchPointRadius):

4:26 AM Changeset in webkit [123202] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Check parameters of ewk APIs in ewk_security_origin
​https://bugs.webkit.org/show_bug.cgi?id=91833

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-07-20
Reviewed by Kentaro Hara.

For preventing crash, check parameters of ewk APIs in the ewk_security_origin.cpp.

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_application_cache_quota_set):
(ewk_security_origin_application_cache_clear):
(ewk_security_origin_web_database_get_all):
(ewk_security_origin_free):

  • ewk/ewk_security_origin.h:
4:25 AM Changeset in webkit [123201] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r123192. Skipped a new test.

Patch by János Badics <János Badics> on 2012-07-20

  • platform/qt/Skipped:
3:28 AM Changeset in webkit [123200] by gyuyoung.kim@samsung.com
  • 5 edits in trunk

Unreviewed, rolling out r123085.
​http://trac.webkit.org/changeset/123085
​https://bugs.webkit.org/show_bug.cgi?id=91719

r123085 causes crashes on EFL layout test bot.

Source/WebKit2:

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::applicationCacheDirectory):

Tools:

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:

(WTR::LayoutTestController::platformInitialize):

3:17 AM Changeset in webkit [123199] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use "load,finished" signal in EWK2UnitTestBase::loadUrlSync() instead of "load,progress"
​https://bugs.webkit.org/show_bug.cgi?id=91721

Patch by Christophe Dumez <Christophe Dumez> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

The purpose of EWK2UnitTestBase::loadUrlSync() is to load
a URL in the view and wait synchronously for the load to finish.
The current implementation uses the "load,progress" signal to
detect when the load is finished, which is inefficient because
it gets emitted several times.

It is better to wait for the "load,finished" signal which gets
emitted only once when the load is complete.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

2:41 AM Changeset in webkit [123198] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: Timeline: forward compatibility for load.
​https://bugs.webkit.org/show_bug.cgi?id=91714

Patch by Eugene Klyuchnikov <​eustas.big@gmail.com> on 2012-07-20
Reviewed by Pavel Feldman.

Accept records of unrecognized types and render them as "unknown".

Source/WebCore:

Test: inspector/timeline/timeline-load-incompatible.html

  • English.lproj/localizedStrings.js: Added UI string.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.recordStyle): Add missing record
styles at runtime.
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
Add some common information for default case.

LayoutTests:

  • inspector/timeline/timeline-load-incompatible-expected.txt: Added.
  • inspector/timeline/timeline-load-incompatible.html: Added.
2:30 AM Changeset in webkit [123197] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Another unreviewed Mac build fix against r123184.

  • WebCore.exp.in:
2:23 AM Changeset in webkit [123196] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions]Crash when flowing a region into itself
​https://bugs.webkit.org/show_bug.cgi?id=90289

Reviewed by Andreas Kling.

If a region is designed to receive itself as content through a named flow, we avoid
a circular dependency by not attaching the region to the desired named flow.
In such occasions, the region's attached flow thread object is null and
we have to check this pointer before using it in RenderRegion::styleDidChange.

Source/WebCore:

Test: fast/regions/flow-region-into-itself-crash.html

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::styleDidChange):

LayoutTests:

  • fast/regions/flow-region-into-itself-crash-expected.txt: Added.
  • fast/regions/flow-region-into-itself-crash.html: Added.
2:13 AM Changeset in webkit [123195] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Mac build fix against r123184.

  • WebCore.exp.in:
1:41 AM Changeset in webkit [123194] by kinuko@chromium.org
  • 5 edits
    2 adds in trunk

If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
​https://bugs.webkit.org/show_bug.cgi?id=90976

Reviewed by Alexey Proskuryakov.

Source/WebCore:

​http://www.w3.org/TR/XMLHttpRequest2/#the-responsetype-attribute
The spec does not say it should throw an exception when a non-supported
type is set, and other browsers do not throw it either.

Test: fast/xmlhttprequest/xmlhttprequest-responsetype-set-type.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setResponseType): Stop throwing an exception when non-supported type is given.

LayoutTests:

Adding tests to see if setting invalid responseType does not throw an exception and does not change the value.

  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Removed a line which tries to set invalid type (since we now have a separate test)
1:28 AM Changeset in webkit [123193] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Show or hide <dialog> depending on the open attribute
​https://bugs.webkit.org/show_bug.cgi?id=90931

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-07-20
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/dom/HTMLDialogElement/dialog-open.html

(dialog:not([open])):
(dialog):

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::close): Set open to false, to hide the dialog.
(WebCore::HTMLDialogElement::show): Set open to true, to show the dialog.
(WebCore):
(WebCore::HTMLDialogElement::isPresentationAttribute): Make openAttr a presentation attribute, to work around bug 91058

  • html/HTMLDialogElement.h:

(HTMLDialogElement):

  • html/HTMLDialogElement.idl:

LayoutTests:

  • fast/dom/HTMLDialogElement/dialog-open-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-open.html: Added.
1:06 AM Changeset in webkit [123192] by shinyak@chromium.org
  • 4 edits
    2 adds in trunk

Needs pseudo id to point the inner element of an img elemnet for styling
​https://bugs.webkit.org/show_bug.cgi?id=91590

Reviewed by Hajime Morita.

Source/WebCore:

We introduce pseudo id to point the element in UserAgentShadowDOM.
This enables us to style the inner element of an img element shadow.
Please see also ​http://trac.webkit.org/wiki/ShadowDOMForReplacedElements

Test: fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html

  • html/shadow/ImageInnerElement.cpp:

(WebCore::ImageInnerElement::shadowPseudoId):
(WebCore):

  • html/shadow/ImageInnerElement.h:

(ImageInnerElement):

LayoutTests:

Uses pseudo id to confirm the style is applied to the inner element of an img element shadow.

  • fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html: Added.
1:03 AM Changeset in webkit [123191] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
​https://bugs.webkit.org/show_bug.cgi?id=91804

Reviewed by Hajime Morita.

The complexity of FormKeyGenerator::formKey() was O(N) where N is the
number of form elements with an identical action URL, and formKey() is
called for every form. So, it's O(N2). A page in www.reddit.com
contains hundreds of form elements with action="#". So FormController::
formElementsState() took a few seconds on a slow machine.

In order to avoid O(N2) operation, storing a map from form signatures
to next index numbers, instead of storing existing formKey strings.

No new tests. Just a performance improvement.

  • html/FormController.cpp:

(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
signature string to the next index number.
(WebCore::formSignature): Returns a signature string for a form, without
an index number. This is like "actionURL [name1 name2 ]"
(WebCore::FormKeyGenerator::formKey):
Creates a formKey string by concatenating a formSignature and #n. N is
obtained from m_formSignatureToNextIndexMap in O(1).
(WebCore::FormKeyGenerator::willDeleteForm):
Remove the code for m_existingKeys.

12:56 AM Changeset in webkit [123190] by yosin@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.

  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
12:48 AM Changeset in webkit [123189] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Tools

[WTR] Add *explicit* keyword to constructor which has a parameter
​https://bugs.webkit.org/show_bug.cgi?id=91745

Reviewed by Adam Barth.

Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

12:46 AM Changeset in webkit [123188] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

Fix crash in WebCore::HTMLInputElement::dataList
​https://bugs.webkit.org/show_bug.cgi?id=91818

Reviewed by Kent Tamura.

Source/WebCore:

Fix crash that occurs when setting slider appearance on a regular node.

Test: fast/forms/range/slider-appearance-crash.html

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks): Check if node is an input element.

LayoutTests:

  • fast/forms/range/slider-appearance-crash-expected.txt: Added.
  • fast/forms/range/slider-appearance-crash.html: Added.
12:42 AM Changeset in webkit [123187] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
​https://bugs.webkit.org/show_bug.cgi?id=91824

Reviewed by Hajime Morita.

No new tests. This code is used only in Chromium browser.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::hostInput):
Use shadowHost(), and allow to return 0.
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Check 0.

12:36 AM Changeset in webkit [123186] by yosin@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.

  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
12:02 AM WikiStart edited by shinyak@chromium.org
(diff)
12:01 AM ShadowDOMForReplacedElements created by shinyak@chromium.org
Note: See TracTimeline for information about the timeline view.